{"action":"created","comment":{"url":"https://api.github.com/repos/videolan/vlc-ios/pulls/comments/213663614","pull_request_review_id":150544853,"id":213663614,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzY2MzYxNA==","diff_hunk":"@@ -200,6 +200,12 @@ class VLCActionSheet: UIViewController {\n         // This is to avoid a horrible visual glitch!\n         mainStackView.isHidden = false\n \n+        let roundedCornerPath = UIBezierPath(roundedRect: headerView.bounds, byRoundingCorners: [.topLeft, .topRight],\n+                                             cornerRadii: CGSize(width: 10, height: 10))\n+        let maskLayer = CAShapeLayer()\n+        maskLayer.path = roundedCornerPath.cgPath\n+        headerView.layer.mask = maskLayer","path":"Sources/VLCActionSheet/VLCActionSheet.swift","position":8,"original_position":8,"commit_id":"11e39657960376b818c70969163ad0abc97e5511","original_commit_id":"11e39657960376b818c70969163ad0abc97e5511","user":{"login":"mkchoi212","id":5487597,"node_id":"MDQ6VXNlcjU0ODc1OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/5487597?v=4","gravatar_id":"","url":"https://api.github.com/users/mkchoi212","html_url":"https://github.com/mkchoi212","followers_url":"https://api.github.com/users/mkchoi212/followers","following_url":"https://api.github.com/users/mkchoi212/following{/other_user}","gists_url":"https://api.github.com/users/mkchoi212/gists{/gist_id}","starred_url":"https://api.github.com/users/mkchoi212/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkchoi212/subscriptions","organizations_url":"https://api.github.com/users/mkchoi212/orgs","repos_url":"https://api.github.com/users/mkchoi212/repos","events_url":"https://api.github.com/users/mkchoi212/events{/privacy}","received_events_url":"https://api.github.com/users/mkchoi212/received_events","type":"User","site_admin":false},"body":"Just tried it but didn't work :(\r\n\r\nThe actionSheet is `headerView` + `stackView` and so I think the corner radius of the headerView must be set.","created_at":"2018-08-29T12:54:06Z","updated_at":"2018-08-29T12:54:06Z","html_url":"https://github.com/videolan/vlc-ios/pull/129#discussion_r213663614","pull_request_url":"https://api.github.com/repos/videolan/vlc-ios/pulls/129","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/videolan/vlc-ios/pulls/comments/213663614"},"html":{"href":"https://github.com/videolan/vlc-ios/pull/129#discussion_r213663614"},"pull_request":{"href":"https://api.github.com/repos/videolan/vlc-ios/pulls/129"}},"in_reply_to_id":213583682},"pull_request":{"url":"https://api.github.com/repos/videolan/vlc-ios/pulls/129","id":210992695,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTkyNjk1","html_url":"https://github.com/videolan/vlc-ios/pull/129","diff_url":"https://github.com/videolan/vlc-ios/pull/129.diff","patch_url":"https://github.com/videolan/vlc-ios/pull/129.patch","issue_url":"https://api.github.com/repos/videolan/vlc-ios/issues/129","number":129,"state":"open","locked":false,"title":"Actionsheet: Set rounded corners","user":{"login":"mkchoi212","id":5487597,"node_id":"MDQ6VXNlcjU0ODc1OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/5487597?v=4","gravatar_id":"","url":"https://api.github.com/users/mkchoi212","html_url":"https://github.com/mkchoi212","followers_url":"https://api.github.com/users/mkchoi212/followers","following_url":"https://api.github.com/users/mkchoi212/following{/other_user}","gists_url":"https://api.github.com/users/mkchoi212/gists{/gist_id}","starred_url":"https://api.github.com/users/mkchoi212/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkchoi212/subscriptions","organizations_url":"https://api.github.com/users/mkchoi212/orgs","repos_url":"https://api.github.com/users/mkchoi212/repos","events_url":"https://api.github.com/users/mkchoi212/events{/privacy}","received_events_url":"https://api.github.com/users/mkchoi212/received_events","type":"User","site_admin":false},"body":"<!-- Thanks for contributing to _vlc-ios_! Before you submit your pull request, please make sure to check the following boxes by putting an x in the [ ] (don't: [x ], [ x], do: [x]) -->\r\n\r\n### Checklist\r\n- [ ] I've run `bundle exec fastlane test` from the root directory to see all new and existing tests pass\r\n- [ ] I've followed the [vlc-ios code style](Docs/CodingStyle.md) and run `bundle exec fastlane lint` to ensure the code style is valid\r\n- [ ] I've read the [Contribution Guidelines](https://github.com/videolan/vlc-ios#contribute)\r\n- [ ] I've updated the documentation if necessary.\r\n\r\n### Description\r\n<!-- Describe your changes in detail -->\r\n\r\nCorner radius on top of the header has been applied, based on Figma mockups.\r\n\r\n![simulator screen shot - iphone x - 2018-08-26 at 21 45 46](https://user-images.githubusercontent.com/5487597/44637886-80b0af80-a979-11e8-828e-e509a2052915.png)\r\n","created_at":"2018-08-27T02:47:48Z","updated_at":"2018-08-29T12:54:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80d8ba12a8e1b786681ea8a97caeca9172d317ab","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/videolan/vlc-ios/pulls/129/commits","review_comments_url":"https://api.github.com/repos/videolan/vlc-ios/pulls/129/comments","review_comment_url":"https://api.github.com/repos/videolan/vlc-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videolan/vlc-ios/issues/129/comments","statuses_url":"https://api.github.com/repos/videolan/vlc-ios/statuses/11e39657960376b818c70969163ad0abc97e5511","head":{"label":"mkchoi212:actionsheet-corner","ref":"actionsheet-corner","sha":"11e39657960376b818c70969163ad0abc97e5511","user":{"login":"mkchoi212","id":5487597,"node_id":"MDQ6VXNlcjU0ODc1OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/5487597?v=4","gravatar_id":"","url":"https://api.github.com/users/mkchoi212","html_url":"https://github.com/mkchoi212","followers_url":"https://api.github.com/users/mkchoi212/followers","following_url":"https://api.github.com/users/mkchoi212/following{/other_user}","gists_url":"https://api.github.com/users/mkchoi212/gists{/gist_id}","starred_url":"https://api.github.com/users/mkchoi212/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkchoi212/subscriptions","organizations_url":"https://api.github.com/users/mkchoi212/orgs","repos_url":"https://api.github.com/users/mkchoi212/repos","events_url":"https://api.github.com/users/mkchoi212/events{/privacy}","received_events_url":"https://api.github.com/users/mkchoi212/received_events","type":"User","site_admin":false},"repo":{"id":126275221,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYyNzUyMjE=","name":"vlc-ios","full_name":"mkchoi212/vlc-ios","owner":{"login":"mkchoi212","id":5487597,"node_id":"MDQ6VXNlcjU0ODc1OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/5487597?v=4","gravatar_id":"","url":"https://api.github.com/users/mkchoi212","html_url":"https://github.com/mkchoi212","followers_url":"https://api.github.com/users/mkchoi212/followers","following_url":"https://api.github.com/users/mkchoi212/following{/other_user}","gists_url":"https://api.github.com/users/mkchoi212/gists{/gist_id}","starred_url":"https://api.github.com/users/mkchoi212/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkchoi212/subscriptions","organizations_url":"https://api.github.com/users/mkchoi212/orgs","repos_url":"https://api.github.com/users/mkchoi212/repos","events_url":"https://api.github.com/users/mkchoi212/events{/privacy}","received_events_url":"https://api.github.com/users/mkchoi212/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkchoi212/vlc-ios","description":"VLC for iOS official mirror","fork":true,"url":"https://api.github.com/repos/mkchoi212/vlc-ios","forks_url":"https://api.github.com/repos/mkchoi212/vlc-ios/forks","keys_url":"https://api.github.com/repos/mkchoi212/vlc-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkchoi212/vlc-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkchoi212/vlc-ios/teams","hooks_url":"https://api.github.com/repos/mkchoi212/vlc-ios/hooks","issue_events_url":"https://api.github.com/repos/mkchoi212/vlc-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mkchoi212/vlc-ios/events","assignees_url":"https://api.github.com/repos/mkchoi212/vlc-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mkchoi212/vlc-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mkchoi212/vlc-ios/tags","blobs_url":"https://api.github.com/repos/mkchoi212/vlc-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkchoi212/vlc-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkchoi212/vlc-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkchoi212/vlc-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkchoi212/vlc-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mkchoi212/vlc-ios/languages","stargazers_url":"https://api.github.com/repos/mkchoi212/vlc-ios/stargazers","contributors_url":"https://api.github.com/repos/mkchoi212/vlc-ios/contributors","subscribers_url":"https://api.github.com/repos/mkchoi212/vlc-ios/subscribers","subscription_url":"https://api.github.com/repos/mkchoi212/vlc-ios/subscription","commits_url":"https://api.github.com/repos/mkchoi212/vlc-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkchoi212/vlc-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkchoi212/vlc-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkchoi212/vlc-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkchoi212/vlc-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mkchoi212/vlc-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkchoi212/vlc-ios/merges","archive_url":"https://api.github.com/repos/mkchoi212/vlc-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkchoi212/vlc-ios/downloads","issues_url":"https://api.github.com/repos/mkchoi212/vlc-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mkchoi212/vlc-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mkchoi212/vlc-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mkchoi212/vlc-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkchoi212/vlc-ios/labels{/name}","releases_url":"https://api.github.com/repos/mkchoi212/vlc-ios/releases{/id}","deployments_url":"https://api.github.com/repos/mkchoi212/vlc-ios/deployments","created_at":"2018-03-22T03:36:54Z","updated_at":"2018-06-11T01:34:06Z","pushed_at":"2018-08-27T02:47:37Z","git_url":"git://github.com/mkchoi212/vlc-ios.git","ssh_url":"git@github.com:mkchoi212/vlc-ios.git","clone_url":"https://github.com/mkchoi212/vlc-ios.git","svn_url":"https://github.com/mkchoi212/vlc-ios","homepage":null,"size":48808,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"videolan:master","ref":"master","sha":"eccf4eaa0eacc88516ccae460bca111e6e229216","user":{"login":"videolan","id":1389585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODk1ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/1389585?v=4","gravatar_id":"","url":"https://api.github.com/users/videolan","html_url":"https://github.com/videolan","followers_url":"https://api.github.com/users/videolan/followers","following_url":"https://api.github.com/users/videolan/following{/other_user}","gists_url":"https://api.github.com/users/videolan/gists{/gist_id}","starred_url":"https://api.github.com/users/videolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videolan/subscriptions","organizations_url":"https://api.github.com/users/videolan/orgs","repos_url":"https://api.github.com/users/videolan/repos","events_url":"https://api.github.com/users/videolan/events{/privacy}","received_events_url":"https://api.github.com/users/videolan/received_events","type":"Organization","site_admin":false},"repo":{"id":120193302,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAxOTMzMDI=","name":"vlc-ios","full_name":"videolan/vlc-ios","owner":{"login":"videolan","id":1389585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODk1ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/1389585?v=4","gravatar_id":"","url":"https://api.github.com/users/videolan","html_url":"https://github.com/videolan","followers_url":"https://api.github.com/users/videolan/followers","following_url":"https://api.github.com/users/videolan/following{/other_user}","gists_url":"https://api.github.com/users/videolan/gists{/gist_id}","starred_url":"https://api.github.com/users/videolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videolan/subscriptions","organizations_url":"https://api.github.com/users/videolan/orgs","repos_url":"https://api.github.com/users/videolan/repos","events_url":"https://api.github.com/users/videolan/events{/privacy}","received_events_url":"https://api.github.com/users/videolan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videolan/vlc-ios","description":"VLC for iOS and tvOS official mirror","fork":false,"url":"https://api.github.com/repos/videolan/vlc-ios","forks_url":"https://api.github.com/repos/videolan/vlc-ios/forks","keys_url":"https://api.github.com/repos/videolan/vlc-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videolan/vlc-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videolan/vlc-ios/teams","hooks_url":"https://api.github.com/repos/videolan/vlc-ios/hooks","issue_events_url":"https://api.github.com/repos/videolan/vlc-ios/issues/events{/number}","events_url":"https://api.github.com/repos/videolan/vlc-ios/events","assignees_url":"https://api.github.com/repos/videolan/vlc-ios/assignees{/user}","branches_url":"https://api.github.com/repos/videolan/vlc-ios/branches{/branch}","tags_url":"https://api.github.com/repos/videolan/vlc-ios/tags","blobs_url":"https://api.github.com/repos/videolan/vlc-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videolan/vlc-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videolan/vlc-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/videolan/vlc-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videolan/vlc-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/videolan/vlc-ios/languages","stargazers_url":"https://api.github.com/repos/videolan/vlc-ios/stargazers","contributors_url":"https://api.github.com/repos/videolan/vlc-ios/contributors","subscribers_url":"https://api.github.com/repos/videolan/vlc-ios/subscribers","subscription_url":"https://api.github.com/repos/videolan/vlc-ios/subscription","commits_url":"https://api.github.com/repos/videolan/vlc-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/videolan/vlc-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/videolan/vlc-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/videolan/vlc-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/videolan/vlc-ios/contents/{+path}","compare_url":"https://api.github.com/repos/videolan/vlc-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videolan/vlc-ios/merges","archive_url":"https://api.github.com/repos/videolan/vlc-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videolan/vlc-ios/downloads","issues_url":"https://api.github.com/repos/videolan/vlc-ios/issues{/number}","pulls_url":"https://api.github.com/repos/videolan/vlc-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/videolan/vlc-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/videolan/vlc-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videolan/vlc-ios/labels{/name}","releases_url":"https://api.github.com/repos/videolan/vlc-ios/releases{/id}","deployments_url":"https://api.github.com/repos/videolan/vlc-ios/deployments","created_at":"2018-02-04T14:44:05Z","updated_at":"2018-08-29T08:17:55Z","pushed_at":"2018-08-29T08:52:41Z","git_url":"git://github.com/videolan/vlc-ios.git","ssh_url":"git@github.com:videolan/vlc-ios.git","clone_url":"https://github.com/videolan/vlc-ios.git","svn_url":"https://github.com/videolan/vlc-ios","homepage":"","size":49159,"stargazers_count":236,"watchers_count":236,"language":"Objective-C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":43,"open_issues":4,"watchers":236,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videolan/vlc-ios/pulls/129"},"html":{"href":"https://github.com/videolan/vlc-ios/pull/129"},"issue":{"href":"https://api.github.com/repos/videolan/vlc-ios/issues/129"},"comments":{"href":"https://api.github.com/repos/videolan/vlc-ios/issues/129/comments"},"review_comments":{"href":"https://api.github.com/repos/videolan/vlc-ios/pulls/129/comments"},"review_comment":{"href":"https://api.github.com/repos/videolan/vlc-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videolan/vlc-ios/pulls/129/commits"},"statuses":{"href":"https://api.github.com/repos/videolan/vlc-ios/statuses/11e39657960376b818c70969163ad0abc97e5511"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mkchoi212"}}