{"action":"closed","number":348,"pull_request":{"url":"https://api.github.com/repos/ring-clojure/ring/pulls/348","id":217016861,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MDE2ODYx","html_url":"https://github.com/ring-clojure/ring/pull/348","diff_url":"https://github.com/ring-clojure/ring/pull/348.diff","patch_url":"https://github.com/ring-clojure/ring/pull/348.patch","issue_url":"https://api.github.com/repos/ring-clojure/ring/issues/348","number":348,"state":"closed","locked":false,"title":"Use three-letter timezones from rfc822 for chrome/safari compatibility","user":{"login":"kipz","id":1865026,"node_id":"MDQ6VXNlcjE4NjUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1865026?v=4","gravatar_id":"","url":"https://api.github.com/users/kipz","html_url":"https://github.com/kipz","followers_url":"https://api.github.com/users/kipz/followers","following_url":"https://api.github.com/users/kipz/following{/other_user}","gists_url":"https://api.github.com/users/kipz/gists{/gist_id}","starred_url":"https://api.github.com/users/kipz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kipz/subscriptions","organizations_url":"https://api.github.com/users/kipz/orgs","repos_url":"https://api.github.com/users/kipz/repos","events_url":"https://api.github.com/users/kipz/events{/privacy}","received_events_url":"https://api.github.com/users/kipz/received_events","type":"User","site_admin":false},"body":"Although the various specs prefer [1] numeric timezones allowed by rfc822 [2] for the cookie `expires` field, some browsers discard cookies with dates in this format (latest chrome and safari at the time of writing). Firefox does seem to respect this aspect of the specs.\r\n\r\n[1] https://tools.ietf.org/html/rfc1123#section-5.2.14\r\n[2] https://tools.ietf.org/html/rfc822#section-5.1\r\n\r\nKudos to @neilprosser for spotting this!","created_at":"2018-09-20T15:34:08Z","updated_at":"2018-09-20T15:57:47Z","closed_at":"2018-09-20T15:57:47Z","merged_at":null,"merge_commit_sha":"7c9e423abbcf82f9666d2816ed4876d50bcc18bb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ring-clojure/ring/pulls/348/commits","review_comments_url":"https://api.github.com/repos/ring-clojure/ring/pulls/348/comments","review_comment_url":"https://api.github.com/repos/ring-clojure/ring/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ring-clojure/ring/issues/348/comments","statuses_url":"https://api.github.com/repos/ring-clojure/ring/statuses/73817c9d025424947d30ebffeb9adb9b43a98933","head":{"label":"atomisthq:master","ref":"master","sha":"73817c9d025424947d30ebffeb9adb9b43a98933","user":{"login":"atomisthq","id":13823265,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODIzMjY1","avatar_url":"https://avatars3.githubusercontent.com/u/13823265?v=4","gravatar_id":"","url":"https://api.github.com/users/atomisthq","html_url":"https://github.com/atomisthq","followers_url":"https://api.github.com/users/atomisthq/followers","following_url":"https://api.github.com/users/atomisthq/following{/other_user}","gists_url":"https://api.github.com/users/atomisthq/gists{/gist_id}","starred_url":"https://api.github.com/users/atomisthq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomisthq/subscriptions","organizations_url":"https://api.github.com/users/atomisthq/orgs","repos_url":"https://api.github.com/users/atomisthq/repos","events_url":"https://api.github.com/users/atomisthq/events{/privacy}","received_events_url":"https://api.github.com/users/atomisthq/received_events","type":"Organization","site_admin":false},"repo":{"id":149626142,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk2MjYxNDI=","name":"ring","full_name":"atomisthq/ring","private":false,"owner":{"login":"atomisthq","id":13823265,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODIzMjY1","avatar_url":"https://avatars3.githubusercontent.com/u/13823265?v=4","gravatar_id":"","url":"https://api.github.com/users/atomisthq","html_url":"https://github.com/atomisthq","followers_url":"https://api.github.com/users/atomisthq/followers","following_url":"https://api.github.com/users/atomisthq/following{/other_user}","gists_url":"https://api.github.com/users/atomisthq/gists{/gist_id}","starred_url":"https://api.github.com/users/atomisthq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomisthq/subscriptions","organizations_url":"https://api.github.com/users/atomisthq/orgs","repos_url":"https://api.github.com/users/atomisthq/repos","events_url":"https://api.github.com/users/atomisthq/events{/privacy}","received_events_url":"https://api.github.com/users/atomisthq/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/atomisthq/ring","description":"Clojure HTTP server abstraction","fork":true,"url":"https://api.github.com/repos/atomisthq/ring","forks_url":"https://api.github.com/repos/atomisthq/ring/forks","keys_url":"https://api.github.com/repos/atomisthq/ring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atomisthq/ring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atomisthq/ring/teams","hooks_url":"https://api.github.com/repos/atomisthq/ring/hooks","issue_events_url":"https://api.github.com/repos/atomisthq/ring/issues/events{/number}","events_url":"https://api.github.com/repos/atomisthq/ring/events","assignees_url":"https://api.github.com/repos/atomisthq/ring/assignees{/user}","branches_url":"https://api.github.com/repos/atomisthq/ring/branches{/branch}","tags_url":"https://api.github.com/repos/atomisthq/ring/tags","blobs_url":"https://api.github.com/repos/atomisthq/ring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atomisthq/ring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atomisthq/ring/git/refs{/sha}","trees_url":"https://api.github.com/repos/atomisthq/ring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atomisthq/ring/statuses/{sha}","languages_url":"https://api.github.com/repos/atomisthq/ring/languages","stargazers_url":"https://api.github.com/repos/atomisthq/ring/stargazers","contributors_url":"https://api.github.com/repos/atomisthq/ring/contributors","subscribers_url":"https://api.github.com/repos/atomisthq/ring/subscribers","subscription_url":"https://api.github.com/repos/atomisthq/ring/subscription","commits_url":"https://api.github.com/repos/atomisthq/ring/commits{/sha}","git_commits_url":"https://api.github.com/repos/atomisthq/ring/git/commits{/sha}","comments_url":"https://api.github.com/repos/atomisthq/ring/comments{/number}","issue_comment_url":"https://api.github.com/repos/atomisthq/ring/issues/comments{/number}","contents_url":"https://api.github.com/repos/atomisthq/ring/contents/{+path}","compare_url":"https://api.github.com/repos/atomisthq/ring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atomisthq/ring/merges","archive_url":"https://api.github.com/repos/atomisthq/ring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atomisthq/ring/downloads","issues_url":"https://api.github.com/repos/atomisthq/ring/issues{/number}","pulls_url":"https://api.github.com/repos/atomisthq/ring/pulls{/number}","milestones_url":"https://api.github.com/repos/atomisthq/ring/milestones{/number}","notifications_url":"https://api.github.com/repos/atomisthq/ring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atomisthq/ring/labels{/name}","releases_url":"https://api.github.com/repos/atomisthq/ring/releases{/id}","deployments_url":"https://api.github.com/repos/atomisthq/ring/deployments","created_at":"2018-09-20T14:54:04Z","updated_at":"2018-09-20T15:49:58Z","pushed_at":"2018-09-20T15:49:56Z","git_url":"git://github.com/atomisthq/ring.git","ssh_url":"git@github.com:atomisthq/ring.git","clone_url":"https://github.com/atomisthq/ring.git","svn_url":"https://github.com/atomisthq/ring","homepage":"","size":6921,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ring-clojure:master","ref":"master","sha":"16b11fa486a41cd4881439bfcc51a55fbc0d9fb4","user":{"login":"ring-clojure","id":1689840,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODk4NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1689840?v=4","gravatar_id":"","url":"https://api.github.com/users/ring-clojure","html_url":"https://github.com/ring-clojure","followers_url":"https://api.github.com/users/ring-clojure/followers","following_url":"https://api.github.com/users/ring-clojure/following{/other_user}","gists_url":"https://api.github.com/users/ring-clojure/gists{/gist_id}","starred_url":"https://api.github.com/users/ring-clojure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ring-clojure/subscriptions","organizations_url":"https://api.github.com/users/ring-clojure/orgs","repos_url":"https://api.github.com/users/ring-clojure/repos","events_url":"https://api.github.com/users/ring-clojure/events{/privacy}","received_events_url":"https://api.github.com/users/ring-clojure/received_events","type":"Organization","site_admin":false},"repo":{"id":4173871,"node_id":"MDEwOlJlcG9zaXRvcnk0MTczODcx","name":"ring","full_name":"ring-clojure/ring","private":false,"owner":{"login":"ring-clojure","id":1689840,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODk4NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1689840?v=4","gravatar_id":"","url":"https://api.github.com/users/ring-clojure","html_url":"https://github.com/ring-clojure","followers_url":"https://api.github.com/users/ring-clojure/followers","following_url":"https://api.github.com/users/ring-clojure/following{/other_user}","gists_url":"https://api.github.com/users/ring-clojure/gists{/gist_id}","starred_url":"https://api.github.com/users/ring-clojure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ring-clojure/subscriptions","organizations_url":"https://api.github.com/users/ring-clojure/orgs","repos_url":"https://api.github.com/users/ring-clojure/repos","events_url":"https://api.github.com/users/ring-clojure/events{/privacy}","received_events_url":"https://api.github.com/users/ring-clojure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ring-clojure/ring","description":"Clojure HTTP server abstraction","fork":false,"url":"https://api.github.com/repos/ring-clojure/ring","forks_url":"https://api.github.com/repos/ring-clojure/ring/forks","keys_url":"https://api.github.com/repos/ring-clojure/ring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ring-clojure/ring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ring-clojure/ring/teams","hooks_url":"https://api.github.com/repos/ring-clojure/ring/hooks","issue_events_url":"https://api.github.com/repos/ring-clojure/ring/issues/events{/number}","events_url":"https://api.github.com/repos/ring-clojure/ring/events","assignees_url":"https://api.github.com/repos/ring-clojure/ring/assignees{/user}","branches_url":"https://api.github.com/repos/ring-clojure/ring/branches{/branch}","tags_url":"https://api.github.com/repos/ring-clojure/ring/tags","blobs_url":"https://api.github.com/repos/ring-clojure/ring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ring-clojure/ring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ring-clojure/ring/git/refs{/sha}","trees_url":"https://api.github.com/repos/ring-clojure/ring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ring-clojure/ring/statuses/{sha}","languages_url":"https://api.github.com/repos/ring-clojure/ring/languages","stargazers_url":"https://api.github.com/repos/ring-clojure/ring/stargazers","contributors_url":"https://api.github.com/repos/ring-clojure/ring/contributors","subscribers_url":"https://api.github.com/repos/ring-clojure/ring/subscribers","subscription_url":"https://api.github.com/repos/ring-clojure/ring/subscription","commits_url":"https://api.github.com/repos/ring-clojure/ring/commits{/sha}","git_commits_url":"https://api.github.com/repos/ring-clojure/ring/git/commits{/sha}","comments_url":"https://api.github.com/repos/ring-clojure/ring/comments{/number}","issue_comment_url":"https://api.github.com/repos/ring-clojure/ring/issues/comments{/number}","contents_url":"https://api.github.com/repos/ring-clojure/ring/contents/{+path}","compare_url":"https://api.github.com/repos/ring-clojure/ring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ring-clojure/ring/merges","archive_url":"https://api.github.com/repos/ring-clojure/ring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ring-clojure/ring/downloads","issues_url":"https://api.github.com/repos/ring-clojure/ring/issues{/number}","pulls_url":"https://api.github.com/repos/ring-clojure/ring/pulls{/number}","milestones_url":"https://api.github.com/repos/ring-clojure/ring/milestones{/number}","notifications_url":"https://api.github.com/repos/ring-clojure/ring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ring-clojure/ring/labels{/name}","releases_url":"https://api.github.com/repos/ring-clojure/ring/releases{/id}","deployments_url":"https://api.github.com/repos/ring-clojure/ring/deployments","created_at":"2012-04-29T11:15:06Z","updated_at":"2018-09-20T03:07:54Z","pushed_at":"2018-09-20T15:49:57Z","git_url":"git://github.com/ring-clojure/ring.git","ssh_url":"git@github.com:ring-clojure/ring.git","clone_url":"https://github.com/ring-clojure/ring.git","svn_url":"https://github.com/ring-clojure/ring","homepage":"","size":6921,"stargazers_count":2640,"watchers_count":2640,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":413,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":413,"open_issues":28,"watchers":2640,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ring-clojure/ring/pulls/348"},"html":{"href":"https://github.com/ring-clojure/ring/pull/348"},"issue":{"href":"https://api.github.com/repos/ring-clojure/ring/issues/348"},"comments":{"href":"https://api.github.com/repos/ring-clojure/ring/issues/348/comments"},"review_comments":{"href":"https://api.github.com/repos/ring-clojure/ring/pulls/348/comments"},"review_comment":{"href":"https://api.github.com/repos/ring-clojure/ring/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ring-clojure/ring/pulls/348/commits"},"statuses":{"href":"https://api.github.com/repos/ring-clojure/ring/statuses/73817c9d025424947d30ebffeb9adb9b43a98933"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"kipz"}}