{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/jetty.project/issues/2191","repository_url":"https://api.github.com/repos/eclipse/jetty.project","labels_url":"https://api.github.com/repos/eclipse/jetty.project/issues/2191/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/jetty.project/issues/2191/comments","events_url":"https://api.github.com/repos/eclipse/jetty.project/issues/2191/events","html_url":"https://github.com/eclipse/jetty.project/issues/2191","id":295938856,"node_id":"MDU6SXNzdWUyOTU5Mzg4NTY=","number":2191,"title":"JPMS Support","user":{"login":"jmcc0nn3ll","id":273327,"node_id":"MDQ6VXNlcjI3MzMyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/273327?v=4","gravatar_id":"","url":"https://api.github.com/users/jmcc0nn3ll","html_url":"https://github.com/jmcc0nn3ll","followers_url":"https://api.github.com/users/jmcc0nn3ll/followers","following_url":"https://api.github.com/users/jmcc0nn3ll/following{/other_user}","gists_url":"https://api.github.com/users/jmcc0nn3ll/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcc0nn3ll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcc0nn3ll/subscriptions","organizations_url":"https://api.github.com/users/jmcc0nn3ll/orgs","repos_url":"https://api.github.com/users/jmcc0nn3ll/repos","events_url":"https://api.github.com/users/jmcc0nn3ll/events{/privacy}","received_events_url":"https://api.github.com/users/jmcc0nn3ll/received_events","type":"User","site_admin":false},"labels":[{"id":326417667,"node_id":"MDU6TGFiZWwzMjY0MTc2Njc=","url":"https://api.github.com/repos/eclipse/jetty.project/labels/Enhancement","name":"Enhancement","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":103,"created_at":"2018-02-09T16:56:37Z","updated_at":"2018-09-18T13:09:44Z","closed_at":null,"author_association":"MEMBER","body":"This can be a root issue for ongoing efforts for Jetty to support JPMS features in Java.\r\n\r\nJetty has had OSGi support for nigh on a decade and it is not something we can simply abandon in lieu of java adding on a module management system.  While that community has made strides in integrating well with the JPMS mechanics at the point of this thread creation it has largely been up in the air as to what that should mean for the Jetty project itself.  \r\n\r\nJetty 9.4.x supports the usage of Java 9 with the module system disabled and it remains to be seen what Jetty 10 will do with it.  Lets have some discussion on this thread about that and maybe start getting this broken down a bit.\r\n\r\n@guw  We would welcome your input here as well as a historical user of jetty and osgi, your plans regarding jpms and what you might expect from jetty regarding it.\r\n\r\nWe also have @PashaTurok with #2189 as the first user requesting this support and there is some info in that issue.\r\n\r\nAdditionally, to set expectations this is not something that will happen overnight, especially since it seems that it will involve a fairly substantial review of the overall artifact layout of Jetty."},"comment":{"url":"https://api.github.com/repos/eclipse/jetty.project/issues/comments/422386608","html_url":"https://github.com/eclipse/jetty.project/issues/2191#issuecomment-422386608","issue_url":"https://api.github.com/repos/eclipse/jetty.project/issues/2191","id":422386608,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjM4NjYwOA==","user":{"login":"sbordet","id":414681,"node_id":"MDQ6VXNlcjQxNDY4MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/414681?v=4","gravatar_id":"","url":"https://api.github.com/users/sbordet","html_url":"https://github.com/sbordet","followers_url":"https://api.github.com/users/sbordet/followers","following_url":"https://api.github.com/users/sbordet/following{/other_user}","gists_url":"https://api.github.com/users/sbordet/gists{/gist_id}","starred_url":"https://api.github.com/users/sbordet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbordet/subscriptions","organizations_url":"https://api.github.com/users/sbordet/orgs","repos_url":"https://api.github.com/users/sbordet/repos","events_url":"https://api.github.com/users/sbordet/events{/privacy}","received_events_url":"https://api.github.com/users/sbordet/received_events","type":"User","site_admin":false},"created_at":"2018-09-18T13:09:44Z","updated_at":"2018-09-18T13:09:44Z","author_association":"CONTRIBUTOR","body":"@PashaTurok you should do this:\r\n\r\n```\r\n$ git clone https://github.com/eclipse/jetty.project.git\r\n$ cd jetty.project\r\n$ git checkout jetty-9.4.x-2191-jpms_automatic_module_name\r\n$ mvn clean install -DskipTests\r\n```\r\n\r\nAfter that the Jetty distribution is in `jetty-distribution/target/distribution/`.\r\nThis directory is what I refer to when I say \"Jetty distribution\" or - equivalently - `$JETTY_HOME`.\r\n\r\nBTW I was able to compile a JSP with a taglib directive (`<%@ taglib uri=\"http://java.sun.com/jsp/jstl/core\" prefix=\"c\" %>`) - previously I forgot to add `$JETTY_HOME/lib/apache-jstl` to the module-path.\r\n\r\nIn conclusions, it works for us, so we just need to figure out what's different for you."}}
{"actor":{"display_login":"sbordet"}}