{"push_id":2313108854,"size":2,"distinct_size":1,"ref":"refs/heads/master","head":"95f494c607912a17e82f47e2b656428961fc39d7","before":"b9436599a0e323bdefa9d3ec2e511be73c9102fe","commits":[{"sha":"3588d413ade35138643b7f73f379bc11d96302e8","author":{"name":"Amy Fiori","email":"dacb3d2f647648f725cfd2b74c60514ac48fb0a8@yahoo.com"},"message":"Created domFunctions class, tableDragDrop class, new folder\n\nregressionTest.clearAll() now piggybacks on app’s db so doesn’t need one of its own.\nregressionTest.clearAll() now takes app as an argument, rather than expecting app to exist.\nCreated domFunctions class which includes widgetGetId and getChildByIdr; removed these from app class.\nReplaced all calls to app.getChildByIdr with either app.domFunctions.getChildByIdr or this.domFunctions.getChildByIdr, added domFunctions objects where appropriate. Same for widgetGetId.\nRemoved app object from 1-drag.html, removed all references to app from dragDrop.js.\nRemoved dragDrop.html’s references to all other classes except regressionTesting and domFunctions.\nResult: regressionTest now depends only on domFunctions, and dragDrop depends only on domFunctions and regressionTests.\n\nCreated tableDragDrop class that extends dragDrop. Right now, all it does is create an insert row inside the “container” node based on a “template” node, and everything else is identical to the dragDrop class. (It creates the <tr> element that we didn’t want the user to have to write themselves, and then goes from there.)\n\nRemoved the tr with all the tds from the tbody, and instead just gave the tbody an id of “container” and the tr with the ths an id of “template”. Created new tableDrag.html file, removed all the code for the simple list from that file and removed all the code for the table from the original 1-drag.html file.\n\nCreated a new folder in 4-regressionTests called tableDragDrop. Moved the tableDrag.html, tableDragDrop.js and table test files to that folder.\n\nCleaned up dragDrop: Since items aren’t being added on blur anymore, no need to do some of showHide’s actions BEFORE blurring input (onmousedown) and some AFTER (onclick). Combined those two functions, inputToggle and inputFocusToggle, into inputToggle and called it onclick. Slightly improved the code to keep close button from being erased when editing a node — at least it no longer needs a class-wide variable.\n\nI don’t think it’s possible to select the directory to open with a file input. I have found no instructions for how to do it and several threads saying it can’t be done. Some point out that it is a security issue, others that web sites are usually made in order to be put online where anyone can access them, and you’d have no way to know whether a random other user even HAD the directory you chose.","distinct":false,"url":"https://api.github.com/repos/ETPRI/Graph/commits/3588d413ade35138643b7f73f379bc11d96302e8"},{"sha":"95f494c607912a17e82f47e2b656428961fc39d7","author":{"name":"David Bolt","email":"3ba620066b7d444d6c0c96b8ce99ef742aa1b049@etpri.org"},"message":"Merge pull request #18 from ETPRI/Amy-writing-domFunctions\n\nCreated domFunctions class, tableDragDrop class, new folder","distinct":true,"url":"https://api.github.com/repos/ETPRI/Graph/commits/95f494c607912a17e82f47e2b656428961fc39d7"}]}
{"actor":{"display_login":"dwbolt"}}