{"action":"created","comment":{"url":"https://api.github.com/repos/vacuumlabs/cardanolite/pulls/comments/202312889","pull_request_review_id":136988409,"id":202312889,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjMxMjg4OQ==","diff_hunk":"@@ -178,19 +181,27 @@ const CardanoWallet = async (options) => {\n     }\n   }\n \n-  function estimateTxSize(txInputs, coins, outputcount) {\n+  function estimateTxSize(txInputs, coins, hasChange, outAddressSize) {","path":"wallet/cardano-wallet.js","position":76,"original_position":76,"commit_id":"23d47847c74c9149b1ceb1c2a17c8850c29ff489","original_commit_id":"23d47847c74c9149b1ceb1c2a17c8850c29ff489","user":{"login":"refi93","id":4980147,"node_id":"MDQ6VXNlcjQ5ODAxNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/4980147?v=4","gravatar_id":"","url":"https://api.github.com/users/refi93","html_url":"https://github.com/refi93","followers_url":"https://api.github.com/users/refi93/followers","following_url":"https://api.github.com/users/refi93/following{/other_user}","gists_url":"https://api.github.com/users/refi93/gists{/gist_id}","starred_url":"https://api.github.com/users/refi93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refi93/subscriptions","organizations_url":"https://api.github.com/users/refi93/orgs","repos_url":"https://api.github.com/users/refi93/repos","events_url":"https://api.github.com/users/refi93/events{/privacy}","received_events_url":"https://api.github.com/users/refi93/received_events","type":"User","site_admin":false},"body":"I would flip the order of hasChange and outAddress, since I see this order as more intuitive.","created_at":"2018-07-13T10:44:42Z","updated_at":"2018-07-13T10:47:23Z","html_url":"https://github.com/vacuumlabs/cardanolite/pull/127#discussion_r202312889","pull_request_url":"https://api.github.com/repos/vacuumlabs/cardanolite/pulls/127","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/vacuumlabs/cardanolite/pulls/comments/202312889"},"html":{"href":"https://github.com/vacuumlabs/cardanolite/pull/127#discussion_r202312889"},"pull_request":{"href":"https://api.github.com/repos/vacuumlabs/cardanolite/pulls/127"}}},"pull_request":{"url":"https://api.github.com/repos/vacuumlabs/cardanolite/pulls/127","id":201021630,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMDIxNjMw","html_url":"https://github.com/vacuumlabs/cardanolite/pull/127","diff_url":"https://github.com/vacuumlabs/cardanolite/pull/127.diff","patch_url":"https://github.com/vacuumlabs/cardanolite/pull/127.patch","issue_url":"https://api.github.com/repos/vacuumlabs/cardanolite/issues/127","number":127,"state":"open","locked":false,"title":"Refactor estimateTxSize to take into account outgoing address size","user":{"login":"jmuravsky","id":9059268,"node_id":"MDQ6VXNlcjkwNTkyNjg=","avatar_url":"https://avatars3.githubusercontent.com/u/9059268?v=4","gravatar_id":"","url":"https://api.github.com/users/jmuravsky","html_url":"https://github.com/jmuravsky","followers_url":"https://api.github.com/users/jmuravsky/followers","following_url":"https://api.github.com/users/jmuravsky/following{/other_user}","gists_url":"https://api.github.com/users/jmuravsky/gists{/gist_id}","starred_url":"https://api.github.com/users/jmuravsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmuravsky/subscriptions","organizations_url":"https://api.github.com/users/jmuravsky/orgs","repos_url":"https://api.github.com/users/jmuravsky/repos","events_url":"https://api.github.com/users/jmuravsky/events{/privacy}","received_events_url":"https://api.github.com/users/jmuravsky/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-12T14:31:46Z","updated_at":"2018-07-13T10:47:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c02ffc2af76961d2dad9f0ee92181169357068e9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vacuumlabs/cardanolite/pulls/127/commits","review_comments_url":"https://api.github.com/repos/vacuumlabs/cardanolite/pulls/127/comments","review_comment_url":"https://api.github.com/repos/vacuumlabs/cardanolite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vacuumlabs/cardanolite/issues/127/comments","statuses_url":"https://api.github.com/repos/vacuumlabs/cardanolite/statuses/23d47847c74c9149b1ceb1c2a17c8850c29ff489","head":{"label":"vacuumlabs:issue-120-fix-x-size-estimation","ref":"issue-120-fix-x-size-estimation","sha":"23d47847c74c9149b1ceb1c2a17c8850c29ff489","user":{"login":"vacuumlabs","id":6526075,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjYwNzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6526075?v=4","gravatar_id":"","url":"https://api.github.com/users/vacuumlabs","html_url":"https://github.com/vacuumlabs","followers_url":"https://api.github.com/users/vacuumlabs/followers","following_url":"https://api.github.com/users/vacuumlabs/following{/other_user}","gists_url":"https://api.github.com/users/vacuumlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/vacuumlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vacuumlabs/subscriptions","organizations_url":"https://api.github.com/users/vacuumlabs/orgs","repos_url":"https://api.github.com/users/vacuumlabs/repos","events_url":"https://api.github.com/users/vacuumlabs/events{/privacy}","received_events_url":"https://api.github.com/users/vacuumlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":116134121,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYxMzQxMjE=","name":"cardanolite","full_name":"vacuumlabs/cardanolite","owner":{"login":"vacuumlabs","id":6526075,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjYwNzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6526075?v=4","gravatar_id":"","url":"https://api.github.com/users/vacuumlabs","html_url":"https://github.com/vacuumlabs","followers_url":"https://api.github.com/users/vacuumlabs/followers","following_url":"https://api.github.com/users/vacuumlabs/following{/other_user}","gists_url":"https://api.github.com/users/vacuumlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/vacuumlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vacuumlabs/subscriptions","organizations_url":"https://api.github.com/users/vacuumlabs/orgs","repos_url":"https://api.github.com/users/vacuumlabs/repos","events_url":"https://api.github.com/users/vacuumlabs/events{/privacy}","received_events_url":"https://api.github.com/users/vacuumlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vacuumlabs/cardanolite","description":"A lightweight wallet for Cardano cryptocurrency","fork":false,"url":"https://api.github.com/repos/vacuumlabs/cardanolite","forks_url":"https://api.github.com/repos/vacuumlabs/cardanolite/forks","keys_url":"https://api.github.com/repos/vacuumlabs/cardanolite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vacuumlabs/cardanolite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vacuumlabs/cardanolite/teams","hooks_url":"https://api.github.com/repos/vacuumlabs/cardanolite/hooks","issue_events_url":"https://api.github.com/repos/vacuumlabs/cardanolite/issues/events{/number}","events_url":"https://api.github.com/repos/vacuumlabs/cardanolite/events","assignees_url":"https://api.github.com/repos/vacuumlabs/cardanolite/assignees{/user}","branches_url":"https://api.github.com/repos/vacuumlabs/cardanolite/branches{/branch}","tags_url":"https://api.github.com/repos/vacuumlabs/cardanolite/tags","blobs_url":"https://api.github.com/repos/vacuumlabs/cardanolite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vacuumlabs/cardanolite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vacuumlabs/cardanolite/git/refs{/sha}","trees_url":"https://api.github.com/repos/vacuumlabs/cardanolite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vacuumlabs/cardanolite/statuses/{sha}","languages_url":"https://api.github.com/repos/vacuumlabs/cardanolite/languages","stargazers_url":"https://api.github.com/repos/vacuumlabs/cardanolite/stargazers","contributors_url":"https://api.github.com/repos/vacuumlabs/cardanolite/contributors","subscribers_url":"https://api.github.com/repos/vacuumlabs/cardanolite/subscribers","subscription_url":"https://api.github.com/repos/vacuumlabs/cardanolite/subscription","commits_url":"https://api.github.com/repos/vacuumlabs/cardanolite/commits{/sha}","git_commits_url":"https://api.github.com/repos/vacuumlabs/cardanolite/git/commits{/sha}","comments_url":"https://api.github.com/repos/vacuumlabs/cardanolite/comments{/number}","issue_comment_url":"https://api.github.com/repos/vacuumlabs/cardanolite/issues/comments{/number}","contents_url":"https://api.github.com/repos/vacuumlabs/cardanolite/contents/{+path}","compare_url":"https://api.github.com/repos/vacuumlabs/cardanolite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vacuumlabs/cardanolite/merges","archive_url":"https://api.github.com/repos/vacuumlabs/cardanolite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vacuumlabs/cardanolite/downloads","issues_url":"https://api.github.com/repos/vacuumlabs/cardanolite/issues{/number}","pulls_url":"https://api.github.com/repos/vacuumlabs/cardanolite/pulls{/number}","milestones_url":"https://api.github.com/repos/vacuumlabs/cardanolite/milestones{/number}","notifications_url":"https://api.github.com/repos/vacuumlabs/cardanolite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vacuumlabs/cardanolite/labels{/name}","releases_url":"https://api.github.com/repos/vacuumlabs/cardanolite/releases{/id}","deployments_url":"https://api.github.com/repos/vacuumlabs/cardanolite/deployments","created_at":"2018-01-03T12:24:41Z","updated_at":"2018-07-02T14:04:56Z","pushed_at":"2018-07-13T10:37:24Z","git_url":"git://github.com/vacuumlabs/cardanolite.git","ssh_url":"git@github.com:vacuumlabs/cardanolite.git","clone_url":"https://github.com/vacuumlabs/cardanolite.git","svn_url":"https://github.com/vacuumlabs/cardanolite","homepage":"https://www.cardanolite.com","size":3485,"stargazers_count":10,"watchers_count":10,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":0,"open_issues":13,"watchers":10,"default_branch":"master"}},"base":{"label":"vacuumlabs:develop","ref":"develop","sha":"76d126981d415f9bb0c544d727b9438b116ab909","user":{"login":"vacuumlabs","id":6526075,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjYwNzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6526075?v=4","gravatar_id":"","url":"https://api.github.com/users/vacuumlabs","html_url":"https://github.com/vacuumlabs","followers_url":"https://api.github.com/users/vacuumlabs/followers","following_url":"https://api.github.com/users/vacuumlabs/following{/other_user}","gists_url":"https://api.github.com/users/vacuumlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/vacuumlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vacuumlabs/subscriptions","organizations_url":"https://api.github.com/users/vacuumlabs/orgs","repos_url":"https://api.github.com/users/vacuumlabs/repos","events_url":"https://api.github.com/users/vacuumlabs/events{/privacy}","received_events_url":"https://api.github.com/users/vacuumlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":116134121,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYxMzQxMjE=","name":"cardanolite","full_name":"vacuumlabs/cardanolite","owner":{"login":"vacuumlabs","id":6526075,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjYwNzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6526075?v=4","gravatar_id":"","url":"https://api.github.com/users/vacuumlabs","html_url":"https://github.com/vacuumlabs","followers_url":"https://api.github.com/users/vacuumlabs/followers","following_url":"https://api.github.com/users/vacuumlabs/following{/other_user}","gists_url":"https://api.github.com/users/vacuumlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/vacuumlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vacuumlabs/subscriptions","organizations_url":"https://api.github.com/users/vacuumlabs/orgs","repos_url":"https://api.github.com/users/vacuumlabs/repos","events_url":"https://api.github.com/users/vacuumlabs/events{/privacy}","received_events_url":"https://api.github.com/users/vacuumlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vacuumlabs/cardanolite","description":"A lightweight wallet for Cardano cryptocurrency","fork":false,"url":"https://api.github.com/repos/vacuumlabs/cardanolite","forks_url":"https://api.github.com/repos/vacuumlabs/cardanolite/forks","keys_url":"https://api.github.com/repos/vacuumlabs/cardanolite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vacuumlabs/cardanolite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vacuumlabs/cardanolite/teams","hooks_url":"https://api.github.com/repos/vacuumlabs/cardanolite/hooks","issue_events_url":"https://api.github.com/repos/vacuumlabs/cardanolite/issues/events{/number}","events_url":"https://api.github.com/repos/vacuumlabs/cardanolite/events","assignees_url":"https://api.github.com/repos/vacuumlabs/cardanolite/assignees{/user}","branches_url":"https://api.github.com/repos/vacuumlabs/cardanolite/branches{/branch}","tags_url":"https://api.github.com/repos/vacuumlabs/cardanolite/tags","blobs_url":"https://api.github.com/repos/vacuumlabs/cardanolite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vacuumlabs/cardanolite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vacuumlabs/cardanolite/git/refs{/sha}","trees_url":"https://api.github.com/repos/vacuumlabs/cardanolite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vacuumlabs/cardanolite/statuses/{sha}","languages_url":"https://api.github.com/repos/vacuumlabs/cardanolite/languages","stargazers_url":"https://api.github.com/repos/vacuumlabs/cardanolite/stargazers","contributors_url":"https://api.github.com/repos/vacuumlabs/cardanolite/contributors","subscribers_url":"https://api.github.com/repos/vacuumlabs/cardanolite/subscribers","subscription_url":"https://api.github.com/repos/vacuumlabs/cardanolite/subscription","commits_url":"https://api.github.com/repos/vacuumlabs/cardanolite/commits{/sha}","git_commits_url":"https://api.github.com/repos/vacuumlabs/cardanolite/git/commits{/sha}","comments_url":"https://api.github.com/repos/vacuumlabs/cardanolite/comments{/number}","issue_comment_url":"https://api.github.com/repos/vacuumlabs/cardanolite/issues/comments{/number}","contents_url":"https://api.github.com/repos/vacuumlabs/cardanolite/contents/{+path}","compare_url":"https://api.github.com/repos/vacuumlabs/cardanolite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vacuumlabs/cardanolite/merges","archive_url":"https://api.github.com/repos/vacuumlabs/cardanolite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vacuumlabs/cardanolite/downloads","issues_url":"https://api.github.com/repos/vacuumlabs/cardanolite/issues{/number}","pulls_url":"https://api.github.com/repos/vacuumlabs/cardanolite/pulls{/number}","milestones_url":"https://api.github.com/repos/vacuumlabs/cardanolite/milestones{/number}","notifications_url":"https://api.github.com/repos/vacuumlabs/cardanolite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vacuumlabs/cardanolite/labels{/name}","releases_url":"https://api.github.com/repos/vacuumlabs/cardanolite/releases{/id}","deployments_url":"https://api.github.com/repos/vacuumlabs/cardanolite/deployments","created_at":"2018-01-03T12:24:41Z","updated_at":"2018-07-02T14:04:56Z","pushed_at":"2018-07-13T10:37:24Z","git_url":"git://github.com/vacuumlabs/cardanolite.git","ssh_url":"git@github.com:vacuumlabs/cardanolite.git","clone_url":"https://github.com/vacuumlabs/cardanolite.git","svn_url":"https://github.com/vacuumlabs/cardanolite","homepage":"https://www.cardanolite.com","size":3485,"stargazers_count":10,"watchers_count":10,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":0,"open_issues":13,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vacuumlabs/cardanolite/pulls/127"},"html":{"href":"https://github.com/vacuumlabs/cardanolite/pull/127"},"issue":{"href":"https://api.github.com/repos/vacuumlabs/cardanolite/issues/127"},"comments":{"href":"https://api.github.com/repos/vacuumlabs/cardanolite/issues/127/comments"},"review_comments":{"href":"https://api.github.com/repos/vacuumlabs/cardanolite/pulls/127/comments"},"review_comment":{"href":"https://api.github.com/repos/vacuumlabs/cardanolite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vacuumlabs/cardanolite/pulls/127/commits"},"statuses":{"href":"https://api.github.com/repos/vacuumlabs/cardanolite/statuses/23d47847c74c9149b1ceb1c2a17c8850c29ff489"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"refi93"}}