{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/pulls/comments/208714387","pull_request_review_id":144582528,"id":208714387,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODcxNDM4Nw==","diff_hunk":"@@ -251,11 +269,25 @@ public Integer invoke(File f, VirtualChannel channel) throws IOException, Interr\n         static final StatusCheck STATUS_CHECK_INSTANCE = new StatusCheck();\n \n         @Override public Integer exitStatus(FilePath workspace, Launcher launcher, TaskListener listener) throws IOException, InterruptedException {\n+            return exitStatus(workspace, listener);\n+        }\n+\n+        /**\n+         * Like {@link #exitStatus(FilePath, Launcher, TaskListener)} but not requesting a {@link Launcher}, which would not be available in {@link #watch} mode anyway.\n+         */\n+        protected @CheckForNull Integer exitStatus(FilePath workspace, TaskListener listener) throws IOException, InterruptedException {\n             FilePath status = getResultFile(workspace);\n             return status.act(STATUS_CHECK_INSTANCE);\n         }\n \n         @Override public byte[] getOutput(FilePath workspace, Launcher launcher) throws IOException, InterruptedException {\n+            return getOutput(workspace);\n+        }\n+\n+        /**\n+         * Like {@link #getOutput(FilePath, Launcher)} but not requesting a {@link Launcher}, which would not be available in {@link #watch} mode anyway.\n+         */\n+        protected byte[] getOutput(FilePath workspace) throws IOException, InterruptedException {","path":"src/main/java/org/jenkinsci/plugins/durabletask/FileMonitoringTask.java","position":89,"original_position":89,"commit_id":"3ba5eb8cbce665c005eecdd98c69eacfe4bdd028","original_commit_id":"3ba5eb8cbce665c005eecdd98c69eacfe4bdd028","user":{"login":"jglick","id":154109,"node_id":"MDQ6VXNlcjE1NDEwOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/154109?v=4","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":"Was already discussed earlier. This method is only used when you specify `returnStdout: true`, a fairly specialized case which is anyway only suited for small amounts of output—in the case of a `workflow-cps` caller, the entire resulting `String` gets saved to `program.dat`.","created_at":"2018-08-08T19:56:36Z","updated_at":"2018-08-08T19:56:36Z","html_url":"https://github.com/jenkinsci/durable-task-plugin/pull/60#discussion_r208714387","pull_request_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/pulls/60","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/durable-task-plugin/pulls/comments/208714387"},"html":{"href":"https://github.com/jenkinsci/durable-task-plugin/pull/60#discussion_r208714387"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/durable-task-plugin/pulls/60"}},"in_reply_to_id":208705862},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/pulls/60","id":168300682,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY4MzAwNjgy","html_url":"https://github.com/jenkinsci/durable-task-plugin/pull/60","diff_url":"https://github.com/jenkinsci/durable-task-plugin/pull/60.diff","patch_url":"https://github.com/jenkinsci/durable-task-plugin/pull/60.patch","issue_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/issues/60","number":60,"state":"open","locked":false,"title":"[JENKINS-52165] Controller.watch API","user":{"login":"jglick","id":154109,"node_id":"MDQ6VXNlcjE1NDEwOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/154109?v=4","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":"[JENKINS-52165](https://issues.jenkins-ci.org/browse/JENKINS-52165) Just the minimum changes pulled out of #29 to enable push rather than pull logging from durable tasks.","created_at":"2018-02-09T17:38:53Z","updated_at":"2018-08-08T19:56:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d26c75089333f2379b5c36cabe85173b2e64e97b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"abayer","id":120218,"node_id":"MDQ6VXNlcjEyMDIxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/120218?v=4","gravatar_id":"","url":"https://api.github.com/users/abayer","html_url":"https://github.com/abayer","followers_url":"https://api.github.com/users/abayer/followers","following_url":"https://api.github.com/users/abayer/following{/other_user}","gists_url":"https://api.github.com/users/abayer/gists{/gist_id}","starred_url":"https://api.github.com/users/abayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abayer/subscriptions","organizations_url":"https://api.github.com/users/abayer/orgs","repos_url":"https://api.github.com/users/abayer/repos","events_url":"https://api.github.com/users/abayer/events{/privacy}","received_events_url":"https://api.github.com/users/abayer/received_events","type":"User","site_admin":false},{"login":"rsandell","id":300688,"node_id":"MDQ6VXNlcjMwMDY4OA==","avatar_url":"https://avatars2.githubusercontent.com/u/300688?v=4","gravatar_id":"","url":"https://api.github.com/users/rsandell","html_url":"https://github.com/rsandell","followers_url":"https://api.github.com/users/rsandell/followers","following_url":"https://api.github.com/users/rsandell/following{/other_user}","gists_url":"https://api.github.com/users/rsandell/gists{/gist_id}","starred_url":"https://api.github.com/users/rsandell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsandell/subscriptions","organizations_url":"https://api.github.com/users/rsandell/orgs","repos_url":"https://api.github.com/users/rsandell/repos","events_url":"https://api.github.com/users/rsandell/events{/privacy}","received_events_url":"https://api.github.com/users/rsandell/received_events","type":"User","site_admin":false},{"login":"oleg-nenashev","id":3000480,"node_id":"MDQ6VXNlcjMwMDA0ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/3000480?v=4","gravatar_id":"","url":"https://api.github.com/users/oleg-nenashev","html_url":"https://github.com/oleg-nenashev","followers_url":"https://api.github.com/users/oleg-nenashev/followers","following_url":"https://api.github.com/users/oleg-nenashev/following{/other_user}","gists_url":"https://api.github.com/users/oleg-nenashev/gists{/gist_id}","starred_url":"https://api.github.com/users/oleg-nenashev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleg-nenashev/subscriptions","organizations_url":"https://api.github.com/users/oleg-nenashev/orgs","repos_url":"https://api.github.com/users/oleg-nenashev/repos","events_url":"https://api.github.com/users/oleg-nenashev/events{/privacy}","received_events_url":"https://api.github.com/users/oleg-nenashev/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/pulls/60/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/pulls/60/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/issues/60/comments","statuses_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/statuses/3ba5eb8cbce665c005eecdd98c69eacfe4bdd028","head":{"label":"jglick:watch-JENKINS-38381","ref":"watch-JENKINS-38381","sha":"3ba5eb8cbce665c005eecdd98c69eacfe4bdd028","user":{"login":"jglick","id":154109,"node_id":"MDQ6VXNlcjE1NDEwOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/154109?v=4","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"repo":{"id":31729588,"node_id":"MDEwOlJlcG9zaXRvcnkzMTcyOTU4OA==","name":"durable-task-plugin","full_name":"jglick/durable-task-plugin","owner":{"login":"jglick","id":154109,"node_id":"MDQ6VXNlcjE1NDEwOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/154109?v=4","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jglick/durable-task-plugin","description":null,"fork":true,"url":"https://api.github.com/repos/jglick/durable-task-plugin","forks_url":"https://api.github.com/repos/jglick/durable-task-plugin/forks","keys_url":"https://api.github.com/repos/jglick/durable-task-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jglick/durable-task-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jglick/durable-task-plugin/teams","hooks_url":"https://api.github.com/repos/jglick/durable-task-plugin/hooks","issue_events_url":"https://api.github.com/repos/jglick/durable-task-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jglick/durable-task-plugin/events","assignees_url":"https://api.github.com/repos/jglick/durable-task-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jglick/durable-task-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jglick/durable-task-plugin/tags","blobs_url":"https://api.github.com/repos/jglick/durable-task-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jglick/durable-task-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jglick/durable-task-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jglick/durable-task-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jglick/durable-task-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jglick/durable-task-plugin/languages","stargazers_url":"https://api.github.com/repos/jglick/durable-task-plugin/stargazers","contributors_url":"https://api.github.com/repos/jglick/durable-task-plugin/contributors","subscribers_url":"https://api.github.com/repos/jglick/durable-task-plugin/subscribers","subscription_url":"https://api.github.com/repos/jglick/durable-task-plugin/subscription","commits_url":"https://api.github.com/repos/jglick/durable-task-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jglick/durable-task-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jglick/durable-task-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jglick/durable-task-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jglick/durable-task-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jglick/durable-task-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jglick/durable-task-plugin/merges","archive_url":"https://api.github.com/repos/jglick/durable-task-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jglick/durable-task-plugin/downloads","issues_url":"https://api.github.com/repos/jglick/durable-task-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jglick/durable-task-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jglick/durable-task-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jglick/durable-task-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jglick/durable-task-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jglick/durable-task-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jglick/durable-task-plugin/deployments","created_at":"2015-03-05T18:39:08Z","updated_at":"2015-03-05T18:39:08Z","pushed_at":"2018-08-08T18:19:29Z","git_url":"git://github.com/jglick/durable-task-plugin.git","ssh_url":"git@github.com:jglick/durable-task-plugin.git","clone_url":"https://github.com/jglick/durable-task-plugin.git","svn_url":"https://github.com/jglick/durable-task-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Durable+Task+Plugin","size":401,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"87d6e9fccebbf5308a88582860902e9468fd8541","user":{"login":"jenkinsci","id":107424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":17874839,"node_id":"MDEwOlJlcG9zaXRvcnkxNzg3NDgzOQ==","name":"durable-task-plugin","full_name":"jenkinsci/durable-task-plugin","owner":{"login":"jenkinsci","id":107424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/durable-task-plugin","description":null,"fork":false,"url":"https://api.github.com/repos/jenkinsci/durable-task-plugin","forks_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/durable-task-plugin/deployments","created_at":"2014-03-18T17:21:04Z","updated_at":"2018-08-08T18:23:51Z","pushed_at":"2018-08-08T18:23:48Z","git_url":"git://github.com/jenkinsci/durable-task-plugin.git","ssh_url":"git@github.com:jenkinsci/durable-task-plugin.git","clone_url":"https://github.com/jenkinsci/durable-task-plugin.git","svn_url":"https://github.com/jenkinsci/durable-task-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Durable+Task+Plugin","size":343,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":58,"open_issues":11,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/durable-task-plugin/pulls/60"},"html":{"href":"https://github.com/jenkinsci/durable-task-plugin/pull/60"},"issue":{"href":"https://api.github.com/repos/jenkinsci/durable-task-plugin/issues/60"},"comments":{"href":"https://api.github.com/repos/jenkinsci/durable-task-plugin/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/durable-task-plugin/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/durable-task-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/durable-task-plugin/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/durable-task-plugin/statuses/3ba5eb8cbce665c005eecdd98c69eacfe4bdd028"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jglick"}}