{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/237111541","pull_request_review_id":179330372,"id":237111541,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzExMTU0MQ==","diff_hunk":"@@ -879,13 +879,13 @@ case class ColumnStatsMap(originalMap: AttributeMap[ColumnStat]) {\n   }\n \n   def hasCountStats(a: Attribute): Boolean =\n-    get(a).map(_.hasCountStats).getOrElse(false)\n+    get(a).exists(_.hasCountStats)\n \n   def hasDistinctCount(a: Attribute): Boolean =\n-    get(a).map(_.distinctCount.isDefined).getOrElse(false)\n+    get(a).exists(_.distinctCount.isDefined)\n \n   def hasMinMaxStats(a: Attribute): Boolean =\n-    get(a).map(_.hasCountStats).getOrElse(false)\n+    get(a).exists(_.hasMinMaxStats)","path":"sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala","position":13,"original_position":13,"commit_id":"1c1edccc43ac9cdb6da53ad93ac998b06bf8b6dd","original_commit_id":"1c1edccc43ac9cdb6da53ad93ac998b06bf8b6dd","user":{"login":"viirya","id":68855,"node_id":"MDQ6VXNlcjY4ODU1","avatar_url":"https://avatars1.githubusercontent.com/u/68855?v=4","gravatar_id":"","url":"https://api.github.com/users/viirya","html_url":"https://github.com/viirya","followers_url":"https://api.github.com/users/viirya/followers","following_url":"https://api.github.com/users/viirya/following{/other_user}","gists_url":"https://api.github.com/users/viirya/gists{/gist_id}","starred_url":"https://api.github.com/users/viirya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viirya/subscriptions","organizations_url":"https://api.github.com/users/viirya/orgs","repos_url":"https://api.github.com/users/viirya/repos","events_url":"https://api.github.com/users/viirya/events{/privacy}","received_events_url":"https://api.github.com/users/viirya/received_events","type":"User","site_admin":false},"body":"Can you add a test for it?","created_at":"2018-11-28T14:43:41Z","updated_at":"2018-11-28T14:43:42Z","html_url":"https://github.com/apache/spark/pull/23152#discussion_r237111541","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/23152","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/237111541"},"html":{"href":"https://github.com/apache/spark/pull/23152#discussion_r237111541"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/23152"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/23152","id":233794408,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNzk0NDA4","html_url":"https://github.com/apache/spark/pull/23152","diff_url":"https://github.com/apache/spark/pull/23152.diff","patch_url":"https://github.com/apache/spark/pull/23152.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/23152","number":23152,"state":"open","locked":false,"title":"[SPARK-26181][SQL] the `hasMinMaxStats` method of `ColumnStatsMap` is not correct","user":{"login":"adrian-wang","id":3078910,"node_id":"MDQ6VXNlcjMwNzg5MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3078910?v=4","gravatar_id":"","url":"https://api.github.com/users/adrian-wang","html_url":"https://github.com/adrian-wang","followers_url":"https://api.github.com/users/adrian-wang/followers","following_url":"https://api.github.com/users/adrian-wang/following{/other_user}","gists_url":"https://api.github.com/users/adrian-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-wang/subscriptions","organizations_url":"https://api.github.com/users/adrian-wang/orgs","repos_url":"https://api.github.com/users/adrian-wang/repos","events_url":"https://api.github.com/users/adrian-wang/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-wang/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nFor now the `hasMinMaxStats` will return the same as `hasCountStats`, which is obviously not as expected.\r\n\r\n## How was this patch tested?\r\n\r\nExisting tests.\r\n","created_at":"2018-11-27T06:29:21Z","updated_at":"2018-11-28T14:43:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6de7d67bc7d114caa949149967f36e5916d7b314","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/23152/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/23152/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/23152/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/1c1edccc43ac9cdb6da53ad93ac998b06bf8b6dd","head":{"label":"adrian-wang:minmaxstats","ref":"minmaxstats","sha":"1c1edccc43ac9cdb6da53ad93ac998b06bf8b6dd","user":{"login":"adrian-wang","id":3078910,"node_id":"MDQ6VXNlcjMwNzg5MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3078910?v=4","gravatar_id":"","url":"https://api.github.com/users/adrian-wang","html_url":"https://github.com/adrian-wang","followers_url":"https://api.github.com/users/adrian-wang/followers","following_url":"https://api.github.com/users/adrian-wang/following{/other_user}","gists_url":"https://api.github.com/users/adrian-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-wang/subscriptions","organizations_url":"https://api.github.com/users/adrian-wang/orgs","repos_url":"https://api.github.com/users/adrian-wang/repos","events_url":"https://api.github.com/users/adrian-wang/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-wang/received_events","type":"User","site_admin":false},"repo":{"id":18545588,"node_id":"MDEwOlJlcG9zaXRvcnkxODU0NTU4OA==","name":"spark","full_name":"adrian-wang/spark","private":false,"owner":{"login":"adrian-wang","id":3078910,"node_id":"MDQ6VXNlcjMwNzg5MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3078910?v=4","gravatar_id":"","url":"https://api.github.com/users/adrian-wang","html_url":"https://github.com/adrian-wang","followers_url":"https://api.github.com/users/adrian-wang/followers","following_url":"https://api.github.com/users/adrian-wang/following{/other_user}","gists_url":"https://api.github.com/users/adrian-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/adrian-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrian-wang/subscriptions","organizations_url":"https://api.github.com/users/adrian-wang/orgs","repos_url":"https://api.github.com/users/adrian-wang/repos","events_url":"https://api.github.com/users/adrian-wang/events{/privacy}","received_events_url":"https://api.github.com/users/adrian-wang/received_events","type":"User","site_admin":false},"html_url":"https://github.com/adrian-wang/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/adrian-wang/spark","forks_url":"https://api.github.com/repos/adrian-wang/spark/forks","keys_url":"https://api.github.com/repos/adrian-wang/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adrian-wang/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adrian-wang/spark/teams","hooks_url":"https://api.github.com/repos/adrian-wang/spark/hooks","issue_events_url":"https://api.github.com/repos/adrian-wang/spark/issues/events{/number}","events_url":"https://api.github.com/repos/adrian-wang/spark/events","assignees_url":"https://api.github.com/repos/adrian-wang/spark/assignees{/user}","branches_url":"https://api.github.com/repos/adrian-wang/spark/branches{/branch}","tags_url":"https://api.github.com/repos/adrian-wang/spark/tags","blobs_url":"https://api.github.com/repos/adrian-wang/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adrian-wang/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adrian-wang/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/adrian-wang/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adrian-wang/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/adrian-wang/spark/languages","stargazers_url":"https://api.github.com/repos/adrian-wang/spark/stargazers","contributors_url":"https://api.github.com/repos/adrian-wang/spark/contributors","subscribers_url":"https://api.github.com/repos/adrian-wang/spark/subscribers","subscription_url":"https://api.github.com/repos/adrian-wang/spark/subscription","commits_url":"https://api.github.com/repos/adrian-wang/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/adrian-wang/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/adrian-wang/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/adrian-wang/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/adrian-wang/spark/contents/{+path}","compare_url":"https://api.github.com/repos/adrian-wang/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adrian-wang/spark/merges","archive_url":"https://api.github.com/repos/adrian-wang/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adrian-wang/spark/downloads","issues_url":"https://api.github.com/repos/adrian-wang/spark/issues{/number}","pulls_url":"https://api.github.com/repos/adrian-wang/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/adrian-wang/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/adrian-wang/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adrian-wang/spark/labels{/name}","releases_url":"https://api.github.com/repos/adrian-wang/spark/releases{/id}","deployments_url":"https://api.github.com/repos/adrian-wang/spark/deployments","created_at":"2014-04-08T04:42:25Z","updated_at":"2018-05-18T06:01:24Z","pushed_at":"2018-11-27T06:19:55Z","git_url":"git://github.com/adrian-wang/spark.git","ssh_url":"git@github.com:adrian-wang/spark.git","clone_url":"https://github.com/adrian-wang/spark.git","svn_url":"https://github.com/adrian-wang/spark","homepage":null,"size":269869,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"85383d29ede19dd73949fe57cadb73ec94b29334","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE2NTY1OA==","name":"spark","full_name":"apache/spark","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2018-11-28T12:59:25Z","pushed_at":"2018-11-28T14:39:01Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":288059,"stargazers_count":19667,"watchers_count":19667,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17534,"mirror_url":null,"archived":false,"open_issues_count":510,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17534,"open_issues":510,"watchers":19667,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/23152"},"html":{"href":"https://github.com/apache/spark/pull/23152"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/23152"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/23152/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/23152/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/23152/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/1c1edccc43ac9cdb6da53ad93ac998b06bf8b6dd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"viirya"}}