{"action":"created","comment":{"url":"https://api.github.com/repos/metoppv/improver/pulls/comments/170725425","pull_request_review_id":99455287,"id":170725425,"diff_hunk":"@@ -0,0 +1,105 @@\n+# -*- coding: utf-8 -*-\n+# -----------------------------------------------------------------------------\n+# (C) British Crown Copyright 2017 Met Office.\n+# All rights reserved.\n+#\n+# Redistribution and use in source and binary forms, with or without\n+# modification, are permitted provided that the following conditions are met:\n+#\n+# * Redistributions of source code must retain the above copyright notice, this\n+#   list of conditions and the following disclaimer.\n+#\n+# * Redistributions in binary form must reproduce the above copyright notice,\n+#   this list of conditions and the following disclaimer in the documentation\n+#   and/or other materials provided with the distribution.\n+#\n+# * Neither the name of the copyright holder nor the names of its\n+#   contributors may be used to endorse or promote products derived from\n+#   this software without specific prior written permission.\n+#\n+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\"\n+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE\n+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE\n+# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE\n+# LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR\n+# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF\n+# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS\n+# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN\n+# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)\n+# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE\n+# POSSIBILITY OF SUCH DAMAGE.\n+\"\"\"Unit tests for plugin wind_downscaling.FrictionVelocity\"\"\"\n+\n+import unittest\n+import numpy as np\n+\n+from iris.tests import IrisTest\n+\n+from improver.constants import RMDI\n+from improver.wind_downscaling import FrictionVelocity\n+\n+\n+class Test_process(IrisTest):\n+\n+    \"\"\"Test the creation of friction velocity 2D arrays. Note that in the\n+    future, use of the Real Missing Data Indicator (RMDI) constant is due to be\n+    deprecated in favour of np.nan\"\"\"\n+","path":"lib/improver/tests/wind_downscaling/test_FrictionVelocity.py","position":47,"original_position":47,"commit_id":"840a0a80fcf05e1847489185be2ecd7010c02406","original_commit_id":"840a0a80fcf05e1847489185be2ecd7010c02406","user":{"login":"markysparks","id":20327097,"avatar_url":"https://avatars3.githubusercontent.com/u/20327097?v=4","gravatar_id":"","url":"https://api.github.com/users/markysparks","html_url":"https://github.com/markysparks","followers_url":"https://api.github.com/users/markysparks/followers","following_url":"https://api.github.com/users/markysparks/following{/other_user}","gists_url":"https://api.github.com/users/markysparks/gists{/gist_id}","starred_url":"https://api.github.com/users/markysparks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markysparks/subscriptions","organizations_url":"https://api.github.com/users/markysparks/orgs","repos_url":"https://api.github.com/users/markysparks/repos","events_url":"https://api.github.com/users/markysparks/events{/privacy}","received_events_url":"https://api.github.com/users/markysparks/received_events","type":"User","site_admin":false},"body":"Extended docstring to mention about future deprecation of RMDI","created_at":"2018-02-26T20:30:14Z","updated_at":"2018-02-26T20:30:14Z","html_url":"https://github.com/metoppv/improver/pull/432#discussion_r170725425","pull_request_url":"https://api.github.com/repos/metoppv/improver/pulls/432","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/metoppv/improver/pulls/comments/170725425"},"html":{"href":"https://github.com/metoppv/improver/pull/432#discussion_r170725425"},"pull_request":{"href":"https://api.github.com/repos/metoppv/improver/pulls/432"}}},"pull_request":{"url":"https://api.github.com/repos/metoppv/improver/pulls/432","id":171031658,"html_url":"https://github.com/metoppv/improver/pull/432","diff_url":"https://github.com/metoppv/improver/pull/432.diff","patch_url":"https://github.com/metoppv/improver/pull/432.patch","issue_url":"https://api.github.com/repos/metoppv/improver/issues/432","number":432,"state":"open","locked":false,"title":"Impro249: Friction velocity unit tests","user":{"login":"MarkWorsfold","id":35810969,"avatar_url":"https://avatars2.githubusercontent.com/u/35810969?v=4","gravatar_id":"","url":"https://api.github.com/users/MarkWorsfold","html_url":"https://github.com/MarkWorsfold","followers_url":"https://api.github.com/users/MarkWorsfold/followers","following_url":"https://api.github.com/users/MarkWorsfold/following{/other_user}","gists_url":"https://api.github.com/users/MarkWorsfold/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkWorsfold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkWorsfold/subscriptions","organizations_url":"https://api.github.com/users/MarkWorsfold/orgs","repos_url":"https://api.github.com/users/MarkWorsfold/repos","events_url":"https://api.github.com/users/MarkWorsfold/events{/privacy}","received_events_url":"https://api.github.com/users/MarkWorsfold/received_events","type":"User","site_admin":false},"body":"This addresses issue #19 concerning developing tests for the FrictionVelocity plugin of wind downscaling.\r\n\r\nIssue #19 \r\n\r\nTesting:\r\n - [x] Ran tests and they passed OK\r\n - [x] Added new tests for the new feature(s)\r\n\r\nCLA\r\n - [x] If a new developer, signed up to CLA\r\n","created_at":"2018-02-23T14:44:48Z","updated_at":"2018-02-26T20:30:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f9943b306368d4801d5963038f5c97ea69a9512","assignee":{"login":"MarkWorsfold","id":35810969,"avatar_url":"https://avatars2.githubusercontent.com/u/35810969?v=4","gravatar_id":"","url":"https://api.github.com/users/MarkWorsfold","html_url":"https://github.com/MarkWorsfold","followers_url":"https://api.github.com/users/MarkWorsfold/followers","following_url":"https://api.github.com/users/MarkWorsfold/following{/other_user}","gists_url":"https://api.github.com/users/MarkWorsfold/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkWorsfold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkWorsfold/subscriptions","organizations_url":"https://api.github.com/users/MarkWorsfold/orgs","repos_url":"https://api.github.com/users/MarkWorsfold/repos","events_url":"https://api.github.com/users/MarkWorsfold/events{/privacy}","received_events_url":"https://api.github.com/users/MarkWorsfold/received_events","type":"User","site_admin":false},"assignees":[{"login":"MarkWorsfold","id":35810969,"avatar_url":"https://avatars2.githubusercontent.com/u/35810969?v=4","gravatar_id":"","url":"https://api.github.com/users/MarkWorsfold","html_url":"https://github.com/MarkWorsfold","followers_url":"https://api.github.com/users/MarkWorsfold/followers","following_url":"https://api.github.com/users/MarkWorsfold/following{/other_user}","gists_url":"https://api.github.com/users/MarkWorsfold/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkWorsfold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkWorsfold/subscriptions","organizations_url":"https://api.github.com/users/MarkWorsfold/orgs","repos_url":"https://api.github.com/users/MarkWorsfold/repos","events_url":"https://api.github.com/users/MarkWorsfold/events{/privacy}","received_events_url":"https://api.github.com/users/MarkWorsfold/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/metoppv/improver/pulls/432/commits","review_comments_url":"https://api.github.com/repos/metoppv/improver/pulls/432/comments","review_comment_url":"https://api.github.com/repos/metoppv/improver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metoppv/improver/issues/432/comments","statuses_url":"https://api.github.com/repos/metoppv/improver/statuses/840a0a80fcf05e1847489185be2ecd7010c02406","head":{"label":"MarkWorsfold:IMPRO249","ref":"IMPRO249","sha":"840a0a80fcf05e1847489185be2ecd7010c02406","user":{"login":"MarkWorsfold","id":35810969,"avatar_url":"https://avatars2.githubusercontent.com/u/35810969?v=4","gravatar_id":"","url":"https://api.github.com/users/MarkWorsfold","html_url":"https://github.com/MarkWorsfold","followers_url":"https://api.github.com/users/MarkWorsfold/followers","following_url":"https://api.github.com/users/MarkWorsfold/following{/other_user}","gists_url":"https://api.github.com/users/MarkWorsfold/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkWorsfold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkWorsfold/subscriptions","organizations_url":"https://api.github.com/users/MarkWorsfold/orgs","repos_url":"https://api.github.com/users/MarkWorsfold/repos","events_url":"https://api.github.com/users/MarkWorsfold/events{/privacy}","received_events_url":"https://api.github.com/users/MarkWorsfold/received_events","type":"User","site_admin":false},"repo":{"id":120636183,"name":"improver","full_name":"MarkWorsfold/improver","owner":{"login":"MarkWorsfold","id":35810969,"avatar_url":"https://avatars2.githubusercontent.com/u/35810969?v=4","gravatar_id":"","url":"https://api.github.com/users/MarkWorsfold","html_url":"https://github.com/MarkWorsfold","followers_url":"https://api.github.com/users/MarkWorsfold/followers","following_url":"https://api.github.com/users/MarkWorsfold/following{/other_user}","gists_url":"https://api.github.com/users/MarkWorsfold/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkWorsfold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkWorsfold/subscriptions","organizations_url":"https://api.github.com/users/MarkWorsfold/orgs","repos_url":"https://api.github.com/users/MarkWorsfold/repos","events_url":"https://api.github.com/users/MarkWorsfold/events{/privacy}","received_events_url":"https://api.github.com/users/MarkWorsfold/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MarkWorsfold/improver","description":"IMPROVER is a library of algorithms for meteorological post-processing and verification.","fork":true,"url":"https://api.github.com/repos/MarkWorsfold/improver","forks_url":"https://api.github.com/repos/MarkWorsfold/improver/forks","keys_url":"https://api.github.com/repos/MarkWorsfold/improver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarkWorsfold/improver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarkWorsfold/improver/teams","hooks_url":"https://api.github.com/repos/MarkWorsfold/improver/hooks","issue_events_url":"https://api.github.com/repos/MarkWorsfold/improver/issues/events{/number}","events_url":"https://api.github.com/repos/MarkWorsfold/improver/events","assignees_url":"https://api.github.com/repos/MarkWorsfold/improver/assignees{/user}","branches_url":"https://api.github.com/repos/MarkWorsfold/improver/branches{/branch}","tags_url":"https://api.github.com/repos/MarkWorsfold/improver/tags","blobs_url":"https://api.github.com/repos/MarkWorsfold/improver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarkWorsfold/improver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarkWorsfold/improver/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarkWorsfold/improver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarkWorsfold/improver/statuses/{sha}","languages_url":"https://api.github.com/repos/MarkWorsfold/improver/languages","stargazers_url":"https://api.github.com/repos/MarkWorsfold/improver/stargazers","contributors_url":"https://api.github.com/repos/MarkWorsfold/improver/contributors","subscribers_url":"https://api.github.com/repos/MarkWorsfold/improver/subscribers","subscription_url":"https://api.github.com/repos/MarkWorsfold/improver/subscription","commits_url":"https://api.github.com/repos/MarkWorsfold/improver/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarkWorsfold/improver/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarkWorsfold/improver/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarkWorsfold/improver/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarkWorsfold/improver/contents/{+path}","compare_url":"https://api.github.com/repos/MarkWorsfold/improver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarkWorsfold/improver/merges","archive_url":"https://api.github.com/repos/MarkWorsfold/improver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarkWorsfold/improver/downloads","issues_url":"https://api.github.com/repos/MarkWorsfold/improver/issues{/number}","pulls_url":"https://api.github.com/repos/MarkWorsfold/improver/pulls{/number}","milestones_url":"https://api.github.com/repos/MarkWorsfold/improver/milestones{/number}","notifications_url":"https://api.github.com/repos/MarkWorsfold/improver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarkWorsfold/improver/labels{/name}","releases_url":"https://api.github.com/repos/MarkWorsfold/improver/releases{/id}","deployments_url":"https://api.github.com/repos/MarkWorsfold/improver/deployments","created_at":"2018-02-07T15:53:28Z","updated_at":"2018-02-07T15:53:30Z","pushed_at":"2018-02-26T20:29:11Z","git_url":"git://github.com/MarkWorsfold/improver.git","ssh_url":"git@github.com:MarkWorsfold/improver.git","clone_url":"https://github.com/MarkWorsfold/improver.git","svn_url":"https://github.com/MarkWorsfold/improver","homepage":"http://improver.readthedocs.io/en/latest/","size":2836,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"metoppv:master","ref":"master","sha":"4fbef69bcd0c8ba5ab8546ccdce8770ce9030345","user":{"login":"metoppv","id":26465485,"avatar_url":"https://avatars2.githubusercontent.com/u/26465485?v=4","gravatar_id":"","url":"https://api.github.com/users/metoppv","html_url":"https://github.com/metoppv","followers_url":"https://api.github.com/users/metoppv/followers","following_url":"https://api.github.com/users/metoppv/following{/other_user}","gists_url":"https://api.github.com/users/metoppv/gists{/gist_id}","starred_url":"https://api.github.com/users/metoppv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metoppv/subscriptions","organizations_url":"https://api.github.com/users/metoppv/orgs","repos_url":"https://api.github.com/users/metoppv/repos","events_url":"https://api.github.com/users/metoppv/events{/privacy}","received_events_url":"https://api.github.com/users/metoppv/received_events","type":"Organization","site_admin":false},"repo":{"id":85334761,"name":"improver","full_name":"metoppv/improver","owner":{"login":"metoppv","id":26465485,"avatar_url":"https://avatars2.githubusercontent.com/u/26465485?v=4","gravatar_id":"","url":"https://api.github.com/users/metoppv","html_url":"https://github.com/metoppv","followers_url":"https://api.github.com/users/metoppv/followers","following_url":"https://api.github.com/users/metoppv/following{/other_user}","gists_url":"https://api.github.com/users/metoppv/gists{/gist_id}","starred_url":"https://api.github.com/users/metoppv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metoppv/subscriptions","organizations_url":"https://api.github.com/users/metoppv/orgs","repos_url":"https://api.github.com/users/metoppv/repos","events_url":"https://api.github.com/users/metoppv/events{/privacy}","received_events_url":"https://api.github.com/users/metoppv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metoppv/improver","description":"IMPROVER is a library of algorithms for meteorological post-processing and verification.","fork":false,"url":"https://api.github.com/repos/metoppv/improver","forks_url":"https://api.github.com/repos/metoppv/improver/forks","keys_url":"https://api.github.com/repos/metoppv/improver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metoppv/improver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metoppv/improver/teams","hooks_url":"https://api.github.com/repos/metoppv/improver/hooks","issue_events_url":"https://api.github.com/repos/metoppv/improver/issues/events{/number}","events_url":"https://api.github.com/repos/metoppv/improver/events","assignees_url":"https://api.github.com/repos/metoppv/improver/assignees{/user}","branches_url":"https://api.github.com/repos/metoppv/improver/branches{/branch}","tags_url":"https://api.github.com/repos/metoppv/improver/tags","blobs_url":"https://api.github.com/repos/metoppv/improver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metoppv/improver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metoppv/improver/git/refs{/sha}","trees_url":"https://api.github.com/repos/metoppv/improver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metoppv/improver/statuses/{sha}","languages_url":"https://api.github.com/repos/metoppv/improver/languages","stargazers_url":"https://api.github.com/repos/metoppv/improver/stargazers","contributors_url":"https://api.github.com/repos/metoppv/improver/contributors","subscribers_url":"https://api.github.com/repos/metoppv/improver/subscribers","subscription_url":"https://api.github.com/repos/metoppv/improver/subscription","commits_url":"https://api.github.com/repos/metoppv/improver/commits{/sha}","git_commits_url":"https://api.github.com/repos/metoppv/improver/git/commits{/sha}","comments_url":"https://api.github.com/repos/metoppv/improver/comments{/number}","issue_comment_url":"https://api.github.com/repos/metoppv/improver/issues/comments{/number}","contents_url":"https://api.github.com/repos/metoppv/improver/contents/{+path}","compare_url":"https://api.github.com/repos/metoppv/improver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metoppv/improver/merges","archive_url":"https://api.github.com/repos/metoppv/improver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metoppv/improver/downloads","issues_url":"https://api.github.com/repos/metoppv/improver/issues{/number}","pulls_url":"https://api.github.com/repos/metoppv/improver/pulls{/number}","milestones_url":"https://api.github.com/repos/metoppv/improver/milestones{/number}","notifications_url":"https://api.github.com/repos/metoppv/improver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metoppv/improver/labels{/name}","releases_url":"https://api.github.com/repos/metoppv/improver/releases{/id}","deployments_url":"https://api.github.com/repos/metoppv/improver/deployments","created_at":"2017-03-17T16:51:29Z","updated_at":"2018-01-23T14:42:19Z","pushed_at":"2018-02-26T20:29:13Z","git_url":"git://github.com/metoppv/improver.git","ssh_url":"git@github.com:metoppv/improver.git","clone_url":"https://github.com/metoppv/improver.git","svn_url":"https://github.com/metoppv/improver","homepage":"http://improver.readthedocs.io/en/latest/","size":2861,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":104,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":24,"open_issues":104,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metoppv/improver/pulls/432"},"html":{"href":"https://github.com/metoppv/improver/pull/432"},"issue":{"href":"https://api.github.com/repos/metoppv/improver/issues/432"},"comments":{"href":"https://api.github.com/repos/metoppv/improver/issues/432/comments"},"review_comments":{"href":"https://api.github.com/repos/metoppv/improver/pulls/432/comments"},"review_comment":{"href":"https://api.github.com/repos/metoppv/improver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metoppv/improver/pulls/432/commits"},"statuses":{"href":"https://api.github.com/repos/metoppv/improver/statuses/840a0a80fcf05e1847489185be2ecd7010c02406"}},"author_association":"NONE"}}
{"actor":{"display_login":"markysparks"}}