{"action":"created","comment":{"url":"https://api.github.com/repos/as-ideas/oil/pulls/comments/223296326","pull_request_review_id":162384674,"id":223296326,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzI5NjMyNg==","diff_hunk":"@@ -13,27 +13,29 @@ export let cachedVendorList;\n export let pendingVendorlistPromise = null;\n \n export function loadVendorList() {\n-  return new Promise(function (resolve) {\n-    if (cachedVendorList) {\n-      resolve(cachedVendorList);\n-    } else if (pendingVendorlistPromise) {\n-      resolve(pendingVendorlistPromise);\n-    } else {\n-      let iabVendorListUrl = getIabVendorListUrl();\n-      pendingVendorlistPromise = fetchJsonData(iabVendorListUrl)\n-      pendingVendorlistPromise.then(response => {\n-          cachedVendorList = response;\n-          pendingVendorlistPromise = null;\n-          sortVendors(cachedVendorList);\n-          resolve(cachedVendorList);\n-        })\n-        .catch(error => {\n-          pendingVendorlistPromise = null;\n-          logError(`OIL getVendorList failed and returned error: ${error}. Falling back to default vendor list!`);\n-          resolve(getVendorList());\n-        });\n-    }\n-  });\n+  if (pendingVendorlistPromise) {\n+    return pendingVendorlistPromise;\n+  } else if (cachedVendorList) {\n+    return new Promise(function (resolve) {\n+      resolve(cachedVendorList); ","path":"src/scripts/core/core_vendor_information.js","position":29,"original_position":29,"commit_id":"be67242c9e83236f169bfcfff78731833de25259","original_commit_id":"be67242c9e83236f169bfcfff78731833de25259","user":{"login":"ltparis2018","id":35994641,"node_id":"MDQ6VXNlcjM1OTk0NjQx","avatar_url":"https://avatars1.githubusercontent.com/u/35994641?v=4","gravatar_id":"","url":"https://api.github.com/users/ltparis2018","html_url":"https://github.com/ltparis2018","followers_url":"https://api.github.com/users/ltparis2018/followers","following_url":"https://api.github.com/users/ltparis2018/following{/other_user}","gists_url":"https://api.github.com/users/ltparis2018/gists{/gist_id}","starred_url":"https://api.github.com/users/ltparis2018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltparis2018/subscriptions","organizations_url":"https://api.github.com/users/ltparis2018/orgs","repos_url":"https://api.github.com/users/ltparis2018/repos","events_url":"https://api.github.com/users/ltparis2018/events{/privacy}","received_events_url":"https://api.github.com/users/ltparis2018/received_events","type":"User","site_admin":false},"body":"Please use consistent function definition. Line 19 and 23 use \"function() {}\", line 26 use an arrow function.","created_at":"2018-10-08T09:15:19Z","updated_at":"2018-10-08T09:38:48Z","html_url":"https://github.com/as-ideas/oil/pull/215#discussion_r223296326","pull_request_url":"https://api.github.com/repos/as-ideas/oil/pulls/215","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/as-ideas/oil/pulls/comments/223296326"},"html":{"href":"https://github.com/as-ideas/oil/pull/215#discussion_r223296326"},"pull_request":{"href":"https://api.github.com/repos/as-ideas/oil/pulls/215"}}},"pull_request":{"url":"https://api.github.com/repos/as-ideas/oil/pulls/215","id":220691532,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNjkxNTMy","html_url":"https://github.com/as-ideas/oil/pull/215","diff_url":"https://github.com/as-ideas/oil/pull/215.diff","patch_url":"https://github.com/as-ideas/oil/pull/215.patch","issue_url":"https://api.github.com/repos/as-ideas/oil/issues/215","number":215,"state":"open","locked":false,"title":"Oil 292/load vendor list refactoring","user":{"login":"TimonBerlin","id":43786350,"node_id":"MDQ6VXNlcjQzNzg2MzUw","avatar_url":"https://avatars2.githubusercontent.com/u/43786350?v=4","gravatar_id":"","url":"https://api.github.com/users/TimonBerlin","html_url":"https://github.com/TimonBerlin","followers_url":"https://api.github.com/users/TimonBerlin/followers","following_url":"https://api.github.com/users/TimonBerlin/following{/other_user}","gists_url":"https://api.github.com/users/TimonBerlin/gists{/gist_id}","starred_url":"https://api.github.com/users/TimonBerlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimonBerlin/subscriptions","organizations_url":"https://api.github.com/users/TimonBerlin/orgs","repos_url":"https://api.github.com/users/TimonBerlin/repos","events_url":"https://api.github.com/users/TimonBerlin/events{/privacy}","received_events_url":"https://api.github.com/users/TimonBerlin/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-05T12:53:14Z","updated_at":"2018-10-08T09:38:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70bb4693444d1b622133a1b3e0a01b6ad88979a0","assignee":{"login":"subsend","id":1379905,"node_id":"MDQ6VXNlcjEzNzk5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1379905?v=4","gravatar_id":"","url":"https://api.github.com/users/subsend","html_url":"https://github.com/subsend","followers_url":"https://api.github.com/users/subsend/followers","following_url":"https://api.github.com/users/subsend/following{/other_user}","gists_url":"https://api.github.com/users/subsend/gists{/gist_id}","starred_url":"https://api.github.com/users/subsend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/subsend/subscriptions","organizations_url":"https://api.github.com/users/subsend/orgs","repos_url":"https://api.github.com/users/subsend/repos","events_url":"https://api.github.com/users/subsend/events{/privacy}","received_events_url":"https://api.github.com/users/subsend/received_events","type":"User","site_admin":false},"assignees":[{"login":"subsend","id":1379905,"node_id":"MDQ6VXNlcjEzNzk5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1379905?v=4","gravatar_id":"","url":"https://api.github.com/users/subsend","html_url":"https://github.com/subsend","followers_url":"https://api.github.com/users/subsend/followers","following_url":"https://api.github.com/users/subsend/following{/other_user}","gists_url":"https://api.github.com/users/subsend/gists{/gist_id}","starred_url":"https://api.github.com/users/subsend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/subsend/subscriptions","organizations_url":"https://api.github.com/users/subsend/orgs","repos_url":"https://api.github.com/users/subsend/repos","events_url":"https://api.github.com/users/subsend/events{/privacy}","received_events_url":"https://api.github.com/users/subsend/received_events","type":"User","site_admin":false},{"login":"tbtz","id":9198250,"node_id":"MDQ6VXNlcjkxOTgyNTA=","avatar_url":"https://avatars0.githubusercontent.com/u/9198250?v=4","gravatar_id":"","url":"https://api.github.com/users/tbtz","html_url":"https://github.com/tbtz","followers_url":"https://api.github.com/users/tbtz/followers","following_url":"https://api.github.com/users/tbtz/following{/other_user}","gists_url":"https://api.github.com/users/tbtz/gists{/gist_id}","starred_url":"https://api.github.com/users/tbtz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbtz/subscriptions","organizations_url":"https://api.github.com/users/tbtz/orgs","repos_url":"https://api.github.com/users/tbtz/repos","events_url":"https://api.github.com/users/tbtz/events{/privacy}","received_events_url":"https://api.github.com/users/tbtz/received_events","type":"User","site_admin":false},{"login":"ltparis2018","id":35994641,"node_id":"MDQ6VXNlcjM1OTk0NjQx","avatar_url":"https://avatars1.githubusercontent.com/u/35994641?v=4","gravatar_id":"","url":"https://api.github.com/users/ltparis2018","html_url":"https://github.com/ltparis2018","followers_url":"https://api.github.com/users/ltparis2018/followers","following_url":"https://api.github.com/users/ltparis2018/following{/other_user}","gists_url":"https://api.github.com/users/ltparis2018/gists{/gist_id}","starred_url":"https://api.github.com/users/ltparis2018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltparis2018/subscriptions","organizations_url":"https://api.github.com/users/ltparis2018/orgs","repos_url":"https://api.github.com/users/ltparis2018/repos","events_url":"https://api.github.com/users/ltparis2018/events{/privacy}","received_events_url":"https://api.github.com/users/ltparis2018/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/as-ideas/oil/pulls/215/commits","review_comments_url":"https://api.github.com/repos/as-ideas/oil/pulls/215/comments","review_comment_url":"https://api.github.com/repos/as-ideas/oil/pulls/comments{/number}","comments_url":"https://api.github.com/repos/as-ideas/oil/issues/215/comments","statuses_url":"https://api.github.com/repos/as-ideas/oil/statuses/be67242c9e83236f169bfcfff78731833de25259","head":{"label":"as-ideas:OIL-292/loadVendorListRefactoring","ref":"OIL-292/loadVendorListRefactoring","sha":"be67242c9e83236f169bfcfff78731833de25259","user":{"login":"as-ideas","id":6329093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzMjkwOTM=","avatar_url":"https://avatars2.githubusercontent.com/u/6329093?v=4","gravatar_id":"","url":"https://api.github.com/users/as-ideas","html_url":"https://github.com/as-ideas","followers_url":"https://api.github.com/users/as-ideas/followers","following_url":"https://api.github.com/users/as-ideas/following{/other_user}","gists_url":"https://api.github.com/users/as-ideas/gists{/gist_id}","starred_url":"https://api.github.com/users/as-ideas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/as-ideas/subscriptions","organizations_url":"https://api.github.com/users/as-ideas/orgs","repos_url":"https://api.github.com/users/as-ideas/repos","events_url":"https://api.github.com/users/as-ideas/events{/privacy}","received_events_url":"https://api.github.com/users/as-ideas/received_events","type":"Organization","site_admin":false},"repo":{"id":87075311,"node_id":"MDEwOlJlcG9zaXRvcnk4NzA3NTMxMQ==","name":"oil","full_name":"as-ideas/oil","private":false,"owner":{"login":"as-ideas","id":6329093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzMjkwOTM=","avatar_url":"https://avatars2.githubusercontent.com/u/6329093?v=4","gravatar_id":"","url":"https://api.github.com/users/as-ideas","html_url":"https://github.com/as-ideas","followers_url":"https://api.github.com/users/as-ideas/followers","following_url":"https://api.github.com/users/as-ideas/following{/other_user}","gists_url":"https://api.github.com/users/as-ideas/gists{/gist_id}","starred_url":"https://api.github.com/users/as-ideas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/as-ideas/subscriptions","organizations_url":"https://api.github.com/users/as-ideas/orgs","repos_url":"https://api.github.com/users/as-ideas/repos","events_url":"https://api.github.com/users/as-ideas/events{/privacy}","received_events_url":"https://api.github.com/users/as-ideas/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/as-ideas/oil","description":"Open Source GPDR Consent Management Provider (CMP), Opt-In Layer (oil.js), supports the IAB Framework","fork":false,"url":"https://api.github.com/repos/as-ideas/oil","forks_url":"https://api.github.com/repos/as-ideas/oil/forks","keys_url":"https://api.github.com/repos/as-ideas/oil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/as-ideas/oil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/as-ideas/oil/teams","hooks_url":"https://api.github.com/repos/as-ideas/oil/hooks","issue_events_url":"https://api.github.com/repos/as-ideas/oil/issues/events{/number}","events_url":"https://api.github.com/repos/as-ideas/oil/events","assignees_url":"https://api.github.com/repos/as-ideas/oil/assignees{/user}","branches_url":"https://api.github.com/repos/as-ideas/oil/branches{/branch}","tags_url":"https://api.github.com/repos/as-ideas/oil/tags","blobs_url":"https://api.github.com/repos/as-ideas/oil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/as-ideas/oil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/as-ideas/oil/git/refs{/sha}","trees_url":"https://api.github.com/repos/as-ideas/oil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/as-ideas/oil/statuses/{sha}","languages_url":"https://api.github.com/repos/as-ideas/oil/languages","stargazers_url":"https://api.github.com/repos/as-ideas/oil/stargazers","contributors_url":"https://api.github.com/repos/as-ideas/oil/contributors","subscribers_url":"https://api.github.com/repos/as-ideas/oil/subscribers","subscription_url":"https://api.github.com/repos/as-ideas/oil/subscription","commits_url":"https://api.github.com/repos/as-ideas/oil/commits{/sha}","git_commits_url":"https://api.github.com/repos/as-ideas/oil/git/commits{/sha}","comments_url":"https://api.github.com/repos/as-ideas/oil/comments{/number}","issue_comment_url":"https://api.github.com/repos/as-ideas/oil/issues/comments{/number}","contents_url":"https://api.github.com/repos/as-ideas/oil/contents/{+path}","compare_url":"https://api.github.com/repos/as-ideas/oil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/as-ideas/oil/merges","archive_url":"https://api.github.com/repos/as-ideas/oil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/as-ideas/oil/downloads","issues_url":"https://api.github.com/repos/as-ideas/oil/issues{/number}","pulls_url":"https://api.github.com/repos/as-ideas/oil/pulls{/number}","milestones_url":"https://api.github.com/repos/as-ideas/oil/milestones{/number}","notifications_url":"https://api.github.com/repos/as-ideas/oil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/as-ideas/oil/labels{/name}","releases_url":"https://api.github.com/repos/as-ideas/oil/releases{/id}","deployments_url":"https://api.github.com/repos/as-ideas/oil/deployments","created_at":"2017-04-03T13:10:00Z","updated_at":"2018-10-06T18:43:44Z","pushed_at":"2018-10-05T12:53:14Z","git_url":"git://github.com/as-ideas/oil.git","ssh_url":"git@github.com:as-ideas/oil.git","clone_url":"https://github.com/as-ideas/oil.git","svn_url":"https://github.com/as-ideas/oil","homepage":"https://www.oiljs.org","size":27102,"stargazers_count":60,"watchers_count":60,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":16,"open_issues":11,"watchers":60,"default_branch":"master"}},"base":{"label":"as-ideas:master","ref":"master","sha":"2d49f871aaca63eef31e5924ea5e6a516649daf0","user":{"login":"as-ideas","id":6329093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzMjkwOTM=","avatar_url":"https://avatars2.githubusercontent.com/u/6329093?v=4","gravatar_id":"","url":"https://api.github.com/users/as-ideas","html_url":"https://github.com/as-ideas","followers_url":"https://api.github.com/users/as-ideas/followers","following_url":"https://api.github.com/users/as-ideas/following{/other_user}","gists_url":"https://api.github.com/users/as-ideas/gists{/gist_id}","starred_url":"https://api.github.com/users/as-ideas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/as-ideas/subscriptions","organizations_url":"https://api.github.com/users/as-ideas/orgs","repos_url":"https://api.github.com/users/as-ideas/repos","events_url":"https://api.github.com/users/as-ideas/events{/privacy}","received_events_url":"https://api.github.com/users/as-ideas/received_events","type":"Organization","site_admin":false},"repo":{"id":87075311,"node_id":"MDEwOlJlcG9zaXRvcnk4NzA3NTMxMQ==","name":"oil","full_name":"as-ideas/oil","private":false,"owner":{"login":"as-ideas","id":6329093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzMjkwOTM=","avatar_url":"https://avatars2.githubusercontent.com/u/6329093?v=4","gravatar_id":"","url":"https://api.github.com/users/as-ideas","html_url":"https://github.com/as-ideas","followers_url":"https://api.github.com/users/as-ideas/followers","following_url":"https://api.github.com/users/as-ideas/following{/other_user}","gists_url":"https://api.github.com/users/as-ideas/gists{/gist_id}","starred_url":"https://api.github.com/users/as-ideas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/as-ideas/subscriptions","organizations_url":"https://api.github.com/users/as-ideas/orgs","repos_url":"https://api.github.com/users/as-ideas/repos","events_url":"https://api.github.com/users/as-ideas/events{/privacy}","received_events_url":"https://api.github.com/users/as-ideas/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/as-ideas/oil","description":"Open Source GPDR Consent Management Provider (CMP), Opt-In Layer (oil.js), supports the IAB Framework","fork":false,"url":"https://api.github.com/repos/as-ideas/oil","forks_url":"https://api.github.com/repos/as-ideas/oil/forks","keys_url":"https://api.github.com/repos/as-ideas/oil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/as-ideas/oil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/as-ideas/oil/teams","hooks_url":"https://api.github.com/repos/as-ideas/oil/hooks","issue_events_url":"https://api.github.com/repos/as-ideas/oil/issues/events{/number}","events_url":"https://api.github.com/repos/as-ideas/oil/events","assignees_url":"https://api.github.com/repos/as-ideas/oil/assignees{/user}","branches_url":"https://api.github.com/repos/as-ideas/oil/branches{/branch}","tags_url":"https://api.github.com/repos/as-ideas/oil/tags","blobs_url":"https://api.github.com/repos/as-ideas/oil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/as-ideas/oil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/as-ideas/oil/git/refs{/sha}","trees_url":"https://api.github.com/repos/as-ideas/oil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/as-ideas/oil/statuses/{sha}","languages_url":"https://api.github.com/repos/as-ideas/oil/languages","stargazers_url":"https://api.github.com/repos/as-ideas/oil/stargazers","contributors_url":"https://api.github.com/repos/as-ideas/oil/contributors","subscribers_url":"https://api.github.com/repos/as-ideas/oil/subscribers","subscription_url":"https://api.github.com/repos/as-ideas/oil/subscription","commits_url":"https://api.github.com/repos/as-ideas/oil/commits{/sha}","git_commits_url":"https://api.github.com/repos/as-ideas/oil/git/commits{/sha}","comments_url":"https://api.github.com/repos/as-ideas/oil/comments{/number}","issue_comment_url":"https://api.github.com/repos/as-ideas/oil/issues/comments{/number}","contents_url":"https://api.github.com/repos/as-ideas/oil/contents/{+path}","compare_url":"https://api.github.com/repos/as-ideas/oil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/as-ideas/oil/merges","archive_url":"https://api.github.com/repos/as-ideas/oil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/as-ideas/oil/downloads","issues_url":"https://api.github.com/repos/as-ideas/oil/issues{/number}","pulls_url":"https://api.github.com/repos/as-ideas/oil/pulls{/number}","milestones_url":"https://api.github.com/repos/as-ideas/oil/milestones{/number}","notifications_url":"https://api.github.com/repos/as-ideas/oil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/as-ideas/oil/labels{/name}","releases_url":"https://api.github.com/repos/as-ideas/oil/releases{/id}","deployments_url":"https://api.github.com/repos/as-ideas/oil/deployments","created_at":"2017-04-03T13:10:00Z","updated_at":"2018-10-06T18:43:44Z","pushed_at":"2018-10-05T12:53:14Z","git_url":"git://github.com/as-ideas/oil.git","ssh_url":"git@github.com:as-ideas/oil.git","clone_url":"https://github.com/as-ideas/oil.git","svn_url":"https://github.com/as-ideas/oil","homepage":"https://www.oiljs.org","size":27102,"stargazers_count":60,"watchers_count":60,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":16,"open_issues":11,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/as-ideas/oil/pulls/215"},"html":{"href":"https://github.com/as-ideas/oil/pull/215"},"issue":{"href":"https://api.github.com/repos/as-ideas/oil/issues/215"},"comments":{"href":"https://api.github.com/repos/as-ideas/oil/issues/215/comments"},"review_comments":{"href":"https://api.github.com/repos/as-ideas/oil/pulls/215/comments"},"review_comment":{"href":"https://api.github.com/repos/as-ideas/oil/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/as-ideas/oil/pulls/215/commits"},"statuses":{"href":"https://api.github.com/repos/as-ideas/oil/statuses/be67242c9e83236f169bfcfff78731833de25259"}},"author_association":"NONE"}}
{"actor":{"display_login":"ltparis2018"}}