{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/15891","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/15891/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/15891/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/15891/events","html_url":"https://github.com/magento/magento2/pull/15891","id":329805078,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyOTY1Mzgy","number":15891,"title":"Remove parameter from method calling","user":{"login":"saurabh-aureate","id":38528863,"node_id":"MDQ6VXNlcjM4NTI4ODYz","avatar_url":"https://avatars0.githubusercontent.com/u/38528863?v=4","gravatar_id":"","url":"https://api.github.com/users/saurabh-aureate","html_url":"https://github.com/saurabh-aureate","followers_url":"https://api.github.com/users/saurabh-aureate/followers","following_url":"https://api.github.com/users/saurabh-aureate/following{/other_user}","gists_url":"https://api.github.com/users/saurabh-aureate/gists{/gist_id}","starred_url":"https://api.github.com/users/saurabh-aureate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saurabh-aureate/subscriptions","organizations_url":"https://api.github.com/users/saurabh-aureate/orgs","repos_url":"https://api.github.com/users/saurabh-aureate/repos","events_url":"https://api.github.com/users/saurabh-aureate/events{/privacy}","received_events_url":"https://api.github.com/users/saurabh-aureate/received_events","type":"User","site_admin":false},"labels":[{"id":703232382,"node_id":"MDU6TGFiZWw3MDMyMzIzODI=","url":"https://api.github.com/repos/magento/magento2/labels/2.2-develop","name":"2.2-develop","color":"fbca04","default":false},{"id":953817359,"node_id":"MDU6TGFiZWw5NTM4MTczNTk=","url":"https://api.github.com/repos/magento/magento2/labels/Component:%20UrlRewrite","name":"Component: UrlRewrite","color":"7fb703","default":false},{"id":164491159,"node_id":"MDU6TGFiZWwxNjQ0OTExNTk=","url":"https://api.github.com/repos/magento/magento2/labels/accept","name":"accept","color":"009800","default":false}],"state":"closed","locked":false,"assignee":{"login":"sidolov","id":11355520,"node_id":"MDQ6VXNlcjExMzU1NTIw","avatar_url":"https://avatars3.githubusercontent.com/u/11355520?v=4","gravatar_id":"","url":"https://api.github.com/users/sidolov","html_url":"https://github.com/sidolov","followers_url":"https://api.github.com/users/sidolov/followers","following_url":"https://api.github.com/users/sidolov/following{/other_user}","gists_url":"https://api.github.com/users/sidolov/gists{/gist_id}","starred_url":"https://api.github.com/users/sidolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidolov/subscriptions","organizations_url":"https://api.github.com/users/sidolov/orgs","repos_url":"https://api.github.com/users/sidolov/repos","events_url":"https://api.github.com/users/sidolov/events{/privacy}","received_events_url":"https://api.github.com/users/sidolov/received_events","type":"User","site_admin":false},"assignees":[{"login":"sidolov","id":11355520,"node_id":"MDQ6VXNlcjExMzU1NTIw","avatar_url":"https://avatars3.githubusercontent.com/u/11355520?v=4","gravatar_id":"","url":"https://api.github.com/users/sidolov","html_url":"https://github.com/sidolov","followers_url":"https://api.github.com/users/sidolov/followers","following_url":"https://api.github.com/users/sidolov/following{/other_user}","gists_url":"https://api.github.com/users/sidolov/gists{/gist_id}","starred_url":"https://api.github.com/users/sidolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidolov/subscriptions","organizations_url":"https://api.github.com/users/sidolov/orgs","repos_url":"https://api.github.com/users/sidolov/repos","events_url":"https://api.github.com/users/sidolov/events{/privacy}","received_events_url":"https://api.github.com/users/sidolov/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/magento/magento2/milestones/20","html_url":"https://github.com/magento/magento2/milestone/20","labels_url":"https://api.github.com/repos/magento/magento2/milestones/20/labels","id":3383796,"node_id":"MDk6TWlsZXN0b25lMzM4Mzc5Ng==","number":20,"title":"Release: 2.2.6","description":"Community pull requests delivered to Release: 2.2.6 release","creator":{"login":"magento-engcom-team","id":31669971,"node_id":"MDQ6VXNlcjMxNjY5OTcx","avatar_url":"https://avatars1.githubusercontent.com/u/31669971?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-engcom-team","html_url":"https://github.com/magento-engcom-team","followers_url":"https://api.github.com/users/magento-engcom-team/followers","following_url":"https://api.github.com/users/magento-engcom-team/following{/other_user}","gists_url":"https://api.github.com/users/magento-engcom-team/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-engcom-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-engcom-team/subscriptions","organizations_url":"https://api.github.com/users/magento-engcom-team/orgs","repos_url":"https://api.github.com/users/magento-engcom-team/repos","events_url":"https://api.github.com/users/magento-engcom-team/events{/privacy}","received_events_url":"https://api.github.com/users/magento-engcom-team/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":42,"state":"open","created_at":"2018-05-29T11:52:10Z","updated_at":"2018-06-07T17:05:54Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-06-06T10:16:21Z","updated_at":"2018-06-07T17:06:06Z","closed_at":"2018-06-07T17:05:54Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/15891","html_url":"https://github.com/magento/magento2/pull/15891","diff_url":"https://github.com/magento/magento2/pull/15891.diff","patch_url":"https://github.com/magento/magento2/pull/15891.patch"},"body":"\r\n<!---\r\n    Thank you for contributing to Magento.\r\n    To help us process this pull request we recommend that you add the following information:\r\n     - Summary of the pull request,\r\n     - Issue(s) related to the changes made,\r\n     - Manual testing scenarios,\r\n-->\r\nRemove parameter from method calling\r\n<!--- Please provide a general summary of the Pull Request in the Title above -->\r\n\r\n### Description\r\n<!---\r\n    Please provide a description of the changes proposed in the pull request.\r\n    Letting us know what has changed and why it needed changing will help us validate this pull request.\r\n-->\r\nMethod definition does not require any parameters. But when it was actually called extra parameter was passed. I remove extra parameter while calling method.\r\n\r\n### Fixed Issues (if relevant)\r\n<!---\r\n    If relevant, please provide a list of fixed issues in the format magento/magento2#<issue_number>.\r\n    There could be 1 or more issues linked here and it will help us find some more information about the reasoning behind this change.\r\n-->\r\nN/A\r\n\r\n### Manual testing scenarios\r\n<!---\r\n    Please provide a set of unambiguous steps to test the proposed code change.\r\n    Giving us manual testing scenarios will help with the processing and validation process.\r\n-->\r\n1 You can check at magento admin panel -> Marketing -> SEO & Search -> URL Rewrites -> Add/Edit with product.\r\n\r\n### Contribution checklist\r\n - [ ] Pull request has a meaningful description of its purpose\r\n - [ ] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds on Travis CI are green)\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/395494776","html_url":"https://github.com/magento/magento2/pull/15891#issuecomment-395494776","issue_url":"https://api.github.com/repos/magento/magento2/issues/15891","id":395494776,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTQ5NDc3Ng==","user":{"login":"magento-engcom-team","id":31669971,"node_id":"MDQ6VXNlcjMxNjY5OTcx","avatar_url":"https://avatars1.githubusercontent.com/u/31669971?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-engcom-team","html_url":"https://github.com/magento-engcom-team","followers_url":"https://api.github.com/users/magento-engcom-team/followers","following_url":"https://api.github.com/users/magento-engcom-team/following{/other_user}","gists_url":"https://api.github.com/users/magento-engcom-team/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-engcom-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-engcom-team/subscriptions","organizations_url":"https://api.github.com/users/magento-engcom-team/orgs","repos_url":"https://api.github.com/users/magento-engcom-team/repos","events_url":"https://api.github.com/users/magento-engcom-team/events{/privacy}","received_events_url":"https://api.github.com/users/magento-engcom-team/received_events","type":"User","site_admin":false},"created_at":"2018-06-07T17:06:06Z","updated_at":"2018-06-07T17:06:06Z","author_association":"CONTRIBUTOR","body":"Hi @saurabh-aureate. Thank you for your contribution. \nChanges from your Pull Request will be available with the upcoming 2.2.6 release.\n\nPlease, consider to port this solution to 2.3 release line.\nYou may use [Porting tool](https://github.com/magento/magento2/wiki/Simple-way-to-port-your-solutions-automatically) to port commits automatically."}}
{"actor":{"display_login":"magento-engcom-team"}}