{"action":"created","comment":{"url":"https://api.github.com/repos/status-im/status-go/pulls/comments/200628504","pull_request_review_id":134982453,"id":200628504,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDYyODUwNA==","diff_hunk":"@@ -0,0 +1,52 @@\n+package peers\n+\n+import (\n+\t\"time\"\n+\n+\t\"github.com/ethereum/go-ethereum/p2p\"\n+\t\"github.com/ethereum/go-ethereum/p2p/discover\"\n+\t\"github.com/ethereum/go-ethereum/p2p/discv5\"\n+\t\"github.com/status-im/status-go/params\"\n+\t\"github.com/status-im/status-go/signal\"\n+)\n+\n+// MailServerDiscoveryTopic topic name for mailserver discovery.\n+const MailServerDiscoveryTopic = \"mailserver.discovery\"\n+\n+// MailServerDiscoveryLimits default mailserver discovery limits.\n+var MailServerDiscoveryLimits = params.Limits{Min: 2, Max: 3}","path":"peers/mstopicpool.go","position":17,"original_position":17,"commit_id":"c23ef68021eaad1dd16aaf401b56260257749604","original_commit_id":"c23ef68021eaad1dd16aaf401b56260257749604","user":{"login":"adriacidre","id":593270,"node_id":"MDQ6VXNlcjU5MzI3MA==","avatar_url":"https://avatars2.githubusercontent.com/u/593270?v=4","gravatar_id":"","url":"https://api.github.com/users/adriacidre","html_url":"https://github.com/adriacidre","followers_url":"https://api.github.com/users/adriacidre/followers","following_url":"https://api.github.com/users/adriacidre/following{/other_user}","gists_url":"https://api.github.com/users/adriacidre/gists{/gist_id}","starred_url":"https://api.github.com/users/adriacidre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriacidre/subscriptions","organizations_url":"https://api.github.com/users/adriacidre/orgs","repos_url":"https://api.github.com/users/adriacidre/repos","events_url":"https://api.github.com/users/adriacidre/events{/privacy}","received_events_url":"https://api.github.com/users/adriacidre/received_events","type":"User","site_admin":false},"body":"@dshulyak could you please point me where min and max on mobile are defined?","created_at":"2018-07-06T11:41:09Z","updated_at":"2018-07-06T11:41:09Z","html_url":"https://github.com/status-im/status-go/pull/1082#discussion_r200628504","pull_request_url":"https://api.github.com/repos/status-im/status-go/pulls/1082","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/status-im/status-go/pulls/comments/200628504"},"html":{"href":"https://github.com/status-im/status-go/pull/1082#discussion_r200628504"},"pull_request":{"href":"https://api.github.com/repos/status-im/status-go/pulls/1082"}},"in_reply_to_id":200610285},"pull_request":{"url":"https://api.github.com/repos/status-im/status-go/pulls/1082","id":199488444,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NDg4NDQ0","html_url":"https://github.com/status-im/status-go/pull/1082","diff_url":"https://github.com/status-im/status-go/pull/1082.diff","patch_url":"https://github.com/status-im/status-go/pull/1082.patch","issue_url":"https://api.github.com/repos/status-im/status-go/issues/1082","number":1082,"state":"open","locked":false,"title":"Discover mail servers on start up.","user":{"login":"adriacidre","id":593270,"node_id":"MDQ6VXNlcjU5MzI3MA==","avatar_url":"https://avatars2.githubusercontent.com/u/593270?v=4","gravatar_id":"","url":"https://api.github.com/users/adriacidre","html_url":"https://github.com/adriacidre","followers_url":"https://api.github.com/users/adriacidre/followers","following_url":"https://api.github.com/users/adriacidre/following{/other_user}","gists_url":"https://api.github.com/users/adriacidre/gists{/gist_id}","starred_url":"https://api.github.com/users/adriacidre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriacidre/subscriptions","organizations_url":"https://api.github.com/users/adriacidre/orgs","repos_url":"https://api.github.com/users/adriacidre/repos","events_url":"https://api.github.com/users/adriacidre/events{/privacy}","received_events_url":"https://api.github.com/users/adriacidre/received_events","type":"User","site_admin":false},"body":"This PR introduces the ability for a node with discV5 enabled to discover new mail servers.\r\n\r\nImportant changes:\r\n- [x] TopicPools are now managed through a new interface TopicPoolHandler\r\n- [x] Introduced MailServerTopicPool to manage specific cases\r\n  - [x] MailServerTopicPool discovery process will stop when cached peers reach Max discovery limit.\r\n  - [x] Each mail server peer addition will fire a `mailserver.discovery.completed` signal.\r\n  - [x] Default mail server discovery topic set to `mailserver.discovery`\r\n  - [x] Default mail server discovery limits set to `Min: 2 / Max: 3`\r\n\r\nNote: This is the first task on mail server discovery, and it's only discovering mail servers when the node starts. When we have this as a working feature we will add signals for an RPC client to fire an event, so mail servers can be discovered on demand.\r\n\r\nCloses #1076 \r\n","created_at":"2018-07-05T14:26:40Z","updated_at":"2018-07-06T11:41:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1eb5cbd327356cd17b8d015ec92b8e2d473ba49b","assignee":{"login":"adriacidre","id":593270,"node_id":"MDQ6VXNlcjU5MzI3MA==","avatar_url":"https://avatars2.githubusercontent.com/u/593270?v=4","gravatar_id":"","url":"https://api.github.com/users/adriacidre","html_url":"https://github.com/adriacidre","followers_url":"https://api.github.com/users/adriacidre/followers","following_url":"https://api.github.com/users/adriacidre/following{/other_user}","gists_url":"https://api.github.com/users/adriacidre/gists{/gist_id}","starred_url":"https://api.github.com/users/adriacidre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriacidre/subscriptions","organizations_url":"https://api.github.com/users/adriacidre/orgs","repos_url":"https://api.github.com/users/adriacidre/repos","events_url":"https://api.github.com/users/adriacidre/events{/privacy}","received_events_url":"https://api.github.com/users/adriacidre/received_events","type":"User","site_admin":false},"assignees":[{"login":"adriacidre","id":593270,"node_id":"MDQ6VXNlcjU5MzI3MA==","avatar_url":"https://avatars2.githubusercontent.com/u/593270?v=4","gravatar_id":"","url":"https://api.github.com/users/adriacidre","html_url":"https://github.com/adriacidre","followers_url":"https://api.github.com/users/adriacidre/followers","following_url":"https://api.github.com/users/adriacidre/following{/other_user}","gists_url":"https://api.github.com/users/adriacidre/gists{/gist_id}","starred_url":"https://api.github.com/users/adriacidre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriacidre/subscriptions","organizations_url":"https://api.github.com/users/adriacidre/orgs","repos_url":"https://api.github.com/users/adriacidre/repos","events_url":"https://api.github.com/users/adriacidre/events{/privacy}","received_events_url":"https://api.github.com/users/adriacidre/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"adambabik","id":277870,"node_id":"MDQ6VXNlcjI3Nzg3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/277870?v=4","gravatar_id":"","url":"https://api.github.com/users/adambabik","html_url":"https://github.com/adambabik","followers_url":"https://api.github.com/users/adambabik/followers","following_url":"https://api.github.com/users/adambabik/following{/other_user}","gists_url":"https://api.github.com/users/adambabik/gists{/gist_id}","starred_url":"https://api.github.com/users/adambabik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adambabik/subscriptions","organizations_url":"https://api.github.com/users/adambabik/orgs","repos_url":"https://api.github.com/users/adambabik/repos","events_url":"https://api.github.com/users/adambabik/events{/privacy}","received_events_url":"https://api.github.com/users/adambabik/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/status-im/status-go/pulls/1082/commits","review_comments_url":"https://api.github.com/repos/status-im/status-go/pulls/1082/comments","review_comment_url":"https://api.github.com/repos/status-im/status-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/status-im/status-go/issues/1082/comments","statuses_url":"https://api.github.com/repos/status-im/status-go/statuses/c23ef68021eaad1dd16aaf401b56260257749604","head":{"label":"status-im:feature/issue-1076/mailserver-discovery","ref":"feature/issue-1076/mailserver-discovery","sha":"c23ef68021eaad1dd16aaf401b56260257749604","user":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":61047867,"node_id":"MDEwOlJlcG9zaXRvcnk2MTA0Nzg2Nw==","name":"status-go","full_name":"status-im/status-go","owner":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/status-im/status-go","description":"The Status module that consumes go-ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-go","forks_url":"https://api.github.com/repos/status-im/status-go/forks","keys_url":"https://api.github.com/repos/status-im/status-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-go/teams","hooks_url":"https://api.github.com/repos/status-im/status-go/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-go/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-go/events","assignees_url":"https://api.github.com/repos/status-im/status-go/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-go/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-go/tags","blobs_url":"https://api.github.com/repos/status-im/status-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-go/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-go/languages","stargazers_url":"https://api.github.com/repos/status-im/status-go/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-go/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-go/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-go/subscription","commits_url":"https://api.github.com/repos/status-im/status-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-go/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-go/merges","archive_url":"https://api.github.com/repos/status-im/status-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-go/downloads","issues_url":"https://api.github.com/repos/status-im/status-go/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-go/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-go/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-go/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-go/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-go/deployments","created_at":"2016-06-13T15:32:03Z","updated_at":"2018-07-06T08:30:20Z","pushed_at":"2018-07-06T08:30:17Z","git_url":"git://github.com/status-im/status-go.git","ssh_url":"git@github.com:status-im/status-go.git","clone_url":"https://github.com/status-im/status-go.git","svn_url":"https://github.com/status-im/status-go","homepage":"https://status.im","size":40696,"stargazers_count":425,"watchers_count":425,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":131,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":131,"open_issues":62,"watchers":425,"default_branch":"develop"}},"base":{"label":"status-im:develop","ref":"develop","sha":"737f966dbe127c5ee4e587daa8be4454f4123db7","user":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":61047867,"node_id":"MDEwOlJlcG9zaXRvcnk2MTA0Nzg2Nw==","name":"status-go","full_name":"status-im/status-go","owner":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/status-im/status-go","description":"The Status module that consumes go-ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-go","forks_url":"https://api.github.com/repos/status-im/status-go/forks","keys_url":"https://api.github.com/repos/status-im/status-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-go/teams","hooks_url":"https://api.github.com/repos/status-im/status-go/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-go/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-go/events","assignees_url":"https://api.github.com/repos/status-im/status-go/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-go/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-go/tags","blobs_url":"https://api.github.com/repos/status-im/status-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-go/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-go/languages","stargazers_url":"https://api.github.com/repos/status-im/status-go/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-go/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-go/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-go/subscription","commits_url":"https://api.github.com/repos/status-im/status-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-go/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-go/merges","archive_url":"https://api.github.com/repos/status-im/status-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-go/downloads","issues_url":"https://api.github.com/repos/status-im/status-go/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-go/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-go/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-go/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-go/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-go/deployments","created_at":"2016-06-13T15:32:03Z","updated_at":"2018-07-06T08:30:20Z","pushed_at":"2018-07-06T08:30:17Z","git_url":"git://github.com/status-im/status-go.git","ssh_url":"git@github.com:status-im/status-go.git","clone_url":"https://github.com/status-im/status-go.git","svn_url":"https://github.com/status-im/status-go","homepage":"https://status.im","size":40696,"stargazers_count":425,"watchers_count":425,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":131,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":131,"open_issues":62,"watchers":425,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/status-im/status-go/pulls/1082"},"html":{"href":"https://github.com/status-im/status-go/pull/1082"},"issue":{"href":"https://api.github.com/repos/status-im/status-go/issues/1082"},"comments":{"href":"https://api.github.com/repos/status-im/status-go/issues/1082/comments"},"review_comments":{"href":"https://api.github.com/repos/status-im/status-go/pulls/1082/comments"},"review_comment":{"href":"https://api.github.com/repos/status-im/status-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/status-im/status-go/pulls/1082/commits"},"statuses":{"href":"https://api.github.com/repos/status-im/status-go/statuses/c23ef68021eaad1dd16aaf401b56260257749604"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"adriacidre"}}