{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/jest/pulls/comments/218880670","pull_request_review_id":156918773,"id":218880670,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODg4MDY3MA==","diff_hunk":"@@ -185,6 +188,107 @@ describe('moduleMocker', () => {\n       expect(instanceFooMock.toString.mock).not.toBeUndefined();\n     });\n \n+    it('mocks ES2015 non-enumerable static properties and methods', () => {\n+      class ClassFoo {\n+        static foo() {}\n+      }\n+      ClassFoo.fooProp = () => {};\n+\n+      class ClassBar extends ClassFoo {}\n+\n+      const ClassBarMock = moduleMocker.generateFromMetadata(\n+        moduleMocker.getMetadata(ClassBar),\n+      );\n+\n+      expect(typeof ClassBarMock.foo).toBe('function');\n+      expect(typeof ClassBarMock.fooProp).toBe('function');\n+      expect(ClassBarMock.foo.mock).not.toBeUndefined();","path":"packages/jest-mock/src/__tests__/jest_mock.test.js","position":35,"original_position":35,"commit_id":"cd737c6f7e97fba3f94607db84582128a89f6ef0","original_commit_id":"cd737c6f7e97fba3f94607db84582128a89f6ef0","user":{"login":"SimenB","id":1404810,"node_id":"MDQ6VXNlcjE0MDQ4MTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1404810?v=4","gravatar_id":"","url":"https://api.github.com/users/SimenB","html_url":"https://github.com/SimenB","followers_url":"https://api.github.com/users/SimenB/followers","following_url":"https://api.github.com/users/SimenB/following{/other_user}","gists_url":"https://api.github.com/users/SimenB/gists{/gist_id}","starred_url":"https://api.github.com/users/SimenB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimenB/subscriptions","organizations_url":"https://api.github.com/users/SimenB/orgs","repos_url":"https://api.github.com/users/SimenB/repos","events_url":"https://api.github.com/users/SimenB/events{/privacy}","received_events_url":"https://api.github.com/users/SimenB/received_events","type":"User","site_admin":false},"body":"we have `toBeDefined`","created_at":"2018-09-19T16:48:09Z","updated_at":"2018-09-19T16:49:13Z","html_url":"https://github.com/facebook/jest/pull/7003#discussion_r218880670","pull_request_url":"https://api.github.com/repos/facebook/jest/pulls/7003","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/facebook/jest/pulls/comments/218880670"},"html":{"href":"https://github.com/facebook/jest/pull/7003#discussion_r218880670"},"pull_request":{"href":"https://api.github.com/repos/facebook/jest/pulls/7003"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/jest/pulls/7003","id":216705998,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NzA1OTk4","html_url":"https://github.com/facebook/jest/pull/7003","diff_url":"https://github.com/facebook/jest/pull/7003.diff","patch_url":"https://github.com/facebook/jest/pull/7003.patch","issue_url":"https://api.github.com/repos/facebook/jest/issues/7003","number":7003,"state":"open","locked":false,"title":"Fix mocking inherited static properties and prototype-less objects","user":{"login":"rubennorte","id":117921,"node_id":"MDQ6VXNlcjExNzkyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/117921?v=4","gravatar_id":"","url":"https://api.github.com/users/rubennorte","html_url":"https://github.com/rubennorte","followers_url":"https://api.github.com/users/rubennorte/followers","following_url":"https://api.github.com/users/rubennorte/following{/other_user}","gists_url":"https://api.github.com/users/rubennorte/gists{/gist_id}","starred_url":"https://api.github.com/users/rubennorte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubennorte/subscriptions","organizations_url":"https://api.github.com/users/rubennorte/orgs","repos_url":"https://api.github.com/users/rubennorte/repos","events_url":"https://api.github.com/users/rubennorte/events{/privacy}","received_events_url":"https://api.github.com/users/rubennorte/received_events","type":"User","site_admin":false},"body":"## Summary\r\n\r\nFixes #6994 and #6995, and generalizes some code from jest-mock.\r\n\r\n## Test plan\r\n\r\nAdded new tests cases and tested in FB infra.","created_at":"2018-09-19T16:43:58Z","updated_at":"2018-09-19T16:49:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52d42d5187d61d42a38486b65bf7a69aad96a54f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mjesun","id":829269,"node_id":"MDQ6VXNlcjgyOTI2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/829269?v=4","gravatar_id":"","url":"https://api.github.com/users/mjesun","html_url":"https://github.com/mjesun","followers_url":"https://api.github.com/users/mjesun/followers","following_url":"https://api.github.com/users/mjesun/following{/other_user}","gists_url":"https://api.github.com/users/mjesun/gists{/gist_id}","starred_url":"https://api.github.com/users/mjesun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjesun/subscriptions","organizations_url":"https://api.github.com/users/mjesun/orgs","repos_url":"https://api.github.com/users/mjesun/repos","events_url":"https://api.github.com/users/mjesun/events{/privacy}","received_events_url":"https://api.github.com/users/mjesun/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":847426897,"node_id":"MDU6TGFiZWw4NDc0MjY4OTc=","url":"https://api.github.com/repos/facebook/jest/labels/cla%20signed","name":"cla signed","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/jest/pulls/7003/commits","review_comments_url":"https://api.github.com/repos/facebook/jest/pulls/7003/comments","review_comment_url":"https://api.github.com/repos/facebook/jest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/jest/issues/7003/comments","statuses_url":"https://api.github.com/repos/facebook/jest/statuses/cd737c6f7e97fba3f94607db84582128a89f6ef0","head":{"label":"rubennorte:fix-mocks","ref":"fix-mocks","sha":"cd737c6f7e97fba3f94607db84582128a89f6ef0","user":{"login":"rubennorte","id":117921,"node_id":"MDQ6VXNlcjExNzkyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/117921?v=4","gravatar_id":"","url":"https://api.github.com/users/rubennorte","html_url":"https://github.com/rubennorte","followers_url":"https://api.github.com/users/rubennorte/followers","following_url":"https://api.github.com/users/rubennorte/following{/other_user}","gists_url":"https://api.github.com/users/rubennorte/gists{/gist_id}","starred_url":"https://api.github.com/users/rubennorte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubennorte/subscriptions","organizations_url":"https://api.github.com/users/rubennorte/orgs","repos_url":"https://api.github.com/users/rubennorte/repos","events_url":"https://api.github.com/users/rubennorte/events{/privacy}","received_events_url":"https://api.github.com/users/rubennorte/received_events","type":"User","site_admin":false},"repo":{"id":130679462,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA2Nzk0NjI=","name":"jest","full_name":"rubennorte/jest","private":false,"owner":{"login":"rubennorte","id":117921,"node_id":"MDQ6VXNlcjExNzkyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/117921?v=4","gravatar_id":"","url":"https://api.github.com/users/rubennorte","html_url":"https://github.com/rubennorte","followers_url":"https://api.github.com/users/rubennorte/followers","following_url":"https://api.github.com/users/rubennorte/following{/other_user}","gists_url":"https://api.github.com/users/rubennorte/gists{/gist_id}","starred_url":"https://api.github.com/users/rubennorte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubennorte/subscriptions","organizations_url":"https://api.github.com/users/rubennorte/orgs","repos_url":"https://api.github.com/users/rubennorte/repos","events_url":"https://api.github.com/users/rubennorte/events{/privacy}","received_events_url":"https://api.github.com/users/rubennorte/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rubennorte/jest","description":"🃏 Delightful JavaScript Testing.","fork":true,"url":"https://api.github.com/repos/rubennorte/jest","forks_url":"https://api.github.com/repos/rubennorte/jest/forks","keys_url":"https://api.github.com/repos/rubennorte/jest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubennorte/jest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubennorte/jest/teams","hooks_url":"https://api.github.com/repos/rubennorte/jest/hooks","issue_events_url":"https://api.github.com/repos/rubennorte/jest/issues/events{/number}","events_url":"https://api.github.com/repos/rubennorte/jest/events","assignees_url":"https://api.github.com/repos/rubennorte/jest/assignees{/user}","branches_url":"https://api.github.com/repos/rubennorte/jest/branches{/branch}","tags_url":"https://api.github.com/repos/rubennorte/jest/tags","blobs_url":"https://api.github.com/repos/rubennorte/jest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubennorte/jest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubennorte/jest/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubennorte/jest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubennorte/jest/statuses/{sha}","languages_url":"https://api.github.com/repos/rubennorte/jest/languages","stargazers_url":"https://api.github.com/repos/rubennorte/jest/stargazers","contributors_url":"https://api.github.com/repos/rubennorte/jest/contributors","subscribers_url":"https://api.github.com/repos/rubennorte/jest/subscribers","subscription_url":"https://api.github.com/repos/rubennorte/jest/subscription","commits_url":"https://api.github.com/repos/rubennorte/jest/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubennorte/jest/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubennorte/jest/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubennorte/jest/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubennorte/jest/contents/{+path}","compare_url":"https://api.github.com/repos/rubennorte/jest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubennorte/jest/merges","archive_url":"https://api.github.com/repos/rubennorte/jest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubennorte/jest/downloads","issues_url":"https://api.github.com/repos/rubennorte/jest/issues{/number}","pulls_url":"https://api.github.com/repos/rubennorte/jest/pulls{/number}","milestones_url":"https://api.github.com/repos/rubennorte/jest/milestones{/number}","notifications_url":"https://api.github.com/repos/rubennorte/jest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubennorte/jest/labels{/name}","releases_url":"https://api.github.com/repos/rubennorte/jest/releases{/id}","deployments_url":"https://api.github.com/repos/rubennorte/jest/deployments","created_at":"2018-04-23T10:24:05Z","updated_at":"2018-04-23T10:24:10Z","pushed_at":"2018-09-19T16:46:14Z","git_url":"git://github.com/rubennorte/jest.git","ssh_url":"git@github.com:rubennorte/jest.git","clone_url":"https://github.com/rubennorte/jest.git","svn_url":"https://github.com/rubennorte/jest","homepage":"https://facebook.github.io/jest/","size":81994,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"a5cdea2be9a489e3bbffa3f9bbdbe9daa462bd70","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":15062869,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA2Mjg2OQ==","name":"jest","full_name":"facebook/jest","private":false,"owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/facebook/jest","description":"🃏 Delightful JavaScript Testing.","fork":false,"url":"https://api.github.com/repos/facebook/jest","forks_url":"https://api.github.com/repos/facebook/jest/forks","keys_url":"https://api.github.com/repos/facebook/jest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/jest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/jest/teams","hooks_url":"https://api.github.com/repos/facebook/jest/hooks","issue_events_url":"https://api.github.com/repos/facebook/jest/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/jest/events","assignees_url":"https://api.github.com/repos/facebook/jest/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/jest/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/jest/tags","blobs_url":"https://api.github.com/repos/facebook/jest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/jest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/jest/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/jest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/jest/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/jest/languages","stargazers_url":"https://api.github.com/repos/facebook/jest/stargazers","contributors_url":"https://api.github.com/repos/facebook/jest/contributors","subscribers_url":"https://api.github.com/repos/facebook/jest/subscribers","subscription_url":"https://api.github.com/repos/facebook/jest/subscription","commits_url":"https://api.github.com/repos/facebook/jest/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/jest/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/jest/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/jest/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/jest/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/jest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/jest/merges","archive_url":"https://api.github.com/repos/facebook/jest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/jest/downloads","issues_url":"https://api.github.com/repos/facebook/jest/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/jest/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/jest/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/jest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/jest/labels{/name}","releases_url":"https://api.github.com/repos/facebook/jest/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/jest/deployments","created_at":"2013-12-10T00:18:04Z","updated_at":"2018-09-19T15:49:08Z","pushed_at":"2018-09-19T16:47:54Z","git_url":"git://github.com/facebook/jest.git","ssh_url":"git@github.com:facebook/jest.git","clone_url":"https://github.com/facebook/jest.git","svn_url":"https://github.com/facebook/jest","homepage":"https://facebook.github.io/jest/","size":112756,"stargazers_count":20471,"watchers_count":20471,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2675,"mirror_url":null,"archived":false,"open_issues_count":480,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2675,"open_issues":480,"watchers":20471,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/jest/pulls/7003"},"html":{"href":"https://github.com/facebook/jest/pull/7003"},"issue":{"href":"https://api.github.com/repos/facebook/jest/issues/7003"},"comments":{"href":"https://api.github.com/repos/facebook/jest/issues/7003/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/jest/pulls/7003/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/jest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/jest/pulls/7003/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/jest/statuses/cd737c6f7e97fba3f94607db84582128a89f6ef0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"SimenB"}}