{"action":"created","issue":{"url":"https://api.github.com/repos/Nexmo/nexmo-node/issues/217","repository_url":"https://api.github.com/repos/Nexmo/nexmo-node","labels_url":"https://api.github.com/repos/Nexmo/nexmo-node/issues/217/labels{/name}","comments_url":"https://api.github.com/repos/Nexmo/nexmo-node/issues/217/comments","events_url":"https://api.github.com/repos/Nexmo/nexmo-node/issues/217/events","html_url":"https://github.com/Nexmo/nexmo-node/pull/217","id":371457917,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzODk5MTUx","number":217,"title":"Initial pass at media API implementation","user":{"login":"UddhavNavneeth","id":35415724,"node_id":"MDQ6VXNlcjM1NDE1NzI0","avatar_url":"https://avatars2.githubusercontent.com/u/35415724?v=4","gravatar_id":"","url":"https://api.github.com/users/UddhavNavneeth","html_url":"https://github.com/UddhavNavneeth","followers_url":"https://api.github.com/users/UddhavNavneeth/followers","following_url":"https://api.github.com/users/UddhavNavneeth/following{/other_user}","gists_url":"https://api.github.com/users/UddhavNavneeth/gists{/gist_id}","starred_url":"https://api.github.com/users/UddhavNavneeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UddhavNavneeth/subscriptions","organizations_url":"https://api.github.com/users/UddhavNavneeth/orgs","repos_url":"https://api.github.com/users/UddhavNavneeth/repos","events_url":"https://api.github.com/users/UddhavNavneeth/events{/privacy}","received_events_url":"https://api.github.com/users/UddhavNavneeth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-18T10:13:28Z","updated_at":"2018-10-18T10:13:50Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Nexmo/nexmo-node/pulls/217","html_url":"https://github.com/Nexmo/nexmo-node/pull/217","diff_url":"https://github.com/Nexmo/nexmo-node/pull/217.diff","patch_url":"https://github.com/Nexmo/nexmo-node/pull/217.patch"},"body":"There's a lot of room for improvement, but there's enough here to at\r\nleast try out the API.\r\n\r\n* I've added `request` to handle the multipart form data for us. This\r\nis the first step towards using `request` as our main HTTP client\r\n* Media._makeRequest is required as Content-Type must be application/json\r\nfor all requests\r\n* I've added a flag (`skipJsonDecoding`) to HTTPClient to allow us to\r\ndownload a raw response (required for `media.download()`\r\nout the mocks for `request`\r\n* `media.download` implements both `If-Modified-Since` and\r\n`If-None-Match` - https://ea.developer.nexmo.com/api/media#download-media-file\r\n- but it is not documented. This is functionality we'll only expose if\r\npeople explicitly ask for it.\r\n* Add support for mocking `request` when posting a file.  We check specifically\r\nfor the `postFile` method for now as that's the only thing that uses `request`.\r\nThis will need refactoring if we move away from HTTPClient in the future\r\n* Add examples for Media API + supported list to README"},"comment":{"url":"https://api.github.com/repos/Nexmo/nexmo-node/issues/comments/430954113","html_url":"https://github.com/Nexmo/nexmo-node/pull/217#issuecomment-430954113","issue_url":"https://api.github.com/repos/Nexmo/nexmo-node/issues/217","id":430954113,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDk1NDExMw==","user":{"login":"UddhavNavneeth","id":35415724,"node_id":"MDQ6VXNlcjM1NDE1NzI0","avatar_url":"https://avatars2.githubusercontent.com/u/35415724?v=4","gravatar_id":"","url":"https://api.github.com/users/UddhavNavneeth","html_url":"https://github.com/UddhavNavneeth","followers_url":"https://api.github.com/users/UddhavNavneeth/followers","following_url":"https://api.github.com/users/UddhavNavneeth/following{/other_user}","gists_url":"https://api.github.com/users/UddhavNavneeth/gists{/gist_id}","starred_url":"https://api.github.com/users/UddhavNavneeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UddhavNavneeth/subscriptions","organizations_url":"https://api.github.com/users/UddhavNavneeth/orgs","repos_url":"https://api.github.com/users/UddhavNavneeth/repos","events_url":"https://api.github.com/users/UddhavNavneeth/events{/privacy}","received_events_url":"https://api.github.com/users/UddhavNavneeth/received_events","type":"User","site_admin":false},"created_at":"2018-10-18T10:13:50Z","updated_at":"2018-10-18T10:13:50Z","author_association":"NONE","body":"just for hacktoberfest"}}
{"actor":{"display_login":"UddhavNavneeth"}}