{"action":"created","comment":{"url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/pulls/comments/214876575","pull_request_review_id":152018746,"id":214876575,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDg3NjU3NQ==","diff_hunk":"@@ -0,0 +1,168 @@\n+[id='using_a_configmap_to_configure_you_spring_boot_application']\n+= Using a ConfigMap to configure your {SpringBoot} application\n+//ustory: injecting configuration data into your application using a configmap\n+\n+:deploymentPlatform: Kubernetes\n+\n+//openshift docs on configmaps\n+//https://docs.openshift.org/latest/dev_guide/configmaps.html\n+//https://goo.gl/cQTA2B\n+//https://kubernetes.io/docs/tasks/configure-pod-container/configure-pod-configmap/#create-configmaps-from-files\n+\n+link:http://kubernetes.io/docs/user-guide/configmap/[`ConfigMap`] is a {deploymentPlatform} resource type that allows you to externalize the configuration parameters that you pass to your application in the form of key-value pairs or embedded `application.properties` or `application.yaml` templates.\n+The `ConfigMapPropertySource` provided by Spring Cloud Kubernetes searches the deployment configuration of your application for a ConfigMap object in which the `metadata.name` property matches the name of your {SpringBoot} application and applies the values to the deployment configuration of your application.\n+The application name is set by the `spring.application.name` property.\n+\n+Alternatively, you can specify a custom name for your ConfigMap.\n+Set the value of the `spring.cloud.kubernetes.config.name` property in the `bootstrap.properties` file of your application project to the name of your ConfigMap.\n+This enables the externalized configuration to be recognized and processed by your application.\n+\n+The examples below demonstrate different ways that configuration data is structured within your ConfigMap YAML template.\n+The example below uses the following properties:\n+\n+* `pool.size.core`\n+* `pool.size.maximum`\n+\n+You can inject configuration settings into your application in different ways depending on how you structure the data within the ConfigMap:\n+\n+\n+// make this a prerequisite:\n+// already documented in the Configmap booster doc\n+[NOTE]\n+====\n+Ensure that you have view permissions assigned to the service account of your application.\n+Without these permissions, your application will not be able to access the ConfigMap.\n+\n+[source,bash,options=\"nowrap\",subs=\"attributes+\"]\n+--\n+oc policy add-role-to-user view system:serviceaccount:$(oc project -q):{app-name} -n $(oc project -q)\n+--\n+====\n+\n+* Specify values of individual configuration properties directly in key-value format.\n+{deploymentPlatform} processes the ConfigMap and maps the values to your application.\n+This structure is suitable for updating specific properties within an otherwise static configuration.\n++\n+[source,yaml,options=\"nowrap\"]\n+----\n+kind: ConfigMap\n+apiVersion: v1\n+metadata:\n+  name: demo\n+data:\n+  pool.size.core: 1\n+  pool.size.max: 16\n+----\n+\n+* If your configuration template contains a property named `application.yaml`, {deploymentPlatform} processes the configuration template and creates the ConfigMap.\n+On application startup, {deploymentPlatform} checks if the ConfigMap contains a key with one of the following names:\n++\n+--\n+** `application.yaml`,\n+** `application.yml`,\n+** `application.properties`.\n+--\n++\n+If the key is found, {deploymentPlatform} processes and applies the content of that property as an embedded YAML configuration template.\n+This allows you to update complex sets of application properties at once, while helping you to keep your template readable.\n++\n+[source,yaml,options=\"nowrap\"]\n+----\n+kind: ConfigMap\n+apiVersion: v1\n+metadata:\n+  name: demo\n+data:\n+  application.yaml: |-\n+    pool:\n+      size:\n+        core: 1\n+        max:16\n+----\n+\n+// not sure if multiple profiles are supported","path":"docs/topics/con_configmap-availability.adoc","position":83,"original_position":83,"commit_id":"7b51bd19853955210dbf6ae88b579d6047401f59","original_commit_id":"7b51bd19853955210dbf6ae88b579d6047401f59","user":{"login":"geoand","id":4374975,"node_id":"MDQ6VXNlcjQzNzQ5NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/4374975?v=4","gravatar_id":"","url":"https://api.github.com/users/geoand","html_url":"https://github.com/geoand","followers_url":"https://api.github.com/users/geoand/followers","following_url":"https://api.github.com/users/geoand/following{/other_user}","gists_url":"https://api.github.com/users/geoand/gists{/gist_id}","starred_url":"https://api.github.com/users/geoand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoand/subscriptions","organizations_url":"https://api.github.com/users/geoand/orgs","repos_url":"https://api.github.com/users/geoand/repos","events_url":"https://api.github.com/users/geoand/events{/privacy}","received_events_url":"https://api.github.com/users/geoand/received_events","type":"User","site_admin":false},"body":"They should be","created_at":"2018-09-04T11:17:34Z","updated_at":"2018-09-04T11:17:34Z","html_url":"https://github.com/fabric8-launcher/launcher-documentation/pull/1151#discussion_r214876575","pull_request_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/pulls/1151","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/pulls/comments/214876575"},"html":{"href":"https://github.com/fabric8-launcher/launcher-documentation/pull/1151#discussion_r214876575"},"pull_request":{"href":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/pulls/1151"}}},"pull_request":{"url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/pulls/1151","id":196803793,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2ODAzNzkz","html_url":"https://github.com/fabric8-launcher/launcher-documentation/pull/1151","diff_url":"https://github.com/fabric8-launcher/launcher-documentation/pull/1151.diff","patch_url":"https://github.com/fabric8-launcher/launcher-documentation/pull/1151.patch","issue_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/issues/1151","number":1151,"state":"open","locked":false,"title":"first take on SB-458","user":{"login":"inoxx03","id":17914654,"node_id":"MDQ6VXNlcjE3OTE0NjU0","avatar_url":"https://avatars2.githubusercontent.com/u/17914654?v=4","gravatar_id":"","url":"https://api.github.com/users/inoxx03","html_url":"https://github.com/inoxx03","followers_url":"https://api.github.com/users/inoxx03/followers","following_url":"https://api.github.com/users/inoxx03/following{/other_user}","gists_url":"https://api.github.com/users/inoxx03/gists{/gist_id}","starred_url":"https://api.github.com/users/inoxx03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inoxx03/subscriptions","organizations_url":"https://api.github.com/users/inoxx03/orgs","repos_url":"https://api.github.com/users/inoxx03/repos","events_url":"https://api.github.com/users/inoxx03/events{/privacy}","received_events_url":"https://api.github.com/users/inoxx03/received_events","type":"User","site_admin":false},"body":"@cmoulliard @metacosm @geoand Still a WIP, but please let me know what you think. Thank you.","created_at":"2018-06-22T17:50:44Z","updated_at":"2018-09-04T11:17:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"712b94eb356aacf524aa85a7f0b365504066acb4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rhoads-zach","id":208104,"node_id":"MDQ6VXNlcjIwODEwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/208104?v=4","gravatar_id":"","url":"https://api.github.com/users/rhoads-zach","html_url":"https://github.com/rhoads-zach","followers_url":"https://api.github.com/users/rhoads-zach/followers","following_url":"https://api.github.com/users/rhoads-zach/following{/other_user}","gists_url":"https://api.github.com/users/rhoads-zach/gists{/gist_id}","starred_url":"https://api.github.com/users/rhoads-zach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhoads-zach/subscriptions","organizations_url":"https://api.github.com/users/rhoads-zach/orgs","repos_url":"https://api.github.com/users/rhoads-zach/repos","events_url":"https://api.github.com/users/rhoads-zach/events{/privacy}","received_events_url":"https://api.github.com/users/rhoads-zach/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/pulls/1151/commits","review_comments_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/pulls/1151/comments","review_comment_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/issues/1151/comments","statuses_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/statuses/7b51bd19853955210dbf6ae88b579d6047401f59","head":{"label":"inoxx03:SB-458","ref":"SB-458","sha":"7b51bd19853955210dbf6ae88b579d6047401f59","user":{"login":"inoxx03","id":17914654,"node_id":"MDQ6VXNlcjE3OTE0NjU0","avatar_url":"https://avatars2.githubusercontent.com/u/17914654?v=4","gravatar_id":"","url":"https://api.github.com/users/inoxx03","html_url":"https://github.com/inoxx03","followers_url":"https://api.github.com/users/inoxx03/followers","following_url":"https://api.github.com/users/inoxx03/following{/other_user}","gists_url":"https://api.github.com/users/inoxx03/gists{/gist_id}","starred_url":"https://api.github.com/users/inoxx03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inoxx03/subscriptions","organizations_url":"https://api.github.com/users/inoxx03/orgs","repos_url":"https://api.github.com/users/inoxx03/repos","events_url":"https://api.github.com/users/inoxx03/events{/privacy}","received_events_url":"https://api.github.com/users/inoxx03/received_events","type":"User","site_admin":false},"repo":{"id":86094089,"node_id":"MDEwOlJlcG9zaXRvcnk4NjA5NDA4OQ==","name":"documentation","full_name":"inoxx03/documentation","owner":{"login":"inoxx03","id":17914654,"node_id":"MDQ6VXNlcjE3OTE0NjU0","avatar_url":"https://avatars2.githubusercontent.com/u/17914654?v=4","gravatar_id":"","url":"https://api.github.com/users/inoxx03","html_url":"https://github.com/inoxx03","followers_url":"https://api.github.com/users/inoxx03/followers","following_url":"https://api.github.com/users/inoxx03/following{/other_user}","gists_url":"https://api.github.com/users/inoxx03/gists{/gist_id}","starred_url":"https://api.github.com/users/inoxx03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inoxx03/subscriptions","organizations_url":"https://api.github.com/users/inoxx03/orgs","repos_url":"https://api.github.com/users/inoxx03/repos","events_url":"https://api.github.com/users/inoxx03/events{/privacy}","received_events_url":"https://api.github.com/users/inoxx03/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/inoxx03/documentation","description":null,"fork":true,"url":"https://api.github.com/repos/inoxx03/documentation","forks_url":"https://api.github.com/repos/inoxx03/documentation/forks","keys_url":"https://api.github.com/repos/inoxx03/documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inoxx03/documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inoxx03/documentation/teams","hooks_url":"https://api.github.com/repos/inoxx03/documentation/hooks","issue_events_url":"https://api.github.com/repos/inoxx03/documentation/issues/events{/number}","events_url":"https://api.github.com/repos/inoxx03/documentation/events","assignees_url":"https://api.github.com/repos/inoxx03/documentation/assignees{/user}","branches_url":"https://api.github.com/repos/inoxx03/documentation/branches{/branch}","tags_url":"https://api.github.com/repos/inoxx03/documentation/tags","blobs_url":"https://api.github.com/repos/inoxx03/documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inoxx03/documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inoxx03/documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/inoxx03/documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inoxx03/documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/inoxx03/documentation/languages","stargazers_url":"https://api.github.com/repos/inoxx03/documentation/stargazers","contributors_url":"https://api.github.com/repos/inoxx03/documentation/contributors","subscribers_url":"https://api.github.com/repos/inoxx03/documentation/subscribers","subscription_url":"https://api.github.com/repos/inoxx03/documentation/subscription","commits_url":"https://api.github.com/repos/inoxx03/documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/inoxx03/documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/inoxx03/documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/inoxx03/documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/inoxx03/documentation/contents/{+path}","compare_url":"https://api.github.com/repos/inoxx03/documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inoxx03/documentation/merges","archive_url":"https://api.github.com/repos/inoxx03/documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inoxx03/documentation/downloads","issues_url":"https://api.github.com/repos/inoxx03/documentation/issues{/number}","pulls_url":"https://api.github.com/repos/inoxx03/documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/inoxx03/documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/inoxx03/documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inoxx03/documentation/labels{/name}","releases_url":"https://api.github.com/repos/inoxx03/documentation/releases{/id}","deployments_url":"https://api.github.com/repos/inoxx03/documentation/deployments","created_at":"2017-03-24T17:29:40Z","updated_at":"2017-03-24T17:29:42Z","pushed_at":"2018-09-04T10:33:17Z","git_url":"git://github.com/inoxx03/documentation.git","ssh_url":"git@github.com:inoxx03/documentation.git","clone_url":"https://github.com/inoxx03/documentation.git","svn_url":"https://github.com/inoxx03/documentation","homepage":null,"size":5591,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0","node_id":"MDc6TGljZW5zZTI1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fabric8-launcher:master","ref":"master","sha":"02ad1f7822e9c0d5f18f94dd631353c57492a745","user":{"login":"fabric8-launcher","id":32217730,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjE3NzMw","avatar_url":"https://avatars2.githubusercontent.com/u/32217730?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-launcher","html_url":"https://github.com/fabric8-launcher","followers_url":"https://api.github.com/users/fabric8-launcher/followers","following_url":"https://api.github.com/users/fabric8-launcher/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-launcher/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-launcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-launcher/subscriptions","organizations_url":"https://api.github.com/users/fabric8-launcher/orgs","repos_url":"https://api.github.com/users/fabric8-launcher/repos","events_url":"https://api.github.com/users/fabric8-launcher/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-launcher/received_events","type":"Organization","site_admin":false},"repo":{"id":85718759,"node_id":"MDEwOlJlcG9zaXRvcnk4NTcxODc1OQ==","name":"launcher-documentation","full_name":"fabric8-launcher/launcher-documentation","owner":{"login":"fabric8-launcher","id":32217730,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMjE3NzMw","avatar_url":"https://avatars2.githubusercontent.com/u/32217730?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-launcher","html_url":"https://github.com/fabric8-launcher","followers_url":"https://api.github.com/users/fabric8-launcher/followers","following_url":"https://api.github.com/users/fabric8-launcher/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-launcher/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-launcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-launcher/subscriptions","organizations_url":"https://api.github.com/users/fabric8-launcher/orgs","repos_url":"https://api.github.com/users/fabric8-launcher/repos","events_url":"https://api.github.com/users/fabric8-launcher/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-launcher/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fabric8-launcher/launcher-documentation","description":"The fabric8-launcher documentation","fork":false,"url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation","forks_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/forks","keys_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/teams","hooks_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/hooks","issue_events_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/events","assignees_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/tags","blobs_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/languages","stargazers_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/stargazers","contributors_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/contributors","subscribers_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/subscribers","subscription_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/subscription","commits_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/merges","archive_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/downloads","issues_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/labels{/name}","releases_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/deployments","created_at":"2017-03-21T15:27:12Z","updated_at":"2018-09-04T08:30:14Z","pushed_at":"2018-09-04T10:33:19Z","git_url":"git://github.com/fabric8-launcher/launcher-documentation.git","ssh_url":"git@github.com:fabric8-launcher/launcher-documentation.git","clone_url":"https://github.com/fabric8-launcher/launcher-documentation.git","svn_url":"https://github.com/fabric8-launcher/launcher-documentation","homepage":"https://launcher.fabric8.io","size":14800,"stargazers_count":7,"watchers_count":7,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0","node_id":"MDc6TGljZW5zZTI1"},"forks":38,"open_issues":3,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/pulls/1151"},"html":{"href":"https://github.com/fabric8-launcher/launcher-documentation/pull/1151"},"issue":{"href":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/issues/1151"},"comments":{"href":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/issues/1151/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/pulls/1151/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/pulls/1151/commits"},"statuses":{"href":"https://api.github.com/repos/fabric8-launcher/launcher-documentation/statuses/7b51bd19853955210dbf6ae88b579d6047401f59"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"geoand"}}