{"action":"created","issue":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/7406","repository_url":"https://api.github.com/repos/dolphin-emu/dolphin","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/7406/labels{/name}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/7406/comments","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/7406/events","html_url":"https://github.com/dolphin-emu/dolphin/pull/7406","id":358421099,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MTY5ODA1","number":7406,"title":"Correctly adjust the rendered XFB region at non-native internal resolutions when XFB was loaded from console RAM.","user":{"login":"AdmiralCurtiss","id":4522237,"node_id":"MDQ6VXNlcjQ1MjIyMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/4522237?v=4","gravatar_id":"","url":"https://api.github.com/users/AdmiralCurtiss","html_url":"https://github.com/AdmiralCurtiss","followers_url":"https://api.github.com/users/AdmiralCurtiss/followers","following_url":"https://api.github.com/users/AdmiralCurtiss/following{/other_user}","gists_url":"https://api.github.com/users/AdmiralCurtiss/gists{/gist_id}","starred_url":"https://api.github.com/users/AdmiralCurtiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdmiralCurtiss/subscriptions","organizations_url":"https://api.github.com/users/AdmiralCurtiss/orgs","repos_url":"https://api.github.com/users/AdmiralCurtiss/repos","events_url":"https://api.github.com/users/AdmiralCurtiss/events{/privacy}","received_events_url":"https://api.github.com/users/AdmiralCurtiss/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-09T22:57:51Z","updated_at":"2018-09-10T04:36:16Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/7406","html_url":"https://github.com/dolphin-emu/dolphin/pull/7406","diff_url":"https://github.com/dolphin-emu/dolphin/pull/7406.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/7406.patch"},"body":"If, for whatever reason, the XFB has to be loaded from console memory, it's possible that the texture is returned at native resolution instead of EFB-scaled resolution. In this case, our `xfb_rect.right` adjustment must also happen at native resolution instead of scaled resolution.\r\n\r\nThis actually happens to work regardless in most circumstances because `fbStride` and `fbWidth` are rarely different, and thus the value of the adjustment is `0` anyway. The only way I could get it to happen is by disabling the `bForceProgressive` option and running any of the numerous games that benefit from that.\r\n\r\nAlso, I'm not sure if this is the best check for determining when this happened. Better ideas?"},"comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/419784869","html_url":"https://github.com/dolphin-emu/dolphin/pull/7406#issuecomment-419784869","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/7406","id":419784869,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTc4NDg2OQ==","user":{"login":"iwubcode","id":15224722,"node_id":"MDQ6VXNlcjE1MjI0NzIy","avatar_url":"https://avatars1.githubusercontent.com/u/15224722?v=4","gravatar_id":"","url":"https://api.github.com/users/iwubcode","html_url":"https://github.com/iwubcode","followers_url":"https://api.github.com/users/iwubcode/followers","following_url":"https://api.github.com/users/iwubcode/following{/other_user}","gists_url":"https://api.github.com/users/iwubcode/gists{/gist_id}","starred_url":"https://api.github.com/users/iwubcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iwubcode/subscriptions","organizations_url":"https://api.github.com/users/iwubcode/orgs","repos_url":"https://api.github.com/users/iwubcode/repos","events_url":"https://api.github.com/users/iwubcode/events{/privacy}","received_events_url":"https://api.github.com/users/iwubcode/received_events","type":"User","site_admin":false},"created_at":"2018-09-10T04:36:16Z","updated_at":"2018-09-10T04:36:16Z","author_association":"CONTRIBUTOR","body":"Yes, this was a good catch.  If I remember correctly, I believe Ty 2 was the game that needed the difference between stride and width.  I can't recall if others needed it as well.\r\n\r\nRegardless it looks good to me.  The only other way to know that it came from memory is to set a flag when we choose the 'memory path' but I think this should be fine too.\r\n\r\nI tested with a number of games that we originally tested with Hybrid XFB, I didn't notice any issues.\r\n\r\n\r\n@JMC47 - I'll be interested to hear if you find any games that this fixes!"}}
{"actor":{"display_login":"iwubcode"}}