{"action":"created","comment":{"url":"https://api.github.com/repos/ubc/compair/pulls/comments/197953825","pull_request_review_id":131787928,"id":197953825,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Nzk1MzgyNQ==","diff_hunk":"@@ -1210,6 +1215,9 @@ module.controller(\"AssignmentWriteController\",\n         $scope.loggedInUserId = resolvedData.loggedInUser.id;\n         $scope.canManageAssignment = resolvedData.canManageAssignment;\n         $scope.availableCriteria = resolvedData.criteria.objects;\n+        $scope.groups = resolvedData.groups.objects;","path":"compair/static/modules/assignment/assignment-module.js","position":55,"original_position":55,"commit_id":"188c67afe292704134319de83051b8ce01966e0e","original_commit_id":"188c67afe292704134319de83051b8ce01966e0e","user":{"login":"kitsook","id":13360325,"node_id":"MDQ6VXNlcjEzMzYwMzI1","avatar_url":"https://avatars1.githubusercontent.com/u/13360325?v=4","gravatar_id":"","url":"https://api.github.com/users/kitsook","html_url":"https://github.com/kitsook","followers_url":"https://api.github.com/users/kitsook/followers","following_url":"https://api.github.com/users/kitsook/following{/other_user}","gists_url":"https://api.github.com/users/kitsook/gists{/gist_id}","starred_url":"https://api.github.com/users/kitsook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitsook/subscriptions","organizations_url":"https://api.github.com/users/kitsook/orgs","repos_url":"https://api.github.com/users/kitsook/repos","events_url":"https://api.github.com/users/kitsook/events{/privacy}","received_events_url":"https://api.github.com/users/kitsook/received_events","type":"User","site_admin":false},"body":"This causes exception when tried to duplicate an assignment.  There is no `groups` in `resolvedData`","created_at":"2018-06-25T21:51:00Z","updated_at":"2018-06-25T22:01:11Z","html_url":"https://github.com/ubc/compair/pull/784#discussion_r197953825","pull_request_url":"https://api.github.com/repos/ubc/compair/pulls/784","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ubc/compair/pulls/comments/197953825"},"html":{"href":"https://github.com/ubc/compair/pull/784#discussion_r197953825"},"pull_request":{"href":"https://api.github.com/repos/ubc/compair/pulls/784"}}},"pull_request":{"url":"https://api.github.com/repos/ubc/compair/pulls/784","id":196559242,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NTU5MjQy","html_url":"https://github.com/ubc/compair/pull/784","diff_url":"https://github.com/ubc/compair/pull/784.diff","patch_url":"https://github.com/ubc/compair/pull/784.patch","issue_url":"https://api.github.com/repos/ubc/compair/issues/784","number":784,"state":"open","locked":false,"title":"Add group answer option to assignments","user":{"login":"andrew-gardener","id":3082802,"node_id":"MDQ6VXNlcjMwODI4MDI=","avatar_url":"https://avatars0.githubusercontent.com/u/3082802?v=4","gravatar_id":"","url":"https://api.github.com/users/andrew-gardener","html_url":"https://github.com/andrew-gardener","followers_url":"https://api.github.com/users/andrew-gardener/followers","following_url":"https://api.github.com/users/andrew-gardener/following{/other_user}","gists_url":"https://api.github.com/users/andrew-gardener/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew-gardener/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew-gardener/subscriptions","organizations_url":"https://api.github.com/users/andrew-gardener/orgs","repos_url":"https://api.github.com/users/andrew-gardener/repos","events_url":"https://api.github.com/users/andrew-gardener/events{/privacy}","received_events_url":"https://api.github.com/users/andrew-gardener/received_events","type":"User","site_admin":false},"body":"- Added group table with automatic migration of `group_name` in user_course table to `group_id` with corresponding group using the name\r\n- Added `enable_group_answers` to Assignment\r\n- Added `group_id` to Answer. answers must have one and only one `user_id` or `group_id`.\r\n- modified a lot of answer query logic around groups (most around recognizing the a given user's group id and counting that answer as their own)\r\n- renamed api files `course_group_user.py` and `course_group.py` to `group_user.py` and `group.py`\r\n- added assignment and course grade update logic by group\r\n- users can no longer be removed from their group if the course has a group assignment that is currently in or past the comparison period\r\n- `result.inserted_primary_key` was no longer working in migrations so switched to `result.lastrowid` which will be equivalent in general (would be good to switch back in the future if inserted_primary_key starts working again\r\n\r\nRelated to #611","created_at":"2018-06-21T19:58:10Z","updated_at":"2018-06-25T22:01:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d581b102895b1bcb2755ed3e4180b311b5b1022b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lenglund","id":6118592,"node_id":"MDQ6VXNlcjYxMTg1OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6118592?v=4","gravatar_id":"","url":"https://api.github.com/users/lenglund","html_url":"https://github.com/lenglund","followers_url":"https://api.github.com/users/lenglund/followers","following_url":"https://api.github.com/users/lenglund/following{/other_user}","gists_url":"https://api.github.com/users/lenglund/gists{/gist_id}","starred_url":"https://api.github.com/users/lenglund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lenglund/subscriptions","organizations_url":"https://api.github.com/users/lenglund/orgs","repos_url":"https://api.github.com/users/lenglund/repos","events_url":"https://api.github.com/users/lenglund/events{/privacy}","received_events_url":"https://api.github.com/users/lenglund/received_events","type":"User","site_admin":false},{"login":"wynnset","id":8981258,"node_id":"MDQ6VXNlcjg5ODEyNTg=","avatar_url":"https://avatars1.githubusercontent.com/u/8981258?v=4","gravatar_id":"","url":"https://api.github.com/users/wynnset","html_url":"https://github.com/wynnset","followers_url":"https://api.github.com/users/wynnset/followers","following_url":"https://api.github.com/users/wynnset/following{/other_user}","gists_url":"https://api.github.com/users/wynnset/gists{/gist_id}","starred_url":"https://api.github.com/users/wynnset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wynnset/subscriptions","organizations_url":"https://api.github.com/users/wynnset/orgs","repos_url":"https://api.github.com/users/wynnset/repos","events_url":"https://api.github.com/users/wynnset/events{/privacy}","received_events_url":"https://api.github.com/users/wynnset/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/ubc/compair/milestones/13","html_url":"https://github.com/ubc/compair/milestone/13","labels_url":"https://api.github.com/repos/ubc/compair/milestones/13/labels","id":2798947,"node_id":"MDk6TWlsZXN0b25lMjc5ODk0Nw==","number":13,"title":"Version 1.2","description":"","creator":{"login":"andrew-gardener","id":3082802,"node_id":"MDQ6VXNlcjMwODI4MDI=","avatar_url":"https://avatars0.githubusercontent.com/u/3082802?v=4","gravatar_id":"","url":"https://api.github.com/users/andrew-gardener","html_url":"https://github.com/andrew-gardener","followers_url":"https://api.github.com/users/andrew-gardener/followers","following_url":"https://api.github.com/users/andrew-gardener/following{/other_user}","gists_url":"https://api.github.com/users/andrew-gardener/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew-gardener/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew-gardener/subscriptions","organizations_url":"https://api.github.com/users/andrew-gardener/orgs","repos_url":"https://api.github.com/users/andrew-gardener/repos","events_url":"https://api.github.com/users/andrew-gardener/events{/privacy}","received_events_url":"https://api.github.com/users/andrew-gardener/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":37,"state":"open","created_at":"2017-09-27T22:49:24Z","updated_at":"2018-06-25T20:20:19Z","due_on":"2018-08-15T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/ubc/compair/pulls/784/commits","review_comments_url":"https://api.github.com/repos/ubc/compair/pulls/784/comments","review_comment_url":"https://api.github.com/repos/ubc/compair/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ubc/compair/issues/784/comments","statuses_url":"https://api.github.com/repos/ubc/compair/statuses/188c67afe292704134319de83051b8ce01966e0e","head":{"label":"ubc:#611-assignment-group-answers","ref":"#611-assignment-group-answers","sha":"188c67afe292704134319de83051b8ce01966e0e","user":{"login":"ubc","id":1396118,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTYxMTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1396118?v=4","gravatar_id":"","url":"https://api.github.com/users/ubc","html_url":"https://github.com/ubc","followers_url":"https://api.github.com/users/ubc/followers","following_url":"https://api.github.com/users/ubc/following{/other_user}","gists_url":"https://api.github.com/users/ubc/gists{/gist_id}","starred_url":"https://api.github.com/users/ubc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubc/subscriptions","organizations_url":"https://api.github.com/users/ubc/orgs","repos_url":"https://api.github.com/users/ubc/repos","events_url":"https://api.github.com/users/ubc/events{/privacy}","received_events_url":"https://api.github.com/users/ubc/received_events","type":"Organization","site_admin":false},"repo":{"id":10607020,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYwNzAyMA==","name":"compair","full_name":"ubc/compair","owner":{"login":"ubc","id":1396118,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTYxMTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1396118?v=4","gravatar_id":"","url":"https://api.github.com/users/ubc","html_url":"https://github.com/ubc","followers_url":"https://api.github.com/users/ubc/followers","following_url":"https://api.github.com/users/ubc/following{/other_user}","gists_url":"https://api.github.com/users/ubc/gists{/gist_id}","starred_url":"https://api.github.com/users/ubc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubc/subscriptions","organizations_url":"https://api.github.com/users/ubc/orgs","repos_url":"https://api.github.com/users/ubc/repos","events_url":"https://api.github.com/users/ubc/events{/privacy}","received_events_url":"https://api.github.com/users/ubc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ubc/compair","description":"ComPAIR: a learning application pairing student answers for deeper learning through comparison of peer work","fork":false,"url":"https://api.github.com/repos/ubc/compair","forks_url":"https://api.github.com/repos/ubc/compair/forks","keys_url":"https://api.github.com/repos/ubc/compair/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ubc/compair/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ubc/compair/teams","hooks_url":"https://api.github.com/repos/ubc/compair/hooks","issue_events_url":"https://api.github.com/repos/ubc/compair/issues/events{/number}","events_url":"https://api.github.com/repos/ubc/compair/events","assignees_url":"https://api.github.com/repos/ubc/compair/assignees{/user}","branches_url":"https://api.github.com/repos/ubc/compair/branches{/branch}","tags_url":"https://api.github.com/repos/ubc/compair/tags","blobs_url":"https://api.github.com/repos/ubc/compair/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ubc/compair/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ubc/compair/git/refs{/sha}","trees_url":"https://api.github.com/repos/ubc/compair/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ubc/compair/statuses/{sha}","languages_url":"https://api.github.com/repos/ubc/compair/languages","stargazers_url":"https://api.github.com/repos/ubc/compair/stargazers","contributors_url":"https://api.github.com/repos/ubc/compair/contributors","subscribers_url":"https://api.github.com/repos/ubc/compair/subscribers","subscription_url":"https://api.github.com/repos/ubc/compair/subscription","commits_url":"https://api.github.com/repos/ubc/compair/commits{/sha}","git_commits_url":"https://api.github.com/repos/ubc/compair/git/commits{/sha}","comments_url":"https://api.github.com/repos/ubc/compair/comments{/number}","issue_comment_url":"https://api.github.com/repos/ubc/compair/issues/comments{/number}","contents_url":"https://api.github.com/repos/ubc/compair/contents/{+path}","compare_url":"https://api.github.com/repos/ubc/compair/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ubc/compair/merges","archive_url":"https://api.github.com/repos/ubc/compair/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ubc/compair/downloads","issues_url":"https://api.github.com/repos/ubc/compair/issues{/number}","pulls_url":"https://api.github.com/repos/ubc/compair/pulls{/number}","milestones_url":"https://api.github.com/repos/ubc/compair/milestones{/number}","notifications_url":"https://api.github.com/repos/ubc/compair/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ubc/compair/labels{/name}","releases_url":"https://api.github.com/repos/ubc/compair/releases{/id}","deployments_url":"https://api.github.com/repos/ubc/compair/deployments","created_at":"2013-06-10T18:52:38Z","updated_at":"2018-06-15T18:09:00Z","pushed_at":"2018-06-25T20:20:19Z","git_url":"git://github.com/ubc/compair.git","ssh_url":"git@github.com:ubc/compair.git","clone_url":"https://github.com/ubc/compair.git","svn_url":"https://github.com/ubc/compair","homepage":"http://ubc.github.io/compair","size":16642,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":3,"open_issues":59,"watchers":12,"default_branch":"master"}},"base":{"label":"ubc:master","ref":"master","sha":"15d527e591e1b09f32d2a340091b66730b37fbce","user":{"login":"ubc","id":1396118,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTYxMTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1396118?v=4","gravatar_id":"","url":"https://api.github.com/users/ubc","html_url":"https://github.com/ubc","followers_url":"https://api.github.com/users/ubc/followers","following_url":"https://api.github.com/users/ubc/following{/other_user}","gists_url":"https://api.github.com/users/ubc/gists{/gist_id}","starred_url":"https://api.github.com/users/ubc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubc/subscriptions","organizations_url":"https://api.github.com/users/ubc/orgs","repos_url":"https://api.github.com/users/ubc/repos","events_url":"https://api.github.com/users/ubc/events{/privacy}","received_events_url":"https://api.github.com/users/ubc/received_events","type":"Organization","site_admin":false},"repo":{"id":10607020,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYwNzAyMA==","name":"compair","full_name":"ubc/compair","owner":{"login":"ubc","id":1396118,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTYxMTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1396118?v=4","gravatar_id":"","url":"https://api.github.com/users/ubc","html_url":"https://github.com/ubc","followers_url":"https://api.github.com/users/ubc/followers","following_url":"https://api.github.com/users/ubc/following{/other_user}","gists_url":"https://api.github.com/users/ubc/gists{/gist_id}","starred_url":"https://api.github.com/users/ubc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubc/subscriptions","organizations_url":"https://api.github.com/users/ubc/orgs","repos_url":"https://api.github.com/users/ubc/repos","events_url":"https://api.github.com/users/ubc/events{/privacy}","received_events_url":"https://api.github.com/users/ubc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ubc/compair","description":"ComPAIR: a learning application pairing student answers for deeper learning through comparison of peer work","fork":false,"url":"https://api.github.com/repos/ubc/compair","forks_url":"https://api.github.com/repos/ubc/compair/forks","keys_url":"https://api.github.com/repos/ubc/compair/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ubc/compair/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ubc/compair/teams","hooks_url":"https://api.github.com/repos/ubc/compair/hooks","issue_events_url":"https://api.github.com/repos/ubc/compair/issues/events{/number}","events_url":"https://api.github.com/repos/ubc/compair/events","assignees_url":"https://api.github.com/repos/ubc/compair/assignees{/user}","branches_url":"https://api.github.com/repos/ubc/compair/branches{/branch}","tags_url":"https://api.github.com/repos/ubc/compair/tags","blobs_url":"https://api.github.com/repos/ubc/compair/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ubc/compair/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ubc/compair/git/refs{/sha}","trees_url":"https://api.github.com/repos/ubc/compair/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ubc/compair/statuses/{sha}","languages_url":"https://api.github.com/repos/ubc/compair/languages","stargazers_url":"https://api.github.com/repos/ubc/compair/stargazers","contributors_url":"https://api.github.com/repos/ubc/compair/contributors","subscribers_url":"https://api.github.com/repos/ubc/compair/subscribers","subscription_url":"https://api.github.com/repos/ubc/compair/subscription","commits_url":"https://api.github.com/repos/ubc/compair/commits{/sha}","git_commits_url":"https://api.github.com/repos/ubc/compair/git/commits{/sha}","comments_url":"https://api.github.com/repos/ubc/compair/comments{/number}","issue_comment_url":"https://api.github.com/repos/ubc/compair/issues/comments{/number}","contents_url":"https://api.github.com/repos/ubc/compair/contents/{+path}","compare_url":"https://api.github.com/repos/ubc/compair/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ubc/compair/merges","archive_url":"https://api.github.com/repos/ubc/compair/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ubc/compair/downloads","issues_url":"https://api.github.com/repos/ubc/compair/issues{/number}","pulls_url":"https://api.github.com/repos/ubc/compair/pulls{/number}","milestones_url":"https://api.github.com/repos/ubc/compair/milestones{/number}","notifications_url":"https://api.github.com/repos/ubc/compair/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ubc/compair/labels{/name}","releases_url":"https://api.github.com/repos/ubc/compair/releases{/id}","deployments_url":"https://api.github.com/repos/ubc/compair/deployments","created_at":"2013-06-10T18:52:38Z","updated_at":"2018-06-15T18:09:00Z","pushed_at":"2018-06-25T20:20:19Z","git_url":"git://github.com/ubc/compair.git","ssh_url":"git@github.com:ubc/compair.git","clone_url":"https://github.com/ubc/compair.git","svn_url":"https://github.com/ubc/compair","homepage":"http://ubc.github.io/compair","size":16642,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":3,"open_issues":59,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ubc/compair/pulls/784"},"html":{"href":"https://github.com/ubc/compair/pull/784"},"issue":{"href":"https://api.github.com/repos/ubc/compair/issues/784"},"comments":{"href":"https://api.github.com/repos/ubc/compair/issues/784/comments"},"review_comments":{"href":"https://api.github.com/repos/ubc/compair/pulls/784/comments"},"review_comment":{"href":"https://api.github.com/repos/ubc/compair/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ubc/compair/pulls/784/commits"},"statuses":{"href":"https://api.github.com/repos/ubc/compair/statuses/188c67afe292704134319de83051b8ce01966e0e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kitsook"}}