{"action":"created","comment":{"url":"https://api.github.com/repos/typelevel/cats-effect/pulls/comments/235467464","pull_request_review_id":177340289,"id":235467464,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTQ2NzQ2NA==","diff_hunk":"@@ -73,20 +74,30 @@ abstract class Deferred[F[_], A] {\n   def complete(a: A): F[Unit]\n }\n \n+abstract class TryableDeferred[F[_], A] extends Deferred[F, A]{","path":"core/shared/src/main/scala/cats/effect/concurrent/Deferred.scala","position":12,"original_position":12,"commit_id":"d4d99e779b9ced216286c9b11615aa69f3876c9e","original_commit_id":"d4d99e779b9ced216286c9b11615aa69f3876c9e","user":{"login":"alexandru","id":11753,"node_id":"MDQ6VXNlcjExNzUz","avatar_url":"https://avatars2.githubusercontent.com/u/11753?v=4","gravatar_id":"","url":"https://api.github.com/users/alexandru","html_url":"https://github.com/alexandru","followers_url":"https://api.github.com/users/alexandru/followers","following_url":"https://api.github.com/users/alexandru/following{/other_user}","gists_url":"https://api.github.com/users/alexandru/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandru/subscriptions","organizations_url":"https://api.github.com/users/alexandru/orgs","repos_url":"https://api.github.com/users/alexandru/repos","events_url":"https://api.github.com/users/alexandru/events{/privacy}","received_events_url":"https://api.github.com/users/alexandru/received_events","type":"User","site_admin":false},"body":"Btw, our `abstract class` usage hasn't helped us in adding new operations while maintaining bincompat because we've made the error of not adding the `F[_]` restriction as well. Without `F[_] : Async` or whatever, there isn't much that you can do to add operations.\r\n\r\nSomething to keep in mind for Cats-Effect 2.0.","created_at":"2018-11-21T16:54:13Z","updated_at":"2018-11-21T16:54:13Z","html_url":"https://github.com/typelevel/cats-effect/pull/395#discussion_r235467464","pull_request_url":"https://api.github.com/repos/typelevel/cats-effect/pulls/395","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/typelevel/cats-effect/pulls/comments/235467464"},"html":{"href":"https://github.com/typelevel/cats-effect/pull/395#discussion_r235467464"},"pull_request":{"href":"https://api.github.com/repos/typelevel/cats-effect/pulls/395"}},"in_reply_to_id":226728316},"pull_request":{"url":"https://api.github.com/repos/typelevel/cats-effect/pulls/395","id":223285456,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMjg1NDU2","html_url":"https://github.com/typelevel/cats-effect/pull/395","diff_url":"https://github.com/typelevel/cats-effect/pull/395.diff","patch_url":"https://github.com/typelevel/cats-effect/pull/395.patch","issue_url":"https://api.github.com/repos/typelevel/cats-effect/issues/395","number":395,"state":"open","locked":false,"title":"Add Deferred.tryGet","user":{"login":"Odomontois","id":247558,"node_id":"MDQ6VXNlcjI0NzU1OA==","avatar_url":"https://avatars2.githubusercontent.com/u/247558?v=4","gravatar_id":"","url":"https://api.github.com/users/Odomontois","html_url":"https://github.com/Odomontois","followers_url":"https://api.github.com/users/Odomontois/followers","following_url":"https://api.github.com/users/Odomontois/following{/other_user}","gists_url":"https://api.github.com/users/Odomontois/gists{/gist_id}","starred_url":"https://api.github.com/users/Odomontois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Odomontois/subscriptions","organizations_url":"https://api.github.com/users/Odomontois/orgs","repos_url":"https://api.github.com/users/Odomontois/repos","events_url":"https://api.github.com/users/Odomontois/events{/privacy}","received_events_url":"https://api.github.com/users/Odomontois/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-16T15:00:16Z","updated_at":"2018-11-21T16:54:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4ed4baf4700d879c2c284d7fe3d1cf68e835cdd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/typelevel/cats-effect/pulls/395/commits","review_comments_url":"https://api.github.com/repos/typelevel/cats-effect/pulls/395/comments","review_comment_url":"https://api.github.com/repos/typelevel/cats-effect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/typelevel/cats-effect/issues/395/comments","statuses_url":"https://api.github.com/repos/typelevel/cats-effect/statuses/d4d99e779b9ced216286c9b11615aa69f3876c9e","head":{"label":"Odomontois:deferred-try-get","ref":"deferred-try-get","sha":"d4d99e779b9ced216286c9b11615aa69f3876c9e","user":{"login":"Odomontois","id":247558,"node_id":"MDQ6VXNlcjI0NzU1OA==","avatar_url":"https://avatars2.githubusercontent.com/u/247558?v=4","gravatar_id":"","url":"https://api.github.com/users/Odomontois","html_url":"https://github.com/Odomontois","followers_url":"https://api.github.com/users/Odomontois/followers","following_url":"https://api.github.com/users/Odomontois/following{/other_user}","gists_url":"https://api.github.com/users/Odomontois/gists{/gist_id}","starred_url":"https://api.github.com/users/Odomontois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Odomontois/subscriptions","organizations_url":"https://api.github.com/users/Odomontois/orgs","repos_url":"https://api.github.com/users/Odomontois/repos","events_url":"https://api.github.com/users/Odomontois/events{/privacy}","received_events_url":"https://api.github.com/users/Odomontois/received_events","type":"User","site_admin":false},"repo":{"id":150080676,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAwODA2NzY=","name":"cats-effect","full_name":"Odomontois/cats-effect","private":false,"owner":{"login":"Odomontois","id":247558,"node_id":"MDQ6VXNlcjI0NzU1OA==","avatar_url":"https://avatars2.githubusercontent.com/u/247558?v=4","gravatar_id":"","url":"https://api.github.com/users/Odomontois","html_url":"https://github.com/Odomontois","followers_url":"https://api.github.com/users/Odomontois/followers","following_url":"https://api.github.com/users/Odomontois/following{/other_user}","gists_url":"https://api.github.com/users/Odomontois/gists{/gist_id}","starred_url":"https://api.github.com/users/Odomontois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Odomontois/subscriptions","organizations_url":"https://api.github.com/users/Odomontois/orgs","repos_url":"https://api.github.com/users/Odomontois/repos","events_url":"https://api.github.com/users/Odomontois/events{/privacy}","received_events_url":"https://api.github.com/users/Odomontois/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Odomontois/cats-effect","description":"The IO monad for Scala","fork":true,"url":"https://api.github.com/repos/Odomontois/cats-effect","forks_url":"https://api.github.com/repos/Odomontois/cats-effect/forks","keys_url":"https://api.github.com/repos/Odomontois/cats-effect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Odomontois/cats-effect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Odomontois/cats-effect/teams","hooks_url":"https://api.github.com/repos/Odomontois/cats-effect/hooks","issue_events_url":"https://api.github.com/repos/Odomontois/cats-effect/issues/events{/number}","events_url":"https://api.github.com/repos/Odomontois/cats-effect/events","assignees_url":"https://api.github.com/repos/Odomontois/cats-effect/assignees{/user}","branches_url":"https://api.github.com/repos/Odomontois/cats-effect/branches{/branch}","tags_url":"https://api.github.com/repos/Odomontois/cats-effect/tags","blobs_url":"https://api.github.com/repos/Odomontois/cats-effect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Odomontois/cats-effect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Odomontois/cats-effect/git/refs{/sha}","trees_url":"https://api.github.com/repos/Odomontois/cats-effect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Odomontois/cats-effect/statuses/{sha}","languages_url":"https://api.github.com/repos/Odomontois/cats-effect/languages","stargazers_url":"https://api.github.com/repos/Odomontois/cats-effect/stargazers","contributors_url":"https://api.github.com/repos/Odomontois/cats-effect/contributors","subscribers_url":"https://api.github.com/repos/Odomontois/cats-effect/subscribers","subscription_url":"https://api.github.com/repos/Odomontois/cats-effect/subscription","commits_url":"https://api.github.com/repos/Odomontois/cats-effect/commits{/sha}","git_commits_url":"https://api.github.com/repos/Odomontois/cats-effect/git/commits{/sha}","comments_url":"https://api.github.com/repos/Odomontois/cats-effect/comments{/number}","issue_comment_url":"https://api.github.com/repos/Odomontois/cats-effect/issues/comments{/number}","contents_url":"https://api.github.com/repos/Odomontois/cats-effect/contents/{+path}","compare_url":"https://api.github.com/repos/Odomontois/cats-effect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Odomontois/cats-effect/merges","archive_url":"https://api.github.com/repos/Odomontois/cats-effect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Odomontois/cats-effect/downloads","issues_url":"https://api.github.com/repos/Odomontois/cats-effect/issues{/number}","pulls_url":"https://api.github.com/repos/Odomontois/cats-effect/pulls{/number}","milestones_url":"https://api.github.com/repos/Odomontois/cats-effect/milestones{/number}","notifications_url":"https://api.github.com/repos/Odomontois/cats-effect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Odomontois/cats-effect/labels{/name}","releases_url":"https://api.github.com/repos/Odomontois/cats-effect/releases{/id}","deployments_url":"https://api.github.com/repos/Odomontois/cats-effect/deployments","created_at":"2018-09-24T09:33:36Z","updated_at":"2018-10-16T15:00:03Z","pushed_at":"2018-11-21T13:37:12Z","git_url":"git://github.com/Odomontois/cats-effect.git","ssh_url":"git@github.com:Odomontois/cats-effect.git","clone_url":"https://github.com/Odomontois/cats-effect.git","svn_url":"https://github.com/Odomontois/cats-effect","homepage":"https://typelevel.org/cats-effect/","size":6664,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"typelevel:master","ref":"master","sha":"c0b71639fcfe2daf04989621b3be67f1ad90a4a6","user":{"login":"typelevel","id":3731824,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzE4MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3731824?v=4","gravatar_id":"","url":"https://api.github.com/users/typelevel","html_url":"https://github.com/typelevel","followers_url":"https://api.github.com/users/typelevel/followers","following_url":"https://api.github.com/users/typelevel/following{/other_user}","gists_url":"https://api.github.com/users/typelevel/gists{/gist_id}","starred_url":"https://api.github.com/users/typelevel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typelevel/subscriptions","organizations_url":"https://api.github.com/users/typelevel/orgs","repos_url":"https://api.github.com/users/typelevel/repos","events_url":"https://api.github.com/users/typelevel/events{/privacy}","received_events_url":"https://api.github.com/users/typelevel/received_events","type":"Organization","site_admin":false},"repo":{"id":87653068,"node_id":"MDEwOlJlcG9zaXRvcnk4NzY1MzA2OA==","name":"cats-effect","full_name":"typelevel/cats-effect","private":false,"owner":{"login":"typelevel","id":3731824,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzE4MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3731824?v=4","gravatar_id":"","url":"https://api.github.com/users/typelevel","html_url":"https://github.com/typelevel","followers_url":"https://api.github.com/users/typelevel/followers","following_url":"https://api.github.com/users/typelevel/following{/other_user}","gists_url":"https://api.github.com/users/typelevel/gists{/gist_id}","starred_url":"https://api.github.com/users/typelevel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typelevel/subscriptions","organizations_url":"https://api.github.com/users/typelevel/orgs","repos_url":"https://api.github.com/users/typelevel/repos","events_url":"https://api.github.com/users/typelevel/events{/privacy}","received_events_url":"https://api.github.com/users/typelevel/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/typelevel/cats-effect","description":"The IO monad for Scala","fork":false,"url":"https://api.github.com/repos/typelevel/cats-effect","forks_url":"https://api.github.com/repos/typelevel/cats-effect/forks","keys_url":"https://api.github.com/repos/typelevel/cats-effect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/typelevel/cats-effect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/typelevel/cats-effect/teams","hooks_url":"https://api.github.com/repos/typelevel/cats-effect/hooks","issue_events_url":"https://api.github.com/repos/typelevel/cats-effect/issues/events{/number}","events_url":"https://api.github.com/repos/typelevel/cats-effect/events","assignees_url":"https://api.github.com/repos/typelevel/cats-effect/assignees{/user}","branches_url":"https://api.github.com/repos/typelevel/cats-effect/branches{/branch}","tags_url":"https://api.github.com/repos/typelevel/cats-effect/tags","blobs_url":"https://api.github.com/repos/typelevel/cats-effect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/typelevel/cats-effect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/typelevel/cats-effect/git/refs{/sha}","trees_url":"https://api.github.com/repos/typelevel/cats-effect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/typelevel/cats-effect/statuses/{sha}","languages_url":"https://api.github.com/repos/typelevel/cats-effect/languages","stargazers_url":"https://api.github.com/repos/typelevel/cats-effect/stargazers","contributors_url":"https://api.github.com/repos/typelevel/cats-effect/contributors","subscribers_url":"https://api.github.com/repos/typelevel/cats-effect/subscribers","subscription_url":"https://api.github.com/repos/typelevel/cats-effect/subscription","commits_url":"https://api.github.com/repos/typelevel/cats-effect/commits{/sha}","git_commits_url":"https://api.github.com/repos/typelevel/cats-effect/git/commits{/sha}","comments_url":"https://api.github.com/repos/typelevel/cats-effect/comments{/number}","issue_comment_url":"https://api.github.com/repos/typelevel/cats-effect/issues/comments{/number}","contents_url":"https://api.github.com/repos/typelevel/cats-effect/contents/{+path}","compare_url":"https://api.github.com/repos/typelevel/cats-effect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/typelevel/cats-effect/merges","archive_url":"https://api.github.com/repos/typelevel/cats-effect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/typelevel/cats-effect/downloads","issues_url":"https://api.github.com/repos/typelevel/cats-effect/issues{/number}","pulls_url":"https://api.github.com/repos/typelevel/cats-effect/pulls{/number}","milestones_url":"https://api.github.com/repos/typelevel/cats-effect/milestones{/number}","notifications_url":"https://api.github.com/repos/typelevel/cats-effect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/typelevel/cats-effect/labels{/name}","releases_url":"https://api.github.com/repos/typelevel/cats-effect/releases{/id}","deployments_url":"https://api.github.com/repos/typelevel/cats-effect/deployments","created_at":"2017-04-08T17:55:13Z","updated_at":"2018-11-21T16:49:19Z","pushed_at":"2018-11-21T16:49:15Z","git_url":"git://github.com/typelevel/cats-effect.git","ssh_url":"git@github.com:typelevel/cats-effect.git","clone_url":"https://github.com/typelevel/cats-effect.git","svn_url":"https://github.com/typelevel/cats-effect","homepage":"https://typelevel.org/cats-effect/","size":7220,"stargazers_count":505,"watchers_count":505,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":124,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":124,"open_issues":52,"watchers":505,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/typelevel/cats-effect/pulls/395"},"html":{"href":"https://github.com/typelevel/cats-effect/pull/395"},"issue":{"href":"https://api.github.com/repos/typelevel/cats-effect/issues/395"},"comments":{"href":"https://api.github.com/repos/typelevel/cats-effect/issues/395/comments"},"review_comments":{"href":"https://api.github.com/repos/typelevel/cats-effect/pulls/395/comments"},"review_comment":{"href":"https://api.github.com/repos/typelevel/cats-effect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/typelevel/cats-effect/pulls/395/commits"},"statuses":{"href":"https://api.github.com/repos/typelevel/cats-effect/statuses/d4d99e779b9ced216286c9b11615aa69f3876c9e"}},"author_association":"NONE"}}
{"actor":{"display_login":"alexandru"}}