{"action":"created","issue":{"url":"https://api.github.com/repos/terryma/vim-multiple-cursors/issues/238","repository_url":"https://api.github.com/repos/terryma/vim-multiple-cursors","labels_url":"https://api.github.com/repos/terryma/vim-multiple-cursors/issues/238/labels{/name}","comments_url":"https://api.github.com/repos/terryma/vim-multiple-cursors/issues/238/comments","events_url":"https://api.github.com/repos/terryma/vim-multiple-cursors/issues/238/events","html_url":"https://github.com/terryma/vim-multiple-cursors/pull/238","id":295653466,"number":238,"title":"Fix cursors update when number of lines changes","user":{"login":"antoinemadec","id":10830594,"avatar_url":"https://avatars1.githubusercontent.com/u/10830594?v=4","gravatar_id":"","url":"https://api.github.com/users/antoinemadec","html_url":"https://github.com/antoinemadec","followers_url":"https://api.github.com/users/antoinemadec/followers","following_url":"https://api.github.com/users/antoinemadec/following{/other_user}","gists_url":"https://api.github.com/users/antoinemadec/gists{/gist_id}","starred_url":"https://api.github.com/users/antoinemadec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoinemadec/subscriptions","organizations_url":"https://api.github.com/users/antoinemadec/orgs","repos_url":"https://api.github.com/users/antoinemadec/repos","events_url":"https://api.github.com/users/antoinemadec/events{/privacy}","received_events_url":"https://api.github.com/users/antoinemadec/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-02-08T20:24:46Z","updated_at":"2018-02-09T13:55:42Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/terryma/vim-multiple-cursors/pulls/238","html_url":"https://github.com/terryma/vim-multiple-cursors/pull/238","diff_url":"https://github.com/terryma/vim-multiple-cursors/pull/238.diff","patch_url":"https://github.com/terryma/vim-multiple-cursors/pull/238.patch"},"body":"Updates where starting at index=size-1 and wrapping instead of starting at index=0\r\n\r\nThen inserting cursors here and doing **backspace**:\r\n```\r\n|mon\r\n|tue\r\n|wed\r\n```\r\nYou would loose the last cursor because cursor update was done in the order index=2, 0, 1 (see **s:CursorManager.update_current()**):\r\n```\r\n|mon|tuewed\r\n```\r\n\r\nThis PR fixes it by updating cursors in the order index=0, 1, 2:\r\n```\r\n|mon|tue|wed\r\n```\r\n\r\nI did not notice any regression. It might fix #234: I observed a different behavior, but the issue description is a bit messy, so it is hard to see if it fixes the issue.\r\n\r\nPlease note that putting the cursor at the **end of the line** and pressing **del** is still flaky.\r\nNothing to do with my PR as it was already the case before, but I will try to tackle that when I have time.\r\n\r\nCheers,\r\nAntoine"},"comment":{"url":"https://api.github.com/repos/terryma/vim-multiple-cursors/issues/comments/364439905","html_url":"https://github.com/terryma/vim-multiple-cursors/pull/238#issuecomment-364439905","issue_url":"https://api.github.com/repos/terryma/vim-multiple-cursors/issues/238","id":364439905,"user":{"login":"eapache","id":1706826,"avatar_url":"https://avatars1.githubusercontent.com/u/1706826?v=4","gravatar_id":"","url":"https://api.github.com/users/eapache","html_url":"https://github.com/eapache","followers_url":"https://api.github.com/users/eapache/followers","following_url":"https://api.github.com/users/eapache/following{/other_user}","gists_url":"https://api.github.com/users/eapache/gists{/gist_id}","starred_url":"https://api.github.com/users/eapache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eapache/subscriptions","organizations_url":"https://api.github.com/users/eapache/orgs","repos_url":"https://api.github.com/users/eapache/repos","events_url":"https://api.github.com/users/eapache/events{/privacy}","received_events_url":"https://api.github.com/users/eapache/received_events","type":"User","site_admin":false},"created_at":"2018-02-09T13:55:42Z","updated_at":"2018-02-09T13:55:42Z","author_association":"COLLABORATOR","body":"Occasionally the vim automation tool is just a little flaky; a keystroke gets missed or something and the state ends up wrong. I re-ran CI and it passed the second time.\r\n\r\nThanks for your work on this!"}}
{"actor":{"display_login":"eapache"}}