{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments/212392233","pull_request_review_id":149015779,"id":212392233,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjM5MjIzMw==","diff_hunk":"@@ -116,6 +116,45 @@ MXNET_OPERATOR_REGISTER_BINARY(_backward_softmax)\n .set_attr<FCompute>(\"FCompute<cpu>\", SoftmaxGradCompute<cpu, op::mshadow_op::mul,\n                                                         mxnet_op::softmax_bwd>);\n \n+MXNET_OPERATOR_REGISTER_UNARY(softmin)\n+.describe(R\"code(Applies the softmin function.\n+\n+The resulting array contains elements in the range (0,1) and the elements along the given axis sum\n+up to 1. Equivalant to `softmax(-z)` where `softmax(z)` is defined as:\n+\n+.. math::\n+   softmax(\\mathbf{z/t})_j = \\frac{e^{z_j/t}}{\\sum_{k=1}^K e^{z_k/t}}\n+\n+for :math:`j = 1, ..., K`\n+\n+t is the temperature parameter in softmax function. By default, t equals 1.0\n+\n+Example::\n+\n+  x = [[ 1.  2.  3.]\n+       [ 3.  2.  1.]]\n+\n+  softmax(x,axis=0) = [[ 0.88079703,  0.5,  0.11920292],","path":"src/operator/nn/softmax.cc","position":22,"original_position":22,"commit_id":"d6898cdb27384fe8c6b737a80888901c84fc2222","original_commit_id":"d6898cdb27384fe8c6b737a80888901c84fc2222","user":{"login":"haojin2","id":11465736,"node_id":"MDQ6VXNlcjExNDY1NzM2","avatar_url":"https://avatars3.githubusercontent.com/u/11465736?v=4","gravatar_id":"","url":"https://api.github.com/users/haojin2","html_url":"https://github.com/haojin2","followers_url":"https://api.github.com/users/haojin2/followers","following_url":"https://api.github.com/users/haojin2/following{/other_user}","gists_url":"https://api.github.com/users/haojin2/gists{/gist_id}","starred_url":"https://api.github.com/users/haojin2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haojin2/subscriptions","organizations_url":"https://api.github.com/users/haojin2/orgs","repos_url":"https://api.github.com/users/haojin2/repos","events_url":"https://api.github.com/users/haojin2/events{/privacy}","received_events_url":"https://api.github.com/users/haojin2/received_events","type":"User","site_admin":false},"body":"Please read the doc carefully before you make a comment.","created_at":"2018-08-23T17:27:36Z","updated_at":"2018-08-23T17:27:36Z","html_url":"https://github.com/apache/incubator-mxnet/pull/12306#discussion_r212392233","pull_request_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/12306","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments/212392233"},"html":{"href":"https://github.com/apache/incubator-mxnet/pull/12306#discussion_r212392233"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/12306"}},"in_reply_to_id":212373939},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/12306","id":210348630,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMzQ4NjMw","html_url":"https://github.com/apache/incubator-mxnet/pull/12306","diff_url":"https://github.com/apache/incubator-mxnet/pull/12306.diff","patch_url":"https://github.com/apache/incubator-mxnet/pull/12306.patch","issue_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/12306","number":12306,"state":"open","locked":false,"title":"SoftMin Operator","user":{"login":"haojin2","id":11465736,"node_id":"MDQ6VXNlcjExNDY1NzM2","avatar_url":"https://avatars3.githubusercontent.com/u/11465736?v=4","gravatar_id":"","url":"https://api.github.com/users/haojin2","html_url":"https://github.com/haojin2","followers_url":"https://api.github.com/users/haojin2/followers","following_url":"https://api.github.com/users/haojin2/following{/other_user}","gists_url":"https://api.github.com/users/haojin2/gists{/gist_id}","starred_url":"https://api.github.com/users/haojin2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haojin2/subscriptions","organizations_url":"https://api.github.com/users/haojin2/orgs","repos_url":"https://api.github.com/users/haojin2/repos","events_url":"https://api.github.com/users/haojin2/events{/privacy}","received_events_url":"https://api.github.com/users/haojin2/received_events","type":"User","site_admin":false},"body":"## Description ##\r\nSupport softmin function: https://pytorch.org/docs/master/_modules/torch/nn/functional.html#softmin\r\n\r\n## Checklist ##\r\n### Essentials ###\r\n- [x] Changes are complete (i.e. I finished coding on this PR)\r\n- [x] All changes have test coverage:\r\n- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)\r\n- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)\r\n- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)\r\n- [x] Code is well-documented: \r\n- For user-facing API changes, API doc string has been updated. \r\n- For new C++ functions in header files, their functionalities and arguments are documented. \r\n- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable\r\n- Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html\r\n- [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change\r\n\r\n### Changes ###\r\n- [x] Softmin operator\r\n- [x] Corresponding unit tests\r\n\r\n## Comments ##\r\nPassed more than 10000 trials on both CPU & GPU:\r\n```\r\nMXNET_TEST_COUNT=10000 nosetests -s --verbose tests/python/unittest/test_operator.py:test_softmin\r\n[INFO] Setting module np/mx/python random seeds, use MXNET_MODULE_SEED=53121875 to reproduce.\r\ntest_operator.test_softmin ... ok\r\n\r\n----------------------------------------------------------------------\r\nRan 1 test in 670.955s\r\n\r\nOK\r\n```\r\n```\r\nMXNET_TEST_COUNT=10000 nosetests -s --verbose tests/python/gpu/test_operator_gpu.py:test_softmin\r\n[INFO] Setting module np/mx/python random seeds, use MXNET_MODULE_SEED=207344053 to reproduce.\r\ntest_operator_gpu.test_softmin ... ok\r\n\r\n----------------------------------------------------------------------\r\nRan 1 test in 946.723s\r\n\r\nOK\r\n```","created_at":"2018-08-23T06:58:51Z","updated_at":"2018-08-23T17:27:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8a52bf788a0ba19f09c426f02dd468d34251dcb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"anirudh2290","id":1522319,"node_id":"MDQ6VXNlcjE1MjIzMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1522319?v=4","gravatar_id":"","url":"https://api.github.com/users/anirudh2290","html_url":"https://github.com/anirudh2290","followers_url":"https://api.github.com/users/anirudh2290/followers","following_url":"https://api.github.com/users/anirudh2290/following{/other_user}","gists_url":"https://api.github.com/users/anirudh2290/gists{/gist_id}","starred_url":"https://api.github.com/users/anirudh2290/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anirudh2290/subscriptions","organizations_url":"https://api.github.com/users/anirudh2290/orgs","repos_url":"https://api.github.com/users/anirudh2290/repos","events_url":"https://api.github.com/users/anirudh2290/events{/privacy}","received_events_url":"https://api.github.com/users/anirudh2290/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/12306/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/12306/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/12306/comments","statuses_url":"https://api.github.com/repos/apache/incubator-mxnet/statuses/d6898cdb27384fe8c6b737a80888901c84fc2222","head":{"label":"haojin2:softmin","ref":"softmin","sha":"d6898cdb27384fe8c6b737a80888901c84fc2222","user":{"login":"haojin2","id":11465736,"node_id":"MDQ6VXNlcjExNDY1NzM2","avatar_url":"https://avatars3.githubusercontent.com/u/11465736?v=4","gravatar_id":"","url":"https://api.github.com/users/haojin2","html_url":"https://github.com/haojin2","followers_url":"https://api.github.com/users/haojin2/followers","following_url":"https://api.github.com/users/haojin2/following{/other_user}","gists_url":"https://api.github.com/users/haojin2/gists{/gist_id}","starred_url":"https://api.github.com/users/haojin2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haojin2/subscriptions","organizations_url":"https://api.github.com/users/haojin2/orgs","repos_url":"https://api.github.com/users/haojin2/repos","events_url":"https://api.github.com/users/haojin2/events{/privacy}","received_events_url":"https://api.github.com/users/haojin2/received_events","type":"User","site_admin":false},"repo":{"id":114436356,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ0MzYzNTY=","name":"incubator-mxnet","full_name":"haojin2/incubator-mxnet","owner":{"login":"haojin2","id":11465736,"node_id":"MDQ6VXNlcjExNDY1NzM2","avatar_url":"https://avatars3.githubusercontent.com/u/11465736?v=4","gravatar_id":"","url":"https://api.github.com/users/haojin2","html_url":"https://github.com/haojin2","followers_url":"https://api.github.com/users/haojin2/followers","following_url":"https://api.github.com/users/haojin2/following{/other_user}","gists_url":"https://api.github.com/users/haojin2/gists{/gist_id}","starred_url":"https://api.github.com/users/haojin2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haojin2/subscriptions","organizations_url":"https://api.github.com/users/haojin2/orgs","repos_url":"https://api.github.com/users/haojin2/repos","events_url":"https://api.github.com/users/haojin2/events{/privacy}","received_events_url":"https://api.github.com/users/haojin2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/haojin2/incubator-mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":true,"url":"https://api.github.com/repos/haojin2/incubator-mxnet","forks_url":"https://api.github.com/repos/haojin2/incubator-mxnet/forks","keys_url":"https://api.github.com/repos/haojin2/incubator-mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haojin2/incubator-mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haojin2/incubator-mxnet/teams","hooks_url":"https://api.github.com/repos/haojin2/incubator-mxnet/hooks","issue_events_url":"https://api.github.com/repos/haojin2/incubator-mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/haojin2/incubator-mxnet/events","assignees_url":"https://api.github.com/repos/haojin2/incubator-mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/haojin2/incubator-mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/haojin2/incubator-mxnet/tags","blobs_url":"https://api.github.com/repos/haojin2/incubator-mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haojin2/incubator-mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haojin2/incubator-mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/haojin2/incubator-mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haojin2/incubator-mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/haojin2/incubator-mxnet/languages","stargazers_url":"https://api.github.com/repos/haojin2/incubator-mxnet/stargazers","contributors_url":"https://api.github.com/repos/haojin2/incubator-mxnet/contributors","subscribers_url":"https://api.github.com/repos/haojin2/incubator-mxnet/subscribers","subscription_url":"https://api.github.com/repos/haojin2/incubator-mxnet/subscription","commits_url":"https://api.github.com/repos/haojin2/incubator-mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/haojin2/incubator-mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/haojin2/incubator-mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/haojin2/incubator-mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/haojin2/incubator-mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/haojin2/incubator-mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haojin2/incubator-mxnet/merges","archive_url":"https://api.github.com/repos/haojin2/incubator-mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haojin2/incubator-mxnet/downloads","issues_url":"https://api.github.com/repos/haojin2/incubator-mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/haojin2/incubator-mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/haojin2/incubator-mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/haojin2/incubator-mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haojin2/incubator-mxnet/labels{/name}","releases_url":"https://api.github.com/repos/haojin2/incubator-mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/haojin2/incubator-mxnet/deployments","created_at":"2017-12-16T05:29:32Z","updated_at":"2018-08-21T22:11:14Z","pushed_at":"2018-08-23T07:09:25Z","git_url":"git://github.com/haojin2/incubator-mxnet.git","ssh_url":"git@github.com:haojin2/incubator-mxnet.git","clone_url":"https://github.com/haojin2/incubator-mxnet.git","svn_url":"https://github.com/haojin2/incubator-mxnet","homepage":"http://mxnet.io","size":41574,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"84b3b565bc11900ca6ce06364c04ffe33069a810","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":34864402,"node_id":"MDEwOlJlcG9zaXRvcnkzNDg2NDQwMg==","name":"incubator-mxnet","full_name":"apache/incubator-mxnet","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":false,"url":"https://api.github.com/repos/apache/incubator-mxnet","forks_url":"https://api.github.com/repos/apache/incubator-mxnet/forks","keys_url":"https://api.github.com/repos/apache/incubator-mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-mxnet/teams","hooks_url":"https://api.github.com/repos/apache/incubator-mxnet/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-mxnet/events","assignees_url":"https://api.github.com/repos/apache/incubator-mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-mxnet/tags","blobs_url":"https://api.github.com/repos/apache/incubator-mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-mxnet/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-mxnet/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-mxnet/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-mxnet/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-mxnet/subscription","commits_url":"https://api.github.com/repos/apache/incubator-mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-mxnet/merges","archive_url":"https://api.github.com/repos/apache/incubator-mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-mxnet/downloads","issues_url":"https://api.github.com/repos/apache/incubator-mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-mxnet/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-mxnet/deployments","created_at":"2015-04-30T16:21:15Z","updated_at":"2018-08-23T16:32:47Z","pushed_at":"2018-08-23T16:52:04Z","git_url":"git://github.com/apache/incubator-mxnet.git","ssh_url":"git@github.com:apache/incubator-mxnet.git","clone_url":"https://github.com/apache/incubator-mxnet.git","svn_url":"https://github.com/apache/incubator-mxnet","homepage":"https://mxnet.apache.org","size":41895,"stargazers_count":15059,"watchers_count":15059,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5464,"mirror_url":null,"archived":false,"open_issues_count":883,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5464,"open_issues":883,"watchers":15059,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/12306"},"html":{"href":"https://github.com/apache/incubator-mxnet/pull/12306"},"issue":{"href":"https://api.github.com/repos/apache/incubator-mxnet/issues/12306"},"comments":{"href":"https://api.github.com/repos/apache/incubator-mxnet/issues/12306/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/12306/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/12306/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-mxnet/statuses/d6898cdb27384fe8c6b737a80888901c84fc2222"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"haojin2"}}