{"action":"created","comment":{"url":"https://api.github.com/repos/absinthe-graphql/dataloader/pulls/comments/166189802","pull_request_review_id":94227344,"id":166189802,"diff_hunk":"@@ -195,8 +238,41 @@ defmodule Dataloader.EctoTest do\n     assert_receive(:querying)\n   end\n \n-  defp query(queryable, _args, test_pid) do\n-    send(test_pid, :querying)\n-    queryable\n+  test \"we handle a variety of key possibilities\", %{loader: loader} do","path":"test/dataloader/ecto_test.exs","position":181,"original_position":181,"commit_id":"f4712f794efaaf012a4bda6b24430624a548e7df","original_commit_id":"f4712f794efaaf012a4bda6b24430624a548e7df","user":{"login":"benwilson512","id":247817,"avatar_url":"https://avatars1.githubusercontent.com/u/247817?v=4","gravatar_id":"","url":"https://api.github.com/users/benwilson512","html_url":"https://github.com/benwilson512","followers_url":"https://api.github.com/users/benwilson512/followers","following_url":"https://api.github.com/users/benwilson512/following{/other_user}","gists_url":"https://api.github.com/users/benwilson512/gists{/gist_id}","starred_url":"https://api.github.com/users/benwilson512/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benwilson512/subscriptions","organizations_url":"https://api.github.com/users/benwilson512/orgs","repos_url":"https://api.github.com/users/benwilson512/repos","events_url":"https://api.github.com/users/benwilson512/events{/privacy}","received_events_url":"https://api.github.com/users/benwilson512/received_events","type":"User","site_admin":false},"body":"Handy catalog of the various possibilities.","created_at":"2018-02-06T05:21:45Z","updated_at":"2018-02-06T05:21:47Z","html_url":"https://github.com/absinthe-graphql/dataloader/pull/11#discussion_r166189802","pull_request_url":"https://api.github.com/repos/absinthe-graphql/dataloader/pulls/11","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/absinthe-graphql/dataloader/pulls/comments/166189802"},"html":{"href":"https://github.com/absinthe-graphql/dataloader/pull/11#discussion_r166189802"},"pull_request":{"href":"https://api.github.com/repos/absinthe-graphql/dataloader/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/absinthe-graphql/dataloader/pulls/11","id":166354784,"html_url":"https://github.com/absinthe-graphql/dataloader/pull/11","diff_url":"https://github.com/absinthe-graphql/dataloader/pull/11.diff","patch_url":"https://github.com/absinthe-graphql/dataloader/pull/11.patch","issue_url":"https://api.github.com/repos/absinthe-graphql/dataloader/issues/11","number":11,"state":"open","locked":false,"title":"[WIP] Ecto batch fun","user":{"login":"benwilson512","id":247817,"avatar_url":"https://avatars1.githubusercontent.com/u/247817?v=4","gravatar_id":"","url":"https://api.github.com/users/benwilson512","html_url":"https://github.com/benwilson512","followers_url":"https://api.github.com/users/benwilson512/followers","following_url":"https://api.github.com/users/benwilson512/following{/other_user}","gists_url":"https://api.github.com/users/benwilson512/gists{/gist_id}","starred_url":"https://api.github.com/users/benwilson512/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benwilson512/subscriptions","organizations_url":"https://api.github.com/users/benwilson512/orgs","repos_url":"https://api.github.com/users/benwilson512/repos","events_url":"https://api.github.com/users/benwilson512/events{/privacy}","received_events_url":"https://api.github.com/users/benwilson512/received_events","type":"User","site_admin":false},"body":"Fixes #5 \r\n\r\nMore description will be added once the PR is more complete.\r\n\r\nRemaining: \r\n\r\n- [x] basic batch function\r\n- [x] cardinality handling\r\n- [x] through handling.","created_at":"2018-01-31T19:32:22Z","updated_at":"2018-02-06T05:21:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41cf136b0df2bef7131feb69efcdee9c16b94dff","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/absinthe-graphql/dataloader/pulls/11/commits","review_comments_url":"https://api.github.com/repos/absinthe-graphql/dataloader/pulls/11/comments","review_comment_url":"https://api.github.com/repos/absinthe-graphql/dataloader/pulls/comments{/number}","comments_url":"https://api.github.com/repos/absinthe-graphql/dataloader/issues/11/comments","statuses_url":"https://api.github.com/repos/absinthe-graphql/dataloader/statuses/f4712f794efaaf012a4bda6b24430624a548e7df","head":{"label":"absinthe-graphql:ecto-batch-fun","ref":"ecto-batch-fun","sha":"f4712f794efaaf012a4bda6b24430624a548e7df","user":{"login":"absinthe-graphql","id":16964118,"avatar_url":"https://avatars2.githubusercontent.com/u/16964118?v=4","gravatar_id":"","url":"https://api.github.com/users/absinthe-graphql","html_url":"https://github.com/absinthe-graphql","followers_url":"https://api.github.com/users/absinthe-graphql/followers","following_url":"https://api.github.com/users/absinthe-graphql/following{/other_user}","gists_url":"https://api.github.com/users/absinthe-graphql/gists{/gist_id}","starred_url":"https://api.github.com/users/absinthe-graphql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/absinthe-graphql/subscriptions","organizations_url":"https://api.github.com/users/absinthe-graphql/orgs","repos_url":"https://api.github.com/users/absinthe-graphql/repos","events_url":"https://api.github.com/users/absinthe-graphql/events{/privacy}","received_events_url":"https://api.github.com/users/absinthe-graphql/received_events","type":"Organization","site_admin":false},"repo":{"id":106183076,"name":"dataloader","full_name":"absinthe-graphql/dataloader","owner":{"login":"absinthe-graphql","id":16964118,"avatar_url":"https://avatars2.githubusercontent.com/u/16964118?v=4","gravatar_id":"","url":"https://api.github.com/users/absinthe-graphql","html_url":"https://github.com/absinthe-graphql","followers_url":"https://api.github.com/users/absinthe-graphql/followers","following_url":"https://api.github.com/users/absinthe-graphql/following{/other_user}","gists_url":"https://api.github.com/users/absinthe-graphql/gists{/gist_id}","starred_url":"https://api.github.com/users/absinthe-graphql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/absinthe-graphql/subscriptions","organizations_url":"https://api.github.com/users/absinthe-graphql/orgs","repos_url":"https://api.github.com/users/absinthe-graphql/repos","events_url":"https://api.github.com/users/absinthe-graphql/events{/privacy}","received_events_url":"https://api.github.com/users/absinthe-graphql/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/absinthe-graphql/dataloader","description":"DataLoader for Elixir","fork":false,"url":"https://api.github.com/repos/absinthe-graphql/dataloader","forks_url":"https://api.github.com/repos/absinthe-graphql/dataloader/forks","keys_url":"https://api.github.com/repos/absinthe-graphql/dataloader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/absinthe-graphql/dataloader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/absinthe-graphql/dataloader/teams","hooks_url":"https://api.github.com/repos/absinthe-graphql/dataloader/hooks","issue_events_url":"https://api.github.com/repos/absinthe-graphql/dataloader/issues/events{/number}","events_url":"https://api.github.com/repos/absinthe-graphql/dataloader/events","assignees_url":"https://api.github.com/repos/absinthe-graphql/dataloader/assignees{/user}","branches_url":"https://api.github.com/repos/absinthe-graphql/dataloader/branches{/branch}","tags_url":"https://api.github.com/repos/absinthe-graphql/dataloader/tags","blobs_url":"https://api.github.com/repos/absinthe-graphql/dataloader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/absinthe-graphql/dataloader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/absinthe-graphql/dataloader/git/refs{/sha}","trees_url":"https://api.github.com/repos/absinthe-graphql/dataloader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/absinthe-graphql/dataloader/statuses/{sha}","languages_url":"https://api.github.com/repos/absinthe-graphql/dataloader/languages","stargazers_url":"https://api.github.com/repos/absinthe-graphql/dataloader/stargazers","contributors_url":"https://api.github.com/repos/absinthe-graphql/dataloader/contributors","subscribers_url":"https://api.github.com/repos/absinthe-graphql/dataloader/subscribers","subscription_url":"https://api.github.com/repos/absinthe-graphql/dataloader/subscription","commits_url":"https://api.github.com/repos/absinthe-graphql/dataloader/commits{/sha}","git_commits_url":"https://api.github.com/repos/absinthe-graphql/dataloader/git/commits{/sha}","comments_url":"https://api.github.com/repos/absinthe-graphql/dataloader/comments{/number}","issue_comment_url":"https://api.github.com/repos/absinthe-graphql/dataloader/issues/comments{/number}","contents_url":"https://api.github.com/repos/absinthe-graphql/dataloader/contents/{+path}","compare_url":"https://api.github.com/repos/absinthe-graphql/dataloader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/absinthe-graphql/dataloader/merges","archive_url":"https://api.github.com/repos/absinthe-graphql/dataloader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/absinthe-graphql/dataloader/downloads","issues_url":"https://api.github.com/repos/absinthe-graphql/dataloader/issues{/number}","pulls_url":"https://api.github.com/repos/absinthe-graphql/dataloader/pulls{/number}","milestones_url":"https://api.github.com/repos/absinthe-graphql/dataloader/milestones{/number}","notifications_url":"https://api.github.com/repos/absinthe-graphql/dataloader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/absinthe-graphql/dataloader/labels{/name}","releases_url":"https://api.github.com/repos/absinthe-graphql/dataloader/releases{/id}","deployments_url":"https://api.github.com/repos/absinthe-graphql/dataloader/deployments","created_at":"2017-10-08T14:34:37Z","updated_at":"2018-02-05T15:39:48Z","pushed_at":"2018-02-06T05:12:24Z","git_url":"git://github.com/absinthe-graphql/dataloader.git","ssh_url":"git@github.com:absinthe-graphql/dataloader.git","clone_url":"https://github.com/absinthe-graphql/dataloader.git","svn_url":"https://github.com/absinthe-graphql/dataloader","homepage":null,"size":53,"stargazers_count":51,"watchers_count":51,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":4,"open_issues":4,"watchers":51,"default_branch":"master"}},"base":{"label":"absinthe-graphql:master","ref":"master","sha":"0fa1d29e48d4b6b65f79b866ab24dc9345687180","user":{"login":"absinthe-graphql","id":16964118,"avatar_url":"https://avatars2.githubusercontent.com/u/16964118?v=4","gravatar_id":"","url":"https://api.github.com/users/absinthe-graphql","html_url":"https://github.com/absinthe-graphql","followers_url":"https://api.github.com/users/absinthe-graphql/followers","following_url":"https://api.github.com/users/absinthe-graphql/following{/other_user}","gists_url":"https://api.github.com/users/absinthe-graphql/gists{/gist_id}","starred_url":"https://api.github.com/users/absinthe-graphql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/absinthe-graphql/subscriptions","organizations_url":"https://api.github.com/users/absinthe-graphql/orgs","repos_url":"https://api.github.com/users/absinthe-graphql/repos","events_url":"https://api.github.com/users/absinthe-graphql/events{/privacy}","received_events_url":"https://api.github.com/users/absinthe-graphql/received_events","type":"Organization","site_admin":false},"repo":{"id":106183076,"name":"dataloader","full_name":"absinthe-graphql/dataloader","owner":{"login":"absinthe-graphql","id":16964118,"avatar_url":"https://avatars2.githubusercontent.com/u/16964118?v=4","gravatar_id":"","url":"https://api.github.com/users/absinthe-graphql","html_url":"https://github.com/absinthe-graphql","followers_url":"https://api.github.com/users/absinthe-graphql/followers","following_url":"https://api.github.com/users/absinthe-graphql/following{/other_user}","gists_url":"https://api.github.com/users/absinthe-graphql/gists{/gist_id}","starred_url":"https://api.github.com/users/absinthe-graphql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/absinthe-graphql/subscriptions","organizations_url":"https://api.github.com/users/absinthe-graphql/orgs","repos_url":"https://api.github.com/users/absinthe-graphql/repos","events_url":"https://api.github.com/users/absinthe-graphql/events{/privacy}","received_events_url":"https://api.github.com/users/absinthe-graphql/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/absinthe-graphql/dataloader","description":"DataLoader for Elixir","fork":false,"url":"https://api.github.com/repos/absinthe-graphql/dataloader","forks_url":"https://api.github.com/repos/absinthe-graphql/dataloader/forks","keys_url":"https://api.github.com/repos/absinthe-graphql/dataloader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/absinthe-graphql/dataloader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/absinthe-graphql/dataloader/teams","hooks_url":"https://api.github.com/repos/absinthe-graphql/dataloader/hooks","issue_events_url":"https://api.github.com/repos/absinthe-graphql/dataloader/issues/events{/number}","events_url":"https://api.github.com/repos/absinthe-graphql/dataloader/events","assignees_url":"https://api.github.com/repos/absinthe-graphql/dataloader/assignees{/user}","branches_url":"https://api.github.com/repos/absinthe-graphql/dataloader/branches{/branch}","tags_url":"https://api.github.com/repos/absinthe-graphql/dataloader/tags","blobs_url":"https://api.github.com/repos/absinthe-graphql/dataloader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/absinthe-graphql/dataloader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/absinthe-graphql/dataloader/git/refs{/sha}","trees_url":"https://api.github.com/repos/absinthe-graphql/dataloader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/absinthe-graphql/dataloader/statuses/{sha}","languages_url":"https://api.github.com/repos/absinthe-graphql/dataloader/languages","stargazers_url":"https://api.github.com/repos/absinthe-graphql/dataloader/stargazers","contributors_url":"https://api.github.com/repos/absinthe-graphql/dataloader/contributors","subscribers_url":"https://api.github.com/repos/absinthe-graphql/dataloader/subscribers","subscription_url":"https://api.github.com/repos/absinthe-graphql/dataloader/subscription","commits_url":"https://api.github.com/repos/absinthe-graphql/dataloader/commits{/sha}","git_commits_url":"https://api.github.com/repos/absinthe-graphql/dataloader/git/commits{/sha}","comments_url":"https://api.github.com/repos/absinthe-graphql/dataloader/comments{/number}","issue_comment_url":"https://api.github.com/repos/absinthe-graphql/dataloader/issues/comments{/number}","contents_url":"https://api.github.com/repos/absinthe-graphql/dataloader/contents/{+path}","compare_url":"https://api.github.com/repos/absinthe-graphql/dataloader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/absinthe-graphql/dataloader/merges","archive_url":"https://api.github.com/repos/absinthe-graphql/dataloader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/absinthe-graphql/dataloader/downloads","issues_url":"https://api.github.com/repos/absinthe-graphql/dataloader/issues{/number}","pulls_url":"https://api.github.com/repos/absinthe-graphql/dataloader/pulls{/number}","milestones_url":"https://api.github.com/repos/absinthe-graphql/dataloader/milestones{/number}","notifications_url":"https://api.github.com/repos/absinthe-graphql/dataloader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/absinthe-graphql/dataloader/labels{/name}","releases_url":"https://api.github.com/repos/absinthe-graphql/dataloader/releases{/id}","deployments_url":"https://api.github.com/repos/absinthe-graphql/dataloader/deployments","created_at":"2017-10-08T14:34:37Z","updated_at":"2018-02-05T15:39:48Z","pushed_at":"2018-02-06T05:12:24Z","git_url":"git://github.com/absinthe-graphql/dataloader.git","ssh_url":"git@github.com:absinthe-graphql/dataloader.git","clone_url":"https://github.com/absinthe-graphql/dataloader.git","svn_url":"https://github.com/absinthe-graphql/dataloader","homepage":null,"size":53,"stargazers_count":51,"watchers_count":51,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":4,"open_issues":4,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/absinthe-graphql/dataloader/pulls/11"},"html":{"href":"https://github.com/absinthe-graphql/dataloader/pull/11"},"issue":{"href":"https://api.github.com/repos/absinthe-graphql/dataloader/issues/11"},"comments":{"href":"https://api.github.com/repos/absinthe-graphql/dataloader/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/absinthe-graphql/dataloader/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/absinthe-graphql/dataloader/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/absinthe-graphql/dataloader/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/absinthe-graphql/dataloader/statuses/f4712f794efaaf012a4bda6b24430624a548e7df"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"benwilson512"}}