{"action":"closed","number":1230,"pull_request":{"url":"https://api.github.com/repos/TokTok/c-toxcore/pulls/1230","id":221272939,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMjcyOTM5","html_url":"https://github.com/TokTok/c-toxcore/pull/1230","diff_url":"https://github.com/TokTok/c-toxcore/pull/1230.diff","patch_url":"https://github.com/TokTok/c-toxcore/pull/1230.patch","issue_url":"https://api.github.com/repos/TokTok/c-toxcore/issues/1230","number":1230,"state":"closed","locked":false,"title":"Add `LOGGER_ASSERT` for checking fatal error conditions.","user":{"login":"iphydf","id":10647936,"node_id":"MDQ6VXNlcjEwNjQ3OTM2","avatar_url":"https://avatars0.githubusercontent.com/u/10647936?v=4","gravatar_id":"","url":"https://api.github.com/users/iphydf","html_url":"https://github.com/iphydf","followers_url":"https://api.github.com/users/iphydf/followers","following_url":"https://api.github.com/users/iphydf/following{/other_user}","gists_url":"https://api.github.com/users/iphydf/gists{/gist_id}","starred_url":"https://api.github.com/users/iphydf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iphydf/subscriptions","organizations_url":"https://api.github.com/users/iphydf/orgs","repos_url":"https://api.github.com/users/iphydf/repos","events_url":"https://api.github.com/users/iphydf/events{/privacy}","received_events_url":"https://api.github.com/users/iphydf/received_events","type":"User","site_admin":false},"body":"These are not compiled out under `NDEBUG` and should be provably correct.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/toktok/c-toxcore/1230)\n<!-- Reviewable:end -->\n","created_at":"2018-10-08T23:54:18Z","updated_at":"2018-10-19T18:16:32Z","closed_at":"2018-10-19T18:16:32Z","merged_at":"2018-10-19T18:16:32Z","merge_commit_sha":"aa5c7828802b3fcaedfd8d6fe9a08ca714b9aa2b","assignee":{"login":"hugbubby","id":37486450,"node_id":"MDQ6VXNlcjM3NDg2NDUw","avatar_url":"https://avatars2.githubusercontent.com/u/37486450?v=4","gravatar_id":"","url":"https://api.github.com/users/hugbubby","html_url":"https://github.com/hugbubby","followers_url":"https://api.github.com/users/hugbubby/followers","following_url":"https://api.github.com/users/hugbubby/following{/other_user}","gists_url":"https://api.github.com/users/hugbubby/gists{/gist_id}","starred_url":"https://api.github.com/users/hugbubby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hugbubby/subscriptions","organizations_url":"https://api.github.com/users/hugbubby/orgs","repos_url":"https://api.github.com/users/hugbubby/repos","events_url":"https://api.github.com/users/hugbubby/events{/privacy}","received_events_url":"https://api.github.com/users/hugbubby/received_events","type":"User","site_admin":false},"assignees":[{"login":"hugbubby","id":37486450,"node_id":"MDQ6VXNlcjM3NDg2NDUw","avatar_url":"https://avatars2.githubusercontent.com/u/37486450?v=4","gravatar_id":"","url":"https://api.github.com/users/hugbubby","html_url":"https://github.com/hugbubby","followers_url":"https://api.github.com/users/hugbubby/followers","following_url":"https://api.github.com/users/hugbubby/following{/other_user}","gists_url":"https://api.github.com/users/hugbubby/gists{/gist_id}","starred_url":"https://api.github.com/users/hugbubby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hugbubby/subscriptions","organizations_url":"https://api.github.com/users/hugbubby/orgs","repos_url":"https://api.github.com/users/hugbubby/repos","events_url":"https://api.github.com/users/hugbubby/events{/privacy}","received_events_url":"https://api.github.com/users/hugbubby/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/TokTok/c-toxcore/milestones/28","html_url":"https://github.com/TokTok/c-toxcore/milestone/28","labels_url":"https://api.github.com/repos/TokTok/c-toxcore/milestones/28/labels","id":3174131,"node_id":"MDk6TWlsZXN0b25lMzE3NDEzMQ==","number":28,"title":"v0.2.x","description":"Placeholder for the next 0.2.x version.","creator":{"login":"iphydf","id":10647936,"node_id":"MDQ6VXNlcjEwNjQ3OTM2","avatar_url":"https://avatars0.githubusercontent.com/u/10647936?v=4","gravatar_id":"","url":"https://api.github.com/users/iphydf","html_url":"https://github.com/iphydf","followers_url":"https://api.github.com/users/iphydf/followers","following_url":"https://api.github.com/users/iphydf/following{/other_user}","gists_url":"https://api.github.com/users/iphydf/gists{/gist_id}","starred_url":"https://api.github.com/users/iphydf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iphydf/subscriptions","organizations_url":"https://api.github.com/users/iphydf/orgs","repos_url":"https://api.github.com/users/iphydf/repos","events_url":"https://api.github.com/users/iphydf/events{/privacy}","received_events_url":"https://api.github.com/users/iphydf/received_events","type":"User","site_admin":false},"open_issues":177,"closed_issues":12,"state":"open","created_at":"2018-03-09T13:13:48Z","updated_at":"2018-10-19T18:16:32Z","due_on":"2018-11-03T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/TokTok/c-toxcore/pulls/1230/commits","review_comments_url":"https://api.github.com/repos/TokTok/c-toxcore/pulls/1230/comments","review_comment_url":"https://api.github.com/repos/TokTok/c-toxcore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TokTok/c-toxcore/issues/1230/comments","statuses_url":"https://api.github.com/repos/TokTok/c-toxcore/statuses/aa5c7828802b3fcaedfd8d6fe9a08ca714b9aa2b","head":{"label":"iphydf:logger-assert","ref":"logger-assert","sha":"aa5c7828802b3fcaedfd8d6fe9a08ca714b9aa2b","user":{"login":"iphydf","id":10647936,"node_id":"MDQ6VXNlcjEwNjQ3OTM2","avatar_url":"https://avatars0.githubusercontent.com/u/10647936?v=4","gravatar_id":"","url":"https://api.github.com/users/iphydf","html_url":"https://github.com/iphydf","followers_url":"https://api.github.com/users/iphydf/followers","following_url":"https://api.github.com/users/iphydf/following{/other_user}","gists_url":"https://api.github.com/users/iphydf/gists{/gist_id}","starred_url":"https://api.github.com/users/iphydf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iphydf/subscriptions","organizations_url":"https://api.github.com/users/iphydf/orgs","repos_url":"https://api.github.com/users/iphydf/repos","events_url":"https://api.github.com/users/iphydf/events{/privacy}","received_events_url":"https://api.github.com/users/iphydf/received_events","type":"User","site_admin":false},"repo":{"id":62716866,"node_id":"MDEwOlJlcG9zaXRvcnk2MjcxNjg2Ng==","name":"c-toxcore","full_name":"iphydf/c-toxcore","private":false,"owner":{"login":"iphydf","id":10647936,"node_id":"MDQ6VXNlcjEwNjQ3OTM2","avatar_url":"https://avatars0.githubusercontent.com/u/10647936?v=4","gravatar_id":"","url":"https://api.github.com/users/iphydf","html_url":"https://github.com/iphydf","followers_url":"https://api.github.com/users/iphydf/followers","following_url":"https://api.github.com/users/iphydf/following{/other_user}","gists_url":"https://api.github.com/users/iphydf/gists{/gist_id}","starred_url":"https://api.github.com/users/iphydf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iphydf/subscriptions","organizations_url":"https://api.github.com/users/iphydf/orgs","repos_url":"https://api.github.com/users/iphydf/repos","events_url":"https://api.github.com/users/iphydf/events{/privacy}","received_events_url":"https://api.github.com/users/iphydf/received_events","type":"User","site_admin":false},"html_url":"https://github.com/iphydf/c-toxcore","description":"The future of online communications.","fork":true,"url":"https://api.github.com/repos/iphydf/c-toxcore","forks_url":"https://api.github.com/repos/iphydf/c-toxcore/forks","keys_url":"https://api.github.com/repos/iphydf/c-toxcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iphydf/c-toxcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iphydf/c-toxcore/teams","hooks_url":"https://api.github.com/repos/iphydf/c-toxcore/hooks","issue_events_url":"https://api.github.com/repos/iphydf/c-toxcore/issues/events{/number}","events_url":"https://api.github.com/repos/iphydf/c-toxcore/events","assignees_url":"https://api.github.com/repos/iphydf/c-toxcore/assignees{/user}","branches_url":"https://api.github.com/repos/iphydf/c-toxcore/branches{/branch}","tags_url":"https://api.github.com/repos/iphydf/c-toxcore/tags","blobs_url":"https://api.github.com/repos/iphydf/c-toxcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iphydf/c-toxcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iphydf/c-toxcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/iphydf/c-toxcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iphydf/c-toxcore/statuses/{sha}","languages_url":"https://api.github.com/repos/iphydf/c-toxcore/languages","stargazers_url":"https://api.github.com/repos/iphydf/c-toxcore/stargazers","contributors_url":"https://api.github.com/repos/iphydf/c-toxcore/contributors","subscribers_url":"https://api.github.com/repos/iphydf/c-toxcore/subscribers","subscription_url":"https://api.github.com/repos/iphydf/c-toxcore/subscription","commits_url":"https://api.github.com/repos/iphydf/c-toxcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/iphydf/c-toxcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/iphydf/c-toxcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/iphydf/c-toxcore/issues/comments{/number}","contents_url":"https://api.github.com/repos/iphydf/c-toxcore/contents/{+path}","compare_url":"https://api.github.com/repos/iphydf/c-toxcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iphydf/c-toxcore/merges","archive_url":"https://api.github.com/repos/iphydf/c-toxcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iphydf/c-toxcore/downloads","issues_url":"https://api.github.com/repos/iphydf/c-toxcore/issues{/number}","pulls_url":"https://api.github.com/repos/iphydf/c-toxcore/pulls{/number}","milestones_url":"https://api.github.com/repos/iphydf/c-toxcore/milestones{/number}","notifications_url":"https://api.github.com/repos/iphydf/c-toxcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iphydf/c-toxcore/labels{/name}","releases_url":"https://api.github.com/repos/iphydf/c-toxcore/releases{/id}","deployments_url":"https://api.github.com/repos/iphydf/c-toxcore/deployments","created_at":"2016-07-06T11:44:34Z","updated_at":"2018-10-17T23:18:41Z","pushed_at":"2018-10-19T18:16:32Z","git_url":"git://github.com/iphydf/c-toxcore.git","ssh_url":"git@github.com:iphydf/c-toxcore.git","clone_url":"https://github.com/iphydf/c-toxcore.git","svn_url":"https://github.com/iphydf/c-toxcore","homepage":"https://tox.chat/","size":18663,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"TokTok:master","ref":"master","sha":"1eaa55d2d4f62e73204d8f68ce05fdebb1ab827c","user":{"login":"TokTok","id":17427091,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDI3MDkx","avatar_url":"https://avatars1.githubusercontent.com/u/17427091?v=4","gravatar_id":"","url":"https://api.github.com/users/TokTok","html_url":"https://github.com/TokTok","followers_url":"https://api.github.com/users/TokTok/followers","following_url":"https://api.github.com/users/TokTok/following{/other_user}","gists_url":"https://api.github.com/users/TokTok/gists{/gist_id}","starred_url":"https://api.github.com/users/TokTok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TokTok/subscriptions","organizations_url":"https://api.github.com/users/TokTok/orgs","repos_url":"https://api.github.com/users/TokTok/repos","events_url":"https://api.github.com/users/TokTok/events{/privacy}","received_events_url":"https://api.github.com/users/TokTok/received_events","type":"Organization","site_admin":false},"repo":{"id":62703642,"node_id":"MDEwOlJlcG9zaXRvcnk2MjcwMzY0Mg==","name":"c-toxcore","full_name":"TokTok/c-toxcore","private":false,"owner":{"login":"TokTok","id":17427091,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDI3MDkx","avatar_url":"https://avatars1.githubusercontent.com/u/17427091?v=4","gravatar_id":"","url":"https://api.github.com/users/TokTok","html_url":"https://github.com/TokTok","followers_url":"https://api.github.com/users/TokTok/followers","following_url":"https://api.github.com/users/TokTok/following{/other_user}","gists_url":"https://api.github.com/users/TokTok/gists{/gist_id}","starred_url":"https://api.github.com/users/TokTok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TokTok/subscriptions","organizations_url":"https://api.github.com/users/TokTok/orgs","repos_url":"https://api.github.com/users/TokTok/repos","events_url":"https://api.github.com/users/TokTok/events{/privacy}","received_events_url":"https://api.github.com/users/TokTok/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/TokTok/c-toxcore","description":"The future of online communications.","fork":true,"url":"https://api.github.com/repos/TokTok/c-toxcore","forks_url":"https://api.github.com/repos/TokTok/c-toxcore/forks","keys_url":"https://api.github.com/repos/TokTok/c-toxcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TokTok/c-toxcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TokTok/c-toxcore/teams","hooks_url":"https://api.github.com/repos/TokTok/c-toxcore/hooks","issue_events_url":"https://api.github.com/repos/TokTok/c-toxcore/issues/events{/number}","events_url":"https://api.github.com/repos/TokTok/c-toxcore/events","assignees_url":"https://api.github.com/repos/TokTok/c-toxcore/assignees{/user}","branches_url":"https://api.github.com/repos/TokTok/c-toxcore/branches{/branch}","tags_url":"https://api.github.com/repos/TokTok/c-toxcore/tags","blobs_url":"https://api.github.com/repos/TokTok/c-toxcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TokTok/c-toxcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TokTok/c-toxcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TokTok/c-toxcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TokTok/c-toxcore/statuses/{sha}","languages_url":"https://api.github.com/repos/TokTok/c-toxcore/languages","stargazers_url":"https://api.github.com/repos/TokTok/c-toxcore/stargazers","contributors_url":"https://api.github.com/repos/TokTok/c-toxcore/contributors","subscribers_url":"https://api.github.com/repos/TokTok/c-toxcore/subscribers","subscription_url":"https://api.github.com/repos/TokTok/c-toxcore/subscription","commits_url":"https://api.github.com/repos/TokTok/c-toxcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TokTok/c-toxcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TokTok/c-toxcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TokTok/c-toxcore/issues/comments{/number}","contents_url":"https://api.github.com/repos/TokTok/c-toxcore/contents/{+path}","compare_url":"https://api.github.com/repos/TokTok/c-toxcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TokTok/c-toxcore/merges","archive_url":"https://api.github.com/repos/TokTok/c-toxcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TokTok/c-toxcore/downloads","issues_url":"https://api.github.com/repos/TokTok/c-toxcore/issues{/number}","pulls_url":"https://api.github.com/repos/TokTok/c-toxcore/pulls{/number}","milestones_url":"https://api.github.com/repos/TokTok/c-toxcore/milestones{/number}","notifications_url":"https://api.github.com/repos/TokTok/c-toxcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TokTok/c-toxcore/labels{/name}","releases_url":"https://api.github.com/repos/TokTok/c-toxcore/releases{/id}","deployments_url":"https://api.github.com/repos/TokTok/c-toxcore/deployments","created_at":"2016-07-06T08:15:22Z","updated_at":"2018-10-18T08:48:18Z","pushed_at":"2018-10-19T18:16:29Z","git_url":"git://github.com/TokTok/c-toxcore.git","ssh_url":"git@github.com:TokTok/c-toxcore.git","clone_url":"https://github.com/TokTok/c-toxcore.git","svn_url":"https://github.com/TokTok/c-toxcore","homepage":"https://tox.chat/","size":23400,"stargazers_count":789,"watchers_count":789,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":145,"mirror_url":null,"archived":false,"open_issues_count":211,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":145,"open_issues":211,"watchers":789,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TokTok/c-toxcore/pulls/1230"},"html":{"href":"https://github.com/TokTok/c-toxcore/pull/1230"},"issue":{"href":"https://api.github.com/repos/TokTok/c-toxcore/issues/1230"},"comments":{"href":"https://api.github.com/repos/TokTok/c-toxcore/issues/1230/comments"},"review_comments":{"href":"https://api.github.com/repos/TokTok/c-toxcore/pulls/1230/comments"},"review_comment":{"href":"https://api.github.com/repos/TokTok/c-toxcore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TokTok/c-toxcore/pulls/1230/commits"},"statuses":{"href":"https://api.github.com/repos/TokTok/c-toxcore/statuses/aa5c7828802b3fcaedfd8d6fe9a08ca714b9aa2b"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"iphydf","id":10647936,"node_id":"MDQ6VXNlcjEwNjQ3OTM2","avatar_url":"https://avatars0.githubusercontent.com/u/10647936?v=4","gravatar_id":"","url":"https://api.github.com/users/iphydf","html_url":"https://github.com/iphydf","followers_url":"https://api.github.com/users/iphydf/followers","following_url":"https://api.github.com/users/iphydf/following{/other_user}","gists_url":"https://api.github.com/users/iphydf/gists{/gist_id}","starred_url":"https://api.github.com/users/iphydf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iphydf/subscriptions","organizations_url":"https://api.github.com/users/iphydf/orgs","repos_url":"https://api.github.com/users/iphydf/repos","events_url":"https://api.github.com/users/iphydf/events{/privacy}","received_events_url":"https://api.github.com/users/iphydf/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":28,"deletions":10,"changed_files":3}}
{"actor":{"display_login":"iphydf"}}