{"action":"created","comment":{"url":"https://api.github.com/repos/pyrates/roll/pulls/comments/177280543","pull_request_review_id":107122968,"id":177280543,"diff_hunk":"@@ -0,0 +1,150 @@\n+import pytest\n+import asyncio\n+import websockets\n+\n+\n+@pytest.mark.asyncio\n+async def test_websocket_route(liveclient):\n+    ev = asyncio.Event()\n+\n+    @liveclient.app.route('/ws', protocol=\"websocket\")\n+    async def handler(request, ws, **params):\n+        assert ws.subprotocol is None\n+        ev.set()\n+\n+    with liveclient as query:\n+        response = await query('GET', '/ws', headers={\n+            'Upgrade': 'websocket',\n+            'Connection': 'upgrade',\n+            'Sec-WebSocket-Key': 'hojIvDoHedBucveephosh8==',\n+            'Sec-WebSocket-Version': '13'})\n+\n+    assert ev.is_set()\n+    assert response.status == 101","path":"tests/test_websockets.py","position":23,"original_position":23,"commit_id":"0a5ced85a7bc53c1d26ea2f5b1fc5896cfde5136","original_commit_id":"0a5ced85a7bc53c1d26ea2f5b1fc5896cfde5136","user":{"login":"davidbgk","id":3556,"avatar_url":"https://avatars2.githubusercontent.com/u/3556?v=4","gravatar_id":"","url":"https://api.github.com/users/davidbgk","html_url":"https://github.com/davidbgk","followers_url":"https://api.github.com/users/davidbgk/followers","following_url":"https://api.github.com/users/davidbgk/following{/other_user}","gists_url":"https://api.github.com/users/davidbgk/gists{/gist_id}","starred_url":"https://api.github.com/users/davidbgk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidbgk/subscriptions","organizations_url":"https://api.github.com/users/davidbgk/orgs","repos_url":"https://api.github.com/users/davidbgk/repos","events_url":"https://api.github.com/users/davidbgk/events{/privacy}","received_events_url":"https://api.github.com/users/davidbgk/received_events","type":"User","site_admin":false},"body":"Can you use `http.HTTPStatus.SWITCHING_PROTOCOLS` here and there for consistency?","created_at":"2018-03-27T01:12:57Z","updated_at":"2018-03-27T01:19:06Z","html_url":"https://github.com/pyrates/roll/pull/53#discussion_r177280543","pull_request_url":"https://api.github.com/repos/pyrates/roll/pulls/53","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pyrates/roll/pulls/comments/177280543"},"html":{"href":"https://github.com/pyrates/roll/pull/53#discussion_r177280543"},"pull_request":{"href":"https://api.github.com/repos/pyrates/roll/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/pyrates/roll/pulls/53","id":177520545,"html_url":"https://github.com/pyrates/roll/pull/53","diff_url":"https://github.com/pyrates/roll/pull/53.diff","patch_url":"https://github.com/pyrates/roll/pull/53.patch","issue_url":"https://api.github.com/repos/pyrates/roll/issues/53","number":53,"state":"open","locked":false,"title":"Integrating websockets directly to the core, using a new route proxy mechanism.","user":{"login":"trollfot","id":132847,"avatar_url":"https://avatars0.githubusercontent.com/u/132847?v=4","gravatar_id":"","url":"https://api.github.com/users/trollfot","html_url":"https://github.com/trollfot","followers_url":"https://api.github.com/users/trollfot/followers","following_url":"https://api.github.com/users/trollfot/following{/other_user}","gists_url":"https://api.github.com/users/trollfot/gists{/gist_id}","starred_url":"https://api.github.com/users/trollfot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trollfot/subscriptions","organizations_url":"https://api.github.com/users/trollfot/orgs","repos_url":"https://api.github.com/users/trollfot/repos","events_url":"https://api.github.com/users/trollfot/events{/privacy}","received_events_url":"https://api.github.com/users/trollfot/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-26T17:51:45Z","updated_at":"2018-03-27T01:19:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f608ba8b6da7804736e51f01902c052836c73ef5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pyrates/roll/pulls/53/commits","review_comments_url":"https://api.github.com/repos/pyrates/roll/pulls/53/comments","review_comment_url":"https://api.github.com/repos/pyrates/roll/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pyrates/roll/issues/53/comments","statuses_url":"https://api.github.com/repos/pyrates/roll/statuses/0a5ced85a7bc53c1d26ea2f5b1fc5896cfde5136","head":{"label":"trollfot:master","ref":"master","sha":"0a5ced85a7bc53c1d26ea2f5b1fc5896cfde5136","user":{"login":"trollfot","id":132847,"avatar_url":"https://avatars0.githubusercontent.com/u/132847?v=4","gravatar_id":"","url":"https://api.github.com/users/trollfot","html_url":"https://github.com/trollfot","followers_url":"https://api.github.com/users/trollfot/followers","following_url":"https://api.github.com/users/trollfot/following{/other_user}","gists_url":"https://api.github.com/users/trollfot/gists{/gist_id}","starred_url":"https://api.github.com/users/trollfot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trollfot/subscriptions","organizations_url":"https://api.github.com/users/trollfot/orgs","repos_url":"https://api.github.com/users/trollfot/repos","events_url":"https://api.github.com/users/trollfot/events{/privacy}","received_events_url":"https://api.github.com/users/trollfot/received_events","type":"User","site_admin":false},"repo":{"id":124089953,"name":"roll","full_name":"trollfot/roll","owner":{"login":"trollfot","id":132847,"avatar_url":"https://avatars0.githubusercontent.com/u/132847?v=4","gravatar_id":"","url":"https://api.github.com/users/trollfot","html_url":"https://github.com/trollfot","followers_url":"https://api.github.com/users/trollfot/followers","following_url":"https://api.github.com/users/trollfot/following{/other_user}","gists_url":"https://api.github.com/users/trollfot/gists{/gist_id}","starred_url":"https://api.github.com/users/trollfot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trollfot/subscriptions","organizations_url":"https://api.github.com/users/trollfot/orgs","repos_url":"https://api.github.com/users/trollfot/repos","events_url":"https://api.github.com/users/trollfot/events{/privacy}","received_events_url":"https://api.github.com/users/trollfot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trollfot/roll","description":"Async, simple, fast: pick three! Roll is a pico framework with  performances and aesthetic in mind.","fork":true,"url":"https://api.github.com/repos/trollfot/roll","forks_url":"https://api.github.com/repos/trollfot/roll/forks","keys_url":"https://api.github.com/repos/trollfot/roll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trollfot/roll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trollfot/roll/teams","hooks_url":"https://api.github.com/repos/trollfot/roll/hooks","issue_events_url":"https://api.github.com/repos/trollfot/roll/issues/events{/number}","events_url":"https://api.github.com/repos/trollfot/roll/events","assignees_url":"https://api.github.com/repos/trollfot/roll/assignees{/user}","branches_url":"https://api.github.com/repos/trollfot/roll/branches{/branch}","tags_url":"https://api.github.com/repos/trollfot/roll/tags","blobs_url":"https://api.github.com/repos/trollfot/roll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trollfot/roll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trollfot/roll/git/refs{/sha}","trees_url":"https://api.github.com/repos/trollfot/roll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trollfot/roll/statuses/{sha}","languages_url":"https://api.github.com/repos/trollfot/roll/languages","stargazers_url":"https://api.github.com/repos/trollfot/roll/stargazers","contributors_url":"https://api.github.com/repos/trollfot/roll/contributors","subscribers_url":"https://api.github.com/repos/trollfot/roll/subscribers","subscription_url":"https://api.github.com/repos/trollfot/roll/subscription","commits_url":"https://api.github.com/repos/trollfot/roll/commits{/sha}","git_commits_url":"https://api.github.com/repos/trollfot/roll/git/commits{/sha}","comments_url":"https://api.github.com/repos/trollfot/roll/comments{/number}","issue_comment_url":"https://api.github.com/repos/trollfot/roll/issues/comments{/number}","contents_url":"https://api.github.com/repos/trollfot/roll/contents/{+path}","compare_url":"https://api.github.com/repos/trollfot/roll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trollfot/roll/merges","archive_url":"https://api.github.com/repos/trollfot/roll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trollfot/roll/downloads","issues_url":"https://api.github.com/repos/trollfot/roll/issues{/number}","pulls_url":"https://api.github.com/repos/trollfot/roll/pulls{/number}","milestones_url":"https://api.github.com/repos/trollfot/roll/milestones{/number}","notifications_url":"https://api.github.com/repos/trollfot/roll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trollfot/roll/labels{/name}","releases_url":"https://api.github.com/repos/trollfot/roll/releases{/id}","deployments_url":"https://api.github.com/repos/trollfot/roll/deployments","created_at":"2018-03-06T14:26:36Z","updated_at":"2018-03-26T22:48:39Z","pushed_at":"2018-03-26T22:48:37Z","git_url":"git://github.com/trollfot/roll.git","ssh_url":"git@github.com:trollfot/roll.git","clone_url":"https://github.com/trollfot/roll.git","svn_url":"https://github.com/trollfot/roll","homepage":"http://roll.readthedocs.io/","size":480,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pyrates:master","ref":"master","sha":"57623ed46500caf23eebbac1777b9d7dcf5b5761","user":{"login":"pyrates","id":32146744,"avatar_url":"https://avatars0.githubusercontent.com/u/32146744?v=4","gravatar_id":"","url":"https://api.github.com/users/pyrates","html_url":"https://github.com/pyrates","followers_url":"https://api.github.com/users/pyrates/followers","following_url":"https://api.github.com/users/pyrates/following{/other_user}","gists_url":"https://api.github.com/users/pyrates/gists{/gist_id}","starred_url":"https://api.github.com/users/pyrates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyrates/subscriptions","organizations_url":"https://api.github.com/users/pyrates/orgs","repos_url":"https://api.github.com/users/pyrates/repos","events_url":"https://api.github.com/users/pyrates/events{/privacy}","received_events_url":"https://api.github.com/users/pyrates/received_events","type":"Organization","site_admin":false},"repo":{"id":104368980,"name":"roll","full_name":"pyrates/roll","owner":{"login":"pyrates","id":32146744,"avatar_url":"https://avatars0.githubusercontent.com/u/32146744?v=4","gravatar_id":"","url":"https://api.github.com/users/pyrates","html_url":"https://github.com/pyrates","followers_url":"https://api.github.com/users/pyrates/followers","following_url":"https://api.github.com/users/pyrates/following{/other_user}","gists_url":"https://api.github.com/users/pyrates/gists{/gist_id}","starred_url":"https://api.github.com/users/pyrates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyrates/subscriptions","organizations_url":"https://api.github.com/users/pyrates/orgs","repos_url":"https://api.github.com/users/pyrates/repos","events_url":"https://api.github.com/users/pyrates/events{/privacy}","received_events_url":"https://api.github.com/users/pyrates/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pyrates/roll","description":"Async, simple, fast: pick three! Roll is a pico framework with  performances and aesthetic in mind.","fork":false,"url":"https://api.github.com/repos/pyrates/roll","forks_url":"https://api.github.com/repos/pyrates/roll/forks","keys_url":"https://api.github.com/repos/pyrates/roll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pyrates/roll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pyrates/roll/teams","hooks_url":"https://api.github.com/repos/pyrates/roll/hooks","issue_events_url":"https://api.github.com/repos/pyrates/roll/issues/events{/number}","events_url":"https://api.github.com/repos/pyrates/roll/events","assignees_url":"https://api.github.com/repos/pyrates/roll/assignees{/user}","branches_url":"https://api.github.com/repos/pyrates/roll/branches{/branch}","tags_url":"https://api.github.com/repos/pyrates/roll/tags","blobs_url":"https://api.github.com/repos/pyrates/roll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pyrates/roll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pyrates/roll/git/refs{/sha}","trees_url":"https://api.github.com/repos/pyrates/roll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pyrates/roll/statuses/{sha}","languages_url":"https://api.github.com/repos/pyrates/roll/languages","stargazers_url":"https://api.github.com/repos/pyrates/roll/stargazers","contributors_url":"https://api.github.com/repos/pyrates/roll/contributors","subscribers_url":"https://api.github.com/repos/pyrates/roll/subscribers","subscription_url":"https://api.github.com/repos/pyrates/roll/subscription","commits_url":"https://api.github.com/repos/pyrates/roll/commits{/sha}","git_commits_url":"https://api.github.com/repos/pyrates/roll/git/commits{/sha}","comments_url":"https://api.github.com/repos/pyrates/roll/comments{/number}","issue_comment_url":"https://api.github.com/repos/pyrates/roll/issues/comments{/number}","contents_url":"https://api.github.com/repos/pyrates/roll/contents/{+path}","compare_url":"https://api.github.com/repos/pyrates/roll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pyrates/roll/merges","archive_url":"https://api.github.com/repos/pyrates/roll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pyrates/roll/downloads","issues_url":"https://api.github.com/repos/pyrates/roll/issues{/number}","pulls_url":"https://api.github.com/repos/pyrates/roll/pulls{/number}","milestones_url":"https://api.github.com/repos/pyrates/roll/milestones{/number}","notifications_url":"https://api.github.com/repos/pyrates/roll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pyrates/roll/labels{/name}","releases_url":"https://api.github.com/repos/pyrates/roll/releases{/id}","deployments_url":"https://api.github.com/repos/pyrates/roll/deployments","created_at":"2017-09-21T15:57:05Z","updated_at":"2018-03-05T17:46:42Z","pushed_at":"2018-03-26T22:48:38Z","git_url":"git://github.com/pyrates/roll.git","ssh_url":"git@github.com:pyrates/roll.git","clone_url":"https://github.com/pyrates/roll.git","svn_url":"https://github.com/pyrates/roll","homepage":"http://roll.readthedocs.io/","size":276,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":2,"open_issues":7,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pyrates/roll/pulls/53"},"html":{"href":"https://github.com/pyrates/roll/pull/53"},"issue":{"href":"https://api.github.com/repos/pyrates/roll/issues/53"},"comments":{"href":"https://api.github.com/repos/pyrates/roll/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/pyrates/roll/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/pyrates/roll/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pyrates/roll/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/pyrates/roll/statuses/0a5ced85a7bc53c1d26ea2f5b1fc5896cfde5136"}},"author_association":"NONE"}}
{"actor":{"display_login":"davidbgk"}}