{"action":"created","comment":{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/comments/181547223","pull_request_review_id":112202539,"id":181547223,"diff_hunk":"@@ -12,9 +12,8 @@ DepotManagementController.$inject = [\n  * This controller is about the depot management module in the admin zone\n  * It's responsible for creating, editing and updating a depot\n  */\n-function DepotManagementController(Depots, ModalService,\n-  Notify, uiGridConstants, $state) {\n-  var vm = this;\n+function DepotManagementController(Depots, ModalService, Location, Notify, uiGridConstants, $state) {","path":"client/src/modules/depots/depots.js","position":18,"original_position":18,"commit_id":"3844d2f2b506607b967d950ee26addf62ee9bf3f","original_commit_id":"3844d2f2b506607b967d950ee26addf62ee9bf3f","user":{"login":"jniles","id":896472,"avatar_url":"https://avatars0.githubusercontent.com/u/896472?v=4","gravatar_id":"","url":"https://api.github.com/users/jniles","html_url":"https://github.com/jniles","followers_url":"https://api.github.com/users/jniles/followers","following_url":"https://api.github.com/users/jniles/following{/other_user}","gists_url":"https://api.github.com/users/jniles/gists{/gist_id}","starred_url":"https://api.github.com/users/jniles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jniles/subscriptions","organizations_url":"https://api.github.com/users/jniles/orgs","repos_url":"https://api.github.com/users/jniles/repos","events_url":"https://api.github.com/users/jniles/events{/privacy}","received_events_url":"https://api.github.com/users/jniles/received_events","type":"User","site_admin":false},"body":"It would be better to call this `Locations`, since that has been our practice with most other services (for example, `Depots`), and `location` is a reserved JS word that may confuse future developers.  GitHub's syntax highlighting certainly thinks so!","created_at":"2018-04-14T09:21:53Z","updated_at":"2018-04-14T09:37:18Z","html_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/2684#discussion_r181547223","pull_request_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/2684","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/comments/181547223"},"html":{"href":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/2684#discussion_r181547223"},"pull_request":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/2684"}}},"pull_request":{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/2684","id":181599259,"html_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/2684","diff_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/2684.diff","patch_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/2684.patch","issue_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/2684","number":2684,"state":"open","locked":false,"title":"refactor(depot): add location and link to stock","user":{"login":"mbayopanda","id":5445251,"avatar_url":"https://avatars1.githubusercontent.com/u/5445251?v=4","gravatar_id":"","url":"https://api.github.com/users/mbayopanda","html_url":"https://github.com/mbayopanda","followers_url":"https://api.github.com/users/mbayopanda/followers","following_url":"https://api.github.com/users/mbayopanda/following{/other_user}","gists_url":"https://api.github.com/users/mbayopanda/gists{/gist_id}","starred_url":"https://api.github.com/users/mbayopanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbayopanda/subscriptions","organizations_url":"https://api.github.com/users/mbayopanda/orgs","repos_url":"https://api.github.com/users/mbayopanda/repos","events_url":"https://api.github.com/users/mbayopanda/events{/privacy}","received_events_url":"https://api.github.com/users/mbayopanda/received_events","type":"User","site_admin":false},"body":"This PR : \r\n- Move the depot in its own folder in the navigation tree\r\n- Add location to depot\r\n- Add link to stock registry from depot\r\n\r\nclose #2663 ","created_at":"2018-04-13T21:23:13Z","updated_at":"2018-04-14T09:37:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c751b63b0202ac534730644cf01c676b8d45331","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/2684/commits","review_comments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/2684/comments","review_comment_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/2684/comments","statuses_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/statuses/3844d2f2b506607b967d950ee26addf62ee9bf3f","head":{"label":"mbayopanda:refactor-depot","ref":"refactor-depot","sha":"3844d2f2b506607b967d950ee26addf62ee9bf3f","user":{"login":"mbayopanda","id":5445251,"avatar_url":"https://avatars1.githubusercontent.com/u/5445251?v=4","gravatar_id":"","url":"https://api.github.com/users/mbayopanda","html_url":"https://github.com/mbayopanda","followers_url":"https://api.github.com/users/mbayopanda/followers","following_url":"https://api.github.com/users/mbayopanda/following{/other_user}","gists_url":"https://api.github.com/users/mbayopanda/gists{/gist_id}","starred_url":"https://api.github.com/users/mbayopanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbayopanda/subscriptions","organizations_url":"https://api.github.com/users/mbayopanda/orgs","repos_url":"https://api.github.com/users/mbayopanda/repos","events_url":"https://api.github.com/users/mbayopanda/events{/privacy}","received_events_url":"https://api.github.com/users/mbayopanda/received_events","type":"User","site_admin":false},"repo":{"id":49122869,"name":"bhima-2.X","full_name":"mbayopanda/bhima-2.X","owner":{"login":"mbayopanda","id":5445251,"avatar_url":"https://avatars1.githubusercontent.com/u/5445251?v=4","gravatar_id":"","url":"https://api.github.com/users/mbayopanda","html_url":"https://github.com/mbayopanda","followers_url":"https://api.github.com/users/mbayopanda/followers","following_url":"https://api.github.com/users/mbayopanda/following{/other_user}","gists_url":"https://api.github.com/users/mbayopanda/gists{/gist_id}","starred_url":"https://api.github.com/users/mbayopanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbayopanda/subscriptions","organizations_url":"https://api.github.com/users/mbayopanda/orgs","repos_url":"https://api.github.com/users/mbayopanda/repos","events_url":"https://api.github.com/users/mbayopanda/events{/privacy}","received_events_url":"https://api.github.com/users/mbayopanda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbayopanda/bhima-2.X","description":"A fresh start for bhima to remove large commits","fork":true,"url":"https://api.github.com/repos/mbayopanda/bhima-2.X","forks_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/forks","keys_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/teams","hooks_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/hooks","issue_events_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/issues/events{/number}","events_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/events","assignees_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/assignees{/user}","branches_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/branches{/branch}","tags_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/tags","blobs_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/statuses/{sha}","languages_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/languages","stargazers_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/stargazers","contributors_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/contributors","subscribers_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/subscribers","subscription_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/subscription","commits_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/contents/{+path}","compare_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/merges","archive_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/downloads","issues_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/issues{/number}","pulls_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/pulls{/number}","milestones_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/milestones{/number}","notifications_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/labels{/name}","releases_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/releases{/id}","deployments_url":"https://api.github.com/repos/mbayopanda/bhima-2.X/deployments","created_at":"2016-01-06T08:26:46Z","updated_at":"2017-05-22T12:02:28Z","pushed_at":"2018-04-13T22:06:53Z","git_url":"git://github.com/mbayopanda/bhima-2.X.git","ssh_url":"git@github.com:mbayopanda/bhima-2.X.git","clone_url":"https://github.com/mbayopanda/bhima-2.X.git","svn_url":"https://github.com/mbayopanda/bhima-2.X","homepage":null,"size":13467,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"IMA-WorldHealth:master","ref":"master","sha":"36c029a748b5aad3b99d1c92f5a0067a26605d50","user":{"login":"IMA-WorldHealth","id":5330583,"avatar_url":"https://avatars1.githubusercontent.com/u/5330583?v=4","gravatar_id":"","url":"https://api.github.com/users/IMA-WorldHealth","html_url":"https://github.com/IMA-WorldHealth","followers_url":"https://api.github.com/users/IMA-WorldHealth/followers","following_url":"https://api.github.com/users/IMA-WorldHealth/following{/other_user}","gists_url":"https://api.github.com/users/IMA-WorldHealth/gists{/gist_id}","starred_url":"https://api.github.com/users/IMA-WorldHealth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IMA-WorldHealth/subscriptions","organizations_url":"https://api.github.com/users/IMA-WorldHealth/orgs","repos_url":"https://api.github.com/users/IMA-WorldHealth/repos","events_url":"https://api.github.com/users/IMA-WorldHealth/events{/privacy}","received_events_url":"https://api.github.com/users/IMA-WorldHealth/received_events","type":"Organization","site_admin":false},"repo":{"id":49052669,"name":"bhima-2.X","full_name":"IMA-WorldHealth/bhima-2.X","owner":{"login":"IMA-WorldHealth","id":5330583,"avatar_url":"https://avatars1.githubusercontent.com/u/5330583?v=4","gravatar_id":"","url":"https://api.github.com/users/IMA-WorldHealth","html_url":"https://github.com/IMA-WorldHealth","followers_url":"https://api.github.com/users/IMA-WorldHealth/followers","following_url":"https://api.github.com/users/IMA-WorldHealth/following{/other_user}","gists_url":"https://api.github.com/users/IMA-WorldHealth/gists{/gist_id}","starred_url":"https://api.github.com/users/IMA-WorldHealth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IMA-WorldHealth/subscriptions","organizations_url":"https://api.github.com/users/IMA-WorldHealth/orgs","repos_url":"https://api.github.com/users/IMA-WorldHealth/repos","events_url":"https://api.github.com/users/IMA-WorldHealth/events{/privacy}","received_events_url":"https://api.github.com/users/IMA-WorldHealth/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IMA-WorldHealth/bhima-2.X","description":"A hospital information management application for rural Congolese hospitals","fork":false,"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X","forks_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/forks","keys_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/teams","hooks_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/hooks","issue_events_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/events{/number}","events_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/events","assignees_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/assignees{/user}","branches_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/branches{/branch}","tags_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/tags","blobs_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/refs{/sha}","trees_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/statuses/{sha}","languages_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/languages","stargazers_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/stargazers","contributors_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/contributors","subscribers_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/subscribers","subscription_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/subscription","commits_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/commits{/sha}","git_commits_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/commits{/sha}","comments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/comments{/number}","issue_comment_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/comments{/number}","contents_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/contents/{+path}","compare_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/merges","archive_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/downloads","issues_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues{/number}","pulls_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls{/number}","milestones_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/milestones{/number}","notifications_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/labels{/name}","releases_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/releases{/id}","deployments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/deployments","created_at":"2016-01-05T08:30:30Z","updated_at":"2018-04-11T17:03:57Z","pushed_at":"2018-04-13T22:08:55Z","git_url":"git://github.com/IMA-WorldHealth/bhima-2.X.git","ssh_url":"git@github.com:IMA-WorldHealth/bhima-2.X.git","clone_url":"https://github.com/IMA-WorldHealth/bhima-2.X.git","svn_url":"https://github.com/IMA-WorldHealth/bhima-2.X","homepage":"","size":13581,"stargazers_count":68,"watchers_count":68,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":257,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":37,"open_issues":257,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/2684"},"html":{"href":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/2684"},"issue":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/2684"},"comments":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/2684/comments"},"review_comments":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/2684/comments"},"review_comment":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/2684/commits"},"statuses":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/statuses/3844d2f2b506607b967d950ee26addf62ee9bf3f"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jniles"}}