{"action":"created","comment":{"url":"https://api.github.com/repos/whatwg/html/pulls/comments/166011231","pull_request_review_id":94023714,"id":166011231,"diff_hunk":"@@ -93027,51 +93053,94 @@ dictionary <dfn>ImageBitmapOptions</dfn> {\n    <li><p>Return <var>p</var>.</p></li>\n   </ol>\n \n-  <p>When the steps above require that the user agent <dfn data-x=\"cropped to the source\n-  rectangle with formatting\">crop bitmap data to the source rectangle with formatting</dfn>,\n-  the user agent must run the following steps:</p>\n+  <p><dfn>Rendering image data as a bitmap</dfn>, given <var>imageData</var> and <var>options</var>,\n+  is as follows:</p>\n \n   <ol>\n+   <li>\n+    <p>Return the result of rendering <var>imageData</var> onto a bitmap.</p>","path":"source","position":259,"original_position":259,"commit_id":"e3d2b24873a69756862946b569723a1059ba52cf","original_commit_id":"e3d2b24873a69756862946b569723a1059ba52cf","user":{"login":"junov","id":2607864,"avatar_url":"https://avatars2.githubusercontent.com/u/2607864?v=4","gravatar_id":"","url":"https://api.github.com/users/junov","html_url":"https://github.com/junov","followers_url":"https://api.github.com/users/junov/followers","following_url":"https://api.github.com/users/junov/following{/other_user}","gists_url":"https://api.github.com/users/junov/gists{/gist_id}","starred_url":"https://api.github.com/users/junov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junov/subscriptions","organizations_url":"https://api.github.com/users/junov/orgs","repos_url":"https://api.github.com/users/junov/repos","events_url":"https://api.github.com/users/junov/events{/privacy}","received_events_url":"https://api.github.com/users/junov/received_events","type":"User","site_admin":false},"body":"It is a bit weird that the first thing the algorithm does is \"return\" unconditionally, and then a bunch of stuff.  Perhaps reorder?","created_at":"2018-02-05T15:42:30Z","updated_at":"2018-02-05T15:54:02Z","html_url":"https://github.com/whatwg/html/pull/3424#discussion_r166011231","pull_request_url":"https://api.github.com/repos/whatwg/html/pulls/3424","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/whatwg/html/pulls/comments/166011231"},"html":{"href":"https://github.com/whatwg/html/pull/3424#discussion_r166011231"},"pull_request":{"href":"https://api.github.com/repos/whatwg/html/pulls/3424"}}},"pull_request":{"url":"https://api.github.com/repos/whatwg/html/pulls/3424","id":165680635,"html_url":"https://github.com/whatwg/html/pull/3424","diff_url":"https://github.com/whatwg/html/pull/3424.diff","patch_url":"https://github.com/whatwg/html/pull/3424.patch","issue_url":"https://api.github.com/repos/whatwg/html/issues/3424","number":3424,"state":"open","locked":false,"title":"Substantive createImageBitmap() rewrite","user":{"login":"annevk","id":1544111,"avatar_url":"https://avatars0.githubusercontent.com/u/1544111?v=4","gravatar_id":"","url":"https://api.github.com/users/annevk","html_url":"https://github.com/annevk","followers_url":"https://api.github.com/users/annevk/followers","following_url":"https://api.github.com/users/annevk/following{/other_user}","gists_url":"https://api.github.com/users/annevk/gists{/gist_id}","starred_url":"https://api.github.com/users/annevk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annevk/subscriptions","organizations_url":"https://api.github.com/users/annevk/orgs","repos_url":"https://api.github.com/users/annevk/repos","events_url":"https://api.github.com/users/annevk/events{/privacy}","received_events_url":"https://api.github.com/users/annevk/received_events","type":"User","site_admin":false},"body":"There have been several cleanups already in the past couple days and this very much builds on that.\n\nIt makes it clear what is supposed to happen synchronously and what can be done \"in parallel\". This fixes #1553.\n\nIt makes it much more clear that img and  SVG image elements share a lot of logic with Blob objects by defining combined \"rendering\" steps.\n\nIt defines many more places where this algorithm can fail, primarily due to OOM conditions. Fixes #3323.\n\nIt fixes several wording issues. Fixes #3334. Fixes #3322.\n\n\n<!--\n    This comment and the below content is programatically generated.\n    You may add a comma-separated list of anchors you'd like a\n    direct link to below (e.g. #idl-serializers, #idl-sequence):\n\n    Don't remove this comment or modify anything below this line.\n    If you don't want a preview generated for this pull request,\n    just replace the whole of this comment's content by \"no preview\"\n    and remove what's below.\n-->\n***\n<a href=\"https://whatpr.org/html/3424/imagebitmap-and-animations.html\" title=\"Last updated on Jan 29, 2018, 11:44 AM GMT (228209a)\">/imagebitmap-and-animations.html</a>  ( <a href=\"https://whatpr.org/html/3424/7458477...228209a/imagebitmap-and-animations.html\" title=\"Last updated on Jan 29, 2018, 11:44 AM GMT (228209a)\">diff</a> )","created_at":"2018-01-29T11:34:56Z","updated_at":"2018-02-05T15:54:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e2dfa49ac6b46c04189c614476580c64bc5de3f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/whatwg/html/pulls/3424/commits","review_comments_url":"https://api.github.com/repos/whatwg/html/pulls/3424/comments","review_comment_url":"https://api.github.com/repos/whatwg/html/pulls/comments{/number}","comments_url":"https://api.github.com/repos/whatwg/html/issues/3424/comments","statuses_url":"https://api.github.com/repos/whatwg/html/statuses/e3d2b24873a69756862946b569723a1059ba52cf","head":{"label":"whatwg:annevk/createimagebitmap-further-rewrite","ref":"annevk/createimagebitmap-further-rewrite","sha":"e3d2b24873a69756862946b569723a1059ba52cf","user":{"login":"whatwg","id":2226336,"avatar_url":"https://avatars1.githubusercontent.com/u/2226336?v=4","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"repo":{"id":11969507,"name":"html","full_name":"whatwg/html","owner":{"login":"whatwg","id":2226336,"avatar_url":"https://avatars1.githubusercontent.com/u/2226336?v=4","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/whatwg/html","description":"HTML Standard","fork":false,"url":"https://api.github.com/repos/whatwg/html","forks_url":"https://api.github.com/repos/whatwg/html/forks","keys_url":"https://api.github.com/repos/whatwg/html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whatwg/html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whatwg/html/teams","hooks_url":"https://api.github.com/repos/whatwg/html/hooks","issue_events_url":"https://api.github.com/repos/whatwg/html/issues/events{/number}","events_url":"https://api.github.com/repos/whatwg/html/events","assignees_url":"https://api.github.com/repos/whatwg/html/assignees{/user}","branches_url":"https://api.github.com/repos/whatwg/html/branches{/branch}","tags_url":"https://api.github.com/repos/whatwg/html/tags","blobs_url":"https://api.github.com/repos/whatwg/html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whatwg/html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whatwg/html/git/refs{/sha}","trees_url":"https://api.github.com/repos/whatwg/html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whatwg/html/statuses/{sha}","languages_url":"https://api.github.com/repos/whatwg/html/languages","stargazers_url":"https://api.github.com/repos/whatwg/html/stargazers","contributors_url":"https://api.github.com/repos/whatwg/html/contributors","subscribers_url":"https://api.github.com/repos/whatwg/html/subscribers","subscription_url":"https://api.github.com/repos/whatwg/html/subscription","commits_url":"https://api.github.com/repos/whatwg/html/commits{/sha}","git_commits_url":"https://api.github.com/repos/whatwg/html/git/commits{/sha}","comments_url":"https://api.github.com/repos/whatwg/html/comments{/number}","issue_comment_url":"https://api.github.com/repos/whatwg/html/issues/comments{/number}","contents_url":"https://api.github.com/repos/whatwg/html/contents/{+path}","compare_url":"https://api.github.com/repos/whatwg/html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whatwg/html/merges","archive_url":"https://api.github.com/repos/whatwg/html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whatwg/html/downloads","issues_url":"https://api.github.com/repos/whatwg/html/issues{/number}","pulls_url":"https://api.github.com/repos/whatwg/html/pulls{/number}","milestones_url":"https://api.github.com/repos/whatwg/html/milestones{/number}","notifications_url":"https://api.github.com/repos/whatwg/html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whatwg/html/labels{/name}","releases_url":"https://api.github.com/repos/whatwg/html/releases{/id}","deployments_url":"https://api.github.com/repos/whatwg/html/deployments","created_at":"2013-08-08T06:26:07Z","updated_at":"2018-02-05T07:24:42Z","pushed_at":"2018-02-05T15:33:56Z","git_url":"git://github.com/whatwg/html.git","ssh_url":"git@github.com:whatwg/html.git","clone_url":"https://github.com/whatwg/html.git","svn_url":"https://github.com/whatwg/html","homepage":"https://html.spec.whatwg.org/multipage/","size":186633,"stargazers_count":1667,"watchers_count":1667,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":569,"mirror_url":null,"archived":false,"open_issues_count":761,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0"},"forks":569,"open_issues":761,"watchers":1667,"default_branch":"master"}},"base":{"label":"whatwg:master","ref":"master","sha":"7458477e47ef2f1187fc64bbd87142e491e95094","user":{"login":"whatwg","id":2226336,"avatar_url":"https://avatars1.githubusercontent.com/u/2226336?v=4","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"repo":{"id":11969507,"name":"html","full_name":"whatwg/html","owner":{"login":"whatwg","id":2226336,"avatar_url":"https://avatars1.githubusercontent.com/u/2226336?v=4","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/whatwg/html","description":"HTML Standard","fork":false,"url":"https://api.github.com/repos/whatwg/html","forks_url":"https://api.github.com/repos/whatwg/html/forks","keys_url":"https://api.github.com/repos/whatwg/html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whatwg/html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whatwg/html/teams","hooks_url":"https://api.github.com/repos/whatwg/html/hooks","issue_events_url":"https://api.github.com/repos/whatwg/html/issues/events{/number}","events_url":"https://api.github.com/repos/whatwg/html/events","assignees_url":"https://api.github.com/repos/whatwg/html/assignees{/user}","branches_url":"https://api.github.com/repos/whatwg/html/branches{/branch}","tags_url":"https://api.github.com/repos/whatwg/html/tags","blobs_url":"https://api.github.com/repos/whatwg/html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whatwg/html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whatwg/html/git/refs{/sha}","trees_url":"https://api.github.com/repos/whatwg/html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whatwg/html/statuses/{sha}","languages_url":"https://api.github.com/repos/whatwg/html/languages","stargazers_url":"https://api.github.com/repos/whatwg/html/stargazers","contributors_url":"https://api.github.com/repos/whatwg/html/contributors","subscribers_url":"https://api.github.com/repos/whatwg/html/subscribers","subscription_url":"https://api.github.com/repos/whatwg/html/subscription","commits_url":"https://api.github.com/repos/whatwg/html/commits{/sha}","git_commits_url":"https://api.github.com/repos/whatwg/html/git/commits{/sha}","comments_url":"https://api.github.com/repos/whatwg/html/comments{/number}","issue_comment_url":"https://api.github.com/repos/whatwg/html/issues/comments{/number}","contents_url":"https://api.github.com/repos/whatwg/html/contents/{+path}","compare_url":"https://api.github.com/repos/whatwg/html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whatwg/html/merges","archive_url":"https://api.github.com/repos/whatwg/html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whatwg/html/downloads","issues_url":"https://api.github.com/repos/whatwg/html/issues{/number}","pulls_url":"https://api.github.com/repos/whatwg/html/pulls{/number}","milestones_url":"https://api.github.com/repos/whatwg/html/milestones{/number}","notifications_url":"https://api.github.com/repos/whatwg/html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whatwg/html/labels{/name}","releases_url":"https://api.github.com/repos/whatwg/html/releases{/id}","deployments_url":"https://api.github.com/repos/whatwg/html/deployments","created_at":"2013-08-08T06:26:07Z","updated_at":"2018-02-05T07:24:42Z","pushed_at":"2018-02-05T15:33:56Z","git_url":"git://github.com/whatwg/html.git","ssh_url":"git@github.com:whatwg/html.git","clone_url":"https://github.com/whatwg/html.git","svn_url":"https://github.com/whatwg/html","homepage":"https://html.spec.whatwg.org/multipage/","size":186633,"stargazers_count":1667,"watchers_count":1667,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":569,"mirror_url":null,"archived":false,"open_issues_count":761,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0"},"forks":569,"open_issues":761,"watchers":1667,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/whatwg/html/pulls/3424"},"html":{"href":"https://github.com/whatwg/html/pull/3424"},"issue":{"href":"https://api.github.com/repos/whatwg/html/issues/3424"},"comments":{"href":"https://api.github.com/repos/whatwg/html/issues/3424/comments"},"review_comments":{"href":"https://api.github.com/repos/whatwg/html/pulls/3424/comments"},"review_comment":{"href":"https://api.github.com/repos/whatwg/html/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/whatwg/html/pulls/3424/commits"},"statuses":{"href":"https://api.github.com/repos/whatwg/html/statuses/e3d2b24873a69756862946b569723a1059ba52cf"}},"author_association":"OWNER"}}
{"actor":{"display_login":"junov"}}