{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react-native/pulls/comments/166478184","pull_request_review_id":94546755,"id":166478184,"diff_hunk":"@@ -113,7 +148,10 @@ public boolean readAllParts(ChunkCallback callback) throws IOException {\n         Buffer chunk = new Buffer();\n         content.skip(chunkStart);\n         content.read(chunk, length);\n+        emitProgress(currentHeaders, chunk.size() - currentHeadersLength, true, progressCallback);","path":"ReactAndroid/src/main/java/com/facebook/react/devsupport/MultipartStreamReader.java","position":79,"original_position":79,"commit_id":"bbe67864421b1de228d7af3ddd7327ed8bca060c","original_commit_id":"bbe67864421b1de228d7af3ddd7327ed8bca060c","user":{"login":"janicduplessis","id":2677334,"avatar_url":"https://avatars2.githubusercontent.com/u/2677334?v=4","gravatar_id":"","url":"https://api.github.com/users/janicduplessis","html_url":"https://github.com/janicduplessis","followers_url":"https://api.github.com/users/janicduplessis/followers","following_url":"https://api.github.com/users/janicduplessis/following{/other_user}","gists_url":"https://api.github.com/users/janicduplessis/gists{/gist_id}","starred_url":"https://api.github.com/users/janicduplessis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janicduplessis/subscriptions","organizations_url":"https://api.github.com/users/janicduplessis/orgs","repos_url":"https://api.github.com/users/janicduplessis/repos","events_url":"https://api.github.com/users/janicduplessis/events{/privacy}","received_events_url":"https://api.github.com/users/janicduplessis/received_events","type":"User","site_admin":false},"body":"We do emit progress for each chunk so even if it is not the last chunk (what isCloseDelimiter means) we still want to pass isFinal to true. It's only use is to make sure the last event isn't throttled so we see 100%.","created_at":"2018-02-06T23:38:46Z","updated_at":"2018-02-06T23:38:46Z","html_url":"https://github.com/facebook/react-native/pull/17809#discussion_r166478184","pull_request_url":"https://api.github.com/repos/facebook/react-native/pulls/17809","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments/166478184"},"html":{"href":"https://github.com/facebook/react-native/pull/17809#discussion_r166478184"},"pull_request":{"href":"https://api.github.com/repos/facebook/react-native/pulls/17809"}},"in_reply_to_id":166179227},"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/17809","id":166426595,"html_url":"https://github.com/facebook/react-native/pull/17809","diff_url":"https://github.com/facebook/react-native/pull/17809.diff","patch_url":"https://github.com/facebook/react-native/pull/17809.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/17809","number":17809,"state":"open","locked":false,"title":"Bundle download progress on Android","user":{"login":"janicduplessis","id":2677334,"avatar_url":"https://avatars2.githubusercontent.com/u/2677334?v=4","gravatar_id":"","url":"https://api.github.com/users/janicduplessis","html_url":"https://github.com/janicduplessis","followers_url":"https://api.github.com/users/janicduplessis/followers","following_url":"https://api.github.com/users/janicduplessis/following{/other_user}","gists_url":"https://api.github.com/users/janicduplessis/gists{/gist_id}","starred_url":"https://api.github.com/users/janicduplessis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janicduplessis/subscriptions","organizations_url":"https://api.github.com/users/janicduplessis/orgs","repos_url":"https://api.github.com/users/janicduplessis/repos","events_url":"https://api.github.com/users/janicduplessis/events{/privacy}","received_events_url":"https://api.github.com/users/janicduplessis/received_events","type":"User","site_admin":false},"body":"## Motivation\r\n\r\nAndroid equivalent of #15066\r\n\r\n## Test Plan\r\n\r\nTested that download progress shows up properly when reloading the app.\r\n\r\n## Release Notes\r\n\r\n[ANDROID] [FEATURE] [DevSupport] - Show bundle download progress on Android","created_at":"2018-02-01T02:10:46Z","updated_at":"2018-02-06T23:38:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5dc447dd46f189c98c07b1812dde2485618a5c7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/17809/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/17809/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/17809/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/bbe67864421b1de228d7af3ddd7327ed8bca060c","head":{"label":"janicduplessis:bundle-download-progress-android","ref":"bundle-download-progress-android","sha":"bbe67864421b1de228d7af3ddd7327ed8bca060c","user":{"login":"janicduplessis","id":2677334,"avatar_url":"https://avatars2.githubusercontent.com/u/2677334?v=4","gravatar_id":"","url":"https://api.github.com/users/janicduplessis","html_url":"https://github.com/janicduplessis","followers_url":"https://api.github.com/users/janicduplessis/followers","following_url":"https://api.github.com/users/janicduplessis/following{/other_user}","gists_url":"https://api.github.com/users/janicduplessis/gists{/gist_id}","starred_url":"https://api.github.com/users/janicduplessis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janicduplessis/subscriptions","organizations_url":"https://api.github.com/users/janicduplessis/orgs","repos_url":"https://api.github.com/users/janicduplessis/repos","events_url":"https://api.github.com/users/janicduplessis/events{/privacy}","received_events_url":"https://api.github.com/users/janicduplessis/received_events","type":"User","site_admin":false},"repo":{"id":33167181,"name":"react-native","full_name":"janicduplessis/react-native","owner":{"login":"janicduplessis","id":2677334,"avatar_url":"https://avatars2.githubusercontent.com/u/2677334?v=4","gravatar_id":"","url":"https://api.github.com/users/janicduplessis","html_url":"https://github.com/janicduplessis","followers_url":"https://api.github.com/users/janicduplessis/followers","following_url":"https://api.github.com/users/janicduplessis/following{/other_user}","gists_url":"https://api.github.com/users/janicduplessis/gists{/gist_id}","starred_url":"https://api.github.com/users/janicduplessis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janicduplessis/subscriptions","organizations_url":"https://api.github.com/users/janicduplessis/orgs","repos_url":"https://api.github.com/users/janicduplessis/repos","events_url":"https://api.github.com/users/janicduplessis/events{/privacy}","received_events_url":"https://api.github.com/users/janicduplessis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/janicduplessis/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/janicduplessis/react-native","forks_url":"https://api.github.com/repos/janicduplessis/react-native/forks","keys_url":"https://api.github.com/repos/janicduplessis/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janicduplessis/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janicduplessis/react-native/teams","hooks_url":"https://api.github.com/repos/janicduplessis/react-native/hooks","issue_events_url":"https://api.github.com/repos/janicduplessis/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/janicduplessis/react-native/events","assignees_url":"https://api.github.com/repos/janicduplessis/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/janicduplessis/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/janicduplessis/react-native/tags","blobs_url":"https://api.github.com/repos/janicduplessis/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janicduplessis/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janicduplessis/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/janicduplessis/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janicduplessis/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/janicduplessis/react-native/languages","stargazers_url":"https://api.github.com/repos/janicduplessis/react-native/stargazers","contributors_url":"https://api.github.com/repos/janicduplessis/react-native/contributors","subscribers_url":"https://api.github.com/repos/janicduplessis/react-native/subscribers","subscription_url":"https://api.github.com/repos/janicduplessis/react-native/subscription","commits_url":"https://api.github.com/repos/janicduplessis/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/janicduplessis/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/janicduplessis/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/janicduplessis/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/janicduplessis/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/janicduplessis/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janicduplessis/react-native/merges","archive_url":"https://api.github.com/repos/janicduplessis/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janicduplessis/react-native/downloads","issues_url":"https://api.github.com/repos/janicduplessis/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/janicduplessis/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/janicduplessis/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/janicduplessis/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janicduplessis/react-native/labels{/name}","releases_url":"https://api.github.com/repos/janicduplessis/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/janicduplessis/react-native/deployments","created_at":"2015-03-31T05:43:42Z","updated_at":"2017-06-01T21:22:32Z","pushed_at":"2018-02-01T02:06:21Z","git_url":"git://github.com/janicduplessis/react-native.git","ssh_url":"git@github.com:janicduplessis/react-native.git","clone_url":"https://github.com/janicduplessis/react-native.git","svn_url":"https://github.com/janicduplessis/react-native","homepage":"http://facebook.github.io/react-native/","size":108965,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"9f57dedc1712733ce4a490121138a97917fd3a52","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2018-02-06T23:23:20Z","pushed_at":"2018-02-06T23:37:24Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"http://facebook.github.io/react-native/","size":188381,"stargazers_count":59472,"watchers_count":59472,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13698,"mirror_url":null,"archived":false,"open_issues_count":707,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":13698,"open_issues":707,"watchers":59472,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/17809"},"html":{"href":"https://github.com/facebook/react-native/pull/17809"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/17809"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/17809/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/17809/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/17809/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/bbe67864421b1de228d7af3ddd7327ed8bca060c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"janicduplessis"}}