{"action":"created","issue":{"url":"https://api.github.com/repos/pandas-dev/pandas/issues/20091","repository_url":"https://api.github.com/repos/pandas-dev/pandas","labels_url":"https://api.github.com/repos/pandas-dev/pandas/issues/20091/labels{/name}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/20091/comments","events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/20091/events","html_url":"https://github.com/pandas-dev/pandas/pull/20091","id":304032954,"number":20091,"title":"FIX: add support for desc order when ranking infs with nans #19538","user":{"login":"peterpanmj","id":13047435,"avatar_url":"https://avatars2.githubusercontent.com/u/13047435?v=4","gravatar_id":"","url":"https://api.github.com/users/peterpanmj","html_url":"https://github.com/peterpanmj","followers_url":"https://api.github.com/users/peterpanmj/followers","following_url":"https://api.github.com/users/peterpanmj/following{/other_user}","gists_url":"https://api.github.com/users/peterpanmj/gists{/gist_id}","starred_url":"https://api.github.com/users/peterpanmj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterpanmj/subscriptions","organizations_url":"https://api.github.com/users/peterpanmj/orgs","repos_url":"https://api.github.com/users/peterpanmj/repos","events_url":"https://api.github.com/users/peterpanmj/events{/privacy}","received_events_url":"https://api.github.com/users/peterpanmj/received_events","type":"User","site_admin":false},"labels":[{"id":76811,"url":"https://api.github.com/repos/pandas-dev/pandas/labels/Bug","name":"Bug","color":"e10c02","default":false},{"id":47223669,"url":"https://api.github.com/repos/pandas-dev/pandas/labels/Numeric","name":"Numeric","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/pandas-dev/pandas/milestones/53","html_url":"https://github.com/pandas-dev/pandas/milestone/53","labels_url":"https://api.github.com/repos/pandas-dev/pandas/milestones/53/labels","id":2853937,"number":53,"title":"0.23.0","description":"after 0.22","creator":{"login":"jreback","id":953992,"avatar_url":"https://avatars2.githubusercontent.com/u/953992?v=4","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"open_issues":151,"closed_issues":1346,"state":"open","created_at":"2017-10-20T10:17:09Z","updated_at":"2018-03-27T15:54:39Z","due_on":"2018-03-31T07:00:00Z","closed_at":null},"comments":10,"created_at":"2018-03-10T02:19:39Z","updated_at":"2018-03-27T17:43:08Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/20091","html_url":"https://github.com/pandas-dev/pandas/pull/20091","diff_url":"https://github.com/pandas-dev/pandas/pull/20091.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/20091.patch"},"body":"Please include the output of the validation script below between the \"```\" ticks:\r\n\r\n```\r\n################################################################################\r\n################ Docstring (pandas._libs.algos.rank_1d_object)  ################\r\n################################################################################\r\n\r\nFast NaN-friendly version of scipy.stats.rankdata\r\n\r\n################################################################################\r\n################################## Validation ##################################\r\n################################################################################\r\n\r\nErrors found:\r\n        Summary does not end with dot\r\n        No extended summary found\r\n        No returns section found\r\n        See Also section not found\r\n        No examples section found\r\n(pandas_dev)\r\n\r\n```\r\n\r\nChecklist for other PRs (remove this part if you are doing a PR for the pandas documentation sprint):\r\n\r\n- [x] closes #19538\r\n- [x] tests added / passed\r\n- [x] passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n- [x] whatsnew entry\r\n"},"comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments/376612951","html_url":"https://github.com/pandas-dev/pandas/pull/20091#issuecomment-376612951","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/20091","id":376612951,"user":{"login":"WillAyd","id":609873,"avatar_url":"https://avatars0.githubusercontent.com/u/609873?v=4","gravatar_id":"","url":"https://api.github.com/users/WillAyd","html_url":"https://github.com/WillAyd","followers_url":"https://api.github.com/users/WillAyd/followers","following_url":"https://api.github.com/users/WillAyd/following{/other_user}","gists_url":"https://api.github.com/users/WillAyd/gists{/gist_id}","starred_url":"https://api.github.com/users/WillAyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WillAyd/subscriptions","organizations_url":"https://api.github.com/users/WillAyd/orgs","repos_url":"https://api.github.com/users/WillAyd/repos","events_url":"https://api.github.com/users/WillAyd/events{/privacy}","received_events_url":"https://api.github.com/users/WillAyd/received_events","type":"User","site_admin":false},"created_at":"2018-03-27T17:43:08Z","updated_at":"2018-03-27T17:43:08Z","author_association":"CONTRIBUTOR","body":"Do you want to try and tackle the groupby implementation as part of this? I've linked the relevant function below - it isn't that drastically different from the algos rank implementation\r\n\r\nhttps://github.com/pandas-dev/pandas/blob/766a4800b4d9b7e847577b74b24128fcda8eeb55/pandas/_libs/groupby_helper.pxi.in#L415"}}
{"actor":{"display_login":"WillAyd"}}