{"action":"created","issue":{"url":"https://api.github.com/repos/insites/cookieconsent/issues/356","repository_url":"https://api.github.com/repos/insites/cookieconsent","labels_url":"https://api.github.com/repos/insites/cookieconsent/issues/356/labels{/name}","comments_url":"https://api.github.com/repos/insites/cookieconsent/issues/356/comments","events_url":"https://api.github.com/repos/insites/cookieconsent/issues/356/events","html_url":"https://github.com/insites/cookieconsent/pull/356","id":326266835,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwNDAxNTA4","number":356,"title":"fix HTML semantics & styling","user":{"login":"chharvey","id":1362083,"node_id":"MDQ6VXNlcjEzNjIwODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1362083?v=4","gravatar_id":"","url":"https://api.github.com/users/chharvey","html_url":"https://github.com/chharvey","followers_url":"https://api.github.com/users/chharvey/followers","following_url":"https://api.github.com/users/chharvey/following{/other_user}","gists_url":"https://api.github.com/users/chharvey/gists{/gist_id}","starred_url":"https://api.github.com/users/chharvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chharvey/subscriptions","organizations_url":"https://api.github.com/users/chharvey/orgs","repos_url":"https://api.github.com/users/chharvey/repos","events_url":"https://api.github.com/users/chharvey/events{/privacy}","received_events_url":"https://api.github.com/users/chharvey/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-24T19:52:19Z","updated_at":"2018-07-13T14:21:16Z","closed_at":"2018-07-13T14:21:16Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/insites/cookieconsent/pulls/356","html_url":"https://github.com/insites/cookieconsent/pull/356","diff_url":"https://github.com/insites/cookieconsent/pull/356.diff","patch_url":"https://github.com/insites/cookieconsent/pull/356.patch"},"body":"- use `header` for the header\r\n- use `div` instead of `span` for .cc-message, which are flex items; should be block, not inline\r\n- use `button` instead of `a[role=\"button\"]` for links without `href`\r\n- remove `role=\"button\"` for links with `href`"},"comment":{"url":"https://api.github.com/repos/insites/cookieconsent/issues/comments/404847787","html_url":"https://github.com/insites/cookieconsent/pull/356#issuecomment-404847787","issue_url":"https://api.github.com/repos/insites/cookieconsent/issues/356","id":404847787,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDg0Nzc4Nw==","user":{"login":"alexmorleyfinch","id":3381364,"node_id":"MDQ6VXNlcjMzODEzNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3381364?v=4","gravatar_id":"","url":"https://api.github.com/users/alexmorleyfinch","html_url":"https://github.com/alexmorleyfinch","followers_url":"https://api.github.com/users/alexmorleyfinch/followers","following_url":"https://api.github.com/users/alexmorleyfinch/following{/other_user}","gists_url":"https://api.github.com/users/alexmorleyfinch/gists{/gist_id}","starred_url":"https://api.github.com/users/alexmorleyfinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexmorleyfinch/subscriptions","organizations_url":"https://api.github.com/users/alexmorleyfinch/orgs","repos_url":"https://api.github.com/users/alexmorleyfinch/repos","events_url":"https://api.github.com/users/alexmorleyfinch/events{/privacy}","received_events_url":"https://api.github.com/users/alexmorleyfinch/received_events","type":"User","site_admin":false},"created_at":"2018-07-13T14:21:16Z","updated_at":"2018-07-13T14:21:16Z","author_association":"CONTRIBUTOR","body":"I don't know if the [`<header>`](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/header) tag is semantically correct in this instance. I'm happy to be shown wrong though.\r\n\r\nAlso, I think this could be a breaking change for anybody currently using our plugin with an old doctype. E.G. The HTML 4.01 strict doctype `<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 4.01//EN\" \"http://www.w3.org/TR/html4/strict.dtd\">`. Seeing as we never specified HTML5 in the docs.\r\n\r\nAlso, I don't think it matters if it's a `div` or a `span`, as either way, they are both set to `flex`. Meaning that neither of them are `inline` or `block`. So I think that's a non issue.\r\n\r\nI like the `<a>` to `<button>` change, but I think such a change could also break any existing styles people may have and I'd rather not risk it, seeing as there is no real need to. Seeing as they have `role=\"button\"`, meaning every semantic analyser in the world will know exactly what it is supposed to be.\r\n\r\nI think the aria labels make the HTML semantic enough for accessibility etc. Thanks for the contribution though!!"}}
{"actor":{"display_login":"alexmorleyfinch"}}