{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/jest/pulls/comments/232308742","pull_request_review_id":173482553,"id":232308742,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjMwODc0Mg==","diff_hunk":"@@ -23,4 +28,8 @@ module.exports = {\n       .substr(filename.lastIndexOf(path.sep) + 1)\n       .replace(/(\\.(android|ios|native))?\\.js$/, '');\n   },\n+\n+  setCacheKey(key) {\n+    cacheKey = key;","path":"packages/jest-haste-map/src/__tests__/haste_impl.js","position":20,"original_position":20,"commit_id":"7b198a2d45f71a28ce2e28a55d88f059c1fa256a","original_commit_id":"7b198a2d45f71a28ce2e28a55d88f059c1fa256a","user":{"login":"mjesun","id":829269,"node_id":"MDQ6VXNlcjgyOTI2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/829269?v=4","gravatar_id":"","url":"https://api.github.com/users/mjesun","html_url":"https://github.com/mjesun","followers_url":"https://api.github.com/users/mjesun/followers","following_url":"https://api.github.com/users/mjesun/following{/other_user}","gists_url":"https://api.github.com/users/mjesun/gists{/gist_id}","starred_url":"https://api.github.com/users/mjesun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjesun/subscriptions","organizations_url":"https://api.github.com/users/mjesun/orgs","repos_url":"https://api.github.com/users/mjesun/repos","events_url":"https://api.github.com/users/mjesun/events{/privacy}","received_events_url":"https://api.github.com/users/mjesun/received_events","type":"User","site_admin":false},"body":"The cache key shouldn't be setteable; we should follow the `transform` way, where only the getter exsists.","created_at":"2018-11-09T16:17:17Z","updated_at":"2018-11-09T16:17:26Z","html_url":"https://github.com/facebook/jest/pull/7350#discussion_r232308742","pull_request_url":"https://api.github.com/repos/facebook/jest/pulls/7350","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/facebook/jest/pulls/comments/232308742"},"html":{"href":"https://github.com/facebook/jest/pull/7350#discussion_r232308742"},"pull_request":{"href":"https://api.github.com/repos/facebook/jest/pulls/7350"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/jest/pulls/7350","id":229736025,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NzM2MDI1","html_url":"https://github.com/facebook/jest/pull/7350","diff_url":"https://github.com/facebook/jest/pull/7350.diff","patch_url":"https://github.com/facebook/jest/pull/7350.patch","issue_url":"https://api.github.com/repos/facebook/jest/issues/7350","number":7350,"state":"open","locked":false,"title":"Accept additional cache keys for haste map","user":{"login":"rubennorte","id":117921,"node_id":"MDQ6VXNlcjExNzkyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/117921?v=4","gravatar_id":"","url":"https://api.github.com/users/rubennorte","html_url":"https://github.com/rubennorte","followers_url":"https://api.github.com/users/rubennorte/followers","following_url":"https://api.github.com/users/rubennorte/following{/other_user}","gists_url":"https://api.github.com/users/rubennorte/gists{/gist_id}","starred_url":"https://api.github.com/users/rubennorte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubennorte/subscriptions","organizations_url":"https://api.github.com/users/rubennorte/orgs","repos_url":"https://api.github.com/users/rubennorte/repos","events_url":"https://api.github.com/users/rubennorte/events{/privacy}","received_events_url":"https://api.github.com/users/rubennorte/received_events","type":"User","site_admin":false},"body":"## Summary\r\n\r\nRight now the `hasteImplModulePath` (used to extract \"global\" module names from file paths) and `dependencyExtractor` options are not taken into account to compute the cache key for the haste map. Those options affect a great deal how the haste map is generated, so if they change the haste map should be regenerated (e.g. if we change the dependency extractor to add a new type of dependency, they won't be included in the files that are currently cached in the haste map).\r\n\r\n## Test plan\r\n\r\nAdded unit tests to check this.\r\n","created_at":"2018-11-09T15:50:59Z","updated_at":"2018-11-09T16:17:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"969e193fb1f4983634303b44bb60919dd5f68f7c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":847426897,"node_id":"MDU6TGFiZWw4NDc0MjY4OTc=","url":"https://api.github.com/repos/facebook/jest/labels/cla%20signed","name":"cla signed","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/jest/pulls/7350/commits","review_comments_url":"https://api.github.com/repos/facebook/jest/pulls/7350/comments","review_comment_url":"https://api.github.com/repos/facebook/jest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/jest/issues/7350/comments","statuses_url":"https://api.github.com/repos/facebook/jest/statuses/7b198a2d45f71a28ce2e28a55d88f059c1fa256a","head":{"label":"rubennorte:accept-additional-cache-keys-for-haste-map","ref":"accept-additional-cache-keys-for-haste-map","sha":"7b198a2d45f71a28ce2e28a55d88f059c1fa256a","user":{"login":"rubennorte","id":117921,"node_id":"MDQ6VXNlcjExNzkyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/117921?v=4","gravatar_id":"","url":"https://api.github.com/users/rubennorte","html_url":"https://github.com/rubennorte","followers_url":"https://api.github.com/users/rubennorte/followers","following_url":"https://api.github.com/users/rubennorte/following{/other_user}","gists_url":"https://api.github.com/users/rubennorte/gists{/gist_id}","starred_url":"https://api.github.com/users/rubennorte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubennorte/subscriptions","organizations_url":"https://api.github.com/users/rubennorte/orgs","repos_url":"https://api.github.com/users/rubennorte/repos","events_url":"https://api.github.com/users/rubennorte/events{/privacy}","received_events_url":"https://api.github.com/users/rubennorte/received_events","type":"User","site_admin":false},"repo":{"id":130679462,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA2Nzk0NjI=","name":"jest","full_name":"rubennorte/jest","private":false,"owner":{"login":"rubennorte","id":117921,"node_id":"MDQ6VXNlcjExNzkyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/117921?v=4","gravatar_id":"","url":"https://api.github.com/users/rubennorte","html_url":"https://github.com/rubennorte","followers_url":"https://api.github.com/users/rubennorte/followers","following_url":"https://api.github.com/users/rubennorte/following{/other_user}","gists_url":"https://api.github.com/users/rubennorte/gists{/gist_id}","starred_url":"https://api.github.com/users/rubennorte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubennorte/subscriptions","organizations_url":"https://api.github.com/users/rubennorte/orgs","repos_url":"https://api.github.com/users/rubennorte/repos","events_url":"https://api.github.com/users/rubennorte/events{/privacy}","received_events_url":"https://api.github.com/users/rubennorte/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rubennorte/jest","description":"🃏 Delightful JavaScript Testing.","fork":true,"url":"https://api.github.com/repos/rubennorte/jest","forks_url":"https://api.github.com/repos/rubennorte/jest/forks","keys_url":"https://api.github.com/repos/rubennorte/jest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubennorte/jest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubennorte/jest/teams","hooks_url":"https://api.github.com/repos/rubennorte/jest/hooks","issue_events_url":"https://api.github.com/repos/rubennorte/jest/issues/events{/number}","events_url":"https://api.github.com/repos/rubennorte/jest/events","assignees_url":"https://api.github.com/repos/rubennorte/jest/assignees{/user}","branches_url":"https://api.github.com/repos/rubennorte/jest/branches{/branch}","tags_url":"https://api.github.com/repos/rubennorte/jest/tags","blobs_url":"https://api.github.com/repos/rubennorte/jest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubennorte/jest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubennorte/jest/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubennorte/jest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubennorte/jest/statuses/{sha}","languages_url":"https://api.github.com/repos/rubennorte/jest/languages","stargazers_url":"https://api.github.com/repos/rubennorte/jest/stargazers","contributors_url":"https://api.github.com/repos/rubennorte/jest/contributors","subscribers_url":"https://api.github.com/repos/rubennorte/jest/subscribers","subscription_url":"https://api.github.com/repos/rubennorte/jest/subscription","commits_url":"https://api.github.com/repos/rubennorte/jest/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubennorte/jest/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubennorte/jest/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubennorte/jest/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubennorte/jest/contents/{+path}","compare_url":"https://api.github.com/repos/rubennorte/jest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubennorte/jest/merges","archive_url":"https://api.github.com/repos/rubennorte/jest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubennorte/jest/downloads","issues_url":"https://api.github.com/repos/rubennorte/jest/issues{/number}","pulls_url":"https://api.github.com/repos/rubennorte/jest/pulls{/number}","milestones_url":"https://api.github.com/repos/rubennorte/jest/milestones{/number}","notifications_url":"https://api.github.com/repos/rubennorte/jest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubennorte/jest/labels{/name}","releases_url":"https://api.github.com/repos/rubennorte/jest/releases{/id}","deployments_url":"https://api.github.com/repos/rubennorte/jest/deployments","created_at":"2018-04-23T10:24:05Z","updated_at":"2018-11-08T13:18:56Z","pushed_at":"2018-11-09T16:13:38Z","git_url":"git://github.com/rubennorte/jest.git","ssh_url":"git@github.com:rubennorte/jest.git","clone_url":"https://github.com/rubennorte/jest.git","svn_url":"https://github.com/rubennorte/jest","homepage":"https://facebook.github.io/jest/","size":83919,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"213d8e5c22497a5b8730fbeec1d02b807956626e","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":15062869,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA2Mjg2OQ==","name":"jest","full_name":"facebook/jest","private":false,"owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/facebook/jest","description":"🃏 Delightful JavaScript Testing.","fork":false,"url":"https://api.github.com/repos/facebook/jest","forks_url":"https://api.github.com/repos/facebook/jest/forks","keys_url":"https://api.github.com/repos/facebook/jest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/jest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/jest/teams","hooks_url":"https://api.github.com/repos/facebook/jest/hooks","issue_events_url":"https://api.github.com/repos/facebook/jest/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/jest/events","assignees_url":"https://api.github.com/repos/facebook/jest/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/jest/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/jest/tags","blobs_url":"https://api.github.com/repos/facebook/jest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/jest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/jest/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/jest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/jest/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/jest/languages","stargazers_url":"https://api.github.com/repos/facebook/jest/stargazers","contributors_url":"https://api.github.com/repos/facebook/jest/contributors","subscribers_url":"https://api.github.com/repos/facebook/jest/subscribers","subscription_url":"https://api.github.com/repos/facebook/jest/subscription","commits_url":"https://api.github.com/repos/facebook/jest/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/jest/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/jest/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/jest/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/jest/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/jest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/jest/merges","archive_url":"https://api.github.com/repos/facebook/jest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/jest/downloads","issues_url":"https://api.github.com/repos/facebook/jest/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/jest/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/jest/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/jest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/jest/labels{/name}","releases_url":"https://api.github.com/repos/facebook/jest/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/jest/deployments","created_at":"2013-12-10T00:18:04Z","updated_at":"2018-11-09T16:10:34Z","pushed_at":"2018-11-09T16:13:40Z","git_url":"git://github.com/facebook/jest.git","ssh_url":"git@github.com:facebook/jest.git","clone_url":"https://github.com/facebook/jest.git","svn_url":"https://github.com/facebook/jest","homepage":"https://facebook.github.io/jest/","size":126480,"stargazers_count":21510,"watchers_count":21510,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2856,"mirror_url":null,"archived":false,"open_issues_count":523,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2856,"open_issues":523,"watchers":21510,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/jest/pulls/7350"},"html":{"href":"https://github.com/facebook/jest/pull/7350"},"issue":{"href":"https://api.github.com/repos/facebook/jest/issues/7350"},"comments":{"href":"https://api.github.com/repos/facebook/jest/issues/7350/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/jest/pulls/7350/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/jest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/jest/pulls/7350/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/jest/statuses/7b198a2d45f71a28ce2e28a55d88f059c1fa256a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mjesun"}}