{"action":"created","issue":{"url":"https://api.github.com/repos/lubyk/lub/issues/3","repository_url":"https://api.github.com/repos/lubyk/lub","labels_url":"https://api.github.com/repos/lubyk/lub/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/lubyk/lub/issues/3/comments","events_url":"https://api.github.com/repos/lubyk/lub/issues/3/events","html_url":"https://github.com/lubyk/lub/issues/3","id":338724206,"node_id":"MDU6SXNzdWUzMzg3MjQyMDY=","number":3,"title":"lib.join is slow and unnecessary","user":{"login":"dlaurie","id":2052924,"node_id":"MDQ6VXNlcjIwNTI5MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2052924?v=4","gravatar_id":"","url":"https://api.github.com/users/dlaurie","html_url":"https://github.com/dlaurie","followers_url":"https://api.github.com/users/dlaurie/followers","following_url":"https://api.github.com/users/dlaurie/following{/other_user}","gists_url":"https://api.github.com/users/dlaurie/gists{/gist_id}","starred_url":"https://api.github.com/users/dlaurie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlaurie/subscriptions","organizations_url":"https://api.github.com/users/dlaurie/orgs","repos_url":"https://api.github.com/users/dlaurie/repos","events_url":"https://api.github.com/users/dlaurie/events{/privacy}","received_events_url":"https://api.github.com/users/dlaurie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-05T20:59:51Z","updated_at":"2018-07-14T13:52:14Z","closed_at":null,"author_association":"NONE","body":"The algorithm in lib.join is extremely slow, requiring allocation of a new string for every element in the array. Moreover, lib.join appears to do exactly the same as the standard function table.concat.\r\n\r\nSuggestion: replace its definition by\r\n\r\nlib.join = table.concat\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/lubyk/lub/issues/comments/405025070","html_url":"https://github.com/lubyk/lub/issues/3#issuecomment-405025070","issue_url":"https://api.github.com/repos/lubyk/lub/issues/3","id":405025070,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTAyNTA3MA==","user":{"login":"dlaurie","id":2052924,"node_id":"MDQ6VXNlcjIwNTI5MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2052924?v=4","gravatar_id":"","url":"https://api.github.com/users/dlaurie","html_url":"https://github.com/dlaurie","followers_url":"https://api.github.com/users/dlaurie/followers","following_url":"https://api.github.com/users/dlaurie/following{/other_user}","gists_url":"https://api.github.com/users/dlaurie/gists{/gist_id}","starred_url":"https://api.github.com/users/dlaurie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlaurie/subscriptions","organizations_url":"https://api.github.com/users/dlaurie/orgs","repos_url":"https://api.github.com/users/dlaurie/repos","events_url":"https://api.github.com/users/dlaurie/events{/privacy}","received_events_url":"https://api.github.com/users/dlaurie/received_events","type":"User","site_admin":false},"created_at":"2018-07-14T13:52:13Z","updated_at":"2018-07-14T13:52:13Z","author_association":"NONE","body":"Hi Gaspard,\n\nThank you for responding. I would be grateful for write access, which I\npromise to use responsibly.\n\nBest wishes.\nDirk\n\n2018-07-14 13:42 GMT+02:00 Gaspard Bucher <notifications@github.com>:\n\n> Hi @dlaurie <https://github.com/dlaurie>. I'm sorry that I don't work\n> with Lua anymore and am not maintaining this. I can give you write access\n> to the repo and arrange so that you can publish to luarocks if you want.\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/lubyk/lub/issues/3#issuecomment-405017768>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AB9TPKe7DlQsUBWsNmKt5a3Vrp8ZF2S3ks5uGdksgaJpZM4VEiJ2>\n> .\n>\n"}}
{"actor":{"display_login":"dlaurie"}}