{"action":"created","comment":{"url":"https://api.github.com/repos/newsuk/times-components/pulls/comments/200622279","pull_request_review_id":134974953,"id":200622279,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDYyMjI3OQ==","diff_hunk":"@@ -0,0 +1,41 @@\n+{\n+  \"name\": \"@times-components/android-app\",\n+  \"version\": \"0.1.1\",","path":"android-app/package.json","position":3,"original_position":3,"commit_id":"d5641ec19b311cda3515534e74090ff8c98a965d","original_commit_id":"b5f8c99867b84e5b68f56c906635ae1cc859e962","user":{"login":"tuncaulubilge","id":1849590,"node_id":"MDQ6VXNlcjE4NDk1OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1849590?v=4","gravatar_id":"","url":"https://api.github.com/users/tuncaulubilge","html_url":"https://github.com/tuncaulubilge","followers_url":"https://api.github.com/users/tuncaulubilge/followers","following_url":"https://api.github.com/users/tuncaulubilge/following{/other_user}","gists_url":"https://api.github.com/users/tuncaulubilge/gists{/gist_id}","starred_url":"https://api.github.com/users/tuncaulubilge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuncaulubilge/subscriptions","organizations_url":"https://api.github.com/users/tuncaulubilge/orgs","repos_url":"https://api.github.com/users/tuncaulubilge/repos","events_url":"https://api.github.com/users/tuncaulubilge/events{/privacy}","received_events_url":"https://api.github.com/users/tuncaulubilge/received_events","type":"User","site_admin":false},"body":"This should be bumped just like the other packages and publish should be run afterwards, as the native lib uses this version info","created_at":"2018-07-06T11:09:52Z","updated_at":"2018-07-06T11:09:52Z","html_url":"https://github.com/newsuk/times-components/pull/1082#discussion_r200622279","pull_request_url":"https://api.github.com/repos/newsuk/times-components/pulls/1082","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/comments/200622279"},"html":{"href":"https://github.com/newsuk/times-components/pull/1082#discussion_r200622279"},"pull_request":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/1082"}},"in_reply_to_id":200621914},"pull_request":{"url":"https://api.github.com/repos/newsuk/times-components/pulls/1082","id":199443055,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NDQzMDU1","html_url":"https://github.com/newsuk/times-components/pull/1082","diff_url":"https://github.com/newsuk/times-components/pull/1082.diff","patch_url":"https://github.com/newsuk/times-components/pull/1082.patch","issue_url":"https://api.github.com/repos/newsuk/times-components/issues/1082","number":1082,"state":"open","locked":false,"title":"Xnative","user":{"login":"tuncaulubilge","id":1849590,"node_id":"MDQ6VXNlcjE4NDk1OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1849590?v=4","gravatar_id":"","url":"https://api.github.com/users/tuncaulubilge","html_url":"https://github.com/tuncaulubilge","followers_url":"https://api.github.com/users/tuncaulubilge/followers","following_url":"https://api.github.com/users/tuncaulubilge/following{/other_user}","gists_url":"https://api.github.com/users/tuncaulubilge/gists{/gist_id}","starred_url":"https://api.github.com/users/tuncaulubilge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuncaulubilge/subscriptions","organizations_url":"https://api.github.com/users/tuncaulubilge/orgs","repos_url":"https://api.github.com/users/tuncaulubilge/repos","events_url":"https://api.github.com/users/tuncaulubilge/events{/privacy}","received_events_url":"https://api.github.com/users/tuncaulubilge/received_events","type":"User","site_admin":false},"body":"Moving in times-xnative into times-components\r\n\r\nWhat's done?\r\n- Created a pages package, which can be used for all 3 platforms.\r\n- Created ios-app and android-app packages, which are consumers of pages package and used to run react-native dev server (haul) and bundle a native library\r\n- Added scripts to root for dev server (`yarn android:app` and `yarn ios:app`)\r\n\r\n\r\nWhat's next?\r\nWe can start using this structure right away, but there are some improvements we can do\r\n- Testing in pages package\r\n- Showcases for pages package\r\n- Set haul to use source codes instead of transpiled code\r\n- Improve pages so render can use it\r\n\r\n","created_at":"2018-07-05T11:41:27Z","updated_at":"2018-07-06T11:09:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"647a87c7793503268c559fdf52d66e85cd857dae","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/newsuk/times-components/pulls/1082/commits","review_comments_url":"https://api.github.com/repos/newsuk/times-components/pulls/1082/comments","review_comment_url":"https://api.github.com/repos/newsuk/times-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/newsuk/times-components/issues/1082/comments","statuses_url":"https://api.github.com/repos/newsuk/times-components/statuses/d5641ec19b311cda3515534e74090ff8c98a965d","head":{"label":"newsuk:xnative","ref":"xnative","sha":"d5641ec19b311cda3515534e74090ff8c98a965d","user":{"login":"newsuk","id":736306,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNjMwNg==","avatar_url":"https://avatars1.githubusercontent.com/u/736306?v=4","gravatar_id":"","url":"https://api.github.com/users/newsuk","html_url":"https://github.com/newsuk","followers_url":"https://api.github.com/users/newsuk/followers","following_url":"https://api.github.com/users/newsuk/following{/other_user}","gists_url":"https://api.github.com/users/newsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/newsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newsuk/subscriptions","organizations_url":"https://api.github.com/users/newsuk/orgs","repos_url":"https://api.github.com/users/newsuk/repos","events_url":"https://api.github.com/users/newsuk/events{/privacy}","received_events_url":"https://api.github.com/users/newsuk/received_events","type":"Organization","site_admin":false},"repo":{"id":93151110,"node_id":"MDEwOlJlcG9zaXRvcnk5MzE1MTExMA==","name":"times-components","full_name":"newsuk/times-components","owner":{"login":"newsuk","id":736306,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNjMwNg==","avatar_url":"https://avatars1.githubusercontent.com/u/736306?v=4","gravatar_id":"","url":"https://api.github.com/users/newsuk","html_url":"https://github.com/newsuk","followers_url":"https://api.github.com/users/newsuk/followers","following_url":"https://api.github.com/users/newsuk/following{/other_user}","gists_url":"https://api.github.com/users/newsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/newsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newsuk/subscriptions","organizations_url":"https://api.github.com/users/newsuk/orgs","repos_url":"https://api.github.com/users/newsuk/repos","events_url":"https://api.github.com/users/newsuk/events{/privacy}","received_events_url":"https://api.github.com/users/newsuk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/newsuk/times-components","description":"A collection of reusable components used by The Times","fork":false,"url":"https://api.github.com/repos/newsuk/times-components","forks_url":"https://api.github.com/repos/newsuk/times-components/forks","keys_url":"https://api.github.com/repos/newsuk/times-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/newsuk/times-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/newsuk/times-components/teams","hooks_url":"https://api.github.com/repos/newsuk/times-components/hooks","issue_events_url":"https://api.github.com/repos/newsuk/times-components/issues/events{/number}","events_url":"https://api.github.com/repos/newsuk/times-components/events","assignees_url":"https://api.github.com/repos/newsuk/times-components/assignees{/user}","branches_url":"https://api.github.com/repos/newsuk/times-components/branches{/branch}","tags_url":"https://api.github.com/repos/newsuk/times-components/tags","blobs_url":"https://api.github.com/repos/newsuk/times-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/newsuk/times-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/newsuk/times-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/newsuk/times-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/newsuk/times-components/statuses/{sha}","languages_url":"https://api.github.com/repos/newsuk/times-components/languages","stargazers_url":"https://api.github.com/repos/newsuk/times-components/stargazers","contributors_url":"https://api.github.com/repos/newsuk/times-components/contributors","subscribers_url":"https://api.github.com/repos/newsuk/times-components/subscribers","subscription_url":"https://api.github.com/repos/newsuk/times-components/subscription","commits_url":"https://api.github.com/repos/newsuk/times-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/newsuk/times-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/newsuk/times-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/newsuk/times-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/newsuk/times-components/contents/{+path}","compare_url":"https://api.github.com/repos/newsuk/times-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/newsuk/times-components/merges","archive_url":"https://api.github.com/repos/newsuk/times-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/newsuk/times-components/downloads","issues_url":"https://api.github.com/repos/newsuk/times-components/issues{/number}","pulls_url":"https://api.github.com/repos/newsuk/times-components/pulls{/number}","milestones_url":"https://api.github.com/repos/newsuk/times-components/milestones{/number}","notifications_url":"https://api.github.com/repos/newsuk/times-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/newsuk/times-components/labels{/name}","releases_url":"https://api.github.com/repos/newsuk/times-components/releases{/id}","deployments_url":"https://api.github.com/repos/newsuk/times-components/deployments","created_at":"2017-06-02T09:41:03Z","updated_at":"2018-07-06T10:33:46Z","pushed_at":"2018-07-06T11:08:58Z","git_url":"git://github.com/newsuk/times-components.git","ssh_url":"git@github.com:newsuk/times-components.git","clone_url":"https://github.com/newsuk/times-components.git","svn_url":"https://github.com/newsuk/times-components","homepage":"http://components.thetimes.co.uk","size":50304,"stargazers_count":82,"watchers_count":82,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":12,"open_issues":33,"watchers":82,"default_branch":"master"}},"base":{"label":"newsuk:master","ref":"master","sha":"8b572857d0b71673ec6c69b01e0bf2c19bcbfbd6","user":{"login":"newsuk","id":736306,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNjMwNg==","avatar_url":"https://avatars1.githubusercontent.com/u/736306?v=4","gravatar_id":"","url":"https://api.github.com/users/newsuk","html_url":"https://github.com/newsuk","followers_url":"https://api.github.com/users/newsuk/followers","following_url":"https://api.github.com/users/newsuk/following{/other_user}","gists_url":"https://api.github.com/users/newsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/newsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newsuk/subscriptions","organizations_url":"https://api.github.com/users/newsuk/orgs","repos_url":"https://api.github.com/users/newsuk/repos","events_url":"https://api.github.com/users/newsuk/events{/privacy}","received_events_url":"https://api.github.com/users/newsuk/received_events","type":"Organization","site_admin":false},"repo":{"id":93151110,"node_id":"MDEwOlJlcG9zaXRvcnk5MzE1MTExMA==","name":"times-components","full_name":"newsuk/times-components","owner":{"login":"newsuk","id":736306,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNjMwNg==","avatar_url":"https://avatars1.githubusercontent.com/u/736306?v=4","gravatar_id":"","url":"https://api.github.com/users/newsuk","html_url":"https://github.com/newsuk","followers_url":"https://api.github.com/users/newsuk/followers","following_url":"https://api.github.com/users/newsuk/following{/other_user}","gists_url":"https://api.github.com/users/newsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/newsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newsuk/subscriptions","organizations_url":"https://api.github.com/users/newsuk/orgs","repos_url":"https://api.github.com/users/newsuk/repos","events_url":"https://api.github.com/users/newsuk/events{/privacy}","received_events_url":"https://api.github.com/users/newsuk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/newsuk/times-components","description":"A collection of reusable components used by The Times","fork":false,"url":"https://api.github.com/repos/newsuk/times-components","forks_url":"https://api.github.com/repos/newsuk/times-components/forks","keys_url":"https://api.github.com/repos/newsuk/times-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/newsuk/times-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/newsuk/times-components/teams","hooks_url":"https://api.github.com/repos/newsuk/times-components/hooks","issue_events_url":"https://api.github.com/repos/newsuk/times-components/issues/events{/number}","events_url":"https://api.github.com/repos/newsuk/times-components/events","assignees_url":"https://api.github.com/repos/newsuk/times-components/assignees{/user}","branches_url":"https://api.github.com/repos/newsuk/times-components/branches{/branch}","tags_url":"https://api.github.com/repos/newsuk/times-components/tags","blobs_url":"https://api.github.com/repos/newsuk/times-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/newsuk/times-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/newsuk/times-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/newsuk/times-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/newsuk/times-components/statuses/{sha}","languages_url":"https://api.github.com/repos/newsuk/times-components/languages","stargazers_url":"https://api.github.com/repos/newsuk/times-components/stargazers","contributors_url":"https://api.github.com/repos/newsuk/times-components/contributors","subscribers_url":"https://api.github.com/repos/newsuk/times-components/subscribers","subscription_url":"https://api.github.com/repos/newsuk/times-components/subscription","commits_url":"https://api.github.com/repos/newsuk/times-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/newsuk/times-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/newsuk/times-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/newsuk/times-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/newsuk/times-components/contents/{+path}","compare_url":"https://api.github.com/repos/newsuk/times-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/newsuk/times-components/merges","archive_url":"https://api.github.com/repos/newsuk/times-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/newsuk/times-components/downloads","issues_url":"https://api.github.com/repos/newsuk/times-components/issues{/number}","pulls_url":"https://api.github.com/repos/newsuk/times-components/pulls{/number}","milestones_url":"https://api.github.com/repos/newsuk/times-components/milestones{/number}","notifications_url":"https://api.github.com/repos/newsuk/times-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/newsuk/times-components/labels{/name}","releases_url":"https://api.github.com/repos/newsuk/times-components/releases{/id}","deployments_url":"https://api.github.com/repos/newsuk/times-components/deployments","created_at":"2017-06-02T09:41:03Z","updated_at":"2018-07-06T10:33:46Z","pushed_at":"2018-07-06T11:08:58Z","git_url":"git://github.com/newsuk/times-components.git","ssh_url":"git@github.com:newsuk/times-components.git","clone_url":"https://github.com/newsuk/times-components.git","svn_url":"https://github.com/newsuk/times-components","homepage":"http://components.thetimes.co.uk","size":50304,"stargazers_count":82,"watchers_count":82,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":12,"open_issues":33,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/1082"},"html":{"href":"https://github.com/newsuk/times-components/pull/1082"},"issue":{"href":"https://api.github.com/repos/newsuk/times-components/issues/1082"},"comments":{"href":"https://api.github.com/repos/newsuk/times-components/issues/1082/comments"},"review_comments":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/1082/comments"},"review_comment":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/1082/commits"},"statuses":{"href":"https://api.github.com/repos/newsuk/times-components/statuses/d5641ec19b311cda3515534e74090ff8c98a965d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tuncaulubilge"}}