{"action":"created","comment":{"url":"https://api.github.com/repos/qiniu/logkit/pulls/comments/209881718","pull_request_review_id":145978473,"id":209881718,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTg4MTcxOA==","diff_hunk":"@@ -426,7 +469,10 @@ func (d *diskQueue) saveToDisk() {\n \tfor {\n \t\tselect {\n \t\tcase msg := <-d.memoryChan:\n-\t\t\td.writeOne(msg)\n+\t\t\terr := d.writeOne(msg)\n+\t\t\tif err != nil {\n+\t\t\t\tlog.Errorf(\"DISKQUEUE(%s): drop one msg from memory chan - %v\", d.name, err)","path":"queue/disk.go","position":279,"original_position":279,"commit_id":"97a22d26f7c85dfff4348243569b9a6808bc7115","original_commit_id":"d044334274ea528563364440ac28b9f03f10c903","user":{"login":"Unknwon","id":2946214,"node_id":"MDQ6VXNlcjI5NDYyMTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2946214?v=4","gravatar_id":"","url":"https://api.github.com/users/Unknwon","html_url":"https://github.com/Unknwon","followers_url":"https://api.github.com/users/Unknwon/followers","following_url":"https://api.github.com/users/Unknwon/following{/other_user}","gists_url":"https://api.github.com/users/Unknwon/gists{/gist_id}","starred_url":"https://api.github.com/users/Unknwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unknwon/subscriptions","organizations_url":"https://api.github.com/users/Unknwon/orgs","repos_url":"https://api.github.com/users/Unknwon/repos","events_url":"https://api.github.com/users/Unknwon/events{/privacy}","received_events_url":"https://api.github.com/users/Unknwon/received_events","type":"User","site_admin":false},"body":"如果 writeOne 一直失败就会无限循环退出不来","created_at":"2018-08-14T09:16:05Z","updated_at":"2018-08-14T09:16:05Z","html_url":"https://github.com/qiniu/logkit/pull/706#discussion_r209881718","pull_request_url":"https://api.github.com/repos/qiniu/logkit/pulls/706","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/qiniu/logkit/pulls/comments/209881718"},"html":{"href":"https://github.com/qiniu/logkit/pull/706#discussion_r209881718"},"pull_request":{"href":"https://api.github.com/repos/qiniu/logkit/pulls/706"}},"in_reply_to_id":209875427},"pull_request":{"url":"https://api.github.com/repos/qiniu/logkit/pulls/706","id":207905503,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3OTA1NTAz","html_url":"https://github.com/qiniu/logkit/pull/706","diff_url":"https://github.com/qiniu/logkit/pull/706.diff","patch_url":"https://github.com/qiniu/logkit/pull/706.patch","issue_url":"https://api.github.com/repos/qiniu/logkit/issues/706","number":706,"state":"open","locked":false,"title":"queue: able to set max disk used bytes for diskQueue","user":{"login":"Unknwon","id":2946214,"node_id":"MDQ6VXNlcjI5NDYyMTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2946214?v=4","gravatar_id":"","url":"https://api.github.com/users/Unknwon","html_url":"https://github.com/Unknwon","followers_url":"https://api.github.com/users/Unknwon/followers","following_url":"https://api.github.com/users/Unknwon/following{/other_user}","gists_url":"https://api.github.com/users/Unknwon/gists{/gist_id}","starred_url":"https://api.github.com/users/Unknwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unknwon/subscriptions","organizations_url":"https://api.github.com/users/Unknwon/orgs","repos_url":"https://api.github.com/users/Unknwon/repos","events_url":"https://api.github.com/users/Unknwon/events{/privacy}","received_events_url":"https://api.github.com/users/Unknwon/received_events","type":"User","site_admin":false},"body":"JIRA: https://jira.qiniu.io/browse/PDR-7002\r\n\r\n1. 支持给 diskQueue 设置最大磁盘使用量，多余的数据直接丢弃\r\n2. queue 相关测试改为并行执行","created_at":"2018-08-13T08:36:49Z","updated_at":"2018-08-14T09:16:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f77b6914c574f532b3e3b2690410a3ea606bea3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/qiniu/logkit/pulls/706/commits","review_comments_url":"https://api.github.com/repos/qiniu/logkit/pulls/706/comments","review_comment_url":"https://api.github.com/repos/qiniu/logkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qiniu/logkit/issues/706/comments","statuses_url":"https://api.github.com/repos/qiniu/logkit/statuses/97a22d26f7c85dfff4348243569b9a6808bc7115","head":{"label":"Unknwon:PDR-7002-disk-queue-max-disk-usage","ref":"PDR-7002-disk-queue-max-disk-usage","sha":"97a22d26f7c85dfff4348243569b9a6808bc7115","user":{"login":"Unknwon","id":2946214,"node_id":"MDQ6VXNlcjI5NDYyMTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2946214?v=4","gravatar_id":"","url":"https://api.github.com/users/Unknwon","html_url":"https://github.com/Unknwon","followers_url":"https://api.github.com/users/Unknwon/followers","following_url":"https://api.github.com/users/Unknwon/following{/other_user}","gists_url":"https://api.github.com/users/Unknwon/gists{/gist_id}","starred_url":"https://api.github.com/users/Unknwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unknwon/subscriptions","organizations_url":"https://api.github.com/users/Unknwon/orgs","repos_url":"https://api.github.com/users/Unknwon/repos","events_url":"https://api.github.com/users/Unknwon/events{/privacy}","received_events_url":"https://api.github.com/users/Unknwon/received_events","type":"User","site_admin":false},"repo":{"id":134546209,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ1NDYyMDk=","name":"logkit","full_name":"Unknwon/logkit","owner":{"login":"Unknwon","id":2946214,"node_id":"MDQ6VXNlcjI5NDYyMTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2946214?v=4","gravatar_id":"","url":"https://api.github.com/users/Unknwon","html_url":"https://github.com/Unknwon","followers_url":"https://api.github.com/users/Unknwon/followers","following_url":"https://api.github.com/users/Unknwon/following{/other_user}","gists_url":"https://api.github.com/users/Unknwon/gists{/gist_id}","starred_url":"https://api.github.com/users/Unknwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unknwon/subscriptions","organizations_url":"https://api.github.com/users/Unknwon/orgs","repos_url":"https://api.github.com/users/Unknwon/repos","events_url":"https://api.github.com/users/Unknwon/events{/privacy}","received_events_url":"https://api.github.com/users/Unknwon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Unknwon/logkit","description":"Very powerful server agent for collecting & sending logs & metrics with an easy-to-use web console.","fork":true,"url":"https://api.github.com/repos/Unknwon/logkit","forks_url":"https://api.github.com/repos/Unknwon/logkit/forks","keys_url":"https://api.github.com/repos/Unknwon/logkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unknwon/logkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unknwon/logkit/teams","hooks_url":"https://api.github.com/repos/Unknwon/logkit/hooks","issue_events_url":"https://api.github.com/repos/Unknwon/logkit/issues/events{/number}","events_url":"https://api.github.com/repos/Unknwon/logkit/events","assignees_url":"https://api.github.com/repos/Unknwon/logkit/assignees{/user}","branches_url":"https://api.github.com/repos/Unknwon/logkit/branches{/branch}","tags_url":"https://api.github.com/repos/Unknwon/logkit/tags","blobs_url":"https://api.github.com/repos/Unknwon/logkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unknwon/logkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unknwon/logkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unknwon/logkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unknwon/logkit/statuses/{sha}","languages_url":"https://api.github.com/repos/Unknwon/logkit/languages","stargazers_url":"https://api.github.com/repos/Unknwon/logkit/stargazers","contributors_url":"https://api.github.com/repos/Unknwon/logkit/contributors","subscribers_url":"https://api.github.com/repos/Unknwon/logkit/subscribers","subscription_url":"https://api.github.com/repos/Unknwon/logkit/subscription","commits_url":"https://api.github.com/repos/Unknwon/logkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unknwon/logkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unknwon/logkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unknwon/logkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unknwon/logkit/contents/{+path}","compare_url":"https://api.github.com/repos/Unknwon/logkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unknwon/logkit/merges","archive_url":"https://api.github.com/repos/Unknwon/logkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unknwon/logkit/downloads","issues_url":"https://api.github.com/repos/Unknwon/logkit/issues{/number}","pulls_url":"https://api.github.com/repos/Unknwon/logkit/pulls{/number}","milestones_url":"https://api.github.com/repos/Unknwon/logkit/milestones{/number}","notifications_url":"https://api.github.com/repos/Unknwon/logkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unknwon/logkit/labels{/name}","releases_url":"https://api.github.com/repos/Unknwon/logkit/releases{/id}","deployments_url":"https://api.github.com/repos/Unknwon/logkit/deployments","created_at":"2018-05-23T09:31:08Z","updated_at":"2018-08-13T10:21:11Z","pushed_at":"2018-08-14T09:13:48Z","git_url":"git://github.com/Unknwon/logkit.git","ssh_url":"git@github.com:Unknwon/logkit.git","clone_url":"https://github.com/Unknwon/logkit.git","svn_url":"https://github.com/Unknwon/logkit","homepage":"https://pandora-docs.qiniu.com","size":20469,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"qiniu:master","ref":"master","sha":"372c4f8ddc0447966c2d997e7b95bc9fefab285d","user":{"login":"qiniu","id":1563636,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjM2MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1563636?v=4","gravatar_id":"","url":"https://api.github.com/users/qiniu","html_url":"https://github.com/qiniu","followers_url":"https://api.github.com/users/qiniu/followers","following_url":"https://api.github.com/users/qiniu/following{/other_user}","gists_url":"https://api.github.com/users/qiniu/gists{/gist_id}","starred_url":"https://api.github.com/users/qiniu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiniu/subscriptions","organizations_url":"https://api.github.com/users/qiniu/orgs","repos_url":"https://api.github.com/users/qiniu/repos","events_url":"https://api.github.com/users/qiniu/events{/privacy}","received_events_url":"https://api.github.com/users/qiniu/received_events","type":"Organization","site_admin":false},"repo":{"id":91304426,"node_id":"MDEwOlJlcG9zaXRvcnk5MTMwNDQyNg==","name":"logkit","full_name":"qiniu/logkit","owner":{"login":"qiniu","id":1563636,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjM2MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1563636?v=4","gravatar_id":"","url":"https://api.github.com/users/qiniu","html_url":"https://github.com/qiniu","followers_url":"https://api.github.com/users/qiniu/followers","following_url":"https://api.github.com/users/qiniu/following{/other_user}","gists_url":"https://api.github.com/users/qiniu/gists{/gist_id}","starred_url":"https://api.github.com/users/qiniu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiniu/subscriptions","organizations_url":"https://api.github.com/users/qiniu/orgs","repos_url":"https://api.github.com/users/qiniu/repos","events_url":"https://api.github.com/users/qiniu/events{/privacy}","received_events_url":"https://api.github.com/users/qiniu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qiniu/logkit","description":"Very powerful server agent for collecting & sending logs & metrics with an easy-to-use web console.","fork":false,"url":"https://api.github.com/repos/qiniu/logkit","forks_url":"https://api.github.com/repos/qiniu/logkit/forks","keys_url":"https://api.github.com/repos/qiniu/logkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qiniu/logkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qiniu/logkit/teams","hooks_url":"https://api.github.com/repos/qiniu/logkit/hooks","issue_events_url":"https://api.github.com/repos/qiniu/logkit/issues/events{/number}","events_url":"https://api.github.com/repos/qiniu/logkit/events","assignees_url":"https://api.github.com/repos/qiniu/logkit/assignees{/user}","branches_url":"https://api.github.com/repos/qiniu/logkit/branches{/branch}","tags_url":"https://api.github.com/repos/qiniu/logkit/tags","blobs_url":"https://api.github.com/repos/qiniu/logkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qiniu/logkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qiniu/logkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/qiniu/logkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qiniu/logkit/statuses/{sha}","languages_url":"https://api.github.com/repos/qiniu/logkit/languages","stargazers_url":"https://api.github.com/repos/qiniu/logkit/stargazers","contributors_url":"https://api.github.com/repos/qiniu/logkit/contributors","subscribers_url":"https://api.github.com/repos/qiniu/logkit/subscribers","subscription_url":"https://api.github.com/repos/qiniu/logkit/subscription","commits_url":"https://api.github.com/repos/qiniu/logkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/qiniu/logkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/qiniu/logkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/qiniu/logkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/qiniu/logkit/contents/{+path}","compare_url":"https://api.github.com/repos/qiniu/logkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qiniu/logkit/merges","archive_url":"https://api.github.com/repos/qiniu/logkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qiniu/logkit/downloads","issues_url":"https://api.github.com/repos/qiniu/logkit/issues{/number}","pulls_url":"https://api.github.com/repos/qiniu/logkit/pulls{/number}","milestones_url":"https://api.github.com/repos/qiniu/logkit/milestones{/number}","notifications_url":"https://api.github.com/repos/qiniu/logkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qiniu/logkit/labels{/name}","releases_url":"https://api.github.com/repos/qiniu/logkit/releases{/id}","deployments_url":"https://api.github.com/repos/qiniu/logkit/deployments","created_at":"2017-05-15T06:50:40Z","updated_at":"2018-08-14T07:02:09Z","pushed_at":"2018-08-14T09:13:50Z","git_url":"git://github.com/qiniu/logkit.git","ssh_url":"git@github.com:qiniu/logkit.git","clone_url":"https://github.com/qiniu/logkit.git","svn_url":"https://github.com/qiniu/logkit","homepage":"https://pandora-docs.qiniu.com","size":20466,"stargazers_count":592,"watchers_count":592,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":128,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":128,"open_issues":8,"watchers":592,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qiniu/logkit/pulls/706"},"html":{"href":"https://github.com/qiniu/logkit/pull/706"},"issue":{"href":"https://api.github.com/repos/qiniu/logkit/issues/706"},"comments":{"href":"https://api.github.com/repos/qiniu/logkit/issues/706/comments"},"review_comments":{"href":"https://api.github.com/repos/qiniu/logkit/pulls/706/comments"},"review_comment":{"href":"https://api.github.com/repos/qiniu/logkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qiniu/logkit/pulls/706/commits"},"statuses":{"href":"https://api.github.com/repos/qiniu/logkit/statuses/97a22d26f7c85dfff4348243569b9a6808bc7115"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Unknwon"}}