{"action":"created","issue":{"url":"https://api.github.com/repos/nornir-automation/nornir/issues/224","repository_url":"https://api.github.com/repos/nornir-automation/nornir","labels_url":"https://api.github.com/repos/nornir-automation/nornir/issues/224/labels{/name}","comments_url":"https://api.github.com/repos/nornir-automation/nornir/issues/224/comments","events_url":"https://api.github.com/repos/nornir-automation/nornir/issues/224/events","html_url":"https://github.com/nornir-automation/nornir/pull/224","id":347735733,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MjYwNjAw","number":224,"title":"[WIP] consolidate inventory attributes","user":{"login":"dbarrosop","id":6246622,"node_id":"MDQ6VXNlcjYyNDY2MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/6246622?v=4","gravatar_id":"","url":"https://api.github.com/users/dbarrosop","html_url":"https://github.com/dbarrosop","followers_url":"https://api.github.com/users/dbarrosop/followers","following_url":"https://api.github.com/users/dbarrosop/following{/other_user}","gists_url":"https://api.github.com/users/dbarrosop/gists{/gist_id}","starred_url":"https://api.github.com/users/dbarrosop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbarrosop/subscriptions","organizations_url":"https://api.github.com/users/dbarrosop/orgs","repos_url":"https://api.github.com/users/dbarrosop/repos","events_url":"https://api.github.com/users/dbarrosop/events{/privacy}","received_events_url":"https://api.github.com/users/dbarrosop/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-08-05T22:14:32Z","updated_at":"2018-08-10T07:35:07Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nornir-automation/nornir/pulls/224","html_url":"https://github.com/nornir-automation/nornir/pull/224","diff_url":"https://github.com/nornir-automation/nornir/pull/224.diff","patch_url":"https://github.com/nornir-automation/nornir/pull/224.patch"},"body":"TODO:\r\n\r\n1. ~Add tests using DummyPlugin to test the logic for overriding parameters~\r\n2. Update docs\r\n3. Add an \"upgrade\" notice."},"comment":{"url":"https://api.github.com/repos/nornir-automation/nornir/issues/comments/412001550","html_url":"https://github.com/nornir-automation/nornir/pull/224#issuecomment-412001550","issue_url":"https://api.github.com/repos/nornir-automation/nornir/issues/224","id":412001550,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjAwMTU1MA==","user":{"login":"dbarrosop","id":6246622,"node_id":"MDQ6VXNlcjYyNDY2MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/6246622?v=4","gravatar_id":"","url":"https://api.github.com/users/dbarrosop","html_url":"https://github.com/dbarrosop","followers_url":"https://api.github.com/users/dbarrosop/followers","following_url":"https://api.github.com/users/dbarrosop/following{/other_user}","gists_url":"https://api.github.com/users/dbarrosop/gists{/gist_id}","starred_url":"https://api.github.com/users/dbarrosop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbarrosop/subscriptions","organizations_url":"https://api.github.com/users/dbarrosop/orgs","repos_url":"https://api.github.com/users/dbarrosop/repos","events_url":"https://api.github.com/users/dbarrosop/events{/privacy}","received_events_url":"https://api.github.com/users/dbarrosop/received_events","type":"User","site_admin":false},"created_at":"2018-08-10T07:35:07Z","updated_at":"2018-08-10T07:35:07Z","author_association":"CONTRIBUTOR","body":"`napalm` implementation is correct although, as you probably noticed, it has logic to extract the `timeout` value and then it maps directly into `optional_args`. I am fine doing instead:\r\n\r\n```\r\nparameters.update(advanced_options)\r\nconnection = network_driver(**parameters)\r\n```\r\n\r\nwhich would be consistent with the behavior described in my previous comment about netmiko."}}
{"actor":{"display_login":"dbarrosop"}}