{"action":"created","comment":{"url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/pulls/comments/182798270","pull_request_review_id":113670699,"id":182798270,"diff_hunk":"@@ -332,26 +334,28 @@ public SearchResultResponse getFacetList(SearchRequest searchRequest) {\n \t\t\tfacetFieldUtil.addToSolrQuery(ancestorPath, solrQuery);\n \t\t}\n \n-\t\t// Sort neighbors using the title sort\n-\t\taddSort(solrQuery, \"title\", true);\n-\n \t\t// Query for a window of results to either side of the target\n \t\tsolrQuery.setRows(windowSize - 1);\n \t\tsolrQuery.setFields(new String[0]);\n \t\t\n \t\t// Clone base query for reuse in getting succeeding neighbors\n-\t\tSolrQuery precedingQuery = solrQuery;\n \t\tSolrQuery succeedingQuery = solrQuery.getCopy();","path":"access-common/src/main/java/edu/unc/lib/dl/ui/service/SolrQueryLayerService.java","position":22,"original_position":22,"commit_id":"2b7db69adb80522fb5d58b3f60bc0687a0a71e26","original_commit_id":"2b7db69adb80522fb5d58b3f60bc0687a0a71e26","user":{"login":"harringj","id":21954788,"avatar_url":"https://avatars2.githubusercontent.com/u/21954788?v=4","gravatar_id":"","url":"https://api.github.com/users/harringj","html_url":"https://github.com/harringj","followers_url":"https://api.github.com/users/harringj/followers","following_url":"https://api.github.com/users/harringj/following{/other_user}","gists_url":"https://api.github.com/users/harringj/gists{/gist_id}","starred_url":"https://api.github.com/users/harringj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harringj/subscriptions","organizations_url":"https://api.github.com/users/harringj/orgs","repos_url":"https://api.github.com/users/harringj/repos","events_url":"https://api.github.com/users/harringj/events{/privacy}","received_events_url":"https://api.github.com/users/harringj/received_events","type":"User","site_admin":false},"body":"why is getCopy() being used here? wouldn't it be possible to set succeedingQuery to solrQuery, just like for precedingQuery?","created_at":"2018-04-19T15:57:33Z","updated_at":"2018-04-19T15:57:33Z","html_url":"https://github.com/UNC-Libraries/Carolina-Digital-Repository/pull/726#discussion_r182798270","pull_request_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/pulls/726","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/pulls/comments/182798270"},"html":{"href":"https://github.com/UNC-Libraries/Carolina-Digital-Repository/pull/726#discussion_r182798270"},"pull_request":{"href":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/pulls/726"}}},"pull_request":{"url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/pulls/726","id":182791703,"html_url":"https://github.com/UNC-Libraries/Carolina-Digital-Repository/pull/726","diff_url":"https://github.com/UNC-Libraries/Carolina-Digital-Repository/pull/726.diff","patch_url":"https://github.com/UNC-Libraries/Carolina-Digital-Repository/pull/726.patch","issue_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/issues/726","number":726,"state":"open","locked":false,"title":"Fix same items always appearing for preceding neighbors","user":{"login":"bbpennel","id":969810,"avatar_url":"https://avatars2.githubusercontent.com/u/969810?v=4","gravatar_id":"","url":"https://api.github.com/users/bbpennel","html_url":"https://github.com/bbpennel","followers_url":"https://api.github.com/users/bbpennel/followers","following_url":"https://api.github.com/users/bbpennel/following{/other_user}","gists_url":"https://api.github.com/users/bbpennel/gists{/gist_id}","starred_url":"https://api.github.com/users/bbpennel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbpennel/subscriptions","organizations_url":"https://api.github.com/users/bbpennel/orgs","repos_url":"https://api.github.com/users/bbpennel/repos","events_url":"https://api.github.com/users/bbpennel/events{/privacy}","received_events_url":"https://api.github.com/users/bbpennel/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-19T14:18:21Z","updated_at":"2018-04-19T15:57:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3014fb2a1ff8f691034ac160aa06be3c6228b863","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/pulls/726/commits","review_comments_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/pulls/726/comments","review_comment_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/issues/726/comments","statuses_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/statuses/2b7db69adb80522fb5d58b3f60bc0687a0a71e26","head":{"label":"UNC-Libraries:neighbor-fix","ref":"neighbor-fix","sha":"2b7db69adb80522fb5d58b3f60bc0687a0a71e26","user":{"login":"UNC-Libraries","id":552066,"avatar_url":"https://avatars0.githubusercontent.com/u/552066?v=4","gravatar_id":"","url":"https://api.github.com/users/UNC-Libraries","html_url":"https://github.com/UNC-Libraries","followers_url":"https://api.github.com/users/UNC-Libraries/followers","following_url":"https://api.github.com/users/UNC-Libraries/following{/other_user}","gists_url":"https://api.github.com/users/UNC-Libraries/gists{/gist_id}","starred_url":"https://api.github.com/users/UNC-Libraries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UNC-Libraries/subscriptions","organizations_url":"https://api.github.com/users/UNC-Libraries/orgs","repos_url":"https://api.github.com/users/UNC-Libraries/repos","events_url":"https://api.github.com/users/UNC-Libraries/events{/privacy}","received_events_url":"https://api.github.com/users/UNC-Libraries/received_events","type":"Organization","site_admin":false},"repo":{"id":2357859,"name":"Carolina-Digital-Repository","full_name":"UNC-Libraries/Carolina-Digital-Repository","owner":{"login":"UNC-Libraries","id":552066,"avatar_url":"https://avatars0.githubusercontent.com/u/552066?v=4","gravatar_id":"","url":"https://api.github.com/users/UNC-Libraries","html_url":"https://github.com/UNC-Libraries","followers_url":"https://api.github.com/users/UNC-Libraries/followers","following_url":"https://api.github.com/users/UNC-Libraries/following{/other_user}","gists_url":"https://api.github.com/users/UNC-Libraries/gists{/gist_id}","starred_url":"https://api.github.com/users/UNC-Libraries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UNC-Libraries/subscriptions","organizations_url":"https://api.github.com/users/UNC-Libraries/orgs","repos_url":"https://api.github.com/users/UNC-Libraries/repos","events_url":"https://api.github.com/users/UNC-Libraries/events{/privacy}","received_events_url":"https://api.github.com/users/UNC-Libraries/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UNC-Libraries/Carolina-Digital-Repository","description":"Carolina Digital Repository","fork":false,"url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository","forks_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/forks","keys_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/teams","hooks_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/hooks","issue_events_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/issues/events{/number}","events_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/events","assignees_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/assignees{/user}","branches_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/branches{/branch}","tags_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/tags","blobs_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/git/refs{/sha}","trees_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/statuses/{sha}","languages_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/languages","stargazers_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/stargazers","contributors_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/contributors","subscribers_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/subscribers","subscription_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/subscription","commits_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/commits{/sha}","git_commits_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/git/commits{/sha}","comments_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/comments{/number}","issue_comment_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/issues/comments{/number}","contents_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/contents/{+path}","compare_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/merges","archive_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/downloads","issues_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/issues{/number}","pulls_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/pulls{/number}","milestones_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/milestones{/number}","notifications_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/labels{/name}","releases_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/releases{/id}","deployments_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/deployments","created_at":"2011-09-09T20:22:21Z","updated_at":"2018-04-12T14:21:50Z","pushed_at":"2018-04-19T14:18:21Z","git_url":"git://github.com/UNC-Libraries/Carolina-Digital-Repository.git","ssh_url":"git@github.com:UNC-Libraries/Carolina-Digital-Repository.git","clone_url":"https://github.com/UNC-Libraries/Carolina-Digital-Repository.git","svn_url":"https://github.com/UNC-Libraries/Carolina-Digital-Repository","homepage":"http://www.lib.unc.edu/blogs/cdr/index.php/about/","size":104540,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":10,"open_issues":2,"watchers":9,"default_branch":"fcrepo4"}},"base":{"label":"UNC-Libraries:master","ref":"master","sha":"0eeb7eb1c0257118b9286dd1d036a4adb08094cc","user":{"login":"UNC-Libraries","id":552066,"avatar_url":"https://avatars0.githubusercontent.com/u/552066?v=4","gravatar_id":"","url":"https://api.github.com/users/UNC-Libraries","html_url":"https://github.com/UNC-Libraries","followers_url":"https://api.github.com/users/UNC-Libraries/followers","following_url":"https://api.github.com/users/UNC-Libraries/following{/other_user}","gists_url":"https://api.github.com/users/UNC-Libraries/gists{/gist_id}","starred_url":"https://api.github.com/users/UNC-Libraries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UNC-Libraries/subscriptions","organizations_url":"https://api.github.com/users/UNC-Libraries/orgs","repos_url":"https://api.github.com/users/UNC-Libraries/repos","events_url":"https://api.github.com/users/UNC-Libraries/events{/privacy}","received_events_url":"https://api.github.com/users/UNC-Libraries/received_events","type":"Organization","site_admin":false},"repo":{"id":2357859,"name":"Carolina-Digital-Repository","full_name":"UNC-Libraries/Carolina-Digital-Repository","owner":{"login":"UNC-Libraries","id":552066,"avatar_url":"https://avatars0.githubusercontent.com/u/552066?v=4","gravatar_id":"","url":"https://api.github.com/users/UNC-Libraries","html_url":"https://github.com/UNC-Libraries","followers_url":"https://api.github.com/users/UNC-Libraries/followers","following_url":"https://api.github.com/users/UNC-Libraries/following{/other_user}","gists_url":"https://api.github.com/users/UNC-Libraries/gists{/gist_id}","starred_url":"https://api.github.com/users/UNC-Libraries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UNC-Libraries/subscriptions","organizations_url":"https://api.github.com/users/UNC-Libraries/orgs","repos_url":"https://api.github.com/users/UNC-Libraries/repos","events_url":"https://api.github.com/users/UNC-Libraries/events{/privacy}","received_events_url":"https://api.github.com/users/UNC-Libraries/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UNC-Libraries/Carolina-Digital-Repository","description":"Carolina Digital Repository","fork":false,"url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository","forks_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/forks","keys_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/teams","hooks_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/hooks","issue_events_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/issues/events{/number}","events_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/events","assignees_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/assignees{/user}","branches_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/branches{/branch}","tags_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/tags","blobs_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/git/refs{/sha}","trees_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/statuses/{sha}","languages_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/languages","stargazers_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/stargazers","contributors_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/contributors","subscribers_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/subscribers","subscription_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/subscription","commits_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/commits{/sha}","git_commits_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/git/commits{/sha}","comments_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/comments{/number}","issue_comment_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/issues/comments{/number}","contents_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/contents/{+path}","compare_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/merges","archive_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/downloads","issues_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/issues{/number}","pulls_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/pulls{/number}","milestones_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/milestones{/number}","notifications_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/labels{/name}","releases_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/releases{/id}","deployments_url":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/deployments","created_at":"2011-09-09T20:22:21Z","updated_at":"2018-04-12T14:21:50Z","pushed_at":"2018-04-19T14:18:21Z","git_url":"git://github.com/UNC-Libraries/Carolina-Digital-Repository.git","ssh_url":"git@github.com:UNC-Libraries/Carolina-Digital-Repository.git","clone_url":"https://github.com/UNC-Libraries/Carolina-Digital-Repository.git","svn_url":"https://github.com/UNC-Libraries/Carolina-Digital-Repository","homepage":"http://www.lib.unc.edu/blogs/cdr/index.php/about/","size":104540,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":10,"open_issues":2,"watchers":9,"default_branch":"fcrepo4"}},"_links":{"self":{"href":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/pulls/726"},"html":{"href":"https://github.com/UNC-Libraries/Carolina-Digital-Repository/pull/726"},"issue":{"href":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/issues/726"},"comments":{"href":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/issues/726/comments"},"review_comments":{"href":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/pulls/726/comments"},"review_comment":{"href":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/pulls/726/commits"},"statuses":{"href":"https://api.github.com/repos/UNC-Libraries/Carolina-Digital-Repository/statuses/2b7db69adb80522fb5d58b3f60bc0687a0a71e26"}},"author_association":"OWNER"}}
{"actor":{"display_login":"harringj"}}