{"action":"created","issue":{"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1460","repository_url":"https://api.github.com/repos/Subsurface-divelog/subsurface","labels_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1460/labels{/name}","comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1460/comments","events_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1460/events","html_url":"https://github.com/Subsurface-divelog/subsurface/pull/1460","id":338367100,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MzE3Njgy","number":1460,"title":"Multiple cylinder edit on mobile","user":{"login":"jbygdell","id":24942439,"node_id":"MDQ6VXNlcjI0OTQyNDM5","avatar_url":"https://avatars2.githubusercontent.com/u/24942439?v=4","gravatar_id":"","url":"https://api.github.com/users/jbygdell","html_url":"https://github.com/jbygdell","followers_url":"https://api.github.com/users/jbygdell/followers","following_url":"https://api.github.com/users/jbygdell/following{/other_user}","gists_url":"https://api.github.com/users/jbygdell/gists{/gist_id}","starred_url":"https://api.github.com/users/jbygdell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbygdell/subscriptions","organizations_url":"https://api.github.com/users/jbygdell/orgs","repos_url":"https://api.github.com/users/jbygdell/repos","events_url":"https://api.github.com/users/jbygdell/events{/privacy}","received_events_url":"https://api.github.com/users/jbygdell/received_events","type":"User","site_admin":false},"labels":[{"id":753474103,"node_id":"MDU6TGFiZWw3NTM0NzQxMDM=","url":"https://api.github.com/repos/Subsurface-divelog/subsurface/labels/dive-cylinder","name":"dive-cylinder","color":"1d76db","default":false},{"id":515043298,"node_id":"MDU6TGFiZWw1MTUwNDMyOTg=","url":"https://api.github.com/repos/Subsurface-divelog/subsurface/labels/enhancements-we-intend-to-add","name":"enhancements-we-intend-to-add","color":"0e8a16","default":false},{"id":752325541,"node_id":"MDU6TGFiZWw3NTIzMjU1NDE=","url":"https://api.github.com/repos/Subsurface-divelog/subsurface/labels/needs-documentation-change","name":"needs-documentation-change","color":"5319e7","default":false},{"id":700898927,"node_id":"MDU6TGFiZWw3MDA4OTg5Mjc=","url":"https://api.github.com/repos/Subsurface-divelog/subsurface/labels/ui-mobile","name":"ui-mobile","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-04T20:06:48Z","updated_at":"2018-07-07T07:47:26Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1460","html_url":"https://github.com/Subsurface-divelog/subsurface/pull/1460","diff_url":"https://github.com/Subsurface-divelog/subsurface/pull/1460.diff","patch_url":"https://github.com/Subsurface-divelog/subsurface/pull/1460.patch"},"body":"<!-- Lines like this one are comments and will not be shown in the final output. -->\r\n<!-- Make sure that you have read the \"Contributing\" section of the README and also the notes in CodingStyle. -->\r\n<!-- If you are a collaborator, please add labels and assign other collaborators for a review. -->\r\n\r\n### Describe the pull request:\r\n<!-- Replace [ ] with [x] to select options. -->\r\n- [ ] Bug fix\r\n- [ ] Functional change\r\n- [X] New feature\r\n- [ ] Code cleanup\r\n- [ ] Build system change\r\n- [ ] Documentation change\r\n- [ ] Language translation\r\n\r\n### Pull request long description:\r\nWe have had multiple requests both here #547 and on the ML to support editing multiple gas mixes and cylinders on the mobile app.\r\nThis PR is a stab at enabling that functionality without cluttering the UI.\r\nThe solution is to allow the user to add multiple cylinders, gases and pressures as comma separated lists in the respective input fields.\r\n\r\n### Changes made:\r\n1) Displays all used cylinders, gases and pressures when viewing info for a dive.\r\n2) Allow the user the user to add multiple entries as comma separated lists.\r\n\r\n### Related issues:\r\nFixes #547\r\n\r\n### Additional information:\r\n<!-- Include sample dive log or other relevant information to allow testing the change where feasible. -->\r\n\r\n### Release note:\r\n- Mobile: enable editing of multiple cylinders in a dive\r\n\r\n### Documentation change:\r\nThe user can add/edit cylinder information for a dive that uses multiple cylinders on the mobile app.\r\n\r\n### Mentions:\r\n<!-- Mention users that you want to review your pull request with @<user-name>. Leave empty if not sure. -->\r\n"},"comment":{"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/comments/403196603","html_url":"https://github.com/Subsurface-divelog/subsurface/pull/1460#issuecomment-403196603","issue_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1460","id":403196603,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzE5NjYwMw==","user":{"login":"jbygdell","id":24942439,"node_id":"MDQ6VXNlcjI0OTQyNDM5","avatar_url":"https://avatars2.githubusercontent.com/u/24942439?v=4","gravatar_id":"","url":"https://api.github.com/users/jbygdell","html_url":"https://github.com/jbygdell","followers_url":"https://api.github.com/users/jbygdell/followers","following_url":"https://api.github.com/users/jbygdell/following{/other_user}","gists_url":"https://api.github.com/users/jbygdell/gists{/gist_id}","starred_url":"https://api.github.com/users/jbygdell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbygdell/subscriptions","organizations_url":"https://api.github.com/users/jbygdell/orgs","repos_url":"https://api.github.com/users/jbygdell/repos","events_url":"https://api.github.com/users/jbygdell/events{/privacy}","received_events_url":"https://api.github.com/users/jbygdell/received_events","type":"User","site_admin":false},"created_at":"2018-07-07T07:47:26Z","updated_at":"2018-07-07T07:47:26Z","author_association":"CONTRIBUTOR","body":"The UX when editing dive data need an overhaul to get this functioning properly.\r\nI just needs to get what I have in my head into fully functioning code."}}
{"actor":{"display_login":"jbygdell"}}