{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/SimpleRestClients/pulls/comments/180267960","pull_request_review_id":110659781,"id":180267960,"diff_hunk":"@@ -95,42 +100,62 @@ export class GenericRestClient {\n     }\n \n     // Override this function to process any generic headers that come down with a successful response\n-    protected _processSuccessResponse<T>(resp: WebResponse<T>): void {\n+    protected _processSuccessResponse<ResponseBody>(resp: WebResponse<ResponseBody, ApiCallOptions>): void {\n         // No-op by default\n     }\n \n-    performApiGet<T>(apiPath: string, options?: ApiCallOptions): SyncTasks.Promise<T> {\n-        return this.performApiGetDetailed<T>(apiPath, options).then(resp => resp.body);\n+    performApiGet<ResponseBody>(apiPath: string, options?: ApiCallOptions): SyncTasks.Promise<ResponseBody> {\n+        return this\n+            .performApiGetDetailed<ResponseBody>(apiPath, options)\n+            .then(resp => resp.body);\n     }\n-    performApiGetDetailed<T>(apiPath: string, options?: ApiCallOptions): SyncTasks.Promise<WebResponse<T>> {\n-        return this._performApiCall<T>(apiPath, 'GET', undefined, options);\n+\n+    performApiGetDetailed<TResponseBody>(apiPath: string, options?: ApiCallOptions)\n+            : SyncTasks.Promise<WebResponse<TResponseBody, ApiCallOptions>> {\n+        return this._performApiCall<TResponseBody>(apiPath, 'GET', undefined, options);\n     }\n \n-    performApiPost<T>(apiPath: string, objToPost: any, options?: ApiCallOptions): SyncTasks.Promise<T> {\n-        return this.performApiPostDetailed<T>(apiPath, objToPost, options).then(resp => resp.body);\n+    performApiPost<ResponseBody>(apiPath: string, objToPost: any, options?: ApiCallOptions): SyncTasks.Promise<ResponseBody> {\n+        return this\n+            .performApiPostDetailed<ResponseBody>(apiPath, objToPost, options)\n+            .then(resp => resp.body);\n     }\n-    performApiPostDetailed<T>(apiPath: string, objToPost: any, options?: ApiCallOptions): SyncTasks.Promise<WebResponse<T>> {\n-        return this._performApiCall<T>(apiPath, 'POST', objToPost, options);\n+\n+    performApiPostDetailed<ResponseBody>(apiPath: string, objToPost: any, options?: ApiCallOptions)\n+            : SyncTasks.Promise<WebResponse<ResponseBody, ApiCallOptions>> {\n+        return this._performApiCall<ResponseBody>(apiPath, 'POST', objToPost, options);\n     }\n \n-    performApiPatch<T>(apiPath: string, objToPatch: any, options?: ApiCallOptions): SyncTasks.Promise<T> {\n-        return this.performApiPatchDetailed<T>(apiPath, objToPatch, options).then(resp => resp.body);\n+    performApiPatch<ResponseBody>(apiPath: string, objToPatch: any, options?: ApiCallOptions): SyncTasks.Promise<ResponseBody> {","path":"src/GenericRestClient.ts","position":150,"original_position":150,"commit_id":"4107182b05fa9d0da80c8af9b5aba4d4a69756ae","original_commit_id":"4107182b05fa9d0da80c8af9b5aba4d4a69756ae","user":{"login":"berickson1","id":1418465,"avatar_url":"https://avatars1.githubusercontent.com/u/1418465?v=4","gravatar_id":"","url":"https://api.github.com/users/berickson1","html_url":"https://github.com/berickson1","followers_url":"https://api.github.com/users/berickson1/followers","following_url":"https://api.github.com/users/berickson1/following{/other_user}","gists_url":"https://api.github.com/users/berickson1/gists{/gist_id}","starred_url":"https://api.github.com/users/berickson1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berickson1/subscriptions","organizations_url":"https://api.github.com/users/berickson1/orgs","repos_url":"https://api.github.com/users/berickson1/repos","events_url":"https://api.github.com/users/berickson1/events{/privacy}","received_events_url":"https://api.github.com/users/berickson1/received_events","type":"User","site_admin":false},"body":"Please leave these all as <T>","created_at":"2018-04-10T00:27:31Z","updated_at":"2018-04-10T00:28:52Z","html_url":"https://github.com/Microsoft/SimpleRestClients/pull/24#discussion_r180267960","pull_request_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/pulls/24","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/SimpleRestClients/pulls/comments/180267960"},"html":{"href":"https://github.com/Microsoft/SimpleRestClients/pull/24#discussion_r180267960"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/SimpleRestClients/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/SimpleRestClients/pulls/24","id":180264206,"html_url":"https://github.com/Microsoft/SimpleRestClients/pull/24","diff_url":"https://github.com/Microsoft/SimpleRestClients/pull/24.diff","patch_url":"https://github.com/Microsoft/SimpleRestClients/pull/24.patch","issue_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/issues/24","number":24,"state":"open","locked":false,"title":"Feature/add default template parameters to web response","user":{"login":"a-tarasyuk","id":509265,"avatar_url":"https://avatars0.githubusercontent.com/u/509265?v=4","gravatar_id":"","url":"https://api.github.com/users/a-tarasyuk","html_url":"https://github.com/a-tarasyuk","followers_url":"https://api.github.com/users/a-tarasyuk/followers","following_url":"https://api.github.com/users/a-tarasyuk/following{/other_user}","gists_url":"https://api.github.com/users/a-tarasyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/a-tarasyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-tarasyuk/subscriptions","organizations_url":"https://api.github.com/users/a-tarasyuk/orgs","repos_url":"https://api.github.com/users/a-tarasyuk/repos","events_url":"https://api.github.com/users/a-tarasyuk/events{/privacy}","received_events_url":"https://api.github.com/users/a-tarasyuk/received_events","type":"User","site_admin":false},"body":"> WebResponse does not know about additional options, which exist in `GenericRestClient`\r\n```\r\nexport interface ApiCallOptions extends WebRequestOptions {\r\n   backendUrl?: string;\r\n   excludeEndpointUrl?: boolean;\r\n   eTag?: string;\r\n}\r\n```\r\n\r\nhttps://codesandbox.io/s/v6jyl7n1m0","created_at":"2018-04-09T10:02:53Z","updated_at":"2018-04-10T00:28:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9fcdde7128f4926c311b71762b159ee5b9cddc5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/pulls/24/commits","review_comments_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/pulls/24/comments","review_comment_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/issues/24/comments","statuses_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/statuses/4107182b05fa9d0da80c8af9b5aba4d4a69756ae","head":{"label":"a-tarasyuk:feature/add-default-template-parameters-to-web-response","ref":"feature/add-default-template-parameters-to-web-response","sha":"4107182b05fa9d0da80c8af9b5aba4d4a69756ae","user":{"login":"a-tarasyuk","id":509265,"avatar_url":"https://avatars0.githubusercontent.com/u/509265?v=4","gravatar_id":"","url":"https://api.github.com/users/a-tarasyuk","html_url":"https://github.com/a-tarasyuk","followers_url":"https://api.github.com/users/a-tarasyuk/followers","following_url":"https://api.github.com/users/a-tarasyuk/following{/other_user}","gists_url":"https://api.github.com/users/a-tarasyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/a-tarasyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-tarasyuk/subscriptions","organizations_url":"https://api.github.com/users/a-tarasyuk/orgs","repos_url":"https://api.github.com/users/a-tarasyuk/repos","events_url":"https://api.github.com/users/a-tarasyuk/events{/privacy}","received_events_url":"https://api.github.com/users/a-tarasyuk/received_events","type":"User","site_admin":false},"repo":{"id":124084214,"name":"SimpleRestClients","full_name":"a-tarasyuk/SimpleRestClients","owner":{"login":"a-tarasyuk","id":509265,"avatar_url":"https://avatars0.githubusercontent.com/u/509265?v=4","gravatar_id":"","url":"https://api.github.com/users/a-tarasyuk","html_url":"https://github.com/a-tarasyuk","followers_url":"https://api.github.com/users/a-tarasyuk/followers","following_url":"https://api.github.com/users/a-tarasyuk/following{/other_user}","gists_url":"https://api.github.com/users/a-tarasyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/a-tarasyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-tarasyuk/subscriptions","organizations_url":"https://api.github.com/users/a-tarasyuk/orgs","repos_url":"https://api.github.com/users/a-tarasyuk/repos","events_url":"https://api.github.com/users/a-tarasyuk/events{/privacy}","received_events_url":"https://api.github.com/users/a-tarasyuk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/a-tarasyuk/SimpleRestClients","description":"A simple set of wrappers for RESTful calls","fork":true,"url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients","forks_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/forks","keys_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/teams","hooks_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/hooks","issue_events_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/issues/events{/number}","events_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/events","assignees_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/assignees{/user}","branches_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/branches{/branch}","tags_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/tags","blobs_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/git/refs{/sha}","trees_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/statuses/{sha}","languages_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/languages","stargazers_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/stargazers","contributors_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/contributors","subscribers_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/subscribers","subscription_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/subscription","commits_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/commits{/sha}","git_commits_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/git/commits{/sha}","comments_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/comments{/number}","issue_comment_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/issues/comments{/number}","contents_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/contents/{+path}","compare_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/merges","archive_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/downloads","issues_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/issues{/number}","pulls_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/pulls{/number}","milestones_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/milestones{/number}","notifications_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/labels{/name}","releases_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/releases{/id}","deployments_url":"https://api.github.com/repos/a-tarasyuk/SimpleRestClients/deployments","created_at":"2018-03-06T13:44:10Z","updated_at":"2018-03-06T13:44:12Z","pushed_at":"2018-04-09T17:06:28Z","git_url":"git://github.com/a-tarasyuk/SimpleRestClients.git","ssh_url":"git@github.com:a-tarasyuk/SimpleRestClients.git","clone_url":"https://github.com/a-tarasyuk/SimpleRestClients.git","svn_url":"https://github.com/a-tarasyuk/SimpleRestClients","homepage":null,"size":141,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"0511a798a163f6e8ff22da01566a055b582f9db5","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":72688215,"name":"SimpleRestClients","full_name":"Microsoft/SimpleRestClients","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/SimpleRestClients","description":"A simple set of wrappers for RESTful calls","fork":false,"url":"https://api.github.com/repos/Microsoft/SimpleRestClients","forks_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/forks","keys_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/teams","hooks_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/events","assignees_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/tags","blobs_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/languages","stargazers_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/subscription","commits_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/merges","archive_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/downloads","issues_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/SimpleRestClients/deployments","created_at":"2016-11-02T22:51:34Z","updated_at":"2018-04-08T16:21:50Z","pushed_at":"2018-04-09T10:02:54Z","git_url":"git://github.com/Microsoft/SimpleRestClients.git","ssh_url":"git@github.com:Microsoft/SimpleRestClients.git","clone_url":"https://github.com/Microsoft/SimpleRestClients.git","svn_url":"https://github.com/Microsoft/SimpleRestClients","homepage":null,"size":99,"stargazers_count":22,"watchers_count":22,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":17,"open_issues":2,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/SimpleRestClients/pulls/24"},"html":{"href":"https://github.com/Microsoft/SimpleRestClients/pull/24"},"issue":{"href":"https://api.github.com/repos/Microsoft/SimpleRestClients/issues/24"},"comments":{"href":"https://api.github.com/repos/Microsoft/SimpleRestClients/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/SimpleRestClients/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/SimpleRestClients/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/SimpleRestClients/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/SimpleRestClients/statuses/4107182b05fa9d0da80c8af9b5aba4d4a69756ae"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"berickson1"}}