{"action":"created","issue":{"url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/issues/1765","repository_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT","labels_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/issues/1765/labels{/name}","comments_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/issues/1765/comments","events_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/issues/1765/events","html_url":"https://github.com/CONNECT-Solution/CONNECT/pull/1765","id":364987843,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MDQ0NDk2","number":1765,"title":"Conn 2261 - Event Logger Refactor / Failure Logging Implementation","user":{"login":"plobre","id":37808646,"node_id":"MDQ6VXNlcjM3ODA4NjQ2","avatar_url":"https://avatars2.githubusercontent.com/u/37808646?v=4","gravatar_id":"","url":"https://api.github.com/users/plobre","html_url":"https://github.com/plobre","followers_url":"https://api.github.com/users/plobre/followers","following_url":"https://api.github.com/users/plobre/following{/other_user}","gists_url":"https://api.github.com/users/plobre/gists{/gist_id}","starred_url":"https://api.github.com/users/plobre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plobre/subscriptions","organizations_url":"https://api.github.com/users/plobre/orgs","repos_url":"https://api.github.com/users/plobre/repos","events_url":"https://api.github.com/users/plobre/events{/privacy}","received_events_url":"https://api.github.com/users/plobre/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-28T18:04:57Z","updated_at":"2018-10-09T14:55:05Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/pulls/1765","html_url":"https://github.com/CONNECT-Solution/CONNECT/pull/1765","diff_url":"https://github.com/CONNECT-Solution/CONNECT/pull/1765.diff","patch_url":"https://github.com/CONNECT-Solution/CONNECT/pull/1765.patch"},"body":"- Refactors Event Logging to catch ErrorEventExceptions and handle them via the EventAspectAdvice proceeding join points. \r\n- Supports new Failure logging feature, which will catch these exceptions thrown and log the exception in the Event database as a MESSAGE_PROCESSING_FAILED event\r\n- Failure logging supports having a return override, which is returned via the EventAspectAdvice, which will override the returned value of the method in the event of a failure, and suppress the exception. The exception will still be logged in the database as a failure, and logged in the stack trace, but will allow the service chain to continue running as normal. This allows the service to handle its own failures and return the appropriate error response SOAP messages to each layer.\r\n- Refactored all services to *stop* swallowing all exceptions and pretending like no error ever occurred. These cases now throw an ErrorEventException, which should be handled by the EventAspectAdvice.\r\n- Updated Regression Suite to take into account the new, more verbose, error codes instead of the generic failure messages which is not beneficial to the user."},"comment":{"url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/issues/comments/428224998","html_url":"https://github.com/CONNECT-Solution/CONNECT/pull/1765#issuecomment-428224998","issue_url":"https://api.github.com/repos/CONNECT-Solution/CONNECT/issues/1765","id":428224998,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODIyNDk5OA==","user":{"login":"connectscagitbot","id":19269192,"node_id":"MDQ6VXNlcjE5MjY5MTky","avatar_url":"https://avatars2.githubusercontent.com/u/19269192?v=4","gravatar_id":"","url":"https://api.github.com/users/connectscagitbot","html_url":"https://github.com/connectscagitbot","followers_url":"https://api.github.com/users/connectscagitbot/followers","following_url":"https://api.github.com/users/connectscagitbot/following{/other_user}","gists_url":"https://api.github.com/users/connectscagitbot/gists{/gist_id}","starred_url":"https://api.github.com/users/connectscagitbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connectscagitbot/subscriptions","organizations_url":"https://api.github.com/users/connectscagitbot/orgs","repos_url":"https://api.github.com/users/connectscagitbot/repos","events_url":"https://api.github.com/users/connectscagitbot/events{/privacy}","received_events_url":"https://api.github.com/users/connectscagitbot/received_events","type":"User","site_admin":false},"created_at":"2018-10-09T14:55:05Z","updated_at":"2018-10-09T14:55:05Z","author_association":"NONE","body":"SonarQube analysis reported 1 issue\n\nNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:\n\n1. ![MAJOR][MAJOR] [EntityDocSubmissionImpl.java#L44](https://github.com/CONNECT-Solution/CONNECT/blob/85b98689944ddb6771f22be18dd5dcb6606faa1b/Product/Production/Gateway/DocumentSubmission_11/src/main/java/gov/hhs/fha/nhinc/docsubmission/_11/entity/EntityDocSubmissionImpl.java#L44): Remove this unused \"LOG\" private field. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](http://192.168.3.101:9000/coding_rules#rule_key=squid%3AS1068)\n\n[MAJOR]: https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR'"}}
{"actor":{"display_login":"connectscagitbot"}}