{"action":"created","issue":{"url":"https://api.github.com/repos/palantir/tslint/issues/4036","repository_url":"https://api.github.com/repos/palantir/tslint","labels_url":"https://api.github.com/repos/palantir/tslint/issues/4036/labels{/name}","comments_url":"https://api.github.com/repos/palantir/tslint/issues/4036/comments","events_url":"https://api.github.com/repos/palantir/tslint/issues/4036/events","html_url":"https://github.com/palantir/tslint/pull/4036","id":341154894,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMzk2NzAy","number":4036,"title":"Add context to shorthand errors.","user":{"login":"johnjbarton","id":205570,"node_id":"MDQ6VXNlcjIwNTU3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/205570?v=4","gravatar_id":"","url":"https://api.github.com/users/johnjbarton","html_url":"https://github.com/johnjbarton","followers_url":"https://api.github.com/users/johnjbarton/followers","following_url":"https://api.github.com/users/johnjbarton/following{/other_user}","gists_url":"https://api.github.com/users/johnjbarton/gists{/gist_id}","starred_url":"https://api.github.com/users/johnjbarton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnjbarton/subscriptions","organizations_url":"https://api.github.com/users/johnjbarton/orgs","repos_url":"https://api.github.com/users/johnjbarton/repos","events_url":"https://api.github.com/users/johnjbarton/events{/privacy}","received_events_url":"https://api.github.com/users/johnjbarton/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-13T20:47:34Z","updated_at":"2018-07-13T22:47:00Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/palantir/tslint/pulls/4036","html_url":"https://github.com/palantir/tslint/pull/4036","diff_url":"https://github.com/palantir/tslint/pull/4036.diff","patch_url":"https://github.com/palantir/tslint/pull/4036.patch"},"body":"The error message \"Expected property shorthand in object literal ('{injector}').\" confused me because\r\nit appeared within an object literal like:\r\n  const x = { <lines of properties with initializers>, injector: injector, <more lines of other properties>}\r\nAs I was unfamiliar with the combination of object literals and short-hand properties,\r\nI took the authoritative voice of the lint message literally and attempted\r\n  const x = { <lines of properties with initializers>, {injector}, <more lines of other properties>}\r\nwhich of course is silly in retrospect, but that was exactly the suggestion of the error message.\r\n\r\nThe new result will be\r\n  Expected property shorthand in object literal ('{..., injector, ...}').\r\nshowing that the braces are context, not something to be added to obey the linter.\r\n\r\nBy adding context indicators around the token, novice users learn from lint that the syntax for shorthand properties is simple.\r\n"},"comment":{"url":"https://api.github.com/repos/palantir/tslint/issues/comments/404972264","html_url":"https://github.com/palantir/tslint/pull/4036#issuecomment-404972264","issue_url":"https://api.github.com/repos/palantir/tslint/issues/4036","id":404972264,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDk3MjI2NA==","user":{"login":"johnjbarton","id":205570,"node_id":"MDQ6VXNlcjIwNTU3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/205570?v=4","gravatar_id":"","url":"https://api.github.com/users/johnjbarton","html_url":"https://github.com/johnjbarton","followers_url":"https://api.github.com/users/johnjbarton/followers","following_url":"https://api.github.com/users/johnjbarton/following{/other_user}","gists_url":"https://api.github.com/users/johnjbarton/gists{/gist_id}","starred_url":"https://api.github.com/users/johnjbarton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnjbarton/subscriptions","organizations_url":"https://api.github.com/users/johnjbarton/orgs","repos_url":"https://api.github.com/users/johnjbarton/repos","events_url":"https://api.github.com/users/johnjbarton/events{/privacy}","received_events_url":"https://api.github.com/users/johnjbarton/received_events","type":"User","site_admin":false},"created_at":"2018-07-13T22:47:00Z","updated_at":"2018-07-13T22:47:00Z","author_association":"NONE","body":"> just visit https://cla.palantir.com/ \r\ngives\r\n```\r\nInternal Server Error\r\n\r\nThe server encountered an unexpected internal server error\r\n\r\n(generated by waitress)\r\n```\r\n\r\n"}}
{"actor":{"display_login":"johnjbarton"}}