{"action":"created","comment":{"url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments/184870982","pull_request_review_id":116154773,"id":184870982,"diff_hunk":"@@ -242,7 +242,7 @@\n \r\n /atom/proc/hitby(atom/movable/AM, skipcatch, hitpush, blocked)\r\n \tif(density && !has_gravity(AM)) //thrown stuff bounces off dense stuff in no grav, unless the thrown stuff ends up inside what it hit(embedding, bola, etc...).\r\n-\t\taddtimer(src, \"hitby_react\", 2, TRUE, AM)\r\n+\t\taddtimer(CALLBACK(src, .proc/hitby_react, AM), 2)\r","path":"code/game/atoms.dm","position":5,"original_position":5,"commit_id":"cfe182a1f76e9ddac6fc0af917b586facc823850","original_commit_id":"cfe182a1f76e9ddac6fc0af917b586facc823850","user":{"login":"Fox-McCloud","id":5785200,"avatar_url":"https://avatars1.githubusercontent.com/u/5785200?v=4","gravatar_id":"","url":"https://api.github.com/users/Fox-McCloud","html_url":"https://github.com/Fox-McCloud","followers_url":"https://api.github.com/users/Fox-McCloud/followers","following_url":"https://api.github.com/users/Fox-McCloud/following{/other_user}","gists_url":"https://api.github.com/users/Fox-McCloud/gists{/gist_id}","starred_url":"https://api.github.com/users/Fox-McCloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fox-McCloud/subscriptions","organizations_url":"https://api.github.com/users/Fox-McCloud/orgs","repos_url":"https://api.github.com/users/Fox-McCloud/repos","events_url":"https://api.github.com/users/Fox-McCloud/events{/privacy}","received_events_url":"https://api.github.com/users/Fox-McCloud/received_events","type":"User","site_admin":false},"body":"This does not have `TIMER_UNIQUE` as TG does not.","created_at":"2018-04-29T04:31:11Z","updated_at":"2018-04-29T04:31:11Z","html_url":"https://github.com/ParadiseSS13/Paradise/pull/8946#discussion_r184870982","pull_request_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/8946","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments/184870982"},"html":{"href":"https://github.com/ParadiseSS13/Paradise/pull/8946#discussion_r184870982"},"pull_request":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/8946"}}},"pull_request":{"url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/8946","id":184811805,"html_url":"https://github.com/ParadiseSS13/Paradise/pull/8946","diff_url":"https://github.com/ParadiseSS13/Paradise/pull/8946.diff","patch_url":"https://github.com/ParadiseSS13/Paradise/pull/8946.patch","issue_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/8946","number":8946,"state":"open","locked":false,"title":"Ports over Timer Subsystem","user":{"login":"Fox-McCloud","id":5785200,"avatar_url":"https://avatars1.githubusercontent.com/u/5785200?v=4","gravatar_id":"","url":"https://api.github.com/users/Fox-McCloud","html_url":"https://github.com/Fox-McCloud","followers_url":"https://api.github.com/users/Fox-McCloud/followers","following_url":"https://api.github.com/users/Fox-McCloud/following{/other_user}","gists_url":"https://api.github.com/users/Fox-McCloud/gists{/gist_id}","starred_url":"https://api.github.com/users/Fox-McCloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fox-McCloud/subscriptions","organizations_url":"https://api.github.com/users/Fox-McCloud/orgs","repos_url":"https://api.github.com/users/Fox-McCloud/repos","events_url":"https://api.github.com/users/Fox-McCloud/events{/privacy}","received_events_url":"https://api.github.com/users/Fox-McCloud/received_events","type":"User","site_admin":false},"body":"Ports over TG's Timer subsystem @MrStonedOne I would appreciate if you could review this to see if there's anything I've missed or if I've used timers improperly at any location. I know it's a lot to ask to review, but the timer SS is a bit beyond me; I get the gist of it, how to use the timers with the callbacks now, and how to pass arguments and such, but the fine inner workings is a bit...yeah.\r\n\r\nAnyway, once this gets merged, ***utilizing `spawn` or `sleep` to act as a timer will be strictly forbidden***, unless you have a good reason to do it; even for things like `spawn(0)`, we'll have `INVOKE_ASYNC`","created_at":"2018-04-29T00:28:52Z","updated_at":"2018-04-29T04:31:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc632741ad47007626761bfc89e1083395092c23","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":227282518,"url":"https://api.github.com/repos/ParadiseSS13/Paradise/labels/Performance","name":"Performance","color":"0052cc","default":false},{"id":176235945,"url":"https://api.github.com/repos/ParadiseSS13/Paradise/labels/Refactor","name":"Refactor","color":"FFB626","default":false}],"milestone":{"url":"https://api.github.com/repos/ParadiseSS13/Paradise/milestones/1","html_url":"https://github.com/ParadiseSS13/Paradise/milestone/1","labels_url":"https://api.github.com/repos/ParadiseSS13/Paradise/milestones/1/labels","id":3205388,"number":1,"title":"Process Scheduler -> StonedMC","description":"","creator":{"login":"tigercat2000","id":10103534,"avatar_url":"https://avatars3.githubusercontent.com/u/10103534?v=4","gravatar_id":"","url":"https://api.github.com/users/tigercat2000","html_url":"https://github.com/tigercat2000","followers_url":"https://api.github.com/users/tigercat2000/followers","following_url":"https://api.github.com/users/tigercat2000/following{/other_user}","gists_url":"https://api.github.com/users/tigercat2000/gists{/gist_id}","starred_url":"https://api.github.com/users/tigercat2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tigercat2000/subscriptions","organizations_url":"https://api.github.com/users/tigercat2000/orgs","repos_url":"https://api.github.com/users/tigercat2000/repos","events_url":"https://api.github.com/users/tigercat2000/events{/privacy}","received_events_url":"https://api.github.com/users/tigercat2000/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":4,"state":"open","created_at":"2018-03-21T05:50:56Z","updated_at":"2018-04-29T00:56:31Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/8946/commits","review_comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/8946/comments","review_comment_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/8946/comments","statuses_url":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/cfe182a1f76e9ddac6fc0af917b586facc823850","head":{"label":"Fox-McCloud:timer-subsystem","ref":"timer-subsystem","sha":"cfe182a1f76e9ddac6fc0af917b586facc823850","user":{"login":"Fox-McCloud","id":5785200,"avatar_url":"https://avatars1.githubusercontent.com/u/5785200?v=4","gravatar_id":"","url":"https://api.github.com/users/Fox-McCloud","html_url":"https://github.com/Fox-McCloud","followers_url":"https://api.github.com/users/Fox-McCloud/followers","following_url":"https://api.github.com/users/Fox-McCloud/following{/other_user}","gists_url":"https://api.github.com/users/Fox-McCloud/gists{/gist_id}","starred_url":"https://api.github.com/users/Fox-McCloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fox-McCloud/subscriptions","organizations_url":"https://api.github.com/users/Fox-McCloud/orgs","repos_url":"https://api.github.com/users/Fox-McCloud/repos","events_url":"https://api.github.com/users/Fox-McCloud/events{/privacy}","received_events_url":"https://api.github.com/users/Fox-McCloud/received_events","type":"User","site_admin":false},"repo":{"id":27287788,"name":"Paradise-1","full_name":"Fox-McCloud/Paradise-1","owner":{"login":"Fox-McCloud","id":5785200,"avatar_url":"https://avatars1.githubusercontent.com/u/5785200?v=4","gravatar_id":"","url":"https://api.github.com/users/Fox-McCloud","html_url":"https://github.com/Fox-McCloud","followers_url":"https://api.github.com/users/Fox-McCloud/followers","following_url":"https://api.github.com/users/Fox-McCloud/following{/other_user}","gists_url":"https://api.github.com/users/Fox-McCloud/gists{/gist_id}","starred_url":"https://api.github.com/users/Fox-McCloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fox-McCloud/subscriptions","organizations_url":"https://api.github.com/users/Fox-McCloud/orgs","repos_url":"https://api.github.com/users/Fox-McCloud/repos","events_url":"https://api.github.com/users/Fox-McCloud/events{/privacy}","received_events_url":"https://api.github.com/users/Fox-McCloud/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Fox-McCloud/Paradise-1","description":null,"fork":true,"url":"https://api.github.com/repos/Fox-McCloud/Paradise-1","forks_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/forks","keys_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/teams","hooks_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/hooks","issue_events_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/issues/events{/number}","events_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/events","assignees_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/assignees{/user}","branches_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/branches{/branch}","tags_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/tags","blobs_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/statuses/{sha}","languages_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/languages","stargazers_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/stargazers","contributors_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/contributors","subscribers_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/subscribers","subscription_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/subscription","commits_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/contents/{+path}","compare_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/merges","archive_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/downloads","issues_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/issues{/number}","pulls_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/pulls{/number}","milestones_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/milestones{/number}","notifications_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/labels{/name}","releases_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/releases{/id}","deployments_url":"https://api.github.com/repos/Fox-McCloud/Paradise-1/deployments","created_at":"2014-11-29T01:29:20Z","updated_at":"2018-04-26T22:01:04Z","pushed_at":"2018-04-29T00:26:13Z","git_url":"git://github.com/Fox-McCloud/Paradise-1.git","ssh_url":"git@github.com:Fox-McCloud/Paradise-1.git","clone_url":"https://github.com/Fox-McCloud/Paradise-1.git","svn_url":"https://github.com/Fox-McCloud/Paradise-1","homepage":null,"size":1029825,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ParadiseSS13:master","ref":"master","sha":"f07033d3806dd4f4fe154764bcd149d56064fdd6","user":{"login":"ParadiseSS13","id":9994901,"avatar_url":"https://avatars2.githubusercontent.com/u/9994901?v=4","gravatar_id":"","url":"https://api.github.com/users/ParadiseSS13","html_url":"https://github.com/ParadiseSS13","followers_url":"https://api.github.com/users/ParadiseSS13/followers","following_url":"https://api.github.com/users/ParadiseSS13/following{/other_user}","gists_url":"https://api.github.com/users/ParadiseSS13/gists{/gist_id}","starred_url":"https://api.github.com/users/ParadiseSS13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParadiseSS13/subscriptions","organizations_url":"https://api.github.com/users/ParadiseSS13/orgs","repos_url":"https://api.github.com/users/ParadiseSS13/repos","events_url":"https://api.github.com/users/ParadiseSS13/events{/privacy}","received_events_url":"https://api.github.com/users/ParadiseSS13/received_events","type":"Organization","site_admin":false},"repo":{"id":27286452,"name":"Paradise","full_name":"ParadiseSS13/Paradise","owner":{"login":"ParadiseSS13","id":9994901,"avatar_url":"https://avatars2.githubusercontent.com/u/9994901?v=4","gravatar_id":"","url":"https://api.github.com/users/ParadiseSS13","html_url":"https://github.com/ParadiseSS13","followers_url":"https://api.github.com/users/ParadiseSS13/followers","following_url":"https://api.github.com/users/ParadiseSS13/following{/other_user}","gists_url":"https://api.github.com/users/ParadiseSS13/gists{/gist_id}","starred_url":"https://api.github.com/users/ParadiseSS13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParadiseSS13/subscriptions","organizations_url":"https://api.github.com/users/ParadiseSS13/orgs","repos_url":"https://api.github.com/users/ParadiseSS13/repos","events_url":"https://api.github.com/users/ParadiseSS13/events{/privacy}","received_events_url":"https://api.github.com/users/ParadiseSS13/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ParadiseSS13/Paradise","description":"Paradise Station's GitHub main repository.","fork":false,"url":"https://api.github.com/repos/ParadiseSS13/Paradise","forks_url":"https://api.github.com/repos/ParadiseSS13/Paradise/forks","keys_url":"https://api.github.com/repos/ParadiseSS13/Paradise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ParadiseSS13/Paradise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ParadiseSS13/Paradise/teams","hooks_url":"https://api.github.com/repos/ParadiseSS13/Paradise/hooks","issue_events_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/events{/number}","events_url":"https://api.github.com/repos/ParadiseSS13/Paradise/events","assignees_url":"https://api.github.com/repos/ParadiseSS13/Paradise/assignees{/user}","branches_url":"https://api.github.com/repos/ParadiseSS13/Paradise/branches{/branch}","tags_url":"https://api.github.com/repos/ParadiseSS13/Paradise/tags","blobs_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/refs{/sha}","trees_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/{sha}","languages_url":"https://api.github.com/repos/ParadiseSS13/Paradise/languages","stargazers_url":"https://api.github.com/repos/ParadiseSS13/Paradise/stargazers","contributors_url":"https://api.github.com/repos/ParadiseSS13/Paradise/contributors","subscribers_url":"https://api.github.com/repos/ParadiseSS13/Paradise/subscribers","subscription_url":"https://api.github.com/repos/ParadiseSS13/Paradise/subscription","commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/commits{/sha}","git_commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/commits{/sha}","comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/comments{/number}","issue_comment_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/comments{/number}","contents_url":"https://api.github.com/repos/ParadiseSS13/Paradise/contents/{+path}","compare_url":"https://api.github.com/repos/ParadiseSS13/Paradise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ParadiseSS13/Paradise/merges","archive_url":"https://api.github.com/repos/ParadiseSS13/Paradise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ParadiseSS13/Paradise/downloads","issues_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues{/number}","pulls_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls{/number}","milestones_url":"https://api.github.com/repos/ParadiseSS13/Paradise/milestones{/number}","notifications_url":"https://api.github.com/repos/ParadiseSS13/Paradise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ParadiseSS13/Paradise/labels{/name}","releases_url":"https://api.github.com/repos/ParadiseSS13/Paradise/releases{/id}","deployments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/deployments","created_at":"2014-11-29T00:16:54Z","updated_at":"2018-04-28T07:07:23Z","pushed_at":"2018-04-29T01:04:49Z","git_url":"git://github.com/ParadiseSS13/Paradise.git","ssh_url":"git@github.com:ParadiseSS13/Paradise.git","clone_url":"https://github.com/ParadiseSS13/Paradise.git","svn_url":"https://github.com/ParadiseSS13/Paradise","homepage":"https://nanotrasen.se/forum/","size":1028040,"stargazers_count":118,"watchers_count":118,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":402,"mirror_url":null,"archived":false,"open_issues_count":630,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":402,"open_issues":630,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/8946"},"html":{"href":"https://github.com/ParadiseSS13/Paradise/pull/8946"},"issue":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/8946"},"comments":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/8946/comments"},"review_comments":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/8946/comments"},"review_comment":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/8946/commits"},"statuses":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/cfe182a1f76e9ddac6fc0af917b586facc823850"}},"author_association":"OWNER"}}
{"actor":{"display_login":"Fox-McCloud"}}