{"action":"created","issue":{"url":"https://api.github.com/repos/codice/ddf/issues/3052","repository_url":"https://api.github.com/repos/codice/ddf","labels_url":"https://api.github.com/repos/codice/ddf/issues/3052/labels{/name}","comments_url":"https://api.github.com/repos/codice/ddf/issues/3052/comments","events_url":"https://api.github.com/repos/codice/ddf/issues/3052/events","html_url":"https://github.com/codice/ddf/pull/3052","id":304556414,"number":3052,"title":"DDF-3664 Replacing Google Font in bootswatch themes with hosted fonts","user":{"login":"BernardIgiri","id":9195522,"avatar_url":"https://avatars3.githubusercontent.com/u/9195522?v=4","gravatar_id":"","url":"https://api.github.com/users/BernardIgiri","html_url":"https://github.com/BernardIgiri","followers_url":"https://api.github.com/users/BernardIgiri/followers","following_url":"https://api.github.com/users/BernardIgiri/following{/other_user}","gists_url":"https://api.github.com/users/BernardIgiri/gists{/gist_id}","starred_url":"https://api.github.com/users/BernardIgiri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BernardIgiri/subscriptions","organizations_url":"https://api.github.com/users/BernardIgiri/orgs","repos_url":"https://api.github.com/users/BernardIgiri/repos","events_url":"https://api.github.com/users/BernardIgiri/events{/privacy}","received_events_url":"https://api.github.com/users/BernardIgiri/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-12T22:01:13Z","updated_at":"2018-03-13T14:38:35Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/3052","html_url":"https://github.com/codice/ddf/pull/3052","diff_url":"https://github.com/codice/ddf/pull/3052.diff","patch_url":"https://github.com/codice/ddf/pull/3052.patch"},"body":"#### What does this PR do?\r\nCreates a ddf-theme module that overrides the external font url to replace that with hosted font css and font files. The ddf-theme module uses SASS to generate the CSS for the bootswatch themes using the SCSS files from bootswatch and bootstrap-sass, as well as CSS taken from the Google fonts, and the Google font files.\r\n#### Who is reviewing it? \r\n@ahoffer @GabrielFabian \r\n#### Select relevant component teams: \r\n@codice/ui\r\n#### Choose 2 committers to review/merge the PR. \r\n@bdeining\r\n@jlcsmith \r\n#### How should this be tested?\r\n\r\nTo test this you should install DDF in experimental/development mode.\r\n\r\nAll of the following URL's should render correct css:\r\nhttps://localhost:8993/admin/metrics\r\nhttps://localhost:8993/admin/certificate\r\nhttps://localhost:8993/admin\r\nhttps://localhost:8993/admin/sources\r\nhttps://localhost:8993/admin/geowebcache\r\nhttps://localhost:8993/error\r\nhttps://localhost:8993/admin/registry/local\r\nhttps://localhost:8993/admin/registry/remote\r\nhttps://localhost:8993/admin/queries\r\nhttps://localhost:8993/admin/data-usage\r\nhttps://localhost:8993/login\r\nhttps://localhost:8993/idp\r\nhttps://localhost:8993/logout\r\nhttps://localhost:8993/admin/spatial-config\r\nhttps://localhost:8993/search/standard\r\n\r\nAdditionally all of the following css files should be accessible:\r\nhttps://localhost:8993/admin/certificate/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/admin/certificate/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/admin/certificate/css/ddf-theme-flatly.css\r\nhttps://localhost:8993/admin/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/admin/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/admin/css/ddf-theme-flatly.css\r\nhttps://localhost:8993/admin/data-usage/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/admin/data-usage/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/admin/data-usage/css/ddf-theme-flatly.css\r\nhttps://localhost:8993/admin/geowebcache/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/admin/geowebcache/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/admin/geowebcache/css/ddf-theme-flatly.css\r\nhttps://localhost:8993/admin/metrics/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/admin/metrics/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/admin/metrics/css/ddf-theme-flatly.css\r\nhttps://localhost:8993/admin/queries/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/admin/queries/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/admin/queries/css/ddf-theme-flatly.css\r\nhttps://localhost:8993/admin/registry/local/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/admin/registry/local/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/admin/registry/local/css/ddf-theme-flatly.css\r\nhttps://localhost:8993/admin/registry/remote/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/admin/registry/remote/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/admin/registry/remote/css/ddf-theme-flatly.css\r\nhttps://localhost:8993/admin/sources/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/admin/sources/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/admin/sources/css/ddf-theme-flatly.css\r\nhttps://localhost:8993/admin/spatial-config/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/admin/spatial-config/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/admin/spatial-config/css/ddf-theme-flatly.css\r\nhttps://localhost:8993/error/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/error/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/error/css/ddf-theme-flatly.css\r\nhttps://localhost:8993/idp/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/idp/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/idp/css/ddf-theme-flatly.css\r\nhttps://localhost:8993/login/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/login/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/login/css/ddf-theme-flatly.css\r\nhttps://localhost:8993/logout/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/logout/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/logout/css/ddf-theme-flatly.css\r\nhttps://localhost:8993/search/standard/css/ddf-theme-cosmo.css\r\nhttps://localhost:8993/search/standard/css/ddf-theme-cyborg.css\r\nhttps://localhost:8993/search/standard/css/ddf-theme-flatly.css\r\n\r\n#### Any background context you want to provide?\r\n\r\nChanges in the ddf-theme module should affect the CSS for every part of the app that was using bootswatch themes before. This means upgrading the bootswatch theme should also be easier.\r\n\r\n#### What are the relevant tickets?\r\n[](https://codice.atlassian.net/browse/)\r\n#### Screenshots (if appropriate)\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [ ] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n"},"comment":{"url":"https://api.github.com/repos/codice/ddf/issues/comments/372687945","html_url":"https://github.com/codice/ddf/pull/3052#issuecomment-372687945","issue_url":"https://api.github.com/repos/codice/ddf/issues/3052","id":372687945,"user":{"login":"BernardIgiri","id":9195522,"avatar_url":"https://avatars3.githubusercontent.com/u/9195522?v=4","gravatar_id":"","url":"https://api.github.com/users/BernardIgiri","html_url":"https://github.com/BernardIgiri","followers_url":"https://api.github.com/users/BernardIgiri/followers","following_url":"https://api.github.com/users/BernardIgiri/following{/other_user}","gists_url":"https://api.github.com/users/BernardIgiri/gists{/gist_id}","starred_url":"https://api.github.com/users/BernardIgiri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BernardIgiri/subscriptions","organizations_url":"https://api.github.com/users/BernardIgiri/orgs","repos_url":"https://api.github.com/users/BernardIgiri/repos","events_url":"https://api.github.com/users/BernardIgiri/events{/privacy}","received_events_url":"https://api.github.com/users/BernardIgiri/received_events","type":"User","site_admin":false},"created_at":"2018-03-13T14:38:35Z","updated_at":"2018-03-13T14:38:35Z","author_association":"CONTRIBUTOR","body":"@bdeining I made the changes you suggested and pushed them."}}
{"actor":{"display_login":"BernardIgiri"}}