{"action":"created","comment":{"url":"https://api.github.com/repos/reactorlabs/rir/pulls/comments/210240201","pull_request_review_id":146411320,"id":210240201,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDI0MDIwMQ==","diff_hunk":"@@ -11,17 +13,22 @@ class Rir2PirCompiler : public RirCompiler {\n   public:\n     Rir2PirCompiler(Module* module, const DebugOptions& debug);\n \n-    void compileClosure(SEXP, MaybeCls success, Maybe fail) override;\n+    void compileClosure(SEXP, MaybeCls success, Maybe fail,\n+                        bool isIndependent) override;\n     void compileFunction(rir::Function*, FormalArgs const&, MaybeCls success,\n                          Maybe fail);\n     void optimizeModule();\n     void printAfterPass(const std::string&, const std::string&, Closure*,\n                         size_t);\n \n+    StreamLogger& getLog() { return log; }","path":"rir/src/compiler/translations/rir_2_pir/rir_2_pir_compiler.h","position":23,"original_position":23,"commit_id":"fb385f85c76a19a33c8fcc26456ade0458246bc9","original_commit_id":"fb385f85c76a19a33c8fcc26456ade0458246bc9","user":{"login":"o-","id":710933,"node_id":"MDQ6VXNlcjcxMDkzMw==","avatar_url":"https://avatars0.githubusercontent.com/u/710933?v=4","gravatar_id":"","url":"https://api.github.com/users/o-","html_url":"https://github.com/o-","followers_url":"https://api.github.com/users/o-/followers","following_url":"https://api.github.com/users/o-/following{/other_user}","gists_url":"https://api.github.com/users/o-/gists{/gist_id}","starred_url":"https://api.github.com/users/o-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/o-/subscriptions","organizations_url":"https://api.github.com/users/o-/orgs","repos_url":"https://api.github.com/users/o-/repos","events_url":"https://api.github.com/users/o-/events{/privacy}","received_events_url":"https://api.github.com/users/o-/received_events","type":"User","site_admin":false},"body":"I agree that the consts can sometimes be a bit like cancer, you need to put them everywhere. So I think it is fine to have the StreamLogger be mutuable by any class that can touch it, that seems fine. But I think the issue here is, why is `getLog()` public? it seems to me that the logger should only be used internally and there is no need for a *client* of the rir_2_pir_compiler to access the logger.","created_at":"2018-08-15T11:28:13Z","updated_at":"2018-08-15T11:28:13Z","html_url":"https://github.com/reactorlabs/rir/pull/188#discussion_r210240201","pull_request_url":"https://api.github.com/repos/reactorlabs/rir/pulls/188","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/reactorlabs/rir/pulls/comments/210240201"},"html":{"href":"https://github.com/reactorlabs/rir/pull/188#discussion_r210240201"},"pull_request":{"href":"https://api.github.com/repos/reactorlabs/rir/pulls/188"}},"in_reply_to_id":210077522},"pull_request":{"url":"https://api.github.com/repos/reactorlabs/rir/pulls/188","id":208261172,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MjYxMTcy","html_url":"https://github.com/reactorlabs/rir/pull/188","diff_url":"https://github.com/reactorlabs/rir/pull/188.diff","patch_url":"https://github.com/reactorlabs/rir/pull/188.patch","issue_url":"https://api.github.com/repos/reactorlabs/rir/issues/188","number":188,"state":"open","locked":false,"title":"Add a Logger in charge of managing the logging of the different (inne…","user":{"login":"charig","id":942105,"node_id":"MDQ6VXNlcjk0MjEwNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/942105?v=4","gravatar_id":"","url":"https://api.github.com/users/charig","html_url":"https://github.com/charig","followers_url":"https://api.github.com/users/charig/followers","following_url":"https://api.github.com/users/charig/following{/other_user}","gists_url":"https://api.github.com/users/charig/gists{/gist_id}","starred_url":"https://api.github.com/users/charig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charig/subscriptions","organizations_url":"https://api.github.com/users/charig/orgs","repos_url":"https://api.github.com/users/charig/repos","events_url":"https://api.github.com/users/charig/events{/privacy}","received_events_url":"https://api.github.com/users/charig/received_events","type":"User","site_admin":false},"body":"…r) functions in different streams","created_at":"2018-08-14T12:15:05Z","updated_at":"2018-08-15T11:28:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c24e1873737a5307d05171eef7bcbda363b9cc8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/reactorlabs/rir/pulls/188/commits","review_comments_url":"https://api.github.com/repos/reactorlabs/rir/pulls/188/comments","review_comment_url":"https://api.github.com/repos/reactorlabs/rir/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactorlabs/rir/issues/188/comments","statuses_url":"https://api.github.com/repos/reactorlabs/rir/statuses/fb385f85c76a19a33c8fcc26456ade0458246bc9","head":{"label":"charig:PrintDebugOnStreams","ref":"PrintDebugOnStreams","sha":"fb385f85c76a19a33c8fcc26456ade0458246bc9","user":{"login":"charig","id":942105,"node_id":"MDQ6VXNlcjk0MjEwNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/942105?v=4","gravatar_id":"","url":"https://api.github.com/users/charig","html_url":"https://github.com/charig","followers_url":"https://api.github.com/users/charig/followers","following_url":"https://api.github.com/users/charig/following{/other_user}","gists_url":"https://api.github.com/users/charig/gists{/gist_id}","starred_url":"https://api.github.com/users/charig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charig/subscriptions","organizations_url":"https://api.github.com/users/charig/orgs","repos_url":"https://api.github.com/users/charig/repos","events_url":"https://api.github.com/users/charig/events{/privacy}","received_events_url":"https://api.github.com/users/charig/received_events","type":"User","site_admin":false},"repo":{"id":123274428,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMyNzQ0Mjg=","name":"rir","full_name":"charig/rir","owner":{"login":"charig","id":942105,"node_id":"MDQ6VXNlcjk0MjEwNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/942105?v=4","gravatar_id":"","url":"https://api.github.com/users/charig","html_url":"https://github.com/charig","followers_url":"https://api.github.com/users/charig/followers","following_url":"https://api.github.com/users/charig/following{/other_user}","gists_url":"https://api.github.com/users/charig/gists{/gist_id}","starred_url":"https://api.github.com/users/charig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charig/subscriptions","organizations_url":"https://api.github.com/users/charig/orgs","repos_url":"https://api.github.com/users/charig/repos","events_url":"https://api.github.com/users/charig/events{/privacy}","received_events_url":"https://api.github.com/users/charig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/charig/rir","description":null,"fork":true,"url":"https://api.github.com/repos/charig/rir","forks_url":"https://api.github.com/repos/charig/rir/forks","keys_url":"https://api.github.com/repos/charig/rir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/charig/rir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/charig/rir/teams","hooks_url":"https://api.github.com/repos/charig/rir/hooks","issue_events_url":"https://api.github.com/repos/charig/rir/issues/events{/number}","events_url":"https://api.github.com/repos/charig/rir/events","assignees_url":"https://api.github.com/repos/charig/rir/assignees{/user}","branches_url":"https://api.github.com/repos/charig/rir/branches{/branch}","tags_url":"https://api.github.com/repos/charig/rir/tags","blobs_url":"https://api.github.com/repos/charig/rir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/charig/rir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/charig/rir/git/refs{/sha}","trees_url":"https://api.github.com/repos/charig/rir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/charig/rir/statuses/{sha}","languages_url":"https://api.github.com/repos/charig/rir/languages","stargazers_url":"https://api.github.com/repos/charig/rir/stargazers","contributors_url":"https://api.github.com/repos/charig/rir/contributors","subscribers_url":"https://api.github.com/repos/charig/rir/subscribers","subscription_url":"https://api.github.com/repos/charig/rir/subscription","commits_url":"https://api.github.com/repos/charig/rir/commits{/sha}","git_commits_url":"https://api.github.com/repos/charig/rir/git/commits{/sha}","comments_url":"https://api.github.com/repos/charig/rir/comments{/number}","issue_comment_url":"https://api.github.com/repos/charig/rir/issues/comments{/number}","contents_url":"https://api.github.com/repos/charig/rir/contents/{+path}","compare_url":"https://api.github.com/repos/charig/rir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/charig/rir/merges","archive_url":"https://api.github.com/repos/charig/rir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/charig/rir/downloads","issues_url":"https://api.github.com/repos/charig/rir/issues{/number}","pulls_url":"https://api.github.com/repos/charig/rir/pulls{/number}","milestones_url":"https://api.github.com/repos/charig/rir/milestones{/number}","notifications_url":"https://api.github.com/repos/charig/rir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/charig/rir/labels{/name}","releases_url":"https://api.github.com/repos/charig/rir/releases{/id}","deployments_url":"https://api.github.com/repos/charig/rir/deployments","created_at":"2018-02-28T11:17:17Z","updated_at":"2018-08-09T08:09:20Z","pushed_at":"2018-08-14T17:03:49Z","git_url":"git://github.com/charig/rir.git","ssh_url":"git@github.com:charig/rir.git","clone_url":"https://github.com/charig/rir.git","svn_url":"https://github.com/charig/rir","homepage":null,"size":4698,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reactorlabs:master","ref":"master","sha":"3774b67e291e47d39e0c79f4f912d0a9b36a409d","user":{"login":"reactorlabs","id":16352773,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MzUyNzcz","avatar_url":"https://avatars3.githubusercontent.com/u/16352773?v=4","gravatar_id":"","url":"https://api.github.com/users/reactorlabs","html_url":"https://github.com/reactorlabs","followers_url":"https://api.github.com/users/reactorlabs/followers","following_url":"https://api.github.com/users/reactorlabs/following{/other_user}","gists_url":"https://api.github.com/users/reactorlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/reactorlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactorlabs/subscriptions","organizations_url":"https://api.github.com/users/reactorlabs/orgs","repos_url":"https://api.github.com/users/reactorlabs/repos","events_url":"https://api.github.com/users/reactorlabs/events{/privacy}","received_events_url":"https://api.github.com/users/reactorlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":63323368,"node_id":"MDEwOlJlcG9zaXRvcnk2MzMyMzM2OA==","name":"rir","full_name":"reactorlabs/rir","owner":{"login":"reactorlabs","id":16352773,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MzUyNzcz","avatar_url":"https://avatars3.githubusercontent.com/u/16352773?v=4","gravatar_id":"","url":"https://api.github.com/users/reactorlabs","html_url":"https://github.com/reactorlabs","followers_url":"https://api.github.com/users/reactorlabs/followers","following_url":"https://api.github.com/users/reactorlabs/following{/other_user}","gists_url":"https://api.github.com/users/reactorlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/reactorlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactorlabs/subscriptions","organizations_url":"https://api.github.com/users/reactorlabs/orgs","repos_url":"https://api.github.com/users/reactorlabs/repos","events_url":"https://api.github.com/users/reactorlabs/events{/privacy}","received_events_url":"https://api.github.com/users/reactorlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reactorlabs/rir","description":null,"fork":false,"url":"https://api.github.com/repos/reactorlabs/rir","forks_url":"https://api.github.com/repos/reactorlabs/rir/forks","keys_url":"https://api.github.com/repos/reactorlabs/rir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactorlabs/rir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactorlabs/rir/teams","hooks_url":"https://api.github.com/repos/reactorlabs/rir/hooks","issue_events_url":"https://api.github.com/repos/reactorlabs/rir/issues/events{/number}","events_url":"https://api.github.com/repos/reactorlabs/rir/events","assignees_url":"https://api.github.com/repos/reactorlabs/rir/assignees{/user}","branches_url":"https://api.github.com/repos/reactorlabs/rir/branches{/branch}","tags_url":"https://api.github.com/repos/reactorlabs/rir/tags","blobs_url":"https://api.github.com/repos/reactorlabs/rir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactorlabs/rir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactorlabs/rir/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactorlabs/rir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactorlabs/rir/statuses/{sha}","languages_url":"https://api.github.com/repos/reactorlabs/rir/languages","stargazers_url":"https://api.github.com/repos/reactorlabs/rir/stargazers","contributors_url":"https://api.github.com/repos/reactorlabs/rir/contributors","subscribers_url":"https://api.github.com/repos/reactorlabs/rir/subscribers","subscription_url":"https://api.github.com/repos/reactorlabs/rir/subscription","commits_url":"https://api.github.com/repos/reactorlabs/rir/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactorlabs/rir/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactorlabs/rir/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactorlabs/rir/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactorlabs/rir/contents/{+path}","compare_url":"https://api.github.com/repos/reactorlabs/rir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactorlabs/rir/merges","archive_url":"https://api.github.com/repos/reactorlabs/rir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactorlabs/rir/downloads","issues_url":"https://api.github.com/repos/reactorlabs/rir/issues{/number}","pulls_url":"https://api.github.com/repos/reactorlabs/rir/pulls{/number}","milestones_url":"https://api.github.com/repos/reactorlabs/rir/milestones{/number}","notifications_url":"https://api.github.com/repos/reactorlabs/rir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactorlabs/rir/labels{/name}","releases_url":"https://api.github.com/repos/reactorlabs/rir/releases{/id}","deployments_url":"https://api.github.com/repos/reactorlabs/rir/deployments","created_at":"2016-07-14T09:40:07Z","updated_at":"2018-08-15T07:39:02Z","pushed_at":"2018-08-15T11:07:58Z","git_url":"git://github.com/reactorlabs/rir.git","ssh_url":"git@github.com:reactorlabs/rir.git","clone_url":"https://github.com/reactorlabs/rir.git","svn_url":"https://github.com/reactorlabs/rir","homepage":null,"size":4636,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":20,"license":null,"forks":7,"open_issues":20,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactorlabs/rir/pulls/188"},"html":{"href":"https://github.com/reactorlabs/rir/pull/188"},"issue":{"href":"https://api.github.com/repos/reactorlabs/rir/issues/188"},"comments":{"href":"https://api.github.com/repos/reactorlabs/rir/issues/188/comments"},"review_comments":{"href":"https://api.github.com/repos/reactorlabs/rir/pulls/188/comments"},"review_comment":{"href":"https://api.github.com/repos/reactorlabs/rir/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactorlabs/rir/pulls/188/commits"},"statuses":{"href":"https://api.github.com/repos/reactorlabs/rir/statuses/fb385f85c76a19a33c8fcc26456ade0458246bc9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"o-"}}