{"action":"created","issue":{"url":"https://api.github.com/repos/zeromq/czmq/issues/1893","repository_url":"https://api.github.com/repos/zeromq/czmq","labels_url":"https://api.github.com/repos/zeromq/czmq/issues/1893/labels{/name}","comments_url":"https://api.github.com/repos/zeromq/czmq/issues/1893/comments","events_url":"https://api.github.com/repos/zeromq/czmq/issues/1893/events","html_url":"https://github.com/zeromq/czmq/pull/1893","id":313741827,"number":1893,"title":"Problem: zdir_new() is not careful with its inputs","user":{"login":"jimklimov","id":1636756,"avatar_url":"https://avatars3.githubusercontent.com/u/1636756?v=4","gravatar_id":"","url":"https://api.github.com/users/jimklimov","html_url":"https://github.com/jimklimov","followers_url":"https://api.github.com/users/jimklimov/followers","following_url":"https://api.github.com/users/jimklimov/following{/other_user}","gists_url":"https://api.github.com/users/jimklimov/gists{/gist_id}","starred_url":"https://api.github.com/users/jimklimov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimklimov/subscriptions","organizations_url":"https://api.github.com/users/jimklimov/orgs","repos_url":"https://api.github.com/users/jimklimov/repos","events_url":"https://api.github.com/users/jimklimov/events{/privacy}","received_events_url":"https://api.github.com/users/jimklimov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-12T14:04:12Z","updated_at":"2018-04-12T14:54:21Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/zeromq/czmq/pulls/1893","html_url":"https://github.com/zeromq/czmq/pull/1893","diff_url":"https://github.com/zeromq/czmq/pull/1893.diff","patch_url":"https://github.com/zeromq/czmq/pull/1893.patch"},"body":"Solutions:\r\n* check for NULL arguments before using them\r\n* check for empty `path` when it is the full path (parent is `-`)\r\n** note: empty path and empty parent implicitly means rootfs here; should it?.. actually empty parent seems not checked at all\r\n** note: empty path and non-empty parent resolves into parent, this looks right\r\n* do not cut the trailing slash of the root dir (`path == /`)\r\n* cut multiple trailing slashes, not just one"},"comment":{"url":"https://api.github.com/repos/zeromq/czmq/issues/comments/380834420","html_url":"https://github.com/zeromq/czmq/pull/1893#issuecomment-380834420","issue_url":"https://api.github.com/repos/zeromq/czmq/issues/1893","id":380834420,"user":{"login":"jimklimov","id":1636756,"avatar_url":"https://avatars3.githubusercontent.com/u/1636756?v=4","gravatar_id":"","url":"https://api.github.com/users/jimklimov","html_url":"https://github.com/jimklimov","followers_url":"https://api.github.com/users/jimklimov/followers","following_url":"https://api.github.com/users/jimklimov/following{/other_user}","gists_url":"https://api.github.com/users/jimklimov/gists{/gist_id}","starred_url":"https://api.github.com/users/jimklimov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimklimov/subscriptions","organizations_url":"https://api.github.com/users/jimklimov/orgs","repos_url":"https://api.github.com/users/jimklimov/repos","events_url":"https://api.github.com/users/jimklimov/events{/privacy}","received_events_url":"https://api.github.com/users/jimklimov/received_events","type":"User","site_admin":false},"created_at":"2018-04-12T14:54:21Z","updated_at":"2018-04-12T14:54:21Z","author_association":"MEMBER","body":"Yes, splitting the PR. Seems there are human decisions to be made about validity of empty/NULL inputs."}}
{"actor":{"display_login":"jimklimov"}}