{"action":"created","comment":{"url":"https://api.github.com/repos/thesofproject/sof/pulls/comments/214690560","pull_request_review_id":151798898,"id":214690560,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDY5MDU2MA==","diff_hunk":"@@ -0,0 +1,54 @@\n+/*\n+ * Copyright (c) 2018, Intel Corporation\n+ * All rights reserved.\n+ *\n+ * Redistribution and use in source and binary forms, with or without\n+ * modification, are permitted provided that the following conditions are met:\n+ *   * Redistributions of source code must retain the above copyright\n+ *     notice, this list of conditions and the following disclaimer.\n+ *   * Redistributions in binary form must reproduce the above copyright\n+ *     notice, this list of conditions and the following disclaimer in the\n+ *     documentation and/or other materials provided with the distribution.\n+ *   * Neither the name of the Intel Corporation nor the\n+ *     names of its contributors may be used to endorse or promote products\n+ *     derived from this software without specific prior written permission.\n+ *\n+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\"\n+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE\n+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE\n+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE\n+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR\n+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF\n+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS\n+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN\n+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)\n+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE\n+ * POSSIBILITY OF SUCH DAMAGE.\n+ *\n+ * Author: Liam Girdwood <liam.r.girdwood@linux.intel.com>","path":"src/platform/icelake/base_module.c","position":28,"original_position":28,"commit_id":"252d7fec4c027865ed22f06782d9a0c4a9ee3e6e","original_commit_id":"c0f156b2bac54c03d176b945f3a2be2c007ce196","user":{"login":"lgirdwood","id":12020523,"node_id":"MDQ6VXNlcjEyMDIwNTIz","avatar_url":"https://avatars0.githubusercontent.com/u/12020523?v=4","gravatar_id":"","url":"https://api.github.com/users/lgirdwood","html_url":"https://github.com/lgirdwood","followers_url":"https://api.github.com/users/lgirdwood/followers","following_url":"https://api.github.com/users/lgirdwood/following{/other_user}","gists_url":"https://api.github.com/users/lgirdwood/gists{/gist_id}","starred_url":"https://api.github.com/users/lgirdwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgirdwood/subscriptions","organizations_url":"https://api.github.com/users/lgirdwood/orgs","repos_url":"https://api.github.com/users/lgirdwood/repos","events_url":"https://api.github.com/users/lgirdwood/events{/privacy}","received_events_url":"https://api.github.com/users/lgirdwood/received_events","type":"User","site_admin":false},"body":"I think it's better to if you create a new file or change > 5% lines of an existing file.","created_at":"2018-09-03T13:31:38Z","updated_at":"2018-09-03T13:31:38Z","html_url":"https://github.com/thesofproject/sof/pull/290#discussion_r214690560","pull_request_url":"https://api.github.com/repos/thesofproject/sof/pulls/290","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/comments/214690560"},"html":{"href":"https://github.com/thesofproject/sof/pull/290#discussion_r214690560"},"pull_request":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/290"}},"in_reply_to_id":214543335},"pull_request":{"url":"https://api.github.com/repos/thesofproject/sof/pulls/290","id":212449728,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNDQ5NzI4","html_url":"https://github.com/thesofproject/sof/pull/290","diff_url":"https://github.com/thesofproject/sof/pull/290.diff","patch_url":"https://github.com/thesofproject/sof/pull/290.patch","issue_url":"https://api.github.com/repos/thesofproject/sof/issues/290","number":290,"state":"closed","locked":false,"title":"icelake: initial configuration","user":{"login":"jajanusz","id":40290934,"node_id":"MDQ6VXNlcjQwMjkwOTM0","avatar_url":"https://avatars0.githubusercontent.com/u/40290934?v=4","gravatar_id":"","url":"https://api.github.com/users/jajanusz","html_url":"https://github.com/jajanusz","followers_url":"https://api.github.com/users/jajanusz/followers","following_url":"https://api.github.com/users/jajanusz/following{/other_user}","gists_url":"https://api.github.com/users/jajanusz/gists{/gist_id}","starred_url":"https://api.github.com/users/jajanusz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jajanusz/subscriptions","organizations_url":"https://api.github.com/users/jajanusz/orgs","repos_url":"https://api.github.com/users/jajanusz/repos","events_url":"https://api.github.com/users/jajanusz/events{/privacy}","received_events_url":"https://api.github.com/users/jajanusz/received_events","type":"User","site_admin":false},"body":"Added intial configuration for building icl firmware.\r\nI can split it into more commits, but it will break fw build.\r\n\r\nI guess you can ignore all src/icelake/include/arch/xtensa/config/* files, because they are literally copy-paste of cnl platform config - they should be part of toolchain anyway because they are going to generate a lot of boilerplate code in our repo for every platform if we will keep it here.","created_at":"2018-08-31T17:35:46Z","updated_at":"2018-09-03T13:31:38Z","closed_at":"2018-09-02T14:53:08Z","merged_at":"2018-09-02T14:53:08Z","merge_commit_sha":"9d552d532bb9f57c05a9dae0944057b2aaf0ec9b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thesofproject/sof/pulls/290/commits","review_comments_url":"https://api.github.com/repos/thesofproject/sof/pulls/290/comments","review_comment_url":"https://api.github.com/repos/thesofproject/sof/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thesofproject/sof/issues/290/comments","statuses_url":"https://api.github.com/repos/thesofproject/sof/statuses/252d7fec4c027865ed22f06782d9a0c4a9ee3e6e","head":{"label":"jajanusz:icelake-initial","ref":"icelake-initial","sha":"252d7fec4c027865ed22f06782d9a0c4a9ee3e6e","user":{"login":"jajanusz","id":40290934,"node_id":"MDQ6VXNlcjQwMjkwOTM0","avatar_url":"https://avatars0.githubusercontent.com/u/40290934?v=4","gravatar_id":"","url":"https://api.github.com/users/jajanusz","html_url":"https://github.com/jajanusz","followers_url":"https://api.github.com/users/jajanusz/followers","following_url":"https://api.github.com/users/jajanusz/following{/other_user}","gists_url":"https://api.github.com/users/jajanusz/gists{/gist_id}","starred_url":"https://api.github.com/users/jajanusz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jajanusz/subscriptions","organizations_url":"https://api.github.com/users/jajanusz/orgs","repos_url":"https://api.github.com/users/jajanusz/repos","events_url":"https://api.github.com/users/jajanusz/events{/privacy}","received_events_url":"https://api.github.com/users/jajanusz/received_events","type":"User","site_admin":false},"repo":{"id":139576789,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk1NzY3ODk=","name":"sof","full_name":"jajanusz/sof","owner":{"login":"jajanusz","id":40290934,"node_id":"MDQ6VXNlcjQwMjkwOTM0","avatar_url":"https://avatars0.githubusercontent.com/u/40290934?v=4","gravatar_id":"","url":"https://api.github.com/users/jajanusz","html_url":"https://github.com/jajanusz","followers_url":"https://api.github.com/users/jajanusz/followers","following_url":"https://api.github.com/users/jajanusz/following{/other_user}","gists_url":"https://api.github.com/users/jajanusz/gists{/gist_id}","starred_url":"https://api.github.com/users/jajanusz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jajanusz/subscriptions","organizations_url":"https://api.github.com/users/jajanusz/orgs","repos_url":"https://api.github.com/users/jajanusz/repos","events_url":"https://api.github.com/users/jajanusz/events{/privacy}","received_events_url":"https://api.github.com/users/jajanusz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jajanusz/sof","description":"Sound Open Firmware","fork":true,"url":"https://api.github.com/repos/jajanusz/sof","forks_url":"https://api.github.com/repos/jajanusz/sof/forks","keys_url":"https://api.github.com/repos/jajanusz/sof/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jajanusz/sof/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jajanusz/sof/teams","hooks_url":"https://api.github.com/repos/jajanusz/sof/hooks","issue_events_url":"https://api.github.com/repos/jajanusz/sof/issues/events{/number}","events_url":"https://api.github.com/repos/jajanusz/sof/events","assignees_url":"https://api.github.com/repos/jajanusz/sof/assignees{/user}","branches_url":"https://api.github.com/repos/jajanusz/sof/branches{/branch}","tags_url":"https://api.github.com/repos/jajanusz/sof/tags","blobs_url":"https://api.github.com/repos/jajanusz/sof/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jajanusz/sof/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jajanusz/sof/git/refs{/sha}","trees_url":"https://api.github.com/repos/jajanusz/sof/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jajanusz/sof/statuses/{sha}","languages_url":"https://api.github.com/repos/jajanusz/sof/languages","stargazers_url":"https://api.github.com/repos/jajanusz/sof/stargazers","contributors_url":"https://api.github.com/repos/jajanusz/sof/contributors","subscribers_url":"https://api.github.com/repos/jajanusz/sof/subscribers","subscription_url":"https://api.github.com/repos/jajanusz/sof/subscription","commits_url":"https://api.github.com/repos/jajanusz/sof/commits{/sha}","git_commits_url":"https://api.github.com/repos/jajanusz/sof/git/commits{/sha}","comments_url":"https://api.github.com/repos/jajanusz/sof/comments{/number}","issue_comment_url":"https://api.github.com/repos/jajanusz/sof/issues/comments{/number}","contents_url":"https://api.github.com/repos/jajanusz/sof/contents/{+path}","compare_url":"https://api.github.com/repos/jajanusz/sof/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jajanusz/sof/merges","archive_url":"https://api.github.com/repos/jajanusz/sof/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jajanusz/sof/downloads","issues_url":"https://api.github.com/repos/jajanusz/sof/issues{/number}","pulls_url":"https://api.github.com/repos/jajanusz/sof/pulls{/number}","milestones_url":"https://api.github.com/repos/jajanusz/sof/milestones{/number}","notifications_url":"https://api.github.com/repos/jajanusz/sof/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jajanusz/sof/labels{/name}","releases_url":"https://api.github.com/repos/jajanusz/sof/releases{/id}","deployments_url":"https://api.github.com/repos/jajanusz/sof/deployments","created_at":"2018-07-03T11:58:39Z","updated_at":"2018-09-03T09:27:15Z","pushed_at":"2018-09-03T09:27:37Z","git_url":"git://github.com/jajanusz/sof.git","ssh_url":"git@github.com:jajanusz/sof.git","clone_url":"https://github.com/jajanusz/sof.git","svn_url":"https://github.com/jajanusz/sof","homepage":null,"size":3371,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thesofproject:master","ref":"master","sha":"35ed394a26a4ec70bc3b47970c7f9c00a57d113b","user":{"login":"thesofproject","id":39773507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzczNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/39773507?v=4","gravatar_id":"","url":"https://api.github.com/users/thesofproject","html_url":"https://github.com/thesofproject","followers_url":"https://api.github.com/users/thesofproject/followers","following_url":"https://api.github.com/users/thesofproject/following{/other_user}","gists_url":"https://api.github.com/users/thesofproject/gists{/gist_id}","starred_url":"https://api.github.com/users/thesofproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesofproject/subscriptions","organizations_url":"https://api.github.com/users/thesofproject/orgs","repos_url":"https://api.github.com/users/thesofproject/repos","events_url":"https://api.github.com/users/thesofproject/events{/privacy}","received_events_url":"https://api.github.com/users/thesofproject/received_events","type":"Organization","site_admin":false},"repo":{"id":135623245,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU2MjMyNDU=","name":"sof","full_name":"thesofproject/sof","owner":{"login":"thesofproject","id":39773507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzczNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/39773507?v=4","gravatar_id":"","url":"https://api.github.com/users/thesofproject","html_url":"https://github.com/thesofproject","followers_url":"https://api.github.com/users/thesofproject/followers","following_url":"https://api.github.com/users/thesofproject/following{/other_user}","gists_url":"https://api.github.com/users/thesofproject/gists{/gist_id}","starred_url":"https://api.github.com/users/thesofproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesofproject/subscriptions","organizations_url":"https://api.github.com/users/thesofproject/orgs","repos_url":"https://api.github.com/users/thesofproject/repos","events_url":"https://api.github.com/users/thesofproject/events{/privacy}","received_events_url":"https://api.github.com/users/thesofproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thesofproject/sof","description":"Sound Open Firmware","fork":false,"url":"https://api.github.com/repos/thesofproject/sof","forks_url":"https://api.github.com/repos/thesofproject/sof/forks","keys_url":"https://api.github.com/repos/thesofproject/sof/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thesofproject/sof/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thesofproject/sof/teams","hooks_url":"https://api.github.com/repos/thesofproject/sof/hooks","issue_events_url":"https://api.github.com/repos/thesofproject/sof/issues/events{/number}","events_url":"https://api.github.com/repos/thesofproject/sof/events","assignees_url":"https://api.github.com/repos/thesofproject/sof/assignees{/user}","branches_url":"https://api.github.com/repos/thesofproject/sof/branches{/branch}","tags_url":"https://api.github.com/repos/thesofproject/sof/tags","blobs_url":"https://api.github.com/repos/thesofproject/sof/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thesofproject/sof/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thesofproject/sof/git/refs{/sha}","trees_url":"https://api.github.com/repos/thesofproject/sof/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thesofproject/sof/statuses/{sha}","languages_url":"https://api.github.com/repos/thesofproject/sof/languages","stargazers_url":"https://api.github.com/repos/thesofproject/sof/stargazers","contributors_url":"https://api.github.com/repos/thesofproject/sof/contributors","subscribers_url":"https://api.github.com/repos/thesofproject/sof/subscribers","subscription_url":"https://api.github.com/repos/thesofproject/sof/subscription","commits_url":"https://api.github.com/repos/thesofproject/sof/commits{/sha}","git_commits_url":"https://api.github.com/repos/thesofproject/sof/git/commits{/sha}","comments_url":"https://api.github.com/repos/thesofproject/sof/comments{/number}","issue_comment_url":"https://api.github.com/repos/thesofproject/sof/issues/comments{/number}","contents_url":"https://api.github.com/repos/thesofproject/sof/contents/{+path}","compare_url":"https://api.github.com/repos/thesofproject/sof/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thesofproject/sof/merges","archive_url":"https://api.github.com/repos/thesofproject/sof/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thesofproject/sof/downloads","issues_url":"https://api.github.com/repos/thesofproject/sof/issues{/number}","pulls_url":"https://api.github.com/repos/thesofproject/sof/pulls{/number}","milestones_url":"https://api.github.com/repos/thesofproject/sof/milestones{/number}","notifications_url":"https://api.github.com/repos/thesofproject/sof/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thesofproject/sof/labels{/name}","releases_url":"https://api.github.com/repos/thesofproject/sof/releases{/id}","deployments_url":"https://api.github.com/repos/thesofproject/sof/deployments","created_at":"2018-05-31T18:51:03Z","updated_at":"2018-09-03T12:45:22Z","pushed_at":"2018-09-03T12:45:19Z","git_url":"git://github.com/thesofproject/sof.git","ssh_url":"git@github.com:thesofproject/sof.git","clone_url":"https://github.com/thesofproject/sof.git","svn_url":"https://github.com/thesofproject/sof","homepage":null,"size":3414,"stargazers_count":15,"watchers_count":15,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":36,"open_issues":44,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/290"},"html":{"href":"https://github.com/thesofproject/sof/pull/290"},"issue":{"href":"https://api.github.com/repos/thesofproject/sof/issues/290"},"comments":{"href":"https://api.github.com/repos/thesofproject/sof/issues/290/comments"},"review_comments":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/290/comments"},"review_comment":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/290/commits"},"statuses":{"href":"https://api.github.com/repos/thesofproject/sof/statuses/252d7fec4c027865ed22f06782d9a0c4a9ee3e6e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"lgirdwood"}}