{"action":"closed","number":24246,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/24246","id":229326367,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MzI2MzY3","html_url":"https://github.com/nodejs/node/pull/24246","diff_url":"https://github.com/nodejs/node/pull/24246.diff","patch_url":"https://github.com/nodejs/node/pull/24246.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/24246","number":24246,"state":"closed","locked":false,"title":"src, test: fix V8 compiler warnings","user":{"login":"danbev","id":432351,"node_id":"MDQ6VXNlcjQzMjM1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/432351?v=4","gravatar_id":"","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following{/other_user}","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User","site_admin":false},"body":"This pull request follows up on https://github.com/nodejs/node/pull/24060 and attempts to fix all the remaining v8 warnings regarding Set/Get.\r\n\r\n~There is currently one warning still being generated from [src/node.cc]~(https://github.com/nodejs/node/commit/a52528321fb5f493ed70b981900e4bca5aa109e9#diff-cd53544f44aab2c697bcd7b6a57f23ccR675-677)\r\n\r\n~I've left a comment in the code as I was not sure how to get the correct context. Hopefully someone can help out and advise on this.~\r\n\r\n\r\nThe commits are currently separate for each C++ source file but can be squashed unless anyone objects.\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-11-08T11:03:10Z","updated_at":"2018-11-11T07:08:57Z","closed_at":"2018-11-11T07:08:57Z","merged_at":null,"merge_commit_sha":"54446c2d5327a752d8b273b09b53af967266b8f1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":155267502,"node_id":"MDU6TGFiZWwxNTUyNjc1MDI=","url":"https://api.github.com/repos/nodejs/node/labels/C++","name":"C++","color":"e11d21","default":false},{"id":281232761,"node_id":"MDU6TGFiZWwyODEyMzI3NjE=","url":"https://api.github.com/repos/nodejs/node/labels/lib%20/%20src","name":"lib / src","color":"fad8c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/24246/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/24246/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/24246/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/1537d392ac14344833660c1b3ead024e8d0e3f89","head":{"label":"danbev:v8_compiler_warnings","ref":"v8_compiler_warnings","sha":"1537d392ac14344833660c1b3ead024e8d0e3f89","user":{"login":"danbev","id":432351,"node_id":"MDQ6VXNlcjQzMjM1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/432351?v=4","gravatar_id":"","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following{/other_user}","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User","site_admin":false},"repo":{"id":60841866,"node_id":"MDEwOlJlcG9zaXRvcnk2MDg0MTg2Ng==","name":"node","full_name":"danbev/node","private":false,"owner":{"login":"danbev","id":432351,"node_id":"MDQ6VXNlcjQzMjM1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/432351?v=4","gravatar_id":"","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following{/other_user}","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User","site_admin":false},"html_url":"https://github.com/danbev/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/danbev/node","forks_url":"https://api.github.com/repos/danbev/node/forks","keys_url":"https://api.github.com/repos/danbev/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danbev/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danbev/node/teams","hooks_url":"https://api.github.com/repos/danbev/node/hooks","issue_events_url":"https://api.github.com/repos/danbev/node/issues/events{/number}","events_url":"https://api.github.com/repos/danbev/node/events","assignees_url":"https://api.github.com/repos/danbev/node/assignees{/user}","branches_url":"https://api.github.com/repos/danbev/node/branches{/branch}","tags_url":"https://api.github.com/repos/danbev/node/tags","blobs_url":"https://api.github.com/repos/danbev/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danbev/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danbev/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/danbev/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danbev/node/statuses/{sha}","languages_url":"https://api.github.com/repos/danbev/node/languages","stargazers_url":"https://api.github.com/repos/danbev/node/stargazers","contributors_url":"https://api.github.com/repos/danbev/node/contributors","subscribers_url":"https://api.github.com/repos/danbev/node/subscribers","subscription_url":"https://api.github.com/repos/danbev/node/subscription","commits_url":"https://api.github.com/repos/danbev/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/danbev/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/danbev/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/danbev/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/danbev/node/contents/{+path}","compare_url":"https://api.github.com/repos/danbev/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danbev/node/merges","archive_url":"https://api.github.com/repos/danbev/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danbev/node/downloads","issues_url":"https://api.github.com/repos/danbev/node/issues{/number}","pulls_url":"https://api.github.com/repos/danbev/node/pulls{/number}","milestones_url":"https://api.github.com/repos/danbev/node/milestones{/number}","notifications_url":"https://api.github.com/repos/danbev/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danbev/node/labels{/name}","releases_url":"https://api.github.com/repos/danbev/node/releases{/id}","deployments_url":"https://api.github.com/repos/danbev/node/deployments","created_at":"2016-06-10T11:03:24Z","updated_at":"2018-05-14T03:58:52Z","pushed_at":"2018-11-11T04:54:39Z","git_url":"git://github.com/danbev/node.git","ssh_url":"git@github.com:danbev/node.git","clone_url":"https://github.com/danbev/node.git","svn_url":"https://github.com/danbev/node","homepage":"https://nodejs.org","size":398822,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"d4654d89be0c20f8ca1e153d074a236348618b00","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","private":false,"owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-11-11T07:02:32Z","pushed_at":"2018-11-11T07:08:44Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":430623,"stargazers_count":55282,"watchers_count":55282,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12092,"mirror_url":null,"archived":false,"open_issues_count":902,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12092,"open_issues":902,"watchers":55282,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/24246"},"html":{"href":"https://github.com/nodejs/node/pull/24246"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/24246"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/24246/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/24246/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/24246/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/1537d392ac14344833660c1b3ead024e8d0e3f89"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":11,"review_comments":3,"maintainer_can_modify":false,"commits":2,"additions":431,"deletions":224,"changed_files":39}}
{"actor":{"display_login":"danbev"}}