{"action":"opened","number":12427,"pull_request":{"url":"https://api.github.com/repos/mui-org/material-ui/pulls/12427","id":206468118,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NDY4MTE4","html_url":"https://github.com/mui-org/material-ui/pull/12427","diff_url":"https://github.com/mui-org/material-ui/pull/12427.diff","patch_url":"https://github.com/mui-org/material-ui/pull/12427.patch","issue_url":"https://api.github.com/repos/mui-org/material-ui/issues/12427","number":12427,"state":"open","locked":false,"title":"[Dialog] Fix positioning issue","user":{"login":"alancasagrande","id":893649,"node_id":"MDQ6VXNlcjg5MzY0OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/893649?v=4","gravatar_id":"","url":"https://api.github.com/users/alancasagrande","html_url":"https://github.com/alancasagrande","followers_url":"https://api.github.com/users/alancasagrande/followers","following_url":"https://api.github.com/users/alancasagrande/following{/other_user}","gists_url":"https://api.github.com/users/alancasagrande/gists{/gist_id}","starred_url":"https://api.github.com/users/alancasagrande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alancasagrande/subscriptions","organizations_url":"https://api.github.com/users/alancasagrande/orgs","repos_url":"https://api.github.com/users/alancasagrande/repos","events_url":"https://api.github.com/users/alancasagrande/events{/privacy}","received_events_url":"https://api.github.com/users/alancasagrande/received_events","type":"User","site_admin":false},"body":"I encountered an issue with tall dialogs on first render. \r\n\r\nIt looks like the position is incorrect because it's calculated based on an outdated dialog height. Calling  `this.positionDialog()` on the next iteration fixed the issue. \r\n\r\nNot sure if that works for all browsers but at worst it won't have any effect.\r\n\r\n**Without `setTimeout` (incorrect)**\r\n\r\n<img width=\"1680\" alt=\"screen shot 2018-08-06 at 13 42 58\" src=\"https://user-images.githubusercontent.com/893649/43730205-ffb2512a-9980-11e8-9904-c9feec54d728.png\">\r\n\r\n**With `setTimeout` (correct)**\r\n\r\n<img width=\"1680\" alt=\"screen shot 2018-08-06 at 13 48 43\" src=\"https://user-images.githubusercontent.com/893649/43730210-073b0450-9981-11e8-98a5-7b2acca0da1a.png\">\r\n","created_at":"2018-08-06T17:36:33Z","updated_at":"2018-08-06T17:36:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mui-org/material-ui/pulls/12427/commits","review_comments_url":"https://api.github.com/repos/mui-org/material-ui/pulls/12427/comments","review_comment_url":"https://api.github.com/repos/mui-org/material-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mui-org/material-ui/issues/12427/comments","statuses_url":"https://api.github.com/repos/mui-org/material-ui/statuses/38f214d46a98e36a3b4b931656f85b420468000f","head":{"label":"alancasagrande:fix/tall-dialog","ref":"fix/tall-dialog","sha":"38f214d46a98e36a3b4b931656f85b420468000f","user":{"login":"alancasagrande","id":893649,"node_id":"MDQ6VXNlcjg5MzY0OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/893649?v=4","gravatar_id":"","url":"https://api.github.com/users/alancasagrande","html_url":"https://github.com/alancasagrande","followers_url":"https://api.github.com/users/alancasagrande/followers","following_url":"https://api.github.com/users/alancasagrande/following{/other_user}","gists_url":"https://api.github.com/users/alancasagrande/gists{/gist_id}","starred_url":"https://api.github.com/users/alancasagrande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alancasagrande/subscriptions","organizations_url":"https://api.github.com/users/alancasagrande/orgs","repos_url":"https://api.github.com/users/alancasagrande/repos","events_url":"https://api.github.com/users/alancasagrande/events{/privacy}","received_events_url":"https://api.github.com/users/alancasagrande/received_events","type":"User","site_admin":false},"repo":{"id":92294004,"node_id":"MDEwOlJlcG9zaXRvcnk5MjI5NDAwNA==","name":"material-ui","full_name":"alancasagrande/material-ui","owner":{"login":"alancasagrande","id":893649,"node_id":"MDQ6VXNlcjg5MzY0OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/893649?v=4","gravatar_id":"","url":"https://api.github.com/users/alancasagrande","html_url":"https://github.com/alancasagrande","followers_url":"https://api.github.com/users/alancasagrande/followers","following_url":"https://api.github.com/users/alancasagrande/following{/other_user}","gists_url":"https://api.github.com/users/alancasagrande/gists{/gist_id}","starred_url":"https://api.github.com/users/alancasagrande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alancasagrande/subscriptions","organizations_url":"https://api.github.com/users/alancasagrande/orgs","repos_url":"https://api.github.com/users/alancasagrande/repos","events_url":"https://api.github.com/users/alancasagrande/events{/privacy}","received_events_url":"https://api.github.com/users/alancasagrande/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alancasagrande/material-ui","description":"React Components that Implement Google's Material Design.","fork":true,"url":"https://api.github.com/repos/alancasagrande/material-ui","forks_url":"https://api.github.com/repos/alancasagrande/material-ui/forks","keys_url":"https://api.github.com/repos/alancasagrande/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alancasagrande/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alancasagrande/material-ui/teams","hooks_url":"https://api.github.com/repos/alancasagrande/material-ui/hooks","issue_events_url":"https://api.github.com/repos/alancasagrande/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/alancasagrande/material-ui/events","assignees_url":"https://api.github.com/repos/alancasagrande/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/alancasagrande/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/alancasagrande/material-ui/tags","blobs_url":"https://api.github.com/repos/alancasagrande/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alancasagrande/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alancasagrande/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/alancasagrande/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alancasagrande/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/alancasagrande/material-ui/languages","stargazers_url":"https://api.github.com/repos/alancasagrande/material-ui/stargazers","contributors_url":"https://api.github.com/repos/alancasagrande/material-ui/contributors","subscribers_url":"https://api.github.com/repos/alancasagrande/material-ui/subscribers","subscription_url":"https://api.github.com/repos/alancasagrande/material-ui/subscription","commits_url":"https://api.github.com/repos/alancasagrande/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/alancasagrande/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/alancasagrande/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/alancasagrande/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/alancasagrande/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/alancasagrande/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alancasagrande/material-ui/merges","archive_url":"https://api.github.com/repos/alancasagrande/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alancasagrande/material-ui/downloads","issues_url":"https://api.github.com/repos/alancasagrande/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/alancasagrande/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/alancasagrande/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/alancasagrande/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alancasagrande/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/alancasagrande/material-ui/releases{/id}","deployments_url":"https://api.github.com/repos/alancasagrande/material-ui/deployments","created_at":"2017-05-24T13:15:36Z","updated_at":"2018-08-06T15:38:36Z","pushed_at":"2018-08-06T16:54:14Z","git_url":"git://github.com/alancasagrande/material-ui.git","ssh_url":"git@github.com:alancasagrande/material-ui.git","clone_url":"https://github.com/alancasagrande/material-ui.git","svn_url":"https://github.com/alancasagrande/material-ui","homepage":"http://www.material-ui.com","size":46989,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mui-org:v0.x","ref":"v0.x","sha":"1b1c1fce216b5b2f5ecd52d21f8ec6a326c00cd5","user":{"login":"mui-org","id":33663932,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNjYzOTMy","avatar_url":"https://avatars2.githubusercontent.com/u/33663932?v=4","gravatar_id":"","url":"https://api.github.com/users/mui-org","html_url":"https://github.com/mui-org","followers_url":"https://api.github.com/users/mui-org/followers","following_url":"https://api.github.com/users/mui-org/following{/other_user}","gists_url":"https://api.github.com/users/mui-org/gists{/gist_id}","starred_url":"https://api.github.com/users/mui-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mui-org/subscriptions","organizations_url":"https://api.github.com/users/mui-org/orgs","repos_url":"https://api.github.com/users/mui-org/repos","events_url":"https://api.github.com/users/mui-org/events{/privacy}","received_events_url":"https://api.github.com/users/mui-org/received_events","type":"Organization","site_admin":false},"repo":{"id":23083156,"node_id":"MDEwOlJlcG9zaXRvcnkyMzA4MzE1Ng==","name":"material-ui","full_name":"mui-org/material-ui","owner":{"login":"mui-org","id":33663932,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNjYzOTMy","avatar_url":"https://avatars2.githubusercontent.com/u/33663932?v=4","gravatar_id":"","url":"https://api.github.com/users/mui-org","html_url":"https://github.com/mui-org","followers_url":"https://api.github.com/users/mui-org/followers","following_url":"https://api.github.com/users/mui-org/following{/other_user}","gists_url":"https://api.github.com/users/mui-org/gists{/gist_id}","starred_url":"https://api.github.com/users/mui-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mui-org/subscriptions","organizations_url":"https://api.github.com/users/mui-org/orgs","repos_url":"https://api.github.com/users/mui-org/repos","events_url":"https://api.github.com/users/mui-org/events{/privacy}","received_events_url":"https://api.github.com/users/mui-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mui-org/material-ui","description":"React components that implement Google's Material Design.","fork":false,"url":"https://api.github.com/repos/mui-org/material-ui","forks_url":"https://api.github.com/repos/mui-org/material-ui/forks","keys_url":"https://api.github.com/repos/mui-org/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mui-org/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mui-org/material-ui/teams","hooks_url":"https://api.github.com/repos/mui-org/material-ui/hooks","issue_events_url":"https://api.github.com/repos/mui-org/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/mui-org/material-ui/events","assignees_url":"https://api.github.com/repos/mui-org/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/mui-org/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/mui-org/material-ui/tags","blobs_url":"https://api.github.com/repos/mui-org/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mui-org/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mui-org/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/mui-org/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mui-org/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/mui-org/material-ui/languages","stargazers_url":"https://api.github.com/repos/mui-org/material-ui/stargazers","contributors_url":"https://api.github.com/repos/mui-org/material-ui/contributors","subscribers_url":"https://api.github.com/repos/mui-org/material-ui/subscribers","subscription_url":"https://api.github.com/repos/mui-org/material-ui/subscription","commits_url":"https://api.github.com/repos/mui-org/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/mui-org/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/mui-org/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/mui-org/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/mui-org/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/mui-org/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mui-org/material-ui/merges","archive_url":"https://api.github.com/repos/mui-org/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mui-org/material-ui/downloads","issues_url":"https://api.github.com/repos/mui-org/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/mui-org/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/mui-org/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/mui-org/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mui-org/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/mui-org/material-ui/releases{/id}","deployments_url":"https://api.github.com/repos/mui-org/material-ui/deployments","created_at":"2014-08-18T19:11:54Z","updated_at":"2018-08-06T16:35:26Z","pushed_at":"2018-08-06T16:27:38Z","git_url":"git://github.com/mui-org/material-ui.git","ssh_url":"git@github.com:mui-org/material-ui.git","clone_url":"https://github.com/mui-org/material-ui.git","svn_url":"https://github.com/mui-org/material-ui","homepage":"https://material-ui.com/","size":47662,"stargazers_count":39120,"watchers_count":39120,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7170,"mirror_url":null,"archived":false,"open_issues_count":192,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7170,"open_issues":192,"watchers":39120,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mui-org/material-ui/pulls/12427"},"html":{"href":"https://github.com/mui-org/material-ui/pull/12427"},"issue":{"href":"https://api.github.com/repos/mui-org/material-ui/issues/12427"},"comments":{"href":"https://api.github.com/repos/mui-org/material-ui/issues/12427/comments"},"review_comments":{"href":"https://api.github.com/repos/mui-org/material-ui/pulls/12427/comments"},"review_comment":{"href":"https://api.github.com/repos/mui-org/material-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mui-org/material-ui/pulls/12427/commits"},"statuses":{"href":"https://api.github.com/repos/mui-org/material-ui/statuses/38f214d46a98e36a3b4b931656f85b420468000f"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"alancasagrande"}}