{"action":"created","comment":{"url":"https://api.github.com/repos/dotCMS/core-web/pulls/comments/185924438","pull_request_review_id":117414896,"id":185924438,"diff_hunk":"@@ -142,31 +142,64 @@ describe('DotEditContentToolbarHtmlService', () => {\n     });\n \n     describe('contentlet toolbar', () => {\n+        let htmlElement: HTMLHtmlElement;\n+\n         beforeEach(() => {\n             testDoc = document.implementation.createDocument('http://www.w3.org/1999/xhtml', 'html', null);\n             dummyContainer = testDoc.createElement('div');\n-            const htmlElement: HTMLHtmlElement = testDoc.getElementsByTagName('html')[0];\n-            dummyContainer.innerHTML = `\n-                <div data-dot-object=\"container\">\n-                    <div data-dot-object=\"contentlet\" data-dot-can-edit=\"false\">\n-                        <div class=\"large-column\"></div>\n-                    </div>\n-                </div>\n-            `;\n-            htmlElement.appendChild(dummyContainer);\n-            dotEditContentToolbarHtmlService.addContentletMarkup(testDoc);\n+            htmlElement = testDoc.getElementsByTagName('html')[0];\n         });\n \n-        it('should create buttons', () => {\n-            expect(testDoc.querySelectorAll('.dotedit-contentlet__drag').length).toEqual(1);\n-            expect(testDoc.querySelectorAll('.dotedit-contentlet__edit').length).toEqual(1);\n-            expect(testDoc.querySelectorAll('.dotedit-contentlet__remove').length).toEqual(1);\n-        });\n+        describe('default', () => {\n+            beforeEach(() => {\n+                dummyContainer.innerHTML = `\n+                    <div data-dot-object=\"container\">\n+                        <div data-dot-object=\"contentlet\" data-dot-can-edit=\"false\">\n+                            <div class=\"large-column\"></div>\n+                        </div>\n+                    </div>\n+                `;\n+                htmlElement.appendChild(dummyContainer);\n+                dotEditContentToolbarHtmlService.addContentletMarkup(testDoc);\n+            });\n+\n+            it('should create buttons', () => {\n+                expect(testDoc.querySelectorAll('.dotedit-contentlet__drag').length).toEqual(1);\n+                expect(testDoc.querySelectorAll('.dotedit-contentlet__edit').length).toEqual(1);\n+                expect(testDoc.querySelectorAll('.dotedit-contentlet__remove').length).toEqual(1);\n+                expect(testDoc.querySelectorAll('.dotedit-contentlet__code').length).toEqual(0);\n+            });\n+\n+            it('should have edit button disabled', () => {\n+                expect(testDoc.querySelector('.dotedit-contentlet__edit').classList.contains('dotedit-contentlet__disabled')).toBe(true);\n+            });\n \n-        it('should have edit button disabled', () => {\n-            expect(testDoc.querySelector('.dotedit-contentlet__edit').classList.contains('dotedit-contentlet__disabled')).toBe(true);\n+            xit('should bind events');","path":"src/app/portlets/dot-edit-page/content/services/html/dot-edit-content-toolbar-html.service.spec.ts","position":95,"original_position":95,"commit_id":"29e1dd955bf95f7b955128ec07918bee5425a72d","original_commit_id":"29e1dd955bf95f7b955128ec07918bee5425a72d","user":{"login":"alfredo-dotcms","id":37185433,"avatar_url":"https://avatars0.githubusercontent.com/u/37185433?v=4","gravatar_id":"","url":"https://api.github.com/users/alfredo-dotcms","html_url":"https://github.com/alfredo-dotcms","followers_url":"https://api.github.com/users/alfredo-dotcms/followers","following_url":"https://api.github.com/users/alfredo-dotcms/following{/other_user}","gists_url":"https://api.github.com/users/alfredo-dotcms/gists{/gist_id}","starred_url":"https://api.github.com/users/alfredo-dotcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfredo-dotcms/subscriptions","organizations_url":"https://api.github.com/users/alfredo-dotcms/orgs","repos_url":"https://api.github.com/users/alfredo-dotcms/repos","events_url":"https://api.github.com/users/alfredo-dotcms/events{/privacy}","received_events_url":"https://api.github.com/users/alfredo-dotcms/received_events","type":"User","site_admin":false},"body":"xit???","created_at":"2018-05-03T20:19:31Z","updated_at":"2018-05-03T20:19:31Z","html_url":"https://github.com/dotCMS/core-web/pull/644#discussion_r185924438","pull_request_url":"https://api.github.com/repos/dotCMS/core-web/pulls/644","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotCMS/core-web/pulls/comments/185924438"},"html":{"href":"https://github.com/dotCMS/core-web/pull/644#discussion_r185924438"},"pull_request":{"href":"https://api.github.com/repos/dotCMS/core-web/pulls/644"}}},"pull_request":{"url":"https://api.github.com/repos/dotCMS/core-web/pulls/644","id":185824546,"html_url":"https://github.com/dotCMS/core-web/pull/644","diff_url":"https://github.com/dotCMS/core-web/pull/644.diff","patch_url":"https://github.com/dotCMS/core-web/pull/644.patch","issue_url":"https://api.github.com/repos/dotCMS/core-web/issues/644","number":644,"state":"open","locked":false,"title":"dotCMS/core#14056 Missing and edit .vtl file icon in Edit Mode for parsed vtl files in dynamic listings","user":{"login":"fmontes","id":751424,"avatar_url":"https://avatars3.githubusercontent.com/u/751424?v=4","gravatar_id":"","url":"https://api.github.com/users/fmontes","html_url":"https://github.com/fmontes","followers_url":"https://api.github.com/users/fmontes/followers","following_url":"https://api.github.com/users/fmontes/following{/other_user}","gists_url":"https://api.github.com/users/fmontes/gists{/gist_id}","starred_url":"https://api.github.com/users/fmontes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmontes/subscriptions","organizations_url":"https://api.github.com/users/fmontes/orgs","repos_url":"https://api.github.com/users/fmontes/repos","events_url":"https://api.github.com/users/fmontes/events{/privacy}","received_events_url":"https://api.github.com/users/fmontes/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-03T20:10:15Z","updated_at":"2018-05-03T20:19:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e9be6ae43b4260f90957e44940bc6716ddc6988","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotCMS/core-web/pulls/644/commits","review_comments_url":"https://api.github.com/repos/dotCMS/core-web/pulls/644/comments","review_comment_url":"https://api.github.com/repos/dotCMS/core-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotCMS/core-web/issues/644/comments","statuses_url":"https://api.github.com/repos/dotCMS/core-web/statuses/29e1dd955bf95f7b955128ec07918bee5425a72d","head":{"label":"dotCMS:issue-14056-edit-vtl-button","ref":"issue-14056-edit-vtl-button","sha":"29e1dd955bf95f7b955128ec07918bee5425a72d","user":{"login":"dotCMS","id":1005263,"avatar_url":"https://avatars3.githubusercontent.com/u/1005263?v=4","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":36376350,"name":"core-web","full_name":"dotCMS/core-web","owner":{"login":"dotCMS","id":1005263,"avatar_url":"https://avatars3.githubusercontent.com/u/1005263?v=4","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotCMS/core-web","description":"dotCMS UI","fork":false,"url":"https://api.github.com/repos/dotCMS/core-web","forks_url":"https://api.github.com/repos/dotCMS/core-web/forks","keys_url":"https://api.github.com/repos/dotCMS/core-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotCMS/core-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotCMS/core-web/teams","hooks_url":"https://api.github.com/repos/dotCMS/core-web/hooks","issue_events_url":"https://api.github.com/repos/dotCMS/core-web/issues/events{/number}","events_url":"https://api.github.com/repos/dotCMS/core-web/events","assignees_url":"https://api.github.com/repos/dotCMS/core-web/assignees{/user}","branches_url":"https://api.github.com/repos/dotCMS/core-web/branches{/branch}","tags_url":"https://api.github.com/repos/dotCMS/core-web/tags","blobs_url":"https://api.github.com/repos/dotCMS/core-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotCMS/core-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotCMS/core-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotCMS/core-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotCMS/core-web/statuses/{sha}","languages_url":"https://api.github.com/repos/dotCMS/core-web/languages","stargazers_url":"https://api.github.com/repos/dotCMS/core-web/stargazers","contributors_url":"https://api.github.com/repos/dotCMS/core-web/contributors","subscribers_url":"https://api.github.com/repos/dotCMS/core-web/subscribers","subscription_url":"https://api.github.com/repos/dotCMS/core-web/subscription","commits_url":"https://api.github.com/repos/dotCMS/core-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotCMS/core-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotCMS/core-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotCMS/core-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotCMS/core-web/contents/{+path}","compare_url":"https://api.github.com/repos/dotCMS/core-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotCMS/core-web/merges","archive_url":"https://api.github.com/repos/dotCMS/core-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotCMS/core-web/downloads","issues_url":"https://api.github.com/repos/dotCMS/core-web/issues{/number}","pulls_url":"https://api.github.com/repos/dotCMS/core-web/pulls{/number}","milestones_url":"https://api.github.com/repos/dotCMS/core-web/milestones{/number}","notifications_url":"https://api.github.com/repos/dotCMS/core-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotCMS/core-web/labels{/name}","releases_url":"https://api.github.com/repos/dotCMS/core-web/releases{/id}","deployments_url":"https://api.github.com/repos/dotCMS/core-web/deployments","created_at":"2015-05-27T15:26:16Z","updated_at":"2018-05-03T14:39:15Z","pushed_at":"2018-05-03T20:10:15Z","git_url":"git://github.com/dotCMS/core-web.git","ssh_url":"git@github.com:dotCMS/core-web.git","clone_url":"https://github.com/dotCMS/core-web.git","svn_url":"https://github.com/dotCMS/core-web","homepage":"https://dotcms.com","size":9879,"stargazers_count":5,"watchers_count":5,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":3,"open_issues":13,"watchers":5,"default_branch":"master"}},"base":{"label":"dotCMS:master","ref":"master","sha":"44461a4ffd1240a995ac5a589e8548b8e58bf506","user":{"login":"dotCMS","id":1005263,"avatar_url":"https://avatars3.githubusercontent.com/u/1005263?v=4","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":36376350,"name":"core-web","full_name":"dotCMS/core-web","owner":{"login":"dotCMS","id":1005263,"avatar_url":"https://avatars3.githubusercontent.com/u/1005263?v=4","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotCMS/core-web","description":"dotCMS UI","fork":false,"url":"https://api.github.com/repos/dotCMS/core-web","forks_url":"https://api.github.com/repos/dotCMS/core-web/forks","keys_url":"https://api.github.com/repos/dotCMS/core-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotCMS/core-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotCMS/core-web/teams","hooks_url":"https://api.github.com/repos/dotCMS/core-web/hooks","issue_events_url":"https://api.github.com/repos/dotCMS/core-web/issues/events{/number}","events_url":"https://api.github.com/repos/dotCMS/core-web/events","assignees_url":"https://api.github.com/repos/dotCMS/core-web/assignees{/user}","branches_url":"https://api.github.com/repos/dotCMS/core-web/branches{/branch}","tags_url":"https://api.github.com/repos/dotCMS/core-web/tags","blobs_url":"https://api.github.com/repos/dotCMS/core-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotCMS/core-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotCMS/core-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotCMS/core-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotCMS/core-web/statuses/{sha}","languages_url":"https://api.github.com/repos/dotCMS/core-web/languages","stargazers_url":"https://api.github.com/repos/dotCMS/core-web/stargazers","contributors_url":"https://api.github.com/repos/dotCMS/core-web/contributors","subscribers_url":"https://api.github.com/repos/dotCMS/core-web/subscribers","subscription_url":"https://api.github.com/repos/dotCMS/core-web/subscription","commits_url":"https://api.github.com/repos/dotCMS/core-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotCMS/core-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotCMS/core-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotCMS/core-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotCMS/core-web/contents/{+path}","compare_url":"https://api.github.com/repos/dotCMS/core-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotCMS/core-web/merges","archive_url":"https://api.github.com/repos/dotCMS/core-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotCMS/core-web/downloads","issues_url":"https://api.github.com/repos/dotCMS/core-web/issues{/number}","pulls_url":"https://api.github.com/repos/dotCMS/core-web/pulls{/number}","milestones_url":"https://api.github.com/repos/dotCMS/core-web/milestones{/number}","notifications_url":"https://api.github.com/repos/dotCMS/core-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotCMS/core-web/labels{/name}","releases_url":"https://api.github.com/repos/dotCMS/core-web/releases{/id}","deployments_url":"https://api.github.com/repos/dotCMS/core-web/deployments","created_at":"2015-05-27T15:26:16Z","updated_at":"2018-05-03T14:39:15Z","pushed_at":"2018-05-03T20:10:15Z","git_url":"git://github.com/dotCMS/core-web.git","ssh_url":"git@github.com:dotCMS/core-web.git","clone_url":"https://github.com/dotCMS/core-web.git","svn_url":"https://github.com/dotCMS/core-web","homepage":"https://dotcms.com","size":9879,"stargazers_count":5,"watchers_count":5,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":3,"open_issues":13,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotCMS/core-web/pulls/644"},"html":{"href":"https://github.com/dotCMS/core-web/pull/644"},"issue":{"href":"https://api.github.com/repos/dotCMS/core-web/issues/644"},"comments":{"href":"https://api.github.com/repos/dotCMS/core-web/issues/644/comments"},"review_comments":{"href":"https://api.github.com/repos/dotCMS/core-web/pulls/644/comments"},"review_comment":{"href":"https://api.github.com/repos/dotCMS/core-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotCMS/core-web/pulls/644/commits"},"statuses":{"href":"https://api.github.com/repos/dotCMS/core-web/statuses/29e1dd955bf95f7b955128ec07918bee5425a72d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"alfredo-dotcms"}}