{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/224947584","pull_request_review_id":164448953,"id":224947584,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDk0NzU4NA==","diff_hunk":"@@ -292,7 +292,25 @@ func (qm *QueryMap) ForRepo(org, repo string) TideQueries {\n // * a label that is in both the labels and missing_labels section\n // * a branch that is in both included and excluded branch set.\n func (tq *TideQuery) Validate() error {\n-\torgs, repos, excludedRepos := sets.NewString(), sets.NewString(), sets.NewString()\n+\tduplicates := func(field string, list []string) error {\n+\t\tdups := sets.NewString()\n+\t\tdupCount := 0\n+\t\tseen := sets.NewString()\n+\t\tfor _, elem := range list {\n+\t\t\tif seen.Has(elem) {\n+\t\t\t\tdupCount++\n+\t\t\t\tdups.Insert(elem)\n+\t\t\t} else {\n+\t\t\t\tseen.Insert(elem)\n+\t\t\t}\n+\t\t}\n+\t\tif dupCount == 0 {\n+\t\t\treturn nil\n+\t\t}\n+\t\treturn fmt.Errorf(\"'%s' contains %d duplicate entries: %s\", field, dupCount, dups.List())","path":"prow/config/tide.go","position":20,"original_position":20,"commit_id":"8633c272fd39b32b58016eedd7c7d6aef18f0776","original_commit_id":"8633c272fd39b32b58016eedd7c7d6aef18f0776","user":{"login":"fejta","id":940341,"node_id":"MDQ6VXNlcjk0MDM0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/940341?v=4","gravatar_id":"","url":"https://api.github.com/users/fejta","html_url":"https://github.com/fejta","followers_url":"https://api.github.com/users/fejta/followers","following_url":"https://api.github.com/users/fejta/following{/other_user}","gists_url":"https://api.github.com/users/fejta/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta/subscriptions","organizations_url":"https://api.github.com/users/fejta/orgs","repos_url":"https://api.github.com/users/fejta/repos","events_url":"https://api.github.com/users/fejta/events{/privacy}","received_events_url":"https://api.github.com/users/fejta/received_events","type":"User","site_admin":false},"body":"%q to quote?\r\nstrings.Join() for the List()?","created_at":"2018-10-13T02:53:13Z","updated_at":"2018-10-13T02:53:54Z","html_url":"https://github.com/kubernetes/test-infra/pull/9789#discussion_r224947584","pull_request_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/9789","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/224947584"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/9789#discussion_r224947584"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/9789"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/9789","id":222601300,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNjAxMzAw","html_url":"https://github.com/kubernetes/test-infra/pull/9789","diff_url":"https://github.com/kubernetes/test-infra/pull/9789.diff","patch_url":"https://github.com/kubernetes/test-infra/pull/9789.patch","issue_url":"https://api.github.com/repos/kubernetes/test-infra/issues/9789","number":9789,"state":"open","locked":false,"title":"Make Tide specify offending values when complaining about duplicates in config.","user":{"login":"cjwagner","id":5334145,"node_id":"MDQ6VXNlcjUzMzQxNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5334145?v=4","gravatar_id":"","url":"https://api.github.com/users/cjwagner","html_url":"https://github.com/cjwagner","followers_url":"https://api.github.com/users/cjwagner/followers","following_url":"https://api.github.com/users/cjwagner/following{/other_user}","gists_url":"https://api.github.com/users/cjwagner/gists{/gist_id}","starred_url":"https://api.github.com/users/cjwagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjwagner/subscriptions","organizations_url":"https://api.github.com/users/cjwagner/orgs","repos_url":"https://api.github.com/users/cjwagner/repos","events_url":"https://api.github.com/users/cjwagner/events{/privacy}","received_events_url":"https://api.github.com/users/cjwagner/received_events","type":"User","site_admin":false},"body":"fixes #9764 \r\n/assign @stevekuznetsov \r\n\r\nExample of the new error output:\r\n```\r\nCould not load config: tide query (index 2) is invalid: 'repos' contains 1 duplicate entries: [kubernetes/komposer]\r\n```\r\n\r\nI also expanded the validation to check for duplicates in the label and branch fields.","created_at":"2018-10-12T22:26:33Z","updated_at":"2018-10-13T02:53:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f9cbadb10edfc18854a07cfe49d60227e484a66","assignee":{"login":"stevekuznetsov","id":7328370,"node_id":"MDQ6VXNlcjczMjgzNzA=","avatar_url":"https://avatars1.githubusercontent.com/u/7328370?v=4","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false},"assignees":[{"login":"stevekuznetsov","id":7328370,"node_id":"MDQ6VXNlcjczMjgzNzA=","avatar_url":"https://avatars1.githubusercontent.com/u/7328370?v=4","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"stevekuznetsov","id":7328370,"node_id":"MDQ6VXNlcjczMjgzNzA=","avatar_url":"https://avatars1.githubusercontent.com/u/7328370?v=4","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":705940018,"node_id":"MDU6TGFiZWw3MDU5NDAwMTg=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":412127043,"node_id":"MDU6TGFiZWw0MTIxMjcwNDM=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/area/prow","name":"area/prow","color":"0052cc","default":false},{"id":484580953,"node_id":"MDU6TGFiZWw0ODQ1ODA5NTM=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":671126262,"node_id":"MDU6TGFiZWw2NzExMjYyNjI=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/9789/commits","review_comments_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/9789/comments","review_comment_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/issues/9789/comments","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/8633c272fd39b32b58016eedd7c7d6aef18f0776","head":{"label":"cjwagner:tide-config-error-message","ref":"tide-config-error-message","sha":"8633c272fd39b32b58016eedd7c7d6aef18f0776","user":{"login":"cjwagner","id":5334145,"node_id":"MDQ6VXNlcjUzMzQxNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5334145?v=4","gravatar_id":"","url":"https://api.github.com/users/cjwagner","html_url":"https://github.com/cjwagner","followers_url":"https://api.github.com/users/cjwagner/followers","following_url":"https://api.github.com/users/cjwagner/following{/other_user}","gists_url":"https://api.github.com/users/cjwagner/gists{/gist_id}","starred_url":"https://api.github.com/users/cjwagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjwagner/subscriptions","organizations_url":"https://api.github.com/users/cjwagner/orgs","repos_url":"https://api.github.com/users/cjwagner/repos","events_url":"https://api.github.com/users/cjwagner/events{/privacy}","received_events_url":"https://api.github.com/users/cjwagner/received_events","type":"User","site_admin":false},"repo":{"id":87842138,"node_id":"MDEwOlJlcG9zaXRvcnk4Nzg0MjEzOA==","name":"test-infra","full_name":"cjwagner/test-infra","private":false,"owner":{"login":"cjwagner","id":5334145,"node_id":"MDQ6VXNlcjUzMzQxNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5334145?v=4","gravatar_id":"","url":"https://api.github.com/users/cjwagner","html_url":"https://github.com/cjwagner","followers_url":"https://api.github.com/users/cjwagner/followers","following_url":"https://api.github.com/users/cjwagner/following{/other_user}","gists_url":"https://api.github.com/users/cjwagner/gists{/gist_id}","starred_url":"https://api.github.com/users/cjwagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjwagner/subscriptions","organizations_url":"https://api.github.com/users/cjwagner/orgs","repos_url":"https://api.github.com/users/cjwagner/repos","events_url":"https://api.github.com/users/cjwagner/events{/privacy}","received_events_url":"https://api.github.com/users/cjwagner/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cjwagner/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":true,"url":"https://api.github.com/repos/cjwagner/test-infra","forks_url":"https://api.github.com/repos/cjwagner/test-infra/forks","keys_url":"https://api.github.com/repos/cjwagner/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cjwagner/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cjwagner/test-infra/teams","hooks_url":"https://api.github.com/repos/cjwagner/test-infra/hooks","issue_events_url":"https://api.github.com/repos/cjwagner/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/cjwagner/test-infra/events","assignees_url":"https://api.github.com/repos/cjwagner/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/cjwagner/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/cjwagner/test-infra/tags","blobs_url":"https://api.github.com/repos/cjwagner/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cjwagner/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cjwagner/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/cjwagner/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cjwagner/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/cjwagner/test-infra/languages","stargazers_url":"https://api.github.com/repos/cjwagner/test-infra/stargazers","contributors_url":"https://api.github.com/repos/cjwagner/test-infra/contributors","subscribers_url":"https://api.github.com/repos/cjwagner/test-infra/subscribers","subscription_url":"https://api.github.com/repos/cjwagner/test-infra/subscription","commits_url":"https://api.github.com/repos/cjwagner/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/cjwagner/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/cjwagner/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/cjwagner/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/cjwagner/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/cjwagner/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cjwagner/test-infra/merges","archive_url":"https://api.github.com/repos/cjwagner/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cjwagner/test-infra/downloads","issues_url":"https://api.github.com/repos/cjwagner/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/cjwagner/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/cjwagner/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/cjwagner/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cjwagner/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/cjwagner/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/cjwagner/test-infra/deployments","created_at":"2017-04-10T18:07:52Z","updated_at":"2018-10-12T21:16:24Z","pushed_at":"2018-10-12T22:26:30Z","git_url":"git://github.com/cjwagner/test-infra.git","ssh_url":"git@github.com:cjwagner/test-infra.git","clone_url":"https://github.com/cjwagner/test-infra.git","svn_url":"https://github.com/cjwagner/test-infra","homepage":null,"size":66548,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"30fa4c0b056b6f01d868ff74372de1e3662d5f26","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":57333709,"node_id":"MDEwOlJlcG9zaXRvcnk1NzMzMzcwOQ==","name":"test-infra","full_name":"kubernetes/test-infra","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":false,"url":"https://api.github.com/repos/kubernetes/test-infra","forks_url":"https://api.github.com/repos/kubernetes/test-infra/forks","keys_url":"https://api.github.com/repos/kubernetes/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/test-infra/teams","hooks_url":"https://api.github.com/repos/kubernetes/test-infra/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/test-infra/events","assignees_url":"https://api.github.com/repos/kubernetes/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/test-infra/tags","blobs_url":"https://api.github.com/repos/kubernetes/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/test-infra/languages","stargazers_url":"https://api.github.com/repos/kubernetes/test-infra/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/test-infra/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/test-infra/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/test-infra/subscription","commits_url":"https://api.github.com/repos/kubernetes/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/test-infra/merges","archive_url":"https://api.github.com/repos/kubernetes/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/test-infra/downloads","issues_url":"https://api.github.com/repos/kubernetes/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/test-infra/deployments","created_at":"2016-04-28T21:05:35Z","updated_at":"2018-10-13T01:17:09Z","pushed_at":"2018-10-13T01:18:21Z","git_url":"git://github.com/kubernetes/test-infra.git","ssh_url":"git@github.com:kubernetes/test-infra.git","clone_url":"https://github.com/kubernetes/test-infra.git","svn_url":"https://github.com/kubernetes/test-infra","homepage":null,"size":67312,"stargazers_count":649,"watchers_count":649,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":580,"mirror_url":null,"archived":false,"open_issues_count":379,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":580,"open_issues":379,"watchers":649,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/9789"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/9789"},"issue":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/9789"},"comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/9789/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/9789/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/9789/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/test-infra/statuses/8633c272fd39b32b58016eedd7c7d6aef18f0776"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"fejta"}}