{"action":"created","issue":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/3461","repository_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto","labels_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/3461/labels{/name}","comments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/3461/comments","events_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/3461/events","html_url":"https://github.com/gravitystorm/openstreetmap-carto/issues/3461","id":372148941,"node_id":"MDU6SXNzdWUzNzIxNDg5NDE=","number":3461,"title":"Remake natural=spring as dot+icon","user":{"login":"kocio-pl","id":5439713,"node_id":"MDQ6VXNlcjU0Mzk3MTM=","avatar_url":"https://avatars2.githubusercontent.com/u/5439713?v=4","gravatar_id":"","url":"https://api.github.com/users/kocio-pl","html_url":"https://github.com/kocio-pl","followers_url":"https://api.github.com/users/kocio-pl/followers","following_url":"https://api.github.com/users/kocio-pl/following{/other_user}","gists_url":"https://api.github.com/users/kocio-pl/gists{/gist_id}","starred_url":"https://api.github.com/users/kocio-pl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kocio-pl/subscriptions","organizations_url":"https://api.github.com/users/kocio-pl/orgs","repos_url":"https://api.github.com/users/kocio-pl/repos","events_url":"https://api.github.com/users/kocio-pl/events{/privacy}","received_events_url":"https://api.github.com/users/kocio-pl/received_events","type":"User","site_admin":false},"labels":[{"id":92406692,"node_id":"MDU6TGFiZWw5MjQwNjY5Mg==","url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/labels/water-features","name":"water-features","color":"207de5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/milestones/3","html_url":"https://github.com/gravitystorm/openstreetmap-carto/milestone/3","labels_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/milestones/3/labels","id":804552,"node_id":"MDk6TWlsZXN0b25lODA0NTUy","number":3,"title":"Bugs and improvements","description":"","creator":{"login":"matthijsmelissen","id":5251909,"node_id":"MDQ6VXNlcjUyNTE5MDk=","avatar_url":"https://avatars3.githubusercontent.com/u/5251909?v=4","gravatar_id":"","url":"https://api.github.com/users/matthijsmelissen","html_url":"https://github.com/matthijsmelissen","followers_url":"https://api.github.com/users/matthijsmelissen/followers","following_url":"https://api.github.com/users/matthijsmelissen/following{/other_user}","gists_url":"https://api.github.com/users/matthijsmelissen/gists{/gist_id}","starred_url":"https://api.github.com/users/matthijsmelissen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthijsmelissen/subscriptions","organizations_url":"https://api.github.com/users/matthijsmelissen/orgs","repos_url":"https://api.github.com/users/matthijsmelissen/repos","events_url":"https://api.github.com/users/matthijsmelissen/events{/privacy}","received_events_url":"https://api.github.com/users/matthijsmelissen/received_events","type":"User","site_admin":false},"open_issues":240,"closed_issues":634,"state":"open","created_at":"2014-09-26T17:37:22Z","updated_at":"2018-10-20T14:33:54Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2018-10-19T23:45:37Z","updated_at":"2018-10-20T17:19:28Z","closed_at":null,"author_association":"COLLABORATOR","body":"Follow up to #3189, #3253 and #3274.\r\nProof of concept code is here (based on v4.10.0): https://github.com/gravitystorm/openstreetmap-carto/compare/master...kocio-pl:spring-dot\r\n\r\nI'm not satisfied with our new spring rendering. It was based on a clever idea, but in practice it's not too good. My proposition is to get back to the original \"s\"-based design and follow the way we're rendering fountains. Here's why:\r\n- it's best not to use letters and stay with geometric shapes (\"s\" may be misleading in other languages than English)\r\n- on medium zoom levels we need just something to spot, and since we already have blue dot as a symbol of a fountain, it should be easier to get the meaning (man made or natural water source)\r\n- on higher levels there's enough space to show real icon depicting object, so it's clear that this is not a fountain\r\n- it fixes the problem of rendering on water areas\r\n- dot is smaller than ring\r\n\r\nI also tried to make both dots and labels more visible, so I used the same darker blue color as fountain and made bigger halo.\r\n\r\nExamples:\r\n\r\n[Named spring is better visible than currently](https://www.openstreetmap.org/node/1100451137)\r\n\r\nBefore\r\n\r\n![hgkypdhd](https://user-images.githubusercontent.com/5439713/47247583-f2026100-d404-11e8-82c9-e7594c9f0b04.png)\r\n\r\nAfter\r\n\r\n![ll8xgnpg](https://user-images.githubusercontent.com/5439713/47247588-f464bb00-d404-11e8-96ad-a6762954e0bf.png)\r\n\r\n[Spring in the middle of a water area](https://www.openstreetmap.org/node/5442671644)\r\n\r\n![_mimirc](https://user-images.githubusercontent.com/5439713/47247539-9fc14000-d404-11e8-922f-a0ec1bf461d0.png)\r\n![epsvrlfa](https://user-images.githubusercontent.com/5439713/47247538-9e901300-d404-11e8-915e-b166bd510bd2.png)\r\n\r\n[Lot of springs on the grass](https://www.openstreetmap.org/#map=14/48.2824/24.1234) (even better than \"s\")\r\n\r\nLong before\r\n![yei2krqw](https://user-images.githubusercontent.com/5439713/47247470-3e996c80-d404-11e8-8596-232329b2aa07.png)\r\nAfter\r\n![_uohlkab](https://user-images.githubusercontent.com/5439713/47247363-78b63e80-d403-11e8-93f3-cb9c075c5f42.png)\r\n\r\n[Lot of springs in the forest](https://www.openstreetmap.org/#map=14/48.5753/9.0193)\r\n\r\n![wmkncwpn](https://user-images.githubusercontent.com/5439713/47247762-ecf1e180-d405-11e8-9cda-38512449cfc8.png)\r\n\r\n[Lots of springs on bare ground](https://www.openstreetmap.org/#map=14/-24.1451/-48.3252)\r\n\r\n![lpnitxka](https://user-images.githubusercontent.com/5439713/47251976-b7b4b600-d43c-11e8-81b1-f33468ef4cd6.png)\r\n\r\nreal icon on z18+ does not make clutter even on crowded places\r\n\r\n![ucejbs8i](https://user-images.githubusercontent.com/5439713/47248002-a8674580-d407-11e8-8e93-ad6fe2c4cbf0.png)\r\n\r\n![mnvimnfy](https://user-images.githubusercontent.com/5439713/47247997-9a192980-d407-11e8-9f14-dad74f008ffa.png)"},"comment":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/comments/431601119","html_url":"https://github.com/gravitystorm/openstreetmap-carto/issues/3461#issuecomment-431601119","issue_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/3461","id":431601119,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTYwMTExOQ==","user":{"login":"kocio-pl","id":5439713,"node_id":"MDQ6VXNlcjU0Mzk3MTM=","avatar_url":"https://avatars2.githubusercontent.com/u/5439713?v=4","gravatar_id":"","url":"https://api.github.com/users/kocio-pl","html_url":"https://github.com/kocio-pl","followers_url":"https://api.github.com/users/kocio-pl/followers","following_url":"https://api.github.com/users/kocio-pl/following{/other_user}","gists_url":"https://api.github.com/users/kocio-pl/gists{/gist_id}","starred_url":"https://api.github.com/users/kocio-pl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kocio-pl/subscriptions","organizations_url":"https://api.github.com/users/kocio-pl/orgs","repos_url":"https://api.github.com/users/kocio-pl/repos","events_url":"https://api.github.com/users/kocio-pl/events{/privacy}","received_events_url":"https://api.github.com/users/kocio-pl/received_events","type":"User","site_admin":false},"created_at":"2018-10-20T17:19:28Z","updated_at":"2018-10-20T17:19:28Z","author_association":"COLLABORATOR","body":"Thanks for reactions. It looks like this solution makes sense in general, so we can look more into details.\r\n\r\n@polarbearing Sorry for confusion, I was sure that everyone knows how it looks today and wanted to sketch a solution before anything more detailed. I have now added before/after when needed, all the other images are planned \"after\". \r\n\r\nMy proposition is to redesign it close to the initial \"s\" idea, but replace the letter with dot instead for medium zoom and show spring icon at high zoom.\r\n\r\nI thought that it will be clear that it's not fountain icon (because it's simple, not symmetrical and lacks the plate at the bottom). However if there is a problem with recognizing, we could use also another icon from Osmic (https://github.com/gmgeo/osmic/blob/master/nature/spring-14.svg): ![spring-14](https://user-images.githubusercontent.com/5439713/47258448-89b28e80-d49b-11e8-9c72-250981571a34.png) I like it less, but it's still perfectly acceptable for me - and maybe @Tomasz-W could make some other design.\r\n\r\n@Tomasz-W I was worried that thinner outline will make it harder to spot - look like the \"s\" on the grass looks like with smaller outline. I just made the outline to be a bit blue instead of pure white to make it less aggressive. This is natural feature, which is typically in the outdoor, so I assume that visibility is important and should be highlighted.\r\n\r\nFurther comments and ideas?"}}
{"actor":{"display_login":"kocio-pl"}}