{"action":"closed","number":9467,"pull_request":{"url":"https://api.github.com/repos/kubernetes/website/pulls/9467","id":200591566,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNTkxNTY2","html_url":"https://github.com/kubernetes/website/pull/9467","diff_url":"https://github.com/kubernetes/website/pull/9467.diff","patch_url":"https://github.com/kubernetes/website/pull/9467.patch","issue_url":"https://api.github.com/repos/kubernetes/website/issues/9467","number":9467,"state":"closed","locked":false,"title":"Improve examples test","user":{"login":"tengqm","id":5094756,"node_id":"MDQ6VXNlcjUwOTQ3NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/5094756?v=4","gravatar_id":"","url":"https://api.github.com/users/tengqm","html_url":"https://github.com/tengqm","followers_url":"https://api.github.com/users/tengqm/followers","following_url":"https://api.github.com/users/tengqm/following{/other_user}","gists_url":"https://api.github.com/users/tengqm/gists{/gist_id}","starred_url":"https://api.github.com/users/tengqm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tengqm/subscriptions","organizations_url":"https://api.github.com/users/tengqm/orgs","repos_url":"https://api.github.com/users/tengqm/repos","events_url":"https://api.github.com/users/tengqm/events{/privacy}","received_events_url":"https://api.github.com/users/tengqm/received_events","type":"User","site_admin":false},"body":"This PR moves the examples test to where it belongs and also include the\r\nfollowing improvements:\r\n\r\n- Removed test cases defined for non-existent files;\r\n- Add guard against ineffective tests against missing files;\r\n- Remove the special case for scheduler-policy-config which is no longer\r\n  an example, the dependency on the related go module is thus\r\n  eliminated;\r\n- Updated the .tavis.yml file to use the new test case: the instruction\r\n  sequence is adjusted to ensure the correct version of kubernetes is\r\n  fully prepared before we do `go get -v -t`.\r\n- The examples_test.go is formatted using `gofmt`;\r\n- Verbose output during test has been added.\r\n\r\nRelated: #9285","created_at":"2018-07-11T05:38:38Z","updated_at":"2018-07-11T15:43:26Z","closed_at":"2018-07-11T15:43:26Z","merged_at":"2018-07-11T15:43:26Z","merge_commit_sha":"6c80860a75137c225f7d94a56e4987967048f7c3","assignee":{"login":"steveperry-53","id":13792782,"node_id":"MDQ6VXNlcjEzNzkyNzgy","avatar_url":"https://avatars2.githubusercontent.com/u/13792782?v=4","gravatar_id":"","url":"https://api.github.com/users/steveperry-53","html_url":"https://github.com/steveperry-53","followers_url":"https://api.github.com/users/steveperry-53/followers","following_url":"https://api.github.com/users/steveperry-53/following{/other_user}","gists_url":"https://api.github.com/users/steveperry-53/gists{/gist_id}","starred_url":"https://api.github.com/users/steveperry-53/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveperry-53/subscriptions","organizations_url":"https://api.github.com/users/steveperry-53/orgs","repos_url":"https://api.github.com/users/steveperry-53/repos","events_url":"https://api.github.com/users/steveperry-53/events{/privacy}","received_events_url":"https://api.github.com/users/steveperry-53/received_events","type":"User","site_admin":false},"assignees":[{"login":"steveperry-53","id":13792782,"node_id":"MDQ6VXNlcjEzNzkyNzgy","avatar_url":"https://avatars2.githubusercontent.com/u/13792782?v=4","gravatar_id":"","url":"https://api.github.com/users/steveperry-53","html_url":"https://github.com/steveperry-53","followers_url":"https://api.github.com/users/steveperry-53/followers","following_url":"https://api.github.com/users/steveperry-53/following{/other_user}","gists_url":"https://api.github.com/users/steveperry-53/gists{/gist_id}","starred_url":"https://api.github.com/users/steveperry-53/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveperry-53/subscriptions","organizations_url":"https://api.github.com/users/steveperry-53/orgs","repos_url":"https://api.github.com/users/steveperry-53/repos","events_url":"https://api.github.com/users/steveperry-53/events{/privacy}","received_events_url":"https://api.github.com/users/steveperry-53/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"xiangpengzhao","id":15881573,"node_id":"MDQ6VXNlcjE1ODgxNTcz","avatar_url":"https://avatars0.githubusercontent.com/u/15881573?v=4","gravatar_id":"","url":"https://api.github.com/users/xiangpengzhao","html_url":"https://github.com/xiangpengzhao","followers_url":"https://api.github.com/users/xiangpengzhao/followers","following_url":"https://api.github.com/users/xiangpengzhao/following{/other_user}","gists_url":"https://api.github.com/users/xiangpengzhao/gists{/gist_id}","starred_url":"https://api.github.com/users/xiangpengzhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiangpengzhao/subscriptions","organizations_url":"https://api.github.com/users/xiangpengzhao/orgs","repos_url":"https://api.github.com/users/xiangpengzhao/repos","events_url":"https://api.github.com/users/xiangpengzhao/events{/privacy}","received_events_url":"https://api.github.com/users/xiangpengzhao/received_events","type":"User","site_admin":false},{"login":"Rajakavitha1","id":37059749,"node_id":"MDQ6VXNlcjM3MDU5NzQ5","avatar_url":"https://avatars2.githubusercontent.com/u/37059749?v=4","gravatar_id":"","url":"https://api.github.com/users/Rajakavitha1","html_url":"https://github.com/Rajakavitha1","followers_url":"https://api.github.com/users/Rajakavitha1/followers","following_url":"https://api.github.com/users/Rajakavitha1/following{/other_user}","gists_url":"https://api.github.com/users/Rajakavitha1/gists{/gist_id}","starred_url":"https://api.github.com/users/Rajakavitha1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rajakavitha1/subscriptions","organizations_url":"https://api.github.com/users/Rajakavitha1/orgs","repos_url":"https://api.github.com/users/Rajakavitha1/repos","events_url":"https://api.github.com/users/Rajakavitha1/events{/privacy}","received_events_url":"https://api.github.com/users/Rajakavitha1/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":764240459,"node_id":"MDU6TGFiZWw3NjQyNDA0NTk=","url":"https://api.github.com/repos/kubernetes/website/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":484571291,"node_id":"MDU6TGFiZWw0ODQ1NzEyOTE=","url":"https://api.github.com/repos/kubernetes/website/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":724216403,"node_id":"MDU6TGFiZWw3MjQyMTY0MDM=","url":"https://api.github.com/repos/kubernetes/website/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":679457866,"node_id":"MDU6TGFiZWw2Nzk0NTc4NjY=","url":"https://api.github.com/repos/kubernetes/website/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/website/pulls/9467/commits","review_comments_url":"https://api.github.com/repos/kubernetes/website/pulls/9467/comments","review_comment_url":"https://api.github.com/repos/kubernetes/website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/website/issues/9467/comments","statuses_url":"https://api.github.com/repos/kubernetes/website/statuses/34e05a475b8e78627da1befc995c07045ee0d19f","head":{"label":"tengqm:improve-examples-test","ref":"improve-examples-test","sha":"34e05a475b8e78627da1befc995c07045ee0d19f","user":{"login":"tengqm","id":5094756,"node_id":"MDQ6VXNlcjUwOTQ3NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/5094756?v=4","gravatar_id":"","url":"https://api.github.com/users/tengqm","html_url":"https://github.com/tengqm","followers_url":"https://api.github.com/users/tengqm/followers","following_url":"https://api.github.com/users/tengqm/following{/other_user}","gists_url":"https://api.github.com/users/tengqm/gists{/gist_id}","starred_url":"https://api.github.com/users/tengqm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tengqm/subscriptions","organizations_url":"https://api.github.com/users/tengqm/orgs","repos_url":"https://api.github.com/users/tengqm/repos","events_url":"https://api.github.com/users/tengqm/events{/privacy}","received_events_url":"https://api.github.com/users/tengqm/received_events","type":"User","site_admin":false},"repo":{"id":93366860,"node_id":"MDEwOlJlcG9zaXRvcnk5MzM2Njg2MA==","name":"website","full_name":"tengqm/website","owner":{"login":"tengqm","id":5094756,"node_id":"MDQ6VXNlcjUwOTQ3NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/5094756?v=4","gravatar_id":"","url":"https://api.github.com/users/tengqm","html_url":"https://github.com/tengqm","followers_url":"https://api.github.com/users/tengqm/followers","following_url":"https://api.github.com/users/tengqm/following{/other_user}","gists_url":"https://api.github.com/users/tengqm/gists{/gist_id}","starred_url":"https://api.github.com/users/tengqm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tengqm/subscriptions","organizations_url":"https://api.github.com/users/tengqm/orgs","repos_url":"https://api.github.com/users/tengqm/repos","events_url":"https://api.github.com/users/tengqm/events{/privacy}","received_events_url":"https://api.github.com/users/tengqm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tengqm/website","description":"Kubernetes website and documentation repo: ","fork":true,"url":"https://api.github.com/repos/tengqm/website","forks_url":"https://api.github.com/repos/tengqm/website/forks","keys_url":"https://api.github.com/repos/tengqm/website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tengqm/website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tengqm/website/teams","hooks_url":"https://api.github.com/repos/tengqm/website/hooks","issue_events_url":"https://api.github.com/repos/tengqm/website/issues/events{/number}","events_url":"https://api.github.com/repos/tengqm/website/events","assignees_url":"https://api.github.com/repos/tengqm/website/assignees{/user}","branches_url":"https://api.github.com/repos/tengqm/website/branches{/branch}","tags_url":"https://api.github.com/repos/tengqm/website/tags","blobs_url":"https://api.github.com/repos/tengqm/website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tengqm/website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tengqm/website/git/refs{/sha}","trees_url":"https://api.github.com/repos/tengqm/website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tengqm/website/statuses/{sha}","languages_url":"https://api.github.com/repos/tengqm/website/languages","stargazers_url":"https://api.github.com/repos/tengqm/website/stargazers","contributors_url":"https://api.github.com/repos/tengqm/website/contributors","subscribers_url":"https://api.github.com/repos/tengqm/website/subscribers","subscription_url":"https://api.github.com/repos/tengqm/website/subscription","commits_url":"https://api.github.com/repos/tengqm/website/commits{/sha}","git_commits_url":"https://api.github.com/repos/tengqm/website/git/commits{/sha}","comments_url":"https://api.github.com/repos/tengqm/website/comments{/number}","issue_comment_url":"https://api.github.com/repos/tengqm/website/issues/comments{/number}","contents_url":"https://api.github.com/repos/tengqm/website/contents/{+path}","compare_url":"https://api.github.com/repos/tengqm/website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tengqm/website/merges","archive_url":"https://api.github.com/repos/tengqm/website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tengqm/website/downloads","issues_url":"https://api.github.com/repos/tengqm/website/issues{/number}","pulls_url":"https://api.github.com/repos/tengqm/website/pulls{/number}","milestones_url":"https://api.github.com/repos/tengqm/website/milestones{/number}","notifications_url":"https://api.github.com/repos/tengqm/website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tengqm/website/labels{/name}","releases_url":"https://api.github.com/repos/tengqm/website/releases{/id}","deployments_url":"https://api.github.com/repos/tengqm/website/deployments","created_at":"2017-06-05T05:04:14Z","updated_at":"2018-07-11T01:50:17Z","pushed_at":"2018-07-11T05:43:09Z","git_url":"git://github.com/tengqm/website.git","ssh_url":"git@github.com:tengqm/website.git","clone_url":"https://github.com/tengqm/website.git","svn_url":"https://github.com/tengqm/website","homepage":"https://kubernetes.github.io","size":105510,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0","node_id":"MDc6TGljZW5zZTI1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"6632f380f1f3ed5c4e4fd66ddd7f4919a905a92d","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":51478266,"node_id":"MDEwOlJlcG9zaXRvcnk1MTQ3ODI2Ng==","name":"website","full_name":"kubernetes/website","owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/website","description":"Kubernetes website and documentation repo: ","fork":false,"url":"https://api.github.com/repos/kubernetes/website","forks_url":"https://api.github.com/repos/kubernetes/website/forks","keys_url":"https://api.github.com/repos/kubernetes/website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/website/teams","hooks_url":"https://api.github.com/repos/kubernetes/website/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/website/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/website/events","assignees_url":"https://api.github.com/repos/kubernetes/website/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/website/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/website/tags","blobs_url":"https://api.github.com/repos/kubernetes/website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/website/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/website/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/website/languages","stargazers_url":"https://api.github.com/repos/kubernetes/website/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/website/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/website/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/website/subscription","commits_url":"https://api.github.com/repos/kubernetes/website/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/website/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/website/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/website/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/website/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/website/merges","archive_url":"https://api.github.com/repos/kubernetes/website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/website/downloads","issues_url":"https://api.github.com/repos/kubernetes/website/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/website/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/website/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/website/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/website/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/website/deployments","created_at":"2016-02-10T22:46:48Z","updated_at":"2018-07-11T15:17:53Z","pushed_at":"2018-07-11T15:43:26Z","git_url":"git://github.com/kubernetes/website.git","ssh_url":"git@github.com:kubernetes/website.git","clone_url":"https://github.com/kubernetes/website.git","svn_url":"https://github.com/kubernetes/website","homepage":"https://kubernetes.io","size":136939,"stargazers_count":579,"watchers_count":579,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2849,"mirror_url":null,"archived":false,"open_issues_count":494,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0","node_id":"MDc6TGljZW5zZTI1"},"forks":2849,"open_issues":494,"watchers":579,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/website/pulls/9467"},"html":{"href":"https://github.com/kubernetes/website/pull/9467"},"issue":{"href":"https://api.github.com/repos/kubernetes/website/issues/9467"},"comments":{"href":"https://api.github.com/repos/kubernetes/website/issues/9467/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/website/pulls/9467/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/website/pulls/9467/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/website/statuses/34e05a475b8e78627da1befc995c07045ee0d19f"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":69,"deletions":86,"changed_files":4}}
{"actor":{"display_login":"k8s-ci-robot"}}