{"action":"created","comment":{"url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments/186818057","pull_request_review_id":118473202,"id":186818057,"diff_hunk":"@@ -801,7 +803,10 @@ def job_destination(self):\n \n         :returns: ``JobDestination``\n         \"\"\"\n-        return self.job_runner_mapper.get_job_destination(self.params)\n+        dest = self.job_runner_mapper.get_job_destination(self.params)\n+        if self.dataset_path_rewriter is None:\n+            self.dataset_path_rewriter = self._job_dataset_path_rewriter(self.working_directory)\n+        return dest","path":"lib/galaxy/jobs/__init__.py","position":19,"original_position":19,"commit_id":"a1c58a708829d79859426ecb7c39b5c5f69ad735","original_commit_id":"a1c58a708829d79859426ecb7c39b5c5f69ad735","user":{"login":"nsoranzo","id":4924623,"avatar_url":"https://avatars2.githubusercontent.com/u/4924623?v=4","gravatar_id":"","url":"https://api.github.com/users/nsoranzo","html_url":"https://github.com/nsoranzo","followers_url":"https://api.github.com/users/nsoranzo/followers","following_url":"https://api.github.com/users/nsoranzo/following{/other_user}","gists_url":"https://api.github.com/users/nsoranzo/gists{/gist_id}","starred_url":"https://api.github.com/users/nsoranzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsoranzo/subscriptions","organizations_url":"https://api.github.com/users/nsoranzo/orgs","repos_url":"https://api.github.com/users/nsoranzo/repos","events_url":"https://api.github.com/users/nsoranzo/events{/privacy}","received_events_url":"https://api.github.com/users/nsoranzo/received_events","type":"User","site_admin":false},"body":"Are we sure that `self.dataset_path_rewriter` is never used before `self.job_destination` (e.g. in the `TaskWrapper` subclass)?\r\nAlternatively I think we can move its initialisation right after `self.job_runner_mapper.cached_job_destination = JobDestination(from_job=job)` around line 728 above.","created_at":"2018-05-08T18:08:02Z","updated_at":"2018-05-08T18:08:02Z","html_url":"https://github.com/galaxyproject/galaxy/pull/6087#discussion_r186818057","pull_request_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/6087","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments/186818057"},"html":{"href":"https://github.com/galaxyproject/galaxy/pull/6087#discussion_r186818057"},"pull_request":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/6087"}}},"pull_request":{"url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/6087","id":186645813,"html_url":"https://github.com/galaxyproject/galaxy/pull/6087","diff_url":"https://github.com/galaxyproject/galaxy/pull/6087.diff","patch_url":"https://github.com/galaxyproject/galaxy/pull/6087.patch","issue_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/6087","number":6087,"state":"open","locked":false,"title":"Fix JobWrapper.get_destination_configuration() so that it actually checks the JobDestination params","user":{"login":"natefoo","id":286969,"avatar_url":"https://avatars2.githubusercontent.com/u/286969?v=4","gravatar_id":"","url":"https://api.github.com/users/natefoo","html_url":"https://github.com/natefoo","followers_url":"https://api.github.com/users/natefoo/followers","following_url":"https://api.github.com/users/natefoo/following{/other_user}","gists_url":"https://api.github.com/users/natefoo/gists{/gist_id}","starred_url":"https://api.github.com/users/natefoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natefoo/subscriptions","organizations_url":"https://api.github.com/users/natefoo/orgs","repos_url":"https://api.github.com/users/natefoo/repos","events_url":"https://api.github.com/users/natefoo/events{/privacy}","received_events_url":"https://api.github.com/users/natefoo/received_events","type":"User","site_admin":false},"body":"I believe this was the original intent, but I could be wrong. Currently, when this method is called it only checks the persisted `destination_params` on the `Job` object and falls back to the app config. But I assume it should also be looking at the job destination's params. Because the params are persisted to the `Job` fairly late, you can't really use destination params for things like `outputs_to_working_directory` as intended.\r\n\r\nWith this change, it will now check the persisted params, followed by the destination params, and finally, the app config.","created_at":"2018-05-08T14:06:24Z","updated_at":"2018-05-08T18:08:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55b17db3c0bc941025545995e5f079d5ff18c1bd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":276558748,"url":"https://api.github.com/repos/galaxyproject/galaxy/labels/area/jobs","name":"area/jobs","color":"006b75","default":false},{"id":180024669,"url":"https://api.github.com/repos/galaxyproject/galaxy/labels/kind/bug","name":"kind/bug","color":"84b6eb","default":false},{"id":276566862,"url":"https://api.github.com/repos/galaxyproject/galaxy/labels/status/review","name":"status/review","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/galaxyproject/galaxy/milestones/11","html_url":"https://github.com/galaxyproject/galaxy/milestone/11","labels_url":"https://api.github.com/repos/galaxyproject/galaxy/milestones/11/labels","id":3064200,"number":11,"title":"18.09","description":"","creator":{"login":"martenson","id":1814954,"avatar_url":"https://avatars2.githubusercontent.com/u/1814954?v=4","gravatar_id":"","url":"https://api.github.com/users/martenson","html_url":"https://github.com/martenson","followers_url":"https://api.github.com/users/martenson/followers","following_url":"https://api.github.com/users/martenson/following{/other_user}","gists_url":"https://api.github.com/users/martenson/gists{/gist_id}","starred_url":"https://api.github.com/users/martenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martenson/subscriptions","organizations_url":"https://api.github.com/users/martenson/orgs","repos_url":"https://api.github.com/users/martenson/repos","events_url":"https://api.github.com/users/martenson/events{/privacy}","received_events_url":"https://api.github.com/users/martenson/received_events","type":"User","site_admin":false},"open_issues":53,"closed_issues":16,"state":"open","created_at":"2018-01-25T16:03:47Z","updated_at":"2018-05-08T15:05:27Z","due_on":"2018-09-01T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/6087/commits","review_comments_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/6087/comments","review_comment_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/6087/comments","statuses_url":"https://api.github.com/repos/galaxyproject/galaxy/statuses/a1c58a708829d79859426ecb7c39b5c5f69ad735","head":{"label":"natefoo:job-dest-config-fix","ref":"job-dest-config-fix","sha":"a1c58a708829d79859426ecb7c39b5c5f69ad735","user":{"login":"natefoo","id":286969,"avatar_url":"https://avatars2.githubusercontent.com/u/286969?v=4","gravatar_id":"","url":"https://api.github.com/users/natefoo","html_url":"https://github.com/natefoo","followers_url":"https://api.github.com/users/natefoo/followers","following_url":"https://api.github.com/users/natefoo/following{/other_user}","gists_url":"https://api.github.com/users/natefoo/gists{/gist_id}","starred_url":"https://api.github.com/users/natefoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natefoo/subscriptions","organizations_url":"https://api.github.com/users/natefoo/orgs","repos_url":"https://api.github.com/users/natefoo/repos","events_url":"https://api.github.com/users/natefoo/events{/privacy}","received_events_url":"https://api.github.com/users/natefoo/received_events","type":"User","site_admin":false},"repo":{"id":31212836,"name":"galaxy","full_name":"natefoo/galaxy","owner":{"login":"natefoo","id":286969,"avatar_url":"https://avatars2.githubusercontent.com/u/286969?v=4","gravatar_id":"","url":"https://api.github.com/users/natefoo","html_url":"https://github.com/natefoo","followers_url":"https://api.github.com/users/natefoo/followers","following_url":"https://api.github.com/users/natefoo/following{/other_user}","gists_url":"https://api.github.com/users/natefoo/gists{/gist_id}","starred_url":"https://api.github.com/users/natefoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natefoo/subscriptions","organizations_url":"https://api.github.com/users/natefoo/orgs","repos_url":"https://api.github.com/users/natefoo/repos","events_url":"https://api.github.com/users/natefoo/events{/privacy}","received_events_url":"https://api.github.com/users/natefoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/natefoo/galaxy","description":"Galaxy","fork":true,"url":"https://api.github.com/repos/natefoo/galaxy","forks_url":"https://api.github.com/repos/natefoo/galaxy/forks","keys_url":"https://api.github.com/repos/natefoo/galaxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/natefoo/galaxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/natefoo/galaxy/teams","hooks_url":"https://api.github.com/repos/natefoo/galaxy/hooks","issue_events_url":"https://api.github.com/repos/natefoo/galaxy/issues/events{/number}","events_url":"https://api.github.com/repos/natefoo/galaxy/events","assignees_url":"https://api.github.com/repos/natefoo/galaxy/assignees{/user}","branches_url":"https://api.github.com/repos/natefoo/galaxy/branches{/branch}","tags_url":"https://api.github.com/repos/natefoo/galaxy/tags","blobs_url":"https://api.github.com/repos/natefoo/galaxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/natefoo/galaxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/natefoo/galaxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/natefoo/galaxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/natefoo/galaxy/statuses/{sha}","languages_url":"https://api.github.com/repos/natefoo/galaxy/languages","stargazers_url":"https://api.github.com/repos/natefoo/galaxy/stargazers","contributors_url":"https://api.github.com/repos/natefoo/galaxy/contributors","subscribers_url":"https://api.github.com/repos/natefoo/galaxy/subscribers","subscription_url":"https://api.github.com/repos/natefoo/galaxy/subscription","commits_url":"https://api.github.com/repos/natefoo/galaxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/natefoo/galaxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/natefoo/galaxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/natefoo/galaxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/natefoo/galaxy/contents/{+path}","compare_url":"https://api.github.com/repos/natefoo/galaxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/natefoo/galaxy/merges","archive_url":"https://api.github.com/repos/natefoo/galaxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/natefoo/galaxy/downloads","issues_url":"https://api.github.com/repos/natefoo/galaxy/issues{/number}","pulls_url":"https://api.github.com/repos/natefoo/galaxy/pulls{/number}","milestones_url":"https://api.github.com/repos/natefoo/galaxy/milestones{/number}","notifications_url":"https://api.github.com/repos/natefoo/galaxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/natefoo/galaxy/labels{/name}","releases_url":"https://api.github.com/repos/natefoo/galaxy/releases{/id}","deployments_url":"https://api.github.com/repos/natefoo/galaxy/deployments","created_at":"2015-02-23T15:01:46Z","updated_at":"2018-05-07T16:50:19Z","pushed_at":"2018-05-08T17:56:36Z","git_url":"git://github.com/natefoo/galaxy.git","ssh_url":"git@github.com:natefoo/galaxy.git","clone_url":"https://github.com/natefoo/galaxy.git","svn_url":"https://github.com/natefoo/galaxy","homepage":"http://galaxyproject.org","size":444274,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":0,"watchers":1,"default_branch":"dev"}},"base":{"label":"galaxyproject:dev","ref":"dev","sha":"c67c4b4b82dd4280e9fcef4003a9956c6c0ca062","user":{"login":"galaxyproject","id":7937847,"avatar_url":"https://avatars3.githubusercontent.com/u/7937847?v=4","gravatar_id":"","url":"https://api.github.com/users/galaxyproject","html_url":"https://github.com/galaxyproject","followers_url":"https://api.github.com/users/galaxyproject/followers","following_url":"https://api.github.com/users/galaxyproject/following{/other_user}","gists_url":"https://api.github.com/users/galaxyproject/gists{/gist_id}","starred_url":"https://api.github.com/users/galaxyproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galaxyproject/subscriptions","organizations_url":"https://api.github.com/users/galaxyproject/orgs","repos_url":"https://api.github.com/users/galaxyproject/repos","events_url":"https://api.github.com/users/galaxyproject/events{/privacy}","received_events_url":"https://api.github.com/users/galaxyproject/received_events","type":"Organization","site_admin":false},"repo":{"id":31211061,"name":"galaxy","full_name":"galaxyproject/galaxy","owner":{"login":"galaxyproject","id":7937847,"avatar_url":"https://avatars3.githubusercontent.com/u/7937847?v=4","gravatar_id":"","url":"https://api.github.com/users/galaxyproject","html_url":"https://github.com/galaxyproject","followers_url":"https://api.github.com/users/galaxyproject/followers","following_url":"https://api.github.com/users/galaxyproject/following{/other_user}","gists_url":"https://api.github.com/users/galaxyproject/gists{/gist_id}","starred_url":"https://api.github.com/users/galaxyproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galaxyproject/subscriptions","organizations_url":"https://api.github.com/users/galaxyproject/orgs","repos_url":"https://api.github.com/users/galaxyproject/repos","events_url":"https://api.github.com/users/galaxyproject/events{/privacy}","received_events_url":"https://api.github.com/users/galaxyproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/galaxyproject/galaxy","description":"Data intensive science for everyone.","fork":false,"url":"https://api.github.com/repos/galaxyproject/galaxy","forks_url":"https://api.github.com/repos/galaxyproject/galaxy/forks","keys_url":"https://api.github.com/repos/galaxyproject/galaxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/galaxyproject/galaxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/galaxyproject/galaxy/teams","hooks_url":"https://api.github.com/repos/galaxyproject/galaxy/hooks","issue_events_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/events{/number}","events_url":"https://api.github.com/repos/galaxyproject/galaxy/events","assignees_url":"https://api.github.com/repos/galaxyproject/galaxy/assignees{/user}","branches_url":"https://api.github.com/repos/galaxyproject/galaxy/branches{/branch}","tags_url":"https://api.github.com/repos/galaxyproject/galaxy/tags","blobs_url":"https://api.github.com/repos/galaxyproject/galaxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/galaxyproject/galaxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/galaxyproject/galaxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/galaxyproject/galaxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/galaxyproject/galaxy/statuses/{sha}","languages_url":"https://api.github.com/repos/galaxyproject/galaxy/languages","stargazers_url":"https://api.github.com/repos/galaxyproject/galaxy/stargazers","contributors_url":"https://api.github.com/repos/galaxyproject/galaxy/contributors","subscribers_url":"https://api.github.com/repos/galaxyproject/galaxy/subscribers","subscription_url":"https://api.github.com/repos/galaxyproject/galaxy/subscription","commits_url":"https://api.github.com/repos/galaxyproject/galaxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/galaxyproject/galaxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/galaxyproject/galaxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/galaxyproject/galaxy/contents/{+path}","compare_url":"https://api.github.com/repos/galaxyproject/galaxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/galaxyproject/galaxy/merges","archive_url":"https://api.github.com/repos/galaxyproject/galaxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/galaxyproject/galaxy/downloads","issues_url":"https://api.github.com/repos/galaxyproject/galaxy/issues{/number}","pulls_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls{/number}","milestones_url":"https://api.github.com/repos/galaxyproject/galaxy/milestones{/number}","notifications_url":"https://api.github.com/repos/galaxyproject/galaxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/galaxyproject/galaxy/labels{/name}","releases_url":"https://api.github.com/repos/galaxyproject/galaxy/releases{/id}","deployments_url":"https://api.github.com/repos/galaxyproject/galaxy/deployments","created_at":"2015-02-23T14:18:06Z","updated_at":"2018-05-08T16:52:18Z","pushed_at":"2018-05-08T17:55:54Z","git_url":"git://github.com/galaxyproject/galaxy.git","ssh_url":"git@github.com:galaxyproject/galaxy.git","clone_url":"https://github.com/galaxyproject/galaxy.git","svn_url":"https://github.com/galaxyproject/galaxy","homepage":"https://galaxyproject.org/","size":451624,"stargazers_count":460,"watchers_count":460,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":433,"mirror_url":null,"archived":false,"open_issues_count":1116,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":433,"open_issues":1116,"watchers":460,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/6087"},"html":{"href":"https://github.com/galaxyproject/galaxy/pull/6087"},"issue":{"href":"https://api.github.com/repos/galaxyproject/galaxy/issues/6087"},"comments":{"href":"https://api.github.com/repos/galaxyproject/galaxy/issues/6087/comments"},"review_comments":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/6087/comments"},"review_comment":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/6087/commits"},"statuses":{"href":"https://api.github.com/repos/galaxyproject/galaxy/statuses/a1c58a708829d79859426ecb7c39b5c5f69ad735"}},"author_association":"OWNER"}}
{"actor":{"display_login":"nsoranzo"}}