{"action":"created","issue":{"url":"https://api.github.com/repos/grpc/grpc/issues/14448","repository_url":"https://api.github.com/repos/grpc/grpc","labels_url":"https://api.github.com/repos/grpc/grpc/issues/14448/labels{/name}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/14448/comments","events_url":"https://api.github.com/repos/grpc/grpc/issues/14448/events","html_url":"https://github.com/grpc/grpc/pull/14448","id":297877521,"number":14448,"title":"Remove Python background poller thread","user":{"login":"kpayson64","id":18316330,"avatar_url":"https://avatars2.githubusercontent.com/u/18316330?v=4","gravatar_id":"","url":"https://api.github.com/users/kpayson64","html_url":"https://github.com/kpayson64","followers_url":"https://api.github.com/users/kpayson64/followers","following_url":"https://api.github.com/users/kpayson64/following{/other_user}","gists_url":"https://api.github.com/users/kpayson64/gists{/gist_id}","starred_url":"https://api.github.com/users/kpayson64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpayson64/subscriptions","organizations_url":"https://api.github.com/users/kpayson64/orgs","repos_url":"https://api.github.com/users/kpayson64/repos","events_url":"https://api.github.com/users/kpayson64/events{/privacy}","received_events_url":"https://api.github.com/users/kpayson64/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-02-16T18:24:57Z","updated_at":"2018-02-21T01:24:09Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/14448","html_url":"https://github.com/grpc/grpc/pull/14448","diff_url":"https://github.com/grpc/grpc/pull/14448.diff","patch_url":"https://github.com/grpc/grpc/pull/14448.patch"},"body":"This thread is apparently no longer required because a background polling thread gets created in c-core.\r\n\r\n_reconnect_test.py still passes with its removal."},"comment":{"url":"https://api.github.com/repos/grpc/grpc/issues/comments/367181467","html_url":"https://github.com/grpc/grpc/pull/14448#issuecomment-367181467","issue_url":"https://api.github.com/repos/grpc/grpc/issues/14448","id":367181467,"user":{"login":"kpayson64","id":18316330,"avatar_url":"https://avatars2.githubusercontent.com/u/18316330?v=4","gravatar_id":"","url":"https://api.github.com/users/kpayson64","html_url":"https://github.com/kpayson64","followers_url":"https://api.github.com/users/kpayson64/followers","following_url":"https://api.github.com/users/kpayson64/following{/other_user}","gists_url":"https://api.github.com/users/kpayson64/gists{/gist_id}","starred_url":"https://api.github.com/users/kpayson64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpayson64/subscriptions","organizations_url":"https://api.github.com/users/kpayson64/orgs","repos_url":"https://api.github.com/users/kpayson64/repos","events_url":"https://api.github.com/users/kpayson64/events{/privacy}","received_events_url":"https://api.github.com/users/kpayson64/received_events","type":"User","site_admin":false},"created_at":"2018-02-21T01:24:09Z","updated_at":"2018-02-21T01:24:09Z","author_association":"CONTRIBUTOR","body":"It appears the background poller only solves this issue for ```epoll1```.\r\n```\r\n(py27)kpayson@kpayson0:~/grpc$ GRPC_POLL_STRATEGY=epoll1 python src/python/grpcio_tests/tests/unit/_reconnect_test.py\r\ntest_reconnect (__main__.ReconnectTest) ... ok\r\n\r\n----------------------------------------------------------------------\r\nRan 1 test in 0.008s\r\n\r\nOK\r\n(py27)kpayson@kpayson0:~/grpc$ GRPC_POLL_STRATEGY=epollsig python src/python/grpcio_tests/tests/unit/_reconnect_test.py\r\ntest_reconnect (__main__.ReconnectTest) ... ERROR\r\n\r\n======================================================================\r\nERROR: test_reconnect (__main__.ReconnectTest)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"src/python/grpcio_tests/tests/unit/_reconnect_test.py\", line 94, in test_reconnect\r\n    self.assertEqual(_RESPONSE, multi_callable(_REQUEST))\r\n  File \"/usr/local/google/home/kpayson/grpc2/py27/local/lib/python2.7/site-packages/grpc/_channel.py\", line 487, in __call__\r\n    return _end_unary_response_blocking(state, call, False, deadline)\r\n  File \"/usr/local/google/home/kpayson/grpc2/py27/local/lib/python2.7/site-packages/grpc/_channel.py\", line 437, in _end_unary_response_blocking\r\n    raise _Rendezvous(state, None, None, deadline)\r\n_Rendezvous: <_Rendezvous of RPC that terminated with (StatusCode.UNAVAILABLE, Socket closed)>\r\n\r\n----------------------------------------------------------------------\r\nRan 1 test in 0.011s\r\n\r\nFAILED (errors=1)\r\n(py27)kpayson@kpayson0:~/grpc$ GRPC_POLL_STRATEGY=poll python src/python/grpcio_tests/tests/unit/_reconnect_test.py\r\ntest_reconnect (__main__.ReconnectTest) ... ERROR\r\n\r\n======================================================================\r\nERROR: test_reconnect (__main__.ReconnectTest)\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"src/python/grpcio_tests/tests/unit/_reconnect_test.py\", line 94, in test_reconnect\r\n    self.assertEqual(_RESPONSE, multi_callable(_REQUEST))\r\n  File \"/usr/local/google/home/kpayson/grpc2/py27/local/lib/python2.7/site-packages/grpc/_channel.py\", line 487, in __call__\r\n    return _end_unary_response_blocking(state, call, False, deadline)\r\n  File \"/usr/local/google/home/kpayson/grpc2/py27/local/lib/python2.7/site-packages/grpc/_channel.py\", line 437, in _end_unary_response_blocking\r\n    raise _Rendezvous(state, None, None, deadline)\r\n_Rendezvous: <_Rendezvous of RPC that terminated with (StatusCode.UNAVAILABLE, Socket closed)>\r\n\r\n----------------------------------------------------------------------\r\nRan 1 test in 0.009s\r\n\r\nFAILED (errors=1)\r\n```\r\n(I also tried epollex internally and it failed)\r\n\r\n@sreecha Do you have any ideas why this might be?"}}
{"actor":{"display_login":"kpayson64"}}