{"action":"created","issue":{"url":"https://api.github.com/repos/coq/coq/issues/8773","repository_url":"https://api.github.com/repos/coq/coq","labels_url":"https://api.github.com/repos/coq/coq/issues/8773/labels{/name}","comments_url":"https://api.github.com/repos/coq/coq/issues/8773/comments","events_url":"https://api.github.com/repos/coq/coq/issues/8773/events","html_url":"https://github.com/coq/coq/pull/8773","id":371762675,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MTM4MTY0","number":8773,"title":"[checker] Refactor by sharing code with the kernel","user":{"login":"maximedenes","id":647105,"node_id":"MDQ6VXNlcjY0NzEwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/647105?v=4","gravatar_id":"","url":"https://api.github.com/users/maximedenes","html_url":"https://github.com/maximedenes","followers_url":"https://api.github.com/users/maximedenes/followers","following_url":"https://api.github.com/users/maximedenes/following{/other_user}","gists_url":"https://api.github.com/users/maximedenes/gists{/gist_id}","starred_url":"https://api.github.com/users/maximedenes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximedenes/subscriptions","organizations_url":"https://api.github.com/users/maximedenes/orgs","repos_url":"https://api.github.com/users/maximedenes/repos","events_url":"https://api.github.com/users/maximedenes/events{/privacy}","received_events_url":"https://api.github.com/users/maximedenes/received_events","type":"User","site_admin":false},"labels":[{"id":485985791,"node_id":"MDU6TGFiZWw0ODU5ODU3OTE=","url":"https://api.github.com/repos/coq/coq/labels/kind:%20cleanup","name":"kind: cleanup","color":"3366ff","default":false},{"id":394846778,"node_id":"MDU6TGFiZWwzOTQ4NDY3Nzg=","url":"https://api.github.com/repos/coq/coq/labels/needs:%20progress","name":"needs: progress","color":"ffd062","default":false},{"id":723364316,"node_id":"MDU6TGFiZWw3MjMzNjQzMTY=","url":"https://api.github.com/repos/coq/coq/labels/part:%20checker","name":"part: checker","color":"dddddd","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":29,"created_at":"2018-10-19T00:28:11Z","updated_at":"2018-11-05T13:35:54Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/coq/coq/pulls/8773","html_url":"https://github.com/coq/coq/pull/8773","diff_url":"https://github.com/coq/coq/pull/8773.diff","patch_url":"https://github.com/coq/coq/pull/8773.patch"},"body":"For historical reasons, the checker was duplicating a lot of code of the\r\nkernel. The main differences I found were bug fixes that had not been\r\nbackported.\r\n\r\nWith this patch, the checker uses the kernel as a library to serve the\r\nsame purpose as before: validation of a `.vo` file, re-typechecking all\r\ndefinitions a posteriori.\r\n\r\nWe also rename some files from the checker so that they don't clash with\r\nkernel files.\r\n\r\nBased on #8684 [merged].\r\n\r\nEDIT: now depends on #8842 [merged] and #8870 [merged].\r\n\r\nStill TODO:\r\n- [x] Fix the Dune build\r\n- [x] Make sure we check the same things as before on modules (@ppedrot can you have a look?)\r\n- [X] Disable VM (and native) for conversions triggered by the checker\r\n- [X] Make sure the checker can't load plugins, as claimed in the manual"},"comment":{"url":"https://api.github.com/repos/coq/coq/issues/comments/435875394","html_url":"https://github.com/coq/coq/pull/8773#issuecomment-435875394","issue_url":"https://api.github.com/repos/coq/coq/issues/8773","id":435875394,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTg3NTM5NA==","user":{"login":"maximedenes","id":647105,"node_id":"MDQ6VXNlcjY0NzEwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/647105?v=4","gravatar_id":"","url":"https://api.github.com/users/maximedenes","html_url":"https://github.com/maximedenes","followers_url":"https://api.github.com/users/maximedenes/followers","following_url":"https://api.github.com/users/maximedenes/following{/other_user}","gists_url":"https://api.github.com/users/maximedenes/gists{/gist_id}","starred_url":"https://api.github.com/users/maximedenes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximedenes/subscriptions","organizations_url":"https://api.github.com/users/maximedenes/orgs","repos_url":"https://api.github.com/users/maximedenes/repos","events_url":"https://api.github.com/users/maximedenes/events{/privacy}","received_events_url":"https://api.github.com/users/maximedenes/received_events","type":"User","site_admin":false},"created_at":"2018-11-05T13:35:54Z","updated_at":"2018-11-05T13:35:54Z","author_association":"MEMBER","body":"Oh no, there is still two  FIXMEs, will address them now, sorry."}}
{"actor":{"display_login":"maximedenes"}}