{"action":"created","comment":{"url":"https://api.github.com/repos/docker/swarmkit/pulls/comments/240997195","pull_request_review_id":184152301,"id":240997195,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDk5NzE5NQ==","diff_hunk":"@@ -4,6 +4,26 @@ DOCKER_IMAGE_DIR=${GOPATH}/src/${PROJECT_ROOT}\n \n DOCKER_SWARMKIT_DELVE_PORT ?= 2345\n \n+# HOW TO USE CONTAINERIZED BUILDS:\n+#\n+# There are lots of flags that we've added to containerized builds of swarmkit,\n+# mostly to support the various swarmkit dev's workflows. These can be kind of\n+# confusing, and might feel like they require reading the makefile to fully\n+# understand. For clarity, these are the various flags and what they do:\n+#\n+# DOCKER_SWARMKIT_USE_CONTAINER: Build swarmkit inside of a docker container.\n+# DOCKER_SWARMKIT_NOMOUNT: Runs the make target without bindmounting the local\n+# \tdirectory into the container. Useful if you're, say, running tests over a\n+# \tnetwork socket. Otherwise, we'll be doing the equivalent of \n+# \t-v ~/go/src/github.com/docker/swarmkit:/go/src/github.com/docker/swarmkit\n+# DOCKER_SWARMKIT_USE_DELVE: Use the Delve debugger\n+# DOCKER_SWARMKIT_DELVE_PORT: The port for hooking up the Delve debugger\n+# DOCKER_SWARMKTI_USE_DOCKER_SYNC: uses the Docker Sync tool, which can speed\n+# \tup operations when running on Docker for Windows or Docker for Mac","path":"containerized.mk","position":19,"original_position":19,"commit_id":"c53b4aa9e901caaa6938105ea457f51cff4f41ee","original_commit_id":"c53b4aa9e901caaa6938105ea457f51cff4f41ee","user":{"login":"wk8","id":2536231,"node_id":"MDQ6VXNlcjI1MzYyMzE=","avatar_url":"https://avatars3.githubusercontent.com/u/2536231?v=4","gravatar_id":"","url":"https://api.github.com/users/wk8","html_url":"https://github.com/wk8","followers_url":"https://api.github.com/users/wk8/followers","following_url":"https://api.github.com/users/wk8/following{/other_user}","gists_url":"https://api.github.com/users/wk8/gists{/gist_id}","starred_url":"https://api.github.com/users/wk8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wk8/subscriptions","organizations_url":"https://api.github.com/users/wk8/orgs","repos_url":"https://api.github.com/users/wk8/repos","events_url":"https://api.github.com/users/wk8/events{/privacy}","received_events_url":"https://api.github.com/users/wk8/received_events","type":"User","site_admin":false},"body":"Which, actually, makes me wonder: why can't you just use docker-sync here? Should work just fine, and at least you wouldn't need to re-build your image/restart your container every time you make a change?","created_at":"2018-12-12T12:36:51Z","updated_at":"2018-12-12T12:47:10Z","html_url":"https://github.com/docker/swarmkit/pull/2792#discussion_r240997195","pull_request_url":"https://api.github.com/repos/docker/swarmkit/pulls/2792","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/comments/240997195"},"html":{"href":"https://github.com/docker/swarmkit/pull/2792#discussion_r240997195"},"pull_request":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/2792"}}},"pull_request":{"url":"https://api.github.com/repos/docker/swarmkit/pulls/2792","id":237408650,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NDA4NjUw","html_url":"https://github.com/docker/swarmkit/pull/2792","diff_url":"https://github.com/docker/swarmkit/pull/2792.diff","patch_url":"https://github.com/docker/swarmkit/pull/2792.patch","issue_url":"https://api.github.com/repos/docker/swarmkit/issues/2792","number":2792,"state":"open","locked":false,"title":"Add make option to not bindmount local dir","user":{"login":"dperny","id":2367858,"node_id":"MDQ6VXNlcjIzNjc4NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/2367858?v=4","gravatar_id":"","url":"https://api.github.com/users/dperny","html_url":"https://github.com/dperny","followers_url":"https://api.github.com/users/dperny/followers","following_url":"https://api.github.com/users/dperny/following{/other_user}","gists_url":"https://api.github.com/users/dperny/gists{/gist_id}","starred_url":"https://api.github.com/users/dperny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dperny/subscriptions","organizations_url":"https://api.github.com/users/dperny/orgs","repos_url":"https://api.github.com/users/dperny/repos","events_url":"https://api.github.com/users/dperny/events{/privacy}","received_events_url":"https://api.github.com/users/dperny/received_events","type":"User","site_admin":false},"body":"Adds a flag, DOCKER_SWARMKIT_NOMOUNT, which, when used with DOCKER_SWARMKIT_USE_CONTAINER, avoids bind mounting the local directory into the container. This is useful if you are building and running the commands over a TCP socket.\r\n\r\nAdditionally, documents the various makefile flags we have available.\r\n\r\nI did this because my local dev setup is weird. I'm running Windows Subsystem for Linux, so I can use most of my typical dev workflow on my local machine. However, I'm also using Docker for Windows, because Docker doesn't work natively in WSL. The easiest way to do this is to expose the Docker for Windows daemon on a TCP socket and point the Docker client in WSL at that TCP socket. This has the side-effect of making bind-mounting the directory in WSL not possible.\r\n\r\nI'm not entirely sure that this doesn't break the existing code path, so I was hoping @wk8 could manually ensure there's no regression in the makefile","created_at":"2018-12-10T17:43:03Z","updated_at":"2018-12-12T12:47:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e111631f0b1ddac03b38622fb6041644575cca28","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/swarmkit/pulls/2792/commits","review_comments_url":"https://api.github.com/repos/docker/swarmkit/pulls/2792/comments","review_comment_url":"https://api.github.com/repos/docker/swarmkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/swarmkit/issues/2792/comments","statuses_url":"https://api.github.com/repos/docker/swarmkit/statuses/c53b4aa9e901caaa6938105ea457f51cff4f41ee","head":{"label":"dperny:more-make-flags","ref":"more-make-flags","sha":"c53b4aa9e901caaa6938105ea457f51cff4f41ee","user":{"login":"dperny","id":2367858,"node_id":"MDQ6VXNlcjIzNjc4NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/2367858?v=4","gravatar_id":"","url":"https://api.github.com/users/dperny","html_url":"https://github.com/dperny","followers_url":"https://api.github.com/users/dperny/followers","following_url":"https://api.github.com/users/dperny/following{/other_user}","gists_url":"https://api.github.com/users/dperny/gists{/gist_id}","starred_url":"https://api.github.com/users/dperny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dperny/subscriptions","organizations_url":"https://api.github.com/users/dperny/orgs","repos_url":"https://api.github.com/users/dperny/repos","events_url":"https://api.github.com/users/dperny/events{/privacy}","received_events_url":"https://api.github.com/users/dperny/received_events","type":"User","site_admin":false},"repo":{"id":60813040,"node_id":"MDEwOlJlcG9zaXRvcnk2MDgxMzA0MA==","name":"swarmkit-1","full_name":"dperny/swarmkit-1","private":false,"owner":{"login":"dperny","id":2367858,"node_id":"MDQ6VXNlcjIzNjc4NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/2367858?v=4","gravatar_id":"","url":"https://api.github.com/users/dperny","html_url":"https://github.com/dperny","followers_url":"https://api.github.com/users/dperny/followers","following_url":"https://api.github.com/users/dperny/following{/other_user}","gists_url":"https://api.github.com/users/dperny/gists{/gist_id}","starred_url":"https://api.github.com/users/dperny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dperny/subscriptions","organizations_url":"https://api.github.com/users/dperny/orgs","repos_url":"https://api.github.com/users/dperny/repos","events_url":"https://api.github.com/users/dperny/events{/privacy}","received_events_url":"https://api.github.com/users/dperny/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dperny/swarmkit-1","description":"A toolkit for orchestrating distributed systems at any scale. It includes primitives for node discovery, raft-based consensus, task scheduling and more.","fork":true,"url":"https://api.github.com/repos/dperny/swarmkit-1","forks_url":"https://api.github.com/repos/dperny/swarmkit-1/forks","keys_url":"https://api.github.com/repos/dperny/swarmkit-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dperny/swarmkit-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dperny/swarmkit-1/teams","hooks_url":"https://api.github.com/repos/dperny/swarmkit-1/hooks","issue_events_url":"https://api.github.com/repos/dperny/swarmkit-1/issues/events{/number}","events_url":"https://api.github.com/repos/dperny/swarmkit-1/events","assignees_url":"https://api.github.com/repos/dperny/swarmkit-1/assignees{/user}","branches_url":"https://api.github.com/repos/dperny/swarmkit-1/branches{/branch}","tags_url":"https://api.github.com/repos/dperny/swarmkit-1/tags","blobs_url":"https://api.github.com/repos/dperny/swarmkit-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dperny/swarmkit-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dperny/swarmkit-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/dperny/swarmkit-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dperny/swarmkit-1/statuses/{sha}","languages_url":"https://api.github.com/repos/dperny/swarmkit-1/languages","stargazers_url":"https://api.github.com/repos/dperny/swarmkit-1/stargazers","contributors_url":"https://api.github.com/repos/dperny/swarmkit-1/contributors","subscribers_url":"https://api.github.com/repos/dperny/swarmkit-1/subscribers","subscription_url":"https://api.github.com/repos/dperny/swarmkit-1/subscription","commits_url":"https://api.github.com/repos/dperny/swarmkit-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/dperny/swarmkit-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/dperny/swarmkit-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/dperny/swarmkit-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/dperny/swarmkit-1/contents/{+path}","compare_url":"https://api.github.com/repos/dperny/swarmkit-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dperny/swarmkit-1/merges","archive_url":"https://api.github.com/repos/dperny/swarmkit-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dperny/swarmkit-1/downloads","issues_url":"https://api.github.com/repos/dperny/swarmkit-1/issues{/number}","pulls_url":"https://api.github.com/repos/dperny/swarmkit-1/pulls{/number}","milestones_url":"https://api.github.com/repos/dperny/swarmkit-1/milestones{/number}","notifications_url":"https://api.github.com/repos/dperny/swarmkit-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dperny/swarmkit-1/labels{/name}","releases_url":"https://api.github.com/repos/dperny/swarmkit-1/releases{/id}","deployments_url":"https://api.github.com/repos/dperny/swarmkit-1/deployments","created_at":"2016-06-09T23:18:00Z","updated_at":"2016-06-09T23:18:01Z","pushed_at":"2018-12-10T17:38:43Z","git_url":"git://github.com/dperny/swarmkit-1.git","ssh_url":"git@github.com:dperny/swarmkit-1.git","clone_url":"https://github.com/dperny/swarmkit-1.git","svn_url":"https://github.com/dperny/swarmkit-1","homepage":"","size":22570,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"9afd76bc07767ceb16781184e3d11ec982394178","user":{"login":"docker","id":5429470,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0Mjk0NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/5429470?v=4","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":51556828,"node_id":"MDEwOlJlcG9zaXRvcnk1MTU1NjgyOA==","name":"swarmkit","full_name":"docker/swarmkit","private":false,"owner":{"login":"docker","id":5429470,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0Mjk0NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/5429470?v=4","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/docker/swarmkit","description":"A toolkit for orchestrating distributed systems at any scale. It includes primitives for node discovery, raft-based consensus, task scheduling and more.","fork":false,"url":"https://api.github.com/repos/docker/swarmkit","forks_url":"https://api.github.com/repos/docker/swarmkit/forks","keys_url":"https://api.github.com/repos/docker/swarmkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/swarmkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/swarmkit/teams","hooks_url":"https://api.github.com/repos/docker/swarmkit/hooks","issue_events_url":"https://api.github.com/repos/docker/swarmkit/issues/events{/number}","events_url":"https://api.github.com/repos/docker/swarmkit/events","assignees_url":"https://api.github.com/repos/docker/swarmkit/assignees{/user}","branches_url":"https://api.github.com/repos/docker/swarmkit/branches{/branch}","tags_url":"https://api.github.com/repos/docker/swarmkit/tags","blobs_url":"https://api.github.com/repos/docker/swarmkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/swarmkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/swarmkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/swarmkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/swarmkit/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/swarmkit/languages","stargazers_url":"https://api.github.com/repos/docker/swarmkit/stargazers","contributors_url":"https://api.github.com/repos/docker/swarmkit/contributors","subscribers_url":"https://api.github.com/repos/docker/swarmkit/subscribers","subscription_url":"https://api.github.com/repos/docker/swarmkit/subscription","commits_url":"https://api.github.com/repos/docker/swarmkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/swarmkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/swarmkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/swarmkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/swarmkit/contents/{+path}","compare_url":"https://api.github.com/repos/docker/swarmkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/swarmkit/merges","archive_url":"https://api.github.com/repos/docker/swarmkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/swarmkit/downloads","issues_url":"https://api.github.com/repos/docker/swarmkit/issues{/number}","pulls_url":"https://api.github.com/repos/docker/swarmkit/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/swarmkit/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/swarmkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/swarmkit/labels{/name}","releases_url":"https://api.github.com/repos/docker/swarmkit/releases{/id}","deployments_url":"https://api.github.com/repos/docker/swarmkit/deployments","created_at":"2016-02-12T00:02:15Z","updated_at":"2018-12-10T02:00:42Z","pushed_at":"2018-12-12T12:45:05Z","git_url":"git://github.com/docker/swarmkit.git","ssh_url":"git@github.com:docker/swarmkit.git","clone_url":"https://github.com/docker/swarmkit.git","svn_url":"https://github.com/docker/swarmkit","homepage":"","size":22161,"stargazers_count":1921,"watchers_count":1921,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":435,"mirror_url":null,"archived":false,"open_issues_count":259,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":435,"open_issues":259,"watchers":1921,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/2792"},"html":{"href":"https://github.com/docker/swarmkit/pull/2792"},"issue":{"href":"https://api.github.com/repos/docker/swarmkit/issues/2792"},"comments":{"href":"https://api.github.com/repos/docker/swarmkit/issues/2792/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/2792/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/2792/commits"},"statuses":{"href":"https://api.github.com/repos/docker/swarmkit/statuses/c53b4aa9e901caaa6938105ea457f51cff4f41ee"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"wk8"}}