{"action":"created","issue":{"url":"https://api.github.com/repos/apache/flink/issues/5573","repository_url":"https://api.github.com/repos/apache/flink","labels_url":"https://api.github.com/repos/apache/flink/issues/5573/labels{/name}","comments_url":"https://api.github.com/repos/apache/flink/issues/5573/comments","events_url":"https://api.github.com/repos/apache/flink/issues/5573/events","html_url":"https://github.com/apache/flink/pull/5573","id":299918944,"number":5573,"title":"[FLINK-8756][Client] Support ClusterClient.getAccumulators() in RestClusterClient","user":{"login":"yanghua","id":2283778,"avatar_url":"https://avatars3.githubusercontent.com/u/2283778?v=4","gravatar_id":"","url":"https://api.github.com/users/yanghua","html_url":"https://github.com/yanghua","followers_url":"https://api.github.com/users/yanghua/followers","following_url":"https://api.github.com/users/yanghua/following{/other_user}","gists_url":"https://api.github.com/users/yanghua/gists{/gist_id}","starred_url":"https://api.github.com/users/yanghua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanghua/subscriptions","organizations_url":"https://api.github.com/users/yanghua/orgs","repos_url":"https://api.github.com/users/yanghua/repos","events_url":"https://api.github.com/users/yanghua/events{/privacy}","received_events_url":"https://api.github.com/users/yanghua/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-02-24T07:03:37Z","updated_at":"2018-02-26T07:32:55Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/5573","html_url":"https://github.com/apache/flink/pull/5573","diff_url":"https://github.com/apache/flink/pull/5573.diff","patch_url":"https://github.com/apache/flink/pull/5573.patch"},"body":"## What is the purpose of the change\r\n\r\nThis PR Support ClusterClient.getAccumulators() in RestClusterClient.\r\n\r\n## Brief change log\r\n\r\n  - *Send REST request to get `JobAccumulatorsInfo` object*\r\n  - *Use jackson's ObjectMapper convert `JobAccumulatorsInfo` object to Map*\r\n  - *Add a test method into `RestClusterClientTest` class to test the `getAccumulators` function*\r\n  - *Add a test handler to mock `JobAccumulatorsInfo` object*\r\n\r\n\r\n## Verifying this change\r\n\r\nThis change added tests and can be verified as follows:\r\n\r\n  - *Added test that validates that actual accumulators size equals we mocked in the test handler*\r\n\r\n## Does this pull request potentially affect one of the following parts:\r\n\r\n  - Dependencies (does it add or upgrade a dependency): (no)\r\n  - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)\r\n  - The serializers: (no)\r\n  - The runtime per-record code paths (performance sensitive): (no)\r\n  - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)\r\n  - The S3 file system connector: (no)\r\n\r\n## Documentation\r\n\r\n  - Does this pull request introduce a new feature? (no)\r\n  - If yes, how is the feature documented? (not documented)\r\n"},"comment":{"url":"https://api.github.com/repos/apache/flink/issues/comments/368413416","html_url":"https://github.com/apache/flink/pull/5573#issuecomment-368413416","issue_url":"https://api.github.com/repos/apache/flink/issues/5573","id":368413416,"user":{"login":"aljoscha","id":68551,"avatar_url":"https://avatars1.githubusercontent.com/u/68551?v=4","gravatar_id":"","url":"https://api.github.com/users/aljoscha","html_url":"https://github.com/aljoscha","followers_url":"https://api.github.com/users/aljoscha/followers","following_url":"https://api.github.com/users/aljoscha/following{/other_user}","gists_url":"https://api.github.com/users/aljoscha/gists{/gist_id}","starred_url":"https://api.github.com/users/aljoscha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aljoscha/subscriptions","organizations_url":"https://api.github.com/users/aljoscha/orgs","repos_url":"https://api.github.com/users/aljoscha/repos","events_url":"https://api.github.com/users/aljoscha/events{/privacy}","received_events_url":"https://api.github.com/users/aljoscha/received_events","type":"User","site_admin":false},"created_at":"2018-02-26T07:32:55Z","updated_at":"2018-02-26T07:32:55Z","author_association":"CONTRIBUTOR","body":"I think it would be good to be able to query both representations. The stringified version can be good if you want to do a quick query using a rest client. And we don't have to change the Web UI if we keep both versions."}}
{"actor":{"display_login":"aljoscha"}}