{"action":"created","issue":{"url":"https://api.github.com/repos/status-im/status-react/issues/5631","repository_url":"https://api.github.com/repos/status-im/status-react","labels_url":"https://api.github.com/repos/status-im/status-react/issues/5631/labels{/name}","comments_url":"https://api.github.com/repos/status-im/status-react/issues/5631/comments","events_url":"https://api.github.com/repos/status-im/status-react/issues/5631/events","html_url":"https://github.com/status-im/status-react/pull/5631","id":353706104,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNjgzNDQ3","number":5631,"title":"Unify login flow after account recovery","user":{"login":"mandrigin","id":466427,"node_id":"MDQ6VXNlcjQ2NjQyNw==","avatar_url":"https://avatars0.githubusercontent.com/u/466427?v=4","gravatar_id":"","url":"https://api.github.com/users/mandrigin","html_url":"https://github.com/mandrigin","followers_url":"https://api.github.com/users/mandrigin/followers","following_url":"https://api.github.com/users/mandrigin/following{/other_user}","gists_url":"https://api.github.com/users/mandrigin/gists{/gist_id}","starred_url":"https://api.github.com/users/mandrigin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandrigin/subscriptions","organizations_url":"https://api.github.com/users/mandrigin/orgs","repos_url":"https://api.github.com/users/mandrigin/repos","events_url":"https://api.github.com/users/mandrigin/events{/privacy}","received_events_url":"https://api.github.com/users/mandrigin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"mandrigin","id":466427,"node_id":"MDQ6VXNlcjQ2NjQyNw==","avatar_url":"https://avatars0.githubusercontent.com/u/466427?v=4","gravatar_id":"","url":"https://api.github.com/users/mandrigin","html_url":"https://github.com/mandrigin","followers_url":"https://api.github.com/users/mandrigin/followers","following_url":"https://api.github.com/users/mandrigin/following{/other_user}","gists_url":"https://api.github.com/users/mandrigin/gists{/gist_id}","starred_url":"https://api.github.com/users/mandrigin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandrigin/subscriptions","organizations_url":"https://api.github.com/users/mandrigin/orgs","repos_url":"https://api.github.com/users/mandrigin/repos","events_url":"https://api.github.com/users/mandrigin/events{/privacy}","received_events_url":"https://api.github.com/users/mandrigin/received_events","type":"User","site_admin":false},"assignees":[{"login":"mandrigin","id":466427,"node_id":"MDQ6VXNlcjQ2NjQyNw==","avatar_url":"https://avatars0.githubusercontent.com/u/466427?v=4","gravatar_id":"","url":"https://api.github.com/users/mandrigin","html_url":"https://github.com/mandrigin","followers_url":"https://api.github.com/users/mandrigin/followers","following_url":"https://api.github.com/users/mandrigin/following{/other_user}","gists_url":"https://api.github.com/users/mandrigin/gists{/gist_id}","starred_url":"https://api.github.com/users/mandrigin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandrigin/subscriptions","organizations_url":"https://api.github.com/users/mandrigin/orgs","repos_url":"https://api.github.com/users/mandrigin/repos","events_url":"https://api.github.com/users/mandrigin/events{/privacy}","received_events_url":"https://api.github.com/users/mandrigin/received_events","type":"User","site_admin":false},{"login":"lukaszfryc","id":7532782,"node_id":"MDQ6VXNlcjc1MzI3ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/7532782?v=4","gravatar_id":"","url":"https://api.github.com/users/lukaszfryc","html_url":"https://github.com/lukaszfryc","followers_url":"https://api.github.com/users/lukaszfryc/followers","following_url":"https://api.github.com/users/lukaszfryc/following{/other_user}","gists_url":"https://api.github.com/users/lukaszfryc/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaszfryc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaszfryc/subscriptions","organizations_url":"https://api.github.com/users/lukaszfryc/orgs","repos_url":"https://api.github.com/users/lukaszfryc/repos","events_url":"https://api.github.com/users/lukaszfryc/events{/privacy}","received_events_url":"https://api.github.com/users/lukaszfryc/received_events","type":"User","site_admin":false}],"milestone":null,"comments":12,"created_at":"2018-08-24T09:14:33Z","updated_at":"2018-08-24T11:43:45Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/status-im/status-react/pulls/5631","html_url":"https://github.com/status-im/status-react/pull/5631","diff_url":"https://github.com/status-im/status-react/pull/5631.diff","patch_url":"https://github.com/status-im/status-react/pull/5631.patch"},"body":"fixes #5286\r\n\r\n### Summary:\r\n\r\nWe had a delay to show the main screen while we are recovering account. That might lead for the node to be starting longer than this 2 seconds delay and causing all sorts of issues.\r\nThe fix is with replacing this with our typical login flow (showing the login dialog with a process indicator) right after we recovered the account. It handles node restarts gracefully.\r\n\r\nTODO\r\n- [x] use `merge-fx` instead of `dispatch-n` in the code\r\n\r\n### Steps to test:\r\n- Open Status\r\n- Create an account, switch it to the test network. Join some noisy channel to have more stuff happening.\r\n- Recover any account.\r\n\r\n<!-- (PRs will only be accepted if squashed into single commit.) -->\r\n\r\nstatus: ready <!-- Can be ready or wip -->\r\n"},"comment":{"url":"https://api.github.com/repos/status-im/status-react/issues/comments/415734881","html_url":"https://github.com/status-im/status-react/pull/5631#issuecomment-415734881","issue_url":"https://api.github.com/repos/status-im/status-react/issues/5631","id":415734881,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTczNDg4MQ==","user":{"login":"lukaszfryc","id":7532782,"node_id":"MDQ6VXNlcjc1MzI3ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/7532782?v=4","gravatar_id":"","url":"https://api.github.com/users/lukaszfryc","html_url":"https://github.com/lukaszfryc","followers_url":"https://api.github.com/users/lukaszfryc/followers","following_url":"https://api.github.com/users/lukaszfryc/following{/other_user}","gists_url":"https://api.github.com/users/lukaszfryc/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaszfryc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaszfryc/subscriptions","organizations_url":"https://api.github.com/users/lukaszfryc/orgs","repos_url":"https://api.github.com/users/lukaszfryc/repos","events_url":"https://api.github.com/users/lukaszfryc/events{/privacy}","received_events_url":"https://api.github.com/users/lukaszfryc/received_events","type":"User","site_admin":false},"created_at":"2018-08-24T11:43:45Z","updated_at":"2018-08-24T11:43:45Z","author_association":"MEMBER","body":"@mandrigin let's wait for e2e to finish. I just scheduled them manually: https://ci.status.im/job/end-to-end-tests/job/status-app-end-to-end-tests/1469/console"}}
{"actor":{"display_login":"lukaszfryc"}}