{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/165488774","pull_request_review_id":93438956,"id":165488774,"diff_hunk":"@@ -41,4 +41,1041 @@ self: super: {\n   transformers = null;\n   unix = null;\n   xhtml = null;\n+\n+  # Undo the override in `configuration-common.nix`\n+  jailbreak-cabal = super.jailbreak-cabal.override { Cabal = self.Cabal; }; #pkgs.haskell.packages.ghc822.jailbreak-cabal;\n+\n+  ## On Hackage:\n+\n+  blaze-markup = overrideCabal super.blaze-markup (drv: {\n+    ## On Hackage, awaiting for import","path":"pkgs/development/haskell-modules/configuration-ghc-8.4.x.nix","position":11,"original_position":11,"commit_id":"2897a7ff06e55e0b7c04d0b275a1c81ca8a3fbfa","original_commit_id":"2897a7ff06e55e0b7c04d0b275a1c81ca8a3fbfa","user":{"login":"deepfire","id":452652,"avatar_url":"https://avatars2.githubusercontent.com/u/452652?v=4","gravatar_id":"","url":"https://api.github.com/users/deepfire","html_url":"https://github.com/deepfire","followers_url":"https://api.github.com/users/deepfire/followers","following_url":"https://api.github.com/users/deepfire/following{/other_user}","gists_url":"https://api.github.com/users/deepfire/gists{/gist_id}","starred_url":"https://api.github.com/users/deepfire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepfire/subscriptions","organizations_url":"https://api.github.com/users/deepfire/orgs","repos_url":"https://api.github.com/users/deepfire/repos","events_url":"https://api.github.com/users/deepfire/events{/privacy}","received_events_url":"https://api.github.com/users/deepfire/received_events","type":"User","site_admin":false},"body":"The `editedCabalFile` is coming from a pre-auto-trim state of the override set, but after I have promoted the package from github-overridden (where the editedCabalFile negation is necessary) to \"hackaged\" -- basically intermediate state.\r\n\r\nInvestigating now how to deal with the loops -- mainly how much of the problems can be dealt with `doCheck = false`..","created_at":"2018-02-01T21:11:56Z","updated_at":"2018-02-01T21:11:57Z","html_url":"https://github.com/NixOS/nixpkgs/pull/34404#discussion_r165488774","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/34404","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/165488774"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/34404#discussion_r165488774"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/34404"}},"in_reply_to_id":165004238},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/34404","id":165874470,"html_url":"https://github.com/NixOS/nixpkgs/pull/34404","diff_url":"https://github.com/NixOS/nixpkgs/pull/34404.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/34404.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/34404","number":34404,"state":"open","locked":false,"title":"GHC 8.4 package overrides","user":{"login":"deepfire","id":452652,"avatar_url":"https://avatars2.githubusercontent.com/u/452652?v=4","gravatar_id":"","url":"https://api.github.com/users/deepfire","html_url":"https://github.com/deepfire","followers_url":"https://api.github.com/users/deepfire/followers","following_url":"https://api.github.com/users/deepfire/following{/other_user}","gists_url":"https://api.github.com/users/deepfire/gists{/gist_id}","starred_url":"https://api.github.com/users/deepfire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepfire/subscriptions","organizations_url":"https://api.github.com/users/deepfire/orgs","repos_url":"https://api.github.com/users/deepfire/repos","events_url":"https://api.github.com/users/deepfire/events{/privacy}","received_events_url":"https://api.github.com/users/deepfire/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\nSupply a set of fixes to make more packages buildable with GHC 8.4-alpha2.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-01-30T02:58:31Z","updated_at":"2018-02-01T21:11:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc3e9f4cbfbbf92043512e9643e5cd6be3701a82","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/34404/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/34404/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/34404/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/2897a7ff06e55e0b7c04d0b275a1c81ca8a3fbfa","head":{"label":"deepfire:x-ghc-8.4-overrides","ref":"x-ghc-8.4-overrides","sha":"2897a7ff06e55e0b7c04d0b275a1c81ca8a3fbfa","user":{"login":"deepfire","id":452652,"avatar_url":"https://avatars2.githubusercontent.com/u/452652?v=4","gravatar_id":"","url":"https://api.github.com/users/deepfire","html_url":"https://github.com/deepfire","followers_url":"https://api.github.com/users/deepfire/followers","following_url":"https://api.github.com/users/deepfire/following{/other_user}","gists_url":"https://api.github.com/users/deepfire/gists{/gist_id}","starred_url":"https://api.github.com/users/deepfire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepfire/subscriptions","organizations_url":"https://api.github.com/users/deepfire/orgs","repos_url":"https://api.github.com/users/deepfire/repos","events_url":"https://api.github.com/users/deepfire/events{/privacy}","received_events_url":"https://api.github.com/users/deepfire/received_events","type":"User","site_admin":false},"repo":{"id":20626938,"name":"nixpkgs","full_name":"deepfire/nixpkgs","owner":{"login":"deepfire","id":452652,"avatar_url":"https://avatars2.githubusercontent.com/u/452652?v=4","gravatar_id":"","url":"https://api.github.com/users/deepfire","html_url":"https://github.com/deepfire","followers_url":"https://api.github.com/users/deepfire/followers","following_url":"https://api.github.com/users/deepfire/following{/other_user}","gists_url":"https://api.github.com/users/deepfire/gists{/gist_id}","starred_url":"https://api.github.com/users/deepfire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepfire/subscriptions","organizations_url":"https://api.github.com/users/deepfire/orgs","repos_url":"https://api.github.com/users/deepfire/repos","events_url":"https://api.github.com/users/deepfire/events{/privacy}","received_events_url":"https://api.github.com/users/deepfire/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/deepfire/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/deepfire/nixpkgs","forks_url":"https://api.github.com/repos/deepfire/nixpkgs/forks","keys_url":"https://api.github.com/repos/deepfire/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deepfire/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deepfire/nixpkgs/teams","hooks_url":"https://api.github.com/repos/deepfire/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/deepfire/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/deepfire/nixpkgs/events","assignees_url":"https://api.github.com/repos/deepfire/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/deepfire/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/deepfire/nixpkgs/tags","blobs_url":"https://api.github.com/repos/deepfire/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deepfire/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deepfire/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/deepfire/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deepfire/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/deepfire/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/deepfire/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/deepfire/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/deepfire/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/deepfire/nixpkgs/subscription","commits_url":"https://api.github.com/repos/deepfire/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/deepfire/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/deepfire/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/deepfire/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/deepfire/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/deepfire/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deepfire/nixpkgs/merges","archive_url":"https://api.github.com/repos/deepfire/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deepfire/nixpkgs/downloads","issues_url":"https://api.github.com/repos/deepfire/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/deepfire/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/deepfire/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/deepfire/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deepfire/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/deepfire/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/deepfire/nixpkgs/deployments","created_at":"2014-06-08T21:29:19Z","updated_at":"2017-03-13T03:52:53Z","pushed_at":"2018-01-31T01:26:24Z","git_url":"git://github.com/deepfire/nixpkgs.git","ssh_url":"git@github.com:deepfire/nixpkgs.git","clone_url":"https://github.com/deepfire/nixpkgs.git","svn_url":"https://github.com/deepfire/nixpkgs","homepage":null,"size":701366,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"5097e84a9d2657b5cd7cbeda9fa202933ba4d194","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-02-01T20:40:30Z","pushed_at":"2018-02-01T21:11:26Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":748102,"stargazers_count":2183,"watchers_count":2183,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2529,"mirror_url":null,"archived":false,"open_issues_count":2862,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2529,"open_issues":2862,"watchers":2183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/34404"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/34404"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/34404"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/34404/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/34404/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/34404/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/2897a7ff06e55e0b7c04d0b275a1c81ca8a3fbfa"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"deepfire"}}