{"action":"created","issue":{"url":"https://api.github.com/repos/ESCOMP/cism/issues/12","repository_url":"https://api.github.com/repos/ESCOMP/cism","labels_url":"https://api.github.com/repos/ESCOMP/cism/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/ESCOMP/cism/issues/12/comments","events_url":"https://api.github.com/repos/ESCOMP/cism/issues/12/events","html_url":"https://github.com/ESCOMP/cism/issues/12","id":338781962,"node_id":"MDU6SXNzdWUzMzg3ODE5NjI=","number":12,"title":"Are changes needed to support a Gregorian (leap year) calendar?","user":{"login":"billsacks","id":6266741,"node_id":"MDQ6VXNlcjYyNjY3NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/6266741?v=4","gravatar_id":"","url":"https://api.github.com/users/billsacks","html_url":"https://github.com/billsacks","followers_url":"https://api.github.com/users/billsacks/followers","following_url":"https://api.github.com/users/billsacks/following{/other_user}","gists_url":"https://api.github.com/users/billsacks/gists{/gist_id}","starred_url":"https://api.github.com/users/billsacks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billsacks/subscriptions","organizations_url":"https://api.github.com/users/billsacks/orgs","repos_url":"https://api.github.com/users/billsacks/repos","events_url":"https://api.github.com/users/billsacks/events{/privacy}","received_events_url":"https://api.github.com/users/billsacks/received_events","type":"User","site_admin":false},"labels":[{"id":920645210,"node_id":"MDU6TGFiZWw5MjA2NDUyMTA=","url":"https://api.github.com/repos/ESCOMP/cism/labels/question","name":"question","color":"d876e3","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-07-06T02:15:19Z","updated_at":"2018-07-06T02:15:24Z","closed_at":null,"author_association":"MEMBER","body":"_From @billsacks on April 8, 2016 1:25_\n\nFor now this is more of a question than an issue... we can change it into an issue if it seems warranted:\n\nDo people feel that any changes are needed for CISM to support a Gregorian (leap year) calendar? Typically CESM operates with a NOLEAP calendar, but some applications use it with a Gregorian calendar.\n\nI'm pretty sure that CISM currently assumes a 365-day (no-leap) calendar (e.g., the scyr parameter is hard-coded to 365 days). I could imagine this possibly causing small errors both in terms of averaging quantities sent to / from the climate model, and also in terms of the number and size of the dynamics timesteps that fit within a year.\n\nThere are really two questions:\n\n(1) Are people concerned about the small (but systematic) errors this will cause?\n\n(2) Might the current assumptions cause any major problems, such as causing the run to crash?\n\nThis one will probably take some experimentation. I'm not sure how to test this, which is part of my motivation for filing this as an issue to come back to later.\n\n\n_Copied from original issue: E3SM-Project/cism-piscees#54_"},"comment":{"url":"https://api.github.com/repos/ESCOMP/cism/issues/comments/402905032","html_url":"https://github.com/ESCOMP/cism/issues/12#issuecomment-402905032","issue_url":"https://api.github.com/repos/ESCOMP/cism/issues/12","id":402905032,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjkwNTAzMg==","user":{"login":"billsacks","id":6266741,"node_id":"MDQ6VXNlcjYyNjY3NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/6266741?v=4","gravatar_id":"","url":"https://api.github.com/users/billsacks","html_url":"https://github.com/billsacks","followers_url":"https://api.github.com/users/billsacks/followers","following_url":"https://api.github.com/users/billsacks/following{/other_user}","gists_url":"https://api.github.com/users/billsacks/gists{/gist_id}","starred_url":"https://api.github.com/users/billsacks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billsacks/subscriptions","organizations_url":"https://api.github.com/users/billsacks/orgs","repos_url":"https://api.github.com/users/billsacks/repos","events_url":"https://api.github.com/users/billsacks/events{/privacy}","received_events_url":"https://api.github.com/users/billsacks/received_events","type":"User","site_admin":false},"created_at":"2018-07-06T02:15:23Z","updated_at":"2018-07-06T02:15:23Z","author_association":"MEMBER","body":"@JeremyFyke : It's not so much that we'd want to run with a Gregorian calendar ourselves, but rather that others want to do it. The main reason I'm aware of is when you're doing an application that involves direct comparisons with data, such as data assimilation, in which case you don't want to simply exclude every Feb 29.\n"}}
{"actor":{"display_login":"billsacks"}}