{"action":"created","comment":{"url":"https://api.github.com/repos/njoy/NJOY2016/pulls/comments/242682916","pull_request_review_id":186253689,"id":242682916,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjY4MjkxNg==","diff_hunk":"@@ -1103,6 +1110,11 @@ subroutine unresl(ee,tt,sig0,nsig0,sigbkg,sigu,arry)\n                   sti=gg(5)/del(itp)\n                   do is0=1,nsig0\n                      beta=sigm(is0)/s0u\n+\t\t\t\t\t if (beta.lt.zero.and.abs(beta).lt.one.and.noissue) then","path":"src/unresr.f90","position":27,"original_position":27,"commit_id":"6aeb05251ad9b423b3498caa481f3fe7eb2f926a","original_commit_id":"6aeb05251ad9b423b3498caa481f3fe7eb2f926a","user":{"login":"jlconlin","id":1275437,"node_id":"MDQ6VXNlcjEyNzU0Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1275437?v=4","gravatar_id":"","url":"https://api.github.com/users/jlconlin","html_url":"https://github.com/jlconlin","followers_url":"https://api.github.com/users/jlconlin/followers","following_url":"https://api.github.com/users/jlconlin/following{/other_user}","gists_url":"https://api.github.com/users/jlconlin/gists{/gist_id}","starred_url":"https://api.github.com/users/jlconlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlconlin/subscriptions","organizations_url":"https://api.github.com/users/jlconlin/orgs","repos_url":"https://api.github.com/users/jlconlin/repos","events_url":"https://api.github.com/users/jlconlin/events{/privacy}","received_events_url":"https://api.github.com/users/jlconlin/received_events","type":"User","site_admin":false},"body":"This is some strange indenting. Can you fix it?","created_at":"2018-12-18T19:54:34Z","updated_at":"2018-12-18T19:56:35Z","html_url":"https://github.com/njoy/NJOY2016/pull/117#discussion_r242682916","pull_request_url":"https://api.github.com/repos/njoy/NJOY2016/pulls/117","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/njoy/NJOY2016/pulls/comments/242682916"},"html":{"href":"https://github.com/njoy/NJOY2016/pull/117#discussion_r242682916"},"pull_request":{"href":"https://api.github.com/repos/njoy/NJOY2016/pulls/117"}}},"pull_request":{"url":"https://api.github.com/repos/njoy/NJOY2016/pulls/117","id":239597573,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NTk3NTcz","html_url":"https://github.com/njoy/NJOY2016/pull/117","diff_url":"https://github.com/njoy/NJOY2016/pull/117.diff","patch_url":"https://github.com/njoy/NJOY2016/pull/117.patch","issue_url":"https://api.github.com/repos/njoy/NJOY2016/issues/117","number":117,"state":"open","locked":false,"title":"Fix/unresr","user":{"login":"whaeck","id":18539456,"node_id":"MDQ6VXNlcjE4NTM5NDU2","avatar_url":"https://avatars0.githubusercontent.com/u/18539456?v=4","gravatar_id":"","url":"https://api.github.com/users/whaeck","html_url":"https://github.com/whaeck","followers_url":"https://api.github.com/users/whaeck/followers","following_url":"https://api.github.com/users/whaeck/following{/other_user}","gists_url":"https://api.github.com/users/whaeck/gists{/gist_id}","starred_url":"https://api.github.com/users/whaeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whaeck/subscriptions","organizations_url":"https://api.github.com/users/whaeck/orgs","repos_url":"https://api.github.com/users/whaeck/repos","events_url":"https://api.github.com/users/whaeck/events{/privacy}","received_events_url":"https://api.github.com/users/whaeck/received_events","type":"User","site_admin":false},"body":"Additional messages in UNRESR for signaling issue #116.\r\n\r\nThe changes are as follows:\r\n- a message is issued when the background plus the potential scattering, the interference and sigma0 value are negative\r\n- a message is issued when the beta value is within the -1 to 0 range (which causes a sqrt to return NaN) \r\n\r\nQuestions:\r\n- the first message could be slightly changed so that it is issued when the background plus the potential scattering and the interference are negative, regardless of the value of sigma0. In my opinion, the fact that this value is negative before adding sigma0 is an indication that the evaluation is no good whatever happens.\r\n- the second message could be transformed into an error and that would stop the processing dead in its tracks (which degrades the behaviour from before these changes - it was silently ignored). In my opinion, the results will be inherently wrong, which would merit the use of error instead of mess.","created_at":"2018-12-18T19:04:06Z","updated_at":"2018-12-18T19:56:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d4fac45b8133563d0d90a443c4d3f8d52ba504f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kahlerac","id":17732681,"node_id":"MDQ6VXNlcjE3NzMyNjgx","avatar_url":"https://avatars2.githubusercontent.com/u/17732681?v=4","gravatar_id":"","url":"https://api.github.com/users/kahlerac","html_url":"https://github.com/kahlerac","followers_url":"https://api.github.com/users/kahlerac/followers","following_url":"https://api.github.com/users/kahlerac/following{/other_user}","gists_url":"https://api.github.com/users/kahlerac/gists{/gist_id}","starred_url":"https://api.github.com/users/kahlerac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kahlerac/subscriptions","organizations_url":"https://api.github.com/users/kahlerac/orgs","repos_url":"https://api.github.com/users/kahlerac/repos","events_url":"https://api.github.com/users/kahlerac/events{/privacy}","received_events_url":"https://api.github.com/users/kahlerac/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/njoy/NJOY2016/pulls/117/commits","review_comments_url":"https://api.github.com/repos/njoy/NJOY2016/pulls/117/comments","review_comment_url":"https://api.github.com/repos/njoy/NJOY2016/pulls/comments{/number}","comments_url":"https://api.github.com/repos/njoy/NJOY2016/issues/117/comments","statuses_url":"https://api.github.com/repos/njoy/NJOY2016/statuses/6aeb05251ad9b423b3498caa481f3fe7eb2f926a","head":{"label":"njoy:fix/unresr","ref":"fix/unresr","sha":"6aeb05251ad9b423b3498caa481f3fe7eb2f926a","user":{"login":"njoy","id":17747175,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzQ3MTc1","avatar_url":"https://avatars0.githubusercontent.com/u/17747175?v=4","gravatar_id":"","url":"https://api.github.com/users/njoy","html_url":"https://github.com/njoy","followers_url":"https://api.github.com/users/njoy/followers","following_url":"https://api.github.com/users/njoy/following{/other_user}","gists_url":"https://api.github.com/users/njoy/gists{/gist_id}","starred_url":"https://api.github.com/users/njoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njoy/subscriptions","organizations_url":"https://api.github.com/users/njoy/orgs","repos_url":"https://api.github.com/users/njoy/repos","events_url":"https://api.github.com/users/njoy/events{/privacy}","received_events_url":"https://api.github.com/users/njoy/received_events","type":"Organization","site_admin":false},"repo":{"id":78686040,"node_id":"MDEwOlJlcG9zaXRvcnk3ODY4NjA0MA==","name":"NJOY2016","full_name":"njoy/NJOY2016","private":false,"owner":{"login":"njoy","id":17747175,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzQ3MTc1","avatar_url":"https://avatars0.githubusercontent.com/u/17747175?v=4","gravatar_id":"","url":"https://api.github.com/users/njoy","html_url":"https://github.com/njoy","followers_url":"https://api.github.com/users/njoy/followers","following_url":"https://api.github.com/users/njoy/following{/other_user}","gists_url":"https://api.github.com/users/njoy/gists{/gist_id}","starred_url":"https://api.github.com/users/njoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njoy/subscriptions","organizations_url":"https://api.github.com/users/njoy/orgs","repos_url":"https://api.github.com/users/njoy/repos","events_url":"https://api.github.com/users/njoy/events{/privacy}","received_events_url":"https://api.github.com/users/njoy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/njoy/NJOY2016","description":"Nuclear data processing with legacy NJOY","fork":false,"url":"https://api.github.com/repos/njoy/NJOY2016","forks_url":"https://api.github.com/repos/njoy/NJOY2016/forks","keys_url":"https://api.github.com/repos/njoy/NJOY2016/keys{/key_id}","collaborators_url":"https://api.github.com/repos/njoy/NJOY2016/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/njoy/NJOY2016/teams","hooks_url":"https://api.github.com/repos/njoy/NJOY2016/hooks","issue_events_url":"https://api.github.com/repos/njoy/NJOY2016/issues/events{/number}","events_url":"https://api.github.com/repos/njoy/NJOY2016/events","assignees_url":"https://api.github.com/repos/njoy/NJOY2016/assignees{/user}","branches_url":"https://api.github.com/repos/njoy/NJOY2016/branches{/branch}","tags_url":"https://api.github.com/repos/njoy/NJOY2016/tags","blobs_url":"https://api.github.com/repos/njoy/NJOY2016/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/njoy/NJOY2016/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/njoy/NJOY2016/git/refs{/sha}","trees_url":"https://api.github.com/repos/njoy/NJOY2016/git/trees{/sha}","statuses_url":"https://api.github.com/repos/njoy/NJOY2016/statuses/{sha}","languages_url":"https://api.github.com/repos/njoy/NJOY2016/languages","stargazers_url":"https://api.github.com/repos/njoy/NJOY2016/stargazers","contributors_url":"https://api.github.com/repos/njoy/NJOY2016/contributors","subscribers_url":"https://api.github.com/repos/njoy/NJOY2016/subscribers","subscription_url":"https://api.github.com/repos/njoy/NJOY2016/subscription","commits_url":"https://api.github.com/repos/njoy/NJOY2016/commits{/sha}","git_commits_url":"https://api.github.com/repos/njoy/NJOY2016/git/commits{/sha}","comments_url":"https://api.github.com/repos/njoy/NJOY2016/comments{/number}","issue_comment_url":"https://api.github.com/repos/njoy/NJOY2016/issues/comments{/number}","contents_url":"https://api.github.com/repos/njoy/NJOY2016/contents/{+path}","compare_url":"https://api.github.com/repos/njoy/NJOY2016/compare/{base}...{head}","merges_url":"https://api.github.com/repos/njoy/NJOY2016/merges","archive_url":"https://api.github.com/repos/njoy/NJOY2016/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/njoy/NJOY2016/downloads","issues_url":"https://api.github.com/repos/njoy/NJOY2016/issues{/number}","pulls_url":"https://api.github.com/repos/njoy/NJOY2016/pulls{/number}","milestones_url":"https://api.github.com/repos/njoy/NJOY2016/milestones{/number}","notifications_url":"https://api.github.com/repos/njoy/NJOY2016/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/njoy/NJOY2016/labels{/name}","releases_url":"https://api.github.com/repos/njoy/NJOY2016/releases{/id}","deployments_url":"https://api.github.com/repos/njoy/NJOY2016/deployments","created_at":"2017-01-11T22:34:13Z","updated_at":"2018-12-08T17:10:33Z","pushed_at":"2018-12-18T19:04:07Z","git_url":"git://github.com/njoy/NJOY2016.git","ssh_url":"git@github.com:njoy/NJOY2016.git","clone_url":"https://github.com/njoy/NJOY2016.git","svn_url":"https://github.com/njoy/NJOY2016","homepage":"https://njoy.github.io/NJOY2016","size":232388,"stargazers_count":36,"watchers_count":36,"language":"Fortran","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":30,"open_issues":24,"watchers":36,"default_branch":"master"}},"base":{"label":"njoy:master","ref":"master","sha":"f03b64494277a01e561dee84e96d4b570f417312","user":{"login":"njoy","id":17747175,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzQ3MTc1","avatar_url":"https://avatars0.githubusercontent.com/u/17747175?v=4","gravatar_id":"","url":"https://api.github.com/users/njoy","html_url":"https://github.com/njoy","followers_url":"https://api.github.com/users/njoy/followers","following_url":"https://api.github.com/users/njoy/following{/other_user}","gists_url":"https://api.github.com/users/njoy/gists{/gist_id}","starred_url":"https://api.github.com/users/njoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njoy/subscriptions","organizations_url":"https://api.github.com/users/njoy/orgs","repos_url":"https://api.github.com/users/njoy/repos","events_url":"https://api.github.com/users/njoy/events{/privacy}","received_events_url":"https://api.github.com/users/njoy/received_events","type":"Organization","site_admin":false},"repo":{"id":78686040,"node_id":"MDEwOlJlcG9zaXRvcnk3ODY4NjA0MA==","name":"NJOY2016","full_name":"njoy/NJOY2016","private":false,"owner":{"login":"njoy","id":17747175,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzQ3MTc1","avatar_url":"https://avatars0.githubusercontent.com/u/17747175?v=4","gravatar_id":"","url":"https://api.github.com/users/njoy","html_url":"https://github.com/njoy","followers_url":"https://api.github.com/users/njoy/followers","following_url":"https://api.github.com/users/njoy/following{/other_user}","gists_url":"https://api.github.com/users/njoy/gists{/gist_id}","starred_url":"https://api.github.com/users/njoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njoy/subscriptions","organizations_url":"https://api.github.com/users/njoy/orgs","repos_url":"https://api.github.com/users/njoy/repos","events_url":"https://api.github.com/users/njoy/events{/privacy}","received_events_url":"https://api.github.com/users/njoy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/njoy/NJOY2016","description":"Nuclear data processing with legacy NJOY","fork":false,"url":"https://api.github.com/repos/njoy/NJOY2016","forks_url":"https://api.github.com/repos/njoy/NJOY2016/forks","keys_url":"https://api.github.com/repos/njoy/NJOY2016/keys{/key_id}","collaborators_url":"https://api.github.com/repos/njoy/NJOY2016/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/njoy/NJOY2016/teams","hooks_url":"https://api.github.com/repos/njoy/NJOY2016/hooks","issue_events_url":"https://api.github.com/repos/njoy/NJOY2016/issues/events{/number}","events_url":"https://api.github.com/repos/njoy/NJOY2016/events","assignees_url":"https://api.github.com/repos/njoy/NJOY2016/assignees{/user}","branches_url":"https://api.github.com/repos/njoy/NJOY2016/branches{/branch}","tags_url":"https://api.github.com/repos/njoy/NJOY2016/tags","blobs_url":"https://api.github.com/repos/njoy/NJOY2016/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/njoy/NJOY2016/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/njoy/NJOY2016/git/refs{/sha}","trees_url":"https://api.github.com/repos/njoy/NJOY2016/git/trees{/sha}","statuses_url":"https://api.github.com/repos/njoy/NJOY2016/statuses/{sha}","languages_url":"https://api.github.com/repos/njoy/NJOY2016/languages","stargazers_url":"https://api.github.com/repos/njoy/NJOY2016/stargazers","contributors_url":"https://api.github.com/repos/njoy/NJOY2016/contributors","subscribers_url":"https://api.github.com/repos/njoy/NJOY2016/subscribers","subscription_url":"https://api.github.com/repos/njoy/NJOY2016/subscription","commits_url":"https://api.github.com/repos/njoy/NJOY2016/commits{/sha}","git_commits_url":"https://api.github.com/repos/njoy/NJOY2016/git/commits{/sha}","comments_url":"https://api.github.com/repos/njoy/NJOY2016/comments{/number}","issue_comment_url":"https://api.github.com/repos/njoy/NJOY2016/issues/comments{/number}","contents_url":"https://api.github.com/repos/njoy/NJOY2016/contents/{+path}","compare_url":"https://api.github.com/repos/njoy/NJOY2016/compare/{base}...{head}","merges_url":"https://api.github.com/repos/njoy/NJOY2016/merges","archive_url":"https://api.github.com/repos/njoy/NJOY2016/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/njoy/NJOY2016/downloads","issues_url":"https://api.github.com/repos/njoy/NJOY2016/issues{/number}","pulls_url":"https://api.github.com/repos/njoy/NJOY2016/pulls{/number}","milestones_url":"https://api.github.com/repos/njoy/NJOY2016/milestones{/number}","notifications_url":"https://api.github.com/repos/njoy/NJOY2016/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/njoy/NJOY2016/labels{/name}","releases_url":"https://api.github.com/repos/njoy/NJOY2016/releases{/id}","deployments_url":"https://api.github.com/repos/njoy/NJOY2016/deployments","created_at":"2017-01-11T22:34:13Z","updated_at":"2018-12-08T17:10:33Z","pushed_at":"2018-12-18T19:04:07Z","git_url":"git://github.com/njoy/NJOY2016.git","ssh_url":"git@github.com:njoy/NJOY2016.git","clone_url":"https://github.com/njoy/NJOY2016.git","svn_url":"https://github.com/njoy/NJOY2016","homepage":"https://njoy.github.io/NJOY2016","size":232388,"stargazers_count":36,"watchers_count":36,"language":"Fortran","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":30,"open_issues":24,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/njoy/NJOY2016/pulls/117"},"html":{"href":"https://github.com/njoy/NJOY2016/pull/117"},"issue":{"href":"https://api.github.com/repos/njoy/NJOY2016/issues/117"},"comments":{"href":"https://api.github.com/repos/njoy/NJOY2016/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/njoy/NJOY2016/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/njoy/NJOY2016/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/njoy/NJOY2016/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/njoy/NJOY2016/statuses/6aeb05251ad9b423b3498caa481f3fe7eb2f926a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jlconlin"}}