{"action":"closed","issue":{"url":"https://api.github.com/repos/ilestis/miscellany/issues/2","repository_url":"https://api.github.com/repos/ilestis/miscellany","labels_url":"https://api.github.com/repos/ilestis/miscellany/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/ilestis/miscellany/issues/2/comments","events_url":"https://api.github.com/repos/ilestis/miscellany/issues/2/events","html_url":"https://github.com/ilestis/miscellany/issues/2","id":290981779,"number":2,"title":"Attributes on each entity","user":{"login":"Marvellanius","id":9035837,"avatar_url":"https://avatars2.githubusercontent.com/u/9035837?v=4","gravatar_id":"","url":"https://api.github.com/users/Marvellanius","html_url":"https://github.com/Marvellanius","followers_url":"https://api.github.com/users/Marvellanius/followers","following_url":"https://api.github.com/users/Marvellanius/following{/other_user}","gists_url":"https://api.github.com/users/Marvellanius/gists{/gist_id}","starred_url":"https://api.github.com/users/Marvellanius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Marvellanius/subscriptions","organizations_url":"https://api.github.com/users/Marvellanius/orgs","repos_url":"https://api.github.com/users/Marvellanius/repos","events_url":"https://api.github.com/users/Marvellanius/events{/privacy}","received_events_url":"https://api.github.com/users/Marvellanius/received_events","type":"User","site_admin":false},"labels":[{"id":732085616,"url":"https://api.github.com/repos/ilestis/miscellany/labels/feature","name":"feature","color":"1155ff","default":false},{"id":732085618,"url":"https://api.github.com/repos/ilestis/miscellany/labels/good%20first%20issue","name":"good first issue","color":"7057ff","default":true},{"id":814301661,"url":"https://api.github.com/repos/ilestis/miscellany/labels/medium%20priority","name":"medium priority","color":"cc593f","default":false}],"state":"closed","locked":false,"assignee":{"login":"Marvellanius","id":9035837,"avatar_url":"https://avatars2.githubusercontent.com/u/9035837?v=4","gravatar_id":"","url":"https://api.github.com/users/Marvellanius","html_url":"https://github.com/Marvellanius","followers_url":"https://api.github.com/users/Marvellanius/followers","following_url":"https://api.github.com/users/Marvellanius/following{/other_user}","gists_url":"https://api.github.com/users/Marvellanius/gists{/gist_id}","starred_url":"https://api.github.com/users/Marvellanius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Marvellanius/subscriptions","organizations_url":"https://api.github.com/users/Marvellanius/orgs","repos_url":"https://api.github.com/users/Marvellanius/repos","events_url":"https://api.github.com/users/Marvellanius/events{/privacy}","received_events_url":"https://api.github.com/users/Marvellanius/received_events","type":"User","site_admin":false},"assignees":[{"login":"Marvellanius","id":9035837,"avatar_url":"https://avatars2.githubusercontent.com/u/9035837?v=4","gravatar_id":"","url":"https://api.github.com/users/Marvellanius","html_url":"https://github.com/Marvellanius","followers_url":"https://api.github.com/users/Marvellanius/followers","following_url":"https://api.github.com/users/Marvellanius/following{/other_user}","gists_url":"https://api.github.com/users/Marvellanius/gists{/gist_id}","starred_url":"https://api.github.com/users/Marvellanius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Marvellanius/subscriptions","organizations_url":"https://api.github.com/users/Marvellanius/orgs","repos_url":"https://api.github.com/users/Marvellanius/repos","events_url":"https://api.github.com/users/Marvellanius/events{/privacy}","received_events_url":"https://api.github.com/users/Marvellanius/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-01-23T20:28:23Z","updated_at":"2018-02-16T14:42:16Z","closed_at":"2018-02-16T14:42:16Z","author_association":"COLLABORATOR","body":"# Story\r\nAs a user, I want to be able to set attributes on other entities, the same way attributes work on *Characters*.\r\n\r\n# Work\r\n1. Move the current Attributes code from the Character entity to a generic Crud (very similar to *relations*). This will require a new model using the *entities* table.\r\n2. Create a migration that moves the character attributes to the new attributes table\r\n3. Add the Attributes tab and code to the following entities: Locations, Families, Events and Organisations. \r\n4. Remove the attributes code specifically targeted to Characters, using the new generic code instead.\r\n5. Moving entities should keep all the attributes\r\n\r\n# Tests\r\n* I can create, update and delete cruds on Characters, Locations, Families, Events and Organisations\r\n* Attributes created on characters before the change are still viewable, editable and deletable.\r\n* The character_attribute table no longer exists\r\n* Moving an entity with attributes to another keeps the attributes.\r\n* Moving an entity with attributes to another without attributes keeps the attributes none the less."}}
{"actor":{"display_login":"ilestis"}}