{"action":"created","issue":{"url":"https://api.github.com/repos/tullamods/Dominos/issues/337","repository_url":"https://api.github.com/repos/tullamods/Dominos","labels_url":"https://api.github.com/repos/tullamods/Dominos/issues/337/labels{/name}","comments_url":"https://api.github.com/repos/tullamods/Dominos/issues/337/comments","events_url":"https://api.github.com/repos/tullamods/Dominos/issues/337/events","html_url":"https://github.com/tullamods/Dominos/issues/337","id":390938791,"node_id":"MDU6SXNzdWUzOTA5Mzg3OTE=","number":337,"title":"[Patch] \"tried to call the protected function#\" taint error","user":{"login":"brittyazel","id":3747347,"node_id":"MDQ6VXNlcjM3NDczNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/3747347?v=4","gravatar_id":"","url":"https://api.github.com/users/brittyazel","html_url":"https://github.com/brittyazel","followers_url":"https://api.github.com/users/brittyazel/followers","following_url":"https://api.github.com/users/brittyazel/following{/other_user}","gists_url":"https://api.github.com/users/brittyazel/gists{/gist_id}","starred_url":"https://api.github.com/users/brittyazel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brittyazel/subscriptions","organizations_url":"https://api.github.com/users/brittyazel/orgs","repos_url":"https://api.github.com/users/brittyazel/repos","events_url":"https://api.github.com/users/brittyazel/events{/privacy}","received_events_url":"https://api.github.com/users/brittyazel/received_events","type":"User","site_admin":false},"labels":[{"id":47252,"node_id":"MDU6TGFiZWw0NzI1Mg==","url":"https://api.github.com/repos/tullamods/Dominos/labels/%E2%98%A0%EF%B8%8F%20bug","name":"☠️ bug","color":"C40233","default":false}],"state":"closed","locked":false,"assignee":{"login":"Tuller","id":191239,"node_id":"MDQ6VXNlcjE5MTIzOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/191239?v=4","gravatar_id":"","url":"https://api.github.com/users/Tuller","html_url":"https://github.com/Tuller","followers_url":"https://api.github.com/users/Tuller/followers","following_url":"https://api.github.com/users/Tuller/following{/other_user}","gists_url":"https://api.github.com/users/Tuller/gists{/gist_id}","starred_url":"https://api.github.com/users/Tuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tuller/subscriptions","organizations_url":"https://api.github.com/users/Tuller/orgs","repos_url":"https://api.github.com/users/Tuller/repos","events_url":"https://api.github.com/users/Tuller/events{/privacy}","received_events_url":"https://api.github.com/users/Tuller/received_events","type":"User","site_admin":false},"assignees":[{"login":"Tuller","id":191239,"node_id":"MDQ6VXNlcjE5MTIzOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/191239?v=4","gravatar_id":"","url":"https://api.github.com/users/Tuller","html_url":"https://github.com/Tuller","followers_url":"https://api.github.com/users/Tuller/followers","following_url":"https://api.github.com/users/Tuller/following{/other_user}","gists_url":"https://api.github.com/users/Tuller/gists{/gist_id}","starred_url":"https://api.github.com/users/Tuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tuller/subscriptions","organizations_url":"https://api.github.com/users/Tuller/orgs","repos_url":"https://api.github.com/users/Tuller/repos","events_url":"https://api.github.com/users/Tuller/events{/privacy}","received_events_url":"https://api.github.com/users/Tuller/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-12-14T02:20:04Z","updated_at":"2018-12-21T09:54:49Z","closed_at":"2018-12-17T13:06:39Z","author_association":"NONE","body":"Hi Tuller,\r\n\r\nMy name is Soyier, and I'm the author of Neuron, an action bar addon very similar to your own. I noticed you were getting a lot of the same issue reports as I with regard to taint error \"AddonX tried to call the protection function#:Hide()\", or something in that vein. I think I have a decent fix for it, though I still need to test it thoroughly. I took your Blizzard Bar disabling code and modified it:\r\n\r\nThe code below is mostly yours, with a bit of modernization (I got rid of the _G calls), and most of the fix comes from these lines, which make use of Ace3-Hook:\r\n\r\nNeuron:RawHook('ActionButton_Update', function() end, true)\r\nNeuron:RawHook('MultiActionBar_Update', function() end, true)\r\n\r\nAlso, I had to explicitly disableFrame(MainMenuBar), or you get errors about :SetPoint or some such. \r\n\r\nHopefully this helps a bit, and maybe you can refine the code even further for both of our benefit :-)\r\n\r\nCheers buddy! Happy Holidays\r\n\r\n```\r\nfunction Neuron:HideBlizzard()\r\n\tif (InCombatLockdown()) then\r\n\t\treturn\r\n\tend\r\n\r\n\r\n\t---the idea for this code is inspired from Dominos. Thanks Tuller!\r\n\tlocal hiddenFrame = CreateFrame('Frame', nil, UIParent, 'SecureFrameTemplate');\r\n\thiddenFrame:Hide()\r\n\r\n\tlocal function disableFrame(frame, unregisterEvents)\r\n\r\n\t\tif not frame then\r\n\t\t\tNeuron:Print('Unknown Frame', frame:GetName())\r\n\t\t\treturn\r\n\t\tend\r\n\r\n\t\tframe:SetParent(hiddenFrame)\r\n\t\tframe.ignoreFramePositionManager = true\r\n\r\n\t\tif unregisterEvents then\r\n\t\t\tframe:UnregisterAllEvents()\r\n\t\tend\r\n\tend\r\n\r\n\tlocal function disableFrameSlidingAnimation(frame)\r\n\t\tlocal animation = (frame.slideOut:GetAnimations())\r\n\r\n\t\tanimation:SetOffset(0, 0)\r\n\tend\r\n\r\n\tdisableFrame(MainMenuBar)\r\n\r\n\t-- disable override bar transition animations\r\n\tdisableFrameSlidingAnimation(MainMenuBar)\r\n\tdisableFrameSlidingAnimation(OverrideActionBar)\r\n\r\n\tdisableFrame(MultiBarBottomLeft)\r\n\tdisableFrame(MultiBarBottomRight)\r\n\tdisableFrame(MultiBarLeft)\r\n\tdisableFrame(MultiBarRight)\r\n\tdisableFrame(MainMenuBarArtFrame)\r\n\tdisableFrame(StanceBarFrame)\r\n\tdisableFrame(PossessBarFrame)\r\n\tdisableFrame(PetActionBarFrame)\r\n\tdisableFrame(MultiCastActionBarFrame)\r\n\tdisableFrame(MicroButtonAndBagsBar)\r\n\tdisableFrame(MainMenuBarPerformanceBar)\r\n\r\n\tStatusTrackingBarManager:UnregisterAllEvents()\r\n\tStatusTrackingBarManager:Hide()\r\n\r\n\tif (not Neuron:IsHooked('ActionButton_Update')) then\r\n\t\tNeuron:RawHook('ActionButton_Update', function() end, true)\r\n\tend\r\n\tif (not Neuron:IsHooked('MultiActionBar_Update')) then\r\n\t\tNeuron:RawHook('MultiActionBar_Update', function() end, true)\r\n\tend\r\n\r\nend\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/tullamods/Dominos/issues/comments/449338746","html_url":"https://github.com/tullamods/Dominos/issues/337#issuecomment-449338746","issue_url":"https://api.github.com/repos/tullamods/Dominos/issues/337","id":449338746,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTMzODc0Ng==","user":{"login":"IngeniousDox","id":25202399,"node_id":"MDQ6VXNlcjI1MjAyMzk5","avatar_url":"https://avatars1.githubusercontent.com/u/25202399?v=4","gravatar_id":"","url":"https://api.github.com/users/IngeniousDox","html_url":"https://github.com/IngeniousDox","followers_url":"https://api.github.com/users/IngeniousDox/followers","following_url":"https://api.github.com/users/IngeniousDox/following{/other_user}","gists_url":"https://api.github.com/users/IngeniousDox/gists{/gist_id}","starred_url":"https://api.github.com/users/IngeniousDox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IngeniousDox/subscriptions","organizations_url":"https://api.github.com/users/IngeniousDox/orgs","repos_url":"https://api.github.com/users/IngeniousDox/repos","events_url":"https://api.github.com/users/IngeniousDox/events{/privacy}","received_events_url":"https://api.github.com/users/IngeniousDox/received_events","type":"User","site_admin":false},"created_at":"2018-12-21T09:54:49Z","updated_at":"2018-12-21T09:54:49Z","author_association":"NONE","body":"Yesterday, I was getting \"Action blocked\" when I tried to bonus roll on world bosses, this is with 8.1.3, I don't remember what version I was on before, since I hadn't updated addons in a while.\r\n\r\nI tried reloading UI / relogging, both didn't help. I had to disable Dominos Roll altogether to be able to bonus roll. So there might still be some taint somewhere there there."}}
{"actor":{"display_login":"IngeniousDox"}}