{"action":"created","comment":{"url":"https://api.github.com/repos/frappe/frappe/pulls/comments/232537023","pull_request_review_id":173754450,"id":232537023,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjUzNzAyMw==","diff_hunk":"@@ -86,6 +86,11 @@ def get_data():\n \t\t\t\t\t\"type\": \"doctype\",\n \t\t\t\t\t\"name\": \"Portal Settings\",\n \t\t\t\t\t\"label\": _(\"Portal Settings\"),\n+\t\t\t\t},","path":"frappe/config/website.py","position":4,"original_position":4,"commit_id":"4d1b97968da0eb97f9383b67d433bc6a0a9f0eda","original_commit_id":"4d1b97968da0eb97f9383b67d433bc6a0a9f0eda","user":{"login":"rmehta","id":140076,"node_id":"MDQ6VXNlcjE0MDA3Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/140076?v=4","gravatar_id":"","url":"https://api.github.com/users/rmehta","html_url":"https://github.com/rmehta","followers_url":"https://api.github.com/users/rmehta/followers","following_url":"https://api.github.com/users/rmehta/following{/other_user}","gists_url":"https://api.github.com/users/rmehta/gists{/gist_id}","starred_url":"https://api.github.com/users/rmehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmehta/subscriptions","organizations_url":"https://api.github.com/users/rmehta/orgs","repos_url":"https://api.github.com/users/rmehta/repos","events_url":"https://api.github.com/users/rmehta/events{/privacy}","received_events_url":"https://api.github.com/users/rmehta/received_events","type":"User","site_admin":false},"body":"product settings should be added via `erpnext/config/website.py` !","created_at":"2018-11-12T05:19:25Z","updated_at":"2018-11-12T05:19:25Z","html_url":"https://github.com/frappe/frappe/pull/6436#discussion_r232537023","pull_request_url":"https://api.github.com/repos/frappe/frappe/pulls/6436","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/frappe/frappe/pulls/comments/232537023"},"html":{"href":"https://github.com/frappe/frappe/pull/6436#discussion_r232537023"},"pull_request":{"href":"https://api.github.com/repos/frappe/frappe/pulls/6436"}}},"pull_request":{"url":"https://api.github.com/repos/frappe/frappe/pulls/6436","id":229794823,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5Nzk0ODIz","html_url":"https://github.com/frappe/frappe/pull/6436","diff_url":"https://github.com/frappe/frappe/pull/6436.diff","patch_url":"https://github.com/frappe/frappe/pull/6436.patch","issue_url":"https://api.github.com/repos/frappe/frappe/issues/6436","number":6436,"state":"open","locked":false,"title":"Adding Products Settings for Website in the Website module","user":{"login":"Tropicalrambler","id":16600935,"node_id":"MDQ6VXNlcjE2NjAwOTM1","avatar_url":"https://avatars2.githubusercontent.com/u/16600935?v=4","gravatar_id":"","url":"https://api.github.com/users/Tropicalrambler","html_url":"https://github.com/Tropicalrambler","followers_url":"https://api.github.com/users/Tropicalrambler/followers","following_url":"https://api.github.com/users/Tropicalrambler/following{/other_user}","gists_url":"https://api.github.com/users/Tropicalrambler/gists{/gist_id}","starred_url":"https://api.github.com/users/Tropicalrambler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tropicalrambler/subscriptions","organizations_url":"https://api.github.com/users/Tropicalrambler/orgs","repos_url":"https://api.github.com/users/Tropicalrambler/repos","events_url":"https://api.github.com/users/Tropicalrambler/events{/privacy}","received_events_url":"https://api.github.com/users/Tropicalrambler/received_events","type":"User","site_admin":false},"body":"Added the Products Settings DocType (already existing in core Frappe) to the menu for Website Module.\r\nPreviously user had to manually enter the name in the Awesome bar.\r\n![ezgif-3-d69c1b0dc4a2](https://user-images.githubusercontent.com/16600935/48283672-c92d2480-e422-11e8-961e-0e91ef9acb27.gif)\r\n\r\nPlease read the [Pull Request Checklist](https://github.com/frappe/erpnext/wiki/Pull-Request-Checklist) to ensure you have everything that is needed to get your contribution merged.","created_at":"2018-11-09T19:25:17Z","updated_at":"2018-11-12T05:19:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3ac058ceff344808a06197ce5d6456d7fafe7d8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/frappe/frappe/pulls/6436/commits","review_comments_url":"https://api.github.com/repos/frappe/frappe/pulls/6436/comments","review_comment_url":"https://api.github.com/repos/frappe/frappe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/frappe/frappe/issues/6436/comments","statuses_url":"https://api.github.com/repos/frappe/frappe/statuses/4d1b97968da0eb97f9383b67d433bc6a0a9f0eda","head":{"label":"sihaysistema:products-settings","ref":"products-settings","sha":"4d1b97968da0eb97f9383b67d433bc6a0a9f0eda","user":{"login":"sihaysistema","id":31116294,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMTE2Mjk0","avatar_url":"https://avatars3.githubusercontent.com/u/31116294?v=4","gravatar_id":"","url":"https://api.github.com/users/sihaysistema","html_url":"https://github.com/sihaysistema","followers_url":"https://api.github.com/users/sihaysistema/followers","following_url":"https://api.github.com/users/sihaysistema/following{/other_user}","gists_url":"https://api.github.com/users/sihaysistema/gists{/gist_id}","starred_url":"https://api.github.com/users/sihaysistema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sihaysistema/subscriptions","organizations_url":"https://api.github.com/users/sihaysistema/orgs","repos_url":"https://api.github.com/users/sihaysistema/repos","events_url":"https://api.github.com/users/sihaysistema/events{/privacy}","received_events_url":"https://api.github.com/users/sihaysistema/received_events","type":"Organization","site_admin":false},"repo":{"id":156906945,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY5MDY5NDU=","name":"frappe","full_name":"sihaysistema/frappe","private":false,"owner":{"login":"sihaysistema","id":31116294,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMTE2Mjk0","avatar_url":"https://avatars3.githubusercontent.com/u/31116294?v=4","gravatar_id":"","url":"https://api.github.com/users/sihaysistema","html_url":"https://github.com/sihaysistema","followers_url":"https://api.github.com/users/sihaysistema/followers","following_url":"https://api.github.com/users/sihaysistema/following{/other_user}","gists_url":"https://api.github.com/users/sihaysistema/gists{/gist_id}","starred_url":"https://api.github.com/users/sihaysistema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sihaysistema/subscriptions","organizations_url":"https://api.github.com/users/sihaysistema/orgs","repos_url":"https://api.github.com/users/sihaysistema/repos","events_url":"https://api.github.com/users/sihaysistema/events{/privacy}","received_events_url":"https://api.github.com/users/sihaysistema/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sihaysistema/frappe","description":"Full Stack Web Framework in Python & JS. Used to build ERPNext","fork":true,"url":"https://api.github.com/repos/sihaysistema/frappe","forks_url":"https://api.github.com/repos/sihaysistema/frappe/forks","keys_url":"https://api.github.com/repos/sihaysistema/frappe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sihaysistema/frappe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sihaysistema/frappe/teams","hooks_url":"https://api.github.com/repos/sihaysistema/frappe/hooks","issue_events_url":"https://api.github.com/repos/sihaysistema/frappe/issues/events{/number}","events_url":"https://api.github.com/repos/sihaysistema/frappe/events","assignees_url":"https://api.github.com/repos/sihaysistema/frappe/assignees{/user}","branches_url":"https://api.github.com/repos/sihaysistema/frappe/branches{/branch}","tags_url":"https://api.github.com/repos/sihaysistema/frappe/tags","blobs_url":"https://api.github.com/repos/sihaysistema/frappe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sihaysistema/frappe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sihaysistema/frappe/git/refs{/sha}","trees_url":"https://api.github.com/repos/sihaysistema/frappe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sihaysistema/frappe/statuses/{sha}","languages_url":"https://api.github.com/repos/sihaysistema/frappe/languages","stargazers_url":"https://api.github.com/repos/sihaysistema/frappe/stargazers","contributors_url":"https://api.github.com/repos/sihaysistema/frappe/contributors","subscribers_url":"https://api.github.com/repos/sihaysistema/frappe/subscribers","subscription_url":"https://api.github.com/repos/sihaysistema/frappe/subscription","commits_url":"https://api.github.com/repos/sihaysistema/frappe/commits{/sha}","git_commits_url":"https://api.github.com/repos/sihaysistema/frappe/git/commits{/sha}","comments_url":"https://api.github.com/repos/sihaysistema/frappe/comments{/number}","issue_comment_url":"https://api.github.com/repos/sihaysistema/frappe/issues/comments{/number}","contents_url":"https://api.github.com/repos/sihaysistema/frappe/contents/{+path}","compare_url":"https://api.github.com/repos/sihaysistema/frappe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sihaysistema/frappe/merges","archive_url":"https://api.github.com/repos/sihaysistema/frappe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sihaysistema/frappe/downloads","issues_url":"https://api.github.com/repos/sihaysistema/frappe/issues{/number}","pulls_url":"https://api.github.com/repos/sihaysistema/frappe/pulls{/number}","milestones_url":"https://api.github.com/repos/sihaysistema/frappe/milestones{/number}","notifications_url":"https://api.github.com/repos/sihaysistema/frappe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sihaysistema/frappe/labels{/name}","releases_url":"https://api.github.com/repos/sihaysistema/frappe/releases{/id}","deployments_url":"https://api.github.com/repos/sihaysistema/frappe/deployments","created_at":"2018-11-09T19:12:31Z","updated_at":"2018-11-09T19:12:40Z","pushed_at":"2018-11-09T19:21:44Z","git_url":"git://github.com/sihaysistema/frappe.git","ssh_url":"git@github.com:sihaysistema/frappe.git","clone_url":"https://github.com/sihaysistema/frappe.git","svn_url":"https://github.com/sihaysistema/frappe","homepage":"http://frappe.io","size":178448,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"frappe:develop","ref":"develop","sha":"488f62bcb82583cb51077558dda7f4efd2cb30a4","user":{"login":"frappe","id":836974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgzNjk3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/836974?v=4","gravatar_id":"","url":"https://api.github.com/users/frappe","html_url":"https://github.com/frappe","followers_url":"https://api.github.com/users/frappe/followers","following_url":"https://api.github.com/users/frappe/following{/other_user}","gists_url":"https://api.github.com/users/frappe/gists{/gist_id}","starred_url":"https://api.github.com/users/frappe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frappe/subscriptions","organizations_url":"https://api.github.com/users/frappe/orgs","repos_url":"https://api.github.com/users/frappe/repos","events_url":"https://api.github.com/users/frappe/events{/privacy}","received_events_url":"https://api.github.com/users/frappe/received_events","type":"Organization","site_admin":false},"repo":{"id":1864194,"node_id":"MDEwOlJlcG9zaXRvcnkxODY0MTk0","name":"frappe","full_name":"frappe/frappe","private":false,"owner":{"login":"frappe","id":836974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgzNjk3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/836974?v=4","gravatar_id":"","url":"https://api.github.com/users/frappe","html_url":"https://github.com/frappe","followers_url":"https://api.github.com/users/frappe/followers","following_url":"https://api.github.com/users/frappe/following{/other_user}","gists_url":"https://api.github.com/users/frappe/gists{/gist_id}","starred_url":"https://api.github.com/users/frappe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frappe/subscriptions","organizations_url":"https://api.github.com/users/frappe/orgs","repos_url":"https://api.github.com/users/frappe/repos","events_url":"https://api.github.com/users/frappe/events{/privacy}","received_events_url":"https://api.github.com/users/frappe/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/frappe/frappe","description":"Full Stack Web Framework in Python & JS. Used to build ERPNext","fork":false,"url":"https://api.github.com/repos/frappe/frappe","forks_url":"https://api.github.com/repos/frappe/frappe/forks","keys_url":"https://api.github.com/repos/frappe/frappe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frappe/frappe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frappe/frappe/teams","hooks_url":"https://api.github.com/repos/frappe/frappe/hooks","issue_events_url":"https://api.github.com/repos/frappe/frappe/issues/events{/number}","events_url":"https://api.github.com/repos/frappe/frappe/events","assignees_url":"https://api.github.com/repos/frappe/frappe/assignees{/user}","branches_url":"https://api.github.com/repos/frappe/frappe/branches{/branch}","tags_url":"https://api.github.com/repos/frappe/frappe/tags","blobs_url":"https://api.github.com/repos/frappe/frappe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frappe/frappe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frappe/frappe/git/refs{/sha}","trees_url":"https://api.github.com/repos/frappe/frappe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frappe/frappe/statuses/{sha}","languages_url":"https://api.github.com/repos/frappe/frappe/languages","stargazers_url":"https://api.github.com/repos/frappe/frappe/stargazers","contributors_url":"https://api.github.com/repos/frappe/frappe/contributors","subscribers_url":"https://api.github.com/repos/frappe/frappe/subscribers","subscription_url":"https://api.github.com/repos/frappe/frappe/subscription","commits_url":"https://api.github.com/repos/frappe/frappe/commits{/sha}","git_commits_url":"https://api.github.com/repos/frappe/frappe/git/commits{/sha}","comments_url":"https://api.github.com/repos/frappe/frappe/comments{/number}","issue_comment_url":"https://api.github.com/repos/frappe/frappe/issues/comments{/number}","contents_url":"https://api.github.com/repos/frappe/frappe/contents/{+path}","compare_url":"https://api.github.com/repos/frappe/frappe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frappe/frappe/merges","archive_url":"https://api.github.com/repos/frappe/frappe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frappe/frappe/downloads","issues_url":"https://api.github.com/repos/frappe/frappe/issues{/number}","pulls_url":"https://api.github.com/repos/frappe/frappe/pulls{/number}","milestones_url":"https://api.github.com/repos/frappe/frappe/milestones{/number}","notifications_url":"https://api.github.com/repos/frappe/frappe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frappe/frappe/labels{/name}","releases_url":"https://api.github.com/repos/frappe/frappe/releases{/id}","deployments_url":"https://api.github.com/repos/frappe/frappe/deployments","created_at":"2011-06-08T08:14:16Z","updated_at":"2018-11-12T05:18:51Z","pushed_at":"2018-11-12T05:18:46Z","git_url":"git://github.com/frappe/frappe.git","ssh_url":"git@github.com:frappe/frappe.git","clone_url":"https://github.com/frappe/frappe.git","svn_url":"https://github.com/frappe/frappe","homepage":"http://frappe.io","size":178489,"stargazers_count":1024,"watchers_count":1024,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":806,"mirror_url":null,"archived":false,"open_issues_count":352,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":806,"open_issues":352,"watchers":1024,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/frappe/frappe/pulls/6436"},"html":{"href":"https://github.com/frappe/frappe/pull/6436"},"issue":{"href":"https://api.github.com/repos/frappe/frappe/issues/6436"},"comments":{"href":"https://api.github.com/repos/frappe/frappe/issues/6436/comments"},"review_comments":{"href":"https://api.github.com/repos/frappe/frappe/pulls/6436/comments"},"review_comment":{"href":"https://api.github.com/repos/frappe/frappe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/frappe/frappe/pulls/6436/commits"},"statuses":{"href":"https://api.github.com/repos/frappe/frappe/statuses/4d1b97968da0eb97f9383b67d433bc6a0a9f0eda"}},"author_association":"NONE"}}
{"actor":{"display_login":"rmehta"}}