{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/cluster-api-provider-aws/issues/112","repository_url":"https://api.github.com/repos/openshift/cluster-api-provider-aws","labels_url":"https://api.github.com/repos/openshift/cluster-api-provider-aws/issues/112/labels{/name}","comments_url":"https://api.github.com/repos/openshift/cluster-api-provider-aws/issues/112/comments","events_url":"https://api.github.com/repos/openshift/cluster-api-provider-aws/issues/112/events","html_url":"https://github.com/openshift/cluster-api-provider-aws/pull/112","id":384709962,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzODQ0ODEz","number":112,"title":"Code refactoring","user":{"login":"ingvagabund","id":8055242,"node_id":"MDQ6VXNlcjgwNTUyNDI=","avatar_url":"https://avatars2.githubusercontent.com/u/8055242?v=4","gravatar_id":"","url":"https://api.github.com/users/ingvagabund","html_url":"https://github.com/ingvagabund","followers_url":"https://api.github.com/users/ingvagabund/followers","following_url":"https://api.github.com/users/ingvagabund/following{/other_user}","gists_url":"https://api.github.com/users/ingvagabund/gists{/gist_id}","starred_url":"https://api.github.com/users/ingvagabund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingvagabund/subscriptions","organizations_url":"https://api.github.com/users/ingvagabund/orgs","repos_url":"https://api.github.com/users/ingvagabund/repos","events_url":"https://api.github.com/users/ingvagabund/events{/privacy}","received_events_url":"https://api.github.com/users/ingvagabund/received_events","type":"User","site_admin":false},"labels":[{"id":1003572879,"node_id":"MDU6TGFiZWwxMDAzNTcyODc5","url":"https://api.github.com/repos/openshift/cluster-api-provider-aws/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":1003578039,"node_id":"MDU6TGFiZWwxMDAzNTc4MDM5","url":"https://api.github.com/repos/openshift/cluster-api-provider-aws/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":{"login":"paulfantom","id":3531758,"node_id":"MDQ6VXNlcjM1MzE3NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/3531758?v=4","gravatar_id":"","url":"https://api.github.com/users/paulfantom","html_url":"https://github.com/paulfantom","followers_url":"https://api.github.com/users/paulfantom/followers","following_url":"https://api.github.com/users/paulfantom/following{/other_user}","gists_url":"https://api.github.com/users/paulfantom/gists{/gist_id}","starred_url":"https://api.github.com/users/paulfantom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulfantom/subscriptions","organizations_url":"https://api.github.com/users/paulfantom/orgs","repos_url":"https://api.github.com/users/paulfantom/repos","events_url":"https://api.github.com/users/paulfantom/events{/privacy}","received_events_url":"https://api.github.com/users/paulfantom/received_events","type":"User","site_admin":false},"assignees":[{"login":"paulfantom","id":3531758,"node_id":"MDQ6VXNlcjM1MzE3NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/3531758?v=4","gravatar_id":"","url":"https://api.github.com/users/paulfantom","html_url":"https://github.com/paulfantom","followers_url":"https://api.github.com/users/paulfantom/followers","following_url":"https://api.github.com/users/paulfantom/following{/other_user}","gists_url":"https://api.github.com/users/paulfantom/gists{/gist_id}","starred_url":"https://api.github.com/users/paulfantom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulfantom/subscriptions","organizations_url":"https://api.github.com/users/paulfantom/orgs","repos_url":"https://api.github.com/users/paulfantom/repos","events_url":"https://api.github.com/users/paulfantom/events{/privacy}","received_events_url":"https://api.github.com/users/paulfantom/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-11-27T09:55:05Z","updated_at":"2018-11-27T13:43:29Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openshift/cluster-api-provider-aws/pulls/112","html_url":"https://github.com/openshift/cluster-api-provider-aws/pull/112","diff_url":"https://github.com/openshift/cluster-api-provider-aws/pull/112.diff","patch_url":"https://github.com/openshift/cluster-api-provider-aws/pull/112.patch"},"body":"- [ ] move testing aws client under machine actuator to eliminate exposure of actuator functions\r\n- [ ] open actuator-pkg PR to extend `CloudProviderClient` interface with additional methods (https://github.com/openshift/cluster-api-actuator-pkg/pull/22)\r\n- [ ] make more functions unexported\r\n- [ ] move code into more suitable locations (e.g. `instances.go`, `loadbalancers.go`\r\n- [ ] improve instance sorting"},"comment":{"url":"https://api.github.com/repos/openshift/cluster-api-provider-aws/issues/comments/442062309","html_url":"https://github.com/openshift/cluster-api-provider-aws/pull/112#issuecomment-442062309","issue_url":"https://api.github.com/repos/openshift/cluster-api-provider-aws/issues/112","id":442062309,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjA2MjMwOQ==","user":{"login":"openshift-ci-robot","id":30189103,"node_id":"MDQ6VXNlcjMwMTg5MTAz","avatar_url":"https://avatars1.githubusercontent.com/u/30189103?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-ci-robot","html_url":"https://github.com/openshift-ci-robot","followers_url":"https://api.github.com/users/openshift-ci-robot/followers","following_url":"https://api.github.com/users/openshift-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-ci-robot/orgs","repos_url":"https://api.github.com/users/openshift-ci-robot/repos","events_url":"https://api.github.com/users/openshift-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-11-27T13:43:29Z","updated_at":"2018-11-27T13:43:29Z","author_association":"NONE","body":"@ingvagabund: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nci/prow/e2e-aws | 71913d5f2d879cf404835faea119f34e4f45746b | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_cluster-api-provider-aws/112/pull-ci-openshift-cluster-api-provider-aws-master-e2e-aws/226) | `/test e2e-aws`\n\n[Full PR test history](https://openshift-gce-devel.appspot.com/pr/openshift_cluster-api-provider-aws/112). [Your PR dashboard](https://openshift-gce-devel.appspot.com/pr/ingvagabund). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/openshift/cluster-api-provider-aws/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"openshift-ci-robot"}}