{"action":"created","issue":{"url":"https://api.github.com/repos/StellarCN/py-stellar-base/issues/125","repository_url":"https://api.github.com/repos/StellarCN/py-stellar-base","labels_url":"https://api.github.com/repos/StellarCN/py-stellar-base/issues/125/labels{/name}","comments_url":"https://api.github.com/repos/StellarCN/py-stellar-base/issues/125/comments","events_url":"https://api.github.com/repos/StellarCN/py-stellar-base/issues/125/events","html_url":"https://github.com/StellarCN/py-stellar-base/pull/125","id":331663946,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MzM5MzY3","number":125,"title":"refactor operation construction","user":{"login":"aliciawyy","id":6472721,"node_id":"MDQ6VXNlcjY0NzI3MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/6472721?v=4","gravatar_id":"","url":"https://api.github.com/users/aliciawyy","html_url":"https://github.com/aliciawyy","followers_url":"https://api.github.com/users/aliciawyy/followers","following_url":"https://api.github.com/users/aliciawyy/following{/other_user}","gists_url":"https://api.github.com/users/aliciawyy/gists{/gist_id}","starred_url":"https://api.github.com/users/aliciawyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliciawyy/subscriptions","organizations_url":"https://api.github.com/users/aliciawyy/orgs","repos_url":"https://api.github.com/users/aliciawyy/repos","events_url":"https://api.github.com/users/aliciawyy/events{/privacy}","received_events_url":"https://api.github.com/users/aliciawyy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-12T16:31:59Z","updated_at":"2018-06-19T08:29:15Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/StellarCN/py-stellar-base/pulls/125","html_url":"https://github.com/StellarCN/py-stellar-base/pull/125","diff_url":"https://github.com/StellarCN/py-stellar-base/pull/125.diff","patch_url":"https://github.com/StellarCN/py-stellar-base/pull/125.patch"},"body":"Hi again,\r\n\r\nThis PR mainly\r\n- Refactored the operation construction from if ... else to subclass scan\r\n- Removed some redundant assert (no need to assert isinstance dict if later a .get is called)\r\n- Fixed some general error handling\r\n\r\nBy the way, it's really a good idea to change some dictionary argument like `opts` in `Transaction.__init__` to keyword arguments. Just it will introduce some breaking change, but it will be more user-friendly, what do you think ?"},"comment":{"url":"https://api.github.com/repos/StellarCN/py-stellar-base/issues/comments/398318521","html_url":"https://github.com/StellarCN/py-stellar-base/pull/125#issuecomment-398318521","issue_url":"https://api.github.com/repos/StellarCN/py-stellar-base/issues/125","id":398318521,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODMxODUyMQ==","user":{"login":"aliciawyy","id":6472721,"node_id":"MDQ6VXNlcjY0NzI3MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/6472721?v=4","gravatar_id":"","url":"https://api.github.com/users/aliciawyy","html_url":"https://github.com/aliciawyy","followers_url":"https://api.github.com/users/aliciawyy/followers","following_url":"https://api.github.com/users/aliciawyy/following{/other_user}","gists_url":"https://api.github.com/users/aliciawyy/gists{/gist_id}","starred_url":"https://api.github.com/users/aliciawyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliciawyy/subscriptions","organizations_url":"https://api.github.com/users/aliciawyy/orgs","repos_url":"https://api.github.com/users/aliciawyy/repos","events_url":"https://api.github.com/users/aliciawyy/events{/privacy}","received_events_url":"https://api.github.com/users/aliciawyy/received_events","type":"User","site_admin":false},"created_at":"2018-06-19T08:29:15Z","updated_at":"2018-06-19T08:29:15Z","author_association":"CONTRIBUTOR","body":"Hi @overcat, can you merge this change ?"}}
{"actor":{"display_login":"aliciawyy"}}