{"action":"created","comment":{"url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/pulls/comments/166613515","pull_request_review_id":94703121,"id":166613515,"diff_hunk":"@@ -53,6 +53,20 @@ Java_com_google_sample_oboe_hellooboe_PlaybackEngine_native_1setToneOn(JNIEnv *e\n     engine->setToneOn(isToneOn);\n }\n \n+JNIEXPORT void JNICALL\n+Java_com_google_sample_oboe_hellooboe_PlaybackEngine_native_1setAudioApi(JNIEnv *env, jclass type,","path":"oboe/hello-oboe/src/main/cpp/jni_bridge.cpp","position":5,"original_position":5,"commit_id":"736680ca779337ed28de6522f684c312ebe628c5","original_commit_id":"736680ca779337ed28de6522f684c312ebe628c5","user":{"login":"dturner","id":873212,"avatar_url":"https://avatars1.githubusercontent.com/u/873212?v=4","gravatar_id":"","url":"https://api.github.com/users/dturner","html_url":"https://github.com/dturner","followers_url":"https://api.github.com/users/dturner/followers","following_url":"https://api.github.com/users/dturner/following{/other_user}","gists_url":"https://api.github.com/users/dturner/gists{/gist_id}","starred_url":"https://api.github.com/users/dturner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dturner/subscriptions","organizations_url":"https://api.github.com/users/dturner/orgs","repos_url":"https://api.github.com/users/dturner/repos","events_url":"https://api.github.com/users/dturner/events{/privacy}","received_events_url":"https://api.github.com/users/dturner/received_events","type":"User","site_admin":false},"body":"Not sure what you mean. In C++ you can do `void method(param1, ...)` but explicit parameter types are preferable in this case. ","created_at":"2018-02-07T13:17:06Z","updated_at":"2018-02-07T13:17:06Z","html_url":"https://github.com/googlesamples/android-audio-high-performance/pull/102#discussion_r166613515","pull_request_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/pulls/102","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/googlesamples/android-audio-high-performance/pulls/comments/166613515"},"html":{"href":"https://github.com/googlesamples/android-audio-high-performance/pull/102#discussion_r166613515"},"pull_request":{"href":"https://api.github.com/repos/googlesamples/android-audio-high-performance/pulls/102"}},"in_reply_to_id":166569288},"pull_request":{"url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/pulls/102","id":167529092,"html_url":"https://github.com/googlesamples/android-audio-high-performance/pull/102","diff_url":"https://github.com/googlesamples/android-audio-high-performance/pull/102.diff","patch_url":"https://github.com/googlesamples/android-audio-high-performance/pull/102.patch","issue_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/issues/102","number":102,"state":"open","locked":false,"title":"hello-oboe: Allow explicit selection of audio API (OpenSLES or AAudio)","user":{"login":"dturner","id":873212,"avatar_url":"https://avatars1.githubusercontent.com/u/873212?v=4","gravatar_id":"","url":"https://api.github.com/users/dturner","html_url":"https://github.com/dturner","followers_url":"https://api.github.com/users/dturner/followers","following_url":"https://api.github.com/users/dturner/following{/other_user}","gists_url":"https://api.github.com/users/dturner/gists{/gist_id}","starred_url":"https://api.github.com/users/dturner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dturner/subscriptions","organizations_url":"https://api.github.com/users/dturner/orgs","repos_url":"https://api.github.com/users/dturner/repos","events_url":"https://api.github.com/users/dturner/events{/privacy}","received_events_url":"https://api.github.com/users/dturner/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-06T21:06:17Z","updated_at":"2018-02-07T13:17:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a26367a07ec23d7e685b93930d4d20c7d328f26","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/pulls/102/commits","review_comments_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/pulls/102/comments","review_comment_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/issues/102/comments","statuses_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/statuses/736680ca779337ed28de6522f684c312ebe628c5","head":{"label":"googlesamples:api-select","ref":"api-select","sha":"736680ca779337ed28de6522f684c312ebe628c5","user":{"login":"googlesamples","id":7378196,"avatar_url":"https://avatars3.githubusercontent.com/u/7378196?v=4","gravatar_id":"","url":"https://api.github.com/users/googlesamples","html_url":"https://github.com/googlesamples","followers_url":"https://api.github.com/users/googlesamples/followers","following_url":"https://api.github.com/users/googlesamples/following{/other_user}","gists_url":"https://api.github.com/users/googlesamples/gists{/gist_id}","starred_url":"https://api.github.com/users/googlesamples/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlesamples/subscriptions","organizations_url":"https://api.github.com/users/googlesamples/orgs","repos_url":"https://api.github.com/users/googlesamples/repos","events_url":"https://api.github.com/users/googlesamples/events{/privacy}","received_events_url":"https://api.github.com/users/googlesamples/received_events","type":"Organization","site_admin":false},"repo":{"id":43714189,"name":"android-audio-high-performance","full_name":"googlesamples/android-audio-high-performance","owner":{"login":"googlesamples","id":7378196,"avatar_url":"https://avatars3.githubusercontent.com/u/7378196?v=4","gravatar_id":"","url":"https://api.github.com/users/googlesamples","html_url":"https://github.com/googlesamples","followers_url":"https://api.github.com/users/googlesamples/followers","following_url":"https://api.github.com/users/googlesamples/following{/other_user}","gists_url":"https://api.github.com/users/googlesamples/gists{/gist_id}","starred_url":"https://api.github.com/users/googlesamples/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlesamples/subscriptions","organizations_url":"https://api.github.com/users/googlesamples/orgs","repos_url":"https://api.github.com/users/googlesamples/repos","events_url":"https://api.github.com/users/googlesamples/events{/privacy}","received_events_url":"https://api.github.com/users/googlesamples/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googlesamples/android-audio-high-performance","description":"Code samples and documentation for building high performance audio apps on Android","fork":false,"url":"https://api.github.com/repos/googlesamples/android-audio-high-performance","forks_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/forks","keys_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/teams","hooks_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/hooks","issue_events_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/issues/events{/number}","events_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/events","assignees_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/assignees{/user}","branches_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/branches{/branch}","tags_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/tags","blobs_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/statuses/{sha}","languages_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/languages","stargazers_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/stargazers","contributors_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/contributors","subscribers_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/subscribers","subscription_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/subscription","commits_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/contents/{+path}","compare_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/merges","archive_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/downloads","issues_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/issues{/number}","pulls_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/pulls{/number}","milestones_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/milestones{/number}","notifications_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/labels{/name}","releases_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/releases{/id}","deployments_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/deployments","created_at":"2015-10-05T21:13:26Z","updated_at":"2018-02-07T12:54:41Z","pushed_at":"2018-02-06T21:06:18Z","git_url":"git://github.com/googlesamples/android-audio-high-performance.git","ssh_url":"git@github.com:googlesamples/android-audio-high-performance.git","clone_url":"https://github.com/googlesamples/android-audio-high-performance.git","svn_url":"https://github.com/googlesamples/android-audio-high-performance","homepage":"https://developer.android.com/ndk/guides/audio/","size":3234,"stargazers_count":419,"watchers_count":419,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":156,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":156,"open_issues":15,"watchers":419,"default_branch":"master"}},"base":{"label":"googlesamples:master","ref":"master","sha":"b6b1ce42d60a77a94ec068e16e88c2ba15755acc","user":{"login":"googlesamples","id":7378196,"avatar_url":"https://avatars3.githubusercontent.com/u/7378196?v=4","gravatar_id":"","url":"https://api.github.com/users/googlesamples","html_url":"https://github.com/googlesamples","followers_url":"https://api.github.com/users/googlesamples/followers","following_url":"https://api.github.com/users/googlesamples/following{/other_user}","gists_url":"https://api.github.com/users/googlesamples/gists{/gist_id}","starred_url":"https://api.github.com/users/googlesamples/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlesamples/subscriptions","organizations_url":"https://api.github.com/users/googlesamples/orgs","repos_url":"https://api.github.com/users/googlesamples/repos","events_url":"https://api.github.com/users/googlesamples/events{/privacy}","received_events_url":"https://api.github.com/users/googlesamples/received_events","type":"Organization","site_admin":false},"repo":{"id":43714189,"name":"android-audio-high-performance","full_name":"googlesamples/android-audio-high-performance","owner":{"login":"googlesamples","id":7378196,"avatar_url":"https://avatars3.githubusercontent.com/u/7378196?v=4","gravatar_id":"","url":"https://api.github.com/users/googlesamples","html_url":"https://github.com/googlesamples","followers_url":"https://api.github.com/users/googlesamples/followers","following_url":"https://api.github.com/users/googlesamples/following{/other_user}","gists_url":"https://api.github.com/users/googlesamples/gists{/gist_id}","starred_url":"https://api.github.com/users/googlesamples/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlesamples/subscriptions","organizations_url":"https://api.github.com/users/googlesamples/orgs","repos_url":"https://api.github.com/users/googlesamples/repos","events_url":"https://api.github.com/users/googlesamples/events{/privacy}","received_events_url":"https://api.github.com/users/googlesamples/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googlesamples/android-audio-high-performance","description":"Code samples and documentation for building high performance audio apps on Android","fork":false,"url":"https://api.github.com/repos/googlesamples/android-audio-high-performance","forks_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/forks","keys_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/teams","hooks_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/hooks","issue_events_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/issues/events{/number}","events_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/events","assignees_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/assignees{/user}","branches_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/branches{/branch}","tags_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/tags","blobs_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/statuses/{sha}","languages_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/languages","stargazers_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/stargazers","contributors_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/contributors","subscribers_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/subscribers","subscription_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/subscription","commits_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/contents/{+path}","compare_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/merges","archive_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/downloads","issues_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/issues{/number}","pulls_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/pulls{/number}","milestones_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/milestones{/number}","notifications_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/labels{/name}","releases_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/releases{/id}","deployments_url":"https://api.github.com/repos/googlesamples/android-audio-high-performance/deployments","created_at":"2015-10-05T21:13:26Z","updated_at":"2018-02-07T12:54:41Z","pushed_at":"2018-02-06T21:06:18Z","git_url":"git://github.com/googlesamples/android-audio-high-performance.git","ssh_url":"git@github.com:googlesamples/android-audio-high-performance.git","clone_url":"https://github.com/googlesamples/android-audio-high-performance.git","svn_url":"https://github.com/googlesamples/android-audio-high-performance","homepage":"https://developer.android.com/ndk/guides/audio/","size":3234,"stargazers_count":419,"watchers_count":419,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":156,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":156,"open_issues":15,"watchers":419,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googlesamples/android-audio-high-performance/pulls/102"},"html":{"href":"https://github.com/googlesamples/android-audio-high-performance/pull/102"},"issue":{"href":"https://api.github.com/repos/googlesamples/android-audio-high-performance/issues/102"},"comments":{"href":"https://api.github.com/repos/googlesamples/android-audio-high-performance/issues/102/comments"},"review_comments":{"href":"https://api.github.com/repos/googlesamples/android-audio-high-performance/pulls/102/comments"},"review_comment":{"href":"https://api.github.com/repos/googlesamples/android-audio-high-performance/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googlesamples/android-audio-high-performance/pulls/102/commits"},"statuses":{"href":"https://api.github.com/repos/googlesamples/android-audio-high-performance/statuses/736680ca779337ed28de6522f684c312ebe628c5"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"dturner"}}