{"action":"created","issue":{"url":"https://api.github.com/repos/spring-projects/spring-boot/issues/11916","repository_url":"https://api.github.com/repos/spring-projects/spring-boot","labels_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/11916/labels{/name}","comments_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/11916/comments","events_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/11916/events","html_url":"https://github.com/spring-projects/spring-boot/issues/11916","id":294610955,"number":11916,"title":"Tomcat metrics are not exposed","user":{"login":"shakuzen","id":8924140,"avatar_url":"https://avatars2.githubusercontent.com/u/8924140?v=4","gravatar_id":"","url":"https://api.github.com/users/shakuzen","html_url":"https://github.com/shakuzen","followers_url":"https://api.github.com/users/shakuzen/followers","following_url":"https://api.github.com/users/shakuzen/following{/other_user}","gists_url":"https://api.github.com/users/shakuzen/gists{/gist_id}","starred_url":"https://api.github.com/users/shakuzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakuzen/subscriptions","organizations_url":"https://api.github.com/users/shakuzen/orgs","repos_url":"https://api.github.com/users/shakuzen/repos","events_url":"https://api.github.com/users/shakuzen/events{/privacy}","received_events_url":"https://api.github.com/users/shakuzen/received_events","type":"User","site_admin":false},"labels":[{"id":514595823,"url":"https://api.github.com/repos/spring-projects/spring-boot/labels/priority:%20normal","name":"priority: normal","color":"c2e0c6","default":false},{"id":16916893,"url":"https://api.github.com/repos/spring-projects/spring-boot/labels/type:%20enhancement","name":"type: enhancement","color":"d4c5f9","default":false}],"state":"closed","locked":false,"assignee":{"login":"wilkinsona","id":914682,"avatar_url":"https://avatars3.githubusercontent.com/u/914682?v=4","gravatar_id":"","url":"https://api.github.com/users/wilkinsona","html_url":"https://github.com/wilkinsona","followers_url":"https://api.github.com/users/wilkinsona/followers","following_url":"https://api.github.com/users/wilkinsona/following{/other_user}","gists_url":"https://api.github.com/users/wilkinsona/gists{/gist_id}","starred_url":"https://api.github.com/users/wilkinsona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilkinsona/subscriptions","organizations_url":"https://api.github.com/users/wilkinsona/orgs","repos_url":"https://api.github.com/users/wilkinsona/repos","events_url":"https://api.github.com/users/wilkinsona/events{/privacy}","received_events_url":"https://api.github.com/users/wilkinsona/received_events","type":"User","site_admin":false},"assignees":[{"login":"wilkinsona","id":914682,"avatar_url":"https://avatars3.githubusercontent.com/u/914682?v=4","gravatar_id":"","url":"https://api.github.com/users/wilkinsona","html_url":"https://github.com/wilkinsona","followers_url":"https://api.github.com/users/wilkinsona/followers","following_url":"https://api.github.com/users/wilkinsona/following{/other_user}","gists_url":"https://api.github.com/users/wilkinsona/gists{/gist_id}","starred_url":"https://api.github.com/users/wilkinsona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilkinsona/subscriptions","organizations_url":"https://api.github.com/users/wilkinsona/orgs","repos_url":"https://api.github.com/users/wilkinsona/repos","events_url":"https://api.github.com/users/wilkinsona/events{/privacy}","received_events_url":"https://api.github.com/users/wilkinsona/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/spring-projects/spring-boot/milestones/95","html_url":"https://github.com/spring-projects/spring-boot/milestone/95","labels_url":"https://api.github.com/repos/spring-projects/spring-boot/milestones/95/labels","id":2931499,"number":95,"title":"2.0.0.RC2","description":"","creator":{"login":"philwebb","id":519772,"avatar_url":"https://avatars1.githubusercontent.com/u/519772?v=4","gravatar_id":"","url":"https://api.github.com/users/philwebb","html_url":"https://github.com/philwebb","followers_url":"https://api.github.com/users/philwebb/followers","following_url":"https://api.github.com/users/philwebb/following{/other_user}","gists_url":"https://api.github.com/users/philwebb/gists{/gist_id}","starred_url":"https://api.github.com/users/philwebb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philwebb/subscriptions","organizations_url":"https://api.github.com/users/philwebb/orgs","repos_url":"https://api.github.com/users/philwebb/repos","events_url":"https://api.github.com/users/philwebb/events{/privacy}","received_events_url":"https://api.github.com/users/philwebb/received_events","type":"User","site_admin":false},"open_issues":22,"closed_issues":103,"state":"open","created_at":"2017-11-22T16:36:47Z","updated_at":"2018-02-14T01:12:57Z","due_on":"2018-02-20T08:00:00Z","closed_at":null},"comments":0,"created_at":"2018-02-06T02:27:25Z","updated_at":"2018-02-14T02:22:59Z","closed_at":"2018-02-13T12:48:10Z","author_association":"CONTRIBUTOR","body":"Micrometer's `micrometer-spring-legacy` project has `TomcatMetricsConfiguration` to provide Tomcat-specific metrics (which were available in Spring Boot 1.5 in some form). This is currently (Spring Boot 2.0.0.RC1) missing in Spring Boot 2 code, so no Tomcat metrics are available.\r\n\r\nhttps://github.com/micrometer-metrics/micrometer/blob/fadd1ee0b758f983841bbef3235d10f3ada86fb4/micrometer-spring-legacy/src/main/java/io/micrometer/spring/autoconfigure/web/tomcat/TomcatMetricsConfiguration.java"},"comment":{"url":"https://api.github.com/repos/spring-projects/spring-boot/issues/comments/365474873","html_url":"https://github.com/spring-projects/spring-boot/issues/11916#issuecomment-365474873","issue_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/11916","id":365474873,"user":{"login":"shakuzen","id":8924140,"avatar_url":"https://avatars2.githubusercontent.com/u/8924140?v=4","gravatar_id":"","url":"https://api.github.com/users/shakuzen","html_url":"https://github.com/shakuzen","followers_url":"https://api.github.com/users/shakuzen/followers","following_url":"https://api.github.com/users/shakuzen/following{/other_user}","gists_url":"https://api.github.com/users/shakuzen/gists{/gist_id}","starred_url":"https://api.github.com/users/shakuzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakuzen/subscriptions","organizations_url":"https://api.github.com/users/shakuzen/orgs","repos_url":"https://api.github.com/users/shakuzen/repos","events_url":"https://api.github.com/users/shakuzen/events{/privacy}","received_events_url":"https://api.github.com/users/shakuzen/received_events","type":"User","site_admin":false},"created_at":"2018-02-14T02:22:58Z","updated_at":"2018-02-14T02:22:58Z","author_association":"CONTRIBUTOR","body":"@wilkinsona I think there might be an ordering issue. When I debug the auto-configuration, I'm seeing `WebServerApplicationContext#getWebServer` always returning `null` here, which results in all the Tomcat session metrics not being available. When I was trying to implement this issue myself, I couldn't figure out what to change to get this to run after the `WebServer` is available."}}
{"actor":{"display_login":"shakuzen"}}