{"action":"created","comment":{"url":"https://api.github.com/repos/starweb/starlit-app/pulls/comments/218436437","pull_request_review_id":156364813,"id":218436437,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODQzNjQzNw==","diff_hunk":"@@ -36,76 +41,128 @@ class Container implements ContainerInterface\n      * @param mixed  $value\n      * @return Container\n      */\n-    public function set($key, $value)\n+    public function set(string $key, $value): self\n     {\n+        if (!(\\is_string($value) || \\is_object($value))) {\n+            throw new \\InvalidArgumentException('Value must be a class name, an object instance, or a callable');\n+        }\n+\n         $this->dicValues[$key] = $value;\n         unset($this->dicObjects[$key]); // In case an object instance was stored for sharing\n \n         return $this;\n     }\n \n+    public function alias(string $alias, string $key): self {","path":"src/Container/Container.php","position":29,"original_position":29,"commit_id":"5921a5e9f637c8f3800a46933d283e3e32b42226","original_commit_id":"5921a5e9f637c8f3800a46933d283e3e32b42226","user":{"login":"lordrhodos","id":807902,"node_id":"MDQ6VXNlcjgwNzkwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/807902?v=4","gravatar_id":"","url":"https://api.github.com/users/lordrhodos","html_url":"https://github.com/lordrhodos","followers_url":"https://api.github.com/users/lordrhodos/followers","following_url":"https://api.github.com/users/lordrhodos/following{/other_user}","gists_url":"https://api.github.com/users/lordrhodos/gists{/gist_id}","starred_url":"https://api.github.com/users/lordrhodos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lordrhodos/subscriptions","organizations_url":"https://api.github.com/users/lordrhodos/orgs","repos_url":"https://api.github.com/users/lordrhodos/repos","events_url":"https://api.github.com/users/lordrhodos/events{/privacy}","received_events_url":"https://api.github.com/users/lordrhodos/received_events","type":"User","site_admin":false},"body":"shouldn't the openening curly bracket go on the next line?","created_at":"2018-09-18T13:42:17Z","updated_at":"2018-09-18T13:50:42Z","html_url":"https://github.com/starweb/starlit-app/pull/3#discussion_r218436437","pull_request_url":"https://api.github.com/repos/starweb/starlit-app/pulls/3","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/starweb/starlit-app/pulls/comments/218436437"},"html":{"href":"https://github.com/starweb/starlit-app/pull/3#discussion_r218436437"},"pull_request":{"href":"https://api.github.com/repos/starweb/starlit-app/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/starweb/starlit-app/pulls/3","id":216305920,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MzA1OTIw","html_url":"https://github.com/starweb/starlit-app/pull/3","diff_url":"https://github.com/starweb/starlit-app/pull/3.diff","patch_url":"https://github.com/starweb/starlit-app/pull/3.patch","issue_url":"https://api.github.com/repos/starweb/starlit-app/issues/3","number":3,"state":"open","locked":false,"title":"Feature/reflection based dependency injection","user":{"login":"PaulPylkas","id":38281739,"node_id":"MDQ6VXNlcjM4MjgxNzM5","avatar_url":"https://avatars3.githubusercontent.com/u/38281739?v=4","gravatar_id":"","url":"https://api.github.com/users/PaulPylkas","html_url":"https://github.com/PaulPylkas","followers_url":"https://api.github.com/users/PaulPylkas/followers","following_url":"https://api.github.com/users/PaulPylkas/following{/other_user}","gists_url":"https://api.github.com/users/PaulPylkas/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulPylkas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulPylkas/subscriptions","organizations_url":"https://api.github.com/users/PaulPylkas/orgs","repos_url":"https://api.github.com/users/PaulPylkas/repos","events_url":"https://api.github.com/users/PaulPylkas/events{/privacy}","received_events_url":"https://api.github.com/users/PaulPylkas/received_events","type":"User","site_admin":false},"body":"Implements automatic, recursive, reflection-based resolution of dependencies into the DI Container.\r\n\r\nThis will allow for simpler service providers in most cases.","created_at":"2018-09-18T13:22:55Z","updated_at":"2018-09-18T13:50:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63c8e6c0df4e02163c703b8583c87c2856f4ea48","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/starweb/starlit-app/pulls/3/commits","review_comments_url":"https://api.github.com/repos/starweb/starlit-app/pulls/3/comments","review_comment_url":"https://api.github.com/repos/starweb/starlit-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/starweb/starlit-app/issues/3/comments","statuses_url":"https://api.github.com/repos/starweb/starlit-app/statuses/5921a5e9f637c8f3800a46933d283e3e32b42226","head":{"label":"PaulPylkas:feature/reflection-based_dependency_injection","ref":"feature/reflection-based_dependency_injection","sha":"5921a5e9f637c8f3800a46933d283e3e32b42226","user":{"login":"PaulPylkas","id":38281739,"node_id":"MDQ6VXNlcjM4MjgxNzM5","avatar_url":"https://avatars3.githubusercontent.com/u/38281739?v=4","gravatar_id":"","url":"https://api.github.com/users/PaulPylkas","html_url":"https://github.com/PaulPylkas","followers_url":"https://api.github.com/users/PaulPylkas/followers","following_url":"https://api.github.com/users/PaulPylkas/following{/other_user}","gists_url":"https://api.github.com/users/PaulPylkas/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulPylkas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulPylkas/subscriptions","organizations_url":"https://api.github.com/users/PaulPylkas/orgs","repos_url":"https://api.github.com/users/PaulPylkas/repos","events_url":"https://api.github.com/users/PaulPylkas/events{/privacy}","received_events_url":"https://api.github.com/users/PaulPylkas/received_events","type":"User","site_admin":false},"repo":{"id":149134511,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkxMzQ1MTE=","name":"starlit-app","full_name":"PaulPylkas/starlit-app","private":false,"owner":{"login":"PaulPylkas","id":38281739,"node_id":"MDQ6VXNlcjM4MjgxNzM5","avatar_url":"https://avatars3.githubusercontent.com/u/38281739?v=4","gravatar_id":"","url":"https://api.github.com/users/PaulPylkas","html_url":"https://github.com/PaulPylkas","followers_url":"https://api.github.com/users/PaulPylkas/followers","following_url":"https://api.github.com/users/PaulPylkas/following{/other_user}","gists_url":"https://api.github.com/users/PaulPylkas/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulPylkas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulPylkas/subscriptions","organizations_url":"https://api.github.com/users/PaulPylkas/orgs","repos_url":"https://api.github.com/users/PaulPylkas/repos","events_url":"https://api.github.com/users/PaulPylkas/events{/privacy}","received_events_url":"https://api.github.com/users/PaulPylkas/received_events","type":"User","site_admin":false},"html_url":"https://github.com/PaulPylkas/starlit-app","description":"A lightweight PHP MVC style microframework.","fork":true,"url":"https://api.github.com/repos/PaulPylkas/starlit-app","forks_url":"https://api.github.com/repos/PaulPylkas/starlit-app/forks","keys_url":"https://api.github.com/repos/PaulPylkas/starlit-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PaulPylkas/starlit-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PaulPylkas/starlit-app/teams","hooks_url":"https://api.github.com/repos/PaulPylkas/starlit-app/hooks","issue_events_url":"https://api.github.com/repos/PaulPylkas/starlit-app/issues/events{/number}","events_url":"https://api.github.com/repos/PaulPylkas/starlit-app/events","assignees_url":"https://api.github.com/repos/PaulPylkas/starlit-app/assignees{/user}","branches_url":"https://api.github.com/repos/PaulPylkas/starlit-app/branches{/branch}","tags_url":"https://api.github.com/repos/PaulPylkas/starlit-app/tags","blobs_url":"https://api.github.com/repos/PaulPylkas/starlit-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PaulPylkas/starlit-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PaulPylkas/starlit-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/PaulPylkas/starlit-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PaulPylkas/starlit-app/statuses/{sha}","languages_url":"https://api.github.com/repos/PaulPylkas/starlit-app/languages","stargazers_url":"https://api.github.com/repos/PaulPylkas/starlit-app/stargazers","contributors_url":"https://api.github.com/repos/PaulPylkas/starlit-app/contributors","subscribers_url":"https://api.github.com/repos/PaulPylkas/starlit-app/subscribers","subscription_url":"https://api.github.com/repos/PaulPylkas/starlit-app/subscription","commits_url":"https://api.github.com/repos/PaulPylkas/starlit-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/PaulPylkas/starlit-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/PaulPylkas/starlit-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/PaulPylkas/starlit-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/PaulPylkas/starlit-app/contents/{+path}","compare_url":"https://api.github.com/repos/PaulPylkas/starlit-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PaulPylkas/starlit-app/merges","archive_url":"https://api.github.com/repos/PaulPylkas/starlit-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PaulPylkas/starlit-app/downloads","issues_url":"https://api.github.com/repos/PaulPylkas/starlit-app/issues{/number}","pulls_url":"https://api.github.com/repos/PaulPylkas/starlit-app/pulls{/number}","milestones_url":"https://api.github.com/repos/PaulPylkas/starlit-app/milestones{/number}","notifications_url":"https://api.github.com/repos/PaulPylkas/starlit-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PaulPylkas/starlit-app/labels{/name}","releases_url":"https://api.github.com/repos/PaulPylkas/starlit-app/releases{/id}","deployments_url":"https://api.github.com/repos/PaulPylkas/starlit-app/deployments","created_at":"2018-09-17T14:04:16Z","updated_at":"2018-09-17T14:04:18Z","pushed_at":"2018-09-18T13:20:25Z","git_url":"git://github.com/PaulPylkas/starlit-app.git","ssh_url":"git@github.com:PaulPylkas/starlit-app.git","clone_url":"https://github.com/PaulPylkas/starlit-app.git","svn_url":"https://github.com/PaulPylkas/starlit-app","homepage":"","size":41,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"starweb:master","ref":"master","sha":"780f28b8faa843a0446718f05b45fd6c8124ce67","user":{"login":"starweb","id":1343870,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDM4NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1343870?v=4","gravatar_id":"","url":"https://api.github.com/users/starweb","html_url":"https://github.com/starweb","followers_url":"https://api.github.com/users/starweb/followers","following_url":"https://api.github.com/users/starweb/following{/other_user}","gists_url":"https://api.github.com/users/starweb/gists{/gist_id}","starred_url":"https://api.github.com/users/starweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starweb/subscriptions","organizations_url":"https://api.github.com/users/starweb/orgs","repos_url":"https://api.github.com/users/starweb/repos","events_url":"https://api.github.com/users/starweb/events{/privacy}","received_events_url":"https://api.github.com/users/starweb/received_events","type":"Organization","site_admin":false},"repo":{"id":48774299,"node_id":"MDEwOlJlcG9zaXRvcnk0ODc3NDI5OQ==","name":"starlit-app","full_name":"starweb/starlit-app","private":false,"owner":{"login":"starweb","id":1343870,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDM4NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1343870?v=4","gravatar_id":"","url":"https://api.github.com/users/starweb","html_url":"https://github.com/starweb","followers_url":"https://api.github.com/users/starweb/followers","following_url":"https://api.github.com/users/starweb/following{/other_user}","gists_url":"https://api.github.com/users/starweb/gists{/gist_id}","starred_url":"https://api.github.com/users/starweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starweb/subscriptions","organizations_url":"https://api.github.com/users/starweb/orgs","repos_url":"https://api.github.com/users/starweb/repos","events_url":"https://api.github.com/users/starweb/events{/privacy}","received_events_url":"https://api.github.com/users/starweb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/starweb/starlit-app","description":"A lightweight PHP MVC style microframework.","fork":false,"url":"https://api.github.com/repos/starweb/starlit-app","forks_url":"https://api.github.com/repos/starweb/starlit-app/forks","keys_url":"https://api.github.com/repos/starweb/starlit-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/starweb/starlit-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/starweb/starlit-app/teams","hooks_url":"https://api.github.com/repos/starweb/starlit-app/hooks","issue_events_url":"https://api.github.com/repos/starweb/starlit-app/issues/events{/number}","events_url":"https://api.github.com/repos/starweb/starlit-app/events","assignees_url":"https://api.github.com/repos/starweb/starlit-app/assignees{/user}","branches_url":"https://api.github.com/repos/starweb/starlit-app/branches{/branch}","tags_url":"https://api.github.com/repos/starweb/starlit-app/tags","blobs_url":"https://api.github.com/repos/starweb/starlit-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/starweb/starlit-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/starweb/starlit-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/starweb/starlit-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/starweb/starlit-app/statuses/{sha}","languages_url":"https://api.github.com/repos/starweb/starlit-app/languages","stargazers_url":"https://api.github.com/repos/starweb/starlit-app/stargazers","contributors_url":"https://api.github.com/repos/starweb/starlit-app/contributors","subscribers_url":"https://api.github.com/repos/starweb/starlit-app/subscribers","subscription_url":"https://api.github.com/repos/starweb/starlit-app/subscription","commits_url":"https://api.github.com/repos/starweb/starlit-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/starweb/starlit-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/starweb/starlit-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/starweb/starlit-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/starweb/starlit-app/contents/{+path}","compare_url":"https://api.github.com/repos/starweb/starlit-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/starweb/starlit-app/merges","archive_url":"https://api.github.com/repos/starweb/starlit-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/starweb/starlit-app/downloads","issues_url":"https://api.github.com/repos/starweb/starlit-app/issues{/number}","pulls_url":"https://api.github.com/repos/starweb/starlit-app/pulls{/number}","milestones_url":"https://api.github.com/repos/starweb/starlit-app/milestones{/number}","notifications_url":"https://api.github.com/repos/starweb/starlit-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/starweb/starlit-app/labels{/name}","releases_url":"https://api.github.com/repos/starweb/starlit-app/releases{/id}","deployments_url":"https://api.github.com/repos/starweb/starlit-app/deployments","created_at":"2015-12-30T01:09:29Z","updated_at":"2018-09-18T08:56:31Z","pushed_at":"2018-09-18T13:22:56Z","git_url":"git://github.com/starweb/starlit-app.git","ssh_url":"git@github.com:starweb/starlit-app.git","clone_url":"https://github.com/starweb/starlit-app.git","svn_url":"https://github.com/starweb/starlit-app","homepage":"","size":36,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/starweb/starlit-app/pulls/3"},"html":{"href":"https://github.com/starweb/starlit-app/pull/3"},"issue":{"href":"https://api.github.com/repos/starweb/starlit-app/issues/3"},"comments":{"href":"https://api.github.com/repos/starweb/starlit-app/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/starweb/starlit-app/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/starweb/starlit-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/starweb/starlit-app/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/starweb/starlit-app/statuses/5921a5e9f637c8f3800a46933d283e3e32b42226"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lordrhodos"}}