{"action":"created","comment":{"url":"https://api.github.com/repos/bazelbuild/bazel/pulls/comments/176083308","pull_request_review_id":105722866,"id":176083308,"diff_hunk":"@@ -190,15 +190,17 @@ def _find_vcvarsall_bat_script(repository_ctx, vc_path):\n   return vcvarsall\n \n \n-def _find_env_vars(repository_ctx, vc_path):\n+def setup_vc_env_vars(repository_ctx, vc_path):\n   \"\"\"Get environment variables set by VCVARSALL.BAT. Doesn't %-escape the result!\"\"\"","path":"tools/cpp/windows_cc_configure.bzl","position":6,"original_position":6,"commit_id":"1c43bfbca5cbbfdac853abb9e88df0f99841ab7f","original_commit_id":"1c43bfbca5cbbfdac853abb9e88df0f99841ab7f","user":{"login":"meteorcloudy","id":4171702,"avatar_url":"https://avatars2.githubusercontent.com/u/4171702?v=4","gravatar_id":"","url":"https://api.github.com/users/meteorcloudy","html_url":"https://github.com/meteorcloudy","followers_url":"https://api.github.com/users/meteorcloudy/followers","following_url":"https://api.github.com/users/meteorcloudy/following{/other_user}","gists_url":"https://api.github.com/users/meteorcloudy/gists{/gist_id}","starred_url":"https://api.github.com/users/meteorcloudy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteorcloudy/subscriptions","organizations_url":"https://api.github.com/users/meteorcloudy/orgs","repos_url":"https://api.github.com/users/meteorcloudy/repos","events_url":"https://api.github.com/users/meteorcloudy/events{/privacy}","received_events_url":"https://api.github.com/users/meteorcloudy/received_events","type":"User","site_admin":false},"body":"Escape % for strings, it would corrupt the CROSSTOOL file because we use %{var_name} for replacement.\r\nSee https://github.com/bazelbuild/bazel/blob/db80298391bd953b1a1f8e9bb83c2d4c2f3747b4/tools/cpp/lib_cc_configure.bzl#L18","created_at":"2018-03-21T13:39:25Z","updated_at":"2018-03-21T13:39:25Z","html_url":"https://github.com/bazelbuild/bazel/pull/4892#discussion_r176083308","pull_request_url":"https://api.github.com/repos/bazelbuild/bazel/pulls/4892","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/bazelbuild/bazel/pulls/comments/176083308"},"html":{"href":"https://github.com/bazelbuild/bazel/pull/4892#discussion_r176083308"},"pull_request":{"href":"https://api.github.com/repos/bazelbuild/bazel/pulls/4892"}},"in_reply_to_id":176076022},"pull_request":{"url":"https://api.github.com/repos/bazelbuild/bazel/pulls/4892","id":176429758,"html_url":"https://github.com/bazelbuild/bazel/pull/4892","diff_url":"https://github.com/bazelbuild/bazel/pull/4892.diff","patch_url":"https://github.com/bazelbuild/bazel/pull/4892.patch","issue_url":"https://api.github.com/repos/bazelbuild/bazel/issues/4892","number":4892,"state":"open","locked":false,"title":"Windows: Expose setup_vc_env_vars function from windows_cc_configure.bzl","user":{"login":"meteorcloudy","id":4171702,"avatar_url":"https://avatars2.githubusercontent.com/u/4171702?v=4","gravatar_id":"","url":"https://api.github.com/users/meteorcloudy","html_url":"https://github.com/meteorcloudy","followers_url":"https://api.github.com/users/meteorcloudy/followers","following_url":"https://api.github.com/users/meteorcloudy/following{/other_user}","gists_url":"https://api.github.com/users/meteorcloudy/gists{/gist_id}","starred_url":"https://api.github.com/users/meteorcloudy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteorcloudy/subscriptions","organizations_url":"https://api.github.com/users/meteorcloudy/orgs","repos_url":"https://api.github.com/users/meteorcloudy/repos","events_url":"https://api.github.com/users/meteorcloudy/events{/privacy}","received_events_url":"https://api.github.com/users/meteorcloudy/received_events","type":"User","site_admin":false},"body":"`setup_vc_env_vars` runs vcvarsall.bat to setup environment varibles for Visuall C++ build tools.\r\nIt returns the values of PATH, LIB, INCLUDE and WINDOWSSDKDIR.\r\n\r\nExpose this function so that users can use\r\n\r\n  load(\"@bazel_tools/tools/cpp:windows_cc_configure.bzl\", \"setup_vc_env_vars\")\r\n\r\nto access this function.\r\n\r\nFixed https://github.com/bazelbuild/bazel/issues/4542\r\n\r\nRELNOTES[NEW]:\r\nNow you can access three functions in windows_cc_configure.bzl by:\r\n  load(\"@bazel_tools/tools/cpp:windows_cc_configure.bzl\", \"<function_name>\")\r\n\r\n  1. find_vc_path(repository_ctx): Detect the VC installation path on your machine, respect BAZEL_VC first, return None if VC not found.\r\n  2. setup_vc_env_vars(repository_ctx, vc_path): Get PATH, LIB, INCLUDE, WINDOWSSDKDIR env vars set by VCVARSALL.bat, return None if VCVARSALL.bat not found.\r\n  3. find_msvc_tool(repository_ctx, vc_path, tool): Find a certain VC build tool (eg. cl.exe, lib.exe, link.exe), return None if tool not found.\r\n\r\nChange-Id: Iec5770165aaa4766470bb3b4d818a2cf90678586","created_at":"2018-03-21T10:16:09Z","updated_at":"2018-03-21T13:39:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"513330b39009522a801695defedb2a475d575151","assignee":{"login":"laszlocsomor","id":10532244,"avatar_url":"https://avatars0.githubusercontent.com/u/10532244?v=4","gravatar_id":"","url":"https://api.github.com/users/laszlocsomor","html_url":"https://github.com/laszlocsomor","followers_url":"https://api.github.com/users/laszlocsomor/followers","following_url":"https://api.github.com/users/laszlocsomor/following{/other_user}","gists_url":"https://api.github.com/users/laszlocsomor/gists{/gist_id}","starred_url":"https://api.github.com/users/laszlocsomor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laszlocsomor/subscriptions","organizations_url":"https://api.github.com/users/laszlocsomor/orgs","repos_url":"https://api.github.com/users/laszlocsomor/repos","events_url":"https://api.github.com/users/laszlocsomor/events{/privacy}","received_events_url":"https://api.github.com/users/laszlocsomor/received_events","type":"User","site_admin":false},"assignees":[{"login":"laszlocsomor","id":10532244,"avatar_url":"https://avatars0.githubusercontent.com/u/10532244?v=4","gravatar_id":"","url":"https://api.github.com/users/laszlocsomor","html_url":"https://github.com/laszlocsomor","followers_url":"https://api.github.com/users/laszlocsomor/followers","following_url":"https://api.github.com/users/laszlocsomor/following{/other_user}","gists_url":"https://api.github.com/users/laszlocsomor/gists{/gist_id}","starred_url":"https://api.github.com/users/laszlocsomor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laszlocsomor/subscriptions","organizations_url":"https://api.github.com/users/laszlocsomor/orgs","repos_url":"https://api.github.com/users/laszlocsomor/repos","events_url":"https://api.github.com/users/laszlocsomor/events{/privacy}","received_events_url":"https://api.github.com/users/laszlocsomor/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":323761238,"url":"https://api.github.com/repos/bazelbuild/bazel/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bazelbuild/bazel/pulls/4892/commits","review_comments_url":"https://api.github.com/repos/bazelbuild/bazel/pulls/4892/comments","review_comment_url":"https://api.github.com/repos/bazelbuild/bazel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bazelbuild/bazel/issues/4892/comments","statuses_url":"https://api.github.com/repos/bazelbuild/bazel/statuses/1c43bfbca5cbbfdac853abb9e88df0f99841ab7f","head":{"label":"meteorcloudy:expose_windowssdkdir","ref":"expose_windowssdkdir","sha":"1c43bfbca5cbbfdac853abb9e88df0f99841ab7f","user":{"login":"meteorcloudy","id":4171702,"avatar_url":"https://avatars2.githubusercontent.com/u/4171702?v=4","gravatar_id":"","url":"https://api.github.com/users/meteorcloudy","html_url":"https://github.com/meteorcloudy","followers_url":"https://api.github.com/users/meteorcloudy/followers","following_url":"https://api.github.com/users/meteorcloudy/following{/other_user}","gists_url":"https://api.github.com/users/meteorcloudy/gists{/gist_id}","starred_url":"https://api.github.com/users/meteorcloudy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteorcloudy/subscriptions","organizations_url":"https://api.github.com/users/meteorcloudy/orgs","repos_url":"https://api.github.com/users/meteorcloudy/repos","events_url":"https://api.github.com/users/meteorcloudy/events{/privacy}","received_events_url":"https://api.github.com/users/meteorcloudy/received_events","type":"User","site_admin":false},"repo":{"id":58738893,"name":"bazel","full_name":"meteorcloudy/bazel","owner":{"login":"meteorcloudy","id":4171702,"avatar_url":"https://avatars2.githubusercontent.com/u/4171702?v=4","gravatar_id":"","url":"https://api.github.com/users/meteorcloudy","html_url":"https://github.com/meteorcloudy","followers_url":"https://api.github.com/users/meteorcloudy/followers","following_url":"https://api.github.com/users/meteorcloudy/following{/other_user}","gists_url":"https://api.github.com/users/meteorcloudy/gists{/gist_id}","starred_url":"https://api.github.com/users/meteorcloudy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteorcloudy/subscriptions","organizations_url":"https://api.github.com/users/meteorcloudy/orgs","repos_url":"https://api.github.com/users/meteorcloudy/repos","events_url":"https://api.github.com/users/meteorcloudy/events{/privacy}","received_events_url":"https://api.github.com/users/meteorcloudy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/meteorcloudy/bazel","description":"Correct, reproducible, and fast builds for everyone.","fork":true,"url":"https://api.github.com/repos/meteorcloudy/bazel","forks_url":"https://api.github.com/repos/meteorcloudy/bazel/forks","keys_url":"https://api.github.com/repos/meteorcloudy/bazel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meteorcloudy/bazel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meteorcloudy/bazel/teams","hooks_url":"https://api.github.com/repos/meteorcloudy/bazel/hooks","issue_events_url":"https://api.github.com/repos/meteorcloudy/bazel/issues/events{/number}","events_url":"https://api.github.com/repos/meteorcloudy/bazel/events","assignees_url":"https://api.github.com/repos/meteorcloudy/bazel/assignees{/user}","branches_url":"https://api.github.com/repos/meteorcloudy/bazel/branches{/branch}","tags_url":"https://api.github.com/repos/meteorcloudy/bazel/tags","blobs_url":"https://api.github.com/repos/meteorcloudy/bazel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meteorcloudy/bazel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meteorcloudy/bazel/git/refs{/sha}","trees_url":"https://api.github.com/repos/meteorcloudy/bazel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meteorcloudy/bazel/statuses/{sha}","languages_url":"https://api.github.com/repos/meteorcloudy/bazel/languages","stargazers_url":"https://api.github.com/repos/meteorcloudy/bazel/stargazers","contributors_url":"https://api.github.com/repos/meteorcloudy/bazel/contributors","subscribers_url":"https://api.github.com/repos/meteorcloudy/bazel/subscribers","subscription_url":"https://api.github.com/repos/meteorcloudy/bazel/subscription","commits_url":"https://api.github.com/repos/meteorcloudy/bazel/commits{/sha}","git_commits_url":"https://api.github.com/repos/meteorcloudy/bazel/git/commits{/sha}","comments_url":"https://api.github.com/repos/meteorcloudy/bazel/comments{/number}","issue_comment_url":"https://api.github.com/repos/meteorcloudy/bazel/issues/comments{/number}","contents_url":"https://api.github.com/repos/meteorcloudy/bazel/contents/{+path}","compare_url":"https://api.github.com/repos/meteorcloudy/bazel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meteorcloudy/bazel/merges","archive_url":"https://api.github.com/repos/meteorcloudy/bazel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meteorcloudy/bazel/downloads","issues_url":"https://api.github.com/repos/meteorcloudy/bazel/issues{/number}","pulls_url":"https://api.github.com/repos/meteorcloudy/bazel/pulls{/number}","milestones_url":"https://api.github.com/repos/meteorcloudy/bazel/milestones{/number}","notifications_url":"https://api.github.com/repos/meteorcloudy/bazel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meteorcloudy/bazel/labels{/name}","releases_url":"https://api.github.com/repos/meteorcloudy/bazel/releases{/id}","deployments_url":"https://api.github.com/repos/meteorcloudy/bazel/deployments","created_at":"2016-05-13T12:36:12Z","updated_at":"2016-05-13T12:36:20Z","pushed_at":"2018-03-21T11:37:44Z","git_url":"git://github.com/meteorcloudy/bazel.git","ssh_url":"git@github.com:meteorcloudy/bazel.git","clone_url":"https://github.com/meteorcloudy/bazel.git","svn_url":"https://github.com/meteorcloudy/bazel","homepage":"http://bazel.io","size":448287,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bazelbuild:master","ref":"master","sha":"755d3bec0e7136c34eb9be424c6e1b9a59fbf56c","user":{"login":"bazelbuild","id":11684617,"avatar_url":"https://avatars1.githubusercontent.com/u/11684617?v=4","gravatar_id":"","url":"https://api.github.com/users/bazelbuild","html_url":"https://github.com/bazelbuild","followers_url":"https://api.github.com/users/bazelbuild/followers","following_url":"https://api.github.com/users/bazelbuild/following{/other_user}","gists_url":"https://api.github.com/users/bazelbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/bazelbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazelbuild/subscriptions","organizations_url":"https://api.github.com/users/bazelbuild/orgs","repos_url":"https://api.github.com/users/bazelbuild/repos","events_url":"https://api.github.com/users/bazelbuild/events{/privacy}","received_events_url":"https://api.github.com/users/bazelbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":20773773,"name":"bazel","full_name":"bazelbuild/bazel","owner":{"login":"bazelbuild","id":11684617,"avatar_url":"https://avatars1.githubusercontent.com/u/11684617?v=4","gravatar_id":"","url":"https://api.github.com/users/bazelbuild","html_url":"https://github.com/bazelbuild","followers_url":"https://api.github.com/users/bazelbuild/followers","following_url":"https://api.github.com/users/bazelbuild/following{/other_user}","gists_url":"https://api.github.com/users/bazelbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/bazelbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazelbuild/subscriptions","organizations_url":"https://api.github.com/users/bazelbuild/orgs","repos_url":"https://api.github.com/users/bazelbuild/repos","events_url":"https://api.github.com/users/bazelbuild/events{/privacy}","received_events_url":"https://api.github.com/users/bazelbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bazelbuild/bazel","description":"a fast, scalable, multi-language and extensible build system","fork":false,"url":"https://api.github.com/repos/bazelbuild/bazel","forks_url":"https://api.github.com/repos/bazelbuild/bazel/forks","keys_url":"https://api.github.com/repos/bazelbuild/bazel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bazelbuild/bazel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bazelbuild/bazel/teams","hooks_url":"https://api.github.com/repos/bazelbuild/bazel/hooks","issue_events_url":"https://api.github.com/repos/bazelbuild/bazel/issues/events{/number}","events_url":"https://api.github.com/repos/bazelbuild/bazel/events","assignees_url":"https://api.github.com/repos/bazelbuild/bazel/assignees{/user}","branches_url":"https://api.github.com/repos/bazelbuild/bazel/branches{/branch}","tags_url":"https://api.github.com/repos/bazelbuild/bazel/tags","blobs_url":"https://api.github.com/repos/bazelbuild/bazel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bazelbuild/bazel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bazelbuild/bazel/git/refs{/sha}","trees_url":"https://api.github.com/repos/bazelbuild/bazel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bazelbuild/bazel/statuses/{sha}","languages_url":"https://api.github.com/repos/bazelbuild/bazel/languages","stargazers_url":"https://api.github.com/repos/bazelbuild/bazel/stargazers","contributors_url":"https://api.github.com/repos/bazelbuild/bazel/contributors","subscribers_url":"https://api.github.com/repos/bazelbuild/bazel/subscribers","subscription_url":"https://api.github.com/repos/bazelbuild/bazel/subscription","commits_url":"https://api.github.com/repos/bazelbuild/bazel/commits{/sha}","git_commits_url":"https://api.github.com/repos/bazelbuild/bazel/git/commits{/sha}","comments_url":"https://api.github.com/repos/bazelbuild/bazel/comments{/number}","issue_comment_url":"https://api.github.com/repos/bazelbuild/bazel/issues/comments{/number}","contents_url":"https://api.github.com/repos/bazelbuild/bazel/contents/{+path}","compare_url":"https://api.github.com/repos/bazelbuild/bazel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bazelbuild/bazel/merges","archive_url":"https://api.github.com/repos/bazelbuild/bazel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bazelbuild/bazel/downloads","issues_url":"https://api.github.com/repos/bazelbuild/bazel/issues{/number}","pulls_url":"https://api.github.com/repos/bazelbuild/bazel/pulls{/number}","milestones_url":"https://api.github.com/repos/bazelbuild/bazel/milestones{/number}","notifications_url":"https://api.github.com/repos/bazelbuild/bazel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bazelbuild/bazel/labels{/name}","releases_url":"https://api.github.com/repos/bazelbuild/bazel/releases{/id}","deployments_url":"https://api.github.com/repos/bazelbuild/bazel/deployments","created_at":"2014-06-12T16:00:38Z","updated_at":"2018-03-21T13:34:03Z","pushed_at":"2018-03-21T13:33:56Z","git_url":"git://github.com/bazelbuild/bazel.git","ssh_url":"git@github.com:bazelbuild/bazel.git","clone_url":"https://github.com/bazelbuild/bazel.git","svn_url":"https://github.com/bazelbuild/bazel","homepage":"https://bazel.build","size":448843,"stargazers_count":8533,"watchers_count":8533,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1313,"mirror_url":null,"archived":false,"open_issues_count":1325,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1313,"open_issues":1325,"watchers":8533,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bazelbuild/bazel/pulls/4892"},"html":{"href":"https://github.com/bazelbuild/bazel/pull/4892"},"issue":{"href":"https://api.github.com/repos/bazelbuild/bazel/issues/4892"},"comments":{"href":"https://api.github.com/repos/bazelbuild/bazel/issues/4892/comments"},"review_comments":{"href":"https://api.github.com/repos/bazelbuild/bazel/pulls/4892/comments"},"review_comment":{"href":"https://api.github.com/repos/bazelbuild/bazel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bazelbuild/bazel/pulls/4892/commits"},"statuses":{"href":"https://api.github.com/repos/bazelbuild/bazel/statuses/1c43bfbca5cbbfdac853abb9e88df0f99841ab7f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"meteorcloudy"}}