{"action":"closed","number":214,"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/pulls/214","id":197292387,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MjkyMzg3","html_url":"https://github.com/spring-projects/spring-data-elasticsearch/pull/214","diff_url":"https://github.com/spring-projects/spring-data-elasticsearch/pull/214.diff","patch_url":"https://github.com/spring-projects/spring-data-elasticsearch/pull/214.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/issues/214","number":214,"state":"closed","locked":false,"title":"fix bug","user":{"login":"asasas234","id":4795442,"node_id":"MDQ6VXNlcjQ3OTU0NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/4795442?v=4","gravatar_id":"","url":"https://api.github.com/users/asasas234","html_url":"https://github.com/asasas234","followers_url":"https://api.github.com/users/asasas234/followers","following_url":"https://api.github.com/users/asasas234/following{/other_user}","gists_url":"https://api.github.com/users/asasas234/gists{/gist_id}","starred_url":"https://api.github.com/users/asasas234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asasas234/subscriptions","organizations_url":"https://api.github.com/users/asasas234/orgs","repos_url":"https://api.github.com/users/asasas234/repos","events_url":"https://api.github.com/users/asasas234/events{/privacy}","received_events_url":"https://api.github.com/users/asasas234/received_events","type":"User","site_admin":false},"body":"TransportClientFactoryBean has 3 bugs in client creation\r\n1. StringUtils.split(clusterNodes, COMMA) , StringUtils should be in the apache package, spring package has a bug, for example: clusterNodes is 127.0.0.1:9300, the result array is null, there should be an array of 1 elements, array element values Is 127.0.0.1:9300\r\n2. clusterName.lastIndexOf(COLON); This code is wrong, it should be clusterNode.lastIndexOf(COLON);\r\n3. clusterNode.substring(colonPosition, clusterNode.length()); should be clusterNode.substring(colonPosition + 1, clusterNode.length());\r\n\r\n\r\n<!--\r\n\r\nThank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.\r\nMake sure that:\r\n\r\n-->\r\n\r\n- [ ] You have read the [Spring Data contribution guidelines](https://github.com/spring-projects/spring-data-build/blob/master/CONTRIBUTING.adoc).\r\n- [ ] There is a ticket in the bug tracker for the project in our [JIRA](https://jira.spring.io/browse/DATAES).\r\n- [ ] You use the code formatters provided [here](https://github.com/spring-projects/spring-data-build/tree/master/etc/ide) and have them applied to your changes. Don’t submit any formatting related changes.\r\n- [ ] You submit test cases (unit or integration tests) that back your changes.\r\n- [ ] You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).\r\n","created_at":"2018-06-26T03:32:44Z","updated_at":"2018-11-01T23:02:52Z","closed_at":"2018-11-01T23:02:52Z","merged_at":null,"merge_commit_sha":"9f11062d7dd36f3450aeb478a088d023579142ab","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/pulls/214/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/pulls/214/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/issues/214/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/statuses/aedd4d62cfba275dd8e8ece9a714c917a04202ec","head":{"label":"asasas234:master","ref":"master","sha":"aedd4d62cfba275dd8e8ece9a714c917a04202ec","user":{"login":"asasas234","id":4795442,"node_id":"MDQ6VXNlcjQ3OTU0NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/4795442?v=4","gravatar_id":"","url":"https://api.github.com/users/asasas234","html_url":"https://github.com/asasas234","followers_url":"https://api.github.com/users/asasas234/followers","following_url":"https://api.github.com/users/asasas234/following{/other_user}","gists_url":"https://api.github.com/users/asasas234/gists{/gist_id}","starred_url":"https://api.github.com/users/asasas234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asasas234/subscriptions","organizations_url":"https://api.github.com/users/asasas234/orgs","repos_url":"https://api.github.com/users/asasas234/repos","events_url":"https://api.github.com/users/asasas234/events{/privacy}","received_events_url":"https://api.github.com/users/asasas234/received_events","type":"User","site_admin":false},"repo":{"id":138678295,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg2NzgyOTU=","name":"spring-data-elasticsearch","full_name":"asasas234/spring-data-elasticsearch","private":false,"owner":{"login":"asasas234","id":4795442,"node_id":"MDQ6VXNlcjQ3OTU0NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/4795442?v=4","gravatar_id":"","url":"https://api.github.com/users/asasas234","html_url":"https://github.com/asasas234","followers_url":"https://api.github.com/users/asasas234/followers","following_url":"https://api.github.com/users/asasas234/following{/other_user}","gists_url":"https://api.github.com/users/asasas234/gists{/gist_id}","starred_url":"https://api.github.com/users/asasas234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asasas234/subscriptions","organizations_url":"https://api.github.com/users/asasas234/orgs","repos_url":"https://api.github.com/users/asasas234/repos","events_url":"https://api.github.com/users/asasas234/events{/privacy}","received_events_url":"https://api.github.com/users/asasas234/received_events","type":"User","site_admin":false},"html_url":"https://github.com/asasas234/spring-data-elasticsearch","description":"Spring Data Elasticsearch","fork":true,"url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch","forks_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/forks","keys_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/teams","hooks_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/events","assignees_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/tags","blobs_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/languages","stargazers_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/subscription","commits_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/merges","archive_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/downloads","issues_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/asasas234/spring-data-elasticsearch/deployments","created_at":"2018-06-26T03:09:47Z","updated_at":"2018-06-26T03:24:21Z","pushed_at":"2018-06-26T03:23:46Z","git_url":"git://github.com/asasas234/spring-data-elasticsearch.git","ssh_url":"git@github.com:asasas234/spring-data-elasticsearch.git","clone_url":"https://github.com/asasas234/spring-data-elasticsearch.git","svn_url":"https://github.com/asasas234/spring-data-elasticsearch","homepage":null,"size":16178,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"32a4f4ea7ac8b6433af8efe1a37eff44195a059e","user":{"login":"spring-projects","id":317776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzc3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/317776?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":9749905,"node_id":"MDEwOlJlcG9zaXRvcnk5NzQ5OTA1","name":"spring-data-elasticsearch","full_name":"spring-projects/spring-data-elasticsearch","private":false,"owner":{"login":"spring-projects","id":317776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzc3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/317776?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spring-projects/spring-data-elasticsearch","description":"Spring Data Elasticsearch","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch","forks_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/deployments","created_at":"2013-04-29T14:27:38Z","updated_at":"2018-11-01T21:06:29Z","pushed_at":"2018-10-29T13:35:32Z","git_url":"git://github.com/spring-projects/spring-data-elasticsearch.git","ssh_url":"git@github.com:spring-projects/spring-data-elasticsearch.git","clone_url":"https://github.com/spring-projects/spring-data-elasticsearch.git","svn_url":"https://github.com/spring-projects/spring-data-elasticsearch","homepage":null,"size":16354,"stargazers_count":1430,"watchers_count":1430,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":746,"mirror_url":null,"archived":false,"open_issues_count":51,"license":null,"forks":746,"open_issues":51,"watchers":1430,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/pulls/214"},"html":{"href":"https://github.com/spring-projects/spring-data-elasticsearch/pull/214"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/issues/214"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/issues/214/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/pulls/214/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/pulls/214/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-data-elasticsearch/statuses/aedd4d62cfba275dd8e8ece9a714c917a04202ec"}},"author_association":"NONE","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":20,"deletions":20,"changed_files":3}}
{"actor":{"display_login":"xhaggi"}}