{"action":"created","issue":{"url":"https://api.github.com/repos/sakura-editor/sakura/issues/591","repository_url":"https://api.github.com/repos/sakura-editor/sakura","labels_url":"https://api.github.com/repos/sakura-editor/sakura/issues/591/labels{/name}","comments_url":"https://api.github.com/repos/sakura-editor/sakura/issues/591/comments","events_url":"https://api.github.com/repos/sakura-editor/sakura/issues/591/events","html_url":"https://github.com/sakura-editor/sakura/pull/591","id":376764736,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3OTAxNzUy","number":591,"title":"Build and run tests on MinGW environment.","user":{"login":"ds14050","id":23469385,"node_id":"MDQ6VXNlcjIzNDY5Mzg1","avatar_url":"https://avatars1.githubusercontent.com/u/23469385?v=4","gravatar_id":"","url":"https://api.github.com/users/ds14050","html_url":"https://github.com/ds14050","followers_url":"https://api.github.com/users/ds14050/followers","following_url":"https://api.github.com/users/ds14050/following{/other_user}","gists_url":"https://api.github.com/users/ds14050/gists{/gist_id}","starred_url":"https://api.github.com/users/ds14050/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ds14050/subscriptions","organizations_url":"https://api.github.com/users/ds14050/orgs","repos_url":"https://api.github.com/users/ds14050/repos","events_url":"https://api.github.com/users/ds14050/events{/privacy}","received_events_url":"https://api.github.com/users/ds14050/received_events","type":"User","site_admin":false},"labels":[{"id":1035111615,"node_id":"MDU6TGFiZWwxMDM1MTExNjE1","url":"https://api.github.com/repos/sakura-editor/sakura/labels/MinGW","name":"MinGW","color":"ff56c4","default":false},{"id":973779397,"node_id":"MDU6TGFiZWw5NzM3NzkzOTc=","url":"https://api.github.com/repos/sakura-editor/sakura/labels/UnitTest","name":"UnitTest","color":"8af762","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/sakura-editor/sakura/milestones/1","html_url":"https://github.com/sakura-editor/sakura/milestone/1","labels_url":"https://api.github.com/repos/sakura-editor/sakura/milestones/1/labels","id":3390252,"node_id":"MDk6TWlsZXN0b25lMzM5MDI1Mg==","number":1,"title":"next release","description":"バージョン番号が確定したらマイルストーン名を変えます","creator":{"login":"kobake","id":2929454,"node_id":"MDQ6VXNlcjI5Mjk0NTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2929454?v=4","gravatar_id":"","url":"https://api.github.com/users/kobake","html_url":"https://github.com/kobake","followers_url":"https://api.github.com/users/kobake/followers","following_url":"https://api.github.com/users/kobake/following{/other_user}","gists_url":"https://api.github.com/users/kobake/gists{/gist_id}","starred_url":"https://api.github.com/users/kobake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobake/subscriptions","organizations_url":"https://api.github.com/users/kobake/orgs","repos_url":"https://api.github.com/users/kobake/repos","events_url":"https://api.github.com/users/kobake/events{/privacy}","received_events_url":"https://api.github.com/users/kobake/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":405,"state":"open","created_at":"2018-05-31T12:48:23Z","updated_at":"2018-11-08T15:00:54Z","due_on":null,"closed_at":null},"comments":17,"created_at":"2018-11-02T11:02:22Z","updated_at":"2018-11-08T16:07:29Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/sakura-editor/sakura/pulls/591","html_url":"https://github.com/sakura-editor/sakura/pull/591","diff_url":"https://github.com/sakura-editor/sakura/pull/591.diff","patch_url":"https://github.com/sakura-editor/sakura/pull/591.patch"},"body":"#579 の続きです。MinGW ビルドでテストプログラムを作成して実行します。AppVeyor が×を出すはずですが https://github.com/sakura-editor/sakura/pull/559#issuecomment-433756837 で予告していた通りであり、この PR の問題ではありません。\r\n\r\nsakura_core/Makefile に対する修正はローカルの cmd.exe が / 区切りのパスを解釈しなかったことへの対処です。\r\n\r\ntests/create-project.bat で cmake へのオプションを変えていますが、これは cmake 3.12 のドキュメントや `cmake --help`、`cmake --build` を読んでも -B オプションの説明が見つからなかったからです。-H オプションについては --help, -help, -usage, -h, /? と同じだと書かれていました。[Software pre-installed on Windows build VMs | AppVeyor](https://www.appveyor.com/docs/windows-images-software/) によると AppVeyor にプリインストールされているのは CMake 3.12.2 です。\r\n"},"comment":{"url":"https://api.github.com/repos/sakura-editor/sakura/issues/comments/437051697","html_url":"https://github.com/sakura-editor/sakura/pull/591#issuecomment-437051697","issue_url":"https://api.github.com/repos/sakura-editor/sakura/issues/591","id":437051697,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzA1MTY5Nw==","user":{"login":"ds14050","id":23469385,"node_id":"MDQ6VXNlcjIzNDY5Mzg1","avatar_url":"https://avatars1.githubusercontent.com/u/23469385?v=4","gravatar_id":"","url":"https://api.github.com/users/ds14050","html_url":"https://github.com/ds14050","followers_url":"https://api.github.com/users/ds14050/followers","following_url":"https://api.github.com/users/ds14050/following{/other_user}","gists_url":"https://api.github.com/users/ds14050/gists{/gist_id}","starred_url":"https://api.github.com/users/ds14050/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ds14050/subscriptions","organizations_url":"https://api.github.com/users/ds14050/orgs","repos_url":"https://api.github.com/users/ds14050/repos","events_url":"https://api.github.com/users/ds14050/events{/privacy}","received_events_url":"https://api.github.com/users/ds14050/received_events","type":"User","site_admin":false},"created_at":"2018-11-08T16:07:29Z","updated_at":"2018-11-08T16:07:29Z","author_association":"MEMBER","body":">あと指摘に対応して push したら、しばらく経っても反応ないときは明示的にレビュー依頼してください。\r\n\r\nいい心がけだと思います。特に国が異なると、せっついて初めて事が動き出すということがあるようです。待ってると待ちぼうけ、みたいな。でも待ちますよ。忘れられるなら不要だったということです。\r\n"}}
{"actor":{"display_login":"ds14050"}}