{"action":"created","issue":{"url":"https://api.github.com/repos/CliMT/climt/issues/65","repository_url":"https://api.github.com/repos/CliMT/climt","labels_url":"https://api.github.com/repos/CliMT/climt/issues/65/labels{/name}","comments_url":"https://api.github.com/repos/CliMT/climt/issues/65/comments","events_url":"https://api.github.com/repos/CliMT/climt/issues/65/events","html_url":"https://github.com/CliMT/climt/issues/65","id":349726620,"node_id":"MDU6SXNzdWUzNDk3MjY2MjA=","number":65,"title":"get_default_state outputs quantities with wrong dimensions","user":{"login":"JoyMonteiro","id":7300413,"node_id":"MDQ6VXNlcjczMDA0MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/7300413?v=4","gravatar_id":"","url":"https://api.github.com/users/JoyMonteiro","html_url":"https://github.com/JoyMonteiro","followers_url":"https://api.github.com/users/JoyMonteiro/followers","following_url":"https://api.github.com/users/JoyMonteiro/following{/other_user}","gists_url":"https://api.github.com/users/JoyMonteiro/gists{/gist_id}","starred_url":"https://api.github.com/users/JoyMonteiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoyMonteiro/subscriptions","organizations_url":"https://api.github.com/users/JoyMonteiro/orgs","repos_url":"https://api.github.com/users/JoyMonteiro/repos","events_url":"https://api.github.com/users/JoyMonteiro/events{/privacy}","received_events_url":"https://api.github.com/users/JoyMonteiro/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-08-11T11:10:27Z","updated_at":"2018-08-13T07:14:49Z","closed_at":null,"author_association":"MEMBER","body":"The output of get_default_state is zero dimensional (only a scalar) if the field is uniform in all directions.\r\nWhile this is ok for components since the extracted arrays are in the correct shape, the Monitors don't\r\nseem to get the state in the correct shape, and therefore if you do a `store` at the first step, the dimensions\r\nare not correct.\r\n\r\nI think the correct approach would be to ensure that the initial state itself has the correct dimensions. This is also important to not throw off anyone inspecting the initial state."},"comment":{"url":"https://api.github.com/repos/CliMT/climt/issues/comments/412428533","html_url":"https://github.com/CliMT/climt/issues/65#issuecomment-412428533","issue_url":"https://api.github.com/repos/CliMT/climt/issues/65","id":412428533,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjQyODUzMw==","user":{"login":"JoyMonteiro","id":7300413,"node_id":"MDQ6VXNlcjczMDA0MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/7300413?v=4","gravatar_id":"","url":"https://api.github.com/users/JoyMonteiro","html_url":"https://github.com/JoyMonteiro","followers_url":"https://api.github.com/users/JoyMonteiro/followers","following_url":"https://api.github.com/users/JoyMonteiro/following{/other_user}","gists_url":"https://api.github.com/users/JoyMonteiro/gists{/gist_id}","starred_url":"https://api.github.com/users/JoyMonteiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoyMonteiro/subscriptions","organizations_url":"https://api.github.com/users/JoyMonteiro/orgs","repos_url":"https://api.github.com/users/JoyMonteiro/repos","events_url":"https://api.github.com/users/JoyMonteiro/events{/privacy}","received_events_url":"https://api.github.com/users/JoyMonteiro/received_events","type":"User","site_admin":false},"created_at":"2018-08-13T07:14:49Z","updated_at":"2018-08-13T07:14:49Z","author_association":"MEMBER","body":"Nope. This means that `write_on_store` does not do what it says. I can also see other problems: say, for example, someone wants to update CO2 concentration from the 100th timestep, then store will fail again.\r\n\r\nThe same issue with `PlotFunctionMonitor`. I had to modify every script to not store on the first time step in `climt/examples`. This is definitely undesirable.\r\n\r\nI'm definitely not saying that it should be advertised as a feature. Moreover, there is nothing that can prevent such issues from cropping up even now -- for example, I could replace the scalar in a `DataArray` with another one without keeping in mind units. It is harder to change dimensions as xarray\r\nprevents assignments which changes array shapes."}}
{"actor":{"display_login":"JoyMonteiro"}}