{"action":"created","comment":{"url":"https://api.github.com/repos/node-red/node-red/pulls/comments/215572665","pull_request_review_id":152863738,"id":215572665,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTU3MjY2NQ==","diff_hunk":"@@ -2038,7 +2038,14 @@ RED.view = (function() {\n                             .attr(\"ry\",4)\n                             .attr(\"width\",16)\n                             .attr(\"height\",node_height-12)\n-                            .attr(\"fill\",function(d) { return RED.utils.getNodeColor(d.type,d._def); /*d._def.color;*/})\n+                            .attr(\"fill\", function (d) {\n+                                var nodeColor = RED.utils.getNodeColor(d.type,d._def); /*d._def.color;*/","path":"editor/js/ui/view.js","position":6,"original_position":6,"commit_id":"3e320429ab85be5df0e811e5d4eb772b8fe076c2","original_commit_id":"3e320429ab85be5df0e811e5d4eb772b8fe076c2","user":{"login":"knolleary","id":51083,"node_id":"MDQ6VXNlcjUxMDgz","avatar_url":"https://avatars2.githubusercontent.com/u/51083?v=4","gravatar_id":"","url":"https://api.github.com/users/knolleary","html_url":"https://github.com/knolleary","followers_url":"https://api.github.com/users/knolleary/followers","following_url":"https://api.github.com/users/knolleary/following{/other_user}","gists_url":"https://api.github.com/users/knolleary/gists{/gist_id}","starred_url":"https://api.github.com/users/knolleary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knolleary/subscriptions","organizations_url":"https://api.github.com/users/knolleary/orgs","repos_url":"https://api.github.com/users/knolleary/repos","events_url":"https://api.github.com/users/knolleary/events{/privacy}","received_events_url":"https://api.github.com/users/knolleary/received_events","type":"User","site_admin":false},"body":"I think it would be better to have `RED.utils.getNodeColor` return a default colour, rather than have to add this same logic in multiple places.","created_at":"2018-09-06T10:18:34Z","updated_at":"2018-09-06T10:18:35Z","html_url":"https://github.com/node-red/node-red/pull/1877#discussion_r215572665","pull_request_url":"https://api.github.com/repos/node-red/node-red/pulls/1877","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/node-red/node-red/pulls/comments/215572665"},"html":{"href":"https://github.com/node-red/node-red/pull/1877#discussion_r215572665"},"pull_request":{"href":"https://api.github.com/repos/node-red/node-red/pulls/1877"}}},"pull_request":{"url":"https://api.github.com/repos/node-red/node-red/pulls/1877","id":213558610,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNTU4NjEw","html_url":"https://github.com/node-red/node-red/pull/1877","diff_url":"https://github.com/node-red/node-red/pull/1877.diff","patch_url":"https://github.com/node-red/node-red/pull/1877.patch","issue_url":"https://api.github.com/repos/node-red/node-red/issues/1877","number":1877,"state":"open","locked":false,"title":"Fix node color bug","user":{"login":"kazuhitoyokoi","id":20310935,"node_id":"MDQ6VXNlcjIwMzEwOTM1","avatar_url":"https://avatars2.githubusercontent.com/u/20310935?v=4","gravatar_id":"","url":"https://api.github.com/users/kazuhitoyokoi","html_url":"https://github.com/kazuhitoyokoi","followers_url":"https://api.github.com/users/kazuhitoyokoi/followers","following_url":"https://api.github.com/users/kazuhitoyokoi/following{/other_user}","gists_url":"https://api.github.com/users/kazuhitoyokoi/gists{/gist_id}","starred_url":"https://api.github.com/users/kazuhitoyokoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kazuhitoyokoi/subscriptions","organizations_url":"https://api.github.com/users/kazuhitoyokoi/orgs","repos_url":"https://api.github.com/users/kazuhitoyokoi/repos","events_url":"https://api.github.com/users/kazuhitoyokoi/events{/privacy}","received_events_url":"https://api.github.com/users/kazuhitoyokoi/received_events","type":"User","site_admin":false},"body":"- [x] Bugfix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n\r\n## Proposed changes\r\nI fixed #1876.\r\n\r\n## Checklist\r\n- [x] I have read the [contribution guidelines](https://github.com/node-red/node-red/blob/master/CONTRIBUTING.md)\r\n- [ ] For non-bugfix PRs, I have discussed this change on the mailing list/slack team.\r\n- [x] I have run `grunt` to verify the unit tests pass\r\n- [ ] I have added suitable unit tests to cover the new/changed functionality","created_at":"2018-09-06T09:51:13Z","updated_at":"2018-09-06T10:18:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11eaee6c7b8c3ff80a1d64510512e7465f1ecfd3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/node-red/node-red/pulls/1877/commits","review_comments_url":"https://api.github.com/repos/node-red/node-red/pulls/1877/comments","review_comment_url":"https://api.github.com/repos/node-red/node-red/pulls/comments{/number}","comments_url":"https://api.github.com/repos/node-red/node-red/issues/1877/comments","statuses_url":"https://api.github.com/repos/node-red/node-red/statuses/3e320429ab85be5df0e811e5d4eb772b8fe076c2","head":{"label":"kazuhitoyokoi:master-fixnodecolorbug","ref":"master-fixnodecolorbug","sha":"3e320429ab85be5df0e811e5d4eb772b8fe076c2","user":{"login":"kazuhitoyokoi","id":20310935,"node_id":"MDQ6VXNlcjIwMzEwOTM1","avatar_url":"https://avatars2.githubusercontent.com/u/20310935?v=4","gravatar_id":"","url":"https://api.github.com/users/kazuhitoyokoi","html_url":"https://github.com/kazuhitoyokoi","followers_url":"https://api.github.com/users/kazuhitoyokoi/followers","following_url":"https://api.github.com/users/kazuhitoyokoi/following{/other_user}","gists_url":"https://api.github.com/users/kazuhitoyokoi/gists{/gist_id}","starred_url":"https://api.github.com/users/kazuhitoyokoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kazuhitoyokoi/subscriptions","organizations_url":"https://api.github.com/users/kazuhitoyokoi/orgs","repos_url":"https://api.github.com/users/kazuhitoyokoi/repos","events_url":"https://api.github.com/users/kazuhitoyokoi/events{/privacy}","received_events_url":"https://api.github.com/users/kazuhitoyokoi/received_events","type":"User","site_admin":false},"repo":{"id":143723526,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3MjM1MjY=","name":"node-red","full_name":"kazuhitoyokoi/node-red","owner":{"login":"kazuhitoyokoi","id":20310935,"node_id":"MDQ6VXNlcjIwMzEwOTM1","avatar_url":"https://avatars2.githubusercontent.com/u/20310935?v=4","gravatar_id":"","url":"https://api.github.com/users/kazuhitoyokoi","html_url":"https://github.com/kazuhitoyokoi","followers_url":"https://api.github.com/users/kazuhitoyokoi/followers","following_url":"https://api.github.com/users/kazuhitoyokoi/following{/other_user}","gists_url":"https://api.github.com/users/kazuhitoyokoi/gists{/gist_id}","starred_url":"https://api.github.com/users/kazuhitoyokoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kazuhitoyokoi/subscriptions","organizations_url":"https://api.github.com/users/kazuhitoyokoi/orgs","repos_url":"https://api.github.com/users/kazuhitoyokoi/repos","events_url":"https://api.github.com/users/kazuhitoyokoi/events{/privacy}","received_events_url":"https://api.github.com/users/kazuhitoyokoi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kazuhitoyokoi/node-red","description":"A visual tool for wiring the Internet of Things","fork":true,"url":"https://api.github.com/repos/kazuhitoyokoi/node-red","forks_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/forks","keys_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/teams","hooks_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/hooks","issue_events_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/issues/events{/number}","events_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/events","assignees_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/assignees{/user}","branches_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/branches{/branch}","tags_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/tags","blobs_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/git/refs{/sha}","trees_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/statuses/{sha}","languages_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/languages","stargazers_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/stargazers","contributors_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/contributors","subscribers_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/subscribers","subscription_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/subscription","commits_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/commits{/sha}","git_commits_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/git/commits{/sha}","comments_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/comments{/number}","issue_comment_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/issues/comments{/number}","contents_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/contents/{+path}","compare_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/merges","archive_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/downloads","issues_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/issues{/number}","pulls_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/pulls{/number}","milestones_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/milestones{/number}","notifications_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/labels{/name}","releases_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/releases{/id}","deployments_url":"https://api.github.com/repos/kazuhitoyokoi/node-red/deployments","created_at":"2018-08-06T12:11:34Z","updated_at":"2018-08-06T12:11:37Z","pushed_at":"2018-09-06T10:06:28Z","git_url":"git://github.com/kazuhitoyokoi/node-red.git","ssh_url":"git@github.com:kazuhitoyokoi/node-red.git","clone_url":"https://github.com/kazuhitoyokoi/node-red.git","svn_url":"https://github.com/kazuhitoyokoi/node-red","homepage":"http://nodered.org","size":13724,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"node-red:master","ref":"master","sha":"6fa8b7f5f179fd6d97b5af9938d92d0fc44bfda0","user":{"login":"node-red","id":5375661,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNzU2NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/5375661?v=4","gravatar_id":"","url":"https://api.github.com/users/node-red","html_url":"https://github.com/node-red","followers_url":"https://api.github.com/users/node-red/followers","following_url":"https://api.github.com/users/node-red/following{/other_user}","gists_url":"https://api.github.com/users/node-red/gists{/gist_id}","starred_url":"https://api.github.com/users/node-red/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/node-red/subscriptions","organizations_url":"https://api.github.com/users/node-red/orgs","repos_url":"https://api.github.com/users/node-red/repos","events_url":"https://api.github.com/users/node-red/events{/privacy}","received_events_url":"https://api.github.com/users/node-red/received_events","type":"Organization","site_admin":false},"repo":{"id":12618379,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYxODM3OQ==","name":"node-red","full_name":"node-red/node-red","owner":{"login":"node-red","id":5375661,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNzU2NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/5375661?v=4","gravatar_id":"","url":"https://api.github.com/users/node-red","html_url":"https://github.com/node-red","followers_url":"https://api.github.com/users/node-red/followers","following_url":"https://api.github.com/users/node-red/following{/other_user}","gists_url":"https://api.github.com/users/node-red/gists{/gist_id}","starred_url":"https://api.github.com/users/node-red/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/node-red/subscriptions","organizations_url":"https://api.github.com/users/node-red/orgs","repos_url":"https://api.github.com/users/node-red/repos","events_url":"https://api.github.com/users/node-red/events{/privacy}","received_events_url":"https://api.github.com/users/node-red/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/node-red/node-red","description":"A visual tool for wiring the Internet of Things","fork":false,"url":"https://api.github.com/repos/node-red/node-red","forks_url":"https://api.github.com/repos/node-red/node-red/forks","keys_url":"https://api.github.com/repos/node-red/node-red/keys{/key_id}","collaborators_url":"https://api.github.com/repos/node-red/node-red/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/node-red/node-red/teams","hooks_url":"https://api.github.com/repos/node-red/node-red/hooks","issue_events_url":"https://api.github.com/repos/node-red/node-red/issues/events{/number}","events_url":"https://api.github.com/repos/node-red/node-red/events","assignees_url":"https://api.github.com/repos/node-red/node-red/assignees{/user}","branches_url":"https://api.github.com/repos/node-red/node-red/branches{/branch}","tags_url":"https://api.github.com/repos/node-red/node-red/tags","blobs_url":"https://api.github.com/repos/node-red/node-red/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/node-red/node-red/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/node-red/node-red/git/refs{/sha}","trees_url":"https://api.github.com/repos/node-red/node-red/git/trees{/sha}","statuses_url":"https://api.github.com/repos/node-red/node-red/statuses/{sha}","languages_url":"https://api.github.com/repos/node-red/node-red/languages","stargazers_url":"https://api.github.com/repos/node-red/node-red/stargazers","contributors_url":"https://api.github.com/repos/node-red/node-red/contributors","subscribers_url":"https://api.github.com/repos/node-red/node-red/subscribers","subscription_url":"https://api.github.com/repos/node-red/node-red/subscription","commits_url":"https://api.github.com/repos/node-red/node-red/commits{/sha}","git_commits_url":"https://api.github.com/repos/node-red/node-red/git/commits{/sha}","comments_url":"https://api.github.com/repos/node-red/node-red/comments{/number}","issue_comment_url":"https://api.github.com/repos/node-red/node-red/issues/comments{/number}","contents_url":"https://api.github.com/repos/node-red/node-red/contents/{+path}","compare_url":"https://api.github.com/repos/node-red/node-red/compare/{base}...{head}","merges_url":"https://api.github.com/repos/node-red/node-red/merges","archive_url":"https://api.github.com/repos/node-red/node-red/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/node-red/node-red/downloads","issues_url":"https://api.github.com/repos/node-red/node-red/issues{/number}","pulls_url":"https://api.github.com/repos/node-red/node-red/pulls{/number}","milestones_url":"https://api.github.com/repos/node-red/node-red/milestones{/number}","notifications_url":"https://api.github.com/repos/node-red/node-red/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/node-red/node-red/labels{/name}","releases_url":"https://api.github.com/repos/node-red/node-red/releases{/id}","deployments_url":"https://api.github.com/repos/node-red/node-red/deployments","created_at":"2013-09-05T13:30:47Z","updated_at":"2018-09-06T03:58:01Z","pushed_at":"2018-09-06T10:06:29Z","git_url":"git://github.com/node-red/node-red.git","ssh_url":"git@github.com:node-red/node-red.git","clone_url":"https://github.com/node-red/node-red.git","svn_url":"https://github.com/node-red/node-red","homepage":"http://nodered.org","size":14664,"stargazers_count":6417,"watchers_count":6417,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1503,"mirror_url":null,"archived":false,"open_issues_count":158,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1503,"open_issues":158,"watchers":6417,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/node-red/node-red/pulls/1877"},"html":{"href":"https://github.com/node-red/node-red/pull/1877"},"issue":{"href":"https://api.github.com/repos/node-red/node-red/issues/1877"},"comments":{"href":"https://api.github.com/repos/node-red/node-red/issues/1877/comments"},"review_comments":{"href":"https://api.github.com/repos/node-red/node-red/pulls/1877/comments"},"review_comment":{"href":"https://api.github.com/repos/node-red/node-red/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/node-red/node-red/pulls/1877/commits"},"statuses":{"href":"https://api.github.com/repos/node-red/node-red/statuses/3e320429ab85be5df0e811e5d4eb772b8fe076c2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"knolleary"}}