{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/225971587","pull_request_review_id":165683643,"id":225971587,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTk3MTU4Nw==","diff_hunk":"@@ -31,9 +31,15 @@ module.exports = function exampleInlineTagDef(parseArgString, createDocMessage,\n       const sourceCode = getExampleRegion(doc, relativePath, regionName);\n \n       const attributes = [];\n+      if (relativePath) attributes.push(` path=\"${relativePath}\"`);\n+      if (regionName) attributes.push(` region=\"${regionName}\"`);\n       if (header) attributes.push(` header=\"${header}\"`);\n       if (linenums !== undefined) attributes.push(` linenums=\"${linenums}\"`);\n \n+      // Preserve the no-longer-supported `title` attribute,\n+      // in order to throw an appripriate error in `renderExamples` later.\n+      if (tagArgs.title) attributes.push(` title=\"${tagArgs.title}\"`);\n+","path":"aio/tools/transforms/examples-package/inline-tag-defs/example.js","position":45,"original_position":12,"commit_id":"779389369634a6ae0e48dc78bb815e2949a81c04","original_commit_id":"beb3cc5609a8d5cd87e3649a80e7643fc6077a97","user":{"login":"gkalpak","id":8604205,"node_id":"MDQ6VXNlcjg2MDQyMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8604205?v=4","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"body":"The API docs are full of those 😕 ","created_at":"2018-10-17T15:07:48Z","updated_at":"2018-10-17T15:07:48Z","html_url":"https://github.com/angular/angular/pull/26514#discussion_r225971587","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/26514","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/225971587"},"html":{"href":"https://github.com/angular/angular/pull/26514#discussion_r225971587"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/26514"}},"in_reply_to_id":225970798},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/26514","id":223632697,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNjMyNjk3","html_url":"https://github.com/angular/angular/pull/26514","diff_url":"https://github.com/angular/angular/pull/26514.diff","patch_url":"https://github.com/angular/angular/pull/26514.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/26514","number":26514,"state":"open","locked":false,"title":"build(docs-infra): throw error if using `title` on code snippets","user":{"login":"gkalpak","id":8604205,"node_id":"MDQ6VXNlcjg2MDQyMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8604205?v=4","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"body":"Since #26396, the `title` property is ignored and `header` should be used instead for specifying a code snippet's header.\r\n\r\nThis PR ensures that we don't accidentally set `title` have it be silently ignored.\r\n","created_at":"2018-10-17T14:42:59Z","updated_at":"2018-10-17T15:07:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"258921f1e72fc43b302e1ca04f7a2b39fd3698e7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":217969169,"node_id":"MDU6TGFiZWwyMTc5NjkxNjk=","url":"https://api.github.com/repos/angular/angular/labels/PR%20action:%20review","name":"PR action: review","color":"fbca04","default":false},{"id":217962760,"node_id":"MDU6TGFiZWwyMTc5NjI3NjA=","url":"https://api.github.com/repos/angular/angular/labels/PR%20state:%20blocked","name":"PR state: blocked","color":"e11d21","default":false},{"id":655699838,"node_id":"MDU6TGFiZWw2NTU2OTk4Mzg=","url":"https://api.github.com/repos/angular/angular/labels/PR%20target:%20master%20&%20patch","name":"PR target: master & patch","color":"5319e7","default":false},{"id":149476288,"node_id":"MDU6TGFiZWwxNDk0NzYyODg=","url":"https://api.github.com/repos/angular/angular/labels/cla:%20no","name":"cla: no","color":"e11d21","default":false},{"id":193817683,"node_id":"MDU6TGFiZWwxOTM4MTc2ODM=","url":"https://api.github.com/repos/angular/angular/labels/comp:%20build%20&%20ci","name":"comp: build & ci","color":"c7def8","default":false},{"id":533874619,"node_id":"MDU6TGFiZWw1MzM4NzQ2MTk=","url":"https://api.github.com/repos/angular/angular/labels/comp:%20docs-infra","name":"comp: docs-infra","color":"c7def8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/26514/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/26514/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/26514/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/779389369634a6ae0e48dc78bb815e2949a81c04","head":{"label":"gkalpak:build-aio-prevent-code-title","ref":"build-aio-prevent-code-title","sha":"779389369634a6ae0e48dc78bb815e2949a81c04","user":{"login":"gkalpak","id":8604205,"node_id":"MDQ6VXNlcjg2MDQyMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8604205?v=4","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"repo":{"id":42242550,"node_id":"MDEwOlJlcG9zaXRvcnk0MjI0MjU1MA==","name":"angular","full_name":"gkalpak/angular","private":false,"owner":{"login":"gkalpak","id":8604205,"node_id":"MDQ6VXNlcjg2MDQyMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8604205?v=4","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gkalpak/angular","description":null,"fork":true,"url":"https://api.github.com/repos/gkalpak/angular","forks_url":"https://api.github.com/repos/gkalpak/angular/forks","keys_url":"https://api.github.com/repos/gkalpak/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gkalpak/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gkalpak/angular/teams","hooks_url":"https://api.github.com/repos/gkalpak/angular/hooks","issue_events_url":"https://api.github.com/repos/gkalpak/angular/issues/events{/number}","events_url":"https://api.github.com/repos/gkalpak/angular/events","assignees_url":"https://api.github.com/repos/gkalpak/angular/assignees{/user}","branches_url":"https://api.github.com/repos/gkalpak/angular/branches{/branch}","tags_url":"https://api.github.com/repos/gkalpak/angular/tags","blobs_url":"https://api.github.com/repos/gkalpak/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gkalpak/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gkalpak/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/gkalpak/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gkalpak/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/gkalpak/angular/languages","stargazers_url":"https://api.github.com/repos/gkalpak/angular/stargazers","contributors_url":"https://api.github.com/repos/gkalpak/angular/contributors","subscribers_url":"https://api.github.com/repos/gkalpak/angular/subscribers","subscription_url":"https://api.github.com/repos/gkalpak/angular/subscription","commits_url":"https://api.github.com/repos/gkalpak/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/gkalpak/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/gkalpak/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/gkalpak/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/gkalpak/angular/contents/{+path}","compare_url":"https://api.github.com/repos/gkalpak/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gkalpak/angular/merges","archive_url":"https://api.github.com/repos/gkalpak/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gkalpak/angular/downloads","issues_url":"https://api.github.com/repos/gkalpak/angular/issues{/number}","pulls_url":"https://api.github.com/repos/gkalpak/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/gkalpak/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/gkalpak/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gkalpak/angular/labels{/name}","releases_url":"https://api.github.com/repos/gkalpak/angular/releases{/id}","deployments_url":"https://api.github.com/repos/gkalpak/angular/deployments","created_at":"2015-09-10T12:16:17Z","updated_at":"2018-10-17T12:21:01Z","pushed_at":"2018-10-17T15:06:50Z","git_url":"git://github.com/gkalpak/angular.git","ssh_url":"git@github.com:gkalpak/angular.git","clone_url":"https://github.com/gkalpak/angular.git","svn_url":"https://github.com/gkalpak/angular","homepage":"https://angular.io","size":87133,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"948f507ba00beedbab74dfc5c602ab42cc8b6599","user":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"node_id":"MDEwOlJlcG9zaXRvcnkyNDE5NTMzOQ==","name":"angular","full_name":"angular/angular","private":false,"owner":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/angular/angular","description":"One framework. Mobile & desktop.","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2018-10-17T14:26:59Z","pushed_at":"2018-10-17T15:06:53Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":91524,"stargazers_count":41601,"watchers_count":41601,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10367,"mirror_url":null,"archived":false,"open_issues_count":2524,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10367,"open_issues":2524,"watchers":41601,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/26514"},"html":{"href":"https://github.com/angular/angular/pull/26514"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/26514"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/26514/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/26514/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/26514/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/779389369634a6ae0e48dc78bb815e2949a81c04"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"gkalpak"}}