{"action":"created","comment":{"url":"https://api.github.com/repos/BlueBrain/Brion/pulls/comments/185793563","pull_request_review_id":117254046,"id":185793563,"diff_hunk":"@@ -62,14 +62,35 @@ Vector4fs Soma::getProfilePoints() const\n \n float Soma::getMeanRadius() const\n {\n-    const Vector4fs points = getProfilePoints();\n-    const Vector3f centroid = _computeCentroid(points);\n+    const auto points = getProfilePoints();\n+    if (points.size() == 1)\n+        // Assume a (point, radius) soma\n+        return points[0][3];\n+\n+    const auto centroid = _computeCentroid(points);\n     float radius = 0;\n-    for (const Vector4f point : points)\n+    for (const auto point : points)","path":"brain/neuron/soma.cpp","position":29,"original_position":20,"commit_id":"dd8e85628fe47538c091f93dc3fd22830bc7e5cb","original_commit_id":"8d483d9887f6c81d66cb847a787d435300bc7414","user":{"login":"rdumusc","id":5166658,"avatar_url":"https://avatars2.githubusercontent.com/u/5166658?v=4","gravatar_id":"","url":"https://api.github.com/users/rdumusc","html_url":"https://github.com/rdumusc","followers_url":"https://api.github.com/users/rdumusc/followers","following_url":"https://api.github.com/users/rdumusc/following{/other_user}","gists_url":"https://api.github.com/users/rdumusc/gists{/gist_id}","starred_url":"https://api.github.com/users/rdumusc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdumusc/subscriptions","organizations_url":"https://api.github.com/users/rdumusc/orgs","repos_url":"https://api.github.com/users/rdumusc/repos","events_url":"https://api.github.com/users/rdumusc/events{/privacy}","received_events_url":"https://api.github.com/users/rdumusc/received_events","type":"User","site_admin":false},"body":"I also don't know what the real impact is, but it's best not to take chances :-)","created_at":"2018-05-03T13:18:20Z","updated_at":"2018-05-03T13:18:20Z","html_url":"https://github.com/BlueBrain/Brion/pull/225#discussion_r185793563","pull_request_url":"https://api.github.com/repos/BlueBrain/Brion/pulls/225","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/Brion/pulls/comments/185793563"},"html":{"href":"https://github.com/BlueBrain/Brion/pull/225#discussion_r185793563"},"pull_request":{"href":"https://api.github.com/repos/BlueBrain/Brion/pulls/225"}},"in_reply_to_id":185750951},"pull_request":{"url":"https://api.github.com/repos/BlueBrain/Brion/pulls/225","id":182815235,"html_url":"https://github.com/BlueBrain/Brion/pull/225","diff_url":"https://github.com/BlueBrain/Brion/pull/225.diff","patch_url":"https://github.com/BlueBrain/Brion/pull/225.patch","issue_url":"https://api.github.com/repos/BlueBrain/Brion/issues/225","number":225,"state":"open","locked":false,"title":"Added functions and classes required for removing BBPSDK from RTNeuron","user":{"login":"hernando","id":791427,"avatar_url":"https://avatars3.githubusercontent.com/u/791427?v=4","gravatar_id":"","url":"https://api.github.com/users/hernando","html_url":"https://github.com/hernando","followers_url":"https://api.github.com/users/hernando/followers","following_url":"https://api.github.com/users/hernando/following{/other_user}","gists_url":"https://api.github.com/users/hernando/gists{/gist_id}","starred_url":"https://api.github.com/users/hernando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hernando/subscriptions","organizations_url":"https://api.github.com/users/hernando/orgs","repos_url":"https://api.github.com/users/hernando/repos","events_url":"https://api.github.com/users/hernando/events{/privacy}","received_events_url":"https://api.github.com/users/hernando/received_events","type":"User","site_admin":false},"body":"Some Python wrapping helpers moved to a separate library\r\n\r\nPerformance improvement in reading scattered cell data from mvd3\r\n\r\nImprovements in synapse data loading:\r\n- Do not throw is synapse summary files are missing.\r\n- Make sure synapses between two cells are loaded from the afferent\r\nview to make synapse GIDs available.\r\n- If nrn_extra is missing generate GIDs based on the indices in the\r\nafferent view.","created_at":"2018-04-19T15:31:27Z","updated_at":"2018-05-03T13:18:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d588a6b130eb84b4503628e1f9c97af05279c611","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/BlueBrain/Brion/pulls/225/commits","review_comments_url":"https://api.github.com/repos/BlueBrain/Brion/pulls/225/comments","review_comment_url":"https://api.github.com/repos/BlueBrain/Brion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BlueBrain/Brion/issues/225/comments","statuses_url":"https://api.github.com/repos/BlueBrain/Brion/statuses/dd8e85628fe47538c091f93dc3fd22830bc7e5cb","head":{"label":"hernando:additions","ref":"additions","sha":"dd8e85628fe47538c091f93dc3fd22830bc7e5cb","user":{"login":"hernando","id":791427,"avatar_url":"https://avatars3.githubusercontent.com/u/791427?v=4","gravatar_id":"","url":"https://api.github.com/users/hernando","html_url":"https://github.com/hernando","followers_url":"https://api.github.com/users/hernando/followers","following_url":"https://api.github.com/users/hernando/following{/other_user}","gists_url":"https://api.github.com/users/hernando/gists{/gist_id}","starred_url":"https://api.github.com/users/hernando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hernando/subscriptions","organizations_url":"https://api.github.com/users/hernando/orgs","repos_url":"https://api.github.com/users/hernando/repos","events_url":"https://api.github.com/users/hernando/events{/privacy}","received_events_url":"https://api.github.com/users/hernando/received_events","type":"User","site_admin":false},"repo":{"id":36439822,"name":"Brion","full_name":"hernando/Brion","owner":{"login":"hernando","id":791427,"avatar_url":"https://avatars3.githubusercontent.com/u/791427?v=4","gravatar_id":"","url":"https://api.github.com/users/hernando","html_url":"https://github.com/hernando","followers_url":"https://api.github.com/users/hernando/followers","following_url":"https://api.github.com/users/hernando/following{/other_user}","gists_url":"https://api.github.com/users/hernando/gists{/gist_id}","starred_url":"https://api.github.com/users/hernando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hernando/subscriptions","organizations_url":"https://api.github.com/users/hernando/orgs","repos_url":"https://api.github.com/users/hernando/repos","events_url":"https://api.github.com/users/hernando/events{/privacy}","received_events_url":"https://api.github.com/users/hernando/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hernando/Brion","description":"Blue Brain C++ File IO Library","fork":true,"url":"https://api.github.com/repos/hernando/Brion","forks_url":"https://api.github.com/repos/hernando/Brion/forks","keys_url":"https://api.github.com/repos/hernando/Brion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hernando/Brion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hernando/Brion/teams","hooks_url":"https://api.github.com/repos/hernando/Brion/hooks","issue_events_url":"https://api.github.com/repos/hernando/Brion/issues/events{/number}","events_url":"https://api.github.com/repos/hernando/Brion/events","assignees_url":"https://api.github.com/repos/hernando/Brion/assignees{/user}","branches_url":"https://api.github.com/repos/hernando/Brion/branches{/branch}","tags_url":"https://api.github.com/repos/hernando/Brion/tags","blobs_url":"https://api.github.com/repos/hernando/Brion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hernando/Brion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hernando/Brion/git/refs{/sha}","trees_url":"https://api.github.com/repos/hernando/Brion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hernando/Brion/statuses/{sha}","languages_url":"https://api.github.com/repos/hernando/Brion/languages","stargazers_url":"https://api.github.com/repos/hernando/Brion/stargazers","contributors_url":"https://api.github.com/repos/hernando/Brion/contributors","subscribers_url":"https://api.github.com/repos/hernando/Brion/subscribers","subscription_url":"https://api.github.com/repos/hernando/Brion/subscription","commits_url":"https://api.github.com/repos/hernando/Brion/commits{/sha}","git_commits_url":"https://api.github.com/repos/hernando/Brion/git/commits{/sha}","comments_url":"https://api.github.com/repos/hernando/Brion/comments{/number}","issue_comment_url":"https://api.github.com/repos/hernando/Brion/issues/comments{/number}","contents_url":"https://api.github.com/repos/hernando/Brion/contents/{+path}","compare_url":"https://api.github.com/repos/hernando/Brion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hernando/Brion/merges","archive_url":"https://api.github.com/repos/hernando/Brion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hernando/Brion/downloads","issues_url":"https://api.github.com/repos/hernando/Brion/issues{/number}","pulls_url":"https://api.github.com/repos/hernando/Brion/pulls{/number}","milestones_url":"https://api.github.com/repos/hernando/Brion/milestones{/number}","notifications_url":"https://api.github.com/repos/hernando/Brion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hernando/Brion/labels{/name}","releases_url":"https://api.github.com/repos/hernando/Brion/releases{/id}","deployments_url":"https://api.github.com/repos/hernando/Brion/deployments","created_at":"2015-05-28T13:23:07Z","updated_at":"2018-03-21T12:15:01Z","pushed_at":"2018-05-03T13:05:49Z","git_url":"git://github.com/hernando/Brion.git","ssh_url":"git@github.com:hernando/Brion.git","clone_url":"https://github.com/hernando/Brion.git","svn_url":"https://github.com/hernando/Brion","homepage":"http://bluebrain.github.io/","size":1600,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BlueBrain:master","ref":"master","sha":"8da98d2fed8e515e052723fb2485b9f8586140b4","user":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars1.githubusercontent.com/u/1479142?v=4","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"repo":{"id":35547993,"name":"Brion","full_name":"BlueBrain/Brion","owner":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars1.githubusercontent.com/u/1479142?v=4","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BlueBrain/Brion","description":"Blue Brain C++ File IO Library","fork":false,"url":"https://api.github.com/repos/BlueBrain/Brion","forks_url":"https://api.github.com/repos/BlueBrain/Brion/forks","keys_url":"https://api.github.com/repos/BlueBrain/Brion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BlueBrain/Brion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BlueBrain/Brion/teams","hooks_url":"https://api.github.com/repos/BlueBrain/Brion/hooks","issue_events_url":"https://api.github.com/repos/BlueBrain/Brion/issues/events{/number}","events_url":"https://api.github.com/repos/BlueBrain/Brion/events","assignees_url":"https://api.github.com/repos/BlueBrain/Brion/assignees{/user}","branches_url":"https://api.github.com/repos/BlueBrain/Brion/branches{/branch}","tags_url":"https://api.github.com/repos/BlueBrain/Brion/tags","blobs_url":"https://api.github.com/repos/BlueBrain/Brion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BlueBrain/Brion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BlueBrain/Brion/git/refs{/sha}","trees_url":"https://api.github.com/repos/BlueBrain/Brion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BlueBrain/Brion/statuses/{sha}","languages_url":"https://api.github.com/repos/BlueBrain/Brion/languages","stargazers_url":"https://api.github.com/repos/BlueBrain/Brion/stargazers","contributors_url":"https://api.github.com/repos/BlueBrain/Brion/contributors","subscribers_url":"https://api.github.com/repos/BlueBrain/Brion/subscribers","subscription_url":"https://api.github.com/repos/BlueBrain/Brion/subscription","commits_url":"https://api.github.com/repos/BlueBrain/Brion/commits{/sha}","git_commits_url":"https://api.github.com/repos/BlueBrain/Brion/git/commits{/sha}","comments_url":"https://api.github.com/repos/BlueBrain/Brion/comments{/number}","issue_comment_url":"https://api.github.com/repos/BlueBrain/Brion/issues/comments{/number}","contents_url":"https://api.github.com/repos/BlueBrain/Brion/contents/{+path}","compare_url":"https://api.github.com/repos/BlueBrain/Brion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BlueBrain/Brion/merges","archive_url":"https://api.github.com/repos/BlueBrain/Brion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BlueBrain/Brion/downloads","issues_url":"https://api.github.com/repos/BlueBrain/Brion/issues{/number}","pulls_url":"https://api.github.com/repos/BlueBrain/Brion/pulls{/number}","milestones_url":"https://api.github.com/repos/BlueBrain/Brion/milestones{/number}","notifications_url":"https://api.github.com/repos/BlueBrain/Brion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BlueBrain/Brion/labels{/name}","releases_url":"https://api.github.com/repos/BlueBrain/Brion/releases{/id}","deployments_url":"https://api.github.com/repos/BlueBrain/Brion/deployments","created_at":"2015-05-13T12:33:49Z","updated_at":"2018-04-25T17:28:06Z","pushed_at":"2018-05-03T13:05:50Z","git_url":"git://github.com/BlueBrain/Brion.git","ssh_url":"git@github.com:BlueBrain/Brion.git","clone_url":"https://github.com/BlueBrain/Brion.git","svn_url":"https://github.com/BlueBrain/Brion","homepage":"http://bluebrain.github.io/","size":1509,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":20,"open_issues":7,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/Brion/pulls/225"},"html":{"href":"https://github.com/BlueBrain/Brion/pull/225"},"issue":{"href":"https://api.github.com/repos/BlueBrain/Brion/issues/225"},"comments":{"href":"https://api.github.com/repos/BlueBrain/Brion/issues/225/comments"},"review_comments":{"href":"https://api.github.com/repos/BlueBrain/Brion/pulls/225/comments"},"review_comment":{"href":"https://api.github.com/repos/BlueBrain/Brion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BlueBrain/Brion/pulls/225/commits"},"statuses":{"href":"https://api.github.com/repos/BlueBrain/Brion/statuses/dd8e85628fe47538c091f93dc3fd22830bc7e5cb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rdumusc"}}