{"push_id":2607405469,"size":2,"distinct_size":2,"ref":"refs/heads/th/build-cleanup-defines","head":"bc06d9a5edf0924e92a5e7b57c83252b1595917a","before":"8fe092ab5053e392520697c7b137edd7f401fd01","commits":[{"sha":"29d6b0fd5bc047e1516446e7c62c7c13e9191346","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"all: replace systemd's siphash24 with c-siphash\n\nOriginally, we used \"nm-utils/siphash24.c\", which was copied\nfrom systemd's source tree. It was both used by our own NetworkManager\ncode, and by our internal systemd fork.\n\nThen, we added \"shared/c-siphash\" as a dependency for n-acd.\n\nNow, drop systemd's implementation and use c-siphash also\nfor our internal purpose. Also, let systemd code use c-siphash,\nby patching \"src/systemd/src/basic/siphash24.h\".","distinct":true,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/29d6b0fd5bc047e1516446e7c62c7c13e9191346"},{"sha":"bc06d9a5edf0924e92a5e7b57c83252b1595917a","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"build/meson: fix meson build for shared files\n\nThe files in shared/nm-utils are not compiled as one static library,\ninstead each subproject that needs (parts of) them, re-compiles the\nfiles individually.\n\nThe major reason for that is, because we might have different compile\nflags, depending on whether we build libnm-core or\nlibnm-util/libnm-glib. Actually, I think that is not really the case,\nand maybe this should be refactored, to indeed build them all as a\nstatic library first.\n\nAnyway, libnm-util, libnm-glib, clients' common lib, they all need a\ndifferent set of shared files that they should compile. Refactor\n\"shared/meson.build\" to account for that and handle it like autotools\ndoes.\n\nAnother change is, that \"shared_c_siphash_dep\" no longer advertises\n\"include_directories: include_directories('c-siphash/src')\". We don't\nput c-siphash.h into the include search path. Users who need it, should\ninclude it via \"#include <c-siphash/src/c-siphash.h>\". The only exception\nis when building shared_n_acd library, which is not under our control.","distinct":true,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/bc06d9a5edf0924e92a5e7b57c83252b1595917a"}]}
{"actor":{"display_login":"fdo-mirror"}}