{"action":"created","comment":{"url":"https://api.github.com/repos/twosigma/Cook/pulls/comments/238819288","pull_request_review_id":181455406,"id":238819288,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODgxOTI4OA==","diff_hunk":"@@ -15,7 +12,7 @@ def __print_state(lines_to_move_up):\n     lines_to_move_up lines and then printing the current state of the data\n     list, which contains [item, status] pairs.\n     \"\"\"\n-    print_info(term.move_up * lines_to_move_up, end='')\n+    print_info('\\033[F' * lines_to_move_up, end='')","path":"cli/cook/progress.py","position":16,"original_position":16,"commit_id":"fae9e1e82b1d7951cb6249a839c86cf1f814830d","original_commit_id":"fae9e1e82b1d7951cb6249a839c86cf1f814830d","user":{"login":"nsinkov","id":8312298,"node_id":"MDQ6VXNlcjgzMTIyOTg=","avatar_url":"https://avatars3.githubusercontent.com/u/8312298?v=4","gravatar_id":"","url":"https://api.github.com/users/nsinkov","html_url":"https://github.com/nsinkov","followers_url":"https://api.github.com/users/nsinkov/followers","following_url":"https://api.github.com/users/nsinkov/following{/other_user}","gists_url":"https://api.github.com/users/nsinkov/gists{/gist_id}","starred_url":"https://api.github.com/users/nsinkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsinkov/subscriptions","organizations_url":"https://api.github.com/users/nsinkov/orgs","repos_url":"https://api.github.com/users/nsinkov/repos","events_url":"https://api.github.com/users/nsinkov/events{/privacy}","received_events_url":"https://api.github.com/users/nsinkov/received_events","type":"User","site_admin":false},"body":"suggestion:\r\nmove magic number to colors.py and rename colors.py to terminal.py","created_at":"2018-12-04T20:07:59Z","updated_at":"2018-12-04T20:07:59Z","html_url":"https://github.com/twosigma/Cook/pull/1046#discussion_r238819288","pull_request_url":"https://api.github.com/repos/twosigma/Cook/pulls/1046","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/twosigma/Cook/pulls/comments/238819288"},"html":{"href":"https://github.com/twosigma/Cook/pull/1046#discussion_r238819288"},"pull_request":{"href":"https://api.github.com/repos/twosigma/Cook/pulls/1046"}}},"pull_request":{"url":"https://api.github.com/repos/twosigma/Cook/pulls/1046","id":235941299,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1OTQxMjk5","html_url":"https://github.com/twosigma/Cook/pull/1046","diff_url":"https://github.com/twosigma/Cook/pull/1046.diff","patch_url":"https://github.com/twosigma/Cook/pull/1046.patch","issue_url":"https://api.github.com/repos/twosigma/Cook/issues/1046","number":1046,"state":"open","locked":false,"title":"Removes blessed","user":{"login":"dposada","id":444778,"node_id":"MDQ6VXNlcjQ0NDc3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/444778?v=4","gravatar_id":"","url":"https://api.github.com/users/dposada","html_url":"https://github.com/dposada","followers_url":"https://api.github.com/users/dposada/followers","following_url":"https://api.github.com/users/dposada/following{/other_user}","gists_url":"https://api.github.com/users/dposada/gists{/gist_id}","starred_url":"https://api.github.com/users/dposada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dposada/subscriptions","organizations_url":"https://api.github.com/users/dposada/orgs","repos_url":"https://api.github.com/users/dposada/repos","events_url":"https://api.github.com/users/dposada/events{/privacy}","received_events_url":"https://api.github.com/users/dposada/received_events","type":"User","site_admin":false},"body":"## Changes proposed in this PR\r\n\r\n- switching from using the `blessed` library to simply rolling our own terminal colors, etc.\r\n\r\n## Why are we making these changes?\r\n\r\nWe are running into issues with `blessed` when using `pyinstaller`. Also, we simply don't use much of the functionality provided by `blessed`, so it's nice to get rid of the dependency.\r\n","created_at":"2018-12-04T20:02:21Z","updated_at":"2018-12-04T20:07:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89a7b1b845f775d82e8badb71c279a48a2591535","assignee":{"login":"dposada","id":444778,"node_id":"MDQ6VXNlcjQ0NDc3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/444778?v=4","gravatar_id":"","url":"https://api.github.com/users/dposada","html_url":"https://github.com/dposada","followers_url":"https://api.github.com/users/dposada/followers","following_url":"https://api.github.com/users/dposada/following{/other_user}","gists_url":"https://api.github.com/users/dposada/gists{/gist_id}","starred_url":"https://api.github.com/users/dposada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dposada/subscriptions","organizations_url":"https://api.github.com/users/dposada/orgs","repos_url":"https://api.github.com/users/dposada/repos","events_url":"https://api.github.com/users/dposada/events{/privacy}","received_events_url":"https://api.github.com/users/dposada/received_events","type":"User","site_admin":false},"assignees":[{"login":"dposada","id":444778,"node_id":"MDQ6VXNlcjQ0NDc3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/444778?v=4","gravatar_id":"","url":"https://api.github.com/users/dposada","html_url":"https://github.com/dposada","followers_url":"https://api.github.com/users/dposada/followers","following_url":"https://api.github.com/users/dposada/following{/other_user}","gists_url":"https://api.github.com/users/dposada/gists{/gist_id}","starred_url":"https://api.github.com/users/dposada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dposada/subscriptions","organizations_url":"https://api.github.com/users/dposada/orgs","repos_url":"https://api.github.com/users/dposada/repos","events_url":"https://api.github.com/users/dposada/events{/privacy}","received_events_url":"https://api.github.com/users/dposada/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":711086781,"node_id":"MDU6TGFiZWw3MTEwODY3ODE=","url":"https://api.github.com/repos/twosigma/Cook/labels/cli","name":"cli","color":"fbca04","default":false},{"id":758298439,"node_id":"MDU6TGFiZWw3NTgyOTg0Mzk=","url":"https://api.github.com/repos/twosigma/Cook/labels/wip","name":"wip","color":"000000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/twosigma/Cook/pulls/1046/commits","review_comments_url":"https://api.github.com/repos/twosigma/Cook/pulls/1046/comments","review_comment_url":"https://api.github.com/repos/twosigma/Cook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twosigma/Cook/issues/1046/comments","statuses_url":"https://api.github.com/repos/twosigma/Cook/statuses/fae9e1e82b1d7951cb6249a839c86cf1f814830d","head":{"label":"dposada:remove-blessed","ref":"remove-blessed","sha":"fae9e1e82b1d7951cb6249a839c86cf1f814830d","user":{"login":"dposada","id":444778,"node_id":"MDQ6VXNlcjQ0NDc3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/444778?v=4","gravatar_id":"","url":"https://api.github.com/users/dposada","html_url":"https://github.com/dposada","followers_url":"https://api.github.com/users/dposada/followers","following_url":"https://api.github.com/users/dposada/following{/other_user}","gists_url":"https://api.github.com/users/dposada/gists{/gist_id}","starred_url":"https://api.github.com/users/dposada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dposada/subscriptions","organizations_url":"https://api.github.com/users/dposada/orgs","repos_url":"https://api.github.com/users/dposada/repos","events_url":"https://api.github.com/users/dposada/events{/privacy}","received_events_url":"https://api.github.com/users/dposada/received_events","type":"User","site_admin":false},"repo":{"id":79499145,"node_id":"MDEwOlJlcG9zaXRvcnk3OTQ5OTE0NQ==","name":"Cook","full_name":"dposada/Cook","private":false,"owner":{"login":"dposada","id":444778,"node_id":"MDQ6VXNlcjQ0NDc3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/444778?v=4","gravatar_id":"","url":"https://api.github.com/users/dposada","html_url":"https://github.com/dposada","followers_url":"https://api.github.com/users/dposada/followers","following_url":"https://api.github.com/users/dposada/following{/other_user}","gists_url":"https://api.github.com/users/dposada/gists{/gist_id}","starred_url":"https://api.github.com/users/dposada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dposada/subscriptions","organizations_url":"https://api.github.com/users/dposada/orgs","repos_url":"https://api.github.com/users/dposada/repos","events_url":"https://api.github.com/users/dposada/events{/privacy}","received_events_url":"https://api.github.com/users/dposada/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dposada/Cook","description":"Fair job scheduler on Mesos for batch workloads and Spark","fork":true,"url":"https://api.github.com/repos/dposada/Cook","forks_url":"https://api.github.com/repos/dposada/Cook/forks","keys_url":"https://api.github.com/repos/dposada/Cook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dposada/Cook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dposada/Cook/teams","hooks_url":"https://api.github.com/repos/dposada/Cook/hooks","issue_events_url":"https://api.github.com/repos/dposada/Cook/issues/events{/number}","events_url":"https://api.github.com/repos/dposada/Cook/events","assignees_url":"https://api.github.com/repos/dposada/Cook/assignees{/user}","branches_url":"https://api.github.com/repos/dposada/Cook/branches{/branch}","tags_url":"https://api.github.com/repos/dposada/Cook/tags","blobs_url":"https://api.github.com/repos/dposada/Cook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dposada/Cook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dposada/Cook/git/refs{/sha}","trees_url":"https://api.github.com/repos/dposada/Cook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dposada/Cook/statuses/{sha}","languages_url":"https://api.github.com/repos/dposada/Cook/languages","stargazers_url":"https://api.github.com/repos/dposada/Cook/stargazers","contributors_url":"https://api.github.com/repos/dposada/Cook/contributors","subscribers_url":"https://api.github.com/repos/dposada/Cook/subscribers","subscription_url":"https://api.github.com/repos/dposada/Cook/subscription","commits_url":"https://api.github.com/repos/dposada/Cook/commits{/sha}","git_commits_url":"https://api.github.com/repos/dposada/Cook/git/commits{/sha}","comments_url":"https://api.github.com/repos/dposada/Cook/comments{/number}","issue_comment_url":"https://api.github.com/repos/dposada/Cook/issues/comments{/number}","contents_url":"https://api.github.com/repos/dposada/Cook/contents/{+path}","compare_url":"https://api.github.com/repos/dposada/Cook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dposada/Cook/merges","archive_url":"https://api.github.com/repos/dposada/Cook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dposada/Cook/downloads","issues_url":"https://api.github.com/repos/dposada/Cook/issues{/number}","pulls_url":"https://api.github.com/repos/dposada/Cook/pulls{/number}","milestones_url":"https://api.github.com/repos/dposada/Cook/milestones{/number}","notifications_url":"https://api.github.com/repos/dposada/Cook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dposada/Cook/labels{/name}","releases_url":"https://api.github.com/repos/dposada/Cook/releases{/id}","deployments_url":"https://api.github.com/repos/dposada/Cook/deployments","created_at":"2017-01-19T21:54:37Z","updated_at":"2018-11-01T20:08:33Z","pushed_at":"2018-12-04T19:51:51Z","git_url":"git://github.com/dposada/Cook.git","ssh_url":"git@github.com:dposada/Cook.git","clone_url":"https://github.com/dposada/Cook.git","svn_url":"https://github.com/dposada/Cook","homepage":"","size":42960,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twosigma:master","ref":"master","sha":"ed53741f73dffeda2227f3f6a6b52bb697c4c79f","user":{"login":"twosigma","id":4049181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDkxODE=","avatar_url":"https://avatars3.githubusercontent.com/u/4049181?v=4","gravatar_id":"","url":"https://api.github.com/users/twosigma","html_url":"https://github.com/twosigma","followers_url":"https://api.github.com/users/twosigma/followers","following_url":"https://api.github.com/users/twosigma/following{/other_user}","gists_url":"https://api.github.com/users/twosigma/gists{/gist_id}","starred_url":"https://api.github.com/users/twosigma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twosigma/subscriptions","organizations_url":"https://api.github.com/users/twosigma/orgs","repos_url":"https://api.github.com/users/twosigma/repos","events_url":"https://api.github.com/users/twosigma/events{/privacy}","received_events_url":"https://api.github.com/users/twosigma/received_events","type":"Organization","site_admin":false},"repo":{"id":42325066,"node_id":"MDEwOlJlcG9zaXRvcnk0MjMyNTA2Ng==","name":"Cook","full_name":"twosigma/Cook","private":false,"owner":{"login":"twosigma","id":4049181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDkxODE=","avatar_url":"https://avatars3.githubusercontent.com/u/4049181?v=4","gravatar_id":"","url":"https://api.github.com/users/twosigma","html_url":"https://github.com/twosigma","followers_url":"https://api.github.com/users/twosigma/followers","following_url":"https://api.github.com/users/twosigma/following{/other_user}","gists_url":"https://api.github.com/users/twosigma/gists{/gist_id}","starred_url":"https://api.github.com/users/twosigma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twosigma/subscriptions","organizations_url":"https://api.github.com/users/twosigma/orgs","repos_url":"https://api.github.com/users/twosigma/repos","events_url":"https://api.github.com/users/twosigma/events{/privacy}","received_events_url":"https://api.github.com/users/twosigma/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/twosigma/Cook","description":"Fair job scheduler on Mesos for batch workloads and Spark","fork":false,"url":"https://api.github.com/repos/twosigma/Cook","forks_url":"https://api.github.com/repos/twosigma/Cook/forks","keys_url":"https://api.github.com/repos/twosigma/Cook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twosigma/Cook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twosigma/Cook/teams","hooks_url":"https://api.github.com/repos/twosigma/Cook/hooks","issue_events_url":"https://api.github.com/repos/twosigma/Cook/issues/events{/number}","events_url":"https://api.github.com/repos/twosigma/Cook/events","assignees_url":"https://api.github.com/repos/twosigma/Cook/assignees{/user}","branches_url":"https://api.github.com/repos/twosigma/Cook/branches{/branch}","tags_url":"https://api.github.com/repos/twosigma/Cook/tags","blobs_url":"https://api.github.com/repos/twosigma/Cook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twosigma/Cook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twosigma/Cook/git/refs{/sha}","trees_url":"https://api.github.com/repos/twosigma/Cook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twosigma/Cook/statuses/{sha}","languages_url":"https://api.github.com/repos/twosigma/Cook/languages","stargazers_url":"https://api.github.com/repos/twosigma/Cook/stargazers","contributors_url":"https://api.github.com/repos/twosigma/Cook/contributors","subscribers_url":"https://api.github.com/repos/twosigma/Cook/subscribers","subscription_url":"https://api.github.com/repos/twosigma/Cook/subscription","commits_url":"https://api.github.com/repos/twosigma/Cook/commits{/sha}","git_commits_url":"https://api.github.com/repos/twosigma/Cook/git/commits{/sha}","comments_url":"https://api.github.com/repos/twosigma/Cook/comments{/number}","issue_comment_url":"https://api.github.com/repos/twosigma/Cook/issues/comments{/number}","contents_url":"https://api.github.com/repos/twosigma/Cook/contents/{+path}","compare_url":"https://api.github.com/repos/twosigma/Cook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twosigma/Cook/merges","archive_url":"https://api.github.com/repos/twosigma/Cook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twosigma/Cook/downloads","issues_url":"https://api.github.com/repos/twosigma/Cook/issues{/number}","pulls_url":"https://api.github.com/repos/twosigma/Cook/pulls{/number}","milestones_url":"https://api.github.com/repos/twosigma/Cook/milestones{/number}","notifications_url":"https://api.github.com/repos/twosigma/Cook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twosigma/Cook/labels{/name}","releases_url":"https://api.github.com/repos/twosigma/Cook/releases{/id}","deployments_url":"https://api.github.com/repos/twosigma/Cook/deployments","created_at":"2015-09-11T18:20:08Z","updated_at":"2018-12-04T16:52:42Z","pushed_at":"2018-12-04T20:02:21Z","git_url":"git://github.com/twosigma/Cook.git","ssh_url":"git@github.com:twosigma/Cook.git","clone_url":"https://github.com/twosigma/Cook.git","svn_url":"https://github.com/twosigma/Cook","homepage":"","size":43179,"stargazers_count":275,"watchers_count":275,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":97,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":49,"open_issues":97,"watchers":275,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twosigma/Cook/pulls/1046"},"html":{"href":"https://github.com/twosigma/Cook/pull/1046"},"issue":{"href":"https://api.github.com/repos/twosigma/Cook/issues/1046"},"comments":{"href":"https://api.github.com/repos/twosigma/Cook/issues/1046/comments"},"review_comments":{"href":"https://api.github.com/repos/twosigma/Cook/pulls/1046/comments"},"review_comment":{"href":"https://api.github.com/repos/twosigma/Cook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twosigma/Cook/pulls/1046/commits"},"statuses":{"href":"https://api.github.com/repos/twosigma/Cook/statuses/fae9e1e82b1d7951cb6249a839c86cf1f814830d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nsinkov"}}