{"action":"created","comment":{"url":"https://api.github.com/repos/jetstack/tarmak/pulls/comments/177376294","pull_request_review_id":107231835,"id":177376294,"diff_hunk":"@@ -79,6 +79,7 @@ ExecStart=<%= scope['kubernetes::_dest_dir'] %>/kubelet \\\n   \"--tls-cert-file=<%= @cert_file %>\" \\\n   \"--tls-private-key-file=<%= @key_file %>\" \\\n <% end -%>\n+  --eviction-hard=memory.available<<%= @hard_eviction_memory_threshold %>","path":"puppet/modules/kubernetes/templates/kubelet.service.erb","position":4,"original_position":4,"commit_id":"0f68ceccd076b42e7b7ba708119d6fd21193e484","original_commit_id":"0f68ceccd076b42e7b7ba708119d6fd21193e484","user":{"login":"simonswine","id":223048,"avatar_url":"https://avatars0.githubusercontent.com/u/223048?v=4","gravatar_id":"","url":"https://api.github.com/users/simonswine","html_url":"https://github.com/simonswine","followers_url":"https://api.github.com/users/simonswine/followers","following_url":"https://api.github.com/users/simonswine/following{/other_user}","gists_url":"https://api.github.com/users/simonswine/gists{/gist_id}","starred_url":"https://api.github.com/users/simonswine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonswine/subscriptions","organizations_url":"https://api.github.com/users/simonswine/orgs","repos_url":"https://api.github.com/users/simonswine/repos","events_url":"https://api.github.com/users/simonswine/events{/privacy}","received_events_url":"https://api.github.com/users/simonswine/received_events","type":"User","site_admin":false},"body":"I would feel safer with quoting the whole thing `\"--eviction[...]%>\"`","created_at":"2018-03-27T10:22:49Z","updated_at":"2018-03-27T10:23:20Z","html_url":"https://github.com/jetstack/tarmak/pull/150#discussion_r177376294","pull_request_url":"https://api.github.com/repos/jetstack/tarmak/pulls/150","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/jetstack/tarmak/pulls/comments/177376294"},"html":{"href":"https://github.com/jetstack/tarmak/pull/150#discussion_r177376294"},"pull_request":{"href":"https://api.github.com/repos/jetstack/tarmak/pulls/150"}}},"pull_request":{"url":"https://api.github.com/repos/jetstack/tarmak/pulls/150","id":177490839,"html_url":"https://github.com/jetstack/tarmak/pull/150","diff_url":"https://github.com/jetstack/tarmak/pull/150.diff","patch_url":"https://github.com/jetstack/tarmak/pull/150.patch","issue_url":"https://api.github.com/repos/jetstack/tarmak/issues/150","number":150,"state":"open","locked":false,"title":"Set kubelet eviction-hard based on total memory","user":{"login":"charlieegan3","id":1774239,"avatar_url":"https://avatars3.githubusercontent.com/u/1774239?v=4","gravatar_id":"","url":"https://api.github.com/users/charlieegan3","html_url":"https://github.com/charlieegan3","followers_url":"https://api.github.com/users/charlieegan3/followers","following_url":"https://api.github.com/users/charlieegan3/following{/other_user}","gists_url":"https://api.github.com/users/charlieegan3/gists{/gist_id}","starred_url":"https://api.github.com/users/charlieegan3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlieegan3/subscriptions","organizations_url":"https://api.github.com/users/charlieegan3/orgs","repos_url":"https://api.github.com/users/charlieegan3/repos","events_url":"https://api.github.com/users/charlieegan3/events{/privacy}","received_events_url":"https://api.github.com/users/charlieegan3/received_events","type":"User","site_admin":false},"body":"The kubelet will default to memory.available<100Mi as the hard eviction\r\nthreshold. This makes that figure 5% of the total memory or 100Mi.\r\nWhichever is greater.\r\n\r\nRead from the default memory facts to set the kubelet `eviction-hard`\r\nparameter.\r\n\r\nDefault facts:\r\nhttps://puppet.com/docs/facter/3.10/core_facts.html#memory\r\n\r\nImplements https://github.com/jetstack/tarmak/issues/149\r\n\r\n<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\n```\r\n","created_at":"2018-03-26T15:53:39Z","updated_at":"2018-03-27T10:23:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7783984a00cd5e29041688ed858498f9306f9af","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":729324071,"url":"https://api.github.com/repos/jetstack/tarmak/labels/do-not-merge/release-note-label-needed","name":"do-not-merge/release-note-label-needed","color":"e11d21","default":false},{"id":729324234,"url":"https://api.github.com/repos/jetstack/tarmak/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jetstack/tarmak/pulls/150/commits","review_comments_url":"https://api.github.com/repos/jetstack/tarmak/pulls/150/comments","review_comment_url":"https://api.github.com/repos/jetstack/tarmak/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jetstack/tarmak/issues/150/comments","statuses_url":"https://api.github.com/repos/jetstack/tarmak/statuses/0f68ceccd076b42e7b7ba708119d6fd21193e484","head":{"label":"charlieegan3:hard-eviction-target-issue-149","ref":"hard-eviction-target-issue-149","sha":"0f68ceccd076b42e7b7ba708119d6fd21193e484","user":{"login":"charlieegan3","id":1774239,"avatar_url":"https://avatars3.githubusercontent.com/u/1774239?v=4","gravatar_id":"","url":"https://api.github.com/users/charlieegan3","html_url":"https://github.com/charlieegan3","followers_url":"https://api.github.com/users/charlieegan3/followers","following_url":"https://api.github.com/users/charlieegan3/following{/other_user}","gists_url":"https://api.github.com/users/charlieegan3/gists{/gist_id}","starred_url":"https://api.github.com/users/charlieegan3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlieegan3/subscriptions","organizations_url":"https://api.github.com/users/charlieegan3/orgs","repos_url":"https://api.github.com/users/charlieegan3/repos","events_url":"https://api.github.com/users/charlieegan3/events{/privacy}","received_events_url":"https://api.github.com/users/charlieegan3/received_events","type":"User","site_admin":false},"repo":{"id":126313234,"name":"tarmak","full_name":"charlieegan3/tarmak","owner":{"login":"charlieegan3","id":1774239,"avatar_url":"https://avatars3.githubusercontent.com/u/1774239?v=4","gravatar_id":"","url":"https://api.github.com/users/charlieegan3","html_url":"https://github.com/charlieegan3","followers_url":"https://api.github.com/users/charlieegan3/followers","following_url":"https://api.github.com/users/charlieegan3/following{/other_user}","gists_url":"https://api.github.com/users/charlieegan3/gists{/gist_id}","starred_url":"https://api.github.com/users/charlieegan3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlieegan3/subscriptions","organizations_url":"https://api.github.com/users/charlieegan3/orgs","repos_url":"https://api.github.com/users/charlieegan3/repos","events_url":"https://api.github.com/users/charlieegan3/events{/privacy}","received_events_url":"https://api.github.com/users/charlieegan3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/charlieegan3/tarmak","description":"A toolkit for Kubernetes cluster provisioning and lifecycle management","fork":true,"url":"https://api.github.com/repos/charlieegan3/tarmak","forks_url":"https://api.github.com/repos/charlieegan3/tarmak/forks","keys_url":"https://api.github.com/repos/charlieegan3/tarmak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/charlieegan3/tarmak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/charlieegan3/tarmak/teams","hooks_url":"https://api.github.com/repos/charlieegan3/tarmak/hooks","issue_events_url":"https://api.github.com/repos/charlieegan3/tarmak/issues/events{/number}","events_url":"https://api.github.com/repos/charlieegan3/tarmak/events","assignees_url":"https://api.github.com/repos/charlieegan3/tarmak/assignees{/user}","branches_url":"https://api.github.com/repos/charlieegan3/tarmak/branches{/branch}","tags_url":"https://api.github.com/repos/charlieegan3/tarmak/tags","blobs_url":"https://api.github.com/repos/charlieegan3/tarmak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/charlieegan3/tarmak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/charlieegan3/tarmak/git/refs{/sha}","trees_url":"https://api.github.com/repos/charlieegan3/tarmak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/charlieegan3/tarmak/statuses/{sha}","languages_url":"https://api.github.com/repos/charlieegan3/tarmak/languages","stargazers_url":"https://api.github.com/repos/charlieegan3/tarmak/stargazers","contributors_url":"https://api.github.com/repos/charlieegan3/tarmak/contributors","subscribers_url":"https://api.github.com/repos/charlieegan3/tarmak/subscribers","subscription_url":"https://api.github.com/repos/charlieegan3/tarmak/subscription","commits_url":"https://api.github.com/repos/charlieegan3/tarmak/commits{/sha}","git_commits_url":"https://api.github.com/repos/charlieegan3/tarmak/git/commits{/sha}","comments_url":"https://api.github.com/repos/charlieegan3/tarmak/comments{/number}","issue_comment_url":"https://api.github.com/repos/charlieegan3/tarmak/issues/comments{/number}","contents_url":"https://api.github.com/repos/charlieegan3/tarmak/contents/{+path}","compare_url":"https://api.github.com/repos/charlieegan3/tarmak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/charlieegan3/tarmak/merges","archive_url":"https://api.github.com/repos/charlieegan3/tarmak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/charlieegan3/tarmak/downloads","issues_url":"https://api.github.com/repos/charlieegan3/tarmak/issues{/number}","pulls_url":"https://api.github.com/repos/charlieegan3/tarmak/pulls{/number}","milestones_url":"https://api.github.com/repos/charlieegan3/tarmak/milestones{/number}","notifications_url":"https://api.github.com/repos/charlieegan3/tarmak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/charlieegan3/tarmak/labels{/name}","releases_url":"https://api.github.com/repos/charlieegan3/tarmak/releases{/id}","deployments_url":"https://api.github.com/repos/charlieegan3/tarmak/deployments","created_at":"2018-03-22T09:44:40Z","updated_at":"2018-03-22T09:44:44Z","pushed_at":"2018-03-26T15:58:41Z","git_url":"git://github.com/charlieegan3/tarmak.git","ssh_url":"git@github.com:charlieegan3/tarmak.git","clone_url":"https://github.com/charlieegan3/tarmak.git","svn_url":"https://github.com/charlieegan3/tarmak","homepage":"","size":80023,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jetstack:master","ref":"master","sha":"3e4f5aebc583842c8dffcccd158fee088b8f782a","user":{"login":"jetstack","id":13183983,"avatar_url":"https://avatars1.githubusercontent.com/u/13183983?v=4","gravatar_id":"","url":"https://api.github.com/users/jetstack","html_url":"https://github.com/jetstack","followers_url":"https://api.github.com/users/jetstack/followers","following_url":"https://api.github.com/users/jetstack/following{/other_user}","gists_url":"https://api.github.com/users/jetstack/gists{/gist_id}","starred_url":"https://api.github.com/users/jetstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetstack/subscriptions","organizations_url":"https://api.github.com/users/jetstack/orgs","repos_url":"https://api.github.com/users/jetstack/repos","events_url":"https://api.github.com/users/jetstack/events{/privacy}","received_events_url":"https://api.github.com/users/jetstack/received_events","type":"Organization","site_admin":false},"repo":{"id":96748966,"name":"tarmak","full_name":"jetstack/tarmak","owner":{"login":"jetstack","id":13183983,"avatar_url":"https://avatars1.githubusercontent.com/u/13183983?v=4","gravatar_id":"","url":"https://api.github.com/users/jetstack","html_url":"https://github.com/jetstack","followers_url":"https://api.github.com/users/jetstack/followers","following_url":"https://api.github.com/users/jetstack/following{/other_user}","gists_url":"https://api.github.com/users/jetstack/gists{/gist_id}","starred_url":"https://api.github.com/users/jetstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetstack/subscriptions","organizations_url":"https://api.github.com/users/jetstack/orgs","repos_url":"https://api.github.com/users/jetstack/repos","events_url":"https://api.github.com/users/jetstack/events{/privacy}","received_events_url":"https://api.github.com/users/jetstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jetstack/tarmak","description":"A toolkit for Kubernetes cluster provisioning and lifecycle management","fork":false,"url":"https://api.github.com/repos/jetstack/tarmak","forks_url":"https://api.github.com/repos/jetstack/tarmak/forks","keys_url":"https://api.github.com/repos/jetstack/tarmak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jetstack/tarmak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jetstack/tarmak/teams","hooks_url":"https://api.github.com/repos/jetstack/tarmak/hooks","issue_events_url":"https://api.github.com/repos/jetstack/tarmak/issues/events{/number}","events_url":"https://api.github.com/repos/jetstack/tarmak/events","assignees_url":"https://api.github.com/repos/jetstack/tarmak/assignees{/user}","branches_url":"https://api.github.com/repos/jetstack/tarmak/branches{/branch}","tags_url":"https://api.github.com/repos/jetstack/tarmak/tags","blobs_url":"https://api.github.com/repos/jetstack/tarmak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jetstack/tarmak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jetstack/tarmak/git/refs{/sha}","trees_url":"https://api.github.com/repos/jetstack/tarmak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jetstack/tarmak/statuses/{sha}","languages_url":"https://api.github.com/repos/jetstack/tarmak/languages","stargazers_url":"https://api.github.com/repos/jetstack/tarmak/stargazers","contributors_url":"https://api.github.com/repos/jetstack/tarmak/contributors","subscribers_url":"https://api.github.com/repos/jetstack/tarmak/subscribers","subscription_url":"https://api.github.com/repos/jetstack/tarmak/subscription","commits_url":"https://api.github.com/repos/jetstack/tarmak/commits{/sha}","git_commits_url":"https://api.github.com/repos/jetstack/tarmak/git/commits{/sha}","comments_url":"https://api.github.com/repos/jetstack/tarmak/comments{/number}","issue_comment_url":"https://api.github.com/repos/jetstack/tarmak/issues/comments{/number}","contents_url":"https://api.github.com/repos/jetstack/tarmak/contents/{+path}","compare_url":"https://api.github.com/repos/jetstack/tarmak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jetstack/tarmak/merges","archive_url":"https://api.github.com/repos/jetstack/tarmak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jetstack/tarmak/downloads","issues_url":"https://api.github.com/repos/jetstack/tarmak/issues{/number}","pulls_url":"https://api.github.com/repos/jetstack/tarmak/pulls{/number}","milestones_url":"https://api.github.com/repos/jetstack/tarmak/milestones{/number}","notifications_url":"https://api.github.com/repos/jetstack/tarmak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jetstack/tarmak/labels{/name}","releases_url":"https://api.github.com/repos/jetstack/tarmak/releases{/id}","deployments_url":"https://api.github.com/repos/jetstack/tarmak/deployments","created_at":"2017-07-10T07:32:26Z","updated_at":"2018-03-26T15:02:00Z","pushed_at":"2018-03-27T09:42:25Z","git_url":"git://github.com/jetstack/tarmak.git","ssh_url":"git@github.com:jetstack/tarmak.git","clone_url":"https://github.com/jetstack/tarmak.git","svn_url":"https://github.com/jetstack/tarmak","homepage":"","size":80020,"stargazers_count":150,"watchers_count":150,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":18,"open_issues":47,"watchers":150,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jetstack/tarmak/pulls/150"},"html":{"href":"https://github.com/jetstack/tarmak/pull/150"},"issue":{"href":"https://api.github.com/repos/jetstack/tarmak/issues/150"},"comments":{"href":"https://api.github.com/repos/jetstack/tarmak/issues/150/comments"},"review_comments":{"href":"https://api.github.com/repos/jetstack/tarmak/pulls/150/comments"},"review_comment":{"href":"https://api.github.com/repos/jetstack/tarmak/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jetstack/tarmak/pulls/150/commits"},"statuses":{"href":"https://api.github.com/repos/jetstack/tarmak/statuses/0f68ceccd076b42e7b7ba708119d6fd21193e484"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"simonswine"}}