{"action":"created","issue":{"url":"https://api.github.com/repos/sequelize/sequelize/issues/10055","repository_url":"https://api.github.com/repos/sequelize/sequelize","labels_url":"https://api.github.com/repos/sequelize/sequelize/issues/10055/labels{/name}","comments_url":"https://api.github.com/repos/sequelize/sequelize/issues/10055/comments","events_url":"https://api.github.com/repos/sequelize/sequelize/issues/10055/events","html_url":"https://github.com/sequelize/sequelize/pull/10055","id":372309537,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NTM3NzY2","number":10055,"title":"refactor: use template strings, unify testing, remove dottie","user":{"login":"SimonSchick","id":3259089,"node_id":"MDQ6VXNlcjMyNTkwODk=","avatar_url":"https://avatars3.githubusercontent.com/u/3259089?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonSchick","html_url":"https://github.com/SimonSchick","followers_url":"https://api.github.com/users/SimonSchick/followers","following_url":"https://api.github.com/users/SimonSchick/following{/other_user}","gists_url":"https://api.github.com/users/SimonSchick/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonSchick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonSchick/subscriptions","organizations_url":"https://api.github.com/users/SimonSchick/orgs","repos_url":"https://api.github.com/users/SimonSchick/repos","events_url":"https://api.github.com/users/SimonSchick/events{/privacy}","received_events_url":"https://api.github.com/users/SimonSchick/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-21T12:25:26Z","updated_at":"2018-10-21T14:52:13Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/sequelize/sequelize/pulls/10055","html_url":"https://github.com/sequelize/sequelize/pull/10055","diff_url":"https://github.com/sequelize/sequelize/pull/10055.diff","patch_url":"https://github.com/sequelize/sequelize/pull/10055.patch"},"body":"### Pull Request check-list\r\n\r\n_Please make sure to review and check all of these items:_\r\n\r\n- [x] Does `npm run test` or `npm run test-DIALECT` pass with this change (including linting)?\r\n- [ ] Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?\r\n- [ ] Have you added new tests to prevent regressions?\r\n- [x] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?\r\n- [x] Did you follow the commit message conventions explained in [CONTRIBUTING.md](https://github.com/sequelize/sequelize/blob/master/CONTRIBUTING.md)?\r\n\r\n### Description of change\r\n\r\nLast big PR for a while.\r\n\r\n1) Used eslint to convert all string concat to template strings, see https://stackoverflow.com/questions/29055518/are-es6-template-literals-faster-than-string-concatenation\r\n2) Moved all usage of `suite` and `test` within tests to use the `describe` and `it` functions.\r\n3) Replaced dottie with _.set/get (one less dependency 🎉)"},"comment":{"url":"https://api.github.com/repos/sequelize/sequelize/issues/comments/431675372","html_url":"https://github.com/sequelize/sequelize/pull/10055#issuecomment-431675372","issue_url":"https://api.github.com/repos/sequelize/sequelize/issues/10055","id":431675372,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTY3NTM3Mg==","user":{"login":"SimonSchick","id":3259089,"node_id":"MDQ6VXNlcjMyNTkwODk=","avatar_url":"https://avatars3.githubusercontent.com/u/3259089?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonSchick","html_url":"https://github.com/SimonSchick","followers_url":"https://api.github.com/users/SimonSchick/followers","following_url":"https://api.github.com/users/SimonSchick/following{/other_user}","gists_url":"https://api.github.com/users/SimonSchick/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonSchick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonSchick/subscriptions","organizations_url":"https://api.github.com/users/SimonSchick/orgs","repos_url":"https://api.github.com/users/SimonSchick/repos","events_url":"https://api.github.com/users/SimonSchick/events{/privacy}","received_events_url":"https://api.github.com/users/SimonSchick/received_events","type":"User","site_admin":false},"created_at":"2018-10-21T14:52:13Z","updated_at":"2018-10-21T14:52:13Z","author_association":"CONTRIBUTOR","body":"Re dottie, I did a rudimentary benchmark with 10mil iterations.\r\n\r\n```\r\nget\r\nlodash: 2487.456ms\r\ndottie: 1422.263ms\r\nset\r\nlodash: 2952.551ms\r\ndottie: 2644.326ms\r\n```\r\n\r\nReason I removed it is that you use `_.get` `_.set` everywhere else, not sure if the performance impact is relevant at all."}}
{"actor":{"display_login":"SimonSchick"}}