{"action":"created","issue":{"url":"https://api.github.com/repos/TigerVNC/tigervnc/issues/677","repository_url":"https://api.github.com/repos/TigerVNC/tigervnc","labels_url":"https://api.github.com/repos/TigerVNC/tigervnc/issues/677/labels{/name}","comments_url":"https://api.github.com/repos/TigerVNC/tigervnc/issues/677/comments","events_url":"https://api.github.com/repos/TigerVNC/tigervnc/issues/677/events","html_url":"https://github.com/TigerVNC/tigervnc/pull/677","id":339929963,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNDYzOTAy","number":677,"title":"Add support for dynamic JPEG quality adjustment","user":{"login":"clbr","id":790333,"node_id":"MDQ6VXNlcjc5MDMzMw==","avatar_url":"https://avatars2.githubusercontent.com/u/790333?v=4","gravatar_id":"","url":"https://api.github.com/users/clbr","html_url":"https://github.com/clbr","followers_url":"https://api.github.com/users/clbr/followers","following_url":"https://api.github.com/users/clbr/following{/other_user}","gists_url":"https://api.github.com/users/clbr/gists{/gist_id}","starred_url":"https://api.github.com/users/clbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clbr/subscriptions","organizations_url":"https://api.github.com/users/clbr/orgs","repos_url":"https://api.github.com/users/clbr/repos","events_url":"https://api.github.com/users/clbr/events{/privacy}","received_events_url":"https://api.github.com/users/clbr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-07-10T17:03:06Z","updated_at":"2018-07-13T14:41:14Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/TigerVNC/tigervnc/pulls/677","html_url":"https://github.com/TigerVNC/tigervnc/pull/677","diff_url":"https://github.com/TigerVNC/tigervnc/pull/677.diff","patch_url":"https://github.com/TigerVNC/tigervnc/pull/677.patch"},"body":"These commits add support for dynamic JPEG quality adjustment, requested in #672.\r\n\r\nIt's added as a server-side option, where if enabled, all clients supporting the Tight\r\nencoding with jpeg images get it. It can be configured with the min and max parameters,\r\ngiving a range of quality values, using the same 0-9 scale as the client-side quality\r\noption.\r\n\r\nI ran some tests compared to the defaults (jpeg at constant level 8). First was a web\r\npage with text and two animated banners. Using the full dynamic range, 0-9, the numbers\r\nreported by Xvnc for Tight (JPEG) improved by 12%. Range 2-8 improved by 21%.\r\n\r\nThen I tried playing video, a 10-sec clip from a movie. Range 0-9 improved over the\r\nbaseline by 25%, and range 2-8 by 29%.\r\n\r\nI couldn't notice visual degradation, so setting the maximum even lower may work, depending\r\non workload. Fully compatible with existing VNC viewers, I tested two old binaries from\r\n2010 and 2008."},"comment":{"url":"https://api.github.com/repos/TigerVNC/tigervnc/issues/comments/404853636","html_url":"https://github.com/TigerVNC/tigervnc/pull/677#issuecomment-404853636","issue_url":"https://api.github.com/repos/TigerVNC/tigervnc/issues/677","id":404853636,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDg1MzYzNg==","user":{"login":"mmcclaskey","id":5209269,"node_id":"MDQ6VXNlcjUyMDkyNjk=","avatar_url":"https://avatars2.githubusercontent.com/u/5209269?v=4","gravatar_id":"","url":"https://api.github.com/users/mmcclaskey","html_url":"https://github.com/mmcclaskey","followers_url":"https://api.github.com/users/mmcclaskey/followers","following_url":"https://api.github.com/users/mmcclaskey/following{/other_user}","gists_url":"https://api.github.com/users/mmcclaskey/gists{/gist_id}","starred_url":"https://api.github.com/users/mmcclaskey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmcclaskey/subscriptions","organizations_url":"https://api.github.com/users/mmcclaskey/orgs","repos_url":"https://api.github.com/users/mmcclaskey/repos","events_url":"https://api.github.com/users/mmcclaskey/events{/privacy}","received_events_url":"https://api.github.com/users/mmcclaskey/received_events","type":"User","site_admin":false},"created_at":"2018-07-13T14:41:14Z","updated_at":"2018-07-13T14:41:14Z","author_association":"NONE","body":"I'm trying to build this commit. I've got a docker container that sets up the build environment, however, it fails. The documentation I've found out there on building tigervnc doesn't cover all the dependencies needed, or perhaps it does but not explicitly. So through trial and error I've got the dockerfile with all the needed ubuntu packages. I get the following error when doing a \"make servertarball\"\r\n\r\n-- Installing: /tmp/tigervnc-build.NCurOK/inst/usr/local/share/icons/hicolor/48x48/apps/tigervnc.png\r\n-- Installing: /tmp/tigervnc-build.NCurOK/inst/usr/local/share/icons/hicolor/scalable/apps/tigervnc.svg\r\ninstall: cannot stat './xorg.build/bin/Xvnc': No such file or directory\r\nCMakeFiles/servertarball.dir/build.make:59: recipe for target 'CMakeFiles/servertarball' failed\r\nmake[3]: *** [CMakeFiles/servertarball] Error 1\r\nCMakeFiles/Makefile2:103: recipe for target 'CMakeFiles/servertarball.dir/all' failed\r\nmake[2]: *** [CMakeFiles/servertarball.dir/all] Error 2\r\nCMakeFiles/Makefile2:110: recipe for target 'CMakeFiles/servertarball.dir/rule' failed\r\nmake[1]: *** [CMakeFiles/servertarball.dir/rule] Error 2\r\nMakefile:176: recipe for target 'servertarball' failed\r\nmake: *** [servertarball] Error 2\r\n\r\nIf I just try make tarball (just the viewer) I get the following error.\r\n\r\n-- Installing: /tmp/tigervnc-build.64oip7/inst/usr/local/share/icons/hicolor/scalable/apps/tigervnc.svg\r\nrelease/maketarball: 55: release/maketarball: pushd: not found\r\nCMakeFiles/tarball.dir/build.make:59: recipe for target 'CMakeFiles/tarball' failed\r\nmake[3]: *** [CMakeFiles/tarball] Error 127\r\n\r\n------- Dockerfile --------\r\n\r\nFROM ubuntu:16.04\r\n\r\nRUN apt-get update\r\nRUN apt-get install -y gettext libjpeg-turbo8 libjpeg-turbo8-dev libfltk1.3 openjdk-9-jre make gcc git\r\nRUN apt-get install -y autoconf cmake build-essential libx11-dev zlib1g-dev libfltk1.3-dev libgnutls-dev\r\nRUN apt-get install -y xorg-dev"}}
{"actor":{"display_login":"mmcclaskey"}}