{"action":"created","issue":{"url":"https://api.github.com/repos/NVIDIAGameWorks/Falcor/issues/155","repository_url":"https://api.github.com/repos/NVIDIAGameWorks/Falcor","labels_url":"https://api.github.com/repos/NVIDIAGameWorks/Falcor/issues/155/labels{/name}","comments_url":"https://api.github.com/repos/NVIDIAGameWorks/Falcor/issues/155/comments","events_url":"https://api.github.com/repos/NVIDIAGameWorks/Falcor/issues/155/events","html_url":"https://github.com/NVIDIAGameWorks/Falcor/issues/155","id":375154083,"node_id":"MDU6SXNzdWUzNzUxNTQwODM=","number":155,"title":"Cannot use ParameterBlock<> in shader.","user":{"login":"Alekssasho","id":1225431,"node_id":"MDQ6VXNlcjEyMjU0MzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1225431?v=4","gravatar_id":"","url":"https://api.github.com/users/Alekssasho","html_url":"https://github.com/Alekssasho","followers_url":"https://api.github.com/users/Alekssasho/followers","following_url":"https://api.github.com/users/Alekssasho/following{/other_user}","gists_url":"https://api.github.com/users/Alekssasho/gists{/gist_id}","starred_url":"https://api.github.com/users/Alekssasho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alekssasho/subscriptions","organizations_url":"https://api.github.com/users/Alekssasho/orgs","repos_url":"https://api.github.com/users/Alekssasho/repos","events_url":"https://api.github.com/users/Alekssasho/events{/privacy}","received_events_url":"https://api.github.com/users/Alekssasho/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-29T18:22:27Z","updated_at":"2018-10-29T18:33:50Z","closed_at":null,"author_association":"NONE","body":"If you add new ParameterBlock<> inside a shader, the root descriptor in dx12 fails to compile and issues warning.\r\n\r\nThe easiest way to reproduce is to change Shadow texture in ForwardRenderer sample to be in ParameterBlock.\r\nForwardRenderer.slang:\r\n   `Texture2D gVisibilityBuffer;`\r\n becomes\r\n`struct ShadowTextureData\r\n{\r\nTexture2D gVisibilityBuffer;\r\n};\r\nParameterBlock<ShadowTextureData> Shadow;`\r\n\r\nThis fails on runtime when trying to compile the root descriptor for this program with \r\n`Shader register range of type CBV (root parameter [3], visibility ALL, descriptor table slot [7]) overlaps with another shader register range (root parameter[0], visibility ALL, descriptor table slot [0]).`\r\nIt looks like some constant buffer has the same index as the ParameterBlock created in ShaderCommon.slang for material data.\r\n\r\nAm I doing something wrong, or there is a bug inside Falcor, which prevents from adding multiple ParameterBlocks ? "},"comment":{"url":"https://api.github.com/repos/NVIDIAGameWorks/Falcor/issues/comments/434028846","html_url":"https://github.com/NVIDIAGameWorks/Falcor/issues/155#issuecomment-434028846","issue_url":"https://api.github.com/repos/NVIDIAGameWorks/Falcor/issues/155","id":434028846,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDAyODg0Ng==","user":{"login":"nbenty","id":17769755,"node_id":"MDQ6VXNlcjE3NzY5NzU1","avatar_url":"https://avatars1.githubusercontent.com/u/17769755?v=4","gravatar_id":"","url":"https://api.github.com/users/nbenty","html_url":"https://github.com/nbenty","followers_url":"https://api.github.com/users/nbenty/followers","following_url":"https://api.github.com/users/nbenty/following{/other_user}","gists_url":"https://api.github.com/users/nbenty/gists{/gist_id}","starred_url":"https://api.github.com/users/nbenty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbenty/subscriptions","organizations_url":"https://api.github.com/users/nbenty/orgs","repos_url":"https://api.github.com/users/nbenty/repos","events_url":"https://api.github.com/users/nbenty/events{/privacy}","received_events_url":"https://api.github.com/users/nbenty/received_events","type":"User","site_admin":false},"created_at":"2018-10-29T18:33:50Z","updated_at":"2018-10-29T18:33:50Z","author_association":"CONTRIBUTOR","body":"You should be able to add multiple `ParameterBlocks`. I'm looking into it."}}
{"actor":{"display_login":"nbenty"}}