{"action":"created","issue":{"url":"https://api.github.com/repos/vim-airline/vim-airline/issues/1801","repository_url":"https://api.github.com/repos/vim-airline/vim-airline","labels_url":"https://api.github.com/repos/vim-airline/vim-airline/issues/1801/labels{/name}","comments_url":"https://api.github.com/repos/vim-airline/vim-airline/issues/1801/comments","events_url":"https://api.github.com/repos/vim-airline/vim-airline/issues/1801/events","html_url":"https://github.com/vim-airline/vim-airline/pull/1801","id":362820830,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NDM1Nzkw","number":1801,"title":"The rest of the wordcount fixes, and some improvements","user":{"login":"flemingfleming","id":38706002,"node_id":"MDQ6VXNlcjM4NzA2MDAy","avatar_url":"https://avatars3.githubusercontent.com/u/38706002?v=4","gravatar_id":"","url":"https://api.github.com/users/flemingfleming","html_url":"https://github.com/flemingfleming","followers_url":"https://api.github.com/users/flemingfleming/followers","following_url":"https://api.github.com/users/flemingfleming/following{/other_user}","gists_url":"https://api.github.com/users/flemingfleming/gists{/gist_id}","starred_url":"https://api.github.com/users/flemingfleming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flemingfleming/subscriptions","organizations_url":"https://api.github.com/users/flemingfleming/orgs","repos_url":"https://api.github.com/users/flemingfleming/repos","events_url":"https://api.github.com/users/flemingfleming/events{/privacy}","received_events_url":"https://api.github.com/users/flemingfleming/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-22T02:58:56Z","updated_at":"2018-09-22T03:53:26Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/vim-airline/vim-airline/pulls/1801","html_url":"https://github.com/vim-airline/vim-airline/pull/1801","diff_url":"https://github.com/vim-airline/vim-airline/pull/1801.diff","patch_url":"https://github.com/vim-airline/vim-airline/pull/1801.patch"},"body":"I compiled vim 7.2, so I think I've found the remaining problems now.\r\n\r\nAs mentioned in the commit details:\r\n- Old vim doesn't like funcrefs of script local function, so the format update function is now an autoload\r\n- Apparently 'normal!' can sometimes move the cursor if you were in insert mode so I compensated for that. It feels like it should be a vim bug, even if that won't help with supporting old versions of vim.\r\n- Stopped to_string() from refusing to format 0. It tries to format everything now, not sure what the expected behavior should be if you pass it a string (right now it optimistically tries to format everything)\r\n\r\n- Now the old get_wordcount() pulls the right values with a direct match. Seems simpler and more elegant than using magic indices.\r\n- I also changed one of the safety checks I missed to a simpler get() call. Hope you don't mind.\r\n- Added a bit of documentation that I forgot last time."},"comment":{"url":"https://api.github.com/repos/vim-airline/vim-airline/issues/comments/423714284","html_url":"https://github.com/vim-airline/vim-airline/pull/1801#issuecomment-423714284","issue_url":"https://api.github.com/repos/vim-airline/vim-airline/issues/1801","id":423714284,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzcxNDI4NA==","user":{"login":"flemingfleming","id":38706002,"node_id":"MDQ6VXNlcjM4NzA2MDAy","avatar_url":"https://avatars3.githubusercontent.com/u/38706002?v=4","gravatar_id":"","url":"https://api.github.com/users/flemingfleming","html_url":"https://github.com/flemingfleming","followers_url":"https://api.github.com/users/flemingfleming/followers","following_url":"https://api.github.com/users/flemingfleming/following{/other_user}","gists_url":"https://api.github.com/users/flemingfleming/gists{/gist_id}","starred_url":"https://api.github.com/users/flemingfleming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flemingfleming/subscriptions","organizations_url":"https://api.github.com/users/flemingfleming/orgs","repos_url":"https://api.github.com/users/flemingfleming/repos","events_url":"https://api.github.com/users/flemingfleming/events{/privacy}","received_events_url":"https://api.github.com/users/flemingfleming/received_events","type":"User","site_admin":false},"created_at":"2018-09-22T03:53:26Z","updated_at":"2018-09-22T03:53:26Z","author_association":"CONTRIBUTOR","body":"That should be about everything.\r\n\r\nI still feel like there's a better way to update the format strings. Crudely profiling it suggests that dynamically reloading them every time is causes performance hit of about 20% for the formatter.\r\n\r\nRetrospectively, it was naive to assume that the code worked perfectly on old versions, and not that I'd messed up and was actually running the wrong version."}}
{"actor":{"display_login":"flemingfleming"}}