{"action":"created","issue":{"url":"https://api.github.com/repos/liblouis/liblouis/issues/322","repository_url":"https://api.github.com/repos/liblouis/liblouis","labels_url":"https://api.github.com/repos/liblouis/liblouis/issues/322/labels{/name}","comments_url":"https://api.github.com/repos/liblouis/liblouis/issues/322/comments","events_url":"https://api.github.com/repos/liblouis/liblouis/issues/322/events","html_url":"https://github.com/liblouis/liblouis/issues/322","id":223909797,"number":322,"title":"Fix all compilation warnings","user":{"login":"bertfrees","id":1167989,"avatar_url":"https://avatars1.githubusercontent.com/u/1167989?v=4","gravatar_id":"","url":"https://api.github.com/users/bertfrees","html_url":"https://github.com/bertfrees","followers_url":"https://api.github.com/users/bertfrees/followers","following_url":"https://api.github.com/users/bertfrees/following{/other_user}","gists_url":"https://api.github.com/users/bertfrees/gists{/gist_id}","starred_url":"https://api.github.com/users/bertfrees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bertfrees/subscriptions","organizations_url":"https://api.github.com/users/bertfrees/orgs","repos_url":"https://api.github.com/users/bertfrees/repos","events_url":"https://api.github.com/users/bertfrees/events{/privacy}","received_events_url":"https://api.github.com/users/bertfrees/received_events","type":"User","site_admin":false},"labels":[{"id":121634785,"url":"https://api.github.com/repos/liblouis/liblouis/labels/2%20-%20In%20progress","name":"2 - In progress","color":"ffffff","default":false}],"state":"open","locked":false,"assignee":{"login":"egli","id":119274,"avatar_url":"https://avatars0.githubusercontent.com/u/119274?v=4","gravatar_id":"","url":"https://api.github.com/users/egli","html_url":"https://github.com/egli","followers_url":"https://api.github.com/users/egli/followers","following_url":"https://api.github.com/users/egli/following{/other_user}","gists_url":"https://api.github.com/users/egli/gists{/gist_id}","starred_url":"https://api.github.com/users/egli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egli/subscriptions","organizations_url":"https://api.github.com/users/egli/orgs","repos_url":"https://api.github.com/users/egli/repos","events_url":"https://api.github.com/users/egli/events{/privacy}","received_events_url":"https://api.github.com/users/egli/received_events","type":"User","site_admin":false},"assignees":[{"login":"egli","id":119274,"avatar_url":"https://avatars0.githubusercontent.com/u/119274?v=4","gravatar_id":"","url":"https://api.github.com/users/egli","html_url":"https://github.com/egli","followers_url":"https://api.github.com/users/egli/followers","following_url":"https://api.github.com/users/egli/following{/other_user}","gists_url":"https://api.github.com/users/egli/gists{/gist_id}","starred_url":"https://api.github.com/users/egli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egli/subscriptions","organizations_url":"https://api.github.com/users/egli/orgs","repos_url":"https://api.github.com/users/egli/repos","events_url":"https://api.github.com/users/egli/events{/privacy}","received_events_url":"https://api.github.com/users/egli/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/liblouis/liblouis/milestones/16","html_url":"https://github.com/liblouis/liblouis/milestone/16","labels_url":"https://api.github.com/repos/liblouis/liblouis/milestones/16/labels","id":2752270,"number":16,"title":"3.6","description":"","creator":{"login":"egli","id":119274,"avatar_url":"https://avatars0.githubusercontent.com/u/119274?v=4","gravatar_id":"","url":"https://api.github.com/users/egli","html_url":"https://github.com/egli","followers_url":"https://api.github.com/users/egli/followers","following_url":"https://api.github.com/users/egli/following{/other_user}","gists_url":"https://api.github.com/users/egli/gists{/gist_id}","starred_url":"https://api.github.com/users/egli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egli/subscriptions","organizations_url":"https://api.github.com/users/egli/orgs","repos_url":"https://api.github.com/users/egli/repos","events_url":"https://api.github.com/users/egli/events{/privacy}","received_events_url":"https://api.github.com/users/egli/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":6,"state":"open","created_at":"2017-09-08T06:45:08Z","updated_at":"2018-05-02T11:05:09Z","due_on":"2018-06-04T07:00:00Z","closed_at":null},"comments":11,"created_at":"2017-04-24T18:23:37Z","updated_at":"2018-05-02T15:03:13Z","closed_at":null,"author_association":"OWNER","body":"- [x] `passing 'yaml_char_t *' (aka 'unsigned char *') to parameter of type 'const char *' [-Wpointer-sign]`\r\n- [x] `assigning to 'char *' from 'yaml_char_t *' (aka 'unsigned char *') [-Wpointer-sign]`\r\n- [x] `using the result of an assignment as a condition without parentheses [-Wparentheses]`\r\n- [ ] `comparison of unsigned expression < 0 is always false [-Wtautological-compare]`\r\n- [ ] `comparison of unsigned enum expression < 0 is always false [-Wtautological-compare]`\r\n- [x] `'/*' within block comment [-Wcomment]`\r\n- [ ] `assigning to 'char *' from 'gl_uint8_t *' (aka 'unsigned char *') [-Wpointer-sign]`\r\n- [x] `data argument not used by format string [-Wformat-extra-args]`\r\n- [x] `add explicit braces to avoid dangling else [-Wdangling-else]`\r\n- [x] `[-Wdiscarded-qualifiers]` (see below)\r\n\r\nPossibly there are more if we enable more checks."},"comment":{"url":"https://api.github.com/repos/liblouis/liblouis/issues/comments/386009587","html_url":"https://github.com/liblouis/liblouis/issues/322#issuecomment-386009587","issue_url":"https://api.github.com/repos/liblouis/liblouis/issues/322","id":386009587,"user":{"login":"bertfrees","id":1167989,"avatar_url":"https://avatars1.githubusercontent.com/u/1167989?v=4","gravatar_id":"","url":"https://api.github.com/users/bertfrees","html_url":"https://github.com/bertfrees","followers_url":"https://api.github.com/users/bertfrees/followers","following_url":"https://api.github.com/users/bertfrees/following{/other_user}","gists_url":"https://api.github.com/users/bertfrees/gists{/gist_id}","starred_url":"https://api.github.com/users/bertfrees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bertfrees/subscriptions","organizations_url":"https://api.github.com/users/bertfrees/orgs","repos_url":"https://api.github.com/users/bertfrees/repos","events_url":"https://api.github.com/users/bertfrees/events{/privacy}","received_events_url":"https://api.github.com/users/bertfrees/received_events","type":"User","site_admin":false},"created_at":"2018-05-02T15:03:13Z","updated_at":"2018-05-02T15:03:13Z","author_association":"OWNER","body":"Apologies! All this time I though I was using gcc but it appears to be a gcc front-end for llvm.\r\n\r\nIf I run `make CC=/usr/local/bin/gcc-7` (7.2.0 installed from source), I get a different output, but still there are a lot more than your 32. I also have an 64-bit Intel machine by the way.\r\n\r\n    compileTranslationTable.c:247:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:984:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:1062:12: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:1177:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:1189:24: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:1296:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:1390:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:1423:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:1424:36: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:1429:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:1580:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:1596:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:1617:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:1628:23: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]\r\n    compileTranslationTable.c:1650:24: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:1712:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:1726:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:2048:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:2050:9: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:2129:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:2304:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:2369:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:2417:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:2547:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:2549:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:2569:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:2714:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:2716:8: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:2781:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:2783:8: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:2786:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:2815:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:2823:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:2875:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:2917:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:2931:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:2933:9: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:3006:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:3010:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:3049:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:3051:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:3401:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:3497:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:3618:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:3630:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:3641:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:3697:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:3715:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:3734:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:3761:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:3780:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:3798:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:3819:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:3828:41: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:3841:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:3921:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:3950:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:3952:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:4030:28: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:4537:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    compileTranslationTable.c:3867:23: warning: this statement may fall through [-Wimplicit-fallthrough=]\r\n    compileTranslationTable.c:3968:6: warning: this statement may fall through [-Wimplicit-fallthrough=]\r\n    lou_translateString.c:358:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    lou_translateString.c:372:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    lou_translateString.c:390:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    lou_translateString.c:598:9: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    lou_translateString.c:616:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    lou_translateString.c:632:10: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    lou_translateString.c:761:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    lou_translateString.c:785:9: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    lou_translateString.c:906:57: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    lou_translateString.c:908:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    lou_translateString.c:1407:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    lou_translateString.c:3693:77: warning: unused parameter 'mode' [-Wunused-parameter]\r\n    lou_translateString.c:834:8: warning: this statement may fall through [-Wimplicit-fallthrough=]\r\n    lou_translateString.c:3496:7: warning: this statement may fall through [-Wimplicit-fallthrough=]\r\n    lou_translateString.c:2017:20: warning: this statement may fall through [-Wimplicit-fallthrough=]\r\n    lou_translateString.c:2050:10: warning: this statement may fall through [-Wimplicit-fallthrough=]\r\n    lou_translateString.c:303:3: warning: 'transOpcode' may be used uninitialized in this function [-Wmaybe-uninitialized]\r\n    lou_translateString.c:1249:36: warning: 'posMapping3' may be used uninitialized in this function [-Wmaybe-uninitialized]\r\n    lou_translateString.c:1020:9: warning: 'passPosMapping' may be used uninitialized in this function [-Wmaybe-uninitialized]\r\n    lou_backTranslateString.c:1249:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    lou_backTranslateString.c:1264:26: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    lou_backTranslateString.c:1275:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    lou_backTranslateString.c:1322:44: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    lou_backTranslateString.c:1401:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    lou_backTranslateString.c:1415:9: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    lou_backTranslateString.c:1506:47: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    lou_backTranslateString.c:1507:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    lou_backTranslateString.c:633:10: warning: this statement may fall through [-Wimplicit-fallthrough=]\r\n    lou_backTranslateString.c:517:6: warning: 'multindRule' may be used uninitialized in this function [-Wmaybe-uninitialized]\r\n    lou_backTranslateString.c:209:39: warning: 'src' may be used uninitialized in this function [-Wmaybe-uninitialized]\r\n    commonTranslationFunctions.c:41:44: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    commonTranslationFunctions.c:46:44: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    commonTranslationFunctions.c:51:44: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    commonTranslationFunctions.c:56:44: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    commonTranslationFunctions.c:61:44: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    pattern.c:306:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    pattern.c:314:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    pattern.c:436:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    pattern.c:445:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    pattern.c:637:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    pattern.c:686:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    pattern.c:723:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    pattern.c:731:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    pattern.c:739:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    pattern.c:746:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    pattern.c:753:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    pattern.c:760:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    pattern.c:869:48: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    pattern.c:905:48: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    pattern.c:927:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    pattern.c:939:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    pattern.c:956:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    pattern.c:983:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    pattern.c:1018:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    pattern.c:1040:21: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    pattern.c:1075:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    pattern.c:1130:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    pattern.c:1281:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    pattern.c:1556:18: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    pattern.c:935:6: warning: this statement may fall through [-Wimplicit-fallthrough=]\r\n    pattern.c:1246:24: warning: this statement may fall through [-Wimplicit-fallthrough=]\r\n    pattern.c:949:1: warning: 'pattern_insert_alternate' defined but not used [-Wunused-function]\r\n    pattern.c:465:1: warning: 'pattern_print' defined but not used [-Wunused-function]\r\n    pattern.c:344:1: warning: 'pattern_output' defined but not used [-Wunused-function]\r\n    logging.c:76:30: warning: unused parameter 'level' [-Wunused-parameter]\r\n    brl_checks.c:374:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n    lou_debug.c:102:9: warning: pointer targets in return differ in signedness [-Wpointer-sign]\r\n    lou_trace.c:81:19: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]\r\n    lou_trace.c:101:9: warning: pointer targets in return differ in signedness [-Wpointer-sign]\r\n    lou_checkyaml.c:121:6: warning: unused variable 'parse_error' [-Wunused-variable]"}}
{"actor":{"display_login":"bertfrees"}}