{"action":"created","comment":{"url":"https://api.github.com/repos/endlessm/eos-installer/pulls/comments/194037678","pull_request_review_id":127136892,"id":194037678,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDAzNzY3OA==","diff_hunk":"@@ -1072,7 +1072,7 @@ gis_scribe_begin_verify (GisScribe *self,\n     g_pollable_input_stream_create_source (G_POLLABLE_INPUT_STREAM (gpg_stdout),\n                                            cancellable);\n   g_task_attach_source (task, task_data->stdout_source,\n-                        (GSourceFunc) gis_scribe_gpg_progress);\n+                        (GSourceFunc) (void (*)(void)) gis_scribe_gpg_progress);","path":"gnome-image-installer/pages/install/gis-scribe.c","position":283,"original_position":30,"commit_id":"44118d90577108864fc1d11f73c5c016d0729d88","original_commit_id":"2657567cdf2fc90c31923f54b09c9f23d47a1adb","user":{"login":"pwithnall","id":53172,"node_id":"MDQ6VXNlcjUzMTcy","avatar_url":"https://avatars2.githubusercontent.com/u/53172?v=4","gravatar_id":"","url":"https://api.github.com/users/pwithnall","html_url":"https://github.com/pwithnall","followers_url":"https://api.github.com/users/pwithnall/followers","following_url":"https://api.github.com/users/pwithnall/following{/other_user}","gists_url":"https://api.github.com/users/pwithnall/gists{/gist_id}","starred_url":"https://api.github.com/users/pwithnall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwithnall/subscriptions","organizations_url":"https://api.github.com/users/pwithnall/orgs","repos_url":"https://api.github.com/users/pwithnall/repos","events_url":"https://api.github.com/users/pwithnall/events{/privacy}","received_events_url":"https://api.github.com/users/pwithnall/received_events","type":"User","site_admin":false},"body":"*hopeful smile*","created_at":"2018-06-08T12:12:35Z","updated_at":"2018-06-08T12:12:35Z","html_url":"https://github.com/endlessm/eos-installer/pull/77#discussion_r194037678","pull_request_url":"https://api.github.com/repos/endlessm/eos-installer/pulls/77","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/endlessm/eos-installer/pulls/comments/194037678"},"html":{"href":"https://github.com/endlessm/eos-installer/pull/77#discussion_r194037678"},"pull_request":{"href":"https://api.github.com/repos/endlessm/eos-installer/pulls/77"}},"in_reply_to_id":193807296},"pull_request":{"url":"https://api.github.com/repos/endlessm/eos-installer/pulls/77","id":193372841,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMzcyODQx","html_url":"https://github.com/endlessm/eos-installer/pull/77","diff_url":"https://github.com/endlessm/eos-installer/pull/77.diff","patch_url":"https://github.com/endlessm/eos-installer/pull/77.patch","issue_url":"https://api.github.com/repos/endlessm/eos-installer/issues/77","number":77,"state":"open","locked":false,"title":"Add extra checks and logging to scribe; fix many warnings","user":{"login":"wjt","id":86760,"node_id":"MDQ6VXNlcjg2NzYw","avatar_url":"https://avatars2.githubusercontent.com/u/86760?v=4","gravatar_id":"","url":"https://api.github.com/users/wjt","html_url":"https://github.com/wjt","followers_url":"https://api.github.com/users/wjt/followers","following_url":"https://api.github.com/users/wjt/following{/other_user}","gists_url":"https://api.github.com/users/wjt/gists{/gist_id}","starred_url":"https://api.github.com/users/wjt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjt/subscriptions","organizations_url":"https://api.github.com/users/wjt/orgs","repos_url":"https://api.github.com/users/wjt/repos","events_url":"https://api.github.com/users/wjt/events{/privacy}","received_events_url":"https://api.github.com/users/wjt/received_events","type":"User","site_admin":false},"body":"I saw a transient GPG verification failure when reformatting from a nightly ISO in a virtual machine. There was no useful information in the journal (beyond GPG's \"BAD signature\" output); re-running the process (without a reboot or anything) worked fine; and I manually GPG-verified the ISO, the squashfs within it, and the uncompressed image within that. Mysterious!\n\nThere isn't really much to go on. Maybe this was a transient read error from the USB disk on which the ISO is stored. Maybe a cosmic ray flipped a bit. But in case it happens again, here is some extra debug output and an extra coherence check in the scribe.\n\nI also included many warning fixes, found by editing this project in GNOME Builder building against a non-Endless system.","created_at":"2018-06-07T16:02:50Z","updated_at":"2018-06-08T12:12:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc6596a42aba24717a184502064d7452887d0c82","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ramcq","id":254468,"node_id":"MDQ6VXNlcjI1NDQ2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/254468?v=4","gravatar_id":"","url":"https://api.github.com/users/ramcq","html_url":"https://github.com/ramcq","followers_url":"https://api.github.com/users/ramcq/followers","following_url":"https://api.github.com/users/ramcq/following{/other_user}","gists_url":"https://api.github.com/users/ramcq/gists{/gist_id}","starred_url":"https://api.github.com/users/ramcq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramcq/subscriptions","organizations_url":"https://api.github.com/users/ramcq/orgs","repos_url":"https://api.github.com/users/ramcq/repos","events_url":"https://api.github.com/users/ramcq/events{/privacy}","received_events_url":"https://api.github.com/users/ramcq/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/endlessm/eos-installer/pulls/77/commits","review_comments_url":"https://api.github.com/repos/endlessm/eos-installer/pulls/77/comments","review_comment_url":"https://api.github.com/repos/endlessm/eos-installer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endlessm/eos-installer/issues/77/comments","statuses_url":"https://api.github.com/repos/endlessm/eos-installer/statuses/44118d90577108864fc1d11f73c5c016d0729d88","head":{"label":"endlessm:mystery-verification-error","ref":"mystery-verification-error","sha":"44118d90577108864fc1d11f73c5c016d0729d88","user":{"login":"endlessm","id":1930958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzA5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":56624950,"node_id":"MDEwOlJlcG9zaXRvcnk1NjYyNDk1MA==","name":"eos-installer","full_name":"endlessm/eos-installer","owner":{"login":"endlessm","id":1930958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzA5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/eos-installer","description":"Copy of gnome-initial-setup that we will customize for use as an installer","fork":false,"url":"https://api.github.com/repos/endlessm/eos-installer","forks_url":"https://api.github.com/repos/endlessm/eos-installer/forks","keys_url":"https://api.github.com/repos/endlessm/eos-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/eos-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/eos-installer/teams","hooks_url":"https://api.github.com/repos/endlessm/eos-installer/hooks","issue_events_url":"https://api.github.com/repos/endlessm/eos-installer/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/eos-installer/events","assignees_url":"https://api.github.com/repos/endlessm/eos-installer/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/eos-installer/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/eos-installer/tags","blobs_url":"https://api.github.com/repos/endlessm/eos-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/eos-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/eos-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/eos-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/eos-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/eos-installer/languages","stargazers_url":"https://api.github.com/repos/endlessm/eos-installer/stargazers","contributors_url":"https://api.github.com/repos/endlessm/eos-installer/contributors","subscribers_url":"https://api.github.com/repos/endlessm/eos-installer/subscribers","subscription_url":"https://api.github.com/repos/endlessm/eos-installer/subscription","commits_url":"https://api.github.com/repos/endlessm/eos-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/eos-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/eos-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/eos-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/eos-installer/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/eos-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/eos-installer/merges","archive_url":"https://api.github.com/repos/endlessm/eos-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/eos-installer/downloads","issues_url":"https://api.github.com/repos/endlessm/eos-installer/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/eos-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/eos-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/eos-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/eos-installer/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/eos-installer/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/eos-installer/deployments","created_at":"2016-04-19T19:17:44Z","updated_at":"2018-05-07T21:03:57Z","pushed_at":"2018-06-08T11:40:26Z","git_url":"git://github.com/endlessm/eos-installer.git","ssh_url":"git@github.com:endlessm/eos-installer.git","clone_url":"https://github.com/endlessm/eos-installer.git","svn_url":"https://github.com/endlessm/eos-installer","homepage":null,"size":5262,"stargazers_count":5,"watchers_count":5,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":3,"open_issues":1,"watchers":5,"default_branch":"master"}},"base":{"label":"endlessm:master","ref":"master","sha":"5d298e58161e61b95139d8557d3a9671cee996e7","user":{"login":"endlessm","id":1930958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzA5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":56624950,"node_id":"MDEwOlJlcG9zaXRvcnk1NjYyNDk1MA==","name":"eos-installer","full_name":"endlessm/eos-installer","owner":{"login":"endlessm","id":1930958,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MzA5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/eos-installer","description":"Copy of gnome-initial-setup that we will customize for use as an installer","fork":false,"url":"https://api.github.com/repos/endlessm/eos-installer","forks_url":"https://api.github.com/repos/endlessm/eos-installer/forks","keys_url":"https://api.github.com/repos/endlessm/eos-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/eos-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/eos-installer/teams","hooks_url":"https://api.github.com/repos/endlessm/eos-installer/hooks","issue_events_url":"https://api.github.com/repos/endlessm/eos-installer/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/eos-installer/events","assignees_url":"https://api.github.com/repos/endlessm/eos-installer/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/eos-installer/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/eos-installer/tags","blobs_url":"https://api.github.com/repos/endlessm/eos-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/eos-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/eos-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/eos-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/eos-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/eos-installer/languages","stargazers_url":"https://api.github.com/repos/endlessm/eos-installer/stargazers","contributors_url":"https://api.github.com/repos/endlessm/eos-installer/contributors","subscribers_url":"https://api.github.com/repos/endlessm/eos-installer/subscribers","subscription_url":"https://api.github.com/repos/endlessm/eos-installer/subscription","commits_url":"https://api.github.com/repos/endlessm/eos-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/eos-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/eos-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/eos-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/eos-installer/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/eos-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/eos-installer/merges","archive_url":"https://api.github.com/repos/endlessm/eos-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/eos-installer/downloads","issues_url":"https://api.github.com/repos/endlessm/eos-installer/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/eos-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/eos-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/eos-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/eos-installer/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/eos-installer/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/eos-installer/deployments","created_at":"2016-04-19T19:17:44Z","updated_at":"2018-05-07T21:03:57Z","pushed_at":"2018-06-08T11:40:26Z","git_url":"git://github.com/endlessm/eos-installer.git","ssh_url":"git@github.com:endlessm/eos-installer.git","clone_url":"https://github.com/endlessm/eos-installer.git","svn_url":"https://github.com/endlessm/eos-installer","homepage":null,"size":5262,"stargazers_count":5,"watchers_count":5,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":3,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endlessm/eos-installer/pulls/77"},"html":{"href":"https://github.com/endlessm/eos-installer/pull/77"},"issue":{"href":"https://api.github.com/repos/endlessm/eos-installer/issues/77"},"comments":{"href":"https://api.github.com/repos/endlessm/eos-installer/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/endlessm/eos-installer/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/endlessm/eos-installer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endlessm/eos-installer/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/endlessm/eos-installer/statuses/44118d90577108864fc1d11f73c5c016d0729d88"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pwithnall"}}