{"action":"created","comment":{"url":"https://api.github.com/repos/capitalone/cloud-custodian/pulls/comments/210665218","pull_request_review_id":146929206,"id":210665218,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDY2NTIxOA==","diff_hunk":"@@ -0,0 +1,45 @@\n+# Copyright 2017 Capital One Services, LLC\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+# http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+from __future__ import absolute_import, division, print_function, unicode_literals\n+\n+from .common import BaseTest, functional\n+\n+\n+class TestSsm(BaseTest):\n+\n+    @functional\n+    def test_ssm_parameter_not_secure(self):\n+        session_factory = self.replay_flight_data(\"test_ssm_parameter_not_secure\")\n+        client = session_factory().client(\"ssm\")\n+\n+        client.put_parameter(Name='test-name',\n+                             Type='String',\n+                             Overwrite=True,\n+                             Value='test-value')\n+","path":"tests/test_ssm.py","position":30,"original_position":30,"commit_id":"5d092f396f00d892cd88e6775e00cce54ca8ddd5","original_commit_id":"5d092f396f00d892cd88e6775e00cce54ca8ddd5","user":{"login":"kapilt","id":21650,"node_id":"MDQ6VXNlcjIxNjUw","avatar_url":"https://avatars3.githubusercontent.com/u/21650?v=4","gravatar_id":"","url":"https://api.github.com/users/kapilt","html_url":"https://github.com/kapilt","followers_url":"https://api.github.com/users/kapilt/followers","following_url":"https://api.github.com/users/kapilt/following{/other_user}","gists_url":"https://api.github.com/users/kapilt/gists{/gist_id}","starred_url":"https://api.github.com/users/kapilt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kapilt/subscriptions","organizations_url":"https://api.github.com/users/kapilt/orgs","repos_url":"https://api.github.com/users/kapilt/repos","events_url":"https://api.github.com/users/kapilt/events{/privacy}","received_events_url":"https://api.github.com/users/kapilt/received_events","type":"User","site_admin":false},"body":"for functional tests, we do want the test to try and clean up after itself.  ie. `self.addCleanup(client.delete_parameters, Names=['test-name', 'secure-test-name'])`","created_at":"2018-08-16T16:43:52Z","updated_at":"2018-08-16T16:43:52Z","html_url":"https://github.com/capitalone/cloud-custodian/pull/2764#discussion_r210665218","pull_request_url":"https://api.github.com/repos/capitalone/cloud-custodian/pulls/2764","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/capitalone/cloud-custodian/pulls/comments/210665218"},"html":{"href":"https://github.com/capitalone/cloud-custodian/pull/2764#discussion_r210665218"},"pull_request":{"href":"https://api.github.com/repos/capitalone/cloud-custodian/pulls/2764"}}},"pull_request":{"url":"https://api.github.com/repos/capitalone/cloud-custodian/pulls/2764","id":208906894,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4OTA2ODk0","html_url":"https://github.com/capitalone/cloud-custodian/pull/2764","diff_url":"https://github.com/capitalone/cloud-custodian/pull/2764.diff","patch_url":"https://github.com/capitalone/cloud-custodian/pull/2764.patch","issue_url":"https://api.github.com/repos/capitalone/cloud-custodian/issues/2764","number":2764,"state":"open","locked":false,"title":"Add support for checking insecure SSM parameters","user":{"login":"troylar","id":1931732,"node_id":"MDQ6VXNlcjE5MzE3MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/1931732?v=4","gravatar_id":"","url":"https://api.github.com/users/troylar","html_url":"https://github.com/troylar","followers_url":"https://api.github.com/users/troylar/followers","following_url":"https://api.github.com/users/troylar/following{/other_user}","gists_url":"https://api.github.com/users/troylar/gists{/gist_id}","starred_url":"https://api.github.com/users/troylar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troylar/subscriptions","organizations_url":"https://api.github.com/users/troylar/orgs","repos_url":"https://api.github.com/users/troylar/repos","events_url":"https://api.github.com/users/troylar/events{/privacy}","received_events_url":"https://api.github.com/users/troylar/received_events","type":"User","site_admin":false},"body":"This PR resolves #2761 by adding support for checking insecure SSM parameters. ","created_at":"2018-08-16T15:55:51Z","updated_at":"2018-08-16T16:43:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c15f54113e7e269bf903f04405dedafcda8e3d32","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/capitalone/cloud-custodian/pulls/2764/commits","review_comments_url":"https://api.github.com/repos/capitalone/cloud-custodian/pulls/2764/comments","review_comment_url":"https://api.github.com/repos/capitalone/cloud-custodian/pulls/comments{/number}","comments_url":"https://api.github.com/repos/capitalone/cloud-custodian/issues/2764/comments","statuses_url":"https://api.github.com/repos/capitalone/cloud-custodian/statuses/5d092f396f00d892cd88e6775e00cce54ca8ddd5","head":{"label":"troylar:ssm_parameter_store","ref":"ssm_parameter_store","sha":"5d092f396f00d892cd88e6775e00cce54ca8ddd5","user":{"login":"troylar","id":1931732,"node_id":"MDQ6VXNlcjE5MzE3MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/1931732?v=4","gravatar_id":"","url":"https://api.github.com/users/troylar","html_url":"https://github.com/troylar","followers_url":"https://api.github.com/users/troylar/followers","following_url":"https://api.github.com/users/troylar/following{/other_user}","gists_url":"https://api.github.com/users/troylar/gists{/gist_id}","starred_url":"https://api.github.com/users/troylar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troylar/subscriptions","organizations_url":"https://api.github.com/users/troylar/orgs","repos_url":"https://api.github.com/users/troylar/repos","events_url":"https://api.github.com/users/troylar/events{/privacy}","received_events_url":"https://api.github.com/users/troylar/received_events","type":"User","site_admin":false},"repo":{"id":144397926,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQzOTc5MjY=","name":"cloud-custodian","full_name":"troylar/cloud-custodian","owner":{"login":"troylar","id":1931732,"node_id":"MDQ6VXNlcjE5MzE3MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/1931732?v=4","gravatar_id":"","url":"https://api.github.com/users/troylar","html_url":"https://github.com/troylar","followers_url":"https://api.github.com/users/troylar/followers","following_url":"https://api.github.com/users/troylar/following{/other_user}","gists_url":"https://api.github.com/users/troylar/gists{/gist_id}","starred_url":"https://api.github.com/users/troylar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troylar/subscriptions","organizations_url":"https://api.github.com/users/troylar/orgs","repos_url":"https://api.github.com/users/troylar/repos","events_url":"https://api.github.com/users/troylar/events{/privacy}","received_events_url":"https://api.github.com/users/troylar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/troylar/cloud-custodian","description":"Rules engine for cloud security, cost optimization, and governance, DSL in yaml for policies to query, filter, and take actions on resources","fork":true,"url":"https://api.github.com/repos/troylar/cloud-custodian","forks_url":"https://api.github.com/repos/troylar/cloud-custodian/forks","keys_url":"https://api.github.com/repos/troylar/cloud-custodian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/troylar/cloud-custodian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/troylar/cloud-custodian/teams","hooks_url":"https://api.github.com/repos/troylar/cloud-custodian/hooks","issue_events_url":"https://api.github.com/repos/troylar/cloud-custodian/issues/events{/number}","events_url":"https://api.github.com/repos/troylar/cloud-custodian/events","assignees_url":"https://api.github.com/repos/troylar/cloud-custodian/assignees{/user}","branches_url":"https://api.github.com/repos/troylar/cloud-custodian/branches{/branch}","tags_url":"https://api.github.com/repos/troylar/cloud-custodian/tags","blobs_url":"https://api.github.com/repos/troylar/cloud-custodian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/troylar/cloud-custodian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/troylar/cloud-custodian/git/refs{/sha}","trees_url":"https://api.github.com/repos/troylar/cloud-custodian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/troylar/cloud-custodian/statuses/{sha}","languages_url":"https://api.github.com/repos/troylar/cloud-custodian/languages","stargazers_url":"https://api.github.com/repos/troylar/cloud-custodian/stargazers","contributors_url":"https://api.github.com/repos/troylar/cloud-custodian/contributors","subscribers_url":"https://api.github.com/repos/troylar/cloud-custodian/subscribers","subscription_url":"https://api.github.com/repos/troylar/cloud-custodian/subscription","commits_url":"https://api.github.com/repos/troylar/cloud-custodian/commits{/sha}","git_commits_url":"https://api.github.com/repos/troylar/cloud-custodian/git/commits{/sha}","comments_url":"https://api.github.com/repos/troylar/cloud-custodian/comments{/number}","issue_comment_url":"https://api.github.com/repos/troylar/cloud-custodian/issues/comments{/number}","contents_url":"https://api.github.com/repos/troylar/cloud-custodian/contents/{+path}","compare_url":"https://api.github.com/repos/troylar/cloud-custodian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/troylar/cloud-custodian/merges","archive_url":"https://api.github.com/repos/troylar/cloud-custodian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/troylar/cloud-custodian/downloads","issues_url":"https://api.github.com/repos/troylar/cloud-custodian/issues{/number}","pulls_url":"https://api.github.com/repos/troylar/cloud-custodian/pulls{/number}","milestones_url":"https://api.github.com/repos/troylar/cloud-custodian/milestones{/number}","notifications_url":"https://api.github.com/repos/troylar/cloud-custodian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/troylar/cloud-custodian/labels{/name}","releases_url":"https://api.github.com/repos/troylar/cloud-custodian/releases{/id}","deployments_url":"https://api.github.com/repos/troylar/cloud-custodian/deployments","created_at":"2018-08-11T15:47:07Z","updated_at":"2018-08-11T15:47:15Z","pushed_at":"2018-08-16T15:53:40Z","git_url":"git://github.com/troylar/cloud-custodian.git","ssh_url":"git@github.com:troylar/cloud-custodian.git","clone_url":"https://github.com/troylar/cloud-custodian.git","svn_url":"https://github.com/troylar/cloud-custodian","homepage":"https://developer.capitalone.com/opensource-projects/cloud-custodian","size":79175,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"capitalone:master","ref":"master","sha":"af72c083bca0b80dbf12775b8f3a0e1745be9a75","user":{"login":"capitalone","id":8644615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2NDQ2MTU=","avatar_url":"https://avatars0.githubusercontent.com/u/8644615?v=4","gravatar_id":"","url":"https://api.github.com/users/capitalone","html_url":"https://github.com/capitalone","followers_url":"https://api.github.com/users/capitalone/followers","following_url":"https://api.github.com/users/capitalone/following{/other_user}","gists_url":"https://api.github.com/users/capitalone/gists{/gist_id}","starred_url":"https://api.github.com/users/capitalone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/capitalone/subscriptions","organizations_url":"https://api.github.com/users/capitalone/orgs","repos_url":"https://api.github.com/users/capitalone/repos","events_url":"https://api.github.com/users/capitalone/events{/privacy}","received_events_url":"https://api.github.com/users/capitalone/received_events","type":"Organization","site_admin":false},"repo":{"id":52837350,"node_id":"MDEwOlJlcG9zaXRvcnk1MjgzNzM1MA==","name":"cloud-custodian","full_name":"capitalone/cloud-custodian","owner":{"login":"capitalone","id":8644615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2NDQ2MTU=","avatar_url":"https://avatars0.githubusercontent.com/u/8644615?v=4","gravatar_id":"","url":"https://api.github.com/users/capitalone","html_url":"https://github.com/capitalone","followers_url":"https://api.github.com/users/capitalone/followers","following_url":"https://api.github.com/users/capitalone/following{/other_user}","gists_url":"https://api.github.com/users/capitalone/gists{/gist_id}","starred_url":"https://api.github.com/users/capitalone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/capitalone/subscriptions","organizations_url":"https://api.github.com/users/capitalone/orgs","repos_url":"https://api.github.com/users/capitalone/repos","events_url":"https://api.github.com/users/capitalone/events{/privacy}","received_events_url":"https://api.github.com/users/capitalone/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/capitalone/cloud-custodian","description":"Rules engine for cloud security, cost optimization, and governance, DSL in yaml for policies to query, filter, and take actions on resources","fork":false,"url":"https://api.github.com/repos/capitalone/cloud-custodian","forks_url":"https://api.github.com/repos/capitalone/cloud-custodian/forks","keys_url":"https://api.github.com/repos/capitalone/cloud-custodian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/capitalone/cloud-custodian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/capitalone/cloud-custodian/teams","hooks_url":"https://api.github.com/repos/capitalone/cloud-custodian/hooks","issue_events_url":"https://api.github.com/repos/capitalone/cloud-custodian/issues/events{/number}","events_url":"https://api.github.com/repos/capitalone/cloud-custodian/events","assignees_url":"https://api.github.com/repos/capitalone/cloud-custodian/assignees{/user}","branches_url":"https://api.github.com/repos/capitalone/cloud-custodian/branches{/branch}","tags_url":"https://api.github.com/repos/capitalone/cloud-custodian/tags","blobs_url":"https://api.github.com/repos/capitalone/cloud-custodian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/capitalone/cloud-custodian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/capitalone/cloud-custodian/git/refs{/sha}","trees_url":"https://api.github.com/repos/capitalone/cloud-custodian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/capitalone/cloud-custodian/statuses/{sha}","languages_url":"https://api.github.com/repos/capitalone/cloud-custodian/languages","stargazers_url":"https://api.github.com/repos/capitalone/cloud-custodian/stargazers","contributors_url":"https://api.github.com/repos/capitalone/cloud-custodian/contributors","subscribers_url":"https://api.github.com/repos/capitalone/cloud-custodian/subscribers","subscription_url":"https://api.github.com/repos/capitalone/cloud-custodian/subscription","commits_url":"https://api.github.com/repos/capitalone/cloud-custodian/commits{/sha}","git_commits_url":"https://api.github.com/repos/capitalone/cloud-custodian/git/commits{/sha}","comments_url":"https://api.github.com/repos/capitalone/cloud-custodian/comments{/number}","issue_comment_url":"https://api.github.com/repos/capitalone/cloud-custodian/issues/comments{/number}","contents_url":"https://api.github.com/repos/capitalone/cloud-custodian/contents/{+path}","compare_url":"https://api.github.com/repos/capitalone/cloud-custodian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/capitalone/cloud-custodian/merges","archive_url":"https://api.github.com/repos/capitalone/cloud-custodian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/capitalone/cloud-custodian/downloads","issues_url":"https://api.github.com/repos/capitalone/cloud-custodian/issues{/number}","pulls_url":"https://api.github.com/repos/capitalone/cloud-custodian/pulls{/number}","milestones_url":"https://api.github.com/repos/capitalone/cloud-custodian/milestones{/number}","notifications_url":"https://api.github.com/repos/capitalone/cloud-custodian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/capitalone/cloud-custodian/labels{/name}","releases_url":"https://api.github.com/repos/capitalone/cloud-custodian/releases{/id}","deployments_url":"https://api.github.com/repos/capitalone/cloud-custodian/deployments","created_at":"2016-03-01T01:11:20Z","updated_at":"2018-08-16T14:06:21Z","pushed_at":"2018-08-16T15:55:52Z","git_url":"git://github.com/capitalone/cloud-custodian.git","ssh_url":"git@github.com:capitalone/cloud-custodian.git","clone_url":"https://github.com/capitalone/cloud-custodian.git","svn_url":"https://github.com/capitalone/cloud-custodian","homepage":"https://developer.capitalone.com/opensource-projects/cloud-custodian","size":79630,"stargazers_count":1554,"watchers_count":1554,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":460,"mirror_url":null,"archived":false,"open_issues_count":402,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":460,"open_issues":402,"watchers":1554,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/capitalone/cloud-custodian/pulls/2764"},"html":{"href":"https://github.com/capitalone/cloud-custodian/pull/2764"},"issue":{"href":"https://api.github.com/repos/capitalone/cloud-custodian/issues/2764"},"comments":{"href":"https://api.github.com/repos/capitalone/cloud-custodian/issues/2764/comments"},"review_comments":{"href":"https://api.github.com/repos/capitalone/cloud-custodian/pulls/2764/comments"},"review_comment":{"href":"https://api.github.com/repos/capitalone/cloud-custodian/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/capitalone/cloud-custodian/pulls/2764/commits"},"statuses":{"href":"https://api.github.com/repos/capitalone/cloud-custodian/statuses/5d092f396f00d892cd88e6775e00cce54ca8ddd5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kapilt"}}