{"action":"created","issue":{"url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/issues/157","repository_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator","labels_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/issues/157/labels{/name}","comments_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/issues/157/comments","events_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/issues/157/events","html_url":"https://github.com/TheDevPath/googleMaps-offline-navigator/pull/157","id":299547991,"number":157,"title":"use api for signin and register","user":{"login":"seckboy","id":6200031,"avatar_url":"https://avatars3.githubusercontent.com/u/6200031?v=4","gravatar_id":"","url":"https://api.github.com/users/seckboy","html_url":"https://github.com/seckboy","followers_url":"https://api.github.com/users/seckboy/followers","following_url":"https://api.github.com/users/seckboy/following{/other_user}","gists_url":"https://api.github.com/users/seckboy/gists{/gist_id}","starred_url":"https://api.github.com/users/seckboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seckboy/subscriptions","organizations_url":"https://api.github.com/users/seckboy/orgs","repos_url":"https://api.github.com/users/seckboy/repos","events_url":"https://api.github.com/users/seckboy/events{/privacy}","received_events_url":"https://api.github.com/users/seckboy/received_events","type":"User","site_admin":false},"labels":[{"id":808479707,"url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/labels/review","name":"review","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-22T23:34:04Z","updated_at":"2018-02-23T03:07:03Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/pulls/157","html_url":"https://github.com/TheDevPath/googleMaps-offline-navigator/pull/157","diff_url":"https://github.com/TheDevPath/googleMaps-offline-navigator/pull/157.diff","patch_url":"https://github.com/TheDevPath/googleMaps-offline-navigator/pull/157.patch"},"body":"## Issue Number:\r\n125\r\n## Issue Description:\r\nConnect signin and register to api\r\n\r\n### Summary of solution:\r\n1. Used axios to connect to api\r\n2. Created client/src/js/auth-helpers.js \r\n3. Used cookies to store token\r\n\r\n### Can this issue be closed?\r\nYes\r\n\r\n### Should any new issues be added as a result of this solution?\r\nWe need a new issue to hook up forgot password and change password. These may need additions to backend api. Also perhaps a new issue to hide Profile, Maps, etc unless signed in.\r\n\r\n### Have you named your branch in a descriptive way? Remember to name your branch in a unique and descriptive manner in order to properly reflect the issue or feature.\r\nNamed attach-signin-to-api\r\n\r\n### Thanks for contributing!\r\n"},"comment":{"url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/issues/comments/367896352","html_url":"https://github.com/TheDevPath/googleMaps-offline-navigator/pull/157#issuecomment-367896352","issue_url":"https://api.github.com/repos/TheDevPath/googleMaps-offline-navigator/issues/157","id":367896352,"user":{"login":"seckboy","id":6200031,"avatar_url":"https://avatars3.githubusercontent.com/u/6200031?v=4","gravatar_id":"","url":"https://api.github.com/users/seckboy","html_url":"https://github.com/seckboy","followers_url":"https://api.github.com/users/seckboy/followers","following_url":"https://api.github.com/users/seckboy/following{/other_user}","gists_url":"https://api.github.com/users/seckboy/gists{/gist_id}","starred_url":"https://api.github.com/users/seckboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seckboy/subscriptions","organizations_url":"https://api.github.com/users/seckboy/orgs","repos_url":"https://api.github.com/users/seckboy/repos","events_url":"https://api.github.com/users/seckboy/events{/privacy}","received_events_url":"https://api.github.com/users/seckboy/received_events","type":"User","site_admin":false},"created_at":"2018-02-23T03:07:03Z","updated_at":"2018-02-23T03:07:03Z","author_association":"CONTRIBUTOR","body":"Those are all great suggestions and I will work on them. Yes testing will need its own ticket. I was trying to figure out how best to test error messages and registration flow. I started to get swallowed up with trying out enzyme, superagent-mock, etc. and gave up so I could get something to show even if it is without tests."}}
{"actor":{"display_login":"seckboy"}}