{"action":"created","issue":{"url":"https://api.github.com/repos/onivim/oni/issues/2372","repository_url":"https://api.github.com/repos/onivim/oni","labels_url":"https://api.github.com/repos/onivim/oni/issues/2372/labels{/name}","comments_url":"https://api.github.com/repos/onivim/oni/issues/2372/comments","events_url":"https://api.github.com/repos/onivim/oni/issues/2372/events","html_url":"https://github.com/onivim/oni/pull/2372","id":337066966,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MzY5OTc2","number":2372,"title":"Sort out CLI for Oni","user":{"login":"CrossR","id":10038688,"node_id":"MDQ6VXNlcjEwMDM4Njg4","avatar_url":"https://avatars1.githubusercontent.com/u/10038688?v=4","gravatar_id":"","url":"https://api.github.com/users/CrossR","html_url":"https://github.com/CrossR","followers_url":"https://api.github.com/users/CrossR/followers","following_url":"https://api.github.com/users/CrossR/following{/other_user}","gists_url":"https://api.github.com/users/CrossR/gists{/gist_id}","starred_url":"https://api.github.com/users/CrossR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CrossR/subscriptions","organizations_url":"https://api.github.com/users/CrossR/orgs","repos_url":"https://api.github.com/users/CrossR/repos","events_url":"https://api.github.com/users/CrossR/events{/privacy}","received_events_url":"https://api.github.com/users/CrossR/received_events","type":"User","site_admin":false},"labels":[{"id":854303629,"node_id":"MDU6TGFiZWw4NTQzMDM2Mjk=","url":"https://api.github.com/repos/onivim/oni/labels/breaking-change","name":"breaking-change","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-06-29T16:46:42Z","updated_at":"2018-07-01T00:39:58Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/onivim/oni/pulls/2372","html_url":"https://github.com/onivim/oni/pull/2372","diff_url":"https://github.com/onivim/oni/pull/2372.diff","patch_url":"https://github.com/onivim/oni/pull/2372.patch"},"body":"This PR aims to address some of the points outlined over in #1707.\r\n\r\nThe first thing I'm aiming to fix is the ability to launch in the background, by fixing/editing the existing launch script (well currently I've deleted the old one, but this is very WIP so I'm just seeing what works).\r\n\r\nI've based it on the VSCode script that is outlined in the linked issue.\r\n\r\nTodo:\r\n\r\n* [x] Windows Script.\r\n  * [ ] Look into double click issue (ie closing powershell takes two clicks of the close X?\r\n* [x] Linux Script.\r\n* [x] macOS Script (we do have one already, so I'll see about editing this etc)\r\n* [x] Check existing functionality isn't changed:\r\n  - Normal opening (Invoking Oni directly with a click)\r\n  - Opening a file that Oni is registered for.\r\n  - Opening a file via `Edit with Oni` (Windows only I think)\r\n  - Launching via Dev.\r\n* [x] Sort out the meshing of  the current CLI functionality and the new changes, ensure swapping folders, opening files and such is okay with the change.\r\n\r\nI'm considering the following but will probably just leave them to a second PR:\r\n- The updated workspace detection (may be simple enough when I'm checking/sorting the existing logic, so I'll see).\r\n- Add the option to pass neovim flags.\r\n- Instance management.\r\n\r\nThere is a very basic implementation I've done already that works on Windows, so seems like a good start, so hopefully it works across the other platforms."},"comment":{"url":"https://api.github.com/repos/onivim/oni/issues/comments/401575514","html_url":"https://github.com/onivim/oni/pull/2372#issuecomment-401575514","issue_url":"https://api.github.com/repos/onivim/oni/issues/2372","id":401575514,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTU3NTUxNA==","user":{"login":"bryphe","id":13532591,"node_id":"MDQ6VXNlcjEzNTMyNTkx","avatar_url":"https://avatars1.githubusercontent.com/u/13532591?v=4","gravatar_id":"","url":"https://api.github.com/users/bryphe","html_url":"https://github.com/bryphe","followers_url":"https://api.github.com/users/bryphe/followers","following_url":"https://api.github.com/users/bryphe/following{/other_user}","gists_url":"https://api.github.com/users/bryphe/gists{/gist_id}","starred_url":"https://api.github.com/users/bryphe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryphe/subscriptions","organizations_url":"https://api.github.com/users/bryphe/orgs","repos_url":"https://api.github.com/users/bryphe/repos","events_url":"https://api.github.com/users/bryphe/events{/privacy}","received_events_url":"https://api.github.com/users/bryphe/received_events","type":"User","site_admin":false},"created_at":"2018-07-01T00:39:58Z","updated_at":"2018-07-01T00:39:58Z","author_association":"COLLABORATOR","body":"> Had a stupid logic error, but fixed that now and it works to add to the path on mac.\r\n\r\nAh I missed that too when I looked at the code!  Glad you caught it.\r\n\r\n> I'll leave potentially adding an on launch check to a later PR, I'd rather stick with the CLI stuff whilst I'm in the area.\r\n\r\nSure, sounds reasonable as a separate PR - this change looks great 👍 "}}
{"actor":{"display_login":"bryphe"}}