{"action":"created","issue":{"url":"https://api.github.com/repos/mkerins/mass/issues/29","repository_url":"https://api.github.com/repos/mkerins/mass","labels_url":"https://api.github.com/repos/mkerins/mass/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/mkerins/mass/issues/29/comments","events_url":"https://api.github.com/repos/mkerins/mass/issues/29/events","html_url":"https://github.com/mkerins/mass/pull/29","id":378760800,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5Mzg3MzYz","number":29,"title":"Add pagination to list views","user":{"login":"mkerins","id":5294718,"node_id":"MDQ6VXNlcjUyOTQ3MTg=","avatar_url":"https://avatars3.githubusercontent.com/u/5294718?v=4","gravatar_id":"","url":"https://api.github.com/users/mkerins","html_url":"https://github.com/mkerins","followers_url":"https://api.github.com/users/mkerins/followers","following_url":"https://api.github.com/users/mkerins/following{/other_user}","gists_url":"https://api.github.com/users/mkerins/gists{/gist_id}","starred_url":"https://api.github.com/users/mkerins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkerins/subscriptions","organizations_url":"https://api.github.com/users/mkerins/orgs","repos_url":"https://api.github.com/users/mkerins/repos","events_url":"https://api.github.com/users/mkerins/events{/privacy}","received_events_url":"https://api.github.com/users/mkerins/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-08T14:41:22Z","updated_at":"2018-11-08T14:43:28Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/mkerins/mass/pulls/29","html_url":"https://github.com/mkerins/mass/pull/29","diff_url":"https://github.com/mkerins/mass/pull/29.diff","patch_url":"https://github.com/mkerins/mass/pull/29.patch"},"body":"Tried to use MultipleObjectMixin but it wasn't playing nice with\r\nFormView so used Paginator() directly\r\n\r\nfilestore/models.py\r\n- added default ordering so pagination results are more predictable\r\n\r\nfilestore/templates/filestore/{file_list.html,folder_list.html}\r\n- added pagination <nav> block to handle the display and operation of\r\n  the expected pagination experience (next, previous, etc.)\r\n\r\nfilestore/tests/test_views.py\r\n- added test to make sure requests to \"/\" get redirected to \"/files\"\r\n- added File and Folder tests to check pagination works properly\r\n\r\nfilestore/urls.py\r\n- to support pagination changed the FileList view to be on \"/files\"\r\n  instead of \"/\"\r\n\r\nfilestore/views.py\r\n- added simple index view function to redirect requests to \"/\" to\r\n  \"/files\"\r\n- removed unnecessary get_queryset() static methods\r\n- FileList and FolderList views now support pagination. Requests to\r\n  invalid or non-existant pages will go to page 1\r\n\r\nMisc\r\n- run_dev.sh and run_tests.sh: hit the \"/update_clamav_db\" endpoint\r\n  to update the ClamAV DB\r\n- format tox.ini to be consistent"},"comment":{"url":"https://api.github.com/repos/mkerins/mass/issues/comments/437017068","html_url":"https://github.com/mkerins/mass/pull/29#issuecomment-437017068","issue_url":"https://api.github.com/repos/mkerins/mass/issues/29","id":437017068,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzAxNzA2OA==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-11-08T14:43:28Z","updated_at":"2018-11-08T14:43:28Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/mkerins/mass/pull/29?src=pr&el=h1) Report\n> Merging [#29](https://codecov.io/gh/mkerins/mass/pull/29?src=pr&el=desc) into [master](https://codecov.io/gh/mkerins/mass/commit/9547db29c0326a0fd69f7da88268f81352bfd257?src=pr&el=desc) will **increase** coverage by `0.16%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/mkerins/mass/pull/29/graphs/tree.svg?width=650&token=6qlbkIbNYG&height=150&src=pr)](https://codecov.io/gh/mkerins/mass/pull/29?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master      #29      +/-   ##\n==========================================\n+ Coverage    96.6%   96.76%   +0.16%     \n==========================================\n  Files           6        6              \n  Lines         383      402      +19     \n==========================================\n+ Hits          370      389      +19     \n  Misses         13       13\n```\n\n\n| [Impacted Files](https://codecov.io/gh/mkerins/mass/pull/29?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [filestore/models.py](https://codecov.io/gh/mkerins/mass/pull/29/diff?src=pr&el=tree#diff-ZmlsZXN0b3JlL21vZGVscy5weQ==) | `93.71% <100%> (+0.16%)` | :arrow_up: |\n| [filestore/views.py](https://codecov.io/gh/mkerins/mass/pull/29/diff?src=pr&el=tree#diff-ZmlsZXN0b3JlL3ZpZXdzLnB5) | `100% <100%> (ø)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/mkerins/mass/pull/29?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/mkerins/mass/pull/29?src=pr&el=footer). Last update [9547db2...a8d9891](https://codecov.io/gh/mkerins/mass/pull/29?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}