{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/192878532","pull_request_review_id":125740383,"id":192878532,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mjg3ODUzMg==","diff_hunk":"@@ -36,6 +38,16 @@ class BottomNavigationBarItem {\n   /// [IconTheme] size and color.\n   final Widget icon;\n \n+  /// An alternative icon displayed when this item is not selected in a material\n+  /// fixed bottom navigation bar.\n+  ///\n+  /// To ensure that bottom navigation items without a title are accessible,\n+  /// use a filled version of an icon as [icon] and a stroked version as\n+  /// [inactiveIcon].\n+  ///\n+  /// Defaults to [icon].\n+  final Widget inactiveIcon;","path":"packages/flutter/lib/src/widgets/bottom_navigation_bar_item.dart","position":24,"original_position":24,"commit_id":"30842345f73581cf6785d3e172e43168320b1f62","original_commit_id":"30842345f73581cf6785d3e172e43168320b1f62","user":{"login":"goderbauer","id":1227763,"node_id":"MDQ6VXNlcjEyMjc3NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1227763?v=4","gravatar_id":"","url":"https://api.github.com/users/goderbauer","html_url":"https://github.com/goderbauer","followers_url":"https://api.github.com/users/goderbauer/followers","following_url":"https://api.github.com/users/goderbauer/following{/other_user}","gists_url":"https://api.github.com/users/goderbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/goderbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goderbauer/subscriptions","organizations_url":"https://api.github.com/users/goderbauer/orgs","repos_url":"https://api.github.com/users/goderbauer/repos","events_url":"https://api.github.com/users/goderbauer/events{/privacy}","received_events_url":"https://api.github.com/users/goderbauer/received_events","type":"User","site_admin":false},"body":"(this comment is not actionable)\r\nInteresting, I would have done it the other way around: icon specifies the icon that you'll see most of the time (tab is not selected) and then you have a special selectedIcon property for when the tab is selected. Obviously, your choice works as well and I and I have little arguments for one choice or the other...","created_at":"2018-06-04T20:59:08Z","updated_at":"2018-06-04T21:01:30Z","html_url":"https://github.com/flutter/flutter/pull/18125#discussion_r192878532","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/18125","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/192878532"},"html":{"href":"https://github.com/flutter/flutter/pull/18125#discussion_r192878532"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/18125"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/18125","id":192149590,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMTQ5NTkw","html_url":"https://github.com/flutter/flutter/pull/18125","diff_url":"https://github.com/flutter/flutter/pull/18125.diff","patch_url":"https://github.com/flutter/flutter/pull/18125.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/18125","number":18125,"state":"open","locked":false,"title":"Add inactiveIcon to BottomNavigationBarItem","user":{"login":"jonahwilliams","id":8975114,"node_id":"MDQ6VXNlcjg5NzUxMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8975114?v=4","gravatar_id":"","url":"https://api.github.com/users/jonahwilliams","html_url":"https://github.com/jonahwilliams","followers_url":"https://api.github.com/users/jonahwilliams/followers","following_url":"https://api.github.com/users/jonahwilliams/following{/other_user}","gists_url":"https://api.github.com/users/jonahwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/jonahwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonahwilliams/subscriptions","organizations_url":"https://api.github.com/users/jonahwilliams/orgs","repos_url":"https://api.github.com/users/jonahwilliams/repos","events_url":"https://api.github.com/users/jonahwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/jonahwilliams/received_events","type":"User","site_admin":false},"body":"\r\nThis allows users to specify a separate widget to be displayed if the navigation bar item isn't currently selected.  This is recommended for a11y if there is no provided text title.\r\n\r\nThere isn't a general purpose way we could reasonable default to stroked/unstroked widgets so this relies on users to either correctly specify paired widgets or always use a title.\r\n\r\n<img src=\"https://user-images.githubusercontent.com/8975114/40864818-401429d8-65aa-11e8-8a6e-05db4c5d3534.png\" width=\"300\">\r\n\r\nFixes https://github.com/flutter/flutter/issues/16574","created_at":"2018-06-01T21:43:41Z","updated_at":"2018-06-04T21:01:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"492d81e7f57040bdd815469dc0f0b4a3c330d4e2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":487496476,"node_id":"MDU6TGFiZWw0ODc0OTY0NzY=","url":"https://api.github.com/repos/flutter/flutter/labels/cla:%20yes","name":"cla: yes","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/18125/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/18125/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/18125/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/30842345f73581cf6785d3e172e43168320b1f62","head":{"label":"jonahwilliams:a11y_16574","ref":"a11y_16574","sha":"30842345f73581cf6785d3e172e43168320b1f62","user":{"login":"jonahwilliams","id":8975114,"node_id":"MDQ6VXNlcjg5NzUxMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8975114?v=4","gravatar_id":"","url":"https://api.github.com/users/jonahwilliams","html_url":"https://github.com/jonahwilliams","followers_url":"https://api.github.com/users/jonahwilliams/followers","following_url":"https://api.github.com/users/jonahwilliams/following{/other_user}","gists_url":"https://api.github.com/users/jonahwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/jonahwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonahwilliams/subscriptions","organizations_url":"https://api.github.com/users/jonahwilliams/orgs","repos_url":"https://api.github.com/users/jonahwilliams/repos","events_url":"https://api.github.com/users/jonahwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/jonahwilliams/received_events","type":"User","site_admin":false},"repo":{"id":123957473,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM5NTc0NzM=","name":"flutter","full_name":"jonahwilliams/flutter","owner":{"login":"jonahwilliams","id":8975114,"node_id":"MDQ6VXNlcjg5NzUxMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8975114?v=4","gravatar_id":"","url":"https://api.github.com/users/jonahwilliams","html_url":"https://github.com/jonahwilliams","followers_url":"https://api.github.com/users/jonahwilliams/followers","following_url":"https://api.github.com/users/jonahwilliams/following{/other_user}","gists_url":"https://api.github.com/users/jonahwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/jonahwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonahwilliams/subscriptions","organizations_url":"https://api.github.com/users/jonahwilliams/orgs","repos_url":"https://api.github.com/users/jonahwilliams/repos","events_url":"https://api.github.com/users/jonahwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/jonahwilliams/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonahwilliams/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":true,"url":"https://api.github.com/repos/jonahwilliams/flutter","forks_url":"https://api.github.com/repos/jonahwilliams/flutter/forks","keys_url":"https://api.github.com/repos/jonahwilliams/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonahwilliams/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonahwilliams/flutter/teams","hooks_url":"https://api.github.com/repos/jonahwilliams/flutter/hooks","issue_events_url":"https://api.github.com/repos/jonahwilliams/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/jonahwilliams/flutter/events","assignees_url":"https://api.github.com/repos/jonahwilliams/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/jonahwilliams/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/jonahwilliams/flutter/tags","blobs_url":"https://api.github.com/repos/jonahwilliams/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonahwilliams/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonahwilliams/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonahwilliams/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonahwilliams/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/jonahwilliams/flutter/languages","stargazers_url":"https://api.github.com/repos/jonahwilliams/flutter/stargazers","contributors_url":"https://api.github.com/repos/jonahwilliams/flutter/contributors","subscribers_url":"https://api.github.com/repos/jonahwilliams/flutter/subscribers","subscription_url":"https://api.github.com/repos/jonahwilliams/flutter/subscription","commits_url":"https://api.github.com/repos/jonahwilliams/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonahwilliams/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonahwilliams/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonahwilliams/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonahwilliams/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/jonahwilliams/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonahwilliams/flutter/merges","archive_url":"https://api.github.com/repos/jonahwilliams/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonahwilliams/flutter/downloads","issues_url":"https://api.github.com/repos/jonahwilliams/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/jonahwilliams/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/jonahwilliams/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/jonahwilliams/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonahwilliams/flutter/labels{/name}","releases_url":"https://api.github.com/repos/jonahwilliams/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/jonahwilliams/flutter/deployments","created_at":"2018-03-05T17:57:36Z","updated_at":"2018-03-26T16:03:34Z","pushed_at":"2018-06-02T02:06:04Z","git_url":"git://github.com/jonahwilliams/flutter.git","ssh_url":"git@github.com:jonahwilliams/flutter.git","clone_url":"https://github.com/jonahwilliams/flutter.git","svn_url":"https://github.com/jonahwilliams/flutter","homepage":"https://flutter.io","size":39439,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"529d25045393430742daf06517417a7687074dba","user":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"node_id":"MDEwOlJlcG9zaXRvcnkzMTc5MjgyNA==","name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2018-06-04T20:18:06Z","pushed_at":"2018-06-04T20:50:49Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":39268,"stargazers_count":25637,"watchers_count":25637,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2308,"mirror_url":null,"archived":false,"open_issues_count":3250,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2308,"open_issues":3250,"watchers":25637,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/18125"},"html":{"href":"https://github.com/flutter/flutter/pull/18125"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/18125"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/18125/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/18125/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/18125/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/30842345f73581cf6785d3e172e43168320b1f62"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"goderbauer"}}