{"action":"created","comment":{"url":"https://api.github.com/repos/bundler/bundler/pulls/comments/175066210","pull_request_review_id":104536417,"id":175066210,"diff_hunk":"@@ -28,6 +28,8 @@ Gem::Specification.new do |spec|\n       \"public gem pushes.\"\n   end\n \n+  # Specify which files should be added to the gem when it is released.\n+  # The `git ls-files -z` default will base this on all the files checked in to git.","path":"lib/bundler/templates/newgem/newgem.gemspec.tt","position":5,"original_position":5,"commit_id":"e76cd7f41c782f02d7bab7cfaf785e58bfb98690","original_commit_id":"e76cd7f41c782f02d7bab7cfaf785e58bfb98690","user":{"login":"colby-swandale","id":996377,"avatar_url":"https://avatars0.githubusercontent.com/u/996377?v=4","gravatar_id":"","url":"https://api.github.com/users/colby-swandale","html_url":"https://github.com/colby-swandale","followers_url":"https://api.github.com/users/colby-swandale/followers","following_url":"https://api.github.com/users/colby-swandale/following{/other_user}","gists_url":"https://api.github.com/users/colby-swandale/gists{/gist_id}","starred_url":"https://api.github.com/users/colby-swandale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colby-swandale/subscriptions","organizations_url":"https://api.github.com/users/colby-swandale/orgs","repos_url":"https://api.github.com/users/colby-swandale/repos","events_url":"https://api.github.com/users/colby-swandale/events{/privacy}","received_events_url":"https://api.github.com/users/colby-swandale/received_events","type":"User","site_admin":false},"body":"> The `git ls-files -z` default will base this on all the files checked in to git.\r\n\r\nThis doesn't read that well when i say it out loud. How about we change this to something like:\r\n\r\n```\r\nThe `git ls-files -z` loads the files in the RubyGem that have been added into git\r\n```\r\n\r\n?","created_at":"2018-03-16T11:51:09Z","updated_at":"2018-03-16T11:51:54Z","html_url":"https://github.com/bundler/bundler/pull/6346#discussion_r175066210","pull_request_url":"https://api.github.com/repos/bundler/bundler/pulls/6346","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/bundler/bundler/pulls/comments/175066210"},"html":{"href":"https://github.com/bundler/bundler/pull/6346#discussion_r175066210"},"pull_request":{"href":"https://api.github.com/repos/bundler/bundler/pulls/6346"}}},"pull_request":{"url":"https://api.github.com/repos/bundler/bundler/pulls/6346","id":175383317,"html_url":"https://github.com/bundler/bundler/pull/6346","diff_url":"https://github.com/bundler/bundler/pull/6346.diff","patch_url":"https://github.com/bundler/bundler/pull/6346.patch","issue_url":"https://api.github.com/repos/bundler/bundler/issues/6346","number":6346,"state":"open","locked":false,"title":"Explain spec files and output a link to bundler.io guides","user":{"login":"nesaulov","id":20617394,"avatar_url":"https://avatars3.githubusercontent.com/u/20617394?v=4","gravatar_id":"","url":"https://api.github.com/users/nesaulov","html_url":"https://github.com/nesaulov","followers_url":"https://api.github.com/users/nesaulov/followers","following_url":"https://api.github.com/users/nesaulov/following{/other_user}","gists_url":"https://api.github.com/users/nesaulov/gists{/gist_id}","starred_url":"https://api.github.com/users/nesaulov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nesaulov/subscriptions","organizations_url":"https://api.github.com/users/nesaulov/orgs","repos_url":"https://api.github.com/users/nesaulov/repos","events_url":"https://api.github.com/users/nesaulov/events{/privacy}","received_events_url":"https://api.github.com/users/nesaulov/received_events","type":"User","site_admin":false},"body":"Resolves #6246 \r\n\r\n### What was the end-user problem that led to this PR?\r\n\r\n1. There is no helpful comment about `spec.files` method in a new gem's gemspec.\r\n2. `$ bundle gem gem_name` is missing link to further reading about developing, testing and releasing the newly created gem.\r\n\r\n### What is your fix for the problem, implemented in this PR?\r\n\r\n1. Add a comment in the `newgem.gemspec.tt`\r\n2. Add a message after new gem generation with link to [bundler.io guides](https://bundler.io/guides/creating_gem.html)\r\n\r\nExample: \r\n```bash\r\n๛  ~/code/oss/tmp $  ../bundler/bin/bundle gem new_gem\r\nCreating gem 'new_gem'...\r\n      create  new_gem/Gemfile\r\n      create  new_gem/lib/new_gem.rb\r\n      create  new_gem/lib/new_gem/version.rb\r\n      create  new_gem/new_gem.gemspec\r\n      create  new_gem/Rakefile\r\n      create  new_gem/README.md\r\n      create  new_gem/bin/console\r\n      create  new_gem/bin/setup\r\n      create  new_gem/.gitignore\r\nInitializing git repo in /Users/nesaulov/code/oss/tmp/new_gem\r\nGem 'new_gem' was successfully created. For detailed information on further steps please visit https://bundler.io/guides/creating_gem.html\r\n๛  ~/code/oss/tmp $\r\n```","created_at":"2018-03-15T21:25:44Z","updated_at":"2018-03-16T11:51:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c1c04d42ee92fa04a4011cf0578ade84fbcb8fb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bundler/bundler/pulls/6346/commits","review_comments_url":"https://api.github.com/repos/bundler/bundler/pulls/6346/comments","review_comment_url":"https://api.github.com/repos/bundler/bundler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bundler/bundler/issues/6346/comments","statuses_url":"https://api.github.com/repos/bundler/bundler/statuses/e76cd7f41c782f02d7bab7cfaf785e58bfb98690","head":{"label":"nesaulov:explain-spec-files","ref":"explain-spec-files","sha":"e76cd7f41c782f02d7bab7cfaf785e58bfb98690","user":{"login":"nesaulov","id":20617394,"avatar_url":"https://avatars3.githubusercontent.com/u/20617394?v=4","gravatar_id":"","url":"https://api.github.com/users/nesaulov","html_url":"https://github.com/nesaulov","followers_url":"https://api.github.com/users/nesaulov/followers","following_url":"https://api.github.com/users/nesaulov/following{/other_user}","gists_url":"https://api.github.com/users/nesaulov/gists{/gist_id}","starred_url":"https://api.github.com/users/nesaulov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nesaulov/subscriptions","organizations_url":"https://api.github.com/users/nesaulov/orgs","repos_url":"https://api.github.com/users/nesaulov/repos","events_url":"https://api.github.com/users/nesaulov/events{/privacy}","received_events_url":"https://api.github.com/users/nesaulov/received_events","type":"User","site_admin":false},"repo":{"id":125257538,"name":"bundler","full_name":"nesaulov/bundler","owner":{"login":"nesaulov","id":20617394,"avatar_url":"https://avatars3.githubusercontent.com/u/20617394?v=4","gravatar_id":"","url":"https://api.github.com/users/nesaulov","html_url":"https://github.com/nesaulov","followers_url":"https://api.github.com/users/nesaulov/followers","following_url":"https://api.github.com/users/nesaulov/following{/other_user}","gists_url":"https://api.github.com/users/nesaulov/gists{/gist_id}","starred_url":"https://api.github.com/users/nesaulov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nesaulov/subscriptions","organizations_url":"https://api.github.com/users/nesaulov/orgs","repos_url":"https://api.github.com/users/nesaulov/repos","events_url":"https://api.github.com/users/nesaulov/events{/privacy}","received_events_url":"https://api.github.com/users/nesaulov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nesaulov/bundler","description":"Manage your Ruby application's gem dependencies","fork":true,"url":"https://api.github.com/repos/nesaulov/bundler","forks_url":"https://api.github.com/repos/nesaulov/bundler/forks","keys_url":"https://api.github.com/repos/nesaulov/bundler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nesaulov/bundler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nesaulov/bundler/teams","hooks_url":"https://api.github.com/repos/nesaulov/bundler/hooks","issue_events_url":"https://api.github.com/repos/nesaulov/bundler/issues/events{/number}","events_url":"https://api.github.com/repos/nesaulov/bundler/events","assignees_url":"https://api.github.com/repos/nesaulov/bundler/assignees{/user}","branches_url":"https://api.github.com/repos/nesaulov/bundler/branches{/branch}","tags_url":"https://api.github.com/repos/nesaulov/bundler/tags","blobs_url":"https://api.github.com/repos/nesaulov/bundler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nesaulov/bundler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nesaulov/bundler/git/refs{/sha}","trees_url":"https://api.github.com/repos/nesaulov/bundler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nesaulov/bundler/statuses/{sha}","languages_url":"https://api.github.com/repos/nesaulov/bundler/languages","stargazers_url":"https://api.github.com/repos/nesaulov/bundler/stargazers","contributors_url":"https://api.github.com/repos/nesaulov/bundler/contributors","subscribers_url":"https://api.github.com/repos/nesaulov/bundler/subscribers","subscription_url":"https://api.github.com/repos/nesaulov/bundler/subscription","commits_url":"https://api.github.com/repos/nesaulov/bundler/commits{/sha}","git_commits_url":"https://api.github.com/repos/nesaulov/bundler/git/commits{/sha}","comments_url":"https://api.github.com/repos/nesaulov/bundler/comments{/number}","issue_comment_url":"https://api.github.com/repos/nesaulov/bundler/issues/comments{/number}","contents_url":"https://api.github.com/repos/nesaulov/bundler/contents/{+path}","compare_url":"https://api.github.com/repos/nesaulov/bundler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nesaulov/bundler/merges","archive_url":"https://api.github.com/repos/nesaulov/bundler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nesaulov/bundler/downloads","issues_url":"https://api.github.com/repos/nesaulov/bundler/issues{/number}","pulls_url":"https://api.github.com/repos/nesaulov/bundler/pulls{/number}","milestones_url":"https://api.github.com/repos/nesaulov/bundler/milestones{/number}","notifications_url":"https://api.github.com/repos/nesaulov/bundler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nesaulov/bundler/labels{/name}","releases_url":"https://api.github.com/repos/nesaulov/bundler/releases{/id}","deployments_url":"https://api.github.com/repos/nesaulov/bundler/deployments","created_at":"2018-03-14T18:35:28Z","updated_at":"2018-03-14T18:35:34Z","pushed_at":"2018-03-15T22:11:13Z","git_url":"git://github.com/nesaulov/bundler.git","ssh_url":"git@github.com:nesaulov/bundler.git","clone_url":"https://github.com/nesaulov/bundler.git","svn_url":"https://github.com/nesaulov/bundler","homepage":"https://bundler.io","size":34127,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bundler:master","ref":"master","sha":"331ade5e654b4cb5cfcafff159593d2bb63d5b1b","user":{"login":"bundler","id":1137638,"avatar_url":"https://avatars0.githubusercontent.com/u/1137638?v=4","gravatar_id":"","url":"https://api.github.com/users/bundler","html_url":"https://github.com/bundler","followers_url":"https://api.github.com/users/bundler/followers","following_url":"https://api.github.com/users/bundler/following{/other_user}","gists_url":"https://api.github.com/users/bundler/gists{/gist_id}","starred_url":"https://api.github.com/users/bundler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bundler/subscriptions","organizations_url":"https://api.github.com/users/bundler/orgs","repos_url":"https://api.github.com/users/bundler/repos","events_url":"https://api.github.com/users/bundler/events{/privacy}","received_events_url":"https://api.github.com/users/bundler/received_events","type":"Organization","site_admin":false},"repo":{"id":488514,"name":"bundler","full_name":"bundler/bundler","owner":{"login":"bundler","id":1137638,"avatar_url":"https://avatars0.githubusercontent.com/u/1137638?v=4","gravatar_id":"","url":"https://api.github.com/users/bundler","html_url":"https://github.com/bundler","followers_url":"https://api.github.com/users/bundler/followers","following_url":"https://api.github.com/users/bundler/following{/other_user}","gists_url":"https://api.github.com/users/bundler/gists{/gist_id}","starred_url":"https://api.github.com/users/bundler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bundler/subscriptions","organizations_url":"https://api.github.com/users/bundler/orgs","repos_url":"https://api.github.com/users/bundler/repos","events_url":"https://api.github.com/users/bundler/events{/privacy}","received_events_url":"https://api.github.com/users/bundler/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bundler/bundler","description":"Manage your Ruby application's gem dependencies","fork":false,"url":"https://api.github.com/repos/bundler/bundler","forks_url":"https://api.github.com/repos/bundler/bundler/forks","keys_url":"https://api.github.com/repos/bundler/bundler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bundler/bundler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bundler/bundler/teams","hooks_url":"https://api.github.com/repos/bundler/bundler/hooks","issue_events_url":"https://api.github.com/repos/bundler/bundler/issues/events{/number}","events_url":"https://api.github.com/repos/bundler/bundler/events","assignees_url":"https://api.github.com/repos/bundler/bundler/assignees{/user}","branches_url":"https://api.github.com/repos/bundler/bundler/branches{/branch}","tags_url":"https://api.github.com/repos/bundler/bundler/tags","blobs_url":"https://api.github.com/repos/bundler/bundler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bundler/bundler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bundler/bundler/git/refs{/sha}","trees_url":"https://api.github.com/repos/bundler/bundler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bundler/bundler/statuses/{sha}","languages_url":"https://api.github.com/repos/bundler/bundler/languages","stargazers_url":"https://api.github.com/repos/bundler/bundler/stargazers","contributors_url":"https://api.github.com/repos/bundler/bundler/contributors","subscribers_url":"https://api.github.com/repos/bundler/bundler/subscribers","subscription_url":"https://api.github.com/repos/bundler/bundler/subscription","commits_url":"https://api.github.com/repos/bundler/bundler/commits{/sha}","git_commits_url":"https://api.github.com/repos/bundler/bundler/git/commits{/sha}","comments_url":"https://api.github.com/repos/bundler/bundler/comments{/number}","issue_comment_url":"https://api.github.com/repos/bundler/bundler/issues/comments{/number}","contents_url":"https://api.github.com/repos/bundler/bundler/contents/{+path}","compare_url":"https://api.github.com/repos/bundler/bundler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bundler/bundler/merges","archive_url":"https://api.github.com/repos/bundler/bundler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bundler/bundler/downloads","issues_url":"https://api.github.com/repos/bundler/bundler/issues{/number}","pulls_url":"https://api.github.com/repos/bundler/bundler/pulls{/number}","milestones_url":"https://api.github.com/repos/bundler/bundler/milestones{/number}","notifications_url":"https://api.github.com/repos/bundler/bundler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bundler/bundler/labels{/name}","releases_url":"https://api.github.com/repos/bundler/bundler/releases{/id}","deployments_url":"https://api.github.com/repos/bundler/bundler/deployments","created_at":"2010-01-26T00:46:38Z","updated_at":"2018-03-16T02:47:25Z","pushed_at":"2018-03-16T11:45:00Z","git_url":"git://github.com/bundler/bundler.git","ssh_url":"git@github.com:bundler/bundler.git","clone_url":"https://github.com/bundler/bundler.git","svn_url":"https://github.com/bundler/bundler","homepage":"https://bundler.io","size":34118,"stargazers_count":4131,"watchers_count":4131,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1890,"mirror_url":null,"archived":false,"open_issues_count":154,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1890,"open_issues":154,"watchers":4131,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bundler/bundler/pulls/6346"},"html":{"href":"https://github.com/bundler/bundler/pull/6346"},"issue":{"href":"https://api.github.com/repos/bundler/bundler/issues/6346"},"comments":{"href":"https://api.github.com/repos/bundler/bundler/issues/6346/comments"},"review_comments":{"href":"https://api.github.com/repos/bundler/bundler/pulls/6346/comments"},"review_comment":{"href":"https://api.github.com/repos/bundler/bundler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bundler/bundler/pulls/6346/commits"},"statuses":{"href":"https://api.github.com/repos/bundler/bundler/statuses/e76cd7f41c782f02d7bab7cfaf785e58bfb98690"}},"author_association":"NONE"}}
{"actor":{"display_login":"colby-swandale"}}