{"action":"created","comment":{"url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/comments/203615911","pull_request_review_id":138538945,"id":203615911,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzYxNTkxMQ==","diff_hunk":"@@ -0,0 +1,45 @@\n+/*\n+ * Copyright 2018 The Cartographer Authors\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+#ifndef CARTOGRAPHER_POSE_GRAPH_CONSTRAINT_RELATIVE_POSE_CONSTRAINT_2D_H_\n+#define CARTOGRAPHER_POSE_GRAPH_CONSTRAINT_RELATIVE_POSE_CONSTRAINT_2D_H_\n+\n+#include \"cartographer/pose_graph/constraint/constraint.h\"\n+#include \"cartographer/pose_graph/constraint/cost_function/relative_pose_cost_2d.h\"\n+\n+namespace cartographer {\n+namespace pose_graph {\n+\n+class RelativePoseConstraint2D : public Constraint {\n+ public:\n+  RelativePoseConstraint2D(const ConstraintId& id,\n+                           const proto::RelativePose2D& proto);\n+\n+  void AddToOptimizer(Nodes* nodes, ceres::Problem* problem) const final;\n+\n+ protected:\n+  proto::CostFunction ToCostFunctionProto() const final;\n+\n+ private:\n+  NodeId first_;\n+  NodeId second_;\n+  std::unique_ptr<RelativePoseCost2D> ceres_cost_;","path":"cartographer/pose_graph/constraint/relative_pose_constraint_2d.h","position":39,"original_position":39,"commit_id":"22599cae7208e02aa302a69634a951428117211b","original_commit_id":"22599cae7208e02aa302a69634a951428117211b","user":{"login":"pifon2a","id":32522095,"node_id":"MDQ6VXNlcjMyNTIyMDk1","avatar_url":"https://avatars2.githubusercontent.com/u/32522095?v=4","gravatar_id":"","url":"https://api.github.com/users/pifon2a","html_url":"https://github.com/pifon2a","followers_url":"https://api.github.com/users/pifon2a/followers","following_url":"https://api.github.com/users/pifon2a/following{/other_user}","gists_url":"https://api.github.com/users/pifon2a/gists{/gist_id}","starred_url":"https://api.github.com/users/pifon2a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pifon2a/subscriptions","organizations_url":"https://api.github.com/users/pifon2a/orgs","repos_url":"https://api.github.com/users/pifon2a/repos","events_url":"https://api.github.com/users/pifon2a/events{/privacy}","received_events_url":"https://api.github.com/users/pifon2a/received_events","type":"User","site_admin":false},"body":"It does not :). Done.","created_at":"2018-07-19T06:40:37Z","updated_at":"2018-07-19T06:40:38Z","html_url":"https://github.com/googlecartographer/cartographer/pull/1297#discussion_r203615911","pull_request_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1297","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/comments/203615911"},"html":{"href":"https://github.com/googlecartographer/cartographer/pull/1297#discussion_r203615911"},"pull_request":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1297"}},"in_reply_to_id":203407299},"pull_request":{"url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1297","id":202274891,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMjc0ODkx","html_url":"https://github.com/googlecartographer/cartographer/pull/1297","diff_url":"https://github.com/googlecartographer/cartographer/pull/1297.diff","patch_url":"https://github.com/googlecartographer/cartographer/pull/1297.patch","issue_url":"https://api.github.com/repos/googlecartographer/cartographer/issues/1297","number":1297,"state":"open","locked":false,"title":"[GenericPoseGraph] Add RelativePoseConstraint2D.","user":{"login":"pifon2a","id":32522095,"node_id":"MDQ6VXNlcjMyNTIyMDk1","avatar_url":"https://avatars2.githubusercontent.com/u/32522095?v=4","gravatar_id":"","url":"https://api.github.com/users/pifon2a","html_url":"https://github.com/pifon2a","followers_url":"https://api.github.com/users/pifon2a/followers","following_url":"https://api.github.com/users/pifon2a/following{/other_user}","gists_url":"https://api.github.com/users/pifon2a/gists{/gist_id}","starred_url":"https://api.github.com/users/pifon2a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pifon2a/subscriptions","organizations_url":"https://api.github.com/users/pifon2a/orgs","repos_url":"https://api.github.com/users/pifon2a/repos","events_url":"https://api.github.com/users/pifon2a/events{/privacy}","received_events_url":"https://api.github.com/users/pifon2a/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-18T14:35:25Z","updated_at":"2018-07-19T06:40:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bba8fe626202f02e5828ffd2f4dffee67a4722f3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":418020229,"node_id":"MDU6TGFiZWw0MTgwMjAyMjk=","url":"https://api.github.com/repos/googlecartographer/cartographer/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1297/commits","review_comments_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1297/comments","review_comment_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googlecartographer/cartographer/issues/1297/comments","statuses_url":"https://api.github.com/repos/googlecartographer/cartographer/statuses/22599cae7208e02aa302a69634a951428117211b","head":{"label":"pifon2a:relelel2","ref":"relelel2","sha":"22599cae7208e02aa302a69634a951428117211b","user":{"login":"pifon2a","id":32522095,"node_id":"MDQ6VXNlcjMyNTIyMDk1","avatar_url":"https://avatars2.githubusercontent.com/u/32522095?v=4","gravatar_id":"","url":"https://api.github.com/users/pifon2a","html_url":"https://github.com/pifon2a","followers_url":"https://api.github.com/users/pifon2a/followers","following_url":"https://api.github.com/users/pifon2a/following{/other_user}","gists_url":"https://api.github.com/users/pifon2a/gists{/gist_id}","starred_url":"https://api.github.com/users/pifon2a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pifon2a/subscriptions","organizations_url":"https://api.github.com/users/pifon2a/orgs","repos_url":"https://api.github.com/users/pifon2a/repos","events_url":"https://api.github.com/users/pifon2a/events{/privacy}","received_events_url":"https://api.github.com/users/pifon2a/received_events","type":"User","site_admin":false},"repo":{"id":108394000,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgzOTQwMDA=","name":"cartographer","full_name":"pifon2a/cartographer","owner":{"login":"pifon2a","id":32522095,"node_id":"MDQ6VXNlcjMyNTIyMDk1","avatar_url":"https://avatars2.githubusercontent.com/u/32522095?v=4","gravatar_id":"","url":"https://api.github.com/users/pifon2a","html_url":"https://github.com/pifon2a","followers_url":"https://api.github.com/users/pifon2a/followers","following_url":"https://api.github.com/users/pifon2a/following{/other_user}","gists_url":"https://api.github.com/users/pifon2a/gists{/gist_id}","starred_url":"https://api.github.com/users/pifon2a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pifon2a/subscriptions","organizations_url":"https://api.github.com/users/pifon2a/orgs","repos_url":"https://api.github.com/users/pifon2a/repos","events_url":"https://api.github.com/users/pifon2a/events{/privacy}","received_events_url":"https://api.github.com/users/pifon2a/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pifon2a/cartographer","description":"Cartographer is a system that provides real-time simultaneous localization and mapping (SLAM) in 2D and 3D across multiple platforms and sensor configurations.","fork":true,"url":"https://api.github.com/repos/pifon2a/cartographer","forks_url":"https://api.github.com/repos/pifon2a/cartographer/forks","keys_url":"https://api.github.com/repos/pifon2a/cartographer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pifon2a/cartographer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pifon2a/cartographer/teams","hooks_url":"https://api.github.com/repos/pifon2a/cartographer/hooks","issue_events_url":"https://api.github.com/repos/pifon2a/cartographer/issues/events{/number}","events_url":"https://api.github.com/repos/pifon2a/cartographer/events","assignees_url":"https://api.github.com/repos/pifon2a/cartographer/assignees{/user}","branches_url":"https://api.github.com/repos/pifon2a/cartographer/branches{/branch}","tags_url":"https://api.github.com/repos/pifon2a/cartographer/tags","blobs_url":"https://api.github.com/repos/pifon2a/cartographer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pifon2a/cartographer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pifon2a/cartographer/git/refs{/sha}","trees_url":"https://api.github.com/repos/pifon2a/cartographer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pifon2a/cartographer/statuses/{sha}","languages_url":"https://api.github.com/repos/pifon2a/cartographer/languages","stargazers_url":"https://api.github.com/repos/pifon2a/cartographer/stargazers","contributors_url":"https://api.github.com/repos/pifon2a/cartographer/contributors","subscribers_url":"https://api.github.com/repos/pifon2a/cartographer/subscribers","subscription_url":"https://api.github.com/repos/pifon2a/cartographer/subscription","commits_url":"https://api.github.com/repos/pifon2a/cartographer/commits{/sha}","git_commits_url":"https://api.github.com/repos/pifon2a/cartographer/git/commits{/sha}","comments_url":"https://api.github.com/repos/pifon2a/cartographer/comments{/number}","issue_comment_url":"https://api.github.com/repos/pifon2a/cartographer/issues/comments{/number}","contents_url":"https://api.github.com/repos/pifon2a/cartographer/contents/{+path}","compare_url":"https://api.github.com/repos/pifon2a/cartographer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pifon2a/cartographer/merges","archive_url":"https://api.github.com/repos/pifon2a/cartographer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pifon2a/cartographer/downloads","issues_url":"https://api.github.com/repos/pifon2a/cartographer/issues{/number}","pulls_url":"https://api.github.com/repos/pifon2a/cartographer/pulls{/number}","milestones_url":"https://api.github.com/repos/pifon2a/cartographer/milestones{/number}","notifications_url":"https://api.github.com/repos/pifon2a/cartographer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pifon2a/cartographer/labels{/name}","releases_url":"https://api.github.com/repos/pifon2a/cartographer/releases{/id}","deployments_url":"https://api.github.com/repos/pifon2a/cartographer/deployments","created_at":"2017-10-26T09:59:05Z","updated_at":"2018-05-30T09:44:12Z","pushed_at":"2018-07-18T14:34:52Z","git_url":"git://github.com/pifon2a/cartographer.git","ssh_url":"git@github.com:pifon2a/cartographer.git","clone_url":"https://github.com/pifon2a/cartographer.git","svn_url":"https://github.com/pifon2a/cartographer","homepage":"","size":4879,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googlecartographer:master","ref":"master","sha":"0ab591aa013edffb9b25ac4a7127c67e3d129621","user":{"login":"googlecartographer","id":20636162,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjM2MTYy","avatar_url":"https://avatars3.githubusercontent.com/u/20636162?v=4","gravatar_id":"","url":"https://api.github.com/users/googlecartographer","html_url":"https://github.com/googlecartographer","followers_url":"https://api.github.com/users/googlecartographer/followers","following_url":"https://api.github.com/users/googlecartographer/following{/other_user}","gists_url":"https://api.github.com/users/googlecartographer/gists{/gist_id}","starred_url":"https://api.github.com/users/googlecartographer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlecartographer/subscriptions","organizations_url":"https://api.github.com/users/googlecartographer/orgs","repos_url":"https://api.github.com/users/googlecartographer/repos","events_url":"https://api.github.com/users/googlecartographer/events{/privacy}","received_events_url":"https://api.github.com/users/googlecartographer/received_events","type":"Organization","site_admin":false},"repo":{"id":64732358,"node_id":"MDEwOlJlcG9zaXRvcnk2NDczMjM1OA==","name":"cartographer","full_name":"googlecartographer/cartographer","owner":{"login":"googlecartographer","id":20636162,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjM2MTYy","avatar_url":"https://avatars3.githubusercontent.com/u/20636162?v=4","gravatar_id":"","url":"https://api.github.com/users/googlecartographer","html_url":"https://github.com/googlecartographer","followers_url":"https://api.github.com/users/googlecartographer/followers","following_url":"https://api.github.com/users/googlecartographer/following{/other_user}","gists_url":"https://api.github.com/users/googlecartographer/gists{/gist_id}","starred_url":"https://api.github.com/users/googlecartographer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlecartographer/subscriptions","organizations_url":"https://api.github.com/users/googlecartographer/orgs","repos_url":"https://api.github.com/users/googlecartographer/repos","events_url":"https://api.github.com/users/googlecartographer/events{/privacy}","received_events_url":"https://api.github.com/users/googlecartographer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googlecartographer/cartographer","description":"Cartographer is a system that provides real-time simultaneous localization and mapping (SLAM) in 2D and 3D across multiple platforms and sensor configurations.","fork":false,"url":"https://api.github.com/repos/googlecartographer/cartographer","forks_url":"https://api.github.com/repos/googlecartographer/cartographer/forks","keys_url":"https://api.github.com/repos/googlecartographer/cartographer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlecartographer/cartographer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlecartographer/cartographer/teams","hooks_url":"https://api.github.com/repos/googlecartographer/cartographer/hooks","issue_events_url":"https://api.github.com/repos/googlecartographer/cartographer/issues/events{/number}","events_url":"https://api.github.com/repos/googlecartographer/cartographer/events","assignees_url":"https://api.github.com/repos/googlecartographer/cartographer/assignees{/user}","branches_url":"https://api.github.com/repos/googlecartographer/cartographer/branches{/branch}","tags_url":"https://api.github.com/repos/googlecartographer/cartographer/tags","blobs_url":"https://api.github.com/repos/googlecartographer/cartographer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlecartographer/cartographer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlecartographer/cartographer/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlecartographer/cartographer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlecartographer/cartographer/statuses/{sha}","languages_url":"https://api.github.com/repos/googlecartographer/cartographer/languages","stargazers_url":"https://api.github.com/repos/googlecartographer/cartographer/stargazers","contributors_url":"https://api.github.com/repos/googlecartographer/cartographer/contributors","subscribers_url":"https://api.github.com/repos/googlecartographer/cartographer/subscribers","subscription_url":"https://api.github.com/repos/googlecartographer/cartographer/subscription","commits_url":"https://api.github.com/repos/googlecartographer/cartographer/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlecartographer/cartographer/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlecartographer/cartographer/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlecartographer/cartographer/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlecartographer/cartographer/contents/{+path}","compare_url":"https://api.github.com/repos/googlecartographer/cartographer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlecartographer/cartographer/merges","archive_url":"https://api.github.com/repos/googlecartographer/cartographer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlecartographer/cartographer/downloads","issues_url":"https://api.github.com/repos/googlecartographer/cartographer/issues{/number}","pulls_url":"https://api.github.com/repos/googlecartographer/cartographer/pulls{/number}","milestones_url":"https://api.github.com/repos/googlecartographer/cartographer/milestones{/number}","notifications_url":"https://api.github.com/repos/googlecartographer/cartographer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlecartographer/cartographer/labels{/name}","releases_url":"https://api.github.com/repos/googlecartographer/cartographer/releases{/id}","deployments_url":"https://api.github.com/repos/googlecartographer/cartographer/deployments","created_at":"2016-08-02T06:55:43Z","updated_at":"2018-07-18T15:08:04Z","pushed_at":"2018-07-18T15:08:01Z","git_url":"git://github.com/googlecartographer/cartographer.git","ssh_url":"git@github.com:googlecartographer/cartographer.git","clone_url":"https://github.com/googlecartographer/cartographer.git","svn_url":"https://github.com/googlecartographer/cartographer","homepage":"","size":4860,"stargazers_count":3532,"watchers_count":3532,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1157,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1157,"open_issues":57,"watchers":3532,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1297"},"html":{"href":"https://github.com/googlecartographer/cartographer/pull/1297"},"issue":{"href":"https://api.github.com/repos/googlecartographer/cartographer/issues/1297"},"comments":{"href":"https://api.github.com/repos/googlecartographer/cartographer/issues/1297/comments"},"review_comments":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1297/comments"},"review_comment":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googlecartographer/cartographer/pulls/1297/commits"},"statuses":{"href":"https://api.github.com/repos/googlecartographer/cartographer/statuses/22599cae7208e02aa302a69634a951428117211b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pifon2a"}}