{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/169832554","pull_request_review_id":98423357,"id":169832554,"diff_hunk":"@@ -0,0 +1,168 @@\n+import collections\n+import itertools\n+import numbers\n+import operator\n+import random\n+import string\n+import sys\n+\n+import numpy as np\n+import pytest\n+\n+\n+from pandas.core.dtypes.base import ExtensionDtype\n+from pandas.core.arrays import ExtensionArray\n+\n+from . import base\n+\n+pytestmark = pytest.mark.skipif(sys.version_info[0] == 2,\n+                                reason=\"Py2 doesn't have a UserDict\")\n+\n+\n+class JSONDtype(ExtensionDtype):\n+    type = collections.Mapping\n+    name = 'json'\n+\n+    @classmethod\n+    def construct_from_string(cls, string):\n+        if string == cls.name:\n+            return cls()\n+        else:\n+            raise TypeError(\"Cannot construct a '{}' from \"\n+                            \"'{}'\".format(cls, string))\n+\n+\n+class JSONArray(ExtensionArray):\n+    dtype = JSONDtype()\n+\n+    def __init__(self, values):\n+        for val in values:\n+            if not isinstance(val, self.dtype.type):\n+                raise TypeError\n+        self.data = values\n+\n+    def __getitem__(self, item):\n+        if isinstance(item, numbers.Integral):\n+            return self.data[item]\n+        elif isinstance(item, np.ndarray) and item.dtype == 'bool':\n+            return type(self)([x for x, m in zip(self, item) if m])\n+        else:\n+            return type(self)(self.data[item])\n+\n+    def __setitem__(self, key, value):\n+        if isinstance(key, numbers.Integral):\n+            self.data[key] = value\n+        else:\n+            if not isinstance(value, (type(self),\n+                                      collections.Sequence)):\n+                # broadcast value","path":"pandas/tests/extension/test_json.py","position":58,"original_position":58,"commit_id":"79d43b1aafb3e0ec67bbf0a5c9d6d6312a76d14b","original_commit_id":"79d43b1aafb3e0ec67bbf0a5c9d6d6312a76d14b","user":{"login":"jreback","id":953992,"avatar_url":"https://avatars2.githubusercontent.com/u/953992?v=4","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"body":"this is a crazy test.","created_at":"2018-02-22T01:33:22Z","updated_at":"2018-02-22T01:33:48Z","html_url":"https://github.com/pandas-dev/pandas/pull/19520#discussion_r169832554","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/19520","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/169832554"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/19520#discussion_r169832554"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/19520"}}},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/19520","id":166910288,"html_url":"https://github.com/pandas-dev/pandas/pull/19520","diff_url":"https://github.com/pandas-dev/pandas/pull/19520.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/19520.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/19520","number":19520,"state":"open","locked":false,"title":"ENH: Allow storing ExtensionArrays in containers","user":{"login":"TomAugspurger","id":1312546,"avatar_url":"https://avatars3.githubusercontent.com/u/1312546?v=4","gravatar_id":"","url":"https://api.github.com/users/TomAugspurger","html_url":"https://github.com/TomAugspurger","followers_url":"https://api.github.com/users/TomAugspurger/followers","following_url":"https://api.github.com/users/TomAugspurger/following{/other_user}","gists_url":"https://api.github.com/users/TomAugspurger/gists{/gist_id}","starred_url":"https://api.github.com/users/TomAugspurger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomAugspurger/subscriptions","organizations_url":"https://api.github.com/users/TomAugspurger/orgs","repos_url":"https://api.github.com/users/TomAugspurger/repos","events_url":"https://api.github.com/users/TomAugspurger/events{/privacy}","received_events_url":"https://api.github.com/users/TomAugspurger/received_events","type":"User","site_admin":false},"body":"Followup number 1 to #19268 \r\n\r\nThis adds changes to frame, series, dtypes, etc. (all the places other that `core/internals.py`) to support 3rd party extension arrays.\r\n\r\nThese changes were developed to support IntervalArrays (https://github.com/TomAugspurger/pandas/compare/pandas-array-upstream+fu1...TomAugspurger:pandas-array-upstream+fu1+interval separate PR) and https://github.com/continuumio/pandas-ip (external).\r\n\r\nAlso closes https://github.com/pandas-dev/pandas/issues/19585","created_at":"2018-02-02T21:43:26Z","updated_at":"2018-02-22T01:33:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"774595caeaf9e28d5041c07393f9b18f2efcc171","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":31404521,"url":"https://api.github.com/repos/pandas-dev/pandas/labels/Dtypes","name":"Dtypes","color":"e102d8","default":false},{"id":76812,"url":"https://api.github.com/repos/pandas-dev/pandas/labels/Enhancement","name":"Enhancement","color":"4E9A06","default":false},{"id":49094459,"url":"https://api.github.com/repos/pandas-dev/pandas/labels/Internals","name":"Internals","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/19520/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/19520/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/19520/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/79d43b1aafb3e0ec67bbf0a5c9d6d6312a76d14b","head":{"label":"TomAugspurger:pandas-array-upstream+fu1","ref":"pandas-array-upstream+fu1","sha":"79d43b1aafb3e0ec67bbf0a5c9d6d6312a76d14b","user":{"login":"TomAugspurger","id":1312546,"avatar_url":"https://avatars3.githubusercontent.com/u/1312546?v=4","gravatar_id":"","url":"https://api.github.com/users/TomAugspurger","html_url":"https://github.com/TomAugspurger","followers_url":"https://api.github.com/users/TomAugspurger/followers","following_url":"https://api.github.com/users/TomAugspurger/following{/other_user}","gists_url":"https://api.github.com/users/TomAugspurger/gists{/gist_id}","starred_url":"https://api.github.com/users/TomAugspurger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomAugspurger/subscriptions","organizations_url":"https://api.github.com/users/TomAugspurger/orgs","repos_url":"https://api.github.com/users/TomAugspurger/repos","events_url":"https://api.github.com/users/TomAugspurger/events{/privacy}","received_events_url":"https://api.github.com/users/TomAugspurger/received_events","type":"User","site_admin":false},"repo":{"id":9450481,"name":"pandas","full_name":"TomAugspurger/pandas","owner":{"login":"TomAugspurger","id":1312546,"avatar_url":"https://avatars3.githubusercontent.com/u/1312546?v=4","gravatar_id":"","url":"https://api.github.com/users/TomAugspurger","html_url":"https://github.com/TomAugspurger","followers_url":"https://api.github.com/users/TomAugspurger/followers","following_url":"https://api.github.com/users/TomAugspurger/following{/other_user}","gists_url":"https://api.github.com/users/TomAugspurger/gists{/gist_id}","starred_url":"https://api.github.com/users/TomAugspurger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomAugspurger/subscriptions","organizations_url":"https://api.github.com/users/TomAugspurger/orgs","repos_url":"https://api.github.com/users/TomAugspurger/repos","events_url":"https://api.github.com/users/TomAugspurger/events{/privacy}","received_events_url":"https://api.github.com/users/TomAugspurger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TomAugspurger/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/TomAugspurger/pandas","forks_url":"https://api.github.com/repos/TomAugspurger/pandas/forks","keys_url":"https://api.github.com/repos/TomAugspurger/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TomAugspurger/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TomAugspurger/pandas/teams","hooks_url":"https://api.github.com/repos/TomAugspurger/pandas/hooks","issue_events_url":"https://api.github.com/repos/TomAugspurger/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/TomAugspurger/pandas/events","assignees_url":"https://api.github.com/repos/TomAugspurger/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/TomAugspurger/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/TomAugspurger/pandas/tags","blobs_url":"https://api.github.com/repos/TomAugspurger/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TomAugspurger/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TomAugspurger/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/TomAugspurger/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TomAugspurger/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/TomAugspurger/pandas/languages","stargazers_url":"https://api.github.com/repos/TomAugspurger/pandas/stargazers","contributors_url":"https://api.github.com/repos/TomAugspurger/pandas/contributors","subscribers_url":"https://api.github.com/repos/TomAugspurger/pandas/subscribers","subscription_url":"https://api.github.com/repos/TomAugspurger/pandas/subscription","commits_url":"https://api.github.com/repos/TomAugspurger/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/TomAugspurger/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/TomAugspurger/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/TomAugspurger/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/TomAugspurger/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/TomAugspurger/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TomAugspurger/pandas/merges","archive_url":"https://api.github.com/repos/TomAugspurger/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TomAugspurger/pandas/downloads","issues_url":"https://api.github.com/repos/TomAugspurger/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/TomAugspurger/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/TomAugspurger/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/TomAugspurger/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TomAugspurger/pandas/labels{/name}","releases_url":"https://api.github.com/repos/TomAugspurger/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/TomAugspurger/pandas/deployments","created_at":"2013-04-15T14:23:40Z","updated_at":"2017-04-20T12:53:33Z","pushed_at":"2018-02-21T20:26:08Z","git_url":"git://github.com/TomAugspurger/pandas.git","ssh_url":"git@github.com:TomAugspurger/pandas.git","clone_url":"https://github.com/TomAugspurger/pandas.git","svn_url":"https://github.com/TomAugspurger/pandas","homepage":"http://pandas.pydata.org","size":118987,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"9df5ab781f903ce00407630aa9db661e3f739bcf","user":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pandas-dev/pandas","owner":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2018-02-22T01:14:19Z","pushed_at":"2018-02-22T01:05:38Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"http://pandas.pydata.org","size":116903,"stargazers_count":12977,"watchers_count":12977,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5030,"mirror_url":null,"archived":false,"open_issues_count":2368,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":5030,"open_issues":2368,"watchers":12977,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/19520"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/19520"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/19520"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/19520/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/19520/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/19520/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/79d43b1aafb3e0ec67bbf0a5c9d6d6312a76d14b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jreback"}}