{"action":"created","comment":{"url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/comments/214393710","pull_request_review_id":151447756,"id":214393710,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDM5MzcxMA==","diff_hunk":"@@ -0,0 +1,46 @@\n+package context","path":"client/context/client_manager.go","position":1,"original_position":1,"commit_id":"8b359413acb162417e64e84b5db28890db461d18","original_commit_id":"8b359413acb162417e64e84b5db28890db461d18","user":{"login":"HaoyangLiu","id":2945006,"node_id":"MDQ6VXNlcjI5NDUwMDY=","avatar_url":"https://avatars0.githubusercontent.com/u/2945006?v=4","gravatar_id":"","url":"https://api.github.com/users/HaoyangLiu","html_url":"https://github.com/HaoyangLiu","followers_url":"https://api.github.com/users/HaoyangLiu/followers","following_url":"https://api.github.com/users/HaoyangLiu/following{/other_user}","gists_url":"https://api.github.com/users/HaoyangLiu/gists{/gist_id}","starred_url":"https://api.github.com/users/HaoyangLiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaoyangLiu/subscriptions","organizations_url":"https://api.github.com/users/HaoyangLiu/orgs","repos_url":"https://api.github.com/users/HaoyangLiu/repos","events_url":"https://api.github.com/users/HaoyangLiu/events{/privacy}","received_events_url":"https://api.github.com/users/HaoyangLiu/received_events","type":"User","site_admin":false},"body":"The round-robin load balancing is indeedly simple. But it does contribute to TPS, please refer to the my test [report](https://github.com/HaoyangLiu/cosmos-sdk/blob/haoyang/lcd-test/docs/light/Cosmos-LCD-Test-Report.md). I think a load balancing module is necessary. Maybe currently we can just remove this module. But in long run, we have to add load balancing. How do you think about this?","created_at":"2018-08-31T15:36:40Z","updated_at":"2018-08-31T15:36:40Z","html_url":"https://github.com/cosmos/cosmos-sdk/pull/2199#discussion_r214393710","pull_request_url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2199","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/comments/214393710"},"html":{"href":"https://github.com/cosmos/cosmos-sdk/pull/2199#discussion_r214393710"},"pull_request":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2199"}},"in_reply_to_id":214370337},"pull_request":{"url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2199","id":212297150,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMjk3MTUw","html_url":"https://github.com/cosmos/cosmos-sdk/pull/2199","diff_url":"https://github.com/cosmos/cosmos-sdk/pull/2199.diff","patch_url":"https://github.com/cosmos/cosmos-sdk/pull/2199.patch","issue_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2199","number":2199,"state":"open","locked":false,"title":"R4R: Split LCD implementation PR, part two","user":{"login":"HaoyangLiu","id":2945006,"node_id":"MDQ6VXNlcjI5NDUwMDY=","avatar_url":"https://avatars0.githubusercontent.com/u/2945006?v=4","gravatar_id":"","url":"https://api.github.com/users/HaoyangLiu","html_url":"https://github.com/HaoyangLiu","followers_url":"https://api.github.com/users/HaoyangLiu/followers","following_url":"https://api.github.com/users/HaoyangLiu/following{/other_user}","gists_url":"https://api.github.com/users/HaoyangLiu/gists{/gist_id}","starred_url":"https://api.github.com/users/HaoyangLiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaoyangLiu/subscriptions","organizations_url":"https://api.github.com/users/HaoyangLiu/orgs","repos_url":"https://api.github.com/users/HaoyangLiu/repos","events_url":"https://api.github.com/users/HaoyangLiu/events{/privacy}","received_events_url":"https://api.github.com/users/HaoyangLiu/received_events","type":"User","site_admin":false},"body":"* Add client manager to do load balancing\r\n* Add swagger-ui for these modules: bank,transaction\r\n\r\nProceed from:\r\nhttps://github.com/cosmos/cosmos-sdk/pull/2118\r\nhttps://github.com/cosmos/cosmos-sdk/pull/2147\r\nhttps://github.com/cosmos/cosmos-sdk/pull/2177\r\n\r\nCloses #525 and #1020 and #2179","created_at":"2018-08-31T07:29:24Z","updated_at":"2018-08-31T15:36:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3568e05502156f377a48dbd7c5e5e4338891f63","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ebuchman","id":2300911,"node_id":"MDQ6VXNlcjIzMDA5MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/2300911?v=4","gravatar_id":"","url":"https://api.github.com/users/ebuchman","html_url":"https://github.com/ebuchman","followers_url":"https://api.github.com/users/ebuchman/followers","following_url":"https://api.github.com/users/ebuchman/following{/other_user}","gists_url":"https://api.github.com/users/ebuchman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebuchman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebuchman/subscriptions","organizations_url":"https://api.github.com/users/ebuchman/orgs","repos_url":"https://api.github.com/users/ebuchman/repos","events_url":"https://api.github.com/users/ebuchman/events{/privacy}","received_events_url":"https://api.github.com/users/ebuchman/received_events","type":"User","site_admin":false},{"login":"faboweb","id":5869273,"node_id":"MDQ6VXNlcjU4NjkyNzM=","avatar_url":"https://avatars1.githubusercontent.com/u/5869273?v=4","gravatar_id":"","url":"https://api.github.com/users/faboweb","html_url":"https://github.com/faboweb","followers_url":"https://api.github.com/users/faboweb/followers","following_url":"https://api.github.com/users/faboweb/following{/other_user}","gists_url":"https://api.github.com/users/faboweb/gists{/gist_id}","starred_url":"https://api.github.com/users/faboweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faboweb/subscriptions","organizations_url":"https://api.github.com/users/faboweb/orgs","repos_url":"https://api.github.com/users/faboweb/repos","events_url":"https://api.github.com/users/faboweb/events{/privacy}","received_events_url":"https://api.github.com/users/faboweb/received_events","type":"User","site_admin":false},{"login":"rigelrozanski","id":20132176,"node_id":"MDQ6VXNlcjIwMTMyMTc2","avatar_url":"https://avatars1.githubusercontent.com/u/20132176?v=4","gravatar_id":"","url":"https://api.github.com/users/rigelrozanski","html_url":"https://github.com/rigelrozanski","followers_url":"https://api.github.com/users/rigelrozanski/followers","following_url":"https://api.github.com/users/rigelrozanski/following{/other_user}","gists_url":"https://api.github.com/users/rigelrozanski/gists{/gist_id}","starred_url":"https://api.github.com/users/rigelrozanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigelrozanski/subscriptions","organizations_url":"https://api.github.com/users/rigelrozanski/orgs","repos_url":"https://api.github.com/users/rigelrozanski/repos","events_url":"https://api.github.com/users/rigelrozanski/events{/privacy}","received_events_url":"https://api.github.com/users/rigelrozanski/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2199/commits","review_comments_url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2199/comments","review_comment_url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2199/comments","statuses_url":"https://api.github.com/repos/cosmos/cosmos-sdk/statuses/8b359413acb162417e64e84b5db28890db461d18","head":{"label":"irisnet:bianjie/lcd-lite-server-swagger","ref":"bianjie/lcd-lite-server-swagger","sha":"8b359413acb162417e64e84b5db28890db461d18","user":{"login":"irisnet","id":33032395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMDMyMzk1","avatar_url":"https://avatars0.githubusercontent.com/u/33032395?v=4","gravatar_id":"","url":"https://api.github.com/users/irisnet","html_url":"https://github.com/irisnet","followers_url":"https://api.github.com/users/irisnet/followers","following_url":"https://api.github.com/users/irisnet/following{/other_user}","gists_url":"https://api.github.com/users/irisnet/gists{/gist_id}","starred_url":"https://api.github.com/users/irisnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irisnet/subscriptions","organizations_url":"https://api.github.com/users/irisnet/orgs","repos_url":"https://api.github.com/users/irisnet/repos","events_url":"https://api.github.com/users/irisnet/events{/privacy}","received_events_url":"https://api.github.com/users/irisnet/received_events","type":"Organization","site_admin":false},"repo":{"id":134528325,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ1MjgzMjU=","name":"cosmos-sdk","full_name":"irisnet/cosmos-sdk","owner":{"login":"irisnet","id":33032395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMDMyMzk1","avatar_url":"https://avatars0.githubusercontent.com/u/33032395?v=4","gravatar_id":"","url":"https://api.github.com/users/irisnet","html_url":"https://github.com/irisnet","followers_url":"https://api.github.com/users/irisnet/followers","following_url":"https://api.github.com/users/irisnet/following{/other_user}","gists_url":"https://api.github.com/users/irisnet/gists{/gist_id}","starred_url":"https://api.github.com/users/irisnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irisnet/subscriptions","organizations_url":"https://api.github.com/users/irisnet/orgs","repos_url":"https://api.github.com/users/irisnet/repos","events_url":"https://api.github.com/users/irisnet/events{/privacy}","received_events_url":"https://api.github.com/users/irisnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/irisnet/cosmos-sdk","description":"Secure Blockchain Framework","fork":true,"url":"https://api.github.com/repos/irisnet/cosmos-sdk","forks_url":"https://api.github.com/repos/irisnet/cosmos-sdk/forks","keys_url":"https://api.github.com/repos/irisnet/cosmos-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/irisnet/cosmos-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/irisnet/cosmos-sdk/teams","hooks_url":"https://api.github.com/repos/irisnet/cosmos-sdk/hooks","issue_events_url":"https://api.github.com/repos/irisnet/cosmos-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/irisnet/cosmos-sdk/events","assignees_url":"https://api.github.com/repos/irisnet/cosmos-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/irisnet/cosmos-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/irisnet/cosmos-sdk/tags","blobs_url":"https://api.github.com/repos/irisnet/cosmos-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/irisnet/cosmos-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/irisnet/cosmos-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/irisnet/cosmos-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/irisnet/cosmos-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/irisnet/cosmos-sdk/languages","stargazers_url":"https://api.github.com/repos/irisnet/cosmos-sdk/stargazers","contributors_url":"https://api.github.com/repos/irisnet/cosmos-sdk/contributors","subscribers_url":"https://api.github.com/repos/irisnet/cosmos-sdk/subscribers","subscription_url":"https://api.github.com/repos/irisnet/cosmos-sdk/subscription","commits_url":"https://api.github.com/repos/irisnet/cosmos-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/irisnet/cosmos-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/irisnet/cosmos-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/irisnet/cosmos-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/irisnet/cosmos-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/irisnet/cosmos-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/irisnet/cosmos-sdk/merges","archive_url":"https://api.github.com/repos/irisnet/cosmos-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/irisnet/cosmos-sdk/downloads","issues_url":"https://api.github.com/repos/irisnet/cosmos-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/irisnet/cosmos-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/irisnet/cosmos-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/irisnet/cosmos-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/irisnet/cosmos-sdk/labels{/name}","releases_url":"https://api.github.com/repos/irisnet/cosmos-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/irisnet/cosmos-sdk/deployments","created_at":"2018-05-23T07:08:10Z","updated_at":"2018-07-27T08:34:51Z","pushed_at":"2018-08-31T15:27:30Z","git_url":"git://github.com/irisnet/cosmos-sdk.git","ssh_url":"git@github.com:irisnet/cosmos-sdk.git","clone_url":"https://github.com/irisnet/cosmos-sdk.git","svn_url":"https://github.com/irisnet/cosmos-sdk","homepage":"https://tendermint.com","size":34607,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cosmos:develop","ref":"develop","sha":"ee0434e5a7d724f5a14056b8fd96d5327dbaf93c","user":{"login":"cosmos","id":228843,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODg0Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/228843?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmos","html_url":"https://github.com/cosmos","followers_url":"https://api.github.com/users/cosmos/followers","following_url":"https://api.github.com/users/cosmos/following{/other_user}","gists_url":"https://api.github.com/users/cosmos/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmos/subscriptions","organizations_url":"https://api.github.com/users/cosmos/orgs","repos_url":"https://api.github.com/users/cosmos/repos","events_url":"https://api.github.com/users/cosmos/events{/privacy}","received_events_url":"https://api.github.com/users/cosmos/received_events","type":"Organization","site_admin":false},"repo":{"id":51193526,"node_id":"MDEwOlJlcG9zaXRvcnk1MTE5MzUyNg==","name":"cosmos-sdk","full_name":"cosmos/cosmos-sdk","owner":{"login":"cosmos","id":228843,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODg0Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/228843?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmos","html_url":"https://github.com/cosmos","followers_url":"https://api.github.com/users/cosmos/followers","following_url":"https://api.github.com/users/cosmos/following{/other_user}","gists_url":"https://api.github.com/users/cosmos/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmos/subscriptions","organizations_url":"https://api.github.com/users/cosmos/orgs","repos_url":"https://api.github.com/users/cosmos/repos","events_url":"https://api.github.com/users/cosmos/events{/privacy}","received_events_url":"https://api.github.com/users/cosmos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cosmos/cosmos-sdk","description":":chains: Well Designed Blockchain Framework :sparkles:","fork":false,"url":"https://api.github.com/repos/cosmos/cosmos-sdk","forks_url":"https://api.github.com/repos/cosmos/cosmos-sdk/forks","keys_url":"https://api.github.com/repos/cosmos/cosmos-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cosmos/cosmos-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cosmos/cosmos-sdk/teams","hooks_url":"https://api.github.com/repos/cosmos/cosmos-sdk/hooks","issue_events_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/cosmos/cosmos-sdk/events","assignees_url":"https://api.github.com/repos/cosmos/cosmos-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/cosmos/cosmos-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/cosmos/cosmos-sdk/tags","blobs_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cosmos/cosmos-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/cosmos/cosmos-sdk/languages","stargazers_url":"https://api.github.com/repos/cosmos/cosmos-sdk/stargazers","contributors_url":"https://api.github.com/repos/cosmos/cosmos-sdk/contributors","subscribers_url":"https://api.github.com/repos/cosmos/cosmos-sdk/subscribers","subscription_url":"https://api.github.com/repos/cosmos/cosmos-sdk/subscription","commits_url":"https://api.github.com/repos/cosmos/cosmos-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/cosmos/cosmos-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/cosmos/cosmos-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/cosmos/cosmos-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cosmos/cosmos-sdk/merges","archive_url":"https://api.github.com/repos/cosmos/cosmos-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cosmos/cosmos-sdk/downloads","issues_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/cosmos/cosmos-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/cosmos/cosmos-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cosmos/cosmos-sdk/labels{/name}","releases_url":"https://api.github.com/repos/cosmos/cosmos-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/cosmos/cosmos-sdk/deployments","created_at":"2016-02-06T07:15:53Z","updated_at":"2018-08-31T09:00:12Z","pushed_at":"2018-08-31T15:29:43Z","git_url":"git://github.com/cosmos/cosmos-sdk.git","ssh_url":"git@github.com:cosmos/cosmos-sdk.git","clone_url":"https://github.com/cosmos/cosmos-sdk.git","svn_url":"https://github.com/cosmos/cosmos-sdk","homepage":"https://cosmos.network/","size":34506,"stargazers_count":553,"watchers_count":553,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":189,"mirror_url":null,"archived":false,"open_issues_count":345,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":189,"open_issues":345,"watchers":553,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2199"},"html":{"href":"https://github.com/cosmos/cosmos-sdk/pull/2199"},"issue":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2199"},"comments":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2199/comments"},"review_comments":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2199/comments"},"review_comment":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2199/commits"},"statuses":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/statuses/8b359413acb162417e64e84b5db28890db461d18"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"HaoyangLiu"}}