{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/210063902","pull_request_review_id":146202618,"id":210063902,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDA2MzkwMg==","diff_hunk":"@@ -4715,10 +4714,16 @@ UniValue walletcreatefundedpsbt(const JSONRPCRequest& request)\n         }, true\n     );\n \n+","path":"src/wallet/rpcwallet.cpp","position":12,"original_position":12,"commit_id":"6a5822d2671ea204c5dd0496a6636d5b38110348","original_commit_id":"6a5822d2671ea204c5dd0496a6636d5b38110348","user":{"login":"achow101","id":3782274,"node_id":"MDQ6VXNlcjM3ODIyNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3782274?v=4","gravatar_id":"","url":"https://api.github.com/users/achow101","html_url":"https://github.com/achow101","followers_url":"https://api.github.com/users/achow101/followers","following_url":"https://api.github.com/users/achow101/following{/other_user}","gists_url":"https://api.github.com/users/achow101/gists{/gist_id}","starred_url":"https://api.github.com/users/achow101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achow101/subscriptions","organizations_url":"https://api.github.com/users/achow101/orgs","repos_url":"https://api.github.com/users/achow101/repos","events_url":"https://api.github.com/users/achow101/events{/privacy}","received_events_url":"https://api.github.com/users/achow101/received_events","type":"User","site_admin":false},"body":"Nit: miscellaneous whitespace change","created_at":"2018-08-14T18:50:16Z","updated_at":"2018-08-14T18:52:14Z","html_url":"https://github.com/bitcoin/bitcoin/pull/13968#discussion_r210063902","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13968","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/210063902"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/13968#discussion_r210063902"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13968"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13968","id":208374046,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4Mzc0MDQ2","html_url":"https://github.com/bitcoin/bitcoin/pull/13968","diff_url":"https://github.com/bitcoin/bitcoin/pull/13968.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/13968.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/13968","number":13968,"state":"open","locked":false,"title":"[wallet] couple of walletcreatefundedpsbt fixes","user":{"login":"instagibbs","id":5767891,"node_id":"MDQ6VXNlcjU3Njc4OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/5767891?v=4","gravatar_id":"","url":"https://api.github.com/users/instagibbs","html_url":"https://github.com/instagibbs","followers_url":"https://api.github.com/users/instagibbs/followers","following_url":"https://api.github.com/users/instagibbs/following{/other_user}","gists_url":"https://api.github.com/users/instagibbs/gists{/gist_id}","starred_url":"https://api.github.com/users/instagibbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/instagibbs/subscriptions","organizations_url":"https://api.github.com/users/instagibbs/orgs","repos_url":"https://api.github.com/users/instagibbs/repos","events_url":"https://api.github.com/users/instagibbs/events{/privacy}","received_events_url":"https://api.github.com/users/instagibbs/received_events","type":"User","site_admin":false},"body":"1) Previously an empty input argument transaction that is marked for replaceability fails to pass the `SignalsOptInRBF` check right before funding it. Explicitly check for that condition before throwing an error.\r\n\r\n2) The rpc call had two separate `replaceable` arguments, each of which being used in mutually exclusive places. Since we have named args I opted to prefer the top-level argument instead.","created_at":"2018-08-14T18:42:58Z","updated_at":"2018-08-14T18:52:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d49a61e2ab8454c25c1f96a41ba549573b8f50a8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13968/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13968/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/13968/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/6a5822d2671ea204c5dd0496a6636d5b38110348","head":{"label":"instagibbs:wcpsbtreplace","ref":"wcpsbtreplace","sha":"6a5822d2671ea204c5dd0496a6636d5b38110348","user":{"login":"instagibbs","id":5767891,"node_id":"MDQ6VXNlcjU3Njc4OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/5767891?v=4","gravatar_id":"","url":"https://api.github.com/users/instagibbs","html_url":"https://github.com/instagibbs","followers_url":"https://api.github.com/users/instagibbs/followers","following_url":"https://api.github.com/users/instagibbs/following{/other_user}","gists_url":"https://api.github.com/users/instagibbs/gists{/gist_id}","starred_url":"https://api.github.com/users/instagibbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/instagibbs/subscriptions","organizations_url":"https://api.github.com/users/instagibbs/orgs","repos_url":"https://api.github.com/users/instagibbs/repos","events_url":"https://api.github.com/users/instagibbs/events{/privacy}","received_events_url":"https://api.github.com/users/instagibbs/received_events","type":"User","site_admin":false},"repo":{"id":13910191,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkxMDE5MQ==","name":"bitcoin","full_name":"instagibbs/bitcoin","owner":{"login":"instagibbs","id":5767891,"node_id":"MDQ6VXNlcjU3Njc4OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/5767891?v=4","gravatar_id":"","url":"https://api.github.com/users/instagibbs","html_url":"https://github.com/instagibbs","followers_url":"https://api.github.com/users/instagibbs/followers","following_url":"https://api.github.com/users/instagibbs/following{/other_user}","gists_url":"https://api.github.com/users/instagibbs/gists{/gist_id}","starred_url":"https://api.github.com/users/instagibbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/instagibbs/subscriptions","organizations_url":"https://api.github.com/users/instagibbs/orgs","repos_url":"https://api.github.com/users/instagibbs/repos","events_url":"https://api.github.com/users/instagibbs/events{/privacy}","received_events_url":"https://api.github.com/users/instagibbs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/instagibbs/bitcoin","description":"Bitcoin integration/staging tree","fork":true,"url":"https://api.github.com/repos/instagibbs/bitcoin","forks_url":"https://api.github.com/repos/instagibbs/bitcoin/forks","keys_url":"https://api.github.com/repos/instagibbs/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/instagibbs/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/instagibbs/bitcoin/teams","hooks_url":"https://api.github.com/repos/instagibbs/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/instagibbs/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/instagibbs/bitcoin/events","assignees_url":"https://api.github.com/repos/instagibbs/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/instagibbs/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/instagibbs/bitcoin/tags","blobs_url":"https://api.github.com/repos/instagibbs/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/instagibbs/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/instagibbs/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/instagibbs/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/instagibbs/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/instagibbs/bitcoin/languages","stargazers_url":"https://api.github.com/repos/instagibbs/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/instagibbs/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/instagibbs/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/instagibbs/bitcoin/subscription","commits_url":"https://api.github.com/repos/instagibbs/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/instagibbs/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/instagibbs/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/instagibbs/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/instagibbs/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/instagibbs/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/instagibbs/bitcoin/merges","archive_url":"https://api.github.com/repos/instagibbs/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/instagibbs/bitcoin/downloads","issues_url":"https://api.github.com/repos/instagibbs/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/instagibbs/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/instagibbs/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/instagibbs/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/instagibbs/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/instagibbs/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/instagibbs/bitcoin/deployments","created_at":"2013-10-27T20:56:53Z","updated_at":"2015-03-19T19:05:23Z","pushed_at":"2018-08-14T18:39:18Z","git_url":"git://github.com/instagibbs/bitcoin.git","ssh_url":"git@github.com:instagibbs/bitcoin.git","clone_url":"https://github.com/instagibbs/bitcoin.git","svn_url":"https://github.com/instagibbs/bitcoin","homepage":"http://www.bitcoin.org","size":104601,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"63f8b0128b2aac3b25c6ec4d2f5bda213033162a","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2018-08-14T18:34:31Z","pushed_at":"2018-08-14T18:42:59Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":109989,"stargazers_count":33970,"watchers_count":33970,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":20558,"mirror_url":null,"archived":false,"open_issues_count":839,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":20558,"open_issues":839,"watchers":33970,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13968"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/13968"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/13968"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/13968/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13968/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13968/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/6a5822d2671ea204c5dd0496a6636d5b38110348"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"achow101"}}