{"action":"created","comment":{"url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/pulls/comments/217696949","pull_request_review_id":155474536,"id":217696949,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzY5Njk0OQ==","diff_hunk":"@@ -162,6 +163,7 @@ build:master_docker_latest:\n     - build:master_docker_latest\n   script:\n     - ./test/toolbox_image.sh .build_*/um-update*.xz.img\n+    - ./test/prepare_disk.sh .build_*/um-update*.xz.img","path":".gitlab-ci.yml","position":14,"original_position":14,"commit_id":"b7e60361959c74b6aa638cdaa9d478185a4b8037","original_commit_id":"b7e60361959c74b6aa638cdaa9d478185a4b8037","user":{"login":"oliv3r","id":1245341,"node_id":"MDQ6VXNlcjEyNDUzNDE=","avatar_url":"https://avatars1.githubusercontent.com/u/1245341?v=4","gravatar_id":"","url":"https://api.github.com/users/oliv3r","html_url":"https://github.com/oliv3r","followers_url":"https://api.github.com/users/oliv3r/followers","following_url":"https://api.github.com/users/oliv3r/following{/other_user}","gists_url":"https://api.github.com/users/oliv3r/gists{/gist_id}","starred_url":"https://api.github.com/users/oliv3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliv3r/subscriptions","organizations_url":"https://api.github.com/users/oliv3r/orgs","repos_url":"https://api.github.com/users/oliv3r/repos","events_url":"https://api.github.com/users/oliv3r/events{/privacy}","received_events_url":"https://api.github.com/users/oliv3r/received_events","type":"User","site_admin":false},"body":"for our tests, i'd recommend putting each in its own job. feel free to template it so it only reads:\r\n```yaml\r\ntest:toolboxtest_1/2:\r\n<<: *job_template\r\nscript: ./test/toolbox_image.sh ...\r\n```\r\nor something. a) it allows for the tests to run in parallel; b) you more easily see which tests fails in the overview, rather then 'all tests failed'","created_at":"2018-09-14T12:35:23Z","updated_at":"2018-09-14T12:50:11Z","html_url":"https://github.com/Ultimaker/um-update_toolbox_armhf/pull/43#discussion_r217696949","pull_request_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/pulls/43","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/pulls/comments/217696949"},"html":{"href":"https://github.com/Ultimaker/um-update_toolbox_armhf/pull/43#discussion_r217696949"},"pull_request":{"href":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/pulls/43","id":215254645,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MjU0NjQ1","html_url":"https://github.com/Ultimaker/um-update_toolbox_armhf/pull/43","diff_url":"https://github.com/Ultimaker/um-update_toolbox_armhf/pull/43.diff","patch_url":"https://github.com/Ultimaker/um-update_toolbox_armhf/pull/43.patch","issue_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/issues/43","number":43,"state":"open","locked":false,"title":"Emp 406 create prepare disk test script","user":{"login":"raysiudak","id":2758985,"node_id":"MDQ6VXNlcjI3NTg5ODU=","avatar_url":"https://avatars3.githubusercontent.com/u/2758985?v=4","gravatar_id":"","url":"https://api.github.com/users/raysiudak","html_url":"https://github.com/raysiudak","followers_url":"https://api.github.com/users/raysiudak/followers","following_url":"https://api.github.com/users/raysiudak/following{/other_user}","gists_url":"https://api.github.com/users/raysiudak/gists{/gist_id}","starred_url":"https://api.github.com/users/raysiudak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raysiudak/subscriptions","organizations_url":"https://api.github.com/users/raysiudak/orgs","repos_url":"https://api.github.com/users/raysiudak/repos","events_url":"https://api.github.com/users/raysiudak/events{/privacy}","received_events_url":"https://api.github.com/users/raysiudak/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-13T11:45:50Z","updated_at":"2018-09-14T12:50:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9865af1b8d2851ef39d5da3b67cfd21df0175632","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/pulls/43/commits","review_comments_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/pulls/43/comments","review_comment_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/issues/43/comments","statuses_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/statuses/b7e60361959c74b6aa638cdaa9d478185a4b8037","head":{"label":"Ultimaker:EMP-406_create_prepare_disk_test_script","ref":"EMP-406_create_prepare_disk_test_script","sha":"b7e60361959c74b6aa638cdaa9d478185a4b8037","user":{"login":"Ultimaker","id":499557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTU1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/499557?v=4","gravatar_id":"","url":"https://api.github.com/users/Ultimaker","html_url":"https://github.com/Ultimaker","followers_url":"https://api.github.com/users/Ultimaker/followers","following_url":"https://api.github.com/users/Ultimaker/following{/other_user}","gists_url":"https://api.github.com/users/Ultimaker/gists{/gist_id}","starred_url":"https://api.github.com/users/Ultimaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ultimaker/subscriptions","organizations_url":"https://api.github.com/users/Ultimaker/orgs","repos_url":"https://api.github.com/users/Ultimaker/repos","events_url":"https://api.github.com/users/Ultimaker/events{/privacy}","received_events_url":"https://api.github.com/users/Ultimaker/received_events","type":"Organization","site_admin":false},"repo":{"id":141393035,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEzOTMwMzU=","name":"um-update_toolbox_armhf","full_name":"Ultimaker/um-update_toolbox_armhf","owner":{"login":"Ultimaker","id":499557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTU1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/499557?v=4","gravatar_id":"","url":"https://api.github.com/users/Ultimaker","html_url":"https://github.com/Ultimaker","followers_url":"https://api.github.com/users/Ultimaker/followers","following_url":"https://api.github.com/users/Ultimaker/following{/other_user}","gists_url":"https://api.github.com/users/Ultimaker/gists{/gist_id}","starred_url":"https://api.github.com/users/Ultimaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ultimaker/subscriptions","organizations_url":"https://api.github.com/users/Ultimaker/orgs","repos_url":"https://api.github.com/users/Ultimaker/repos","events_url":"https://api.github.com/users/Ultimaker/events{/privacy}","received_events_url":"https://api.github.com/users/Ultimaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Ultimaker/um-update_toolbox_armhf","description":null,"fork":false,"url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf","forks_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/forks","keys_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/teams","hooks_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/hooks","issue_events_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/issues/events{/number}","events_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/events","assignees_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/assignees{/user}","branches_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/branches{/branch}","tags_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/tags","blobs_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/statuses/{sha}","languages_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/languages","stargazers_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/stargazers","contributors_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/contributors","subscribers_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/subscribers","subscription_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/subscription","commits_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/contents/{+path}","compare_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/merges","archive_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/downloads","issues_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/issues{/number}","pulls_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/pulls{/number}","milestones_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/milestones{/number}","notifications_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/labels{/name}","releases_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/releases{/id}","deployments_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/deployments","created_at":"2018-07-18T06:47:30Z","updated_at":"2018-09-14T06:49:45Z","pushed_at":"2018-09-14T12:26:38Z","git_url":"git://github.com/Ultimaker/um-update_toolbox_armhf.git","ssh_url":"git@github.com:Ultimaker/um-update_toolbox_armhf.git","clone_url":"https://github.com/Ultimaker/um-update_toolbox_armhf.git","svn_url":"https://github.com/Ultimaker/um-update_toolbox_armhf","homepage":"","size":2167,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"Ultimaker:master","ref":"master","sha":"9000390e12b1bc94482003701acc1cf8d98ffd71","user":{"login":"Ultimaker","id":499557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTU1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/499557?v=4","gravatar_id":"","url":"https://api.github.com/users/Ultimaker","html_url":"https://github.com/Ultimaker","followers_url":"https://api.github.com/users/Ultimaker/followers","following_url":"https://api.github.com/users/Ultimaker/following{/other_user}","gists_url":"https://api.github.com/users/Ultimaker/gists{/gist_id}","starred_url":"https://api.github.com/users/Ultimaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ultimaker/subscriptions","organizations_url":"https://api.github.com/users/Ultimaker/orgs","repos_url":"https://api.github.com/users/Ultimaker/repos","events_url":"https://api.github.com/users/Ultimaker/events{/privacy}","received_events_url":"https://api.github.com/users/Ultimaker/received_events","type":"Organization","site_admin":false},"repo":{"id":141393035,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEzOTMwMzU=","name":"um-update_toolbox_armhf","full_name":"Ultimaker/um-update_toolbox_armhf","owner":{"login":"Ultimaker","id":499557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTU1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/499557?v=4","gravatar_id":"","url":"https://api.github.com/users/Ultimaker","html_url":"https://github.com/Ultimaker","followers_url":"https://api.github.com/users/Ultimaker/followers","following_url":"https://api.github.com/users/Ultimaker/following{/other_user}","gists_url":"https://api.github.com/users/Ultimaker/gists{/gist_id}","starred_url":"https://api.github.com/users/Ultimaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ultimaker/subscriptions","organizations_url":"https://api.github.com/users/Ultimaker/orgs","repos_url":"https://api.github.com/users/Ultimaker/repos","events_url":"https://api.github.com/users/Ultimaker/events{/privacy}","received_events_url":"https://api.github.com/users/Ultimaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Ultimaker/um-update_toolbox_armhf","description":null,"fork":false,"url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf","forks_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/forks","keys_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/teams","hooks_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/hooks","issue_events_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/issues/events{/number}","events_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/events","assignees_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/assignees{/user}","branches_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/branches{/branch}","tags_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/tags","blobs_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/statuses/{sha}","languages_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/languages","stargazers_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/stargazers","contributors_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/contributors","subscribers_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/subscribers","subscription_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/subscription","commits_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/contents/{+path}","compare_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/merges","archive_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/downloads","issues_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/issues{/number}","pulls_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/pulls{/number}","milestones_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/milestones{/number}","notifications_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/labels{/name}","releases_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/releases{/id}","deployments_url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/deployments","created_at":"2018-07-18T06:47:30Z","updated_at":"2018-09-14T06:49:45Z","pushed_at":"2018-09-14T12:26:38Z","git_url":"git://github.com/Ultimaker/um-update_toolbox_armhf.git","ssh_url":"git@github.com:Ultimaker/um-update_toolbox_armhf.git","clone_url":"https://github.com/Ultimaker/um-update_toolbox_armhf.git","svn_url":"https://github.com/Ultimaker/um-update_toolbox_armhf","homepage":"","size":2167,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/pulls/43"},"html":{"href":"https://github.com/Ultimaker/um-update_toolbox_armhf/pull/43"},"issue":{"href":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/issues/43"},"comments":{"href":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/statuses/b7e60361959c74b6aa638cdaa9d478185a4b8037"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"oliv3r"}}