{"action":"created","comment":{"url":"https://api.github.com/repos/google/incremental-dom/pulls/comments/208406265","pull_request_review_id":144210139,"id":208406265,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODQwNjI2NQ==","diff_hunk":"@@ -56,6 +56,14 @@ export class NodeData {\n     this.key = key;\n     this.text = text;\n   }\n+\n+  hasAttrs(): boolean {","path":"src/node_data.ts","position":14,"original_position":14,"commit_id":"152466c938c787d2d860907c8ec014751347684d","original_commit_id":"152466c938c787d2d860907c8ec014751347684d","user":{"login":"jridgewell","id":112982,"node_id":"MDQ6VXNlcjExMjk4Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/112982?v=4","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2018-08-07T22:34:29Z","updated_at":"2018-08-07T22:53:25Z","html_url":"https://github.com/google/incremental-dom/pull/334#discussion_r208406265","pull_request_url":"https://api.github.com/repos/google/incremental-dom/pulls/334","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/google/incremental-dom/pulls/comments/208406265"},"html":{"href":"https://github.com/google/incremental-dom/pull/334#discussion_r208406265"},"pull_request":{"href":"https://api.github.com/repos/google/incremental-dom/pulls/334"}},"in_reply_to_id":208403813},"pull_request":{"url":"https://api.github.com/repos/google/incremental-dom/pulls/334","id":118904122,"node_id":"MDExOlB1bGxSZXF1ZXN0MTE4OTA0MTIy","html_url":"https://github.com/google/incremental-dom/pull/334","diff_url":"https://github.com/google/incremental-dom/pull/334.diff","patch_url":"https://github.com/google/incremental-dom/pull/334.patch","issue_url":"https://api.github.com/repos/google/incremental-dom/issues/334","number":334,"state":"open","locked":false,"title":"Lazy load NodeData properties","user":{"login":"jridgewell","id":112982,"node_id":"MDQ6VXNlcjExMjk4Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/112982?v=4","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"body":"A few things:\r\n\r\n- Lazy loads `attrsArr`, creating it with proper size when needed\r\n","created_at":"2017-05-04T05:59:24Z","updated_at":"2018-08-07T22:53:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e32835a14cf1b8d892cb07e66484ff4716f3582","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/incremental-dom/pulls/334/commits","review_comments_url":"https://api.github.com/repos/google/incremental-dom/pulls/334/comments","review_comment_url":"https://api.github.com/repos/google/incremental-dom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/incremental-dom/issues/334/comments","statuses_url":"https://api.github.com/repos/google/incremental-dom/statuses/152466c938c787d2d860907c8ec014751347684d","head":{"label":"jridgewell:lazy-node-data","ref":"lazy-node-data","sha":"152466c938c787d2d860907c8ec014751347684d","user":{"login":"jridgewell","id":112982,"node_id":"MDQ6VXNlcjExMjk4Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/112982?v=4","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"repo":{"id":38864030,"node_id":"MDEwOlJlcG9zaXRvcnkzODg2NDAzMA==","name":"incremental-dom","full_name":"jridgewell/incremental-dom","owner":{"login":"jridgewell","id":112982,"node_id":"MDQ6VXNlcjExMjk4Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/112982?v=4","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jridgewell/incremental-dom","description":null,"fork":true,"url":"https://api.github.com/repos/jridgewell/incremental-dom","forks_url":"https://api.github.com/repos/jridgewell/incremental-dom/forks","keys_url":"https://api.github.com/repos/jridgewell/incremental-dom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jridgewell/incremental-dom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jridgewell/incremental-dom/teams","hooks_url":"https://api.github.com/repos/jridgewell/incremental-dom/hooks","issue_events_url":"https://api.github.com/repos/jridgewell/incremental-dom/issues/events{/number}","events_url":"https://api.github.com/repos/jridgewell/incremental-dom/events","assignees_url":"https://api.github.com/repos/jridgewell/incremental-dom/assignees{/user}","branches_url":"https://api.github.com/repos/jridgewell/incremental-dom/branches{/branch}","tags_url":"https://api.github.com/repos/jridgewell/incremental-dom/tags","blobs_url":"https://api.github.com/repos/jridgewell/incremental-dom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jridgewell/incremental-dom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jridgewell/incremental-dom/git/refs{/sha}","trees_url":"https://api.github.com/repos/jridgewell/incremental-dom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jridgewell/incremental-dom/statuses/{sha}","languages_url":"https://api.github.com/repos/jridgewell/incremental-dom/languages","stargazers_url":"https://api.github.com/repos/jridgewell/incremental-dom/stargazers","contributors_url":"https://api.github.com/repos/jridgewell/incremental-dom/contributors","subscribers_url":"https://api.github.com/repos/jridgewell/incremental-dom/subscribers","subscription_url":"https://api.github.com/repos/jridgewell/incremental-dom/subscription","commits_url":"https://api.github.com/repos/jridgewell/incremental-dom/commits{/sha}","git_commits_url":"https://api.github.com/repos/jridgewell/incremental-dom/git/commits{/sha}","comments_url":"https://api.github.com/repos/jridgewell/incremental-dom/comments{/number}","issue_comment_url":"https://api.github.com/repos/jridgewell/incremental-dom/issues/comments{/number}","contents_url":"https://api.github.com/repos/jridgewell/incremental-dom/contents/{+path}","compare_url":"https://api.github.com/repos/jridgewell/incremental-dom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jridgewell/incremental-dom/merges","archive_url":"https://api.github.com/repos/jridgewell/incremental-dom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jridgewell/incremental-dom/downloads","issues_url":"https://api.github.com/repos/jridgewell/incremental-dom/issues{/number}","pulls_url":"https://api.github.com/repos/jridgewell/incremental-dom/pulls{/number}","milestones_url":"https://api.github.com/repos/jridgewell/incremental-dom/milestones{/number}","notifications_url":"https://api.github.com/repos/jridgewell/incremental-dom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jridgewell/incremental-dom/labels{/name}","releases_url":"https://api.github.com/repos/jridgewell/incremental-dom/releases{/id}","deployments_url":"https://api.github.com/repos/jridgewell/incremental-dom/deployments","created_at":"2015-07-10T06:08:03Z","updated_at":"2016-02-02T01:55:46Z","pushed_at":"2018-08-07T21:56:57Z","git_url":"git://github.com/jridgewell/incremental-dom.git","ssh_url":"git@github.com:jridgewell/incremental-dom.git","clone_url":"https://github.com/jridgewell/incremental-dom.git","svn_url":"https://github.com/jridgewell/incremental-dom","homepage":null,"size":968,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"41409c9451de0ed90c69839ca7cdb64cd8b4f0e4","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":37283747,"node_id":"MDEwOlJlcG9zaXRvcnkzNzI4Mzc0Nw==","name":"incremental-dom","full_name":"google/incremental-dom","owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/incremental-dom","description":"An in-place DOM diffing library","fork":false,"url":"https://api.github.com/repos/google/incremental-dom","forks_url":"https://api.github.com/repos/google/incremental-dom/forks","keys_url":"https://api.github.com/repos/google/incremental-dom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/incremental-dom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/incremental-dom/teams","hooks_url":"https://api.github.com/repos/google/incremental-dom/hooks","issue_events_url":"https://api.github.com/repos/google/incremental-dom/issues/events{/number}","events_url":"https://api.github.com/repos/google/incremental-dom/events","assignees_url":"https://api.github.com/repos/google/incremental-dom/assignees{/user}","branches_url":"https://api.github.com/repos/google/incremental-dom/branches{/branch}","tags_url":"https://api.github.com/repos/google/incremental-dom/tags","blobs_url":"https://api.github.com/repos/google/incremental-dom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/incremental-dom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/incremental-dom/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/incremental-dom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/incremental-dom/statuses/{sha}","languages_url":"https://api.github.com/repos/google/incremental-dom/languages","stargazers_url":"https://api.github.com/repos/google/incremental-dom/stargazers","contributors_url":"https://api.github.com/repos/google/incremental-dom/contributors","subscribers_url":"https://api.github.com/repos/google/incremental-dom/subscribers","subscription_url":"https://api.github.com/repos/google/incremental-dom/subscription","commits_url":"https://api.github.com/repos/google/incremental-dom/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/incremental-dom/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/incremental-dom/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/incremental-dom/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/incremental-dom/contents/{+path}","compare_url":"https://api.github.com/repos/google/incremental-dom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/incremental-dom/merges","archive_url":"https://api.github.com/repos/google/incremental-dom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/incremental-dom/downloads","issues_url":"https://api.github.com/repos/google/incremental-dom/issues{/number}","pulls_url":"https://api.github.com/repos/google/incremental-dom/pulls{/number}","milestones_url":"https://api.github.com/repos/google/incremental-dom/milestones{/number}","notifications_url":"https://api.github.com/repos/google/incremental-dom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/incremental-dom/labels{/name}","releases_url":"https://api.github.com/repos/google/incremental-dom/releases{/id}","deployments_url":"https://api.github.com/repos/google/incremental-dom/deployments","created_at":"2015-06-11T20:15:03Z","updated_at":"2018-08-07T21:56:30Z","pushed_at":"2018-08-07T21:56:28Z","git_url":"git://github.com/google/incremental-dom.git","ssh_url":"git@github.com:google/incremental-dom.git","clone_url":"https://github.com/google/incremental-dom.git","svn_url":"https://github.com/google/incremental-dom","homepage":"http://google.github.io/incremental-dom/","size":989,"stargazers_count":2920,"watchers_count":2920,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":141,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":141,"open_issues":44,"watchers":2920,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/incremental-dom/pulls/334"},"html":{"href":"https://github.com/google/incremental-dom/pull/334"},"issue":{"href":"https://api.github.com/repos/google/incremental-dom/issues/334"},"comments":{"href":"https://api.github.com/repos/google/incremental-dom/issues/334/comments"},"review_comments":{"href":"https://api.github.com/repos/google/incremental-dom/pulls/334/comments"},"review_comment":{"href":"https://api.github.com/repos/google/incremental-dom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/incremental-dom/pulls/334/commits"},"statuses":{"href":"https://api.github.com/repos/google/incremental-dom/statuses/152466c938c787d2d860907c8ec014751347684d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jridgewell"}}