{"action":"created","comment":{"url":"https://api.github.com/repos/rubykube/peatio/pulls/comments/196702261","pull_request_review_id":130301918,"id":196702261,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjcwMjI2MQ==","diff_hunk":"@@ -52,10 +53,7 @@ def create_trade_and_strike_orders\n         @ask = OrderAsk.lock.find(@payload[:ask_id])\n         @bid = OrderBid.lock.find(@payload[:bid_id])\n \n-        unless valid?\n-          raise TradeExecutionError.new \\\n-            ask: @ask, bid: @bid, price: @price, volume: @volume, funds: @funds\n-        end\n+        valid?","path":"app/trading/matching/executor.rb","position":33,"original_position":33,"commit_id":"345cffb8a44eaee1214d64e96806319e814e4ff2","original_commit_id":"345cffb8a44eaee1214d64e96806319e814e4ff2","user":{"login":"mod","id":80003,"node_id":"MDQ6VXNlcjgwMDAz","avatar_url":"https://avatars2.githubusercontent.com/u/80003?v=4","gravatar_id":"","url":"https://api.github.com/users/mod","html_url":"https://github.com/mod","followers_url":"https://api.github.com/users/mod/followers","following_url":"https://api.github.com/users/mod/following{/other_user}","gists_url":"https://api.github.com/users/mod/gists{/gist_id}","starred_url":"https://api.github.com/users/mod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mod/subscriptions","organizations_url":"https://api.github.com/users/mod/orgs","repos_url":"https://api.github.com/users/mod/repos","events_url":"https://api.github.com/users/mod/events{/privacy}","received_events_url":"https://api.github.com/users/mod/received_events","type":"User","site_admin":false},"body":"rename in validate","created_at":"2018-06-20T09:11:44Z","updated_at":"2018-06-20T09:12:15Z","html_url":"https://github.com/rubykube/peatio/pull/1328#discussion_r196702261","pull_request_url":"https://api.github.com/repos/rubykube/peatio/pulls/1328","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/rubykube/peatio/pulls/comments/196702261"},"html":{"href":"https://github.com/rubykube/peatio/pull/1328#discussion_r196702261"},"pull_request":{"href":"https://api.github.com/repos/rubykube/peatio/pulls/1328"}}},"pull_request":{"url":"https://api.github.com/repos/rubykube/peatio/pulls/1328","id":196056166,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MDU2MTY2","html_url":"https://github.com/rubykube/peatio/pull/1328","diff_url":"https://github.com/rubykube/peatio/pull/1328.diff","patch_url":"https://github.com/rubykube/peatio/pull/1328.patch","issue_url":"https://api.github.com/repos/rubykube/peatio/issues/1328","number":1328,"state":"open","locked":false,"title":"[WIP] #1324 Matching engine and trade executor generating errors","user":{"login":"dinesh-skyach","id":35770481,"node_id":"MDQ6VXNlcjM1NzcwNDgx","avatar_url":"https://avatars0.githubusercontent.com/u/35770481?v=4","gravatar_id":"","url":"https://api.github.com/users/dinesh-skyach","html_url":"https://github.com/dinesh-skyach","followers_url":"https://api.github.com/users/dinesh-skyach/followers","following_url":"https://api.github.com/users/dinesh-skyach/following{/other_user}","gists_url":"https://api.github.com/users/dinesh-skyach/gists{/gist_id}","starred_url":"https://api.github.com/users/dinesh-skyach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dinesh-skyach/subscriptions","organizations_url":"https://api.github.com/users/dinesh-skyach/orgs","repos_url":"https://api.github.com/users/dinesh-skyach/repos","events_url":"https://api.github.com/users/dinesh-skyach/events{/privacy}","received_events_url":"https://api.github.com/users/dinesh-skyach/received_events","type":"User","site_admin":false},"body":" Matching engine and trade executor generating errors #1324","created_at":"2018-06-20T08:17:56Z","updated_at":"2018-06-20T09:12:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33384b4b5a7311508e65a7e91afec49121613f47","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rubykube/peatio/pulls/1328/commits","review_comments_url":"https://api.github.com/repos/rubykube/peatio/pulls/1328/comments","review_comment_url":"https://api.github.com/repos/rubykube/peatio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rubykube/peatio/issues/1328/comments","statuses_url":"https://api.github.com/repos/rubykube/peatio/statuses/345cffb8a44eaee1214d64e96806319e814e4ff2","head":{"label":"skyach:trade_executor_errors","ref":"trade_executor_errors","sha":"345cffb8a44eaee1214d64e96806319e814e4ff2","user":{"login":"skyach","id":16320666,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MzIwNjY2","avatar_url":"https://avatars2.githubusercontent.com/u/16320666?v=4","gravatar_id":"","url":"https://api.github.com/users/skyach","html_url":"https://github.com/skyach","followers_url":"https://api.github.com/users/skyach/followers","following_url":"https://api.github.com/users/skyach/following{/other_user}","gists_url":"https://api.github.com/users/skyach/gists{/gist_id}","starred_url":"https://api.github.com/users/skyach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skyach/subscriptions","organizations_url":"https://api.github.com/users/skyach/orgs","repos_url":"https://api.github.com/users/skyach/repos","events_url":"https://api.github.com/users/skyach/events{/privacy}","received_events_url":"https://api.github.com/users/skyach/received_events","type":"Organization","site_admin":false},"repo":{"id":118778347,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg3NzgzNDc=","name":"peatio","full_name":"skyach/peatio","owner":{"login":"skyach","id":16320666,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MzIwNjY2","avatar_url":"https://avatars2.githubusercontent.com/u/16320666?v=4","gravatar_id":"","url":"https://api.github.com/users/skyach","html_url":"https://github.com/skyach","followers_url":"https://api.github.com/users/skyach/followers","following_url":"https://api.github.com/users/skyach/following{/other_user}","gists_url":"https://api.github.com/users/skyach/gists{/gist_id}","starred_url":"https://api.github.com/users/skyach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skyach/subscriptions","organizations_url":"https://api.github.com/users/skyach/orgs","repos_url":"https://api.github.com/users/skyach/repos","events_url":"https://api.github.com/users/skyach/events{/privacy}","received_events_url":"https://api.github.com/users/skyach/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/skyach/peatio","description":"An open-source assets exchange.","fork":true,"url":"https://api.github.com/repos/skyach/peatio","forks_url":"https://api.github.com/repos/skyach/peatio/forks","keys_url":"https://api.github.com/repos/skyach/peatio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skyach/peatio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skyach/peatio/teams","hooks_url":"https://api.github.com/repos/skyach/peatio/hooks","issue_events_url":"https://api.github.com/repos/skyach/peatio/issues/events{/number}","events_url":"https://api.github.com/repos/skyach/peatio/events","assignees_url":"https://api.github.com/repos/skyach/peatio/assignees{/user}","branches_url":"https://api.github.com/repos/skyach/peatio/branches{/branch}","tags_url":"https://api.github.com/repos/skyach/peatio/tags","blobs_url":"https://api.github.com/repos/skyach/peatio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skyach/peatio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skyach/peatio/git/refs{/sha}","trees_url":"https://api.github.com/repos/skyach/peatio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skyach/peatio/statuses/{sha}","languages_url":"https://api.github.com/repos/skyach/peatio/languages","stargazers_url":"https://api.github.com/repos/skyach/peatio/stargazers","contributors_url":"https://api.github.com/repos/skyach/peatio/contributors","subscribers_url":"https://api.github.com/repos/skyach/peatio/subscribers","subscription_url":"https://api.github.com/repos/skyach/peatio/subscription","commits_url":"https://api.github.com/repos/skyach/peatio/commits{/sha}","git_commits_url":"https://api.github.com/repos/skyach/peatio/git/commits{/sha}","comments_url":"https://api.github.com/repos/skyach/peatio/comments{/number}","issue_comment_url":"https://api.github.com/repos/skyach/peatio/issues/comments{/number}","contents_url":"https://api.github.com/repos/skyach/peatio/contents/{+path}","compare_url":"https://api.github.com/repos/skyach/peatio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skyach/peatio/merges","archive_url":"https://api.github.com/repos/skyach/peatio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skyach/peatio/downloads","issues_url":"https://api.github.com/repos/skyach/peatio/issues{/number}","pulls_url":"https://api.github.com/repos/skyach/peatio/pulls{/number}","milestones_url":"https://api.github.com/repos/skyach/peatio/milestones{/number}","notifications_url":"https://api.github.com/repos/skyach/peatio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skyach/peatio/labels{/name}","releases_url":"https://api.github.com/repos/skyach/peatio/releases{/id}","deployments_url":"https://api.github.com/repos/skyach/peatio/deployments","created_at":"2018-01-24T14:46:22Z","updated_at":"2018-05-09T11:16:31Z","pushed_at":"2018-06-20T08:12:21Z","git_url":"git://github.com/skyach/peatio.git","ssh_url":"git@github.com:skyach/peatio.git","clone_url":"https://github.com/skyach/peatio.git","svn_url":"https://github.com/skyach/peatio","homepage":"https://peatio.tech","size":8041,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rubykube:1-8-stable","ref":"1-8-stable","sha":"9b81df496f9ef84d510a23684c0edba2808aeb9e","user":{"login":"rubykube","id":29372474,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MzcyNDc0","avatar_url":"https://avatars2.githubusercontent.com/u/29372474?v=4","gravatar_id":"","url":"https://api.github.com/users/rubykube","html_url":"https://github.com/rubykube","followers_url":"https://api.github.com/users/rubykube/followers","following_url":"https://api.github.com/users/rubykube/following{/other_user}","gists_url":"https://api.github.com/users/rubykube/gists{/gist_id}","starred_url":"https://api.github.com/users/rubykube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubykube/subscriptions","organizations_url":"https://api.github.com/users/rubykube/orgs","repos_url":"https://api.github.com/users/rubykube/repos","events_url":"https://api.github.com/users/rubykube/events{/privacy}","received_events_url":"https://api.github.com/users/rubykube/received_events","type":"Organization","site_admin":false},"repo":{"id":103532367,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM1MzIzNjc=","name":"peatio","full_name":"rubykube/peatio","owner":{"login":"rubykube","id":29372474,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MzcyNDc0","avatar_url":"https://avatars2.githubusercontent.com/u/29372474?v=4","gravatar_id":"","url":"https://api.github.com/users/rubykube","html_url":"https://github.com/rubykube","followers_url":"https://api.github.com/users/rubykube/followers","following_url":"https://api.github.com/users/rubykube/following{/other_user}","gists_url":"https://api.github.com/users/rubykube/gists{/gist_id}","starred_url":"https://api.github.com/users/rubykube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubykube/subscriptions","organizations_url":"https://api.github.com/users/rubykube/orgs","repos_url":"https://api.github.com/users/rubykube/repos","events_url":"https://api.github.com/users/rubykube/events{/privacy}","received_events_url":"https://api.github.com/users/rubykube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rubykube/peatio","description":"An open-source Crypto-Currency exchange.","fork":true,"url":"https://api.github.com/repos/rubykube/peatio","forks_url":"https://api.github.com/repos/rubykube/peatio/forks","keys_url":"https://api.github.com/repos/rubykube/peatio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubykube/peatio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubykube/peatio/teams","hooks_url":"https://api.github.com/repos/rubykube/peatio/hooks","issue_events_url":"https://api.github.com/repos/rubykube/peatio/issues/events{/number}","events_url":"https://api.github.com/repos/rubykube/peatio/events","assignees_url":"https://api.github.com/repos/rubykube/peatio/assignees{/user}","branches_url":"https://api.github.com/repos/rubykube/peatio/branches{/branch}","tags_url":"https://api.github.com/repos/rubykube/peatio/tags","blobs_url":"https://api.github.com/repos/rubykube/peatio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubykube/peatio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubykube/peatio/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubykube/peatio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubykube/peatio/statuses/{sha}","languages_url":"https://api.github.com/repos/rubykube/peatio/languages","stargazers_url":"https://api.github.com/repos/rubykube/peatio/stargazers","contributors_url":"https://api.github.com/repos/rubykube/peatio/contributors","subscribers_url":"https://api.github.com/repos/rubykube/peatio/subscribers","subscription_url":"https://api.github.com/repos/rubykube/peatio/subscription","commits_url":"https://api.github.com/repos/rubykube/peatio/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubykube/peatio/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubykube/peatio/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubykube/peatio/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubykube/peatio/contents/{+path}","compare_url":"https://api.github.com/repos/rubykube/peatio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubykube/peatio/merges","archive_url":"https://api.github.com/repos/rubykube/peatio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubykube/peatio/downloads","issues_url":"https://api.github.com/repos/rubykube/peatio/issues{/number}","pulls_url":"https://api.github.com/repos/rubykube/peatio/pulls{/number}","milestones_url":"https://api.github.com/repos/rubykube/peatio/milestones{/number}","notifications_url":"https://api.github.com/repos/rubykube/peatio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubykube/peatio/labels{/name}","releases_url":"https://api.github.com/repos/rubykube/peatio/releases{/id}","deployments_url":"https://api.github.com/repos/rubykube/peatio/deployments","created_at":"2017-09-14T12:57:42Z","updated_at":"2018-06-20T06:23:20Z","pushed_at":"2018-06-20T08:17:57Z","git_url":"git://github.com/rubykube/peatio.git","ssh_url":"git@github.com:rubykube/peatio.git","clone_url":"https://github.com/rubykube/peatio.git","svn_url":"https://github.com/rubykube/peatio","homepage":"https://www.peatio.tech","size":7973,"stargazers_count":244,"watchers_count":244,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":179,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":179,"open_issues":39,"watchers":244,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rubykube/peatio/pulls/1328"},"html":{"href":"https://github.com/rubykube/peatio/pull/1328"},"issue":{"href":"https://api.github.com/repos/rubykube/peatio/issues/1328"},"comments":{"href":"https://api.github.com/repos/rubykube/peatio/issues/1328/comments"},"review_comments":{"href":"https://api.github.com/repos/rubykube/peatio/pulls/1328/comments"},"review_comment":{"href":"https://api.github.com/repos/rubykube/peatio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rubykube/peatio/pulls/1328/commits"},"statuses":{"href":"https://api.github.com/repos/rubykube/peatio/statuses/345cffb8a44eaee1214d64e96806319e814e4ff2"}},"author_association":"NONE"}}
{"actor":{"display_login":"mod"}}