{"action":"created","comment":{"url":"https://api.github.com/repos/dlang/phobos/pulls/comments/167005228","pull_request_review_id":95157824,"id":167005228,"diff_hunk":"@@ -649,7 +649,7 @@ struct RIPEMD160\n                     \"1234567890123456789012345678901234567890\");\n     assert(digest == cast(ubyte[]) hexString!\"9b752e45573d4b39f4dbd3323cab82bf63326bfb\");\n \n-    enum ubyte[20] input = hexString!\"f71c27109c692c1b56bbdceb5b9d2865b3708dbc\";\n+    enum ubyte[20] input = cast(ubyte[20]) hexString!\"f71c27109c692c1b56bbdceb5b9d2865b3708dbc\";","path":"std/digest/ripemd.d","position":5,"original_position":5,"commit_id":"1dd1ebc3db4138f899f9526a01df407ec809654d","original_commit_id":"1dd1ebc3db4138f899f9526a01df407ec809654d","user":{"login":"carun","id":471374,"avatar_url":"https://avatars3.githubusercontent.com/u/471374?v=4","gravatar_id":"","url":"https://api.github.com/users/carun","html_url":"https://github.com/carun","followers_url":"https://api.github.com/users/carun/followers","following_url":"https://api.github.com/users/carun/following{/other_user}","gists_url":"https://api.github.com/users/carun/gists{/gist_id}","starred_url":"https://api.github.com/users/carun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carun/subscriptions","organizations_url":"https://api.github.com/users/carun/orgs","repos_url":"https://api.github.com/users/carun/repos","events_url":"https://api.github.com/users/carun/events{/privacy}","received_events_url":"https://api.github.com/users/carun/received_events","type":"User","site_admin":false},"body":"Just wondering if it is mandatory to use `enum ubyte[16] input`? `auto input` would look idiomatic.","created_at":"2018-02-08T17:14:12Z","updated_at":"2018-02-08T17:14:13Z","html_url":"https://github.com/dlang/phobos/pull/6138#discussion_r167005228","pull_request_url":"https://api.github.com/repos/dlang/phobos/pulls/6138","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dlang/phobos/pulls/comments/167005228"},"html":{"href":"https://github.com/dlang/phobos/pull/6138#discussion_r167005228"},"pull_request":{"href":"https://api.github.com/repos/dlang/phobos/pulls/6138"}}},"pull_request":{"url":"https://api.github.com/repos/dlang/phobos/pulls/6138","id":167868564,"html_url":"https://github.com/dlang/phobos/pull/6138","diff_url":"https://github.com/dlang/phobos/pull/6138.diff","patch_url":"https://github.com/dlang/phobos/pull/6138.patch","issue_url":"https://api.github.com/repos/dlang/phobos/issues/6138","number":6138,"state":"open","locked":false,"title":"fix Issue 18397 - Poor implementation of std.conv.hexString results i…","user":{"login":"WalterBright","id":568298,"avatar_url":"https://avatars0.githubusercontent.com/u/568298?v=4","gravatar_id":"","url":"https://api.github.com/users/WalterBright","html_url":"https://github.com/WalterBright","followers_url":"https://api.github.com/users/WalterBright/followers","following_url":"https://api.github.com/users/WalterBright/following{/other_user}","gists_url":"https://api.github.com/users/WalterBright/gists{/gist_id}","starred_url":"https://api.github.com/users/WalterBright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WalterBright/subscriptions","organizations_url":"https://api.github.com/users/WalterBright/orgs","repos_url":"https://api.github.com/users/WalterBright/repos","events_url":"https://api.github.com/users/WalterBright/events{/privacy}","received_events_url":"https://api.github.com/users/WalterBright/received_events","type":"User","site_admin":false},"body":"…n unintended bloat\r\n\r\nThe trick is to make it an enum, use a mixin string literal rather than an array, and instantiate the template in std.conv rather than in user code.\r\n\r\nFor:\r\n```\r\nimport std.conv;\r\nvoid test() {\r\n    auto data = cast(ubyte[]) hexString!\"deadbeef\";\r\n}\r\n```\r\nnow compiles to:\r\n```\r\n___a4_deadbeef\tcomdat\r\n\tdb\t0deh,0adh,0beh,0efh,000h\t;.....\r\n___a4_deadbeef\tends\r\n_D5test24testFZv\tcomdat\r\n\tassume\tCS:_D5test24testFZv\r\n\t\tmov\tECX,offset FLAT:___a4_deadbeef\r\n\t\tmov\tEAX,4\r\n\t\tret\r\n_D5test24testFZv\tends\r\n```\r\ninstead of the hundreds of bytes of code it used to.","created_at":"2018-02-08T03:25:44Z","updated_at":"2018-02-08T17:14:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"960f60a1e043c08fba1c8dfad16f179e28e409e0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"JackStouffer","id":680068,"avatar_url":"https://avatars0.githubusercontent.com/u/680068?v=4","gravatar_id":"","url":"https://api.github.com/users/JackStouffer","html_url":"https://github.com/JackStouffer","followers_url":"https://api.github.com/users/JackStouffer/followers","following_url":"https://api.github.com/users/JackStouffer/following{/other_user}","gists_url":"https://api.github.com/users/JackStouffer/gists{/gist_id}","starred_url":"https://api.github.com/users/JackStouffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JackStouffer/subscriptions","organizations_url":"https://api.github.com/users/JackStouffer/orgs","repos_url":"https://api.github.com/users/JackStouffer/repos","events_url":"https://api.github.com/users/JackStouffer/events{/privacy}","received_events_url":"https://api.github.com/users/JackStouffer/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/dlang/phobos/pulls/6138/commits","review_comments_url":"https://api.github.com/repos/dlang/phobos/pulls/6138/comments","review_comment_url":"https://api.github.com/repos/dlang/phobos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/phobos/issues/6138/comments","statuses_url":"https://api.github.com/repos/dlang/phobos/statuses/1dd1ebc3db4138f899f9526a01df407ec809654d","head":{"label":"WalterBright:fix18397","ref":"fix18397","sha":"1dd1ebc3db4138f899f9526a01df407ec809654d","user":{"login":"WalterBright","id":568298,"avatar_url":"https://avatars0.githubusercontent.com/u/568298?v=4","gravatar_id":"","url":"https://api.github.com/users/WalterBright","html_url":"https://github.com/WalterBright","followers_url":"https://api.github.com/users/WalterBright/followers","following_url":"https://api.github.com/users/WalterBright/following{/other_user}","gists_url":"https://api.github.com/users/WalterBright/gists{/gist_id}","starred_url":"https://api.github.com/users/WalterBright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WalterBright/subscriptions","organizations_url":"https://api.github.com/users/WalterBright/orgs","repos_url":"https://api.github.com/users/WalterBright/repos","events_url":"https://api.github.com/users/WalterBright/events{/privacy}","received_events_url":"https://api.github.com/users/WalterBright/received_events","type":"User","site_admin":false},"repo":{"id":7236335,"name":"phobos","full_name":"WalterBright/phobos","owner":{"login":"WalterBright","id":568298,"avatar_url":"https://avatars0.githubusercontent.com/u/568298?v=4","gravatar_id":"","url":"https://api.github.com/users/WalterBright","html_url":"https://github.com/WalterBright","followers_url":"https://api.github.com/users/WalterBright/followers","following_url":"https://api.github.com/users/WalterBright/following{/other_user}","gists_url":"https://api.github.com/users/WalterBright/gists{/gist_id}","starred_url":"https://api.github.com/users/WalterBright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WalterBright/subscriptions","organizations_url":"https://api.github.com/users/WalterBright/orgs","repos_url":"https://api.github.com/users/WalterBright/repos","events_url":"https://api.github.com/users/WalterBright/events{/privacy}","received_events_url":"https://api.github.com/users/WalterBright/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WalterBright/phobos","description":"The standard library of the D programming language","fork":true,"url":"https://api.github.com/repos/WalterBright/phobos","forks_url":"https://api.github.com/repos/WalterBright/phobos/forks","keys_url":"https://api.github.com/repos/WalterBright/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WalterBright/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WalterBright/phobos/teams","hooks_url":"https://api.github.com/repos/WalterBright/phobos/hooks","issue_events_url":"https://api.github.com/repos/WalterBright/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/WalterBright/phobos/events","assignees_url":"https://api.github.com/repos/WalterBright/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/WalterBright/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/WalterBright/phobos/tags","blobs_url":"https://api.github.com/repos/WalterBright/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WalterBright/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WalterBright/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/WalterBright/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WalterBright/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/WalterBright/phobos/languages","stargazers_url":"https://api.github.com/repos/WalterBright/phobos/stargazers","contributors_url":"https://api.github.com/repos/WalterBright/phobos/contributors","subscribers_url":"https://api.github.com/repos/WalterBright/phobos/subscribers","subscription_url":"https://api.github.com/repos/WalterBright/phobos/subscription","commits_url":"https://api.github.com/repos/WalterBright/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/WalterBright/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/WalterBright/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/WalterBright/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/WalterBright/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/WalterBright/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WalterBright/phobos/merges","archive_url":"https://api.github.com/repos/WalterBright/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WalterBright/phobos/downloads","issues_url":"https://api.github.com/repos/WalterBright/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/WalterBright/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/WalterBright/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/WalterBright/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WalterBright/phobos/labels{/name}","releases_url":"https://api.github.com/repos/WalterBright/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/WalterBright/phobos/deployments","created_at":"2012-12-19T06:55:07Z","updated_at":"2016-12-14T10:46:54Z","pushed_at":"2018-02-08T04:21:16Z","git_url":"git://github.com/WalterBright/phobos.git","ssh_url":"git@github.com:WalterBright/phobos.git","clone_url":"https://github.com/WalterBright/phobos.git","svn_url":"https://github.com/WalterBright/phobos","homepage":"dlang.org/phobos","size":47341,"stargazers_count":3,"watchers_count":3,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"9087e479618a2ad75960569cabfa75ce09255fd7","user":{"login":"dlang","id":565913,"avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257084,"name":"phobos","full_name":"dlang/phobos","owner":{"login":"dlang","id":565913,"avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dlang/phobos","description":"The standard library of the D programming language","fork":false,"url":"https://api.github.com/repos/dlang/phobos","forks_url":"https://api.github.com/repos/dlang/phobos/forks","keys_url":"https://api.github.com/repos/dlang/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/phobos/teams","hooks_url":"https://api.github.com/repos/dlang/phobos/hooks","issue_events_url":"https://api.github.com/repos/dlang/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/phobos/events","assignees_url":"https://api.github.com/repos/dlang/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/phobos/tags","blobs_url":"https://api.github.com/repos/dlang/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/phobos/languages","stargazers_url":"https://api.github.com/repos/dlang/phobos/stargazers","contributors_url":"https://api.github.com/repos/dlang/phobos/contributors","subscribers_url":"https://api.github.com/repos/dlang/phobos/subscribers","subscription_url":"https://api.github.com/repos/dlang/phobos/subscription","commits_url":"https://api.github.com/repos/dlang/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/phobos/merges","archive_url":"https://api.github.com/repos/dlang/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/phobos/downloads","issues_url":"https://api.github.com/repos/dlang/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/phobos/labels{/name}","releases_url":"https://api.github.com/repos/dlang/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/phobos/deployments","created_at":"2011-01-15T07:00:06Z","updated_at":"2018-01-31T22:13:50Z","pushed_at":"2018-02-08T16:43:56Z","git_url":"git://github.com/dlang/phobos.git","ssh_url":"git@github.com:dlang/phobos.git","clone_url":"https://github.com/dlang/phobos.git","svn_url":"https://github.com/dlang/phobos","homepage":"dlang.org/phobos","size":46852,"stargazers_count":863,"watchers_count":863,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":584,"mirror_url":null,"archived":false,"open_issues_count":100,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0"},"forks":584,"open_issues":100,"watchers":863,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/phobos/pulls/6138"},"html":{"href":"https://github.com/dlang/phobos/pull/6138"},"issue":{"href":"https://api.github.com/repos/dlang/phobos/issues/6138"},"comments":{"href":"https://api.github.com/repos/dlang/phobos/issues/6138/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/phobos/pulls/6138/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/phobos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/phobos/pulls/6138/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/phobos/statuses/1dd1ebc3db4138f899f9526a01df407ec809654d"}},"author_association":"OWNER"}}
{"actor":{"display_login":"carun"}}