{"action":"created","issue":{"url":"https://api.github.com/repos/istio/proxy/issues/2013","repository_url":"https://api.github.com/repos/istio/proxy","labels_url":"https://api.github.com/repos/istio/proxy/issues/2013/labels{/name}","comments_url":"https://api.github.com/repos/istio/proxy/issues/2013/comments","events_url":"https://api.github.com/repos/istio/proxy/issues/2013/events","html_url":"https://github.com/istio/proxy/pull/2013","id":375711151,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MDk1NTQz","number":2013,"title":"Send dynamic metadata as part of report calls","user":{"login":"rshriram","id":8202871,"node_id":"MDQ6VXNlcjgyMDI4NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/8202871?v=4","gravatar_id":"","url":"https://api.github.com/users/rshriram","html_url":"https://github.com/rshriram","followers_url":"https://api.github.com/users/rshriram/followers","following_url":"https://api.github.com/users/rshriram/following{/other_user}","gists_url":"https://api.github.com/users/rshriram/gists{/gist_id}","starred_url":"https://api.github.com/users/rshriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshriram/subscriptions","organizations_url":"https://api.github.com/users/rshriram/orgs","repos_url":"https://api.github.com/users/rshriram/repos","events_url":"https://api.github.com/users/rshriram/events{/privacy}","received_events_url":"https://api.github.com/users/rshriram/received_events","type":"User","site_admin":false},"labels":[{"id":712050392,"node_id":"MDU6TGFiZWw3MTIwNTAzOTI=","url":"https://api.github.com/repos/istio/proxy/labels/cla:%20yes","name":"cla: yes","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-10-30T21:58:10Z","updated_at":"2018-10-30T23:19:06Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/istio/proxy/pulls/2013","html_url":"https://github.com/istio/proxy/pull/2013","diff_url":"https://github.com/istio/proxy/pull/2013.diff","patch_url":"https://github.com/istio/proxy/pull/2013.patch"},"body":"Envoy filters can add arbitrary attributes to dynamicMetadata. Its useful to log this as part of reports (envoy's gRPC access logs and normal access logs already print this info).\r\n\r\nI am send the metadata as a dumb string (serialized form of envoy.api.v2.core.Metadata). Right now, there is no support in mixer for this, but an adapter wishing to utilize this can deserialize this info and log this info, thus providing the ability for third party codecs to log additional attributes as part of a connection.\r\n\r\nSigned-off-by: Shriram Rajagopalan <shriramr@vmware.com>"},"comment":{"url":"https://api.github.com/repos/istio/proxy/issues/comments/434505588","html_url":"https://github.com/istio/proxy/pull/2013#issuecomment-434505588","issue_url":"https://api.github.com/repos/istio/proxy/issues/2013","id":434505588,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDUwNTU4OA==","user":{"login":"istio-testing","id":25311884,"node_id":"MDQ6VXNlcjI1MzExODg0","avatar_url":"https://avatars1.githubusercontent.com/u/25311884?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-testing","html_url":"https://github.com/istio-testing","followers_url":"https://api.github.com/users/istio-testing/followers","following_url":"https://api.github.com/users/istio-testing/following{/other_user}","gists_url":"https://api.github.com/users/istio-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-testing/subscriptions","organizations_url":"https://api.github.com/users/istio-testing/orgs","repos_url":"https://api.github.com/users/istio-testing/repos","events_url":"https://api.github.com/users/istio-testing/events{/privacy}","received_events_url":"https://api.github.com/users/istio-testing/received_events","type":"User","site_admin":false},"created_at":"2018-10-30T23:19:06Z","updated_at":"2018-10-30T23:19:06Z","author_association":"COLLABORATOR","body":"@rshriram: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nprow/proxy-presubmit.sh | 65216a1689fd5f5e1b72ac5b1637e9ceea902423 | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_proxy/2013/proxy-presubmit/2271/) | `/test proxy-presubmit`\n\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"istio-testing"}}