{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/5878","repository_url":"https://api.github.com/repos/Microsoft/visualfsharp","labels_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/5878/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/5878/comments","events_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/5878/events","html_url":"https://github.com/Microsoft/visualfsharp/pull/5878","id":378794300,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NDEzNjE5","number":5878,"title":"Add F#+ to the test suite","user":{"login":"realvictorprm","id":25414896,"node_id":"MDQ6VXNlcjI1NDE0ODk2","avatar_url":"https://avatars1.githubusercontent.com/u/25414896?v=4","gravatar_id":"","url":"https://api.github.com/users/realvictorprm","html_url":"https://github.com/realvictorprm","followers_url":"https://api.github.com/users/realvictorprm/followers","following_url":"https://api.github.com/users/realvictorprm/following{/other_user}","gists_url":"https://api.github.com/users/realvictorprm/gists{/gist_id}","starred_url":"https://api.github.com/users/realvictorprm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realvictorprm/subscriptions","organizations_url":"https://api.github.com/users/realvictorprm/orgs","repos_url":"https://api.github.com/users/realvictorprm/repos","events_url":"https://api.github.com/users/realvictorprm/events{/privacy}","received_events_url":"https://api.github.com/users/realvictorprm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":21,"created_at":"2018-11-08T15:52:40Z","updated_at":"2018-11-27T09:33:31Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/5878","html_url":"https://github.com/Microsoft/visualfsharp/pull/5878","diff_url":"https://github.com/Microsoft/visualfsharp/pull/5878.diff","patch_url":"https://github.com/Microsoft/visualfsharp/pull/5878.patch"},"body":"As discussed in https://github.com/Microsoft/visualfsharp/issues/3814#issuecomment-433622188 this PR adds the build of F#+ to the test suit.\r\n\r\nLeft points are:\r\n- [x] Reference correct commit of F#+\r\n- [x] Run F#+ tests too\r\n\r\nThe changes include:\r\n\r\n- The Git exe is retrieved from the Path environment variable\r\n- A new directory `./tests/fsharp/repos/` is created.\r\n- F#+ is cloned to this directory and reset to a specific commit\r\n- Build of F#+.fsproj\r\n\r\nSigned-off-by: realvictorprm <mueller.vpr@gmail.com>"},"comment":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/comments/441989980","html_url":"https://github.com/Microsoft/visualfsharp/pull/5878#issuecomment-441989980","issue_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/5878","id":441989980,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTk4OTk4MA==","user":{"login":"dsyme","id":7204669,"node_id":"MDQ6VXNlcjcyMDQ2Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/7204669?v=4","gravatar_id":"","url":"https://api.github.com/users/dsyme","html_url":"https://github.com/dsyme","followers_url":"https://api.github.com/users/dsyme/followers","following_url":"https://api.github.com/users/dsyme/following{/other_user}","gists_url":"https://api.github.com/users/dsyme/gists{/gist_id}","starred_url":"https://api.github.com/users/dsyme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsyme/subscriptions","organizations_url":"https://api.github.com/users/dsyme/orgs","repos_url":"https://api.github.com/users/dsyme/repos","events_url":"https://api.github.com/users/dsyme/events{/privacy}","received_events_url":"https://api.github.com/users/dsyme/received_events","type":"User","site_admin":false},"created_at":"2018-11-27T09:33:31Z","updated_at":"2018-11-27T09:33:31Z","author_association":"CONTRIBUTOR","body":"@cartermp Yes the testing is against a specific commit. \r\n\r\nCompiling and running the F#+ tests would for me be a requirement for any future change in SRTP. We may as well automate it. \r\n\r\nIt is simply critical to know when we are breaking existing code early rather than late. \r\n\r\nIf we'd been doing this for a few other repos too we would have saved ourselves months of handling regressions. \r\n\r\nLet's embrace this. We build and test SAFE stack nightly don't we? \r\n"}}
{"actor":{"display_login":"dsyme"}}