{"action":"created","comment":{"url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/pulls/comments/241423841","pull_request_review_id":184684848,"id":241423841,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTQyMzg0MQ==","diff_hunk":"@@ -85,8 +85,14 @@ describe('ReviewSubmitComponent', () => {\n       loadSupportedDeliveryModes: createSpy()\n     };\n     mockCartService = {\n-      activeCart$: new BehaviorSubject(null),\n-      entries$: new BehaviorSubject(null)\n+      cart$: new BehaviorSubject(null),\n+      entries$: new BehaviorSubject(null),\n+      getActiveCart(): BehaviorSubject<null> {","path":"projects/storefrontlib/src/lib/checkout/components/multi-step-checkout/review-submit/review-submit.component.spec.ts","position":8,"original_position":8,"commit_id":"2cd338bf664c3059289a070c9fe58c9a243b92d0","original_commit_id":"c6dc50c3688dbc5a29fcc5a46c3fea27212673d1","user":{"login":"znikola","id":11561723,"node_id":"MDQ6VXNlcjExNTYxNzIz","avatar_url":"https://avatars2.githubusercontent.com/u/11561723?v=4","gravatar_id":"","url":"https://api.github.com/users/znikola","html_url":"https://github.com/znikola","followers_url":"https://api.github.com/users/znikola/followers","following_url":"https://api.github.com/users/znikola/following{/other_user}","gists_url":"https://api.github.com/users/znikola/gists{/gist_id}","starred_url":"https://api.github.com/users/znikola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/znikola/subscriptions","organizations_url":"https://api.github.com/users/znikola/orgs","repos_url":"https://api.github.com/users/znikola/repos","events_url":"https://api.github.com/users/znikola/events{/privacy}","received_events_url":"https://api.github.com/users/znikola/received_events","type":"User","site_admin":false},"body":"Just use the same type as in the real service.","created_at":"2018-12-13T14:41:19Z","updated_at":"2018-12-13T14:41:20Z","html_url":"https://github.com/SAP/cloud-commerce-spartacus-storefront/pull/562#discussion_r241423841","pull_request_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/pulls/562","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/pulls/comments/241423841"},"html":{"href":"https://github.com/SAP/cloud-commerce-spartacus-storefront/pull/562#discussion_r241423841"},"pull_request":{"href":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/pulls/562"}},"in_reply_to_id":241040094},"pull_request":{"url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/pulls/562","id":236672407,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NjcyNDA3","html_url":"https://github.com/SAP/cloud-commerce-spartacus-storefront/pull/562","diff_url":"https://github.com/SAP/cloud-commerce-spartacus-storefront/pull/562.diff","patch_url":"https://github.com/SAP/cloud-commerce-spartacus-storefront/pull/562.patch","issue_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/issues/562","number":562,"state":"open","locked":false,"title":"GH-461: Cart module: refactor public accessors","user":{"login":"Jim-Yang","id":9470994,"node_id":"MDQ6VXNlcjk0NzA5OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9470994?v=4","gravatar_id":"","url":"https://api.github.com/users/Jim-Yang","html_url":"https://github.com/Jim-Yang","followers_url":"https://api.github.com/users/Jim-Yang/followers","following_url":"https://api.github.com/users/Jim-Yang/following{/other_user}","gists_url":"https://api.github.com/users/Jim-Yang/gists{/gist_id}","starred_url":"https://api.github.com/users/Jim-Yang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jim-Yang/subscriptions","organizations_url":"https://api.github.com/users/Jim-Yang/orgs","repos_url":"https://api.github.com/users/Jim-Yang/repos","events_url":"https://api.github.com/users/Jim-Yang/events{/privacy}","received_events_url":"https://api.github.com/users/Jim-Yang/received_events","type":"User","site_admin":false},"body":"fixes: gh-461","created_at":"2018-12-06T21:07:26Z","updated_at":"2018-12-13T14:41:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"386a1dffeee30149be60ccf636eea64ca6eb6c1b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/pulls/562/commits","review_comments_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/pulls/562/comments","review_comment_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/issues/562/comments","statuses_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/statuses/2cd338bf664c3059289a070c9fe58c9a243b92d0","head":{"label":"SAP:feature/GH-461","ref":"feature/GH-461","sha":"2cd338bf664c3059289a070c9fe58c9a243b92d0","user":{"login":"SAP","id":2531208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzEyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"repo":{"id":149351199,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkzNTExOTk=","name":"cloud-commerce-spartacus-storefront","full_name":"SAP/cloud-commerce-spartacus-storefront","private":false,"owner":{"login":"SAP","id":2531208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzEyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SAP/cloud-commerce-spartacus-storefront","description":"Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.","fork":false,"url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront","forks_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/forks","keys_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/teams","hooks_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/hooks","issue_events_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/issues/events{/number}","events_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/events","assignees_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/assignees{/user}","branches_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/branches{/branch}","tags_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/tags","blobs_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/git/refs{/sha}","trees_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/statuses/{sha}","languages_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/languages","stargazers_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/stargazers","contributors_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/contributors","subscribers_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/subscribers","subscription_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/subscription","commits_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/commits{/sha}","git_commits_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/git/commits{/sha}","comments_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/comments{/number}","issue_comment_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/issues/comments{/number}","contents_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/contents/{+path}","compare_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/merges","archive_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/downloads","issues_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/issues{/number}","pulls_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/pulls{/number}","milestones_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/milestones{/number}","notifications_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/labels{/name}","releases_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/releases{/id}","deployments_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/deployments","created_at":"2018-09-18T20:56:49Z","updated_at":"2018-12-13T14:40:20Z","pushed_at":"2018-12-13T14:40:19Z","git_url":"git://github.com/SAP/cloud-commerce-spartacus-storefront.git","ssh_url":"git@github.com:SAP/cloud-commerce-spartacus-storefront.git","clone_url":"https://github.com/SAP/cloud-commerce-spartacus-storefront.git","svn_url":"https://github.com/SAP/cloud-commerce-spartacus-storefront","homepage":"","size":14155,"stargazers_count":90,"watchers_count":90,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":300,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":25,"open_issues":300,"watchers":90,"default_branch":"develop"}},"base":{"label":"SAP:develop","ref":"develop","sha":"8ec1400bbf26afb4a50ee3788c407303c9ad721c","user":{"login":"SAP","id":2531208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzEyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"repo":{"id":149351199,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkzNTExOTk=","name":"cloud-commerce-spartacus-storefront","full_name":"SAP/cloud-commerce-spartacus-storefront","private":false,"owner":{"login":"SAP","id":2531208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzEyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SAP/cloud-commerce-spartacus-storefront","description":"Spartacus is a lean, Angular-based JavaScript storefront for SAP Commerce Cloud that communicates exclusively through the Commerce REST API.","fork":false,"url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront","forks_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/forks","keys_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/teams","hooks_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/hooks","issue_events_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/issues/events{/number}","events_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/events","assignees_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/assignees{/user}","branches_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/branches{/branch}","tags_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/tags","blobs_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/git/refs{/sha}","trees_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/statuses/{sha}","languages_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/languages","stargazers_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/stargazers","contributors_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/contributors","subscribers_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/subscribers","subscription_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/subscription","commits_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/commits{/sha}","git_commits_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/git/commits{/sha}","comments_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/comments{/number}","issue_comment_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/issues/comments{/number}","contents_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/contents/{+path}","compare_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/merges","archive_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/downloads","issues_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/issues{/number}","pulls_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/pulls{/number}","milestones_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/milestones{/number}","notifications_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/labels{/name}","releases_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/releases{/id}","deployments_url":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/deployments","created_at":"2018-09-18T20:56:49Z","updated_at":"2018-12-13T14:40:20Z","pushed_at":"2018-12-13T14:40:19Z","git_url":"git://github.com/SAP/cloud-commerce-spartacus-storefront.git","ssh_url":"git@github.com:SAP/cloud-commerce-spartacus-storefront.git","clone_url":"https://github.com/SAP/cloud-commerce-spartacus-storefront.git","svn_url":"https://github.com/SAP/cloud-commerce-spartacus-storefront","homepage":"","size":14155,"stargazers_count":90,"watchers_count":90,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":300,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":25,"open_issues":300,"watchers":90,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/pulls/562"},"html":{"href":"https://github.com/SAP/cloud-commerce-spartacus-storefront/pull/562"},"issue":{"href":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/issues/562"},"comments":{"href":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/issues/562/comments"},"review_comments":{"href":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/pulls/562/comments"},"review_comment":{"href":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/pulls/562/commits"},"statuses":{"href":"https://api.github.com/repos/SAP/cloud-commerce-spartacus-storefront/statuses/2cd338bf664c3059289a070c9fe58c9a243b92d0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"znikola"}}