{"action":"closed","number":4845,"pull_request":{"url":"https://api.github.com/repos/fossasia/open-event-server/pulls/4845","id":192293290,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMjkzMjkw","html_url":"https://github.com/fossasia/open-event-server/pull/4845","diff_url":"https://github.com/fossasia/open-event-server/pull/4845.diff","patch_url":"https://github.com/fossasia/open-event-server/pull/4845.patch","issue_url":"https://api.github.com/repos/fossasia/open-event-server/issues/4845","number":4845,"state":"closed","locked":false,"title":"fix: Access codes: raise exception only when min qty, valid-from are strictly greater","user":{"login":"mishuvs","id":35009811,"node_id":"MDQ6VXNlcjM1MDA5ODEx","avatar_url":"https://avatars3.githubusercontent.com/u/35009811?v=4","gravatar_id":"","url":"https://api.github.com/users/mishuvs","html_url":"https://github.com/mishuvs","followers_url":"https://api.github.com/users/mishuvs/followers","following_url":"https://api.github.com/users/mishuvs/following{/other_user}","gists_url":"https://api.github.com/users/mishuvs/gists{/gist_id}","starred_url":"https://api.github.com/users/mishuvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishuvs/subscriptions","organizations_url":"https://api.github.com/users/mishuvs/orgs","repos_url":"https://api.github.com/users/mishuvs/repos","events_url":"https://api.github.com/users/mishuvs/events{/privacy}","received_events_url":"https://api.github.com/users/mishuvs/received_events","type":"User","site_admin":false},"body":"Fixes #4844 \r\n\r\n#### Checklist\r\n\r\n- [x] I have read the [Contribution & Best practices Guide](https://blog.fossasia.org/open-source-developer-guide-and-best-practices-at-fossasia) and my PR follows them.\r\n- [x] My branch is up-to-date with the Upstream `development` branch.\r\n- [ ] The unit tests pass locally with my changes <!-- use `nosetests tests/unittests` to run all the tests -->\r\n- [ ] I have added tests that prove my fix is effective or that my feature works\r\n- [ ] I have added necessary documentation (if appropriate)\r\n<!-- If an existing function does not have a docstring, please add one -->\r\n- [ ] All the functions created/modified in this PR contain relevant docstrings.\r\n\r\n#### Short description of what this resolves:\r\nFixes #4844 Access codes returns HTTP 422 when max and min quantity is equal\r\n\r\n#### Changes proposed in this pull request:\r\n- Unprocessable Entitiy Exception is now raised only when min qty is strictly greater than max qty, and when valid-from is strictly after valid-till","created_at":"2018-06-04T04:11:54Z","updated_at":"2018-06-09T09:54:28Z","closed_at":"2018-06-09T09:54:28Z","merged_at":"2018-06-09T09:54:27Z","merge_commit_sha":"fc8f6a61734c42aa843d131bb0f46de08487fa0f","assignee":{"login":"mishuvs","id":35009811,"node_id":"MDQ6VXNlcjM1MDA5ODEx","avatar_url":"https://avatars3.githubusercontent.com/u/35009811?v=4","gravatar_id":"","url":"https://api.github.com/users/mishuvs","html_url":"https://github.com/mishuvs","followers_url":"https://api.github.com/users/mishuvs/followers","following_url":"https://api.github.com/users/mishuvs/following{/other_user}","gists_url":"https://api.github.com/users/mishuvs/gists{/gist_id}","starred_url":"https://api.github.com/users/mishuvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishuvs/subscriptions","organizations_url":"https://api.github.com/users/mishuvs/orgs","repos_url":"https://api.github.com/users/mishuvs/repos","events_url":"https://api.github.com/users/mishuvs/events{/privacy}","received_events_url":"https://api.github.com/users/mishuvs/received_events","type":"User","site_admin":false},"assignees":[{"login":"mishuvs","id":35009811,"node_id":"MDQ6VXNlcjM1MDA5ODEx","avatar_url":"https://avatars3.githubusercontent.com/u/35009811?v=4","gravatar_id":"","url":"https://api.github.com/users/mishuvs","html_url":"https://github.com/mishuvs","followers_url":"https://api.github.com/users/mishuvs/followers","following_url":"https://api.github.com/users/mishuvs/following{/other_user}","gists_url":"https://api.github.com/users/mishuvs/gists{/gist_id}","starred_url":"https://api.github.com/users/mishuvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishuvs/subscriptions","organizations_url":"https://api.github.com/users/mishuvs/orgs","repos_url":"https://api.github.com/users/mishuvs/repos","events_url":"https://api.github.com/users/mishuvs/events{/privacy}","received_events_url":"https://api.github.com/users/mishuvs/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fossasia/open-event-server/pulls/4845/commits","review_comments_url":"https://api.github.com/repos/fossasia/open-event-server/pulls/4845/comments","review_comment_url":"https://api.github.com/repos/fossasia/open-event-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fossasia/open-event-server/issues/4845/comments","statuses_url":"https://api.github.com/repos/fossasia/open-event-server/statuses/96346eaa9ad3bf69d74d8b4e254e19801459b1a5","head":{"label":"mishuvs:minmax","ref":"minmax","sha":"96346eaa9ad3bf69d74d8b4e254e19801459b1a5","user":{"login":"mishuvs","id":35009811,"node_id":"MDQ6VXNlcjM1MDA5ODEx","avatar_url":"https://avatars3.githubusercontent.com/u/35009811?v=4","gravatar_id":"","url":"https://api.github.com/users/mishuvs","html_url":"https://github.com/mishuvs","followers_url":"https://api.github.com/users/mishuvs/followers","following_url":"https://api.github.com/users/mishuvs/following{/other_user}","gists_url":"https://api.github.com/users/mishuvs/gists{/gist_id}","starred_url":"https://api.github.com/users/mishuvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishuvs/subscriptions","organizations_url":"https://api.github.com/users/mishuvs/orgs","repos_url":"https://api.github.com/users/mishuvs/repos","events_url":"https://api.github.com/users/mishuvs/events{/privacy}","received_events_url":"https://api.github.com/users/mishuvs/received_events","type":"User","site_admin":false},"repo":{"id":125301428,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUzMDE0Mjg=","name":"open-event-server","full_name":"mishuvs/open-event-server","owner":{"login":"mishuvs","id":35009811,"node_id":"MDQ6VXNlcjM1MDA5ODEx","avatar_url":"https://avatars3.githubusercontent.com/u/35009811?v=4","gravatar_id":"","url":"https://api.github.com/users/mishuvs","html_url":"https://github.com/mishuvs","followers_url":"https://api.github.com/users/mishuvs/followers","following_url":"https://api.github.com/users/mishuvs/following{/other_user}","gists_url":"https://api.github.com/users/mishuvs/gists{/gist_id}","starred_url":"https://api.github.com/users/mishuvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mishuvs/subscriptions","organizations_url":"https://api.github.com/users/mishuvs/orgs","repos_url":"https://api.github.com/users/mishuvs/repos","events_url":"https://api.github.com/users/mishuvs/events{/privacy}","received_events_url":"https://api.github.com/users/mishuvs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mishuvs/open-event-server","description":"The Open Event Organizer Server to Manage Events","fork":true,"url":"https://api.github.com/repos/mishuvs/open-event-server","forks_url":"https://api.github.com/repos/mishuvs/open-event-server/forks","keys_url":"https://api.github.com/repos/mishuvs/open-event-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mishuvs/open-event-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mishuvs/open-event-server/teams","hooks_url":"https://api.github.com/repos/mishuvs/open-event-server/hooks","issue_events_url":"https://api.github.com/repos/mishuvs/open-event-server/issues/events{/number}","events_url":"https://api.github.com/repos/mishuvs/open-event-server/events","assignees_url":"https://api.github.com/repos/mishuvs/open-event-server/assignees{/user}","branches_url":"https://api.github.com/repos/mishuvs/open-event-server/branches{/branch}","tags_url":"https://api.github.com/repos/mishuvs/open-event-server/tags","blobs_url":"https://api.github.com/repos/mishuvs/open-event-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mishuvs/open-event-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mishuvs/open-event-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mishuvs/open-event-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mishuvs/open-event-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mishuvs/open-event-server/languages","stargazers_url":"https://api.github.com/repos/mishuvs/open-event-server/stargazers","contributors_url":"https://api.github.com/repos/mishuvs/open-event-server/contributors","subscribers_url":"https://api.github.com/repos/mishuvs/open-event-server/subscribers","subscription_url":"https://api.github.com/repos/mishuvs/open-event-server/subscription","commits_url":"https://api.github.com/repos/mishuvs/open-event-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mishuvs/open-event-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mishuvs/open-event-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mishuvs/open-event-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mishuvs/open-event-server/contents/{+path}","compare_url":"https://api.github.com/repos/mishuvs/open-event-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mishuvs/open-event-server/merges","archive_url":"https://api.github.com/repos/mishuvs/open-event-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mishuvs/open-event-server/downloads","issues_url":"https://api.github.com/repos/mishuvs/open-event-server/issues{/number}","pulls_url":"https://api.github.com/repos/mishuvs/open-event-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mishuvs/open-event-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mishuvs/open-event-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mishuvs/open-event-server/labels{/name}","releases_url":"https://api.github.com/repos/mishuvs/open-event-server/releases{/id}","deployments_url":"https://api.github.com/repos/mishuvs/open-event-server/deployments","created_at":"2018-03-15T02:27:56Z","updated_at":"2018-05-22T11:10:38Z","pushed_at":"2018-06-09T09:36:44Z","git_url":"git://github.com/mishuvs/open-event-server.git","ssh_url":"git@github.com:mishuvs/open-event-server.git","clone_url":"https://github.com/mishuvs/open-event-server.git","svn_url":"https://github.com/mishuvs/open-event-server","homepage":"http://open-event-api.herokuapp.com/","size":44402,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"fossasia:development","ref":"development","sha":"eeb4acc1b327beecd2377bf0865f0ffe9bfb691a","user":{"login":"fossasia","id":6295529,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyOTU1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/6295529?v=4","gravatar_id":"","url":"https://api.github.com/users/fossasia","html_url":"https://github.com/fossasia","followers_url":"https://api.github.com/users/fossasia/followers","following_url":"https://api.github.com/users/fossasia/following{/other_user}","gists_url":"https://api.github.com/users/fossasia/gists{/gist_id}","starred_url":"https://api.github.com/users/fossasia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fossasia/subscriptions","organizations_url":"https://api.github.com/users/fossasia/orgs","repos_url":"https://api.github.com/users/fossasia/repos","events_url":"https://api.github.com/users/fossasia/events{/privacy}","received_events_url":"https://api.github.com/users/fossasia/received_events","type":"Organization","site_admin":false},"repo":{"id":35270176,"node_id":"MDEwOlJlcG9zaXRvcnkzNTI3MDE3Ng==","name":"open-event-server","full_name":"fossasia/open-event-server","owner":{"login":"fossasia","id":6295529,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyOTU1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/6295529?v=4","gravatar_id":"","url":"https://api.github.com/users/fossasia","html_url":"https://github.com/fossasia","followers_url":"https://api.github.com/users/fossasia/followers","following_url":"https://api.github.com/users/fossasia/following{/other_user}","gists_url":"https://api.github.com/users/fossasia/gists{/gist_id}","starred_url":"https://api.github.com/users/fossasia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fossasia/subscriptions","organizations_url":"https://api.github.com/users/fossasia/orgs","repos_url":"https://api.github.com/users/fossasia/repos","events_url":"https://api.github.com/users/fossasia/events{/privacy}","received_events_url":"https://api.github.com/users/fossasia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fossasia/open-event-server","description":"The Open Event Organizer Server to Manage Events","fork":false,"url":"https://api.github.com/repos/fossasia/open-event-server","forks_url":"https://api.github.com/repos/fossasia/open-event-server/forks","keys_url":"https://api.github.com/repos/fossasia/open-event-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fossasia/open-event-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fossasia/open-event-server/teams","hooks_url":"https://api.github.com/repos/fossasia/open-event-server/hooks","issue_events_url":"https://api.github.com/repos/fossasia/open-event-server/issues/events{/number}","events_url":"https://api.github.com/repos/fossasia/open-event-server/events","assignees_url":"https://api.github.com/repos/fossasia/open-event-server/assignees{/user}","branches_url":"https://api.github.com/repos/fossasia/open-event-server/branches{/branch}","tags_url":"https://api.github.com/repos/fossasia/open-event-server/tags","blobs_url":"https://api.github.com/repos/fossasia/open-event-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fossasia/open-event-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fossasia/open-event-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/fossasia/open-event-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fossasia/open-event-server/statuses/{sha}","languages_url":"https://api.github.com/repos/fossasia/open-event-server/languages","stargazers_url":"https://api.github.com/repos/fossasia/open-event-server/stargazers","contributors_url":"https://api.github.com/repos/fossasia/open-event-server/contributors","subscribers_url":"https://api.github.com/repos/fossasia/open-event-server/subscribers","subscription_url":"https://api.github.com/repos/fossasia/open-event-server/subscription","commits_url":"https://api.github.com/repos/fossasia/open-event-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/fossasia/open-event-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/fossasia/open-event-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/fossasia/open-event-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/fossasia/open-event-server/contents/{+path}","compare_url":"https://api.github.com/repos/fossasia/open-event-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fossasia/open-event-server/merges","archive_url":"https://api.github.com/repos/fossasia/open-event-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fossasia/open-event-server/downloads","issues_url":"https://api.github.com/repos/fossasia/open-event-server/issues{/number}","pulls_url":"https://api.github.com/repos/fossasia/open-event-server/pulls{/number}","milestones_url":"https://api.github.com/repos/fossasia/open-event-server/milestones{/number}","notifications_url":"https://api.github.com/repos/fossasia/open-event-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fossasia/open-event-server/labels{/name}","releases_url":"https://api.github.com/repos/fossasia/open-event-server/releases{/id}","deployments_url":"https://api.github.com/repos/fossasia/open-event-server/deployments","created_at":"2015-05-08T09:16:19Z","updated_at":"2018-06-09T07:41:29Z","pushed_at":"2018-06-09T09:54:27Z","git_url":"git://github.com/fossasia/open-event-server.git","ssh_url":"git@github.com:fossasia/open-event-server.git","clone_url":"https://github.com/fossasia/open-event-server.git","svn_url":"https://github.com/fossasia/open-event-server","homepage":"http://open-event-api.herokuapp.com/","size":44421,"stargazers_count":1010,"watchers_count":1010,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":913,"mirror_url":null,"archived":false,"open_issues_count":81,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":913,"open_issues":81,"watchers":1010,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/fossasia/open-event-server/pulls/4845"},"html":{"href":"https://github.com/fossasia/open-event-server/pull/4845"},"issue":{"href":"https://api.github.com/repos/fossasia/open-event-server/issues/4845"},"comments":{"href":"https://api.github.com/repos/fossasia/open-event-server/issues/4845/comments"},"review_comments":{"href":"https://api.github.com/repos/fossasia/open-event-server/pulls/4845/comments"},"review_comment":{"href":"https://api.github.com/repos/fossasia/open-event-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fossasia/open-event-server/pulls/4845/commits"},"statuses":{"href":"https://api.github.com/repos/fossasia/open-event-server/statuses/96346eaa9ad3bf69d74d8b4e254e19801459b1a5"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bhaveshAn","id":22936570,"node_id":"MDQ6VXNlcjIyOTM2NTcw","avatar_url":"https://avatars1.githubusercontent.com/u/22936570?v=4","gravatar_id":"","url":"https://api.github.com/users/bhaveshAn","html_url":"https://github.com/bhaveshAn","followers_url":"https://api.github.com/users/bhaveshAn/followers","following_url":"https://api.github.com/users/bhaveshAn/following{/other_user}","gists_url":"https://api.github.com/users/bhaveshAn/gists{/gist_id}","starred_url":"https://api.github.com/users/bhaveshAn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhaveshAn/subscriptions","organizations_url":"https://api.github.com/users/bhaveshAn/orgs","repos_url":"https://api.github.com/users/bhaveshAn/repos","events_url":"https://api.github.com/users/bhaveshAn/events{/privacy}","received_events_url":"https://api.github.com/users/bhaveshAn/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":6,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"bhaveshAn"}}