{"action":"created","comment":{"url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/pulls/comments/192434230","pull_request_review_id":125216317,"id":192434230,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjQzNDIzMA==","diff_hunk":"@@ -7,5 +7,7 @@ public class CsvFormatterOptions\n         public string CsvDelimiter { get; set; } = \";\";\r\n \r\n         public string Encoding { get; set; } = \"ISO-8859-1\";\r\n+        \r\n+        public bool UseNewtonsoftJsonDataAnnotations { get; set; } = false;\r","path":"src/WebApiContrib.Core.Formatter.Csv/CsvFormatterOptions.cs","position":5,"original_position":5,"commit_id":"7b0999ff89f50bcf1641cb1cf49b998d0b4dec73","original_commit_id":"7b0999ff89f50bcf1641cb1cf49b998d0b4dec73","user":{"login":"filipw","id":1710369,"node_id":"MDQ6VXNlcjE3MTAzNjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1710369?v=4","gravatar_id":"","url":"https://api.github.com/users/filipw","html_url":"https://github.com/filipw","followers_url":"https://api.github.com/users/filipw/followers","following_url":"https://api.github.com/users/filipw/following{/other_user}","gists_url":"https://api.github.com/users/filipw/gists{/gist_id}","starred_url":"https://api.github.com/users/filipw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipw/subscriptions","organizations_url":"https://api.github.com/users/filipw/orgs","repos_url":"https://api.github.com/users/filipw/repos","events_url":"https://api.github.com/users/filipw/events{/privacy}","received_events_url":"https://api.github.com/users/filipw/received_events","type":"User","site_admin":false},"body":"sorry if I wasn't clear. I just meant that we should definitely respect JSON.NET attributes, and that we should always check for them. I don't think there should be a setting to opt-in or opt-out from that behavior.\r\n\r\nThis is consistent with the MVC behavior in general. You could for example define an API model like this:\r\n\r\n```\r\n    public class Person\r\n    {\r\n        [JsonProperty(Required = Required.Always)]\r\n        public string FirstName { get; set; }\r\n\r\n        [JsonIgnore]\r\n        public string LastName { get; set; }\r\n    }\r\n```\r\n\r\nAnd rely on the fact that `ModelState` will be invalid if the caller doesn't send the first name. There is no dedicated opt in or opt out from that behavior, as it's implicit on the formatter level.\r\n\r\nSo for the sake of consistency we should behave the same way.","created_at":"2018-06-01T15:35:00Z","updated_at":"2018-06-01T15:35:00Z","html_url":"https://github.com/WebApiContrib/WebAPIContrib.Core/pull/137#discussion_r192434230","pull_request_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/pulls/137","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/pulls/comments/192434230"},"html":{"href":"https://github.com/WebApiContrib/WebAPIContrib.Core/pull/137#discussion_r192434230"},"pull_request":{"href":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/pulls/137"}},"in_reply_to_id":192358081},"pull_request":{"url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/pulls/137","id":191834178,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxODM0MTc4","html_url":"https://github.com/WebApiContrib/WebAPIContrib.Core/pull/137","diff_url":"https://github.com/WebApiContrib/WebAPIContrib.Core/pull/137.diff","patch_url":"https://github.com/WebApiContrib/WebAPIContrib.Core/pull/137.patch","issue_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/issues/137","number":137,"state":"open","locked":false,"title":"Damienbod/ignore properties configuration","user":{"login":"damienbod","id":3442158,"node_id":"MDQ6VXNlcjM0NDIxNTg=","avatar_url":"https://avatars3.githubusercontent.com/u/3442158?v=4","gravatar_id":"","url":"https://api.github.com/users/damienbod","html_url":"https://github.com/damienbod","followers_url":"https://api.github.com/users/damienbod/followers","following_url":"https://api.github.com/users/damienbod/following{/other_user}","gists_url":"https://api.github.com/users/damienbod/gists{/gist_id}","starred_url":"https://api.github.com/users/damienbod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damienbod/subscriptions","organizations_url":"https://api.github.com/users/damienbod/orgs","repos_url":"https://api.github.com/users/damienbod/repos","events_url":"https://api.github.com/users/damienbod/events{/privacy}","received_events_url":"https://api.github.com/users/damienbod/received_events","type":"User","site_admin":false},"body":"PR from @os1r1s110\r\n\r\nProperties can be ignored now using the atttribute JsonIgnore","created_at":"2018-05-31T18:17:30Z","updated_at":"2018-06-01T15:35:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b54322d0dfd7305e2106edba321b207fda0ecc71","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/pulls/137/commits","review_comments_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/pulls/137/comments","review_comment_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/issues/137/comments","statuses_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/statuses/7b0999ff89f50bcf1641cb1cf49b998d0b4dec73","head":{"label":"damienbod:damienbod/ignore-properties-configuration","ref":"damienbod/ignore-properties-configuration","sha":"7b0999ff89f50bcf1641cb1cf49b998d0b4dec73","user":{"login":"damienbod","id":3442158,"node_id":"MDQ6VXNlcjM0NDIxNTg=","avatar_url":"https://avatars3.githubusercontent.com/u/3442158?v=4","gravatar_id":"","url":"https://api.github.com/users/damienbod","html_url":"https://github.com/damienbod","followers_url":"https://api.github.com/users/damienbod/followers","following_url":"https://api.github.com/users/damienbod/following{/other_user}","gists_url":"https://api.github.com/users/damienbod/gists{/gist_id}","starred_url":"https://api.github.com/users/damienbod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damienbod/subscriptions","organizations_url":"https://api.github.com/users/damienbod/orgs","repos_url":"https://api.github.com/users/damienbod/repos","events_url":"https://api.github.com/users/damienbod/events{/privacy}","received_events_url":"https://api.github.com/users/damienbod/received_events","type":"User","site_admin":false},"repo":{"id":61446773,"node_id":"MDEwOlJlcG9zaXRvcnk2MTQ0Njc3Mw==","name":"WebAPIContrib.Core","full_name":"damienbod/WebAPIContrib.Core","owner":{"login":"damienbod","id":3442158,"node_id":"MDQ6VXNlcjM0NDIxNTg=","avatar_url":"https://avatars3.githubusercontent.com/u/3442158?v=4","gravatar_id":"","url":"https://api.github.com/users/damienbod","html_url":"https://github.com/damienbod","followers_url":"https://api.github.com/users/damienbod/followers","following_url":"https://api.github.com/users/damienbod/following{/other_user}","gists_url":"https://api.github.com/users/damienbod/gists{/gist_id}","starred_url":"https://api.github.com/users/damienbod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damienbod/subscriptions","organizations_url":"https://api.github.com/users/damienbod/orgs","repos_url":"https://api.github.com/users/damienbod/repos","events_url":"https://api.github.com/users/damienbod/events{/privacy}","received_events_url":"https://api.github.com/users/damienbod/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/damienbod/WebAPIContrib.Core","description":"Community Contributions for ASP.NET Core","fork":true,"url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core","forks_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/forks","keys_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/teams","hooks_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/hooks","issue_events_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/issues/events{/number}","events_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/events","assignees_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/assignees{/user}","branches_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/branches{/branch}","tags_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/tags","blobs_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/git/refs{/sha}","trees_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/statuses/{sha}","languages_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/languages","stargazers_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/stargazers","contributors_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/contributors","subscribers_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/subscribers","subscription_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/subscription","commits_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/commits{/sha}","git_commits_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/git/commits{/sha}","comments_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/comments{/number}","issue_comment_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/issues/comments{/number}","contents_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/contents/{+path}","compare_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/merges","archive_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/downloads","issues_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/issues{/number}","pulls_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/pulls{/number}","milestones_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/milestones{/number}","notifications_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/labels{/name}","releases_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/releases{/id}","deployments_url":"https://api.github.com/repos/damienbod/WebAPIContrib.Core/deployments","created_at":"2016-06-18T18:18:18Z","updated_at":"2018-05-31T18:02:44Z","pushed_at":"2018-05-31T18:15:15Z","git_url":"git://github.com/damienbod/WebAPIContrib.Core.git","ssh_url":"git@github.com:damienbod/WebAPIContrib.Core.git","clone_url":"https://github.com/damienbod/WebAPIContrib.Core.git","svn_url":"https://github.com/damienbod/WebAPIContrib.Core","homepage":null,"size":430,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"WebApiContrib:master","ref":"master","sha":"92987ffd630bd5a38d6ebdca5c6a8a9c43edc0b4","user":{"login":"WebApiContrib","id":1561645,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjE2NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1561645?v=4","gravatar_id":"","url":"https://api.github.com/users/WebApiContrib","html_url":"https://github.com/WebApiContrib","followers_url":"https://api.github.com/users/WebApiContrib/followers","following_url":"https://api.github.com/users/WebApiContrib/following{/other_user}","gists_url":"https://api.github.com/users/WebApiContrib/gists{/gist_id}","starred_url":"https://api.github.com/users/WebApiContrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebApiContrib/subscriptions","organizations_url":"https://api.github.com/users/WebApiContrib/orgs","repos_url":"https://api.github.com/users/WebApiContrib/repos","events_url":"https://api.github.com/users/WebApiContrib/events{/privacy}","received_events_url":"https://api.github.com/users/WebApiContrib/received_events","type":"Organization","site_admin":false},"repo":{"id":60242719,"node_id":"MDEwOlJlcG9zaXRvcnk2MDI0MjcxOQ==","name":"WebAPIContrib.Core","full_name":"WebApiContrib/WebAPIContrib.Core","owner":{"login":"WebApiContrib","id":1561645,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjE2NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1561645?v=4","gravatar_id":"","url":"https://api.github.com/users/WebApiContrib","html_url":"https://github.com/WebApiContrib","followers_url":"https://api.github.com/users/WebApiContrib/followers","following_url":"https://api.github.com/users/WebApiContrib/following{/other_user}","gists_url":"https://api.github.com/users/WebApiContrib/gists{/gist_id}","starred_url":"https://api.github.com/users/WebApiContrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebApiContrib/subscriptions","organizations_url":"https://api.github.com/users/WebApiContrib/orgs","repos_url":"https://api.github.com/users/WebApiContrib/repos","events_url":"https://api.github.com/users/WebApiContrib/events{/privacy}","received_events_url":"https://api.github.com/users/WebApiContrib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WebApiContrib/WebAPIContrib.Core","description":"Community Contributions for ASP.NET Core","fork":false,"url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core","forks_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/forks","keys_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/teams","hooks_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/hooks","issue_events_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/issues/events{/number}","events_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/events","assignees_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/assignees{/user}","branches_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/branches{/branch}","tags_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/tags","blobs_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/git/refs{/sha}","trees_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/statuses/{sha}","languages_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/languages","stargazers_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/stargazers","contributors_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/contributors","subscribers_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/subscribers","subscription_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/subscription","commits_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/commits{/sha}","git_commits_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/git/commits{/sha}","comments_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/comments{/number}","issue_comment_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/issues/comments{/number}","contents_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/contents/{+path}","compare_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/merges","archive_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/downloads","issues_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/issues{/number}","pulls_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/pulls{/number}","milestones_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/milestones{/number}","notifications_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/labels{/name}","releases_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/releases{/id}","deployments_url":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/deployments","created_at":"2016-06-02T07:37:28Z","updated_at":"2018-05-28T12:46:03Z","pushed_at":"2018-05-31T18:17:31Z","git_url":"git://github.com/WebApiContrib/WebAPIContrib.Core.git","ssh_url":"git@github.com:WebApiContrib/WebAPIContrib.Core.git","clone_url":"https://github.com/WebApiContrib/WebAPIContrib.Core.git","svn_url":"https://github.com/WebApiContrib/WebAPIContrib.Core","homepage":null,"size":441,"stargazers_count":287,"watchers_count":287,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":53,"open_issues":18,"watchers":287,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/pulls/137"},"html":{"href":"https://github.com/WebApiContrib/WebAPIContrib.Core/pull/137"},"issue":{"href":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/issues/137"},"comments":{"href":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/WebApiContrib/WebAPIContrib.Core/statuses/7b0999ff89f50bcf1641cb1cf49b998d0b4dec73"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"filipw"}}