{"action":"created","issue":{"url":"https://api.github.com/repos/UltraStar-Deluxe/Play/issues/14","repository_url":"https://api.github.com/repos/UltraStar-Deluxe/Play","labels_url":"https://api.github.com/repos/UltraStar-Deluxe/Play/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/UltraStar-Deluxe/Play/issues/14/comments","events_url":"https://api.github.com/repos/UltraStar-Deluxe/Play/issues/14/events","html_url":"https://github.com/UltraStar-Deluxe/Play/pull/14","id":338733878,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NTkzNTUz","number":14,"title":"Codacy items and Cleanup","user":{"login":"Baklap4","id":3918517,"node_id":"MDQ6VXNlcjM5MTg1MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/3918517?v=4","gravatar_id":"","url":"https://api.github.com/users/Baklap4","html_url":"https://github.com/Baklap4","followers_url":"https://api.github.com/users/Baklap4/followers","following_url":"https://api.github.com/users/Baklap4/following{/other_user}","gists_url":"https://api.github.com/users/Baklap4/gists{/gist_id}","starred_url":"https://api.github.com/users/Baklap4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baklap4/subscriptions","organizations_url":"https://api.github.com/users/Baklap4/orgs","repos_url":"https://api.github.com/users/Baklap4/repos","events_url":"https://api.github.com/users/Baklap4/events{/privacy}","received_events_url":"https://api.github.com/users/Baklap4/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-05T21:36:49Z","updated_at":"2018-07-05T21:50:24Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/UltraStar-Deluxe/Play/pulls/14","html_url":"https://github.com/UltraStar-Deluxe/Play/pull/14","diff_url":"https://github.com/UltraStar-Deluxe/Play/pull/14.diff","patch_url":"https://github.com/UltraStar-Deluxe/Play/pull/14.patch"},"body":"# Changes in the pull request\r\n* Fixed loads of Codacy issues, some highlights:\r\n    * Make use of overloading instead of defaulting values.\r\n    * Added static keywords to classes which were completely static\r\n    * Braces\r\n    * Default cases + Custom exception.\r\n* Removed unused / dead code as per Contributing guidelines: https://github.com/UltraStar-Deluxe/Play/blob/master/CONTRIBUTING.md\r\n* Removed Todo's\r\n    * Todo's mainly will clutter code and should be fixed within your feature/bugfix/hotfix branch.\r\n    * If a todo cannot be solved earlier an issue should be made to track this status.\r\n* Added some xml doc to methods if it had a comment already.\r\n    * Would be nice to XML document every method, class, enum and interface even if the instance is private.\r\n    * This will prevent your code being cluttered with inline comments.\r\n        * If an inline comment is needed your method is probably doing too much. Keep it simple, stupid.\r\n* Fixed a test to actually test something."},"comment":{"url":"https://api.github.com/repos/UltraStar-Deluxe/Play/issues/comments/402863242","html_url":"https://github.com/UltraStar-Deluxe/Play/pull/14#issuecomment-402863242","issue_url":"https://api.github.com/repos/UltraStar-Deluxe/Play/issues/14","id":402863242,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjg2MzI0Mg==","user":{"login":"basisbit","id":10870269,"node_id":"MDQ6VXNlcjEwODcwMjY5","avatar_url":"https://avatars3.githubusercontent.com/u/10870269?v=4","gravatar_id":"","url":"https://api.github.com/users/basisbit","html_url":"https://github.com/basisbit","followers_url":"https://api.github.com/users/basisbit/followers","following_url":"https://api.github.com/users/basisbit/following{/other_user}","gists_url":"https://api.github.com/users/basisbit/gists{/gist_id}","starred_url":"https://api.github.com/users/basisbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basisbit/subscriptions","organizations_url":"https://api.github.com/users/basisbit/orgs","repos_url":"https://api.github.com/users/basisbit/repos","events_url":"https://api.github.com/users/basisbit/events{/privacy}","received_events_url":"https://api.github.com/users/basisbit/received_events","type":"User","site_admin":false},"created_at":"2018-07-05T21:50:24Z","updated_at":"2018-07-05T21:50:24Z","author_association":"MEMBER","body":"> Removed unused / dead code as per Contributing guidelines: https://github.com/UltraStar-Deluxe/Play/blob/master/CONTRIBUTING.md\r\n\r\n... not sure if removing TODOs and still to be implemented stuff is the right way to go, but it would be exactly what the contributing.md says 😸 "}}
{"actor":{"display_login":"basisbit"}}