{"action":"created","comment":{"url":"https://api.github.com/repos/sebasguts/PyQNormaliz/pulls/comments/219670450","pull_request_review_id":157908734,"id":219670450,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTY3MDQ1MA==","diff_hunk":"@@ -238,15 +240,6 @@ PyObject* NmzToPyNumber( mpz_class in ){\n   return ret_val;\n }\n \n-PyObject* NmzToPyList( mpq_class in ){","path":"QNormalizModule.cpp","position":24,"original_position":24,"commit_id":"6a931d18f43c6494b65907ce33117840a1118e8a","original_commit_id":"6a931d18f43c6494b65907ce33117840a1118e8a","user":{"login":"sebasguts","id":1068084,"node_id":"MDQ6VXNlcjEwNjgwODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1068084?v=4","gravatar_id":"","url":"https://api.github.com/users/sebasguts","html_url":"https://github.com/sebasguts","followers_url":"https://api.github.com/users/sebasguts/followers","following_url":"https://api.github.com/users/sebasguts/following{/other_user}","gists_url":"https://api.github.com/users/sebasguts/gists{/gist_id}","starred_url":"https://api.github.com/users/sebasguts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebasguts/subscriptions","organizations_url":"https://api.github.com/users/sebasguts/orgs","repos_url":"https://api.github.com/users/sebasguts/repos","events_url":"https://api.github.com/users/sebasguts/events{/privacy}","received_events_url":"https://api.github.com/users/sebasguts/received_events","type":"User","site_admin":false},"body":"This is indeed unused, probably a left over from PyNormaliz.","created_at":"2018-09-22T12:37:50Z","updated_at":"2018-09-22T12:44:57Z","html_url":"https://github.com/sebasguts/PyQNormaliz/pull/1#discussion_r219670450","pull_request_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/sebasguts/PyQNormaliz/pulls/comments/219670450"},"html":{"href":"https://github.com/sebasguts/PyQNormaliz/pull/1#discussion_r219670450"},"pull_request":{"href":"https://api.github.com/repos/sebasguts/PyQNormaliz/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/sebasguts/PyQNormaliz/pulls/1","id":217434902,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NDM0OTAy","html_url":"https://github.com/sebasguts/PyQNormaliz/pull/1","diff_url":"https://github.com/sebasguts/PyQNormaliz/pull/1.diff","patch_url":"https://github.com/sebasguts/PyQNormaliz/pull/1.patch","issue_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/issues/1","number":1,"state":"open","locked":false,"title":"Trying to fix memory management errors","user":{"login":"mkoeppe","id":8345221,"node_id":"MDQ6VXNlcjgzNDUyMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/8345221?v=4","gravatar_id":"","url":"https://api.github.com/users/mkoeppe","html_url":"https://github.com/mkoeppe","followers_url":"https://api.github.com/users/mkoeppe/followers","following_url":"https://api.github.com/users/mkoeppe/following{/other_user}","gists_url":"https://api.github.com/users/mkoeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/mkoeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkoeppe/subscriptions","organizations_url":"https://api.github.com/users/mkoeppe/orgs","repos_url":"https://api.github.com/users/mkoeppe/repos","events_url":"https://api.github.com/users/mkoeppe/events{/privacy}","received_events_url":"https://api.github.com/users/mkoeppe/received_events","type":"User","site_admin":false},"body":"I'm getting memory management errors, which seem hard to reproduce outside of Sage.\r\nhttps://trac.sagemath.org/ticket/25097\r\n\r\nValgrind report is inconclusive. \r\n\r\nReviewing the PyQNormaliz source, I found a few suspicious places, but the segfaults persist.\r\n","created_at":"2018-09-22T02:32:01Z","updated_at":"2018-09-22T12:44:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"787675660da92e017a87d45fa7bb8d3ccfa74e89","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/pulls/1/commits","review_comments_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/pulls/1/comments","review_comment_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/issues/1/comments","statuses_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/statuses/6a931d18f43c6494b65907ce33117840a1118e8a","head":{"label":"mkoeppe:master","ref":"master","sha":"6a931d18f43c6494b65907ce33117840a1118e8a","user":{"login":"mkoeppe","id":8345221,"node_id":"MDQ6VXNlcjgzNDUyMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/8345221?v=4","gravatar_id":"","url":"https://api.github.com/users/mkoeppe","html_url":"https://github.com/mkoeppe","followers_url":"https://api.github.com/users/mkoeppe/followers","following_url":"https://api.github.com/users/mkoeppe/following{/other_user}","gists_url":"https://api.github.com/users/mkoeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/mkoeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkoeppe/subscriptions","organizations_url":"https://api.github.com/users/mkoeppe/orgs","repos_url":"https://api.github.com/users/mkoeppe/repos","events_url":"https://api.github.com/users/mkoeppe/events{/privacy}","received_events_url":"https://api.github.com/users/mkoeppe/received_events","type":"User","site_admin":false},"repo":{"id":149838039,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk4MzgwMzk=","name":"PyQNormaliz","full_name":"mkoeppe/PyQNormaliz","private":false,"owner":{"login":"mkoeppe","id":8345221,"node_id":"MDQ6VXNlcjgzNDUyMjE=","avatar_url":"https://avatars3.githubusercontent.com/u/8345221?v=4","gravatar_id":"","url":"https://api.github.com/users/mkoeppe","html_url":"https://github.com/mkoeppe","followers_url":"https://api.github.com/users/mkoeppe/followers","following_url":"https://api.github.com/users/mkoeppe/following{/other_user}","gists_url":"https://api.github.com/users/mkoeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/mkoeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkoeppe/subscriptions","organizations_url":"https://api.github.com/users/mkoeppe/orgs","repos_url":"https://api.github.com/users/mkoeppe/repos","events_url":"https://api.github.com/users/mkoeppe/events{/privacy}","received_events_url":"https://api.github.com/users/mkoeppe/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mkoeppe/PyQNormaliz","description":"Python wrapper for QNormaliz with e-antic real embedded number fields","fork":true,"url":"https://api.github.com/repos/mkoeppe/PyQNormaliz","forks_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/forks","keys_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/teams","hooks_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/hooks","issue_events_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/issues/events{/number}","events_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/events","assignees_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/assignees{/user}","branches_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/branches{/branch}","tags_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/tags","blobs_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/statuses/{sha}","languages_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/languages","stargazers_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/stargazers","contributors_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/contributors","subscribers_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/subscribers","subscription_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/subscription","commits_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/contents/{+path}","compare_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/merges","archive_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/downloads","issues_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/issues{/number}","pulls_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/pulls{/number}","milestones_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/milestones{/number}","notifications_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/labels{/name}","releases_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/releases{/id}","deployments_url":"https://api.github.com/repos/mkoeppe/PyQNormaliz/deployments","created_at":"2018-09-22T02:24:11Z","updated_at":"2018-09-22T02:24:50Z","pushed_at":"2018-09-22T02:24:49Z","git_url":"git://github.com/mkoeppe/PyQNormaliz.git","ssh_url":"git@github.com:mkoeppe/PyQNormaliz.git","clone_url":"https://github.com/mkoeppe/PyQNormaliz.git","svn_url":"https://github.com/mkoeppe/PyQNormaliz","homepage":null,"size":41,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sebasguts:master","ref":"master","sha":"eb98c47c48db00315d6933712f01d7530dfe2394","user":{"login":"sebasguts","id":1068084,"node_id":"MDQ6VXNlcjEwNjgwODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1068084?v=4","gravatar_id":"","url":"https://api.github.com/users/sebasguts","html_url":"https://github.com/sebasguts","followers_url":"https://api.github.com/users/sebasguts/followers","following_url":"https://api.github.com/users/sebasguts/following{/other_user}","gists_url":"https://api.github.com/users/sebasguts/gists{/gist_id}","starred_url":"https://api.github.com/users/sebasguts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebasguts/subscriptions","organizations_url":"https://api.github.com/users/sebasguts/orgs","repos_url":"https://api.github.com/users/sebasguts/repos","events_url":"https://api.github.com/users/sebasguts/events{/privacy}","received_events_url":"https://api.github.com/users/sebasguts/received_events","type":"User","site_admin":false},"repo":{"id":128224593,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgyMjQ1OTM=","name":"PyQNormaliz","full_name":"sebasguts/PyQNormaliz","private":false,"owner":{"login":"sebasguts","id":1068084,"node_id":"MDQ6VXNlcjEwNjgwODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1068084?v=4","gravatar_id":"","url":"https://api.github.com/users/sebasguts","html_url":"https://github.com/sebasguts","followers_url":"https://api.github.com/users/sebasguts/followers","following_url":"https://api.github.com/users/sebasguts/following{/other_user}","gists_url":"https://api.github.com/users/sebasguts/gists{/gist_id}","starred_url":"https://api.github.com/users/sebasguts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebasguts/subscriptions","organizations_url":"https://api.github.com/users/sebasguts/orgs","repos_url":"https://api.github.com/users/sebasguts/repos","events_url":"https://api.github.com/users/sebasguts/events{/privacy}","received_events_url":"https://api.github.com/users/sebasguts/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sebasguts/PyQNormaliz","description":"Python wrapper for QNormaliz with e-antic real embedded number fields","fork":false,"url":"https://api.github.com/repos/sebasguts/PyQNormaliz","forks_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/forks","keys_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/teams","hooks_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/hooks","issue_events_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/issues/events{/number}","events_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/events","assignees_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/assignees{/user}","branches_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/branches{/branch}","tags_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/tags","blobs_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/git/refs{/sha}","trees_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/statuses/{sha}","languages_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/languages","stargazers_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/stargazers","contributors_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/contributors","subscribers_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/subscribers","subscription_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/subscription","commits_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/commits{/sha}","git_commits_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/git/commits{/sha}","comments_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/comments{/number}","issue_comment_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/issues/comments{/number}","contents_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/contents/{+path}","compare_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/merges","archive_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/downloads","issues_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/issues{/number}","pulls_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/pulls{/number}","milestones_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/milestones{/number}","notifications_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/labels{/name}","releases_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/releases{/id}","deployments_url":"https://api.github.com/repos/sebasguts/PyQNormaliz/deployments","created_at":"2018-04-05T15:17:36Z","updated_at":"2018-07-26T13:27:39Z","pushed_at":"2018-09-22T02:32:02Z","git_url":"git://github.com/sebasguts/PyQNormaliz.git","ssh_url":"git@github.com:sebasguts/PyQNormaliz.git","clone_url":"https://github.com/sebasguts/PyQNormaliz.git","svn_url":"https://github.com/sebasguts/PyQNormaliz","homepage":null,"size":40,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sebasguts/PyQNormaliz/pulls/1"},"html":{"href":"https://github.com/sebasguts/PyQNormaliz/pull/1"},"issue":{"href":"https://api.github.com/repos/sebasguts/PyQNormaliz/issues/1"},"comments":{"href":"https://api.github.com/repos/sebasguts/PyQNormaliz/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/sebasguts/PyQNormaliz/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/sebasguts/PyQNormaliz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sebasguts/PyQNormaliz/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/sebasguts/PyQNormaliz/statuses/6a931d18f43c6494b65907ce33117840a1118e8a"}},"author_association":"NONE"}}
{"actor":{"display_login":"sebasguts"}}