{"action":"created","comment":{"url":"https://api.github.com/repos/bukalapak/url-router/pulls/comments/207844589","pull_request_review_id":143535823,"id":207844589,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzg0NDU4OQ==","diff_hunk":"@@ -49,32 +49,51 @@ class Router {\n      *\n      * @param expression Expression\n      * @param processor  Invocation\n+     * @param parentExpression  Scheme and host expression\n      */\n-    fun map(expression: String, processor: Processor) {\n+    private fun pathMap(expression: String, processor: Processor, parentExpression: String? = null) {\n         assertExpression(expression)\n-        processors = processors.plus(Expression(expression, processor, 1))\n+        processors = processors.plus(Expression(expression, processor, 1, parentExpression))\n     }\n \n     /**\n      * Path and query processor for multiple expressions in single processor\n      *\n      * @param expressions Expressions\n      * @param processor   Invocation\n+     * @param parentExpression  Scheme and host expression\n      */\n-    fun map(expressions: List<String>, processor: Processor) {\n+    private fun pathMap(expressions: List<String>, processor: Processor, parentExpression: String? = null) {\n         assertExpression(expressions)\n-        processors = processors.plus(expressions.map { Expression(it, processor, expressions.size) })\n+        processors = processors.plus(expressions.map { Expression(it, processor, expressions.size, parentExpression) })\n     }\n \n     /**\n      * Scheme and host processor for single expression in single processor\n      *\n      * @param expression Expression\n+     * @param routerMap  Multiple path and query processor for multiple expression in singgle processor\n      * @param preProcessor  Invocation\n      */\n-    fun preMap(expression: String, preProcessor: PreProcessor) {\n+    fun map(expression: String, routerMap: List<RouterMap> = emptyList(), preProcessor: PreProcessor) {","path":"url-router/src/main/java/com/bukalapak/urlrouter/Router.kt","position":35,"original_position":35,"commit_id":"c8e8772be04ba390a7f934d6285eeefbd829e470","original_commit_id":"c8e8772be04ba390a7f934d6285eeefbd829e470","user":{"login":"mrhabibi","id":13618227,"node_id":"MDQ6VXNlcjEzNjE4MjI3","avatar_url":"https://avatars1.githubusercontent.com/u/13618227?v=4","gravatar_id":"","url":"https://api.github.com/users/mrhabibi","html_url":"https://github.com/mrhabibi","followers_url":"https://api.github.com/users/mrhabibi/followers","following_url":"https://api.github.com/users/mrhabibi/following{/other_user}","gists_url":"https://api.github.com/users/mrhabibi/gists{/gist_id}","starred_url":"https://api.github.com/users/mrhabibi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrhabibi/subscriptions","organizations_url":"https://api.github.com/users/mrhabibi/orgs","repos_url":"https://api.github.com/users/mrhabibi/repos","events_url":"https://api.github.com/users/mrhabibi/events{/privacy}","received_events_url":"https://api.github.com/users/mrhabibi/received_events","type":"User","site_admin":false},"body":"dibikin sama semua aja urutannya: expression, preprocessor, routermap","created_at":"2018-08-06T10:31:57Z","updated_at":"2018-08-06T10:32:12Z","html_url":"https://github.com/bukalapak/url-router/pull/1#discussion_r207844589","pull_request_url":"https://api.github.com/repos/bukalapak/url-router/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/bukalapak/url-router/pulls/comments/207844589"},"html":{"href":"https://github.com/bukalapak/url-router/pull/1#discussion_r207844589"},"pull_request":{"href":"https://api.github.com/repos/bukalapak/url-router/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/bukalapak/url-router/pulls/1","id":204130990,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MTMwOTkw","html_url":"https://github.com/bukalapak/url-router/pull/1","diff_url":"https://github.com/bukalapak/url-router/pull/1.diff","patch_url":"https://github.com/bukalapak/url-router/pull/1.patch","issue_url":"https://api.github.com/repos/bukalapak/url-router/issues/1","number":1,"state":"open","locked":false,"title":"change method premap for support path and query with different subdomain","user":{"login":"arifinbardansyah","id":11383384,"node_id":"MDQ6VXNlcjExMzgzMzg0","avatar_url":"https://avatars3.githubusercontent.com/u/11383384?v=4","gravatar_id":"","url":"https://api.github.com/users/arifinbardansyah","html_url":"https://github.com/arifinbardansyah","followers_url":"https://api.github.com/users/arifinbardansyah/followers","following_url":"https://api.github.com/users/arifinbardansyah/following{/other_user}","gists_url":"https://api.github.com/users/arifinbardansyah/gists{/gist_id}","starred_url":"https://api.github.com/users/arifinbardansyah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arifinbardansyah/subscriptions","organizations_url":"https://api.github.com/users/arifinbardansyah/orgs","repos_url":"https://api.github.com/users/arifinbardansyah/repos","events_url":"https://api.github.com/users/arifinbardansyah/events{/privacy}","received_events_url":"https://api.github.com/users/arifinbardansyah/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-26T12:48:19Z","updated_at":"2018-08-06T10:32:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d07bcd19f815cbaffd529c9df2d4f548e6af227","assignee":{"login":"arifinbardansyah","id":11383384,"node_id":"MDQ6VXNlcjExMzgzMzg0","avatar_url":"https://avatars3.githubusercontent.com/u/11383384?v=4","gravatar_id":"","url":"https://api.github.com/users/arifinbardansyah","html_url":"https://github.com/arifinbardansyah","followers_url":"https://api.github.com/users/arifinbardansyah/followers","following_url":"https://api.github.com/users/arifinbardansyah/following{/other_user}","gists_url":"https://api.github.com/users/arifinbardansyah/gists{/gist_id}","starred_url":"https://api.github.com/users/arifinbardansyah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arifinbardansyah/subscriptions","organizations_url":"https://api.github.com/users/arifinbardansyah/orgs","repos_url":"https://api.github.com/users/arifinbardansyah/repos","events_url":"https://api.github.com/users/arifinbardansyah/events{/privacy}","received_events_url":"https://api.github.com/users/arifinbardansyah/received_events","type":"User","site_admin":false},"assignees":[{"login":"arifinbardansyah","id":11383384,"node_id":"MDQ6VXNlcjExMzgzMzg0","avatar_url":"https://avatars3.githubusercontent.com/u/11383384?v=4","gravatar_id":"","url":"https://api.github.com/users/arifinbardansyah","html_url":"https://github.com/arifinbardansyah","followers_url":"https://api.github.com/users/arifinbardansyah/followers","following_url":"https://api.github.com/users/arifinbardansyah/following{/other_user}","gists_url":"https://api.github.com/users/arifinbardansyah/gists{/gist_id}","starred_url":"https://api.github.com/users/arifinbardansyah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arifinbardansyah/subscriptions","organizations_url":"https://api.github.com/users/arifinbardansyah/orgs","repos_url":"https://api.github.com/users/arifinbardansyah/repos","events_url":"https://api.github.com/users/arifinbardansyah/events{/privacy}","received_events_url":"https://api.github.com/users/arifinbardansyah/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bukalapak/url-router/pulls/1/commits","review_comments_url":"https://api.github.com/repos/bukalapak/url-router/pulls/1/comments","review_comment_url":"https://api.github.com/repos/bukalapak/url-router/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bukalapak/url-router/issues/1/comments","statuses_url":"https://api.github.com/repos/bukalapak/url-router/statuses/c8e8772be04ba390a7f934d6285eeefbd829e470","head":{"label":"bukalapak:subdomain_url_router","ref":"subdomain_url_router","sha":"c8e8772be04ba390a7f934d6285eeefbd829e470","user":{"login":"bukalapak","id":1088949,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODg5NDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1088949?v=4","gravatar_id":"","url":"https://api.github.com/users/bukalapak","html_url":"https://github.com/bukalapak","followers_url":"https://api.github.com/users/bukalapak/followers","following_url":"https://api.github.com/users/bukalapak/following{/other_user}","gists_url":"https://api.github.com/users/bukalapak/gists{/gist_id}","starred_url":"https://api.github.com/users/bukalapak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bukalapak/subscriptions","organizations_url":"https://api.github.com/users/bukalapak/orgs","repos_url":"https://api.github.com/users/bukalapak/repos","events_url":"https://api.github.com/users/bukalapak/events{/privacy}","received_events_url":"https://api.github.com/users/bukalapak/received_events","type":"Organization","site_admin":false},"repo":{"id":96386137,"node_id":"MDEwOlJlcG9zaXRvcnk5NjM4NjEzNw==","name":"url-router","full_name":"bukalapak/url-router","owner":{"login":"bukalapak","id":1088949,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODg5NDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1088949?v=4","gravatar_id":"","url":"https://api.github.com/users/bukalapak","html_url":"https://github.com/bukalapak","followers_url":"https://api.github.com/users/bukalapak/followers","following_url":"https://api.github.com/users/bukalapak/following{/other_user}","gists_url":"https://api.github.com/users/bukalapak/gists{/gist_id}","starred_url":"https://api.github.com/users/bukalapak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bukalapak/subscriptions","organizations_url":"https://api.github.com/users/bukalapak/orgs","repos_url":"https://api.github.com/users/bukalapak/repos","events_url":"https://api.github.com/users/bukalapak/events{/privacy}","received_events_url":"https://api.github.com/users/bukalapak/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bukalapak/url-router","description":"A wrapper for easily routing URL on Android","fork":false,"url":"https://api.github.com/repos/bukalapak/url-router","forks_url":"https://api.github.com/repos/bukalapak/url-router/forks","keys_url":"https://api.github.com/repos/bukalapak/url-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bukalapak/url-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bukalapak/url-router/teams","hooks_url":"https://api.github.com/repos/bukalapak/url-router/hooks","issue_events_url":"https://api.github.com/repos/bukalapak/url-router/issues/events{/number}","events_url":"https://api.github.com/repos/bukalapak/url-router/events","assignees_url":"https://api.github.com/repos/bukalapak/url-router/assignees{/user}","branches_url":"https://api.github.com/repos/bukalapak/url-router/branches{/branch}","tags_url":"https://api.github.com/repos/bukalapak/url-router/tags","blobs_url":"https://api.github.com/repos/bukalapak/url-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bukalapak/url-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bukalapak/url-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/bukalapak/url-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bukalapak/url-router/statuses/{sha}","languages_url":"https://api.github.com/repos/bukalapak/url-router/languages","stargazers_url":"https://api.github.com/repos/bukalapak/url-router/stargazers","contributors_url":"https://api.github.com/repos/bukalapak/url-router/contributors","subscribers_url":"https://api.github.com/repos/bukalapak/url-router/subscribers","subscription_url":"https://api.github.com/repos/bukalapak/url-router/subscription","commits_url":"https://api.github.com/repos/bukalapak/url-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/bukalapak/url-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/bukalapak/url-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/bukalapak/url-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/bukalapak/url-router/contents/{+path}","compare_url":"https://api.github.com/repos/bukalapak/url-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bukalapak/url-router/merges","archive_url":"https://api.github.com/repos/bukalapak/url-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bukalapak/url-router/downloads","issues_url":"https://api.github.com/repos/bukalapak/url-router/issues{/number}","pulls_url":"https://api.github.com/repos/bukalapak/url-router/pulls{/number}","milestones_url":"https://api.github.com/repos/bukalapak/url-router/milestones{/number}","notifications_url":"https://api.github.com/repos/bukalapak/url-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bukalapak/url-router/labels{/name}","releases_url":"https://api.github.com/repos/bukalapak/url-router/releases{/id}","deployments_url":"https://api.github.com/repos/bukalapak/url-router/deployments","created_at":"2017-07-06T03:50:24Z","updated_at":"2018-08-03T17:57:24Z","pushed_at":"2018-08-02T05:33:43Z","git_url":"git://github.com/bukalapak/url-router.git","ssh_url":"git@github.com:bukalapak/url-router.git","clone_url":"https://github.com/bukalapak/url-router.git","svn_url":"https://github.com/bukalapak/url-router","homepage":"","size":140,"stargazers_count":2,"watchers_count":2,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"bukalapak:master","ref":"master","sha":"d1265d360d5c90434ab69560e887f99be251c0ca","user":{"login":"bukalapak","id":1088949,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODg5NDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1088949?v=4","gravatar_id":"","url":"https://api.github.com/users/bukalapak","html_url":"https://github.com/bukalapak","followers_url":"https://api.github.com/users/bukalapak/followers","following_url":"https://api.github.com/users/bukalapak/following{/other_user}","gists_url":"https://api.github.com/users/bukalapak/gists{/gist_id}","starred_url":"https://api.github.com/users/bukalapak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bukalapak/subscriptions","organizations_url":"https://api.github.com/users/bukalapak/orgs","repos_url":"https://api.github.com/users/bukalapak/repos","events_url":"https://api.github.com/users/bukalapak/events{/privacy}","received_events_url":"https://api.github.com/users/bukalapak/received_events","type":"Organization","site_admin":false},"repo":{"id":96386137,"node_id":"MDEwOlJlcG9zaXRvcnk5NjM4NjEzNw==","name":"url-router","full_name":"bukalapak/url-router","owner":{"login":"bukalapak","id":1088949,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODg5NDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1088949?v=4","gravatar_id":"","url":"https://api.github.com/users/bukalapak","html_url":"https://github.com/bukalapak","followers_url":"https://api.github.com/users/bukalapak/followers","following_url":"https://api.github.com/users/bukalapak/following{/other_user}","gists_url":"https://api.github.com/users/bukalapak/gists{/gist_id}","starred_url":"https://api.github.com/users/bukalapak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bukalapak/subscriptions","organizations_url":"https://api.github.com/users/bukalapak/orgs","repos_url":"https://api.github.com/users/bukalapak/repos","events_url":"https://api.github.com/users/bukalapak/events{/privacy}","received_events_url":"https://api.github.com/users/bukalapak/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bukalapak/url-router","description":"A wrapper for easily routing URL on Android","fork":false,"url":"https://api.github.com/repos/bukalapak/url-router","forks_url":"https://api.github.com/repos/bukalapak/url-router/forks","keys_url":"https://api.github.com/repos/bukalapak/url-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bukalapak/url-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bukalapak/url-router/teams","hooks_url":"https://api.github.com/repos/bukalapak/url-router/hooks","issue_events_url":"https://api.github.com/repos/bukalapak/url-router/issues/events{/number}","events_url":"https://api.github.com/repos/bukalapak/url-router/events","assignees_url":"https://api.github.com/repos/bukalapak/url-router/assignees{/user}","branches_url":"https://api.github.com/repos/bukalapak/url-router/branches{/branch}","tags_url":"https://api.github.com/repos/bukalapak/url-router/tags","blobs_url":"https://api.github.com/repos/bukalapak/url-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bukalapak/url-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bukalapak/url-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/bukalapak/url-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bukalapak/url-router/statuses/{sha}","languages_url":"https://api.github.com/repos/bukalapak/url-router/languages","stargazers_url":"https://api.github.com/repos/bukalapak/url-router/stargazers","contributors_url":"https://api.github.com/repos/bukalapak/url-router/contributors","subscribers_url":"https://api.github.com/repos/bukalapak/url-router/subscribers","subscription_url":"https://api.github.com/repos/bukalapak/url-router/subscription","commits_url":"https://api.github.com/repos/bukalapak/url-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/bukalapak/url-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/bukalapak/url-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/bukalapak/url-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/bukalapak/url-router/contents/{+path}","compare_url":"https://api.github.com/repos/bukalapak/url-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bukalapak/url-router/merges","archive_url":"https://api.github.com/repos/bukalapak/url-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bukalapak/url-router/downloads","issues_url":"https://api.github.com/repos/bukalapak/url-router/issues{/number}","pulls_url":"https://api.github.com/repos/bukalapak/url-router/pulls{/number}","milestones_url":"https://api.github.com/repos/bukalapak/url-router/milestones{/number}","notifications_url":"https://api.github.com/repos/bukalapak/url-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bukalapak/url-router/labels{/name}","releases_url":"https://api.github.com/repos/bukalapak/url-router/releases{/id}","deployments_url":"https://api.github.com/repos/bukalapak/url-router/deployments","created_at":"2017-07-06T03:50:24Z","updated_at":"2018-08-03T17:57:24Z","pushed_at":"2018-08-02T05:33:43Z","git_url":"git://github.com/bukalapak/url-router.git","ssh_url":"git@github.com:bukalapak/url-router.git","clone_url":"https://github.com/bukalapak/url-router.git","svn_url":"https://github.com/bukalapak/url-router","homepage":"","size":140,"stargazers_count":2,"watchers_count":2,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bukalapak/url-router/pulls/1"},"html":{"href":"https://github.com/bukalapak/url-router/pull/1"},"issue":{"href":"https://api.github.com/repos/bukalapak/url-router/issues/1"},"comments":{"href":"https://api.github.com/repos/bukalapak/url-router/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/bukalapak/url-router/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/bukalapak/url-router/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bukalapak/url-router/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/bukalapak/url-router/statuses/c8e8772be04ba390a7f934d6285eeefbd829e470"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mrhabibi"}}