{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/apm-agent-ruby/pulls/comments/179905154","pull_request_review_id":110243111,"id":179905154,"diff_hunk":"@@ -0,0 +1,124 @@\n+# frozen_string_literal: true","path":"lib/elastic_apm/timed_worker.rb","position":1,"original_position":1,"commit_id":"4fec7176aaaae140517c5c7707f2a827241f7b12","original_commit_id":"6401a8917253eefb3009165a3171e7195e7fb4bb","user":{"login":"mikker","id":2819,"avatar_url":"https://avatars3.githubusercontent.com/u/2819?v=4","gravatar_id":"","url":"https://api.github.com/users/mikker","html_url":"https://github.com/mikker","followers_url":"https://api.github.com/users/mikker/followers","following_url":"https://api.github.com/users/mikker/following{/other_user}","gists_url":"https://api.github.com/users/mikker/gists{/gist_id}","starred_url":"https://api.github.com/users/mikker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikker/subscriptions","organizations_url":"https://api.github.com/users/mikker/orgs","repos_url":"https://api.github.com/users/mikker/repos","events_url":"https://api.github.com/users/mikker/events{/privacy}","received_events_url":"https://api.github.com/users/mikker/received_events","type":"User","site_admin":false},"body":"@Qard I’m hesitant to add dependencies. I’m not completely sure if it’s really a wasted effort but at least I’m putting it off as much as possible.","created_at":"2018-04-07T01:51:56Z","updated_at":"2018-04-07T01:51:56Z","html_url":"https://github.com/elastic/apm-agent-ruby/pull/92#discussion_r179905154","pull_request_url":"https://api.github.com/repos/elastic/apm-agent-ruby/pulls/92","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/elastic/apm-agent-ruby/pulls/comments/179905154"},"html":{"href":"https://github.com/elastic/apm-agent-ruby/pull/92#discussion_r179905154"},"pull_request":{"href":"https://api.github.com/repos/elastic/apm-agent-ruby/pulls/92"}},"in_reply_to_id":179421350},"pull_request":{"url":"https://api.github.com/repos/elastic/apm-agent-ruby/pulls/92","id":179509875,"html_url":"https://github.com/elastic/apm-agent-ruby/pull/92","diff_url":"https://github.com/elastic/apm-agent-ruby/pull/92.diff","patch_url":"https://github.com/elastic/apm-agent-ruby/pull/92.patch","issue_url":"https://api.github.com/repos/elastic/apm-agent-ruby/issues/92","number":92,"state":"open","locked":false,"title":"Replace Worker with TimedWorker","user":{"login":"mikker","id":2819,"avatar_url":"https://avatars3.githubusercontent.com/u/2819?v=4","gravatar_id":"","url":"https://api.github.com/users/mikker","html_url":"https://github.com/mikker","followers_url":"https://api.github.com/users/mikker/followers","following_url":"https://api.github.com/users/mikker/following{/other_user}","gists_url":"https://api.github.com/users/mikker/gists{/gist_id}","starred_url":"https://api.github.com/users/mikker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikker/subscriptions","organizations_url":"https://api.github.com/users/mikker/orgs","repos_url":"https://api.github.com/users/mikker/repos","events_url":"https://api.github.com/users/mikker/events{/privacy}","received_events_url":"https://api.github.com/users/mikker/received_events","type":"User","site_admin":false},"body":"Instead of having to wait for the next incoming req to flush\r\nbatched transactions, TimedWorker will check at least every\r\nflush_interval.\r\n\r\nWould love to hear what you think of the approach, @simitt @Qard.","created_at":"2018-04-04T20:55:02Z","updated_at":"2018-04-07T01:51:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f81a0d9b1aebb796f0da5f1b45ded3bd3502b5b4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/apm-agent-ruby/pulls/92/commits","review_comments_url":"https://api.github.com/repos/elastic/apm-agent-ruby/pulls/92/comments","review_comment_url":"https://api.github.com/repos/elastic/apm-agent-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/apm-agent-ruby/issues/92/comments","statuses_url":"https://api.github.com/repos/elastic/apm-agent-ruby/statuses/4fec7176aaaae140517c5c7707f2a827241f7b12","head":{"label":"elastic:timer-thread","ref":"timer-thread","sha":"4fec7176aaaae140517c5c7707f2a827241f7b12","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":109134055,"name":"apm-agent-ruby","full_name":"elastic/apm-agent-ruby","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/apm-agent-ruby","description":"Elastic APM Ruby Agent (Beta)","fork":false,"url":"https://api.github.com/repos/elastic/apm-agent-ruby","forks_url":"https://api.github.com/repos/elastic/apm-agent-ruby/forks","keys_url":"https://api.github.com/repos/elastic/apm-agent-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/apm-agent-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/apm-agent-ruby/teams","hooks_url":"https://api.github.com/repos/elastic/apm-agent-ruby/hooks","issue_events_url":"https://api.github.com/repos/elastic/apm-agent-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/apm-agent-ruby/events","assignees_url":"https://api.github.com/repos/elastic/apm-agent-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/apm-agent-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/apm-agent-ruby/tags","blobs_url":"https://api.github.com/repos/elastic/apm-agent-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/apm-agent-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/apm-agent-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/apm-agent-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/apm-agent-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/apm-agent-ruby/languages","stargazers_url":"https://api.github.com/repos/elastic/apm-agent-ruby/stargazers","contributors_url":"https://api.github.com/repos/elastic/apm-agent-ruby/contributors","subscribers_url":"https://api.github.com/repos/elastic/apm-agent-ruby/subscribers","subscription_url":"https://api.github.com/repos/elastic/apm-agent-ruby/subscription","commits_url":"https://api.github.com/repos/elastic/apm-agent-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/apm-agent-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/apm-agent-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/apm-agent-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/apm-agent-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/apm-agent-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/apm-agent-ruby/merges","archive_url":"https://api.github.com/repos/elastic/apm-agent-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/apm-agent-ruby/downloads","issues_url":"https://api.github.com/repos/elastic/apm-agent-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/apm-agent-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/apm-agent-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/apm-agent-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/apm-agent-ruby/labels{/name}","releases_url":"https://api.github.com/repos/elastic/apm-agent-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/apm-agent-ruby/deployments","created_at":"2017-11-01T13:21:05Z","updated_at":"2018-04-03T13:29:53Z","pushed_at":"2018-04-06T13:21:48Z","git_url":"git://github.com/elastic/apm-agent-ruby.git","ssh_url":"git@github.com:elastic/apm-agent-ruby.git","clone_url":"https://github.com/elastic/apm-agent-ruby.git","svn_url":"https://github.com/elastic/apm-agent-ruby","homepage":"https://www.elastic.co/solutions/apm","size":396,"stargazers_count":19,"watchers_count":19,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":10,"open_issues":9,"watchers":19,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"1ce1acc3254fd9c1a2bbdec5c897b4db45a46dd0","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":109134055,"name":"apm-agent-ruby","full_name":"elastic/apm-agent-ruby","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/apm-agent-ruby","description":"Elastic APM Ruby Agent (Beta)","fork":false,"url":"https://api.github.com/repos/elastic/apm-agent-ruby","forks_url":"https://api.github.com/repos/elastic/apm-agent-ruby/forks","keys_url":"https://api.github.com/repos/elastic/apm-agent-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/apm-agent-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/apm-agent-ruby/teams","hooks_url":"https://api.github.com/repos/elastic/apm-agent-ruby/hooks","issue_events_url":"https://api.github.com/repos/elastic/apm-agent-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/apm-agent-ruby/events","assignees_url":"https://api.github.com/repos/elastic/apm-agent-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/apm-agent-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/apm-agent-ruby/tags","blobs_url":"https://api.github.com/repos/elastic/apm-agent-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/apm-agent-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/apm-agent-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/apm-agent-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/apm-agent-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/apm-agent-ruby/languages","stargazers_url":"https://api.github.com/repos/elastic/apm-agent-ruby/stargazers","contributors_url":"https://api.github.com/repos/elastic/apm-agent-ruby/contributors","subscribers_url":"https://api.github.com/repos/elastic/apm-agent-ruby/subscribers","subscription_url":"https://api.github.com/repos/elastic/apm-agent-ruby/subscription","commits_url":"https://api.github.com/repos/elastic/apm-agent-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/apm-agent-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/apm-agent-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/apm-agent-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/apm-agent-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/apm-agent-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/apm-agent-ruby/merges","archive_url":"https://api.github.com/repos/elastic/apm-agent-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/apm-agent-ruby/downloads","issues_url":"https://api.github.com/repos/elastic/apm-agent-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/apm-agent-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/apm-agent-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/apm-agent-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/apm-agent-ruby/labels{/name}","releases_url":"https://api.github.com/repos/elastic/apm-agent-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/apm-agent-ruby/deployments","created_at":"2017-11-01T13:21:05Z","updated_at":"2018-04-03T13:29:53Z","pushed_at":"2018-04-06T13:21:48Z","git_url":"git://github.com/elastic/apm-agent-ruby.git","ssh_url":"git@github.com:elastic/apm-agent-ruby.git","clone_url":"https://github.com/elastic/apm-agent-ruby.git","svn_url":"https://github.com/elastic/apm-agent-ruby","homepage":"https://www.elastic.co/solutions/apm","size":396,"stargazers_count":19,"watchers_count":19,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":10,"open_issues":9,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/apm-agent-ruby/pulls/92"},"html":{"href":"https://github.com/elastic/apm-agent-ruby/pull/92"},"issue":{"href":"https://api.github.com/repos/elastic/apm-agent-ruby/issues/92"},"comments":{"href":"https://api.github.com/repos/elastic/apm-agent-ruby/issues/92/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/apm-agent-ruby/pulls/92/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/apm-agent-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/apm-agent-ruby/pulls/92/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/apm-agent-ruby/statuses/4fec7176aaaae140517c5c7707f2a827241f7b12"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mikker"}}