{"action":"closed","issue":{"url":"https://api.github.com/repos/go-gitea/gitea/issues/4732","repository_url":"https://api.github.com/repos/go-gitea/gitea","labels_url":"https://api.github.com/repos/go-gitea/gitea/issues/4732/labels{/name}","comments_url":"https://api.github.com/repos/go-gitea/gitea/issues/4732/comments","events_url":"https://api.github.com/repos/go-gitea/gitea/issues/4732/events","html_url":"https://github.com/go-gitea/gitea/issues/4732","id":351290782,"node_id":"MDU6SXNzdWUzNTEyOTA3ODI=","number":4732,"title":"Webhook for \"Issue Comment\" contains no secret","user":{"login":"maltehol","id":18170619,"node_id":"MDQ6VXNlcjE4MTcwNjE5","avatar_url":"https://avatars3.githubusercontent.com/u/18170619?v=4","gravatar_id":"","url":"https://api.github.com/users/maltehol","html_url":"https://github.com/maltehol","followers_url":"https://api.github.com/users/maltehol/followers","following_url":"https://api.github.com/users/maltehol/following{/other_user}","gists_url":"https://api.github.com/users/maltehol/gists{/gist_id}","starred_url":"https://api.github.com/users/maltehol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maltehol/subscriptions","organizations_url":"https://api.github.com/users/maltehol/orgs","repos_url":"https://api.github.com/users/maltehol/repos","events_url":"https://api.github.com/users/maltehol/events{/privacy}","received_events_url":"https://api.github.com/users/maltehol/received_events","type":"User","site_admin":false},"labels":[{"id":472744938,"node_id":"MDU6TGFiZWw0NzI3NDQ5Mzg=","url":"https://api.github.com/repos/go-gitea/gitea/labels/kind/bug","name":"kind/bug","color":"ee0701","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/go-gitea/gitea/milestones/28","html_url":"https://github.com/go-gitea/gitea/milestone/28","labels_url":"https://api.github.com/repos/go-gitea/gitea/milestones/28/labels","id":3604129,"node_id":"MDk6TWlsZXN0b25lMzYwNDEyOQ==","number":28,"title":"1.7.0","description":"","creator":{"login":"lunny","id":81045,"node_id":"MDQ6VXNlcjgxMDQ1","avatar_url":"https://avatars2.githubusercontent.com/u/81045?v=4","gravatar_id":"","url":"https://api.github.com/users/lunny","html_url":"https://github.com/lunny","followers_url":"https://api.github.com/users/lunny/followers","following_url":"https://api.github.com/users/lunny/following{/other_user}","gists_url":"https://api.github.com/users/lunny/gists{/gist_id}","starred_url":"https://api.github.com/users/lunny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunny/subscriptions","organizations_url":"https://api.github.com/users/lunny/orgs","repos_url":"https://api.github.com/users/lunny/repos","events_url":"https://api.github.com/users/lunny/events{/privacy}","received_events_url":"https://api.github.com/users/lunny/received_events","type":"User","site_admin":false},"open_issues":104,"closed_issues":41,"state":"open","created_at":"2018-08-28T14:20:14Z","updated_at":"2018-10-28T22:03:03Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2018-08-16T17:03:43Z","updated_at":"2018-10-28T22:03:03Z","closed_at":"2018-10-28T22:03:03Z","author_association":"NONE","body":"<!--\r\n    1. Please speak English, this is the language all of us can speak and write.\r\n    2. Please ask questions or configuration/deploy problems on our Discord \r\n       server (https://discord.gg/NsatcWJ) or forum (https://discourse.gitea.io).\r\n    3. Please take a moment to check that your issue doesn't already exist.\r\n    4. Please give all relevant information below for bug reports, because \r\n       incomplete details will be handled as an invalid report.\r\n-->\r\n\r\n- Gitea version (or commit ref): 1.5\r\n- Git version: 2.1.4\r\n- Operating system: Raspbian\r\n- Database (use `[x]`):\r\n  - [ ] PostgreSQL\r\n  - [x] MySQL (MariaDB)\r\n  - [ ] MSSQL\r\n  - [ ] SQLite\r\n- Can you reproduce the bug at https://try.gitea.io:\r\n  - [ ] Yes (provide example URL)\r\n  - [ ] No\r\n  - [x] Not relevant\r\n- Log gist:\r\n\r\n## Description\r\nWhen setting up webhooks in gitea, I expect that every hook uses the secret one chooses.\r\nBut for `issue_comment` there is no `secret` field in the json which is send out.\r\n\r\nThe send json:\r\n```json\r\n{\r\n  \"action\": \"created\",\r\n  \"issue\": {\r\n    \"id\": 23,\r\n    \"url\": \"<url>\",\r\n    \"number\": 11,\r\n    \"user\": {\r\n      // User Object\r\n    },\r\n    \"title\": \"123\",\r\n    \"body\": \"\",\r\n    \"labels\": [],\r\n    \"milestone\": null,\r\n    \"assignee\": null,\r\n    \"assignees\": null,\r\n    \"state\": \"open\",\r\n    \"comments\": 0,\r\n    \"created_at\": \"2018-08-13T08:39:29Z\",\r\n    \"updated_at\": \"2018-08-16T16:44:36Z\",\r\n    \"closed_at\": null,\r\n    \"due_date\": null,\r\n    \"pull_request\": null\r\n  },\r\n  \"comment\": {\r\n    \"id\": 42,\r\n    \"html_url\": \"<html_url>\",\r\n    \"pull_request_url\": \"\",\r\n    \"issue_url\": \"<issue_url>\",\r\n    \"user\": {\r\n      // User object\r\n    },\r\n    \"body\": \"No secret?\",\r\n    \"created_at\": \"2018-08-16T16:44:36Z\",\r\n    \"updated_at\": \"2018-08-16T16:44:36Z\"\r\n  },\r\n  \"repository\": {\r\n    \"id\": 6,\r\n    \"owner\": {\r\n      // User object\r\n    },\r\n    \"name\": \"hook-test\",\r\n    \"full_name\": \"mh/hook-test\",\r\n    \"description\": \"\",\r\n    \"empty\": false,\r\n    \"private\": true,\r\n    \"fork\": false,\r\n    \"parent\": null,\r\n    \"mirror\": false,\r\n    \"size\": 128,\r\n    \"html_url\": \"<html_url>\",\r\n    \"ssh_url\": \"<ssh_url>\",\r\n    \"clone_url\": \"<clone_url>\",\r\n    \"website\": \"\",\r\n    \"stars_count\": 0,\r\n    \"forks_count\": 0,\r\n    \"watchers_count\": 1,\r\n    \"open_issues_count\": 7,\r\n    \"default_branch\": \"master\",\r\n    \"created_at\": \"2018-08-12T09:50:19Z\",\r\n    \"updated_at\": \"2018-08-13T10:59:50Z\",\r\n    \"permissions\": {\r\n      \"admin\": true,\r\n      \"push\": true,\r\n      \"pull\": true\r\n    }\r\n  },\r\n  \"sender\": {\r\n    // User object\r\n  }\r\n}\r\n```\r\n\r\nTo reproduce:\r\n* Create a webhook in gitea, choose  \"Custom Events....\" -> \"Issue Comment\"\r\n* Add a comment to a arbitrary issue in that repo\r\n* Edit the webhook and look at \"Recent Deliveries\"\r\n"}}
{"actor":{"display_login":"techknowlogick"}}