{"action":"created","comment":{"url":"https://api.github.com/repos/ualbertalib/jupiter/pulls/comments/192183815","pull_request_review_id":124910546,"id":192183815,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjE4MzgxNQ==","diff_hunk":"@@ -159,9 +159,9 @@ def reify_result_set\n \n   def sort_clause\n     model = criteria[:restrict_to_model].first.owning_class\n-    indexes = criteria[:sort].present? ? criteria[:sort] : model.default_sort_indexes\n+    indexes = criteria[:sort].presence || model.default_sort_indexes","path":"app/models/jupiter_core/deferred_faceted_solr_query.rb","position":5,"original_position":5,"commit_id":"e1955a7880986b875c90cd301d34a84ce79a333f","original_commit_id":"f2c89a6ae8fe2951d342f6d65984799ee058bc5d","user":{"login":"mbarnett","id":51773,"node_id":"MDQ6VXNlcjUxNzcz","avatar_url":"https://avatars1.githubusercontent.com/u/51773?v=4","gravatar_id":"","url":"https://api.github.com/users/mbarnett","html_url":"https://github.com/mbarnett","followers_url":"https://api.github.com/users/mbarnett/followers","following_url":"https://api.github.com/users/mbarnett/following{/other_user}","gists_url":"https://api.github.com/users/mbarnett/gists{/gist_id}","starred_url":"https://api.github.com/users/mbarnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbarnett/subscriptions","organizations_url":"https://api.github.com/users/mbarnett/orgs","repos_url":"https://api.github.com/users/mbarnett/repos","events_url":"https://api.github.com/users/mbarnett/events{/privacy}","received_events_url":"https://api.github.com/users/mbarnett/received_events","type":"User","site_admin":false},"body":"@cjwant || @pgwillia ? Any strong feelings? I can learn to live with this, I just don't find it terribly obvious.","created_at":"2018-05-31T17:52:54Z","updated_at":"2018-05-31T17:52:55Z","html_url":"https://github.com/ualbertalib/jupiter/pull/735#discussion_r192183815","pull_request_url":"https://api.github.com/repos/ualbertalib/jupiter/pulls/735","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ualbertalib/jupiter/pulls/comments/192183815"},"html":{"href":"https://github.com/ualbertalib/jupiter/pull/735#discussion_r192183815"},"pull_request":{"href":"https://api.github.com/repos/ualbertalib/jupiter/pulls/735"}},"in_reply_to_id":192172028},"pull_request":{"url":"https://api.github.com/repos/ualbertalib/jupiter/pulls/735","id":190995444,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwOTk1NDQ0","html_url":"https://github.com/ualbertalib/jupiter/pull/735","diff_url":"https://github.com/ualbertalib/jupiter/pull/735.diff","patch_url":"https://github.com/ualbertalib/jupiter/pull/735.patch","issue_url":"https://api.github.com/repos/ualbertalib/jupiter/issues/735","number":735,"state":"open","locked":false,"title":"Update Rubocop and fix offenses","user":{"login":"murny","id":1930474,"node_id":"MDQ6VXNlcjE5MzA0NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1930474?v=4","gravatar_id":"","url":"https://api.github.com/users/murny","html_url":"https://github.com/murny","followers_url":"https://api.github.com/users/murny/followers","following_url":"https://api.github.com/users/murny/following{/other_user}","gists_url":"https://api.github.com/users/murny/gists{/gist_id}","starred_url":"https://api.github.com/users/murny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murny/subscriptions","organizations_url":"https://api.github.com/users/murny/orgs","repos_url":"https://api.github.com/users/murny/repos","events_url":"https://api.github.com/users/murny/events{/privacy}","received_events_url":"https://api.github.com/users/murny/received_events","type":"User","site_admin":false},"body":"- Upgrade Rubocop from 0.51 to 0.56","created_at":"2018-05-28T20:54:00Z","updated_at":"2018-05-31T17:52:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c83ccbb9cb6a3ac6fb337fc721533fd10053e5ec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":873729577,"node_id":"MDU6TGFiZWw4NzM3Mjk1Nzc=","url":"https://api.github.com/repos/ualbertalib/jupiter/labels/needs-review","name":"needs-review","color":"262cad","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ualbertalib/jupiter/pulls/735/commits","review_comments_url":"https://api.github.com/repos/ualbertalib/jupiter/pulls/735/comments","review_comment_url":"https://api.github.com/repos/ualbertalib/jupiter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ualbertalib/jupiter/issues/735/comments","statuses_url":"https://api.github.com/repos/ualbertalib/jupiter/statuses/e1955a7880986b875c90cd301d34a84ce79a333f","head":{"label":"murny:rubocop-upgrade","ref":"rubocop-upgrade","sha":"e1955a7880986b875c90cd301d34a84ce79a333f","user":{"login":"murny","id":1930474,"node_id":"MDQ6VXNlcjE5MzA0NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1930474?v=4","gravatar_id":"","url":"https://api.github.com/users/murny","html_url":"https://github.com/murny","followers_url":"https://api.github.com/users/murny/followers","following_url":"https://api.github.com/users/murny/following{/other_user}","gists_url":"https://api.github.com/users/murny/gists{/gist_id}","starred_url":"https://api.github.com/users/murny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murny/subscriptions","organizations_url":"https://api.github.com/users/murny/orgs","repos_url":"https://api.github.com/users/murny/repos","events_url":"https://api.github.com/users/murny/events{/privacy}","received_events_url":"https://api.github.com/users/murny/received_events","type":"User","site_admin":false},"repo":{"id":96910081,"node_id":"MDEwOlJlcG9zaXRvcnk5NjkxMDA4MQ==","name":"jupiter","full_name":"murny/jupiter","owner":{"login":"murny","id":1930474,"node_id":"MDQ6VXNlcjE5MzA0NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1930474?v=4","gravatar_id":"","url":"https://api.github.com/users/murny","html_url":"https://github.com/murny","followers_url":"https://api.github.com/users/murny/followers","following_url":"https://api.github.com/users/murny/following{/other_user}","gists_url":"https://api.github.com/users/murny/gists{/gist_id}","starred_url":"https://api.github.com/users/murny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murny/subscriptions","organizations_url":"https://api.github.com/users/murny/orgs","repos_url":"https://api.github.com/users/murny/repos","events_url":"https://api.github.com/users/murny/events{/privacy}","received_events_url":"https://api.github.com/users/murny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/murny/jupiter","description":"An experiment","fork":true,"url":"https://api.github.com/repos/murny/jupiter","forks_url":"https://api.github.com/repos/murny/jupiter/forks","keys_url":"https://api.github.com/repos/murny/jupiter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/murny/jupiter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/murny/jupiter/teams","hooks_url":"https://api.github.com/repos/murny/jupiter/hooks","issue_events_url":"https://api.github.com/repos/murny/jupiter/issues/events{/number}","events_url":"https://api.github.com/repos/murny/jupiter/events","assignees_url":"https://api.github.com/repos/murny/jupiter/assignees{/user}","branches_url":"https://api.github.com/repos/murny/jupiter/branches{/branch}","tags_url":"https://api.github.com/repos/murny/jupiter/tags","blobs_url":"https://api.github.com/repos/murny/jupiter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/murny/jupiter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/murny/jupiter/git/refs{/sha}","trees_url":"https://api.github.com/repos/murny/jupiter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/murny/jupiter/statuses/{sha}","languages_url":"https://api.github.com/repos/murny/jupiter/languages","stargazers_url":"https://api.github.com/repos/murny/jupiter/stargazers","contributors_url":"https://api.github.com/repos/murny/jupiter/contributors","subscribers_url":"https://api.github.com/repos/murny/jupiter/subscribers","subscription_url":"https://api.github.com/repos/murny/jupiter/subscription","commits_url":"https://api.github.com/repos/murny/jupiter/commits{/sha}","git_commits_url":"https://api.github.com/repos/murny/jupiter/git/commits{/sha}","comments_url":"https://api.github.com/repos/murny/jupiter/comments{/number}","issue_comment_url":"https://api.github.com/repos/murny/jupiter/issues/comments{/number}","contents_url":"https://api.github.com/repos/murny/jupiter/contents/{+path}","compare_url":"https://api.github.com/repos/murny/jupiter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/murny/jupiter/merges","archive_url":"https://api.github.com/repos/murny/jupiter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/murny/jupiter/downloads","issues_url":"https://api.github.com/repos/murny/jupiter/issues{/number}","pulls_url":"https://api.github.com/repos/murny/jupiter/pulls{/number}","milestones_url":"https://api.github.com/repos/murny/jupiter/milestones{/number}","notifications_url":"https://api.github.com/repos/murny/jupiter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/murny/jupiter/labels{/name}","releases_url":"https://api.github.com/repos/murny/jupiter/releases{/id}","deployments_url":"https://api.github.com/repos/murny/jupiter/deployments","created_at":"2017-07-11T15:44:36Z","updated_at":"2018-05-28T19:44:22Z","pushed_at":"2018-05-31T17:39:58Z","git_url":"git://github.com/murny/jupiter.git","ssh_url":"git@github.com:murny/jupiter.git","clone_url":"https://github.com/murny/jupiter.git","svn_url":"https://github.com/murny/jupiter","homepage":"","size":2504,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ualbertalib:master","ref":"master","sha":"e082a51e6191c99fc26a0d4028e7724bbe187fdc","user":{"login":"ualbertalib","id":2856757,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTY3NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2856757?v=4","gravatar_id":"","url":"https://api.github.com/users/ualbertalib","html_url":"https://github.com/ualbertalib","followers_url":"https://api.github.com/users/ualbertalib/followers","following_url":"https://api.github.com/users/ualbertalib/following{/other_user}","gists_url":"https://api.github.com/users/ualbertalib/gists{/gist_id}","starred_url":"https://api.github.com/users/ualbertalib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ualbertalib/subscriptions","organizations_url":"https://api.github.com/users/ualbertalib/orgs","repos_url":"https://api.github.com/users/ualbertalib/repos","events_url":"https://api.github.com/users/ualbertalib/events{/privacy}","received_events_url":"https://api.github.com/users/ualbertalib/received_events","type":"Organization","site_admin":false},"repo":{"id":94144356,"node_id":"MDEwOlJlcG9zaXRvcnk5NDE0NDM1Ng==","name":"jupiter","full_name":"ualbertalib/jupiter","owner":{"login":"ualbertalib","id":2856757,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTY3NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2856757?v=4","gravatar_id":"","url":"https://api.github.com/users/ualbertalib","html_url":"https://github.com/ualbertalib","followers_url":"https://api.github.com/users/ualbertalib/followers","following_url":"https://api.github.com/users/ualbertalib/following{/other_user}","gists_url":"https://api.github.com/users/ualbertalib/gists{/gist_id}","starred_url":"https://api.github.com/users/ualbertalib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ualbertalib/subscriptions","organizations_url":"https://api.github.com/users/ualbertalib/orgs","repos_url":"https://api.github.com/users/ualbertalib/repos","events_url":"https://api.github.com/users/ualbertalib/events{/privacy}","received_events_url":"https://api.github.com/users/ualbertalib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ualbertalib/jupiter","description":"Jupiter is a University of Alberta Libraries-based initiative to create a sustainable and extensible digital asset management system. This is phase 1 (IR).","fork":false,"url":"https://api.github.com/repos/ualbertalib/jupiter","forks_url":"https://api.github.com/repos/ualbertalib/jupiter/forks","keys_url":"https://api.github.com/repos/ualbertalib/jupiter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ualbertalib/jupiter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ualbertalib/jupiter/teams","hooks_url":"https://api.github.com/repos/ualbertalib/jupiter/hooks","issue_events_url":"https://api.github.com/repos/ualbertalib/jupiter/issues/events{/number}","events_url":"https://api.github.com/repos/ualbertalib/jupiter/events","assignees_url":"https://api.github.com/repos/ualbertalib/jupiter/assignees{/user}","branches_url":"https://api.github.com/repos/ualbertalib/jupiter/branches{/branch}","tags_url":"https://api.github.com/repos/ualbertalib/jupiter/tags","blobs_url":"https://api.github.com/repos/ualbertalib/jupiter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ualbertalib/jupiter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ualbertalib/jupiter/git/refs{/sha}","trees_url":"https://api.github.com/repos/ualbertalib/jupiter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ualbertalib/jupiter/statuses/{sha}","languages_url":"https://api.github.com/repos/ualbertalib/jupiter/languages","stargazers_url":"https://api.github.com/repos/ualbertalib/jupiter/stargazers","contributors_url":"https://api.github.com/repos/ualbertalib/jupiter/contributors","subscribers_url":"https://api.github.com/repos/ualbertalib/jupiter/subscribers","subscription_url":"https://api.github.com/repos/ualbertalib/jupiter/subscription","commits_url":"https://api.github.com/repos/ualbertalib/jupiter/commits{/sha}","git_commits_url":"https://api.github.com/repos/ualbertalib/jupiter/git/commits{/sha}","comments_url":"https://api.github.com/repos/ualbertalib/jupiter/comments{/number}","issue_comment_url":"https://api.github.com/repos/ualbertalib/jupiter/issues/comments{/number}","contents_url":"https://api.github.com/repos/ualbertalib/jupiter/contents/{+path}","compare_url":"https://api.github.com/repos/ualbertalib/jupiter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ualbertalib/jupiter/merges","archive_url":"https://api.github.com/repos/ualbertalib/jupiter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ualbertalib/jupiter/downloads","issues_url":"https://api.github.com/repos/ualbertalib/jupiter/issues{/number}","pulls_url":"https://api.github.com/repos/ualbertalib/jupiter/pulls{/number}","milestones_url":"https://api.github.com/repos/ualbertalib/jupiter/milestones{/number}","notifications_url":"https://api.github.com/repos/ualbertalib/jupiter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ualbertalib/jupiter/labels{/name}","releases_url":"https://api.github.com/repos/ualbertalib/jupiter/releases{/id}","deployments_url":"https://api.github.com/repos/ualbertalib/jupiter/deployments","created_at":"2017-06-12T22:00:01Z","updated_at":"2018-05-28T19:41:24Z","pushed_at":"2018-05-31T17:40:01Z","git_url":"git://github.com/ualbertalib/jupiter.git","ssh_url":"git@github.com:ualbertalib/jupiter.git","clone_url":"https://github.com/ualbertalib/jupiter.git","svn_url":"https://github.com/ualbertalib/jupiter","homepage":"https://era.library.ualberta.ca/","size":2495,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":66,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ualbertalib/jupiter/pulls/735"},"html":{"href":"https://github.com/ualbertalib/jupiter/pull/735"},"issue":{"href":"https://api.github.com/repos/ualbertalib/jupiter/issues/735"},"comments":{"href":"https://api.github.com/repos/ualbertalib/jupiter/issues/735/comments"},"review_comments":{"href":"https://api.github.com/repos/ualbertalib/jupiter/pulls/735/comments"},"review_comment":{"href":"https://api.github.com/repos/ualbertalib/jupiter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ualbertalib/jupiter/pulls/735/commits"},"statuses":{"href":"https://api.github.com/repos/ualbertalib/jupiter/statuses/e1955a7880986b875c90cd301d34a84ce79a333f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mbarnett"}}