{"action":"created","comment":{"url":"https://api.github.com/repos/mugoweb/ezflow/pulls/comments/236723123","pull_request_review_id":178856516,"id":236723123,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjcyMzEyMw==","diff_hunk":"@@ -156,7 +156,9 @@\n         {undef $loop_count}\n     {/if}\n     {if and( not( $is_dynamic ), not( $is_custom ) )}\n+        {def $start_browse_node_id = first_set( ezini( $block.type, 'ManualBlockStartBrowseNode', 'block.ini' ), 2 )}","path":"packages/ezflow_extension/ezextension/ezflow/design/standard/templates/block/edit/edit.tpl","position":4,"original_position":4,"commit_id":"798471bae3fe8cfa4c14e90110d41c222b1331b0","original_commit_id":"798471bae3fe8cfa4c14e90110d41c222b1331b0","user":{"login":"peterkeung","id":575638,"node_id":"MDQ6VXNlcjU3NTYzOA==","avatar_url":"https://avatars3.githubusercontent.com/u/575638?v=4","gravatar_id":"","url":"https://api.github.com/users/peterkeung","html_url":"https://github.com/peterkeung","followers_url":"https://api.github.com/users/peterkeung/followers","following_url":"https://api.github.com/users/peterkeung/following{/other_user}","gists_url":"https://api.github.com/users/peterkeung/gists{/gist_id}","starred_url":"https://api.github.com/users/peterkeung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterkeung/subscriptions","organizations_url":"https://api.github.com/users/peterkeung/orgs","repos_url":"https://api.github.com/users/peterkeung/repos","events_url":"https://api.github.com/users/peterkeung/events{/privacy}","received_events_url":"https://api.github.com/users/peterkeung/received_events","type":"User","site_admin":false},"body":"I wouldn't default to \"2\", because this changes the behavior. Instead, only output the hidden input field if the INI value is set.\r\n\r\n(eZContentBrowse has its own INI fallback.)\r\n\r\nTechnically this is also a BC break if you have an override of block/edit/edit.tpl already. You would lose the ManualBlockStartBrowseNode effect. I would have put the fallback ManualBlockStartBrowseNode logic into PHP:\r\n\r\n```\r\nif( $http->hasVariable( 'start-browse-node-id' ) )\r\n...\r\nelseif( $blockINI->hasVariable( $block->attribute( 'type' ), 'ManualBlockStartBrowseNode' ) )\r\n...\r\n```\r\n\r\n... then the template just has a commented out hidden input field for a developer to use or not.","created_at":"2018-11-27T15:47:01Z","updated_at":"2018-11-27T15:47:01Z","html_url":"https://github.com/mugoweb/ezflow/pull/2#discussion_r236723123","pull_request_url":"https://api.github.com/repos/mugoweb/ezflow/pulls/2","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mugoweb/ezflow/pulls/comments/236723123"},"html":{"href":"https://github.com/mugoweb/ezflow/pull/2#discussion_r236723123"},"pull_request":{"href":"https://api.github.com/repos/mugoweb/ezflow/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/mugoweb/ezflow/pulls/2","id":233909948,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzOTA5OTQ4","html_url":"https://github.com/mugoweb/ezflow/pull/2","diff_url":"https://github.com/mugoweb/ezflow/pull/2.diff","patch_url":"https://github.com/mugoweb/ezflow/pull/2.patch","issue_url":"https://api.github.com/repos/mugoweb/ezflow/issues/2","number":2,"state":"open","locked":false,"title":"Allow browse start node id to be specified in the template","user":{"login":"pkamps","id":971684,"node_id":"MDQ6VXNlcjk3MTY4NA==","avatar_url":"https://avatars1.githubusercontent.com/u/971684?v=4","gravatar_id":"","url":"https://api.github.com/users/pkamps","html_url":"https://github.com/pkamps","followers_url":"https://api.github.com/users/pkamps/followers","following_url":"https://api.github.com/users/pkamps/following{/other_user}","gists_url":"https://api.github.com/users/pkamps/gists{/gist_id}","starred_url":"https://api.github.com/users/pkamps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkamps/subscriptions","organizations_url":"https://api.github.com/users/pkamps/orgs","repos_url":"https://api.github.com/users/pkamps/repos","events_url":"https://api.github.com/users/pkamps/events{/privacy}","received_events_url":"https://api.github.com/users/pkamps/received_events","type":"User","site_admin":false},"body":"- placeholder -","created_at":"2018-11-27T13:26:25Z","updated_at":"2018-11-27T15:47:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"692c05ae974474fede26c9b6a7ac7013fb7ecdce","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mugoweb/ezflow/pulls/2/commits","review_comments_url":"https://api.github.com/repos/mugoweb/ezflow/pulls/2/comments","review_comment_url":"https://api.github.com/repos/mugoweb/ezflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mugoweb/ezflow/issues/2/comments","statuses_url":"https://api.github.com/repos/mugoweb/ezflow/statuses/798471bae3fe8cfa4c14e90110d41c222b1331b0","head":{"label":"mugoweb:start_browse_node_template","ref":"start_browse_node_template","sha":"798471bae3fe8cfa4c14e90110d41c222b1331b0","user":{"login":"mugoweb","id":1810994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTA5OTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1810994?v=4","gravatar_id":"","url":"https://api.github.com/users/mugoweb","html_url":"https://github.com/mugoweb","followers_url":"https://api.github.com/users/mugoweb/followers","following_url":"https://api.github.com/users/mugoweb/following{/other_user}","gists_url":"https://api.github.com/users/mugoweb/gists{/gist_id}","starred_url":"https://api.github.com/users/mugoweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mugoweb/subscriptions","organizations_url":"https://api.github.com/users/mugoweb/orgs","repos_url":"https://api.github.com/users/mugoweb/repos","events_url":"https://api.github.com/users/mugoweb/events{/privacy}","received_events_url":"https://api.github.com/users/mugoweb/received_events","type":"Organization","site_admin":false},"repo":{"id":75715660,"node_id":"MDEwOlJlcG9zaXRvcnk3NTcxNTY2MA==","name":"ezflow","full_name":"mugoweb/ezflow","private":false,"owner":{"login":"mugoweb","id":1810994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTA5OTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1810994?v=4","gravatar_id":"","url":"https://api.github.com/users/mugoweb","html_url":"https://github.com/mugoweb","followers_url":"https://api.github.com/users/mugoweb/followers","following_url":"https://api.github.com/users/mugoweb/following{/other_user}","gists_url":"https://api.github.com/users/mugoweb/gists{/gist_id}","starred_url":"https://api.github.com/users/mugoweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mugoweb/subscriptions","organizations_url":"https://api.github.com/users/mugoweb/orgs","repos_url":"https://api.github.com/users/mugoweb/repos","events_url":"https://api.github.com/users/mugoweb/events{/privacy}","received_events_url":"https://api.github.com/users/mugoweb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mugoweb/ezflow","description":null,"fork":true,"url":"https://api.github.com/repos/mugoweb/ezflow","forks_url":"https://api.github.com/repos/mugoweb/ezflow/forks","keys_url":"https://api.github.com/repos/mugoweb/ezflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mugoweb/ezflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mugoweb/ezflow/teams","hooks_url":"https://api.github.com/repos/mugoweb/ezflow/hooks","issue_events_url":"https://api.github.com/repos/mugoweb/ezflow/issues/events{/number}","events_url":"https://api.github.com/repos/mugoweb/ezflow/events","assignees_url":"https://api.github.com/repos/mugoweb/ezflow/assignees{/user}","branches_url":"https://api.github.com/repos/mugoweb/ezflow/branches{/branch}","tags_url":"https://api.github.com/repos/mugoweb/ezflow/tags","blobs_url":"https://api.github.com/repos/mugoweb/ezflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mugoweb/ezflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mugoweb/ezflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/mugoweb/ezflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mugoweb/ezflow/statuses/{sha}","languages_url":"https://api.github.com/repos/mugoweb/ezflow/languages","stargazers_url":"https://api.github.com/repos/mugoweb/ezflow/stargazers","contributors_url":"https://api.github.com/repos/mugoweb/ezflow/contributors","subscribers_url":"https://api.github.com/repos/mugoweb/ezflow/subscribers","subscription_url":"https://api.github.com/repos/mugoweb/ezflow/subscription","commits_url":"https://api.github.com/repos/mugoweb/ezflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/mugoweb/ezflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/mugoweb/ezflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/mugoweb/ezflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/mugoweb/ezflow/contents/{+path}","compare_url":"https://api.github.com/repos/mugoweb/ezflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mugoweb/ezflow/merges","archive_url":"https://api.github.com/repos/mugoweb/ezflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mugoweb/ezflow/downloads","issues_url":"https://api.github.com/repos/mugoweb/ezflow/issues{/number}","pulls_url":"https://api.github.com/repos/mugoweb/ezflow/pulls{/number}","milestones_url":"https://api.github.com/repos/mugoweb/ezflow/milestones{/number}","notifications_url":"https://api.github.com/repos/mugoweb/ezflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mugoweb/ezflow/labels{/name}","releases_url":"https://api.github.com/repos/mugoweb/ezflow/releases{/id}","deployments_url":"https://api.github.com/repos/mugoweb/ezflow/deployments","created_at":"2016-12-06T09:25:59Z","updated_at":"2018-11-27T12:52:19Z","pushed_at":"2018-11-27T13:26:25Z","git_url":"git://github.com/mugoweb/ezflow.git","ssh_url":"git@github.com:mugoweb/ezflow.git","clone_url":"https://github.com/mugoweb/ezflow.git","svn_url":"https://github.com/mugoweb/ezflow","homepage":"","size":29369,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"mugoweb:master","ref":"master","sha":"f98602260768e1738a84a2368d1f1294d5e5194f","user":{"login":"mugoweb","id":1810994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTA5OTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1810994?v=4","gravatar_id":"","url":"https://api.github.com/users/mugoweb","html_url":"https://github.com/mugoweb","followers_url":"https://api.github.com/users/mugoweb/followers","following_url":"https://api.github.com/users/mugoweb/following{/other_user}","gists_url":"https://api.github.com/users/mugoweb/gists{/gist_id}","starred_url":"https://api.github.com/users/mugoweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mugoweb/subscriptions","organizations_url":"https://api.github.com/users/mugoweb/orgs","repos_url":"https://api.github.com/users/mugoweb/repos","events_url":"https://api.github.com/users/mugoweb/events{/privacy}","received_events_url":"https://api.github.com/users/mugoweb/received_events","type":"Organization","site_admin":false},"repo":{"id":75715660,"node_id":"MDEwOlJlcG9zaXRvcnk3NTcxNTY2MA==","name":"ezflow","full_name":"mugoweb/ezflow","private":false,"owner":{"login":"mugoweb","id":1810994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTA5OTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1810994?v=4","gravatar_id":"","url":"https://api.github.com/users/mugoweb","html_url":"https://github.com/mugoweb","followers_url":"https://api.github.com/users/mugoweb/followers","following_url":"https://api.github.com/users/mugoweb/following{/other_user}","gists_url":"https://api.github.com/users/mugoweb/gists{/gist_id}","starred_url":"https://api.github.com/users/mugoweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mugoweb/subscriptions","organizations_url":"https://api.github.com/users/mugoweb/orgs","repos_url":"https://api.github.com/users/mugoweb/repos","events_url":"https://api.github.com/users/mugoweb/events{/privacy}","received_events_url":"https://api.github.com/users/mugoweb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mugoweb/ezflow","description":null,"fork":true,"url":"https://api.github.com/repos/mugoweb/ezflow","forks_url":"https://api.github.com/repos/mugoweb/ezflow/forks","keys_url":"https://api.github.com/repos/mugoweb/ezflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mugoweb/ezflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mugoweb/ezflow/teams","hooks_url":"https://api.github.com/repos/mugoweb/ezflow/hooks","issue_events_url":"https://api.github.com/repos/mugoweb/ezflow/issues/events{/number}","events_url":"https://api.github.com/repos/mugoweb/ezflow/events","assignees_url":"https://api.github.com/repos/mugoweb/ezflow/assignees{/user}","branches_url":"https://api.github.com/repos/mugoweb/ezflow/branches{/branch}","tags_url":"https://api.github.com/repos/mugoweb/ezflow/tags","blobs_url":"https://api.github.com/repos/mugoweb/ezflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mugoweb/ezflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mugoweb/ezflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/mugoweb/ezflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mugoweb/ezflow/statuses/{sha}","languages_url":"https://api.github.com/repos/mugoweb/ezflow/languages","stargazers_url":"https://api.github.com/repos/mugoweb/ezflow/stargazers","contributors_url":"https://api.github.com/repos/mugoweb/ezflow/contributors","subscribers_url":"https://api.github.com/repos/mugoweb/ezflow/subscribers","subscription_url":"https://api.github.com/repos/mugoweb/ezflow/subscription","commits_url":"https://api.github.com/repos/mugoweb/ezflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/mugoweb/ezflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/mugoweb/ezflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/mugoweb/ezflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/mugoweb/ezflow/contents/{+path}","compare_url":"https://api.github.com/repos/mugoweb/ezflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mugoweb/ezflow/merges","archive_url":"https://api.github.com/repos/mugoweb/ezflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mugoweb/ezflow/downloads","issues_url":"https://api.github.com/repos/mugoweb/ezflow/issues{/number}","pulls_url":"https://api.github.com/repos/mugoweb/ezflow/pulls{/number}","milestones_url":"https://api.github.com/repos/mugoweb/ezflow/milestones{/number}","notifications_url":"https://api.github.com/repos/mugoweb/ezflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mugoweb/ezflow/labels{/name}","releases_url":"https://api.github.com/repos/mugoweb/ezflow/releases{/id}","deployments_url":"https://api.github.com/repos/mugoweb/ezflow/deployments","created_at":"2016-12-06T09:25:59Z","updated_at":"2018-11-27T12:52:19Z","pushed_at":"2018-11-27T13:26:25Z","git_url":"git://github.com/mugoweb/ezflow.git","ssh_url":"git@github.com:mugoweb/ezflow.git","clone_url":"https://github.com/mugoweb/ezflow.git","svn_url":"https://github.com/mugoweb/ezflow","homepage":"","size":29369,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mugoweb/ezflow/pulls/2"},"html":{"href":"https://github.com/mugoweb/ezflow/pull/2"},"issue":{"href":"https://api.github.com/repos/mugoweb/ezflow/issues/2"},"comments":{"href":"https://api.github.com/repos/mugoweb/ezflow/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/mugoweb/ezflow/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/mugoweb/ezflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mugoweb/ezflow/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/mugoweb/ezflow/statuses/798471bae3fe8cfa4c14e90110d41c222b1331b0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"peterkeung"}}