{"action":"created","issue":{"url":"https://api.github.com/repos/meteor/meteor/issues/9695","repository_url":"https://api.github.com/repos/meteor/meteor","labels_url":"https://api.github.com/repos/meteor/meteor/issues/9695/labels{/name}","comments_url":"https://api.github.com/repos/meteor/meteor/issues/9695/comments","events_url":"https://api.github.com/repos/meteor/meteor/issues/9695/events","html_url":"https://github.com/meteor/meteor/issues/9695","id":300017423,"number":9695,"title":"Cannot run meteor test-packages anymore on a package","user":{"login":"mitar","id":585279,"avatar_url":"https://avatars3.githubusercontent.com/u/585279?v=4","gravatar_id":"","url":"https://api.github.com/users/mitar","html_url":"https://github.com/mitar","followers_url":"https://api.github.com/users/mitar/followers","following_url":"https://api.github.com/users/mitar/following{/other_user}","gists_url":"https://api.github.com/users/mitar/gists{/gist_id}","starred_url":"https://api.github.com/users/mitar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitar/subscriptions","organizations_url":"https://api.github.com/users/mitar/orgs","repos_url":"https://api.github.com/users/mitar/repos","events_url":"https://api.github.com/users/mitar/events{/privacy}","received_events_url":"https://api.github.com/users/mitar/received_events","type":"User","site_admin":false},"labels":[{"id":371713890,"url":"https://api.github.com/repos/meteor/meteor/labels/Impact:some","name":"Impact:some","color":"fef2c0","default":false},{"id":164742717,"url":"https://api.github.com/repos/meteor/meteor/labels/Project:Tool","name":"Project:Tool","color":"c7def8","default":false},{"id":371713461,"url":"https://api.github.com/repos/meteor/meteor/labels/Severity:blocks-development","name":"Severity:blocks-development","color":"fef2c0","default":false},{"id":370605281,"url":"https://api.github.com/repos/meteor/meteor/labels/bug","name":"bug","color":"b60205","default":true},{"id":11613368,"url":"https://api.github.com/repos/meteor/meteor/labels/confirmed","name":"confirmed","color":"f2831d","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/meteor/meteor/milestones/40","html_url":"https://github.com/meteor/meteor/milestone/40","labels_url":"https://api.github.com/repos/meteor/meteor/milestones/40/labels","id":2554014,"number":40,"title":"Package Patches","description":"Issues and pull requests that can be fixed/shipped without publishing a new Meteor release.","creator":{"login":"benjamn","id":5750,"avatar_url":"https://avatars0.githubusercontent.com/u/5750?v=4","gravatar_id":"","url":"https://api.github.com/users/benjamn","html_url":"https://github.com/benjamn","followers_url":"https://api.github.com/users/benjamn/followers","following_url":"https://api.github.com/users/benjamn/following{/other_user}","gists_url":"https://api.github.com/users/benjamn/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamn/subscriptions","organizations_url":"https://api.github.com/users/benjamn/orgs","repos_url":"https://api.github.com/users/benjamn/repos","events_url":"https://api.github.com/users/benjamn/events{/privacy}","received_events_url":"https://api.github.com/users/benjamn/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":65,"state":"open","created_at":"2017-05-31T15:11:28Z","updated_at":"2018-03-01T18:56:57Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2018-02-25T11:13:50Z","updated_at":"2018-03-04T01:01:20Z","closed_at":null,"author_association":"COLLABORATOR","body":"I have a CI running on all my packages. It installs Meteor and runs mostly just:\r\n\r\n```\r\nmeteor test-packages ./\r\n```\r\n\r\nBut this does not work anymore. For example, [for this package](https://github.com/peerlibrary/meteor-blaze-common-component), if I run the above command I get:\r\n\r\n```\r\n=> Errors prevented startup:                  \r\n   \r\n   While selecting package versions:\r\n   error: Conflict: Constraint babel-compiler@6.13.0 is not satisfied by babel-compiler 7.0.5.\r\n   Constraints on package \"babel-compiler\":\r\n   * babel-compiler@~7.0.0 <- top level\r\n   * babel-compiler@7.0.0 <- ecmascript 0.10.5 <- allow-deny 1.1.0 <- mongo 1.4.4 <- autoupdate 1.4.0\r\n   * babel-compiler@7.0.0 <- ecmascript 0.10.5 <- autoupdate 1.4.0\r\n   * babel-compiler@6.13.0 <- coffeescript 1.11.1_4 <- local-test:peerlibrary:blaze-common-component 0.4.3\r\n```\r\n\r\nIf I run:\r\n\r\n```\r\nmeteor --release 1.6.0.1 test-packages ./\r\n```\r\n\r\nThen I get:\r\n\r\n```\r\n=> Errors prevented startup:                  \r\n   \r\n   While loading plugin `basicFileTypes` from package `meteor`:\r\n   packages/basicFileTypes_plugin.js:39:9: Package._define is not a function\r\n   at packages/basicFileTypes_plugin.js:39:9\r\n   at packages/basicFileTypes_plugin.js:41:3\r\n```\r\n\r\nRunning `meteor --release 1.4.4.5 test-packages ./` works.\r\n\r\nDoes this mean now we have a fixed `--release` when testing packages?"},"comment":{"url":"https://api.github.com/repos/meteor/meteor/issues/comments/370192987","html_url":"https://github.com/meteor/meteor/issues/9695#issuecomment-370192987","issue_url":"https://api.github.com/repos/meteor/meteor/issues/9695","id":370192987,"user":{"login":"hwillson","id":137740,"avatar_url":"https://avatars1.githubusercontent.com/u/137740?v=4","gravatar_id":"","url":"https://api.github.com/users/hwillson","html_url":"https://github.com/hwillson","followers_url":"https://api.github.com/users/hwillson/followers","following_url":"https://api.github.com/users/hwillson/following{/other_user}","gists_url":"https://api.github.com/users/hwillson/gists{/gist_id}","starred_url":"https://api.github.com/users/hwillson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwillson/subscriptions","organizations_url":"https://api.github.com/users/hwillson/orgs","repos_url":"https://api.github.com/users/hwillson/repos","events_url":"https://api.github.com/users/hwillson/events{/privacy}","received_events_url":"https://api.github.com/users/hwillson/received_events","type":"User","site_admin":false},"created_at":"2018-03-04T01:01:20Z","updated_at":"2018-03-04T01:01:20Z","author_association":"MEMBER","body":"The original issue here lists 2 separate issues. The second issue (and the one that I have a feeling most people are 👍'ing) has been resolved. If anyone here is getting a `Package._define` error, please run a `meteor update meteor` to fix the issue.\r\n\r\nRegarding the first issue @mitar:\r\n\r\n```\r\n=> Errors prevented startup:                  \r\n   \r\n   While selecting package versions:\r\n   error: Conflict: Constraint babel-compiler@6.13.0 is not satisfied by babel-compiler 7.0.5.\r\n   Constraints on package \"babel-compiler\":\r\n   * babel-compiler@~7.0.0 <- top level\r\n   * babel-compiler@7.0.0 <- ecmascript 0.10.5 <- allow-deny 1.1.0 <- mongo 1.4.4 <- autoupdate 1.4.0\r\n   * babel-compiler@7.0.0 <- ecmascript 0.10.5 <- autoupdate 1.4.0\r\n   * babel-compiler@6.13.0 <- coffeescript 1.11.1_4 <- local-test:peerlibrary:blaze-common-component 0.4.3\r\n```\r\n\r\nMeteor 1.6.1 requires `babel-compiler` 7.0.x. When you're calling `meteor test-packages ./`, you're using Meteor 1.6.1 to create a dummy test app behind the scenes, that then loads your package for testing. This dummy test app requires `babel-compiler` 7.0.x (since it was created with Meteor 1.6.1). In your package however, you're making a `api.versionsFrom('1.4.0.1')` call, so you're requesting to use a version of `coffeescript` that's compatible with the `coffeescript` dependency included when Meteor 1.4.0.1 was released. Because of the `api.versionsFrom('1.4.0.1')` call, the constraint solver is deciding that the appropriate version of `coffescript` to use with your package is 1.11.1_4, which ultimately requires `babel-compiler` 6.13.0, which is obviously not patch compatible with Meteor 1.6.1's `babel-compiler` 7.0.x (hence the error).\r\n\r\nThere are 2 ways to fix this:\r\n\r\n1. Use an earlier release when running your tests, so you don't bring in the new mandatory `babel-compiler` 7.0.x requirement. E.g. `meteor --release 1.6.0.1 test-packages ./`\r\n\r\n2. Update your `api.versionsFrom('1.4.0.1')` call to something more recent, that allows the constraint solver to find a compatible version of `coffeescript` that works with both Meteor 1.6.1 and your package. You don't have to increase it much - using `api.versionsFrom('1.4.3.1')` should work. This is because `coffeescript` was moved into `non-core` in release 1.4.3.1, which means as of 1.4.3.1 the version of `coffeescript` used is no longer constrained by the Meteor release. If your package (and it's dependent packages) are switched to use `api.versionsFrom('1.4.3.1')` (and you aren't using an explicit 1.x `coffeescript` version anywhere), then `meteor test-packages ./` will use `coffeescript@2.2.1_1` (which is the most recent version, and is compatible with Meteor 1.6.1)."}}
{"actor":{"display_login":"hwillson"}}