{"action":"created","issue":{"url":"https://api.github.com/repos/rails/rails/issues/33594","repository_url":"https://api.github.com/repos/rails/rails","labels_url":"https://api.github.com/repos/rails/rails/issues/33594/labels{/name}","comments_url":"https://api.github.com/repos/rails/rails/issues/33594/comments","events_url":"https://api.github.com/repos/rails/rails/issues/33594/events","html_url":"https://github.com/rails/rails/pull/33594","id":349846602,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3ODQyMDg2","number":33594,"title":"Exclude added flash types from action_methods","user":{"login":"Bodacious","id":73998,"node_id":"MDQ6VXNlcjczOTk4","avatar_url":"https://avatars2.githubusercontent.com/u/73998?v=4","gravatar_id":"","url":"https://api.github.com/users/Bodacious","html_url":"https://github.com/Bodacious","followers_url":"https://api.github.com/users/Bodacious/followers","following_url":"https://api.github.com/users/Bodacious/following{/other_user}","gists_url":"https://api.github.com/users/Bodacious/gists{/gist_id}","starred_url":"https://api.github.com/users/Bodacious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bodacious/subscriptions","organizations_url":"https://api.github.com/users/Bodacious/orgs","repos_url":"https://api.github.com/users/Bodacious/repos","events_url":"https://api.github.com/users/Bodacious/events{/privacy}","received_events_url":"https://api.github.com/users/Bodacious/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"schneems","id":59744,"node_id":"MDQ6VXNlcjU5NzQ0","avatar_url":"https://avatars2.githubusercontent.com/u/59744?v=4","gravatar_id":"","url":"https://api.github.com/users/schneems","html_url":"https://github.com/schneems","followers_url":"https://api.github.com/users/schneems/followers","following_url":"https://api.github.com/users/schneems/following{/other_user}","gists_url":"https://api.github.com/users/schneems/gists{/gist_id}","starred_url":"https://api.github.com/users/schneems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schneems/subscriptions","organizations_url":"https://api.github.com/users/schneems/orgs","repos_url":"https://api.github.com/users/schneems/repos","events_url":"https://api.github.com/users/schneems/events{/privacy}","received_events_url":"https://api.github.com/users/schneems/received_events","type":"User","site_admin":false},"assignees":[{"login":"schneems","id":59744,"node_id":"MDQ6VXNlcjU5NzQ0","avatar_url":"https://avatars2.githubusercontent.com/u/59744?v=4","gravatar_id":"","url":"https://api.github.com/users/schneems","html_url":"https://github.com/schneems","followers_url":"https://api.github.com/users/schneems/followers","following_url":"https://api.github.com/users/schneems/following{/other_user}","gists_url":"https://api.github.com/users/schneems/gists{/gist_id}","starred_url":"https://api.github.com/users/schneems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schneems/subscriptions","organizations_url":"https://api.github.com/users/schneems/orgs","repos_url":"https://api.github.com/users/schneems/repos","events_url":"https://api.github.com/users/schneems/events{/privacy}","received_events_url":"https://api.github.com/users/schneems/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-08-12T21:45:08Z","updated_at":"2018-08-13T07:13:15Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/33594","html_url":"https://github.com/rails/rails/pull/33594","diff_url":"https://github.com/rails/rails/pull/33594.diff","patch_url":"https://github.com/rails/rails/pull/33594.patch"},"body":"Exclude additional flash types from `action_methods`.\r\n\r\nFixes #33593\r\n\r\nWhen new flash types are added to ApplicationController, these\r\nshould not appear in the `action_methods` set, since they're\r\nnot actions. This commit corrects this behaviour.\r\n\r\n    class MyController < ApplicationController\r\n      add_flash_types :hype\r\n    end\r\n\r\n    # Currently:\r\n    MyController.action_methods.include?('hype') # => true\r\n\r\n    # This commit\r\n    MyController.action_methods.include?('hype') # => false\r\n"},"comment":{"url":"https://api.github.com/repos/rails/rails/issues/comments/412428201","html_url":"https://github.com/rails/rails/pull/33594#issuecomment-412428201","issue_url":"https://api.github.com/repos/rails/rails/issues/33594","id":412428201,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjQyODIwMQ==","user":{"login":"Bodacious","id":73998,"node_id":"MDQ6VXNlcjczOTk4","avatar_url":"https://avatars2.githubusercontent.com/u/73998?v=4","gravatar_id":"","url":"https://api.github.com/users/Bodacious","html_url":"https://github.com/Bodacious","followers_url":"https://api.github.com/users/Bodacious/followers","following_url":"https://api.github.com/users/Bodacious/following{/other_user}","gists_url":"https://api.github.com/users/Bodacious/gists{/gist_id}","starred_url":"https://api.github.com/users/Bodacious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bodacious/subscriptions","organizations_url":"https://api.github.com/users/Bodacious/orgs","repos_url":"https://api.github.com/users/Bodacious/repos","events_url":"https://api.github.com/users/Bodacious/events{/privacy}","received_events_url":"https://api.github.com/users/Bodacious/received_events","type":"User","site_admin":false},"created_at":"2018-08-13T07:13:15Z","updated_at":"2018-08-13T07:13:15Z","author_association":"CONTRIBUTOR","body":"      \n  \n\n Yes, will do today!   \n  \n\n  \nCheers.\n  \n\n  \n  \n\n  \n  \n>   \n> On Aug 13, 2018 at 1:48 am,  <Richard Schneeman (mailto:notifications@github.com)>  wrote:\n>   \n>   \n>   \n>\n> Tests are still failing. Can you take a look?\n>\n>   \n>\n> —\n>  You are receiving this because you authored the thread.\n>  Reply to this email directly,  view it on GitHub (https://github.com/rails/rails/pull/33594#issuecomment-412383640), or   mute the thread (https://github.com/notifications/unsubscribe-auth/AAEhDoQELSHm9Tl2aV34QwaPpkdRbC1Hks5uQMzqgaJpZM4V5szo).\n>\n>     \n>   \n  \n  \n     "}}
{"actor":{"display_login":"Bodacious"}}