{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/17813","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/17813/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/17813/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/17813/events","html_url":"https://github.com/magento/magento2/issues/17813","id":354263064,"node_id":"MDU6SXNzdWUzNTQyNjMwNjQ=","number":17813,"title":"Huge \"product_data_storage\" in localStorage hangs the shop","user":{"login":"krzksz","id":829189,"node_id":"MDQ6VXNlcjgyOTE4OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/829189?v=4","gravatar_id":"","url":"https://api.github.com/users/krzksz","html_url":"https://github.com/krzksz","followers_url":"https://api.github.com/users/krzksz/followers","following_url":"https://api.github.com/users/krzksz/following{/other_user}","gists_url":"https://api.github.com/users/krzksz/gists{/gist_id}","starred_url":"https://api.github.com/users/krzksz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzksz/subscriptions","organizations_url":"https://api.github.com/users/krzksz/orgs","repos_url":"https://api.github.com/users/krzksz/repos","events_url":"https://api.github.com/users/krzksz/events{/privacy}","received_events_url":"https://api.github.com/users/krzksz/received_events","type":"User","site_admin":false},"labels":[{"id":959314347,"node_id":"MDU6TGFiZWw5NTkzMTQzNDc=","url":"https://api.github.com/repos/magento/magento2/labels/Component:%20Framework/Session","name":"Component: Framework/Session","color":"7fb703","default":false},{"id":1105723778,"node_id":"MDU6TGFiZWwxMTA1NzIzNzc4","url":"https://api.github.com/repos/magento/magento2/labels/Event:%20mm18mx","name":"Event: mm18mx","color":"ededed","default":false},{"id":686477444,"node_id":"MDU6TGFiZWw2ODY0Nzc0NDQ=","url":"https://api.github.com/repos/magento/magento2/labels/Fixed%20in%202.2.x","name":"Fixed in 2.2.x","color":"0e8a16","default":false},{"id":686477493,"node_id":"MDU6TGFiZWw2ODY0Nzc0OTM=","url":"https://api.github.com/repos/magento/magento2/labels/Fixed%20in%202.3.x","name":"Fixed in 2.3.x","color":"0e8a16","default":false},{"id":686420665,"node_id":"MDU6TGFiZWw2ODY0MjA2NjU=","url":"https://api.github.com/repos/magento/magento2/labels/Issue:%20Clear%20Description","name":"Issue: Clear Description","color":"0e8a16","default":false},{"id":686476746,"node_id":"MDU6TGFiZWw2ODY0NzY3NDY=","url":"https://api.github.com/repos/magento/magento2/labels/Issue:%20Confirmed","name":"Issue: Confirmed","color":"0e8a16","default":false},{"id":688811200,"node_id":"MDU6TGFiZWw2ODg4MTEyMDA=","url":"https://api.github.com/repos/magento/magento2/labels/Issue:%20Format%20is%20valid","name":"Issue: Format is valid","color":"0e8a16","default":false},{"id":21716835,"node_id":"MDU6TGFiZWwyMTcxNjgzNQ==","url":"https://api.github.com/repos/magento/magento2/labels/Issue:%20Ready%20for%20Work","name":"Issue: Ready for Work","color":"0e8a16","default":false},{"id":686477126,"node_id":"MDU6TGFiZWw2ODY0NzcxMjY=","url":"https://api.github.com/repos/magento/magento2/labels/Reproduced%20on%202.2.x","name":"Reproduced on 2.2.x","color":"e99695","default":false},{"id":686477167,"node_id":"MDU6TGFiZWw2ODY0NzcxNjc=","url":"https://api.github.com/repos/magento/magento2/labels/Reproduced%20on%202.3.x","name":"Reproduced on 2.3.x","color":"7d6ed1","default":false}],"state":"closed","locked":false,"assignee":{"login":"yagator","id":5140625,"node_id":"MDQ6VXNlcjUxNDA2MjU=","avatar_url":"https://avatars2.githubusercontent.com/u/5140625?v=4","gravatar_id":"","url":"https://api.github.com/users/yagator","html_url":"https://github.com/yagator","followers_url":"https://api.github.com/users/yagator/followers","following_url":"https://api.github.com/users/yagator/following{/other_user}","gists_url":"https://api.github.com/users/yagator/gists{/gist_id}","starred_url":"https://api.github.com/users/yagator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yagator/subscriptions","organizations_url":"https://api.github.com/users/yagator/orgs","repos_url":"https://api.github.com/users/yagator/repos","events_url":"https://api.github.com/users/yagator/events{/privacy}","received_events_url":"https://api.github.com/users/yagator/received_events","type":"User","site_admin":false},"assignees":[{"login":"yagator","id":5140625,"node_id":"MDQ6VXNlcjUxNDA2MjU=","avatar_url":"https://avatars2.githubusercontent.com/u/5140625?v=4","gravatar_id":"","url":"https://api.github.com/users/yagator","html_url":"https://github.com/yagator","followers_url":"https://api.github.com/users/yagator/followers","following_url":"https://api.github.com/users/yagator/following{/other_user}","gists_url":"https://api.github.com/users/yagator/gists{/gist_id}","starred_url":"https://api.github.com/users/yagator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yagator/subscriptions","organizations_url":"https://api.github.com/users/yagator/orgs","repos_url":"https://api.github.com/users/yagator/repos","events_url":"https://api.github.com/users/yagator/events{/privacy}","received_events_url":"https://api.github.com/users/yagator/received_events","type":"User","site_admin":false}],"milestone":null,"comments":52,"created_at":"2018-08-27T10:21:34Z","updated_at":"2019-01-05T17:41:22Z","closed_at":"2018-11-29T08:50:13Z","author_association":"CONTRIBUTOR","body":"<!---\r\n    Thank you for contributing to Magento.\r\n    To help us process this issue we recommend that you add the following information:\r\n     - Summary of the issue,\r\n     - Information on your environment,\r\n     - Steps to reproduce,\r\n     - Expected and actual results,\r\n\r\n    Please also have a look at our guidelines article before adding a new issue https://github.com/magento/magento2/wiki/Issue-reporting-guidelines\r\n-->\r\n\r\n### Preconditions\r\n1. Magento 2.2.x and others with this commit applied: https://github.com/magento/magento2/commit/05ff6d4b36022a3875061b6ff9a58fb2545a95e0.\r\n\r\n### Steps to reproduce\r\n<!---\r\n    It is important to provide a set of clear steps to reproduce this bug.\r\n    If relevant please include code samples\r\n-->\r\n1. Open the shop.\r\n2. Visit a lot of different product pages (~400 in our case) without invalidating user data.\r\n3. Notice how browser slows down at load because of `product_data_storage` in localStorage getting bigger and bigger.\r\n\r\nI'm also attaching the contents of [product_data_storage.txt](https://github.com/magento/magento2/files/2323063/product_data_storage.txt), which we dumped from one of the affected computers that you can use to replace the value in your browser.\r\n\r\n\r\n### Expected result\r\n<!--- Tell us what should happen -->\r\n1. I think that some rotating mechanism or even a simple purge when number of products in `product_data_storage` is getting too big.\r\n\r\n### Actual result\r\n<!--- Tell us what happens instead -->\r\n1. `product_data_storage` is growing bigger and bigger slowing down the browser.\r\n![obraz](https://user-images.githubusercontent.com/829189/44654923-b0040280-a9f3-11e8-99e7-9c16b0a977c1.png)\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/451675183","html_url":"https://github.com/magento/magento2/issues/17813#issuecomment-451675183","issue_url":"https://api.github.com/repos/magento/magento2/issues/17813","id":451675183,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTY3NTE4Mw==","user":{"login":"kombi77","id":45667823,"node_id":"MDQ6VXNlcjQ1NjY3ODIz","avatar_url":"https://avatars1.githubusercontent.com/u/45667823?v=4","gravatar_id":"","url":"https://api.github.com/users/kombi77","html_url":"https://github.com/kombi77","followers_url":"https://api.github.com/users/kombi77/followers","following_url":"https://api.github.com/users/kombi77/following{/other_user}","gists_url":"https://api.github.com/users/kombi77/gists{/gist_id}","starred_url":"https://api.github.com/users/kombi77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kombi77/subscriptions","organizations_url":"https://api.github.com/users/kombi77/orgs","repos_url":"https://api.github.com/users/kombi77/repos","events_url":"https://api.github.com/users/kombi77/events{/privacy}","received_events_url":"https://api.github.com/users/kombi77/received_events","type":"User","site_admin":false},"created_at":"2019-01-05T17:41:22Z","updated_at":"2019-01-05T17:41:22Z","author_association":"NONE","body":"Thanks for the great post and fix.  I see this post is closed not sure where else to go being new to GitHub as well.\r\n\r\nBeing new to Magento 2.3.0 I do not see a path called \"Magento_Catalog/js/product/storage/ids-storage.js\". When I search for ids-storage.js ( Two files come up) and open the files I do not find \" if (!utils.compare(data, localStorage).equal) {\" .  Am I just way off base in where to find the file?\r\n\r\nids-storage.js files I did find.\r\n/vendor/magento/module-catalog/view/frontend/web/js/product/storage/ids-storage.js\r\n/pub/static/frontend/Magento/luma/en_US/Magento_Catalog/js/product/storage/ids-storage.js\r\n\r\n![2019-01-05 09_29_39](https://user-images.githubusercontent.com/45667823/50727246-1f3de180-10cd-11e9-88c8-b4b58c87033f.png)\r\n\r\n\r\n"}}
{"actor":{"display_login":"kombi77"}}