{"action":"closed","number":860,"pull_request":{"url":"https://api.github.com/repos/LiskHQ/lisk-elements/pulls/860","id":231936828,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxOTM2ODI4","html_url":"https://github.com/LiskHQ/lisk-elements/pull/860","diff_url":"https://github.com/LiskHQ/lisk-elements/pull/860.diff","patch_url":"https://github.com/LiskHQ/lisk-elements/pull/860.patch","issue_url":"https://api.github.com/repos/LiskHQ/lisk-elements/issues/860","number":860,"state":"closed","locked":false,"title":"Remove default export from child packages and lisk-elements","user":{"login":"shuse2","id":2367565,"node_id":"MDQ6VXNlcjIzNjc1NjU=","avatar_url":"https://avatars0.githubusercontent.com/u/2367565?v=4","gravatar_id":"","url":"https://api.github.com/users/shuse2","html_url":"https://github.com/shuse2","followers_url":"https://api.github.com/users/shuse2/followers","following_url":"https://api.github.com/users/shuse2/following{/other_user}","gists_url":"https://api.github.com/users/shuse2/gists{/gist_id}","starred_url":"https://api.github.com/users/shuse2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuse2/subscriptions","organizations_url":"https://api.github.com/users/shuse2/orgs","repos_url":"https://api.github.com/users/shuse2/repos","events_url":"https://api.github.com/users/shuse2/events{/privacy}","received_events_url":"https://api.github.com/users/shuse2/received_events","type":"User","site_admin":false},"body":"### What was the problem?\r\nexport default was not standard, and it was mainly for babel users.\r\nNow it's in typescript, and the original main user was front-end, so we keep the functionality for client, but remove from all other packages.\r\n\r\n### How did I fix it?\r\nRemove default export from all the packages except `@liskhq/lisk-client`\r\n\r\n### How to test it?\r\n`npm test` or\r\n`npm run build` and try to use each pakcages\r\n\r\n### Review checklist\r\n\r\n* The PR resolves #859 \r\n* All new code is covered with unit tests\r\n* All new code was formatted with Prettier\r\n* Linting passes\r\n* Tests pass\r\n* Commit messages follow the [commit guidelines](CONTRIBUTING.md#git-commit-messages)\r\n* Documentation has been added/updated\r\n","created_at":"2018-11-19T11:18:50Z","updated_at":"2018-11-21T09:43:05Z","closed_at":"2018-11-21T09:43:04Z","merged_at":"2018-11-21T09:43:04Z","merge_commit_sha":"7b2eec88a3972c3bbcf52f9f99e8b73871499bbf","assignee":{"login":"shuse2","id":2367565,"node_id":"MDQ6VXNlcjIzNjc1NjU=","avatar_url":"https://avatars0.githubusercontent.com/u/2367565?v=4","gravatar_id":"","url":"https://api.github.com/users/shuse2","html_url":"https://github.com/shuse2","followers_url":"https://api.github.com/users/shuse2/followers","following_url":"https://api.github.com/users/shuse2/following{/other_user}","gists_url":"https://api.github.com/users/shuse2/gists{/gist_id}","starred_url":"https://api.github.com/users/shuse2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuse2/subscriptions","organizations_url":"https://api.github.com/users/shuse2/orgs","repos_url":"https://api.github.com/users/shuse2/repos","events_url":"https://api.github.com/users/shuse2/events{/privacy}","received_events_url":"https://api.github.com/users/shuse2/received_events","type":"User","site_admin":false},"assignees":[{"login":"shuse2","id":2367565,"node_id":"MDQ6VXNlcjIzNjc1NjU=","avatar_url":"https://avatars0.githubusercontent.com/u/2367565?v=4","gravatar_id":"","url":"https://api.github.com/users/shuse2","html_url":"https://github.com/shuse2","followers_url":"https://api.github.com/users/shuse2/followers","following_url":"https://api.github.com/users/shuse2/following{/other_user}","gists_url":"https://api.github.com/users/shuse2/gists{/gist_id}","starred_url":"https://api.github.com/users/shuse2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuse2/subscriptions","organizations_url":"https://api.github.com/users/shuse2/orgs","repos_url":"https://api.github.com/users/shuse2/repos","events_url":"https://api.github.com/users/shuse2/events{/privacy}","received_events_url":"https://api.github.com/users/shuse2/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"SargeKhan","id":4995051,"node_id":"MDQ6VXNlcjQ5OTUwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/4995051?v=4","gravatar_id":"","url":"https://api.github.com/users/SargeKhan","html_url":"https://github.com/SargeKhan","followers_url":"https://api.github.com/users/SargeKhan/followers","following_url":"https://api.github.com/users/SargeKhan/following{/other_user}","gists_url":"https://api.github.com/users/SargeKhan/gists{/gist_id}","starred_url":"https://api.github.com/users/SargeKhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SargeKhan/subscriptions","organizations_url":"https://api.github.com/users/SargeKhan/orgs","repos_url":"https://api.github.com/users/SargeKhan/repos","events_url":"https://api.github.com/users/SargeKhan/events{/privacy}","received_events_url":"https://api.github.com/users/SargeKhan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":655490233,"node_id":"MDU6TGFiZWw2NTU0OTAyMzM=","url":"https://api.github.com/repos/LiskHQ/lisk-elements/labels/:eye:%20pending%20review","name":":eye: pending review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/LiskHQ/lisk-elements/pulls/860/commits","review_comments_url":"https://api.github.com/repos/LiskHQ/lisk-elements/pulls/860/comments","review_comment_url":"https://api.github.com/repos/LiskHQ/lisk-elements/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LiskHQ/lisk-elements/issues/860/comments","statuses_url":"https://api.github.com/repos/LiskHQ/lisk-elements/statuses/f15a1ec91292ff49b2decfb7853abab0a61a0316","head":{"label":"LiskHQ:859-remove_default_export","ref":"859-remove_default_export","sha":"f15a1ec91292ff49b2decfb7853abab0a61a0316","user":{"login":"LiskHQ","id":16600915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjAwOTE1","avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":49426311,"node_id":"MDEwOlJlcG9zaXRvcnk0OTQyNjMxMQ==","name":"lisk-elements","full_name":"LiskHQ/lisk-elements","private":false,"owner":{"login":"LiskHQ","id":16600915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjAwOTE1","avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LiskHQ/lisk-elements","description":"⚙️ Library for sending Lisk transactions from the client or server","fork":false,"url":"https://api.github.com/repos/LiskHQ/lisk-elements","forks_url":"https://api.github.com/repos/LiskHQ/lisk-elements/forks","keys_url":"https://api.github.com/repos/LiskHQ/lisk-elements/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LiskHQ/lisk-elements/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LiskHQ/lisk-elements/teams","hooks_url":"https://api.github.com/repos/LiskHQ/lisk-elements/hooks","issue_events_url":"https://api.github.com/repos/LiskHQ/lisk-elements/issues/events{/number}","events_url":"https://api.github.com/repos/LiskHQ/lisk-elements/events","assignees_url":"https://api.github.com/repos/LiskHQ/lisk-elements/assignees{/user}","branches_url":"https://api.github.com/repos/LiskHQ/lisk-elements/branches{/branch}","tags_url":"https://api.github.com/repos/LiskHQ/lisk-elements/tags","blobs_url":"https://api.github.com/repos/LiskHQ/lisk-elements/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LiskHQ/lisk-elements/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LiskHQ/lisk-elements/git/refs{/sha}","trees_url":"https://api.github.com/repos/LiskHQ/lisk-elements/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LiskHQ/lisk-elements/statuses/{sha}","languages_url":"https://api.github.com/repos/LiskHQ/lisk-elements/languages","stargazers_url":"https://api.github.com/repos/LiskHQ/lisk-elements/stargazers","contributors_url":"https://api.github.com/repos/LiskHQ/lisk-elements/contributors","subscribers_url":"https://api.github.com/repos/LiskHQ/lisk-elements/subscribers","subscription_url":"https://api.github.com/repos/LiskHQ/lisk-elements/subscription","commits_url":"https://api.github.com/repos/LiskHQ/lisk-elements/commits{/sha}","git_commits_url":"https://api.github.com/repos/LiskHQ/lisk-elements/git/commits{/sha}","comments_url":"https://api.github.com/repos/LiskHQ/lisk-elements/comments{/number}","issue_comment_url":"https://api.github.com/repos/LiskHQ/lisk-elements/issues/comments{/number}","contents_url":"https://api.github.com/repos/LiskHQ/lisk-elements/contents/{+path}","compare_url":"https://api.github.com/repos/LiskHQ/lisk-elements/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LiskHQ/lisk-elements/merges","archive_url":"https://api.github.com/repos/LiskHQ/lisk-elements/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LiskHQ/lisk-elements/downloads","issues_url":"https://api.github.com/repos/LiskHQ/lisk-elements/issues{/number}","pulls_url":"https://api.github.com/repos/LiskHQ/lisk-elements/pulls{/number}","milestones_url":"https://api.github.com/repos/LiskHQ/lisk-elements/milestones{/number}","notifications_url":"https://api.github.com/repos/LiskHQ/lisk-elements/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LiskHQ/lisk-elements/labels{/name}","releases_url":"https://api.github.com/repos/LiskHQ/lisk-elements/releases{/id}","deployments_url":"https://api.github.com/repos/LiskHQ/lisk-elements/deployments","created_at":"2016-01-11T12:54:02Z","updated_at":"2018-11-20T15:19:38Z","pushed_at":"2018-11-21T09:43:04Z","git_url":"git://github.com/LiskHQ/lisk-elements.git","ssh_url":"git@github.com:LiskHQ/lisk-elements.git","clone_url":"https://github.com/LiskHQ/lisk-elements.git","svn_url":"https://github.com/LiskHQ/lisk-elements","homepage":"https://lisk.io/","size":14258,"stargazers_count":263,"watchers_count":263,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":73,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":73,"open_issues":8,"watchers":263,"default_branch":"development"}},"base":{"label":"LiskHQ:development","ref":"development","sha":"041261090057a379cad7156104b38a68b9b4ee46","user":{"login":"LiskHQ","id":16600915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjAwOTE1","avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":49426311,"node_id":"MDEwOlJlcG9zaXRvcnk0OTQyNjMxMQ==","name":"lisk-elements","full_name":"LiskHQ/lisk-elements","private":false,"owner":{"login":"LiskHQ","id":16600915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjAwOTE1","avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LiskHQ/lisk-elements","description":"⚙️ Library for sending Lisk transactions from the client or server","fork":false,"url":"https://api.github.com/repos/LiskHQ/lisk-elements","forks_url":"https://api.github.com/repos/LiskHQ/lisk-elements/forks","keys_url":"https://api.github.com/repos/LiskHQ/lisk-elements/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LiskHQ/lisk-elements/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LiskHQ/lisk-elements/teams","hooks_url":"https://api.github.com/repos/LiskHQ/lisk-elements/hooks","issue_events_url":"https://api.github.com/repos/LiskHQ/lisk-elements/issues/events{/number}","events_url":"https://api.github.com/repos/LiskHQ/lisk-elements/events","assignees_url":"https://api.github.com/repos/LiskHQ/lisk-elements/assignees{/user}","branches_url":"https://api.github.com/repos/LiskHQ/lisk-elements/branches{/branch}","tags_url":"https://api.github.com/repos/LiskHQ/lisk-elements/tags","blobs_url":"https://api.github.com/repos/LiskHQ/lisk-elements/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LiskHQ/lisk-elements/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LiskHQ/lisk-elements/git/refs{/sha}","trees_url":"https://api.github.com/repos/LiskHQ/lisk-elements/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LiskHQ/lisk-elements/statuses/{sha}","languages_url":"https://api.github.com/repos/LiskHQ/lisk-elements/languages","stargazers_url":"https://api.github.com/repos/LiskHQ/lisk-elements/stargazers","contributors_url":"https://api.github.com/repos/LiskHQ/lisk-elements/contributors","subscribers_url":"https://api.github.com/repos/LiskHQ/lisk-elements/subscribers","subscription_url":"https://api.github.com/repos/LiskHQ/lisk-elements/subscription","commits_url":"https://api.github.com/repos/LiskHQ/lisk-elements/commits{/sha}","git_commits_url":"https://api.github.com/repos/LiskHQ/lisk-elements/git/commits{/sha}","comments_url":"https://api.github.com/repos/LiskHQ/lisk-elements/comments{/number}","issue_comment_url":"https://api.github.com/repos/LiskHQ/lisk-elements/issues/comments{/number}","contents_url":"https://api.github.com/repos/LiskHQ/lisk-elements/contents/{+path}","compare_url":"https://api.github.com/repos/LiskHQ/lisk-elements/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LiskHQ/lisk-elements/merges","archive_url":"https://api.github.com/repos/LiskHQ/lisk-elements/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LiskHQ/lisk-elements/downloads","issues_url":"https://api.github.com/repos/LiskHQ/lisk-elements/issues{/number}","pulls_url":"https://api.github.com/repos/LiskHQ/lisk-elements/pulls{/number}","milestones_url":"https://api.github.com/repos/LiskHQ/lisk-elements/milestones{/number}","notifications_url":"https://api.github.com/repos/LiskHQ/lisk-elements/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LiskHQ/lisk-elements/labels{/name}","releases_url":"https://api.github.com/repos/LiskHQ/lisk-elements/releases{/id}","deployments_url":"https://api.github.com/repos/LiskHQ/lisk-elements/deployments","created_at":"2016-01-11T12:54:02Z","updated_at":"2018-11-20T15:19:38Z","pushed_at":"2018-11-21T09:43:04Z","git_url":"git://github.com/LiskHQ/lisk-elements.git","ssh_url":"git@github.com:LiskHQ/lisk-elements.git","clone_url":"https://github.com/LiskHQ/lisk-elements.git","svn_url":"https://github.com/LiskHQ/lisk-elements","homepage":"https://lisk.io/","size":14258,"stargazers_count":263,"watchers_count":263,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":73,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":73,"open_issues":8,"watchers":263,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/LiskHQ/lisk-elements/pulls/860"},"html":{"href":"https://github.com/LiskHQ/lisk-elements/pull/860"},"issue":{"href":"https://api.github.com/repos/LiskHQ/lisk-elements/issues/860"},"comments":{"href":"https://api.github.com/repos/LiskHQ/lisk-elements/issues/860/comments"},"review_comments":{"href":"https://api.github.com/repos/LiskHQ/lisk-elements/pulls/860/comments"},"review_comment":{"href":"https://api.github.com/repos/LiskHQ/lisk-elements/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LiskHQ/lisk-elements/pulls/860/commits"},"statuses":{"href":"https://api.github.com/repos/LiskHQ/lisk-elements/statuses/f15a1ec91292ff49b2decfb7853abab0a61a0316"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"shuse2","id":2367565,"node_id":"MDQ6VXNlcjIzNjc1NjU=","avatar_url":"https://avatars0.githubusercontent.com/u/2367565?v=4","gravatar_id":"","url":"https://api.github.com/users/shuse2","html_url":"https://github.com/shuse2","followers_url":"https://api.github.com/users/shuse2/followers","following_url":"https://api.github.com/users/shuse2/following{/other_user}","gists_url":"https://api.github.com/users/shuse2/gists{/gist_id}","starred_url":"https://api.github.com/users/shuse2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuse2/subscriptions","organizations_url":"https://api.github.com/users/shuse2/orgs","repos_url":"https://api.github.com/users/shuse2/repos","events_url":"https://api.github.com/users/shuse2/events{/privacy}","received_events_url":"https://api.github.com/users/shuse2/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":40,"deletions":72,"changed_files":27}}
{"actor":{"display_login":"shuse2"}}