{"action":"created","issue":{"url":"https://api.github.com/repos/revilheart/ESGST/issues/661","repository_url":"https://api.github.com/repos/revilheart/ESGST","labels_url":"https://api.github.com/repos/revilheart/ESGST/issues/661/labels{/name}","comments_url":"https://api.github.com/repos/revilheart/ESGST/issues/661/comments","events_url":"https://api.github.com/repos/revilheart/ESGST/issues/661/events","html_url":"https://github.com/revilheart/ESGST/issues/661","id":320602086,"number":661,"title":"Fix a bug in Comment Formatting Helper that does not add a scrolling bar to the text area in the edit discussion page","user":{"login":"Luckz","id":224748,"avatar_url":"https://avatars3.githubusercontent.com/u/224748?v=4","gravatar_id":"","url":"https://api.github.com/users/Luckz","html_url":"https://github.com/Luckz","followers_url":"https://api.github.com/users/Luckz/followers","following_url":"https://api.github.com/users/Luckz/following{/other_user}","gists_url":"https://api.github.com/users/Luckz/gists{/gist_id}","starred_url":"https://api.github.com/users/Luckz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Luckz/subscriptions","organizations_url":"https://api.github.com/users/Luckz/orgs","repos_url":"https://api.github.com/users/Luckz/repos","events_url":"https://api.github.com/users/Luckz/events{/privacy}","received_events_url":"https://api.github.com/users/Luckz/received_events","type":"User","site_admin":false},"labels":[{"id":692493755,"url":"https://api.github.com/repos/revilheart/ESGST/labels/Bug","name":"Bug","color":"d93f0b","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/revilheart/ESGST/milestones/36","html_url":"https://github.com/revilheart/ESGST/milestone/36","labels_url":"https://api.github.com/repos/revilheart/ESGST/milestones/36/labels","id":3291645,"number":36,"title":"7.18.0","description":null,"creator":{"login":"revilheart","id":25509361,"avatar_url":"https://avatars2.githubusercontent.com/u/25509361?v=4","gravatar_id":"","url":"https://api.github.com/users/revilheart","html_url":"https://github.com/revilheart","followers_url":"https://api.github.com/users/revilheart/followers","following_url":"https://api.github.com/users/revilheart/following{/other_user}","gists_url":"https://api.github.com/users/revilheart/gists{/gist_id}","starred_url":"https://api.github.com/users/revilheart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/revilheart/subscriptions","organizations_url":"https://api.github.com/users/revilheart/orgs","repos_url":"https://api.github.com/users/revilheart/repos","events_url":"https://api.github.com/users/revilheart/events{/privacy}","received_events_url":"https://api.github.com/users/revilheart/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":23,"state":"closed","created_at":"2018-04-24T04:56:47Z","updated_at":"2018-05-07T02:06:00Z","due_on":null,"closed_at":"2018-05-07T02:06:00Z"},"comments":2,"created_at":"2018-05-06T15:27:34Z","updated_at":"2018-05-07T14:06:31Z","closed_at":"2018-05-06T22:23:01Z","author_association":"NONE","body":"Normally, SG's thread editing textarea expands to the entire height of the text inside once you first click inside it. With the ESGST Comment Formatting Panel enabled, this is changed to (at best) a decent size with a scrollbar. It's tolerable for mildly sized threads, and just a slight bit annoying when your OP is several pages long. However, ESGST injects the following CSS:\r\n```\r\n        .esgst-cfh-panel ~ textarea {\r\n            /*! max-height: 475px; */\r\n        }\r\n```\r\n..and with that present, and the comment formatting option on, it changes to showing a 475 pixels height textarea without a scrollbar or any other reasonable means of interaction.\r\n\r\nI could reproduce this on Firefox-esque browsers, including with a fresh profile, on Tampermonkey, and with an old profile running old Greasemonkey v3.\r\nI resolved the issue for myself and friends by deleting the quoted code from the user.js.\r\n\r\n\r\nIn addition, I would say switching from the default behaviour of having the entire textarea show up (with a height of many thousand px if needed) to ESGST's intended behaviour of making it a limited height area with a scrollbar should be optional. I realise at very low screen resolutions it might be hard to find the editing toolbar without this, but there are many different use cases out there."},"comment":{"url":"https://api.github.com/repos/revilheart/ESGST/issues/comments/387075821","html_url":"https://github.com/revilheart/ESGST/issues/661#issuecomment-387075821","issue_url":"https://api.github.com/repos/revilheart/ESGST/issues/661","id":387075821,"user":{"login":"Luckz","id":224748,"avatar_url":"https://avatars3.githubusercontent.com/u/224748?v=4","gravatar_id":"","url":"https://api.github.com/users/Luckz","html_url":"https://github.com/Luckz","followers_url":"https://api.github.com/users/Luckz/followers","following_url":"https://api.github.com/users/Luckz/following{/other_user}","gists_url":"https://api.github.com/users/Luckz/gists{/gist_id}","starred_url":"https://api.github.com/users/Luckz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Luckz/subscriptions","organizations_url":"https://api.github.com/users/Luckz/orgs","repos_url":"https://api.github.com/users/Luckz/repos","events_url":"https://api.github.com/users/Luckz/events{/privacy}","received_events_url":"https://api.github.com/users/Luckz/received_events","type":"User","site_admin":false},"created_at":"2018-05-07T14:06:31Z","updated_at":"2018-05-07T14:06:31Z","author_association":"NONE","body":"The only minor weirdness is that the comment formatting bar now scrolls along in the middle of the window, covering up text behind it, **if Fixed Header is not set**. "}}
{"actor":{"display_login":"Luckz"}}