{"action":"created","comment":{"url":"https://api.github.com/repos/adobe/xdm/pulls/comments/169937235","pull_request_review_id":98541100,"id":169937235,"diff_hunk":"@@ -0,0 +1,61 @@\n+{\n+  \"meta:license\": [\n+    \"Copyright 2017 Adobe Systems Incorporated. All rights reserved.\",\n+    \"This work is licensed under a Creative Commons Attribution 4.0 International (CC BY 4.0) license\",\n+    \"you may not use this file except in compliance with the License. You may obtain a copy\",\n+    \"of the License at https://creativecommons.org/licenses/by/4.0/\"\n+  ],\n+  \"$id\": \"https://ns.adobe.com/xdm/audiences/segment\",\n+  \"$schema\": \"http://json-schema.org/draft-06/schema#\",\n+  \"title\": \"Segment Assignment\",\n+  \"type\": \"object\",\n+  \"description\":\n+    \"\",\n+  \"definitions\": {\n+    \"segment\": {\n+      \"properties\": {\n+        \"@id\": {\n+          \"title\": \"Identity\",\n+          \"type\": \"string\",\n+          \"format\": \"uri\",\n+          \"description\": \"Unique identity of the segment.\"\n+        },\n+        \"xdm:endUserIDs\": {\n+          \"title\": \"End User IDs\",\n+          \"$ref\": \"https://ns.adobe.com/xdm/context/enduserids\",\n+          \"description\":\n+            \"Condensed, normalized encapsulation of an end user identifier that the segment is assigned to.\"\n+        },\n+        \"xdm:name\": {","path":"schemas/audiences/segment.schema.json","position":29,"original_position":29,"commit_id":"13eba1505445321de262d30aa0f9a474f7eeeefb","original_commit_id":"8860acdb964ff6ff57201774d9c50a940556a6e1","user":{"login":"trieloff","id":39613,"avatar_url":"https://avatars3.githubusercontent.com/u/39613?v=4","gravatar_id":"","url":"https://api.github.com/users/trieloff","html_url":"https://github.com/trieloff","followers_url":"https://api.github.com/users/trieloff/followers","following_url":"https://api.github.com/users/trieloff/following{/other_user}","gists_url":"https://api.github.com/users/trieloff/gists{/gist_id}","starred_url":"https://api.github.com/users/trieloff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trieloff/subscriptions","organizations_url":"https://api.github.com/users/trieloff/orgs","repos_url":"https://api.github.com/users/trieloff/repos","events_url":"https://api.github.com/users/trieloff/events{/privacy}","received_events_url":"https://api.github.com/users/trieloff/received_events","type":"User","site_admin":false},"body":"I'd remove that property, as we can look it up in the segment/audience itself.","created_at":"2018-02-22T12:11:56Z","updated_at":"2018-02-22T12:31:36Z","html_url":"https://github.com/adobe/xdm/pull/135#discussion_r169937235","pull_request_url":"https://api.github.com/repos/adobe/xdm/pulls/135","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/adobe/xdm/pulls/comments/169937235"},"html":{"href":"https://github.com/adobe/xdm/pull/135#discussion_r169937235"},"pull_request":{"href":"https://api.github.com/repos/adobe/xdm/pulls/135"}}},"pull_request":{"url":"https://api.github.com/repos/adobe/xdm/pulls/135","id":170338899,"html_url":"https://github.com/adobe/xdm/pull/135","diff_url":"https://github.com/adobe/xdm/pull/135.diff","patch_url":"https://github.com/adobe/xdm/pull/135.patch","issue_url":"https://api.github.com/repos/adobe/xdm/issues/135","number":135,"state":"open","locked":false,"title":"WIP - Add new schemas from DMa platform: segment and propensity","user":{"login":"jwen-adobe","id":35241610,"avatar_url":"https://avatars2.githubusercontent.com/u/35241610?v=4","gravatar_id":"","url":"https://api.github.com/users/jwen-adobe","html_url":"https://github.com/jwen-adobe","followers_url":"https://api.github.com/users/jwen-adobe/followers","following_url":"https://api.github.com/users/jwen-adobe/following{/other_user}","gists_url":"https://api.github.com/users/jwen-adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/jwen-adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwen-adobe/subscriptions","organizations_url":"https://api.github.com/users/jwen-adobe/orgs","repos_url":"https://api.github.com/users/jwen-adobe/repos","events_url":"https://api.github.com/users/jwen-adobe/events{/privacy}","received_events_url":"https://api.github.com/users/jwen-adobe/received_events","type":"User","site_admin":false},"body":"This PR links to the issue #133 \r\n\r\n@trieloff @kstreeter @cmathis @cdegroot-adobe \r\n\r\nAdd new schemas below, see old comments from Lars here: https://github.com/adobe/xdm/pull/110\r\n-segment\r\n-propensity","created_at":"2018-02-20T23:32:06Z","updated_at":"2018-02-22T12:31:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dfe86257ff065aad6f50ec76d55699aa4f28823a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/adobe/xdm/pulls/135/commits","review_comments_url":"https://api.github.com/repos/adobe/xdm/pulls/135/comments","review_comment_url":"https://api.github.com/repos/adobe/xdm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adobe/xdm/issues/135/comments","statuses_url":"https://api.github.com/repos/adobe/xdm/statuses/13eba1505445321de262d30aa0f9a474f7eeeefb","head":{"label":"adobe:platform-pr-segment","ref":"platform-pr-segment","sha":"13eba1505445321de262d30aa0f9a474f7eeeefb","user":{"login":"adobe","id":476009,"avatar_url":"https://avatars2.githubusercontent.com/u/476009?v=4","gravatar_id":"","url":"https://api.github.com/users/adobe","html_url":"https://github.com/adobe","followers_url":"https://api.github.com/users/adobe/followers","following_url":"https://api.github.com/users/adobe/following{/other_user}","gists_url":"https://api.github.com/users/adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe/subscriptions","organizations_url":"https://api.github.com/users/adobe/orgs","repos_url":"https://api.github.com/users/adobe/repos","events_url":"https://api.github.com/users/adobe/events{/privacy}","received_events_url":"https://api.github.com/users/adobe/received_events","type":"Organization","site_admin":false},"repo":{"id":113054321,"name":"xdm","full_name":"adobe/xdm","owner":{"login":"adobe","id":476009,"avatar_url":"https://avatars2.githubusercontent.com/u/476009?v=4","gravatar_id":"","url":"https://api.github.com/users/adobe","html_url":"https://github.com/adobe","followers_url":"https://api.github.com/users/adobe/followers","following_url":"https://api.github.com/users/adobe/following{/other_user}","gists_url":"https://api.github.com/users/adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe/subscriptions","organizations_url":"https://api.github.com/users/adobe/orgs","repos_url":"https://api.github.com/users/adobe/repos","events_url":"https://api.github.com/users/adobe/events{/privacy}","received_events_url":"https://api.github.com/users/adobe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adobe/xdm","description":"Experience Data Model","fork":false,"url":"https://api.github.com/repos/adobe/xdm","forks_url":"https://api.github.com/repos/adobe/xdm/forks","keys_url":"https://api.github.com/repos/adobe/xdm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adobe/xdm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adobe/xdm/teams","hooks_url":"https://api.github.com/repos/adobe/xdm/hooks","issue_events_url":"https://api.github.com/repos/adobe/xdm/issues/events{/number}","events_url":"https://api.github.com/repos/adobe/xdm/events","assignees_url":"https://api.github.com/repos/adobe/xdm/assignees{/user}","branches_url":"https://api.github.com/repos/adobe/xdm/branches{/branch}","tags_url":"https://api.github.com/repos/adobe/xdm/tags","blobs_url":"https://api.github.com/repos/adobe/xdm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adobe/xdm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adobe/xdm/git/refs{/sha}","trees_url":"https://api.github.com/repos/adobe/xdm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adobe/xdm/statuses/{sha}","languages_url":"https://api.github.com/repos/adobe/xdm/languages","stargazers_url":"https://api.github.com/repos/adobe/xdm/stargazers","contributors_url":"https://api.github.com/repos/adobe/xdm/contributors","subscribers_url":"https://api.github.com/repos/adobe/xdm/subscribers","subscription_url":"https://api.github.com/repos/adobe/xdm/subscription","commits_url":"https://api.github.com/repos/adobe/xdm/commits{/sha}","git_commits_url":"https://api.github.com/repos/adobe/xdm/git/commits{/sha}","comments_url":"https://api.github.com/repos/adobe/xdm/comments{/number}","issue_comment_url":"https://api.github.com/repos/adobe/xdm/issues/comments{/number}","contents_url":"https://api.github.com/repos/adobe/xdm/contents/{+path}","compare_url":"https://api.github.com/repos/adobe/xdm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adobe/xdm/merges","archive_url":"https://api.github.com/repos/adobe/xdm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adobe/xdm/downloads","issues_url":"https://api.github.com/repos/adobe/xdm/issues{/number}","pulls_url":"https://api.github.com/repos/adobe/xdm/pulls{/number}","milestones_url":"https://api.github.com/repos/adobe/xdm/milestones{/number}","notifications_url":"https://api.github.com/repos/adobe/xdm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adobe/xdm/labels{/name}","releases_url":"https://api.github.com/repos/adobe/xdm/releases{/id}","deployments_url":"https://api.github.com/repos/adobe/xdm/deployments","created_at":"2017-12-04T14:40:24Z","updated_at":"2018-02-22T09:28:01Z","pushed_at":"2018-02-22T12:05:01Z","git_url":"git://github.com/adobe/xdm.git","ssh_url":"git@github.com:adobe/xdm.git","clone_url":"https://github.com/adobe/xdm.git","svn_url":"https://github.com/adobe/xdm","homepage":"","size":2548,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0"},"forks":24,"open_issues":46,"watchers":12,"default_branch":"master"}},"base":{"label":"adobe:master","ref":"master","sha":"9cb046bde3760055cf6369308251819cf24f1006","user":{"login":"adobe","id":476009,"avatar_url":"https://avatars2.githubusercontent.com/u/476009?v=4","gravatar_id":"","url":"https://api.github.com/users/adobe","html_url":"https://github.com/adobe","followers_url":"https://api.github.com/users/adobe/followers","following_url":"https://api.github.com/users/adobe/following{/other_user}","gists_url":"https://api.github.com/users/adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe/subscriptions","organizations_url":"https://api.github.com/users/adobe/orgs","repos_url":"https://api.github.com/users/adobe/repos","events_url":"https://api.github.com/users/adobe/events{/privacy}","received_events_url":"https://api.github.com/users/adobe/received_events","type":"Organization","site_admin":false},"repo":{"id":113054321,"name":"xdm","full_name":"adobe/xdm","owner":{"login":"adobe","id":476009,"avatar_url":"https://avatars2.githubusercontent.com/u/476009?v=4","gravatar_id":"","url":"https://api.github.com/users/adobe","html_url":"https://github.com/adobe","followers_url":"https://api.github.com/users/adobe/followers","following_url":"https://api.github.com/users/adobe/following{/other_user}","gists_url":"https://api.github.com/users/adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe/subscriptions","organizations_url":"https://api.github.com/users/adobe/orgs","repos_url":"https://api.github.com/users/adobe/repos","events_url":"https://api.github.com/users/adobe/events{/privacy}","received_events_url":"https://api.github.com/users/adobe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adobe/xdm","description":"Experience Data Model","fork":false,"url":"https://api.github.com/repos/adobe/xdm","forks_url":"https://api.github.com/repos/adobe/xdm/forks","keys_url":"https://api.github.com/repos/adobe/xdm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adobe/xdm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adobe/xdm/teams","hooks_url":"https://api.github.com/repos/adobe/xdm/hooks","issue_events_url":"https://api.github.com/repos/adobe/xdm/issues/events{/number}","events_url":"https://api.github.com/repos/adobe/xdm/events","assignees_url":"https://api.github.com/repos/adobe/xdm/assignees{/user}","branches_url":"https://api.github.com/repos/adobe/xdm/branches{/branch}","tags_url":"https://api.github.com/repos/adobe/xdm/tags","blobs_url":"https://api.github.com/repos/adobe/xdm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adobe/xdm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adobe/xdm/git/refs{/sha}","trees_url":"https://api.github.com/repos/adobe/xdm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adobe/xdm/statuses/{sha}","languages_url":"https://api.github.com/repos/adobe/xdm/languages","stargazers_url":"https://api.github.com/repos/adobe/xdm/stargazers","contributors_url":"https://api.github.com/repos/adobe/xdm/contributors","subscribers_url":"https://api.github.com/repos/adobe/xdm/subscribers","subscription_url":"https://api.github.com/repos/adobe/xdm/subscription","commits_url":"https://api.github.com/repos/adobe/xdm/commits{/sha}","git_commits_url":"https://api.github.com/repos/adobe/xdm/git/commits{/sha}","comments_url":"https://api.github.com/repos/adobe/xdm/comments{/number}","issue_comment_url":"https://api.github.com/repos/adobe/xdm/issues/comments{/number}","contents_url":"https://api.github.com/repos/adobe/xdm/contents/{+path}","compare_url":"https://api.github.com/repos/adobe/xdm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adobe/xdm/merges","archive_url":"https://api.github.com/repos/adobe/xdm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adobe/xdm/downloads","issues_url":"https://api.github.com/repos/adobe/xdm/issues{/number}","pulls_url":"https://api.github.com/repos/adobe/xdm/pulls{/number}","milestones_url":"https://api.github.com/repos/adobe/xdm/milestones{/number}","notifications_url":"https://api.github.com/repos/adobe/xdm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adobe/xdm/labels{/name}","releases_url":"https://api.github.com/repos/adobe/xdm/releases{/id}","deployments_url":"https://api.github.com/repos/adobe/xdm/deployments","created_at":"2017-12-04T14:40:24Z","updated_at":"2018-02-22T09:28:01Z","pushed_at":"2018-02-22T12:05:01Z","git_url":"git://github.com/adobe/xdm.git","ssh_url":"git@github.com:adobe/xdm.git","clone_url":"https://github.com/adobe/xdm.git","svn_url":"https://github.com/adobe/xdm","homepage":"","size":2548,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0"},"forks":24,"open_issues":46,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adobe/xdm/pulls/135"},"html":{"href":"https://github.com/adobe/xdm/pull/135"},"issue":{"href":"https://api.github.com/repos/adobe/xdm/issues/135"},"comments":{"href":"https://api.github.com/repos/adobe/xdm/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/adobe/xdm/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/adobe/xdm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adobe/xdm/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/adobe/xdm/statuses/13eba1505445321de262d30aa0f9a474f7eeeefb"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"trieloff"}}