{"action":"created","comment":{"url":"https://api.github.com/repos/chainer/chainer/pulls/comments/196296622","pull_request_review_id":129820178,"id":196296622,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjI5NjYyMg==","diff_hunk":"@@ -47,7 +47,8 @@ def setUp(self):\n         # Sample weights. Weights should not sum to 0.\n         while True:\n             self.w = numpy.random.uniform(-2, 2, w_shape).astype(self.dtype)\n-            if self.w.sum() > 1e-2:\n+            w_sum_eps = 1.0 if self.dtype == numpy.float16 else 5e-2\n+            if abs(self.w.sum()) > w_sum_eps:","path":"tests/chainer_tests/functions_tests/math_tests/test_average.py","position":6,"original_position":6,"commit_id":"25f76512e91dd7a9637f880b637b39349d43f0b8","original_commit_id":"25f76512e91dd7a9637f880b637b39349d43f0b8","user":{"login":"asi1024","id":5086403,"node_id":"MDQ6VXNlcjUwODY0MDM=","avatar_url":"https://avatars1.githubusercontent.com/u/5086403?v=4","gravatar_id":"","url":"https://api.github.com/users/asi1024","html_url":"https://github.com/asi1024","followers_url":"https://api.github.com/users/asi1024/followers","following_url":"https://api.github.com/users/asi1024/following{/other_user}","gists_url":"https://api.github.com/users/asi1024/gists{/gist_id}","starred_url":"https://api.github.com/users/asi1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asi1024/subscriptions","organizations_url":"https://api.github.com/users/asi1024/orgs","repos_url":"https://api.github.com/users/asi1024/repos","events_url":"https://api.github.com/users/asi1024/events{/privacy}","received_events_url":"https://api.github.com/users/asi1024/received_events","type":"User","site_admin":false},"body":"I tried `abs(self.w.astype(numpy.float64).sum()) > w_sum_eps`, but the test failed.","created_at":"2018-06-19T05:19:11Z","updated_at":"2018-06-19T05:19:11Z","html_url":"https://github.com/chainer/chainer/pull/4771#discussion_r196296622","pull_request_url":"https://api.github.com/repos/chainer/chainer/pulls/4771","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/chainer/chainer/pulls/comments/196296622"},"html":{"href":"https://github.com/chainer/chainer/pull/4771#discussion_r196296622"},"pull_request":{"href":"https://api.github.com/repos/chainer/chainer/pulls/4771"}},"in_reply_to_id":196296008},"pull_request":{"url":"https://api.github.com/repos/chainer/chainer/pulls/4771","id":187853319,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg3ODUzMzE5","html_url":"https://github.com/chainer/chainer/pull/4771","diff_url":"https://github.com/chainer/chainer/pull/4771.diff","patch_url":"https://github.com/chainer/chainer/pull/4771.patch","issue_url":"https://api.github.com/repos/chainer/chainer/issues/4771","number":4771,"state":"open","locked":false,"title":"Fix occasional test failure of `F.average` by changing lower-bound of weight.sum","user":{"login":"asi1024","id":5086403,"node_id":"MDQ6VXNlcjUwODY0MDM=","avatar_url":"https://avatars1.githubusercontent.com/u/5086403?v=4","gravatar_id":"","url":"https://api.github.com/users/asi1024","html_url":"https://github.com/asi1024","followers_url":"https://api.github.com/users/asi1024/followers","following_url":"https://api.github.com/users/asi1024/following{/other_user}","gists_url":"https://api.github.com/users/asi1024/gists{/gist_id}","starred_url":"https://api.github.com/users/asi1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asi1024/subscriptions","organizations_url":"https://api.github.com/users/asi1024/orgs","repos_url":"https://api.github.com/users/asi1024/repos","events_url":"https://api.github.com/users/asi1024/events{/privacy}","received_events_url":"https://api.github.com/users/asi1024/received_events","type":"User","site_admin":false},"body":"Fixed the lower bound of `self.w.sum()`.\r\n(#3766)","created_at":"2018-05-14T14:51:00Z","updated_at":"2018-06-19T05:19:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7debec878201c81450e09c480fd7f68ce87745ca","assignee":{"login":"kmaehashi","id":939877,"node_id":"MDQ6VXNlcjkzOTg3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/939877?v=4","gravatar_id":"","url":"https://api.github.com/users/kmaehashi","html_url":"https://github.com/kmaehashi","followers_url":"https://api.github.com/users/kmaehashi/followers","following_url":"https://api.github.com/users/kmaehashi/following{/other_user}","gists_url":"https://api.github.com/users/kmaehashi/gists{/gist_id}","starred_url":"https://api.github.com/users/kmaehashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmaehashi/subscriptions","organizations_url":"https://api.github.com/users/kmaehashi/orgs","repos_url":"https://api.github.com/users/kmaehashi/repos","events_url":"https://api.github.com/users/kmaehashi/events{/privacy}","received_events_url":"https://api.github.com/users/kmaehashi/received_events","type":"User","site_admin":false},"assignees":[{"login":"kmaehashi","id":939877,"node_id":"MDQ6VXNlcjkzOTg3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/939877?v=4","gravatar_id":"","url":"https://api.github.com/users/kmaehashi","html_url":"https://github.com/kmaehashi","followers_url":"https://api.github.com/users/kmaehashi/followers","following_url":"https://api.github.com/users/kmaehashi/following{/other_user}","gists_url":"https://api.github.com/users/kmaehashi/gists{/gist_id}","starred_url":"https://api.github.com/users/kmaehashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmaehashi/subscriptions","organizations_url":"https://api.github.com/users/kmaehashi/orgs","repos_url":"https://api.github.com/users/kmaehashi/repos","events_url":"https://api.github.com/users/kmaehashi/events{/privacy}","received_events_url":"https://api.github.com/users/kmaehashi/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":227815619,"node_id":"MDU6TGFiZWwyMjc4MTU2MTk=","url":"https://api.github.com/repos/chainer/chainer/labels/test","name":"test","color":"009800","default":false},{"id":619749531,"node_id":"MDU6TGFiZWw2MTk3NDk1MzE=","url":"https://api.github.com/repos/chainer/chainer/labels/to-be-backported","name":"to-be-backported","color":"fef2c0","default":false}],"milestone":{"url":"https://api.github.com/repos/chainer/chainer/milestones/67","html_url":"https://github.com/chainer/chainer/milestone/67","labels_url":"https://api.github.com/repos/chainer/chainer/milestones/67/labels","id":3367415,"node_id":"MDk6TWlsZXN0b25lMzM2NzQxNQ==","number":67,"title":"v5.0.0b2","description":"","creator":{"login":"kmaehashi","id":939877,"node_id":"MDQ6VXNlcjkzOTg3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/939877?v=4","gravatar_id":"","url":"https://api.github.com/users/kmaehashi","html_url":"https://github.com/kmaehashi","followers_url":"https://api.github.com/users/kmaehashi/followers","following_url":"https://api.github.com/users/kmaehashi/following{/other_user}","gists_url":"https://api.github.com/users/kmaehashi/gists{/gist_id}","starred_url":"https://api.github.com/users/kmaehashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmaehashi/subscriptions","organizations_url":"https://api.github.com/users/kmaehashi/orgs","repos_url":"https://api.github.com/users/kmaehashi/repos","events_url":"https://api.github.com/users/kmaehashi/events{/privacy}","received_events_url":"https://api.github.com/users/kmaehashi/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":88,"state":"open","created_at":"2018-05-23T02:55:03Z","updated_at":"2018-06-19T01:31:02Z","due_on":"2018-06-21T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/chainer/chainer/pulls/4771/commits","review_comments_url":"https://api.github.com/repos/chainer/chainer/pulls/4771/comments","review_comment_url":"https://api.github.com/repos/chainer/chainer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chainer/chainer/issues/4771/comments","statuses_url":"https://api.github.com/repos/chainer/chainer/statuses/25f76512e91dd7a9637f880b637b39349d43f0b8","head":{"label":"asi1024:fix-#3766-average","ref":"fix-#3766-average","sha":"25f76512e91dd7a9637f880b637b39349d43f0b8","user":{"login":"asi1024","id":5086403,"node_id":"MDQ6VXNlcjUwODY0MDM=","avatar_url":"https://avatars1.githubusercontent.com/u/5086403?v=4","gravatar_id":"","url":"https://api.github.com/users/asi1024","html_url":"https://github.com/asi1024","followers_url":"https://api.github.com/users/asi1024/followers","following_url":"https://api.github.com/users/asi1024/following{/other_user}","gists_url":"https://api.github.com/users/asi1024/gists{/gist_id}","starred_url":"https://api.github.com/users/asi1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asi1024/subscriptions","organizations_url":"https://api.github.com/users/asi1024/orgs","repos_url":"https://api.github.com/users/asi1024/repos","events_url":"https://api.github.com/users/asi1024/events{/privacy}","received_events_url":"https://api.github.com/users/asi1024/received_events","type":"User","site_admin":false},"repo":{"id":64816174,"node_id":"MDEwOlJlcG9zaXRvcnk2NDgxNjE3NA==","name":"chainer","full_name":"asi1024/chainer","owner":{"login":"asi1024","id":5086403,"node_id":"MDQ6VXNlcjUwODY0MDM=","avatar_url":"https://avatars1.githubusercontent.com/u/5086403?v=4","gravatar_id":"","url":"https://api.github.com/users/asi1024","html_url":"https://github.com/asi1024","followers_url":"https://api.github.com/users/asi1024/followers","following_url":"https://api.github.com/users/asi1024/following{/other_user}","gists_url":"https://api.github.com/users/asi1024/gists{/gist_id}","starred_url":"https://api.github.com/users/asi1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asi1024/subscriptions","organizations_url":"https://api.github.com/users/asi1024/orgs","repos_url":"https://api.github.com/users/asi1024/repos","events_url":"https://api.github.com/users/asi1024/events{/privacy}","received_events_url":"https://api.github.com/users/asi1024/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asi1024/chainer","description":"A flexible framework of neural networks for deep learning","fork":true,"url":"https://api.github.com/repos/asi1024/chainer","forks_url":"https://api.github.com/repos/asi1024/chainer/forks","keys_url":"https://api.github.com/repos/asi1024/chainer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asi1024/chainer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asi1024/chainer/teams","hooks_url":"https://api.github.com/repos/asi1024/chainer/hooks","issue_events_url":"https://api.github.com/repos/asi1024/chainer/issues/events{/number}","events_url":"https://api.github.com/repos/asi1024/chainer/events","assignees_url":"https://api.github.com/repos/asi1024/chainer/assignees{/user}","branches_url":"https://api.github.com/repos/asi1024/chainer/branches{/branch}","tags_url":"https://api.github.com/repos/asi1024/chainer/tags","blobs_url":"https://api.github.com/repos/asi1024/chainer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asi1024/chainer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asi1024/chainer/git/refs{/sha}","trees_url":"https://api.github.com/repos/asi1024/chainer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asi1024/chainer/statuses/{sha}","languages_url":"https://api.github.com/repos/asi1024/chainer/languages","stargazers_url":"https://api.github.com/repos/asi1024/chainer/stargazers","contributors_url":"https://api.github.com/repos/asi1024/chainer/contributors","subscribers_url":"https://api.github.com/repos/asi1024/chainer/subscribers","subscription_url":"https://api.github.com/repos/asi1024/chainer/subscription","commits_url":"https://api.github.com/repos/asi1024/chainer/commits{/sha}","git_commits_url":"https://api.github.com/repos/asi1024/chainer/git/commits{/sha}","comments_url":"https://api.github.com/repos/asi1024/chainer/comments{/number}","issue_comment_url":"https://api.github.com/repos/asi1024/chainer/issues/comments{/number}","contents_url":"https://api.github.com/repos/asi1024/chainer/contents/{+path}","compare_url":"https://api.github.com/repos/asi1024/chainer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asi1024/chainer/merges","archive_url":"https://api.github.com/repos/asi1024/chainer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asi1024/chainer/downloads","issues_url":"https://api.github.com/repos/asi1024/chainer/issues{/number}","pulls_url":"https://api.github.com/repos/asi1024/chainer/pulls{/number}","milestones_url":"https://api.github.com/repos/asi1024/chainer/milestones{/number}","notifications_url":"https://api.github.com/repos/asi1024/chainer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asi1024/chainer/labels{/name}","releases_url":"https://api.github.com/repos/asi1024/chainer/releases{/id}","deployments_url":"https://api.github.com/repos/asi1024/chainer/deployments","created_at":"2016-08-03T04:56:30Z","updated_at":"2018-06-07T09:18:09Z","pushed_at":"2018-06-17T14:32:18Z","git_url":"git://github.com/asi1024/chainer.git","ssh_url":"git@github.com:asi1024/chainer.git","clone_url":"https://github.com/asi1024/chainer.git","svn_url":"https://github.com/asi1024/chainer","homepage":"http://chainer.org","size":29172,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chainer:master","ref":"master","sha":"3efc4b1ba014d7740faa8de333ecb634933199b3","user":{"login":"chainer","id":23183003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTgzMDAz","avatar_url":"https://avatars3.githubusercontent.com/u/23183003?v=4","gravatar_id":"","url":"https://api.github.com/users/chainer","html_url":"https://github.com/chainer","followers_url":"https://api.github.com/users/chainer/followers","following_url":"https://api.github.com/users/chainer/following{/other_user}","gists_url":"https://api.github.com/users/chainer/gists{/gist_id}","starred_url":"https://api.github.com/users/chainer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chainer/subscriptions","organizations_url":"https://api.github.com/users/chainer/orgs","repos_url":"https://api.github.com/users/chainer/repos","events_url":"https://api.github.com/users/chainer/events{/privacy}","received_events_url":"https://api.github.com/users/chainer/received_events","type":"Organization","site_admin":false},"repo":{"id":36914478,"node_id":"MDEwOlJlcG9zaXRvcnkzNjkxNDQ3OA==","name":"chainer","full_name":"chainer/chainer","owner":{"login":"chainer","id":23183003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTgzMDAz","avatar_url":"https://avatars3.githubusercontent.com/u/23183003?v=4","gravatar_id":"","url":"https://api.github.com/users/chainer","html_url":"https://github.com/chainer","followers_url":"https://api.github.com/users/chainer/followers","following_url":"https://api.github.com/users/chainer/following{/other_user}","gists_url":"https://api.github.com/users/chainer/gists{/gist_id}","starred_url":"https://api.github.com/users/chainer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chainer/subscriptions","organizations_url":"https://api.github.com/users/chainer/orgs","repos_url":"https://api.github.com/users/chainer/repos","events_url":"https://api.github.com/users/chainer/events{/privacy}","received_events_url":"https://api.github.com/users/chainer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chainer/chainer","description":"A flexible framework of neural networks for deep learning","fork":false,"url":"https://api.github.com/repos/chainer/chainer","forks_url":"https://api.github.com/repos/chainer/chainer/forks","keys_url":"https://api.github.com/repos/chainer/chainer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chainer/chainer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chainer/chainer/teams","hooks_url":"https://api.github.com/repos/chainer/chainer/hooks","issue_events_url":"https://api.github.com/repos/chainer/chainer/issues/events{/number}","events_url":"https://api.github.com/repos/chainer/chainer/events","assignees_url":"https://api.github.com/repos/chainer/chainer/assignees{/user}","branches_url":"https://api.github.com/repos/chainer/chainer/branches{/branch}","tags_url":"https://api.github.com/repos/chainer/chainer/tags","blobs_url":"https://api.github.com/repos/chainer/chainer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chainer/chainer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chainer/chainer/git/refs{/sha}","trees_url":"https://api.github.com/repos/chainer/chainer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chainer/chainer/statuses/{sha}","languages_url":"https://api.github.com/repos/chainer/chainer/languages","stargazers_url":"https://api.github.com/repos/chainer/chainer/stargazers","contributors_url":"https://api.github.com/repos/chainer/chainer/contributors","subscribers_url":"https://api.github.com/repos/chainer/chainer/subscribers","subscription_url":"https://api.github.com/repos/chainer/chainer/subscription","commits_url":"https://api.github.com/repos/chainer/chainer/commits{/sha}","git_commits_url":"https://api.github.com/repos/chainer/chainer/git/commits{/sha}","comments_url":"https://api.github.com/repos/chainer/chainer/comments{/number}","issue_comment_url":"https://api.github.com/repos/chainer/chainer/issues/comments{/number}","contents_url":"https://api.github.com/repos/chainer/chainer/contents/{+path}","compare_url":"https://api.github.com/repos/chainer/chainer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chainer/chainer/merges","archive_url":"https://api.github.com/repos/chainer/chainer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chainer/chainer/downloads","issues_url":"https://api.github.com/repos/chainer/chainer/issues{/number}","pulls_url":"https://api.github.com/repos/chainer/chainer/pulls{/number}","milestones_url":"https://api.github.com/repos/chainer/chainer/milestones{/number}","notifications_url":"https://api.github.com/repos/chainer/chainer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chainer/chainer/labels{/name}","releases_url":"https://api.github.com/repos/chainer/chainer/releases{/id}","deployments_url":"https://api.github.com/repos/chainer/chainer/deployments","created_at":"2015-06-05T05:50:37Z","updated_at":"2018-06-19T03:28:37Z","pushed_at":"2018-06-19T05:00:21Z","git_url":"git://github.com/chainer/chainer.git","ssh_url":"git@github.com:chainer/chainer.git","clone_url":"https://github.com/chainer/chainer.git","svn_url":"https://github.com/chainer/chainer","homepage":"https://chainer.org","size":25664,"stargazers_count":3899,"watchers_count":3899,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1034,"mirror_url":null,"archived":false,"open_issues_count":206,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1034,"open_issues":206,"watchers":3899,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chainer/chainer/pulls/4771"},"html":{"href":"https://github.com/chainer/chainer/pull/4771"},"issue":{"href":"https://api.github.com/repos/chainer/chainer/issues/4771"},"comments":{"href":"https://api.github.com/repos/chainer/chainer/issues/4771/comments"},"review_comments":{"href":"https://api.github.com/repos/chainer/chainer/pulls/4771/comments"},"review_comment":{"href":"https://api.github.com/repos/chainer/chainer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chainer/chainer/pulls/4771/commits"},"statuses":{"href":"https://api.github.com/repos/chainer/chainer/statuses/25f76512e91dd7a9637f880b637b39349d43f0b8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"asi1024"}}