{"action":"created","comment":{"url":"https://api.github.com/repos/pillar-markup/pillar/pulls/comments/198862553","pull_request_review_id":132869523,"id":198862553,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODg2MjU1Mw==","diff_hunk":"@@ -0,0 +1,5 @@\n+sorting\n+sort: aCollectionOfReferences by: aString\n+\taString = 'date' ifTrue: [ ^ PRDocumentListDateSorter with: aCollectionOfReferences ].\n+\taString = 'name' ifTrue: [ ^ PRDocumentListNameSorter with: aCollectionOfReferences ].","path":"src/Pillar-ExporterCore.package/PRDocumentListTransformer.class/instance/sort.by..st","position":4,"original_position":4,"commit_id":"e87c355bba02ab1ad6b70696a85094cb910d0716","original_commit_id":"e87c355bba02ab1ad6b70696a85094cb910d0716","user":{"login":"guillep","id":708322,"node_id":"MDQ6VXNlcjcwODMyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/708322?v=4","gravatar_id":"","url":"https://api.github.com/users/guillep","html_url":"https://github.com/guillep","followers_url":"https://api.github.com/users/guillep/followers","following_url":"https://api.github.com/users/guillep/following{/other_user}","gists_url":"https://api.github.com/users/guillep/gists{/gist_id}","starred_url":"https://api.github.com/users/guillep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guillep/subscriptions","organizations_url":"https://api.github.com/users/guillep/orgs","repos_url":"https://api.github.com/users/guillep/repos","events_url":"https://api.github.com/users/guillep/events{/privacy}","received_events_url":"https://api.github.com/users/guillep/received_events","type":"User","site_admin":false},"body":"We will have to see how to sort by default, and what happens if there is an invalid value.","created_at":"2018-06-28T14:28:23Z","updated_at":"2018-06-28T14:29:03Z","html_url":"https://github.com/pillar-markup/pillar/pull/315#discussion_r198862553","pull_request_url":"https://api.github.com/repos/pillar-markup/pillar/pulls/315","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pillar-markup/pillar/pulls/comments/198862553"},"html":{"href":"https://github.com/pillar-markup/pillar/pull/315#discussion_r198862553"},"pull_request":{"href":"https://api.github.com/repos/pillar-markup/pillar/pulls/315"}}},"pull_request":{"url":"https://api.github.com/repos/pillar-markup/pillar/pulls/315","id":196138753,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MTM4NzUz","html_url":"https://github.com/pillar-markup/pillar/pull/315","diff_url":"https://github.com/pillar-markup/pillar/pull/315.diff","patch_url":"https://github.com/pillar-markup/pillar/pull/315.patch","issue_url":"https://api.github.com/repos/pillar-markup/pillar/issues/315","number":315,"state":"open","locked":false,"title":"Clean code of DocumentList transformer","user":{"login":"samakhov","id":13077011,"node_id":"MDQ6VXNlcjEzMDc3MDEx","avatar_url":"https://avatars3.githubusercontent.com/u/13077011?v=4","gravatar_id":"","url":"https://api.github.com/users/samakhov","html_url":"https://github.com/samakhov","followers_url":"https://api.github.com/users/samakhov/followers","following_url":"https://api.github.com/users/samakhov/following{/other_user}","gists_url":"https://api.github.com/users/samakhov/gists{/gist_id}","starred_url":"https://api.github.com/users/samakhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samakhov/subscriptions","organizations_url":"https://api.github.com/users/samakhov/orgs","repos_url":"https://api.github.com/users/samakhov/repos","events_url":"https://api.github.com/users/samakhov/events{/privacy}","received_events_url":"https://api.github.com/users/samakhov/received_events","type":"User","site_admin":false},"body":"-Move DocumentListTransformer to Document-List in Pillar-ExporterCore\r-Move DocumentListAnnotation to Document-List in Pillar-Model\r-and so on for tests\r-Also check for links","created_at":"2018-06-20T13:29:01Z","updated_at":"2018-06-28T14:29:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9532dc9469ca8d894319be9ead8793de9e944452","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pillar-markup/pillar/pulls/315/commits","review_comments_url":"https://api.github.com/repos/pillar-markup/pillar/pulls/315/comments","review_comment_url":"https://api.github.com/repos/pillar-markup/pillar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pillar-markup/pillar/issues/315/comments","statuses_url":"https://api.github.com/repos/pillar-markup/pillar/statuses/e87c355bba02ab1ad6b70696a85094cb910d0716","head":{"label":"samakhov:fix/annotation2","ref":"fix/annotation2","sha":"e87c355bba02ab1ad6b70696a85094cb910d0716","user":{"login":"samakhov","id":13077011,"node_id":"MDQ6VXNlcjEzMDc3MDEx","avatar_url":"https://avatars3.githubusercontent.com/u/13077011?v=4","gravatar_id":"","url":"https://api.github.com/users/samakhov","html_url":"https://github.com/samakhov","followers_url":"https://api.github.com/users/samakhov/followers","following_url":"https://api.github.com/users/samakhov/following{/other_user}","gists_url":"https://api.github.com/users/samakhov/gists{/gist_id}","starred_url":"https://api.github.com/users/samakhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samakhov/subscriptions","organizations_url":"https://api.github.com/users/samakhov/orgs","repos_url":"https://api.github.com/users/samakhov/repos","events_url":"https://api.github.com/users/samakhov/events{/privacy}","received_events_url":"https://api.github.com/users/samakhov/received_events","type":"User","site_admin":false},"repo":{"id":116695075,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY2OTUwNzU=","name":"pillar","full_name":"samakhov/pillar","owner":{"login":"samakhov","id":13077011,"node_id":"MDQ6VXNlcjEzMDc3MDEx","avatar_url":"https://avatars3.githubusercontent.com/u/13077011?v=4","gravatar_id":"","url":"https://api.github.com/users/samakhov","html_url":"https://github.com/samakhov","followers_url":"https://api.github.com/users/samakhov/followers","following_url":"https://api.github.com/users/samakhov/following{/other_user}","gists_url":"https://api.github.com/users/samakhov/gists{/gist_id}","starred_url":"https://api.github.com/users/samakhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samakhov/subscriptions","organizations_url":"https://api.github.com/users/samakhov/orgs","repos_url":"https://api.github.com/users/samakhov/repos","events_url":"https://api.github.com/users/samakhov/events{/privacy}","received_events_url":"https://api.github.com/users/samakhov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samakhov/pillar","description":"Markup syntax and associated tools to write and generate documentation, books and slides","fork":true,"url":"https://api.github.com/repos/samakhov/pillar","forks_url":"https://api.github.com/repos/samakhov/pillar/forks","keys_url":"https://api.github.com/repos/samakhov/pillar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samakhov/pillar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samakhov/pillar/teams","hooks_url":"https://api.github.com/repos/samakhov/pillar/hooks","issue_events_url":"https://api.github.com/repos/samakhov/pillar/issues/events{/number}","events_url":"https://api.github.com/repos/samakhov/pillar/events","assignees_url":"https://api.github.com/repos/samakhov/pillar/assignees{/user}","branches_url":"https://api.github.com/repos/samakhov/pillar/branches{/branch}","tags_url":"https://api.github.com/repos/samakhov/pillar/tags","blobs_url":"https://api.github.com/repos/samakhov/pillar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samakhov/pillar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samakhov/pillar/git/refs{/sha}","trees_url":"https://api.github.com/repos/samakhov/pillar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samakhov/pillar/statuses/{sha}","languages_url":"https://api.github.com/repos/samakhov/pillar/languages","stargazers_url":"https://api.github.com/repos/samakhov/pillar/stargazers","contributors_url":"https://api.github.com/repos/samakhov/pillar/contributors","subscribers_url":"https://api.github.com/repos/samakhov/pillar/subscribers","subscription_url":"https://api.github.com/repos/samakhov/pillar/subscription","commits_url":"https://api.github.com/repos/samakhov/pillar/commits{/sha}","git_commits_url":"https://api.github.com/repos/samakhov/pillar/git/commits{/sha}","comments_url":"https://api.github.com/repos/samakhov/pillar/comments{/number}","issue_comment_url":"https://api.github.com/repos/samakhov/pillar/issues/comments{/number}","contents_url":"https://api.github.com/repos/samakhov/pillar/contents/{+path}","compare_url":"https://api.github.com/repos/samakhov/pillar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samakhov/pillar/merges","archive_url":"https://api.github.com/repos/samakhov/pillar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samakhov/pillar/downloads","issues_url":"https://api.github.com/repos/samakhov/pillar/issues{/number}","pulls_url":"https://api.github.com/repos/samakhov/pillar/pulls{/number}","milestones_url":"https://api.github.com/repos/samakhov/pillar/milestones{/number}","notifications_url":"https://api.github.com/repos/samakhov/pillar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samakhov/pillar/labels{/name}","releases_url":"https://api.github.com/repos/samakhov/pillar/releases{/id}","deployments_url":"https://api.github.com/repos/samakhov/pillar/deployments","created_at":"2018-01-08T15:38:21Z","updated_at":"2018-01-08T15:38:22Z","pushed_at":"2018-06-28T09:33:24Z","git_url":"git://github.com/samakhov/pillar.git","ssh_url":"git@github.com:samakhov/pillar.git","clone_url":"https://github.com/samakhov/pillar.git","svn_url":"https://github.com/samakhov/pillar","homepage":"http://www.smalltalkhub.com/#!/~Pier/Pillar","size":4609,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pillar-markup:dev-7","ref":"dev-7","sha":"38c412e3ed4dbc343902ce50bc3a82be54e06ca0","user":{"login":"pillar-markup","id":7497635,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0OTc2MzU=","avatar_url":"https://avatars0.githubusercontent.com/u/7497635?v=4","gravatar_id":"","url":"https://api.github.com/users/pillar-markup","html_url":"https://github.com/pillar-markup","followers_url":"https://api.github.com/users/pillar-markup/followers","following_url":"https://api.github.com/users/pillar-markup/following{/other_user}","gists_url":"https://api.github.com/users/pillar-markup/gists{/gist_id}","starred_url":"https://api.github.com/users/pillar-markup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pillar-markup/subscriptions","organizations_url":"https://api.github.com/users/pillar-markup/orgs","repos_url":"https://api.github.com/users/pillar-markup/repos","events_url":"https://api.github.com/users/pillar-markup/events{/privacy}","received_events_url":"https://api.github.com/users/pillar-markup/received_events","type":"Organization","site_admin":false},"repo":{"id":41843105,"node_id":"MDEwOlJlcG9zaXRvcnk0MTg0MzEwNQ==","name":"pillar","full_name":"pillar-markup/pillar","owner":{"login":"pillar-markup","id":7497635,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0OTc2MzU=","avatar_url":"https://avatars0.githubusercontent.com/u/7497635?v=4","gravatar_id":"","url":"https://api.github.com/users/pillar-markup","html_url":"https://github.com/pillar-markup","followers_url":"https://api.github.com/users/pillar-markup/followers","following_url":"https://api.github.com/users/pillar-markup/following{/other_user}","gists_url":"https://api.github.com/users/pillar-markup/gists{/gist_id}","starred_url":"https://api.github.com/users/pillar-markup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pillar-markup/subscriptions","organizations_url":"https://api.github.com/users/pillar-markup/orgs","repos_url":"https://api.github.com/users/pillar-markup/repos","events_url":"https://api.github.com/users/pillar-markup/events{/privacy}","received_events_url":"https://api.github.com/users/pillar-markup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pillar-markup/pillar","description":"Markup syntax and associated tools to write and generate documentation, books and slides","fork":false,"url":"https://api.github.com/repos/pillar-markup/pillar","forks_url":"https://api.github.com/repos/pillar-markup/pillar/forks","keys_url":"https://api.github.com/repos/pillar-markup/pillar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pillar-markup/pillar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pillar-markup/pillar/teams","hooks_url":"https://api.github.com/repos/pillar-markup/pillar/hooks","issue_events_url":"https://api.github.com/repos/pillar-markup/pillar/issues/events{/number}","events_url":"https://api.github.com/repos/pillar-markup/pillar/events","assignees_url":"https://api.github.com/repos/pillar-markup/pillar/assignees{/user}","branches_url":"https://api.github.com/repos/pillar-markup/pillar/branches{/branch}","tags_url":"https://api.github.com/repos/pillar-markup/pillar/tags","blobs_url":"https://api.github.com/repos/pillar-markup/pillar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pillar-markup/pillar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pillar-markup/pillar/git/refs{/sha}","trees_url":"https://api.github.com/repos/pillar-markup/pillar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pillar-markup/pillar/statuses/{sha}","languages_url":"https://api.github.com/repos/pillar-markup/pillar/languages","stargazers_url":"https://api.github.com/repos/pillar-markup/pillar/stargazers","contributors_url":"https://api.github.com/repos/pillar-markup/pillar/contributors","subscribers_url":"https://api.github.com/repos/pillar-markup/pillar/subscribers","subscription_url":"https://api.github.com/repos/pillar-markup/pillar/subscription","commits_url":"https://api.github.com/repos/pillar-markup/pillar/commits{/sha}","git_commits_url":"https://api.github.com/repos/pillar-markup/pillar/git/commits{/sha}","comments_url":"https://api.github.com/repos/pillar-markup/pillar/comments{/number}","issue_comment_url":"https://api.github.com/repos/pillar-markup/pillar/issues/comments{/number}","contents_url":"https://api.github.com/repos/pillar-markup/pillar/contents/{+path}","compare_url":"https://api.github.com/repos/pillar-markup/pillar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pillar-markup/pillar/merges","archive_url":"https://api.github.com/repos/pillar-markup/pillar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pillar-markup/pillar/downloads","issues_url":"https://api.github.com/repos/pillar-markup/pillar/issues{/number}","pulls_url":"https://api.github.com/repos/pillar-markup/pillar/pulls{/number}","milestones_url":"https://api.github.com/repos/pillar-markup/pillar/milestones{/number}","notifications_url":"https://api.github.com/repos/pillar-markup/pillar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pillar-markup/pillar/labels{/name}","releases_url":"https://api.github.com/repos/pillar-markup/pillar/releases{/id}","deployments_url":"https://api.github.com/repos/pillar-markup/pillar/deployments","created_at":"2015-09-03T05:16:04Z","updated_at":"2018-06-22T12:31:57Z","pushed_at":"2018-06-27T14:17:11Z","git_url":"git://github.com/pillar-markup/pillar.git","ssh_url":"git@github.com:pillar-markup/pillar.git","clone_url":"https://github.com/pillar-markup/pillar.git","svn_url":"https://github.com/pillar-markup/pillar","homepage":"http://www.smalltalkhub.com/#!/~Pier/Pillar","size":4585,"stargazers_count":13,"watchers_count":13,"language":"Smalltalk","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":150,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":14,"open_issues":150,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pillar-markup/pillar/pulls/315"},"html":{"href":"https://github.com/pillar-markup/pillar/pull/315"},"issue":{"href":"https://api.github.com/repos/pillar-markup/pillar/issues/315"},"comments":{"href":"https://api.github.com/repos/pillar-markup/pillar/issues/315/comments"},"review_comments":{"href":"https://api.github.com/repos/pillar-markup/pillar/pulls/315/comments"},"review_comment":{"href":"https://api.github.com/repos/pillar-markup/pillar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pillar-markup/pillar/pulls/315/commits"},"statuses":{"href":"https://api.github.com/repos/pillar-markup/pillar/statuses/e87c355bba02ab1ad6b70696a85094cb910d0716"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"guillep"}}