{"action":"created","issue":{"url":"https://api.github.com/repos/hyleung/ratpack-zipkin/issues/64","repository_url":"https://api.github.com/repos/hyleung/ratpack-zipkin","labels_url":"https://api.github.com/repos/hyleung/ratpack-zipkin/issues/64/labels{/name}","comments_url":"https://api.github.com/repos/hyleung/ratpack-zipkin/issues/64/comments","events_url":"https://api.github.com/repos/hyleung/ratpack-zipkin/issues/64/events","html_url":"https://github.com/hyleung/ratpack-zipkin/issues/64","id":386890190,"node_id":"MDU6SXNzdWUzODY4OTAxOTA=","number":64,"title":"Support Ratpack 1.6","user":{"login":"llinder","id":99359,"node_id":"MDQ6VXNlcjk5MzU5","avatar_url":"https://avatars1.githubusercontent.com/u/99359?v=4","gravatar_id":"","url":"https://api.github.com/users/llinder","html_url":"https://github.com/llinder","followers_url":"https://api.github.com/users/llinder/followers","following_url":"https://api.github.com/users/llinder/following{/other_user}","gists_url":"https://api.github.com/users/llinder/gists{/gist_id}","starred_url":"https://api.github.com/users/llinder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llinder/subscriptions","organizations_url":"https://api.github.com/users/llinder/orgs","repos_url":"https://api.github.com/users/llinder/repos","events_url":"https://api.github.com/users/llinder/events{/privacy}","received_events_url":"https://api.github.com/users/llinder/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-03T16:11:02Z","updated_at":"2018-12-09T20:32:53Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Ratpack 1.6 is out and should include a client interceptor API now.   I suspect we will get better milage from using the interceptors and hope that it may also fix some anomalies around client tracing that have been seen under heavy load."},"comment":{"url":"https://api.github.com/repos/hyleung/ratpack-zipkin/issues/comments/445569037","html_url":"https://github.com/hyleung/ratpack-zipkin/issues/64#issuecomment-445569037","issue_url":"https://api.github.com/repos/hyleung/ratpack-zipkin/issues/64","id":445569037,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTU2OTAzNw==","user":{"login":"llinder","id":99359,"node_id":"MDQ6VXNlcjk5MzU5","avatar_url":"https://avatars1.githubusercontent.com/u/99359?v=4","gravatar_id":"","url":"https://api.github.com/users/llinder","html_url":"https://github.com/llinder","followers_url":"https://api.github.com/users/llinder/followers","following_url":"https://api.github.com/users/llinder/following{/other_user}","gists_url":"https://api.github.com/users/llinder/gists{/gist_id}","starred_url":"https://api.github.com/users/llinder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llinder/subscriptions","organizations_url":"https://api.github.com/users/llinder/orgs","repos_url":"https://api.github.com/users/llinder/repos","events_url":"https://api.github.com/users/llinder/events{/privacy}","received_events_url":"https://api.github.com/users/llinder/received_events","type":"User","site_admin":false},"created_at":"2018-12-09T20:32:53Z","updated_at":"2018-12-09T20:32:53Z","author_association":"CONTRIBUTOR","body":"Thanks for the heads up on the issues.  So far the upgrade has been going ok.  I actually started on the client interceptor changes first.  My biggest concern right now is backwards compatibility with Ratpack 1.5.x.  I guess at worst case we end up with 2 branches, either that or we try to be clever on detecting the version and maintain different code internally.  Either way its not going to be the most pleasant I suppose.\r\n\r\nSorry I skipped the 1.5.4 upgrade you started.  We have been seeing weird things with client tracing where 2 spans are started on occasion and only one is finished.  My hope is that the 1.6 interceptors resolve this... if not then we can raise an issue in Ratpack."}}
{"actor":{"display_login":"llinder"}}