{"action":"created","comment":{"url":"https://api.github.com/repos/neo-one-suite/neo-one/pulls/comments/239352108","pull_request_review_id":182112347,"id":239352108,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTM1MjEwOA==","diff_hunk":"@@ -263,18 +263,32 @@ export class InteractiveCLI {\n \n             // tslint:disable-next-line no-any\n             let spinner: any | undefined;\n+            // tslint:disable-next-line no-any\n+            let verSpinner: any | undefined;\n+\n             try {\n-              const { pid } = await manager.start({\n+              const { pid, newerVersion } = await manager.start({\n                 port,\n                 httpPort,\n                 binary: createBinary(argv, this.serverConfig),\n                 onStart: () => {\n                   if (first) {\n+                    verSpinner = ora(`Checking for @neo-one/server updates...`).start();\n                     spinner = ora(`Starting ${name.title} server...`).start();\n                   }\n                 },\n               });\n \n+              if (verSpinner !== undefined) {\n+                if (newerVersion === undefined) {\n+                  verSpinner.succeed(`@neo-one/server is current`);\n+                } else {\n+                  verSpinner.warn(\n+                    `A newer version (${newerVersion}) of @neo-one/server is available for download see https://neo-one.io/docs/playground#Updating or we can update the https://github.com/neo-one-suite/neo-one-playground to be self descriptive with installation and update commands as well as a link to the setup docs?`,","path":"packages/neo-one-cli/src/InteractiveCLI.ts","position":26,"original_position":26,"commit_id":"139445b41d98d4625c7dc097100843bc19a6a9f0","original_commit_id":"139445b41d98d4625c7dc097100843bc19a6a9f0","user":{"login":"dicarlo2","id":1311014,"node_id":"MDQ6VXNlcjEzMTEwMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1311014?v=4","gravatar_id":"","url":"https://api.github.com/users/dicarlo2","html_url":"https://github.com/dicarlo2","followers_url":"https://api.github.com/users/dicarlo2/followers","following_url":"https://api.github.com/users/dicarlo2/following{/other_user}","gists_url":"https://api.github.com/users/dicarlo2/gists{/gist_id}","starred_url":"https://api.github.com/users/dicarlo2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dicarlo2/subscriptions","organizations_url":"https://api.github.com/users/dicarlo2/orgs","repos_url":"https://api.github.com/users/dicarlo2/repos","events_url":"https://api.github.com/users/dicarlo2/events{/privacy}","received_events_url":"https://api.github.com/users/dicarlo2/received_events","type":"User","site_admin":false},"body":"This isn't for updating the playground, this is for updating the `neo-one` binary. This should be a section in https://neo-one.io/docs/environment-setup","created_at":"2018-12-06T07:41:19Z","updated_at":"2018-12-06T07:41:22Z","html_url":"https://github.com/neo-one-suite/neo-one/pull/766#discussion_r239352108","pull_request_url":"https://api.github.com/repos/neo-one-suite/neo-one/pulls/766","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/neo-one-suite/neo-one/pulls/comments/239352108"},"html":{"href":"https://github.com/neo-one-suite/neo-one/pull/766#discussion_r239352108"},"pull_request":{"href":"https://api.github.com/repos/neo-one-suite/neo-one/pulls/766"}}},"pull_request":{"url":"https://api.github.com/repos/neo-one-suite/neo-one/pulls/766","id":233696349,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNjk2MzQ5","html_url":"https://github.com/neo-one-suite/neo-one/pull/766","diff_url":"https://github.com/neo-one-suite/neo-one/pull/766.diff","patch_url":"https://github.com/neo-one-suite/neo-one/pull/766.patch","issue_url":"https://api.github.com/repos/neo-one-suite/neo-one/issues/766","number":766,"state":"open","locked":false,"title":"feat(toolchain): show error on mismatched server version","user":{"login":"davemneo","id":39564353,"node_id":"MDQ6VXNlcjM5NTY0MzUz","avatar_url":"https://avatars3.githubusercontent.com/u/39564353?v=4","gravatar_id":"","url":"https://api.github.com/users/davemneo","html_url":"https://github.com/davemneo","followers_url":"https://api.github.com/users/davemneo/followers","following_url":"https://api.github.com/users/davemneo/following{/other_user}","gists_url":"https://api.github.com/users/davemneo/gists{/gist_id}","starred_url":"https://api.github.com/users/davemneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davemneo/subscriptions","organizations_url":"https://api.github.com/users/davemneo/orgs","repos_url":"https://api.github.com/users/davemneo/repos","events_url":"https://api.github.com/users/davemneo/events{/privacy}","received_events_url":"https://api.github.com/users/davemneo/received_events","type":"User","site_admin":false},"body":"### Requirements\r\n\r\nMake client requests aware of server version, when there's a conflict, take appropriate action, see below.\r\n\r\n### Description of the Change\r\n\r\n These outcomes are expected both when the server is running or not running:\r\n * client/server have same version, newer version online\r\n * client is upgraded, server is not - restart server\r\n * server is upgraded, client is not - throw version conflict error\r\n\r\n### Test Plan\r\nmanual testing of the above listed scenarios.\r\n\r\n### Benefits\r\nServer will restart with correct version, otherwise user will be made aware of version conflicts. \r\n\r\n### Applicable Issues\r\nRE: #716\r\nDepends on #803 ","created_at":"2018-11-26T21:05:51Z","updated_at":"2018-12-06T07:41:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"465f62e8e7fa46d401d7384c0355f487fa558d15","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/neo-one-suite/neo-one/pulls/766/commits","review_comments_url":"https://api.github.com/repos/neo-one-suite/neo-one/pulls/766/comments","review_comment_url":"https://api.github.com/repos/neo-one-suite/neo-one/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo-one-suite/neo-one/issues/766/comments","statuses_url":"https://api.github.com/repos/neo-one-suite/neo-one/statuses/139445b41d98d4625c7dc097100843bc19a6a9f0","head":{"label":"davemneo:716-neo-one-upgrade","ref":"716-neo-one-upgrade","sha":"139445b41d98d4625c7dc097100843bc19a6a9f0","user":{"login":"davemneo","id":39564353,"node_id":"MDQ6VXNlcjM5NTY0MzUz","avatar_url":"https://avatars3.githubusercontent.com/u/39564353?v=4","gravatar_id":"","url":"https://api.github.com/users/davemneo","html_url":"https://github.com/davemneo","followers_url":"https://api.github.com/users/davemneo/followers","following_url":"https://api.github.com/users/davemneo/following{/other_user}","gists_url":"https://api.github.com/users/davemneo/gists{/gist_id}","starred_url":"https://api.github.com/users/davemneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davemneo/subscriptions","organizations_url":"https://api.github.com/users/davemneo/orgs","repos_url":"https://api.github.com/users/davemneo/repos","events_url":"https://api.github.com/users/davemneo/events{/privacy}","received_events_url":"https://api.github.com/users/davemneo/received_events","type":"User","site_admin":false},"repo":{"id":134598750,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ1OTg3NTA=","name":"neo-one","full_name":"davemneo/neo-one","private":false,"owner":{"login":"davemneo","id":39564353,"node_id":"MDQ6VXNlcjM5NTY0MzUz","avatar_url":"https://avatars3.githubusercontent.com/u/39564353?v=4","gravatar_id":"","url":"https://api.github.com/users/davemneo","html_url":"https://github.com/davemneo","followers_url":"https://api.github.com/users/davemneo/followers","following_url":"https://api.github.com/users/davemneo/following{/other_user}","gists_url":"https://api.github.com/users/davemneo/gists{/gist_id}","starred_url":"https://api.github.com/users/davemneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davemneo/subscriptions","organizations_url":"https://api.github.com/users/davemneo/orgs","repos_url":"https://api.github.com/users/davemneo/repos","events_url":"https://api.github.com/users/davemneo/events{/privacy}","received_events_url":"https://api.github.com/users/davemneo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/davemneo/neo-one","description":"The One for easy, fast, & fun NEO app development.","fork":true,"url":"https://api.github.com/repos/davemneo/neo-one","forks_url":"https://api.github.com/repos/davemneo/neo-one/forks","keys_url":"https://api.github.com/repos/davemneo/neo-one/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davemneo/neo-one/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davemneo/neo-one/teams","hooks_url":"https://api.github.com/repos/davemneo/neo-one/hooks","issue_events_url":"https://api.github.com/repos/davemneo/neo-one/issues/events{/number}","events_url":"https://api.github.com/repos/davemneo/neo-one/events","assignees_url":"https://api.github.com/repos/davemneo/neo-one/assignees{/user}","branches_url":"https://api.github.com/repos/davemneo/neo-one/branches{/branch}","tags_url":"https://api.github.com/repos/davemneo/neo-one/tags","blobs_url":"https://api.github.com/repos/davemneo/neo-one/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davemneo/neo-one/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davemneo/neo-one/git/refs{/sha}","trees_url":"https://api.github.com/repos/davemneo/neo-one/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davemneo/neo-one/statuses/{sha}","languages_url":"https://api.github.com/repos/davemneo/neo-one/languages","stargazers_url":"https://api.github.com/repos/davemneo/neo-one/stargazers","contributors_url":"https://api.github.com/repos/davemneo/neo-one/contributors","subscribers_url":"https://api.github.com/repos/davemneo/neo-one/subscribers","subscription_url":"https://api.github.com/repos/davemneo/neo-one/subscription","commits_url":"https://api.github.com/repos/davemneo/neo-one/commits{/sha}","git_commits_url":"https://api.github.com/repos/davemneo/neo-one/git/commits{/sha}","comments_url":"https://api.github.com/repos/davemneo/neo-one/comments{/number}","issue_comment_url":"https://api.github.com/repos/davemneo/neo-one/issues/comments{/number}","contents_url":"https://api.github.com/repos/davemneo/neo-one/contents/{+path}","compare_url":"https://api.github.com/repos/davemneo/neo-one/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davemneo/neo-one/merges","archive_url":"https://api.github.com/repos/davemneo/neo-one/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davemneo/neo-one/downloads","issues_url":"https://api.github.com/repos/davemneo/neo-one/issues{/number}","pulls_url":"https://api.github.com/repos/davemneo/neo-one/pulls{/number}","milestones_url":"https://api.github.com/repos/davemneo/neo-one/milestones{/number}","notifications_url":"https://api.github.com/repos/davemneo/neo-one/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davemneo/neo-one/labels{/name}","releases_url":"https://api.github.com/repos/davemneo/neo-one/releases{/id}","deployments_url":"https://api.github.com/repos/davemneo/neo-one/deployments","created_at":"2018-05-23T16:40:05Z","updated_at":"2018-12-05T21:12:36Z","pushed_at":"2018-12-06T01:35:14Z","git_url":"git://github.com/davemneo/neo-one.git","ssh_url":"git@github.com:davemneo/neo-one.git","clone_url":"https://github.com/davemneo/neo-one.git","svn_url":"https://github.com/davemneo/neo-one","homepage":"https://neo-one.io","size":18988,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neo-one-suite:master","ref":"master","sha":"6821cb9b4627beef23a93355c26614b794321afa","user":{"login":"neo-one-suite","id":34582920,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTgyOTIw","avatar_url":"https://avatars3.githubusercontent.com/u/34582920?v=4","gravatar_id":"","url":"https://api.github.com/users/neo-one-suite","html_url":"https://github.com/neo-one-suite","followers_url":"https://api.github.com/users/neo-one-suite/followers","following_url":"https://api.github.com/users/neo-one-suite/following{/other_user}","gists_url":"https://api.github.com/users/neo-one-suite/gists{/gist_id}","starred_url":"https://api.github.com/users/neo-one-suite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo-one-suite/subscriptions","organizations_url":"https://api.github.com/users/neo-one-suite/orgs","repos_url":"https://api.github.com/users/neo-one-suite/repos","events_url":"https://api.github.com/users/neo-one-suite/events{/privacy}","received_events_url":"https://api.github.com/users/neo-one-suite/received_events","type":"Organization","site_admin":false},"repo":{"id":114402666,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ0MDI2NjY=","name":"neo-one","full_name":"neo-one-suite/neo-one","private":false,"owner":{"login":"neo-one-suite","id":34582920,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTgyOTIw","avatar_url":"https://avatars3.githubusercontent.com/u/34582920?v=4","gravatar_id":"","url":"https://api.github.com/users/neo-one-suite","html_url":"https://github.com/neo-one-suite","followers_url":"https://api.github.com/users/neo-one-suite/followers","following_url":"https://api.github.com/users/neo-one-suite/following{/other_user}","gists_url":"https://api.github.com/users/neo-one-suite/gists{/gist_id}","starred_url":"https://api.github.com/users/neo-one-suite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo-one-suite/subscriptions","organizations_url":"https://api.github.com/users/neo-one-suite/orgs","repos_url":"https://api.github.com/users/neo-one-suite/repos","events_url":"https://api.github.com/users/neo-one-suite/events{/privacy}","received_events_url":"https://api.github.com/users/neo-one-suite/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/neo-one-suite/neo-one","description":"The One for easy, fast, & fun NEO app development.","fork":false,"url":"https://api.github.com/repos/neo-one-suite/neo-one","forks_url":"https://api.github.com/repos/neo-one-suite/neo-one/forks","keys_url":"https://api.github.com/repos/neo-one-suite/neo-one/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo-one-suite/neo-one/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo-one-suite/neo-one/teams","hooks_url":"https://api.github.com/repos/neo-one-suite/neo-one/hooks","issue_events_url":"https://api.github.com/repos/neo-one-suite/neo-one/issues/events{/number}","events_url":"https://api.github.com/repos/neo-one-suite/neo-one/events","assignees_url":"https://api.github.com/repos/neo-one-suite/neo-one/assignees{/user}","branches_url":"https://api.github.com/repos/neo-one-suite/neo-one/branches{/branch}","tags_url":"https://api.github.com/repos/neo-one-suite/neo-one/tags","blobs_url":"https://api.github.com/repos/neo-one-suite/neo-one/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo-one-suite/neo-one/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo-one-suite/neo-one/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo-one-suite/neo-one/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo-one-suite/neo-one/statuses/{sha}","languages_url":"https://api.github.com/repos/neo-one-suite/neo-one/languages","stargazers_url":"https://api.github.com/repos/neo-one-suite/neo-one/stargazers","contributors_url":"https://api.github.com/repos/neo-one-suite/neo-one/contributors","subscribers_url":"https://api.github.com/repos/neo-one-suite/neo-one/subscribers","subscription_url":"https://api.github.com/repos/neo-one-suite/neo-one/subscription","commits_url":"https://api.github.com/repos/neo-one-suite/neo-one/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo-one-suite/neo-one/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo-one-suite/neo-one/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo-one-suite/neo-one/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo-one-suite/neo-one/contents/{+path}","compare_url":"https://api.github.com/repos/neo-one-suite/neo-one/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo-one-suite/neo-one/merges","archive_url":"https://api.github.com/repos/neo-one-suite/neo-one/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo-one-suite/neo-one/downloads","issues_url":"https://api.github.com/repos/neo-one-suite/neo-one/issues{/number}","pulls_url":"https://api.github.com/repos/neo-one-suite/neo-one/pulls{/number}","milestones_url":"https://api.github.com/repos/neo-one-suite/neo-one/milestones{/number}","notifications_url":"https://api.github.com/repos/neo-one-suite/neo-one/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo-one-suite/neo-one/labels{/name}","releases_url":"https://api.github.com/repos/neo-one-suite/neo-one/releases{/id}","deployments_url":"https://api.github.com/repos/neo-one-suite/neo-one/deployments","created_at":"2017-12-15T19:03:12Z","updated_at":"2018-12-06T00:41:17Z","pushed_at":"2018-12-06T07:33:36Z","git_url":"git://github.com/neo-one-suite/neo-one.git","ssh_url":"git@github.com:neo-one-suite/neo-one.git","clone_url":"https://github.com/neo-one-suite/neo-one.git","svn_url":"https://github.com/neo-one-suite/neo-one","homepage":"https://neo-one.io","size":21460,"stargazers_count":65,"watchers_count":65,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":24,"open_issues":68,"watchers":65,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neo-one-suite/neo-one/pulls/766"},"html":{"href":"https://github.com/neo-one-suite/neo-one/pull/766"},"issue":{"href":"https://api.github.com/repos/neo-one-suite/neo-one/issues/766"},"comments":{"href":"https://api.github.com/repos/neo-one-suite/neo-one/issues/766/comments"},"review_comments":{"href":"https://api.github.com/repos/neo-one-suite/neo-one/pulls/766/comments"},"review_comment":{"href":"https://api.github.com/repos/neo-one-suite/neo-one/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo-one-suite/neo-one/pulls/766/commits"},"statuses":{"href":"https://api.github.com/repos/neo-one-suite/neo-one/statuses/139445b41d98d4625c7dc097100843bc19a6a9f0"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"dicarlo2"}}