{"action":"closed","number":904,"pull_request":{"url":"https://api.github.com/repos/assetgraph/assetgraph/pulls/904","id":201784031,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNzg0MDMx","html_url":"https://github.com/assetgraph/assetgraph/pull/904","diff_url":"https://github.com/assetgraph/assetgraph/pull/904.diff","patch_url":"https://github.com/assetgraph/assetgraph/pull/904.patch","issue_url":"https://api.github.com/repos/assetgraph/assetgraph/issues/904","number":904,"state":"closed","locked":false,"title":"Added function to download google fonts","user":{"login":"Munter","id":331790,"node_id":"MDQ6VXNlcjMzMTc5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/331790?v=4","gravatar_id":"","url":"https://api.github.com/users/Munter","html_url":"https://github.com/Munter","followers_url":"https://api.github.com/users/Munter/followers","following_url":"https://api.github.com/users/Munter/following{/other_user}","gists_url":"https://api.github.com/users/Munter/gists{/gist_id}","starred_url":"https://api.github.com/users/Munter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Munter/subscriptions","organizations_url":"https://api.github.com/users/Munter/orgs","repos_url":"https://api.github.com/users/Munter/repos","events_url":"https://api.github.com/users/Munter/events{/privacy}","received_events_url":"https://api.github.com/users/Munter/received_events","type":"User","site_admin":false},"body":"I opted for a setup where I create a google font id for each passed in `fontProps` object, but use the google response CSS to populate the resulting CSS properties. This is to ensure that the response keeps in sync with what google interprets the fontProps as.\r\n\r\nI added unicode-range and font-display setting ability right away, and also a subsetting ability.\r\n\r\nEven though were going to have a few stringifications and parsings of the fonts I think it's worth it to keep the function agnostic. We can make a transform that takes the resulting CSS font-face declaration stylesheets, concats them and extracts the fonts to a given URL later.","created_at":"2018-07-16T23:08:39Z","updated_at":"2018-07-27T21:32:10Z","closed_at":"2018-07-27T21:32:10Z","merged_at":"2018-07-27T21:32:10Z","merge_commit_sha":"166e1239e49d6e9eb9a79af698664e783efcfc56","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/assetgraph/assetgraph/pulls/904/commits","review_comments_url":"https://api.github.com/repos/assetgraph/assetgraph/pulls/904/comments","review_comment_url":"https://api.github.com/repos/assetgraph/assetgraph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/assetgraph/assetgraph/issues/904/comments","statuses_url":"https://api.github.com/repos/assetgraph/assetgraph/statuses/ae0f31b8544e7e78c94aa2eb251b7127c6c122c2","head":{"label":"assetgraph:feature/download-google-fonts","ref":"feature/download-google-fonts","sha":"ae0f31b8544e7e78c94aa2eb251b7127c6c122c2","user":{"login":"assetgraph","id":6302962,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzMDI5NjI=","avatar_url":"https://avatars0.githubusercontent.com/u/6302962?v=4","gravatar_id":"","url":"https://api.github.com/users/assetgraph","html_url":"https://github.com/assetgraph","followers_url":"https://api.github.com/users/assetgraph/followers","following_url":"https://api.github.com/users/assetgraph/following{/other_user}","gists_url":"https://api.github.com/users/assetgraph/gists{/gist_id}","starred_url":"https://api.github.com/users/assetgraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assetgraph/subscriptions","organizations_url":"https://api.github.com/users/assetgraph/orgs","repos_url":"https://api.github.com/users/assetgraph/repos","events_url":"https://api.github.com/users/assetgraph/events{/privacy}","received_events_url":"https://api.github.com/users/assetgraph/received_events","type":"Organization","site_admin":false},"repo":{"id":1324028,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI0MDI4","name":"assetgraph","full_name":"assetgraph/assetgraph","owner":{"login":"assetgraph","id":6302962,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzMDI5NjI=","avatar_url":"https://avatars0.githubusercontent.com/u/6302962?v=4","gravatar_id":"","url":"https://api.github.com/users/assetgraph","html_url":"https://github.com/assetgraph","followers_url":"https://api.github.com/users/assetgraph/followers","following_url":"https://api.github.com/users/assetgraph/following{/other_user}","gists_url":"https://api.github.com/users/assetgraph/gists{/gist_id}","starred_url":"https://api.github.com/users/assetgraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assetgraph/subscriptions","organizations_url":"https://api.github.com/users/assetgraph/orgs","repos_url":"https://api.github.com/users/assetgraph/repos","events_url":"https://api.github.com/users/assetgraph/events{/privacy}","received_events_url":"https://api.github.com/users/assetgraph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/assetgraph/assetgraph","description":"Optimization framework for web pages and applications","fork":false,"url":"https://api.github.com/repos/assetgraph/assetgraph","forks_url":"https://api.github.com/repos/assetgraph/assetgraph/forks","keys_url":"https://api.github.com/repos/assetgraph/assetgraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/assetgraph/assetgraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/assetgraph/assetgraph/teams","hooks_url":"https://api.github.com/repos/assetgraph/assetgraph/hooks","issue_events_url":"https://api.github.com/repos/assetgraph/assetgraph/issues/events{/number}","events_url":"https://api.github.com/repos/assetgraph/assetgraph/events","assignees_url":"https://api.github.com/repos/assetgraph/assetgraph/assignees{/user}","branches_url":"https://api.github.com/repos/assetgraph/assetgraph/branches{/branch}","tags_url":"https://api.github.com/repos/assetgraph/assetgraph/tags","blobs_url":"https://api.github.com/repos/assetgraph/assetgraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/assetgraph/assetgraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/assetgraph/assetgraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/assetgraph/assetgraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/assetgraph/assetgraph/statuses/{sha}","languages_url":"https://api.github.com/repos/assetgraph/assetgraph/languages","stargazers_url":"https://api.github.com/repos/assetgraph/assetgraph/stargazers","contributors_url":"https://api.github.com/repos/assetgraph/assetgraph/contributors","subscribers_url":"https://api.github.com/repos/assetgraph/assetgraph/subscribers","subscription_url":"https://api.github.com/repos/assetgraph/assetgraph/subscription","commits_url":"https://api.github.com/repos/assetgraph/assetgraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/assetgraph/assetgraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/assetgraph/assetgraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/assetgraph/assetgraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/assetgraph/assetgraph/contents/{+path}","compare_url":"https://api.github.com/repos/assetgraph/assetgraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/assetgraph/assetgraph/merges","archive_url":"https://api.github.com/repos/assetgraph/assetgraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/assetgraph/assetgraph/downloads","issues_url":"https://api.github.com/repos/assetgraph/assetgraph/issues{/number}","pulls_url":"https://api.github.com/repos/assetgraph/assetgraph/pulls{/number}","milestones_url":"https://api.github.com/repos/assetgraph/assetgraph/milestones{/number}","notifications_url":"https://api.github.com/repos/assetgraph/assetgraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/assetgraph/assetgraph/labels{/name}","releases_url":"https://api.github.com/repos/assetgraph/assetgraph/releases{/id}","deployments_url":"https://api.github.com/repos/assetgraph/assetgraph/deployments","created_at":"2011-02-03T13:05:29Z","updated_at":"2018-07-27T21:10:53Z","pushed_at":"2018-07-27T21:32:10Z","git_url":"git://github.com/assetgraph/assetgraph.git","ssh_url":"git@github.com:assetgraph/assetgraph.git","clone_url":"https://github.com/assetgraph/assetgraph.git","svn_url":"https://github.com/assetgraph/assetgraph","homepage":"","size":15585,"stargazers_count":830,"watchers_count":830,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":43,"open_issues":45,"watchers":830,"default_branch":"master"}},"base":{"label":"assetgraph:master","ref":"master","sha":"650286bc3af9657c8072bca3a00f653b072ba212","user":{"login":"assetgraph","id":6302962,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzMDI5NjI=","avatar_url":"https://avatars0.githubusercontent.com/u/6302962?v=4","gravatar_id":"","url":"https://api.github.com/users/assetgraph","html_url":"https://github.com/assetgraph","followers_url":"https://api.github.com/users/assetgraph/followers","following_url":"https://api.github.com/users/assetgraph/following{/other_user}","gists_url":"https://api.github.com/users/assetgraph/gists{/gist_id}","starred_url":"https://api.github.com/users/assetgraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assetgraph/subscriptions","organizations_url":"https://api.github.com/users/assetgraph/orgs","repos_url":"https://api.github.com/users/assetgraph/repos","events_url":"https://api.github.com/users/assetgraph/events{/privacy}","received_events_url":"https://api.github.com/users/assetgraph/received_events","type":"Organization","site_admin":false},"repo":{"id":1324028,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI0MDI4","name":"assetgraph","full_name":"assetgraph/assetgraph","owner":{"login":"assetgraph","id":6302962,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzMDI5NjI=","avatar_url":"https://avatars0.githubusercontent.com/u/6302962?v=4","gravatar_id":"","url":"https://api.github.com/users/assetgraph","html_url":"https://github.com/assetgraph","followers_url":"https://api.github.com/users/assetgraph/followers","following_url":"https://api.github.com/users/assetgraph/following{/other_user}","gists_url":"https://api.github.com/users/assetgraph/gists{/gist_id}","starred_url":"https://api.github.com/users/assetgraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assetgraph/subscriptions","organizations_url":"https://api.github.com/users/assetgraph/orgs","repos_url":"https://api.github.com/users/assetgraph/repos","events_url":"https://api.github.com/users/assetgraph/events{/privacy}","received_events_url":"https://api.github.com/users/assetgraph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/assetgraph/assetgraph","description":"Optimization framework for web pages and applications","fork":false,"url":"https://api.github.com/repos/assetgraph/assetgraph","forks_url":"https://api.github.com/repos/assetgraph/assetgraph/forks","keys_url":"https://api.github.com/repos/assetgraph/assetgraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/assetgraph/assetgraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/assetgraph/assetgraph/teams","hooks_url":"https://api.github.com/repos/assetgraph/assetgraph/hooks","issue_events_url":"https://api.github.com/repos/assetgraph/assetgraph/issues/events{/number}","events_url":"https://api.github.com/repos/assetgraph/assetgraph/events","assignees_url":"https://api.github.com/repos/assetgraph/assetgraph/assignees{/user}","branches_url":"https://api.github.com/repos/assetgraph/assetgraph/branches{/branch}","tags_url":"https://api.github.com/repos/assetgraph/assetgraph/tags","blobs_url":"https://api.github.com/repos/assetgraph/assetgraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/assetgraph/assetgraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/assetgraph/assetgraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/assetgraph/assetgraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/assetgraph/assetgraph/statuses/{sha}","languages_url":"https://api.github.com/repos/assetgraph/assetgraph/languages","stargazers_url":"https://api.github.com/repos/assetgraph/assetgraph/stargazers","contributors_url":"https://api.github.com/repos/assetgraph/assetgraph/contributors","subscribers_url":"https://api.github.com/repos/assetgraph/assetgraph/subscribers","subscription_url":"https://api.github.com/repos/assetgraph/assetgraph/subscription","commits_url":"https://api.github.com/repos/assetgraph/assetgraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/assetgraph/assetgraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/assetgraph/assetgraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/assetgraph/assetgraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/assetgraph/assetgraph/contents/{+path}","compare_url":"https://api.github.com/repos/assetgraph/assetgraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/assetgraph/assetgraph/merges","archive_url":"https://api.github.com/repos/assetgraph/assetgraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/assetgraph/assetgraph/downloads","issues_url":"https://api.github.com/repos/assetgraph/assetgraph/issues{/number}","pulls_url":"https://api.github.com/repos/assetgraph/assetgraph/pulls{/number}","milestones_url":"https://api.github.com/repos/assetgraph/assetgraph/milestones{/number}","notifications_url":"https://api.github.com/repos/assetgraph/assetgraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/assetgraph/assetgraph/labels{/name}","releases_url":"https://api.github.com/repos/assetgraph/assetgraph/releases{/id}","deployments_url":"https://api.github.com/repos/assetgraph/assetgraph/deployments","created_at":"2011-02-03T13:05:29Z","updated_at":"2018-07-27T21:10:53Z","pushed_at":"2018-07-27T21:32:10Z","git_url":"git://github.com/assetgraph/assetgraph.git","ssh_url":"git@github.com:assetgraph/assetgraph.git","clone_url":"https://github.com/assetgraph/assetgraph.git","svn_url":"https://github.com/assetgraph/assetgraph","homepage":"","size":15585,"stargazers_count":830,"watchers_count":830,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":43,"open_issues":45,"watchers":830,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/assetgraph/assetgraph/pulls/904"},"html":{"href":"https://github.com/assetgraph/assetgraph/pull/904"},"issue":{"href":"https://api.github.com/repos/assetgraph/assetgraph/issues/904"},"comments":{"href":"https://api.github.com/repos/assetgraph/assetgraph/issues/904/comments"},"review_comments":{"href":"https://api.github.com/repos/assetgraph/assetgraph/pulls/904/comments"},"review_comment":{"href":"https://api.github.com/repos/assetgraph/assetgraph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/assetgraph/assetgraph/pulls/904/commits"},"statuses":{"href":"https://api.github.com/repos/assetgraph/assetgraph/statuses/ae0f31b8544e7e78c94aa2eb251b7127c6c122c2"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Munter","id":331790,"node_id":"MDQ6VXNlcjMzMTc5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/331790?v=4","gravatar_id":"","url":"https://api.github.com/users/Munter","html_url":"https://github.com/Munter","followers_url":"https://api.github.com/users/Munter/followers","following_url":"https://api.github.com/users/Munter/following{/other_user}","gists_url":"https://api.github.com/users/Munter/gists{/gist_id}","starred_url":"https://api.github.com/users/Munter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Munter/subscriptions","organizations_url":"https://api.github.com/users/Munter/orgs","repos_url":"https://api.github.com/users/Munter/repos","events_url":"https://api.github.com/users/Munter/events{/privacy}","received_events_url":"https://api.github.com/users/Munter/received_events","type":"User","site_admin":false},"comments":3,"review_comments":1,"maintainer_can_modify":false,"commits":6,"additions":188,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"Munter"}}