{"action":"opened","number":170,"pull_request":{"url":"https://api.github.com/repos/HadoukenIO/layouts-service/pulls/170","id":222938639,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyOTM4NjM5","html_url":"https://github.com/HadoukenIO/layouts-service/pull/170","diff_url":"https://github.com/HadoukenIO/layouts-service/pull/170.diff","patch_url":"https://github.com/HadoukenIO/layouts-service/pull/170.patch","issue_url":"https://api.github.com/repos/HadoukenIO/layouts-service/issues/170","number":170,"state":"open","locked":false,"title":"[SERVICE-256] Testing Improvements","user":{"login":"tomrobertsOF","id":38854624,"node_id":"MDQ6VXNlcjM4ODU0NjI0","avatar_url":"https://avatars1.githubusercontent.com/u/38854624?v=4","gravatar_id":"","url":"https://api.github.com/users/tomrobertsOF","html_url":"https://github.com/tomrobertsOF","followers_url":"https://api.github.com/users/tomrobertsOF/followers","following_url":"https://api.github.com/users/tomrobertsOF/following{/other_user}","gists_url":"https://api.github.com/users/tomrobertsOF/gists{/gist_id}","starred_url":"https://api.github.com/users/tomrobertsOF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomrobertsOF/subscriptions","organizations_url":"https://api.github.com/users/tomrobertsOF/orgs","repos_url":"https://api.github.com/users/tomrobertsOF/repos","events_url":"https://api.github.com/users/tomrobertsOF/events{/privacy}","received_events_url":"https://api.github.com/users/tomrobertsOF/received_events","type":"User","site_admin":false},"body":"Lots of general improvements to the test suite and accompanying utils.\r\n\r\n- Changed remote execution code to use IAB channels.\r\n  - Allows easy passing of errors or return values back through the bus.\r\n  - Required setting a fixed channel name for the service as a window cannot have named/unnamed channels at the same time\r\n- Changes to allow more rigorous type-checking when writing remotely executed code in a test file\r\n  - Tests directory now includes a global declaration file which extends the window object with the window-mounted service components.\r\n  - Effectively allows writing code as if it is in the provider window context inside the test itself. (Examples of how to do this are in `snapServiceUtils.ts`)\r\n- Updated and added several new remote execution utils (e.g. `getTabGroupID()`, `getSnapGroup()`...)\r\n- Updated and added new assertions using the new remote execution utils (e.g. `assertTabbed`, `assertRegistered`)\r\n  - Several existing tests were updated to use these new checks.\r\n- Significant restructuring of the basicSnap tests (and related). \r\n  - Heavily parameterized the tests, removing large amounts of duplicated code\r\n  - Added utils to allow more easy parameterization of new tests. Includes extendable types to make tests fully type safe where possible.\r\n- Moved some service-level constants into config.ts to allow importing into both the service and test files\r\n-  Other minor fixes and improvements","created_at":"2018-10-15T15:01:08Z","updated_at":"2018-10-15T15:01:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HadoukenIO/layouts-service/pulls/170/commits","review_comments_url":"https://api.github.com/repos/HadoukenIO/layouts-service/pulls/170/comments","review_comment_url":"https://api.github.com/repos/HadoukenIO/layouts-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HadoukenIO/layouts-service/issues/170/comments","statuses_url":"https://api.github.com/repos/HadoukenIO/layouts-service/statuses/2abdd320c49a3838252c7b8c4a7f19f94d739f2b","head":{"label":"tomrobertsOF:dev/tom/SERVICE-256","ref":"dev/tom/SERVICE-256","sha":"2abdd320c49a3838252c7b8c4a7f19f94d739f2b","user":{"login":"tomrobertsOF","id":38854624,"node_id":"MDQ6VXNlcjM4ODU0NjI0","avatar_url":"https://avatars1.githubusercontent.com/u/38854624?v=4","gravatar_id":"","url":"https://api.github.com/users/tomrobertsOF","html_url":"https://github.com/tomrobertsOF","followers_url":"https://api.github.com/users/tomrobertsOF/followers","following_url":"https://api.github.com/users/tomrobertsOF/following{/other_user}","gists_url":"https://api.github.com/users/tomrobertsOF/gists{/gist_id}","starred_url":"https://api.github.com/users/tomrobertsOF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomrobertsOF/subscriptions","organizations_url":"https://api.github.com/users/tomrobertsOF/orgs","repos_url":"https://api.github.com/users/tomrobertsOF/repos","events_url":"https://api.github.com/users/tomrobertsOF/events{/privacy}","received_events_url":"https://api.github.com/users/tomrobertsOF/received_events","type":"User","site_admin":false},"repo":{"id":142028508,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIwMjg1MDg=","name":"layouts-service","full_name":"tomrobertsOF/layouts-service","private":false,"owner":{"login":"tomrobertsOF","id":38854624,"node_id":"MDQ6VXNlcjM4ODU0NjI0","avatar_url":"https://avatars1.githubusercontent.com/u/38854624?v=4","gravatar_id":"","url":"https://api.github.com/users/tomrobertsOF","html_url":"https://github.com/tomrobertsOF","followers_url":"https://api.github.com/users/tomrobertsOF/followers","following_url":"https://api.github.com/users/tomrobertsOF/following{/other_user}","gists_url":"https://api.github.com/users/tomrobertsOF/gists{/gist_id}","starred_url":"https://api.github.com/users/tomrobertsOF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomrobertsOF/subscriptions","organizations_url":"https://api.github.com/users/tomrobertsOF/orgs","repos_url":"https://api.github.com/users/tomrobertsOF/repos","events_url":"https://api.github.com/users/tomrobertsOF/events{/privacy}","received_events_url":"https://api.github.com/users/tomrobertsOF/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tomrobertsOF/layouts-service","description":"OpenFin Layouts Service","fork":true,"url":"https://api.github.com/repos/tomrobertsOF/layouts-service","forks_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/forks","keys_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/teams","hooks_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/hooks","issue_events_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/issues/events{/number}","events_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/events","assignees_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/assignees{/user}","branches_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/branches{/branch}","tags_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/tags","blobs_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/statuses/{sha}","languages_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/languages","stargazers_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/stargazers","contributors_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/contributors","subscribers_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/subscribers","subscription_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/subscription","commits_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/contents/{+path}","compare_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/merges","archive_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/downloads","issues_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/issues{/number}","pulls_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/pulls{/number}","milestones_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/milestones{/number}","notifications_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/labels{/name}","releases_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/releases{/id}","deployments_url":"https://api.github.com/repos/tomrobertsOF/layouts-service/deployments","created_at":"2018-07-23T14:49:33Z","updated_at":"2018-10-15T14:15:58Z","pushed_at":"2018-10-15T14:26:14Z","git_url":"git://github.com/tomrobertsOF/layouts-service.git","ssh_url":"git@github.com:tomrobertsOF/layouts-service.git","clone_url":"https://github.com/tomrobertsOF/layouts-service.git","svn_url":"https://github.com/tomrobertsOF/layouts-service","homepage":null,"size":1696,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"HadoukenIO:develop","ref":"develop","sha":"57088503218f4b2bbc5af6938336cde54b2c5600","user":{"login":"HadoukenIO","id":28318664,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzE4NjY0","avatar_url":"https://avatars0.githubusercontent.com/u/28318664?v=4","gravatar_id":"","url":"https://api.github.com/users/HadoukenIO","html_url":"https://github.com/HadoukenIO","followers_url":"https://api.github.com/users/HadoukenIO/followers","following_url":"https://api.github.com/users/HadoukenIO/following{/other_user}","gists_url":"https://api.github.com/users/HadoukenIO/gists{/gist_id}","starred_url":"https://api.github.com/users/HadoukenIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HadoukenIO/subscriptions","organizations_url":"https://api.github.com/users/HadoukenIO/orgs","repos_url":"https://api.github.com/users/HadoukenIO/repos","events_url":"https://api.github.com/users/HadoukenIO/events{/privacy}","received_events_url":"https://api.github.com/users/HadoukenIO/received_events","type":"Organization","site_admin":false},"repo":{"id":131767963,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE3Njc5NjM=","name":"layouts-service","full_name":"HadoukenIO/layouts-service","private":false,"owner":{"login":"HadoukenIO","id":28318664,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzE4NjY0","avatar_url":"https://avatars0.githubusercontent.com/u/28318664?v=4","gravatar_id":"","url":"https://api.github.com/users/HadoukenIO","html_url":"https://github.com/HadoukenIO","followers_url":"https://api.github.com/users/HadoukenIO/followers","following_url":"https://api.github.com/users/HadoukenIO/following{/other_user}","gists_url":"https://api.github.com/users/HadoukenIO/gists{/gist_id}","starred_url":"https://api.github.com/users/HadoukenIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HadoukenIO/subscriptions","organizations_url":"https://api.github.com/users/HadoukenIO/orgs","repos_url":"https://api.github.com/users/HadoukenIO/repos","events_url":"https://api.github.com/users/HadoukenIO/events{/privacy}","received_events_url":"https://api.github.com/users/HadoukenIO/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/HadoukenIO/layouts-service","description":"OpenFin Layouts Service","fork":false,"url":"https://api.github.com/repos/HadoukenIO/layouts-service","forks_url":"https://api.github.com/repos/HadoukenIO/layouts-service/forks","keys_url":"https://api.github.com/repos/HadoukenIO/layouts-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HadoukenIO/layouts-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HadoukenIO/layouts-service/teams","hooks_url":"https://api.github.com/repos/HadoukenIO/layouts-service/hooks","issue_events_url":"https://api.github.com/repos/HadoukenIO/layouts-service/issues/events{/number}","events_url":"https://api.github.com/repos/HadoukenIO/layouts-service/events","assignees_url":"https://api.github.com/repos/HadoukenIO/layouts-service/assignees{/user}","branches_url":"https://api.github.com/repos/HadoukenIO/layouts-service/branches{/branch}","tags_url":"https://api.github.com/repos/HadoukenIO/layouts-service/tags","blobs_url":"https://api.github.com/repos/HadoukenIO/layouts-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HadoukenIO/layouts-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HadoukenIO/layouts-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/HadoukenIO/layouts-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HadoukenIO/layouts-service/statuses/{sha}","languages_url":"https://api.github.com/repos/HadoukenIO/layouts-service/languages","stargazers_url":"https://api.github.com/repos/HadoukenIO/layouts-service/stargazers","contributors_url":"https://api.github.com/repos/HadoukenIO/layouts-service/contributors","subscribers_url":"https://api.github.com/repos/HadoukenIO/layouts-service/subscribers","subscription_url":"https://api.github.com/repos/HadoukenIO/layouts-service/subscription","commits_url":"https://api.github.com/repos/HadoukenIO/layouts-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/HadoukenIO/layouts-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/HadoukenIO/layouts-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/HadoukenIO/layouts-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/HadoukenIO/layouts-service/contents/{+path}","compare_url":"https://api.github.com/repos/HadoukenIO/layouts-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HadoukenIO/layouts-service/merges","archive_url":"https://api.github.com/repos/HadoukenIO/layouts-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HadoukenIO/layouts-service/downloads","issues_url":"https://api.github.com/repos/HadoukenIO/layouts-service/issues{/number}","pulls_url":"https://api.github.com/repos/HadoukenIO/layouts-service/pulls{/number}","milestones_url":"https://api.github.com/repos/HadoukenIO/layouts-service/milestones{/number}","notifications_url":"https://api.github.com/repos/HadoukenIO/layouts-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HadoukenIO/layouts-service/labels{/name}","releases_url":"https://api.github.com/repos/HadoukenIO/layouts-service/releases{/id}","deployments_url":"https://api.github.com/repos/HadoukenIO/layouts-service/deployments","created_at":"2018-05-01T22:05:31Z","updated_at":"2018-10-15T14:04:29Z","pushed_at":"2018-10-15T14:45:24Z","git_url":"git://github.com/HadoukenIO/layouts-service.git","ssh_url":"git@github.com:HadoukenIO/layouts-service.git","clone_url":"https://github.com/HadoukenIO/layouts-service.git","svn_url":"https://github.com/HadoukenIO/layouts-service","homepage":null,"size":1501,"stargazers_count":8,"watchers_count":8,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":13,"open_issues":4,"watchers":8,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/HadoukenIO/layouts-service/pulls/170"},"html":{"href":"https://github.com/HadoukenIO/layouts-service/pull/170"},"issue":{"href":"https://api.github.com/repos/HadoukenIO/layouts-service/issues/170"},"comments":{"href":"https://api.github.com/repos/HadoukenIO/layouts-service/issues/170/comments"},"review_comments":{"href":"https://api.github.com/repos/HadoukenIO/layouts-service/pulls/170/comments"},"review_comment":{"href":"https://api.github.com/repos/HadoukenIO/layouts-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HadoukenIO/layouts-service/pulls/170/commits"},"statuses":{"href":"https://api.github.com/repos/HadoukenIO/layouts-service/statuses/2abdd320c49a3838252c7b8c4a7f19f94d739f2b"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":24,"additions":3393,"deletions":3825,"changed_files":36}}
{"actor":{"display_login":"tomrobertsOF"}}