{"action":"closed","number":3814,"pull_request":{"url":"https://api.github.com/repos/musescore/MuseScore/pulls/3814","id":201457529,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDU3NTI5","html_url":"https://github.com/musescore/MuseScore/pull/3814","diff_url":"https://github.com/musescore/MuseScore/pull/3814.diff","patch_url":"https://github.com/musescore/MuseScore/pull/3814.patch","issue_url":"https://api.github.com/repos/musescore/MuseScore/issues/3814","number":3814,"state":"closed","locked":false,"title":"fix #274280: Undoing timewise delete does not restore slur position","user":{"login":"mattmcclinch","id":35512972,"node_id":"MDQ6VXNlcjM1NTEyOTcy","avatar_url":"https://avatars3.githubusercontent.com/u/35512972?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmcclinch","html_url":"https://github.com/mattmcclinch","followers_url":"https://api.github.com/users/mattmcclinch/followers","following_url":"https://api.github.com/users/mattmcclinch/following{/other_user}","gists_url":"https://api.github.com/users/mattmcclinch/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmcclinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmcclinch/subscriptions","organizations_url":"https://api.github.com/users/mattmcclinch/orgs","repos_url":"https://api.github.com/users/mattmcclinch/repos","events_url":"https://api.github.com/users/mattmcclinch/events{/privacy}","received_events_url":"https://api.github.com/users/mattmcclinch/received_events","type":"User","site_admin":false},"body":"See https://musescore.org/en/node/274280.\r\n\r\nThis fixes the issue by setting the spanner's startElement and endElement in an undoable manner when the startElement or endElement is removed.\r\n\r\nI took this opportunity to make a few corrections involving \r\n- tick rounding errors\r\n- incorrect use of tick() versus rtick()\r\n- an unhandled case for area of deletion compared to spanner position and length\r\n\r\nIt was necessary to change the order of cases B and C in Score::undoInsertTime() when I changed < and > to <= and >=. This makes it a little harder to see what I actually changed when viewing the diff.","created_at":"2018-07-14T15:59:06Z","updated_at":"2018-07-16T14:00:56Z","closed_at":"2018-07-16T14:00:56Z","merged_at":"2018-07-16T14:00:56Z","merge_commit_sha":"a13cfc05fa2dedae43dbb43fbf4dc428fa2cbe8c","assignee":{"login":"mattmcclinch","id":35512972,"node_id":"MDQ6VXNlcjM1NTEyOTcy","avatar_url":"https://avatars3.githubusercontent.com/u/35512972?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmcclinch","html_url":"https://github.com/mattmcclinch","followers_url":"https://api.github.com/users/mattmcclinch/followers","following_url":"https://api.github.com/users/mattmcclinch/following{/other_user}","gists_url":"https://api.github.com/users/mattmcclinch/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmcclinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmcclinch/subscriptions","organizations_url":"https://api.github.com/users/mattmcclinch/orgs","repos_url":"https://api.github.com/users/mattmcclinch/repos","events_url":"https://api.github.com/users/mattmcclinch/events{/privacy}","received_events_url":"https://api.github.com/users/mattmcclinch/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattmcclinch","id":35512972,"node_id":"MDQ6VXNlcjM1NTEyOTcy","avatar_url":"https://avatars3.githubusercontent.com/u/35512972?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmcclinch","html_url":"https://github.com/mattmcclinch","followers_url":"https://api.github.com/users/mattmcclinch/followers","following_url":"https://api.github.com/users/mattmcclinch/following{/other_user}","gists_url":"https://api.github.com/users/mattmcclinch/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmcclinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmcclinch/subscriptions","organizations_url":"https://api.github.com/users/mattmcclinch/orgs","repos_url":"https://api.github.com/users/mattmcclinch/repos","events_url":"https://api.github.com/users/mattmcclinch/events{/privacy}","received_events_url":"https://api.github.com/users/mattmcclinch/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/musescore/MuseScore/pulls/3814/commits","review_comments_url":"https://api.github.com/repos/musescore/MuseScore/pulls/3814/comments","review_comment_url":"https://api.github.com/repos/musescore/MuseScore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/musescore/MuseScore/issues/3814/comments","statuses_url":"https://api.github.com/repos/musescore/MuseScore/statuses/5cb1b06839e89014648a4a4eb80c7ad466e75e1b","head":{"label":"mattmcclinch:274280-time-delete","ref":"274280-time-delete","sha":"5cb1b06839e89014648a4a4eb80c7ad466e75e1b","user":{"login":"mattmcclinch","id":35512972,"node_id":"MDQ6VXNlcjM1NTEyOTcy","avatar_url":"https://avatars3.githubusercontent.com/u/35512972?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmcclinch","html_url":"https://github.com/mattmcclinch","followers_url":"https://api.github.com/users/mattmcclinch/followers","following_url":"https://api.github.com/users/mattmcclinch/following{/other_user}","gists_url":"https://api.github.com/users/mattmcclinch/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmcclinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmcclinch/subscriptions","organizations_url":"https://api.github.com/users/mattmcclinch/orgs","repos_url":"https://api.github.com/users/mattmcclinch/repos","events_url":"https://api.github.com/users/mattmcclinch/events{/privacy}","received_events_url":"https://api.github.com/users/mattmcclinch/received_events","type":"User","site_admin":false},"repo":{"id":117769409,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc3Njk0MDk=","name":"MuseScore","full_name":"mattmcclinch/MuseScore","owner":{"login":"mattmcclinch","id":35512972,"node_id":"MDQ6VXNlcjM1NTEyOTcy","avatar_url":"https://avatars3.githubusercontent.com/u/35512972?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmcclinch","html_url":"https://github.com/mattmcclinch","followers_url":"https://api.github.com/users/mattmcclinch/followers","following_url":"https://api.github.com/users/mattmcclinch/following{/other_user}","gists_url":"https://api.github.com/users/mattmcclinch/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmcclinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmcclinch/subscriptions","organizations_url":"https://api.github.com/users/mattmcclinch/orgs","repos_url":"https://api.github.com/users/mattmcclinch/repos","events_url":"https://api.github.com/users/mattmcclinch/events{/privacy}","received_events_url":"https://api.github.com/users/mattmcclinch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattmcclinch/MuseScore","description":"MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!","fork":true,"url":"https://api.github.com/repos/mattmcclinch/MuseScore","forks_url":"https://api.github.com/repos/mattmcclinch/MuseScore/forks","keys_url":"https://api.github.com/repos/mattmcclinch/MuseScore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattmcclinch/MuseScore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattmcclinch/MuseScore/teams","hooks_url":"https://api.github.com/repos/mattmcclinch/MuseScore/hooks","issue_events_url":"https://api.github.com/repos/mattmcclinch/MuseScore/issues/events{/number}","events_url":"https://api.github.com/repos/mattmcclinch/MuseScore/events","assignees_url":"https://api.github.com/repos/mattmcclinch/MuseScore/assignees{/user}","branches_url":"https://api.github.com/repos/mattmcclinch/MuseScore/branches{/branch}","tags_url":"https://api.github.com/repos/mattmcclinch/MuseScore/tags","blobs_url":"https://api.github.com/repos/mattmcclinch/MuseScore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattmcclinch/MuseScore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattmcclinch/MuseScore/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattmcclinch/MuseScore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattmcclinch/MuseScore/statuses/{sha}","languages_url":"https://api.github.com/repos/mattmcclinch/MuseScore/languages","stargazers_url":"https://api.github.com/repos/mattmcclinch/MuseScore/stargazers","contributors_url":"https://api.github.com/repos/mattmcclinch/MuseScore/contributors","subscribers_url":"https://api.github.com/repos/mattmcclinch/MuseScore/subscribers","subscription_url":"https://api.github.com/repos/mattmcclinch/MuseScore/subscription","commits_url":"https://api.github.com/repos/mattmcclinch/MuseScore/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattmcclinch/MuseScore/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattmcclinch/MuseScore/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattmcclinch/MuseScore/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattmcclinch/MuseScore/contents/{+path}","compare_url":"https://api.github.com/repos/mattmcclinch/MuseScore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattmcclinch/MuseScore/merges","archive_url":"https://api.github.com/repos/mattmcclinch/MuseScore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattmcclinch/MuseScore/downloads","issues_url":"https://api.github.com/repos/mattmcclinch/MuseScore/issues{/number}","pulls_url":"https://api.github.com/repos/mattmcclinch/MuseScore/pulls{/number}","milestones_url":"https://api.github.com/repos/mattmcclinch/MuseScore/milestones{/number}","notifications_url":"https://api.github.com/repos/mattmcclinch/MuseScore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattmcclinch/MuseScore/labels{/name}","releases_url":"https://api.github.com/repos/mattmcclinch/MuseScore/releases{/id}","deployments_url":"https://api.github.com/repos/mattmcclinch/MuseScore/deployments","created_at":"2018-01-17T02:04:43Z","updated_at":"2018-07-14T13:01:31Z","pushed_at":"2018-07-16T12:49:22Z","git_url":"git://github.com/mattmcclinch/MuseScore.git","ssh_url":"git@github.com:mattmcclinch/MuseScore.git","clone_url":"https://github.com/mattmcclinch/MuseScore.git","svn_url":"https://github.com/mattmcclinch/MuseScore","homepage":"https://musescore.org","size":309065,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"musescore:master","ref":"master","sha":"bcf64ccefd85ca703816ec0e1a1e2602118b26d3","user":{"login":"musescore","id":380563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MDU2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/380563?v=4","gravatar_id":"","url":"https://api.github.com/users/musescore","html_url":"https://github.com/musescore","followers_url":"https://api.github.com/users/musescore/followers","following_url":"https://api.github.com/users/musescore/following{/other_user}","gists_url":"https://api.github.com/users/musescore/gists{/gist_id}","starred_url":"https://api.github.com/users/musescore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musescore/subscriptions","organizations_url":"https://api.github.com/users/musescore/orgs","repos_url":"https://api.github.com/users/musescore/repos","events_url":"https://api.github.com/users/musescore/events{/privacy}","received_events_url":"https://api.github.com/users/musescore/received_events","type":"Organization","site_admin":false},"repo":{"id":4454793,"node_id":"MDEwOlJlcG9zaXRvcnk0NDU0Nzkz","name":"MuseScore","full_name":"musescore/MuseScore","owner":{"login":"musescore","id":380563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MDU2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/380563?v=4","gravatar_id":"","url":"https://api.github.com/users/musescore","html_url":"https://github.com/musescore","followers_url":"https://api.github.com/users/musescore/followers","following_url":"https://api.github.com/users/musescore/following{/other_user}","gists_url":"https://api.github.com/users/musescore/gists{/gist_id}","starred_url":"https://api.github.com/users/musescore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musescore/subscriptions","organizations_url":"https://api.github.com/users/musescore/orgs","repos_url":"https://api.github.com/users/musescore/repos","events_url":"https://api.github.com/users/musescore/events{/privacy}","received_events_url":"https://api.github.com/users/musescore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/musescore/MuseScore","description":"MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!","fork":false,"url":"https://api.github.com/repos/musescore/MuseScore","forks_url":"https://api.github.com/repos/musescore/MuseScore/forks","keys_url":"https://api.github.com/repos/musescore/MuseScore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/musescore/MuseScore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/musescore/MuseScore/teams","hooks_url":"https://api.github.com/repos/musescore/MuseScore/hooks","issue_events_url":"https://api.github.com/repos/musescore/MuseScore/issues/events{/number}","events_url":"https://api.github.com/repos/musescore/MuseScore/events","assignees_url":"https://api.github.com/repos/musescore/MuseScore/assignees{/user}","branches_url":"https://api.github.com/repos/musescore/MuseScore/branches{/branch}","tags_url":"https://api.github.com/repos/musescore/MuseScore/tags","blobs_url":"https://api.github.com/repos/musescore/MuseScore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/musescore/MuseScore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/musescore/MuseScore/git/refs{/sha}","trees_url":"https://api.github.com/repos/musescore/MuseScore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/musescore/MuseScore/statuses/{sha}","languages_url":"https://api.github.com/repos/musescore/MuseScore/languages","stargazers_url":"https://api.github.com/repos/musescore/MuseScore/stargazers","contributors_url":"https://api.github.com/repos/musescore/MuseScore/contributors","subscribers_url":"https://api.github.com/repos/musescore/MuseScore/subscribers","subscription_url":"https://api.github.com/repos/musescore/MuseScore/subscription","commits_url":"https://api.github.com/repos/musescore/MuseScore/commits{/sha}","git_commits_url":"https://api.github.com/repos/musescore/MuseScore/git/commits{/sha}","comments_url":"https://api.github.com/repos/musescore/MuseScore/comments{/number}","issue_comment_url":"https://api.github.com/repos/musescore/MuseScore/issues/comments{/number}","contents_url":"https://api.github.com/repos/musescore/MuseScore/contents/{+path}","compare_url":"https://api.github.com/repos/musescore/MuseScore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/musescore/MuseScore/merges","archive_url":"https://api.github.com/repos/musescore/MuseScore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/musescore/MuseScore/downloads","issues_url":"https://api.github.com/repos/musescore/MuseScore/issues{/number}","pulls_url":"https://api.github.com/repos/musescore/MuseScore/pulls{/number}","milestones_url":"https://api.github.com/repos/musescore/MuseScore/milestones{/number}","notifications_url":"https://api.github.com/repos/musescore/MuseScore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/musescore/MuseScore/labels{/name}","releases_url":"https://api.github.com/repos/musescore/MuseScore/releases{/id}","deployments_url":"https://api.github.com/repos/musescore/MuseScore/deployments","created_at":"2012-05-26T12:46:33Z","updated_at":"2018-07-16T13:55:25Z","pushed_at":"2018-07-16T14:00:56Z","git_url":"git://github.com/musescore/MuseScore.git","ssh_url":"git@github.com:musescore/MuseScore.git","clone_url":"https://github.com/musescore/MuseScore.git","svn_url":"https://github.com/musescore/MuseScore","homepage":"https://musescore.org","size":309436,"stargazers_count":2890,"watchers_count":2890,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1019,"mirror_url":null,"archived":false,"open_issues_count":122,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1019,"open_issues":122,"watchers":2890,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/3814"},"html":{"href":"https://github.com/musescore/MuseScore/pull/3814"},"issue":{"href":"https://api.github.com/repos/musescore/MuseScore/issues/3814"},"comments":{"href":"https://api.github.com/repos/musescore/MuseScore/issues/3814/comments"},"review_comments":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/3814/comments"},"review_comment":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/3814/commits"},"statuses":{"href":"https://api.github.com/repos/musescore/MuseScore/statuses/5cb1b06839e89014648a4a4eb80c7ad466e75e1b"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"wschweer","id":1422476,"node_id":"MDQ6VXNlcjE0MjI0NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/1422476?v=4","gravatar_id":"","url":"https://api.github.com/users/wschweer","html_url":"https://github.com/wschweer","followers_url":"https://api.github.com/users/wschweer/followers","following_url":"https://api.github.com/users/wschweer/following{/other_user}","gists_url":"https://api.github.com/users/wschweer/gists{/gist_id}","starred_url":"https://api.github.com/users/wschweer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wschweer/subscriptions","organizations_url":"https://api.github.com/users/wschweer/orgs","repos_url":"https://api.github.com/users/wschweer/repos","events_url":"https://api.github.com/users/wschweer/events{/privacy}","received_events_url":"https://api.github.com/users/wschweer/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":63,"deletions":25,"changed_files":3}}
{"actor":{"display_login":"wschweer"}}