{"action":"created","comment":{"url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/comments/176522818","pull_request_review_id":106242204,"id":176522818,"diff_hunk":"@@ -1,36 +1,168 @@\n @import \"../../patternfly-utilities\";\n \n+// stylelint-disable\n+:root {\n+\n+  // line height - DELETE - just here for review with designer\n+  --pf-c-content--sm--LineHeight: var(--pf-global--sm--LineHeight);\n+  --pf-c-content--md--LineHeight: var(--pf-global--md--LineHeight);\n+  --pf-c-content--lg--LineHeight: var(--pf-global--lg--LineHeight);\n+\n+// are we being opinionated by specifying a single font-weight variable for all headers?\n+  // Headings\n+  --pf-c-content--heading--FontWeight: var(--pf-global--normal--FontWeight);\n+\n+  // Hero title\n+  // --pf-c-content--hero-title--MarginTop: var(--pf-global--spacer--xxxl);\n+  // --pf-c-content--hero-title--MarginBottom: var(--pf-global--spacer--lg);\n+  // update variables above when spacers are updated\n+  // the following are spacers as defined in the issue\n+  --pf-c-content--hero-title--MarginTop: 24px;\n+  --pf-c-content--hero-title--MarginBottom: 16px;\n+  --pf-c-content--hero-title--LineHeight: var(--pf-global--sm--LineHeight);\n+  --pf-c-content--hero-title--FontSize: var(--pf-global--hero-title--FontSize);\n+  --pf-c-content--hero-title--FontWeight: var(--pf-global--normal--FontWeight);\n+\n+  // h1 - Main title","path":"src/patternfly/components/Content/styles.scss","position":22,"original_position":26,"commit_id":"7437aba6f9b94d18866e5581b0bce7e1f77e3085","original_commit_id":"1b13004fa9222a52e3aa7b128044b6a6a746f11b","user":{"login":"andresgalante","id":1832037,"avatar_url":"https://avatars1.githubusercontent.com/u/1832037?v=4","gravatar_id":"","url":"https://api.github.com/users/andresgalante","html_url":"https://github.com/andresgalante","followers_url":"https://api.github.com/users/andresgalante/followers","following_url":"https://api.github.com/users/andresgalante/following{/other_user}","gists_url":"https://api.github.com/users/andresgalante/gists{/gist_id}","starred_url":"https://api.github.com/users/andresgalante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresgalante/subscriptions","organizations_url":"https://api.github.com/users/andresgalante/orgs","repos_url":"https://api.github.com/users/andresgalante/repos","events_url":"https://api.github.com/users/andresgalante/events{/privacy}","received_events_url":"https://api.github.com/users/andresgalante/received_events","type":"User","site_admin":false},"body":"You are right. The variable reflects the selector, the idea been that you can read the html API and undertand which variable  to change.\r\n\r\nJust make sure that the component variable with the element selector is set with a global variable.","created_at":"2018-03-22T18:15:10Z","updated_at":"2018-03-22T18:15:10Z","html_url":"https://github.com/patternfly/patternfly-next/pull/68#discussion_r176522818","pull_request_url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/68","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/comments/176522818"},"html":{"href":"https://github.com/patternfly/patternfly-next/pull/68#discussion_r176522818"},"pull_request":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/68"}},"in_reply_to_id":176466852},"pull_request":{"url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/68","id":176814627,"html_url":"https://github.com/patternfly/patternfly-next/pull/68","diff_url":"https://github.com/patternfly/patternfly-next/pull/68.diff","patch_url":"https://github.com/patternfly/patternfly-next/pull/68.patch","issue_url":"https://api.github.com/repos/patternfly/patternfly-next/issues/68","number":68,"state":"open","locked":false,"title":"[wip] Update font sizes and line heights","user":{"login":"jgiardino","id":21063328,"avatar_url":"https://avatars1.githubusercontent.com/u/21063328?v=4","gravatar_id":"","url":"https://api.github.com/users/jgiardino","html_url":"https://github.com/jgiardino","followers_url":"https://api.github.com/users/jgiardino/followers","following_url":"https://api.github.com/users/jgiardino/following{/other_user}","gists_url":"https://api.github.com/users/jgiardino/gists{/gist_id}","starred_url":"https://api.github.com/users/jgiardino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgiardino/subscriptions","organizations_url":"https://api.github.com/users/jgiardino/orgs","repos_url":"https://api.github.com/users/jgiardino/repos","events_url":"https://api.github.com/users/jgiardino/events{/privacy}","received_events_url":"https://api.github.com/users/jgiardino/received_events","type":"User","site_admin":false},"body":"This is still a work in progress. For now I'm posting so that visual design can review and provide comments.\r\n\r\nSome items that are still pending:\r\n\r\n- include default values for each style definition\r\n- define font-sizes and possibly other values for h4, h5, and h6\r\n- remove variables for Tiny text from the Content component\r\n\r\nI also have some questions which are mostly included in the form of inline comments.\r\n\r\n[Link to demo](https://deploy-preview-68--pf-next.netlify.com/components/content/)","created_at":"2018-03-22T15:23:02Z","updated_at":"2018-03-22T18:15:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d747084e38ce03d5d23037739a11d3cc98b2d939","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/68/commits","review_comments_url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/68/comments","review_comment_url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/comments{/number}","comments_url":"https://api.github.com/repos/patternfly/patternfly-next/issues/68/comments","statuses_url":"https://api.github.com/repos/patternfly/patternfly-next/statuses/7437aba6f9b94d18866e5581b0bce7e1f77e3085","head":{"label":"jgiardino:typography","ref":"typography","sha":"7437aba6f9b94d18866e5581b0bce7e1f77e3085","user":{"login":"jgiardino","id":21063328,"avatar_url":"https://avatars1.githubusercontent.com/u/21063328?v=4","gravatar_id":"","url":"https://api.github.com/users/jgiardino","html_url":"https://github.com/jgiardino","followers_url":"https://api.github.com/users/jgiardino/followers","following_url":"https://api.github.com/users/jgiardino/following{/other_user}","gists_url":"https://api.github.com/users/jgiardino/gists{/gist_id}","starred_url":"https://api.github.com/users/jgiardino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgiardino/subscriptions","organizations_url":"https://api.github.com/users/jgiardino/orgs","repos_url":"https://api.github.com/users/jgiardino/repos","events_url":"https://api.github.com/users/jgiardino/events{/privacy}","received_events_url":"https://api.github.com/users/jgiardino/received_events","type":"User","site_admin":false},"repo":{"id":125253402,"name":"patternfly-next","full_name":"jgiardino/patternfly-next","owner":{"login":"jgiardino","id":21063328,"avatar_url":"https://avatars1.githubusercontent.com/u/21063328?v=4","gravatar_id":"","url":"https://api.github.com/users/jgiardino","html_url":"https://github.com/jgiardino","followers_url":"https://api.github.com/users/jgiardino/followers","following_url":"https://api.github.com/users/jgiardino/following{/other_user}","gists_url":"https://api.github.com/users/jgiardino/gists{/gist_id}","starred_url":"https://api.github.com/users/jgiardino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgiardino/subscriptions","organizations_url":"https://api.github.com/users/jgiardino/orgs","repos_url":"https://api.github.com/users/jgiardino/repos","events_url":"https://api.github.com/users/jgiardino/events{/privacy}","received_events_url":"https://api.github.com/users/jgiardino/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jgiardino/patternfly-next","description":"Working repo for patternfly next","fork":true,"url":"https://api.github.com/repos/jgiardino/patternfly-next","forks_url":"https://api.github.com/repos/jgiardino/patternfly-next/forks","keys_url":"https://api.github.com/repos/jgiardino/patternfly-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgiardino/patternfly-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgiardino/patternfly-next/teams","hooks_url":"https://api.github.com/repos/jgiardino/patternfly-next/hooks","issue_events_url":"https://api.github.com/repos/jgiardino/patternfly-next/issues/events{/number}","events_url":"https://api.github.com/repos/jgiardino/patternfly-next/events","assignees_url":"https://api.github.com/repos/jgiardino/patternfly-next/assignees{/user}","branches_url":"https://api.github.com/repos/jgiardino/patternfly-next/branches{/branch}","tags_url":"https://api.github.com/repos/jgiardino/patternfly-next/tags","blobs_url":"https://api.github.com/repos/jgiardino/patternfly-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgiardino/patternfly-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgiardino/patternfly-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgiardino/patternfly-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgiardino/patternfly-next/statuses/{sha}","languages_url":"https://api.github.com/repos/jgiardino/patternfly-next/languages","stargazers_url":"https://api.github.com/repos/jgiardino/patternfly-next/stargazers","contributors_url":"https://api.github.com/repos/jgiardino/patternfly-next/contributors","subscribers_url":"https://api.github.com/repos/jgiardino/patternfly-next/subscribers","subscription_url":"https://api.github.com/repos/jgiardino/patternfly-next/subscription","commits_url":"https://api.github.com/repos/jgiardino/patternfly-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgiardino/patternfly-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgiardino/patternfly-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgiardino/patternfly-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/jgiardino/patternfly-next/contents/{+path}","compare_url":"https://api.github.com/repos/jgiardino/patternfly-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgiardino/patternfly-next/merges","archive_url":"https://api.github.com/repos/jgiardino/patternfly-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgiardino/patternfly-next/downloads","issues_url":"https://api.github.com/repos/jgiardino/patternfly-next/issues{/number}","pulls_url":"https://api.github.com/repos/jgiardino/patternfly-next/pulls{/number}","milestones_url":"https://api.github.com/repos/jgiardino/patternfly-next/milestones{/number}","notifications_url":"https://api.github.com/repos/jgiardino/patternfly-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgiardino/patternfly-next/labels{/name}","releases_url":"https://api.github.com/repos/jgiardino/patternfly-next/releases{/id}","deployments_url":"https://api.github.com/repos/jgiardino/patternfly-next/deployments","created_at":"2018-03-14T18:01:05Z","updated_at":"2018-03-20T17:37:11Z","pushed_at":"2018-03-22T15:37:28Z","git_url":"git://github.com/jgiardino/patternfly-next.git","ssh_url":"git@github.com:jgiardino/patternfly-next.git","clone_url":"https://github.com/jgiardino/patternfly-next.git","svn_url":"https://github.com/jgiardino/patternfly-next","homepage":null,"size":13445,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"patternfly:master","ref":"master","sha":"b409a8308d78cdb145fdba1f91647b00ebabbc2e","user":{"login":"patternfly","id":6391110,"avatar_url":"https://avatars3.githubusercontent.com/u/6391110?v=4","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"repo":{"id":122507459,"name":"patternfly-next","full_name":"patternfly/patternfly-next","owner":{"login":"patternfly","id":6391110,"avatar_url":"https://avatars3.githubusercontent.com/u/6391110?v=4","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/patternfly/patternfly-next","description":"Working repo for patternfly next","fork":false,"url":"https://api.github.com/repos/patternfly/patternfly-next","forks_url":"https://api.github.com/repos/patternfly/patternfly-next/forks","keys_url":"https://api.github.com/repos/patternfly/patternfly-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patternfly/patternfly-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patternfly/patternfly-next/teams","hooks_url":"https://api.github.com/repos/patternfly/patternfly-next/hooks","issue_events_url":"https://api.github.com/repos/patternfly/patternfly-next/issues/events{/number}","events_url":"https://api.github.com/repos/patternfly/patternfly-next/events","assignees_url":"https://api.github.com/repos/patternfly/patternfly-next/assignees{/user}","branches_url":"https://api.github.com/repos/patternfly/patternfly-next/branches{/branch}","tags_url":"https://api.github.com/repos/patternfly/patternfly-next/tags","blobs_url":"https://api.github.com/repos/patternfly/patternfly-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patternfly/patternfly-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patternfly/patternfly-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/patternfly/patternfly-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patternfly/patternfly-next/statuses/{sha}","languages_url":"https://api.github.com/repos/patternfly/patternfly-next/languages","stargazers_url":"https://api.github.com/repos/patternfly/patternfly-next/stargazers","contributors_url":"https://api.github.com/repos/patternfly/patternfly-next/contributors","subscribers_url":"https://api.github.com/repos/patternfly/patternfly-next/subscribers","subscription_url":"https://api.github.com/repos/patternfly/patternfly-next/subscription","commits_url":"https://api.github.com/repos/patternfly/patternfly-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/patternfly/patternfly-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/patternfly/patternfly-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/patternfly/patternfly-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/patternfly/patternfly-next/contents/{+path}","compare_url":"https://api.github.com/repos/patternfly/patternfly-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patternfly/patternfly-next/merges","archive_url":"https://api.github.com/repos/patternfly/patternfly-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patternfly/patternfly-next/downloads","issues_url":"https://api.github.com/repos/patternfly/patternfly-next/issues{/number}","pulls_url":"https://api.github.com/repos/patternfly/patternfly-next/pulls{/number}","milestones_url":"https://api.github.com/repos/patternfly/patternfly-next/milestones{/number}","notifications_url":"https://api.github.com/repos/patternfly/patternfly-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patternfly/patternfly-next/labels{/name}","releases_url":"https://api.github.com/repos/patternfly/patternfly-next/releases{/id}","deployments_url":"https://api.github.com/repos/patternfly/patternfly-next/deployments","created_at":"2018-02-22T16:52:59Z","updated_at":"2018-03-22T12:20:19Z","pushed_at":"2018-03-22T17:09:22Z","git_url":"git://github.com/patternfly/patternfly-next.git","ssh_url":"git@github.com:patternfly/patternfly-next.git","clone_url":"https://github.com/patternfly/patternfly-next.git","svn_url":"https://github.com/patternfly/patternfly-next","homepage":null,"size":13441,"stargazers_count":5,"watchers_count":5,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":31,"license":null,"forks":11,"open_issues":31,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/68"},"html":{"href":"https://github.com/patternfly/patternfly-next/pull/68"},"issue":{"href":"https://api.github.com/repos/patternfly/patternfly-next/issues/68"},"comments":{"href":"https://api.github.com/repos/patternfly/patternfly-next/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/patternfly/patternfly-next/statuses/7437aba6f9b94d18866e5581b0bce7e1f77e3085"}},"author_association":"NONE"}}
{"actor":{"display_login":"andresgalante"}}