{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/vyper/issues/1125","repository_url":"https://api.github.com/repos/ethereum/vyper","labels_url":"https://api.github.com/repos/ethereum/vyper/issues/1125/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/vyper/issues/1125/comments","events_url":"https://api.github.com/repos/ethereum/vyper/issues/1125/events","html_url":"https://github.com/ethereum/vyper/pull/1125","id":388526536,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NzcwMDgz","number":1125,"title":"Make built-in constant op code generation more efficient","user":{"login":"jakerockland","id":8602661,"node_id":"MDQ6VXNlcjg2MDI2NjE=","avatar_url":"https://avatars3.githubusercontent.com/u/8602661?v=4","gravatar_id":"","url":"https://api.github.com/users/jakerockland","html_url":"https://github.com/jakerockland","followers_url":"https://api.github.com/users/jakerockland/followers","following_url":"https://api.github.com/users/jakerockland/following{/other_user}","gists_url":"https://api.github.com/users/jakerockland/gists{/gist_id}","starred_url":"https://api.github.com/users/jakerockland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakerockland/subscriptions","organizations_url":"https://api.github.com/users/jakerockland/orgs","repos_url":"https://api.github.com/users/jakerockland/repos","events_url":"https://api.github.com/users/jakerockland/events{/privacy}","received_events_url":"https://api.github.com/users/jakerockland/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-12-07T06:45:42Z","updated_at":"2018-12-11T14:42:40Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ethereum/vyper/pulls/1125","html_url":"https://github.com/ethereum/vyper/pull/1125","diff_url":"https://github.com/ethereum/vyper/pull/1125.diff","patch_url":"https://github.com/ethereum/vyper/pull/1125.patch"},"body":"### - What I did\r\n\r\nAdded better tests, refactored, and made op-code generation for built-in constants more efficient.\r\n\r\nThis also fixes #1121\r\n\r\n### - How I did it\r\n\r\nBuilt-in constants should use the values from `SizeLimits` in `utils.py`\r\n\r\n### - How to verify it\r\n\r\n`make test`\r\n\r\n### - Description for the changelog\r\n\r\nMake built-in constant op code generation more efficient.\r\n\r\n### - Cute Animal Picture\r\n\r\n![image](https://user-images.githubusercontent.com/8602661/49631880-f97bca80-f9b0-11e8-9618-ea19e5f6c2de.png)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ethereum/vyper/issues/comments/446226288","html_url":"https://github.com/ethereum/vyper/pull/1125#issuecomment-446226288","issue_url":"https://api.github.com/repos/ethereum/vyper/issues/1125","id":446226288,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjIyNjI4OA==","user":{"login":"jacqueswww","id":6917456,"node_id":"MDQ6VXNlcjY5MTc0NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/6917456?v=4","gravatar_id":"","url":"https://api.github.com/users/jacqueswww","html_url":"https://github.com/jacqueswww","followers_url":"https://api.github.com/users/jacqueswww/followers","following_url":"https://api.github.com/users/jacqueswww/following{/other_user}","gists_url":"https://api.github.com/users/jacqueswww/gists{/gist_id}","starred_url":"https://api.github.com/users/jacqueswww/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacqueswww/subscriptions","organizations_url":"https://api.github.com/users/jacqueswww/orgs","repos_url":"https://api.github.com/users/jacqueswww/repos","events_url":"https://api.github.com/users/jacqueswww/events{/privacy}","received_events_url":"https://api.github.com/users/jacqueswww/received_events","type":"User","site_admin":false},"created_at":"2018-12-11T14:42:40Z","updated_at":"2018-12-11T14:42:40Z","author_association":"CONTRIBUTOR","body":"this is roughly what the ASM looks like:\r\n```\r\n![image](https://user-images.githubusercontent.com/6917456/49807806-ad8ba580-fd63-11e8-8cab-687f35c028a2.png)\r\n\r\n```\r\n\r\nSo an MLOAD (1byte opcode) + 1byte (memory address) ."}}
{"actor":{"display_login":"jacqueswww"}}