{"action":"closed","number":36316,"pull_request":{"url":"https://api.github.com/repos/moby/moby/pulls/36316","id":169283170,"html_url":"https://github.com/moby/moby/pull/36316","diff_url":"https://github.com/moby/moby/pull/36316.diff","patch_url":"https://github.com/moby/moby/pull/36316.patch","issue_url":"https://api.github.com/repos/moby/moby/issues/36316","number":36316,"state":"closed","locked":false,"title":"Fix to address regression caused by PR 30897","user":{"login":"selansen","id":10554015,"avatar_url":"https://avatars3.githubusercontent.com/u/10554015?v=4","gravatar_id":"","url":"https://api.github.com/users/selansen","html_url":"https://github.com/selansen","followers_url":"https://api.github.com/users/selansen/followers","following_url":"https://api.github.com/users/selansen/following{/other_user}","gists_url":"https://api.github.com/users/selansen/gists{/gist_id}","starred_url":"https://api.github.com/users/selansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selansen/subscriptions","organizations_url":"https://api.github.com/users/selansen/orgs","repos_url":"https://api.github.com/users/selansen/repos","events_url":"https://api.github.com/users/selansen/events{/privacy}","received_events_url":"https://api.github.com/users/selansen/received_events","type":"User","site_admin":false},"body":"fixes https://github.com/moby/moby/issues/36247\r\n\r\nWith the inclusion of PR https://github.com/moby/moby/pull/30897, creating service for host network fails in 18.02. Modified IsPreDefinedNetwork check and return NetworkNameError instead of errdefs.Forbidden to address this issue\r\n\r\nSigned-off-by: selansen <elango.siva@docker.com>\r\n\r\n<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/moby/moby/blob/master/CONTRIBUTING.md\r\n\r\n** Make sure all your commits include a signature generated with `git commit -s` **\r\n\r\nFor additional information on our contributing process, read our contributing\r\nguide https://docs.docker.com/opensource/code/\r\n\r\nIf this is a bug fix, make sure your description includes \"fixes #xxxx\", or\r\n\"closes #xxxx\"\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n**- What I did**\r\n\r\n**- How I did it**\r\n\r\n**- How to verify it**\r\n\r\n**- Description for the changelog**\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog:\r\n-->\r\n\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**","created_at":"2018-02-15T04:32:52Z","updated_at":"2018-03-06T12:40:30Z","closed_at":"2018-03-06T12:40:30Z","merged_at":"2018-03-06T12:40:30Z","merge_commit_sha":"0b0af855ae28698f8e3dc97cdc2a46e714ce6b6a","assignee":{"login":"crosbymichael","id":749551,"avatar_url":"https://avatars1.githubusercontent.com/u/749551?v=4","gravatar_id":"","url":"https://api.github.com/users/crosbymichael","html_url":"https://github.com/crosbymichael","followers_url":"https://api.github.com/users/crosbymichael/followers","following_url":"https://api.github.com/users/crosbymichael/following{/other_user}","gists_url":"https://api.github.com/users/crosbymichael/gists{/gist_id}","starred_url":"https://api.github.com/users/crosbymichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosbymichael/subscriptions","organizations_url":"https://api.github.com/users/crosbymichael/orgs","repos_url":"https://api.github.com/users/crosbymichael/repos","events_url":"https://api.github.com/users/crosbymichael/events{/privacy}","received_events_url":"https://api.github.com/users/crosbymichael/received_events","type":"User","site_admin":false},"assignees":[{"login":"crosbymichael","id":749551,"avatar_url":"https://avatars1.githubusercontent.com/u/749551?v=4","gravatar_id":"","url":"https://api.github.com/users/crosbymichael","html_url":"https://github.com/crosbymichael","followers_url":"https://api.github.com/users/crosbymichael/followers","following_url":"https://api.github.com/users/crosbymichael/following{/other_user}","gists_url":"https://api.github.com/users/crosbymichael/gists{/gist_id}","starred_url":"https://api.github.com/users/crosbymichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosbymichael/subscriptions","organizations_url":"https://api.github.com/users/crosbymichael/orgs","repos_url":"https://api.github.com/users/crosbymichael/repos","events_url":"https://api.github.com/users/crosbymichael/events{/privacy}","received_events_url":"https://api.github.com/users/crosbymichael/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"dnephin","id":442180,"avatar_url":"https://avatars1.githubusercontent.com/u/442180?v=4","gravatar_id":"","url":"https://api.github.com/users/dnephin","html_url":"https://github.com/dnephin","followers_url":"https://api.github.com/users/dnephin/followers","following_url":"https://api.github.com/users/dnephin/following{/other_user}","gists_url":"https://api.github.com/users/dnephin/gists{/gist_id}","starred_url":"https://api.github.com/users/dnephin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnephin/subscriptions","organizations_url":"https://api.github.com/users/dnephin/orgs","repos_url":"https://api.github.com/users/dnephin/repos","events_url":"https://api.github.com/users/dnephin/events{/privacy}","received_events_url":"https://api.github.com/users/dnephin/received_events","type":"User","site_admin":false},{"login":"cpuguy83","id":799078,"avatar_url":"https://avatars3.githubusercontent.com/u/799078?v=4","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":237472034,"url":"https://api.github.com/repos/moby/moby/labels/area/networking","name":"area/networking","color":"fbca04","default":false},{"id":175375407,"url":"https://api.github.com/repos/moby/moby/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/moby/moby/pulls/36316/commits","review_comments_url":"https://api.github.com/repos/moby/moby/pulls/36316/comments","review_comment_url":"https://api.github.com/repos/moby/moby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moby/moby/issues/36316/comments","statuses_url":"https://api.github.com/repos/moby/moby/statuses/7cf8b20762cc9491f52ff3f3d94c880378183696","head":{"label":"selansen:36247","ref":"36247","sha":"7cf8b20762cc9491f52ff3f3d94c880378183696","user":{"login":"selansen","id":10554015,"avatar_url":"https://avatars3.githubusercontent.com/u/10554015?v=4","gravatar_id":"","url":"https://api.github.com/users/selansen","html_url":"https://github.com/selansen","followers_url":"https://api.github.com/users/selansen/followers","following_url":"https://api.github.com/users/selansen/following{/other_user}","gists_url":"https://api.github.com/users/selansen/gists{/gist_id}","starred_url":"https://api.github.com/users/selansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selansen/subscriptions","organizations_url":"https://api.github.com/users/selansen/orgs","repos_url":"https://api.github.com/users/selansen/repos","events_url":"https://api.github.com/users/selansen/events{/privacy}","received_events_url":"https://api.github.com/users/selansen/received_events","type":"User","site_admin":false},"repo":{"id":112528409,"name":"moby","full_name":"selansen/moby","owner":{"login":"selansen","id":10554015,"avatar_url":"https://avatars3.githubusercontent.com/u/10554015?v=4","gravatar_id":"","url":"https://api.github.com/users/selansen","html_url":"https://github.com/selansen","followers_url":"https://api.github.com/users/selansen/followers","following_url":"https://api.github.com/users/selansen/following{/other_user}","gists_url":"https://api.github.com/users/selansen/gists{/gist_id}","starred_url":"https://api.github.com/users/selansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selansen/subscriptions","organizations_url":"https://api.github.com/users/selansen/orgs","repos_url":"https://api.github.com/users/selansen/repos","events_url":"https://api.github.com/users/selansen/events{/privacy}","received_events_url":"https://api.github.com/users/selansen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/selansen/moby","description":"Moby Project - a collaborative project for the container ecosystem to assemble container-based systems","fork":true,"url":"https://api.github.com/repos/selansen/moby","forks_url":"https://api.github.com/repos/selansen/moby/forks","keys_url":"https://api.github.com/repos/selansen/moby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/selansen/moby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/selansen/moby/teams","hooks_url":"https://api.github.com/repos/selansen/moby/hooks","issue_events_url":"https://api.github.com/repos/selansen/moby/issues/events{/number}","events_url":"https://api.github.com/repos/selansen/moby/events","assignees_url":"https://api.github.com/repos/selansen/moby/assignees{/user}","branches_url":"https://api.github.com/repos/selansen/moby/branches{/branch}","tags_url":"https://api.github.com/repos/selansen/moby/tags","blobs_url":"https://api.github.com/repos/selansen/moby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/selansen/moby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/selansen/moby/git/refs{/sha}","trees_url":"https://api.github.com/repos/selansen/moby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/selansen/moby/statuses/{sha}","languages_url":"https://api.github.com/repos/selansen/moby/languages","stargazers_url":"https://api.github.com/repos/selansen/moby/stargazers","contributors_url":"https://api.github.com/repos/selansen/moby/contributors","subscribers_url":"https://api.github.com/repos/selansen/moby/subscribers","subscription_url":"https://api.github.com/repos/selansen/moby/subscription","commits_url":"https://api.github.com/repos/selansen/moby/commits{/sha}","git_commits_url":"https://api.github.com/repos/selansen/moby/git/commits{/sha}","comments_url":"https://api.github.com/repos/selansen/moby/comments{/number}","issue_comment_url":"https://api.github.com/repos/selansen/moby/issues/comments{/number}","contents_url":"https://api.github.com/repos/selansen/moby/contents/{+path}","compare_url":"https://api.github.com/repos/selansen/moby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/selansen/moby/merges","archive_url":"https://api.github.com/repos/selansen/moby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/selansen/moby/downloads","issues_url":"https://api.github.com/repos/selansen/moby/issues{/number}","pulls_url":"https://api.github.com/repos/selansen/moby/pulls{/number}","milestones_url":"https://api.github.com/repos/selansen/moby/milestones{/number}","notifications_url":"https://api.github.com/repos/selansen/moby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/selansen/moby/labels{/name}","releases_url":"https://api.github.com/repos/selansen/moby/releases{/id}","deployments_url":"https://api.github.com/repos/selansen/moby/deployments","created_at":"2017-11-29T21:13:12Z","updated_at":"2017-11-29T21:13:25Z","pushed_at":"2018-03-06T00:10:47Z","git_url":"git://github.com/selansen/moby.git","ssh_url":"git@github.com:selansen/moby.git","clone_url":"https://github.com/selansen/moby.git","svn_url":"https://github.com/selansen/moby","homepage":"https://mobyproject.org/","size":136693,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"moby:master","ref":"master","sha":"3e1505e3e671d35636f7818dc1f41e4a4d429620","user":{"login":"moby","id":27259197,"avatar_url":"https://avatars1.githubusercontent.com/u/27259197?v=4","gravatar_id":"","url":"https://api.github.com/users/moby","html_url":"https://github.com/moby","followers_url":"https://api.github.com/users/moby/followers","following_url":"https://api.github.com/users/moby/following{/other_user}","gists_url":"https://api.github.com/users/moby/gists{/gist_id}","starred_url":"https://api.github.com/users/moby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moby/subscriptions","organizations_url":"https://api.github.com/users/moby/orgs","repos_url":"https://api.github.com/users/moby/repos","events_url":"https://api.github.com/users/moby/events{/privacy}","received_events_url":"https://api.github.com/users/moby/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"moby","full_name":"moby/moby","owner":{"login":"moby","id":27259197,"avatar_url":"https://avatars1.githubusercontent.com/u/27259197?v=4","gravatar_id":"","url":"https://api.github.com/users/moby","html_url":"https://github.com/moby","followers_url":"https://api.github.com/users/moby/followers","following_url":"https://api.github.com/users/moby/following{/other_user}","gists_url":"https://api.github.com/users/moby/gists{/gist_id}","starred_url":"https://api.github.com/users/moby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moby/subscriptions","organizations_url":"https://api.github.com/users/moby/orgs","repos_url":"https://api.github.com/users/moby/repos","events_url":"https://api.github.com/users/moby/events{/privacy}","received_events_url":"https://api.github.com/users/moby/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moby/moby","description":"Moby Project - a collaborative project for the container ecosystem to assemble container-based systems","fork":false,"url":"https://api.github.com/repos/moby/moby","forks_url":"https://api.github.com/repos/moby/moby/forks","keys_url":"https://api.github.com/repos/moby/moby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moby/moby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moby/moby/teams","hooks_url":"https://api.github.com/repos/moby/moby/hooks","issue_events_url":"https://api.github.com/repos/moby/moby/issues/events{/number}","events_url":"https://api.github.com/repos/moby/moby/events","assignees_url":"https://api.github.com/repos/moby/moby/assignees{/user}","branches_url":"https://api.github.com/repos/moby/moby/branches{/branch}","tags_url":"https://api.github.com/repos/moby/moby/tags","blobs_url":"https://api.github.com/repos/moby/moby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moby/moby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moby/moby/git/refs{/sha}","trees_url":"https://api.github.com/repos/moby/moby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moby/moby/statuses/{sha}","languages_url":"https://api.github.com/repos/moby/moby/languages","stargazers_url":"https://api.github.com/repos/moby/moby/stargazers","contributors_url":"https://api.github.com/repos/moby/moby/contributors","subscribers_url":"https://api.github.com/repos/moby/moby/subscribers","subscription_url":"https://api.github.com/repos/moby/moby/subscription","commits_url":"https://api.github.com/repos/moby/moby/commits{/sha}","git_commits_url":"https://api.github.com/repos/moby/moby/git/commits{/sha}","comments_url":"https://api.github.com/repos/moby/moby/comments{/number}","issue_comment_url":"https://api.github.com/repos/moby/moby/issues/comments{/number}","contents_url":"https://api.github.com/repos/moby/moby/contents/{+path}","compare_url":"https://api.github.com/repos/moby/moby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moby/moby/merges","archive_url":"https://api.github.com/repos/moby/moby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moby/moby/downloads","issues_url":"https://api.github.com/repos/moby/moby/issues{/number}","pulls_url":"https://api.github.com/repos/moby/moby/pulls{/number}","milestones_url":"https://api.github.com/repos/moby/moby/milestones{/number}","notifications_url":"https://api.github.com/repos/moby/moby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moby/moby/labels{/name}","releases_url":"https://api.github.com/repos/moby/moby/releases{/id}","deployments_url":"https://api.github.com/repos/moby/moby/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2018-03-06T12:18:23Z","pushed_at":"2018-03-06T12:40:30Z","git_url":"git://github.com/moby/moby.git","ssh_url":"git@github.com:moby/moby.git","clone_url":"https://github.com/moby/moby.git","svn_url":"https://github.com/moby/moby","homepage":"https://mobyproject.org/","size":136736,"stargazers_count":47888,"watchers_count":47888,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14118,"mirror_url":null,"archived":false,"open_issues_count":3077,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":14118,"open_issues":3077,"watchers":47888,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moby/moby/pulls/36316"},"html":{"href":"https://github.com/moby/moby/pull/36316"},"issue":{"href":"https://api.github.com/repos/moby/moby/issues/36316"},"comments":{"href":"https://api.github.com/repos/moby/moby/issues/36316/comments"},"review_comments":{"href":"https://api.github.com/repos/moby/moby/pulls/36316/comments"},"review_comment":{"href":"https://api.github.com/repos/moby/moby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moby/moby/pulls/36316/commits"},"statuses":{"href":"https://api.github.com/repos/moby/moby/statuses/7cf8b20762cc9491f52ff3f3d94c880378183696"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars2.githubusercontent.com/u/1804568?v=4","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"comments":16,"review_comments":12,"maintainer_can_modify":false,"commits":1,"additions":88,"deletions":4,"changed_files":3}}
{"actor":{"display_login":"thaJeztah"}}