{"push_id":2354384201,"size":27,"distinct_size":1,"ref":"refs/heads/session-tracing","head":"bb3ba9fe14f4235ee19c46982036d4763432760f","before":"caf3be75b4a6ba3056539a1238c4712339e0d58d","commits":[{"sha":"6ad5c0b7f17918b7781bedc7c2605c81f5774513","author":{"name":"Radu Berinde","email":"295c33b47a77c8cc349159d95207f89af9f8470a@cockroachlabs.com"},"message":"sql: don't generate spans on implicit columns not part of the key\n\nThe new index selection code can generate spans that incorporate\nvalues on implicit columns. However, this is only correct when\nimplicit columns are part of the key, i.e. non-unique indexes.\n\nRelease note (bug fix): fixed incorrect index constraints on primary\nkey columns on unique indexes (there was a possibility of returning\nfewer results, though unclear if it can happen in practice).","distinct":false,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/6ad5c0b7f17918b7781bedc7c2605c81f5774513"},{"sha":"86d071c4a517521acb9f71040c0c6666333ef153","author":{"name":"Radu Berinde","email":"295c33b47a77c8cc349159d95207f89af9f8470a@cockroachlabs.com"},"message":"opt/idxconstraint: refactor the simplify filter code\n\nUncommenting and refactoring the simplify filter code.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/86d071c4a517521acb9f71040c0c6666333ef153"},{"sha":"3fd001dc2cc1f9bd2d86955bec6bdc2e1fe9b0fc","author":{"name":"Andrew Kimball","email":"93f5b0eff4aa8069432e5aa46db497a274729656@cockroachlabs.com"},"message":"opt: Remove relational operators from older code.\n\nWe don't use relational operators in our index constraints code, so\nremove them. This will make another PR changing how the catalog\nworks easier to land. In the near future, the rest of the older\nindex constraints code will be removed.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/3fd001dc2cc1f9bd2d86955bec6bdc2e1fe9b0fc"},{"sha":"8faa7bb55619640932ccea36e13d383f5323ccfc","author":{"name":"Spencer Kimball","email":"43d88d703c7bdc8f0e0140e90c0c34b9f645ad96@gmail.com"},"message":"storage: refresh spans on InitPut; heed tombstones on Refresh / RefreshRange\n\nA closer examination of `InitPut` made it clear that because it always\nreads, but may not write, we must refresh the span to ensure that no\nfurther writes have occurred. This is different from `ConditionalPut`,\nwhich always leaves an intent on success.\n\nA test case for serializable retries which verifies that `InitPut` must\ndo a client-side retry in the event that it refreshes its key to fail\non a new tombstone showed that we were not failing on new tombstones.\nThis revealed a bug in `Refresh` and `RefreshRange`, where we should be\ndiscovering tombstones, but weren't. This PR adds an optional parameter\nto `MVCCScan` and `MVCCGet` to return tombstone values.\n\nFixes #22543\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/8faa7bb55619640932ccea36e13d383f5323ccfc"},{"sha":"43cac57ae768dfde4768d441e4889042a9c435a6","author":{"name":"Tobias Schottdorf","email":"b6841086cafcf6616505d164b61ac2cf1ab42c4e@gmail.com"},"message":"roachtest: collect heap profiles\n\nThanks to https://github.com/cockroachdb/roachprod/pull/83, we can\ncollect the logs for local clusters like we do for remote ones,\naddressing a TODO.\n\nAllow passing arguments to `roachprod` during start. This highlight\nawkward problems with the separation of `roachtest/roachprod` and in\nparticular the distance to the actual `cockroach start` invocation.\nHowever, not a thread I'm willing to pull now.\n\nPass an env var in the drop test that enables collection of heap\nprofiles (which are then collected as artifacts on teardown).\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/43cac57ae768dfde4768d441e4889042a9c435a6"},{"sha":"f69c298417360e9179c55970476aadf4c69397d6","author":{"name":"Tobias Schottdorf","email":"b6841086cafcf6616505d164b61ac2cf1ab42c4e@gmail.com"},"message":"Merge pull request #22972 from tschottdorf/roachtest/heap\n\nroachtest: collect heap profiles","distinct":false,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/f69c298417360e9179c55970476aadf4c69397d6"},{"sha":"da3e9df9d53746940e405914a11cdeb2520b1eb5","author":{"name":"RaduBerinde","email":"295c33b47a77c8cc349159d95207f89af9f8470a@cockroachlabs.com"},"message":"Merge pull request #22954 from RaduBerinde/move-idx-constr-2\n\nopt/idxconstraint: refactor the simplify filter code","distinct":false,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/da3e9df9d53746940e405914a11cdeb2520b1eb5"},{"sha":"ee65c4758466a1b825cc2a2a3e8ae4075ff137d6","author":{"name":"Radu Berinde","email":"295c33b47a77c8cc349159d95207f89af9f8470a@cockroachlabs.com"},"message":"opt: split idxconstraint test data\n\nSplitting the idxconstraint test data in multiple files. No changes to\nthe tests.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/ee65c4758466a1b825cc2a2a3e8ae4075ff137d6"},{"sha":"740a024756ceb015c2936f9f492d7f15bd378e43","author":{"name":"Andy Kimball","email":"93f5b0eff4aa8069432e5aa46db497a274729656@cockroachlabs.com"},"message":"Merge pull request #22987 from andy-kimball/norel\n\nopt: Remove relational operators from older code.","distinct":false,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/740a024756ceb015c2936f9f492d7f15bd378e43"},{"sha":"efdf6a2673fa7e4fc158a9138b315e021d00fc39","author":{"name":"RaduBerinde","email":"295c33b47a77c8cc349159d95207f89af9f8470a@cockroachlabs.com"},"message":"Merge pull request #22993 from RaduBerinde/split-idx-testdata\n\nopt: split idxconstraint test data","distinct":false,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/efdf6a2673fa7e4fc158a9138b315e021d00fc39"},{"sha":"191b92b7ebe7f9fa6551502dd65bbf4b44c9c0f6","author":{"name":"Raphael 'kena' Poss","email":"7541742341763867a641aada528529ea551ae635@cockroachlabs.com"},"message":"sql: support SET SCHEMA for better compatibility with pg and the SQL standard\n\nAt least one client app (Zippix) uses `SET SCHEMA`, defined by the SQL\nstandard.  `SET SCHEMA` is used by an app after discovering the\navailable schemas in the `information_schema` tables. Postgres\nimplements `SET SCHEMA` as an alias for `SET search_path =`, since the\n\"current schema\" in pg's dialect is defined exactly as \"the first item\nin `search_path`\".\n\nThis patch makes CockroachDB do the same as pg.\n\nRelease note (sql change): CockroachDB now recognizes the special\nsyntax `SET SCHEMA <name>` as an alias for `SET search_path = <name>`\nfor better compatibility with PostgreSQL.","distinct":false,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/191b92b7ebe7f9fa6551502dd65bbf4b44c9c0f6"},{"sha":"4933bb667a9aabeaaa90c0205db61a71f0ce33ea","author":{"name":"RaduBerinde","email":"295c33b47a77c8cc349159d95207f89af9f8470a@cockroachlabs.com"},"message":"Merge pull request #22977 from RaduBerinde/extra-cols\n\nsql: don't generate spans on implicit columns not part of the key","distinct":false,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/4933bb667a9aabeaaa90c0205db61a71f0ce33ea"},{"sha":"ee742367df4924c28399dfe0ea35ce59a98b2c70","author":{"name":"kena","email":"7541742341763867a641aada528529ea551ae635@users.noreply.github.com"},"message":"Merge pull request #22997 from knz/20180223-set-schema\n\nsql: support SET SCHEMA for better compatibility with pg and the SQL standard","distinct":false,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/ee742367df4924c28399dfe0ea35ce59a98b2c70"},{"sha":"fb4ea2c5216dc256a0479b6ad78ae7199ed50bb5","author":{"name":"Raphael 'kena' Poss","email":"7541742341763867a641aada528529ea551ae635@cockroachlabs.com"},"message":"sql: enable inspection of schemas with SHOW SCHEMAS\n\nNow that SHOW TABLES only shows tables in the public schema by\ndefault, and SET DATABASE only supports real databases and not\n(virtual) schemas, there is no simple way for a user to realize that\nthere are multiple schemas in the first place, and which virtual\nschemas exist / are recognized.\n\nRelease note (sql change): the new statement `SHOW SCHEMAS` reveals\nwhich are the valid virtual schemas next to the physical schema\n`public`.","distinct":false,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/fb4ea2c5216dc256a0479b6ad78ae7199ed50bb5"},{"sha":"eadf651e188ac056f16d42c35fe7823564ce8b83","author":{"name":"kena","email":"7541742341763867a641aada528529ea551ae635@users.noreply.github.com"},"message":"Merge pull request #22998 from knz/20180223-show-schemas\n\nsql: enable inspection of schemas with SHOW SCHEMAS","distinct":false,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/eadf651e188ac056f16d42c35fe7823564ce8b83"},{"sha":"5164faf2ac95dddff99dcf80b07de8f5c8420dd4","author":{"name":"Andrew Kimball","email":"93f5b0eff4aa8069432e5aa46db497a274729656@cockroachlabs.com"},"message":"opt: Cleanup logical properties and ColList expressions\n\nThis PR contains some miscellaneous cleanup items:\n  - Improve comments for several ColList operators\n  - Update LogicalPropsFactory to be empty struct and cleanup code a bit\n  - Update logprop and typing tests to use exec-ddl to create schema\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/5164faf2ac95dddff99dcf80b07de8f5c8420dd4"},{"sha":"00445880f4b94733ea6e826834097743d0fbf9f6","author":{"name":"Raphael 'kena' Poss","email":"7541742341763867a641aada528529ea551ae635@cockroachlabs.com"},"message":"sql: simplify the rejection of subqueries in distributed planning\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/00445880f4b94733ea6e826834097743d0fbf9f6"},{"sha":"9a12f9355e9afd15093aca3e8b5ca9280f6545af","author":{"name":"Raphael 'kena' Poss","email":"7541742341763867a641aada528529ea551ae635@cockroachlabs.com"},"message":"sql: make execLocal more clearly operate on the current plan\n\nPrior to this patch, execLocal() would take the logical plan as\nexplicit argument even though its code was effectively operating on\nthe \"current plan\" (planner.curPlan).\n\nThis patch clarifies the situation by removing the explicit argument.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/9a12f9355e9afd15093aca3e8b5ca9280f6545af"},{"sha":"43e20ccbb6dca2ad13c55520955cc638141a41a4","author":{"name":"Spencer Kimball","email":"43d88d703c7bdc8f0e0140e90c0c34b9f645ad96@gmail.com"},"message":"Merge pull request #22965 from spencerkimball/fix-22543\n\nstorage: refresh spans on InitPut; heed tombstones on Refresh / Refre…","distinct":false,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/43e20ccbb6dca2ad13c55520955cc638141a41a4"},{"sha":"a2da685579ff460d0e27dbd514bb5d0ecd22de6f","author":{"name":"Tobias Schottdorf","email":"b6841086cafcf6616505d164b61ac2cf1ab42c4e@gmail.com"},"message":"sql: chunk deletions\n\nIn the absence of a fast path deletion, `DELETE` would generate one\npotentially giant batch and OOM the gateway node. This became obvious\nquickly via heap profiling.\n\nAdded chunking of the deletions to `tableDeleter`. SQL folks may have\nstronger opinions on how to achieve this, or a better idea of a\npreexisting chunking mechanism that works more reliably. If nothing\nelse, this change serves as a prototype to fix #17921.\n\nWith this change, `roachtest run drop` works (as in, it doesn't\nout-of-memory right away; the run takes a long time so I can't yet\nconfirm that it actually passes).\n\nRelease note (sql change): deleting many rows at once now consumes less\nmemory.","distinct":false,"url":"https://api.github.com/repos/andreimatei/cockroach/commits/a2da685579ff460d0e27dbd514bb5d0ecd22de6f"}]}
{"actor":{"display_login":"andreimatei"}}