{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/py-evm/pulls/comments/240401388","pull_request_review_id":183424955,"id":240401388,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDQwMTM4OA==","diff_hunk":"@@ -8,6 +9,36 @@\n )\n \n \n+class BaseDiscoveryServiceResponse(BaseEvent):\n+\n+    def __init__(self, error: Exception) -> None:\n+        self.error = error\n+\n+\n+class PeerCandidatesResponse(BaseDiscoveryServiceResponse):\n+\n+    def __init__(self, candidates: Tuple[str, ...], error: Exception=None) -> None:","path":"p2p/events.py","position":18,"original_position":18,"commit_id":"7fbbcf342c199faafbbcbf5f469985bdcfd5fc1d","original_commit_id":"7fbbcf342c199faafbbcbf5f469985bdcfd5fc1d","user":{"login":"cburgdorf","id":521109,"node_id":"MDQ6VXNlcjUyMTEwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/521109?v=4","gravatar_id":"","url":"https://api.github.com/users/cburgdorf","html_url":"https://github.com/cburgdorf","followers_url":"https://api.github.com/users/cburgdorf/followers","following_url":"https://api.github.com/users/cburgdorf/following{/other_user}","gists_url":"https://api.github.com/users/cburgdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/cburgdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cburgdorf/subscriptions","organizations_url":"https://api.github.com/users/cburgdorf/orgs","repos_url":"https://api.github.com/users/cburgdorf/repos","events_url":"https://api.github.com/users/cburgdorf/events{/privacy}","received_events_url":"https://api.github.com/users/cburgdorf/received_events","type":"User","site_admin":false},"body":"I guess you mean a `NewType` . Yes we *could* do that given how \"short-lived\" and \"fenced\" these `str` are I'm not sure if the extra `NewType` is worth it. It's really just a very small path that these travel as strings and really only because of the serialization issue.","created_at":"2018-12-10T22:12:59Z","updated_at":"2018-12-10T22:12:59Z","html_url":"https://github.com/ethereum/py-evm/pull/1556#discussion_r240401388","pull_request_url":"https://api.github.com/repos/ethereum/py-evm/pulls/1556","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ethereum/py-evm/pulls/comments/240401388"},"html":{"href":"https://github.com/ethereum/py-evm/pull/1556#discussion_r240401388"},"pull_request":{"href":"https://api.github.com/repos/ethereum/py-evm/pulls/1556"}},"in_reply_to_id":240334987},"pull_request":{"url":"https://api.github.com/repos/ethereum/py-evm/pulls/1556","id":236562386,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NTYyMzg2","html_url":"https://github.com/ethereum/py-evm/pull/1556","diff_url":"https://github.com/ethereum/py-evm/pull/1556.diff","patch_url":"https://github.com/ethereum/py-evm/pull/1556.patch","issue_url":"https://api.github.com/repos/ethereum/py-evm/issues/1556","number":1556,"state":"open","locked":false,"title":"Move peer discovery into an isolated plugin","user":{"login":"cburgdorf","id":521109,"node_id":"MDQ6VXNlcjUyMTEwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/521109?v=4","gravatar_id":"","url":"https://api.github.com/users/cburgdorf","html_url":"https://github.com/cburgdorf","followers_url":"https://api.github.com/users/cburgdorf/followers","following_url":"https://api.github.com/users/cburgdorf/following{/other_user}","gists_url":"https://api.github.com/users/cburgdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/cburgdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cburgdorf/subscriptions","organizations_url":"https://api.github.com/users/cburgdorf/orgs","repos_url":"https://api.github.com/users/cburgdorf/repos","events_url":"https://api.github.com/users/cburgdorf/events{/privacy}","received_events_url":"https://api.github.com/users/cburgdorf/received_events","type":"User","site_admin":false},"body":"### What was wrong?\r\n\r\nCurrently the peer discovery runs in the networking process among a lot of other things. Moving it into an isolated plugin should:\r\n\r\n- increase efficiency of syncing as the peer discovery probably takes a fair share of computing power\r\n- increase decoupling as it breaks up the networking code into smaller pieces \r\n- improve reusability as the new discovery can be accessed from any other interested party since it is integrated with the event bus \r\n\r\n### How was it fixed?\r\n\r\nNot yet. Just opening a PR with junk code.\r\n\r\n#### Cute Animal Picture\r\n\r\n![put a cute animal picture link inside the parentheses]()\r\n","created_at":"2018-12-06T15:07:31Z","updated_at":"2018-12-10T22:12:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3194774f033b2b27f860acfbcf1af7fd39fa206","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":630871768,"node_id":"MDU6TGFiZWw2MzA4NzE3Njg=","url":"https://api.github.com/repos/ethereum/py-evm/labels/PR%20state:%20WIP","name":"PR state: WIP","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/py-evm/pulls/1556/commits","review_comments_url":"https://api.github.com/repos/ethereum/py-evm/pulls/1556/comments","review_comment_url":"https://api.github.com/repos/ethereum/py-evm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/py-evm/issues/1556/comments","statuses_url":"https://api.github.com/repos/ethereum/py-evm/statuses/7fbbcf342c199faafbbcbf5f469985bdcfd5fc1d","head":{"label":"cburgdorf:christoph/feat/discovery-plugin","ref":"christoph/feat/discovery-plugin","sha":"7fbbcf342c199faafbbcbf5f469985bdcfd5fc1d","user":{"login":"cburgdorf","id":521109,"node_id":"MDQ6VXNlcjUyMTEwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/521109?v=4","gravatar_id":"","url":"https://api.github.com/users/cburgdorf","html_url":"https://github.com/cburgdorf","followers_url":"https://api.github.com/users/cburgdorf/followers","following_url":"https://api.github.com/users/cburgdorf/following{/other_user}","gists_url":"https://api.github.com/users/cburgdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/cburgdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cburgdorf/subscriptions","organizations_url":"https://api.github.com/users/cburgdorf/orgs","repos_url":"https://api.github.com/users/cburgdorf/repos","events_url":"https://api.github.com/users/cburgdorf/events{/privacy}","received_events_url":"https://api.github.com/users/cburgdorf/received_events","type":"User","site_admin":false},"repo":{"id":122467896,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI0Njc4OTY=","name":"py-evm","full_name":"cburgdorf/py-evm","private":false,"owner":{"login":"cburgdorf","id":521109,"node_id":"MDQ6VXNlcjUyMTEwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/521109?v=4","gravatar_id":"","url":"https://api.github.com/users/cburgdorf","html_url":"https://github.com/cburgdorf","followers_url":"https://api.github.com/users/cburgdorf/followers","following_url":"https://api.github.com/users/cburgdorf/following{/other_user}","gists_url":"https://api.github.com/users/cburgdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/cburgdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cburgdorf/subscriptions","organizations_url":"https://api.github.com/users/cburgdorf/orgs","repos_url":"https://api.github.com/users/cburgdorf/repos","events_url":"https://api.github.com/users/cburgdorf/events{/privacy}","received_events_url":"https://api.github.com/users/cburgdorf/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cburgdorf/py-evm","description":"A Python implementation of the Ethereum Virtual Machine","fork":true,"url":"https://api.github.com/repos/cburgdorf/py-evm","forks_url":"https://api.github.com/repos/cburgdorf/py-evm/forks","keys_url":"https://api.github.com/repos/cburgdorf/py-evm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cburgdorf/py-evm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cburgdorf/py-evm/teams","hooks_url":"https://api.github.com/repos/cburgdorf/py-evm/hooks","issue_events_url":"https://api.github.com/repos/cburgdorf/py-evm/issues/events{/number}","events_url":"https://api.github.com/repos/cburgdorf/py-evm/events","assignees_url":"https://api.github.com/repos/cburgdorf/py-evm/assignees{/user}","branches_url":"https://api.github.com/repos/cburgdorf/py-evm/branches{/branch}","tags_url":"https://api.github.com/repos/cburgdorf/py-evm/tags","blobs_url":"https://api.github.com/repos/cburgdorf/py-evm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cburgdorf/py-evm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cburgdorf/py-evm/git/refs{/sha}","trees_url":"https://api.github.com/repos/cburgdorf/py-evm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cburgdorf/py-evm/statuses/{sha}","languages_url":"https://api.github.com/repos/cburgdorf/py-evm/languages","stargazers_url":"https://api.github.com/repos/cburgdorf/py-evm/stargazers","contributors_url":"https://api.github.com/repos/cburgdorf/py-evm/contributors","subscribers_url":"https://api.github.com/repos/cburgdorf/py-evm/subscribers","subscription_url":"https://api.github.com/repos/cburgdorf/py-evm/subscription","commits_url":"https://api.github.com/repos/cburgdorf/py-evm/commits{/sha}","git_commits_url":"https://api.github.com/repos/cburgdorf/py-evm/git/commits{/sha}","comments_url":"https://api.github.com/repos/cburgdorf/py-evm/comments{/number}","issue_comment_url":"https://api.github.com/repos/cburgdorf/py-evm/issues/comments{/number}","contents_url":"https://api.github.com/repos/cburgdorf/py-evm/contents/{+path}","compare_url":"https://api.github.com/repos/cburgdorf/py-evm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cburgdorf/py-evm/merges","archive_url":"https://api.github.com/repos/cburgdorf/py-evm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cburgdorf/py-evm/downloads","issues_url":"https://api.github.com/repos/cburgdorf/py-evm/issues{/number}","pulls_url":"https://api.github.com/repos/cburgdorf/py-evm/pulls{/number}","milestones_url":"https://api.github.com/repos/cburgdorf/py-evm/milestones{/number}","notifications_url":"https://api.github.com/repos/cburgdorf/py-evm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cburgdorf/py-evm/labels{/name}","releases_url":"https://api.github.com/repos/cburgdorf/py-evm/releases{/id}","deployments_url":"https://api.github.com/repos/cburgdorf/py-evm/deployments","created_at":"2018-02-22T11:07:50Z","updated_at":"2018-03-28T15:01:32Z","pushed_at":"2018-12-10T21:24:28Z","git_url":"git://github.com/cburgdorf/py-evm.git","ssh_url":"git@github.com:cburgdorf/py-evm.git","clone_url":"https://github.com/cburgdorf/py-evm.git","svn_url":"https://github.com/cburgdorf/py-evm","homepage":"http://py-evm.readthedocs.io/en/latest/","size":8170,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"d053f8bb47710c0b847836a9b5698d1e0cf2f91a","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":77478378,"node_id":"MDEwOlJlcG9zaXRvcnk3NzQ3ODM3OA==","name":"py-evm","full_name":"ethereum/py-evm","private":false,"owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethereum/py-evm","description":"A Python implementation of the Ethereum Virtual Machine","fork":false,"url":"https://api.github.com/repos/ethereum/py-evm","forks_url":"https://api.github.com/repos/ethereum/py-evm/forks","keys_url":"https://api.github.com/repos/ethereum/py-evm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/py-evm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/py-evm/teams","hooks_url":"https://api.github.com/repos/ethereum/py-evm/hooks","issue_events_url":"https://api.github.com/repos/ethereum/py-evm/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/py-evm/events","assignees_url":"https://api.github.com/repos/ethereum/py-evm/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/py-evm/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/py-evm/tags","blobs_url":"https://api.github.com/repos/ethereum/py-evm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/py-evm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/py-evm/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/py-evm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/py-evm/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/py-evm/languages","stargazers_url":"https://api.github.com/repos/ethereum/py-evm/stargazers","contributors_url":"https://api.github.com/repos/ethereum/py-evm/contributors","subscribers_url":"https://api.github.com/repos/ethereum/py-evm/subscribers","subscription_url":"https://api.github.com/repos/ethereum/py-evm/subscription","commits_url":"https://api.github.com/repos/ethereum/py-evm/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/py-evm/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/py-evm/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/py-evm/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/py-evm/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/py-evm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/py-evm/merges","archive_url":"https://api.github.com/repos/ethereum/py-evm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/py-evm/downloads","issues_url":"https://api.github.com/repos/ethereum/py-evm/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/py-evm/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/py-evm/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/py-evm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/py-evm/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/py-evm/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/py-evm/deployments","created_at":"2016-12-27T19:36:00Z","updated_at":"2018-12-10T20:56:31Z","pushed_at":"2018-12-10T21:24:30Z","git_url":"git://github.com/ethereum/py-evm.git","ssh_url":"git@github.com:ethereum/py-evm.git","clone_url":"https://github.com/ethereum/py-evm.git","svn_url":"https://github.com/ethereum/py-evm","homepage":"https://trinity.ethereum.org/","size":6494,"stargazers_count":747,"watchers_count":747,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":332,"mirror_url":null,"archived":false,"open_issues_count":154,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":332,"open_issues":154,"watchers":747,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/py-evm/pulls/1556"},"html":{"href":"https://github.com/ethereum/py-evm/pull/1556"},"issue":{"href":"https://api.github.com/repos/ethereum/py-evm/issues/1556"},"comments":{"href":"https://api.github.com/repos/ethereum/py-evm/issues/1556/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/py-evm/pulls/1556/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/py-evm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/py-evm/pulls/1556/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/py-evm/statuses/7fbbcf342c199faafbbcbf5f469985bdcfd5fc1d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cburgdorf"}}