{"action":"created","comment":{"url":"https://api.github.com/repos/espresso-org/aragon-datastore/pulls/comments/245202033","pull_request_review_id":189261276,"id":245202033,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTIwMjAzMw==","diff_hunk":"@@ -25,13 +24,10 @@ library PermissionLibrary {\n         bytes32 FILE_READ_ROLE;\n         bytes32 FILE_WRITE_ROLE;  ","path":"contracts/libraries/PermissionLibrary.sol","position":14,"original_position":14,"commit_id":"dc18839a8b217ed1d70a61efe6bc604b945d451c","original_commit_id":"2664a42751045d19a2d3c43aa1b70088679a3afd","user":{"login":"macor161","id":642515,"node_id":"MDQ6VXNlcjY0MjUxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/642515?v=4","gravatar_id":"","url":"https://api.github.com/users/macor161","html_url":"https://github.com/macor161","followers_url":"https://api.github.com/users/macor161/followers","following_url":"https://api.github.com/users/macor161/following{/other_user}","gists_url":"https://api.github.com/users/macor161/gists{/gist_id}","starred_url":"https://api.github.com/users/macor161/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macor161/subscriptions","organizations_url":"https://api.github.com/users/macor161/orgs","repos_url":"https://api.github.com/users/macor161/repos","events_url":"https://api.github.com/users/macor161/events{/privacy}","received_events_url":"https://api.github.com/users/macor161/received_events","type":"User","site_admin":false},"body":"Good question! Usually ACL roles are defined in the main smart contract itself but these roles are strictly used with the ObjectACL, and only by the PermissionLibrary. I think it would indeed make more sense to have them in the library.","created_at":"2019-01-04T04:34:32Z","updated_at":"2019-01-04T04:34:33Z","html_url":"https://github.com/espresso-org/aragon-datastore/pull/77#discussion_r245202033","pull_request_url":"https://api.github.com/repos/espresso-org/aragon-datastore/pulls/77","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/espresso-org/aragon-datastore/pulls/comments/245202033"},"html":{"href":"https://github.com/espresso-org/aragon-datastore/pull/77#discussion_r245202033"},"pull_request":{"href":"https://api.github.com/repos/espresso-org/aragon-datastore/pulls/77"}},"in_reply_to_id":244970034},"pull_request":{"url":"https://api.github.com/repos/espresso-org/aragon-datastore/pulls/77","id":232396807,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMzk2ODA3","html_url":"https://github.com/espresso-org/aragon-datastore/pull/77","diff_url":"https://github.com/espresso-org/aragon-datastore/pull/77.diff","patch_url":"https://github.com/espresso-org/aragon-datastore/pull/77.patch","issue_url":"https://api.github.com/repos/espresso-org/aragon-datastore/issues/77","number":77,"state":"open","locked":false,"title":"Milestone 2","user":{"login":"macor161","id":642515,"node_id":"MDQ6VXNlcjY0MjUxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/642515?v=4","gravatar_id":"","url":"https://api.github.com/users/macor161","html_url":"https://github.com/macor161","followers_url":"https://api.github.com/users/macor161/followers","following_url":"https://api.github.com/users/macor161/following{/other_user}","gists_url":"https://api.github.com/users/macor161/gists{/gist_id}","starred_url":"https://api.github.com/users/macor161/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macor161/subscriptions","organizations_url":"https://api.github.com/users/macor161/orgs","repos_url":"https://api.github.com/users/macor161/repos","events_url":"https://api.github.com/users/macor161/events{/privacy}","received_events_url":"https://api.github.com/users/macor161/received_events","type":"User","site_admin":false},"body":"- File encryption\r\n- Extract ObjectACL to its own repo\r\n- Display gas usage in tests\r\n- Bytecode size script\r\n- AragonOS upgrade\r\n- Javascript library documentation\r\n- Functions to permanently delete files\r\n","created_at":"2018-11-20T17:13:37Z","updated_at":"2019-01-04T04:34:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f158dee430a5ee8edac4011236b0fabe1fcc69a6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/espresso-org/aragon-datastore/pulls/77/commits","review_comments_url":"https://api.github.com/repos/espresso-org/aragon-datastore/pulls/77/comments","review_comment_url":"https://api.github.com/repos/espresso-org/aragon-datastore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/espresso-org/aragon-datastore/issues/77/comments","statuses_url":"https://api.github.com/repos/espresso-org/aragon-datastore/statuses/dc18839a8b217ed1d70a61efe6bc604b945d451c","head":{"label":"espresso-org:dev","ref":"dev","sha":"dc18839a8b217ed1d70a61efe6bc604b945d451c","user":{"login":"espresso-org","id":42185138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMTg1MTM4","avatar_url":"https://avatars3.githubusercontent.com/u/42185138?v=4","gravatar_id":"","url":"https://api.github.com/users/espresso-org","html_url":"https://github.com/espresso-org","followers_url":"https://api.github.com/users/espresso-org/followers","following_url":"https://api.github.com/users/espresso-org/following{/other_user}","gists_url":"https://api.github.com/users/espresso-org/gists{/gist_id}","starred_url":"https://api.github.com/users/espresso-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espresso-org/subscriptions","organizations_url":"https://api.github.com/users/espresso-org/orgs","repos_url":"https://api.github.com/users/espresso-org/repos","events_url":"https://api.github.com/users/espresso-org/events{/privacy}","received_events_url":"https://api.github.com/users/espresso-org/received_events","type":"Organization","site_admin":false},"repo":{"id":137149031,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcxNDkwMzE=","name":"aragon-datastore","full_name":"espresso-org/aragon-datastore","private":false,"owner":{"login":"espresso-org","id":42185138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMTg1MTM4","avatar_url":"https://avatars3.githubusercontent.com/u/42185138?v=4","gravatar_id":"","url":"https://api.github.com/users/espresso-org","html_url":"https://github.com/espresso-org","followers_url":"https://api.github.com/users/espresso-org/followers","following_url":"https://api.github.com/users/espresso-org/following{/other_user}","gists_url":"https://api.github.com/users/espresso-org/gists{/gist_id}","starred_url":"https://api.github.com/users/espresso-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espresso-org/subscriptions","organizations_url":"https://api.github.com/users/espresso-org/orgs","repos_url":"https://api.github.com/users/espresso-org/repos","events_url":"https://api.github.com/users/espresso-org/events{/privacy}","received_events_url":"https://api.github.com/users/espresso-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/espresso-org/aragon-datastore","description":"Decentrally store files and manage their permissions","fork":false,"url":"https://api.github.com/repos/espresso-org/aragon-datastore","forks_url":"https://api.github.com/repos/espresso-org/aragon-datastore/forks","keys_url":"https://api.github.com/repos/espresso-org/aragon-datastore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/espresso-org/aragon-datastore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/espresso-org/aragon-datastore/teams","hooks_url":"https://api.github.com/repos/espresso-org/aragon-datastore/hooks","issue_events_url":"https://api.github.com/repos/espresso-org/aragon-datastore/issues/events{/number}","events_url":"https://api.github.com/repos/espresso-org/aragon-datastore/events","assignees_url":"https://api.github.com/repos/espresso-org/aragon-datastore/assignees{/user}","branches_url":"https://api.github.com/repos/espresso-org/aragon-datastore/branches{/branch}","tags_url":"https://api.github.com/repos/espresso-org/aragon-datastore/tags","blobs_url":"https://api.github.com/repos/espresso-org/aragon-datastore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/espresso-org/aragon-datastore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/espresso-org/aragon-datastore/git/refs{/sha}","trees_url":"https://api.github.com/repos/espresso-org/aragon-datastore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/espresso-org/aragon-datastore/statuses/{sha}","languages_url":"https://api.github.com/repos/espresso-org/aragon-datastore/languages","stargazers_url":"https://api.github.com/repos/espresso-org/aragon-datastore/stargazers","contributors_url":"https://api.github.com/repos/espresso-org/aragon-datastore/contributors","subscribers_url":"https://api.github.com/repos/espresso-org/aragon-datastore/subscribers","subscription_url":"https://api.github.com/repos/espresso-org/aragon-datastore/subscription","commits_url":"https://api.github.com/repos/espresso-org/aragon-datastore/commits{/sha}","git_commits_url":"https://api.github.com/repos/espresso-org/aragon-datastore/git/commits{/sha}","comments_url":"https://api.github.com/repos/espresso-org/aragon-datastore/comments{/number}","issue_comment_url":"https://api.github.com/repos/espresso-org/aragon-datastore/issues/comments{/number}","contents_url":"https://api.github.com/repos/espresso-org/aragon-datastore/contents/{+path}","compare_url":"https://api.github.com/repos/espresso-org/aragon-datastore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/espresso-org/aragon-datastore/merges","archive_url":"https://api.github.com/repos/espresso-org/aragon-datastore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/espresso-org/aragon-datastore/downloads","issues_url":"https://api.github.com/repos/espresso-org/aragon-datastore/issues{/number}","pulls_url":"https://api.github.com/repos/espresso-org/aragon-datastore/pulls{/number}","milestones_url":"https://api.github.com/repos/espresso-org/aragon-datastore/milestones{/number}","notifications_url":"https://api.github.com/repos/espresso-org/aragon-datastore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/espresso-org/aragon-datastore/labels{/name}","releases_url":"https://api.github.com/repos/espresso-org/aragon-datastore/releases{/id}","deployments_url":"https://api.github.com/repos/espresso-org/aragon-datastore/deployments","created_at":"2018-06-13T01:57:31Z","updated_at":"2019-01-03T18:22:54Z","pushed_at":"2019-01-03T21:54:21Z","git_url":"git://github.com/espresso-org/aragon-datastore.git","ssh_url":"git@github.com:espresso-org/aragon-datastore.git","clone_url":"https://github.com/espresso-org/aragon-datastore.git","svn_url":"https://github.com/espresso-org/aragon-datastore","homepage":null,"size":955,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":13,"watchers":10,"default_branch":"development"}},"base":{"label":"espresso-org:master","ref":"master","sha":"ef3f54cf0ab88868baf23135ed1089ffe7c4248e","user":{"login":"espresso-org","id":42185138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMTg1MTM4","avatar_url":"https://avatars3.githubusercontent.com/u/42185138?v=4","gravatar_id":"","url":"https://api.github.com/users/espresso-org","html_url":"https://github.com/espresso-org","followers_url":"https://api.github.com/users/espresso-org/followers","following_url":"https://api.github.com/users/espresso-org/following{/other_user}","gists_url":"https://api.github.com/users/espresso-org/gists{/gist_id}","starred_url":"https://api.github.com/users/espresso-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espresso-org/subscriptions","organizations_url":"https://api.github.com/users/espresso-org/orgs","repos_url":"https://api.github.com/users/espresso-org/repos","events_url":"https://api.github.com/users/espresso-org/events{/privacy}","received_events_url":"https://api.github.com/users/espresso-org/received_events","type":"Organization","site_admin":false},"repo":{"id":137149031,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcxNDkwMzE=","name":"aragon-datastore","full_name":"espresso-org/aragon-datastore","private":false,"owner":{"login":"espresso-org","id":42185138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMTg1MTM4","avatar_url":"https://avatars3.githubusercontent.com/u/42185138?v=4","gravatar_id":"","url":"https://api.github.com/users/espresso-org","html_url":"https://github.com/espresso-org","followers_url":"https://api.github.com/users/espresso-org/followers","following_url":"https://api.github.com/users/espresso-org/following{/other_user}","gists_url":"https://api.github.com/users/espresso-org/gists{/gist_id}","starred_url":"https://api.github.com/users/espresso-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espresso-org/subscriptions","organizations_url":"https://api.github.com/users/espresso-org/orgs","repos_url":"https://api.github.com/users/espresso-org/repos","events_url":"https://api.github.com/users/espresso-org/events{/privacy}","received_events_url":"https://api.github.com/users/espresso-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/espresso-org/aragon-datastore","description":"Decentrally store files and manage their permissions","fork":false,"url":"https://api.github.com/repos/espresso-org/aragon-datastore","forks_url":"https://api.github.com/repos/espresso-org/aragon-datastore/forks","keys_url":"https://api.github.com/repos/espresso-org/aragon-datastore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/espresso-org/aragon-datastore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/espresso-org/aragon-datastore/teams","hooks_url":"https://api.github.com/repos/espresso-org/aragon-datastore/hooks","issue_events_url":"https://api.github.com/repos/espresso-org/aragon-datastore/issues/events{/number}","events_url":"https://api.github.com/repos/espresso-org/aragon-datastore/events","assignees_url":"https://api.github.com/repos/espresso-org/aragon-datastore/assignees{/user}","branches_url":"https://api.github.com/repos/espresso-org/aragon-datastore/branches{/branch}","tags_url":"https://api.github.com/repos/espresso-org/aragon-datastore/tags","blobs_url":"https://api.github.com/repos/espresso-org/aragon-datastore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/espresso-org/aragon-datastore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/espresso-org/aragon-datastore/git/refs{/sha}","trees_url":"https://api.github.com/repos/espresso-org/aragon-datastore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/espresso-org/aragon-datastore/statuses/{sha}","languages_url":"https://api.github.com/repos/espresso-org/aragon-datastore/languages","stargazers_url":"https://api.github.com/repos/espresso-org/aragon-datastore/stargazers","contributors_url":"https://api.github.com/repos/espresso-org/aragon-datastore/contributors","subscribers_url":"https://api.github.com/repos/espresso-org/aragon-datastore/subscribers","subscription_url":"https://api.github.com/repos/espresso-org/aragon-datastore/subscription","commits_url":"https://api.github.com/repos/espresso-org/aragon-datastore/commits{/sha}","git_commits_url":"https://api.github.com/repos/espresso-org/aragon-datastore/git/commits{/sha}","comments_url":"https://api.github.com/repos/espresso-org/aragon-datastore/comments{/number}","issue_comment_url":"https://api.github.com/repos/espresso-org/aragon-datastore/issues/comments{/number}","contents_url":"https://api.github.com/repos/espresso-org/aragon-datastore/contents/{+path}","compare_url":"https://api.github.com/repos/espresso-org/aragon-datastore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/espresso-org/aragon-datastore/merges","archive_url":"https://api.github.com/repos/espresso-org/aragon-datastore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/espresso-org/aragon-datastore/downloads","issues_url":"https://api.github.com/repos/espresso-org/aragon-datastore/issues{/number}","pulls_url":"https://api.github.com/repos/espresso-org/aragon-datastore/pulls{/number}","milestones_url":"https://api.github.com/repos/espresso-org/aragon-datastore/milestones{/number}","notifications_url":"https://api.github.com/repos/espresso-org/aragon-datastore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/espresso-org/aragon-datastore/labels{/name}","releases_url":"https://api.github.com/repos/espresso-org/aragon-datastore/releases{/id}","deployments_url":"https://api.github.com/repos/espresso-org/aragon-datastore/deployments","created_at":"2018-06-13T01:57:31Z","updated_at":"2019-01-03T18:22:54Z","pushed_at":"2019-01-03T21:54:21Z","git_url":"git://github.com/espresso-org/aragon-datastore.git","ssh_url":"git@github.com:espresso-org/aragon-datastore.git","clone_url":"https://github.com/espresso-org/aragon-datastore.git","svn_url":"https://github.com/espresso-org/aragon-datastore","homepage":null,"size":955,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":13,"watchers":10,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/espresso-org/aragon-datastore/pulls/77"},"html":{"href":"https://github.com/espresso-org/aragon-datastore/pull/77"},"issue":{"href":"https://api.github.com/repos/espresso-org/aragon-datastore/issues/77"},"comments":{"href":"https://api.github.com/repos/espresso-org/aragon-datastore/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/espresso-org/aragon-datastore/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/espresso-org/aragon-datastore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/espresso-org/aragon-datastore/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/espresso-org/aragon-datastore/statuses/dc18839a8b217ed1d70a61efe6bc604b945d451c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"macor161"}}