{"action":"created","comment":{"url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/pulls/comments/174948390","pull_request_review_id":104399113,"id":174948390,"diff_hunk":"@@ -14,7 +14,8 @@\n     url_for, pagination_links, display_list, get_valid_page_or_1,\n     validate_and_return_updater_request, get_int_or_400\n )\n-\n+from datetime import datetime\n+from pendulum import Date","path":"app/main/views/services.py","position":6,"original_position":6,"commit_id":"28fe70491f6e07aeab80c90d7bfc26f5f3d61df8","original_commit_id":"28fe70491f6e07aeab80c90d7bfc26f5f3d61df8","user":{"login":"ndavison","id":1152676,"avatar_url":"https://avatars1.githubusercontent.com/u/1152676?v=4","gravatar_id":"","url":"https://api.github.com/users/ndavison","html_url":"https://github.com/ndavison","followers_url":"https://api.github.com/users/ndavison/followers","following_url":"https://api.github.com/users/ndavison/following{/other_user}","gists_url":"https://api.github.com/users/ndavison/gists{/gist_id}","starred_url":"https://api.github.com/users/ndavison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndavison/subscriptions","organizations_url":"https://api.github.com/users/ndavison/orgs","repos_url":"https://api.github.com/users/ndavison/repos","events_url":"https://api.github.com/users/ndavison/events{/privacy}","received_events_url":"https://api.github.com/users/ndavison/received_events","type":"User","site_admin":false},"body":"Most of the examples in the Pendulum docs seem to prefer `import pendulum` and using `pendulum` directly for `.today()`, `.tomorrow()` etc.\r\n\r\nAlso, `isinstance(pendulum.utcnow(), datetime) === True` so you probably don't need `datetime` at all - e.g. `pendulum.utcnow()` could replace the `datetime.utcnow()` uses.","created_at":"2018-03-15T22:11:30Z","updated_at":"2018-03-15T22:11:40Z","html_url":"https://github.com/AusDTO/dto-digitalmarketplace-api/pull/428#discussion_r174948390","pull_request_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/pulls/428","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/pulls/comments/174948390"},"html":{"href":"https://github.com/AusDTO/dto-digitalmarketplace-api/pull/428#discussion_r174948390"},"pull_request":{"href":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/pulls/428"}}},"pull_request":{"url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/pulls/428","id":175153182,"html_url":"https://github.com/AusDTO/dto-digitalmarketplace-api/pull/428","diff_url":"https://github.com/AusDTO/dto-digitalmarketplace-api/pull/428.diff","patch_url":"https://github.com/AusDTO/dto-digitalmarketplace-api/pull/428.patch","issue_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/issues/428","number":428,"state":"open","locked":false,"title":"[MAR-1537] Update orams prices importer to allow for updating","user":{"login":"malmas18","id":29763502,"avatar_url":"https://avatars1.githubusercontent.com/u/29763502?v=4","gravatar_id":"","url":"https://api.github.com/users/malmas18","html_url":"https://github.com/malmas18","followers_url":"https://api.github.com/users/malmas18/followers","following_url":"https://api.github.com/users/malmas18/following{/other_user}","gists_url":"https://api.github.com/users/malmas18/gists{/gist_id}","starred_url":"https://api.github.com/users/malmas18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malmas18/subscriptions","organizations_url":"https://api.github.com/users/malmas18/orgs","repos_url":"https://api.github.com/users/malmas18/repos","events_url":"https://api.github.com/users/malmas18/events{/privacy}","received_events_url":"https://api.github.com/users/malmas18/received_events","type":"User","site_admin":false},"body":"i've split the test_services.py to separate files.\r\n\r\ntwo new test files are:\r\ntests/app/test_services/test_add_service_type_price_ceilings.py\r\ntests/app/test_services/test_add_service_type_price.py\r\n\r\nthe rest are copied from test_services.py","created_at":"2018-03-15T05:37:50Z","updated_at":"2018-03-15T22:11:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de30d0aac9f01a6616f1b0f058974d4a04ecbc0e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tobiasbrown","id":2645932,"avatar_url":"https://avatars0.githubusercontent.com/u/2645932?v=4","gravatar_id":"","url":"https://api.github.com/users/tobiasbrown","html_url":"https://github.com/tobiasbrown","followers_url":"https://api.github.com/users/tobiasbrown/followers","following_url":"https://api.github.com/users/tobiasbrown/following{/other_user}","gists_url":"https://api.github.com/users/tobiasbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/tobiasbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobiasbrown/subscriptions","organizations_url":"https://api.github.com/users/tobiasbrown/orgs","repos_url":"https://api.github.com/users/tobiasbrown/repos","events_url":"https://api.github.com/users/tobiasbrown/events{/privacy}","received_events_url":"https://api.github.com/users/tobiasbrown/received_events","type":"User","site_admin":false},{"login":"matt-sm","id":4606363,"avatar_url":"https://avatars1.githubusercontent.com/u/4606363?v=4","gravatar_id":"","url":"https://api.github.com/users/matt-sm","html_url":"https://github.com/matt-sm","followers_url":"https://api.github.com/users/matt-sm/followers","following_url":"https://api.github.com/users/matt-sm/following{/other_user}","gists_url":"https://api.github.com/users/matt-sm/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-sm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-sm/subscriptions","organizations_url":"https://api.github.com/users/matt-sm/orgs","repos_url":"https://api.github.com/users/matt-sm/repos","events_url":"https://api.github.com/users/matt-sm/events{/privacy}","received_events_url":"https://api.github.com/users/matt-sm/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/pulls/428/commits","review_comments_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/pulls/428/comments","review_comment_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/issues/428/comments","statuses_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/statuses/28fe70491f6e07aeab80c90d7bfc26f5f3d61df8","head":{"label":"AusDTO:mar-1537","ref":"mar-1537","sha":"28fe70491f6e07aeab80c90d7bfc26f5f3d61df8","user":{"login":"AusDTO","id":11763427,"avatar_url":"https://avatars3.githubusercontent.com/u/11763427?v=4","gravatar_id":"","url":"https://api.github.com/users/AusDTO","html_url":"https://github.com/AusDTO","followers_url":"https://api.github.com/users/AusDTO/followers","following_url":"https://api.github.com/users/AusDTO/following{/other_user}","gists_url":"https://api.github.com/users/AusDTO/gists{/gist_id}","starred_url":"https://api.github.com/users/AusDTO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AusDTO/subscriptions","organizations_url":"https://api.github.com/users/AusDTO/orgs","repos_url":"https://api.github.com/users/AusDTO/repos","events_url":"https://api.github.com/users/AusDTO/events{/privacy}","received_events_url":"https://api.github.com/users/AusDTO/received_events","type":"Organization","site_admin":false},"repo":{"id":62025672,"name":"dto-digitalmarketplace-api","full_name":"AusDTO/dto-digitalmarketplace-api","owner":{"login":"AusDTO","id":11763427,"avatar_url":"https://avatars3.githubusercontent.com/u/11763427?v=4","gravatar_id":"","url":"https://api.github.com/users/AusDTO","html_url":"https://github.com/AusDTO","followers_url":"https://api.github.com/users/AusDTO/followers","following_url":"https://api.github.com/users/AusDTO/following{/other_user}","gists_url":"https://api.github.com/users/AusDTO/gists{/gist_id}","starred_url":"https://api.github.com/users/AusDTO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AusDTO/subscriptions","organizations_url":"https://api.github.com/users/AusDTO/orgs","repos_url":"https://api.github.com/users/AusDTO/repos","events_url":"https://api.github.com/users/AusDTO/events{/privacy}","received_events_url":"https://api.github.com/users/AusDTO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AusDTO/dto-digitalmarketplace-api","description":"Digital Marketplace API.","fork":true,"url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api","forks_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/forks","keys_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/teams","hooks_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/hooks","issue_events_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/issues/events{/number}","events_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/events","assignees_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/assignees{/user}","branches_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/branches{/branch}","tags_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/tags","blobs_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/statuses/{sha}","languages_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/languages","stargazers_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/stargazers","contributors_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/contributors","subscribers_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/subscribers","subscription_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/subscription","commits_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/contents/{+path}","compare_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/merges","archive_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/downloads","issues_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/issues{/number}","pulls_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/pulls{/number}","milestones_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/milestones{/number}","notifications_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/labels{/name}","releases_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/releases{/id}","deployments_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/deployments","created_at":"2016-06-27T04:34:37Z","updated_at":"2018-03-15T02:21:23Z","pushed_at":"2018-03-15T06:20:02Z","git_url":"git://github.com/AusDTO/dto-digitalmarketplace-api.git","ssh_url":"git@github.com:AusDTO/dto-digitalmarketplace-api.git","clone_url":"https://github.com/AusDTO/dto-digitalmarketplace-api.git","svn_url":"https://github.com/AusDTO/dto-digitalmarketplace-api","homepage":null,"size":3338,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":3,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"AusDTO:master","ref":"master","sha":"f990ab881929bf4defceff83c6d7e7b7d6fde797","user":{"login":"AusDTO","id":11763427,"avatar_url":"https://avatars3.githubusercontent.com/u/11763427?v=4","gravatar_id":"","url":"https://api.github.com/users/AusDTO","html_url":"https://github.com/AusDTO","followers_url":"https://api.github.com/users/AusDTO/followers","following_url":"https://api.github.com/users/AusDTO/following{/other_user}","gists_url":"https://api.github.com/users/AusDTO/gists{/gist_id}","starred_url":"https://api.github.com/users/AusDTO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AusDTO/subscriptions","organizations_url":"https://api.github.com/users/AusDTO/orgs","repos_url":"https://api.github.com/users/AusDTO/repos","events_url":"https://api.github.com/users/AusDTO/events{/privacy}","received_events_url":"https://api.github.com/users/AusDTO/received_events","type":"Organization","site_admin":false},"repo":{"id":62025672,"name":"dto-digitalmarketplace-api","full_name":"AusDTO/dto-digitalmarketplace-api","owner":{"login":"AusDTO","id":11763427,"avatar_url":"https://avatars3.githubusercontent.com/u/11763427?v=4","gravatar_id":"","url":"https://api.github.com/users/AusDTO","html_url":"https://github.com/AusDTO","followers_url":"https://api.github.com/users/AusDTO/followers","following_url":"https://api.github.com/users/AusDTO/following{/other_user}","gists_url":"https://api.github.com/users/AusDTO/gists{/gist_id}","starred_url":"https://api.github.com/users/AusDTO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AusDTO/subscriptions","organizations_url":"https://api.github.com/users/AusDTO/orgs","repos_url":"https://api.github.com/users/AusDTO/repos","events_url":"https://api.github.com/users/AusDTO/events{/privacy}","received_events_url":"https://api.github.com/users/AusDTO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AusDTO/dto-digitalmarketplace-api","description":"Digital Marketplace API.","fork":true,"url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api","forks_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/forks","keys_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/teams","hooks_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/hooks","issue_events_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/issues/events{/number}","events_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/events","assignees_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/assignees{/user}","branches_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/branches{/branch}","tags_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/tags","blobs_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/statuses/{sha}","languages_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/languages","stargazers_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/stargazers","contributors_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/contributors","subscribers_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/subscribers","subscription_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/subscription","commits_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/contents/{+path}","compare_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/merges","archive_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/downloads","issues_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/issues{/number}","pulls_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/pulls{/number}","milestones_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/milestones{/number}","notifications_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/labels{/name}","releases_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/releases{/id}","deployments_url":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/deployments","created_at":"2016-06-27T04:34:37Z","updated_at":"2018-03-15T02:21:23Z","pushed_at":"2018-03-15T06:20:02Z","git_url":"git://github.com/AusDTO/dto-digitalmarketplace-api.git","ssh_url":"git@github.com:AusDTO/dto-digitalmarketplace-api.git","clone_url":"https://github.com/AusDTO/dto-digitalmarketplace-api.git","svn_url":"https://github.com/AusDTO/dto-digitalmarketplace-api","homepage":null,"size":3338,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":3,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/pulls/428"},"html":{"href":"https://github.com/AusDTO/dto-digitalmarketplace-api/pull/428"},"issue":{"href":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/issues/428"},"comments":{"href":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/issues/428/comments"},"review_comments":{"href":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/pulls/428/comments"},"review_comment":{"href":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/pulls/428/commits"},"statuses":{"href":"https://api.github.com/repos/AusDTO/dto-digitalmarketplace-api/statuses/28fe70491f6e07aeab80c90d7bfc26f5f3d61df8"}},"author_association":"NONE"}}
{"actor":{"display_login":"ndavison"}}