{"action":"created","comment":{"url":"https://api.github.com/repos/python/mypy/pulls/comments/209732130","pull_request_review_id":145803472,"id":209732130,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTczMjEzMA==","diff_hunk":"@@ -141,6 +141,8 @@ def visit_deleted_type(self, left: DeletedType) -> bool:\n \n     def visit_instance(self, left: Instance) -> bool:\n         if left.type.fallback_to_any:\n+            if isinstance(self.right, NoneTyp):","path":"mypy/subtypes.py","position":4,"original_position":4,"commit_id":"85426481b75c170c49a652753f0750b814981168","original_commit_id":"85426481b75c170c49a652753f0750b814981168","user":{"login":"ilevkivskyi","id":12005495,"node_id":"MDQ6VXNlcjEyMDA1NDk1","avatar_url":"https://avatars1.githubusercontent.com/u/12005495?v=4","gravatar_id":"","url":"https://api.github.com/users/ilevkivskyi","html_url":"https://github.com/ilevkivskyi","followers_url":"https://api.github.com/users/ilevkivskyi/followers","following_url":"https://api.github.com/users/ilevkivskyi/following{/other_user}","gists_url":"https://api.github.com/users/ilevkivskyi/gists{/gist_id}","starred_url":"https://api.github.com/users/ilevkivskyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilevkivskyi/subscriptions","organizations_url":"https://api.github.com/users/ilevkivskyi/orgs","repos_url":"https://api.github.com/users/ilevkivskyi/repos","events_url":"https://api.github.com/users/ilevkivskyi/events{/privacy}","received_events_url":"https://api.github.com/users/ilevkivskyi/received_events","type":"User","site_admin":false},"body":"Makes sense, will add a comment.","created_at":"2018-08-13T19:35:58Z","updated_at":"2018-08-13T19:35:58Z","html_url":"https://github.com/python/mypy/pull/5458#discussion_r209732130","pull_request_url":"https://api.github.com/repos/python/mypy/pulls/5458","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/python/mypy/pulls/comments/209732130"},"html":{"href":"https://github.com/python/mypy/pull/5458#discussion_r209732130"},"pull_request":{"href":"https://api.github.com/repos/python/mypy/pulls/5458"}},"in_reply_to_id":209715298},"pull_request":{"url":"https://api.github.com/repos/python/mypy/pulls/5458","id":207817051,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3ODE3MDUx","html_url":"https://github.com/python/mypy/pull/5458","diff_url":"https://github.com/python/mypy/pull/5458.diff","patch_url":"https://github.com/python/mypy/pull/5458.patch","issue_url":"https://api.github.com/repos/python/mypy/issues/5458","number":5458,"state":"open","locked":false,"title":"Fix descriptor access for dynamic base classes","user":{"login":"ilevkivskyi","id":12005495,"node_id":"MDQ6VXNlcjEyMDA1NDk1","avatar_url":"https://avatars1.githubusercontent.com/u/12005495?v=4","gravatar_id":"","url":"https://api.github.com/users/ilevkivskyi","html_url":"https://github.com/ilevkivskyi","followers_url":"https://api.github.com/users/ilevkivskyi/followers","following_url":"https://api.github.com/users/ilevkivskyi/following{/other_user}","gists_url":"https://api.github.com/users/ilevkivskyi/gists{/gist_id}","starred_url":"https://api.github.com/users/ilevkivskyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilevkivskyi/subscriptions","organizations_url":"https://api.github.com/users/ilevkivskyi/orgs","repos_url":"https://api.github.com/users/ilevkivskyi/repos","events_url":"https://api.github.com/users/ilevkivskyi/events{/privacy}","received_events_url":"https://api.github.com/users/ilevkivskyi/received_events","type":"User","site_admin":false},"body":"Fixes #5456 ","created_at":"2018-08-12T11:35:39Z","updated_at":"2018-08-13T19:35:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c36794819ee0047ae130a30665d46e343019e353","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/python/mypy/pulls/5458/commits","review_comments_url":"https://api.github.com/repos/python/mypy/pulls/5458/comments","review_comment_url":"https://api.github.com/repos/python/mypy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python/mypy/issues/5458/comments","statuses_url":"https://api.github.com/repos/python/mypy/statuses/85426481b75c170c49a652753f0750b814981168","head":{"label":"ilevkivskyi:non-any-fallback","ref":"non-any-fallback","sha":"85426481b75c170c49a652753f0750b814981168","user":{"login":"ilevkivskyi","id":12005495,"node_id":"MDQ6VXNlcjEyMDA1NDk1","avatar_url":"https://avatars1.githubusercontent.com/u/12005495?v=4","gravatar_id":"","url":"https://api.github.com/users/ilevkivskyi","html_url":"https://github.com/ilevkivskyi","followers_url":"https://api.github.com/users/ilevkivskyi/followers","following_url":"https://api.github.com/users/ilevkivskyi/following{/other_user}","gists_url":"https://api.github.com/users/ilevkivskyi/gists{/gist_id}","starred_url":"https://api.github.com/users/ilevkivskyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilevkivskyi/subscriptions","organizations_url":"https://api.github.com/users/ilevkivskyi/orgs","repos_url":"https://api.github.com/users/ilevkivskyi/repos","events_url":"https://api.github.com/users/ilevkivskyi/events{/privacy}","received_events_url":"https://api.github.com/users/ilevkivskyi/received_events","type":"User","site_admin":false},"repo":{"id":55439770,"node_id":"MDEwOlJlcG9zaXRvcnk1NTQzOTc3MA==","name":"mypy","full_name":"ilevkivskyi/mypy","owner":{"login":"ilevkivskyi","id":12005495,"node_id":"MDQ6VXNlcjEyMDA1NDk1","avatar_url":"https://avatars1.githubusercontent.com/u/12005495?v=4","gravatar_id":"","url":"https://api.github.com/users/ilevkivskyi","html_url":"https://github.com/ilevkivskyi","followers_url":"https://api.github.com/users/ilevkivskyi/followers","following_url":"https://api.github.com/users/ilevkivskyi/following{/other_user}","gists_url":"https://api.github.com/users/ilevkivskyi/gists{/gist_id}","starred_url":"https://api.github.com/users/ilevkivskyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilevkivskyi/subscriptions","organizations_url":"https://api.github.com/users/ilevkivskyi/orgs","repos_url":"https://api.github.com/users/ilevkivskyi/repos","events_url":"https://api.github.com/users/ilevkivskyi/events{/privacy}","received_events_url":"https://api.github.com/users/ilevkivskyi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ilevkivskyi/mypy","description":"Optional static typing for Python","fork":true,"url":"https://api.github.com/repos/ilevkivskyi/mypy","forks_url":"https://api.github.com/repos/ilevkivskyi/mypy/forks","keys_url":"https://api.github.com/repos/ilevkivskyi/mypy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ilevkivskyi/mypy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ilevkivskyi/mypy/teams","hooks_url":"https://api.github.com/repos/ilevkivskyi/mypy/hooks","issue_events_url":"https://api.github.com/repos/ilevkivskyi/mypy/issues/events{/number}","events_url":"https://api.github.com/repos/ilevkivskyi/mypy/events","assignees_url":"https://api.github.com/repos/ilevkivskyi/mypy/assignees{/user}","branches_url":"https://api.github.com/repos/ilevkivskyi/mypy/branches{/branch}","tags_url":"https://api.github.com/repos/ilevkivskyi/mypy/tags","blobs_url":"https://api.github.com/repos/ilevkivskyi/mypy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ilevkivskyi/mypy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ilevkivskyi/mypy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ilevkivskyi/mypy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ilevkivskyi/mypy/statuses/{sha}","languages_url":"https://api.github.com/repos/ilevkivskyi/mypy/languages","stargazers_url":"https://api.github.com/repos/ilevkivskyi/mypy/stargazers","contributors_url":"https://api.github.com/repos/ilevkivskyi/mypy/contributors","subscribers_url":"https://api.github.com/repos/ilevkivskyi/mypy/subscribers","subscription_url":"https://api.github.com/repos/ilevkivskyi/mypy/subscription","commits_url":"https://api.github.com/repos/ilevkivskyi/mypy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ilevkivskyi/mypy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ilevkivskyi/mypy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ilevkivskyi/mypy/issues/comments{/number}","contents_url":"https://api.github.com/repos/ilevkivskyi/mypy/contents/{+path}","compare_url":"https://api.github.com/repos/ilevkivskyi/mypy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ilevkivskyi/mypy/merges","archive_url":"https://api.github.com/repos/ilevkivskyi/mypy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ilevkivskyi/mypy/downloads","issues_url":"https://api.github.com/repos/ilevkivskyi/mypy/issues{/number}","pulls_url":"https://api.github.com/repos/ilevkivskyi/mypy/pulls{/number}","milestones_url":"https://api.github.com/repos/ilevkivskyi/mypy/milestones{/number}","notifications_url":"https://api.github.com/repos/ilevkivskyi/mypy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ilevkivskyi/mypy/labels{/name}","releases_url":"https://api.github.com/repos/ilevkivskyi/mypy/releases{/id}","deployments_url":"https://api.github.com/repos/ilevkivskyi/mypy/deployments","created_at":"2016-04-04T19:45:28Z","updated_at":"2018-06-09T17:35:02Z","pushed_at":"2018-08-13T16:40:45Z","git_url":"git://github.com/ilevkivskyi/mypy.git","ssh_url":"git@github.com:ilevkivskyi/mypy.git","clone_url":"https://github.com/ilevkivskyi/mypy.git","svn_url":"https://github.com/ilevkivskyi/mypy","homepage":"http://www.mypy-lang.org/","size":27996,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"python:master","ref":"master","sha":"acfcfc612a74501d94b10d69f2e3ac3493309f47","user":{"login":"python","id":1525981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjU5ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"repo":{"id":7053637,"node_id":"MDEwOlJlcG9zaXRvcnk3MDUzNjM3","name":"mypy","full_name":"python/mypy","owner":{"login":"python","id":1525981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjU5ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python/mypy","description":"Optional static typing for Python 2 and 3 (PEP 484)","fork":false,"url":"https://api.github.com/repos/python/mypy","forks_url":"https://api.github.com/repos/python/mypy/forks","keys_url":"https://api.github.com/repos/python/mypy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/mypy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/mypy/teams","hooks_url":"https://api.github.com/repos/python/mypy/hooks","issue_events_url":"https://api.github.com/repos/python/mypy/issues/events{/number}","events_url":"https://api.github.com/repos/python/mypy/events","assignees_url":"https://api.github.com/repos/python/mypy/assignees{/user}","branches_url":"https://api.github.com/repos/python/mypy/branches{/branch}","tags_url":"https://api.github.com/repos/python/mypy/tags","blobs_url":"https://api.github.com/repos/python/mypy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/mypy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/mypy/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/mypy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/mypy/statuses/{sha}","languages_url":"https://api.github.com/repos/python/mypy/languages","stargazers_url":"https://api.github.com/repos/python/mypy/stargazers","contributors_url":"https://api.github.com/repos/python/mypy/contributors","subscribers_url":"https://api.github.com/repos/python/mypy/subscribers","subscription_url":"https://api.github.com/repos/python/mypy/subscription","commits_url":"https://api.github.com/repos/python/mypy/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/mypy/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/mypy/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/mypy/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/mypy/contents/{+path}","compare_url":"https://api.github.com/repos/python/mypy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/mypy/merges","archive_url":"https://api.github.com/repos/python/mypy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/mypy/downloads","issues_url":"https://api.github.com/repos/python/mypy/issues{/number}","pulls_url":"https://api.github.com/repos/python/mypy/pulls{/number}","milestones_url":"https://api.github.com/repos/python/mypy/milestones{/number}","notifications_url":"https://api.github.com/repos/python/mypy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/mypy/labels{/name}","releases_url":"https://api.github.com/repos/python/mypy/releases{/id}","deployments_url":"https://api.github.com/repos/python/mypy/deployments","created_at":"2012-12-07T13:30:23Z","updated_at":"2018-08-13T12:44:50Z","pushed_at":"2018-08-13T16:42:52Z","git_url":"git://github.com/python/mypy.git","ssh_url":"git@github.com:python/mypy.git","clone_url":"https://github.com/python/mypy.git","svn_url":"https://github.com/python/mypy","homepage":"http://www.mypy-lang.org/","size":27241,"stargazers_count":4341,"watchers_count":4341,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":592,"mirror_url":null,"archived":false,"open_issues_count":865,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":592,"open_issues":865,"watchers":4341,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python/mypy/pulls/5458"},"html":{"href":"https://github.com/python/mypy/pull/5458"},"issue":{"href":"https://api.github.com/repos/python/mypy/issues/5458"},"comments":{"href":"https://api.github.com/repos/python/mypy/issues/5458/comments"},"review_comments":{"href":"https://api.github.com/repos/python/mypy/pulls/5458/comments"},"review_comment":{"href":"https://api.github.com/repos/python/mypy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python/mypy/pulls/5458/commits"},"statuses":{"href":"https://api.github.com/repos/python/mypy/statuses/85426481b75c170c49a652753f0750b814981168"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ilevkivskyi"}}