{"action":"closed","number":7869,"pull_request":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/7869","id":213716667,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNzE2NjY3","html_url":"https://github.com/zfsonlinux/zfs/pull/7869","diff_url":"https://github.com/zfsonlinux/zfs/pull/7869.diff","patch_url":"https://github.com/zfsonlinux/zfs/pull/7869.patch","issue_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/7869","number":7869,"state":"closed","locked":false,"title":"Fix zfs_sysfs_live test failure","user":{"login":"don-brady","id":12415697,"node_id":"MDQ6VXNlcjEyNDE1Njk3","avatar_url":"https://avatars1.githubusercontent.com/u/12415697?v=4","gravatar_id":"","url":"https://api.github.com/users/don-brady","html_url":"https://github.com/don-brady","followers_url":"https://api.github.com/users/don-brady/followers","following_url":"https://api.github.com/users/don-brady/following{/other_user}","gists_url":"https://api.github.com/users/don-brady/gists{/gist_id}","starred_url":"https://api.github.com/users/don-brady/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/don-brady/subscriptions","organizations_url":"https://api.github.com/users/don-brady/orgs","repos_url":"https://api.github.com/users/don-brady/repos","events_url":"https://api.github.com/users/don-brady/events{/privacy}","received_events_url":"https://api.github.com/users/don-brady/received_events","type":"User","site_admin":false},"body":"### Motivation and Context\r\nThe ZTS `zfs_sysfs_live` test fails occasionally due to an unitialized string on an error path.\r\n\r\n### Description\r\n The fix checks for an error to make sure the string is always initialized.\r\n\r\n### How Has This Been Tested?\r\nrun the ZTS for  zfs_sysfs set of tests\r\nmanually check the zfs module sysfs property values\r\n\r\n### Types of changes\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Performance enhancement (non-breaking change which improves efficiency)\r\n- [ ] Code cleanup (non-breaking change which makes code smaller or more readable)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n- [ ] Documentation (a change to man pages or other documentation)\r\n\r\n### Checklist:\r\n- [x] My code follows the ZFS on Linux [code style requirements](https://github.com/zfsonlinux/zfs/blob/master/.github/CONTRIBUTING.md#coding-conventions).\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the [**contributing** document](https://github.com/zfsonlinux/zfs/blob/master/.github/CONTRIBUTING.md).\r\n- [ ] I have added [tests](https://github.com/zfsonlinux/zfs/tree/master/tests) to cover my changes.\r\n- [x] All new and existing tests passed.\r\n- [x] All commit messages are properly formatted and contain [`Signed-off-by`](https://github.com/zfsonlinux/zfs/blob/master/.github/CONTRIBUTING.md#signed-off-by).\r\n- [ ] Change has been approved by a ZFS on Linux member.\r\n","created_at":"2018-09-06T18:56:04Z","updated_at":"2018-09-07T00:36:01Z","closed_at":"2018-09-07T00:36:01Z","merged_at":"2018-09-07T00:36:01Z","merge_commit_sha":"e7b677aa5de49a6a0619681647c8093900d4cd64","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/7869/commits","review_comments_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/7869/comments","review_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/7869/comments","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/4eae2fe4a5ffe8812245fd5ab08b5fa139f515f1","head":{"label":"don-brady:zfs_sysfs_live","ref":"zfs_sysfs_live","sha":"4eae2fe4a5ffe8812245fd5ab08b5fa139f515f1","user":{"login":"don-brady","id":12415697,"node_id":"MDQ6VXNlcjEyNDE1Njk3","avatar_url":"https://avatars1.githubusercontent.com/u/12415697?v=4","gravatar_id":"","url":"https://api.github.com/users/don-brady","html_url":"https://github.com/don-brady","followers_url":"https://api.github.com/users/don-brady/followers","following_url":"https://api.github.com/users/don-brady/following{/other_user}","gists_url":"https://api.github.com/users/don-brady/gists{/gist_id}","starred_url":"https://api.github.com/users/don-brady/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/don-brady/subscriptions","organizations_url":"https://api.github.com/users/don-brady/orgs","repos_url":"https://api.github.com/users/don-brady/repos","events_url":"https://api.github.com/users/don-brady/events{/privacy}","received_events_url":"https://api.github.com/users/don-brady/received_events","type":"User","site_admin":false},"repo":{"id":35576270,"node_id":"MDEwOlJlcG9zaXRvcnkzNTU3NjI3MA==","name":"zfs","full_name":"don-brady/zfs","owner":{"login":"don-brady","id":12415697,"node_id":"MDQ6VXNlcjEyNDE1Njk3","avatar_url":"https://avatars1.githubusercontent.com/u/12415697?v=4","gravatar_id":"","url":"https://api.github.com/users/don-brady","html_url":"https://github.com/don-brady","followers_url":"https://api.github.com/users/don-brady/followers","following_url":"https://api.github.com/users/don-brady/following{/other_user}","gists_url":"https://api.github.com/users/don-brady/gists{/gist_id}","starred_url":"https://api.github.com/users/don-brady/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/don-brady/subscriptions","organizations_url":"https://api.github.com/users/don-brady/orgs","repos_url":"https://api.github.com/users/don-brady/repos","events_url":"https://api.github.com/users/don-brady/events{/privacy}","received_events_url":"https://api.github.com/users/don-brady/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/don-brady/zfs","description":"Native ZFS for Linux","fork":true,"url":"https://api.github.com/repos/don-brady/zfs","forks_url":"https://api.github.com/repos/don-brady/zfs/forks","keys_url":"https://api.github.com/repos/don-brady/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/don-brady/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/don-brady/zfs/teams","hooks_url":"https://api.github.com/repos/don-brady/zfs/hooks","issue_events_url":"https://api.github.com/repos/don-brady/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/don-brady/zfs/events","assignees_url":"https://api.github.com/repos/don-brady/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/don-brady/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/don-brady/zfs/tags","blobs_url":"https://api.github.com/repos/don-brady/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/don-brady/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/don-brady/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/don-brady/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/don-brady/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/don-brady/zfs/languages","stargazers_url":"https://api.github.com/repos/don-brady/zfs/stargazers","contributors_url":"https://api.github.com/repos/don-brady/zfs/contributors","subscribers_url":"https://api.github.com/repos/don-brady/zfs/subscribers","subscription_url":"https://api.github.com/repos/don-brady/zfs/subscription","commits_url":"https://api.github.com/repos/don-brady/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/don-brady/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/don-brady/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/don-brady/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/don-brady/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/don-brady/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/don-brady/zfs/merges","archive_url":"https://api.github.com/repos/don-brady/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/don-brady/zfs/downloads","issues_url":"https://api.github.com/repos/don-brady/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/don-brady/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/don-brady/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/don-brady/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/don-brady/zfs/labels{/name}","releases_url":"https://api.github.com/repos/don-brady/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/don-brady/zfs/deployments","created_at":"2015-05-13T21:58:38Z","updated_at":"2017-08-15T07:11:22Z","pushed_at":"2018-09-06T22:27:06Z","git_url":"git://github.com/don-brady/zfs.git","ssh_url":"git@github.com:don-brady/zfs.git","clone_url":"https://github.com/don-brady/zfs.git","svn_url":"https://github.com/don-brady/zfs","homepage":"http://zfsonlinux.org/","size":47308,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"zfsonlinux:master","ref":"master","sha":"cc99f275a28c43fe450a66a7544f73c4935f7361","user":{"login":"zfsonlinux","id":575083,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTA4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/575083?v=4","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":437011,"node_id":"MDEwOlJlcG9zaXRvcnk0MzcwMTE=","name":"zfs","full_name":"zfsonlinux/zfs","owner":{"login":"zfsonlinux","id":575083,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTA4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/575083?v=4","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zfsonlinux/zfs","description":"ZFS on Linux - the official OpenZFS implementation for Linux.","fork":false,"url":"https://api.github.com/repos/zfsonlinux/zfs","forks_url":"https://api.github.com/repos/zfsonlinux/zfs/forks","keys_url":"https://api.github.com/repos/zfsonlinux/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zfsonlinux/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zfsonlinux/zfs/teams","hooks_url":"https://api.github.com/repos/zfsonlinux/zfs/hooks","issue_events_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/zfsonlinux/zfs/events","assignees_url":"https://api.github.com/repos/zfsonlinux/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/zfsonlinux/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/zfsonlinux/zfs/tags","blobs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zfsonlinux/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/zfsonlinux/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/zfsonlinux/zfs/languages","stargazers_url":"https://api.github.com/repos/zfsonlinux/zfs/stargazers","contributors_url":"https://api.github.com/repos/zfsonlinux/zfs/contributors","subscribers_url":"https://api.github.com/repos/zfsonlinux/zfs/subscribers","subscription_url":"https://api.github.com/repos/zfsonlinux/zfs/subscription","commits_url":"https://api.github.com/repos/zfsonlinux/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/zfsonlinux/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/zfsonlinux/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/zfsonlinux/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zfsonlinux/zfs/merges","archive_url":"https://api.github.com/repos/zfsonlinux/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zfsonlinux/zfs/downloads","issues_url":"https://api.github.com/repos/zfsonlinux/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/zfsonlinux/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/zfsonlinux/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zfsonlinux/zfs/labels{/name}","releases_url":"https://api.github.com/repos/zfsonlinux/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/zfsonlinux/zfs/deployments","created_at":"2009-12-14T20:20:34Z","updated_at":"2018-09-06T20:11:31Z","pushed_at":"2018-09-07T00:36:01Z","git_url":"git://github.com/zfsonlinux/zfs.git","ssh_url":"git@github.com:zfsonlinux/zfs.git","clone_url":"https://github.com/zfsonlinux/zfs.git","svn_url":"https://github.com/zfsonlinux/zfs","homepage":"https://zfsonlinux.org/","size":48434,"stargazers_count":3444,"watchers_count":3444,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":804,"mirror_url":null,"archived":false,"open_issues_count":979,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":804,"open_issues":979,"watchers":3444,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/7869"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/7869"},"issue":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/7869"},"comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/7869/comments"},"review_comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/7869/comments"},"review_comment":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/7869/commits"},"statuses":{"href":"https://api.github.com/repos/zfsonlinux/zfs/statuses/4eae2fe4a5ffe8812245fd5ab08b5fa139f515f1"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"behlendorf","id":148917,"node_id":"MDQ6VXNlcjE0ODkxNw==","avatar_url":"https://avatars2.githubusercontent.com/u/148917?v=4","gravatar_id":"","url":"https://api.github.com/users/behlendorf","html_url":"https://github.com/behlendorf","followers_url":"https://api.github.com/users/behlendorf/followers","following_url":"https://api.github.com/users/behlendorf/following{/other_user}","gists_url":"https://api.github.com/users/behlendorf/gists{/gist_id}","starred_url":"https://api.github.com/users/behlendorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behlendorf/subscriptions","organizations_url":"https://api.github.com/users/behlendorf/orgs","repos_url":"https://api.github.com/users/behlendorf/repos","events_url":"https://api.github.com/users/behlendorf/events{/privacy}","received_events_url":"https://api.github.com/users/behlendorf/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"behlendorf"}}