{"action":"created","issue":{"url":"https://api.github.com/repos/AdguardTeam/CoreLibs/issues/587","repository_url":"https://api.github.com/repos/AdguardTeam/CoreLibs","labels_url":"https://api.github.com/repos/AdguardTeam/CoreLibs/issues/587/labels{/name}","comments_url":"https://api.github.com/repos/AdguardTeam/CoreLibs/issues/587/comments","events_url":"https://api.github.com/repos/AdguardTeam/CoreLibs/issues/587/events","html_url":"https://github.com/AdguardTeam/CoreLibs/issues/587","id":376759922,"node_id":"MDU6SXNzdWUzNzY3NTk5MjI=","number":587,"title":"Some rules in default ad blocker don't work in AG v2.12.234η.","user":{"login":"zebrum","id":23637588,"node_id":"MDQ6VXNlcjIzNjM3NTg4","avatar_url":"https://avatars2.githubusercontent.com/u/23637588?v=4","gravatar_id":"","url":"https://api.github.com/users/zebrum","html_url":"https://github.com/zebrum","followers_url":"https://api.github.com/users/zebrum/followers","following_url":"https://api.github.com/users/zebrum/following{/other_user}","gists_url":"https://api.github.com/users/zebrum/gists{/gist_id}","starred_url":"https://api.github.com/users/zebrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zebrum/subscriptions","organizations_url":"https://api.github.com/users/zebrum/orgs","repos_url":"https://api.github.com/users/zebrum/repos","events_url":"https://api.github.com/users/zebrum/events{/privacy}","received_events_url":"https://api.github.com/users/zebrum/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-11-02T10:47:44Z","updated_at":"2018-11-02T11:42:58Z","closed_at":null,"author_association":"MEMBER","body":"@lancelot-moon commented on [Sun Oct 07 2018](https://github.com/AdguardTeam/AdguardForAndroid/issues/2158)\n\n@ameshkov \r\n\r\nI tested on my old Android device.\r\n**Android v4.4.2 without root.\r\nI'm not sure if the issue also occurs on Android v6, v7, v8 and above.\r\nIt seems that only some specific rules in Base filter don't work.**\r\n\r\nThis is the log (record everything).\r\nhttps://app.box.com/s/45g5yqx4prh2643dkh0do1q8bt83bm2l\r\n\r\nI used the manhuaren app for Android.\r\nhttp://www.manhuaren.com/download/android/dm5hw-2-2-5/\r\n**The app trusts AdGuard certificate.\r\nSo I suggest that you test on both Android v4 and v8.**\r\n\r\nI made the rules for the app before.\r\nhttps://github.com/AdguardTeam/AdguardFilters/issues/21078#issuecomment-413593319\r\n\r\nIn the older nightly version, the rules in default ad blocker worked fine.\r\nAfter updating to v2.12.234η, I found that the ads or leftovers appeared in manhuaren app with AdGuard enabled.\r\nI went to check the filtering log.\r\n**Some ad requests were not blocked even if the rules are in Base filter.\r\nThe under specific rules in Base filter didn't work on my old Android v4.4.2.**\r\n/getStartPageAds\r\n/getMultiAdsStrategy\r\n/getAditem\r\n/getads?\r\n||by218us.cdndm5.com/25^\r\n||by218us.cdndm5.com/29^\r\n\r\nAfter my rough observation, it seems that only some specific rules in Base filter don't work.\r\nFrom my screenshots, you know those HTTP requests which should be blocked by default filters are only processed. \r\n<details><summary>Screenshots:</summary>\r\n\r\n![image](https://i.imgur.com/ZkHn6Of.png)\r\n\r\n![image](https://i.imgur.com/znpSbkI.png)\r\n\r\n![image](https://i.imgur.com/T2IRQHo.png)\r\n\r\n![image](https://i.imgur.com/UCrdEz6.png)\r\n</details><br/>\r\n\r\n(If I manually add those rules in the user filter, the rules could work fine.)\r\n\r\n**Maybe I didn't find more other rules which didn't work.\r\nThe problem seems to be related to Base filter.**\r\nMy rules in Mobile Ads filter seems to work fine.\n\n---\n\n@karina-archazh commented on [Thu Oct 18 2018](https://github.com/AdguardTeam/AdguardForAndroid/issues/2158#issuecomment-431090056)\n\nThis rules from base filter aren't applied for some reason on new Adguard nightly versions and Android versions 4/9\r\nOn version 2.12.212 the base filter blocks ads (screenshot below)\r\n<details><summary>Screenshot:</summary>\r\n\r\n![image](https://user-images.githubusercontent.com/41899455/47171296-06fdc800-d311-11e8-926a-4dc971ee5c19.png)\r\n</details>\n\n---\n\n@lancelot-moon commented on [Thu Oct 18 2018](https://github.com/AdguardTeam/AdguardForAndroid/issues/2158#issuecomment-431098737)\n\nI knew the specific rules in Base filter could work in the earlier nightly version.\r\nI didn't test on my Android v8 because the app is from China.\r\nOh, except for Android v4, the specific rules in Base filter still don't work in Android v9 with the recent nightly version, right?\r\n(If you manually add those rules in the user filter, they'll work.)\r\n\r\nPlease give screenshots with English interface afterwards as possible.\r\nThank that finally there is somebody to check the bug. :3\r\n\n\n---\n\n@lancelot-moon commented on [Fri Nov 02 2018](https://github.com/AdguardTeam/AdguardForAndroid/issues/2158#issuecomment-435317311)\n\n@zebrum\r\n\r\nWhen can you solve the bug?\n\n---\n\n@zebrum commented on [Fri Nov 02 2018](https://github.com/AdguardTeam/AdguardForAndroid/issues/2158#issuecomment-435318304)\n\n@lancelot-moon I wonder may it be related to #2157?\n\n---\n\n@lancelot-moon commented on [Fri Nov 02 2018](https://github.com/AdguardTeam/AdguardForAndroid/issues/2158#issuecomment-435319978)\n\nNo, absolutely not!!!\r\nThey're different issues.\r\nIn this topic, those HTTP requests can be caught by AG.\r\nThey should be blocked due to the rules, but they are only processed (not blocked).\r\nSimply, some specific rules in Base filter don't normally work.\r\nBut they would work if manually adding those rules (already in Base filter) in user filter.\r\n\r\n**In the older nightly version, there is no the issue.\r\nThe issue started to occur from the recent nightly version.**\n\n"},"comment":{"url":"https://api.github.com/repos/AdguardTeam/CoreLibs/issues/comments/435352839","html_url":"https://github.com/AdguardTeam/CoreLibs/issues/587#issuecomment-435352839","issue_url":"https://api.github.com/repos/AdguardTeam/CoreLibs/issues/587","id":435352839,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTM1MjgzOQ==","user":{"login":"lancelot-moon","id":23546320,"node_id":"MDQ6VXNlcjIzNTQ2MzIw","avatar_url":"https://avatars3.githubusercontent.com/u/23546320?v=4","gravatar_id":"","url":"https://api.github.com/users/lancelot-moon","html_url":"https://github.com/lancelot-moon","followers_url":"https://api.github.com/users/lancelot-moon/followers","following_url":"https://api.github.com/users/lancelot-moon/following{/other_user}","gists_url":"https://api.github.com/users/lancelot-moon/gists{/gist_id}","starred_url":"https://api.github.com/users/lancelot-moon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lancelot-moon/subscriptions","organizations_url":"https://api.github.com/users/lancelot-moon/orgs","repos_url":"https://api.github.com/users/lancelot-moon/repos","events_url":"https://api.github.com/users/lancelot-moon/events{/privacy}","received_events_url":"https://api.github.com/users/lancelot-moon/received_events","type":"User","site_admin":false},"created_at":"2018-11-02T11:42:58Z","updated_at":"2018-11-02T11:42:58Z","author_association":"NONE","body":"Oh my God, why deleted those specific rules from Base filter of AG for Android?\r\nI checked rules from the under link.\r\nhttps://filters.adtidy.org/extension/chromium/filters/2.txt\r\nSo I didn't know that we ever added those specific rules into Base filter of AG for Android, but they were deleted from Base filter of AG for Android afterwards.\r\nThanks for solving the issue!"}}
{"actor":{"display_login":"lancelot-moon"}}