{"action":"created","comment":{"url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/pulls/comments/234527919","pull_request_review_id":176184481,"id":234527919,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDUyNzkxOQ==","diff_hunk":"@@ -0,0 +1,199 @@\n+#!/usr/bin/python\n+# -*- coding: utf-8 -*-\n+\n+# Copyright (c) 2018, KubeVirt Team <@kubevirt>\n+# Apache License, Version 2.0\n+# (see LICENSE or http://www.apache.org/licenses/LICENSE-2.0)\n+\n+ANSIBLE_METADATA = {'metadata_version': '1.1',\n+                    'status': ['preview'],\n+                    'supported_by': 'community'}\n+\n+DOCUMENTATION = '''\n+---\n+module: k8s_service\n+\n+short_description: Manage Services on Kubernetes\n+\n+description:\n+    - Use Openshift Python SDK to manage Services on Kubernetes\n+\n+version_added: \"2.8\"\n+\n+author: KubeVirt Team (@kubevirt)\n+\n+options:\n+    name:\n+        description:\n+            - Use to specify a Service object name.\n+        required: true\n+        type: str\n+    namespace:\n+        description:\n+            - Use to specify a Service object namespace.\n+        required: true\n+        type: str\n+    type:\n+        description:\n+            - Specifies the type of Service to create.\n+        choices:\n+            - NodePort\n+            - ClusterIP\n+            - LoadBalancer\n+        required: true\n+    ports:\n+        description:\n+            - A list of ports to expose.\n+        required: true\n+        type: list\n+    selector:\n+        description:\n+            - Label selectors identify objects this Service should apply to.","path":"lib/ansible/modules/clustering/kubevirt/k8s_service.py","position":51,"original_position":51,"commit_id":"f337cdb8f396eecbd301d11e6c4d5ee16e049484","original_commit_id":"f337cdb8f396eecbd301d11e6c4d5ee16e049484","user":{"login":"pkliczewski","id":1384786,"node_id":"MDQ6VXNlcjEzODQ3ODY=","avatar_url":"https://avatars1.githubusercontent.com/u/1384786?v=4","gravatar_id":"","url":"https://api.github.com/users/pkliczewski","html_url":"https://github.com/pkliczewski","followers_url":"https://api.github.com/users/pkliczewski/followers","following_url":"https://api.github.com/users/pkliczewski/following{/other_user}","gists_url":"https://api.github.com/users/pkliczewski/gists{/gist_id}","starred_url":"https://api.github.com/users/pkliczewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkliczewski/subscriptions","organizations_url":"https://api.github.com/users/pkliczewski/orgs","repos_url":"https://api.github.com/users/pkliczewski/repos","events_url":"https://api.github.com/users/pkliczewski/events{/privacy}","received_events_url":"https://api.github.com/users/pkliczewski/received_events","type":"User","site_admin":false},"body":"I think that here we could benefit from having a more information about what we can provide here and what are the types.","created_at":"2018-11-19T08:33:20Z","updated_at":"2018-11-19T08:44:00Z","html_url":"https://github.com/kubevirt/ansible-kubevirt-modules/pull/136#discussion_r234527919","pull_request_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/pulls/136","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/pulls/comments/234527919"},"html":{"href":"https://github.com/kubevirt/ansible-kubevirt-modules/pull/136#discussion_r234527919"},"pull_request":{"href":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/pulls/136"}}},"pull_request":{"url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/pulls/136","id":231149037,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMTQ5MDM3","html_url":"https://github.com/kubevirt/ansible-kubevirt-modules/pull/136","diff_url":"https://github.com/kubevirt/ansible-kubevirt-modules/pull/136.diff","patch_url":"https://github.com/kubevirt/ansible-kubevirt-modules/pull/136.patch","issue_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/issues/136","number":136,"state":"open","locked":false,"title":"[WIP] Add a dedicated module for managing Services","user":{"login":"mmazur","id":62953,"node_id":"MDQ6VXNlcjYyOTUz","avatar_url":"https://avatars1.githubusercontent.com/u/62953?v=4","gravatar_id":"","url":"https://api.github.com/users/mmazur","html_url":"https://github.com/mmazur","followers_url":"https://api.github.com/users/mmazur/followers","following_url":"https://api.github.com/users/mmazur/following{/other_user}","gists_url":"https://api.github.com/users/mmazur/gists{/gist_id}","starred_url":"https://api.github.com/users/mmazur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmazur/subscriptions","organizations_url":"https://api.github.com/users/mmazur/orgs","repos_url":"https://api.github.com/users/mmazur/repos","events_url":"https://api.github.com/users/mmazur/events{/privacy}","received_events_url":"https://api.github.com/users/mmazur/received_events","type":"User","site_admin":false},"body":"Let's make sure we're on the same page wrt to config parameters early. @machacekondra @pkliczewski \r\n\r\nThe idea behind `spec` is:\r\n1. One can completely ignore the module's parameters and provide the whole Service spec inline.\r\n2. Any parameter not covered directly by the module for whatever reason can always be provided this way.","created_at":"2018-11-15T10:49:20Z","updated_at":"2018-11-19T08:44:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d6cd45dccd4704f05dae4d738e45aaeccdeb88f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1119139851,"node_id":"MDU6TGFiZWwxMTE5MTM5ODUx","url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/labels/reviews/2","name":"reviews/2","color":"f1f77b","default":false},{"id":1080282993,"node_id":"MDU6TGFiZWwxMDgwMjgyOTkz","url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/pulls/136/commits","review_comments_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/pulls/136/comments","review_comment_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/issues/136/comments","statuses_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/statuses/f337cdb8f396eecbd301d11e6c4d5ee16e049484","head":{"label":"mmazur:kubevirt_service","ref":"kubevirt_service","sha":"f337cdb8f396eecbd301d11e6c4d5ee16e049484","user":{"login":"mmazur","id":62953,"node_id":"MDQ6VXNlcjYyOTUz","avatar_url":"https://avatars1.githubusercontent.com/u/62953?v=4","gravatar_id":"","url":"https://api.github.com/users/mmazur","html_url":"https://github.com/mmazur","followers_url":"https://api.github.com/users/mmazur/followers","following_url":"https://api.github.com/users/mmazur/following{/other_user}","gists_url":"https://api.github.com/users/mmazur/gists{/gist_id}","starred_url":"https://api.github.com/users/mmazur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmazur/subscriptions","organizations_url":"https://api.github.com/users/mmazur/orgs","repos_url":"https://api.github.com/users/mmazur/repos","events_url":"https://api.github.com/users/mmazur/events{/privacy}","received_events_url":"https://api.github.com/users/mmazur/received_events","type":"User","site_admin":false},"repo":{"id":150269164,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAyNjkxNjQ=","name":"ansible-kubevirt-modules","full_name":"mmazur/ansible-kubevirt-modules","private":false,"owner":{"login":"mmazur","id":62953,"node_id":"MDQ6VXNlcjYyOTUz","avatar_url":"https://avatars1.githubusercontent.com/u/62953?v=4","gravatar_id":"","url":"https://api.github.com/users/mmazur","html_url":"https://github.com/mmazur","followers_url":"https://api.github.com/users/mmazur/followers","following_url":"https://api.github.com/users/mmazur/following{/other_user}","gists_url":"https://api.github.com/users/mmazur/gists{/gist_id}","starred_url":"https://api.github.com/users/mmazur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmazur/subscriptions","organizations_url":"https://api.github.com/users/mmazur/orgs","repos_url":"https://api.github.com/users/mmazur/repos","events_url":"https://api.github.com/users/mmazur/events{/privacy}","received_events_url":"https://api.github.com/users/mmazur/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mmazur/ansible-kubevirt-modules","description":"Ansible modules for KubeVirt management","fork":true,"url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules","forks_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/forks","keys_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/teams","hooks_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/hooks","issue_events_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/issues/events{/number}","events_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/events","assignees_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/assignees{/user}","branches_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/branches{/branch}","tags_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/tags","blobs_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/statuses/{sha}","languages_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/languages","stargazers_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/stargazers","contributors_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/contributors","subscribers_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/subscribers","subscription_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/subscription","commits_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/contents/{+path}","compare_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/merges","archive_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/downloads","issues_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/issues{/number}","pulls_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/pulls{/number}","milestones_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/milestones{/number}","notifications_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/labels{/name}","releases_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/releases{/id}","deployments_url":"https://api.github.com/repos/mmazur/ansible-kubevirt-modules/deployments","created_at":"2018-09-25T13:23:54Z","updated_at":"2018-10-05T16:06:45Z","pushed_at":"2018-11-16T15:41:25Z","git_url":"git://github.com/mmazur/ansible-kubevirt-modules.git","ssh_url":"git@github.com:mmazur/ansible-kubevirt-modules.git","clone_url":"https://github.com/mmazur/ansible-kubevirt-modules.git","svn_url":"https://github.com/mmazur/ansible-kubevirt-modules","homepage":null,"size":189,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubevirt:master","ref":"master","sha":"dce8831abbe04174d098ee00c0a0dbd61a701cdf","user":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"repo":{"id":126311840,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYzMTE4NDA=","name":"ansible-kubevirt-modules","full_name":"kubevirt/ansible-kubevirt-modules","private":false,"owner":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubevirt/ansible-kubevirt-modules","description":"Ansible modules for KubeVirt management","fork":false,"url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules","forks_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/forks","keys_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/teams","hooks_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/hooks","issue_events_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/issues/events{/number}","events_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/events","assignees_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/assignees{/user}","branches_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/branches{/branch}","tags_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/tags","blobs_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/statuses/{sha}","languages_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/languages","stargazers_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/stargazers","contributors_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/contributors","subscribers_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/subscribers","subscription_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/subscription","commits_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/contents/{+path}","compare_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/merges","archive_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/downloads","issues_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/issues{/number}","pulls_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/pulls{/number}","milestones_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/milestones{/number}","notifications_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/labels{/name}","releases_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/releases{/id}","deployments_url":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/deployments","created_at":"2018-03-22T09:33:23Z","updated_at":"2018-11-08T15:30:48Z","pushed_at":"2018-11-16T15:41:27Z","git_url":"git://github.com/kubevirt/ansible-kubevirt-modules.git","ssh_url":"git@github.com:kubevirt/ansible-kubevirt-modules.git","clone_url":"https://github.com/kubevirt/ansible-kubevirt-modules.git","svn_url":"https://github.com/kubevirt/ansible-kubevirt-modules","homepage":null,"size":178,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":12,"open_issues":8,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/pulls/136"},"html":{"href":"https://github.com/kubevirt/ansible-kubevirt-modules/pull/136"},"issue":{"href":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/issues/136"},"comments":{"href":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/issues/136/comments"},"review_comments":{"href":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/pulls/136/comments"},"review_comment":{"href":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/pulls/136/commits"},"statuses":{"href":"https://api.github.com/repos/kubevirt/ansible-kubevirt-modules/statuses/f337cdb8f396eecbd301d11e6c4d5ee16e049484"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"pkliczewski"}}