{"action":"opened","number":1754,"pull_request":{"url":"https://api.github.com/repos/DivanteLtd/vue-storefront/pulls/1754","id":217460715,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NDYwNzE1","html_url":"https://github.com/DivanteLtd/vue-storefront/pull/1754","diff_url":"https://github.com/DivanteLtd/vue-storefront/pull/1754.diff","patch_url":"https://github.com/DivanteLtd/vue-storefront/pull/1754.patch","issue_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/1754","number":1754,"state":"open","locked":false,"title":"Fixes issue 1753","user":{"login":"DavidRouyer","id":1556750,"node_id":"MDQ6VXNlcjE1NTY3NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/1556750?v=4","gravatar_id":"","url":"https://api.github.com/users/DavidRouyer","html_url":"https://github.com/DavidRouyer","followers_url":"https://api.github.com/users/DavidRouyer/followers","following_url":"https://api.github.com/users/DavidRouyer/following{/other_user}","gists_url":"https://api.github.com/users/DavidRouyer/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidRouyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidRouyer/subscriptions","organizations_url":"https://api.github.com/users/DavidRouyer/orgs","repos_url":"https://api.github.com/users/DavidRouyer/repos","events_url":"https://api.github.com/users/DavidRouyer/events{/privacy}","received_events_url":"https://api.github.com/users/DavidRouyer/received_events","type":"User","site_admin":false},"body":"### Related issues\r\n\r\nfixes #1753 \r\n\r\n### Short description and why it's useful\r\n\r\nFix missing translations\r\nAdd missing quotes\r\n\r\n### Screenshots of visual changes before/after (if there are any)\r\n\r\n### Screenshot of passed e2e tests (if you are using our standard setup as a backend)\r\n\r\n### Contribution and curently important rules acceptance\r\n\r\n- [x] I read and followed [contribution rules](https://github.com/DivanteLtd/vue-storefront/blob/master/CONTRIBUTING.md)\r\n- [x] I read the [TypeScript Action Plan](https://github.com/DivanteLtd/vue-storefront/blob/master/doc/TypeScript%20Action%20Plan.md) and adjusted my PR according to it\r\n- [x] I read about [Vue Storefront Modules](https://github.com/DivanteLtd/vue-storefront/blob/master/doc/api-modules/about-modules.md) and [refactoring plan for them](https://github.com/DivanteLtd/vue-storefront/blob/master/doc/api-modules/refactoring-to-modules.md)\r\n","created_at":"2018-09-22T14:45:00Z","updated_at":"2018-09-22T14:45:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/pulls/1754/commits","review_comments_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/pulls/1754/comments","review_comment_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/1754/comments","statuses_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/statuses/8884818b8b92302a9ad99702610f76df6eed961c","head":{"label":"DavidRouyer:issue-1753","ref":"issue-1753","sha":"8884818b8b92302a9ad99702610f76df6eed961c","user":{"login":"DavidRouyer","id":1556750,"node_id":"MDQ6VXNlcjE1NTY3NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/1556750?v=4","gravatar_id":"","url":"https://api.github.com/users/DavidRouyer","html_url":"https://github.com/DavidRouyer","followers_url":"https://api.github.com/users/DavidRouyer/followers","following_url":"https://api.github.com/users/DavidRouyer/following{/other_user}","gists_url":"https://api.github.com/users/DavidRouyer/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidRouyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidRouyer/subscriptions","organizations_url":"https://api.github.com/users/DavidRouyer/orgs","repos_url":"https://api.github.com/users/DavidRouyer/repos","events_url":"https://api.github.com/users/DavidRouyer/events{/privacy}","received_events_url":"https://api.github.com/users/DavidRouyer/received_events","type":"User","site_admin":false},"repo":{"id":143405050,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM0MDUwNTA=","name":"vue-storefront","full_name":"DavidRouyer/vue-storefront","private":false,"owner":{"login":"DavidRouyer","id":1556750,"node_id":"MDQ6VXNlcjE1NTY3NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/1556750?v=4","gravatar_id":"","url":"https://api.github.com/users/DavidRouyer","html_url":"https://github.com/DavidRouyer","followers_url":"https://api.github.com/users/DavidRouyer/followers","following_url":"https://api.github.com/users/DavidRouyer/following{/other_user}","gists_url":"https://api.github.com/users/DavidRouyer/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidRouyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidRouyer/subscriptions","organizations_url":"https://api.github.com/users/DavidRouyer/orgs","repos_url":"https://api.github.com/users/DavidRouyer/repos","events_url":"https://api.github.com/users/DavidRouyer/events{/privacy}","received_events_url":"https://api.github.com/users/DavidRouyer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/DavidRouyer/vue-storefront","description":"Vue Storefront - PWA for eCommerce. 100% offline, platform agnostic, headless, Magento 2 supported. Always Open Source, MIT license. Join us as contributor (contributors@vuestorefront.io).","fork":true,"url":"https://api.github.com/repos/DavidRouyer/vue-storefront","forks_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/forks","keys_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/teams","hooks_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/hooks","issue_events_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/issues/events{/number}","events_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/events","assignees_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/assignees{/user}","branches_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/branches{/branch}","tags_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/tags","blobs_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/git/refs{/sha}","trees_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/statuses/{sha}","languages_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/languages","stargazers_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/stargazers","contributors_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/contributors","subscribers_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/subscribers","subscription_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/subscription","commits_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/commits{/sha}","git_commits_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/git/commits{/sha}","comments_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/comments{/number}","issue_comment_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/issues/comments{/number}","contents_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/contents/{+path}","compare_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/merges","archive_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/downloads","issues_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/issues{/number}","pulls_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/pulls{/number}","milestones_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/milestones{/number}","notifications_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/labels{/name}","releases_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/releases{/id}","deployments_url":"https://api.github.com/repos/DavidRouyer/vue-storefront/deployments","created_at":"2018-08-03T09:04:40Z","updated_at":"2018-09-11T07:50:15Z","pushed_at":"2018-09-22T14:42:42Z","git_url":"git://github.com/DavidRouyer/vue-storefront.git","ssh_url":"git@github.com:DavidRouyer/vue-storefront.git","clone_url":"https://github.com/DavidRouyer/vue-storefront.git","svn_url":"https://github.com/DavidRouyer/vue-storefront","homepage":"http://vuestorefront.io","size":27793,"stargazers_count":0,"watchers_count":0,"language":"Vue","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DivanteLtd:develop","ref":"develop","sha":"2e6a75db37a08eb73e3e272eed34266c45096d15","user":{"login":"DivanteLtd","id":11463761,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDYzNzYx","avatar_url":"https://avatars3.githubusercontent.com/u/11463761?v=4","gravatar_id":"","url":"https://api.github.com/users/DivanteLtd","html_url":"https://github.com/DivanteLtd","followers_url":"https://api.github.com/users/DivanteLtd/followers","following_url":"https://api.github.com/users/DivanteLtd/following{/other_user}","gists_url":"https://api.github.com/users/DivanteLtd/gists{/gist_id}","starred_url":"https://api.github.com/users/DivanteLtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DivanteLtd/subscriptions","organizations_url":"https://api.github.com/users/DivanteLtd/orgs","repos_url":"https://api.github.com/users/DivanteLtd/repos","events_url":"https://api.github.com/users/DivanteLtd/events{/privacy}","received_events_url":"https://api.github.com/users/DivanteLtd/received_events","type":"Organization","site_admin":false},"repo":{"id":100346588,"node_id":"MDEwOlJlcG9zaXRvcnkxMDAzNDY1ODg=","name":"vue-storefront","full_name":"DivanteLtd/vue-storefront","private":false,"owner":{"login":"DivanteLtd","id":11463761,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDYzNzYx","avatar_url":"https://avatars3.githubusercontent.com/u/11463761?v=4","gravatar_id":"","url":"https://api.github.com/users/DivanteLtd","html_url":"https://github.com/DivanteLtd","followers_url":"https://api.github.com/users/DivanteLtd/followers","following_url":"https://api.github.com/users/DivanteLtd/following{/other_user}","gists_url":"https://api.github.com/users/DivanteLtd/gists{/gist_id}","starred_url":"https://api.github.com/users/DivanteLtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DivanteLtd/subscriptions","organizations_url":"https://api.github.com/users/DivanteLtd/orgs","repos_url":"https://api.github.com/users/DivanteLtd/repos","events_url":"https://api.github.com/users/DivanteLtd/events{/privacy}","received_events_url":"https://api.github.com/users/DivanteLtd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DivanteLtd/vue-storefront","description":"Vue Storefront - PWA for eCommerce. 100% offline, platform agnostic, headless, Magento 2 supported. Always Open Source, MIT license. Join us as contributor (contributors@vuestorefront.io).","fork":false,"url":"https://api.github.com/repos/DivanteLtd/vue-storefront","forks_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/forks","keys_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/teams","hooks_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/hooks","issue_events_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/events{/number}","events_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/events","assignees_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/assignees{/user}","branches_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/branches{/branch}","tags_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/tags","blobs_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/git/refs{/sha}","trees_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/statuses/{sha}","languages_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/languages","stargazers_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/stargazers","contributors_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/contributors","subscribers_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/subscribers","subscription_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/subscription","commits_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/commits{/sha}","git_commits_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/git/commits{/sha}","comments_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/comments{/number}","issue_comment_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/comments{/number}","contents_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/contents/{+path}","compare_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/merges","archive_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/downloads","issues_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues{/number}","pulls_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/pulls{/number}","milestones_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/milestones{/number}","notifications_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/labels{/name}","releases_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/releases{/id}","deployments_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/deployments","created_at":"2017-08-15T06:33:52Z","updated_at":"2018-09-22T14:42:24Z","pushed_at":"2018-09-22T14:23:18Z","git_url":"git://github.com/DivanteLtd/vue-storefront.git","ssh_url":"git@github.com:DivanteLtd/vue-storefront.git","clone_url":"https://github.com/DivanteLtd/vue-storefront.git","svn_url":"https://github.com/DivanteLtd/vue-storefront","homepage":"https://vuestorefront.io","size":27621,"stargazers_count":2974,"watchers_count":2974,"language":"Vue","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":513,"mirror_url":null,"archived":false,"open_issues_count":172,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":513,"open_issues":172,"watchers":2974,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DivanteLtd/vue-storefront/pulls/1754"},"html":{"href":"https://github.com/DivanteLtd/vue-storefront/pull/1754"},"issue":{"href":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/1754"},"comments":{"href":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/1754/comments"},"review_comments":{"href":"https://api.github.com/repos/DivanteLtd/vue-storefront/pulls/1754/comments"},"review_comment":{"href":"https://api.github.com/repos/DivanteLtd/vue-storefront/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DivanteLtd/vue-storefront/pulls/1754/commits"},"statuses":{"href":"https://api.github.com/repos/DivanteLtd/vue-storefront/statuses/8884818b8b92302a9ad99702610f76df6eed961c"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":33,"deletions":3,"changed_files":12}}
{"actor":{"display_login":"DavidRouyer"}}