{"action":"opened","issue":{"url":"https://api.github.com/repos/contribsys/faktory/issues/166","repository_url":"https://api.github.com/repos/contribsys/faktory","labels_url":"https://api.github.com/repos/contribsys/faktory/issues/166/labels{/name}","comments_url":"https://api.github.com/repos/contribsys/faktory/issues/166/comments","events_url":"https://api.github.com/repos/contribsys/faktory/issues/166/events","html_url":"https://github.com/contribsys/faktory/issues/166","id":360527311,"node_id":"MDU6SXNzdWUzNjA1MjczMTE=","number":166,"title":"Killing a job from the web UI that has already been tried causes panic [0.9 beta]","user":{"login":"cdrx","id":11462,"node_id":"MDQ6VXNlcjExNDYy","avatar_url":"https://avatars1.githubusercontent.com/u/11462?v=4","gravatar_id":"","url":"https://api.github.com/users/cdrx","html_url":"https://github.com/cdrx","followers_url":"https://api.github.com/users/cdrx/followers","following_url":"https://api.github.com/users/cdrx/following{/other_user}","gists_url":"https://api.github.com/users/cdrx/gists{/gist_id}","starred_url":"https://api.github.com/users/cdrx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdrx/subscriptions","organizations_url":"https://api.github.com/users/cdrx/orgs","repos_url":"https://api.github.com/users/cdrx/repos","events_url":"https://api.github.com/users/cdrx/events{/privacy}","received_events_url":"https://api.github.com/users/cdrx/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-15T10:13:05Z","updated_at":"2018-09-15T10:13:05Z","closed_at":null,"author_association":"COLLABORATOR","body":"I had a job in the retries queue, I hit kill around the same time faktory sent it to be retried and the web UI caused a panic. \r\n\r\nProbably we want to give the user a nicer error message than \"The server dropped your connection\" when this happens :-)\r\n\r\n```http: panic serving 10.0.0.58:50459: runtime error: invalid memory address or nil pointer dereference\r\ngoroutine 1220 [running]:\r\nnet/http.(*conn).serve.func1(0xc42008ea00)\r\n\t/usr/local/go/src/net/http/server.go:1726 +0xd0\r\npanic(0x73e500, 0x9f7420)\r\n\t/usr/local/go/src/runtime/panic.go:502 +0x229\r\ngithub.com/contribsys/faktory/storage.(*redisSorted).MoveTo(0xc420154220, 0x7fb6c0, 0xc420154240, 0x0, 0x0, 0xbf1aa7f5830b03f8, 0x37432172dcb846, 0xa040c0, 0xc42015c500, 0x80)\r\n\t/root/go/src/github.com/contribsys/faktory/storage/sorted_redis.go:265 +0x37\r\ngithub.com/contribsys/faktory/webui.actOn(0xc420466500, 0x7fb6c0, 0xc420154220, 0xc42047a32f, 0x4, 0xc4204750f0, 0x1, 0x1, 0x686c9b, 0x78cb40)\r\n\t/root/go/src/github.com/contribsys/faktory/webui/helpers.go:227 +0x2e7\r\ngithub.com/contribsys/faktory/webui.retriesHandler(0x7f8fe0, 0xc42016a0e0, 0xc420466500)\r\n\t/root/go/src/github.com/contribsys/faktory/webui/pages.go:116 +0x2be\r\ngithub.com/contribsys/faktory/webui.Setup.func1(0x7f8fe0, 0xc42016a0e0, 0xc420466400)\r\n\t/root/go/src/github.com/contribsys/faktory/webui/web.go:251 +0x26b\r\nnet/http.HandlerFunc.ServeHTTP(0xc420154540, 0x7f8fe0, 0xc42016a0e0, 0xc420466400)\r\n\t/usr/local/go/src/net/http/server.go:1947 +0x44\r\ngithub.com/contribsys/faktory/vendor/github.com/justinas/nosurf.(*CSRFHandler).handleSuccess(0xc420190360, 0x7f8fe0, 0xc42016a0e0, 0xc420466400)\r\n\t/root/go/src/github.com/contribsys/faktory/vendor/github.com/justinas/nosurf/handler.go:179 +0x51\r\ngithub.com/contribsys/faktory/vendor/github.com/justinas/nosurf.(*CSRFHandler).ServeHTTP(0xc420190360, 0x7f8fe0, 0xc42016a0e0, 0xc420466400)\r\n\t/root/go/src/github.com/contribsys/faktory/vendor/github.com/justinas/nosurf/handler.go:172 +0x2a2\r\ngithub.com/contribsys/faktory/webui.Protect.func2(0x7f8fe0, 0xc42016a0e0, 0xc420466300)\r\n\t/root/go/src/github.com/contribsys/faktory/webui/web.go:314 +0x48\r\nnet/http.HandlerFunc.ServeHTTP(0xc42016c1e0, 0x7f8fe0, 0xc42016a0e0, 0xc420466300)\r\n\t/usr/local/go/src/net/http/server.go:1947 +0x44\r\nnet/http.(*ServeMux).ServeHTTP(0xc4201742a0, 0x7f8fe0, 0xc42016a0e0, 0xc420466300)\r\n\t/usr/local/go/src/net/http/server.go:2337 +0x130\r\nnet/http.serverHandler.ServeHTTP(0xc420194000, 0x7f8fe0, 0xc42016a0e0, 0xc420466300)\r\n\t/usr/local/go/src/net/http/server.go:2694 +0xbc\r\nnet/http.(*conn).serve(0xc42008ea00, 0x7f92a0, 0xc420425c00)\r\n\t/usr/local/go/src/net/http/server.go:1830 +0x651\r\ncreated by net/http.(*Server).Serve\r\n\t/usr/local/go/src/net/http/server.go:2795 +0x27b\r\n```"}}
{"actor":{"display_login":"cdrx"}}