{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67036","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67036/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67036/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67036/events","html_url":"https://github.com/kubernetes/kubernetes/pull/67036","id":348102774,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NTMyOTQ0","number":67036,"title":"update logic of adding default DS pod tolerations","user":{"login":"Huang-Wei","id":1425903,"node_id":"MDQ6VXNlcjE0MjU5MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1425903?v=4","gravatar_id":"","url":"https://api.github.com/users/Huang-Wei","html_url":"https://github.com/Huang-Wei","followers_url":"https://api.github.com/users/Huang-Wei/followers","following_url":"https://api.github.com/users/Huang-Wei/following{/other_user}","gists_url":"https://api.github.com/users/Huang-Wei/gists{/gist_id}","starred_url":"https://api.github.com/users/Huang-Wei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Huang-Wei/subscriptions","organizations_url":"https://api.github.com/users/Huang-Wei/orgs","repos_url":"https://api.github.com/users/Huang-Wei/repos","events_url":"https://api.github.com/users/Huang-Wei/events{/privacy}","received_events_url":"https://api.github.com/users/Huang-Wei/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":148225179,"node_id":"MDU6TGFiZWwxNDgyMjUxNzk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":404091735,"node_id":"MDU6TGFiZWw0MDQwOTE3MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/apps","name":"sig/apps","color":"d2b48c","default":false},{"id":125550211,"node_id":"MDU6TGFiZWwxMjU1NTAyMTE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/scheduling","name":"sig/scheduling","color":"d2b48c","default":false},{"id":253450978,"node_id":"MDU6TGFiZWwyNTM0NTA5Nzg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"k82cn","id":18107181,"node_id":"MDQ6VXNlcjE4MTA3MTgx","avatar_url":"https://avatars0.githubusercontent.com/u/18107181?v=4","gravatar_id":"","url":"https://api.github.com/users/k82cn","html_url":"https://github.com/k82cn","followers_url":"https://api.github.com/users/k82cn/followers","following_url":"https://api.github.com/users/k82cn/following{/other_user}","gists_url":"https://api.github.com/users/k82cn/gists{/gist_id}","starred_url":"https://api.github.com/users/k82cn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k82cn/subscriptions","organizations_url":"https://api.github.com/users/k82cn/orgs","repos_url":"https://api.github.com/users/k82cn/repos","events_url":"https://api.github.com/users/k82cn/events{/privacy}","received_events_url":"https://api.github.com/users/k82cn/received_events","type":"User","site_admin":false},"assignees":[{"login":"mikedanese","id":1787169,"node_id":"MDQ6VXNlcjE3ODcxNjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1787169?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false},{"login":"k82cn","id":18107181,"node_id":"MDQ6VXNlcjE4MTA3MTgx","avatar_url":"https://avatars0.githubusercontent.com/u/18107181?v=4","gravatar_id":"","url":"https://api.github.com/users/k82cn","html_url":"https://github.com/k82cn","followers_url":"https://api.github.com/users/k82cn/followers","following_url":"https://api.github.com/users/k82cn/following{/other_user}","gists_url":"https://api.github.com/users/k82cn/gists{/gist_id}","starred_url":"https://api.github.com/users/k82cn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k82cn/subscriptions","organizations_url":"https://api.github.com/users/k82cn/orgs","repos_url":"https://api.github.com/users/k82cn/repos","events_url":"https://api.github.com/users/k82cn/events{/privacy}","received_events_url":"https://api.github.com/users/k82cn/received_events","type":"User","site_admin":false}],"milestone":null,"comments":12,"created_at":"2018-08-06T22:26:39Z","updated_at":"2018-08-31T09:47:20Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/67036","html_url":"https://github.com/kubernetes/kubernetes/pull/67036","diff_url":"https://github.com/kubernetes/kubernetes/pull/67036.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/67036.patch"},"body":"**What this PR does / why we need it**:\r\n\r\n- update DS pod default tolerations: add PIDPressure, remove OutOfDisk\r\n- remove useless tolerations testcases\r\n\r\n**Which issue(s) this PR fixes**:\r\n\r\n- Fixes partial of comment https://github.com/kubernetes/kubernetes/issues/66348#issuecomment-410419351.\r\n- Relates Upgrade TaintNodesByCondition to Beta #62109\r\n\r\n**Special notes for your reviewer**:\r\n\r\nCorrect the behavior of daemonset controller as \"out-of-disk\" toleration doesn't fit any more.\r\n\r\n**Release note**:\r\n```release-note\r\n`node.kubernetes.io/pid-pressure` toleration is added for DaemonSet pods, and `node.kubernetes.io/out-of-disk` isn't added any more even if it's a critical pod.\r\n```\r\n\r\n/sig scheduling\r\n/sig apps"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/417613168","html_url":"https://github.com/kubernetes/kubernetes/pull/67036#issuecomment-417613168","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/67036","id":417613168,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzYxMzE2OA==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-08-31T09:47:20Z","updated_at":"2018-08-31T09:47:20Z","author_association":"NONE","body":"@Huang-Wei: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-kubemark-e2e-gce-big | e06b2f565fe53764cbdf2074d84a42c0d68f0931 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/67036/pull-kubernetes-kubemark-e2e-gce-big/20655/) | `/test pull-kubernetes-kubemark-e2e-gce-big`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/67036). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/Huang-Wei). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}