{"action":"created","issue":{"url":"https://api.github.com/repos/leoasis/redux-immutable-state-invariant/issues/35","repository_url":"https://api.github.com/repos/leoasis/redux-immutable-state-invariant","labels_url":"https://api.github.com/repos/leoasis/redux-immutable-state-invariant/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/leoasis/redux-immutable-state-invariant/issues/35/comments","events_url":"https://api.github.com/repos/leoasis/redux-immutable-state-invariant/issues/35/events","html_url":"https://github.com/leoasis/redux-immutable-state-invariant/pull/35","id":307369629,"number":35,"title":"Issue #28: support mutation detection for iterable objects in state","user":{"login":"darthrellimnad","id":121980,"avatar_url":"https://avatars3.githubusercontent.com/u/121980?v=4","gravatar_id":"","url":"https://api.github.com/users/darthrellimnad","html_url":"https://github.com/darthrellimnad","followers_url":"https://api.github.com/users/darthrellimnad/followers","following_url":"https://api.github.com/users/darthrellimnad/following{/other_user}","gists_url":"https://api.github.com/users/darthrellimnad/gists{/gist_id}","starred_url":"https://api.github.com/users/darthrellimnad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darthrellimnad/subscriptions","organizations_url":"https://api.github.com/users/darthrellimnad/orgs","repos_url":"https://api.github.com/users/darthrellimnad/repos","events_url":"https://api.github.com/users/darthrellimnad/events{/privacy}","received_events_url":"https://api.github.com/users/darthrellimnad/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-21T18:35:32Z","updated_at":"2018-03-21T18:37:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/leoasis/redux-immutable-state-invariant/pulls/35","html_url":"https://github.com/leoasis/redux-immutable-state-invariant/pull/35","diff_url":"https://github.com/leoasis/redux-immutable-state-invariant/pull/35.diff","patch_url":"https://github.com/leoasis/redux-immutable-state-invariant/pull/35.patch"},"body":"I looked in to this issue a while back, but failed and put it aside for a while :).  Recently I revisited this and got something working that might help resolve issue #28 .\r\n\r\nFeel free to suggest alternate methods :).  The way I found workable (while keeping backwards compatibility) was track nodes in redux state in `Map` objects internally by converting all Object, Arrays, and Sets to Maps when storing them in the internal \"tracker\" data structure (Arrays and Sets then use elt \"index\" as the Map \"key\", similar to how arrays worked before).  This allows me to to treat all objects and iterables the same way when determining if a mutation has occurred. "},"comment":{"url":"https://api.github.com/repos/leoasis/redux-immutable-state-invariant/issues/comments/375052022","html_url":"https://github.com/leoasis/redux-immutable-state-invariant/pull/35#issuecomment-375052022","issue_url":"https://api.github.com/repos/leoasis/redux-immutable-state-invariant/issues/35","id":375052022,"user":{"login":"darthrellimnad","id":121980,"avatar_url":"https://avatars3.githubusercontent.com/u/121980?v=4","gravatar_id":"","url":"https://api.github.com/users/darthrellimnad","html_url":"https://github.com/darthrellimnad","followers_url":"https://api.github.com/users/darthrellimnad/followers","following_url":"https://api.github.com/users/darthrellimnad/following{/other_user}","gists_url":"https://api.github.com/users/darthrellimnad/gists{/gist_id}","starred_url":"https://api.github.com/users/darthrellimnad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darthrellimnad/subscriptions","organizations_url":"https://api.github.com/users/darthrellimnad/orgs","repos_url":"https://api.github.com/users/darthrellimnad/repos","events_url":"https://api.github.com/users/darthrellimnad/events{/privacy}","received_events_url":"https://api.github.com/users/darthrellimnad/received_events","type":"User","site_admin":false},"created_at":"2018-03-21T18:37:02Z","updated_at":"2018-03-21T18:37:02Z","author_association":"CONTRIBUTOR","body":"i was having trouble running the `npm run test:coverage` script, i just get a message saying:\r\n\r\n```\r\nNo coverage information was collected, exit without writing coverage information\r\n```\r\n\r\n...can't remember if there was a trick to running this?  I'll want to run this in case I need to add any more cases to improve coverage."}}
{"actor":{"display_login":"darthrellimnad"}}