{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/217701927","pull_request_review_id":155481088,"id":217701927,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzcwMTkyNw==","diff_hunk":"@@ -86,20 +83,24 @@\n   service_plugins.push(\"neutron_lbaas.services.loadbalancer.plugin.LoadBalancerPluginv2\")\n end\n \n-if neutron[:neutron][:networking_plugin] == \"ml2\"\n-  service_plugins.unshift(\"neutron.services.l3_router.l3_router_plugin.L3RouterPlugin\")\n+use_apic = neutron[:neutron][:networking_plugin] == \"ml2\" && \\\n+    neutron[:neutron][:ml2_mechanism_drivers].include?(\"apic_aim\")","path":"chef/cookbooks/neutron/recipes/common_config.rb","position":17,"original_position":17,"commit_id":"f2a17b79c9584963ef9d9b597142054947c6e475","original_commit_id":"f2a17b79c9584963ef9d9b597142054947c6e475","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Layout/MultilineOperationIndentation: Use 2 (not 4) spaces for indenting an expression in an assignment spanning multiple lines. (https://github.com/SUSE/style-guides/blob/master/Ruby.md#stylemultilineoperationindentation)","created_at":"2018-09-14T12:54:09Z","updated_at":"2018-09-14T12:54:09Z","html_url":"https://github.com/crowbar/crowbar-openstack/pull/1770#discussion_r217701927","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1770","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/217701927"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/1770#discussion_r217701927"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1770"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1770","id":214930841,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0OTMwODQx","html_url":"https://github.com/crowbar/crowbar-openstack/pull/1770","diff_url":"https://github.com/crowbar/crowbar-openstack/pull/1770.diff","patch_url":"https://github.com/crowbar/crowbar-openstack/pull/1770.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/1770","number":1770,"state":"open","locked":false,"title":"[WIP] neutron: [cisco-aci]: Enabling unified mode for Cisco ACI ","user":{"login":"mmnelemane","id":13483069,"node_id":"MDQ6VXNlcjEzNDgzMDY5","avatar_url":"https://avatars3.githubusercontent.com/u/13483069?v=4","gravatar_id":"","url":"https://api.github.com/users/mmnelemane","html_url":"https://github.com/mmnelemane","followers_url":"https://api.github.com/users/mmnelemane/followers","following_url":"https://api.github.com/users/mmnelemane/following{/other_user}","gists_url":"https://api.github.com/users/mmnelemane/gists{/gist_id}","starred_url":"https://api.github.com/users/mmnelemane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmnelemane/subscriptions","organizations_url":"https://api.github.com/users/mmnelemane/orgs","repos_url":"https://api.github.com/users/mmnelemane/repos","events_url":"https://api.github.com/users/mmnelemane/events{/privacy}","received_events_url":"https://api.github.com/users/mmnelemane/received_events","type":"User","site_admin":false},"body":"Cisco ACI integration with OpenStack has enabled support for deployment of a single ML2 mode for both type of driving mechanisms: ML2 and GBP. The earlier method of specifying one of the drivers in a deployment is not valid anymore and the individual ML2 driver is not supported after OpenStack Ocata. The driver is now replaced by ACI Integration Module which allows use of both ML2 and GBP modes of operation. The below commit installs and configure the AIM driver and the config files and does the corresponding changes in the neutron cookbook and Crowbar UI options. The changes are only tested so far until the changes are applied on the respective nodes and the configurations are done. The VMs are launched either as a normal Nova instance or as a Group Member using GBP. However, the testing can only be concluded if there is reliable L2 and L3 connectivity between VMs and this has not yet been established. The unified mode is relevant for Cloud 7, Cloud 8 and Cloud 9 and needs to be tested on all three platforms. Hence this is not yet ready for review or merge until there is a confirmed test on connectivity.","created_at":"2018-09-12T11:43:20Z","updated_at":"2018-09-14T12:54:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f3f9ac8db8a98ae573f50ba3acfd01485ccbaf0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":264032978,"node_id":"MDU6TGFiZWwyNjQwMzI5Nzg=","url":"https://api.github.com/repos/crowbar/crowbar-openstack/labels/do%20not%20merge%20yet","name":"do not merge yet","color":"eb6420","default":false},{"id":711258318,"node_id":"MDU6TGFiZWw3MTEyNTgzMTg=","url":"https://api.github.com/repos/crowbar/crowbar-openstack/labels/needs%20backport%20to%20SOC7","name":"needs backport to SOC7","color":"0052cc","default":false},{"id":998466110,"node_id":"MDU6TGFiZWw5OTg0NjYxMTA=","url":"https://api.github.com/repos/crowbar/crowbar-openstack/labels/needs%20backport%20to%20SOC8","name":"needs backport to SOC8","color":"0052cc","default":false},{"id":264031316,"node_id":"MDU6TGFiZWwyNjQwMzEzMTY=","url":"https://api.github.com/repos/crowbar/crowbar-openstack/labels/wip","name":"wip","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1770/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1770/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/1770/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/f2a17b79c9584963ef9d9b597142054947c6e475","head":{"label":"mmnelemane:aci_role_with_unified","ref":"aci_role_with_unified","sha":"f2a17b79c9584963ef9d9b597142054947c6e475","user":{"login":"mmnelemane","id":13483069,"node_id":"MDQ6VXNlcjEzNDgzMDY5","avatar_url":"https://avatars3.githubusercontent.com/u/13483069?v=4","gravatar_id":"","url":"https://api.github.com/users/mmnelemane","html_url":"https://github.com/mmnelemane","followers_url":"https://api.github.com/users/mmnelemane/followers","following_url":"https://api.github.com/users/mmnelemane/following{/other_user}","gists_url":"https://api.github.com/users/mmnelemane/gists{/gist_id}","starred_url":"https://api.github.com/users/mmnelemane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmnelemane/subscriptions","organizations_url":"https://api.github.com/users/mmnelemane/orgs","repos_url":"https://api.github.com/users/mmnelemane/repos","events_url":"https://api.github.com/users/mmnelemane/events{/privacy}","received_events_url":"https://api.github.com/users/mmnelemane/received_events","type":"User","site_admin":false},"repo":{"id":45601858,"node_id":"MDEwOlJlcG9zaXRvcnk0NTYwMTg1OA==","name":"crowbar-openstack","full_name":"mmnelemane/crowbar-openstack","owner":{"login":"mmnelemane","id":13483069,"node_id":"MDQ6VXNlcjEzNDgzMDY5","avatar_url":"https://avatars3.githubusercontent.com/u/13483069?v=4","gravatar_id":"","url":"https://api.github.com/users/mmnelemane","html_url":"https://github.com/mmnelemane","followers_url":"https://api.github.com/users/mmnelemane/followers","following_url":"https://api.github.com/users/mmnelemane/following{/other_user}","gists_url":"https://api.github.com/users/mmnelemane/gists{/gist_id}","starred_url":"https://api.github.com/users/mmnelemane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmnelemane/subscriptions","organizations_url":"https://api.github.com/users/mmnelemane/orgs","repos_url":"https://api.github.com/users/mmnelemane/repos","events_url":"https://api.github.com/users/mmnelemane/events{/privacy}","received_events_url":"https://api.github.com/users/mmnelemane/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmnelemane/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/mmnelemane/crowbar-openstack","forks_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/deployments","created_at":"2015-11-05T09:43:10Z","updated_at":"2018-07-05T07:38:34Z","pushed_at":"2018-09-14T12:53:54Z","git_url":"git://github.com/mmnelemane/crowbar-openstack.git","ssh_url":"git@github.com:mmnelemane/crowbar-openstack.git","clone_url":"https://github.com/mmnelemane/crowbar-openstack.git","svn_url":"https://github.com/mmnelemane/crowbar-openstack","homepage":null,"size":21389,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"4e7bd3693260a7a95c4fd78633d75adcbf7b6249","user":{"login":"crowbar","id":2910205,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTAyMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2910205?v=4","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39006903,"node_id":"MDEwOlJlcG9zaXRvcnkzOTAwNjkwMw==","name":"crowbar-openstack","full_name":"crowbar/crowbar-openstack","owner":{"login":"crowbar","id":2910205,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTAyMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2910205?v=4","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-openstack","forks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/deployments","created_at":"2015-07-13T10:55:33Z","updated_at":"2018-09-13T09:25:03Z","pushed_at":"2018-09-14T12:53:56Z","git_url":"git://github.com/crowbar/crowbar-openstack.git","ssh_url":"git@github.com:crowbar/crowbar-openstack.git","clone_url":"https://github.com/crowbar/crowbar-openstack.git","svn_url":"https://github.com/crowbar/crowbar-openstack","homepage":null,"size":21249,"stargazers_count":17,"watchers_count":17,"language":"Ruby","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":92,"license":null,"forks":83,"open_issues":92,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1770"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/1770"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/1770"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/1770/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1770/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1770/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/f2a17b79c9584963ef9d9b597142054947c6e475"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houndci-bot"}}