{"action":"created","comment":{"url":"https://api.github.com/repos/kadena-io/pact/pulls/comments/202505238","pull_request_review_id":137227985,"id":202505238,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjUwNTIzOA==","diff_hunk":"@@ -0,0 +1,693 @@\n+{-# LANGUAGE FlexibleContexts           #-}","path":"src/Pact/Analyze/Translate.hs.orig","position":1,"original_position":1,"commit_id":"e654a57f559477c40c6bc62f0b96b7828a9c08b1","original_commit_id":"e654a57f559477c40c6bc62f0b96b7828a9c08b1","user":{"login":"slpopejoy","id":8353613,"node_id":"MDQ6VXNlcjgzNTM2MTM=","avatar_url":"https://avatars2.githubusercontent.com/u/8353613?v=4","gravatar_id":"","url":"https://api.github.com/users/slpopejoy","html_url":"https://github.com/slpopejoy","followers_url":"https://api.github.com/users/slpopejoy/followers","following_url":"https://api.github.com/users/slpopejoy/following{/other_user}","gists_url":"https://api.github.com/users/slpopejoy/gists{/gist_id}","starred_url":"https://api.github.com/users/slpopejoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slpopejoy/subscriptions","organizations_url":"https://api.github.com/users/slpopejoy/orgs","repos_url":"https://api.github.com/users/slpopejoy/repos","events_url":"https://api.github.com/users/slpopejoy/events{/privacy}","received_events_url":"https://api.github.com/users/slpopejoy/received_events","type":"User","site_admin":false},"body":"Delete?","created_at":"2018-07-14T04:10:03Z","updated_at":"2018-07-14T04:13:51Z","html_url":"https://github.com/kadena-io/pact/pull/145#discussion_r202505238","pull_request_url":"https://api.github.com/repos/kadena-io/pact/pulls/145","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kadena-io/pact/pulls/comments/202505238"},"html":{"href":"https://github.com/kadena-io/pact/pull/145#discussion_r202505238"},"pull_request":{"href":"https://api.github.com/repos/kadena-io/pact/pulls/145"}}},"pull_request":{"url":"https://api.github.com/repos/kadena-io/pact/pulls/145","id":198114878,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MTE0ODc4","html_url":"https://github.com/kadena-io/pact/pull/145","diff_url":"https://github.com/kadena-io/pact/pull/145.diff","patch_url":"https://github.com/kadena-io/pact/pull/145.patch","issue_url":"https://api.github.com/repos/kadena-io/pact/issues/145","number":145,"state":"open","locked":false,"title":"Improved analysis error messages, prop typechecking; generalized row-level props","user":{"login":"bts","id":5743,"node_id":"MDQ6VXNlcjU3NDM=","avatar_url":"https://avatars1.githubusercontent.com/u/5743?v=4","gravatar_id":"","url":"https://api.github.com/users/bts","html_url":"https://github.com/bts","followers_url":"https://api.github.com/users/bts/followers","following_url":"https://api.github.com/users/bts/following{/other_user}","gists_url":"https://api.github.com/users/bts/gists{/gist_id}","starred_url":"https://api.github.com/users/bts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bts/subscriptions","organizations_url":"https://api.github.com/users/bts/orgs","repos_url":"https://api.github.com/users/bts/repos","events_url":"https://api.github.com/users/bts/events{/privacy}","received_events_url":"https://api.github.com/users/bts/received_events","type":"User","site_admin":false},"body":"This is ~~*just* about~~ ready to go. ~~I need to work-around a [haddock issue](https://github.com/haskell/haddock/issues/43) related to postfix comments in combination with GADTs.~~\r\n\r\n- We've employed a \"tagging\" technique to improve error messages from:\r\n\r\n```\r\nInvalidating model found: from = \"\" :: String, to = \"\" :: String, amount = -39 :: Integer\r\n```\r\n\r\nto now include information about DB reads, writes, variable bindings, and keyset authorizations:\r\n\r\n```\r\nInvalidating model found:\r\n  Arguments:\r\n    acct := \"\"\r\n    argks := KeySet 1\r\n\r\n  Variables:\r\n    b := -1\r\n    row-ks := KeySet 2\r\n    x := \"\"\r\n\r\n  Reads:\r\n    \"\" => { balance: -1, ks: KeySet 2 }\r\n\r\n  Writes:\r\n    \"\" => { balance: 0, ks: KeySet 0 }\r\n    \"\" => { balance: 0, ks: KeySet 0 }\r\n\r\n  Keysets:\r\n    authorized:   argument argks\r\n    authorized:   database keyset at (accounts, 'ks, \"\")\r\n\r\n  Result:\r\n    -1\r\n```\r\n\r\n- We've also improved typechecking for columns in properties\r\n- `RowRead` and `RowWrite` been generalized from booleans to the number of times a row is read or written.\r\n\r\n/cc @joelburget","created_at":"2018-06-28T18:29:03Z","updated_at":"2018-07-14T04:13:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0eaf826fd7372e3e8d2f9ced8f15eb39970f2b32","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kadena-io/pact/pulls/145/commits","review_comments_url":"https://api.github.com/repos/kadena-io/pact/pulls/145/comments","review_comment_url":"https://api.github.com/repos/kadena-io/pact/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kadena-io/pact/issues/145/comments","statuses_url":"https://api.github.com/repos/kadena-io/pact/statuses/e654a57f559477c40c6bc62f0b96b7828a9c08b1","head":{"label":"kadena-io:analyze","ref":"analyze","sha":"e654a57f559477c40c6bc62f0b96b7828a9c08b1","user":{"login":"kadena-io","id":19830776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5ODMwNzc2","avatar_url":"https://avatars1.githubusercontent.com/u/19830776?v=4","gravatar_id":"","url":"https://api.github.com/users/kadena-io","html_url":"https://github.com/kadena-io","followers_url":"https://api.github.com/users/kadena-io/followers","following_url":"https://api.github.com/users/kadena-io/following{/other_user}","gists_url":"https://api.github.com/users/kadena-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kadena-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadena-io/subscriptions","organizations_url":"https://api.github.com/users/kadena-io/orgs","repos_url":"https://api.github.com/users/kadena-io/repos","events_url":"https://api.github.com/users/kadena-io/events{/privacy}","received_events_url":"https://api.github.com/users/kadena-io/received_events","type":"Organization","site_admin":false},"repo":{"id":73597023,"node_id":"MDEwOlJlcG9zaXRvcnk3MzU5NzAyMw==","name":"pact","full_name":"kadena-io/pact","owner":{"login":"kadena-io","id":19830776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5ODMwNzc2","avatar_url":"https://avatars1.githubusercontent.com/u/19830776?v=4","gravatar_id":"","url":"https://api.github.com/users/kadena-io","html_url":"https://github.com/kadena-io","followers_url":"https://api.github.com/users/kadena-io/followers","following_url":"https://api.github.com/users/kadena-io/following{/other_user}","gists_url":"https://api.github.com/users/kadena-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kadena-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadena-io/subscriptions","organizations_url":"https://api.github.com/users/kadena-io/orgs","repos_url":"https://api.github.com/users/kadena-io/repos","events_url":"https://api.github.com/users/kadena-io/events{/privacy}","received_events_url":"https://api.github.com/users/kadena-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kadena-io/pact","description":"The Pact Smart Contract Language","fork":false,"url":"https://api.github.com/repos/kadena-io/pact","forks_url":"https://api.github.com/repos/kadena-io/pact/forks","keys_url":"https://api.github.com/repos/kadena-io/pact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kadena-io/pact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kadena-io/pact/teams","hooks_url":"https://api.github.com/repos/kadena-io/pact/hooks","issue_events_url":"https://api.github.com/repos/kadena-io/pact/issues/events{/number}","events_url":"https://api.github.com/repos/kadena-io/pact/events","assignees_url":"https://api.github.com/repos/kadena-io/pact/assignees{/user}","branches_url":"https://api.github.com/repos/kadena-io/pact/branches{/branch}","tags_url":"https://api.github.com/repos/kadena-io/pact/tags","blobs_url":"https://api.github.com/repos/kadena-io/pact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kadena-io/pact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kadena-io/pact/git/refs{/sha}","trees_url":"https://api.github.com/repos/kadena-io/pact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kadena-io/pact/statuses/{sha}","languages_url":"https://api.github.com/repos/kadena-io/pact/languages","stargazers_url":"https://api.github.com/repos/kadena-io/pact/stargazers","contributors_url":"https://api.github.com/repos/kadena-io/pact/contributors","subscribers_url":"https://api.github.com/repos/kadena-io/pact/subscribers","subscription_url":"https://api.github.com/repos/kadena-io/pact/subscription","commits_url":"https://api.github.com/repos/kadena-io/pact/commits{/sha}","git_commits_url":"https://api.github.com/repos/kadena-io/pact/git/commits{/sha}","comments_url":"https://api.github.com/repos/kadena-io/pact/comments{/number}","issue_comment_url":"https://api.github.com/repos/kadena-io/pact/issues/comments{/number}","contents_url":"https://api.github.com/repos/kadena-io/pact/contents/{+path}","compare_url":"https://api.github.com/repos/kadena-io/pact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kadena-io/pact/merges","archive_url":"https://api.github.com/repos/kadena-io/pact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kadena-io/pact/downloads","issues_url":"https://api.github.com/repos/kadena-io/pact/issues{/number}","pulls_url":"https://api.github.com/repos/kadena-io/pact/pulls{/number}","milestones_url":"https://api.github.com/repos/kadena-io/pact/milestones{/number}","notifications_url":"https://api.github.com/repos/kadena-io/pact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kadena-io/pact/labels{/name}","releases_url":"https://api.github.com/repos/kadena-io/pact/releases{/id}","deployments_url":"https://api.github.com/repos/kadena-io/pact/deployments","created_at":"2016-11-13T05:16:00Z","updated_at":"2018-07-12T19:31:12Z","pushed_at":"2018-07-13T17:43:41Z","git_url":"git://github.com/kadena-io/pact.git","ssh_url":"git@github.com:kadena-io/pact.git","clone_url":"https://github.com/kadena-io/pact.git","svn_url":"https://github.com/kadena-io/pact","homepage":"http://kadena.io/pact","size":2508,"stargazers_count":204,"watchers_count":204,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":20,"open_issues":46,"watchers":204,"default_branch":"master"}},"base":{"label":"kadena-io:master","ref":"master","sha":"567e076ebc459ebf172836624d4df64be81722a7","user":{"login":"kadena-io","id":19830776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5ODMwNzc2","avatar_url":"https://avatars1.githubusercontent.com/u/19830776?v=4","gravatar_id":"","url":"https://api.github.com/users/kadena-io","html_url":"https://github.com/kadena-io","followers_url":"https://api.github.com/users/kadena-io/followers","following_url":"https://api.github.com/users/kadena-io/following{/other_user}","gists_url":"https://api.github.com/users/kadena-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kadena-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadena-io/subscriptions","organizations_url":"https://api.github.com/users/kadena-io/orgs","repos_url":"https://api.github.com/users/kadena-io/repos","events_url":"https://api.github.com/users/kadena-io/events{/privacy}","received_events_url":"https://api.github.com/users/kadena-io/received_events","type":"Organization","site_admin":false},"repo":{"id":73597023,"node_id":"MDEwOlJlcG9zaXRvcnk3MzU5NzAyMw==","name":"pact","full_name":"kadena-io/pact","owner":{"login":"kadena-io","id":19830776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5ODMwNzc2","avatar_url":"https://avatars1.githubusercontent.com/u/19830776?v=4","gravatar_id":"","url":"https://api.github.com/users/kadena-io","html_url":"https://github.com/kadena-io","followers_url":"https://api.github.com/users/kadena-io/followers","following_url":"https://api.github.com/users/kadena-io/following{/other_user}","gists_url":"https://api.github.com/users/kadena-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kadena-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadena-io/subscriptions","organizations_url":"https://api.github.com/users/kadena-io/orgs","repos_url":"https://api.github.com/users/kadena-io/repos","events_url":"https://api.github.com/users/kadena-io/events{/privacy}","received_events_url":"https://api.github.com/users/kadena-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kadena-io/pact","description":"The Pact Smart Contract Language","fork":false,"url":"https://api.github.com/repos/kadena-io/pact","forks_url":"https://api.github.com/repos/kadena-io/pact/forks","keys_url":"https://api.github.com/repos/kadena-io/pact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kadena-io/pact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kadena-io/pact/teams","hooks_url":"https://api.github.com/repos/kadena-io/pact/hooks","issue_events_url":"https://api.github.com/repos/kadena-io/pact/issues/events{/number}","events_url":"https://api.github.com/repos/kadena-io/pact/events","assignees_url":"https://api.github.com/repos/kadena-io/pact/assignees{/user}","branches_url":"https://api.github.com/repos/kadena-io/pact/branches{/branch}","tags_url":"https://api.github.com/repos/kadena-io/pact/tags","blobs_url":"https://api.github.com/repos/kadena-io/pact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kadena-io/pact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kadena-io/pact/git/refs{/sha}","trees_url":"https://api.github.com/repos/kadena-io/pact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kadena-io/pact/statuses/{sha}","languages_url":"https://api.github.com/repos/kadena-io/pact/languages","stargazers_url":"https://api.github.com/repos/kadena-io/pact/stargazers","contributors_url":"https://api.github.com/repos/kadena-io/pact/contributors","subscribers_url":"https://api.github.com/repos/kadena-io/pact/subscribers","subscription_url":"https://api.github.com/repos/kadena-io/pact/subscription","commits_url":"https://api.github.com/repos/kadena-io/pact/commits{/sha}","git_commits_url":"https://api.github.com/repos/kadena-io/pact/git/commits{/sha}","comments_url":"https://api.github.com/repos/kadena-io/pact/comments{/number}","issue_comment_url":"https://api.github.com/repos/kadena-io/pact/issues/comments{/number}","contents_url":"https://api.github.com/repos/kadena-io/pact/contents/{+path}","compare_url":"https://api.github.com/repos/kadena-io/pact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kadena-io/pact/merges","archive_url":"https://api.github.com/repos/kadena-io/pact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kadena-io/pact/downloads","issues_url":"https://api.github.com/repos/kadena-io/pact/issues{/number}","pulls_url":"https://api.github.com/repos/kadena-io/pact/pulls{/number}","milestones_url":"https://api.github.com/repos/kadena-io/pact/milestones{/number}","notifications_url":"https://api.github.com/repos/kadena-io/pact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kadena-io/pact/labels{/name}","releases_url":"https://api.github.com/repos/kadena-io/pact/releases{/id}","deployments_url":"https://api.github.com/repos/kadena-io/pact/deployments","created_at":"2016-11-13T05:16:00Z","updated_at":"2018-07-12T19:31:12Z","pushed_at":"2018-07-13T17:43:41Z","git_url":"git://github.com/kadena-io/pact.git","ssh_url":"git@github.com:kadena-io/pact.git","clone_url":"https://github.com/kadena-io/pact.git","svn_url":"https://github.com/kadena-io/pact","homepage":"http://kadena.io/pact","size":2508,"stargazers_count":204,"watchers_count":204,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":20,"open_issues":46,"watchers":204,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kadena-io/pact/pulls/145"},"html":{"href":"https://github.com/kadena-io/pact/pull/145"},"issue":{"href":"https://api.github.com/repos/kadena-io/pact/issues/145"},"comments":{"href":"https://api.github.com/repos/kadena-io/pact/issues/145/comments"},"review_comments":{"href":"https://api.github.com/repos/kadena-io/pact/pulls/145/comments"},"review_comment":{"href":"https://api.github.com/repos/kadena-io/pact/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kadena-io/pact/pulls/145/commits"},"statuses":{"href":"https://api.github.com/repos/kadena-io/pact/statuses/e654a57f559477c40c6bc62f0b96b7828a9c08b1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"slpopejoy"}}