{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/comments/232810490","pull_request_review_id":174091882,"id":232810490,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjgxMDQ5MA==","diff_hunk":"@@ -7302,6 +7302,10 @@ spv::Id TGlslangToSpvTraverser::createSpvConstant(const glslang::TIntermTyped& n\n         } else if (auto* const_union_array = &sn->getConstArray()) {\n             int nextConst = 0;\n             result = createSpvConstantFromConstUnionArray(sn->getType(), *const_union_array, nextConst, true);\n+        } else {\n+            logger->missingFunctionality(\"Invalid initializer for spec onstant.\");\n+            exit(1);\n+            return spv::NoResult;","path":"SPIRV/GlslangToSpv.cpp","position":7,"original_position":7,"commit_id":"70661b9c084fdb88ae1820cf4e8ffcdec28bb0b4","original_commit_id":"70661b9c084fdb88ae1820cf4e8ffcdec28bb0b4","user":{"login":"dj2","id":9611,"node_id":"MDQ6VXNlcjk2MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/9611?v=4","gravatar_id":"","url":"https://api.github.com/users/dj2","html_url":"https://github.com/dj2","followers_url":"https://api.github.com/users/dj2/followers","following_url":"https://api.github.com/users/dj2/following{/other_user}","gists_url":"https://api.github.com/users/dj2/gists{/gist_id}","starred_url":"https://api.github.com/users/dj2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dj2/subscriptions","organizations_url":"https://api.github.com/users/dj2/orgs","repos_url":"https://api.github.com/users/dj2/repos","events_url":"https://api.github.com/users/dj2/events{/privacy}","received_events_url":"https://api.github.com/users/dj2/received_events","type":"User","site_admin":false},"body":"The existing code returns spv::NoResult, so I assume it's handled?\r\n\r\nIt generates a compiler error because Result can be used uninitialized. I can disable that warning when building glslang if needed.","created_at":"2018-11-12T21:02:51Z","updated_at":"2018-11-12T21:02:51Z","html_url":"https://github.com/KhronosGroup/glslang/pull/1571#discussion_r232810490","pull_request_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/1571","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/comments/232810490"},"html":{"href":"https://github.com/KhronosGroup/glslang/pull/1571#discussion_r232810490"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/1571"}},"in_reply_to_id":232807777},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/1571","id":230236131,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMjM2MTMx","html_url":"https://github.com/KhronosGroup/glslang/pull/1571","diff_url":"https://github.com/KhronosGroup/glslang/pull/1571.diff","patch_url":"https://github.com/KhronosGroup/glslang/pull/1571.patch","issue_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/1571","number":1571,"state":"open","locked":false,"title":"Handle potentially uninitialized result","user":{"login":"dj2","id":9611,"node_id":"MDQ6VXNlcjk2MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/9611?v=4","gravatar_id":"","url":"https://api.github.com/users/dj2","html_url":"https://github.com/dj2","followers_url":"https://api.github.com/users/dj2/followers","following_url":"https://api.github.com/users/dj2/following{/other_user}","gists_url":"https://api.github.com/users/dj2/gists{/gist_id}","starred_url":"https://api.github.com/users/dj2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dj2/subscriptions","organizations_url":"https://api.github.com/users/dj2/orgs","repos_url":"https://api.github.com/users/dj2/repos","events_url":"https://api.github.com/users/dj2/events{/privacy}","received_events_url":"https://api.github.com/users/dj2/received_events","type":"User","site_admin":false},"body":"In the case where the if and else if are both false the spv::Id result will be used uninitialized in the builder.addName call. If this happens, return an error instead of attempting to use result.","created_at":"2018-11-12T19:00:10Z","updated_at":"2018-11-12T21:02:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5cb23e579e3242eaaa19fc3e1e19206acc7cce8f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/1571/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/1571/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/1571/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/glslang/statuses/70661b9c084fdb88ae1820cf4e8ffcdec28bb0b4","head":{"label":"dj2:result","ref":"result","sha":"70661b9c084fdb88ae1820cf4e8ffcdec28bb0b4","user":{"login":"dj2","id":9611,"node_id":"MDQ6VXNlcjk2MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/9611?v=4","gravatar_id":"","url":"https://api.github.com/users/dj2","html_url":"https://github.com/dj2","followers_url":"https://api.github.com/users/dj2/followers","following_url":"https://api.github.com/users/dj2/following{/other_user}","gists_url":"https://api.github.com/users/dj2/gists{/gist_id}","starred_url":"https://api.github.com/users/dj2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dj2/subscriptions","organizations_url":"https://api.github.com/users/dj2/orgs","repos_url":"https://api.github.com/users/dj2/repos","events_url":"https://api.github.com/users/dj2/events{/privacy}","received_events_url":"https://api.github.com/users/dj2/received_events","type":"User","site_admin":false},"repo":{"id":150157696,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAxNTc2OTY=","name":"glslang","full_name":"dj2/glslang","private":false,"owner":{"login":"dj2","id":9611,"node_id":"MDQ6VXNlcjk2MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/9611?v=4","gravatar_id":"","url":"https://api.github.com/users/dj2","html_url":"https://github.com/dj2","followers_url":"https://api.github.com/users/dj2/followers","following_url":"https://api.github.com/users/dj2/following{/other_user}","gists_url":"https://api.github.com/users/dj2/gists{/gist_id}","starred_url":"https://api.github.com/users/dj2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dj2/subscriptions","organizations_url":"https://api.github.com/users/dj2/orgs","repos_url":"https://api.github.com/users/dj2/repos","events_url":"https://api.github.com/users/dj2/events{/privacy}","received_events_url":"https://api.github.com/users/dj2/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dj2/glslang","description":"Khronos reference front-end for GLSL and ESSL","fork":true,"url":"https://api.github.com/repos/dj2/glslang","forks_url":"https://api.github.com/repos/dj2/glslang/forks","keys_url":"https://api.github.com/repos/dj2/glslang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dj2/glslang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dj2/glslang/teams","hooks_url":"https://api.github.com/repos/dj2/glslang/hooks","issue_events_url":"https://api.github.com/repos/dj2/glslang/issues/events{/number}","events_url":"https://api.github.com/repos/dj2/glslang/events","assignees_url":"https://api.github.com/repos/dj2/glslang/assignees{/user}","branches_url":"https://api.github.com/repos/dj2/glslang/branches{/branch}","tags_url":"https://api.github.com/repos/dj2/glslang/tags","blobs_url":"https://api.github.com/repos/dj2/glslang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dj2/glslang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dj2/glslang/git/refs{/sha}","trees_url":"https://api.github.com/repos/dj2/glslang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dj2/glslang/statuses/{sha}","languages_url":"https://api.github.com/repos/dj2/glslang/languages","stargazers_url":"https://api.github.com/repos/dj2/glslang/stargazers","contributors_url":"https://api.github.com/repos/dj2/glslang/contributors","subscribers_url":"https://api.github.com/repos/dj2/glslang/subscribers","subscription_url":"https://api.github.com/repos/dj2/glslang/subscription","commits_url":"https://api.github.com/repos/dj2/glslang/commits{/sha}","git_commits_url":"https://api.github.com/repos/dj2/glslang/git/commits{/sha}","comments_url":"https://api.github.com/repos/dj2/glslang/comments{/number}","issue_comment_url":"https://api.github.com/repos/dj2/glslang/issues/comments{/number}","contents_url":"https://api.github.com/repos/dj2/glslang/contents/{+path}","compare_url":"https://api.github.com/repos/dj2/glslang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dj2/glslang/merges","archive_url":"https://api.github.com/repos/dj2/glslang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dj2/glslang/downloads","issues_url":"https://api.github.com/repos/dj2/glslang/issues{/number}","pulls_url":"https://api.github.com/repos/dj2/glslang/pulls{/number}","milestones_url":"https://api.github.com/repos/dj2/glslang/milestones{/number}","notifications_url":"https://api.github.com/repos/dj2/glslang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dj2/glslang/labels{/name}","releases_url":"https://api.github.com/repos/dj2/glslang/releases{/id}","deployments_url":"https://api.github.com/repos/dj2/glslang/deployments","created_at":"2018-09-24T19:33:28Z","updated_at":"2018-11-12T18:50:24Z","pushed_at":"2018-11-12T18:58:45Z","git_url":"git://github.com/dj2/glslang.git","ssh_url":"git@github.com:dj2/glslang.git","clone_url":"https://github.com/dj2/glslang.git","svn_url":"https://github.com/dj2/glslang","homepage":null,"size":46360,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"d509a5eec6f5a65b3ffdfa0a19096f338d2582be","user":{"login":"KhronosGroup","id":1608701,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDg3MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1608701?v=4","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":38064932,"node_id":"MDEwOlJlcG9zaXRvcnkzODA2NDkzMg==","name":"glslang","full_name":"KhronosGroup/glslang","private":false,"owner":{"login":"KhronosGroup","id":1608701,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDg3MDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1608701?v=4","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/KhronosGroup/glslang","description":"Khronos reference front-end for GLSL and ESSL, and sample SPIR-V generator","fork":false,"url":"https://api.github.com/repos/KhronosGroup/glslang","forks_url":"https://api.github.com/repos/KhronosGroup/glslang/forks","keys_url":"https://api.github.com/repos/KhronosGroup/glslang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/glslang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/glslang/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/glslang/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/glslang/events","assignees_url":"https://api.github.com/repos/KhronosGroup/glslang/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/glslang/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/glslang/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/glslang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/glslang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/glslang/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/glslang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/glslang/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/glslang/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/glslang/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/glslang/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/glslang/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/glslang/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/glslang/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/glslang/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/glslang/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/glslang/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/glslang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/glslang/merges","archive_url":"https://api.github.com/repos/KhronosGroup/glslang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/glslang/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/glslang/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/glslang/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/glslang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/glslang/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/glslang/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/glslang/deployments","created_at":"2015-06-25T17:54:39Z","updated_at":"2018-11-12T19:56:05Z","pushed_at":"2018-11-12T19:00:11Z","git_url":"git://github.com/KhronosGroup/glslang.git","ssh_url":"git@github.com:KhronosGroup/glslang.git","clone_url":"https://github.com/KhronosGroup/glslang.git","svn_url":"https://github.com/KhronosGroup/glslang","homepage":"","size":47818,"stargazers_count":892,"watchers_count":892,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":286,"mirror_url":null,"archived":false,"open_issues_count":168,"license":null,"forks":286,"open_issues":168,"watchers":892,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/1571"},"html":{"href":"https://github.com/KhronosGroup/glslang/pull/1571"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/glslang/issues/1571"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/glslang/issues/1571/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/1571/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/1571/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/glslang/statuses/70661b9c084fdb88ae1820cf4e8ffcdec28bb0b4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dj2"}}