{"action":"created","issue":{"url":"https://api.github.com/repos/idaholab/moose/issues/11049","repository_url":"https://api.github.com/repos/idaholab/moose","labels_url":"https://api.github.com/repos/idaholab/moose/issues/11049/labels{/name}","comments_url":"https://api.github.com/repos/idaholab/moose/issues/11049/comments","events_url":"https://api.github.com/repos/idaholab/moose/issues/11049/events","html_url":"https://github.com/idaholab/moose/issues/11049","id":306237380,"number":11049,"title":"Enhance chemical reactions (just in PorousFlow?) to multiphase situations","user":{"login":"WilkAndy","id":6676821,"avatar_url":"https://avatars1.githubusercontent.com/u/6676821?v=4","gravatar_id":"","url":"https://api.github.com/users/WilkAndy","html_url":"https://github.com/WilkAndy","followers_url":"https://api.github.com/users/WilkAndy/followers","following_url":"https://api.github.com/users/WilkAndy/following{/other_user}","gists_url":"https://api.github.com/users/WilkAndy/gists{/gist_id}","starred_url":"https://api.github.com/users/WilkAndy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WilkAndy/subscriptions","organizations_url":"https://api.github.com/users/WilkAndy/orgs","repos_url":"https://api.github.com/users/WilkAndy/repos","events_url":"https://api.github.com/users/WilkAndy/events{/privacy}","received_events_url":"https://api.github.com/users/WilkAndy/received_events","type":"User","site_admin":false},"labels":[{"id":84758334,"url":"https://api.github.com/repos/idaholab/moose/labels/C:%20Modules","name":"C: Modules","color":"0052cc","default":false},{"id":80663266,"url":"https://api.github.com/repos/idaholab/moose/labels/P:%20normal","name":"P: normal","color":"ededed","default":false},{"id":80663264,"url":"https://api.github.com/repos/idaholab/moose/labels/T:%20task","name":"T: task","color":"cccccc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-18T12:48:29Z","updated_at":"2018-03-18T20:28:30Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"## Rationale\r\n\r\nCurrently the chemical reactions (module and those in PorousFlow) are only relevant for aqueous chemistry where the liquid saturation is assumed to be unity.  The ETH people use the aqueous chemistry, but in multiphase situations, and this is a pretty simple enhancement (multiply by S_liquid in various places).\r\n\r\nI'm not sure whether this is relevant to the chemical_reactions module.  In any case, i won't be enhancing the stuff there as part of this Issue.  What do you think, @cpgr ?  Should chemical_reactions just work for one phase?  What's its overall design and goals?  If you think this enhancement is warranted in chemical_reactions, do you want to do it as part of this Issue?\r\n\r\n<!--What is the reason for this enhancement or what error are you reporting?-->\r\n\r\n## Description\r\n\r\n<!--Provide details of the enhancement or instructions for reproducing the error.-->\r\n\r\nIn PorousFlow the \"aqueous_saturation\" will have to appear in one formula:\r\n\r\nM = M_old + phi_old * aqueous_saturation * reaction_rate * dt\r\n\r\nThese classes have this formula:\r\n\r\n   * Kernel: PorousFlowPreDis                                                                                    \r\n   * Material: PorousFlowPorosity                                                                                \r\n   * Material: PorousFlowAqueousPreDisChemistry                                                                  \r\n   * Material: PorousFlowAqueousPreDisMineral                                                                    \r\n \r\nI think i'll include another parameter in the PorousFlowDictator which is aqueous_phase_number, and then the user interface to the above classes won't have to change as i'll just multiply by _saturation[_qp][aqueous_phase_number] at the appropriate place.\r\n\r\n## Impact\r\n\r\n<!--How will the changes impact the code, developers, and users? Discuss changes to the\r\ninternal interfaces and public API.-->\r\n\r\nAbility to do aqueous chemistry in multi-phase scenarios.\r\n"},"comment":{"url":"https://api.github.com/repos/idaholab/moose/issues/comments/374042622","html_url":"https://github.com/idaholab/moose/issues/11049#issuecomment-374042622","issue_url":"https://api.github.com/repos/idaholab/moose/issues/11049","id":374042622,"user":{"login":"cpgr","id":7664823,"avatar_url":"https://avatars3.githubusercontent.com/u/7664823?v=4","gravatar_id":"","url":"https://api.github.com/users/cpgr","html_url":"https://github.com/cpgr","followers_url":"https://api.github.com/users/cpgr/followers","following_url":"https://api.github.com/users/cpgr/following{/other_user}","gists_url":"https://api.github.com/users/cpgr/gists{/gist_id}","starred_url":"https://api.github.com/users/cpgr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpgr/subscriptions","organizations_url":"https://api.github.com/users/cpgr/orgs","repos_url":"https://api.github.com/users/cpgr/repos","events_url":"https://api.github.com/users/cpgr/events{/privacy}","received_events_url":"https://api.github.com/users/cpgr/received_events","type":"User","site_admin":false},"created_at":"2018-03-18T20:28:30Z","updated_at":"2018-03-18T20:28:30Z","author_association":"CONTRIBUTOR","body":"At the moment, the chemical reactions module isn't set up for multiple phases at all. I'm not sure how messy it would be to add to it."}}
{"actor":{"display_login":"cpgr"}}