{"action":"created","comment":{"url":"https://api.github.com/repos/alex/django-taggit/pulls/comments/209440753","pull_request_review_id":145460481,"id":209440753,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTQ0MDc1Mw==","diff_hunk":"@@ -664,30 +667,6 @@ class TaggableManagerDirectTestCase(TaggableManagerTestCase):\n     taggeditem_model = TaggedFood\n \n \n-class TaggableManagerDirectCustomPKTestCase(TaggableManagerTestCase):","path":"tests/tests.py","position":35,"original_position":35,"commit_id":"f65744594d560c85b4cfb45a6b905635033f24bf","original_commit_id":"f65744594d560c85b4cfb45a6b905635033f24bf","user":{"login":"jdufresne","id":347634,"node_id":"MDQ6VXNlcjM0NzYzNA==","avatar_url":"https://avatars1.githubusercontent.com/u/347634?v=4","gravatar_id":"","url":"https://api.github.com/users/jdufresne","html_url":"https://github.com/jdufresne","followers_url":"https://api.github.com/users/jdufresne/followers","following_url":"https://api.github.com/users/jdufresne/following{/other_user}","gists_url":"https://api.github.com/users/jdufresne/gists{/gist_id}","starred_url":"https://api.github.com/users/jdufresne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdufresne/subscriptions","organizations_url":"https://api.github.com/users/jdufresne/orgs","repos_url":"https://api.github.com/users/jdufresne/repos","events_url":"https://api.github.com/users/jdufresne/events{/privacy}","received_events_url":"https://api.github.com/users/jdufresne/received_events","type":"User","site_admin":false},"body":"I think the test case should remain as it inherits several test functions that we still want to run.\r\n\r\nI suppose this highlights the purpose of the TODO comment. It is overriding the test from the base class to avoid a failure. Is that right? If so, maybe it is sufficient to simply remove the word \"TODO\" but keep the remainder of the comment to explain why the test is skipped.","created_at":"2018-08-12T00:57:05Z","updated_at":"2018-08-12T00:57:05Z","html_url":"https://github.com/alex/django-taggit/pull/487#discussion_r209440753","pull_request_url":"https://api.github.com/repos/alex/django-taggit/pulls/487","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/alex/django-taggit/pulls/comments/209440753"},"html":{"href":"https://github.com/alex/django-taggit/pull/487#discussion_r209440753"},"pull_request":{"href":"https://api.github.com/repos/alex/django-taggit/pulls/487"}}},"pull_request":{"url":"https://api.github.com/repos/alex/django-taggit/pulls/487","id":119328947,"node_id":"MDExOlB1bGxSZXF1ZXN0MTE5MzI4OTQ3","html_url":"https://github.com/alex/django-taggit/pull/487","diff_url":"https://github.com/alex/django-taggit/pull/487.diff","patch_url":"https://github.com/alex/django-taggit/pull/487.patch","issue_url":"https://api.github.com/repos/alex/django-taggit/issues/487","number":487,"state":"open","locked":false,"title":"Add missing tests for required primary key","user":{"login":"atombrella","id":6141390,"node_id":"MDQ6VXNlcjYxNDEzOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/6141390?v=4","gravatar_id":"","url":"https://api.github.com/users/atombrella","html_url":"https://github.com/atombrella","followers_url":"https://api.github.com/users/atombrella/followers","following_url":"https://api.github.com/users/atombrella/following{/other_user}","gists_url":"https://api.github.com/users/atombrella/gists{/gist_id}","starred_url":"https://api.github.com/users/atombrella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atombrella/subscriptions","organizations_url":"https://api.github.com/users/atombrella/orgs","repos_url":"https://api.github.com/users/atombrella/repos","events_url":"https://api.github.com/users/atombrella/events{/privacy}","received_events_url":"https://api.github.com/users/atombrella/received_events","type":"User","site_admin":false},"body":"I searched, and this seems like one possible way to test that's something has been saved or not.","created_at":"2017-05-07T07:11:55Z","updated_at":"2018-08-12T00:57:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ee81bfca755c542964c904b49e5ed0b8fe671e6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alex/django-taggit/pulls/487/commits","review_comments_url":"https://api.github.com/repos/alex/django-taggit/pulls/487/comments","review_comment_url":"https://api.github.com/repos/alex/django-taggit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alex/django-taggit/issues/487/comments","statuses_url":"https://api.github.com/repos/alex/django-taggit/statuses/f65744594d560c85b4cfb45a6b905635033f24bf","head":{"label":"atombrella:test_pk","ref":"test_pk","sha":"f65744594d560c85b4cfb45a6b905635033f24bf","user":{"login":"atombrella","id":6141390,"node_id":"MDQ6VXNlcjYxNDEzOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/6141390?v=4","gravatar_id":"","url":"https://api.github.com/users/atombrella","html_url":"https://github.com/atombrella","followers_url":"https://api.github.com/users/atombrella/followers","following_url":"https://api.github.com/users/atombrella/following{/other_user}","gists_url":"https://api.github.com/users/atombrella/gists{/gist_id}","starred_url":"https://api.github.com/users/atombrella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atombrella/subscriptions","organizations_url":"https://api.github.com/users/atombrella/orgs","repos_url":"https://api.github.com/users/atombrella/repos","events_url":"https://api.github.com/users/atombrella/events{/privacy}","received_events_url":"https://api.github.com/users/atombrella/received_events","type":"User","site_admin":false},"repo":{"id":88405700,"node_id":"MDEwOlJlcG9zaXRvcnk4ODQwNTcwMA==","name":"django-taggit","full_name":"atombrella/django-taggit","owner":{"login":"atombrella","id":6141390,"node_id":"MDQ6VXNlcjYxNDEzOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/6141390?v=4","gravatar_id":"","url":"https://api.github.com/users/atombrella","html_url":"https://github.com/atombrella","followers_url":"https://api.github.com/users/atombrella/followers","following_url":"https://api.github.com/users/atombrella/following{/other_user}","gists_url":"https://api.github.com/users/atombrella/gists{/gist_id}","starred_url":"https://api.github.com/users/atombrella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atombrella/subscriptions","organizations_url":"https://api.github.com/users/atombrella/orgs","repos_url":"https://api.github.com/users/atombrella/repos","events_url":"https://api.github.com/users/atombrella/events{/privacy}","received_events_url":"https://api.github.com/users/atombrella/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/atombrella/django-taggit","description":"Simple tagging for django","fork":true,"url":"https://api.github.com/repos/atombrella/django-taggit","forks_url":"https://api.github.com/repos/atombrella/django-taggit/forks","keys_url":"https://api.github.com/repos/atombrella/django-taggit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atombrella/django-taggit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atombrella/django-taggit/teams","hooks_url":"https://api.github.com/repos/atombrella/django-taggit/hooks","issue_events_url":"https://api.github.com/repos/atombrella/django-taggit/issues/events{/number}","events_url":"https://api.github.com/repos/atombrella/django-taggit/events","assignees_url":"https://api.github.com/repos/atombrella/django-taggit/assignees{/user}","branches_url":"https://api.github.com/repos/atombrella/django-taggit/branches{/branch}","tags_url":"https://api.github.com/repos/atombrella/django-taggit/tags","blobs_url":"https://api.github.com/repos/atombrella/django-taggit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atombrella/django-taggit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atombrella/django-taggit/git/refs{/sha}","trees_url":"https://api.github.com/repos/atombrella/django-taggit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atombrella/django-taggit/statuses/{sha}","languages_url":"https://api.github.com/repos/atombrella/django-taggit/languages","stargazers_url":"https://api.github.com/repos/atombrella/django-taggit/stargazers","contributors_url":"https://api.github.com/repos/atombrella/django-taggit/contributors","subscribers_url":"https://api.github.com/repos/atombrella/django-taggit/subscribers","subscription_url":"https://api.github.com/repos/atombrella/django-taggit/subscription","commits_url":"https://api.github.com/repos/atombrella/django-taggit/commits{/sha}","git_commits_url":"https://api.github.com/repos/atombrella/django-taggit/git/commits{/sha}","comments_url":"https://api.github.com/repos/atombrella/django-taggit/comments{/number}","issue_comment_url":"https://api.github.com/repos/atombrella/django-taggit/issues/comments{/number}","contents_url":"https://api.github.com/repos/atombrella/django-taggit/contents/{+path}","compare_url":"https://api.github.com/repos/atombrella/django-taggit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atombrella/django-taggit/merges","archive_url":"https://api.github.com/repos/atombrella/django-taggit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atombrella/django-taggit/downloads","issues_url":"https://api.github.com/repos/atombrella/django-taggit/issues{/number}","pulls_url":"https://api.github.com/repos/atombrella/django-taggit/pulls{/number}","milestones_url":"https://api.github.com/repos/atombrella/django-taggit/milestones{/number}","notifications_url":"https://api.github.com/repos/atombrella/django-taggit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atombrella/django-taggit/labels{/name}","releases_url":"https://api.github.com/repos/atombrella/django-taggit/releases{/id}","deployments_url":"https://api.github.com/repos/atombrella/django-taggit/deployments","created_at":"2017-04-16T10:17:18Z","updated_at":"2017-04-16T10:17:20Z","pushed_at":"2018-08-11T18:20:42Z","git_url":"git://github.com/atombrella/django-taggit.git","ssh_url":"git@github.com:atombrella/django-taggit.git","clone_url":"https://github.com/atombrella/django-taggit.git","svn_url":"https://github.com/atombrella/django-taggit","homepage":"https://django-taggit.readthedocs.io","size":648,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alex:master","ref":"master","sha":"94b9ee90b84cdeb0d1c3f2959778a8609a080a8d","user":{"login":"alex","id":772,"node_id":"MDQ6VXNlcjc3Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/772?v=4","gravatar_id":"","url":"https://api.github.com/users/alex","html_url":"https://github.com/alex","followers_url":"https://api.github.com/users/alex/followers","following_url":"https://api.github.com/users/alex/following{/other_user}","gists_url":"https://api.github.com/users/alex/gists{/gist_id}","starred_url":"https://api.github.com/users/alex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex/subscriptions","organizations_url":"https://api.github.com/users/alex/orgs","repos_url":"https://api.github.com/users/alex/repos","events_url":"https://api.github.com/users/alex/events{/privacy}","received_events_url":"https://api.github.com/users/alex/received_events","type":"User","site_admin":false},"repo":{"id":409101,"node_id":"MDEwOlJlcG9zaXRvcnk0MDkxMDE=","name":"django-taggit","full_name":"alex/django-taggit","owner":{"login":"alex","id":772,"node_id":"MDQ6VXNlcjc3Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/772?v=4","gravatar_id":"","url":"https://api.github.com/users/alex","html_url":"https://github.com/alex","followers_url":"https://api.github.com/users/alex/followers","following_url":"https://api.github.com/users/alex/following{/other_user}","gists_url":"https://api.github.com/users/alex/gists{/gist_id}","starred_url":"https://api.github.com/users/alex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex/subscriptions","organizations_url":"https://api.github.com/users/alex/orgs","repos_url":"https://api.github.com/users/alex/repos","events_url":"https://api.github.com/users/alex/events{/privacy}","received_events_url":"https://api.github.com/users/alex/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alex/django-taggit","description":"Simple tagging for django","fork":false,"url":"https://api.github.com/repos/alex/django-taggit","forks_url":"https://api.github.com/repos/alex/django-taggit/forks","keys_url":"https://api.github.com/repos/alex/django-taggit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alex/django-taggit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alex/django-taggit/teams","hooks_url":"https://api.github.com/repos/alex/django-taggit/hooks","issue_events_url":"https://api.github.com/repos/alex/django-taggit/issues/events{/number}","events_url":"https://api.github.com/repos/alex/django-taggit/events","assignees_url":"https://api.github.com/repos/alex/django-taggit/assignees{/user}","branches_url":"https://api.github.com/repos/alex/django-taggit/branches{/branch}","tags_url":"https://api.github.com/repos/alex/django-taggit/tags","blobs_url":"https://api.github.com/repos/alex/django-taggit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alex/django-taggit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alex/django-taggit/git/refs{/sha}","trees_url":"https://api.github.com/repos/alex/django-taggit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alex/django-taggit/statuses/{sha}","languages_url":"https://api.github.com/repos/alex/django-taggit/languages","stargazers_url":"https://api.github.com/repos/alex/django-taggit/stargazers","contributors_url":"https://api.github.com/repos/alex/django-taggit/contributors","subscribers_url":"https://api.github.com/repos/alex/django-taggit/subscribers","subscription_url":"https://api.github.com/repos/alex/django-taggit/subscription","commits_url":"https://api.github.com/repos/alex/django-taggit/commits{/sha}","git_commits_url":"https://api.github.com/repos/alex/django-taggit/git/commits{/sha}","comments_url":"https://api.github.com/repos/alex/django-taggit/comments{/number}","issue_comment_url":"https://api.github.com/repos/alex/django-taggit/issues/comments{/number}","contents_url":"https://api.github.com/repos/alex/django-taggit/contents/{+path}","compare_url":"https://api.github.com/repos/alex/django-taggit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alex/django-taggit/merges","archive_url":"https://api.github.com/repos/alex/django-taggit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alex/django-taggit/downloads","issues_url":"https://api.github.com/repos/alex/django-taggit/issues{/number}","pulls_url":"https://api.github.com/repos/alex/django-taggit/pulls{/number}","milestones_url":"https://api.github.com/repos/alex/django-taggit/milestones{/number}","notifications_url":"https://api.github.com/repos/alex/django-taggit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alex/django-taggit/labels{/name}","releases_url":"https://api.github.com/repos/alex/django-taggit/releases{/id}","deployments_url":"https://api.github.com/repos/alex/django-taggit/deployments","created_at":"2009-12-08T23:40:49Z","updated_at":"2018-08-12T00:44:39Z","pushed_at":"2018-08-12T00:44:37Z","git_url":"git://github.com/alex/django-taggit.git","ssh_url":"git@github.com:alex/django-taggit.git","clone_url":"https://github.com/alex/django-taggit.git","svn_url":"https://github.com/alex/django-taggit","homepage":"https://django-taggit.readthedocs.io","size":646,"stargazers_count":1923,"watchers_count":1923,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":467,"mirror_url":null,"archived":false,"open_issues_count":93,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":467,"open_issues":93,"watchers":1923,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alex/django-taggit/pulls/487"},"html":{"href":"https://github.com/alex/django-taggit/pull/487"},"issue":{"href":"https://api.github.com/repos/alex/django-taggit/issues/487"},"comments":{"href":"https://api.github.com/repos/alex/django-taggit/issues/487/comments"},"review_comments":{"href":"https://api.github.com/repos/alex/django-taggit/pulls/487/comments"},"review_comment":{"href":"https://api.github.com/repos/alex/django-taggit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alex/django-taggit/pulls/487/commits"},"statuses":{"href":"https://api.github.com/repos/alex/django-taggit/statuses/f65744594d560c85b4cfb45a6b905635033f24bf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jdufresne"}}