{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/govuk_app_config/pulls/comments/214021665","pull_request_review_id":150982980,"id":214021665,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDAyMTY2NQ==","diff_hunk":"@@ -0,0 +1,26 @@\n+require \"open-uri\"\n+\n+class GovukNodes\n+  class CarrenzaFetcher\n+    def hostnames_of_class(node_class)\n+      instances_of_class(node_class).map do |instance|\n+        instance.fetch(\"name\")\n+      end\n+    end\n+\n+  private\n+\n+    def instances_of_class(node_class)\n+      url = \"http://puppetdb.cluster/v2/nodes?#{query_string(node_class)}\"","path":"lib/govuk_app_config/govuk_nodes/carrenza_fetcher.rb","position":14,"original_position":14,"commit_id":"0354183cdd84c6e7e6bd664df92d4ccc4ed6abf9","original_commit_id":"ac67ff3dd8b57bb1c67ef51a1d79c3b82734e32c","user":{"login":"elliotcm","id":109225,"node_id":"MDQ6VXNlcjEwOTIyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/109225?v=4","gravatar_id":"","url":"https://api.github.com/users/elliotcm","html_url":"https://github.com/elliotcm","followers_url":"https://api.github.com/users/elliotcm/followers","following_url":"https://api.github.com/users/elliotcm/following{/other_user}","gists_url":"https://api.github.com/users/elliotcm/gists{/gist_id}","starred_url":"https://api.github.com/users/elliotcm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elliotcm/subscriptions","organizations_url":"https://api.github.com/users/elliotcm/orgs","repos_url":"https://api.github.com/users/elliotcm/repos","events_url":"https://api.github.com/users/elliotcm/events{/privacy}","received_events_url":"https://api.github.com/users/elliotcm/received_events","type":"User","site_admin":false},"body":"It's hardcoded in the script I ported, but sure.  Do you have somewhere I can source it from in puppet, or should I hardcode it there?","created_at":"2018-08-30T13:04:44Z","updated_at":"2018-08-30T13:04:44Z","html_url":"https://github.com/alphagov/govuk_app_config/pull/52#discussion_r214021665","pull_request_url":"https://api.github.com/repos/alphagov/govuk_app_config/pulls/52","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alphagov/govuk_app_config/pulls/comments/214021665"},"html":{"href":"https://github.com/alphagov/govuk_app_config/pull/52#discussion_r214021665"},"pull_request":{"href":"https://api.github.com/repos/alphagov/govuk_app_config/pulls/52"}},"in_reply_to_id":214021007},"pull_request":{"url":"https://api.github.com/repos/alphagov/govuk_app_config/pulls/52","id":212070302,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMDcwMzAy","html_url":"https://github.com/alphagov/govuk_app_config/pull/52","diff_url":"https://github.com/alphagov/govuk_app_config/pull/52.diff","patch_url":"https://github.com/alphagov/govuk_app_config/pull/52.patch","issue_url":"https://api.github.com/repos/alphagov/govuk_app_config/issues/52","number":52,"state":"open","locked":false,"title":"Add GovukNodes","user":{"login":"elliotcm","id":109225,"node_id":"MDQ6VXNlcjEwOTIyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/109225?v=4","gravatar_id":"","url":"https://api.github.com/users/elliotcm","html_url":"https://github.com/elliotcm","followers_url":"https://api.github.com/users/elliotcm/followers","following_url":"https://api.github.com/users/elliotcm/following{/other_user}","gists_url":"https://api.github.com/users/elliotcm/gists{/gist_id}","starred_url":"https://api.github.com/users/elliotcm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elliotcm/subscriptions","organizations_url":"https://api.github.com/users/elliotcm/orgs","repos_url":"https://api.github.com/users/elliotcm/repos","events_url":"https://api.github.com/users/elliotcm/events{/privacy}","received_events_url":"https://api.github.com/users/elliotcm/received_events","type":"User","site_admin":false},"body":"This provides functionality for fetching all DNS names for a given node class, regardless of whether on AWS or Carrenza.\r\n\r\nRequired for clearing varnish cache, since the `backend` machines need to issue calls directly to each `cache` box.\r\n\r\nhttps://trello.com/c/f8U7EfUh/427-make-the-new-cache-clearing-app-invalidate-cache-in-varnish","created_at":"2018-08-30T12:59:43Z","updated_at":"2018-08-30T13:04:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63bd632350a465aeb9a8316ca1bf769fbca32ef4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/govuk_app_config/pulls/52/commits","review_comments_url":"https://api.github.com/repos/alphagov/govuk_app_config/pulls/52/comments","review_comment_url":"https://api.github.com/repos/alphagov/govuk_app_config/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/govuk_app_config/issues/52/comments","statuses_url":"https://api.github.com/repos/alphagov/govuk_app_config/statuses/0354183cdd84c6e7e6bd664df92d4ccc4ed6abf9","head":{"label":"alphagov:govuk-nodes","ref":"govuk-nodes","sha":"0354183cdd84c6e7e6bd664df92d4ccc4ed6abf9","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":100607967,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA2MDc5Njc=","name":"govuk_app_config","full_name":"alphagov/govuk_app_config","owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/govuk_app_config","description":"Gem to configure GOV.UK Ruby applications","fork":false,"url":"https://api.github.com/repos/alphagov/govuk_app_config","forks_url":"https://api.github.com/repos/alphagov/govuk_app_config/forks","keys_url":"https://api.github.com/repos/alphagov/govuk_app_config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/govuk_app_config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/govuk_app_config/teams","hooks_url":"https://api.github.com/repos/alphagov/govuk_app_config/hooks","issue_events_url":"https://api.github.com/repos/alphagov/govuk_app_config/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/govuk_app_config/events","assignees_url":"https://api.github.com/repos/alphagov/govuk_app_config/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/govuk_app_config/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/govuk_app_config/tags","blobs_url":"https://api.github.com/repos/alphagov/govuk_app_config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/govuk_app_config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/govuk_app_config/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/govuk_app_config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/govuk_app_config/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/govuk_app_config/languages","stargazers_url":"https://api.github.com/repos/alphagov/govuk_app_config/stargazers","contributors_url":"https://api.github.com/repos/alphagov/govuk_app_config/contributors","subscribers_url":"https://api.github.com/repos/alphagov/govuk_app_config/subscribers","subscription_url":"https://api.github.com/repos/alphagov/govuk_app_config/subscription","commits_url":"https://api.github.com/repos/alphagov/govuk_app_config/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/govuk_app_config/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/govuk_app_config/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/govuk_app_config/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/govuk_app_config/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/govuk_app_config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/govuk_app_config/merges","archive_url":"https://api.github.com/repos/alphagov/govuk_app_config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/govuk_app_config/downloads","issues_url":"https://api.github.com/repos/alphagov/govuk_app_config/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/govuk_app_config/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/govuk_app_config/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/govuk_app_config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/govuk_app_config/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/govuk_app_config/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/govuk_app_config/deployments","created_at":"2017-08-17T13:45:14Z","updated_at":"2018-08-06T07:59:12Z","pushed_at":"2018-08-30T13:03:59Z","git_url":"git://github.com/alphagov/govuk_app_config.git","ssh_url":"git@github.com:alphagov/govuk_app_config.git","clone_url":"https://github.com/alphagov/govuk_app_config.git","svn_url":"https://github.com/alphagov/govuk_app_config","homepage":null,"size":116,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"942f9dc56cf52de88f2dd793e3039048a59974b7","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":100607967,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA2MDc5Njc=","name":"govuk_app_config","full_name":"alphagov/govuk_app_config","owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/govuk_app_config","description":"Gem to configure GOV.UK Ruby applications","fork":false,"url":"https://api.github.com/repos/alphagov/govuk_app_config","forks_url":"https://api.github.com/repos/alphagov/govuk_app_config/forks","keys_url":"https://api.github.com/repos/alphagov/govuk_app_config/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/govuk_app_config/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/govuk_app_config/teams","hooks_url":"https://api.github.com/repos/alphagov/govuk_app_config/hooks","issue_events_url":"https://api.github.com/repos/alphagov/govuk_app_config/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/govuk_app_config/events","assignees_url":"https://api.github.com/repos/alphagov/govuk_app_config/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/govuk_app_config/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/govuk_app_config/tags","blobs_url":"https://api.github.com/repos/alphagov/govuk_app_config/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/govuk_app_config/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/govuk_app_config/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/govuk_app_config/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/govuk_app_config/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/govuk_app_config/languages","stargazers_url":"https://api.github.com/repos/alphagov/govuk_app_config/stargazers","contributors_url":"https://api.github.com/repos/alphagov/govuk_app_config/contributors","subscribers_url":"https://api.github.com/repos/alphagov/govuk_app_config/subscribers","subscription_url":"https://api.github.com/repos/alphagov/govuk_app_config/subscription","commits_url":"https://api.github.com/repos/alphagov/govuk_app_config/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/govuk_app_config/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/govuk_app_config/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/govuk_app_config/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/govuk_app_config/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/govuk_app_config/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/govuk_app_config/merges","archive_url":"https://api.github.com/repos/alphagov/govuk_app_config/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/govuk_app_config/downloads","issues_url":"https://api.github.com/repos/alphagov/govuk_app_config/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/govuk_app_config/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/govuk_app_config/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/govuk_app_config/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/govuk_app_config/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/govuk_app_config/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/govuk_app_config/deployments","created_at":"2017-08-17T13:45:14Z","updated_at":"2018-08-06T07:59:12Z","pushed_at":"2018-08-30T13:03:59Z","git_url":"git://github.com/alphagov/govuk_app_config.git","ssh_url":"git@github.com:alphagov/govuk_app_config.git","clone_url":"https://github.com/alphagov/govuk_app_config.git","svn_url":"https://github.com/alphagov/govuk_app_config","homepage":null,"size":116,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/govuk_app_config/pulls/52"},"html":{"href":"https://github.com/alphagov/govuk_app_config/pull/52"},"issue":{"href":"https://api.github.com/repos/alphagov/govuk_app_config/issues/52"},"comments":{"href":"https://api.github.com/repos/alphagov/govuk_app_config/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/govuk_app_config/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/govuk_app_config/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/govuk_app_config/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/govuk_app_config/statuses/0354183cdd84c6e7e6bd664df92d4ccc4ed6abf9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"elliotcm"}}