{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-mxnet/issues/9671","repository_url":"https://api.github.com/repos/apache/incubator-mxnet","labels_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/9671/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/9671/comments","events_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/9671/events","html_url":"https://github.com/apache/incubator-mxnet/pull/9671","id":293627489,"number":9671,"title":"Exp backoff for downloads.","user":{"login":"KellenSunderland","id":7443219,"avatar_url":"https://avatars0.githubusercontent.com/u/7443219?v=4","gravatar_id":"","url":"https://api.github.com/users/KellenSunderland","html_url":"https://github.com/KellenSunderland","followers_url":"https://api.github.com/users/KellenSunderland/followers","following_url":"https://api.github.com/users/KellenSunderland/following{/other_user}","gists_url":"https://api.github.com/users/KellenSunderland/gists{/gist_id}","starred_url":"https://api.github.com/users/KellenSunderland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KellenSunderland/subscriptions","organizations_url":"https://api.github.com/users/KellenSunderland/orgs","repos_url":"https://api.github.com/users/KellenSunderland/repos","events_url":"https://api.github.com/users/KellenSunderland/events{/privacy}","received_events_url":"https://api.github.com/users/KellenSunderland/received_events","type":"User","site_admin":false},"labels":[{"id":738857750,"url":"https://api.github.com/repos/apache/incubator-mxnet/labels/API%20change","name":"API change","color":"fc2929","default":false},{"id":824030514,"url":"https://api.github.com/repos/apache/incubator-mxnet/labels/Breaking","name":"Breaking","color":"fc2929","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-02-01T17:58:09Z","updated_at":"2018-02-01T18:57:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/9671","html_url":"https://github.com/apache/incubator-mxnet/pull/9671","diff_url":"https://github.com/apache/incubator-mxnet/pull/9671.diff","patch_url":"https://github.com/apache/incubator-mxnet/pull/9671.patch"},"body":"## Description ##\r\nThe primary goal of this PR was to add exponential backoff to our http request.  This should be a good feature for customers with slow Internet connections, but I also hope it will help mitigate test issues such as: #9669.\r\n\r\nI noticed that we have a lot of duplicate code between test_utils.download and gluon.download.  I've attempted to combine these two functions, but can roll it back if they had a good reason to be separated.\r\n\r\n## Checklist ##\r\n### Essentials ###\r\n- [ ] Passed code style checking (`make lint`)\r\n- [x] Changes are complete (i.e. I finished coding on this PR)\r\n- [x] All changes have test coverage:\r\n- [x] Code is well-documented: \r\n\r\nNote examples are affected by this change.  I've updated them so that they do not reference download functions that no longer exist.\r\n\r\n## Comments ##\r\n- The tests require a new test dependency: requests_mock. Which may need to be added to the CI.  Due to this, this PR may require a little iteration before test work properly.  No rush to get it merged.\r\n- I've created a requirements.test.txt file for convenient installation of test deps.\r\n- NNVM will also need to be updated with a few new references in files tutorials/deploy_model_on_rasp.py and tutorials/from_mxnet.py.\r\n"},"comment":{"url":"https://api.github.com/repos/apache/incubator-mxnet/issues/comments/362366467","html_url":"https://github.com/apache/incubator-mxnet/pull/9671#issuecomment-362366467","issue_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/9671","id":362366467,"user":{"login":"eric-haibin-lin","id":5545640,"avatar_url":"https://avatars1.githubusercontent.com/u/5545640?v=4","gravatar_id":"","url":"https://api.github.com/users/eric-haibin-lin","html_url":"https://github.com/eric-haibin-lin","followers_url":"https://api.github.com/users/eric-haibin-lin/followers","following_url":"https://api.github.com/users/eric-haibin-lin/following{/other_user}","gists_url":"https://api.github.com/users/eric-haibin-lin/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-haibin-lin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-haibin-lin/subscriptions","organizations_url":"https://api.github.com/users/eric-haibin-lin/orgs","repos_url":"https://api.github.com/users/eric-haibin-lin/repos","events_url":"https://api.github.com/users/eric-haibin-lin/events{/privacy}","received_events_url":"https://api.github.com/users/eric-haibin-lin/received_events","type":"User","site_admin":false},"created_at":"2018-02-01T18:57:39Z","updated_at":"2018-02-01T18:57:39Z","author_association":"CONTRIBUTOR","body":"Can we keep the alias in test_utils and gluon to keep backward compatibility? "}}
{"actor":{"display_login":"eric-haibin-lin"}}