{"action":"created","comment":{"url":"https://api.github.com/repos/google/protobuf/pulls/comments/204150920","pull_request_review_id":139187695,"id":204150920,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDE1MDkyMA==","diff_hunk":"@@ -853,6 +854,30 @@ public void testSerializePartial() throws Exception {\n     assertEquals(expected, actual);\n   }\n \n+  public void testSerializeBackwardsCompatibility() throws Exception {","path":"java/core/src/test/java/com/google/protobuf/GeneratedMessageTest.java","position":12,"original_position":12,"commit_id":"3ac7eac96dff109aad8b3ff53748632ba80ee4e4","original_commit_id":"3ac7eac96dff109aad8b3ff53748632ba80ee4e4","user":{"login":"ejona86","id":2811396,"node_id":"MDQ6VXNlcjI4MTEzOTY=","avatar_url":"https://avatars2.githubusercontent.com/u/2811396?v=4","gravatar_id":"","url":"https://api.github.com/users/ejona86","html_url":"https://github.com/ejona86","followers_url":"https://api.github.com/users/ejona86/followers","following_url":"https://api.github.com/users/ejona86/following{/other_user}","gists_url":"https://api.github.com/users/ejona86/gists{/gist_id}","starred_url":"https://api.github.com/users/ejona86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejona86/subscriptions","organizations_url":"https://api.github.com/users/ejona86/orgs","repos_url":"https://api.github.com/users/ejona86/repos","events_url":"https://api.github.com/users/ejona86/events{/privacy}","received_events_url":"https://api.github.com/users/ejona86/received_events","type":"User","site_admin":false},"body":"Mention somewhere what \"version\" of the class this is. Namely, that it was before the introduction of the `Class`.","created_at":"2018-07-20T19:43:52Z","updated_at":"2018-07-20T19:44:51Z","html_url":"https://github.com/google/protobuf/pull/4927#discussion_r204150920","pull_request_url":"https://api.github.com/repos/google/protobuf/pulls/4927","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/google/protobuf/pulls/comments/204150920"},"html":{"href":"https://github.com/google/protobuf/pull/4927#discussion_r204150920"},"pull_request":{"href":"https://api.github.com/repos/google/protobuf/pulls/4927"}}},"pull_request":{"url":"https://api.github.com/repos/google/protobuf/pulls/4927","id":201757772,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNzU3Nzcy","html_url":"https://github.com/google/protobuf/pull/4927","diff_url":"https://github.com/google/protobuf/pull/4927.diff","patch_url":"https://github.com/google/protobuf/pull/4927.patch","issue_url":"https://api.github.com/repos/google/protobuf/issues/4927","number":4927,"state":"open","locked":false,"title":"Store the class object itself","user":{"login":"jhaber","id":611459,"node_id":"MDQ6VXNlcjYxMTQ1OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/611459?v=4","gravatar_id":"","url":"https://api.github.com/users/jhaber","html_url":"https://github.com/jhaber","followers_url":"https://api.github.com/users/jhaber/followers","following_url":"https://api.github.com/users/jhaber/following{/other_user}","gists_url":"https://api.github.com/users/jhaber/gists{/gist_id}","starred_url":"https://api.github.com/users/jhaber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhaber/subscriptions","organizations_url":"https://api.github.com/users/jhaber/orgs","repos_url":"https://api.github.com/users/jhaber/repos","events_url":"https://api.github.com/users/jhaber/events{/privacy}","received_events_url":"https://api.github.com/users/jhaber/received_events","type":"User","site_admin":false},"body":"Fix for #3474. This updates the `SerializedForm` to include the `Class` object rather than just the class name as suggested here https://github.com/google/protobuf/issues/3474#issuecomment-401096085 This shifts the burden of finding the right classloader from us to the JVM (which will hopefully handle it better). Based on my understanding of the Java serialization format, this change should be both forwards and backwards compatible","created_at":"2018-07-16T20:54:34Z","updated_at":"2018-07-20T19:44:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eded0b80e65cc2125e74405df995560fba491e2c","assignee":{"login":"xfxyjwf","id":8551050,"node_id":"MDQ6VXNlcjg1NTEwNTA=","avatar_url":"https://avatars0.githubusercontent.com/u/8551050?v=4","gravatar_id":"","url":"https://api.github.com/users/xfxyjwf","html_url":"https://github.com/xfxyjwf","followers_url":"https://api.github.com/users/xfxyjwf/followers","following_url":"https://api.github.com/users/xfxyjwf/following{/other_user}","gists_url":"https://api.github.com/users/xfxyjwf/gists{/gist_id}","starred_url":"https://api.github.com/users/xfxyjwf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xfxyjwf/subscriptions","organizations_url":"https://api.github.com/users/xfxyjwf/orgs","repos_url":"https://api.github.com/users/xfxyjwf/repos","events_url":"https://api.github.com/users/xfxyjwf/events{/privacy}","received_events_url":"https://api.github.com/users/xfxyjwf/received_events","type":"User","site_admin":false},"assignees":[{"login":"xfxyjwf","id":8551050,"node_id":"MDQ6VXNlcjg1NTEwNTA=","avatar_url":"https://avatars0.githubusercontent.com/u/8551050?v=4","gravatar_id":"","url":"https://api.github.com/users/xfxyjwf","html_url":"https://github.com/xfxyjwf","followers_url":"https://api.github.com/users/xfxyjwf/followers","following_url":"https://api.github.com/users/xfxyjwf/following{/other_user}","gists_url":"https://api.github.com/users/xfxyjwf/gists{/gist_id}","starred_url":"https://api.github.com/users/xfxyjwf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xfxyjwf/subscriptions","organizations_url":"https://api.github.com/users/xfxyjwf/orgs","repos_url":"https://api.github.com/users/xfxyjwf/repos","events_url":"https://api.github.com/users/xfxyjwf/events{/privacy}","received_events_url":"https://api.github.com/users/xfxyjwf/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":151794609,"node_id":"MDU6TGFiZWwxNTE3OTQ2MDk=","url":"https://api.github.com/repos/google/protobuf/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":250677115,"node_id":"MDU6TGFiZWwyNTA2NzcxMTU=","url":"https://api.github.com/repos/google/protobuf/labels/java","name":"java","color":"fad8c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/protobuf/pulls/4927/commits","review_comments_url":"https://api.github.com/repos/google/protobuf/pulls/4927/comments","review_comment_url":"https://api.github.com/repos/google/protobuf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/protobuf/issues/4927/comments","statuses_url":"https://api.github.com/repos/google/protobuf/statuses/3ac7eac96dff109aad8b3ff53748632ba80ee4e4","head":{"label":"jhaber:master","ref":"master","sha":"3ac7eac96dff109aad8b3ff53748632ba80ee4e4","user":{"login":"jhaber","id":611459,"node_id":"MDQ6VXNlcjYxMTQ1OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/611459?v=4","gravatar_id":"","url":"https://api.github.com/users/jhaber","html_url":"https://github.com/jhaber","followers_url":"https://api.github.com/users/jhaber/followers","following_url":"https://api.github.com/users/jhaber/following{/other_user}","gists_url":"https://api.github.com/users/jhaber/gists{/gist_id}","starred_url":"https://api.github.com/users/jhaber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhaber/subscriptions","organizations_url":"https://api.github.com/users/jhaber/orgs","repos_url":"https://api.github.com/users/jhaber/repos","events_url":"https://api.github.com/users/jhaber/events{/privacy}","received_events_url":"https://api.github.com/users/jhaber/received_events","type":"User","site_admin":false},"repo":{"id":141193083,"node_id":"MDEwOlJlcG9zaXRvcnkxNDExOTMwODM=","name":"protobuf","full_name":"jhaber/protobuf","owner":{"login":"jhaber","id":611459,"node_id":"MDQ6VXNlcjYxMTQ1OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/611459?v=4","gravatar_id":"","url":"https://api.github.com/users/jhaber","html_url":"https://github.com/jhaber","followers_url":"https://api.github.com/users/jhaber/followers","following_url":"https://api.github.com/users/jhaber/following{/other_user}","gists_url":"https://api.github.com/users/jhaber/gists{/gist_id}","starred_url":"https://api.github.com/users/jhaber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhaber/subscriptions","organizations_url":"https://api.github.com/users/jhaber/orgs","repos_url":"https://api.github.com/users/jhaber/repos","events_url":"https://api.github.com/users/jhaber/events{/privacy}","received_events_url":"https://api.github.com/users/jhaber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jhaber/protobuf","description":"Protocol Buffers - Google's data interchange format","fork":true,"url":"https://api.github.com/repos/jhaber/protobuf","forks_url":"https://api.github.com/repos/jhaber/protobuf/forks","keys_url":"https://api.github.com/repos/jhaber/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhaber/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhaber/protobuf/teams","hooks_url":"https://api.github.com/repos/jhaber/protobuf/hooks","issue_events_url":"https://api.github.com/repos/jhaber/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/jhaber/protobuf/events","assignees_url":"https://api.github.com/repos/jhaber/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/jhaber/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/jhaber/protobuf/tags","blobs_url":"https://api.github.com/repos/jhaber/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhaber/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhaber/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhaber/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhaber/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/jhaber/protobuf/languages","stargazers_url":"https://api.github.com/repos/jhaber/protobuf/stargazers","contributors_url":"https://api.github.com/repos/jhaber/protobuf/contributors","subscribers_url":"https://api.github.com/repos/jhaber/protobuf/subscribers","subscription_url":"https://api.github.com/repos/jhaber/protobuf/subscription","commits_url":"https://api.github.com/repos/jhaber/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhaber/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhaber/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhaber/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhaber/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/jhaber/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhaber/protobuf/merges","archive_url":"https://api.github.com/repos/jhaber/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhaber/protobuf/downloads","issues_url":"https://api.github.com/repos/jhaber/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/jhaber/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/jhaber/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/jhaber/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhaber/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/jhaber/protobuf/releases{/id}","deployments_url":"https://api.github.com/repos/jhaber/protobuf/deployments","created_at":"2018-07-16T20:51:28Z","updated_at":"2018-07-20T19:22:59Z","pushed_at":"2018-07-20T19:22:47Z","git_url":"git://github.com/jhaber/protobuf.git","ssh_url":"git@github.com:jhaber/protobuf.git","clone_url":"https://github.com/jhaber/protobuf.git","svn_url":"https://github.com/jhaber/protobuf","homepage":"https://developers.google.com/protocol-buffers/","size":47771,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"c7442b27cf43eef8281f6608b9ca014a8a867760","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":23357588,"node_id":"MDEwOlJlcG9zaXRvcnkyMzM1NzU4OA==","name":"protobuf","full_name":"google/protobuf","owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/protobuf","description":"Protocol Buffers - Google's data interchange format","fork":false,"url":"https://api.github.com/repos/google/protobuf","forks_url":"https://api.github.com/repos/google/protobuf/forks","keys_url":"https://api.github.com/repos/google/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/protobuf/teams","hooks_url":"https://api.github.com/repos/google/protobuf/hooks","issue_events_url":"https://api.github.com/repos/google/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/google/protobuf/events","assignees_url":"https://api.github.com/repos/google/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/google/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/google/protobuf/tags","blobs_url":"https://api.github.com/repos/google/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/google/protobuf/languages","stargazers_url":"https://api.github.com/repos/google/protobuf/stargazers","contributors_url":"https://api.github.com/repos/google/protobuf/contributors","subscribers_url":"https://api.github.com/repos/google/protobuf/subscribers","subscription_url":"https://api.github.com/repos/google/protobuf/subscription","commits_url":"https://api.github.com/repos/google/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/google/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/protobuf/merges","archive_url":"https://api.github.com/repos/google/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/protobuf/downloads","issues_url":"https://api.github.com/repos/google/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/google/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/google/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/google/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/google/protobuf/releases{/id}","deployments_url":"https://api.github.com/repos/google/protobuf/deployments","created_at":"2014-08-26T15:52:15Z","updated_at":"2018-07-20T19:12:11Z","pushed_at":"2018-07-20T19:22:51Z","git_url":"git://github.com/google/protobuf.git","ssh_url":"git@github.com:google/protobuf.git","clone_url":"https://github.com/google/protobuf.git","svn_url":"https://github.com/google/protobuf","homepage":"https://developers.google.com/protocol-buffers/","size":48348,"stargazers_count":27758,"watchers_count":27758,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7785,"mirror_url":null,"archived":false,"open_issues_count":428,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7785,"open_issues":428,"watchers":27758,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/protobuf/pulls/4927"},"html":{"href":"https://github.com/google/protobuf/pull/4927"},"issue":{"href":"https://api.github.com/repos/google/protobuf/issues/4927"},"comments":{"href":"https://api.github.com/repos/google/protobuf/issues/4927/comments"},"review_comments":{"href":"https://api.github.com/repos/google/protobuf/pulls/4927/comments"},"review_comment":{"href":"https://api.github.com/repos/google/protobuf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/protobuf/pulls/4927/commits"},"statuses":{"href":"https://api.github.com/repos/google/protobuf/statuses/3ac7eac96dff109aad8b3ff53748632ba80ee4e4"}},"author_association":"NONE"}}
{"actor":{"display_login":"ejona86"}}