{"action":"created","comment":{"url":"https://api.github.com/repos/brndnmtthws/conky/pulls/comments/208153096","pull_request_review_id":143903844,"id":208153096,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODE1MzA5Ng==","diff_hunk":"@@ -458,14 +472,15 @@ void print_cmdline_to_pid(struct text_object *obj, char *p, int p_max_size) {\n   struct dirent *entry;\n   char *buf;\n   int bytes_read, i;\n-  char pathbuf[64];\n+  char *pathbuf;\n \n   dir = opendir(PROCDIR);\n   if (dir != nullptr) {\n     while ((entry = readdir(dir)) != nullptr) {\n-      snprintf(pathbuf, 64, PROCDIR \"/%s/cmdline\", entry->d_name);\n+      safe_asprintf(&pathbuf, PROCDIR \"/%s/cmdline\", entry->d_name);\n \n       buf = readfile(pathbuf, &bytes_read, 0);\n+      free(pathbuf);","path":"src/proc.cc","position":257,"original_position":257,"commit_id":"b002e3d12a72c75382be0d57e49e40eee95debb5","original_commit_id":"b002e3d12a72c75382be0d57e49e40eee95debb5","user":{"login":"conky-ci","id":39227759,"node_id":"MDQ6VXNlcjM5MjI3NzU5","avatar_url":"https://avatars3.githubusercontent.com/u/39227759?v=4","gravatar_id":"","url":"https://api.github.com/users/conky-ci","html_url":"https://github.com/conky-ci","followers_url":"https://api.github.com/users/conky-ci/followers","following_url":"https://api.github.com/users/conky-ci/following{/other_user}","gists_url":"https://api.github.com/users/conky-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/conky-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conky-ci/subscriptions","organizations_url":"https://api.github.com/users/conky-ci/orgs","repos_url":"https://api.github.com/users/conky-ci/repos","events_url":"https://api.github.com/users/conky-ci/events{/privacy}","received_events_url":"https://api.github.com/users/conky-ci/received_events","type":"User","site_admin":false},"body":"![Code Smell](https://sonarsource.github.io/sonar-github/code_smell.png 'Code Smell') Code Smell: Remove this use of \"free\". ([cpp:S1231](https://sonarcloud.io/organizations/brndnmtthws-github/rules#rule_key=cpp%3AS1231))\n\n[See it in SonarCloud](https://sonarcloud.io/project/issues?id=conky&pullRequest=575&issues=AWUTjhea8anAXINB2z50&open=AWUTjhea8anAXINB2z50)\n\n[ISSUE_KEY]: AWUTjhea8anAXINB2z50","created_at":"2018-08-07T09:06:29Z","updated_at":"2018-08-07T09:06:31Z","html_url":"https://github.com/brndnmtthws/conky/pull/575#discussion_r208153096","pull_request_url":"https://api.github.com/repos/brndnmtthws/conky/pulls/575","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/brndnmtthws/conky/pulls/comments/208153096"},"html":{"href":"https://github.com/brndnmtthws/conky/pull/575#discussion_r208153096"},"pull_request":{"href":"https://api.github.com/repos/brndnmtthws/conky/pulls/575"}}},"pull_request":{"url":"https://api.github.com/repos/brndnmtthws/conky/pulls/575","id":206620971,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NjIwOTcx","html_url":"https://github.com/brndnmtthws/conky/pull/575","diff_url":"https://github.com/brndnmtthws/conky/pull/575.diff","patch_url":"https://github.com/brndnmtthws/conky/pull/575.patch","issue_url":"https://api.github.com/repos/brndnmtthws/conky/issues/575","number":575,"state":"open","locked":false,"title":"Fix problems found when fixing docker","user":{"login":"ngaro","id":2175147,"node_id":"MDQ6VXNlcjIxNzUxNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/2175147?v=4","gravatar_id":"","url":"https://api.github.com/users/ngaro","html_url":"https://github.com/ngaro","followers_url":"https://api.github.com/users/ngaro/followers","following_url":"https://api.github.com/users/ngaro/following{/other_user}","gists_url":"https://api.github.com/users/ngaro/gists{/gist_id}","starred_url":"https://api.github.com/users/ngaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngaro/subscriptions","organizations_url":"https://api.github.com/users/ngaro/orgs","repos_url":"https://api.github.com/users/ngaro/repos","events_url":"https://api.github.com/users/ngaro/events{/privacy}","received_events_url":"https://api.github.com/users/ngaro/received_events","type":"User","site_admin":false},"body":"These are all (mostly small) fixes and enhancements. I found them missing while building a container.\r\n\r\nOnly the 4 oldest have something to do with docker and only the 2nd oldest is a docker-only fix.","created_at":"2018-08-07T08:38:17Z","updated_at":"2018-08-07T09:06:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65afbed843069e1027414a4c89708850ad87b499","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/brndnmtthws/conky/pulls/575/commits","review_comments_url":"https://api.github.com/repos/brndnmtthws/conky/pulls/575/comments","review_comment_url":"https://api.github.com/repos/brndnmtthws/conky/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brndnmtthws/conky/issues/575/comments","statuses_url":"https://api.github.com/repos/brndnmtthws/conky/statuses/b002e3d12a72c75382be0d57e49e40eee95debb5","head":{"label":"brndnmtthws:garo-master","ref":"garo-master","sha":"b002e3d12a72c75382be0d57e49e40eee95debb5","user":{"login":"brndnmtthws","id":3129093,"node_id":"MDQ6VXNlcjMxMjkwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3129093?v=4","gravatar_id":"","url":"https://api.github.com/users/brndnmtthws","html_url":"https://github.com/brndnmtthws","followers_url":"https://api.github.com/users/brndnmtthws/followers","following_url":"https://api.github.com/users/brndnmtthws/following{/other_user}","gists_url":"https://api.github.com/users/brndnmtthws/gists{/gist_id}","starred_url":"https://api.github.com/users/brndnmtthws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brndnmtthws/subscriptions","organizations_url":"https://api.github.com/users/brndnmtthws/orgs","repos_url":"https://api.github.com/users/brndnmtthws/repos","events_url":"https://api.github.com/users/brndnmtthws/events{/privacy}","received_events_url":"https://api.github.com/users/brndnmtthws/received_events","type":"User","site_admin":false},"repo":{"id":7331227,"node_id":"MDEwOlJlcG9zaXRvcnk3MzMxMjI3","name":"conky","full_name":"brndnmtthws/conky","owner":{"login":"brndnmtthws","id":3129093,"node_id":"MDQ6VXNlcjMxMjkwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3129093?v=4","gravatar_id":"","url":"https://api.github.com/users/brndnmtthws","html_url":"https://github.com/brndnmtthws","followers_url":"https://api.github.com/users/brndnmtthws/followers","following_url":"https://api.github.com/users/brndnmtthws/following{/other_user}","gists_url":"https://api.github.com/users/brndnmtthws/gists{/gist_id}","starred_url":"https://api.github.com/users/brndnmtthws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brndnmtthws/subscriptions","organizations_url":"https://api.github.com/users/brndnmtthws/orgs","repos_url":"https://api.github.com/users/brndnmtthws/repos","events_url":"https://api.github.com/users/brndnmtthws/events{/privacy}","received_events_url":"https://api.github.com/users/brndnmtthws/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brndnmtthws/conky","description":"Light-weight system monitor for X.","fork":false,"url":"https://api.github.com/repos/brndnmtthws/conky","forks_url":"https://api.github.com/repos/brndnmtthws/conky/forks","keys_url":"https://api.github.com/repos/brndnmtthws/conky/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brndnmtthws/conky/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brndnmtthws/conky/teams","hooks_url":"https://api.github.com/repos/brndnmtthws/conky/hooks","issue_events_url":"https://api.github.com/repos/brndnmtthws/conky/issues/events{/number}","events_url":"https://api.github.com/repos/brndnmtthws/conky/events","assignees_url":"https://api.github.com/repos/brndnmtthws/conky/assignees{/user}","branches_url":"https://api.github.com/repos/brndnmtthws/conky/branches{/branch}","tags_url":"https://api.github.com/repos/brndnmtthws/conky/tags","blobs_url":"https://api.github.com/repos/brndnmtthws/conky/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brndnmtthws/conky/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brndnmtthws/conky/git/refs{/sha}","trees_url":"https://api.github.com/repos/brndnmtthws/conky/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brndnmtthws/conky/statuses/{sha}","languages_url":"https://api.github.com/repos/brndnmtthws/conky/languages","stargazers_url":"https://api.github.com/repos/brndnmtthws/conky/stargazers","contributors_url":"https://api.github.com/repos/brndnmtthws/conky/contributors","subscribers_url":"https://api.github.com/repos/brndnmtthws/conky/subscribers","subscription_url":"https://api.github.com/repos/brndnmtthws/conky/subscription","commits_url":"https://api.github.com/repos/brndnmtthws/conky/commits{/sha}","git_commits_url":"https://api.github.com/repos/brndnmtthws/conky/git/commits{/sha}","comments_url":"https://api.github.com/repos/brndnmtthws/conky/comments{/number}","issue_comment_url":"https://api.github.com/repos/brndnmtthws/conky/issues/comments{/number}","contents_url":"https://api.github.com/repos/brndnmtthws/conky/contents/{+path}","compare_url":"https://api.github.com/repos/brndnmtthws/conky/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brndnmtthws/conky/merges","archive_url":"https://api.github.com/repos/brndnmtthws/conky/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brndnmtthws/conky/downloads","issues_url":"https://api.github.com/repos/brndnmtthws/conky/issues{/number}","pulls_url":"https://api.github.com/repos/brndnmtthws/conky/pulls{/number}","milestones_url":"https://api.github.com/repos/brndnmtthws/conky/milestones{/number}","notifications_url":"https://api.github.com/repos/brndnmtthws/conky/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brndnmtthws/conky/labels{/name}","releases_url":"https://api.github.com/repos/brndnmtthws/conky/releases{/id}","deployments_url":"https://api.github.com/repos/brndnmtthws/conky/deployments","created_at":"2012-12-26T19:50:17Z","updated_at":"2018-08-07T08:47:24Z","pushed_at":"2018-08-07T08:59:33Z","git_url":"git://github.com/brndnmtthws/conky.git","ssh_url":"git@github.com:brndnmtthws/conky.git","clone_url":"https://github.com/brndnmtthws/conky.git","svn_url":"https://github.com/brndnmtthws/conky","homepage":null,"size":14555,"stargazers_count":2271,"watchers_count":2271,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":316,"mirror_url":null,"archived":false,"open_issues_count":121,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":316,"open_issues":121,"watchers":2271,"default_branch":"master"}},"base":{"label":"brndnmtthws:master","ref":"master","sha":"a78a750dad32da0875bef76ce4d239e48a8e7bd8","user":{"login":"brndnmtthws","id":3129093,"node_id":"MDQ6VXNlcjMxMjkwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3129093?v=4","gravatar_id":"","url":"https://api.github.com/users/brndnmtthws","html_url":"https://github.com/brndnmtthws","followers_url":"https://api.github.com/users/brndnmtthws/followers","following_url":"https://api.github.com/users/brndnmtthws/following{/other_user}","gists_url":"https://api.github.com/users/brndnmtthws/gists{/gist_id}","starred_url":"https://api.github.com/users/brndnmtthws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brndnmtthws/subscriptions","organizations_url":"https://api.github.com/users/brndnmtthws/orgs","repos_url":"https://api.github.com/users/brndnmtthws/repos","events_url":"https://api.github.com/users/brndnmtthws/events{/privacy}","received_events_url":"https://api.github.com/users/brndnmtthws/received_events","type":"User","site_admin":false},"repo":{"id":7331227,"node_id":"MDEwOlJlcG9zaXRvcnk3MzMxMjI3","name":"conky","full_name":"brndnmtthws/conky","owner":{"login":"brndnmtthws","id":3129093,"node_id":"MDQ6VXNlcjMxMjkwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3129093?v=4","gravatar_id":"","url":"https://api.github.com/users/brndnmtthws","html_url":"https://github.com/brndnmtthws","followers_url":"https://api.github.com/users/brndnmtthws/followers","following_url":"https://api.github.com/users/brndnmtthws/following{/other_user}","gists_url":"https://api.github.com/users/brndnmtthws/gists{/gist_id}","starred_url":"https://api.github.com/users/brndnmtthws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brndnmtthws/subscriptions","organizations_url":"https://api.github.com/users/brndnmtthws/orgs","repos_url":"https://api.github.com/users/brndnmtthws/repos","events_url":"https://api.github.com/users/brndnmtthws/events{/privacy}","received_events_url":"https://api.github.com/users/brndnmtthws/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brndnmtthws/conky","description":"Light-weight system monitor for X.","fork":false,"url":"https://api.github.com/repos/brndnmtthws/conky","forks_url":"https://api.github.com/repos/brndnmtthws/conky/forks","keys_url":"https://api.github.com/repos/brndnmtthws/conky/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brndnmtthws/conky/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brndnmtthws/conky/teams","hooks_url":"https://api.github.com/repos/brndnmtthws/conky/hooks","issue_events_url":"https://api.github.com/repos/brndnmtthws/conky/issues/events{/number}","events_url":"https://api.github.com/repos/brndnmtthws/conky/events","assignees_url":"https://api.github.com/repos/brndnmtthws/conky/assignees{/user}","branches_url":"https://api.github.com/repos/brndnmtthws/conky/branches{/branch}","tags_url":"https://api.github.com/repos/brndnmtthws/conky/tags","blobs_url":"https://api.github.com/repos/brndnmtthws/conky/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brndnmtthws/conky/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brndnmtthws/conky/git/refs{/sha}","trees_url":"https://api.github.com/repos/brndnmtthws/conky/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brndnmtthws/conky/statuses/{sha}","languages_url":"https://api.github.com/repos/brndnmtthws/conky/languages","stargazers_url":"https://api.github.com/repos/brndnmtthws/conky/stargazers","contributors_url":"https://api.github.com/repos/brndnmtthws/conky/contributors","subscribers_url":"https://api.github.com/repos/brndnmtthws/conky/subscribers","subscription_url":"https://api.github.com/repos/brndnmtthws/conky/subscription","commits_url":"https://api.github.com/repos/brndnmtthws/conky/commits{/sha}","git_commits_url":"https://api.github.com/repos/brndnmtthws/conky/git/commits{/sha}","comments_url":"https://api.github.com/repos/brndnmtthws/conky/comments{/number}","issue_comment_url":"https://api.github.com/repos/brndnmtthws/conky/issues/comments{/number}","contents_url":"https://api.github.com/repos/brndnmtthws/conky/contents/{+path}","compare_url":"https://api.github.com/repos/brndnmtthws/conky/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brndnmtthws/conky/merges","archive_url":"https://api.github.com/repos/brndnmtthws/conky/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brndnmtthws/conky/downloads","issues_url":"https://api.github.com/repos/brndnmtthws/conky/issues{/number}","pulls_url":"https://api.github.com/repos/brndnmtthws/conky/pulls{/number}","milestones_url":"https://api.github.com/repos/brndnmtthws/conky/milestones{/number}","notifications_url":"https://api.github.com/repos/brndnmtthws/conky/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brndnmtthws/conky/labels{/name}","releases_url":"https://api.github.com/repos/brndnmtthws/conky/releases{/id}","deployments_url":"https://api.github.com/repos/brndnmtthws/conky/deployments","created_at":"2012-12-26T19:50:17Z","updated_at":"2018-08-07T08:47:24Z","pushed_at":"2018-08-07T08:59:33Z","git_url":"git://github.com/brndnmtthws/conky.git","ssh_url":"git@github.com:brndnmtthws/conky.git","clone_url":"https://github.com/brndnmtthws/conky.git","svn_url":"https://github.com/brndnmtthws/conky","homepage":null,"size":14555,"stargazers_count":2271,"watchers_count":2271,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":316,"mirror_url":null,"archived":false,"open_issues_count":121,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":316,"open_issues":121,"watchers":2271,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brndnmtthws/conky/pulls/575"},"html":{"href":"https://github.com/brndnmtthws/conky/pull/575"},"issue":{"href":"https://api.github.com/repos/brndnmtthws/conky/issues/575"},"comments":{"href":"https://api.github.com/repos/brndnmtthws/conky/issues/575/comments"},"review_comments":{"href":"https://api.github.com/repos/brndnmtthws/conky/pulls/575/comments"},"review_comment":{"href":"https://api.github.com/repos/brndnmtthws/conky/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brndnmtthws/conky/pulls/575/commits"},"statuses":{"href":"https://api.github.com/repos/brndnmtthws/conky/statuses/b002e3d12a72c75382be0d57e49e40eee95debb5"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"conky-ci"}}