{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch-js/pulls/comments/174279815","pull_request_review_id":103607528,"id":174279815,"diff_hunk":"@@ -444,7 +444,10 @@ describe('Http Connector', function () {\n       var con = new HttpConnection(new Host());\n       var respBody = 'i should not be encoded';\n       var server = nock('http://localhost:9200')\n-      .matchHeader('accept-encoding', undefined)\n+      .matchHeader('accept-encoding', function (v) {","path":"test/unit/specs/http_connector.js","position":14,"original_position":14,"commit_id":"bb466293cb58f98cf3b5cd74a5d7894fde793218","original_commit_id":"bb466293cb58f98cf3b5cd74a5d7894fde793218","user":{"login":"dominykas","id":505619,"avatar_url":"https://avatars1.githubusercontent.com/u/505619?v=4","gravatar_id":"","url":"https://api.github.com/users/dominykas","html_url":"https://github.com/dominykas","followers_url":"https://api.github.com/users/dominykas/followers","following_url":"https://api.github.com/users/dominykas/following{/other_user}","gists_url":"https://api.github.com/users/dominykas/gists{/gist_id}","starred_url":"https://api.github.com/users/dominykas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominykas/subscriptions","organizations_url":"https://api.github.com/users/dominykas/orgs","repos_url":"https://api.github.com/users/dominykas/repos","events_url":"https://api.github.com/users/dominykas/events{/privacy}","received_events_url":"https://api.github.com/users/dominykas/received_events","type":"User","site_admin":false},"body":"`nock@9` doesn't seem to do a match on `undefined` - changing to a matcher function.","created_at":"2018-03-13T20:51:19Z","updated_at":"2018-03-13T20:51:19Z","html_url":"https://github.com/elastic/elasticsearch-js/pull/643#discussion_r174279815","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch-js/pulls/643","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch-js/pulls/comments/174279815"},"html":{"href":"https://github.com/elastic/elasticsearch-js/pull/643#discussion_r174279815"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch-js/pulls/643"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch-js/pulls/643","id":174776416,"html_url":"https://github.com/elastic/elasticsearch-js/pull/643","diff_url":"https://github.com/elastic/elasticsearch-js/pull/643.diff","patch_url":"https://github.com/elastic/elasticsearch-js/pull/643.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch-js/issues/643","number":643,"state":"open","locked":false,"title":"Make unit tests pass in node 8","user":{"login":"dominykas","id":505619,"avatar_url":"https://avatars1.githubusercontent.com/u/505619?v=4","gravatar_id":"","url":"https://api.github.com/users/dominykas","html_url":"https://github.com/dominykas","followers_url":"https://api.github.com/users/dominykas/followers","following_url":"https://api.github.com/users/dominykas/following{/other_user}","gists_url":"https://api.github.com/users/dominykas/gists{/gist_id}","starred_url":"https://api.github.com/users/dominykas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominykas/subscriptions","organizations_url":"https://api.github.com/users/dominykas/orgs","repos_url":"https://api.github.com/users/dominykas/repos","events_url":"https://api.github.com/users/dominykas/events{/privacy}","received_events_url":"https://api.github.com/users/dominykas/received_events","type":"User","site_admin":false},"body":"`_.every()` calls the function with `(item, index)` - if we directly pass that through - node 8 crashes, because `isRegexp` check expects a single argument; the fix is to make sure we call `check()` with a single argument.\r\n\r\nI do wonder, though, if all of the `isArrayOf...` stuff should be removed altogether, as the only time I see this used is a single `isArrayOfStrings()` call.\r\n\r\nAlso curious about the `slice()` - is that for performance reasons that this only checks the first 10 members of an array?","created_at":"2018-03-13T20:11:55Z","updated_at":"2018-03-13T20:51:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11b5846c57f4c553a5cce8cd5aedea028ae66300","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch-js/pulls/643/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch-js/pulls/643/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch-js/issues/643/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch-js/statuses/bb466293cb58f98cf3b5cd74a5d7894fde793218","head":{"label":"dominykas:fix-node-8","ref":"fix-node-8","sha":"bb466293cb58f98cf3b5cd74a5d7894fde793218","user":{"login":"dominykas","id":505619,"avatar_url":"https://avatars1.githubusercontent.com/u/505619?v=4","gravatar_id":"","url":"https://api.github.com/users/dominykas","html_url":"https://github.com/dominykas","followers_url":"https://api.github.com/users/dominykas/followers","following_url":"https://api.github.com/users/dominykas/following{/other_user}","gists_url":"https://api.github.com/users/dominykas/gists{/gist_id}","starred_url":"https://api.github.com/users/dominykas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominykas/subscriptions","organizations_url":"https://api.github.com/users/dominykas/orgs","repos_url":"https://api.github.com/users/dominykas/repos","events_url":"https://api.github.com/users/dominykas/events{/privacy}","received_events_url":"https://api.github.com/users/dominykas/received_events","type":"User","site_admin":false},"repo":{"id":121763831,"name":"elasticsearch-js","full_name":"dominykas/elasticsearch-js","owner":{"login":"dominykas","id":505619,"avatar_url":"https://avatars1.githubusercontent.com/u/505619?v=4","gravatar_id":"","url":"https://api.github.com/users/dominykas","html_url":"https://github.com/dominykas","followers_url":"https://api.github.com/users/dominykas/followers","following_url":"https://api.github.com/users/dominykas/following{/other_user}","gists_url":"https://api.github.com/users/dominykas/gists{/gist_id}","starred_url":"https://api.github.com/users/dominykas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominykas/subscriptions","organizations_url":"https://api.github.com/users/dominykas/orgs","repos_url":"https://api.github.com/users/dominykas/repos","events_url":"https://api.github.com/users/dominykas/events{/privacy}","received_events_url":"https://api.github.com/users/dominykas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dominykas/elasticsearch-js","description":"Official Elasticsearch client library for Node.js and the browser","fork":true,"url":"https://api.github.com/repos/dominykas/elasticsearch-js","forks_url":"https://api.github.com/repos/dominykas/elasticsearch-js/forks","keys_url":"https://api.github.com/repos/dominykas/elasticsearch-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dominykas/elasticsearch-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dominykas/elasticsearch-js/teams","hooks_url":"https://api.github.com/repos/dominykas/elasticsearch-js/hooks","issue_events_url":"https://api.github.com/repos/dominykas/elasticsearch-js/issues/events{/number}","events_url":"https://api.github.com/repos/dominykas/elasticsearch-js/events","assignees_url":"https://api.github.com/repos/dominykas/elasticsearch-js/assignees{/user}","branches_url":"https://api.github.com/repos/dominykas/elasticsearch-js/branches{/branch}","tags_url":"https://api.github.com/repos/dominykas/elasticsearch-js/tags","blobs_url":"https://api.github.com/repos/dominykas/elasticsearch-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dominykas/elasticsearch-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dominykas/elasticsearch-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/dominykas/elasticsearch-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dominykas/elasticsearch-js/statuses/{sha}","languages_url":"https://api.github.com/repos/dominykas/elasticsearch-js/languages","stargazers_url":"https://api.github.com/repos/dominykas/elasticsearch-js/stargazers","contributors_url":"https://api.github.com/repos/dominykas/elasticsearch-js/contributors","subscribers_url":"https://api.github.com/repos/dominykas/elasticsearch-js/subscribers","subscription_url":"https://api.github.com/repos/dominykas/elasticsearch-js/subscription","commits_url":"https://api.github.com/repos/dominykas/elasticsearch-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/dominykas/elasticsearch-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/dominykas/elasticsearch-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/dominykas/elasticsearch-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/dominykas/elasticsearch-js/contents/{+path}","compare_url":"https://api.github.com/repos/dominykas/elasticsearch-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dominykas/elasticsearch-js/merges","archive_url":"https://api.github.com/repos/dominykas/elasticsearch-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dominykas/elasticsearch-js/downloads","issues_url":"https://api.github.com/repos/dominykas/elasticsearch-js/issues{/number}","pulls_url":"https://api.github.com/repos/dominykas/elasticsearch-js/pulls{/number}","milestones_url":"https://api.github.com/repos/dominykas/elasticsearch-js/milestones{/number}","notifications_url":"https://api.github.com/repos/dominykas/elasticsearch-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dominykas/elasticsearch-js/labels{/name}","releases_url":"https://api.github.com/repos/dominykas/elasticsearch-js/releases{/id}","deployments_url":"https://api.github.com/repos/dominykas/elasticsearch-js/deployments","created_at":"2018-02-16T15:05:13Z","updated_at":"2018-02-16T15:05:16Z","pushed_at":"2018-03-13T20:33:39Z","git_url":"git://github.com/dominykas/elasticsearch-js.git","ssh_url":"git@github.com:dominykas/elasticsearch-js.git","clone_url":"https://github.com/dominykas/elasticsearch-js.git","svn_url":"https://github.com/dominykas/elasticsearch-js","homepage":"https://www.elastic.co/guide/en/elasticsearch/client/javascript-api/current/index.html","size":6660,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"14.x"}},"base":{"label":"elastic:14.x","ref":"14.x","sha":"b7fae6f94b417e464b454d0488509e660349186d","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":10854028,"name":"elasticsearch-js","full_name":"elastic/elasticsearch-js","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch-js","description":"Official Elasticsearch client library for Node.js and the browser","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch-js","forks_url":"https://api.github.com/repos/elastic/elasticsearch-js/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch-js/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch-js/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch-js/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch-js/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch-js/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch-js/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch-js/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch-js/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch-js/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch-js/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch-js/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch-js/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch-js/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch-js/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch-js/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch-js/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch-js/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch-js/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch-js/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch-js/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch-js/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch-js/deployments","created_at":"2013-06-21T22:27:36Z","updated_at":"2018-03-13T18:21:25Z","pushed_at":"2018-03-13T20:33:41Z","git_url":"git://github.com/elastic/elasticsearch-js.git","ssh_url":"git@github.com:elastic/elasticsearch-js.git","clone_url":"https://github.com/elastic/elasticsearch-js.git","svn_url":"https://github.com/elastic/elasticsearch-js","homepage":"https://www.elastic.co/guide/en/elasticsearch/client/javascript-api/current/index.html","size":6661,"stargazers_count":2572,"watchers_count":2572,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":364,"mirror_url":null,"archived":false,"open_issues_count":123,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":364,"open_issues":123,"watchers":2572,"default_branch":"14.x"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch-js/pulls/643"},"html":{"href":"https://github.com/elastic/elasticsearch-js/pull/643"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch-js/issues/643"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch-js/issues/643/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch-js/pulls/643/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch-js/pulls/643/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch-js/statuses/bb466293cb58f98cf3b5cd74a5d7894fde793218"}},"author_association":"NONE"}}
{"actor":{"display_login":"dominykas"}}