{"action":"created","comment":{"url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/comments/167509251","pull_request_review_id":95737004,"id":167509251,"diff_hunk":"@@ -358,11 +370,12 @@ export class QuickOpenModal extends Component<Props, State> {\n \n   render() {\n     const { enabled, query } = this.props;\n-    const { selectedIndex, results } = this.state;\n+    let { selectedIndex, results, isLoading } = this.state;","path":"src/components/QuickOpenModal.js","position":87,"original_position":87,"commit_id":"3c1e74b8888797a4d7a4f879d1056670ec4faeed","original_commit_id":"3c1e74b8888797a4d7a4f879d1056670ec4faeed","user":{"login":"codehag","id":26968615,"avatar_url":"https://avatars2.githubusercontent.com/u/26968615?v=4","gravatar_id":"","url":"https://api.github.com/users/codehag","html_url":"https://github.com/codehag","followers_url":"https://api.github.com/users/codehag/followers","following_url":"https://api.github.com/users/codehag/following{/other_user}","gists_url":"https://api.github.com/users/codehag/gists{/gist_id}","starred_url":"https://api.github.com/users/codehag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codehag/subscriptions","organizations_url":"https://api.github.com/users/codehag/orgs","repos_url":"https://api.github.com/users/codehag/repos","events_url":"https://api.github.com/users/codehag/events{/privacy}","received_events_url":"https://api.github.com/users/codehag/received_events","type":"User","site_admin":false},"body":"agreeing with @AnshulMalik -- since none of these variables are reassigned (and since they are part of state and should only be updated via setState), we can use const here!","created_at":"2018-02-12T10:07:54Z","updated_at":"2018-02-12T10:07:55Z","html_url":"https://github.com/devtools-html/debugger.html/pull/5371#discussion_r167509251","pull_request_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/5371","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/comments/167509251"},"html":{"href":"https://github.com/devtools-html/debugger.html/pull/5371#discussion_r167509251"},"pull_request":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/5371"}},"in_reply_to_id":167479257},"pull_request":{"url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/5371","id":168144085,"html_url":"https://github.com/devtools-html/debugger.html/pull/5371","diff_url":"https://github.com/devtools-html/debugger.html/pull/5371.diff","patch_url":"https://github.com/devtools-html/debugger.html/pull/5371.patch","issue_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/5371","number":5371,"state":"open","locked":false,"title":"[QuickOpen] show indicator if symbols are still being parsed","user":{"login":"atwalg2","id":23143862,"avatar_url":"https://avatars1.githubusercontent.com/u/23143862?v=4","gravatar_id":"","url":"https://api.github.com/users/atwalg2","html_url":"https://github.com/atwalg2","followers_url":"https://api.github.com/users/atwalg2/followers","following_url":"https://api.github.com/users/atwalg2/following{/other_user}","gists_url":"https://api.github.com/users/atwalg2/gists{/gist_id}","starred_url":"https://api.github.com/users/atwalg2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atwalg2/subscriptions","organizations_url":"https://api.github.com/users/atwalg2/orgs","repos_url":"https://api.github.com/users/atwalg2/repos","events_url":"https://api.github.com/users/atwalg2/events{/privacy}","received_events_url":"https://api.github.com/users/atwalg2/received_events","type":"User","site_admin":false},"body":"Associated Issue: #4488\r\n\r\n### Summary of Changes\r\n\r\n* Added loading element as a wrapper around Results\r\n\r\n### Test Plan\r\n\r\n### To Do\r\n- [ ]  Set up logic\r\n- [x] \"Loading ....\" text shows\r\n- [ ] Bottom Border Animation (Transitions left to right color)\r\n\r\n![screencap](https://user-images.githubusercontent.com/23143862/36020952-90b3c8ba-0d41-11e8-85b5-c8c3171b1687.gif)\r\n\r\nMost Recent Look\r\n![image](https://user-images.githubusercontent.com/23143862/36068927-88b6bdc2-0e9d-11e8-9e4f-49d0d0be903b.png)\r\n\r\n","created_at":"2018-02-09T03:13:41Z","updated_at":"2018-02-12T10:07:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4120df4da228ba074df451a0d578ea4be9eed9a7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/5371/commits","review_comments_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/5371/comments","review_comment_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/comments{/number}","comments_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/5371/comments","statuses_url":"https://api.github.com/repos/devtools-html/debugger.html/statuses/3c1e74b8888797a4d7a4f879d1056670ec4faeed","head":{"label":"atwalg2:quickopenIndicator","ref":"quickopenIndicator","sha":"3c1e74b8888797a4d7a4f879d1056670ec4faeed","user":{"login":"atwalg2","id":23143862,"avatar_url":"https://avatars1.githubusercontent.com/u/23143862?v=4","gravatar_id":"","url":"https://api.github.com/users/atwalg2","html_url":"https://github.com/atwalg2","followers_url":"https://api.github.com/users/atwalg2/followers","following_url":"https://api.github.com/users/atwalg2/following{/other_user}","gists_url":"https://api.github.com/users/atwalg2/gists{/gist_id}","starred_url":"https://api.github.com/users/atwalg2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atwalg2/subscriptions","organizations_url":"https://api.github.com/users/atwalg2/orgs","repos_url":"https://api.github.com/users/atwalg2/repos","events_url":"https://api.github.com/users/atwalg2/events{/privacy}","received_events_url":"https://api.github.com/users/atwalg2/received_events","type":"User","site_admin":false},"repo":{"id":118177636,"name":"debugger.html","full_name":"atwalg2/debugger.html","owner":{"login":"atwalg2","id":23143862,"avatar_url":"https://avatars1.githubusercontent.com/u/23143862?v=4","gravatar_id":"","url":"https://api.github.com/users/atwalg2","html_url":"https://github.com/atwalg2","followers_url":"https://api.github.com/users/atwalg2/followers","following_url":"https://api.github.com/users/atwalg2/following{/other_user}","gists_url":"https://api.github.com/users/atwalg2/gists{/gist_id}","starred_url":"https://api.github.com/users/atwalg2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atwalg2/subscriptions","organizations_url":"https://api.github.com/users/atwalg2/orgs","repos_url":"https://api.github.com/users/atwalg2/repos","events_url":"https://api.github.com/users/atwalg2/events{/privacy}","received_events_url":"https://api.github.com/users/atwalg2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/atwalg2/debugger.html","description":"The Firefox debugger that works anywhere  :boom:","fork":true,"url":"https://api.github.com/repos/atwalg2/debugger.html","forks_url":"https://api.github.com/repos/atwalg2/debugger.html/forks","keys_url":"https://api.github.com/repos/atwalg2/debugger.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atwalg2/debugger.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atwalg2/debugger.html/teams","hooks_url":"https://api.github.com/repos/atwalg2/debugger.html/hooks","issue_events_url":"https://api.github.com/repos/atwalg2/debugger.html/issues/events{/number}","events_url":"https://api.github.com/repos/atwalg2/debugger.html/events","assignees_url":"https://api.github.com/repos/atwalg2/debugger.html/assignees{/user}","branches_url":"https://api.github.com/repos/atwalg2/debugger.html/branches{/branch}","tags_url":"https://api.github.com/repos/atwalg2/debugger.html/tags","blobs_url":"https://api.github.com/repos/atwalg2/debugger.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atwalg2/debugger.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atwalg2/debugger.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/atwalg2/debugger.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atwalg2/debugger.html/statuses/{sha}","languages_url":"https://api.github.com/repos/atwalg2/debugger.html/languages","stargazers_url":"https://api.github.com/repos/atwalg2/debugger.html/stargazers","contributors_url":"https://api.github.com/repos/atwalg2/debugger.html/contributors","subscribers_url":"https://api.github.com/repos/atwalg2/debugger.html/subscribers","subscription_url":"https://api.github.com/repos/atwalg2/debugger.html/subscription","commits_url":"https://api.github.com/repos/atwalg2/debugger.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/atwalg2/debugger.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/atwalg2/debugger.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/atwalg2/debugger.html/issues/comments{/number}","contents_url":"https://api.github.com/repos/atwalg2/debugger.html/contents/{+path}","compare_url":"https://api.github.com/repos/atwalg2/debugger.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atwalg2/debugger.html/merges","archive_url":"https://api.github.com/repos/atwalg2/debugger.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atwalg2/debugger.html/downloads","issues_url":"https://api.github.com/repos/atwalg2/debugger.html/issues{/number}","pulls_url":"https://api.github.com/repos/atwalg2/debugger.html/pulls{/number}","milestones_url":"https://api.github.com/repos/atwalg2/debugger.html/milestones{/number}","notifications_url":"https://api.github.com/repos/atwalg2/debugger.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atwalg2/debugger.html/labels{/name}","releases_url":"https://api.github.com/repos/atwalg2/debugger.html/releases{/id}","deployments_url":"https://api.github.com/repos/atwalg2/debugger.html/deployments","created_at":"2018-01-19T20:57:06Z","updated_at":"2018-01-21T06:45:03Z","pushed_at":"2018-02-11T03:08:06Z","git_url":"git://github.com/atwalg2/debugger.html.git","ssh_url":"git@github.com:atwalg2/debugger.html.git","clone_url":"https://github.com/atwalg2/debugger.html.git","svn_url":"https://github.com/atwalg2/debugger.html","homepage":"https://devtools-html.github.io/debugger.html/","size":15784,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"devtools-html:master","ref":"master","sha":"4f7001fa03276a900ddc5fa0a3fa0d815f1e3d51","user":{"login":"devtools-html","id":19979421,"avatar_url":"https://avatars2.githubusercontent.com/u/19979421?v=4","gravatar_id":"","url":"https://api.github.com/users/devtools-html","html_url":"https://github.com/devtools-html","followers_url":"https://api.github.com/users/devtools-html/followers","following_url":"https://api.github.com/users/devtools-html/following{/other_user}","gists_url":"https://api.github.com/users/devtools-html/gists{/gist_id}","starred_url":"https://api.github.com/users/devtools-html/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devtools-html/subscriptions","organizations_url":"https://api.github.com/users/devtools-html/orgs","repos_url":"https://api.github.com/users/devtools-html/repos","events_url":"https://api.github.com/users/devtools-html/events{/privacy}","received_events_url":"https://api.github.com/users/devtools-html/received_events","type":"Organization","site_admin":false},"repo":{"id":54585418,"name":"debugger.html","full_name":"devtools-html/debugger.html","owner":{"login":"devtools-html","id":19979421,"avatar_url":"https://avatars2.githubusercontent.com/u/19979421?v=4","gravatar_id":"","url":"https://api.github.com/users/devtools-html","html_url":"https://github.com/devtools-html","followers_url":"https://api.github.com/users/devtools-html/followers","following_url":"https://api.github.com/users/devtools-html/following{/other_user}","gists_url":"https://api.github.com/users/devtools-html/gists{/gist_id}","starred_url":"https://api.github.com/users/devtools-html/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devtools-html/subscriptions","organizations_url":"https://api.github.com/users/devtools-html/orgs","repos_url":"https://api.github.com/users/devtools-html/repos","events_url":"https://api.github.com/users/devtools-html/events{/privacy}","received_events_url":"https://api.github.com/users/devtools-html/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/devtools-html/debugger.html","description":"The Firefox debugger that works anywhere  :boom:","fork":false,"url":"https://api.github.com/repos/devtools-html/debugger.html","forks_url":"https://api.github.com/repos/devtools-html/debugger.html/forks","keys_url":"https://api.github.com/repos/devtools-html/debugger.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/devtools-html/debugger.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/devtools-html/debugger.html/teams","hooks_url":"https://api.github.com/repos/devtools-html/debugger.html/hooks","issue_events_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/events{/number}","events_url":"https://api.github.com/repos/devtools-html/debugger.html/events","assignees_url":"https://api.github.com/repos/devtools-html/debugger.html/assignees{/user}","branches_url":"https://api.github.com/repos/devtools-html/debugger.html/branches{/branch}","tags_url":"https://api.github.com/repos/devtools-html/debugger.html/tags","blobs_url":"https://api.github.com/repos/devtools-html/debugger.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/devtools-html/debugger.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/devtools-html/debugger.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/devtools-html/debugger.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/devtools-html/debugger.html/statuses/{sha}","languages_url":"https://api.github.com/repos/devtools-html/debugger.html/languages","stargazers_url":"https://api.github.com/repos/devtools-html/debugger.html/stargazers","contributors_url":"https://api.github.com/repos/devtools-html/debugger.html/contributors","subscribers_url":"https://api.github.com/repos/devtools-html/debugger.html/subscribers","subscription_url":"https://api.github.com/repos/devtools-html/debugger.html/subscription","commits_url":"https://api.github.com/repos/devtools-html/debugger.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/devtools-html/debugger.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/devtools-html/debugger.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/comments{/number}","contents_url":"https://api.github.com/repos/devtools-html/debugger.html/contents/{+path}","compare_url":"https://api.github.com/repos/devtools-html/debugger.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/devtools-html/debugger.html/merges","archive_url":"https://api.github.com/repos/devtools-html/debugger.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/devtools-html/debugger.html/downloads","issues_url":"https://api.github.com/repos/devtools-html/debugger.html/issues{/number}","pulls_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls{/number}","milestones_url":"https://api.github.com/repos/devtools-html/debugger.html/milestones{/number}","notifications_url":"https://api.github.com/repos/devtools-html/debugger.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/devtools-html/debugger.html/labels{/name}","releases_url":"https://api.github.com/repos/devtools-html/debugger.html/releases{/id}","deployments_url":"https://api.github.com/repos/devtools-html/debugger.html/deployments","created_at":"2016-03-23T18:55:36Z","updated_at":"2018-02-12T08:36:38Z","pushed_at":"2018-02-12T10:02:26Z","git_url":"git://github.com/devtools-html/debugger.html.git","ssh_url":"git@github.com:devtools-html/debugger.html.git","clone_url":"https://github.com/devtools-html/debugger.html.git","svn_url":"https://github.com/devtools-html/debugger.html","homepage":"https://devtools-html.github.io/debugger.html/","size":15887,"stargazers_count":3448,"watchers_count":3448,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":538,"mirror_url":null,"archived":false,"open_issues_count":226,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":538,"open_issues":226,"watchers":3448,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/5371"},"html":{"href":"https://github.com/devtools-html/debugger.html/pull/5371"},"issue":{"href":"https://api.github.com/repos/devtools-html/debugger.html/issues/5371"},"comments":{"href":"https://api.github.com/repos/devtools-html/debugger.html/issues/5371/comments"},"review_comments":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/5371/comments"},"review_comment":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/5371/commits"},"statuses":{"href":"https://api.github.com/repos/devtools-html/debugger.html/statuses/3c1e74b8888797a4d7a4f879d1056670ec4faeed"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"codehag"}}