{"action":"created","issue":{"url":"https://api.github.com/repos/frappe/frappe/issues/6076","repository_url":"https://api.github.com/repos/frappe/frappe","labels_url":"https://api.github.com/repos/frappe/frappe/issues/6076/labels{/name}","comments_url":"https://api.github.com/repos/frappe/frappe/issues/6076/comments","events_url":"https://api.github.com/repos/frappe/frappe/issues/6076/events","html_url":"https://github.com/frappe/frappe/pull/6076","id":358613192,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MzA2NTky","number":6076,"title":"Auto repeat improvements","user":{"login":"chdecultot","id":4903591,"node_id":"MDQ6VXNlcjQ5MDM1OTE=","avatar_url":"https://avatars3.githubusercontent.com/u/4903591?v=4","gravatar_id":"","url":"https://api.github.com/users/chdecultot","html_url":"https://github.com/chdecultot","followers_url":"https://api.github.com/users/chdecultot/followers","following_url":"https://api.github.com/users/chdecultot/following{/other_user}","gists_url":"https://api.github.com/users/chdecultot/gists{/gist_id}","starred_url":"https://api.github.com/users/chdecultot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chdecultot/subscriptions","organizations_url":"https://api.github.com/users/chdecultot/orgs","repos_url":"https://api.github.com/users/chdecultot/repos","events_url":"https://api.github.com/users/chdecultot/events{/privacy}","received_events_url":"https://api.github.com/users/chdecultot/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-09-10T13:03:55Z","updated_at":"2018-09-18T13:39:04Z","closed_at":"2018-09-12T11:52:18Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/frappe/frappe/pulls/6076","html_url":"https://github.com/frappe/frappe/pull/6076","diff_url":"https://github.com/frappe/frappe/pull/6076.diff","patch_url":"https://github.com/frappe/frappe/pull/6076.patch"},"body":"Hi,\r\n\r\nWhile using the auto repeat doctype in production we noticed a few issues and I'm therefore proposing the below solutions:\r\n\r\n1. The \"Resume\" button is incorrectly translated because there can only be one global translation for each word.\r\nSince \"Resume\" is already used in the HR module and translated as \"CV\" in french (We don't have any common translation), the button in auto repeat is also translated \"CV\" which is terrible in terms in UX.\r\nI therefore propose to change it to \"Restart\" (as opposed to \"Stop\").\r\n\r\nI also corrected the translation of the first button (See {0}) so that the doctype can be translated and allowed the status of the document to be modified after submission to avoid errors when clicking on \"Stop\"\r\n\r\n![image](https://user-images.githubusercontent.com/4903591/45298760-cdfc5780-b509-11e8-8d4f-9d2490677e46.png)\r\n\r\n\r\n2. I stopped the generation of the repeat schedule when the status is 'Stopped', 'Cancelled' or \"Expired\" since it is very confusing for end users otherwise.\r\n\r\n![image](https://user-images.githubusercontent.com/4903591/45298862-16b41080-b50a-11e8-86e5-87a12a2cef24.png)\r\n\r\n\r\n3. I added a new button to preview the message to be sent.\r\nWe noticed that the message need to include the 'doc' word in jinja variables in order to work correctly. It is a behavior that differs from email templates where the 'doc' variable is not necessary and leads to issues when emails are sent if the user doesn't pay attention.\r\n\r\n![image](https://user-images.githubusercontent.com/4903591/45298889-26335980-b50a-11e8-8523-fd17136cd371.png)\r\n\r\n\r\n4. Users, most of the time, want to see to which party the auto repeat is linked to (for subscriptions for example).\r\nI therefore added an optional party reference in the document that automatically links to Customers, Suppliers and Employees if they exist in the reference document.\r\n\r\n![image](https://user-images.githubusercontent.com/4903591/45298906-34817580-b50a-11e8-9e5e-da33fae8b4d1.png)\r\n\r\n\r\n5. The modification of the email recipients and message is something that can happen often. The cancellation/amendment process is rather time consuming and not necessary for this kind of information, therefore I propose to make the fields linked to the email notification editable after submission.\r\n\r\n![image](https://user-images.githubusercontent.com/4903591/45298952-5549cb00-b50a-11e8-9dd9-7e5c112a207f.png)\r\n\r\n\r\nPlease let me know if you have any question regarding these changes.\r\n\r\n\r\nThank you!"},"comment":{"url":"https://api.github.com/repos/frappe/frappe/issues/comments/422396915","html_url":"https://github.com/frappe/frappe/pull/6076#issuecomment-422396915","issue_url":"https://api.github.com/repos/frappe/frappe/issues/6076","id":422396915,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjM5NjkxNQ==","user":{"login":"chdecultot","id":4903591,"node_id":"MDQ6VXNlcjQ5MDM1OTE=","avatar_url":"https://avatars3.githubusercontent.com/u/4903591?v=4","gravatar_id":"","url":"https://api.github.com/users/chdecultot","html_url":"https://github.com/chdecultot","followers_url":"https://api.github.com/users/chdecultot/followers","following_url":"https://api.github.com/users/chdecultot/following{/other_user}","gists_url":"https://api.github.com/users/chdecultot/gists{/gist_id}","starred_url":"https://api.github.com/users/chdecultot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chdecultot/subscriptions","organizations_url":"https://api.github.com/users/chdecultot/orgs","repos_url":"https://api.github.com/users/chdecultot/repos","events_url":"https://api.github.com/users/chdecultot/events{/privacy}","received_events_url":"https://api.github.com/users/chdecultot/received_events","type":"User","site_admin":false},"created_at":"2018-09-18T13:39:04Z","updated_at":"2018-09-18T13:39:04Z","author_association":"CONTRIBUTOR","body":"Hi @Mohd200,\r\n\r\nYou're right, it seems like it has not been designed that way.\r\nIt only filters standard DocTypes.\r\n\r\nMaybe you could modify this query by adding a selection on the Custom Field table."}}
{"actor":{"display_login":"chdecultot"}}