{"action":"created","comment":{"url":"https://api.github.com/repos/talis/echo-php-client/pulls/comments/202046334","pull_request_review_id":136664747,"id":202046334,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjA0NjMzNA==","diff_hunk":"@@ -394,15 +398,20 @@ public static function setLogger(Logger $logger)\n      * @param string $source\n      * @param array $props\n      * @param string|null $userId\n+     * @param string|null $timestamp\n      * @return string json encoded echo event\n      */\n-    protected function getEventJson($class, $source, array $props = array(), $userId = null)\n+    protected function getEventJson($class, $source, array $props = array(), $userId = null, $timestamp = null)","path":"src/echoclient/EchoClient.php","position":108,"original_position":108,"commit_id":"df4b120b5aaa23342d5fd3207ee3da518c8458a6","original_commit_id":"df4b120b5aaa23342d5fd3207ee3da518c8458a6","user":{"login":"junglebarry","id":242248,"node_id":"MDQ6VXNlcjI0MjI0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/242248?v=4","gravatar_id":"","url":"https://api.github.com/users/junglebarry","html_url":"https://github.com/junglebarry","followers_url":"https://api.github.com/users/junglebarry/followers","following_url":"https://api.github.com/users/junglebarry/following{/other_user}","gists_url":"https://api.github.com/users/junglebarry/gists{/gist_id}","starred_url":"https://api.github.com/users/junglebarry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junglebarry/subscriptions","organizations_url":"https://api.github.com/users/junglebarry/orgs","repos_url":"https://api.github.com/users/junglebarry/repos","events_url":"https://api.github.com/users/junglebarry/events{/privacy}","received_events_url":"https://api.github.com/users/junglebarry/received_events","type":"User","site_admin":false},"body":"If my suggestion above were followed (have the old `createEvent` method construct an `EchoEvent` and call `createEvents`), this may not be required...?","created_at":"2018-07-12T14:02:54Z","updated_at":"2018-07-12T14:02:54Z","html_url":"https://github.com/talis/echo-php-client/pull/16#discussion_r202046334","pull_request_url":"https://api.github.com/repos/talis/echo-php-client/pulls/16","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/talis/echo-php-client/pulls/comments/202046334"},"html":{"href":"https://github.com/talis/echo-php-client/pull/16#discussion_r202046334"},"pull_request":{"href":"https://api.github.com/repos/talis/echo-php-client/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/talis/echo-php-client/pulls/16","id":200689490,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNjg5NDkw","html_url":"https://github.com/talis/echo-php-client/pull/16","diff_url":"https://github.com/talis/echo-php-client/pull/16.diff","patch_url":"https://github.com/talis/echo-php-client/pull/16.patch","issue_url":"https://api.github.com/repos/talis/echo-php-client/issues/16","number":16,"state":"open","locked":false,"title":"30% SHIP-1292 / PLAT-1644  Send batched events","user":{"login":"kiyanwang","id":1135464,"node_id":"MDQ6VXNlcjExMzU0NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1135464?v=4","gravatar_id":"","url":"https://api.github.com/users/kiyanwang","html_url":"https://github.com/kiyanwang","followers_url":"https://api.github.com/users/kiyanwang/followers","following_url":"https://api.github.com/users/kiyanwang/following{/other_user}","gists_url":"https://api.github.com/users/kiyanwang/gists{/gist_id}","starred_url":"https://api.github.com/users/kiyanwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiyanwang/subscriptions","organizations_url":"https://api.github.com/users/kiyanwang/orgs","repos_url":"https://api.github.com/users/kiyanwang/repos","events_url":"https://api.github.com/users/kiyanwang/events{/privacy}","received_events_url":"https://api.github.com/users/kiyanwang/received_events","type":"User","site_admin":false},"body":"This addresses requirements in both talis/shipshape-app#1292 and talis/platform#1644\r\n\r\n- [x] add support for specifying a timestamp when creating an event\r\n- [x] add support for sending a batch of events in a single operation\r\n  - [x] introduce a new type `EchoEvent` to describe events so we can type them accordingly.\r\n  - [x] limit the batch to 100 events\r\n  - [x] limit the batch to 1MB\r\n    - [ ] add test for 1mb check\r\n- [x] add / update tests\r\n- [x] introduce a dockerfile to provide a local development environment\r\n  - [x] update README.me with instructions on how to use the Dockerfile.","created_at":"2018-07-11T12:51:43Z","updated_at":"2018-07-12T14:02:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eaf2297e5174fc0af34ce3d6746d0196084e6c4e","assignee":{"login":"kiyanwang","id":1135464,"node_id":"MDQ6VXNlcjExMzU0NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1135464?v=4","gravatar_id":"","url":"https://api.github.com/users/kiyanwang","html_url":"https://github.com/kiyanwang","followers_url":"https://api.github.com/users/kiyanwang/followers","following_url":"https://api.github.com/users/kiyanwang/following{/other_user}","gists_url":"https://api.github.com/users/kiyanwang/gists{/gist_id}","starred_url":"https://api.github.com/users/kiyanwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiyanwang/subscriptions","organizations_url":"https://api.github.com/users/kiyanwang/orgs","repos_url":"https://api.github.com/users/kiyanwang/repos","events_url":"https://api.github.com/users/kiyanwang/events{/privacy}","received_events_url":"https://api.github.com/users/kiyanwang/received_events","type":"User","site_admin":false},"assignees":[{"login":"kiyanwang","id":1135464,"node_id":"MDQ6VXNlcjExMzU0NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1135464?v=4","gravatar_id":"","url":"https://api.github.com/users/kiyanwang","html_url":"https://github.com/kiyanwang","followers_url":"https://api.github.com/users/kiyanwang/followers","following_url":"https://api.github.com/users/kiyanwang/following{/other_user}","gists_url":"https://api.github.com/users/kiyanwang/gists{/gist_id}","starred_url":"https://api.github.com/users/kiyanwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiyanwang/subscriptions","organizations_url":"https://api.github.com/users/kiyanwang/orgs","repos_url":"https://api.github.com/users/kiyanwang/repos","events_url":"https://api.github.com/users/kiyanwang/events{/privacy}","received_events_url":"https://api.github.com/users/kiyanwang/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/talis/echo-php-client/pulls/16/commits","review_comments_url":"https://api.github.com/repos/talis/echo-php-client/pulls/16/comments","review_comment_url":"https://api.github.com/repos/talis/echo-php-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/talis/echo-php-client/issues/16/comments","statuses_url":"https://api.github.com/repos/talis/echo-php-client/statuses/df4b120b5aaa23342d5fd3207ee3da518c8458a6","head":{"label":"talis:ship-1292-batch-events","ref":"ship-1292-batch-events","sha":"df4b120b5aaa23342d5fd3207ee3da518c8458a6","user":{"login":"talis","id":181416,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTQxNg==","avatar_url":"https://avatars1.githubusercontent.com/u/181416?v=4","gravatar_id":"","url":"https://api.github.com/users/talis","html_url":"https://github.com/talis","followers_url":"https://api.github.com/users/talis/followers","following_url":"https://api.github.com/users/talis/following{/other_user}","gists_url":"https://api.github.com/users/talis/gists{/gist_id}","starred_url":"https://api.github.com/users/talis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talis/subscriptions","organizations_url":"https://api.github.com/users/talis/orgs","repos_url":"https://api.github.com/users/talis/repos","events_url":"https://api.github.com/users/talis/events{/privacy}","received_events_url":"https://api.github.com/users/talis/received_events","type":"Organization","site_admin":false},"repo":{"id":19144395,"node_id":"MDEwOlJlcG9zaXRvcnkxOTE0NDM5NQ==","name":"echo-php-client","full_name":"talis/echo-php-client","owner":{"login":"talis","id":181416,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTQxNg==","avatar_url":"https://avatars1.githubusercontent.com/u/181416?v=4","gravatar_id":"","url":"https://api.github.com/users/talis","html_url":"https://github.com/talis","followers_url":"https://api.github.com/users/talis/followers","following_url":"https://api.github.com/users/talis/following{/other_user}","gists_url":"https://api.github.com/users/talis/gists{/gist_id}","starred_url":"https://api.github.com/users/talis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talis/subscriptions","organizations_url":"https://api.github.com/users/talis/orgs","repos_url":"https://api.github.com/users/talis/repos","events_url":"https://api.github.com/users/talis/events{/privacy}","received_events_url":"https://api.github.com/users/talis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/talis/echo-php-client","description":"PHP client library for echo-server","fork":false,"url":"https://api.github.com/repos/talis/echo-php-client","forks_url":"https://api.github.com/repos/talis/echo-php-client/forks","keys_url":"https://api.github.com/repos/talis/echo-php-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/talis/echo-php-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/talis/echo-php-client/teams","hooks_url":"https://api.github.com/repos/talis/echo-php-client/hooks","issue_events_url":"https://api.github.com/repos/talis/echo-php-client/issues/events{/number}","events_url":"https://api.github.com/repos/talis/echo-php-client/events","assignees_url":"https://api.github.com/repos/talis/echo-php-client/assignees{/user}","branches_url":"https://api.github.com/repos/talis/echo-php-client/branches{/branch}","tags_url":"https://api.github.com/repos/talis/echo-php-client/tags","blobs_url":"https://api.github.com/repos/talis/echo-php-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/talis/echo-php-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/talis/echo-php-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/talis/echo-php-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/talis/echo-php-client/statuses/{sha}","languages_url":"https://api.github.com/repos/talis/echo-php-client/languages","stargazers_url":"https://api.github.com/repos/talis/echo-php-client/stargazers","contributors_url":"https://api.github.com/repos/talis/echo-php-client/contributors","subscribers_url":"https://api.github.com/repos/talis/echo-php-client/subscribers","subscription_url":"https://api.github.com/repos/talis/echo-php-client/subscription","commits_url":"https://api.github.com/repos/talis/echo-php-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/talis/echo-php-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/talis/echo-php-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/talis/echo-php-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/talis/echo-php-client/contents/{+path}","compare_url":"https://api.github.com/repos/talis/echo-php-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/talis/echo-php-client/merges","archive_url":"https://api.github.com/repos/talis/echo-php-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/talis/echo-php-client/downloads","issues_url":"https://api.github.com/repos/talis/echo-php-client/issues{/number}","pulls_url":"https://api.github.com/repos/talis/echo-php-client/pulls{/number}","milestones_url":"https://api.github.com/repos/talis/echo-php-client/milestones{/number}","notifications_url":"https://api.github.com/repos/talis/echo-php-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/talis/echo-php-client/labels{/name}","releases_url":"https://api.github.com/repos/talis/echo-php-client/releases{/id}","deployments_url":"https://api.github.com/repos/talis/echo-php-client/deployments","created_at":"2014-04-25T11:52:12Z","updated_at":"2016-04-25T09:13:57Z","pushed_at":"2018-07-12T13:32:32Z","git_url":"git://github.com/talis/echo-php-client.git","ssh_url":"git@github.com:talis/echo-php-client.git","clone_url":"https://github.com/talis/echo-php-client.git","svn_url":"https://github.com/talis/echo-php-client","homepage":null,"size":76,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"talis:master","ref":"master","sha":"d0dc87d182967843ffd6842fce3926b433ce817c","user":{"login":"talis","id":181416,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTQxNg==","avatar_url":"https://avatars1.githubusercontent.com/u/181416?v=4","gravatar_id":"","url":"https://api.github.com/users/talis","html_url":"https://github.com/talis","followers_url":"https://api.github.com/users/talis/followers","following_url":"https://api.github.com/users/talis/following{/other_user}","gists_url":"https://api.github.com/users/talis/gists{/gist_id}","starred_url":"https://api.github.com/users/talis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talis/subscriptions","organizations_url":"https://api.github.com/users/talis/orgs","repos_url":"https://api.github.com/users/talis/repos","events_url":"https://api.github.com/users/talis/events{/privacy}","received_events_url":"https://api.github.com/users/talis/received_events","type":"Organization","site_admin":false},"repo":{"id":19144395,"node_id":"MDEwOlJlcG9zaXRvcnkxOTE0NDM5NQ==","name":"echo-php-client","full_name":"talis/echo-php-client","owner":{"login":"talis","id":181416,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTQxNg==","avatar_url":"https://avatars1.githubusercontent.com/u/181416?v=4","gravatar_id":"","url":"https://api.github.com/users/talis","html_url":"https://github.com/talis","followers_url":"https://api.github.com/users/talis/followers","following_url":"https://api.github.com/users/talis/following{/other_user}","gists_url":"https://api.github.com/users/talis/gists{/gist_id}","starred_url":"https://api.github.com/users/talis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talis/subscriptions","organizations_url":"https://api.github.com/users/talis/orgs","repos_url":"https://api.github.com/users/talis/repos","events_url":"https://api.github.com/users/talis/events{/privacy}","received_events_url":"https://api.github.com/users/talis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/talis/echo-php-client","description":"PHP client library for echo-server","fork":false,"url":"https://api.github.com/repos/talis/echo-php-client","forks_url":"https://api.github.com/repos/talis/echo-php-client/forks","keys_url":"https://api.github.com/repos/talis/echo-php-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/talis/echo-php-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/talis/echo-php-client/teams","hooks_url":"https://api.github.com/repos/talis/echo-php-client/hooks","issue_events_url":"https://api.github.com/repos/talis/echo-php-client/issues/events{/number}","events_url":"https://api.github.com/repos/talis/echo-php-client/events","assignees_url":"https://api.github.com/repos/talis/echo-php-client/assignees{/user}","branches_url":"https://api.github.com/repos/talis/echo-php-client/branches{/branch}","tags_url":"https://api.github.com/repos/talis/echo-php-client/tags","blobs_url":"https://api.github.com/repos/talis/echo-php-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/talis/echo-php-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/talis/echo-php-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/talis/echo-php-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/talis/echo-php-client/statuses/{sha}","languages_url":"https://api.github.com/repos/talis/echo-php-client/languages","stargazers_url":"https://api.github.com/repos/talis/echo-php-client/stargazers","contributors_url":"https://api.github.com/repos/talis/echo-php-client/contributors","subscribers_url":"https://api.github.com/repos/talis/echo-php-client/subscribers","subscription_url":"https://api.github.com/repos/talis/echo-php-client/subscription","commits_url":"https://api.github.com/repos/talis/echo-php-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/talis/echo-php-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/talis/echo-php-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/talis/echo-php-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/talis/echo-php-client/contents/{+path}","compare_url":"https://api.github.com/repos/talis/echo-php-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/talis/echo-php-client/merges","archive_url":"https://api.github.com/repos/talis/echo-php-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/talis/echo-php-client/downloads","issues_url":"https://api.github.com/repos/talis/echo-php-client/issues{/number}","pulls_url":"https://api.github.com/repos/talis/echo-php-client/pulls{/number}","milestones_url":"https://api.github.com/repos/talis/echo-php-client/milestones{/number}","notifications_url":"https://api.github.com/repos/talis/echo-php-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/talis/echo-php-client/labels{/name}","releases_url":"https://api.github.com/repos/talis/echo-php-client/releases{/id}","deployments_url":"https://api.github.com/repos/talis/echo-php-client/deployments","created_at":"2014-04-25T11:52:12Z","updated_at":"2016-04-25T09:13:57Z","pushed_at":"2018-07-12T13:32:32Z","git_url":"git://github.com/talis/echo-php-client.git","ssh_url":"git@github.com:talis/echo-php-client.git","clone_url":"https://github.com/talis/echo-php-client.git","svn_url":"https://github.com/talis/echo-php-client","homepage":null,"size":76,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/talis/echo-php-client/pulls/16"},"html":{"href":"https://github.com/talis/echo-php-client/pull/16"},"issue":{"href":"https://api.github.com/repos/talis/echo-php-client/issues/16"},"comments":{"href":"https://api.github.com/repos/talis/echo-php-client/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/talis/echo-php-client/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/talis/echo-php-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/talis/echo-php-client/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/talis/echo-php-client/statuses/df4b120b5aaa23342d5fd3207ee3da518c8458a6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"junglebarry"}}