{"action":"created","comment":{"url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/pulls/comments/204043427","pull_request_review_id":139052736,"id":204043427,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDA0MzQyNw==","diff_hunk":"@@ -101,23 +115,46 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)\n \n     String conversationTitle = request.getParameter(\"conversationTitle\");\n     if (!conversationTitle.matches(\"[\\\\w*]*\")) {\n-      request.setAttribute(\"error\", \"Please enter only letters and numbers.\");\n-      request.getRequestDispatcher(\"/WEB-INF/view/conversations.jsp\").forward(request, response);\n-      return;\n+      if (conversationTitle.contains(\"#\")) {\n+        String hashtagTitle = (String)conversationTitle.substring(conversationTitle.indexOf(\"#\") + 1);\n+        if (hashtagStore.isTitleTaken(hashtagTitle) == false) {\n+          Hashtag hashtag = new Hashtag(UUID.randomUUID(), user.getId(), hashtagTitle, Instant.now());\n+        }\n+      } else {\n+        request.setAttribute(\"error\", \"Please enter only letters and numbers.\");\n+        request.getRequestDispatcher(\"/WEB-INF/view/conversations.jsp\").forward(request, response);\n+        return;\n+      }\n     }\n \n     if (conversationStore.isTitleTaken(conversationTitle)) {\n       // conversation title is already taken, just go into that conversation instead of creating a\n       // new one\n-      response.sendRedirect(\"/chat/\" + conversationTitle);\n+      if (conversationTitle.contains(\"#\")) {\n+        String hashtagTitle = (String)conversationTitle.substring(conversationTitle.indexOf(\"#\") + 1);\n+        response.sendRedirect(\"/chat/\" + hashtagTitle);\n+      } else {\n+        response.sendRedirect(\"/chat/\" + conversationTitle);\n+      }\n       return;\n     }\n \n-    Conversation conversation =\n-        new Conversation(UUID.randomUUID(), user.getId(), conversationTitle, Instant.now());\n+    Conversation conversation;\n+    if (conversationTitle.contains(\"#\")) {\n+      conversation = new Conversation(UUID.randomUUID(), user.getId(), conversationTitle.substring(conversationTitle.indexOf(\"#\") + 1), Instant.now());\n+    } else {\n+      conversation = new Conversation(UUID.randomUUID(), user.getId(), conversationTitle, Instant.now());\n+    }\n \n     conversationStore.addConversation(conversation);\n     System.out.println(conversationTitle);\n-    response.sendRedirect(\"/chat/\" + conversationTitle);\n+    if (conversationTitle.contains(\"#\")) {\n+      String hashtagTitle = (String)conversationTitle.substring(conversationTitle.indexOf(\"#\") + 1);","path":"src/main/java/codeu/controller/ConversationServlet.java","position":89,"original_position":89,"commit_id":"3e7821f80cdac77124f50e73dabbd7a7324f89c5","original_commit_id":"3e7821f80cdac77124f50e73dabbd7a7324f89c5","user":{"login":"chilimalone","id":4896632,"node_id":"MDQ6VXNlcjQ4OTY2MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/4896632?v=4","gravatar_id":"","url":"https://api.github.com/users/chilimalone","html_url":"https://github.com/chilimalone","followers_url":"https://api.github.com/users/chilimalone/followers","following_url":"https://api.github.com/users/chilimalone/following{/other_user}","gists_url":"https://api.github.com/users/chilimalone/gists{/gist_id}","starred_url":"https://api.github.com/users/chilimalone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chilimalone/subscriptions","organizations_url":"https://api.github.com/users/chilimalone/orgs","repos_url":"https://api.github.com/users/chilimalone/repos","events_url":"https://api.github.com/users/chilimalone/events{/privacy}","received_events_url":"https://api.github.com/users/chilimalone/received_events","type":"User","site_admin":false},"body":"ditto, line unnecessary","created_at":"2018-07-20T13:27:55Z","updated_at":"2018-07-20T13:33:50Z","html_url":"https://github.com/jayyduran0108/CodeU-2018/pull/13#discussion_r204043427","pull_request_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/pulls/13","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/jayyduran0108/CodeU-2018/pulls/comments/204043427"},"html":{"href":"https://github.com/jayyduran0108/CodeU-2018/pull/13#discussion_r204043427"},"pull_request":{"href":"https://api.github.com/repos/jayyduran0108/CodeU-2018/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/pulls/13","id":202748432,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNzQ4NDMy","html_url":"https://github.com/jayyduran0108/CodeU-2018/pull/13","diff_url":"https://github.com/jayyduran0108/CodeU-2018/pull/13.diff","patch_url":"https://github.com/jayyduran0108/CodeU-2018/pull/13.patch","issue_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/issues/13","number":13,"state":"open","locked":false,"title":"identifying hashtags and creating instances ","user":{"login":"annepham25","id":30185981,"node_id":"MDQ6VXNlcjMwMTg1OTgx","avatar_url":"https://avatars0.githubusercontent.com/u/30185981?v=4","gravatar_id":"","url":"https://api.github.com/users/annepham25","html_url":"https://github.com/annepham25","followers_url":"https://api.github.com/users/annepham25/followers","following_url":"https://api.github.com/users/annepham25/following{/other_user}","gists_url":"https://api.github.com/users/annepham25/gists{/gist_id}","starred_url":"https://api.github.com/users/annepham25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annepham25/subscriptions","organizations_url":"https://api.github.com/users/annepham25/orgs","repos_url":"https://api.github.com/users/annepham25/repos","events_url":"https://api.github.com/users/annepham25/events{/privacy}","received_events_url":"https://api.github.com/users/annepham25/received_events","type":"User","site_admin":false},"body":"- i cleaned up a bit of my own admin page code\r\n- ConversationServlet: is what we all talked about during our video chat working session\r\n- ChatServlet: i essentially added the same structure/function of identifying and creating instances of hashtags\r\n\r\nI was hoping that my code could merge with the master branch so that @Georgeg10499 can take my files and new code and test if the hashtags update with all of the hashtags created in the datastore \r\n","created_at":"2018-07-20T05:14:20Z","updated_at":"2018-07-20T13:33:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e8eb4b1a42e19933dc0c06752d6c4771fa0f2bb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/pulls/13/commits","review_comments_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/pulls/13/comments","review_comment_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/issues/13/comments","statuses_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/statuses/3e7821f80cdac77124f50e73dabbd7a7324f89c5","head":{"label":"jayyduran0108:AnneAdminPage","ref":"AnneAdminPage","sha":"3e7821f80cdac77124f50e73dabbd7a7324f89c5","user":{"login":"jayyduran0108","id":31785076,"node_id":"MDQ6VXNlcjMxNzg1MDc2","avatar_url":"https://avatars1.githubusercontent.com/u/31785076?v=4","gravatar_id":"","url":"https://api.github.com/users/jayyduran0108","html_url":"https://github.com/jayyduran0108","followers_url":"https://api.github.com/users/jayyduran0108/followers","following_url":"https://api.github.com/users/jayyduran0108/following{/other_user}","gists_url":"https://api.github.com/users/jayyduran0108/gists{/gist_id}","starred_url":"https://api.github.com/users/jayyduran0108/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayyduran0108/subscriptions","organizations_url":"https://api.github.com/users/jayyduran0108/orgs","repos_url":"https://api.github.com/users/jayyduran0108/repos","events_url":"https://api.github.com/users/jayyduran0108/events{/privacy}","received_events_url":"https://api.github.com/users/jayyduran0108/received_events","type":"User","site_admin":false},"repo":{"id":133190007,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMxOTAwMDc=","name":"CodeU-2018","full_name":"jayyduran0108/CodeU-2018","owner":{"login":"jayyduran0108","id":31785076,"node_id":"MDQ6VXNlcjMxNzg1MDc2","avatar_url":"https://avatars1.githubusercontent.com/u/31785076?v=4","gravatar_id":"","url":"https://api.github.com/users/jayyduran0108","html_url":"https://github.com/jayyduran0108","followers_url":"https://api.github.com/users/jayyduran0108/followers","following_url":"https://api.github.com/users/jayyduran0108/following{/other_user}","gists_url":"https://api.github.com/users/jayyduran0108/gists{/gist_id}","starred_url":"https://api.github.com/users/jayyduran0108/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayyduran0108/subscriptions","organizations_url":"https://api.github.com/users/jayyduran0108/orgs","repos_url":"https://api.github.com/users/jayyduran0108/repos","events_url":"https://api.github.com/users/jayyduran0108/events{/privacy}","received_events_url":"https://api.github.com/users/jayyduran0108/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jayyduran0108/CodeU-2018","description":null,"fork":false,"url":"https://api.github.com/repos/jayyduran0108/CodeU-2018","forks_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/forks","keys_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/teams","hooks_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/hooks","issue_events_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/issues/events{/number}","events_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/events","assignees_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/assignees{/user}","branches_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/branches{/branch}","tags_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/tags","blobs_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/git/refs{/sha}","trees_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/statuses/{sha}","languages_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/languages","stargazers_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/stargazers","contributors_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/contributors","subscribers_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/subscribers","subscription_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/subscription","commits_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/commits{/sha}","git_commits_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/git/commits{/sha}","comments_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/comments{/number}","issue_comment_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/issues/comments{/number}","contents_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/contents/{+path}","compare_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/merges","archive_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/downloads","issues_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/issues{/number}","pulls_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/pulls{/number}","milestones_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/milestones{/number}","notifications_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/labels{/name}","releases_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/releases{/id}","deployments_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/deployments","created_at":"2018-05-12T23:13:28Z","updated_at":"2018-07-19T02:23:40Z","pushed_at":"2018-07-20T07:21:12Z","git_url":"git://github.com/jayyduran0108/CodeU-2018.git","ssh_url":"git@github.com:jayyduran0108/CodeU-2018.git","clone_url":"https://github.com/jayyduran0108/CodeU-2018.git","svn_url":"https://github.com/jayyduran0108/CodeU-2018","homepage":null,"size":239,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"jayyduran0108:master","ref":"master","sha":"ae65c7051a5caf0f9b4c1f5a8f807a68eb4e6203","user":{"login":"jayyduran0108","id":31785076,"node_id":"MDQ6VXNlcjMxNzg1MDc2","avatar_url":"https://avatars1.githubusercontent.com/u/31785076?v=4","gravatar_id":"","url":"https://api.github.com/users/jayyduran0108","html_url":"https://github.com/jayyduran0108","followers_url":"https://api.github.com/users/jayyduran0108/followers","following_url":"https://api.github.com/users/jayyduran0108/following{/other_user}","gists_url":"https://api.github.com/users/jayyduran0108/gists{/gist_id}","starred_url":"https://api.github.com/users/jayyduran0108/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayyduran0108/subscriptions","organizations_url":"https://api.github.com/users/jayyduran0108/orgs","repos_url":"https://api.github.com/users/jayyduran0108/repos","events_url":"https://api.github.com/users/jayyduran0108/events{/privacy}","received_events_url":"https://api.github.com/users/jayyduran0108/received_events","type":"User","site_admin":false},"repo":{"id":133190007,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMxOTAwMDc=","name":"CodeU-2018","full_name":"jayyduran0108/CodeU-2018","owner":{"login":"jayyduran0108","id":31785076,"node_id":"MDQ6VXNlcjMxNzg1MDc2","avatar_url":"https://avatars1.githubusercontent.com/u/31785076?v=4","gravatar_id":"","url":"https://api.github.com/users/jayyduran0108","html_url":"https://github.com/jayyduran0108","followers_url":"https://api.github.com/users/jayyduran0108/followers","following_url":"https://api.github.com/users/jayyduran0108/following{/other_user}","gists_url":"https://api.github.com/users/jayyduran0108/gists{/gist_id}","starred_url":"https://api.github.com/users/jayyduran0108/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayyduran0108/subscriptions","organizations_url":"https://api.github.com/users/jayyduran0108/orgs","repos_url":"https://api.github.com/users/jayyduran0108/repos","events_url":"https://api.github.com/users/jayyduran0108/events{/privacy}","received_events_url":"https://api.github.com/users/jayyduran0108/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jayyduran0108/CodeU-2018","description":null,"fork":false,"url":"https://api.github.com/repos/jayyduran0108/CodeU-2018","forks_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/forks","keys_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/teams","hooks_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/hooks","issue_events_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/issues/events{/number}","events_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/events","assignees_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/assignees{/user}","branches_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/branches{/branch}","tags_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/tags","blobs_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/git/refs{/sha}","trees_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/statuses/{sha}","languages_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/languages","stargazers_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/stargazers","contributors_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/contributors","subscribers_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/subscribers","subscription_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/subscription","commits_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/commits{/sha}","git_commits_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/git/commits{/sha}","comments_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/comments{/number}","issue_comment_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/issues/comments{/number}","contents_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/contents/{+path}","compare_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/merges","archive_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/downloads","issues_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/issues{/number}","pulls_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/pulls{/number}","milestones_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/milestones{/number}","notifications_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/labels{/name}","releases_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/releases{/id}","deployments_url":"https://api.github.com/repos/jayyduran0108/CodeU-2018/deployments","created_at":"2018-05-12T23:13:28Z","updated_at":"2018-07-19T02:23:40Z","pushed_at":"2018-07-20T07:21:12Z","git_url":"git://github.com/jayyduran0108/CodeU-2018.git","ssh_url":"git@github.com:jayyduran0108/CodeU-2018.git","clone_url":"https://github.com/jayyduran0108/CodeU-2018.git","svn_url":"https://github.com/jayyduran0108/CodeU-2018","homepage":null,"size":239,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jayyduran0108/CodeU-2018/pulls/13"},"html":{"href":"https://github.com/jayyduran0108/CodeU-2018/pull/13"},"issue":{"href":"https://api.github.com/repos/jayyduran0108/CodeU-2018/issues/13"},"comments":{"href":"https://api.github.com/repos/jayyduran0108/CodeU-2018/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/jayyduran0108/CodeU-2018/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/jayyduran0108/CodeU-2018/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jayyduran0108/CodeU-2018/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/jayyduran0108/CodeU-2018/statuses/3e7821f80cdac77124f50e73dabbd7a7324f89c5"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"chilimalone"}}