{"action":"created","issue":{"url":"https://api.github.com/repos/simplecrawler/simplecrawler/issues/361","repository_url":"https://api.github.com/repos/simplecrawler/simplecrawler","labels_url":"https://api.github.com/repos/simplecrawler/simplecrawler/issues/361/labels{/name}","comments_url":"https://api.github.com/repos/simplecrawler/simplecrawler/issues/361/comments","events_url":"https://api.github.com/repos/simplecrawler/simplecrawler/issues/361/events","html_url":"https://github.com/simplecrawler/simplecrawler/issues/361","id":215066150,"number":361,"title":"Look into proxy logic","user":{"login":"fredrikekelund","id":1101677,"avatar_url":"https://avatars1.githubusercontent.com/u/1101677?v=4","gravatar_id":"","url":"https://api.github.com/users/fredrikekelund","html_url":"https://github.com/fredrikekelund","followers_url":"https://api.github.com/users/fredrikekelund/followers","following_url":"https://api.github.com/users/fredrikekelund/following{/other_user}","gists_url":"https://api.github.com/users/fredrikekelund/gists{/gist_id}","starred_url":"https://api.github.com/users/fredrikekelund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredrikekelund/subscriptions","organizations_url":"https://api.github.com/users/fredrikekelund/orgs","repos_url":"https://api.github.com/users/fredrikekelund/repos","events_url":"https://api.github.com/users/fredrikekelund/events{/privacy}","received_events_url":"https://api.github.com/users/fredrikekelund/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-03-17T17:08:29Z","updated_at":"2018-03-06T20:52:36Z","closed_at":null,"author_association":"COLLABORATOR","body":"The current proxy settings don't really prescribe what type of proxy setup is supported, and we determine which http client to use based on the protocol of the queueItem, regardless of how we access the proxy.\r\n\r\nI'd like to add some details to the README about what kind of proxy usage we support, clean up the code and potentially add some integration tests.\r\n\r\nRelated issues: #357, #336 "},"comment":{"url":"https://api.github.com/repos/simplecrawler/simplecrawler/issues/comments/370924096","html_url":"https://github.com/simplecrawler/simplecrawler/issues/361#issuecomment-370924096","issue_url":"https://api.github.com/repos/simplecrawler/simplecrawler/issues/361","id":370924096,"user":{"login":"konstantinblaesi","id":5871169,"avatar_url":"https://avatars2.githubusercontent.com/u/5871169?v=4","gravatar_id":"","url":"https://api.github.com/users/konstantinblaesi","html_url":"https://github.com/konstantinblaesi","followers_url":"https://api.github.com/users/konstantinblaesi/followers","following_url":"https://api.github.com/users/konstantinblaesi/following{/other_user}","gists_url":"https://api.github.com/users/konstantinblaesi/gists{/gist_id}","starred_url":"https://api.github.com/users/konstantinblaesi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/konstantinblaesi/subscriptions","organizations_url":"https://api.github.com/users/konstantinblaesi/orgs","repos_url":"https://api.github.com/users/konstantinblaesi/repos","events_url":"https://api.github.com/users/konstantinblaesi/events{/privacy}","received_events_url":"https://api.github.com/users/konstantinblaesi/received_events","type":"User","site_admin":false},"created_at":"2018-03-06T20:52:36Z","updated_at":"2018-03-06T20:52:36Z","author_association":"COLLABORATOR","body":"@chrischrischrischrischris1 the snippet\r\n```\r\nhttp.globalAgent = new httpAgent(proxy);\r\nhttps.globalAgent = new httpsAgent(proxy);\r\n```\r\nfrom above overwrites the default agent of any http or https connection.  No need to change anything internally."}}
{"actor":{"display_login":"konstantinblaesi"}}