{"action":"opened","number":2478,"pull_request":{"url":"https://api.github.com/repos/LiskHQ/lisk/pulls/2478","id":223252823,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMjUyODIz","html_url":"https://github.com/LiskHQ/lisk/pull/2478","diff_url":"https://github.com/LiskHQ/lisk/pull/2478.diff","patch_url":"https://github.com/LiskHQ/lisk/pull/2478.patch","issue_url":"https://api.github.com/repos/LiskHQ/lisk/issues/2478","number":2478,"state":"open","locked":false,"title":"Improve example for unconfirmedBalance - Closes 2477","user":{"login":"Tschakki","id":1993505,"node_id":"MDQ6VXNlcjE5OTM1MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/1993505?v=4","gravatar_id":"","url":"https://api.github.com/users/Tschakki","html_url":"https://github.com/Tschakki","followers_url":"https://api.github.com/users/Tschakki/followers","following_url":"https://api.github.com/users/Tschakki/following{/other_user}","gists_url":"https://api.github.com/users/Tschakki/gists{/gist_id}","starred_url":"https://api.github.com/users/Tschakki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tschakki/subscriptions","organizations_url":"https://api.github.com/users/Tschakki/orgs","repos_url":"https://api.github.com/users/Tschakki/repos","events_url":"https://api.github.com/users/Tschakki/events{/privacy}","received_events_url":"https://api.github.com/users/Tschakki/received_events","type":"User","site_admin":false},"body":"### What was the problem?\r\nThe example value for unconfirmedBalance was confusing.\r\n\r\n### How did I fix it?\r\nChanged the confusing example value `0`to the same value as the example for `balance`, which makes more sense as unconfirmed balance = confirmed balance + balance of pending transactions.\r\n\r\n### Review checklist\r\n\r\n* The PR resolves #2477 \r\n* All new code is covered with unit tests\r\n* All new code was formatted with Prettier\r\n* Linting passes\r\n* Tests pass\r\n* Commit messages follow the [commit guidelines](CONTRIBUTING.md#git-commit-messages)\r\n* Documentation has been added/updated\r\n","created_at":"2018-10-16T13:35:39Z","updated_at":"2018-10-16T13:35:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"Tschakki","id":1993505,"node_id":"MDQ6VXNlcjE5OTM1MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/1993505?v=4","gravatar_id":"","url":"https://api.github.com/users/Tschakki","html_url":"https://github.com/Tschakki","followers_url":"https://api.github.com/users/Tschakki/followers","following_url":"https://api.github.com/users/Tschakki/following{/other_user}","gists_url":"https://api.github.com/users/Tschakki/gists{/gist_id}","starred_url":"https://api.github.com/users/Tschakki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tschakki/subscriptions","organizations_url":"https://api.github.com/users/Tschakki/orgs","repos_url":"https://api.github.com/users/Tschakki/repos","events_url":"https://api.github.com/users/Tschakki/events{/privacy}","received_events_url":"https://api.github.com/users/Tschakki/received_events","type":"User","site_admin":false},"assignees":[{"login":"Tschakki","id":1993505,"node_id":"MDQ6VXNlcjE5OTM1MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/1993505?v=4","gravatar_id":"","url":"https://api.github.com/users/Tschakki","html_url":"https://github.com/Tschakki","followers_url":"https://api.github.com/users/Tschakki/followers","following_url":"https://api.github.com/users/Tschakki/following{/other_user}","gists_url":"https://api.github.com/users/Tschakki/gists{/gist_id}","starred_url":"https://api.github.com/users/Tschakki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tschakki/subscriptions","organizations_url":"https://api.github.com/users/Tschakki/orgs","repos_url":"https://api.github.com/users/Tschakki/repos","events_url":"https://api.github.com/users/Tschakki/events{/privacy}","received_events_url":"https://api.github.com/users/Tschakki/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":801775562,"node_id":"MDU6TGFiZWw4MDE3NzU1NjI=","url":"https://api.github.com/repos/LiskHQ/lisk/labels/api","name":"api","color":"f2a163","default":false},{"id":531384300,"node_id":"MDU6TGFiZWw1MzEzODQzMDA=","url":"https://api.github.com/repos/LiskHQ/lisk/labels/docs","name":"docs","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/LiskHQ/lisk/pulls/2478/commits","review_comments_url":"https://api.github.com/repos/LiskHQ/lisk/pulls/2478/comments","review_comment_url":"https://api.github.com/repos/LiskHQ/lisk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LiskHQ/lisk/issues/2478/comments","statuses_url":"https://api.github.com/repos/LiskHQ/lisk/statuses/4989007fa4cec6aeacc39b1ebbc0db6d4e938d33","head":{"label":"LiskHQ:2477-fix-example-unconfirmedbalance","ref":"2477-fix-example-unconfirmedbalance","sha":"4989007fa4cec6aeacc39b1ebbc0db6d4e938d33","user":{"login":"LiskHQ","id":16600915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjAwOTE1","avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":50873641,"node_id":"MDEwOlJlcG9zaXRvcnk1MDg3MzY0MQ==","name":"lisk","full_name":"LiskHQ/lisk","private":false,"owner":{"login":"LiskHQ","id":16600915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjAwOTE1","avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LiskHQ/lisk","description":"📟 Lisk blockchain application platform","fork":false,"url":"https://api.github.com/repos/LiskHQ/lisk","forks_url":"https://api.github.com/repos/LiskHQ/lisk/forks","keys_url":"https://api.github.com/repos/LiskHQ/lisk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LiskHQ/lisk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LiskHQ/lisk/teams","hooks_url":"https://api.github.com/repos/LiskHQ/lisk/hooks","issue_events_url":"https://api.github.com/repos/LiskHQ/lisk/issues/events{/number}","events_url":"https://api.github.com/repos/LiskHQ/lisk/events","assignees_url":"https://api.github.com/repos/LiskHQ/lisk/assignees{/user}","branches_url":"https://api.github.com/repos/LiskHQ/lisk/branches{/branch}","tags_url":"https://api.github.com/repos/LiskHQ/lisk/tags","blobs_url":"https://api.github.com/repos/LiskHQ/lisk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LiskHQ/lisk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LiskHQ/lisk/git/refs{/sha}","trees_url":"https://api.github.com/repos/LiskHQ/lisk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LiskHQ/lisk/statuses/{sha}","languages_url":"https://api.github.com/repos/LiskHQ/lisk/languages","stargazers_url":"https://api.github.com/repos/LiskHQ/lisk/stargazers","contributors_url":"https://api.github.com/repos/LiskHQ/lisk/contributors","subscribers_url":"https://api.github.com/repos/LiskHQ/lisk/subscribers","subscription_url":"https://api.github.com/repos/LiskHQ/lisk/subscription","commits_url":"https://api.github.com/repos/LiskHQ/lisk/commits{/sha}","git_commits_url":"https://api.github.com/repos/LiskHQ/lisk/git/commits{/sha}","comments_url":"https://api.github.com/repos/LiskHQ/lisk/comments{/number}","issue_comment_url":"https://api.github.com/repos/LiskHQ/lisk/issues/comments{/number}","contents_url":"https://api.github.com/repos/LiskHQ/lisk/contents/{+path}","compare_url":"https://api.github.com/repos/LiskHQ/lisk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LiskHQ/lisk/merges","archive_url":"https://api.github.com/repos/LiskHQ/lisk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LiskHQ/lisk/downloads","issues_url":"https://api.github.com/repos/LiskHQ/lisk/issues{/number}","pulls_url":"https://api.github.com/repos/LiskHQ/lisk/pulls{/number}","milestones_url":"https://api.github.com/repos/LiskHQ/lisk/milestones{/number}","notifications_url":"https://api.github.com/repos/LiskHQ/lisk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LiskHQ/lisk/labels{/name}","releases_url":"https://api.github.com/repos/LiskHQ/lisk/releases{/id}","deployments_url":"https://api.github.com/repos/LiskHQ/lisk/deployments","created_at":"2016-02-01T21:45:35Z","updated_at":"2018-10-16T10:08:37Z","pushed_at":"2018-10-16T13:31:44Z","git_url":"git://github.com/LiskHQ/lisk.git","ssh_url":"git@github.com:LiskHQ/lisk.git","clone_url":"https://github.com/LiskHQ/lisk.git","svn_url":"https://github.com/LiskHQ/lisk","homepage":"https://lisk.io/","size":21219,"stargazers_count":2539,"watchers_count":2539,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":392,"mirror_url":null,"archived":false,"open_issues_count":90,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":392,"open_issues":90,"watchers":2539,"default_branch":"development"}},"base":{"label":"LiskHQ:development","ref":"development","sha":"5acfc7bdd902965124263d448be124edf481b6ae","user":{"login":"LiskHQ","id":16600915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjAwOTE1","avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":50873641,"node_id":"MDEwOlJlcG9zaXRvcnk1MDg3MzY0MQ==","name":"lisk","full_name":"LiskHQ/lisk","private":false,"owner":{"login":"LiskHQ","id":16600915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjAwOTE1","avatar_url":"https://avatars1.githubusercontent.com/u/16600915?v=4","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LiskHQ/lisk","description":"📟 Lisk blockchain application platform","fork":false,"url":"https://api.github.com/repos/LiskHQ/lisk","forks_url":"https://api.github.com/repos/LiskHQ/lisk/forks","keys_url":"https://api.github.com/repos/LiskHQ/lisk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LiskHQ/lisk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LiskHQ/lisk/teams","hooks_url":"https://api.github.com/repos/LiskHQ/lisk/hooks","issue_events_url":"https://api.github.com/repos/LiskHQ/lisk/issues/events{/number}","events_url":"https://api.github.com/repos/LiskHQ/lisk/events","assignees_url":"https://api.github.com/repos/LiskHQ/lisk/assignees{/user}","branches_url":"https://api.github.com/repos/LiskHQ/lisk/branches{/branch}","tags_url":"https://api.github.com/repos/LiskHQ/lisk/tags","blobs_url":"https://api.github.com/repos/LiskHQ/lisk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LiskHQ/lisk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LiskHQ/lisk/git/refs{/sha}","trees_url":"https://api.github.com/repos/LiskHQ/lisk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LiskHQ/lisk/statuses/{sha}","languages_url":"https://api.github.com/repos/LiskHQ/lisk/languages","stargazers_url":"https://api.github.com/repos/LiskHQ/lisk/stargazers","contributors_url":"https://api.github.com/repos/LiskHQ/lisk/contributors","subscribers_url":"https://api.github.com/repos/LiskHQ/lisk/subscribers","subscription_url":"https://api.github.com/repos/LiskHQ/lisk/subscription","commits_url":"https://api.github.com/repos/LiskHQ/lisk/commits{/sha}","git_commits_url":"https://api.github.com/repos/LiskHQ/lisk/git/commits{/sha}","comments_url":"https://api.github.com/repos/LiskHQ/lisk/comments{/number}","issue_comment_url":"https://api.github.com/repos/LiskHQ/lisk/issues/comments{/number}","contents_url":"https://api.github.com/repos/LiskHQ/lisk/contents/{+path}","compare_url":"https://api.github.com/repos/LiskHQ/lisk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LiskHQ/lisk/merges","archive_url":"https://api.github.com/repos/LiskHQ/lisk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LiskHQ/lisk/downloads","issues_url":"https://api.github.com/repos/LiskHQ/lisk/issues{/number}","pulls_url":"https://api.github.com/repos/LiskHQ/lisk/pulls{/number}","milestones_url":"https://api.github.com/repos/LiskHQ/lisk/milestones{/number}","notifications_url":"https://api.github.com/repos/LiskHQ/lisk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LiskHQ/lisk/labels{/name}","releases_url":"https://api.github.com/repos/LiskHQ/lisk/releases{/id}","deployments_url":"https://api.github.com/repos/LiskHQ/lisk/deployments","created_at":"2016-02-01T21:45:35Z","updated_at":"2018-10-16T10:08:37Z","pushed_at":"2018-10-16T13:31:44Z","git_url":"git://github.com/LiskHQ/lisk.git","ssh_url":"git@github.com:LiskHQ/lisk.git","clone_url":"https://github.com/LiskHQ/lisk.git","svn_url":"https://github.com/LiskHQ/lisk","homepage":"https://lisk.io/","size":21219,"stargazers_count":2539,"watchers_count":2539,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":392,"mirror_url":null,"archived":false,"open_issues_count":90,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":392,"open_issues":90,"watchers":2539,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/LiskHQ/lisk/pulls/2478"},"html":{"href":"https://github.com/LiskHQ/lisk/pull/2478"},"issue":{"href":"https://api.github.com/repos/LiskHQ/lisk/issues/2478"},"comments":{"href":"https://api.github.com/repos/LiskHQ/lisk/issues/2478/comments"},"review_comments":{"href":"https://api.github.com/repos/LiskHQ/lisk/pulls/2478/comments"},"review_comment":{"href":"https://api.github.com/repos/LiskHQ/lisk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LiskHQ/lisk/pulls/2478/commits"},"statuses":{"href":"https://api.github.com/repos/LiskHQ/lisk/statuses/4989007fa4cec6aeacc39b1ebbc0db6d4e938d33"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"Tschakki"}}