{"action":"created","issue":{"url":"https://api.github.com/repos/EC-CUBE/ec-cube/issues/3862","repository_url":"https://api.github.com/repos/EC-CUBE/ec-cube","labels_url":"https://api.github.com/repos/EC-CUBE/ec-cube/issues/3862/labels{/name}","comments_url":"https://api.github.com/repos/EC-CUBE/ec-cube/issues/3862/comments","events_url":"https://api.github.com/repos/EC-CUBE/ec-cube/issues/3862/events","html_url":"https://github.com/EC-CUBE/ec-cube/pull/3862","id":361619163,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NTQyNjA3","number":3862,"title":"商品一覧画面のパフォーマンス改善","user":{"login":"nanasess","id":815715,"node_id":"MDQ6VXNlcjgxNTcxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/815715?v=4","gravatar_id":"","url":"https://api.github.com/users/nanasess","html_url":"https://github.com/nanasess","followers_url":"https://api.github.com/users/nanasess/followers","following_url":"https://api.github.com/users/nanasess/following{/other_user}","gists_url":"https://api.github.com/users/nanasess/gists{/gist_id}","starred_url":"https://api.github.com/users/nanasess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nanasess/subscriptions","organizations_url":"https://api.github.com/users/nanasess/orgs","repos_url":"https://api.github.com/users/nanasess/repos","events_url":"https://api.github.com/users/nanasess/events{/privacy}","received_events_url":"https://api.github.com/users/nanasess/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/EC-CUBE/ec-cube/milestones/17","html_url":"https://github.com/EC-CUBE/ec-cube/milestone/17","labels_url":"https://api.github.com/repos/EC-CUBE/ec-cube/milestones/17/labels","id":1691908,"node_id":"MDk6TWlsZXN0b25lMTY5MTkwOA==","number":17,"title":"4.0","description":"# 次期大型バージョンアップで対応する可能性のある内容を紐付ける\r\n詳細： #2076","creator":{"login":"Yangsin","id":8196511,"node_id":"MDQ6VXNlcjgxOTY1MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/8196511?v=4","gravatar_id":"","url":"https://api.github.com/users/Yangsin","html_url":"https://github.com/Yangsin","followers_url":"https://api.github.com/users/Yangsin/followers","following_url":"https://api.github.com/users/Yangsin/following{/other_user}","gists_url":"https://api.github.com/users/Yangsin/gists{/gist_id}","starred_url":"https://api.github.com/users/Yangsin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yangsin/subscriptions","organizations_url":"https://api.github.com/users/Yangsin/orgs","repos_url":"https://api.github.com/users/Yangsin/repos","events_url":"https://api.github.com/users/Yangsin/events{/privacy}","received_events_url":"https://api.github.com/users/Yangsin/received_events","type":"User","site_admin":false},"open_issues":112,"closed_issues":1273,"state":"open","created_at":"2016-04-08T08:57:16Z","updated_at":"2018-09-20T02:38:47Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2018-09-19T07:41:47Z","updated_at":"2018-09-20T03:14:32Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/EC-CUBE/ec-cube/pulls/3862","html_url":"https://github.com/EC-CUBE/ec-cube/pull/3862","diff_url":"https://github.com/EC-CUBE/ec-cube/pull/3862.diff","patch_url":"https://github.com/EC-CUBE/ec-cube/pull/3862.patch"},"body":"## 概要(Overview・Refs Issue)\r\n規格の情報を一度に取得するよう修正\r\n\r\n## 方針(Policy)\r\n- 規格の情報をまとめて取得する\r\n- Lazy Loading を防ぐために、 TaxRule 及び ProductStock も JOIN する\r\n\r\n## テスト（Test)\r\nSQLのコール数が削減されるのを確認\r\n商品一覧ページ, 60件表示時\r\n- 改修前: 320回\r\n- 改修後: 17回\r\n\r\n## 相談（Discussion）\r\n本来であれば、 TaxRule 及び ProductStock を JOIN しないようにしたい\r\n\r\n## マイナーバージョン互換性保持のための制限事項チェックリスト\r\n<!-- マイナーバージョンでは、機能・プラグイン・デザインテンプレート互換性を損なう変更は原則取り込みません。 -->\r\n<!-- 以下の変更を行っていないことを確認してください。変更を行っていなければチェックしてください。 -->\r\n\r\n- [x] 既存機能の仕様変更\r\n- [x] フックポイントの呼び出しタイミングの変更\r\n- [x] フックポイントのパラメータの削除・データ型の変更\r\n- [x] twigファイルに渡しているパラメータの削除・データ型の変更\r\n- [x] Serviceクラスの公開関数の、引数の削除・データ型の変更\r\n- [x] 入出力ファイル(CSVなど)のフォーマット変更\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/EC-CUBE/ec-cube/issues/comments/423026513","html_url":"https://github.com/EC-CUBE/ec-cube/pull/3862#issuecomment-423026513","issue_url":"https://api.github.com/repos/EC-CUBE/ec-cube/issues/3862","id":423026513,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzAyNjUxMw==","user":{"login":"chihiro-adachi","id":8196725,"node_id":"MDQ6VXNlcjgxOTY3MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/8196725?v=4","gravatar_id":"","url":"https://api.github.com/users/chihiro-adachi","html_url":"https://github.com/chihiro-adachi","followers_url":"https://api.github.com/users/chihiro-adachi/followers","following_url":"https://api.github.com/users/chihiro-adachi/following{/other_user}","gists_url":"https://api.github.com/users/chihiro-adachi/gists{/gist_id}","starred_url":"https://api.github.com/users/chihiro-adachi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chihiro-adachi/subscriptions","organizations_url":"https://api.github.com/users/chihiro-adachi/orgs","repos_url":"https://api.github.com/users/chihiro-adachi/repos","events_url":"https://api.github.com/users/chihiro-adachi/events{/privacy}","received_events_url":"https://api.github.com/users/chihiro-adachi/received_events","type":"User","site_admin":false},"created_at":"2018-09-20T03:14:32Z","updated_at":"2018-09-20T03:14:32Z","author_association":"CONTRIBUTOR","body":"@nanasess \r\n修正確認しました。\r\nscrutinizerの指摘だけ追加で修正しています。"}}
{"actor":{"display_login":"chihiro-adachi"}}