{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/243210147","pull_request_review_id":186917003,"id":243210147,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzIxMDE0Nw==","diff_hunk":"@@ -0,0 +1,253 @@\n+import json\n+import re\n+import threading\n+import functools\n+import uuid\n+from subprocess import check_output\n+\n+from mgr_module import MgrModule\n+\n+import orchestrator\n+\n+\n+all_completions = []\n+\n+\n+class TestReadCompletion(orchestrator.ReadCompletion):\n+\n+    def __init__(self, cb):\n+        super(TestReadCompletion, self).__init__()\n+        self.cb = cb\n+        self._result = None\n+        self._complete = False\n+\n+        self.message = \"<read op>\"\n+\n+        global all_completions\n+        all_completions.append(self)\n+\n+    @property\n+    def result(self):\n+        return self._result\n+\n+    @property\n+    def is_complete(self):\n+        return self._complete\n+\n+    def execute(self):\n+        self._result = self.cb()\n+        self._complete = True\n+\n+\n+class TestWriteCompletion(orchestrator.WriteCompletion):\n+    def __init__(self, execute_cb, complete_cb, message):\n+        super(TestWriteCompletion, self).__init__()\n+        self.execute_cb = execute_cb\n+        self.complete_cb = complete_cb\n+\n+        # Executed means I executed my k8s API call, it may or may","path":"src/pybind/mgr/test_orchestrator/module.py","position":null,"original_position":48,"commit_id":"fe1f713c38c03bf859edbf47822ff6f24880cf24","original_commit_id":"27598c6950ab9af9713434689528badc796b1c10","user":{"login":"sebastian-philipp","id":2574405,"node_id":"MDQ6VXNlcjI1NzQ0MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2574405?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastian-philipp","html_url":"https://github.com/sebastian-philipp","followers_url":"https://api.github.com/users/sebastian-philipp/followers","following_url":"https://api.github.com/users/sebastian-philipp/following{/other_user}","gists_url":"https://api.github.com/users/sebastian-philipp/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastian-philipp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastian-philipp/subscriptions","organizations_url":"https://api.github.com/users/sebastian-philipp/orgs","repos_url":"https://api.github.com/users/sebastian-philipp/repos","events_url":"https://api.github.com/users/sebastian-philipp/events{/privacy}","received_events_url":"https://api.github.com/users/sebastian-philipp/received_events","type":"User","site_admin":false},"body":"done.","created_at":"2018-12-20T09:49:06Z","updated_at":"2018-12-20T09:49:06Z","html_url":"https://github.com/ceph/ceph/pull/25236#discussion_r243210147","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/25236","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/243210147"},"html":{"href":"https://github.com/ceph/ceph/pull/25236#discussion_r243210147"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/25236"}},"in_reply_to_id":243152328},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/25236","id":233208226,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMjA4MjI2","html_url":"https://github.com/ceph/ceph/pull/25236","diff_url":"https://github.com/ceph/ceph/pull/25236.diff","patch_url":"https://github.com/ceph/ceph/pull/25236.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/25236","number":25236,"state":"open","locked":false,"title":"mgr/orchestrator: Add test orchestrator","user":{"login":"sebastian-philipp","id":2574405,"node_id":"MDQ6VXNlcjI1NzQ0MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2574405?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastian-philipp","html_url":"https://github.com/sebastian-philipp","followers_url":"https://api.github.com/users/sebastian-philipp/followers","following_url":"https://api.github.com/users/sebastian-philipp/following{/other_user}","gists_url":"https://api.github.com/users/sebastian-philipp/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastian-philipp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastian-philipp/subscriptions","organizations_url":"https://api.github.com/users/sebastian-philipp/orgs","repos_url":"https://api.github.com/users/sebastian-philipp/repos","events_url":"https://api.github.com/users/sebastian-philipp/events{/privacy}","received_events_url":"https://api.github.com/users/sebastian-philipp/received_events","type":"User","site_admin":false},"body":"1. To be able to run the cli without an external orchestrator.\r\n2. Run the CLI in Teuthology.\r\n\r\nSigned-off-by: Sebastian Wagner <sebastian.wagner@suse.com>\r\n\r\n### TODO\r\n- [x] Make the call to ceph-volume actually work. See #25237\r\n- [x] Includes tests for new functionality or reproducer for bug\r\n\r\n","created_at":"2018-11-23T13:58:12Z","updated_at":"2018-12-20T09:49:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f6b05c1fbbaf8231dbf2d67d27638862503b7ed","assignee":null,"assignees":[],"requested_reviewers":[{"login":"alfredodeza","id":317847,"node_id":"MDQ6VXNlcjMxNzg0Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/317847?v=4","gravatar_id":"","url":"https://api.github.com/users/alfredodeza","html_url":"https://github.com/alfredodeza","followers_url":"https://api.github.com/users/alfredodeza/followers","following_url":"https://api.github.com/users/alfredodeza/following{/other_user}","gists_url":"https://api.github.com/users/alfredodeza/gists{/gist_id}","starred_url":"https://api.github.com/users/alfredodeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfredodeza/subscriptions","organizations_url":"https://api.github.com/users/alfredodeza/orgs","repos_url":"https://api.github.com/users/alfredodeza/repos","events_url":"https://api.github.com/users/alfredodeza/events{/privacy}","received_events_url":"https://api.github.com/users/alfredodeza/received_events","type":"User","site_admin":false},{"login":"liewegas","id":433031,"node_id":"MDQ6VXNlcjQzMzAzMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/433031?v=4","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},{"login":"travisn","id":1048514,"node_id":"MDQ6VXNlcjEwNDg1MTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1048514?v=4","gravatar_id":"","url":"https://api.github.com/users/travisn","html_url":"https://github.com/travisn","followers_url":"https://api.github.com/users/travisn/followers","following_url":"https://api.github.com/users/travisn/following{/other_user}","gists_url":"https://api.github.com/users/travisn/gists{/gist_id}","starred_url":"https://api.github.com/users/travisn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisn/subscriptions","organizations_url":"https://api.github.com/users/travisn/orgs","repos_url":"https://api.github.com/users/travisn/repos","events_url":"https://api.github.com/users/travisn/events{/privacy}","received_events_url":"https://api.github.com/users/travisn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":656485990,"node_id":"MDU6TGFiZWw2NTY0ODU5OTA=","url":"https://api.github.com/repos/ceph/ceph/labels/ceph-volume","name":"ceph-volume","color":"0052cc","default":false},{"id":148431321,"node_id":"MDU6TGFiZWwxNDg0MzEzMjE=","url":"https://api.github.com/repos/ceph/ceph/labels/needs-qa","name":"needs-qa","color":"fad8c7","default":false},{"id":340048817,"node_id":"MDU6TGFiZWwzNDAwNDg4MTc=","url":"https://api.github.com/repos/ceph/ceph/labels/needs-review","name":"needs-review","color":"d4c5f9","default":false},{"id":1111279478,"node_id":"MDU6TGFiZWwxMTExMjc5NDc4","url":"https://api.github.com/repos/ceph/ceph/labels/orchestrator","name":"orchestrator","color":"ff00c0","default":false},{"id":168653239,"node_id":"MDU6TGFiZWwxNjg2NTMyMzk=","url":"https://api.github.com/repos/ceph/ceph/labels/tests","name":"tests","color":"cccccc","default":false},{"id":731274994,"node_id":"MDU6TGFiZWw3MzEyNzQ5OTQ=","url":"https://api.github.com/repos/ceph/ceph/labels/wip-sage3-testing","name":"wip-sage3-testing","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/25236/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/25236/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/25236/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/fe1f713c38c03bf859edbf47822ff6f24880cf24","head":{"label":"sebastian-philipp:orchestrator-test-orchestrator","ref":"orchestrator-test-orchestrator","sha":"fe1f713c38c03bf859edbf47822ff6f24880cf24","user":{"login":"sebastian-philipp","id":2574405,"node_id":"MDQ6VXNlcjI1NzQ0MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2574405?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastian-philipp","html_url":"https://github.com/sebastian-philipp","followers_url":"https://api.github.com/users/sebastian-philipp/followers","following_url":"https://api.github.com/users/sebastian-philipp/following{/other_user}","gists_url":"https://api.github.com/users/sebastian-philipp/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastian-philipp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastian-philipp/subscriptions","organizations_url":"https://api.github.com/users/sebastian-philipp/orgs","repos_url":"https://api.github.com/users/sebastian-philipp/repos","events_url":"https://api.github.com/users/sebastian-philipp/events{/privacy}","received_events_url":"https://api.github.com/users/sebastian-philipp/received_events","type":"User","site_admin":false},"repo":{"id":96899744,"node_id":"MDEwOlJlcG9zaXRvcnk5Njg5OTc0NA==","name":"ceph","full_name":"sebastian-philipp/ceph","private":false,"owner":{"login":"sebastian-philipp","id":2574405,"node_id":"MDQ6VXNlcjI1NzQ0MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2574405?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastian-philipp","html_url":"https://github.com/sebastian-philipp","followers_url":"https://api.github.com/users/sebastian-philipp/followers","following_url":"https://api.github.com/users/sebastian-philipp/following{/other_user}","gists_url":"https://api.github.com/users/sebastian-philipp/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastian-philipp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastian-philipp/subscriptions","organizations_url":"https://api.github.com/users/sebastian-philipp/orgs","repos_url":"https://api.github.com/users/sebastian-philipp/repos","events_url":"https://api.github.com/users/sebastian-philipp/events{/privacy}","received_events_url":"https://api.github.com/users/sebastian-philipp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sebastian-philipp/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/sebastian-philipp/ceph","forks_url":"https://api.github.com/repos/sebastian-philipp/ceph/forks","keys_url":"https://api.github.com/repos/sebastian-philipp/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sebastian-philipp/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sebastian-philipp/ceph/teams","hooks_url":"https://api.github.com/repos/sebastian-philipp/ceph/hooks","issue_events_url":"https://api.github.com/repos/sebastian-philipp/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/sebastian-philipp/ceph/events","assignees_url":"https://api.github.com/repos/sebastian-philipp/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/sebastian-philipp/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/sebastian-philipp/ceph/tags","blobs_url":"https://api.github.com/repos/sebastian-philipp/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sebastian-philipp/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sebastian-philipp/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/sebastian-philipp/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sebastian-philipp/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/sebastian-philipp/ceph/languages","stargazers_url":"https://api.github.com/repos/sebastian-philipp/ceph/stargazers","contributors_url":"https://api.github.com/repos/sebastian-philipp/ceph/contributors","subscribers_url":"https://api.github.com/repos/sebastian-philipp/ceph/subscribers","subscription_url":"https://api.github.com/repos/sebastian-philipp/ceph/subscription","commits_url":"https://api.github.com/repos/sebastian-philipp/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/sebastian-philipp/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/sebastian-philipp/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/sebastian-philipp/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/sebastian-philipp/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/sebastian-philipp/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sebastian-philipp/ceph/merges","archive_url":"https://api.github.com/repos/sebastian-philipp/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sebastian-philipp/ceph/downloads","issues_url":"https://api.github.com/repos/sebastian-philipp/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/sebastian-philipp/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/sebastian-philipp/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/sebastian-philipp/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sebastian-philipp/ceph/labels{/name}","releases_url":"https://api.github.com/repos/sebastian-philipp/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/sebastian-philipp/ceph/deployments","created_at":"2017-07-11T14:02:08Z","updated_at":"2018-11-28T11:50:56Z","pushed_at":"2018-12-20T09:48:12Z","git_url":"git://github.com/sebastian-philipp/ceph.git","ssh_url":"git@github.com:sebastian-philipp/ceph.git","clone_url":"https://github.com/sebastian-philipp/ceph.git","svn_url":"https://github.com/sebastian-philipp/ceph","homepage":"http://ceph.com","size":318720,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"3a2b0906232c3199cb817226fcf71974c65b7118","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"node_id":"MDEwOlJlcG9zaXRvcnkyMzEwNDk1","name":"ceph","full_name":"ceph/ceph","private":false,"owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-12-20T09:38:57Z","pushed_at":"2018-12-20T09:48:17Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":339058,"stargazers_count":5420,"watchers_count":5420,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2847,"mirror_url":null,"archived":false,"open_issues_count":651,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2847,"open_issues":651,"watchers":5420,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/25236"},"html":{"href":"https://github.com/ceph/ceph/pull/25236"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/25236"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/25236/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/25236/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/25236/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/fe1f713c38c03bf859edbf47822ff6f24880cf24"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sebastian-philipp"}}