{"action":"created","comment":{"url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/pulls/comments/228599176","pull_request_review_id":168914854,"id":228599176,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODU5OTE3Ng==","diff_hunk":"@@ -1468,7 +1476,9 @@ module.exports = function(window, edgeVersion) {\n       var mid = transceiver.mid || SDPUtils.generateIdentifier();\n       transceiver.mid = mid;\n       if (transceiver.sdpMLineIndex === undefined) {\n-        transceiver.sdpMLineIndex = sdpMLineIndex;\n+        transceiver.sdpMLineIndex = pc.transceivers.reduce((max, t) =>","path":"rtcpeerconnection.js","position":82,"original_position":82,"commit_id":"89728980cf6ebdb64c60173249f8f337bc74341e","original_commit_id":"89728980cf6ebdb64c60173249f8f337bc74341e","user":{"login":"manjeshbhargav","id":755797,"node_id":"MDQ6VXNlcjc1NTc5Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/755797?v=4","gravatar_id":"","url":"https://api.github.com/users/manjeshbhargav","html_url":"https://github.com/manjeshbhargav","followers_url":"https://api.github.com/users/manjeshbhargav/followers","following_url":"https://api.github.com/users/manjeshbhargav/following{/other_user}","gists_url":"https://api.github.com/users/manjeshbhargav/gists{/gist_id}","starred_url":"https://api.github.com/users/manjeshbhargav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manjeshbhargav/subscriptions","organizations_url":"https://api.github.com/users/manjeshbhargav/orgs","repos_url":"https://api.github.com/users/manjeshbhargav/repos","events_url":"https://api.github.com/users/manjeshbhargav/events{/privacy}","received_events_url":"https://api.github.com/users/manjeshbhargav/received_events","type":"User","site_admin":false},"body":"@syerrapragada Here, `transceiver.sdpMLineIndex` might be different that `sdpMLineIndex`. Won't that cause any side-effects elsewhere?","created_at":"2018-10-26T17:01:24Z","updated_at":"2018-10-26T17:01:25Z","html_url":"https://github.com/twilio/rtcpeerconnection-shim/pull/6#discussion_r228599176","pull_request_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/pulls/6","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/pulls/comments/228599176"},"html":{"href":"https://github.com/twilio/rtcpeerconnection-shim/pull/6#discussion_r228599176"},"pull_request":{"href":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/pulls/6","id":226160292,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MTYwMjky","html_url":"https://github.com/twilio/rtcpeerconnection-shim/pull/6","diff_url":"https://github.com/twilio/rtcpeerconnection-shim/pull/6.diff","patch_url":"https://github.com/twilio/rtcpeerconnection-shim/pull/6.patch","issue_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/issues/6","number":6,"state":"open","locked":false,"title":"Fix _disposeIceAndDtlsTransports to take transceiver parameter instea…","user":{"login":"syerrapragada","id":20006575,"node_id":"MDQ6VXNlcjIwMDA2NTc1","avatar_url":"https://avatars3.githubusercontent.com/u/20006575?v=4","gravatar_id":"","url":"https://api.github.com/users/syerrapragada","html_url":"https://github.com/syerrapragada","followers_url":"https://api.github.com/users/syerrapragada/followers","following_url":"https://api.github.com/users/syerrapragada/following{/other_user}","gists_url":"https://api.github.com/users/syerrapragada/gists{/gist_id}","starred_url":"https://api.github.com/users/syerrapragada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syerrapragada/subscriptions","organizations_url":"https://api.github.com/users/syerrapragada/orgs","repos_url":"https://api.github.com/users/syerrapragada/repos","events_url":"https://api.github.com/users/syerrapragada/events{/privacy}","received_events_url":"https://api.github.com/users/syerrapragada/received_events","type":"User","site_admin":false},"body":"…dof mline index","created_at":"2018-10-26T16:43:53Z","updated_at":"2018-10-26T17:01:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"edc90381e70b918dcf5aa76a6aa7fe16377ce28d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/pulls/6/commits","review_comments_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/pulls/6/comments","review_comment_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/issues/6/comments","statuses_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/statuses/89728980cf6ebdb64c60173249f8f337bc74341e","head":{"label":"twilio:Fix_Dispose","ref":"Fix_Dispose","sha":"89728980cf6ebdb64c60173249f8f337bc74341e","user":{"login":"twilio","id":109142,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTE0Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/109142?v=4","gravatar_id":"","url":"https://api.github.com/users/twilio","html_url":"https://github.com/twilio","followers_url":"https://api.github.com/users/twilio/followers","following_url":"https://api.github.com/users/twilio/following{/other_user}","gists_url":"https://api.github.com/users/twilio/gists{/gist_id}","starred_url":"https://api.github.com/users/twilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twilio/subscriptions","organizations_url":"https://api.github.com/users/twilio/orgs","repos_url":"https://api.github.com/users/twilio/repos","events_url":"https://api.github.com/users/twilio/events{/privacy}","received_events_url":"https://api.github.com/users/twilio/received_events","type":"Organization","site_admin":false},"repo":{"id":146942019,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY5NDIwMTk=","name":"rtcpeerconnection-shim","full_name":"twilio/rtcpeerconnection-shim","private":false,"owner":{"login":"twilio","id":109142,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTE0Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/109142?v=4","gravatar_id":"","url":"https://api.github.com/users/twilio","html_url":"https://github.com/twilio","followers_url":"https://api.github.com/users/twilio/followers","following_url":"https://api.github.com/users/twilio/following{/other_user}","gists_url":"https://api.github.com/users/twilio/gists{/gist_id}","starred_url":"https://api.github.com/users/twilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twilio/subscriptions","organizations_url":"https://api.github.com/users/twilio/orgs","repos_url":"https://api.github.com/users/twilio/repos","events_url":"https://api.github.com/users/twilio/events{/privacy}","received_events_url":"https://api.github.com/users/twilio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/twilio/rtcpeerconnection-shim","description":"Implementation of the RTCPeerConnection API ontop of ORTC","fork":true,"url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim","forks_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/forks","keys_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/teams","hooks_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/hooks","issue_events_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/issues/events{/number}","events_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/events","assignees_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/assignees{/user}","branches_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/branches{/branch}","tags_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/tags","blobs_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/git/refs{/sha}","trees_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/statuses/{sha}","languages_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/languages","stargazers_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/stargazers","contributors_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/contributors","subscribers_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/subscribers","subscription_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/subscription","commits_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/commits{/sha}","git_commits_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/git/commits{/sha}","comments_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/comments{/number}","issue_comment_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/issues/comments{/number}","contents_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/contents/{+path}","compare_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/merges","archive_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/downloads","issues_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/issues{/number}","pulls_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/pulls{/number}","milestones_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/milestones{/number}","notifications_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/labels{/name}","releases_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/releases{/id}","deployments_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/deployments","created_at":"2018-08-31T21:03:07Z","updated_at":"2018-10-22T19:54:01Z","pushed_at":"2018-10-26T16:43:54Z","git_url":"git://github.com/twilio/rtcpeerconnection-shim.git","ssh_url":"git@github.com:twilio/rtcpeerconnection-shim.git","clone_url":"https://github.com/twilio/rtcpeerconnection-shim.git","svn_url":"https://github.com/twilio/rtcpeerconnection-shim","homepage":null,"size":431,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"stable-twilio"}},"base":{"label":"twilio:stable-twilio","ref":"stable-twilio","sha":"3d2ef2cf38f7285d7aac64d59d74626a71f7d264","user":{"login":"twilio","id":109142,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTE0Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/109142?v=4","gravatar_id":"","url":"https://api.github.com/users/twilio","html_url":"https://github.com/twilio","followers_url":"https://api.github.com/users/twilio/followers","following_url":"https://api.github.com/users/twilio/following{/other_user}","gists_url":"https://api.github.com/users/twilio/gists{/gist_id}","starred_url":"https://api.github.com/users/twilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twilio/subscriptions","organizations_url":"https://api.github.com/users/twilio/orgs","repos_url":"https://api.github.com/users/twilio/repos","events_url":"https://api.github.com/users/twilio/events{/privacy}","received_events_url":"https://api.github.com/users/twilio/received_events","type":"Organization","site_admin":false},"repo":{"id":146942019,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY5NDIwMTk=","name":"rtcpeerconnection-shim","full_name":"twilio/rtcpeerconnection-shim","private":false,"owner":{"login":"twilio","id":109142,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwOTE0Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/109142?v=4","gravatar_id":"","url":"https://api.github.com/users/twilio","html_url":"https://github.com/twilio","followers_url":"https://api.github.com/users/twilio/followers","following_url":"https://api.github.com/users/twilio/following{/other_user}","gists_url":"https://api.github.com/users/twilio/gists{/gist_id}","starred_url":"https://api.github.com/users/twilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twilio/subscriptions","organizations_url":"https://api.github.com/users/twilio/orgs","repos_url":"https://api.github.com/users/twilio/repos","events_url":"https://api.github.com/users/twilio/events{/privacy}","received_events_url":"https://api.github.com/users/twilio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/twilio/rtcpeerconnection-shim","description":"Implementation of the RTCPeerConnection API ontop of ORTC","fork":true,"url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim","forks_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/forks","keys_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/teams","hooks_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/hooks","issue_events_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/issues/events{/number}","events_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/events","assignees_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/assignees{/user}","branches_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/branches{/branch}","tags_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/tags","blobs_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/git/refs{/sha}","trees_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/statuses/{sha}","languages_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/languages","stargazers_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/stargazers","contributors_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/contributors","subscribers_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/subscribers","subscription_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/subscription","commits_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/commits{/sha}","git_commits_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/git/commits{/sha}","comments_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/comments{/number}","issue_comment_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/issues/comments{/number}","contents_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/contents/{+path}","compare_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/merges","archive_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/downloads","issues_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/issues{/number}","pulls_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/pulls{/number}","milestones_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/milestones{/number}","notifications_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/labels{/name}","releases_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/releases{/id}","deployments_url":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/deployments","created_at":"2018-08-31T21:03:07Z","updated_at":"2018-10-22T19:54:01Z","pushed_at":"2018-10-26T16:43:54Z","git_url":"git://github.com/twilio/rtcpeerconnection-shim.git","ssh_url":"git@github.com:twilio/rtcpeerconnection-shim.git","clone_url":"https://github.com/twilio/rtcpeerconnection-shim.git","svn_url":"https://github.com/twilio/rtcpeerconnection-shim","homepage":null,"size":431,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"stable-twilio"}},"_links":{"self":{"href":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/pulls/6"},"html":{"href":"https://github.com/twilio/rtcpeerconnection-shim/pull/6"},"issue":{"href":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/issues/6"},"comments":{"href":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/twilio/rtcpeerconnection-shim/statuses/89728980cf6ebdb64c60173249f8f337bc74341e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"manjeshbhargav"}}