{"action":"created","comment":{"url":"https://api.github.com/repos/pluginsGLPI/formcreator/pulls/comments/230317526","pull_request_review_id":171029109,"id":230317526,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDMxNzUyNg==","diff_hunk":"@@ -165,6 +168,56 @@ public static function header($title) {\n          }\n       }\n \n+      $link = new Link;\n+      $ar_links = $link->find(\"name LIKE '\". $_SESSION['plugin_formcretor']['external_links_prefix'] .\"%'\");\n+      foreach ($ar_links as $id => $a_link) {\n+         /*\n+          * The link name is filtered and trimmed to remove the 'Helpdesk' string and extra whitespaces:\n+          * Helpdesk 1 - the first link\n+          * will display: the first link.\n+          */\n+         $label = trim(str_replace($_SESSION['plugin_formcretor']['external_links_prefix'], '', $a_link['name']));\n+\n+         /*\n+          * If the link data field contains a line starting with Icon:, this line is used as a class icon\n+          * for the link. As an example, this line:\n+          * Icon: fa fa-dashboard\n+          * will use the font awesome fa-dashboard icon for the current link.\n+          * As default, the fa-globe icon is used.\n+          */\n+         preg_match_all(\"/^\". $_SESSION['plugin_formcretor']['external_links_icon'] .\"(.*)$/m\", $a_link['data'], $found);\n+         $icon = \"fa fa-globe\";\n+         if ((count($found) > 0) and (count($found[0]) > 0)) {\n+            $icon = trim(str_replace($_SESSION['plugin_formcretor']['external_links_icon'], '', $found[0][0]));\n+         }\n+\n+         /*\n+          * If the link data field contains a line starting with Title:, this line is used to find the title used\n+          * for the link. As an example, this line:\n+          * Title: this is my title\n+          * will define a new title for the current link.\n+          * As default, the link name is used.\n+          */\n+         preg_match_all(\"/^\". $_SESSION['plugin_formcretor']['external_links_title'] .\"(.*)$/m\", $a_link['data'], $found);\n+         $title = $a_link['name'];\n+         if ((count($found) > 0) and (count($found[0]) > 0)) {\n+            $title = trim(str_replace($_SESSION['plugin_formcretor']['external_links_title'], '', $found[0][0]));\n+         }","path":"inc/wizard.class.php","position":57,"original_position":57,"commit_id":"554e1a446a674d81ba5855da14560405706f347a","original_commit_id":"554e1a446a674d81ba5855da14560405706f347a","user":{"login":"btry","id":14139801,"node_id":"MDQ6VXNlcjE0MTM5ODAx","avatar_url":"https://avatars2.githubusercontent.com/u/14139801?v=4","gravatar_id":"","url":"https://api.github.com/users/btry","html_url":"https://github.com/btry","followers_url":"https://api.github.com/users/btry/followers","following_url":"https://api.github.com/users/btry/following{/other_user}","gists_url":"https://api.github.com/users/btry/gists{/gist_id}","starred_url":"https://api.github.com/users/btry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btry/subscriptions","organizations_url":"https://api.github.com/users/btry/orgs","repos_url":"https://api.github.com/users/btry/repos","events_url":"https://api.github.com/users/btry/events{/privacy}","received_events_url":"https://api.github.com/users/btry/received_events","type":"User","site_admin":false},"body":"same agaiin","created_at":"2018-11-02T09:45:21Z","updated_at":"2018-11-02T09:45:22Z","html_url":"https://github.com/pluginsGLPI/formcreator/pull/1157#discussion_r230317526","pull_request_url":"https://api.github.com/repos/pluginsGLPI/formcreator/pulls/1157","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pluginsGLPI/formcreator/pulls/comments/230317526"},"html":{"href":"https://github.com/pluginsGLPI/formcreator/pull/1157#discussion_r230317526"},"pull_request":{"href":"https://api.github.com/repos/pluginsGLPI/formcreator/pulls/1157"}}},"pull_request":{"url":"https://api.github.com/repos/pluginsGLPI/formcreator/pulls/1157","id":225368592,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MzY4NTky","html_url":"https://github.com/pluginsGLPI/formcreator/pull/1157","diff_url":"https://github.com/pluginsGLPI/formcreator/pull/1157.diff","patch_url":"https://github.com/pluginsGLPI/formcreator/pull/1157.patch","issue_url":"https://api.github.com/repos/pluginsGLPI/formcreator/issues/1157","number":1157,"state":"open","locked":false,"title":"Allow to add external links in the Services catalog menu","user":{"login":"mohierf","id":2932687,"node_id":"MDQ6VXNlcjI5MzI2ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/2932687?v=4","gravatar_id":"","url":"https://api.github.com/users/mohierf","html_url":"https://github.com/mohierf","followers_url":"https://api.github.com/users/mohierf/followers","following_url":"https://api.github.com/users/mohierf/following{/other_user}","gists_url":"https://api.github.com/users/mohierf/gists{/gist_id}","starred_url":"https://api.github.com/users/mohierf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohierf/subscriptions","organizations_url":"https://api.github.com/users/mohierf/orgs","repos_url":"https://api.github.com/users/mohierf/repos","events_url":"https://api.github.com/users/mohierf/events{/privacy}","received_events_url":"https://api.github.com/users/mohierf/received_events","type":"User","site_admin":false},"body":"Update plugin configuration table\r\nAdd some new configuration parameters for entities\r\nFixed configuration parameters entity inheritance\r\n\r\n---\r\n\r\nI considered that this will be included in the 2.7 version ... thus I included upgrade code for the DB in the 2.6 -> 2.7 update part.\r\n","created_at":"2018-10-24T11:40:04Z","updated_at":"2018-11-02T09:45:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87f9785b516703eb587a7b819135b655defe2ce9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pluginsGLPI/formcreator/pulls/1157/commits","review_comments_url":"https://api.github.com/repos/pluginsGLPI/formcreator/pulls/1157/comments","review_comment_url":"https://api.github.com/repos/pluginsGLPI/formcreator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pluginsGLPI/formcreator/issues/1157/comments","statuses_url":"https://api.github.com/repos/pluginsGLPI/formcreator/statuses/554e1a446a674d81ba5855da14560405706f347a","head":{"label":"mohierf:external-links","ref":"external-links","sha":"554e1a446a674d81ba5855da14560405706f347a","user":{"login":"mohierf","id":2932687,"node_id":"MDQ6VXNlcjI5MzI2ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/2932687?v=4","gravatar_id":"","url":"https://api.github.com/users/mohierf","html_url":"https://github.com/mohierf","followers_url":"https://api.github.com/users/mohierf/followers","following_url":"https://api.github.com/users/mohierf/following{/other_user}","gists_url":"https://api.github.com/users/mohierf/gists{/gist_id}","starred_url":"https://api.github.com/users/mohierf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohierf/subscriptions","organizations_url":"https://api.github.com/users/mohierf/orgs","repos_url":"https://api.github.com/users/mohierf/repos","events_url":"https://api.github.com/users/mohierf/events{/privacy}","received_events_url":"https://api.github.com/users/mohierf/received_events","type":"User","site_admin":false},"repo":{"id":154439841,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ0Mzk4NDE=","name":"formcreator","full_name":"mohierf/formcreator","private":false,"owner":{"login":"mohierf","id":2932687,"node_id":"MDQ6VXNlcjI5MzI2ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/2932687?v=4","gravatar_id":"","url":"https://api.github.com/users/mohierf","html_url":"https://github.com/mohierf","followers_url":"https://api.github.com/users/mohierf/followers","following_url":"https://api.github.com/users/mohierf/following{/other_user}","gists_url":"https://api.github.com/users/mohierf/gists{/gist_id}","starred_url":"https://api.github.com/users/mohierf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohierf/subscriptions","organizations_url":"https://api.github.com/users/mohierf/orgs","repos_url":"https://api.github.com/users/mohierf/repos","events_url":"https://api.github.com/users/mohierf/events{/privacy}","received_events_url":"https://api.github.com/users/mohierf/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mohierf/formcreator","description":"GLPI Plugin Formcreator (DOWNLOAD : https://github.com/pluginsGLPI/formcreator/releases)","fork":true,"url":"https://api.github.com/repos/mohierf/formcreator","forks_url":"https://api.github.com/repos/mohierf/formcreator/forks","keys_url":"https://api.github.com/repos/mohierf/formcreator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mohierf/formcreator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mohierf/formcreator/teams","hooks_url":"https://api.github.com/repos/mohierf/formcreator/hooks","issue_events_url":"https://api.github.com/repos/mohierf/formcreator/issues/events{/number}","events_url":"https://api.github.com/repos/mohierf/formcreator/events","assignees_url":"https://api.github.com/repos/mohierf/formcreator/assignees{/user}","branches_url":"https://api.github.com/repos/mohierf/formcreator/branches{/branch}","tags_url":"https://api.github.com/repos/mohierf/formcreator/tags","blobs_url":"https://api.github.com/repos/mohierf/formcreator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mohierf/formcreator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mohierf/formcreator/git/refs{/sha}","trees_url":"https://api.github.com/repos/mohierf/formcreator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mohierf/formcreator/statuses/{sha}","languages_url":"https://api.github.com/repos/mohierf/formcreator/languages","stargazers_url":"https://api.github.com/repos/mohierf/formcreator/stargazers","contributors_url":"https://api.github.com/repos/mohierf/formcreator/contributors","subscribers_url":"https://api.github.com/repos/mohierf/formcreator/subscribers","subscription_url":"https://api.github.com/repos/mohierf/formcreator/subscription","commits_url":"https://api.github.com/repos/mohierf/formcreator/commits{/sha}","git_commits_url":"https://api.github.com/repos/mohierf/formcreator/git/commits{/sha}","comments_url":"https://api.github.com/repos/mohierf/formcreator/comments{/number}","issue_comment_url":"https://api.github.com/repos/mohierf/formcreator/issues/comments{/number}","contents_url":"https://api.github.com/repos/mohierf/formcreator/contents/{+path}","compare_url":"https://api.github.com/repos/mohierf/formcreator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mohierf/formcreator/merges","archive_url":"https://api.github.com/repos/mohierf/formcreator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mohierf/formcreator/downloads","issues_url":"https://api.github.com/repos/mohierf/formcreator/issues{/number}","pulls_url":"https://api.github.com/repos/mohierf/formcreator/pulls{/number}","milestones_url":"https://api.github.com/repos/mohierf/formcreator/milestones{/number}","notifications_url":"https://api.github.com/repos/mohierf/formcreator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mohierf/formcreator/labels{/name}","releases_url":"https://api.github.com/repos/mohierf/formcreator/releases{/id}","deployments_url":"https://api.github.com/repos/mohierf/formcreator/deployments","created_at":"2018-10-24T04:38:05Z","updated_at":"2018-10-24T04:38:08Z","pushed_at":"2018-10-31T09:09:46Z","git_url":"git://github.com/mohierf/formcreator.git","ssh_url":"git@github.com:mohierf/formcreator.git","clone_url":"https://github.com/mohierf/formcreator.git","svn_url":"https://github.com/mohierf/formcreator","homepage":"http://www.teclib-edition.com","size":6663,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"pluginsGLPI:develop","ref":"develop","sha":"468ee6b80e89573bf357e0df0ee629bd3cf45189","user":{"login":"pluginsGLPI","id":10156352,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU2MzUy","avatar_url":"https://avatars3.githubusercontent.com/u/10156352?v=4","gravatar_id":"","url":"https://api.github.com/users/pluginsGLPI","html_url":"https://github.com/pluginsGLPI","followers_url":"https://api.github.com/users/pluginsGLPI/followers","following_url":"https://api.github.com/users/pluginsGLPI/following{/other_user}","gists_url":"https://api.github.com/users/pluginsGLPI/gists{/gist_id}","starred_url":"https://api.github.com/users/pluginsGLPI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pluginsGLPI/subscriptions","organizations_url":"https://api.github.com/users/pluginsGLPI/orgs","repos_url":"https://api.github.com/users/pluginsGLPI/repos","events_url":"https://api.github.com/users/pluginsGLPI/events{/privacy}","received_events_url":"https://api.github.com/users/pluginsGLPI/received_events","type":"Organization","site_admin":false},"repo":{"id":22433410,"node_id":"MDEwOlJlcG9zaXRvcnkyMjQzMzQxMA==","name":"formcreator","full_name":"pluginsGLPI/formcreator","private":false,"owner":{"login":"pluginsGLPI","id":10156352,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU2MzUy","avatar_url":"https://avatars3.githubusercontent.com/u/10156352?v=4","gravatar_id":"","url":"https://api.github.com/users/pluginsGLPI","html_url":"https://github.com/pluginsGLPI","followers_url":"https://api.github.com/users/pluginsGLPI/followers","following_url":"https://api.github.com/users/pluginsGLPI/following{/other_user}","gists_url":"https://api.github.com/users/pluginsGLPI/gists{/gist_id}","starred_url":"https://api.github.com/users/pluginsGLPI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pluginsGLPI/subscriptions","organizations_url":"https://api.github.com/users/pluginsGLPI/orgs","repos_url":"https://api.github.com/users/pluginsGLPI/repos","events_url":"https://api.github.com/users/pluginsGLPI/events{/privacy}","received_events_url":"https://api.github.com/users/pluginsGLPI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pluginsGLPI/formcreator","description":"GLPI Plugin Formcreator (DOWNLOAD : https://github.com/pluginsGLPI/formcreator/releases)","fork":false,"url":"https://api.github.com/repos/pluginsGLPI/formcreator","forks_url":"https://api.github.com/repos/pluginsGLPI/formcreator/forks","keys_url":"https://api.github.com/repos/pluginsGLPI/formcreator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pluginsGLPI/formcreator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pluginsGLPI/formcreator/teams","hooks_url":"https://api.github.com/repos/pluginsGLPI/formcreator/hooks","issue_events_url":"https://api.github.com/repos/pluginsGLPI/formcreator/issues/events{/number}","events_url":"https://api.github.com/repos/pluginsGLPI/formcreator/events","assignees_url":"https://api.github.com/repos/pluginsGLPI/formcreator/assignees{/user}","branches_url":"https://api.github.com/repos/pluginsGLPI/formcreator/branches{/branch}","tags_url":"https://api.github.com/repos/pluginsGLPI/formcreator/tags","blobs_url":"https://api.github.com/repos/pluginsGLPI/formcreator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pluginsGLPI/formcreator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pluginsGLPI/formcreator/git/refs{/sha}","trees_url":"https://api.github.com/repos/pluginsGLPI/formcreator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pluginsGLPI/formcreator/statuses/{sha}","languages_url":"https://api.github.com/repos/pluginsGLPI/formcreator/languages","stargazers_url":"https://api.github.com/repos/pluginsGLPI/formcreator/stargazers","contributors_url":"https://api.github.com/repos/pluginsGLPI/formcreator/contributors","subscribers_url":"https://api.github.com/repos/pluginsGLPI/formcreator/subscribers","subscription_url":"https://api.github.com/repos/pluginsGLPI/formcreator/subscription","commits_url":"https://api.github.com/repos/pluginsGLPI/formcreator/commits{/sha}","git_commits_url":"https://api.github.com/repos/pluginsGLPI/formcreator/git/commits{/sha}","comments_url":"https://api.github.com/repos/pluginsGLPI/formcreator/comments{/number}","issue_comment_url":"https://api.github.com/repos/pluginsGLPI/formcreator/issues/comments{/number}","contents_url":"https://api.github.com/repos/pluginsGLPI/formcreator/contents/{+path}","compare_url":"https://api.github.com/repos/pluginsGLPI/formcreator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pluginsGLPI/formcreator/merges","archive_url":"https://api.github.com/repos/pluginsGLPI/formcreator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pluginsGLPI/formcreator/downloads","issues_url":"https://api.github.com/repos/pluginsGLPI/formcreator/issues{/number}","pulls_url":"https://api.github.com/repos/pluginsGLPI/formcreator/pulls{/number}","milestones_url":"https://api.github.com/repos/pluginsGLPI/formcreator/milestones{/number}","notifications_url":"https://api.github.com/repos/pluginsGLPI/formcreator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pluginsGLPI/formcreator/labels{/name}","releases_url":"https://api.github.com/repos/pluginsGLPI/formcreator/releases{/id}","deployments_url":"https://api.github.com/repos/pluginsGLPI/formcreator/deployments","created_at":"2014-07-30T15:23:09Z","updated_at":"2018-11-02T08:07:11Z","pushed_at":"2018-11-02T08:07:08Z","git_url":"git://github.com/pluginsGLPI/formcreator.git","ssh_url":"git@github.com:pluginsGLPI/formcreator.git","clone_url":"https://github.com/pluginsGLPI/formcreator.git","svn_url":"https://github.com/pluginsGLPI/formcreator","homepage":"http://www.teclib-edition.com","size":6719,"stargazers_count":51,"watchers_count":51,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":60,"mirror_url":null,"archived":false,"open_issues_count":216,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":60,"open_issues":216,"watchers":51,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/pluginsGLPI/formcreator/pulls/1157"},"html":{"href":"https://github.com/pluginsGLPI/formcreator/pull/1157"},"issue":{"href":"https://api.github.com/repos/pluginsGLPI/formcreator/issues/1157"},"comments":{"href":"https://api.github.com/repos/pluginsGLPI/formcreator/issues/1157/comments"},"review_comments":{"href":"https://api.github.com/repos/pluginsGLPI/formcreator/pulls/1157/comments"},"review_comment":{"href":"https://api.github.com/repos/pluginsGLPI/formcreator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pluginsGLPI/formcreator/pulls/1157/commits"},"statuses":{"href":"https://api.github.com/repos/pluginsGLPI/formcreator/statuses/554e1a446a674d81ba5855da14560405706f347a"}},"author_association":"NONE"}}
{"actor":{"display_login":"btry"}}