{"action":"created","comment":{"url":"https://api.github.com/repos/hmrc/ct-calculations/pulls/comments/166622711","pull_request_review_id":94714189,"id":166622711,"diff_hunk":"@@ -37,10 +37,10 @@ class CP281aSpec extends WordSpec with Matchers with MockitoSugar with BoxValida\n   testCannotExistWhen(\"CP281a\", CP281a.apply, testDetails = \"CPQ17 false\") {\n     makeBoxRetriever(cpq17Value = false)\n   }\n-\n-  testCannotExistWhen(\"CP281a\", CP281a.apply, testDetails = \"before loss reform\") {\n-    makeBoxRetriever(cp2Value = CPQ17.lossReform2017)\n-  }\n+//\n+//  testCannotExistWhen(\"CP281a\", CP281a.apply, testDetails = \"before loss reform\") {\n+//    makeBoxRetriever(cp2Value = CPQ17.lossReform2017)\n+//  }","path":"src/test/scala/uk/gov/hmrc/ct/computations/CP281aSpec.scala","position":11,"original_position":11,"commit_id":"ee41cb9d918b238bd220a5efe7e49cdc98925af7","original_commit_id":"ca077af24ebf30282d83df417e2225cbeb1e2020","user":{"login":"kastoestoramadus","id":6271645,"avatar_url":"https://avatars2.githubusercontent.com/u/6271645?v=4","gravatar_id":"","url":"https://api.github.com/users/kastoestoramadus","html_url":"https://github.com/kastoestoramadus","followers_url":"https://api.github.com/users/kastoestoramadus/followers","following_url":"https://api.github.com/users/kastoestoramadus/following{/other_user}","gists_url":"https://api.github.com/users/kastoestoramadus/gists{/gist_id}","starred_url":"https://api.github.com/users/kastoestoramadus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kastoestoramadus/subscriptions","organizations_url":"https://api.github.com/users/kastoestoramadus/orgs","repos_url":"https://api.github.com/users/kastoestoramadus/repos","events_url":"https://api.github.com/users/kastoestoramadus/events{/privacy}","received_events_url":"https://api.github.com/users/kastoestoramadus/received_events","type":"User","site_admin":false},"body":"Another commented code. Usully it can be just deleted. Don't spend too much time in the investigation. Even when removed it will be still in the git history. @rutpatelhmrc ","created_at":"2018-02-07T13:53:18Z","updated_at":"2018-02-07T13:53:18Z","html_url":"https://github.com/hmrc/ct-calculations/pull/375#discussion_r166622711","pull_request_url":"https://api.github.com/repos/hmrc/ct-calculations/pulls/375","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/hmrc/ct-calculations/pulls/comments/166622711"},"html":{"href":"https://github.com/hmrc/ct-calculations/pull/375#discussion_r166622711"},"pull_request":{"href":"https://api.github.com/repos/hmrc/ct-calculations/pulls/375"}}},"pull_request":{"url":"https://api.github.com/repos/hmrc/ct-calculations/pulls/375","id":167437568,"html_url":"https://github.com/hmrc/ct-calculations/pull/375","diff_url":"https://github.com/hmrc/ct-calculations/pull/375.diff","patch_url":"https://github.com/hmrc/ct-calculations/pull/375.patch","issue_url":"https://api.github.com/repos/hmrc/ct-calculations/issues/375","number":375,"state":"open","locked":false,"title":"CATO-4874","user":{"login":"rutpatelhmrc","id":31273769,"avatar_url":"https://avatars1.githubusercontent.com/u/31273769?v=4","gravatar_id":"","url":"https://api.github.com/users/rutpatelhmrc","html_url":"https://github.com/rutpatelhmrc","followers_url":"https://api.github.com/users/rutpatelhmrc/followers","following_url":"https://api.github.com/users/rutpatelhmrc/following{/other_user}","gists_url":"https://api.github.com/users/rutpatelhmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/rutpatelhmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rutpatelhmrc/subscriptions","organizations_url":"https://api.github.com/users/rutpatelhmrc/orgs","repos_url":"https://api.github.com/users/rutpatelhmrc/repos","events_url":"https://api.github.com/users/rutpatelhmrc/events{/privacy}","received_events_url":"https://api.github.com/users/rutpatelhmrc/received_events","type":"User","site_admin":false},"body":"Added more test to test the calculations for the northern ireland rate. Also added the negative test to test the error message which is thrown by the system.","created_at":"2018-02-06T15:00:39Z","updated_at":"2018-02-07T13:53:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79432dc9fadc7051c053cb1b36d832b242971687","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmrc/ct-calculations/pulls/375/commits","review_comments_url":"https://api.github.com/repos/hmrc/ct-calculations/pulls/375/comments","review_comment_url":"https://api.github.com/repos/hmrc/ct-calculations/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmrc/ct-calculations/issues/375/comments","statuses_url":"https://api.github.com/repos/hmrc/ct-calculations/statuses/ee41cb9d918b238bd220a5efe7e49cdc98925af7","head":{"label":"hmrc:CATO-4874","ref":"CATO-4874","sha":"ee41cb9d918b238bd220a5efe7e49cdc98925af7","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":42594135,"name":"ct-calculations","full_name":"hmrc/ct-calculations","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/ct-calculations","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/ct-calculations","forks_url":"https://api.github.com/repos/hmrc/ct-calculations/forks","keys_url":"https://api.github.com/repos/hmrc/ct-calculations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/ct-calculations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/ct-calculations/teams","hooks_url":"https://api.github.com/repos/hmrc/ct-calculations/hooks","issue_events_url":"https://api.github.com/repos/hmrc/ct-calculations/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/ct-calculations/events","assignees_url":"https://api.github.com/repos/hmrc/ct-calculations/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/ct-calculations/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/ct-calculations/tags","blobs_url":"https://api.github.com/repos/hmrc/ct-calculations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/ct-calculations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/ct-calculations/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/ct-calculations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/ct-calculations/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/ct-calculations/languages","stargazers_url":"https://api.github.com/repos/hmrc/ct-calculations/stargazers","contributors_url":"https://api.github.com/repos/hmrc/ct-calculations/contributors","subscribers_url":"https://api.github.com/repos/hmrc/ct-calculations/subscribers","subscription_url":"https://api.github.com/repos/hmrc/ct-calculations/subscription","commits_url":"https://api.github.com/repos/hmrc/ct-calculations/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/ct-calculations/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/ct-calculations/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/ct-calculations/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/ct-calculations/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/ct-calculations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/ct-calculations/merges","archive_url":"https://api.github.com/repos/hmrc/ct-calculations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/ct-calculations/downloads","issues_url":"https://api.github.com/repos/hmrc/ct-calculations/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/ct-calculations/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/ct-calculations/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/ct-calculations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/ct-calculations/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/ct-calculations/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/ct-calculations/deployments","created_at":"2015-09-16T14:57:53Z","updated_at":"2016-01-11T09:37:03Z","pushed_at":"2018-02-07T12:34:09Z","git_url":"git://github.com/hmrc/ct-calculations.git","ssh_url":"git@github.com:hmrc/ct-calculations.git","clone_url":"https://github.com/hmrc/ct-calculations.git","svn_url":"https://github.com/hmrc/ct-calculations","homepage":null,"size":3833,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":13,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"hmrc:master","ref":"master","sha":"8bf36964029d27011aad87e107d22f78ad99db67","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":42594135,"name":"ct-calculations","full_name":"hmrc/ct-calculations","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/ct-calculations","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/ct-calculations","forks_url":"https://api.github.com/repos/hmrc/ct-calculations/forks","keys_url":"https://api.github.com/repos/hmrc/ct-calculations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/ct-calculations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/ct-calculations/teams","hooks_url":"https://api.github.com/repos/hmrc/ct-calculations/hooks","issue_events_url":"https://api.github.com/repos/hmrc/ct-calculations/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/ct-calculations/events","assignees_url":"https://api.github.com/repos/hmrc/ct-calculations/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/ct-calculations/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/ct-calculations/tags","blobs_url":"https://api.github.com/repos/hmrc/ct-calculations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/ct-calculations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/ct-calculations/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/ct-calculations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/ct-calculations/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/ct-calculations/languages","stargazers_url":"https://api.github.com/repos/hmrc/ct-calculations/stargazers","contributors_url":"https://api.github.com/repos/hmrc/ct-calculations/contributors","subscribers_url":"https://api.github.com/repos/hmrc/ct-calculations/subscribers","subscription_url":"https://api.github.com/repos/hmrc/ct-calculations/subscription","commits_url":"https://api.github.com/repos/hmrc/ct-calculations/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/ct-calculations/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/ct-calculations/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/ct-calculations/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/ct-calculations/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/ct-calculations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/ct-calculations/merges","archive_url":"https://api.github.com/repos/hmrc/ct-calculations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/ct-calculations/downloads","issues_url":"https://api.github.com/repos/hmrc/ct-calculations/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/ct-calculations/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/ct-calculations/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/ct-calculations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/ct-calculations/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/ct-calculations/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/ct-calculations/deployments","created_at":"2015-09-16T14:57:53Z","updated_at":"2016-01-11T09:37:03Z","pushed_at":"2018-02-07T12:34:09Z","git_url":"git://github.com/hmrc/ct-calculations.git","ssh_url":"git@github.com:hmrc/ct-calculations.git","clone_url":"https://github.com/hmrc/ct-calculations.git","svn_url":"https://github.com/hmrc/ct-calculations","homepage":null,"size":3833,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":13,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmrc/ct-calculations/pulls/375"},"html":{"href":"https://github.com/hmrc/ct-calculations/pull/375"},"issue":{"href":"https://api.github.com/repos/hmrc/ct-calculations/issues/375"},"comments":{"href":"https://api.github.com/repos/hmrc/ct-calculations/issues/375/comments"},"review_comments":{"href":"https://api.github.com/repos/hmrc/ct-calculations/pulls/375/comments"},"review_comment":{"href":"https://api.github.com/repos/hmrc/ct-calculations/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmrc/ct-calculations/pulls/375/commits"},"statuses":{"href":"https://api.github.com/repos/hmrc/ct-calculations/statuses/ee41cb9d918b238bd220a5efe7e49cdc98925af7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kastoestoramadus"}}