{"action":"closed","number":644,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kube-deploy/pulls/644","id":173860052,"html_url":"https://github.com/kubernetes/kube-deploy/pull/644","diff_url":"https://github.com/kubernetes/kube-deploy/pull/644.diff","patch_url":"https://github.com/kubernetes/kube-deploy/pull/644.patch","issue_url":"https://api.github.com/repos/kubernetes/kube-deploy/issues/644","number":644,"state":"closed","locked":false,"title":"Change DNSDomain to service domain","user":{"login":"krousey","id":157083,"avatar_url":"https://avatars2.githubusercontent.com/u/157083?v=4","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**: It was mentionedby @roberthbailey that this field needs a better name.\r\n\r\n**Special notes for your reviewer**: This is an API change. I don't think we're ready to solidify v1alpha1 yet. If we'd rather put this in a v1alpha2, that should be possible, but a lot more work.\r\n\r\n@kubernetes/kube-deploy-reviewers\r\n","created_at":"2018-03-08T21:48:02Z","updated_at":"2018-03-14T17:38:08Z","closed_at":"2018-03-14T17:38:08Z","merged_at":"2018-03-14T17:38:08Z","merge_commit_sha":"98cbfe32443f4bde8152d93e04f48a258aaab0c2","assignee":{"login":"roberthbailey","id":7751204,"avatar_url":"https://avatars1.githubusercontent.com/u/7751204?v=4","gravatar_id":"","url":"https://api.github.com/users/roberthbailey","html_url":"https://github.com/roberthbailey","followers_url":"https://api.github.com/users/roberthbailey/followers","following_url":"https://api.github.com/users/roberthbailey/following{/other_user}","gists_url":"https://api.github.com/users/roberthbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/roberthbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roberthbailey/subscriptions","organizations_url":"https://api.github.com/users/roberthbailey/orgs","repos_url":"https://api.github.com/users/roberthbailey/repos","events_url":"https://api.github.com/users/roberthbailey/events{/privacy}","received_events_url":"https://api.github.com/users/roberthbailey/received_events","type":"User","site_admin":false},"assignees":[{"login":"roberthbailey","id":7751204,"avatar_url":"https://avatars1.githubusercontent.com/u/7751204?v=4","gravatar_id":"","url":"https://api.github.com/users/roberthbailey","html_url":"https://github.com/roberthbailey","followers_url":"https://api.github.com/users/roberthbailey/followers","following_url":"https://api.github.com/users/roberthbailey/following{/other_user}","gists_url":"https://api.github.com/users/roberthbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/roberthbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roberthbailey/subscriptions","organizations_url":"https://api.github.com/users/roberthbailey/orgs","repos_url":"https://api.github.com/users/roberthbailey/repos","events_url":"https://api.github.com/users/roberthbailey/events{/privacy}","received_events_url":"https://api.github.com/users/roberthbailey/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":763706150,"url":"https://api.github.com/repos/kubernetes/kube-deploy/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":499761014,"url":"https://api.github.com/repos/kubernetes/kube-deploy/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349426931,"url":"https://api.github.com/repos/kubernetes/kube-deploy/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":707461437,"url":"https://api.github.com/repos/kubernetes/kube-deploy/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kube-deploy/pulls/644/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kube-deploy/pulls/644/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kube-deploy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kube-deploy/issues/644/comments","statuses_url":"https://api.github.com/repos/kubernetes/kube-deploy/statuses/fbd6836517c00563210d91b4dfc220ff1ba080b6","head":{"label":"krousey:servicedomain","ref":"servicedomain","sha":"fbd6836517c00563210d91b4dfc220ff1ba080b6","user":{"login":"krousey","id":157083,"avatar_url":"https://avatars2.githubusercontent.com/u/157083?v=4","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},"repo":{"id":107704871,"name":"kube-deploy","full_name":"krousey/kube-deploy","owner":{"login":"krousey","id":157083,"avatar_url":"https://avatars2.githubusercontent.com/u/157083?v=4","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krousey/kube-deploy","description":"A place for cluster deployment automation","fork":true,"url":"https://api.github.com/repos/krousey/kube-deploy","forks_url":"https://api.github.com/repos/krousey/kube-deploy/forks","keys_url":"https://api.github.com/repos/krousey/kube-deploy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krousey/kube-deploy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krousey/kube-deploy/teams","hooks_url":"https://api.github.com/repos/krousey/kube-deploy/hooks","issue_events_url":"https://api.github.com/repos/krousey/kube-deploy/issues/events{/number}","events_url":"https://api.github.com/repos/krousey/kube-deploy/events","assignees_url":"https://api.github.com/repos/krousey/kube-deploy/assignees{/user}","branches_url":"https://api.github.com/repos/krousey/kube-deploy/branches{/branch}","tags_url":"https://api.github.com/repos/krousey/kube-deploy/tags","blobs_url":"https://api.github.com/repos/krousey/kube-deploy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krousey/kube-deploy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krousey/kube-deploy/git/refs{/sha}","trees_url":"https://api.github.com/repos/krousey/kube-deploy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krousey/kube-deploy/statuses/{sha}","languages_url":"https://api.github.com/repos/krousey/kube-deploy/languages","stargazers_url":"https://api.github.com/repos/krousey/kube-deploy/stargazers","contributors_url":"https://api.github.com/repos/krousey/kube-deploy/contributors","subscribers_url":"https://api.github.com/repos/krousey/kube-deploy/subscribers","subscription_url":"https://api.github.com/repos/krousey/kube-deploy/subscription","commits_url":"https://api.github.com/repos/krousey/kube-deploy/commits{/sha}","git_commits_url":"https://api.github.com/repos/krousey/kube-deploy/git/commits{/sha}","comments_url":"https://api.github.com/repos/krousey/kube-deploy/comments{/number}","issue_comment_url":"https://api.github.com/repos/krousey/kube-deploy/issues/comments{/number}","contents_url":"https://api.github.com/repos/krousey/kube-deploy/contents/{+path}","compare_url":"https://api.github.com/repos/krousey/kube-deploy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krousey/kube-deploy/merges","archive_url":"https://api.github.com/repos/krousey/kube-deploy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krousey/kube-deploy/downloads","issues_url":"https://api.github.com/repos/krousey/kube-deploy/issues{/number}","pulls_url":"https://api.github.com/repos/krousey/kube-deploy/pulls{/number}","milestones_url":"https://api.github.com/repos/krousey/kube-deploy/milestones{/number}","notifications_url":"https://api.github.com/repos/krousey/kube-deploy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krousey/kube-deploy/labels{/name}","releases_url":"https://api.github.com/repos/krousey/kube-deploy/releases{/id}","deployments_url":"https://api.github.com/repos/krousey/kube-deploy/deployments","created_at":"2017-10-20T17:05:41Z","updated_at":"2017-10-20T17:05:44Z","pushed_at":"2018-03-08T21:45:22Z","git_url":"git://github.com/krousey/kube-deploy.git","ssh_url":"git@github.com:krousey/kube-deploy.git","clone_url":"https://github.com/krousey/kube-deploy.git","svn_url":"https://github.com/krousey/kube-deploy","homepage":null,"size":122894,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"e48c0b7823ac755c26e9212d8e72e2351ae9aab8","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":54912542,"name":"kube-deploy","full_name":"kubernetes/kube-deploy","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kube-deploy","description":"A place for cluster deployment automation","fork":false,"url":"https://api.github.com/repos/kubernetes/kube-deploy","forks_url":"https://api.github.com/repos/kubernetes/kube-deploy/forks","keys_url":"https://api.github.com/repos/kubernetes/kube-deploy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kube-deploy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kube-deploy/teams","hooks_url":"https://api.github.com/repos/kubernetes/kube-deploy/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kube-deploy/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kube-deploy/events","assignees_url":"https://api.github.com/repos/kubernetes/kube-deploy/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kube-deploy/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kube-deploy/tags","blobs_url":"https://api.github.com/repos/kubernetes/kube-deploy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kube-deploy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kube-deploy/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kube-deploy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kube-deploy/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kube-deploy/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kube-deploy/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kube-deploy/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kube-deploy/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kube-deploy/subscription","commits_url":"https://api.github.com/repos/kubernetes/kube-deploy/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kube-deploy/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kube-deploy/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kube-deploy/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kube-deploy/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kube-deploy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kube-deploy/merges","archive_url":"https://api.github.com/repos/kubernetes/kube-deploy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kube-deploy/downloads","issues_url":"https://api.github.com/repos/kubernetes/kube-deploy/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kube-deploy/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kube-deploy/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kube-deploy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kube-deploy/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kube-deploy/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kube-deploy/deployments","created_at":"2016-03-28T18:05:52Z","updated_at":"2018-03-13T22:49:03Z","pushed_at":"2018-03-14T17:38:08Z","git_url":"git://github.com/kubernetes/kube-deploy.git","ssh_url":"git@github.com:kubernetes/kube-deploy.git","clone_url":"https://github.com/kubernetes/kube-deploy.git","svn_url":"https://github.com/kubernetes/kube-deploy","homepage":null,"size":128497,"stargazers_count":430,"watchers_count":430,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":200,"mirror_url":null,"archived":false,"open_issues_count":89,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":200,"open_issues":89,"watchers":430,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kube-deploy/pulls/644"},"html":{"href":"https://github.com/kubernetes/kube-deploy/pull/644"},"issue":{"href":"https://api.github.com/repos/kubernetes/kube-deploy/issues/644"},"comments":{"href":"https://api.github.com/repos/kubernetes/kube-deploy/issues/644/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kube-deploy/pulls/644/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kube-deploy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kube-deploy/pulls/644/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kube-deploy/statuses/fbd6836517c00563210d91b4dfc220ff1ba080b6"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":16,"deletions":16,"changed_files":7}}
{"actor":{"display_login":"k8s-ci-robot"}}