{"action":"closed","number":305,"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-ha/pulls/305","id":174911583,"html_url":"https://github.com/crowbar/crowbar-ha/pull/305","diff_url":"https://github.com/crowbar/crowbar-ha/pull/305.diff","patch_url":"https://github.com/crowbar/crowbar-ha/pull/305.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-ha/issues/305","number":305,"state":"closed","locked":false,"title":"Update corosync configuration correctly and in time when adding a new cluster node","user":{"login":"jsuchome","id":910000,"avatar_url":"https://avatars2.githubusercontent.com/u/910000?v=4","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false},"body":"When a new node is added to the cluster, waiting for corosync reload after the end of chef-client run (:delayed action) is too late.\r\n\r\nWith current implementation of pacemaker sync marks, crm_attribute calls are used and they fail when corosync does not have the full information about all its nodes. So we must somehow extend the first synchronization that happens before the sync marks mechanism is used.\r\n\r\n\r\n~Alternative solution to https://github.com/crowbar/crowbar-ha/pull/303 , this one looks cleaner~\r\n\r\nAlso required for adding cluster node: https://github.com/crowbar/crowbar-openstack/pull/1583","created_at":"2018-03-14T10:30:06Z","updated_at":"2018-04-11T14:16:10Z","closed_at":"2018-04-11T14:16:10Z","merged_at":"2018-04-11T14:16:09Z","merge_commit_sha":"ca362883b27f4a17c6ff353273578fa39afe5cda","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":711257944,"url":"https://api.github.com/repos/crowbar/crowbar-ha/labels/needs%20backport%20to%20SOC7","name":"needs backport to SOC7","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-ha/pulls/305/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-ha/pulls/305/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-ha/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-ha/issues/305/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-ha/statuses/6ef69965f92cae6556ce846017cde16b937a8640","head":{"label":"jsuchome:cluster-change","ref":"cluster-change","sha":"6ef69965f92cae6556ce846017cde16b937a8640","user":{"login":"jsuchome","id":910000,"avatar_url":"https://avatars2.githubusercontent.com/u/910000?v=4","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false},"repo":{"id":54585843,"name":"crowbar-ha","full_name":"jsuchome/crowbar-ha","owner":{"login":"jsuchome","id":910000,"avatar_url":"https://avatars2.githubusercontent.com/u/910000?v=4","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsuchome/crowbar-ha","description":"HA deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/jsuchome/crowbar-ha","forks_url":"https://api.github.com/repos/jsuchome/crowbar-ha/forks","keys_url":"https://api.github.com/repos/jsuchome/crowbar-ha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsuchome/crowbar-ha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsuchome/crowbar-ha/teams","hooks_url":"https://api.github.com/repos/jsuchome/crowbar-ha/hooks","issue_events_url":"https://api.github.com/repos/jsuchome/crowbar-ha/issues/events{/number}","events_url":"https://api.github.com/repos/jsuchome/crowbar-ha/events","assignees_url":"https://api.github.com/repos/jsuchome/crowbar-ha/assignees{/user}","branches_url":"https://api.github.com/repos/jsuchome/crowbar-ha/branches{/branch}","tags_url":"https://api.github.com/repos/jsuchome/crowbar-ha/tags","blobs_url":"https://api.github.com/repos/jsuchome/crowbar-ha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsuchome/crowbar-ha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsuchome/crowbar-ha/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsuchome/crowbar-ha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsuchome/crowbar-ha/statuses/{sha}","languages_url":"https://api.github.com/repos/jsuchome/crowbar-ha/languages","stargazers_url":"https://api.github.com/repos/jsuchome/crowbar-ha/stargazers","contributors_url":"https://api.github.com/repos/jsuchome/crowbar-ha/contributors","subscribers_url":"https://api.github.com/repos/jsuchome/crowbar-ha/subscribers","subscription_url":"https://api.github.com/repos/jsuchome/crowbar-ha/subscription","commits_url":"https://api.github.com/repos/jsuchome/crowbar-ha/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsuchome/crowbar-ha/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsuchome/crowbar-ha/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsuchome/crowbar-ha/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsuchome/crowbar-ha/contents/{+path}","compare_url":"https://api.github.com/repos/jsuchome/crowbar-ha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsuchome/crowbar-ha/merges","archive_url":"https://api.github.com/repos/jsuchome/crowbar-ha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsuchome/crowbar-ha/downloads","issues_url":"https://api.github.com/repos/jsuchome/crowbar-ha/issues{/number}","pulls_url":"https://api.github.com/repos/jsuchome/crowbar-ha/pulls{/number}","milestones_url":"https://api.github.com/repos/jsuchome/crowbar-ha/milestones{/number}","notifications_url":"https://api.github.com/repos/jsuchome/crowbar-ha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsuchome/crowbar-ha/labels{/name}","releases_url":"https://api.github.com/repos/jsuchome/crowbar-ha/releases{/id}","deployments_url":"https://api.github.com/repos/jsuchome/crowbar-ha/deployments","created_at":"2016-03-23T19:02:47Z","updated_at":"2016-03-23T19:02:48Z","pushed_at":"2018-04-11T06:04:20Z","git_url":"git://github.com/jsuchome/crowbar-ha.git","ssh_url":"git@github.com:jsuchome/crowbar-ha.git","clone_url":"https://github.com/jsuchome/crowbar-ha.git","svn_url":"https://github.com/jsuchome/crowbar-ha","homepage":"","size":1554,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"09c9f4608cf759f80bec235879f9f7ff739b6231","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars2.githubusercontent.com/u/2910205?v=4","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39006836,"name":"crowbar-ha","full_name":"crowbar/crowbar-ha","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars2.githubusercontent.com/u/2910205?v=4","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-ha","description":"HA deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-ha","forks_url":"https://api.github.com/repos/crowbar/crowbar-ha/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-ha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-ha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-ha/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-ha/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-ha/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-ha/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-ha/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-ha/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-ha/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-ha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-ha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-ha/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-ha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-ha/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-ha/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-ha/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-ha/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-ha/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-ha/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-ha/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-ha/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-ha/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-ha/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-ha/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-ha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-ha/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-ha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-ha/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-ha/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-ha/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-ha/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-ha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-ha/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-ha/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-ha/deployments","created_at":"2015-07-13T10:53:43Z","updated_at":"2018-03-29T14:24:36Z","pushed_at":"2018-04-11T14:16:09Z","git_url":"git://github.com/crowbar/crowbar-ha.git","ssh_url":"git@github.com:crowbar/crowbar-ha.git","clone_url":"https://github.com/crowbar/crowbar-ha.git","svn_url":"https://github.com/crowbar/crowbar-ha","homepage":"","size":1636,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":15,"license":null,"forks":36,"open_issues":15,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-ha/pulls/305"},"html":{"href":"https://github.com/crowbar/crowbar-ha/pull/305"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-ha/issues/305"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-ha/issues/305/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-ha/pulls/305/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-ha/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-ha/pulls/305/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-ha/statuses/6ef69965f92cae6556ce846017cde16b937a8640"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jsuchome","id":910000,"avatar_url":"https://avatars2.githubusercontent.com/u/910000?v=4","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false},"comments":3,"review_comments":17,"maintainer_can_modify":false,"commits":2,"additions":45,"deletions":4,"changed_files":4}}
{"actor":{"display_login":"jsuchome"}}