{"action":"opened","number":643,"pull_request":{"url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/643","id":207716021,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NzE2MDIx","html_url":"https://github.com/Caltech-IPAC/firefly/pull/643","diff_url":"https://github.com/Caltech-IPAC/firefly/pull/643.diff","patch_url":"https://github.com/Caltech-IPAC/firefly/pull/643.patch","issue_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/643","number":643,"state":"open","locked":false,"title":"IRSA-2067: FileInfoProcessor need to take into consideration login status when caching","user":{"login":"loitly","id":11449642,"node_id":"MDQ6VXNlcjExNDQ5NjQy","avatar_url":"https://avatars2.githubusercontent.com/u/11449642?v=4","gravatar_id":"","url":"https://api.github.com/users/loitly","html_url":"https://github.com/loitly","followers_url":"https://api.github.com/users/loitly/followers","following_url":"https://api.github.com/users/loitly/following{/other_user}","gists_url":"https://api.github.com/users/loitly/gists{/gist_id}","starred_url":"https://api.github.com/users/loitly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loitly/subscriptions","organizations_url":"https://api.github.com/users/loitly/orgs","repos_url":"https://api.github.com/users/loitly/repos","events_url":"https://api.github.com/users/loitly/events{/privacy}","received_events_url":"https://api.github.com/users/loitly/received_events","type":"User","site_admin":false},"body":"https://jira.ipac.caltech.edu/browse/IRSA-2067\r\n\r\nTo test, using irsadev Gator, download a light curve table.\r\n-> login as someone with ztf access -> click example link -> To Time Series Tool -> Download Light Curve Table\r\n\r\nGoto https://irsawebdev9.ipac.caltech.edu/irsa-2067/irsaviewer/timeseries\r\nYou should be logged in as the same user.\r\n-> upload previously downloaded file -> select ztf -> upload \r\n-> navigate through table rows to load protected images -> logout\r\n-> as guest user -> upload same file -> select ztf -> upload \r\nthe images are no longer loading because they are protected and cannot be view by user without privileges\r\n\r\nDoing the same test in IRSA ops will reveal the security breach.\r\n\r\n@robyww, when you have time next week, it would be nice if you can take a long at the code changes to ensure that it does not impact anything else.\r\n\r\nAlso, you may want to take a look at the current implementation of edu.caltech.ipac.visualize.net.AnyUrlParams#getUniqueString\r\nIt's used as a cache key as well as filename.  When favoring for a shorter filename, it deceases the uniqueness of the cache key.","created_at":"2018-08-10T20:35:42Z","updated_at":"2018-08-10T20:35:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"loitly","id":11449642,"node_id":"MDQ6VXNlcjExNDQ5NjQy","avatar_url":"https://avatars2.githubusercontent.com/u/11449642?v=4","gravatar_id":"","url":"https://api.github.com/users/loitly","html_url":"https://github.com/loitly","followers_url":"https://api.github.com/users/loitly/followers","following_url":"https://api.github.com/users/loitly/following{/other_user}","gists_url":"https://api.github.com/users/loitly/gists{/gist_id}","starred_url":"https://api.github.com/users/loitly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loitly/subscriptions","organizations_url":"https://api.github.com/users/loitly/orgs","repos_url":"https://api.github.com/users/loitly/repos","events_url":"https://api.github.com/users/loitly/events{/privacy}","received_events_url":"https://api.github.com/users/loitly/received_events","type":"User","site_admin":false},"assignees":[{"login":"loitly","id":11449642,"node_id":"MDQ6VXNlcjExNDQ5NjQy","avatar_url":"https://avatars2.githubusercontent.com/u/11449642?v=4","gravatar_id":"","url":"https://api.github.com/users/loitly","html_url":"https://github.com/loitly","followers_url":"https://api.github.com/users/loitly/followers","following_url":"https://api.github.com/users/loitly/following{/other_user}","gists_url":"https://api.github.com/users/loitly/gists{/gist_id}","starred_url":"https://api.github.com/users/loitly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loitly/subscriptions","organizations_url":"https://api.github.com/users/loitly/orgs","repos_url":"https://api.github.com/users/loitly/repos","events_url":"https://api.github.com/users/loitly/events{/privacy}","received_events_url":"https://api.github.com/users/loitly/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/643/commits","review_comments_url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/643/comments","review_comment_url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/643/comments","statuses_url":"https://api.github.com/repos/Caltech-IPAC/firefly/statuses/2cd1ad5fe93ecd70b564c91f0ee23a54e8150a95","head":{"label":"Caltech-IPAC:IRSA-2067_fileinfo_cache_login","ref":"IRSA-2067_fileinfo_cache_login","sha":"2cd1ad5fe93ecd70b564c91f0ee23a54e8150a95","user":{"login":"Caltech-IPAC","id":9708378,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MDgzNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/9708378?v=4","gravatar_id":"","url":"https://api.github.com/users/Caltech-IPAC","html_url":"https://github.com/Caltech-IPAC","followers_url":"https://api.github.com/users/Caltech-IPAC/followers","following_url":"https://api.github.com/users/Caltech-IPAC/following{/other_user}","gists_url":"https://api.github.com/users/Caltech-IPAC/gists{/gist_id}","starred_url":"https://api.github.com/users/Caltech-IPAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caltech-IPAC/subscriptions","organizations_url":"https://api.github.com/users/Caltech-IPAC/orgs","repos_url":"https://api.github.com/users/Caltech-IPAC/repos","events_url":"https://api.github.com/users/Caltech-IPAC/events{/privacy}","received_events_url":"https://api.github.com/users/Caltech-IPAC/received_events","type":"Organization","site_admin":false},"repo":{"id":33508214,"node_id":"MDEwOlJlcG9zaXRvcnkzMzUwODIxNA==","name":"firefly","full_name":"Caltech-IPAC/firefly","owner":{"login":"Caltech-IPAC","id":9708378,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MDgzNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/9708378?v=4","gravatar_id":"","url":"https://api.github.com/users/Caltech-IPAC","html_url":"https://github.com/Caltech-IPAC","followers_url":"https://api.github.com/users/Caltech-IPAC/followers","following_url":"https://api.github.com/users/Caltech-IPAC/following{/other_user}","gists_url":"https://api.github.com/users/Caltech-IPAC/gists{/gist_id}","starred_url":"https://api.github.com/users/Caltech-IPAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caltech-IPAC/subscriptions","organizations_url":"https://api.github.com/users/Caltech-IPAC/orgs","repos_url":"https://api.github.com/users/Caltech-IPAC/repos","events_url":"https://api.github.com/users/Caltech-IPAC/events{/privacy}","received_events_url":"https://api.github.com/users/Caltech-IPAC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Caltech-IPAC/firefly","description":"IPAC Firefly ","fork":false,"url":"https://api.github.com/repos/Caltech-IPAC/firefly","forks_url":"https://api.github.com/repos/Caltech-IPAC/firefly/forks","keys_url":"https://api.github.com/repos/Caltech-IPAC/firefly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Caltech-IPAC/firefly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Caltech-IPAC/firefly/teams","hooks_url":"https://api.github.com/repos/Caltech-IPAC/firefly/hooks","issue_events_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/events{/number}","events_url":"https://api.github.com/repos/Caltech-IPAC/firefly/events","assignees_url":"https://api.github.com/repos/Caltech-IPAC/firefly/assignees{/user}","branches_url":"https://api.github.com/repos/Caltech-IPAC/firefly/branches{/branch}","tags_url":"https://api.github.com/repos/Caltech-IPAC/firefly/tags","blobs_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/refs{/sha}","trees_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Caltech-IPAC/firefly/statuses/{sha}","languages_url":"https://api.github.com/repos/Caltech-IPAC/firefly/languages","stargazers_url":"https://api.github.com/repos/Caltech-IPAC/firefly/stargazers","contributors_url":"https://api.github.com/repos/Caltech-IPAC/firefly/contributors","subscribers_url":"https://api.github.com/repos/Caltech-IPAC/firefly/subscribers","subscription_url":"https://api.github.com/repos/Caltech-IPAC/firefly/subscription","commits_url":"https://api.github.com/repos/Caltech-IPAC/firefly/commits{/sha}","git_commits_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/commits{/sha}","comments_url":"https://api.github.com/repos/Caltech-IPAC/firefly/comments{/number}","issue_comment_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/comments{/number}","contents_url":"https://api.github.com/repos/Caltech-IPAC/firefly/contents/{+path}","compare_url":"https://api.github.com/repos/Caltech-IPAC/firefly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Caltech-IPAC/firefly/merges","archive_url":"https://api.github.com/repos/Caltech-IPAC/firefly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Caltech-IPAC/firefly/downloads","issues_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues{/number}","pulls_url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls{/number}","milestones_url":"https://api.github.com/repos/Caltech-IPAC/firefly/milestones{/number}","notifications_url":"https://api.github.com/repos/Caltech-IPAC/firefly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Caltech-IPAC/firefly/labels{/name}","releases_url":"https://api.github.com/repos/Caltech-IPAC/firefly/releases{/id}","deployments_url":"https://api.github.com/repos/Caltech-IPAC/firefly/deployments","created_at":"2015-04-06T22:03:13Z","updated_at":"2018-08-10T18:38:48Z","pushed_at":"2018-08-10T20:13:18Z","git_url":"git://github.com/Caltech-IPAC/firefly.git","ssh_url":"git@github.com:Caltech-IPAC/firefly.git","clone_url":"https://github.com/Caltech-IPAC/firefly.git","svn_url":"https://github.com/Caltech-IPAC/firefly","homepage":"","size":166945,"stargazers_count":10,"watchers_count":10,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":6,"watchers":10,"default_branch":"dev"}},"base":{"label":"Caltech-IPAC:ops","ref":"ops","sha":"c1463cb4449c8dc40ff7587c6555edfffb489925","user":{"login":"Caltech-IPAC","id":9708378,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MDgzNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/9708378?v=4","gravatar_id":"","url":"https://api.github.com/users/Caltech-IPAC","html_url":"https://github.com/Caltech-IPAC","followers_url":"https://api.github.com/users/Caltech-IPAC/followers","following_url":"https://api.github.com/users/Caltech-IPAC/following{/other_user}","gists_url":"https://api.github.com/users/Caltech-IPAC/gists{/gist_id}","starred_url":"https://api.github.com/users/Caltech-IPAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caltech-IPAC/subscriptions","organizations_url":"https://api.github.com/users/Caltech-IPAC/orgs","repos_url":"https://api.github.com/users/Caltech-IPAC/repos","events_url":"https://api.github.com/users/Caltech-IPAC/events{/privacy}","received_events_url":"https://api.github.com/users/Caltech-IPAC/received_events","type":"Organization","site_admin":false},"repo":{"id":33508214,"node_id":"MDEwOlJlcG9zaXRvcnkzMzUwODIxNA==","name":"firefly","full_name":"Caltech-IPAC/firefly","owner":{"login":"Caltech-IPAC","id":9708378,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MDgzNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/9708378?v=4","gravatar_id":"","url":"https://api.github.com/users/Caltech-IPAC","html_url":"https://github.com/Caltech-IPAC","followers_url":"https://api.github.com/users/Caltech-IPAC/followers","following_url":"https://api.github.com/users/Caltech-IPAC/following{/other_user}","gists_url":"https://api.github.com/users/Caltech-IPAC/gists{/gist_id}","starred_url":"https://api.github.com/users/Caltech-IPAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caltech-IPAC/subscriptions","organizations_url":"https://api.github.com/users/Caltech-IPAC/orgs","repos_url":"https://api.github.com/users/Caltech-IPAC/repos","events_url":"https://api.github.com/users/Caltech-IPAC/events{/privacy}","received_events_url":"https://api.github.com/users/Caltech-IPAC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Caltech-IPAC/firefly","description":"IPAC Firefly ","fork":false,"url":"https://api.github.com/repos/Caltech-IPAC/firefly","forks_url":"https://api.github.com/repos/Caltech-IPAC/firefly/forks","keys_url":"https://api.github.com/repos/Caltech-IPAC/firefly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Caltech-IPAC/firefly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Caltech-IPAC/firefly/teams","hooks_url":"https://api.github.com/repos/Caltech-IPAC/firefly/hooks","issue_events_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/events{/number}","events_url":"https://api.github.com/repos/Caltech-IPAC/firefly/events","assignees_url":"https://api.github.com/repos/Caltech-IPAC/firefly/assignees{/user}","branches_url":"https://api.github.com/repos/Caltech-IPAC/firefly/branches{/branch}","tags_url":"https://api.github.com/repos/Caltech-IPAC/firefly/tags","blobs_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/refs{/sha}","trees_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Caltech-IPAC/firefly/statuses/{sha}","languages_url":"https://api.github.com/repos/Caltech-IPAC/firefly/languages","stargazers_url":"https://api.github.com/repos/Caltech-IPAC/firefly/stargazers","contributors_url":"https://api.github.com/repos/Caltech-IPAC/firefly/contributors","subscribers_url":"https://api.github.com/repos/Caltech-IPAC/firefly/subscribers","subscription_url":"https://api.github.com/repos/Caltech-IPAC/firefly/subscription","commits_url":"https://api.github.com/repos/Caltech-IPAC/firefly/commits{/sha}","git_commits_url":"https://api.github.com/repos/Caltech-IPAC/firefly/git/commits{/sha}","comments_url":"https://api.github.com/repos/Caltech-IPAC/firefly/comments{/number}","issue_comment_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/comments{/number}","contents_url":"https://api.github.com/repos/Caltech-IPAC/firefly/contents/{+path}","compare_url":"https://api.github.com/repos/Caltech-IPAC/firefly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Caltech-IPAC/firefly/merges","archive_url":"https://api.github.com/repos/Caltech-IPAC/firefly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Caltech-IPAC/firefly/downloads","issues_url":"https://api.github.com/repos/Caltech-IPAC/firefly/issues{/number}","pulls_url":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls{/number}","milestones_url":"https://api.github.com/repos/Caltech-IPAC/firefly/milestones{/number}","notifications_url":"https://api.github.com/repos/Caltech-IPAC/firefly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Caltech-IPAC/firefly/labels{/name}","releases_url":"https://api.github.com/repos/Caltech-IPAC/firefly/releases{/id}","deployments_url":"https://api.github.com/repos/Caltech-IPAC/firefly/deployments","created_at":"2015-04-06T22:03:13Z","updated_at":"2018-08-10T18:38:48Z","pushed_at":"2018-08-10T20:13:18Z","git_url":"git://github.com/Caltech-IPAC/firefly.git","ssh_url":"git@github.com:Caltech-IPAC/firefly.git","clone_url":"https://github.com/Caltech-IPAC/firefly.git","svn_url":"https://github.com/Caltech-IPAC/firefly","homepage":"","size":166945,"stargazers_count":10,"watchers_count":10,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":6,"watchers":10,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/643"},"html":{"href":"https://github.com/Caltech-IPAC/firefly/pull/643"},"issue":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/643"},"comments":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/issues/643/comments"},"review_comments":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/643/comments"},"review_comment":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/pulls/643/commits"},"statuses":{"href":"https://api.github.com/repos/Caltech-IPAC/firefly/statuses/2cd1ad5fe93ecd70b564c91f0ee23a54e8150a95"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":13,"deletions":4,"changed_files":4}}
{"actor":{"display_login":"loitly"}}