{"action":"created","comment":{"url":"https://api.github.com/repos/xetys/hetzner-kube/pulls/comments/236563606","pull_request_review_id":178659724,"id":236563606,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjU2MzYwNg==","diff_hunk":"@@ -51,8 +51,8 @@ func validateAddonSubCommand(cmd *cobra.Command, args []string) error {\n \tif idx == -1 {\n \t\treturn fmt.Errorf(\"cluster '%s' not found\", name)\n \t}\n-\tif len(args) != 1 {\n-\t\treturn errors.New(\"exactly one argument expected\")\n+\tif len(args) < 1 {","path":"cmd/cluster_addon.go","position":6,"original_position":6,"commit_id":"7b764438912bfab2c7998d98262e86afb7521e60","original_commit_id":"7b764438912bfab2c7998d98262e86afb7521e60","user":{"login":"mavimo","id":43941,"node_id":"MDQ6VXNlcjQzOTQx","avatar_url":"https://avatars0.githubusercontent.com/u/43941?v=4","gravatar_id":"","url":"https://api.github.com/users/mavimo","html_url":"https://github.com/mavimo","followers_url":"https://api.github.com/users/mavimo/followers","following_url":"https://api.github.com/users/mavimo/following{/other_user}","gists_url":"https://api.github.com/users/mavimo/gists{/gist_id}","starred_url":"https://api.github.com/users/mavimo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavimo/subscriptions","organizations_url":"https://api.github.com/users/mavimo/orgs","repos_url":"https://api.github.com/users/mavimo/repos","events_url":"https://api.github.com/users/mavimo/events{/privacy}","received_events_url":"https://api.github.com/users/mavimo/received_events","type":"User","site_admin":false},"body":"Right, maybe we should add a new method `ArgsValidation` to the `Addon` interface and delegate each plugin to validate data they need (I mean in a different PR), WDYT?","created_at":"2018-11-27T08:41:13Z","updated_at":"2018-11-27T08:41:13Z","html_url":"https://github.com/xetys/hetzner-kube/pull/229#discussion_r236563606","pull_request_url":"https://api.github.com/repos/xetys/hetzner-kube/pulls/229","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/xetys/hetzner-kube/pulls/comments/236563606"},"html":{"href":"https://github.com/xetys/hetzner-kube/pull/229#discussion_r236563606"},"pull_request":{"href":"https://api.github.com/repos/xetys/hetzner-kube/pulls/229"}},"in_reply_to_id":236426067},"pull_request":{"url":"https://api.github.com/repos/xetys/hetzner-kube/pulls/229","id":232106975,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMTA2OTc1","html_url":"https://github.com/xetys/hetzner-kube/pull/229","diff_url":"https://github.com/xetys/hetzner-kube/pull/229.diff","patch_url":"https://github.com/xetys/hetzner-kube/pull/229.patch","issue_url":"https://api.github.com/repos/xetys/hetzner-kube/issues/229","number":229,"state":"open","locked":false,"title":"Script Runner addon","user":{"login":"gadelkareem","id":1441127,"node_id":"MDQ6VXNlcjE0NDExMjc=","avatar_url":"https://avatars0.githubusercontent.com/u/1441127?v=4","gravatar_id":"","url":"https://api.github.com/users/gadelkareem","html_url":"https://github.com/gadelkareem","followers_url":"https://api.github.com/users/gadelkareem/followers","following_url":"https://api.github.com/users/gadelkareem/following{/other_user}","gists_url":"https://api.github.com/users/gadelkareem/gists{/gist_id}","starred_url":"https://api.github.com/users/gadelkareem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gadelkareem/subscriptions","organizations_url":"https://api.github.com/users/gadelkareem/orgs","repos_url":"https://api.github.com/users/gadelkareem/repos","events_url":"https://api.github.com/users/gadelkareem/events{/privacy}","received_events_url":"https://api.github.com/users/gadelkareem/received_events","type":"User","site_admin":false},"body":"Script Runner makes it easy to run a bash script on all your k8s nodes with one command.\r\n```\r\nhetzner-kube cluster addon install --name demo script-runner /path/to/script.sh \r\n```\r\n","created_at":"2018-11-19T20:48:21Z","updated_at":"2018-11-27T08:41:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e9083a0726f932a869b87ebe50856c0feb4245e","assignee":{"login":"gadelkareem","id":1441127,"node_id":"MDQ6VXNlcjE0NDExMjc=","avatar_url":"https://avatars0.githubusercontent.com/u/1441127?v=4","gravatar_id":"","url":"https://api.github.com/users/gadelkareem","html_url":"https://github.com/gadelkareem","followers_url":"https://api.github.com/users/gadelkareem/followers","following_url":"https://api.github.com/users/gadelkareem/following{/other_user}","gists_url":"https://api.github.com/users/gadelkareem/gists{/gist_id}","starred_url":"https://api.github.com/users/gadelkareem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gadelkareem/subscriptions","organizations_url":"https://api.github.com/users/gadelkareem/orgs","repos_url":"https://api.github.com/users/gadelkareem/repos","events_url":"https://api.github.com/users/gadelkareem/events{/privacy}","received_events_url":"https://api.github.com/users/gadelkareem/received_events","type":"User","site_admin":false},"assignees":[{"login":"gadelkareem","id":1441127,"node_id":"MDQ6VXNlcjE0NDExMjc=","avatar_url":"https://avatars0.githubusercontent.com/u/1441127?v=4","gravatar_id":"","url":"https://api.github.com/users/gadelkareem","html_url":"https://github.com/gadelkareem","followers_url":"https://api.github.com/users/gadelkareem/followers","following_url":"https://api.github.com/users/gadelkareem/following{/other_user}","gists_url":"https://api.github.com/users/gadelkareem/gists{/gist_id}","starred_url":"https://api.github.com/users/gadelkareem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gadelkareem/subscriptions","organizations_url":"https://api.github.com/users/gadelkareem/orgs","repos_url":"https://api.github.com/users/gadelkareem/repos","events_url":"https://api.github.com/users/gadelkareem/events{/privacy}","received_events_url":"https://api.github.com/users/gadelkareem/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xetys/hetzner-kube/pulls/229/commits","review_comments_url":"https://api.github.com/repos/xetys/hetzner-kube/pulls/229/comments","review_comment_url":"https://api.github.com/repos/xetys/hetzner-kube/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xetys/hetzner-kube/issues/229/comments","statuses_url":"https://api.github.com/repos/xetys/hetzner-kube/statuses/7b764438912bfab2c7998d98262e86afb7521e60","head":{"label":"gadelkareem:feature/script-runner","ref":"feature/script-runner","sha":"7b764438912bfab2c7998d98262e86afb7521e60","user":{"login":"gadelkareem","id":1441127,"node_id":"MDQ6VXNlcjE0NDExMjc=","avatar_url":"https://avatars0.githubusercontent.com/u/1441127?v=4","gravatar_id":"","url":"https://api.github.com/users/gadelkareem","html_url":"https://github.com/gadelkareem","followers_url":"https://api.github.com/users/gadelkareem/followers","following_url":"https://api.github.com/users/gadelkareem/following{/other_user}","gists_url":"https://api.github.com/users/gadelkareem/gists{/gist_id}","starred_url":"https://api.github.com/users/gadelkareem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gadelkareem/subscriptions","organizations_url":"https://api.github.com/users/gadelkareem/orgs","repos_url":"https://api.github.com/users/gadelkareem/repos","events_url":"https://api.github.com/users/gadelkareem/events{/privacy}","received_events_url":"https://api.github.com/users/gadelkareem/received_events","type":"User","site_admin":false},"repo":{"id":158279798,"node_id":"MDEwOlJlcG9zaXRvcnkxNTgyNzk3OTg=","name":"hetzner-kube","full_name":"gadelkareem/hetzner-kube","private":false,"owner":{"login":"gadelkareem","id":1441127,"node_id":"MDQ6VXNlcjE0NDExMjc=","avatar_url":"https://avatars0.githubusercontent.com/u/1441127?v=4","gravatar_id":"","url":"https://api.github.com/users/gadelkareem","html_url":"https://github.com/gadelkareem","followers_url":"https://api.github.com/users/gadelkareem/followers","following_url":"https://api.github.com/users/gadelkareem/following{/other_user}","gists_url":"https://api.github.com/users/gadelkareem/gists{/gist_id}","starred_url":"https://api.github.com/users/gadelkareem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gadelkareem/subscriptions","organizations_url":"https://api.github.com/users/gadelkareem/orgs","repos_url":"https://api.github.com/users/gadelkareem/repos","events_url":"https://api.github.com/users/gadelkareem/events{/privacy}","received_events_url":"https://api.github.com/users/gadelkareem/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gadelkareem/hetzner-kube","description":"A CLI tool for provisioning kubernetes clusters on Hetzner Cloud","fork":true,"url":"https://api.github.com/repos/gadelkareem/hetzner-kube","forks_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/forks","keys_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/teams","hooks_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/hooks","issue_events_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/issues/events{/number}","events_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/events","assignees_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/assignees{/user}","branches_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/branches{/branch}","tags_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/tags","blobs_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/git/refs{/sha}","trees_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/statuses/{sha}","languages_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/languages","stargazers_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/stargazers","contributors_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/contributors","subscribers_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/subscribers","subscription_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/subscription","commits_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/commits{/sha}","git_commits_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/git/commits{/sha}","comments_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/comments{/number}","issue_comment_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/issues/comments{/number}","contents_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/contents/{+path}","compare_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/merges","archive_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/downloads","issues_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/issues{/number}","pulls_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/pulls{/number}","milestones_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/milestones{/number}","notifications_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/labels{/name}","releases_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/releases{/id}","deployments_url":"https://api.github.com/repos/gadelkareem/hetzner-kube/deployments","created_at":"2018-11-19T19:37:28Z","updated_at":"2018-11-26T20:01:11Z","pushed_at":"2018-11-26T20:32:17Z","git_url":"git://github.com/gadelkareem/hetzner-kube.git","ssh_url":"git@github.com:gadelkareem/hetzner-kube.git","clone_url":"https://github.com/gadelkareem/hetzner-kube.git","svn_url":"https://github.com/gadelkareem/hetzner-kube","homepage":null,"size":12564,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xetys:master","ref":"master","sha":"4173c45e45e14f4ef4dbeba7d93c19bc3fef2984","user":{"login":"xetys","id":2758003,"node_id":"MDQ6VXNlcjI3NTgwMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/2758003?v=4","gravatar_id":"","url":"https://api.github.com/users/xetys","html_url":"https://github.com/xetys","followers_url":"https://api.github.com/users/xetys/followers","following_url":"https://api.github.com/users/xetys/following{/other_user}","gists_url":"https://api.github.com/users/xetys/gists{/gist_id}","starred_url":"https://api.github.com/users/xetys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xetys/subscriptions","organizations_url":"https://api.github.com/users/xetys/orgs","repos_url":"https://api.github.com/users/xetys/repos","events_url":"https://api.github.com/users/xetys/events{/privacy}","received_events_url":"https://api.github.com/users/xetys/received_events","type":"User","site_admin":false},"repo":{"id":118689988,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg2ODk5ODg=","name":"hetzner-kube","full_name":"xetys/hetzner-kube","private":false,"owner":{"login":"xetys","id":2758003,"node_id":"MDQ6VXNlcjI3NTgwMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/2758003?v=4","gravatar_id":"","url":"https://api.github.com/users/xetys","html_url":"https://github.com/xetys","followers_url":"https://api.github.com/users/xetys/followers","following_url":"https://api.github.com/users/xetys/following{/other_user}","gists_url":"https://api.github.com/users/xetys/gists{/gist_id}","starred_url":"https://api.github.com/users/xetys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xetys/subscriptions","organizations_url":"https://api.github.com/users/xetys/orgs","repos_url":"https://api.github.com/users/xetys/repos","events_url":"https://api.github.com/users/xetys/events{/privacy}","received_events_url":"https://api.github.com/users/xetys/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xetys/hetzner-kube","description":"A CLI tool for provisioning kubernetes clusters on Hetzner Cloud","fork":false,"url":"https://api.github.com/repos/xetys/hetzner-kube","forks_url":"https://api.github.com/repos/xetys/hetzner-kube/forks","keys_url":"https://api.github.com/repos/xetys/hetzner-kube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xetys/hetzner-kube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xetys/hetzner-kube/teams","hooks_url":"https://api.github.com/repos/xetys/hetzner-kube/hooks","issue_events_url":"https://api.github.com/repos/xetys/hetzner-kube/issues/events{/number}","events_url":"https://api.github.com/repos/xetys/hetzner-kube/events","assignees_url":"https://api.github.com/repos/xetys/hetzner-kube/assignees{/user}","branches_url":"https://api.github.com/repos/xetys/hetzner-kube/branches{/branch}","tags_url":"https://api.github.com/repos/xetys/hetzner-kube/tags","blobs_url":"https://api.github.com/repos/xetys/hetzner-kube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xetys/hetzner-kube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xetys/hetzner-kube/git/refs{/sha}","trees_url":"https://api.github.com/repos/xetys/hetzner-kube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xetys/hetzner-kube/statuses/{sha}","languages_url":"https://api.github.com/repos/xetys/hetzner-kube/languages","stargazers_url":"https://api.github.com/repos/xetys/hetzner-kube/stargazers","contributors_url":"https://api.github.com/repos/xetys/hetzner-kube/contributors","subscribers_url":"https://api.github.com/repos/xetys/hetzner-kube/subscribers","subscription_url":"https://api.github.com/repos/xetys/hetzner-kube/subscription","commits_url":"https://api.github.com/repos/xetys/hetzner-kube/commits{/sha}","git_commits_url":"https://api.github.com/repos/xetys/hetzner-kube/git/commits{/sha}","comments_url":"https://api.github.com/repos/xetys/hetzner-kube/comments{/number}","issue_comment_url":"https://api.github.com/repos/xetys/hetzner-kube/issues/comments{/number}","contents_url":"https://api.github.com/repos/xetys/hetzner-kube/contents/{+path}","compare_url":"https://api.github.com/repos/xetys/hetzner-kube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xetys/hetzner-kube/merges","archive_url":"https://api.github.com/repos/xetys/hetzner-kube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xetys/hetzner-kube/downloads","issues_url":"https://api.github.com/repos/xetys/hetzner-kube/issues{/number}","pulls_url":"https://api.github.com/repos/xetys/hetzner-kube/pulls{/number}","milestones_url":"https://api.github.com/repos/xetys/hetzner-kube/milestones{/number}","notifications_url":"https://api.github.com/repos/xetys/hetzner-kube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xetys/hetzner-kube/labels{/name}","releases_url":"https://api.github.com/repos/xetys/hetzner-kube/releases{/id}","deployments_url":"https://api.github.com/repos/xetys/hetzner-kube/deployments","created_at":"2018-01-24T00:43:37Z","updated_at":"2018-11-26T14:06:25Z","pushed_at":"2018-11-26T20:32:19Z","git_url":"git://github.com/xetys/hetzner-kube.git","ssh_url":"git@github.com:xetys/hetzner-kube.git","clone_url":"https://github.com/xetys/hetzner-kube.git","svn_url":"https://github.com/xetys/hetzner-kube","homepage":null,"size":12502,"stargazers_count":283,"watchers_count":283,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":52,"open_issues":62,"watchers":283,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xetys/hetzner-kube/pulls/229"},"html":{"href":"https://github.com/xetys/hetzner-kube/pull/229"},"issue":{"href":"https://api.github.com/repos/xetys/hetzner-kube/issues/229"},"comments":{"href":"https://api.github.com/repos/xetys/hetzner-kube/issues/229/comments"},"review_comments":{"href":"https://api.github.com/repos/xetys/hetzner-kube/pulls/229/comments"},"review_comment":{"href":"https://api.github.com/repos/xetys/hetzner-kube/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xetys/hetzner-kube/pulls/229/commits"},"statuses":{"href":"https://api.github.com/repos/xetys/hetzner-kube/statuses/7b764438912bfab2c7998d98262e86afb7521e60"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mavimo"}}