{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible/issues/41735","repository_url":"https://api.github.com/repos/ansible/ansible","labels_url":"https://api.github.com/repos/ansible/ansible/issues/41735/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/41735/comments","events_url":"https://api.github.com/repos/ansible/ansible/issues/41735/events","html_url":"https://github.com/ansible/ansible/pull/41735","id":334113480,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MTY3MjE5","number":41735,"title":"Added get_certificate module","user":{"login":"john-westcott-iv","id":32551173,"node_id":"MDQ6VXNlcjMyNTUxMTcz","avatar_url":"https://avatars0.githubusercontent.com/u/32551173?v=4","gravatar_id":"","url":"https://api.github.com/users/john-westcott-iv","html_url":"https://github.com/john-westcott-iv","followers_url":"https://api.github.com/users/john-westcott-iv/followers","following_url":"https://api.github.com/users/john-westcott-iv/following{/other_user}","gists_url":"https://api.github.com/users/john-westcott-iv/gists{/gist_id}","starred_url":"https://api.github.com/users/john-westcott-iv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-westcott-iv/subscriptions","organizations_url":"https://api.github.com/users/john-westcott-iv/orgs","repos_url":"https://api.github.com/users/john-westcott-iv/repos","events_url":"https://api.github.com/users/john-westcott-iv/events{/privacy}","received_events_url":"https://api.github.com/users/john-westcott-iv/received_events","type":"User","site_admin":false},"labels":[{"id":947190508,"node_id":"MDU6TGFiZWw5NDcxOTA1MDg=","url":"https://api.github.com/repos/ansible/ansible/labels/affects_2.7","name":"affects_2.7","color":"ededed","default":false},{"id":496359346,"node_id":"MDU6TGFiZWw0OTYzNTkzNDY=","url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":61436281,"node_id":"MDU6TGFiZWw2MTQzNjI4MQ==","url":"https://api.github.com/repos/ansible/ansible/labels/needs_revision","name":"needs_revision","color":"eb6450","default":false},{"id":473225334,"node_id":"MDU6TGFiZWw0NzMyMjUzMzQ=","url":"https://api.github.com/repos/ansible/ansible/labels/new_module","name":"new_module","color":"ededed","default":false},{"id":153577825,"node_id":"MDU6TGFiZWwxNTM1Nzc4MjU=","url":"https://api.github.com/repos/ansible/ansible/labels/new_plugin","name":"new_plugin","color":"bfe5bf","default":false},{"id":636327968,"node_id":"MDU6TGFiZWw2MzYzMjc5Njg=","url":"https://api.github.com/repos/ansible/ansible/labels/support:community","name":"support:community","color":"ededed","default":false},{"id":468273802,"node_id":"MDU6TGFiZWw0NjgyNzM4MDI=","url":"https://api.github.com/repos/ansible/ansible/labels/test","name":"test","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-20T14:45:46Z","updated_at":"2018-06-21T08:12:40Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/41735","html_url":"https://github.com/ansible/ansible/pull/41735","diff_url":"https://github.com/ansible/ansible/pull/41735.diff","patch_url":"https://github.com/ansible/ansible/pull/41735.patch"},"body":"##### SUMMARY\r\n<!--- Describe the change, including rationale and design decisions -->\r\nAdding new module which can pull a certificate from an SSL port.\r\n\r\n<!--- If you are fixing an existing issue, please include \"Fixes #nnn\" in your\r\ncommit message and your description; but you should still explain what\r\nthe change does.-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - New Module Pull Request\r\n \r\n##### COMPONENT NAME\r\n<!--- Name of the module, plugin, module or task -->\r\nget_certificate\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from \"ansible --version\" between quotes below -->\r\n```\r\nansible 2.4.3.0\r\n  config file = /Users/jowestco/GIT/ansible-mine/ansible.cfg\r\n  configured module search path = [u'/Users/jowestco/GIT/ansible-mine/lib/ansible/modules/crypto']\r\n  ansible python module location = /Users/jowestco/Library/Python/venvs/ansible-2.4.3/lib/python2.7/site-packages/ansible\r\n  executable location = /Users/jowestco/Library/Python/venvs/ansible-2.4.3/bin/ansible\r\n  python version = 2.7.10 (default, Oct  6 2017, 22:29:07) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.31)]\r\n```\r\n\r\n\r\n##### ADDITIONAL INFORMATION\r\n<!--- Include additional information to help people understand the change here.\r\nFor bugs that don't have a linked bug report, a step-by-step reproduction\r\nof the problem is helpful. -->\r\nMy client needed to pull information from a certificate during an ansible-playbook run. We couldn't find an existing module which would do this so we wrote one and are contributing it back.\r\n\r\n<!--- Paste verbatim command output below, e.g. before and after your change -->\r\n```\r\n\r\n```"},"comment":{"url":"https://api.github.com/repos/ansible/ansible/issues/comments/399015416","html_url":"https://github.com/ansible/ansible/pull/41735#issuecomment-399015416","issue_url":"https://api.github.com/repos/ansible/ansible/issues/41735","id":399015416,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTAxNTQxNg==","user":{"login":"Spredzy","id":1191411,"node_id":"MDQ6VXNlcjExOTE0MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1191411?v=4","gravatar_id":"","url":"https://api.github.com/users/Spredzy","html_url":"https://github.com/Spredzy","followers_url":"https://api.github.com/users/Spredzy/followers","following_url":"https://api.github.com/users/Spredzy/following{/other_user}","gists_url":"https://api.github.com/users/Spredzy/gists{/gist_id}","starred_url":"https://api.github.com/users/Spredzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spredzy/subscriptions","organizations_url":"https://api.github.com/users/Spredzy/orgs","repos_url":"https://api.github.com/users/Spredzy/repos","events_url":"https://api.github.com/users/Spredzy/events{/privacy}","received_events_url":"https://api.github.com/users/Spredzy/received_events","type":"User","site_admin":false},"created_at":"2018-06-21T08:12:40Z","updated_at":"2018-06-21T08:12:40Z","author_association":"CONTRIBUTOR","body":"@john-westcott-iv Thanks for submitting this PR. Let me know if you need help with ansiblebot comments, I'll be happy to hel you out.\r\n\r\nFew notes on the module itself:\r\n\r\n  * Could you make this module more exhaustive and returns more informations. Currently its only returning subject info via `get_subject()`. Many other info can be retrieved from a x509 object (issuer, has_expired(), validity start date, validity end date, extensions, serialnumber, digest, signature_algorithm, certificate version, ...). Could you add that to the result json returned ?\r\n \r\n * Could you add a parameter for one to specify `ca_certs` to the get_server_certificate() method ?\r\n\r\nAlso out of curiosity, could you let us know how do you sude this module in your workflow ? For what purpose ? So I can see how it can be used along side openssl_certificate with the assertonly provider."}}
{"actor":{"display_login":"Spredzy"}}