{"action":"created","comment":{"url":"https://api.github.com/repos/etcd-io/etcd/pulls/comments/228168255","pull_request_review_id":168375406,"id":228168255,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODE2ODI1NQ==","diff_hunk":"@@ -26,8 +26,58 @@ import (\n \t\"go.etcd.io/etcd/integration\"\n \t\"go.etcd.io/etcd/pkg/testutil\"\n \t\"google.golang.org/grpc\"\n+\t\"google.golang.org/grpc/codes\"\n+\t\"google.golang.org/grpc/status\"\n )\n \n+// TestServerGRPCKeepAliveTimeout tests ServerParameters keepalive ping on server-side that\n+// after having pinged for keepalive check, the server waits for a duration of Timeout and\n+// if no activity is seen even after that the connection is closed. The keepalive takes few\n+// seconds to get in impact so typically the the time it takes to close the connection is\n+// somewhat higher than specified Timeout value.\n+func TestServerGRPCKeepAliveTimeout(t *testing.T) {\n+\tdefer testutil.AfterTest(t)\n+\n+\tclus := integration.NewClusterV3(t, &integration.ClusterConfig{\n+\t\tSize:                  2,\n+\t\tGRPCKeepAliveInterval: time.Second,\n+\t\tGRPCKeepAliveTimeout:  time.Second,\n+\t})\n+\tdefer clus.Terminate(t)\n+\n+\teps := []string{clus.Members[0].GRPCAddr()}\n+\n+\tccfg := clientv3.Config{\n+\t\tEndpoints: []string{eps[0]},\n+\t}\n+\n+\tcli, err := clientv3.New(ccfg)\n+\tif err != nil {\n+\t\tt.Fatal(err)\n+\t}\n+\tdefer cli.Close()\n+\n+\tif _, err = clus.Client(1).Put(context.TODO(), \"foo\", \"bar\"); err != nil {\n+\t\tt.Fatal(err)\n+\t}\n+\tclus.Members[1].Blackhole()\n+\ttime.Sleep(10 * time.Second)","path":"clientv3/integration/black_hole_test.go","position":39,"original_position":39,"commit_id":"fdbaaa6a49c2e27eeeac39dcc335f141d5a59d26","original_commit_id":"fdbaaa6a49c2e27eeeac39dcc335f141d5a59d26","user":{"login":"spzala","id":6462877,"node_id":"MDQ6VXNlcjY0NjI4Nzc=","avatar_url":"https://avatars2.githubusercontent.com/u/6462877?v=4","gravatar_id":"","url":"https://api.github.com/users/spzala","html_url":"https://github.com/spzala","followers_url":"https://api.github.com/users/spzala/followers","following_url":"https://api.github.com/users/spzala/following{/other_user}","gists_url":"https://api.github.com/users/spzala/gists{/gist_id}","starred_url":"https://api.github.com/users/spzala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spzala/subscriptions","organizations_url":"https://api.github.com/users/spzala/orgs","repos_url":"https://api.github.com/users/spzala/repos","events_url":"https://api.github.com/users/spzala/events{/privacy}","received_events_url":"https://api.github.com/users/spzala/received_events","type":"User","site_admin":false},"body":"Sure, thanks! Yes I noticed that another travis job passed but this failed. It's known that gRPC requires extra time (as I have also commented as test doc) so keeping waiting to 10sec but reducing timeout. I tested it multiple times locally and it seems good, \r\n```\r\nStarting 'integration' pass at Thu Oct 25 08:59:54 EDT 2018\r\nRunning integration tests...\r\n=== RUN   TestServerGRPCKeepAliveTimeout\r\n--- PASS: TestServerGRPCKeepAliveTimeout (10.28s)\r\n=== RUN   TestServerGRPCKeepAliveTimeout\r\n--- PASS: TestServerGRPCKeepAliveTimeout (10.28s)\r\n=== RUN   TestServerGRPCKeepAliveTimeout\r\n--- PASS: TestServerGRPCKeepAliveTimeout (10.20s)\r\nPASS\r\nok  \tgo.etcd.io/etcd/clientv3/integration\t30.796s\r\nFinished 'integration' pass at Thu Oct 25 09:00:42 EDT 2018\r\n```","created_at":"2018-10-25T13:17:53Z","updated_at":"2018-10-25T13:17:53Z","html_url":"https://github.com/etcd-io/etcd/pull/10211#discussion_r228168255","pull_request_url":"https://api.github.com/repos/etcd-io/etcd/pulls/10211","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/etcd-io/etcd/pulls/comments/228168255"},"html":{"href":"https://github.com/etcd-io/etcd/pull/10211#discussion_r228168255"},"pull_request":{"href":"https://api.github.com/repos/etcd-io/etcd/pulls/10211"}},"in_reply_to_id":228067560},"pull_request":{"url":"https://api.github.com/repos/etcd-io/etcd/pulls/10211","id":225518412,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NTE4NDEy","html_url":"https://github.com/etcd-io/etcd/pull/10211","diff_url":"https://github.com/etcd-io/etcd/pull/10211.diff","patch_url":"https://github.com/etcd-io/etcd/pull/10211.patch","issue_url":"https://api.github.com/repos/etcd-io/etcd/issues/10211","number":10211,"state":"open","locked":false,"title":"ClientV3: Add integration test for server timeout","user":{"login":"spzala","id":6462877,"node_id":"MDQ6VXNlcjY0NjI4Nzc=","avatar_url":"https://avatars2.githubusercontent.com/u/6462877?v=4","gravatar_id":"","url":"https://api.github.com/users/spzala","html_url":"https://github.com/spzala","followers_url":"https://api.github.com/users/spzala/followers","following_url":"https://api.github.com/users/spzala/following{/other_user}","gists_url":"https://api.github.com/users/spzala/gists{/gist_id}","starred_url":"https://api.github.com/users/spzala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spzala/subscriptions","organizations_url":"https://api.github.com/users/spzala/orgs","repos_url":"https://api.github.com/users/spzala/repos","events_url":"https://api.github.com/users/spzala/events{/privacy}","received_events_url":"https://api.github.com/users/spzala/received_events","type":"User","site_admin":false},"body":"Add integration test for server timeout.\r\n\r\nPartially Fixes #8645\r\n","created_at":"2018-10-24T19:13:54Z","updated_at":"2018-10-25T13:17:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0152c2dc7dfec050b71a4ef3057e3108d29f8804","assignee":{"login":"gyuho","id":6799218,"node_id":"MDQ6VXNlcjY3OTkyMTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6799218?v=4","gravatar_id":"","url":"https://api.github.com/users/gyuho","html_url":"https://github.com/gyuho","followers_url":"https://api.github.com/users/gyuho/followers","following_url":"https://api.github.com/users/gyuho/following{/other_user}","gists_url":"https://api.github.com/users/gyuho/gists{/gist_id}","starred_url":"https://api.github.com/users/gyuho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyuho/subscriptions","organizations_url":"https://api.github.com/users/gyuho/orgs","repos_url":"https://api.github.com/users/gyuho/repos","events_url":"https://api.github.com/users/gyuho/events{/privacy}","received_events_url":"https://api.github.com/users/gyuho/received_events","type":"User","site_admin":false},"assignees":[{"login":"gyuho","id":6799218,"node_id":"MDQ6VXNlcjY3OTkyMTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6799218?v=4","gravatar_id":"","url":"https://api.github.com/users/gyuho","html_url":"https://github.com/gyuho","followers_url":"https://api.github.com/users/gyuho/followers","following_url":"https://api.github.com/users/gyuho/following{/other_user}","gists_url":"https://api.github.com/users/gyuho/gists{/gist_id}","starred_url":"https://api.github.com/users/gyuho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyuho/subscriptions","organizations_url":"https://api.github.com/users/gyuho/orgs","repos_url":"https://api.github.com/users/gyuho/repos","events_url":"https://api.github.com/users/gyuho/events{/privacy}","received_events_url":"https://api.github.com/users/gyuho/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"hexfusion","id":1249749,"node_id":"MDQ6VXNlcjEyNDk3NDk=","avatar_url":"https://avatars0.githubusercontent.com/u/1249749?v=4","gravatar_id":"","url":"https://api.github.com/users/hexfusion","html_url":"https://github.com/hexfusion","followers_url":"https://api.github.com/users/hexfusion/followers","following_url":"https://api.github.com/users/hexfusion/following{/other_user}","gists_url":"https://api.github.com/users/hexfusion/gists{/gist_id}","starred_url":"https://api.github.com/users/hexfusion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hexfusion/subscriptions","organizations_url":"https://api.github.com/users/hexfusion/orgs","repos_url":"https://api.github.com/users/hexfusion/repos","events_url":"https://api.github.com/users/hexfusion/events{/privacy}","received_events_url":"https://api.github.com/users/hexfusion/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1103752051,"node_id":"MDU6TGFiZWwxMTAzNzUyMDUx","url":"https://api.github.com/repos/etcd-io/etcd/labels/approved","name":"approved","color":"3647e2","default":false},{"id":1103752014,"node_id":"MDU6TGFiZWwxMTAzNzUyMDE0","url":"https://api.github.com/repos/etcd-io/etcd/labels/lgtm","name":"lgtm","color":"49f44c","default":false},{"id":1096793808,"node_id":"MDU6TGFiZWwxMDk2NzkzODA4","url":"https://api.github.com/repos/etcd-io/etcd/labels/size/M","name":"size/M","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/etcd-io/etcd/pulls/10211/commits","review_comments_url":"https://api.github.com/repos/etcd-io/etcd/pulls/10211/comments","review_comment_url":"https://api.github.com/repos/etcd-io/etcd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/etcd-io/etcd/issues/10211/comments","statuses_url":"https://api.github.com/repos/etcd-io/etcd/statuses/fdbaaa6a49c2e27eeeac39dcc335f141d5a59d26","head":{"label":"spzala:keepalivetest","ref":"keepalivetest","sha":"fdbaaa6a49c2e27eeeac39dcc335f141d5a59d26","user":{"login":"spzala","id":6462877,"node_id":"MDQ6VXNlcjY0NjI4Nzc=","avatar_url":"https://avatars2.githubusercontent.com/u/6462877?v=4","gravatar_id":"","url":"https://api.github.com/users/spzala","html_url":"https://github.com/spzala","followers_url":"https://api.github.com/users/spzala/followers","following_url":"https://api.github.com/users/spzala/following{/other_user}","gists_url":"https://api.github.com/users/spzala/gists{/gist_id}","starred_url":"https://api.github.com/users/spzala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spzala/subscriptions","organizations_url":"https://api.github.com/users/spzala/orgs","repos_url":"https://api.github.com/users/spzala/repos","events_url":"https://api.github.com/users/spzala/events{/privacy}","received_events_url":"https://api.github.com/users/spzala/received_events","type":"User","site_admin":false},"repo":{"id":113404402,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM0MDQ0MDI=","name":"etcd","full_name":"spzala/etcd","private":false,"owner":{"login":"spzala","id":6462877,"node_id":"MDQ6VXNlcjY0NjI4Nzc=","avatar_url":"https://avatars2.githubusercontent.com/u/6462877?v=4","gravatar_id":"","url":"https://api.github.com/users/spzala","html_url":"https://github.com/spzala","followers_url":"https://api.github.com/users/spzala/followers","following_url":"https://api.github.com/users/spzala/following{/other_user}","gists_url":"https://api.github.com/users/spzala/gists{/gist_id}","starred_url":"https://api.github.com/users/spzala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spzala/subscriptions","organizations_url":"https://api.github.com/users/spzala/orgs","repos_url":"https://api.github.com/users/spzala/repos","events_url":"https://api.github.com/users/spzala/events{/privacy}","received_events_url":"https://api.github.com/users/spzala/received_events","type":"User","site_admin":false},"html_url":"https://github.com/spzala/etcd","description":"Distributed reliable key-value store for the most critical data of a distributed system","fork":true,"url":"https://api.github.com/repos/spzala/etcd","forks_url":"https://api.github.com/repos/spzala/etcd/forks","keys_url":"https://api.github.com/repos/spzala/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spzala/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spzala/etcd/teams","hooks_url":"https://api.github.com/repos/spzala/etcd/hooks","issue_events_url":"https://api.github.com/repos/spzala/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/spzala/etcd/events","assignees_url":"https://api.github.com/repos/spzala/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/spzala/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/spzala/etcd/tags","blobs_url":"https://api.github.com/repos/spzala/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spzala/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spzala/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/spzala/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spzala/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/spzala/etcd/languages","stargazers_url":"https://api.github.com/repos/spzala/etcd/stargazers","contributors_url":"https://api.github.com/repos/spzala/etcd/contributors","subscribers_url":"https://api.github.com/repos/spzala/etcd/subscribers","subscription_url":"https://api.github.com/repos/spzala/etcd/subscription","commits_url":"https://api.github.com/repos/spzala/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/spzala/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/spzala/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/spzala/etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/spzala/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/spzala/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spzala/etcd/merges","archive_url":"https://api.github.com/repos/spzala/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spzala/etcd/downloads","issues_url":"https://api.github.com/repos/spzala/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/spzala/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/spzala/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/spzala/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spzala/etcd/labels{/name}","releases_url":"https://api.github.com/repos/spzala/etcd/releases{/id}","deployments_url":"https://api.github.com/repos/spzala/etcd/deployments","created_at":"2017-12-07T04:53:29Z","updated_at":"2018-10-03T19:32:35Z","pushed_at":"2018-10-25T03:18:57Z","git_url":"git://github.com/spzala/etcd.git","ssh_url":"git@github.com:spzala/etcd.git","clone_url":"https://github.com/spzala/etcd.git","svn_url":"https://github.com/spzala/etcd","homepage":"https://coreos.com/etcd/docs/latest/","size":45352,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"etcd-io:master","ref":"master","sha":"86b933311d239aeba576fac32077e41157d328eb","user":{"login":"etcd-io","id":41972792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxOTcyNzky","avatar_url":"https://avatars3.githubusercontent.com/u/41972792?v=4","gravatar_id":"","url":"https://api.github.com/users/etcd-io","html_url":"https://github.com/etcd-io","followers_url":"https://api.github.com/users/etcd-io/followers","following_url":"https://api.github.com/users/etcd-io/following{/other_user}","gists_url":"https://api.github.com/users/etcd-io/gists{/gist_id}","starred_url":"https://api.github.com/users/etcd-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etcd-io/subscriptions","organizations_url":"https://api.github.com/users/etcd-io/orgs","repos_url":"https://api.github.com/users/etcd-io/repos","events_url":"https://api.github.com/users/etcd-io/events{/privacy}","received_events_url":"https://api.github.com/users/etcd-io/received_events","type":"Organization","site_admin":false},"repo":{"id":11225014,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIyNTAxNA==","name":"etcd","full_name":"etcd-io/etcd","private":false,"owner":{"login":"etcd-io","id":41972792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxOTcyNzky","avatar_url":"https://avatars3.githubusercontent.com/u/41972792?v=4","gravatar_id":"","url":"https://api.github.com/users/etcd-io","html_url":"https://github.com/etcd-io","followers_url":"https://api.github.com/users/etcd-io/followers","following_url":"https://api.github.com/users/etcd-io/following{/other_user}","gists_url":"https://api.github.com/users/etcd-io/gists{/gist_id}","starred_url":"https://api.github.com/users/etcd-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etcd-io/subscriptions","organizations_url":"https://api.github.com/users/etcd-io/orgs","repos_url":"https://api.github.com/users/etcd-io/repos","events_url":"https://api.github.com/users/etcd-io/events{/privacy}","received_events_url":"https://api.github.com/users/etcd-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/etcd-io/etcd","description":"Distributed reliable key-value store for the most critical data of a distributed system","fork":false,"url":"https://api.github.com/repos/etcd-io/etcd","forks_url":"https://api.github.com/repos/etcd-io/etcd/forks","keys_url":"https://api.github.com/repos/etcd-io/etcd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/etcd-io/etcd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/etcd-io/etcd/teams","hooks_url":"https://api.github.com/repos/etcd-io/etcd/hooks","issue_events_url":"https://api.github.com/repos/etcd-io/etcd/issues/events{/number}","events_url":"https://api.github.com/repos/etcd-io/etcd/events","assignees_url":"https://api.github.com/repos/etcd-io/etcd/assignees{/user}","branches_url":"https://api.github.com/repos/etcd-io/etcd/branches{/branch}","tags_url":"https://api.github.com/repos/etcd-io/etcd/tags","blobs_url":"https://api.github.com/repos/etcd-io/etcd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/etcd-io/etcd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/etcd-io/etcd/git/refs{/sha}","trees_url":"https://api.github.com/repos/etcd-io/etcd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/etcd-io/etcd/statuses/{sha}","languages_url":"https://api.github.com/repos/etcd-io/etcd/languages","stargazers_url":"https://api.github.com/repos/etcd-io/etcd/stargazers","contributors_url":"https://api.github.com/repos/etcd-io/etcd/contributors","subscribers_url":"https://api.github.com/repos/etcd-io/etcd/subscribers","subscription_url":"https://api.github.com/repos/etcd-io/etcd/subscription","commits_url":"https://api.github.com/repos/etcd-io/etcd/commits{/sha}","git_commits_url":"https://api.github.com/repos/etcd-io/etcd/git/commits{/sha}","comments_url":"https://api.github.com/repos/etcd-io/etcd/comments{/number}","issue_comment_url":"https://api.github.com/repos/etcd-io/etcd/issues/comments{/number}","contents_url":"https://api.github.com/repos/etcd-io/etcd/contents/{+path}","compare_url":"https://api.github.com/repos/etcd-io/etcd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/etcd-io/etcd/merges","archive_url":"https://api.github.com/repos/etcd-io/etcd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/etcd-io/etcd/downloads","issues_url":"https://api.github.com/repos/etcd-io/etcd/issues{/number}","pulls_url":"https://api.github.com/repos/etcd-io/etcd/pulls{/number}","milestones_url":"https://api.github.com/repos/etcd-io/etcd/milestones{/number}","notifications_url":"https://api.github.com/repos/etcd-io/etcd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/etcd-io/etcd/labels{/name}","releases_url":"https://api.github.com/repos/etcd-io/etcd/releases{/id}","deployments_url":"https://api.github.com/repos/etcd-io/etcd/deployments","created_at":"2013-07-06T21:57:21Z","updated_at":"2018-10-25T12:39:49Z","pushed_at":"2018-10-25T06:24:17Z","git_url":"git://github.com/etcd-io/etcd.git","ssh_url":"git@github.com:etcd-io/etcd.git","clone_url":"https://github.com/etcd-io/etcd.git","svn_url":"https://github.com/etcd-io/etcd","homepage":"https://etcd.readthedocs.io/en/latest","size":46255,"stargazers_count":20842,"watchers_count":20842,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4176,"mirror_url":null,"archived":false,"open_issues_count":277,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4176,"open_issues":277,"watchers":20842,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/etcd-io/etcd/pulls/10211"},"html":{"href":"https://github.com/etcd-io/etcd/pull/10211"},"issue":{"href":"https://api.github.com/repos/etcd-io/etcd/issues/10211"},"comments":{"href":"https://api.github.com/repos/etcd-io/etcd/issues/10211/comments"},"review_comments":{"href":"https://api.github.com/repos/etcd-io/etcd/pulls/10211/comments"},"review_comment":{"href":"https://api.github.com/repos/etcd-io/etcd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/etcd-io/etcd/pulls/10211/commits"},"statuses":{"href":"https://api.github.com/repos/etcd-io/etcd/statuses/fdbaaa6a49c2e27eeeac39dcc335f141d5a59d26"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"spzala"}}