{"action":"closed","number":505,"pull_request":{"url":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/505","id":218393281,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MzkzMjgx","html_url":"https://github.com/exonum/exonum-java-binding/pull/505","diff_url":"https://github.com/exonum/exonum-java-binding/pull/505.diff","patch_url":"https://github.com/exonum/exonum-java-binding/pull/505.patch","issue_url":"https://api.github.com/repos/exonum/exonum-java-binding/issues/505","number":505,"state":"closed","locked":false,"title":"Update collections to accept proto messages [ECR-2340]","user":{"login":"dmitry-timofeev","id":7531824,"node_id":"MDQ6VXNlcjc1MzE4MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7531824?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitry-timofeev","html_url":"https://github.com/dmitry-timofeev","followers_url":"https://api.github.com/users/dmitry-timofeev/followers","following_url":"https://api.github.com/users/dmitry-timofeev/following{/other_user}","gists_url":"https://api.github.com/users/dmitry-timofeev/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitry-timofeev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitry-timofeev/subscriptions","organizations_url":"https://api.github.com/users/dmitry-timofeev/orgs","repos_url":"https://api.github.com/users/dmitry-timofeev/repos","events_url":"https://api.github.com/users/dmitry-timofeev/events{/privacy}","received_events_url":"https://api.github.com/users/dmitry-timofeev/received_events","type":"User","site_admin":false},"body":"## Overview\r\n<!-- Please describe your changes here and list any open questions you might have. -->\r\n\r\nUpdate indexes to accept proto messages\r\n\r\nMake them automatically create reflective serializers of\r\nprotobuf messages in their static factory methods.\r\n\r\n*Note 1:* ProofMapIndexProxy does not get such a method —\r\nit has a certain restriction on keys, which is unlikely\r\nto hold for an arbitrary Protocol Buffers message.\r\n\r\n*Note 2:* dependency on protobuf cannot be optional\r\nbecause the compiler has to load the classes appearing\r\nin parameter lists to determine which of the overloaded\r\nmethods to call. It can be optional if we _require_\r\nthe clients to add it in \"provided\" scope.\r\n\r\nAlso, avoid overloads by method reference. Because of some\r\ncompiler bug in JDK 8, a call like\r\nIndexConstructors.from(ListIndexProxy::newInstance)\r\ncannot be resolved as ambiguous. The same code compiles fine on 11.\r\n\r\n\\+ Improve the discoverability of StandardSerializers \r\n\r\n---\r\nSee: https://jira.bf.local/browse/ECR-2340\r\n\r\n### Definition of Done\r\n\r\n- [x] There are no TODOs left in the code\r\n- [x] Change is covered by automated [tests](https://github.com/exonum/exonum-java-binding/blob/master/CONTRIBUTING.md#tests)\r\n- [x] The [coding guidelines](https://github.com/exonum/exonum-java-binding/blob/master/CONTRIBUTING.md#the-code-style) are followed\r\n- [x] Public API has Javadoc\r\n- [x] Method preconditions are checked and documented in the Javadoc of the method\r\n- [x] Changelog is updated if needed (in case of notable or breaking changes)\r\n- [x] The continuous integration build passes\r\n","created_at":"2018-09-26T17:18:00Z","updated_at":"2018-10-01T09:06:59Z","closed_at":"2018-10-01T09:06:59Z","merged_at":"2018-10-01T09:06:59Z","merge_commit_sha":"e78cd9f95a8eb16ee97caa59f719902c3847fd90","assignee":null,"assignees":[],"requested_reviewers":[{"login":"DarkEld3r","id":2997902,"node_id":"MDQ6VXNlcjI5OTc5MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/2997902?v=4","gravatar_id":"","url":"https://api.github.com/users/DarkEld3r","html_url":"https://github.com/DarkEld3r","followers_url":"https://api.github.com/users/DarkEld3r/followers","following_url":"https://api.github.com/users/DarkEld3r/following{/other_user}","gists_url":"https://api.github.com/users/DarkEld3r/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkEld3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkEld3r/subscriptions","organizations_url":"https://api.github.com/users/DarkEld3r/orgs","repos_url":"https://api.github.com/users/DarkEld3r/repos","events_url":"https://api.github.com/users/DarkEld3r/events{/privacy}","received_events_url":"https://api.github.com/users/DarkEld3r/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/505/commits","review_comments_url":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/505/comments","review_comment_url":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exonum/exonum-java-binding/issues/505/comments","statuses_url":"https://api.github.com/repos/exonum/exonum-java-binding/statuses/4fb1f65f8d979aa7c93408d079b0ba03748d387b","head":{"label":"dmitry-timofeev:update-indicies-to-accept-proto-messages/ECR-2340","ref":"update-indicies-to-accept-proto-messages/ECR-2340","sha":"4fb1f65f8d979aa7c93408d079b0ba03748d387b","user":{"login":"dmitry-timofeev","id":7531824,"node_id":"MDQ6VXNlcjc1MzE4MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7531824?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitry-timofeev","html_url":"https://github.com/dmitry-timofeev","followers_url":"https://api.github.com/users/dmitry-timofeev/followers","following_url":"https://api.github.com/users/dmitry-timofeev/following{/other_user}","gists_url":"https://api.github.com/users/dmitry-timofeev/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitry-timofeev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitry-timofeev/subscriptions","organizations_url":"https://api.github.com/users/dmitry-timofeev/orgs","repos_url":"https://api.github.com/users/dmitry-timofeev/repos","events_url":"https://api.github.com/users/dmitry-timofeev/events{/privacy}","received_events_url":"https://api.github.com/users/dmitry-timofeev/received_events","type":"User","site_admin":false},"repo":{"id":137935635,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc5MzU2MzU=","name":"exonum-java-binding-1","full_name":"dmitry-timofeev/exonum-java-binding-1","private":false,"owner":{"login":"dmitry-timofeev","id":7531824,"node_id":"MDQ6VXNlcjc1MzE4MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7531824?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitry-timofeev","html_url":"https://github.com/dmitry-timofeev","followers_url":"https://api.github.com/users/dmitry-timofeev/followers","following_url":"https://api.github.com/users/dmitry-timofeev/following{/other_user}","gists_url":"https://api.github.com/users/dmitry-timofeev/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitry-timofeev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitry-timofeev/subscriptions","organizations_url":"https://api.github.com/users/dmitry-timofeev/orgs","repos_url":"https://api.github.com/users/dmitry-timofeev/repos","events_url":"https://api.github.com/users/dmitry-timofeev/events{/privacy}","received_events_url":"https://api.github.com/users/dmitry-timofeev/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dmitry-timofeev/exonum-java-binding-1","description":"Java Binding for the Exonum blockchain framework","fork":true,"url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1","forks_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/forks","keys_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/teams","hooks_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/hooks","issue_events_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/issues/events{/number}","events_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/events","assignees_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/assignees{/user}","branches_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/branches{/branch}","tags_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/tags","blobs_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/statuses/{sha}","languages_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/languages","stargazers_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/stargazers","contributors_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/contributors","subscribers_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/subscribers","subscription_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/subscription","commits_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/contents/{+path}","compare_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/merges","archive_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/downloads","issues_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/issues{/number}","pulls_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/pulls{/number}","milestones_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/milestones{/number}","notifications_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/labels{/name}","releases_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/releases{/id}","deployments_url":"https://api.github.com/repos/dmitry-timofeev/exonum-java-binding-1/deployments","created_at":"2018-06-19T19:23:01Z","updated_at":"2018-09-16T16:56:47Z","pushed_at":"2018-09-26T17:24:38Z","git_url":"git://github.com/dmitry-timofeev/exonum-java-binding-1.git","ssh_url":"git@github.com:dmitry-timofeev/exonum-java-binding-1.git","clone_url":"https://github.com/dmitry-timofeev/exonum-java-binding-1.git","svn_url":"https://github.com/dmitry-timofeev/exonum-java-binding-1","homepage":"http://exonum.com","size":2199,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"exonum:master","ref":"master","sha":"e91c4523c55870df5b2fdd32737a9e876d7721de","user":{"login":"exonum","id":23138442,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTM4NDQy","avatar_url":"https://avatars1.githubusercontent.com/u/23138442?v=4","gravatar_id":"","url":"https://api.github.com/users/exonum","html_url":"https://github.com/exonum","followers_url":"https://api.github.com/users/exonum/followers","following_url":"https://api.github.com/users/exonum/following{/other_user}","gists_url":"https://api.github.com/users/exonum/gists{/gist_id}","starred_url":"https://api.github.com/users/exonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exonum/subscriptions","organizations_url":"https://api.github.com/users/exonum/orgs","repos_url":"https://api.github.com/users/exonum/repos","events_url":"https://api.github.com/users/exonum/events{/privacy}","received_events_url":"https://api.github.com/users/exonum/received_events","type":"Organization","site_admin":false},"repo":{"id":92375988,"node_id":"MDEwOlJlcG9zaXRvcnk5MjM3NTk4OA==","name":"exonum-java-binding","full_name":"exonum/exonum-java-binding","private":false,"owner":{"login":"exonum","id":23138442,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTM4NDQy","avatar_url":"https://avatars1.githubusercontent.com/u/23138442?v=4","gravatar_id":"","url":"https://api.github.com/users/exonum","html_url":"https://github.com/exonum","followers_url":"https://api.github.com/users/exonum/followers","following_url":"https://api.github.com/users/exonum/following{/other_user}","gists_url":"https://api.github.com/users/exonum/gists{/gist_id}","starred_url":"https://api.github.com/users/exonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exonum/subscriptions","organizations_url":"https://api.github.com/users/exonum/orgs","repos_url":"https://api.github.com/users/exonum/repos","events_url":"https://api.github.com/users/exonum/events{/privacy}","received_events_url":"https://api.github.com/users/exonum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/exonum/exonum-java-binding","description":"Java Binding for the Exonum blockchain framework","fork":false,"url":"https://api.github.com/repos/exonum/exonum-java-binding","forks_url":"https://api.github.com/repos/exonum/exonum-java-binding/forks","keys_url":"https://api.github.com/repos/exonum/exonum-java-binding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exonum/exonum-java-binding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exonum/exonum-java-binding/teams","hooks_url":"https://api.github.com/repos/exonum/exonum-java-binding/hooks","issue_events_url":"https://api.github.com/repos/exonum/exonum-java-binding/issues/events{/number}","events_url":"https://api.github.com/repos/exonum/exonum-java-binding/events","assignees_url":"https://api.github.com/repos/exonum/exonum-java-binding/assignees{/user}","branches_url":"https://api.github.com/repos/exonum/exonum-java-binding/branches{/branch}","tags_url":"https://api.github.com/repos/exonum/exonum-java-binding/tags","blobs_url":"https://api.github.com/repos/exonum/exonum-java-binding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exonum/exonum-java-binding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exonum/exonum-java-binding/git/refs{/sha}","trees_url":"https://api.github.com/repos/exonum/exonum-java-binding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exonum/exonum-java-binding/statuses/{sha}","languages_url":"https://api.github.com/repos/exonum/exonum-java-binding/languages","stargazers_url":"https://api.github.com/repos/exonum/exonum-java-binding/stargazers","contributors_url":"https://api.github.com/repos/exonum/exonum-java-binding/contributors","subscribers_url":"https://api.github.com/repos/exonum/exonum-java-binding/subscribers","subscription_url":"https://api.github.com/repos/exonum/exonum-java-binding/subscription","commits_url":"https://api.github.com/repos/exonum/exonum-java-binding/commits{/sha}","git_commits_url":"https://api.github.com/repos/exonum/exonum-java-binding/git/commits{/sha}","comments_url":"https://api.github.com/repos/exonum/exonum-java-binding/comments{/number}","issue_comment_url":"https://api.github.com/repos/exonum/exonum-java-binding/issues/comments{/number}","contents_url":"https://api.github.com/repos/exonum/exonum-java-binding/contents/{+path}","compare_url":"https://api.github.com/repos/exonum/exonum-java-binding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exonum/exonum-java-binding/merges","archive_url":"https://api.github.com/repos/exonum/exonum-java-binding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exonum/exonum-java-binding/downloads","issues_url":"https://api.github.com/repos/exonum/exonum-java-binding/issues{/number}","pulls_url":"https://api.github.com/repos/exonum/exonum-java-binding/pulls{/number}","milestones_url":"https://api.github.com/repos/exonum/exonum-java-binding/milestones{/number}","notifications_url":"https://api.github.com/repos/exonum/exonum-java-binding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exonum/exonum-java-binding/labels{/name}","releases_url":"https://api.github.com/repos/exonum/exonum-java-binding/releases{/id}","deployments_url":"https://api.github.com/repos/exonum/exonum-java-binding/deployments","created_at":"2017-05-25T07:12:56Z","updated_at":"2018-09-26T15:57:04Z","pushed_at":"2018-10-01T09:06:59Z","git_url":"git://github.com/exonum/exonum-java-binding.git","ssh_url":"git@github.com:exonum/exonum-java-binding.git","clone_url":"https://github.com/exonum/exonum-java-binding.git","svn_url":"https://github.com/exonum/exonum-java-binding","homepage":"http://exonum.com","size":2464,"stargazers_count":44,"watchers_count":44,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":12,"open_issues":18,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/505"},"html":{"href":"https://github.com/exonum/exonum-java-binding/pull/505"},"issue":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/issues/505"},"comments":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/issues/505/comments"},"review_comments":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/505/comments"},"review_comment":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/pulls/505/commits"},"statuses":{"href":"https://api.github.com/repos/exonum/exonum-java-binding/statuses/4fb1f65f8d979aa7c93408d079b0ba03748d387b"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bullet-tooth","id":5055052,"node_id":"MDQ6VXNlcjUwNTUwNTI=","avatar_url":"https://avatars1.githubusercontent.com/u/5055052?v=4","gravatar_id":"","url":"https://api.github.com/users/bullet-tooth","html_url":"https://github.com/bullet-tooth","followers_url":"https://api.github.com/users/bullet-tooth/followers","following_url":"https://api.github.com/users/bullet-tooth/following{/other_user}","gists_url":"https://api.github.com/users/bullet-tooth/gists{/gist_id}","starred_url":"https://api.github.com/users/bullet-tooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bullet-tooth/subscriptions","organizations_url":"https://api.github.com/users/bullet-tooth/orgs","repos_url":"https://api.github.com/users/bullet-tooth/repos","events_url":"https://api.github.com/users/bullet-tooth/events{/privacy}","received_events_url":"https://api.github.com/users/bullet-tooth/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":234,"deletions":13,"changed_files":15}}
{"actor":{"display_login":"bullet-tooth"}}