{"action":"created","comment":{"url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/pulls/comments/238573359","pull_request_review_id":181144638,"id":238573359,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODU3MzM1OQ==","diff_hunk":"@@ -169,6 +169,8 @@ def test_unordered_dict(init_func):\n \n \n def test_topic_config_update():\n+    # *NOTE* default.topic.config has been deprecated.\n+    # This example remains to ensure backward-compatibility until it's removal","path":"tests/test_misc.py","position":5,"original_position":5,"commit_id":"7977e88de9529a4aea8113037de8e11d26fe74ab","original_commit_id":"7977e88de9529a4aea8113037de8e11d26fe74ab","user":{"login":"edenhill","id":524990,"node_id":"MDQ6VXNlcjUyNDk5MA==","avatar_url":"https://avatars0.githubusercontent.com/u/524990?v=4","gravatar_id":"","url":"https://api.github.com/users/edenhill","html_url":"https://github.com/edenhill","followers_url":"https://api.github.com/users/edenhill/followers","following_url":"https://api.github.com/users/edenhill/following{/other_user}","gists_url":"https://api.github.com/users/edenhill/gists{/gist_id}","starred_url":"https://api.github.com/users/edenhill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edenhill/subscriptions","organizations_url":"https://api.github.com/users/edenhill/orgs","repos_url":"https://api.github.com/users/edenhill/repos","events_url":"https://api.github.com/users/edenhill/events{/privacy}","received_events_url":"https://api.github.com/users/edenhill/received_events","type":"User","site_admin":false},"body":"its","created_at":"2018-12-04T08:58:14Z","updated_at":"2018-12-04T08:58:24Z","html_url":"https://github.com/confluentinc/confluent-kafka-python/pull/498#discussion_r238573359","pull_request_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/pulls/498","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-python/pulls/comments/238573359"},"html":{"href":"https://github.com/confluentinc/confluent-kafka-python/pull/498#discussion_r238573359"},"pull_request":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-python/pulls/498"}}},"pull_request":{"url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/pulls/498","id":235583207,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NTgzMjA3","html_url":"https://github.com/confluentinc/confluent-kafka-python/pull/498","diff_url":"https://github.com/confluentinc/confluent-kafka-python/pull/498.diff","patch_url":"https://github.com/confluentinc/confluent-kafka-python/pull/498.patch","issue_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/issues/498","number":498,"state":"open","locked":false,"title":"V1.0 deprecations","user":{"login":"rnpridgeon","id":5313961,"node_id":"MDQ6VXNlcjUzMTM5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/5313961?v=4","gravatar_id":"","url":"https://api.github.com/users/rnpridgeon","html_url":"https://github.com/rnpridgeon","followers_url":"https://api.github.com/users/rnpridgeon/followers","following_url":"https://api.github.com/users/rnpridgeon/following{/other_user}","gists_url":"https://api.github.com/users/rnpridgeon/gists{/gist_id}","starred_url":"https://api.github.com/users/rnpridgeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnpridgeon/subscriptions","organizations_url":"https://api.github.com/users/rnpridgeon/orgs","repos_url":"https://api.github.com/users/rnpridgeon/repos","events_url":"https://api.github.com/users/rnpridgeon/events{/privacy}","received_events_url":"https://api.github.com/users/rnpridgeon/received_events","type":"User","site_admin":false},"body":"Note two remaining `default.topic.config` are already handled in #440 ","created_at":"2018-12-03T20:33:09Z","updated_at":"2018-12-04T08:58:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"899fe26996bb8c1a60912d5a9d37bbf62bb9ebe0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/pulls/498/commits","review_comments_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/pulls/498/comments","review_comment_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/issues/498/comments","statuses_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/statuses/7977e88de9529a4aea8113037de8e11d26fe74ab","head":{"label":"confluentinc:v1.0-deprecations","ref":"v1.0-deprecations","sha":"7977e88de9529a4aea8113037de8e11d26fe74ab","user":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":56217288,"node_id":"MDEwOlJlcG9zaXRvcnk1NjIxNzI4OA==","name":"confluent-kafka-python","full_name":"confluentinc/confluent-kafka-python","private":false,"owner":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/confluentinc/confluent-kafka-python","description":"Confluent's Apache Kafka Python client","fork":false,"url":"https://api.github.com/repos/confluentinc/confluent-kafka-python","forks_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/forks","keys_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/teams","hooks_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/events","assignees_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/tags","blobs_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/languages","stargazers_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/subscription","commits_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/merges","archive_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/downloads","issues_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/deployments","created_at":"2016-04-14T07:40:41Z","updated_at":"2018-12-04T08:13:46Z","pushed_at":"2018-12-04T08:13:43Z","git_url":"git://github.com/confluentinc/confluent-kafka-python.git","ssh_url":"git@github.com:confluentinc/confluent-kafka-python.git","clone_url":"https://github.com/confluentinc/confluent-kafka-python.git","svn_url":"https://github.com/confluentinc/confluent-kafka-python","homepage":"http://docs.confluent.io/current/clients/confluent-kafka-python","size":813,"stargazers_count":993,"watchers_count":993,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":251,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":251,"open_issues":59,"watchers":993,"default_branch":"master"}},"base":{"label":"confluentinc:master","ref":"master","sha":"15800d00ef743c1bda204b84319122e34de09a0b","user":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":56217288,"node_id":"MDEwOlJlcG9zaXRvcnk1NjIxNzI4OA==","name":"confluent-kafka-python","full_name":"confluentinc/confluent-kafka-python","private":false,"owner":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/confluentinc/confluent-kafka-python","description":"Confluent's Apache Kafka Python client","fork":false,"url":"https://api.github.com/repos/confluentinc/confluent-kafka-python","forks_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/forks","keys_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/teams","hooks_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/events","assignees_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/tags","blobs_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/languages","stargazers_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/subscription","commits_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/merges","archive_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/downloads","issues_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/confluent-kafka-python/deployments","created_at":"2016-04-14T07:40:41Z","updated_at":"2018-12-04T08:13:46Z","pushed_at":"2018-12-04T08:13:43Z","git_url":"git://github.com/confluentinc/confluent-kafka-python.git","ssh_url":"git@github.com:confluentinc/confluent-kafka-python.git","clone_url":"https://github.com/confluentinc/confluent-kafka-python.git","svn_url":"https://github.com/confluentinc/confluent-kafka-python","homepage":"http://docs.confluent.io/current/clients/confluent-kafka-python","size":813,"stargazers_count":993,"watchers_count":993,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":251,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":251,"open_issues":59,"watchers":993,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-python/pulls/498"},"html":{"href":"https://github.com/confluentinc/confluent-kafka-python/pull/498"},"issue":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-python/issues/498"},"comments":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-python/issues/498/comments"},"review_comments":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-python/pulls/498/comments"},"review_comment":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-python/pulls/498/commits"},"statuses":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-python/statuses/7977e88de9529a4aea8113037de8e11d26fe74ab"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"edenhill"}}