{"action":"opened","number":94,"pull_request":{"url":"https://api.github.com/repos/pavlov99/json-rpc/pulls/94","id":196718640,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NzE4NjQw","html_url":"https://github.com/pavlov99/json-rpc/pull/94","diff_url":"https://github.com/pavlov99/json-rpc/pull/94.diff","patch_url":"https://github.com/pavlov99/json-rpc/pull/94.patch","issue_url":"https://api.github.com/repos/pavlov99/json-rpc/issues/94","number":94,"state":"open","locked":false,"title":"Allow to change the serialization and deserialization methods used by the library","user":{"login":"0xFelix","id":441757,"node_id":"MDQ6VXNlcjQ0MTc1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/441757?v=4","gravatar_id":"","url":"https://api.github.com/users/0xFelix","html_url":"https://github.com/0xFelix","followers_url":"https://api.github.com/users/0xFelix/followers","following_url":"https://api.github.com/users/0xFelix/following{/other_user}","gists_url":"https://api.github.com/users/0xFelix/gists{/gist_id}","starred_url":"https://api.github.com/users/0xFelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xFelix/subscriptions","organizations_url":"https://api.github.com/users/0xFelix/orgs","repos_url":"https://api.github.com/users/0xFelix/repos","events_url":"https://api.github.com/users/0xFelix/events{/privacy}","received_events_url":"https://api.github.com/users/0xFelix/received_events","type":"User","site_admin":false},"body":"### Description of the Change\r\n\r\nSubclass JSONSerializable from JSONRPC20BatchRequest and JSONRPC20BatchResponse to allow usage of JSONSerializable's methods `serialize` and `deserialize`.\r\n\r\nDecouple request validation from JSONRPCResponseManager's `handle` method and introduce a static method inside JSONRPCResponseManager named `deserialize` (analogous to JSONSerializable).\r\n\r\n### Benefits\r\n\r\nThese changes allow to change the serialization and deserialization methods used by the library without overwriting its logic. (e.g. use `cbor2.loads` / `cbor2.dumps` instead of `json.loads` / `json.dumps`)","created_at":"2018-06-22T11:59:57Z","updated_at":"2018-06-22T11:59:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pavlov99/json-rpc/pulls/94/commits","review_comments_url":"https://api.github.com/repos/pavlov99/json-rpc/pulls/94/comments","review_comment_url":"https://api.github.com/repos/pavlov99/json-rpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pavlov99/json-rpc/issues/94/comments","statuses_url":"https://api.github.com/repos/pavlov99/json-rpc/statuses/d12e41bb9b4741e95f86911402a1eddc875e7cf2","head":{"label":"0xFelix:master","ref":"master","sha":"d12e41bb9b4741e95f86911402a1eddc875e7cf2","user":{"login":"0xFelix","id":441757,"node_id":"MDQ6VXNlcjQ0MTc1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/441757?v=4","gravatar_id":"","url":"https://api.github.com/users/0xFelix","html_url":"https://github.com/0xFelix","followers_url":"https://api.github.com/users/0xFelix/followers","following_url":"https://api.github.com/users/0xFelix/following{/other_user}","gists_url":"https://api.github.com/users/0xFelix/gists{/gist_id}","starred_url":"https://api.github.com/users/0xFelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xFelix/subscriptions","organizations_url":"https://api.github.com/users/0xFelix/orgs","repos_url":"https://api.github.com/users/0xFelix/repos","events_url":"https://api.github.com/users/0xFelix/events{/privacy}","received_events_url":"https://api.github.com/users/0xFelix/received_events","type":"User","site_admin":false},"repo":{"id":137897455,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc4OTc0NTU=","name":"json-rpc","full_name":"0xFelix/json-rpc","owner":{"login":"0xFelix","id":441757,"node_id":"MDQ6VXNlcjQ0MTc1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/441757?v=4","gravatar_id":"","url":"https://api.github.com/users/0xFelix","html_url":"https://github.com/0xFelix","followers_url":"https://api.github.com/users/0xFelix/followers","following_url":"https://api.github.com/users/0xFelix/following{/other_user}","gists_url":"https://api.github.com/users/0xFelix/gists{/gist_id}","starred_url":"https://api.github.com/users/0xFelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xFelix/subscriptions","organizations_url":"https://api.github.com/users/0xFelix/orgs","repos_url":"https://api.github.com/users/0xFelix/repos","events_url":"https://api.github.com/users/0xFelix/events{/privacy}","received_events_url":"https://api.github.com/users/0xFelix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/0xFelix/json-rpc","description":"🔁 JSON-RPC 1/2 transport implementation. Supports python 2/3 and pypy.","fork":true,"url":"https://api.github.com/repos/0xFelix/json-rpc","forks_url":"https://api.github.com/repos/0xFelix/json-rpc/forks","keys_url":"https://api.github.com/repos/0xFelix/json-rpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0xFelix/json-rpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0xFelix/json-rpc/teams","hooks_url":"https://api.github.com/repos/0xFelix/json-rpc/hooks","issue_events_url":"https://api.github.com/repos/0xFelix/json-rpc/issues/events{/number}","events_url":"https://api.github.com/repos/0xFelix/json-rpc/events","assignees_url":"https://api.github.com/repos/0xFelix/json-rpc/assignees{/user}","branches_url":"https://api.github.com/repos/0xFelix/json-rpc/branches{/branch}","tags_url":"https://api.github.com/repos/0xFelix/json-rpc/tags","blobs_url":"https://api.github.com/repos/0xFelix/json-rpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0xFelix/json-rpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0xFelix/json-rpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/0xFelix/json-rpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0xFelix/json-rpc/statuses/{sha}","languages_url":"https://api.github.com/repos/0xFelix/json-rpc/languages","stargazers_url":"https://api.github.com/repos/0xFelix/json-rpc/stargazers","contributors_url":"https://api.github.com/repos/0xFelix/json-rpc/contributors","subscribers_url":"https://api.github.com/repos/0xFelix/json-rpc/subscribers","subscription_url":"https://api.github.com/repos/0xFelix/json-rpc/subscription","commits_url":"https://api.github.com/repos/0xFelix/json-rpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/0xFelix/json-rpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/0xFelix/json-rpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/0xFelix/json-rpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/0xFelix/json-rpc/contents/{+path}","compare_url":"https://api.github.com/repos/0xFelix/json-rpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0xFelix/json-rpc/merges","archive_url":"https://api.github.com/repos/0xFelix/json-rpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0xFelix/json-rpc/downloads","issues_url":"https://api.github.com/repos/0xFelix/json-rpc/issues{/number}","pulls_url":"https://api.github.com/repos/0xFelix/json-rpc/pulls{/number}","milestones_url":"https://api.github.com/repos/0xFelix/json-rpc/milestones{/number}","notifications_url":"https://api.github.com/repos/0xFelix/json-rpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0xFelix/json-rpc/labels{/name}","releases_url":"https://api.github.com/repos/0xFelix/json-rpc/releases{/id}","deployments_url":"https://api.github.com/repos/0xFelix/json-rpc/deployments","created_at":"2018-06-19T13:45:50Z","updated_at":"2018-06-22T11:57:52Z","pushed_at":"2018-06-22T11:57:51Z","git_url":"git://github.com/0xFelix/json-rpc.git","ssh_url":"git@github.com:0xFelix/json-rpc.git","clone_url":"https://github.com/0xFelix/json-rpc.git","svn_url":"https://github.com/0xFelix/json-rpc","homepage":"http://json-rpc.readthedocs.org","size":358,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pavlov99:master","ref":"master","sha":"a0bf414c76e5c7453f8f7575887a5f74472679ee","user":{"login":"pavlov99","id":590293,"node_id":"MDQ6VXNlcjU5MDI5Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/590293?v=4","gravatar_id":"","url":"https://api.github.com/users/pavlov99","html_url":"https://github.com/pavlov99","followers_url":"https://api.github.com/users/pavlov99/followers","following_url":"https://api.github.com/users/pavlov99/following{/other_user}","gists_url":"https://api.github.com/users/pavlov99/gists{/gist_id}","starred_url":"https://api.github.com/users/pavlov99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavlov99/subscriptions","organizations_url":"https://api.github.com/users/pavlov99/orgs","repos_url":"https://api.github.com/users/pavlov99/repos","events_url":"https://api.github.com/users/pavlov99/events{/privacy}","received_events_url":"https://api.github.com/users/pavlov99/received_events","type":"User","site_admin":false},"repo":{"id":13211363,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIxMTM2Mw==","name":"json-rpc","full_name":"pavlov99/json-rpc","owner":{"login":"pavlov99","id":590293,"node_id":"MDQ6VXNlcjU5MDI5Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/590293?v=4","gravatar_id":"","url":"https://api.github.com/users/pavlov99","html_url":"https://github.com/pavlov99","followers_url":"https://api.github.com/users/pavlov99/followers","following_url":"https://api.github.com/users/pavlov99/following{/other_user}","gists_url":"https://api.github.com/users/pavlov99/gists{/gist_id}","starred_url":"https://api.github.com/users/pavlov99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavlov99/subscriptions","organizations_url":"https://api.github.com/users/pavlov99/orgs","repos_url":"https://api.github.com/users/pavlov99/repos","events_url":"https://api.github.com/users/pavlov99/events{/privacy}","received_events_url":"https://api.github.com/users/pavlov99/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pavlov99/json-rpc","description":"🔁 JSON-RPC 1/2 transport implementation. Supports python 2/3 and pypy.","fork":false,"url":"https://api.github.com/repos/pavlov99/json-rpc","forks_url":"https://api.github.com/repos/pavlov99/json-rpc/forks","keys_url":"https://api.github.com/repos/pavlov99/json-rpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pavlov99/json-rpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pavlov99/json-rpc/teams","hooks_url":"https://api.github.com/repos/pavlov99/json-rpc/hooks","issue_events_url":"https://api.github.com/repos/pavlov99/json-rpc/issues/events{/number}","events_url":"https://api.github.com/repos/pavlov99/json-rpc/events","assignees_url":"https://api.github.com/repos/pavlov99/json-rpc/assignees{/user}","branches_url":"https://api.github.com/repos/pavlov99/json-rpc/branches{/branch}","tags_url":"https://api.github.com/repos/pavlov99/json-rpc/tags","blobs_url":"https://api.github.com/repos/pavlov99/json-rpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pavlov99/json-rpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pavlov99/json-rpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/pavlov99/json-rpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pavlov99/json-rpc/statuses/{sha}","languages_url":"https://api.github.com/repos/pavlov99/json-rpc/languages","stargazers_url":"https://api.github.com/repos/pavlov99/json-rpc/stargazers","contributors_url":"https://api.github.com/repos/pavlov99/json-rpc/contributors","subscribers_url":"https://api.github.com/repos/pavlov99/json-rpc/subscribers","subscription_url":"https://api.github.com/repos/pavlov99/json-rpc/subscription","commits_url":"https://api.github.com/repos/pavlov99/json-rpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/pavlov99/json-rpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/pavlov99/json-rpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/pavlov99/json-rpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/pavlov99/json-rpc/contents/{+path}","compare_url":"https://api.github.com/repos/pavlov99/json-rpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pavlov99/json-rpc/merges","archive_url":"https://api.github.com/repos/pavlov99/json-rpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pavlov99/json-rpc/downloads","issues_url":"https://api.github.com/repos/pavlov99/json-rpc/issues{/number}","pulls_url":"https://api.github.com/repos/pavlov99/json-rpc/pulls{/number}","milestones_url":"https://api.github.com/repos/pavlov99/json-rpc/milestones{/number}","notifications_url":"https://api.github.com/repos/pavlov99/json-rpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pavlov99/json-rpc/labels{/name}","releases_url":"https://api.github.com/repos/pavlov99/json-rpc/releases{/id}","deployments_url":"https://api.github.com/repos/pavlov99/json-rpc/deployments","created_at":"2013-09-30T09:36:07Z","updated_at":"2018-06-20T05:32:38Z","pushed_at":"2018-06-14T17:36:44Z","git_url":"git://github.com/pavlov99/json-rpc.git","ssh_url":"git@github.com:pavlov99/json-rpc.git","clone_url":"https://github.com/pavlov99/json-rpc.git","svn_url":"https://github.com/pavlov99/json-rpc","homepage":"http://json-rpc.readthedocs.org","size":356,"stargazers_count":194,"watchers_count":194,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":62,"open_issues":21,"watchers":194,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pavlov99/json-rpc/pulls/94"},"html":{"href":"https://github.com/pavlov99/json-rpc/pull/94"},"issue":{"href":"https://api.github.com/repos/pavlov99/json-rpc/issues/94"},"comments":{"href":"https://api.github.com/repos/pavlov99/json-rpc/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/pavlov99/json-rpc/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/pavlov99/json-rpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pavlov99/json-rpc/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/pavlov99/json-rpc/statuses/d12e41bb9b4741e95f86911402a1eddc875e7cf2"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":15,"deletions":9,"changed_files":2}}
{"actor":{"display_login":"0xFelix"}}