{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/192351449","pull_request_review_id":125111986,"id":192351449,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjM1MTQ0OQ==","diff_hunk":"@@ -14,7 +14,15 @@ with lib;\n             Read the repository password from a file.\n           '';\n           example = \"/etc/nixos/restic-password\";\n+        };\n \n+        s3CredentialsFile = mkOption {\n+          type = types.str;","path":"nixos/modules/services/backup/restic.nix","position":7,"original_position":7,"commit_id":"44636a86f28910769c64c62c28a8d17df50c21ea","original_commit_id":"44636a86f28910769c64c62c28a8d17df50c21ea","user":{"login":"Mic92","id":96200,"node_id":"MDQ6VXNlcjk2MjAw","avatar_url":"https://avatars3.githubusercontent.com/u/96200?v=4","gravatar_id":"","url":"https://api.github.com/users/Mic92","html_url":"https://github.com/Mic92","followers_url":"https://api.github.com/users/Mic92/followers","following_url":"https://api.github.com/users/Mic92/following{/other_user}","gists_url":"https://api.github.com/users/Mic92/gists{/gist_id}","starred_url":"https://api.github.com/users/Mic92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mic92/subscriptions","organizations_url":"https://api.github.com/users/Mic92/orgs","repos_url":"https://api.github.com/users/Mic92/repos","events_url":"https://api.github.com/users/Mic92/events{/privacy}","received_events_url":"https://api.github.com/users/Mic92/received_events","type":"User","site_admin":false},"body":"I suppose it should have a default value: \r\n\r\n```\r\ntype = with types; nullOr str;\r\ndefault = null;\r\n```\r\n","created_at":"2018-06-01T10:01:22Z","updated_at":"2018-06-01T10:02:35Z","html_url":"https://github.com/NixOS/nixpkgs/pull/41343#discussion_r192351449","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/41343","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/192351449"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/41343#discussion_r192351449"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/41343"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/41343","id":191911708,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxOTExNzA4","html_url":"https://github.com/NixOS/nixpkgs/pull/41343","diff_url":"https://github.com/NixOS/nixpkgs/pull/41343.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/41343.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/41343","number":41343,"state":"open","locked":false,"title":"restic: add s3CredentialsFile option","user":{"login":"jerith666","id":854319,"node_id":"MDQ6VXNlcjg1NDMxOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/854319?v=4","gravatar_id":"","url":"https://api.github.com/users/jerith666","html_url":"https://github.com/jerith666","followers_url":"https://api.github.com/users/jerith666/followers","following_url":"https://api.github.com/users/jerith666/following{/other_user}","gists_url":"https://api.github.com/users/jerith666/gists{/gist_id}","starred_url":"https://api.github.com/users/jerith666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerith666/subscriptions","organizations_url":"https://api.github.com/users/jerith666/orgs","repos_url":"https://api.github.com/users/jerith666/repos","events_url":"https://api.github.com/users/jerith666/events{/privacy}","received_events_url":"https://api.github.com/users/jerith666/received_events","type":"User","site_admin":false},"body":"###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).","created_at":"2018-06-01T01:16:02Z","updated_at":"2018-06-01T10:02:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e482cc100b7d12b8a8419ea0dea02f030bb65c7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":737642408,"node_id":"MDU6TGFiZWw3Mzc2NDI0MDg=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%200","name":"10.rebuild-linux: 0","color":"eeffee","default":false},{"id":60265212,"node_id":"MDU6TGFiZWw2MDI2NTIxMg==","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20nixos","name":"6.topic: nixos","color":"fef2c0","default":false},{"id":290122884,"node_id":"MDU6TGFiZWwyOTAxMjI4ODQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20module%20(update)","name":"8.has: module (update)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/41343/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/41343/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/41343/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/44636a86f28910769c64c62c28a8d17df50c21ea","head":{"label":"jerith666:restic-s3","ref":"restic-s3","sha":"44636a86f28910769c64c62c28a8d17df50c21ea","user":{"login":"jerith666","id":854319,"node_id":"MDQ6VXNlcjg1NDMxOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/854319?v=4","gravatar_id":"","url":"https://api.github.com/users/jerith666","html_url":"https://github.com/jerith666","followers_url":"https://api.github.com/users/jerith666/followers","following_url":"https://api.github.com/users/jerith666/following{/other_user}","gists_url":"https://api.github.com/users/jerith666/gists{/gist_id}","starred_url":"https://api.github.com/users/jerith666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerith666/subscriptions","organizations_url":"https://api.github.com/users/jerith666/orgs","repos_url":"https://api.github.com/users/jerith666/repos","events_url":"https://api.github.com/users/jerith666/events{/privacy}","received_events_url":"https://api.github.com/users/jerith666/received_events","type":"User","site_admin":false},"repo":{"id":42969550,"node_id":"MDEwOlJlcG9zaXRvcnk0Mjk2OTU1MA==","name":"nixpkgs","full_name":"jerith666/nixpkgs","owner":{"login":"jerith666","id":854319,"node_id":"MDQ6VXNlcjg1NDMxOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/854319?v=4","gravatar_id":"","url":"https://api.github.com/users/jerith666","html_url":"https://github.com/jerith666","followers_url":"https://api.github.com/users/jerith666/followers","following_url":"https://api.github.com/users/jerith666/following{/other_user}","gists_url":"https://api.github.com/users/jerith666/gists{/gist_id}","starred_url":"https://api.github.com/users/jerith666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerith666/subscriptions","organizations_url":"https://api.github.com/users/jerith666/orgs","repos_url":"https://api.github.com/users/jerith666/repos","events_url":"https://api.github.com/users/jerith666/events{/privacy}","received_events_url":"https://api.github.com/users/jerith666/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jerith666/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/jerith666/nixpkgs","forks_url":"https://api.github.com/repos/jerith666/nixpkgs/forks","keys_url":"https://api.github.com/repos/jerith666/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jerith666/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jerith666/nixpkgs/teams","hooks_url":"https://api.github.com/repos/jerith666/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/jerith666/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/jerith666/nixpkgs/events","assignees_url":"https://api.github.com/repos/jerith666/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/jerith666/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/jerith666/nixpkgs/tags","blobs_url":"https://api.github.com/repos/jerith666/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jerith666/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jerith666/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/jerith666/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jerith666/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/jerith666/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/jerith666/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/jerith666/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/jerith666/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/jerith666/nixpkgs/subscription","commits_url":"https://api.github.com/repos/jerith666/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/jerith666/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/jerith666/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/jerith666/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/jerith666/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/jerith666/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jerith666/nixpkgs/merges","archive_url":"https://api.github.com/repos/jerith666/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jerith666/nixpkgs/downloads","issues_url":"https://api.github.com/repos/jerith666/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/jerith666/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/jerith666/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/jerith666/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jerith666/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/jerith666/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/jerith666/nixpkgs/deployments","created_at":"2015-09-23T00:48:44Z","updated_at":"2015-09-23T00:49:32Z","pushed_at":"2018-06-01T01:15:18Z","git_url":"git://github.com/jerith666/nixpkgs.git","ssh_url":"git@github.com:jerith666/nixpkgs.git","clone_url":"https://github.com/jerith666/nixpkgs.git","svn_url":"https://github.com/jerith666/nixpkgs","homepage":null,"size":708485,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"02b77eaf4a6ff64adc5b1dc664dfadbcaaf8a664","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-06-01T10:02:01Z","pushed_at":"2018-06-01T09:58:48Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":802739,"stargazers_count":2484,"watchers_count":2484,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2801,"mirror_url":null,"archived":false,"open_issues_count":3176,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2801,"open_issues":3176,"watchers":2484,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/41343"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/41343"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/41343"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/41343/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/41343/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/41343/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/44636a86f28910769c64c62c28a8d17df50c21ea"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Mic92"}}