{"action":"created","comment":{"url":"https://api.github.com/repos/decentraland/marketplace/pulls/comments/231574616","pull_request_review_id":172565323,"id":231574616,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTU3NDYxNg==","diff_hunk":"@@ -0,0 +1,21 @@\n+import { connect } from 'react-redux'\n+\n+import { locations } from 'locations'\n+import { navigateTo } from '@dapps/modules/location/actions'\n+import { getAddress } from 'modules/wallet/selectors'\n+import { getData as getAuthorizations } from 'modules/authorization/selectors'\n+\n+import AuctionModal from './AuctionModal'\n+\n+const mapState = state => {\n+  const address = getAddress(state)\n+  const authorization = getAuthorizations(state)[address]\n+","path":"webapp/src/components/Modal/AuctionModal/AuctionModal.container.js","position":13,"original_position":13,"commit_id":"499b689c609649ba4285e2b26a340518973d9cb1","original_commit_id":"499b689c609649ba4285e2b26a340518973d9cb1","user":{"login":"nachomazzara","id":7549152,"node_id":"MDQ6VXNlcjc1NDkxNTI=","avatar_url":"https://avatars0.githubusercontent.com/u/7549152?v=4","gravatar_id":"","url":"https://api.github.com/users/nachomazzara","html_url":"https://github.com/nachomazzara","followers_url":"https://api.github.com/users/nachomazzara/followers","following_url":"https://api.github.com/users/nachomazzara/following{/other_user}","gists_url":"https://api.github.com/users/nachomazzara/gists{/gist_id}","starred_url":"https://api.github.com/users/nachomazzara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nachomazzara/subscriptions","organizations_url":"https://api.github.com/users/nachomazzara/orgs","repos_url":"https://api.github.com/users/nachomazzara/repos","events_url":"https://api.github.com/users/nachomazzara/events{/privacy}","received_events_url":"https://api.github.com/users/nachomazzara/received_events","type":"User","site_admin":false},"body":"If we don't have a case where we care about authoriazations of not the current address. What do you think of moving `getAddress(state)` as part of the` getAuthorizations` selector?\r\n\r\nWe could avoid the need of doing:\r\n\r\n```javascript\r\nconst address = getAddress(state)\r\nconst authorization = getAuthorizations(state)[address]\r\n```\r\n\r\nAnd do just \r\n```javascript\r\nconst authorization = getAuthorizations(state)\r\n```\r\n","created_at":"2018-11-07T16:23:17Z","updated_at":"2018-11-07T16:54:33Z","html_url":"https://github.com/decentraland/marketplace/pull/632#discussion_r231574616","pull_request_url":"https://api.github.com/repos/decentraland/marketplace/pulls/632","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/decentraland/marketplace/pulls/comments/231574616"},"html":{"href":"https://github.com/decentraland/marketplace/pull/632#discussion_r231574616"},"pull_request":{"href":"https://api.github.com/repos/decentraland/marketplace/pulls/632"}}},"pull_request":{"url":"https://api.github.com/repos/decentraland/marketplace/pulls/632","id":227676147,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3Njc2MTQ3","html_url":"https://github.com/decentraland/marketplace/pull/632","diff_url":"https://github.com/decentraland/marketplace/pull/632.diff","patch_url":"https://github.com/decentraland/marketplace/pull/632.patch","issue_url":"https://api.github.com/repos/decentraland/marketplace/issues/632","number":632,"state":"open","locked":false,"title":"feat: auction modal.","user":{"login":"NicoSantangelo","id":692077,"node_id":"MDQ6VXNlcjY5MjA3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/692077?v=4","gravatar_id":"","url":"https://api.github.com/users/NicoSantangelo","html_url":"https://github.com/NicoSantangelo","followers_url":"https://api.github.com/users/NicoSantangelo/followers","following_url":"https://api.github.com/users/NicoSantangelo/following{/other_user}","gists_url":"https://api.github.com/users/NicoSantangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/NicoSantangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicoSantangelo/subscriptions","organizations_url":"https://api.github.com/users/NicoSantangelo/orgs","repos_url":"https://api.github.com/users/NicoSantangelo/repos","events_url":"https://api.github.com/users/NicoSantangelo/events{/privacy}","received_events_url":"https://api.github.com/users/NicoSantangelo/received_events","type":"User","site_admin":false},"body":"Auction modal flow:\r\n\r\n1) If you enter `/auction` for the first time and you don't have the contract authorized, you'll see a button redirecting you to Settings.\r\n2) If you enter `/auction` for the first time and you do have the contract authorized, you'll have a button to start that dismisses the modal\r\n3) If you enter `/auction` for the second time and you didn't interact with the modal you'll see 1 or 2 depending on the initial condition\r\n4) If you enter `/auction` having accepted 2) you won't see anything\r\n\r\nIt also refactors the base modal a bit to keep it consistent, remove unused code and styles and working on all resolutions.\r\n\r\nCloses #632 \r\nContinues #626 ","created_at":"2018-11-01T16:20:56Z","updated_at":"2018-11-07T16:54:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7abf56acae3e73e04cc9b630501c71267fcda676","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/decentraland/marketplace/pulls/632/commits","review_comments_url":"https://api.github.com/repos/decentraland/marketplace/pulls/632/comments","review_comment_url":"https://api.github.com/repos/decentraland/marketplace/pulls/comments{/number}","comments_url":"https://api.github.com/repos/decentraland/marketplace/issues/632/comments","statuses_url":"https://api.github.com/repos/decentraland/marketplace/statuses/499b689c609649ba4285e2b26a340518973d9cb1","head":{"label":"decentraland:feat/auction-modal","ref":"feat/auction-modal","sha":"499b689c609649ba4285e2b26a340518973d9cb1","user":{"login":"decentraland","id":12685795,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjg1Nzk1","avatar_url":"https://avatars3.githubusercontent.com/u/12685795?v=4","gravatar_id":"","url":"https://api.github.com/users/decentraland","html_url":"https://github.com/decentraland","followers_url":"https://api.github.com/users/decentraland/followers","following_url":"https://api.github.com/users/decentraland/following{/other_user}","gists_url":"https://api.github.com/users/decentraland/gists{/gist_id}","starred_url":"https://api.github.com/users/decentraland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decentraland/subscriptions","organizations_url":"https://api.github.com/users/decentraland/orgs","repos_url":"https://api.github.com/users/decentraland/repos","events_url":"https://api.github.com/users/decentraland/events{/privacy}","received_events_url":"https://api.github.com/users/decentraland/received_events","type":"Organization","site_admin":false},"repo":{"id":115438139,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU0MzgxMzk=","name":"marketplace","full_name":"decentraland/marketplace","private":false,"owner":{"login":"decentraland","id":12685795,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjg1Nzk1","avatar_url":"https://avatars3.githubusercontent.com/u/12685795?v=4","gravatar_id":"","url":"https://api.github.com/users/decentraland","html_url":"https://github.com/decentraland","followers_url":"https://api.github.com/users/decentraland/followers","following_url":"https://api.github.com/users/decentraland/following{/other_user}","gists_url":"https://api.github.com/users/decentraland/gists{/gist_id}","starred_url":"https://api.github.com/users/decentraland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decentraland/subscriptions","organizations_url":"https://api.github.com/users/decentraland/orgs","repos_url":"https://api.github.com/users/decentraland/repos","events_url":"https://api.github.com/users/decentraland/events{/privacy}","received_events_url":"https://api.github.com/users/decentraland/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/decentraland/marketplace","description":"🏛️ Decentraland's LAND Marketplace","fork":false,"url":"https://api.github.com/repos/decentraland/marketplace","forks_url":"https://api.github.com/repos/decentraland/marketplace/forks","keys_url":"https://api.github.com/repos/decentraland/marketplace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decentraland/marketplace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decentraland/marketplace/teams","hooks_url":"https://api.github.com/repos/decentraland/marketplace/hooks","issue_events_url":"https://api.github.com/repos/decentraland/marketplace/issues/events{/number}","events_url":"https://api.github.com/repos/decentraland/marketplace/events","assignees_url":"https://api.github.com/repos/decentraland/marketplace/assignees{/user}","branches_url":"https://api.github.com/repos/decentraland/marketplace/branches{/branch}","tags_url":"https://api.github.com/repos/decentraland/marketplace/tags","blobs_url":"https://api.github.com/repos/decentraland/marketplace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decentraland/marketplace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decentraland/marketplace/git/refs{/sha}","trees_url":"https://api.github.com/repos/decentraland/marketplace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decentraland/marketplace/statuses/{sha}","languages_url":"https://api.github.com/repos/decentraland/marketplace/languages","stargazers_url":"https://api.github.com/repos/decentraland/marketplace/stargazers","contributors_url":"https://api.github.com/repos/decentraland/marketplace/contributors","subscribers_url":"https://api.github.com/repos/decentraland/marketplace/subscribers","subscription_url":"https://api.github.com/repos/decentraland/marketplace/subscription","commits_url":"https://api.github.com/repos/decentraland/marketplace/commits{/sha}","git_commits_url":"https://api.github.com/repos/decentraland/marketplace/git/commits{/sha}","comments_url":"https://api.github.com/repos/decentraland/marketplace/comments{/number}","issue_comment_url":"https://api.github.com/repos/decentraland/marketplace/issues/comments{/number}","contents_url":"https://api.github.com/repos/decentraland/marketplace/contents/{+path}","compare_url":"https://api.github.com/repos/decentraland/marketplace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decentraland/marketplace/merges","archive_url":"https://api.github.com/repos/decentraland/marketplace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decentraland/marketplace/downloads","issues_url":"https://api.github.com/repos/decentraland/marketplace/issues{/number}","pulls_url":"https://api.github.com/repos/decentraland/marketplace/pulls{/number}","milestones_url":"https://api.github.com/repos/decentraland/marketplace/milestones{/number}","notifications_url":"https://api.github.com/repos/decentraland/marketplace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decentraland/marketplace/labels{/name}","releases_url":"https://api.github.com/repos/decentraland/marketplace/releases{/id}","deployments_url":"https://api.github.com/repos/decentraland/marketplace/deployments","created_at":"2017-12-26T16:31:44Z","updated_at":"2018-11-07T15:15:16Z","pushed_at":"2018-11-07T15:41:20Z","git_url":"git://github.com/decentraland/marketplace.git","ssh_url":"git@github.com:decentraland/marketplace.git","clone_url":"https://github.com/decentraland/marketplace.git","svn_url":"https://github.com/decentraland/marketplace","homepage":"https://market.decentraland.org","size":9611,"stargazers_count":79,"watchers_count":79,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":23,"open_issues":49,"watchers":79,"default_branch":"master"}},"base":{"label":"decentraland:master","ref":"master","sha":"84b3a6d81507f6927df1397dbfeb277a5c8b5877","user":{"login":"decentraland","id":12685795,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjg1Nzk1","avatar_url":"https://avatars3.githubusercontent.com/u/12685795?v=4","gravatar_id":"","url":"https://api.github.com/users/decentraland","html_url":"https://github.com/decentraland","followers_url":"https://api.github.com/users/decentraland/followers","following_url":"https://api.github.com/users/decentraland/following{/other_user}","gists_url":"https://api.github.com/users/decentraland/gists{/gist_id}","starred_url":"https://api.github.com/users/decentraland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decentraland/subscriptions","organizations_url":"https://api.github.com/users/decentraland/orgs","repos_url":"https://api.github.com/users/decentraland/repos","events_url":"https://api.github.com/users/decentraland/events{/privacy}","received_events_url":"https://api.github.com/users/decentraland/received_events","type":"Organization","site_admin":false},"repo":{"id":115438139,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU0MzgxMzk=","name":"marketplace","full_name":"decentraland/marketplace","private":false,"owner":{"login":"decentraland","id":12685795,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjg1Nzk1","avatar_url":"https://avatars3.githubusercontent.com/u/12685795?v=4","gravatar_id":"","url":"https://api.github.com/users/decentraland","html_url":"https://github.com/decentraland","followers_url":"https://api.github.com/users/decentraland/followers","following_url":"https://api.github.com/users/decentraland/following{/other_user}","gists_url":"https://api.github.com/users/decentraland/gists{/gist_id}","starred_url":"https://api.github.com/users/decentraland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decentraland/subscriptions","organizations_url":"https://api.github.com/users/decentraland/orgs","repos_url":"https://api.github.com/users/decentraland/repos","events_url":"https://api.github.com/users/decentraland/events{/privacy}","received_events_url":"https://api.github.com/users/decentraland/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/decentraland/marketplace","description":"🏛️ Decentraland's LAND Marketplace","fork":false,"url":"https://api.github.com/repos/decentraland/marketplace","forks_url":"https://api.github.com/repos/decentraland/marketplace/forks","keys_url":"https://api.github.com/repos/decentraland/marketplace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decentraland/marketplace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decentraland/marketplace/teams","hooks_url":"https://api.github.com/repos/decentraland/marketplace/hooks","issue_events_url":"https://api.github.com/repos/decentraland/marketplace/issues/events{/number}","events_url":"https://api.github.com/repos/decentraland/marketplace/events","assignees_url":"https://api.github.com/repos/decentraland/marketplace/assignees{/user}","branches_url":"https://api.github.com/repos/decentraland/marketplace/branches{/branch}","tags_url":"https://api.github.com/repos/decentraland/marketplace/tags","blobs_url":"https://api.github.com/repos/decentraland/marketplace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decentraland/marketplace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decentraland/marketplace/git/refs{/sha}","trees_url":"https://api.github.com/repos/decentraland/marketplace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decentraland/marketplace/statuses/{sha}","languages_url":"https://api.github.com/repos/decentraland/marketplace/languages","stargazers_url":"https://api.github.com/repos/decentraland/marketplace/stargazers","contributors_url":"https://api.github.com/repos/decentraland/marketplace/contributors","subscribers_url":"https://api.github.com/repos/decentraland/marketplace/subscribers","subscription_url":"https://api.github.com/repos/decentraland/marketplace/subscription","commits_url":"https://api.github.com/repos/decentraland/marketplace/commits{/sha}","git_commits_url":"https://api.github.com/repos/decentraland/marketplace/git/commits{/sha}","comments_url":"https://api.github.com/repos/decentraland/marketplace/comments{/number}","issue_comment_url":"https://api.github.com/repos/decentraland/marketplace/issues/comments{/number}","contents_url":"https://api.github.com/repos/decentraland/marketplace/contents/{+path}","compare_url":"https://api.github.com/repos/decentraland/marketplace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decentraland/marketplace/merges","archive_url":"https://api.github.com/repos/decentraland/marketplace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decentraland/marketplace/downloads","issues_url":"https://api.github.com/repos/decentraland/marketplace/issues{/number}","pulls_url":"https://api.github.com/repos/decentraland/marketplace/pulls{/number}","milestones_url":"https://api.github.com/repos/decentraland/marketplace/milestones{/number}","notifications_url":"https://api.github.com/repos/decentraland/marketplace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decentraland/marketplace/labels{/name}","releases_url":"https://api.github.com/repos/decentraland/marketplace/releases{/id}","deployments_url":"https://api.github.com/repos/decentraland/marketplace/deployments","created_at":"2017-12-26T16:31:44Z","updated_at":"2018-11-07T15:15:16Z","pushed_at":"2018-11-07T15:41:20Z","git_url":"git://github.com/decentraland/marketplace.git","ssh_url":"git@github.com:decentraland/marketplace.git","clone_url":"https://github.com/decentraland/marketplace.git","svn_url":"https://github.com/decentraland/marketplace","homepage":"https://market.decentraland.org","size":9611,"stargazers_count":79,"watchers_count":79,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":23,"open_issues":49,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/decentraland/marketplace/pulls/632"},"html":{"href":"https://github.com/decentraland/marketplace/pull/632"},"issue":{"href":"https://api.github.com/repos/decentraland/marketplace/issues/632"},"comments":{"href":"https://api.github.com/repos/decentraland/marketplace/issues/632/comments"},"review_comments":{"href":"https://api.github.com/repos/decentraland/marketplace/pulls/632/comments"},"review_comment":{"href":"https://api.github.com/repos/decentraland/marketplace/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/decentraland/marketplace/pulls/632/commits"},"statuses":{"href":"https://api.github.com/repos/decentraland/marketplace/statuses/499b689c609649ba4285e2b26a340518973d9cb1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nachomazzara"}}