{"action":"created","issue":{"url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/issues/894","repository_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge","labels_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/issues/894/labels{/name}","comments_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/issues/894/comments","events_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/issues/894/events","html_url":"https://github.com/RSS-Bridge/rss-bridge/pull/894","id":374971112,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NTI0NjAw","number":894,"title":"[core] Added IGNORE_CUSTOM_CACHE_TIMEOUT option","user":{"login":"em92","id":15870400,"node_id":"MDQ6VXNlcjE1ODcwNDAw","avatar_url":"https://avatars3.githubusercontent.com/u/15870400?v=4","gravatar_id":"","url":"https://api.github.com/users/em92","html_url":"https://github.com/em92","followers_url":"https://api.github.com/users/em92/followers","following_url":"https://api.github.com/users/em92/following{/other_user}","gists_url":"https://api.github.com/users/em92/gists{/gist_id}","starred_url":"https://api.github.com/users/em92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/em92/subscriptions","organizations_url":"https://api.github.com/users/em92/orgs","repos_url":"https://api.github.com/users/em92/repos","events_url":"https://api.github.com/users/em92/events{/privacy}","received_events_url":"https://api.github.com/users/em92/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-29T11:27:08Z","updated_at":"2018-11-12T17:57:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/pulls/894","html_url":"https://github.com/RSS-Bridge/rss-bridge/pull/894","diff_url":"https://github.com/RSS-Bridge/rss-bridge/pull/894.diff","patch_url":"https://github.com/RSS-Bridge/rss-bridge/pull/894.patch"},"body":"Explaining my usecase. For some reason I enabled custom_timeout in my config, but forgot to disable it back. Meanwhile some users already generated feed urls with _cache_timeout parameters. So if I disable custom_timeout back, those feed urls become invalid, which is not good.\r\n\r\nSo, I added option to ignore _cache_timeout param in url."},"comment":{"url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/issues/comments/437973637","html_url":"https://github.com/RSS-Bridge/rss-bridge/pull/894#issuecomment-437973637","issue_url":"https://api.github.com/repos/RSS-Bridge/rss-bridge/issues/894","id":437973637,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzk3MzYzNw==","user":{"login":"LogMANOriginal","id":5776685,"node_id":"MDQ6VXNlcjU3NzY2ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/5776685?v=4","gravatar_id":"","url":"https://api.github.com/users/LogMANOriginal","html_url":"https://github.com/LogMANOriginal","followers_url":"https://api.github.com/users/LogMANOriginal/followers","following_url":"https://api.github.com/users/LogMANOriginal/following{/other_user}","gists_url":"https://api.github.com/users/LogMANOriginal/gists{/gist_id}","starred_url":"https://api.github.com/users/LogMANOriginal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LogMANOriginal/subscriptions","organizations_url":"https://api.github.com/users/LogMANOriginal/orgs","repos_url":"https://api.github.com/users/LogMANOriginal/repos","events_url":"https://api.github.com/users/LogMANOriginal/events{/privacy}","received_events_url":"https://api.github.com/users/LogMANOriginal/received_events","type":"User","site_admin":false},"created_at":"2018-11-12T17:57:43Z","updated_at":"2018-11-12T17:57:43Z","author_association":"MEMBER","body":"Almost. Maybe I should have explained myself better. \r\n\r\nYou can remove `ignore_custom_timeout` entirely and just assume, that `custom_timeout = false` implies `ignore_custom_timeout = true`. That way, you only need to replace this line:\r\n\r\nhttps://github.com/RSS-Bridge/rss-bridge/blob/78c69b08f0f544e0eb0caa16ae94771eabd33764/index.php#L129\r\n\r\nby this:\r\n\r\n```PHP\r\nunset($params['_cache_timeout']);\r\nheader('Location: ' . parse_url($_SERVER['REQUEST_URI'], PHP_URL_PATH) . '?' . http_build_query($params), true, 301);\r\ndie();\r\n```\r\n\r\nSo, if `custom_timeout = true`, everything works fine.\r\nIf `custom_timeout = false`, everyone gets redirected."}}
{"actor":{"display_login":"LogMANOriginal"}}