{"action":"closed","issue":{"url":"https://api.github.com/repos/ClickerMonkey/dayspan-vuetify/issues/99","repository_url":"https://api.github.com/repos/ClickerMonkey/dayspan-vuetify","labels_url":"https://api.github.com/repos/ClickerMonkey/dayspan-vuetify/issues/99/labels{/name}","comments_url":"https://api.github.com/repos/ClickerMonkey/dayspan-vuetify/issues/99/comments","events_url":"https://api.github.com/repos/ClickerMonkey/dayspan-vuetify/issues/99/events","html_url":"https://github.com/ClickerMonkey/dayspan-vuetify/issues/99","id":371971201,"node_id":"MDU6SXNzdWUzNzE5NzEyMDE=","number":99,"title":"Use \"seconds\" as durationUnit","user":{"login":"mtx-z","id":2423235,"node_id":"MDQ6VXNlcjI0MjMyMzU=","avatar_url":"https://avatars2.githubusercontent.com/u/2423235?v=4","gravatar_id":"","url":"https://api.github.com/users/mtx-z","html_url":"https://github.com/mtx-z","followers_url":"https://api.github.com/users/mtx-z/followers","following_url":"https://api.github.com/users/mtx-z/following{/other_user}","gists_url":"https://api.github.com/users/mtx-z/gists{/gist_id}","starred_url":"https://api.github.com/users/mtx-z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtx-z/subscriptions","organizations_url":"https://api.github.com/users/mtx-z/orgs","repos_url":"https://api.github.com/users/mtx-z/repos","events_url":"https://api.github.com/users/mtx-z/events{/privacy}","received_events_url":"https://api.github.com/users/mtx-z/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-10-19T14:02:07Z","updated_at":"2018-10-26T02:04:39Z","closed_at":"2018-10-26T02:04:39Z","author_association":"NONE","body":"Hello,\r\n\r\nI'm trying to use \"seconds\" as durationUnit, and so my `duration` attribute contains a number of second. \r\nIt seems to work for the calendar, but the popup fail as there's a missing label:\r\n\r\nThe following fails as `labels['seconds']` does not exist: \r\n\r\n```\r\ngetEventDuration(schedule, labels)\r\n    {\r\n      let units = labels[ schedule.durationUnit ];\r\n      let length = schedule.duration;\r\n      let chosenUnit = length === 1 ? units[ 0 ] : units[ 1 ];\r\n      let duration = length + ' ' + chosenUnit;\r\n\r\n      return duration;\r\n    }\r\n```\r\n(node_modules\\dayspan-vuetify\\src\\component.js)\r\n\r\nI tried adding it to the locale EN using, but even existing overrides do not seem to work:\r\n\r\n```\r\nVue.$dayspan.updateLocale('en', {\r\n    defaults: {\r\n        dsAgendaEvent: {\r\n            labels: {\r\n                second: ['second', 'seconds'], //throw error vue-app.js:6082 Uncaught Incompatible locale data at .defaults.dsAgendaEvent.labels.seconds\r\n                seconds: ['second', 'seconds'], //throw error vue-app.js:6082 Uncaught Incompatible locale data at .defaults.dsAgendaEvent.labels.seconds\r\n                day: ['test', 'tests'], //not seems to work\r\n                days: ['test', 'tests'], //not seems to work\r\n            }\r\n        },\r\n    }\r\n});\r\n```\r\n\r\nAfter I tried to override `day` and `days` translation, logging `labels` variable in `getEventDuration()` still gives default values from `en.js`. \r\n\r\nIs there something I'm missing? \r\n\r\nThanks"}}
{"actor":{"display_login":"ClickerMonkey"}}