{"action":"closed","number":977,"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-azure/pulls/977","id":242165618,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMTY1NjE4","html_url":"https://github.com/openshift/openshift-azure/pull/977","diff_url":"https://github.com/openshift/openshift-azure/pull/977.diff","patch_url":"https://github.com/openshift/openshift-azure/pull/977.patch","issue_url":"https://api.github.com/repos/openshift/openshift-azure/issues/977","number":977,"state":"closed","locked":false,"title":"roll a lot of Future code into azureclient","user":{"login":"jim-minter","id":1038301,"node_id":"MDQ6VXNlcjEwMzgzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1038301?v=4","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},"body":"This PR is one additional commit on top of #976 - I've come round to the idea of abstracting away azure Futures in pkg/util/azureclient - to me, the benefit (very substantially easier-to-understand unit tests) vastly exceeds the downside.","created_at":"2019-01-04T03:12:42Z","updated_at":"2019-01-05T03:15:46Z","closed_at":"2019-01-05T03:15:46Z","merged_at":"2019-01-05T03:15:46Z","merge_commit_sha":"7b5db24e27101236b0e366e543f89ea7e95db738","assignee":{"login":"kargakis","id":3900799,"node_id":"MDQ6VXNlcjM5MDA3OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/3900799?v=4","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"kargakis","id":3900799,"node_id":"MDQ6VXNlcjM5MDA3OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/3900799?v=4","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"asalkeld","id":420707,"node_id":"MDQ6VXNlcjQyMDcwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/420707?v=4","gravatar_id":"","url":"https://api.github.com/users/asalkeld","html_url":"https://github.com/asalkeld","followers_url":"https://api.github.com/users/asalkeld/followers","following_url":"https://api.github.com/users/asalkeld/following{/other_user}","gists_url":"https://api.github.com/users/asalkeld/gists{/gist_id}","starred_url":"https://api.github.com/users/asalkeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asalkeld/subscriptions","organizations_url":"https://api.github.com/users/asalkeld/orgs","repos_url":"https://api.github.com/users/asalkeld/repos","events_url":"https://api.github.com/users/asalkeld/events{/privacy}","received_events_url":"https://api.github.com/users/asalkeld/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1006544929,"node_id":"MDU6TGFiZWwxMDA2NTQ0OTI5","url":"https://api.github.com/repos/openshift/openshift-azure/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":1006545045,"node_id":"MDU6TGFiZWwxMDA2NTQ1MDQ1","url":"https://api.github.com/repos/openshift/openshift-azure/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":1006543190,"node_id":"MDU6TGFiZWwxMDA2NTQzMTkw","url":"https://api.github.com/repos/openshift/openshift-azure/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-azure/pulls/977/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-azure/pulls/977/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-azure/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-azure/issues/977/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-azure/statuses/5640f8eba4ef9ceb68b8339354f750fe98409027","head":{"label":"jim-minter:upgrade4","ref":"upgrade4","sha":"5640f8eba4ef9ceb68b8339354f750fe98409027","user":{"login":"jim-minter","id":1038301,"node_id":"MDQ6VXNlcjEwMzgzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1038301?v=4","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},"repo":{"id":142488214,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI0ODgyMTQ=","name":"openshift-azure","full_name":"jim-minter/openshift-azure","private":false,"owner":{"login":"jim-minter","id":1038301,"node_id":"MDQ6VXNlcjEwMzgzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1038301?v=4","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jim-minter/openshift-azure","description":null,"fork":true,"url":"https://api.github.com/repos/jim-minter/openshift-azure","forks_url":"https://api.github.com/repos/jim-minter/openshift-azure/forks","keys_url":"https://api.github.com/repos/jim-minter/openshift-azure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jim-minter/openshift-azure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jim-minter/openshift-azure/teams","hooks_url":"https://api.github.com/repos/jim-minter/openshift-azure/hooks","issue_events_url":"https://api.github.com/repos/jim-minter/openshift-azure/issues/events{/number}","events_url":"https://api.github.com/repos/jim-minter/openshift-azure/events","assignees_url":"https://api.github.com/repos/jim-minter/openshift-azure/assignees{/user}","branches_url":"https://api.github.com/repos/jim-minter/openshift-azure/branches{/branch}","tags_url":"https://api.github.com/repos/jim-minter/openshift-azure/tags","blobs_url":"https://api.github.com/repos/jim-minter/openshift-azure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jim-minter/openshift-azure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jim-minter/openshift-azure/git/refs{/sha}","trees_url":"https://api.github.com/repos/jim-minter/openshift-azure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jim-minter/openshift-azure/statuses/{sha}","languages_url":"https://api.github.com/repos/jim-minter/openshift-azure/languages","stargazers_url":"https://api.github.com/repos/jim-minter/openshift-azure/stargazers","contributors_url":"https://api.github.com/repos/jim-minter/openshift-azure/contributors","subscribers_url":"https://api.github.com/repos/jim-minter/openshift-azure/subscribers","subscription_url":"https://api.github.com/repos/jim-minter/openshift-azure/subscription","commits_url":"https://api.github.com/repos/jim-minter/openshift-azure/commits{/sha}","git_commits_url":"https://api.github.com/repos/jim-minter/openshift-azure/git/commits{/sha}","comments_url":"https://api.github.com/repos/jim-minter/openshift-azure/comments{/number}","issue_comment_url":"https://api.github.com/repos/jim-minter/openshift-azure/issues/comments{/number}","contents_url":"https://api.github.com/repos/jim-minter/openshift-azure/contents/{+path}","compare_url":"https://api.github.com/repos/jim-minter/openshift-azure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jim-minter/openshift-azure/merges","archive_url":"https://api.github.com/repos/jim-minter/openshift-azure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jim-minter/openshift-azure/downloads","issues_url":"https://api.github.com/repos/jim-minter/openshift-azure/issues{/number}","pulls_url":"https://api.github.com/repos/jim-minter/openshift-azure/pulls{/number}","milestones_url":"https://api.github.com/repos/jim-minter/openshift-azure/milestones{/number}","notifications_url":"https://api.github.com/repos/jim-minter/openshift-azure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jim-minter/openshift-azure/labels{/name}","releases_url":"https://api.github.com/repos/jim-minter/openshift-azure/releases{/id}","deployments_url":"https://api.github.com/repos/jim-minter/openshift-azure/deployments","created_at":"2018-07-26T19:59:36Z","updated_at":"2019-01-04T14:10:59Z","pushed_at":"2019-01-04T14:10:57Z","git_url":"git://github.com/jim-minter/openshift-azure.git","ssh_url":"git@github.com:jim-minter/openshift-azure.git","clone_url":"https://github.com/jim-minter/openshift-azure.git","svn_url":"https://github.com/jim-minter/openshift-azure","homepage":null,"size":39121,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"e57629f4114fe409c7d138fd1d4794de30278ea5","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":137828518,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc4Mjg1MTg=","name":"openshift-azure","full_name":"openshift/openshift-azure","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/openshift-azure","description":null,"fork":false,"url":"https://api.github.com/repos/openshift/openshift-azure","forks_url":"https://api.github.com/repos/openshift/openshift-azure/forks","keys_url":"https://api.github.com/repos/openshift/openshift-azure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-azure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-azure/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-azure/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-azure/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-azure/events","assignees_url":"https://api.github.com/repos/openshift/openshift-azure/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-azure/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-azure/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-azure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-azure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-azure/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-azure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-azure/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-azure/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-azure/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-azure/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-azure/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-azure/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-azure/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-azure/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-azure/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-azure/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-azure/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-azure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-azure/merges","archive_url":"https://api.github.com/repos/openshift/openshift-azure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-azure/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-azure/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-azure/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-azure/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-azure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-azure/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-azure/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-azure/deployments","created_at":"2018-06-19T02:11:07Z","updated_at":"2019-01-04T14:00:47Z","pushed_at":"2019-01-05T03:15:46Z","git_url":"git://github.com/openshift/openshift-azure.git","ssh_url":"git@github.com:openshift/openshift-azure.git","clone_url":"https://github.com/openshift/openshift-azure.git","svn_url":"https://github.com/openshift/openshift-azure","homepage":null,"size":38955,"stargazers_count":14,"watchers_count":14,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":97,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":23,"open_issues":97,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/977"},"html":{"href":"https://github.com/openshift/openshift-azure/pull/977"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-azure/issues/977"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-azure/issues/977/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/977/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-azure/pulls/977/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-azure/statuses/5640f8eba4ef9ceb68b8339354f750fe98409027"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"openshift-merge-robot","id":30189218,"node_id":"MDQ6VXNlcjMwMTg5MjE4","avatar_url":"https://avatars0.githubusercontent.com/u/30189218?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-merge-robot","html_url":"https://github.com/openshift-merge-robot","followers_url":"https://api.github.com/users/openshift-merge-robot/followers","following_url":"https://api.github.com/users/openshift-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-merge-robot/orgs","repos_url":"https://api.github.com/users/openshift-merge-robot/repos","events_url":"https://api.github.com/users/openshift-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-merge-robot/received_events","type":"User","site_admin":false},"comments":8,"review_comments":0,"maintainer_can_modify":false,"commits":17,"additions":622,"deletions":402,"changed_files":33}}
{"actor":{"display_login":"openshift-merge-robot"}}