{"action":"created","issue":{"url":"https://api.github.com/repos/pytorch/ignite/issues/221","repository_url":"https://api.github.com/repos/pytorch/ignite","labels_url":"https://api.github.com/repos/pytorch/ignite/issues/221/labels{/name}","comments_url":"https://api.github.com/repos/pytorch/ignite/issues/221/comments","events_url":"https://api.github.com/repos/pytorch/ignite/issues/221/events","html_url":"https://github.com/pytorch/ignite/issues/221","id":347122308,"node_id":"MDU6SXNzdWUzNDcxMjIzMDg=","number":221,"title":"[Feature Request] Apply `detach` to `y_pred` in metrics","user":{"login":"vfdev-5","id":2459423,"node_id":"MDQ6VXNlcjI0NTk0MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/2459423?v=4","gravatar_id":"","url":"https://api.github.com/users/vfdev-5","html_url":"https://github.com/vfdev-5","followers_url":"https://api.github.com/users/vfdev-5/followers","following_url":"https://api.github.com/users/vfdev-5/following{/other_user}","gists_url":"https://api.github.com/users/vfdev-5/gists{/gist_id}","starred_url":"https://api.github.com/users/vfdev-5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vfdev-5/subscriptions","organizations_url":"https://api.github.com/users/vfdev-5/orgs","repos_url":"https://api.github.com/users/vfdev-5/repos","events_url":"https://api.github.com/users/vfdev-5/events{/privacy}","received_events_url":"https://api.github.com/users/vfdev-5/received_events","type":"User","site_admin":false},"labels":[{"id":759300265,"node_id":"MDU6TGFiZWw3NTkzMDAyNjU=","url":"https://api.github.com/repos/pytorch/ignite/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":759300267,"node_id":"MDU6TGFiZWw3NTkzMDAyNjc=","url":"https://api.github.com/repos/pytorch/ignite/labels/good%20first%20issue","name":"good first issue","color":"7057ff","default":true},{"id":759300266,"node_id":"MDU6TGFiZWw3NTkzMDAyNjY=","url":"https://api.github.com/repos/pytorch/ignite/labels/help%20wanted","name":"help wanted","color":"33aa3f","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-08-02T18:21:31Z","updated_at":"2018-08-08T06:12:43Z","closed_at":null,"author_association":"COLLABORATOR","body":"Following the discussion in slack:\r\n\r\nvfdev : \r\nIn some sense currently we have probably a protection as metrics are computed in \r\nevaluator that calls with `torch.no_grad()` so there is no graph built \r\neven after in metric's update methods. However in general case we need \r\nto reconsider that... \r\n\r\nJason Kriss :\r\nAh yea, I guess since we do support accumulating metrics on a trainer (and not just an evaluator) we need to handle this.\r\n"},"comment":{"url":"https://api.github.com/repos/pytorch/ignite/issues/comments/411297355","html_url":"https://github.com/pytorch/ignite/issues/221#issuecomment-411297355","issue_url":"https://api.github.com/repos/pytorch/ignite/issues/221","id":411297355,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTI5NzM1NQ==","user":{"login":"vfdev-5","id":2459423,"node_id":"MDQ6VXNlcjI0NTk0MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/2459423?v=4","gravatar_id":"","url":"https://api.github.com/users/vfdev-5","html_url":"https://github.com/vfdev-5","followers_url":"https://api.github.com/users/vfdev-5/followers","following_url":"https://api.github.com/users/vfdev-5/following{/other_user}","gists_url":"https://api.github.com/users/vfdev-5/gists{/gist_id}","starred_url":"https://api.github.com/users/vfdev-5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vfdev-5/subscriptions","organizations_url":"https://api.github.com/users/vfdev-5/orgs","repos_url":"https://api.github.com/users/vfdev-5/repos","events_url":"https://api.github.com/users/vfdev-5/events{/privacy}","received_events_url":"https://api.github.com/users/vfdev-5/received_events","type":"User","site_admin":false},"created_at":"2018-08-08T06:12:43Z","updated_at":"2018-08-08T06:12:43Z","author_association":"COLLABORATOR","body":"> Is help wanted for this issue? Can I help?\r\n\r\n@anmolsjoshi Thanks ! Yes, you can go ahead with this issue. The idea is to incorporate `torch.no_grad` somewhere in `Metrics` a \"less intrusive\" manner.\r\n"}}
{"actor":{"display_login":"vfdev-5"}}