{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/pulls/comments/198196321","pull_request_review_id":131929001,"id":198196321,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODE5NjMyMQ==","diff_hunk":"@@ -0,0 +1,109 @@\n+## Variables\n+\n+variable \"additional_tags\" {\n+  type        = \"map\"\n+  description = \"Stack specific tags to apply\"\n+  default     = {}\n+}\n+\n+variable \"aws_region\" {\n+  type        = \"string\"\n+  description = \"AWS region\"\n+  default     = \"eu-west-1\"\n+}\n+\n+variable \"remote_state_bucket\" {\n+  type        = \"string\"\n+  description = \"S3 bucket we store our terraform state in\"\n+  default     = \"ecs-monitoring\"\n+}\n+\n+variable \"stack_name\" {\n+  type        = \"string\"\n+  description = \"Unique name for this collection of resources\"\n+  default     = \"ecs-monitoring\"\n+}\n+\n+variable \"enable_jumpbox\" {\n+  type        = \"string\"\n+  description = \"Boolean, when true a jumpbox will be deployed\"\n+  default     = false","path":"terraform/projects/infra-jump-instance/main.tf","position":30,"original_position":30,"commit_id":"0fe2be8e8a6554a5272b7919adbae605eef15ce9","original_commit_id":"0fe2be8e8a6554a5272b7919adbae605eef15ce9","user":{"login":"idavidmcdonald","id":7228605,"node_id":"MDQ6VXNlcjcyMjg2MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/7228605?v=4","gravatar_id":"","url":"https://api.github.com/users/idavidmcdonald","html_url":"https://github.com/idavidmcdonald","followers_url":"https://api.github.com/users/idavidmcdonald/followers","following_url":"https://api.github.com/users/idavidmcdonald/following{/other_user}","gists_url":"https://api.github.com/users/idavidmcdonald/gists{/gist_id}","starred_url":"https://api.github.com/users/idavidmcdonald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idavidmcdonald/subscriptions","organizations_url":"https://api.github.com/users/idavidmcdonald/orgs","repos_url":"https://api.github.com/users/idavidmcdonald/repos","events_url":"https://api.github.com/users/idavidmcdonald/events{/privacy}","received_events_url":"https://api.github.com/users/idavidmcdonald/received_events","type":"User","site_admin":false},"body":"https://www.terraform.io/docs/configuration/variables.html#booleans","created_at":"2018-06-26T15:41:07Z","updated_at":"2018-06-26T15:49:50Z","html_url":"https://github.com/alphagov/prometheus-aws-configuration-beta/pull/18#discussion_r198196321","pull_request_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/pulls/18","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/pulls/comments/198196321"},"html":{"href":"https://github.com/alphagov/prometheus-aws-configuration-beta/pull/18#discussion_r198196321"},"pull_request":{"href":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/pulls/18","id":190271698,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwMjcxNjk4","html_url":"https://github.com/alphagov/prometheus-aws-configuration-beta/pull/18","diff_url":"https://github.com/alphagov/prometheus-aws-configuration-beta/pull/18.diff","patch_url":"https://github.com/alphagov/prometheus-aws-configuration-beta/pull/18.patch","issue_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/issues/18","number":18,"state":"open","locked":false,"title":"Add a Jumpbox to dev stacks","user":{"login":"ejrowley","id":670851,"node_id":"MDQ6VXNlcjY3MDg1MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/670851?v=4","gravatar_id":"","url":"https://api.github.com/users/ejrowley","html_url":"https://github.com/ejrowley","followers_url":"https://api.github.com/users/ejrowley/followers","following_url":"https://api.github.com/users/ejrowley/following{/other_user}","gists_url":"https://api.github.com/users/ejrowley/gists{/gist_id}","starred_url":"https://api.github.com/users/ejrowley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejrowley/subscriptions","organizations_url":"https://api.github.com/users/ejrowley/orgs","repos_url":"https://api.github.com/users/ejrowley/repos","events_url":"https://api.github.com/users/ejrowley/events{/privacy}","received_events_url":"https://api.github.com/users/ejrowley/received_events","type":"User","site_admin":false},"body":"An ssh key is created based on the users public key (it assumes the\r\nusers public key is available as `~/.ssh/id_rsa.pub`), so at the moment connecting to the instance is only available for the user who is applying the jumpbox project.\r\n\r\nIn order to get the jumpbox to work you will need to ensure that you have `jq` installed and you allow your ssh key to be forwarded, details of which can be found in the README.\r\n\r\nIt's be a good idea to start with a fresh stack in order to ensure that your ssh key is being forwarded to the EC2 instance, so if you have an existing stack to destroy it and then apply the terraform to build it again.\r\n\r\nTo connect to the EC2 instance, rather than jumping onto the jumpbox and then ssh-ing on the the instance the `make jump` task will do both steps for you, you will just need to give permission to access the jumpbox and EC2 instance once unless the jumpbox / instance IP addresses change.","created_at":"2018-05-24T12:28:29Z","updated_at":"2018-06-26T15:49:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8bc1ad69bd1bcf0c34a8001025b964ce87cc2271","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/pulls/18/commits","review_comments_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/pulls/18/comments","review_comment_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/issues/18/comments","statuses_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/statuses/0fe2be8e8a6554a5272b7919adbae605eef15ce9","head":{"label":"alphagov:add_jumpbox","ref":"add_jumpbox","sha":"0fe2be8e8a6554a5272b7919adbae605eef15ce9","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":131585686,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE1ODU2ODY=","name":"prometheus-aws-configuration-beta","full_name":"alphagov/prometheus-aws-configuration-beta","owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/prometheus-aws-configuration-beta","description":"Terraform configuration to manage a Prometheus server running on AWS.","fork":false,"url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta","forks_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/forks","keys_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/teams","hooks_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/hooks","issue_events_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/events","assignees_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/tags","blobs_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/languages","stargazers_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/stargazers","contributors_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/contributors","subscribers_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/subscribers","subscription_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/subscription","commits_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/merges","archive_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/downloads","issues_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/deployments","created_at":"2018-04-30T11:04:47Z","updated_at":"2018-06-21T14:33:59Z","pushed_at":"2018-06-26T15:49:03Z","git_url":"git://github.com/alphagov/prometheus-aws-configuration-beta.git","ssh_url":"git@github.com:alphagov/prometheus-aws-configuration-beta.git","clone_url":"https://github.com/alphagov/prometheus-aws-configuration-beta.git","svn_url":"https://github.com/alphagov/prometheus-aws-configuration-beta","homepage":null,"size":273,"stargazers_count":1,"watchers_count":1,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"b8f78e790777f963748a10d774d1716098683cc0","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":131585686,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE1ODU2ODY=","name":"prometheus-aws-configuration-beta","full_name":"alphagov/prometheus-aws-configuration-beta","owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/prometheus-aws-configuration-beta","description":"Terraform configuration to manage a Prometheus server running on AWS.","fork":false,"url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta","forks_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/forks","keys_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/teams","hooks_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/hooks","issue_events_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/events","assignees_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/tags","blobs_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/languages","stargazers_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/stargazers","contributors_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/contributors","subscribers_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/subscribers","subscription_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/subscription","commits_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/merges","archive_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/downloads","issues_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/deployments","created_at":"2018-04-30T11:04:47Z","updated_at":"2018-06-21T14:33:59Z","pushed_at":"2018-06-26T15:49:03Z","git_url":"git://github.com/alphagov/prometheus-aws-configuration-beta.git","ssh_url":"git@github.com:alphagov/prometheus-aws-configuration-beta.git","clone_url":"https://github.com/alphagov/prometheus-aws-configuration-beta.git","svn_url":"https://github.com/alphagov/prometheus-aws-configuration-beta","homepage":null,"size":273,"stargazers_count":1,"watchers_count":1,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/pulls/18"},"html":{"href":"https://github.com/alphagov/prometheus-aws-configuration-beta/pull/18"},"issue":{"href":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/issues/18"},"comments":{"href":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/statuses/0fe2be8e8a6554a5272b7919adbae605eef15ce9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"idavidmcdonald"}}