{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/omarvides/crud-challenge-backend/pulls/2","id":241092978,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMDkyOTc4","html_url":"https://github.com/omarvides/crud-challenge-backend/pull/2","diff_url":"https://github.com/omarvides/crud-challenge-backend/pull/2.diff","patch_url":"https://github.com/omarvides/crud-challenge-backend/pull/2.patch","issue_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/issues/2","number":2,"state":"closed","locked":false,"title":"Adding basic file structure","user":{"login":"omarvides","id":1542757,"node_id":"MDQ6VXNlcjE1NDI3NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1542757?v=4","gravatar_id":"","url":"https://api.github.com/users/omarvides","html_url":"https://github.com/omarvides","followers_url":"https://api.github.com/users/omarvides/followers","following_url":"https://api.github.com/users/omarvides/following{/other_user}","gists_url":"https://api.github.com/users/omarvides/gists{/gist_id}","starred_url":"https://api.github.com/users/omarvides/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omarvides/subscriptions","organizations_url":"https://api.github.com/users/omarvides/orgs","repos_url":"https://api.github.com/users/omarvides/repos","events_url":"https://api.github.com/users/omarvides/events{/privacy}","received_events_url":"https://api.github.com/users/omarvides/received_events","type":"User","site_admin":false},"body":"# This Pull Request Resolves Issue #1 \r\n\r\n## Adding basic file structure for\r\n\r\n- Drone.io builds, the builds are running at my own drone.io server (github.clouderx.com).\r\n- Enabling the Application to be packaged in a Docker container automatically when a tag is pushed to the repository.\r\n- Adding express-prom-bundle module to allow the application to expose metrics on /metrics endpoint which can be used when the application runs in a container, for lambda functions deployments, metrics should be retrieved differently.\r\n- Adding pre-commit library to prevent broken commits to be pushed, it will run the linter (prettier) and the unit tests (npm run unit).\r\n- Acceptance tests added, right now, it only verifies that the API answers with a 200 code when HTTP GET \"/\" is requested.\r\n- Basic structure to make every component easy to test (controllers, routes, middlewares, modules and utils).\r\n- README.md with basic documentation but structure in place created, this will be filled as the development advances.\r\n- CHANGELOG.md file added to have a record of what changed in the API and linked in the README.md file for easy access, currently contains only the basic structure.\r\n- A basic UI mock was added just for fun, I would like to provide a UI like that, but will try to keep it functional at first.\r\n- Other improvements in the file composition and structure can be expected during next PRs and commits","created_at":"2018-12-27T07:28:42Z","updated_at":"2018-12-27T07:54:07Z","closed_at":"2018-12-27T07:54:07Z","merged_at":"2018-12-27T07:54:07Z","merge_commit_sha":"19fd4f58ee9750fa09f60d4c515671920c5c9ee3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/pulls/2/commits","review_comments_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/pulls/2/comments","review_comment_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/issues/2/comments","statuses_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/statuses/69af00a1dad01a9f47e2b5d00b48e2c64e8eb1f3","head":{"label":"omarvides:file-structure","ref":"file-structure","sha":"69af00a1dad01a9f47e2b5d00b48e2c64e8eb1f3","user":{"login":"omarvides","id":1542757,"node_id":"MDQ6VXNlcjE1NDI3NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1542757?v=4","gravatar_id":"","url":"https://api.github.com/users/omarvides","html_url":"https://github.com/omarvides","followers_url":"https://api.github.com/users/omarvides/followers","following_url":"https://api.github.com/users/omarvides/following{/other_user}","gists_url":"https://api.github.com/users/omarvides/gists{/gist_id}","starred_url":"https://api.github.com/users/omarvides/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omarvides/subscriptions","organizations_url":"https://api.github.com/users/omarvides/orgs","repos_url":"https://api.github.com/users/omarvides/repos","events_url":"https://api.github.com/users/omarvides/events{/privacy}","received_events_url":"https://api.github.com/users/omarvides/received_events","type":"User","site_admin":false},"repo":{"id":162767536,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI3Njc1MzY=","name":"crud-challenge-backend","full_name":"omarvides/crud-challenge-backend","private":false,"owner":{"login":"omarvides","id":1542757,"node_id":"MDQ6VXNlcjE1NDI3NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1542757?v=4","gravatar_id":"","url":"https://api.github.com/users/omarvides","html_url":"https://github.com/omarvides","followers_url":"https://api.github.com/users/omarvides/followers","following_url":"https://api.github.com/users/omarvides/following{/other_user}","gists_url":"https://api.github.com/users/omarvides/gists{/gist_id}","starred_url":"https://api.github.com/users/omarvides/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omarvides/subscriptions","organizations_url":"https://api.github.com/users/omarvides/orgs","repos_url":"https://api.github.com/users/omarvides/repos","events_url":"https://api.github.com/users/omarvides/events{/privacy}","received_events_url":"https://api.github.com/users/omarvides/received_events","type":"User","site_admin":false},"html_url":"https://github.com/omarvides/crud-challenge-backend","description":"RESTful Backend API for a simple CRUD Web App","fork":false,"url":"https://api.github.com/repos/omarvides/crud-challenge-backend","forks_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/forks","keys_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/teams","hooks_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/hooks","issue_events_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/issues/events{/number}","events_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/events","assignees_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/assignees{/user}","branches_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/branches{/branch}","tags_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/tags","blobs_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/languages","stargazers_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/stargazers","contributors_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/contributors","subscribers_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/subscribers","subscription_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/subscription","commits_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/contents/{+path}","compare_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/merges","archive_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/downloads","issues_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/issues{/number}","pulls_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/labels{/name}","releases_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/releases{/id}","deployments_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/deployments","created_at":"2018-12-21T23:50:48Z","updated_at":"2018-12-22T06:30:27Z","pushed_at":"2018-12-27T07:54:07Z","git_url":"git://github.com/omarvides/crud-challenge-backend.git","ssh_url":"git@github.com:omarvides/crud-challenge-backend.git","clone_url":"https://github.com/omarvides/crud-challenge-backend.git","svn_url":"https://github.com/omarvides/crud-challenge-backend","homepage":null,"size":222,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"omarvides:develop","ref":"develop","sha":"6ebdc5b18af70531443a77f28b4ac6e3ace225a6","user":{"login":"omarvides","id":1542757,"node_id":"MDQ6VXNlcjE1NDI3NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1542757?v=4","gravatar_id":"","url":"https://api.github.com/users/omarvides","html_url":"https://github.com/omarvides","followers_url":"https://api.github.com/users/omarvides/followers","following_url":"https://api.github.com/users/omarvides/following{/other_user}","gists_url":"https://api.github.com/users/omarvides/gists{/gist_id}","starred_url":"https://api.github.com/users/omarvides/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omarvides/subscriptions","organizations_url":"https://api.github.com/users/omarvides/orgs","repos_url":"https://api.github.com/users/omarvides/repos","events_url":"https://api.github.com/users/omarvides/events{/privacy}","received_events_url":"https://api.github.com/users/omarvides/received_events","type":"User","site_admin":false},"repo":{"id":162767536,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI3Njc1MzY=","name":"crud-challenge-backend","full_name":"omarvides/crud-challenge-backend","private":false,"owner":{"login":"omarvides","id":1542757,"node_id":"MDQ6VXNlcjE1NDI3NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1542757?v=4","gravatar_id":"","url":"https://api.github.com/users/omarvides","html_url":"https://github.com/omarvides","followers_url":"https://api.github.com/users/omarvides/followers","following_url":"https://api.github.com/users/omarvides/following{/other_user}","gists_url":"https://api.github.com/users/omarvides/gists{/gist_id}","starred_url":"https://api.github.com/users/omarvides/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omarvides/subscriptions","organizations_url":"https://api.github.com/users/omarvides/orgs","repos_url":"https://api.github.com/users/omarvides/repos","events_url":"https://api.github.com/users/omarvides/events{/privacy}","received_events_url":"https://api.github.com/users/omarvides/received_events","type":"User","site_admin":false},"html_url":"https://github.com/omarvides/crud-challenge-backend","description":"RESTful Backend API for a simple CRUD Web App","fork":false,"url":"https://api.github.com/repos/omarvides/crud-challenge-backend","forks_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/forks","keys_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/teams","hooks_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/hooks","issue_events_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/issues/events{/number}","events_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/events","assignees_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/assignees{/user}","branches_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/branches{/branch}","tags_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/tags","blobs_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/languages","stargazers_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/stargazers","contributors_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/contributors","subscribers_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/subscribers","subscription_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/subscription","commits_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/contents/{+path}","compare_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/merges","archive_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/downloads","issues_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/issues{/number}","pulls_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/labels{/name}","releases_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/releases{/id}","deployments_url":"https://api.github.com/repos/omarvides/crud-challenge-backend/deployments","created_at":"2018-12-21T23:50:48Z","updated_at":"2018-12-22T06:30:27Z","pushed_at":"2018-12-27T07:54:07Z","git_url":"git://github.com/omarvides/crud-challenge-backend.git","ssh_url":"git@github.com:omarvides/crud-challenge-backend.git","clone_url":"https://github.com/omarvides/crud-challenge-backend.git","svn_url":"https://github.com/omarvides/crud-challenge-backend","homepage":null,"size":222,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/omarvides/crud-challenge-backend/pulls/2"},"html":{"href":"https://github.com/omarvides/crud-challenge-backend/pull/2"},"issue":{"href":"https://api.github.com/repos/omarvides/crud-challenge-backend/issues/2"},"comments":{"href":"https://api.github.com/repos/omarvides/crud-challenge-backend/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/omarvides/crud-challenge-backend/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/omarvides/crud-challenge-backend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/omarvides/crud-challenge-backend/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/omarvides/crud-challenge-backend/statuses/69af00a1dad01a9f47e2b5d00b48e2c64e8eb1f3"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"omarvides","id":1542757,"node_id":"MDQ6VXNlcjE1NDI3NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1542757?v=4","gravatar_id":"","url":"https://api.github.com/users/omarvides","html_url":"https://github.com/omarvides","followers_url":"https://api.github.com/users/omarvides/followers","following_url":"https://api.github.com/users/omarvides/following{/other_user}","gists_url":"https://api.github.com/users/omarvides/gists{/gist_id}","starred_url":"https://api.github.com/users/omarvides/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omarvides/subscriptions","organizations_url":"https://api.github.com/users/omarvides/orgs","repos_url":"https://api.github.com/users/omarvides/repos","events_url":"https://api.github.com/users/omarvides/events{/privacy}","received_events_url":"https://api.github.com/users/omarvides/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":14,"additions":6997,"deletions":3,"changed_files":16}}
{"actor":{"display_login":"omarvides"}}