{"action":"created","issue":{"url":"https://api.github.com/repos/grpc/grpc/issues/16773","repository_url":"https://api.github.com/repos/grpc/grpc","labels_url":"https://api.github.com/repos/grpc/grpc/issues/16773/labels{/name}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/16773/comments","events_url":"https://api.github.com/repos/grpc/grpc/issues/16773/events","html_url":"https://github.com/grpc/grpc/pull/16773","id":366500295,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMTU4Nzc3","number":16773,"title":"Use gRPC thread model (i.e., pollset_set) in ALTS TSI implementation","user":{"login":"yihuazhang","id":26934891,"node_id":"MDQ6VXNlcjI2OTM0ODkx","avatar_url":"https://avatars2.githubusercontent.com/u/26934891?v=4","gravatar_id":"","url":"https://api.github.com/users/yihuazhang","html_url":"https://github.com/yihuazhang","followers_url":"https://api.github.com/users/yihuazhang/followers","following_url":"https://api.github.com/users/yihuazhang/following{/other_user}","gists_url":"https://api.github.com/users/yihuazhang/gists{/gist_id}","starred_url":"https://api.github.com/users/yihuazhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yihuazhang/subscriptions","organizations_url":"https://api.github.com/users/yihuazhang/orgs","repos_url":"https://api.github.com/users/yihuazhang/repos","events_url":"https://api.github.com/users/yihuazhang/events{/privacy}","received_events_url":"https://api.github.com/users/yihuazhang/received_events","type":"User","site_admin":false},"labels":[{"id":961832073,"node_id":"MDU6TGFiZWw5NjE4MzIwNzM=","url":"https://api.github.com/repos/grpc/grpc/labels/release%20notes:%20no","name":"release notes: no","color":"0f5f75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":32,"created_at":"2018-10-03T19:51:22Z","updated_at":"2018-10-25T18:22:15Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/16773","html_url":"https://github.com/grpc/grpc/pull/16773","diff_url":"https://github.com/grpc/grpc/pull/16773.diff","patch_url":"https://github.com/grpc/grpc/pull/16773.patch"},"body":"The PR made the following changes: \r\n\r\n1) refactor `alts_transport_security.{h, cc}` so that it only contains the shared resources that are usable in both gRPC and Envoy (i.e., dedicated CQ) use cases. \r\n2) create `alts_shared_resources.{h, cc}` in `src/core/tsi/alts/handshaker` that contains shared resources and corresponding APIs that are only usable in Envoy use case. \r\n3) use `grpc_channel_create_pollset_set_call` and `grpc_call_start_batch_and_execute` in ALTS handshaker client implementation, when `pollset_set` is passed in from the handshaker. \r\n4) update ALTS handshaker client test to ensure correct inputs (e.g., closure) have been passed when using gRPC thread model.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/grpc/grpc/16773)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/grpc/grpc/issues/comments/433155577","html_url":"https://github.com/grpc/grpc/pull/16773#issuecomment-433155577","issue_url":"https://api.github.com/repos/grpc/grpc/issues/16773","id":433155577,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzE1NTU3Nw==","user":{"login":"grpc-testing","id":28024233,"node_id":"MDQ6VXNlcjI4MDI0MjMz","avatar_url":"https://avatars1.githubusercontent.com/u/28024233?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc-testing","html_url":"https://github.com/grpc-testing","followers_url":"https://api.github.com/users/grpc-testing/followers","following_url":"https://api.github.com/users/grpc-testing/following{/other_user}","gists_url":"https://api.github.com/users/grpc-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc-testing/subscriptions","organizations_url":"https://api.github.com/users/grpc-testing/orgs","repos_url":"https://api.github.com/users/grpc-testing/repos","events_url":"https://api.github.com/users/grpc-testing/events{/privacy}","received_events_url":"https://api.github.com/users/grpc-testing/received_events","type":"User","site_admin":false},"created_at":"2018-10-25T18:22:15Z","updated_at":"2018-10-25T18:22:15Z","author_association":"NONE","body":"```\n****************************************************************\n\nlibgrpc.so\n\n     VM SIZE                                                                                            FILE SIZE\n ++++++++++++++ GROWING                                                                              ++++++++++++++\n  +0.3% +2.49Ki [None]                                                                               +9.94Ki  +0.1%\n      +0.4% +2.43Ki [Unmapped]                                                                           +9.88Ki  +0.1%\n      [NEW]     +72 g_alts_resource_dedicated                                                                  0  [ = ]\n      [NEW]     +64 handshaker_vtable_dedicated                                                              +64  [NEW]\n      +0.8%      +8 [None]                                                                                     0  [ = ]\n      [NEW]      +8 g_shared_resources                                                                         0  [ = ]\n   +86% +2.46Ki src/core/tsi/alts/handshaker/alts_handshaker_client.cc                               +2.46Ki   +86%\n      [NEW]    +836 alts_handshaker_client_handle_response                                                  +836  [NEW]\n      [NEW]    +567 handshaker_client_start_client                                                          +567  [NEW]\n      [NEW]    +511 handshaker_client_next                                                                  +511  [NEW]\n      [NEW]    +495 handshaker_client_start_server                                                          +495  [NEW]\n      [NEW]    +416 make_grpc_call                                                                          +416  [NEW]\n      [NEW]    +379 alts_grpc_handshaker_client_create                                                      +379  [NEW]\n      [NEW]    +363 grpc_core::internal::alts_handshaker_client_check_fields_for_testing                    +363  [NEW]\n      +138%    +292 [Other]                                                                                 +292  +138%\n      [NEW]    +262 alts_handshaker_client_init                                                             +262  [NEW]\n      [NEW]    +150 grpc_core::internal::alts_handshaker_client_set_recv_bytes_for_testing                  +150  [NEW]\n      +324%    +136 alts_handshaker_client_destroy                                                          +136  +324%\n      [NEW]    +123 grpc_core::internal::alts_handshaker_client_set_vtable_for_testing                      +123  [NEW]\n      [NEW]     +79 grpc_core::internal::alts_handshaker_client_set_fields_for_testing                       +79  [NEW]\n      [NEW]     +77 alts_handshaker_client_next                                                              +77  [NEW]\n      [NEW]     +77 alts_handshaker_client_start_client                                                      +77  [NEW]\n      [NEW]     +77 alts_handshaker_client_start_server                                                      +77  [NEW]\n      [NEW]     +63 alts_handshaker_client_is_initialized                                                    +63  [NEW]\n      [NEW]     +63 grpc_core::internal::alts_handshaker_client_set_cb_for_testing                           +63  [NEW]\n      [NEW]     +63 grpc_core::internal::alts_handshaker_client_get_closure_for_testing                      +63  [NEW]\n      [NEW]     +63 grpc_core::internal::alts_handshaker_client_get_handshaker_for_testing                   +63  [NEW]\n      [NEW]     +63 grpc_core::internal::alts_handshaker_client_get_send_buffer_for_testing                  +63  [NEW]\n  [NEW]    +845 src/core/tsi/alts/handshaker/alts_shared_resource.cc                                    +845  [NEW]\n      [NEW]    +288 grpc_alts_shared_resource_dedicated_start                                               +288  [NEW]\n      [NEW]    +226 grpc_alts_shared_resource_dedicated_shutdown                                            +226  [NEW]\n      [NEW]    +171 thread_worker                                                                           +171  [NEW]\n      [NEW]     +63 alts_shared_resource_dedicated::~alts_shared_resource_dedicated                          +63  [NEW]\n      [NEW]     +60 _GLOBAL__sub_I_alts_shared_resource.cc                                                   +60  [NEW]\n      [NEW]     +17 [Unmapped]                                                                               +17  [NEW]\n      [NEW]     +12 grpc_alts_shared_resource_dedicated_init                                                 +12  [NEW]\n      [NEW]      +8 grpc_alts_get_shared_resource_dedicated                                                   +8  [NEW]\n\n -------------- SHRINKING                                                                            --------------\n -18.3%    -848 src/core/tsi/alts/handshaker/alts_tsi_handshaker.cc                                     -848 -18.3%\n      [DEL] -1.34Ki alts_tsi_handshaker_handle_response                                                  -1.34Ki  [DEL]\n     -25.1%    -160 handshaker_next                                                                         -160 -25.1%\n      [DEL]    -152 grpc_core::internal::alts_tsi_handshaker_set_recv_bytes_for_testing                     -152  [DEL]\n     -19.0%    -142 alts_tsi_handshaker_create                                                              -142 -19.0%\n      [DEL]    -134 thread_worker                                                                           -134  [DEL]\n      [DEL]     -91 grpc_core::internal::alts_tsi_handshaker_set_client_for_testing                          -91  [DEL]\n      [DEL]     -79 grpc_core::internal::alts_tsi_handshaker_get_recv_bytes_for_testing                      -79  [DEL]\n     -32.7%     -32 handshaker_destroy                                                                       -32 -32.7%\n  [DEL]    -498 src/core/tsi/alts/handshaker/alts_tsi_event.cc                                          -498  [DEL]\n      [DEL]    -283 alts_tsi_event_create                                                                   -283  [DEL]\n      [DEL]    -130 alts_tsi_event_destroy                                                                  -130  [DEL]\n      [DEL]     -79 alts_tsi_event_dispatch_to_handshaker                                                    -79  [DEL]\n      [DEL]      -6 [Unmapped]                                                                                -6  [DEL]\n -82.0%    -457 src/core/tsi/alts_transport_security.cc                                                 -457 -82.0%\n     -82.8%    -251 grpc_tsi_alts_shutdown                                                                  -251 -82.8%\n      [DEL]     -63 alts_shared_resource::~alts_shared_resource                                              -63  [DEL]\n      [DEL]     -51 grpc_tsi_alts_signal_for_cq_destroy                                                      -51  [DEL]\n      [DEL]     -47 _GLOBAL__sub_I_alts_transport_security.cc                                                -47  [DEL]\n     -62.3%     -38 grpc_tsi_alts_init                                                                       -38 -62.3%\n     -29.2%      -7 [Unmapped]                                                                                -7 -29.2%\n  -4.8%    -208 src/core/lib/security/transport/security_handshaker.cc                                  -208  -4.8%\n     -62.4%    -219 on_handshake_next_done_grpc_wrapper                                                     -219 -62.4%\n\n  +0.3% +3.81Ki TOTAL                                                                                +11.3Ki  +0.1%\n\n\n****************************************************************\n\nlibgrpc++.so\n\n     VM SIZE        FILE SIZE\n ++++++++++++++  ++++++++++++++\n\n  [ = ]       0        0  [ = ]\n\n\n\n```"}}
{"actor":{"display_login":"grpc-testing"}}