{"action":"created","comment":{"url":"https://api.github.com/repos/Siteimprove/alfa/pulls/comments/208175625","pull_request_review_id":143930267,"id":208175625,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODE3NTYyNQ==","diff_hunk":"@@ -1,7 +1,7 @@\n import { getTabIndex } from \"./get-tab-index\";\n import { isElement } from \"./guards\";\n import { traverseNode } from \"./traverse-node\";\n-import { Element } from \"./types\";\n+import { Element, Node } from \"./types\";\n \n function indexWithin(array: Array<Element>, element: Element) {","path":"packages/alfa-dom/src/get-tab-sequence.ts","position":null,"original_position":7,"commit_id":"4ad657c6a437870d35f22391c30e61773593f996","original_commit_id":"4ad657c6a437870d35f22391c30e61773593f996","user":{"login":"kasperisager","id":1174718,"node_id":"MDQ6VXNlcjExNzQ3MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1174718?v=4","gravatar_id":"","url":"https://api.github.com/users/kasperisager","html_url":"https://github.com/kasperisager","followers_url":"https://api.github.com/users/kasperisager/followers","following_url":"https://api.github.com/users/kasperisager/following{/other_user}","gists_url":"https://api.github.com/users/kasperisager/gists{/gist_id}","starred_url":"https://api.github.com/users/kasperisager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasperisager/subscriptions","organizations_url":"https://api.github.com/users/kasperisager/orgs","repos_url":"https://api.github.com/users/kasperisager/repos","events_url":"https://api.github.com/users/kasperisager/events{/privacy}","received_events_url":"https://api.github.com/users/kasperisager/received_events","type":"User","site_admin":false},"body":"Should be moved to the bottom; public APIs first, then private.","created_at":"2018-08-07T10:19:55Z","updated_at":"2018-08-07T10:40:39Z","html_url":"https://github.com/Siteimprove/alfa/pull/28#discussion_r208175625","pull_request_url":"https://api.github.com/repos/Siteimprove/alfa/pulls/28","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Siteimprove/alfa/pulls/comments/208175625"},"html":{"href":"https://github.com/Siteimprove/alfa/pull/28#discussion_r208175625"},"pull_request":{"href":"https://api.github.com/repos/Siteimprove/alfa/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/Siteimprove/alfa/pulls/28","id":206388863,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2Mzg4ODYz","html_url":"https://github.com/Siteimprove/alfa/pull/28","diff_url":"https://github.com/Siteimprove/alfa/pull/28.diff","patch_url":"https://github.com/Siteimprove/alfa/pull/28.patch","issue_url":"https://api.github.com/repos/Siteimprove/alfa/issues/28","number":28,"state":"open","locked":false,"title":"Closes #24: Implement `getTabSequence()`","user":{"login":"NiclasHedam","id":770169,"node_id":"MDQ6VXNlcjc3MDE2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/770169?v=4","gravatar_id":"","url":"https://api.github.com/users/NiclasHedam","html_url":"https://github.com/NiclasHedam","followers_url":"https://api.github.com/users/NiclasHedam/followers","following_url":"https://api.github.com/users/NiclasHedam/following{/other_user}","gists_url":"https://api.github.com/users/NiclasHedam/gists{/gist_id}","starred_url":"https://api.github.com/users/NiclasHedam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NiclasHedam/subscriptions","organizations_url":"https://api.github.com/users/NiclasHedam/orgs","repos_url":"https://api.github.com/users/NiclasHedam/repos","events_url":"https://api.github.com/users/NiclasHedam/events{/privacy}","received_events_url":"https://api.github.com/users/NiclasHedam/received_events","type":"User","site_admin":false},"body":"The `getTabSequence()` casts all elements to an TabIndexedElement, which contains its index weight. This is done, due to the fact that the order of which the elements are put into the array could return a bad order.","created_at":"2018-08-06T12:52:36Z","updated_at":"2018-08-07T10:40:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24fc660c8d76120187ff6518dec488491c263f15","assignee":{"login":"NiclasHedam","id":770169,"node_id":"MDQ6VXNlcjc3MDE2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/770169?v=4","gravatar_id":"","url":"https://api.github.com/users/NiclasHedam","html_url":"https://github.com/NiclasHedam","followers_url":"https://api.github.com/users/NiclasHedam/followers","following_url":"https://api.github.com/users/NiclasHedam/following{/other_user}","gists_url":"https://api.github.com/users/NiclasHedam/gists{/gist_id}","starred_url":"https://api.github.com/users/NiclasHedam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NiclasHedam/subscriptions","organizations_url":"https://api.github.com/users/NiclasHedam/orgs","repos_url":"https://api.github.com/users/NiclasHedam/repos","events_url":"https://api.github.com/users/NiclasHedam/events{/privacy}","received_events_url":"https://api.github.com/users/NiclasHedam/received_events","type":"User","site_admin":false},"assignees":[{"login":"NiclasHedam","id":770169,"node_id":"MDQ6VXNlcjc3MDE2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/770169?v=4","gravatar_id":"","url":"https://api.github.com/users/NiclasHedam","html_url":"https://github.com/NiclasHedam","followers_url":"https://api.github.com/users/NiclasHedam/followers","following_url":"https://api.github.com/users/NiclasHedam/following{/other_user}","gists_url":"https://api.github.com/users/NiclasHedam/gists{/gist_id}","starred_url":"https://api.github.com/users/NiclasHedam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NiclasHedam/subscriptions","organizations_url":"https://api.github.com/users/NiclasHedam/orgs","repos_url":"https://api.github.com/users/NiclasHedam/repos","events_url":"https://api.github.com/users/NiclasHedam/events{/privacy}","received_events_url":"https://api.github.com/users/NiclasHedam/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Siteimprove/alfa/pulls/28/commits","review_comments_url":"https://api.github.com/repos/Siteimprove/alfa/pulls/28/comments","review_comment_url":"https://api.github.com/repos/Siteimprove/alfa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Siteimprove/alfa/issues/28/comments","statuses_url":"https://api.github.com/repos/Siteimprove/alfa/statuses/4ad657c6a437870d35f22391c30e61773593f996","head":{"label":"Siteimprove:feature-implement-get-tab-sequence","ref":"feature-implement-get-tab-sequence","sha":"4ad657c6a437870d35f22391c30e61773593f996","user":{"login":"Siteimprove","id":1436607,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzY2MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1436607?v=4","gravatar_id":"","url":"https://api.github.com/users/Siteimprove","html_url":"https://github.com/Siteimprove","followers_url":"https://api.github.com/users/Siteimprove/followers","following_url":"https://api.github.com/users/Siteimprove/following{/other_user}","gists_url":"https://api.github.com/users/Siteimprove/gists{/gist_id}","starred_url":"https://api.github.com/users/Siteimprove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Siteimprove/subscriptions","organizations_url":"https://api.github.com/users/Siteimprove/orgs","repos_url":"https://api.github.com/users/Siteimprove/repos","events_url":"https://api.github.com/users/Siteimprove/events{/privacy}","received_events_url":"https://api.github.com/users/Siteimprove/received_events","type":"Organization","site_admin":false},"repo":{"id":111778050,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE3NzgwNTA=","name":"alfa","full_name":"Siteimprove/alfa","owner":{"login":"Siteimprove","id":1436607,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzY2MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1436607?v=4","gravatar_id":"","url":"https://api.github.com/users/Siteimprove","html_url":"https://github.com/Siteimprove","followers_url":"https://api.github.com/users/Siteimprove/followers","following_url":"https://api.github.com/users/Siteimprove/following{/other_user}","gists_url":"https://api.github.com/users/Siteimprove/gists{/gist_id}","starred_url":"https://api.github.com/users/Siteimprove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Siteimprove/subscriptions","organizations_url":"https://api.github.com/users/Siteimprove/orgs","repos_url":"https://api.github.com/users/Siteimprove/repos","events_url":"https://api.github.com/users/Siteimprove/events{/privacy}","received_events_url":"https://api.github.com/users/Siteimprove/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Siteimprove/alfa","description":":wheelchair: Suite of open and standards-based tools for performing reliable accessibility conformance testing at scale","fork":false,"url":"https://api.github.com/repos/Siteimprove/alfa","forks_url":"https://api.github.com/repos/Siteimprove/alfa/forks","keys_url":"https://api.github.com/repos/Siteimprove/alfa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Siteimprove/alfa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Siteimprove/alfa/teams","hooks_url":"https://api.github.com/repos/Siteimprove/alfa/hooks","issue_events_url":"https://api.github.com/repos/Siteimprove/alfa/issues/events{/number}","events_url":"https://api.github.com/repos/Siteimprove/alfa/events","assignees_url":"https://api.github.com/repos/Siteimprove/alfa/assignees{/user}","branches_url":"https://api.github.com/repos/Siteimprove/alfa/branches{/branch}","tags_url":"https://api.github.com/repos/Siteimprove/alfa/tags","blobs_url":"https://api.github.com/repos/Siteimprove/alfa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Siteimprove/alfa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Siteimprove/alfa/git/refs{/sha}","trees_url":"https://api.github.com/repos/Siteimprove/alfa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Siteimprove/alfa/statuses/{sha}","languages_url":"https://api.github.com/repos/Siteimprove/alfa/languages","stargazers_url":"https://api.github.com/repos/Siteimprove/alfa/stargazers","contributors_url":"https://api.github.com/repos/Siteimprove/alfa/contributors","subscribers_url":"https://api.github.com/repos/Siteimprove/alfa/subscribers","subscription_url":"https://api.github.com/repos/Siteimprove/alfa/subscription","commits_url":"https://api.github.com/repos/Siteimprove/alfa/commits{/sha}","git_commits_url":"https://api.github.com/repos/Siteimprove/alfa/git/commits{/sha}","comments_url":"https://api.github.com/repos/Siteimprove/alfa/comments{/number}","issue_comment_url":"https://api.github.com/repos/Siteimprove/alfa/issues/comments{/number}","contents_url":"https://api.github.com/repos/Siteimprove/alfa/contents/{+path}","compare_url":"https://api.github.com/repos/Siteimprove/alfa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Siteimprove/alfa/merges","archive_url":"https://api.github.com/repos/Siteimprove/alfa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Siteimprove/alfa/downloads","issues_url":"https://api.github.com/repos/Siteimprove/alfa/issues{/number}","pulls_url":"https://api.github.com/repos/Siteimprove/alfa/pulls{/number}","milestones_url":"https://api.github.com/repos/Siteimprove/alfa/milestones{/number}","notifications_url":"https://api.github.com/repos/Siteimprove/alfa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Siteimprove/alfa/labels{/name}","releases_url":"https://api.github.com/repos/Siteimprove/alfa/releases{/id}","deployments_url":"https://api.github.com/repos/Siteimprove/alfa/deployments","created_at":"2017-11-23T07:36:42Z","updated_at":"2018-08-07T08:33:56Z","pushed_at":"2018-08-07T09:20:54Z","git_url":"git://github.com/Siteimprove/alfa.git","ssh_url":"git@github.com:Siteimprove/alfa.git","clone_url":"https://github.com/Siteimprove/alfa.git","svn_url":"https://github.com/Siteimprove/alfa","homepage":"","size":2020,"stargazers_count":6,"watchers_count":6,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":10,"watchers":6,"default_branch":"master"}},"base":{"label":"Siteimprove:master","ref":"master","sha":"112939d68d01e42b5835d2f9b455b8c32253aafb","user":{"login":"Siteimprove","id":1436607,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzY2MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1436607?v=4","gravatar_id":"","url":"https://api.github.com/users/Siteimprove","html_url":"https://github.com/Siteimprove","followers_url":"https://api.github.com/users/Siteimprove/followers","following_url":"https://api.github.com/users/Siteimprove/following{/other_user}","gists_url":"https://api.github.com/users/Siteimprove/gists{/gist_id}","starred_url":"https://api.github.com/users/Siteimprove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Siteimprove/subscriptions","organizations_url":"https://api.github.com/users/Siteimprove/orgs","repos_url":"https://api.github.com/users/Siteimprove/repos","events_url":"https://api.github.com/users/Siteimprove/events{/privacy}","received_events_url":"https://api.github.com/users/Siteimprove/received_events","type":"Organization","site_admin":false},"repo":{"id":111778050,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE3NzgwNTA=","name":"alfa","full_name":"Siteimprove/alfa","owner":{"login":"Siteimprove","id":1436607,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzY2MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1436607?v=4","gravatar_id":"","url":"https://api.github.com/users/Siteimprove","html_url":"https://github.com/Siteimprove","followers_url":"https://api.github.com/users/Siteimprove/followers","following_url":"https://api.github.com/users/Siteimprove/following{/other_user}","gists_url":"https://api.github.com/users/Siteimprove/gists{/gist_id}","starred_url":"https://api.github.com/users/Siteimprove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Siteimprove/subscriptions","organizations_url":"https://api.github.com/users/Siteimprove/orgs","repos_url":"https://api.github.com/users/Siteimprove/repos","events_url":"https://api.github.com/users/Siteimprove/events{/privacy}","received_events_url":"https://api.github.com/users/Siteimprove/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Siteimprove/alfa","description":":wheelchair: Suite of open and standards-based tools for performing reliable accessibility conformance testing at scale","fork":false,"url":"https://api.github.com/repos/Siteimprove/alfa","forks_url":"https://api.github.com/repos/Siteimprove/alfa/forks","keys_url":"https://api.github.com/repos/Siteimprove/alfa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Siteimprove/alfa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Siteimprove/alfa/teams","hooks_url":"https://api.github.com/repos/Siteimprove/alfa/hooks","issue_events_url":"https://api.github.com/repos/Siteimprove/alfa/issues/events{/number}","events_url":"https://api.github.com/repos/Siteimprove/alfa/events","assignees_url":"https://api.github.com/repos/Siteimprove/alfa/assignees{/user}","branches_url":"https://api.github.com/repos/Siteimprove/alfa/branches{/branch}","tags_url":"https://api.github.com/repos/Siteimprove/alfa/tags","blobs_url":"https://api.github.com/repos/Siteimprove/alfa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Siteimprove/alfa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Siteimprove/alfa/git/refs{/sha}","trees_url":"https://api.github.com/repos/Siteimprove/alfa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Siteimprove/alfa/statuses/{sha}","languages_url":"https://api.github.com/repos/Siteimprove/alfa/languages","stargazers_url":"https://api.github.com/repos/Siteimprove/alfa/stargazers","contributors_url":"https://api.github.com/repos/Siteimprove/alfa/contributors","subscribers_url":"https://api.github.com/repos/Siteimprove/alfa/subscribers","subscription_url":"https://api.github.com/repos/Siteimprove/alfa/subscription","commits_url":"https://api.github.com/repos/Siteimprove/alfa/commits{/sha}","git_commits_url":"https://api.github.com/repos/Siteimprove/alfa/git/commits{/sha}","comments_url":"https://api.github.com/repos/Siteimprove/alfa/comments{/number}","issue_comment_url":"https://api.github.com/repos/Siteimprove/alfa/issues/comments{/number}","contents_url":"https://api.github.com/repos/Siteimprove/alfa/contents/{+path}","compare_url":"https://api.github.com/repos/Siteimprove/alfa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Siteimprove/alfa/merges","archive_url":"https://api.github.com/repos/Siteimprove/alfa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Siteimprove/alfa/downloads","issues_url":"https://api.github.com/repos/Siteimprove/alfa/issues{/number}","pulls_url":"https://api.github.com/repos/Siteimprove/alfa/pulls{/number}","milestones_url":"https://api.github.com/repos/Siteimprove/alfa/milestones{/number}","notifications_url":"https://api.github.com/repos/Siteimprove/alfa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Siteimprove/alfa/labels{/name}","releases_url":"https://api.github.com/repos/Siteimprove/alfa/releases{/id}","deployments_url":"https://api.github.com/repos/Siteimprove/alfa/deployments","created_at":"2017-11-23T07:36:42Z","updated_at":"2018-08-07T08:33:56Z","pushed_at":"2018-08-07T09:20:54Z","git_url":"git://github.com/Siteimprove/alfa.git","ssh_url":"git@github.com:Siteimprove/alfa.git","clone_url":"https://github.com/Siteimprove/alfa.git","svn_url":"https://github.com/Siteimprove/alfa","homepage":"","size":2020,"stargazers_count":6,"watchers_count":6,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":10,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Siteimprove/alfa/pulls/28"},"html":{"href":"https://github.com/Siteimprove/alfa/pull/28"},"issue":{"href":"https://api.github.com/repos/Siteimprove/alfa/issues/28"},"comments":{"href":"https://api.github.com/repos/Siteimprove/alfa/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/Siteimprove/alfa/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/Siteimprove/alfa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Siteimprove/alfa/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/Siteimprove/alfa/statuses/4ad657c6a437870d35f22391c30e61773593f996"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kasperisager"}}