{"action":"created","issue":{"url":"https://api.github.com/repos/batfish/batfish/issues/1634","repository_url":"https://api.github.com/repos/batfish/batfish","labels_url":"https://api.github.com/repos/batfish/batfish/issues/1634/labels{/name}","comments_url":"https://api.github.com/repos/batfish/batfish/issues/1634/comments","events_url":"https://api.github.com/repos/batfish/batfish/issues/1634/events","html_url":"https://github.com/batfish/batfish/pull/1634","id":330995600,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzODQyMzI0","number":1634,"title":"Crypto maps support","user":{"login":"haverma","id":15151202,"node_id":"MDQ6VXNlcjE1MTUxMjAy","avatar_url":"https://avatars3.githubusercontent.com/u/15151202?v=4","gravatar_id":"","url":"https://api.github.com/users/haverma","html_url":"https://github.com/haverma","followers_url":"https://api.github.com/users/haverma/followers","following_url":"https://api.github.com/users/haverma/following{/other_user}","gists_url":"https://api.github.com/users/haverma/gists{/gist_id}","starred_url":"https://api.github.com/users/haverma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haverma/subscriptions","organizations_url":"https://api.github.com/users/haverma/orgs","repos_url":"https://api.github.com/users/haverma/repos","events_url":"https://api.github.com/users/haverma/events{/privacy}","received_events_url":"https://api.github.com/users/haverma/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-10T19:29:27Z","updated_at":"2018-06-11T19:42:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/batfish/batfish/pulls/1634","html_url":"https://github.com/batfish/batfish/pull/1634","diff_url":"https://github.com/batfish/batfish/pull/1634.diff","patch_url":"https://github.com/batfish/batfish/pull/1634.patch"},"body":"- Adding support for extractions of crypto-maps(static and dynamic) to VI model\r\n- Adding tests "},"comment":{"url":"https://api.github.com/repos/batfish/batfish/issues/comments/396362539","html_url":"https://github.com/batfish/batfish/pull/1634#issuecomment-396362539","issue_url":"https://api.github.com/repos/batfish/batfish/issues/1634","id":396362539,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjM2MjUzOQ==","user":{"login":"haverma","id":15151202,"node_id":"MDQ6VXNlcjE1MTUxMjAy","avatar_url":"https://avatars3.githubusercontent.com/u/15151202?v=4","gravatar_id":"","url":"https://api.github.com/users/haverma","html_url":"https://github.com/haverma","followers_url":"https://api.github.com/users/haverma/followers","following_url":"https://api.github.com/users/haverma/following{/other_user}","gists_url":"https://api.github.com/users/haverma/gists{/gist_id}","starred_url":"https://api.github.com/users/haverma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haverma/subscriptions","organizations_url":"https://api.github.com/users/haverma/orgs","repos_url":"https://api.github.com/users/haverma/repos","events_url":"https://api.github.com/users/haverma/events{/privacy}","received_events_url":"https://api.github.com/users/haverma/received_events","type":"User","site_admin":false},"created_at":"2018-06-11T19:42:39Z","updated_at":"2018-06-11T19:42:39Z","author_association":"CONTRIBUTOR","body":"\n\n\n\nReview status: 0 of 36 files reviewed, 1 unresolved discussion (waiting on @dhalperi)\n\n---\n\n*[projects/batfish/src/test/java/org/batfish/grammar/cisco/CiscoGrammarTest.java, line 1639 at r1](https://reviewable.io/reviews/batfish/batfish/1634#-LEfAPMR6mFhNv-Nw9gg:-LEkMHylBspIhjke84BG:b-o7x2jw) ([raw file](https://github.com/batfish/batfish/blob/045ce86f8052009cc917c29013fb55e47b1edb8d/projects/batfish/src/test/java/org/batfish/grammar/cisco/CiscoGrammarTest.java#L1639)):*\n<details><summary><i>Previously, haverma (Harsh Verma) wrote…</i></summary><blockquote>\n\nI had to comment this part of asserting `sequenceNumber` as I was getting a maven build warning saying `unchecked generic array creation for varargs parameter of type Matcher<? super CryptoMapEntry>[]`. I was not able to fix that warning and so had to comment this assertion, I will uncomment/merge it in the above assertion once I figure out the reason and way to get rid of the warning. \n</blockquote></details>\n\nSeems `allOf()` has this problem if it has 1 or >6 elements.  Separating out `sequenceNumbers` assertion to keep the `allOf`parameters to 6 to ensure that\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/batfish/batfish/1634)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"haverma"}}