{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/dns/pulls/comments/178413394","pull_request_review_id":108472487,"id":178413394,"diff_hunk":"@@ -55,4 +59,69 @@ var _ = Describe(\"kube-dns\", func() {\n \t\t\tkubeDNS.Stop()\n \t\t})\n \t})\n+\n+\tIt(\"should forward missed ptr lookup to upstream server\", func() {\n+\t\tBy(\"Setting up environment without upstream server\")\n+\t\tkubeDNS := &e2edns.KubeDNS{}\n+\t\tfr := e2e.GetFramework()\n+\t\tconfigDir := fr.Options.WorkDir + \"/kube-dns-config\"\n+\n+\t\tif _, err := os.Stat(configDir); err == nil {\n+\t\t\tos.RemoveAll(configDir)\n+\t\t}\n+\t\tif err := os.MkdirAll(configDir, 0744); err != nil {\n+\t\t\tpanic(err)\n+\t\t}\n+\n+\t\tfr.Docker.Pull(fr.Options.DnsmasqPtrImage)\n+\t\tdnsmasq := fr.Docker.Run(\n+\t\t\t\"-d\",\n+\t\t\t\"-p=10054:53/tcp\",\n+\t\t\t\"-p=10054:53/udp\",\n+\t\t\t\"--cap-add=NET_ADMIN\",\n+\t\t\tfr.Options.DnsmasqPtrImage)\n+\n+\t\tkubeDNS.Start(\"kube-dns-ptrfwd\", \"-v=4\", \"--config-dir=\"+configDir)\n+\n+\t\tBy(\"Get answer without upstream server\")","path":"test/e2e/kubedns/kubedns.go","position":55,"original_position":55,"commit_id":"89dc8629e93c02cbac6a96badacd07fa539f8b6d","original_commit_id":"46734980925160e95976b88843ca6d28cbfdff5a","user":{"login":"bowei","id":837034,"avatar_url":"https://avatars1.githubusercontent.com/u/837034?v=4","gravatar_id":"","url":"https://api.github.com/users/bowei","html_url":"https://github.com/bowei","followers_url":"https://api.github.com/users/bowei/followers","following_url":"https://api.github.com/users/bowei/following{/other_user}","gists_url":"https://api.github.com/users/bowei/gists{/gist_id}","starred_url":"https://api.github.com/users/bowei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bowei/subscriptions","organizations_url":"https://api.github.com/users/bowei/orgs","repos_url":"https://api.github.com/users/bowei/repos","events_url":"https://api.github.com/users/bowei/events{/privacy}","received_events_url":"https://api.github.com/users/bowei/received_events","type":"User","site_admin":false},"body":"getting","created_at":"2018-03-31T00:24:03Z","updated_at":"2018-03-31T00:25:38Z","html_url":"https://github.com/kubernetes/dns/pull/220#discussion_r178413394","pull_request_url":"https://api.github.com/repos/kubernetes/dns/pulls/220","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/dns/pulls/comments/178413394"},"html":{"href":"https://github.com/kubernetes/dns/pull/220#discussion_r178413394"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/dns/pulls/220"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/dns/pulls/220","id":176943811,"html_url":"https://github.com/kubernetes/dns/pull/220","diff_url":"https://github.com/kubernetes/dns/pull/220.diff","patch_url":"https://github.com/kubernetes/dns/pull/220.patch","issue_url":"https://api.github.com/repos/kubernetes/dns/issues/220","number":220,"state":"open","locked":false,"title":"Forward external IP from kubedns to upstream server","user":{"login":"grayluck","id":4760200,"avatar_url":"https://avatars3.githubusercontent.com/u/4760200?v=4","gravatar_id":"","url":"https://api.github.com/users/grayluck","html_url":"https://github.com/grayluck","followers_url":"https://api.github.com/users/grayluck/followers","following_url":"https://api.github.com/users/grayluck/following{/other_user}","gists_url":"https://api.github.com/users/grayluck/gists{/gist_id}","starred_url":"https://api.github.com/users/grayluck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grayluck/subscriptions","organizations_url":"https://api.github.com/users/grayluck/orgs","repos_url":"https://api.github.com/users/grayluck/repos","events_url":"https://api.github.com/users/grayluck/events{/privacy}","received_events_url":"https://api.github.com/users/grayluck/received_events","type":"User","site_admin":false},"body":"Fixes #198\r\n\r\nApproach: Let kubedns sync config to skydns nameservers, allowing skydns to do the request forwarding. ","created_at":"2018-03-23T00:19:13Z","updated_at":"2018-03-31T00:25:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f076e756361a053cd569b62893ba36fea4cf538d","assignee":{"login":"MrHohn","id":8681801,"avatar_url":"https://avatars0.githubusercontent.com/u/8681801?v=4","gravatar_id":"","url":"https://api.github.com/users/MrHohn","html_url":"https://github.com/MrHohn","followers_url":"https://api.github.com/users/MrHohn/followers","following_url":"https://api.github.com/users/MrHohn/following{/other_user}","gists_url":"https://api.github.com/users/MrHohn/gists{/gist_id}","starred_url":"https://api.github.com/users/MrHohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrHohn/subscriptions","organizations_url":"https://api.github.com/users/MrHohn/orgs","repos_url":"https://api.github.com/users/MrHohn/repos","events_url":"https://api.github.com/users/MrHohn/events{/privacy}","received_events_url":"https://api.github.com/users/MrHohn/received_events","type":"User","site_admin":false},"assignees":[{"login":"bowei","id":837034,"avatar_url":"https://avatars1.githubusercontent.com/u/837034?v=4","gravatar_id":"","url":"https://api.github.com/users/bowei","html_url":"https://github.com/bowei","followers_url":"https://api.github.com/users/bowei/followers","following_url":"https://api.github.com/users/bowei/following{/other_user}","gists_url":"https://api.github.com/users/bowei/gists{/gist_id}","starred_url":"https://api.github.com/users/bowei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bowei/subscriptions","organizations_url":"https://api.github.com/users/bowei/orgs","repos_url":"https://api.github.com/users/bowei/repos","events_url":"https://api.github.com/users/bowei/events{/privacy}","received_events_url":"https://api.github.com/users/bowei/received_events","type":"User","site_admin":false},{"login":"MrHohn","id":8681801,"avatar_url":"https://avatars0.githubusercontent.com/u/8681801?v=4","gravatar_id":"","url":"https://api.github.com/users/MrHohn","html_url":"https://github.com/MrHohn","followers_url":"https://api.github.com/users/MrHohn/followers","following_url":"https://api.github.com/users/MrHohn/following{/other_user}","gists_url":"https://api.github.com/users/MrHohn/gists{/gist_id}","starred_url":"https://api.github.com/users/MrHohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrHohn/subscriptions","organizations_url":"https://api.github.com/users/MrHohn/orgs","repos_url":"https://api.github.com/users/MrHohn/repos","events_url":"https://api.github.com/users/MrHohn/events{/privacy}","received_events_url":"https://api.github.com/users/MrHohn/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":503718697,"url":"https://api.github.com/repos/kubernetes/dns/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":681748265,"url":"https://api.github.com/repos/kubernetes/dns/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/dns/pulls/220/commits","review_comments_url":"https://api.github.com/repos/kubernetes/dns/pulls/220/comments","review_comment_url":"https://api.github.com/repos/kubernetes/dns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/dns/issues/220/comments","statuses_url":"https://api.github.com/repos/kubernetes/dns/statuses/89dc8629e93c02cbac6a96badacd07fa539f8b6d","head":{"label":"grayluck:fwdup","ref":"fwdup","sha":"89dc8629e93c02cbac6a96badacd07fa539f8b6d","user":{"login":"grayluck","id":4760200,"avatar_url":"https://avatars3.githubusercontent.com/u/4760200?v=4","gravatar_id":"","url":"https://api.github.com/users/grayluck","html_url":"https://github.com/grayluck","followers_url":"https://api.github.com/users/grayluck/followers","following_url":"https://api.github.com/users/grayluck/following{/other_user}","gists_url":"https://api.github.com/users/grayluck/gists{/gist_id}","starred_url":"https://api.github.com/users/grayluck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grayluck/subscriptions","organizations_url":"https://api.github.com/users/grayluck/orgs","repos_url":"https://api.github.com/users/grayluck/repos","events_url":"https://api.github.com/users/grayluck/events{/privacy}","received_events_url":"https://api.github.com/users/grayluck/received_events","type":"User","site_admin":false},"repo":{"id":126392297,"name":"dns","full_name":"grayluck/dns","owner":{"login":"grayluck","id":4760200,"avatar_url":"https://avatars3.githubusercontent.com/u/4760200?v=4","gravatar_id":"","url":"https://api.github.com/users/grayluck","html_url":"https://github.com/grayluck","followers_url":"https://api.github.com/users/grayluck/followers","following_url":"https://api.github.com/users/grayluck/following{/other_user}","gists_url":"https://api.github.com/users/grayluck/gists{/gist_id}","starred_url":"https://api.github.com/users/grayluck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grayluck/subscriptions","organizations_url":"https://api.github.com/users/grayluck/orgs","repos_url":"https://api.github.com/users/grayluck/repos","events_url":"https://api.github.com/users/grayluck/events{/privacy}","received_events_url":"https://api.github.com/users/grayluck/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grayluck/dns","description":"Kubernetes DNS service","fork":true,"url":"https://api.github.com/repos/grayluck/dns","forks_url":"https://api.github.com/repos/grayluck/dns/forks","keys_url":"https://api.github.com/repos/grayluck/dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grayluck/dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grayluck/dns/teams","hooks_url":"https://api.github.com/repos/grayluck/dns/hooks","issue_events_url":"https://api.github.com/repos/grayluck/dns/issues/events{/number}","events_url":"https://api.github.com/repos/grayluck/dns/events","assignees_url":"https://api.github.com/repos/grayluck/dns/assignees{/user}","branches_url":"https://api.github.com/repos/grayluck/dns/branches{/branch}","tags_url":"https://api.github.com/repos/grayluck/dns/tags","blobs_url":"https://api.github.com/repos/grayluck/dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grayluck/dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grayluck/dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/grayluck/dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grayluck/dns/statuses/{sha}","languages_url":"https://api.github.com/repos/grayluck/dns/languages","stargazers_url":"https://api.github.com/repos/grayluck/dns/stargazers","contributors_url":"https://api.github.com/repos/grayluck/dns/contributors","subscribers_url":"https://api.github.com/repos/grayluck/dns/subscribers","subscription_url":"https://api.github.com/repos/grayluck/dns/subscription","commits_url":"https://api.github.com/repos/grayluck/dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/grayluck/dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/grayluck/dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/grayluck/dns/issues/comments{/number}","contents_url":"https://api.github.com/repos/grayluck/dns/contents/{+path}","compare_url":"https://api.github.com/repos/grayluck/dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grayluck/dns/merges","archive_url":"https://api.github.com/repos/grayluck/dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grayluck/dns/downloads","issues_url":"https://api.github.com/repos/grayluck/dns/issues{/number}","pulls_url":"https://api.github.com/repos/grayluck/dns/pulls{/number}","milestones_url":"https://api.github.com/repos/grayluck/dns/milestones{/number}","notifications_url":"https://api.github.com/repos/grayluck/dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grayluck/dns/labels{/name}","releases_url":"https://api.github.com/repos/grayluck/dns/releases{/id}","deployments_url":"https://api.github.com/repos/grayluck/dns/deployments","created_at":"2018-03-22T20:37:20Z","updated_at":"2018-03-28T21:50:34Z","pushed_at":"2018-03-31T00:18:22Z","git_url":"git://github.com/grayluck/dns.git","ssh_url":"git@github.com:grayluck/dns.git","clone_url":"https://github.com/grayluck/dns.git","svn_url":"https://github.com/grayluck/dns","homepage":"","size":8204,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"d522d10e2e5e0797637e89ddb0a68a318cc8be60","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":76596938,"name":"dns","full_name":"kubernetes/dns","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/dns","description":"Kubernetes DNS service","fork":false,"url":"https://api.github.com/repos/kubernetes/dns","forks_url":"https://api.github.com/repos/kubernetes/dns/forks","keys_url":"https://api.github.com/repos/kubernetes/dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/dns/teams","hooks_url":"https://api.github.com/repos/kubernetes/dns/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/dns/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/dns/events","assignees_url":"https://api.github.com/repos/kubernetes/dns/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/dns/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/dns/tags","blobs_url":"https://api.github.com/repos/kubernetes/dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/dns/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/dns/languages","stargazers_url":"https://api.github.com/repos/kubernetes/dns/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/dns/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/dns/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/dns/subscription","commits_url":"https://api.github.com/repos/kubernetes/dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/dns/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/dns/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/dns/merges","archive_url":"https://api.github.com/repos/kubernetes/dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/dns/downloads","issues_url":"https://api.github.com/repos/kubernetes/dns/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/dns/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/dns/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/dns/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/dns/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/dns/deployments","created_at":"2016-12-15T21:20:19Z","updated_at":"2018-03-28T08:42:46Z","pushed_at":"2018-03-31T00:18:23Z","git_url":"git://github.com/kubernetes/dns.git","ssh_url":"git@github.com:kubernetes/dns.git","clone_url":"https://github.com/kubernetes/dns.git","svn_url":"https://github.com/kubernetes/dns","homepage":"","size":8187,"stargazers_count":172,"watchers_count":172,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":136,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":136,"open_issues":35,"watchers":172,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/dns/pulls/220"},"html":{"href":"https://github.com/kubernetes/dns/pull/220"},"issue":{"href":"https://api.github.com/repos/kubernetes/dns/issues/220"},"comments":{"href":"https://api.github.com/repos/kubernetes/dns/issues/220/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/dns/pulls/220/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/dns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/dns/pulls/220/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/dns/statuses/89dc8629e93c02cbac6a96badacd07fa539f8b6d"}},"author_association":"NONE"}}
{"actor":{"display_login":"bowei"}}