{"action":"closed","number":4543,"pull_request":{"url":"https://api.github.com/repos/zeit/next.js/pulls/4543","id":192789488,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNzg5NDg4","html_url":"https://github.com/zeit/next.js/pull/4543","diff_url":"https://github.com/zeit/next.js/pull/4543.diff","patch_url":"https://github.com/zeit/next.js/pull/4543.patch","issue_url":"https://api.github.com/repos/zeit/next.js/issues/4543","number":4543,"state":"closed","locked":false,"title":"Upgrade with-jest-typescript example to next 6.0.0","user":{"login":"ngauthier","id":13654,"node_id":"MDQ6VXNlcjEzNjU0","avatar_url":"https://avatars3.githubusercontent.com/u/13654?v=4","gravatar_id":"","url":"https://api.github.com/users/ngauthier","html_url":"https://github.com/ngauthier","followers_url":"https://api.github.com/users/ngauthier/followers","following_url":"https://api.github.com/users/ngauthier/following{/other_user}","gists_url":"https://api.github.com/users/ngauthier/gists{/gist_id}","starred_url":"https://api.github.com/users/ngauthier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngauthier/subscriptions","organizations_url":"https://api.github.com/users/ngauthier/orgs","repos_url":"https://api.github.com/users/ngauthier/repos","events_url":"https://api.github.com/users/ngauthier/events{/privacy}","received_events_url":"https://api.github.com/users/ngauthier/received_events","type":"User","site_admin":false},"body":"Hello! I ran into an issue using typescript and jest with next 6.0.0. I was able to work through fixing it and I wanted to share my solution back to next.js, by upgrading the with-jest-typescript example to next 6.0.0.\r\n\r\nThe steps I followed were:\r\n\r\n1. `npx babel-upgrade --write` which added babel-core@^7.0.0-bridge.0 to allow jest's babel 6 to play nice with next's babel 7\r\n2. Remove `ts-jest` and replace with `babel-jest` to use babel to transform the typescript code, as is done when the dev and production builds run\r\n3. Update the babelrc to use commonjs modules in test mode to be compatible with jest\r\n\r\nAlso, I removed the `NODE_ENV=test` on the jest task, because jest sets the env to test anyways, and I'm on windows where this code is incorrect. The other option is to use `cross-env` but I felt it was simpler to just remove the environment override.\r\n\r\nTo my knowledge, this PR would help on the following issues:\r\n\r\n#3663 #4227 #4531 #4528 #4239 ","created_at":"2018-06-05T17:59:06Z","updated_at":"2018-06-06T08:31:22Z","closed_at":"2018-06-06T08:31:21Z","merged_at":"2018-06-06T08:31:21Z","merge_commit_sha":"bbbf7ab4987e8037801b6ee4b652b06b0901a495","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zeit/next.js/pulls/4543/commits","review_comments_url":"https://api.github.com/repos/zeit/next.js/pulls/4543/comments","review_comment_url":"https://api.github.com/repos/zeit/next.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zeit/next.js/issues/4543/comments","statuses_url":"https://api.github.com/repos/zeit/next.js/statuses/fdf466acde58541c06876d32f1b83d2148c5f867","head":{"label":"ngauthier:ngauthier-upgrade-typescript-jest-example-6.0.0","ref":"ngauthier-upgrade-typescript-jest-example-6.0.0","sha":"fdf466acde58541c06876d32f1b83d2148c5f867","user":{"login":"ngauthier","id":13654,"node_id":"MDQ6VXNlcjEzNjU0","avatar_url":"https://avatars3.githubusercontent.com/u/13654?v=4","gravatar_id":"","url":"https://api.github.com/users/ngauthier","html_url":"https://github.com/ngauthier","followers_url":"https://api.github.com/users/ngauthier/followers","following_url":"https://api.github.com/users/ngauthier/following{/other_user}","gists_url":"https://api.github.com/users/ngauthier/gists{/gist_id}","starred_url":"https://api.github.com/users/ngauthier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngauthier/subscriptions","organizations_url":"https://api.github.com/users/ngauthier/orgs","repos_url":"https://api.github.com/users/ngauthier/repos","events_url":"https://api.github.com/users/ngauthier/events{/privacy}","received_events_url":"https://api.github.com/users/ngauthier/received_events","type":"User","site_admin":false},"repo":{"id":136214109,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYyMTQxMDk=","name":"next.js","full_name":"ngauthier/next.js","owner":{"login":"ngauthier","id":13654,"node_id":"MDQ6VXNlcjEzNjU0","avatar_url":"https://avatars3.githubusercontent.com/u/13654?v=4","gravatar_id":"","url":"https://api.github.com/users/ngauthier","html_url":"https://github.com/ngauthier","followers_url":"https://api.github.com/users/ngauthier/followers","following_url":"https://api.github.com/users/ngauthier/following{/other_user}","gists_url":"https://api.github.com/users/ngauthier/gists{/gist_id}","starred_url":"https://api.github.com/users/ngauthier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngauthier/subscriptions","organizations_url":"https://api.github.com/users/ngauthier/orgs","repos_url":"https://api.github.com/users/ngauthier/repos","events_url":"https://api.github.com/users/ngauthier/events{/privacy}","received_events_url":"https://api.github.com/users/ngauthier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ngauthier/next.js","description":"Next.js is a lightweight framework for static and server‑rendered applications.","fork":true,"url":"https://api.github.com/repos/ngauthier/next.js","forks_url":"https://api.github.com/repos/ngauthier/next.js/forks","keys_url":"https://api.github.com/repos/ngauthier/next.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ngauthier/next.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ngauthier/next.js/teams","hooks_url":"https://api.github.com/repos/ngauthier/next.js/hooks","issue_events_url":"https://api.github.com/repos/ngauthier/next.js/issues/events{/number}","events_url":"https://api.github.com/repos/ngauthier/next.js/events","assignees_url":"https://api.github.com/repos/ngauthier/next.js/assignees{/user}","branches_url":"https://api.github.com/repos/ngauthier/next.js/branches{/branch}","tags_url":"https://api.github.com/repos/ngauthier/next.js/tags","blobs_url":"https://api.github.com/repos/ngauthier/next.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ngauthier/next.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ngauthier/next.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/ngauthier/next.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ngauthier/next.js/statuses/{sha}","languages_url":"https://api.github.com/repos/ngauthier/next.js/languages","stargazers_url":"https://api.github.com/repos/ngauthier/next.js/stargazers","contributors_url":"https://api.github.com/repos/ngauthier/next.js/contributors","subscribers_url":"https://api.github.com/repos/ngauthier/next.js/subscribers","subscription_url":"https://api.github.com/repos/ngauthier/next.js/subscription","commits_url":"https://api.github.com/repos/ngauthier/next.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/ngauthier/next.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/ngauthier/next.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/ngauthier/next.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/ngauthier/next.js/contents/{+path}","compare_url":"https://api.github.com/repos/ngauthier/next.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ngauthier/next.js/merges","archive_url":"https://api.github.com/repos/ngauthier/next.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ngauthier/next.js/downloads","issues_url":"https://api.github.com/repos/ngauthier/next.js/issues{/number}","pulls_url":"https://api.github.com/repos/ngauthier/next.js/pulls{/number}","milestones_url":"https://api.github.com/repos/ngauthier/next.js/milestones{/number}","notifications_url":"https://api.github.com/repos/ngauthier/next.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ngauthier/next.js/labels{/name}","releases_url":"https://api.github.com/repos/ngauthier/next.js/releases{/id}","deployments_url":"https://api.github.com/repos/ngauthier/next.js/deployments","created_at":"2018-06-05T17:47:58Z","updated_at":"2018-06-05T17:48:02Z","pushed_at":"2018-06-05T17:50:39Z","git_url":"git://github.com/ngauthier/next.js.git","ssh_url":"git@github.com:ngauthier/next.js.git","clone_url":"https://github.com/ngauthier/next.js.git","svn_url":"https://github.com/ngauthier/next.js","homepage":"https://nextjs.org","size":6033,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"canary"}},"base":{"label":"zeit:canary","ref":"canary","sha":"5bc3b23c234bb8f2798512fb4f9d51052be58b60","user":{"login":"zeit","id":14985020,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTg1MDIw","avatar_url":"https://avatars0.githubusercontent.com/u/14985020?v=4","gravatar_id":"","url":"https://api.github.com/users/zeit","html_url":"https://github.com/zeit","followers_url":"https://api.github.com/users/zeit/followers","following_url":"https://api.github.com/users/zeit/following{/other_user}","gists_url":"https://api.github.com/users/zeit/gists{/gist_id}","starred_url":"https://api.github.com/users/zeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeit/subscriptions","organizations_url":"https://api.github.com/users/zeit/orgs","repos_url":"https://api.github.com/users/zeit/repos","events_url":"https://api.github.com/users/zeit/events{/privacy}","received_events_url":"https://api.github.com/users/zeit/received_events","type":"Organization","site_admin":false},"repo":{"id":70107786,"node_id":"MDEwOlJlcG9zaXRvcnk3MDEwNzc4Ng==","name":"next.js","full_name":"zeit/next.js","owner":{"login":"zeit","id":14985020,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTg1MDIw","avatar_url":"https://avatars0.githubusercontent.com/u/14985020?v=4","gravatar_id":"","url":"https://api.github.com/users/zeit","html_url":"https://github.com/zeit","followers_url":"https://api.github.com/users/zeit/followers","following_url":"https://api.github.com/users/zeit/following{/other_user}","gists_url":"https://api.github.com/users/zeit/gists{/gist_id}","starred_url":"https://api.github.com/users/zeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeit/subscriptions","organizations_url":"https://api.github.com/users/zeit/orgs","repos_url":"https://api.github.com/users/zeit/repos","events_url":"https://api.github.com/users/zeit/events{/privacy}","received_events_url":"https://api.github.com/users/zeit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zeit/next.js","description":"Next.js is a lightweight framework for static and server‑rendered applications.","fork":false,"url":"https://api.github.com/repos/zeit/next.js","forks_url":"https://api.github.com/repos/zeit/next.js/forks","keys_url":"https://api.github.com/repos/zeit/next.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zeit/next.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zeit/next.js/teams","hooks_url":"https://api.github.com/repos/zeit/next.js/hooks","issue_events_url":"https://api.github.com/repos/zeit/next.js/issues/events{/number}","events_url":"https://api.github.com/repos/zeit/next.js/events","assignees_url":"https://api.github.com/repos/zeit/next.js/assignees{/user}","branches_url":"https://api.github.com/repos/zeit/next.js/branches{/branch}","tags_url":"https://api.github.com/repos/zeit/next.js/tags","blobs_url":"https://api.github.com/repos/zeit/next.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zeit/next.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zeit/next.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/zeit/next.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zeit/next.js/statuses/{sha}","languages_url":"https://api.github.com/repos/zeit/next.js/languages","stargazers_url":"https://api.github.com/repos/zeit/next.js/stargazers","contributors_url":"https://api.github.com/repos/zeit/next.js/contributors","subscribers_url":"https://api.github.com/repos/zeit/next.js/subscribers","subscription_url":"https://api.github.com/repos/zeit/next.js/subscription","commits_url":"https://api.github.com/repos/zeit/next.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/zeit/next.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/zeit/next.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/zeit/next.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/zeit/next.js/contents/{+path}","compare_url":"https://api.github.com/repos/zeit/next.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zeit/next.js/merges","archive_url":"https://api.github.com/repos/zeit/next.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zeit/next.js/downloads","issues_url":"https://api.github.com/repos/zeit/next.js/issues{/number}","pulls_url":"https://api.github.com/repos/zeit/next.js/pulls{/number}","milestones_url":"https://api.github.com/repos/zeit/next.js/milestones{/number}","notifications_url":"https://api.github.com/repos/zeit/next.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zeit/next.js/labels{/name}","releases_url":"https://api.github.com/repos/zeit/next.js/releases{/id}","deployments_url":"https://api.github.com/repos/zeit/next.js/deployments","created_at":"2016-10-05T23:32:51Z","updated_at":"2018-06-06T07:42:58Z","pushed_at":"2018-06-06T08:31:21Z","git_url":"git://github.com/zeit/next.js.git","ssh_url":"git@github.com:zeit/next.js.git","clone_url":"https://github.com/zeit/next.js.git","svn_url":"https://github.com/zeit/next.js","homepage":"https://nextjs.org","size":6033,"stargazers_count":26001,"watchers_count":26001,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2526,"mirror_url":null,"archived":false,"open_issues_count":245,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2526,"open_issues":245,"watchers":26001,"default_branch":"canary"}},"_links":{"self":{"href":"https://api.github.com/repos/zeit/next.js/pulls/4543"},"html":{"href":"https://github.com/zeit/next.js/pull/4543"},"issue":{"href":"https://api.github.com/repos/zeit/next.js/issues/4543"},"comments":{"href":"https://api.github.com/repos/zeit/next.js/issues/4543/comments"},"review_comments":{"href":"https://api.github.com/repos/zeit/next.js/pulls/4543/comments"},"review_comment":{"href":"https://api.github.com/repos/zeit/next.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zeit/next.js/pulls/4543/commits"},"statuses":{"href":"https://api.github.com/repos/zeit/next.js/statuses/fdf466acde58541c06876d32f1b83d2148c5f867"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"timneutkens","id":6324199,"node_id":"MDQ6VXNlcjYzMjQxOTk=","avatar_url":"https://avatars2.githubusercontent.com/u/6324199?v=4","gravatar_id":"","url":"https://api.github.com/users/timneutkens","html_url":"https://github.com/timneutkens","followers_url":"https://api.github.com/users/timneutkens/followers","following_url":"https://api.github.com/users/timneutkens/following{/other_user}","gists_url":"https://api.github.com/users/timneutkens/gists{/gist_id}","starred_url":"https://api.github.com/users/timneutkens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timneutkens/subscriptions","organizations_url":"https://api.github.com/users/timneutkens/orgs","repos_url":"https://api.github.com/users/timneutkens/repos","events_url":"https://api.github.com/users/timneutkens/events{/privacy}","received_events_url":"https://api.github.com/users/timneutkens/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":35,"deletions":16,"changed_files":3}}
{"actor":{"display_login":"timneutkens"}}