{"action":"created","comment":{"url":"https://api.github.com/repos/spatialos/UnrealGDK/pulls/comments/217737216","pull_request_review_id":155527251,"id":217737216,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzczNzIxNg==","diff_hunk":"@@ -138,7 +138,7 @@ void UGlobalStateManager::GetSingletonActorAndChannel(FString ClassName, AActor*\n \tOutActor = nullptr;\n \tOutChannel = nullptr;\n \n-\tUClass* SingletonActorClass = FindObject<UClass>(ANY_PACKAGE, *ClassName);\n+\tUClass* SingletonActorClass = LoadObject<UClass>(nullptr, *ClassName);","path":"Source/SpatialGDK/Private/Interop/GlobalStateManager.cpp","position":5,"original_position":5,"commit_id":"78e54f18be5e9d630fa65895cdf3185bcf6a8cce","original_commit_id":"78e54f18be5e9d630fa65895cdf3185bcf6a8cce","user":{"login":"Vatyx","id":7674163,"node_id":"MDQ6VXNlcjc2NzQxNjM=","avatar_url":"https://avatars1.githubusercontent.com/u/7674163?v=4","gravatar_id":"","url":"https://api.github.com/users/Vatyx","html_url":"https://github.com/Vatyx","followers_url":"https://api.github.com/users/Vatyx/followers","following_url":"https://api.github.com/users/Vatyx/following{/other_user}","gists_url":"https://api.github.com/users/Vatyx/gists{/gist_id}","starred_url":"https://api.github.com/users/Vatyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vatyx/subscriptions","organizations_url":"https://api.github.com/users/Vatyx/orgs","repos_url":"https://api.github.com/users/Vatyx/repos","events_url":"https://api.github.com/users/Vatyx/events{/privacy}","received_events_url":"https://api.github.com/users/Vatyx/received_events","type":"User","site_admin":false},"body":"This was changed due to @m-samiec's comment saying that if a singleton is a blueprint class, and we use `FindObject` it might not be loaded.\r\n\r\n...though since the game is running I don't know how that would be possible.","created_at":"2018-09-14T14:43:47Z","updated_at":"2018-09-14T14:43:47Z","html_url":"https://github.com/spatialos/UnrealGDK/pull/346#discussion_r217737216","pull_request_url":"https://api.github.com/repos/spatialos/UnrealGDK/pulls/346","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/spatialos/UnrealGDK/pulls/comments/217737216"},"html":{"href":"https://github.com/spatialos/UnrealGDK/pull/346#discussion_r217737216"},"pull_request":{"href":"https://api.github.com/repos/spatialos/UnrealGDK/pulls/346"}},"in_reply_to_id":217662007},"pull_request":{"url":"https://api.github.com/repos/spatialos/UnrealGDK/pulls/346","id":215453521,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NDUzNTIx","html_url":"https://github.com/spatialos/UnrealGDK/pull/346","diff_url":"https://github.com/spatialos/UnrealGDK/pull/346.diff","patch_url":"https://github.com/spatialos/UnrealGDK/pull/346.patch","issue_url":"https://api.github.com/repos/spatialos/UnrealGDK/issues/346","number":346,"state":"open","locked":false,"title":"DTB - PR Feedback Round 2","user":{"login":"Vatyx","id":7674163,"node_id":"MDQ6VXNlcjc2NzQxNjM=","avatar_url":"https://avatars1.githubusercontent.com/u/7674163?v=4","gravatar_id":"","url":"https://api.github.com/users/Vatyx","html_url":"https://github.com/Vatyx","followers_url":"https://api.github.com/users/Vatyx/followers","following_url":"https://api.github.com/users/Vatyx/following{/other_user}","gists_url":"https://api.github.com/users/Vatyx/gists{/gist_id}","starred_url":"https://api.github.com/users/Vatyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vatyx/subscriptions","organizations_url":"https://api.github.com/users/Vatyx/orgs","repos_url":"https://api.github.com/users/Vatyx/repos","events_url":"https://api.github.com/users/Vatyx/events{/privacy}","received_events_url":"https://api.github.com/users/Vatyx/received_events","type":"User","site_admin":false},"body":"This is to address feedback received in the dynamic typebindings PR. I've resolved the comments in the DTB PR that this PR addresses.","created_at":"2018-09-14T00:47:41Z","updated_at":"2018-09-14T14:43:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"278714efda074566cc2317d491e74fb603fb8a62","assignee":null,"assignees":[],"requested_reviewers":[{"login":"girayimprobable","id":27704794,"node_id":"MDQ6VXNlcjI3NzA0Nzk0","avatar_url":"https://avatars1.githubusercontent.com/u/27704794?v=4","gravatar_id":"","url":"https://api.github.com/users/girayimprobable","html_url":"https://github.com/girayimprobable","followers_url":"https://api.github.com/users/girayimprobable/followers","following_url":"https://api.github.com/users/girayimprobable/following{/other_user}","gists_url":"https://api.github.com/users/girayimprobable/gists{/gist_id}","starred_url":"https://api.github.com/users/girayimprobable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girayimprobable/subscriptions","organizations_url":"https://api.github.com/users/girayimprobable/orgs","repos_url":"https://api.github.com/users/girayimprobable/repos","events_url":"https://api.github.com/users/girayimprobable/events{/privacy}","received_events_url":"https://api.github.com/users/girayimprobable/received_events","type":"User","site_admin":false},{"login":"improbable-valentyn","id":32096431,"node_id":"MDQ6VXNlcjMyMDk2NDMx","avatar_url":"https://avatars0.githubusercontent.com/u/32096431?v=4","gravatar_id":"","url":"https://api.github.com/users/improbable-valentyn","html_url":"https://github.com/improbable-valentyn","followers_url":"https://api.github.com/users/improbable-valentyn/followers","following_url":"https://api.github.com/users/improbable-valentyn/following{/other_user}","gists_url":"https://api.github.com/users/improbable-valentyn/gists{/gist_id}","starred_url":"https://api.github.com/users/improbable-valentyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/improbable-valentyn/subscriptions","organizations_url":"https://api.github.com/users/improbable-valentyn/orgs","repos_url":"https://api.github.com/users/improbable-valentyn/repos","events_url":"https://api.github.com/users/improbable-valentyn/events{/privacy}","received_events_url":"https://api.github.com/users/improbable-valentyn/received_events","type":"User","site_admin":false},{"login":"m-samiec","id":35926786,"node_id":"MDQ6VXNlcjM1OTI2Nzg2","avatar_url":"https://avatars2.githubusercontent.com/u/35926786?v=4","gravatar_id":"","url":"https://api.github.com/users/m-samiec","html_url":"https://github.com/m-samiec","followers_url":"https://api.github.com/users/m-samiec/followers","following_url":"https://api.github.com/users/m-samiec/following{/other_user}","gists_url":"https://api.github.com/users/m-samiec/gists{/gist_id}","starred_url":"https://api.github.com/users/m-samiec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-samiec/subscriptions","organizations_url":"https://api.github.com/users/m-samiec/orgs","repos_url":"https://api.github.com/users/m-samiec/repos","events_url":"https://api.github.com/users/m-samiec/events{/privacy}","received_events_url":"https://api.github.com/users/m-samiec/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1002330437,"node_id":"MDU6TGFiZWwxMDAyMzMwNDM3","url":"https://api.github.com/repos/spatialos/UnrealGDK/labels/size/M","name":"size/M","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/spatialos/UnrealGDK/pulls/346/commits","review_comments_url":"https://api.github.com/repos/spatialos/UnrealGDK/pulls/346/comments","review_comment_url":"https://api.github.com/repos/spatialos/UnrealGDK/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spatialos/UnrealGDK/issues/346/comments","statuses_url":"https://api.github.com/repos/spatialos/UnrealGDK/statuses/78e54f18be5e9d630fa65895cdf3185bcf6a8cce","head":{"label":"spatialos:feature/dtb-pr-feedback-round-2","ref":"feature/dtb-pr-feedback-round-2","sha":"78e54f18be5e9d630fa65895cdf3185bcf6a8cce","user":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"repo":{"id":109980189,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk5ODAxODk=","name":"UnrealGDK","full_name":"spatialos/UnrealGDK","owner":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spatialos/UnrealGDK","description":null,"fork":false,"url":"https://api.github.com/repos/spatialos/UnrealGDK","forks_url":"https://api.github.com/repos/spatialos/UnrealGDK/forks","keys_url":"https://api.github.com/repos/spatialos/UnrealGDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spatialos/UnrealGDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spatialos/UnrealGDK/teams","hooks_url":"https://api.github.com/repos/spatialos/UnrealGDK/hooks","issue_events_url":"https://api.github.com/repos/spatialos/UnrealGDK/issues/events{/number}","events_url":"https://api.github.com/repos/spatialos/UnrealGDK/events","assignees_url":"https://api.github.com/repos/spatialos/UnrealGDK/assignees{/user}","branches_url":"https://api.github.com/repos/spatialos/UnrealGDK/branches{/branch}","tags_url":"https://api.github.com/repos/spatialos/UnrealGDK/tags","blobs_url":"https://api.github.com/repos/spatialos/UnrealGDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spatialos/UnrealGDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spatialos/UnrealGDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/spatialos/UnrealGDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spatialos/UnrealGDK/statuses/{sha}","languages_url":"https://api.github.com/repos/spatialos/UnrealGDK/languages","stargazers_url":"https://api.github.com/repos/spatialos/UnrealGDK/stargazers","contributors_url":"https://api.github.com/repos/spatialos/UnrealGDK/contributors","subscribers_url":"https://api.github.com/repos/spatialos/UnrealGDK/subscribers","subscription_url":"https://api.github.com/repos/spatialos/UnrealGDK/subscription","commits_url":"https://api.github.com/repos/spatialos/UnrealGDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/spatialos/UnrealGDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/spatialos/UnrealGDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/spatialos/UnrealGDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/spatialos/UnrealGDK/contents/{+path}","compare_url":"https://api.github.com/repos/spatialos/UnrealGDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spatialos/UnrealGDK/merges","archive_url":"https://api.github.com/repos/spatialos/UnrealGDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spatialos/UnrealGDK/downloads","issues_url":"https://api.github.com/repos/spatialos/UnrealGDK/issues{/number}","pulls_url":"https://api.github.com/repos/spatialos/UnrealGDK/pulls{/number}","milestones_url":"https://api.github.com/repos/spatialos/UnrealGDK/milestones{/number}","notifications_url":"https://api.github.com/repos/spatialos/UnrealGDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spatialos/UnrealGDK/labels{/name}","releases_url":"https://api.github.com/repos/spatialos/UnrealGDK/releases{/id}","deployments_url":"https://api.github.com/repos/spatialos/UnrealGDK/deployments","created_at":"2017-11-08T13:35:16Z","updated_at":"2018-09-11T10:10:20Z","pushed_at":"2018-09-14T14:06:45Z","git_url":"git://github.com/spatialos/UnrealGDK.git","ssh_url":"git@github.com:spatialos/UnrealGDK.git","clone_url":"https://github.com/spatialos/UnrealGDK.git","svn_url":"https://github.com/spatialos/UnrealGDK","homepage":null,"size":57345,"stargazers_count":51,"watchers_count":51,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":8,"watchers":51,"default_branch":"master"}},"base":{"label":"spatialos:feature/dynamic-typebindings","ref":"feature/dynamic-typebindings","sha":"b93119f1c3aae59a6c5ef76a76304d8ae945d52d","user":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"repo":{"id":109980189,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk5ODAxODk=","name":"UnrealGDK","full_name":"spatialos/UnrealGDK","owner":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spatialos/UnrealGDK","description":null,"fork":false,"url":"https://api.github.com/repos/spatialos/UnrealGDK","forks_url":"https://api.github.com/repos/spatialos/UnrealGDK/forks","keys_url":"https://api.github.com/repos/spatialos/UnrealGDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spatialos/UnrealGDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spatialos/UnrealGDK/teams","hooks_url":"https://api.github.com/repos/spatialos/UnrealGDK/hooks","issue_events_url":"https://api.github.com/repos/spatialos/UnrealGDK/issues/events{/number}","events_url":"https://api.github.com/repos/spatialos/UnrealGDK/events","assignees_url":"https://api.github.com/repos/spatialos/UnrealGDK/assignees{/user}","branches_url":"https://api.github.com/repos/spatialos/UnrealGDK/branches{/branch}","tags_url":"https://api.github.com/repos/spatialos/UnrealGDK/tags","blobs_url":"https://api.github.com/repos/spatialos/UnrealGDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spatialos/UnrealGDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spatialos/UnrealGDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/spatialos/UnrealGDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spatialos/UnrealGDK/statuses/{sha}","languages_url":"https://api.github.com/repos/spatialos/UnrealGDK/languages","stargazers_url":"https://api.github.com/repos/spatialos/UnrealGDK/stargazers","contributors_url":"https://api.github.com/repos/spatialos/UnrealGDK/contributors","subscribers_url":"https://api.github.com/repos/spatialos/UnrealGDK/subscribers","subscription_url":"https://api.github.com/repos/spatialos/UnrealGDK/subscription","commits_url":"https://api.github.com/repos/spatialos/UnrealGDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/spatialos/UnrealGDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/spatialos/UnrealGDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/spatialos/UnrealGDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/spatialos/UnrealGDK/contents/{+path}","compare_url":"https://api.github.com/repos/spatialos/UnrealGDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spatialos/UnrealGDK/merges","archive_url":"https://api.github.com/repos/spatialos/UnrealGDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spatialos/UnrealGDK/downloads","issues_url":"https://api.github.com/repos/spatialos/UnrealGDK/issues{/number}","pulls_url":"https://api.github.com/repos/spatialos/UnrealGDK/pulls{/number}","milestones_url":"https://api.github.com/repos/spatialos/UnrealGDK/milestones{/number}","notifications_url":"https://api.github.com/repos/spatialos/UnrealGDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spatialos/UnrealGDK/labels{/name}","releases_url":"https://api.github.com/repos/spatialos/UnrealGDK/releases{/id}","deployments_url":"https://api.github.com/repos/spatialos/UnrealGDK/deployments","created_at":"2017-11-08T13:35:16Z","updated_at":"2018-09-11T10:10:20Z","pushed_at":"2018-09-14T14:06:45Z","git_url":"git://github.com/spatialos/UnrealGDK.git","ssh_url":"git@github.com:spatialos/UnrealGDK.git","clone_url":"https://github.com/spatialos/UnrealGDK.git","svn_url":"https://github.com/spatialos/UnrealGDK","homepage":null,"size":57345,"stargazers_count":51,"watchers_count":51,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":8,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spatialos/UnrealGDK/pulls/346"},"html":{"href":"https://github.com/spatialos/UnrealGDK/pull/346"},"issue":{"href":"https://api.github.com/repos/spatialos/UnrealGDK/issues/346"},"comments":{"href":"https://api.github.com/repos/spatialos/UnrealGDK/issues/346/comments"},"review_comments":{"href":"https://api.github.com/repos/spatialos/UnrealGDK/pulls/346/comments"},"review_comment":{"href":"https://api.github.com/repos/spatialos/UnrealGDK/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spatialos/UnrealGDK/pulls/346/commits"},"statuses":{"href":"https://api.github.com/repos/spatialos/UnrealGDK/statuses/78e54f18be5e9d630fa65895cdf3185bcf6a8cce"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Vatyx"}}