{"action":"created","comment":{"url":"https://api.github.com/repos/gnuradio/gnuradio/pulls/comments/205693355","pull_request_review_id":141014847,"id":205693355,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTY5MzM1NQ==","diff_hunk":"@@ -373,7 +373,7 @@ def import_data(self, data):\n         def verify_and_get_port(key, block, dir):\n             ports = block.sinks if dir == 'sink' else block.sources\n             for port in ports:\n-                if key == port.key or key + '0' == port.key:\n+                if key == port.name or key + '0' == port.name or key == port.key:","path":"grc/core/FlowGraph.py","position":5,"original_position":5,"commit_id":"7c61683cfd4d2bebb29af4b93bc86067976b6b06","original_commit_id":"7c61683cfd4d2bebb29af4b93bc86067976b6b06","user":{"login":"noc0lour","id":4438327,"node_id":"MDQ6VXNlcjQ0MzgzMjc=","avatar_url":"https://avatars1.githubusercontent.com/u/4438327?v=4","gravatar_id":"","url":"https://api.github.com/users/noc0lour","html_url":"https://github.com/noc0lour","followers_url":"https://api.github.com/users/noc0lour/followers","following_url":"https://api.github.com/users/noc0lour/following{/other_user}","gists_url":"https://api.github.com/users/noc0lour/gists{/gist_id}","starred_url":"https://api.github.com/users/noc0lour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noc0lour/subscriptions","organizations_url":"https://api.github.com/users/noc0lour/orgs","repos_url":"https://api.github.com/users/noc0lour/repos","events_url":"https://api.github.com/users/noc0lour/events{/privacy}","received_events_url":"https://api.github.com/users/noc0lour/received_events","type":"User","site_admin":false},"body":"I really can't say what's the right way here. This is as close as I got to a working solution, which still falls short for some connections...","created_at":"2018-07-27T07:50:14Z","updated_at":"2018-07-27T07:50:15Z","html_url":"https://github.com/gnuradio/gnuradio/pull/1915#discussion_r205693355","pull_request_url":"https://api.github.com/repos/gnuradio/gnuradio/pulls/1915","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/gnuradio/gnuradio/pulls/comments/205693355"},"html":{"href":"https://github.com/gnuradio/gnuradio/pull/1915#discussion_r205693355"},"pull_request":{"href":"https://api.github.com/repos/gnuradio/gnuradio/pulls/1915"}},"in_reply_to_id":205690214},"pull_request":{"url":"https://api.github.com/repos/gnuradio/gnuradio/pulls/1915","id":203603191,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNjAzMTkx","html_url":"https://github.com/gnuradio/gnuradio/pull/1915","diff_url":"https://github.com/gnuradio/gnuradio/pull/1915.diff","patch_url":"https://github.com/gnuradio/gnuradio/pull/1915.patch","issue_url":"https://api.github.com/repos/gnuradio/gnuradio/issues/1915","number":1915,"state":"open","locked":false,"title":"grc: merge fixes for YML transition","user":{"login":"noc0lour","id":4438327,"node_id":"MDQ6VXNlcjQ0MzgzMjc=","avatar_url":"https://avatars1.githubusercontent.com/u/4438327?v=4","gravatar_id":"","url":"https://api.github.com/users/noc0lour","html_url":"https://github.com/noc0lour","followers_url":"https://api.github.com/users/noc0lour/followers","following_url":"https://api.github.com/users/noc0lour/following{/other_user}","gists_url":"https://api.github.com/users/noc0lour/gists{/gist_id}","starred_url":"https://api.github.com/users/noc0lour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noc0lour/subscriptions","organizations_url":"https://api.github.com/users/noc0lour/orgs","repos_url":"https://api.github.com/users/noc0lour/repos","events_url":"https://api.github.com/users/noc0lour/events{/privacy}","received_events_url":"https://api.github.com/users/noc0lour/received_events","type":"User","site_admin":false},"body":"This PR supersedes #1875 and #1481\n\nAdditionally:\nThis PR fixes documentation in the GRC tab and the port name parsing.\nIt is entirely possible that documentation won't be shown for py2 now, but at least for py3k the \ndocumentation extractor works now.\n\nI need some thoughts on b5ce295e2 as well, since this changes the port naming/checking a lot and \nmight be wrong, though previously blocks with multiple connections did not work at all.","created_at":"2018-07-24T17:40:16Z","updated_at":"2018-07-27T07:50:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70ac126fae6aee612e7afbe2096ffd953de88a08","assignee":null,"assignees":[],"requested_reviewers":[{"login":"haakov","id":1413378,"node_id":"MDQ6VXNlcjE0MTMzNzg=","avatar_url":"https://avatars1.githubusercontent.com/u/1413378?v=4","gravatar_id":"","url":"https://api.github.com/users/haakov","html_url":"https://github.com/haakov","followers_url":"https://api.github.com/users/haakov/followers","following_url":"https://api.github.com/users/haakov/following{/other_user}","gists_url":"https://api.github.com/users/haakov/gists{/gist_id}","starred_url":"https://api.github.com/users/haakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haakov/subscriptions","organizations_url":"https://api.github.com/users/haakov/orgs","repos_url":"https://api.github.com/users/haakov/repos","events_url":"https://api.github.com/users/haakov/events{/privacy}","received_events_url":"https://api.github.com/users/haakov/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gnuradio/gnuradio/pulls/1915/commits","review_comments_url":"https://api.github.com/repos/gnuradio/gnuradio/pulls/1915/comments","review_comment_url":"https://api.github.com/repos/gnuradio/gnuradio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gnuradio/gnuradio/issues/1915/comments","statuses_url":"https://api.github.com/repos/gnuradio/gnuradio/statuses/7c61683cfd4d2bebb29af4b93bc86067976b6b06","head":{"label":"noc0lour:merge_grc_fixes","ref":"merge_grc_fixes","sha":"7c61683cfd4d2bebb29af4b93bc86067976b6b06","user":{"login":"noc0lour","id":4438327,"node_id":"MDQ6VXNlcjQ0MzgzMjc=","avatar_url":"https://avatars1.githubusercontent.com/u/4438327?v=4","gravatar_id":"","url":"https://api.github.com/users/noc0lour","html_url":"https://github.com/noc0lour","followers_url":"https://api.github.com/users/noc0lour/followers","following_url":"https://api.github.com/users/noc0lour/following{/other_user}","gists_url":"https://api.github.com/users/noc0lour/gists{/gist_id}","starred_url":"https://api.github.com/users/noc0lour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noc0lour/subscriptions","organizations_url":"https://api.github.com/users/noc0lour/orgs","repos_url":"https://api.github.com/users/noc0lour/repos","events_url":"https://api.github.com/users/noc0lour/events{/privacy}","received_events_url":"https://api.github.com/users/noc0lour/received_events","type":"User","site_admin":false},"repo":{"id":51384278,"node_id":"MDEwOlJlcG9zaXRvcnk1MTM4NDI3OA==","name":"gnuradio","full_name":"noc0lour/gnuradio","owner":{"login":"noc0lour","id":4438327,"node_id":"MDQ6VXNlcjQ0MzgzMjc=","avatar_url":"https://avatars1.githubusercontent.com/u/4438327?v=4","gravatar_id":"","url":"https://api.github.com/users/noc0lour","html_url":"https://github.com/noc0lour","followers_url":"https://api.github.com/users/noc0lour/followers","following_url":"https://api.github.com/users/noc0lour/following{/other_user}","gists_url":"https://api.github.com/users/noc0lour/gists{/gist_id}","starred_url":"https://api.github.com/users/noc0lour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noc0lour/subscriptions","organizations_url":"https://api.github.com/users/noc0lour/orgs","repos_url":"https://api.github.com/users/noc0lour/repos","events_url":"https://api.github.com/users/noc0lour/events{/privacy}","received_events_url":"https://api.github.com/users/noc0lour/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/noc0lour/gnuradio","description":"GNU Radio","fork":true,"url":"https://api.github.com/repos/noc0lour/gnuradio","forks_url":"https://api.github.com/repos/noc0lour/gnuradio/forks","keys_url":"https://api.github.com/repos/noc0lour/gnuradio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/noc0lour/gnuradio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/noc0lour/gnuradio/teams","hooks_url":"https://api.github.com/repos/noc0lour/gnuradio/hooks","issue_events_url":"https://api.github.com/repos/noc0lour/gnuradio/issues/events{/number}","events_url":"https://api.github.com/repos/noc0lour/gnuradio/events","assignees_url":"https://api.github.com/repos/noc0lour/gnuradio/assignees{/user}","branches_url":"https://api.github.com/repos/noc0lour/gnuradio/branches{/branch}","tags_url":"https://api.github.com/repos/noc0lour/gnuradio/tags","blobs_url":"https://api.github.com/repos/noc0lour/gnuradio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/noc0lour/gnuradio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/noc0lour/gnuradio/git/refs{/sha}","trees_url":"https://api.github.com/repos/noc0lour/gnuradio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/noc0lour/gnuradio/statuses/{sha}","languages_url":"https://api.github.com/repos/noc0lour/gnuradio/languages","stargazers_url":"https://api.github.com/repos/noc0lour/gnuradio/stargazers","contributors_url":"https://api.github.com/repos/noc0lour/gnuradio/contributors","subscribers_url":"https://api.github.com/repos/noc0lour/gnuradio/subscribers","subscription_url":"https://api.github.com/repos/noc0lour/gnuradio/subscription","commits_url":"https://api.github.com/repos/noc0lour/gnuradio/commits{/sha}","git_commits_url":"https://api.github.com/repos/noc0lour/gnuradio/git/commits{/sha}","comments_url":"https://api.github.com/repos/noc0lour/gnuradio/comments{/number}","issue_comment_url":"https://api.github.com/repos/noc0lour/gnuradio/issues/comments{/number}","contents_url":"https://api.github.com/repos/noc0lour/gnuradio/contents/{+path}","compare_url":"https://api.github.com/repos/noc0lour/gnuradio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/noc0lour/gnuradio/merges","archive_url":"https://api.github.com/repos/noc0lour/gnuradio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/noc0lour/gnuradio/downloads","issues_url":"https://api.github.com/repos/noc0lour/gnuradio/issues{/number}","pulls_url":"https://api.github.com/repos/noc0lour/gnuradio/pulls{/number}","milestones_url":"https://api.github.com/repos/noc0lour/gnuradio/milestones{/number}","notifications_url":"https://api.github.com/repos/noc0lour/gnuradio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/noc0lour/gnuradio/labels{/name}","releases_url":"https://api.github.com/repos/noc0lour/gnuradio/releases{/id}","deployments_url":"https://api.github.com/repos/noc0lour/gnuradio/deployments","created_at":"2016-02-09T17:30:06Z","updated_at":"2016-02-09T17:30:17Z","pushed_at":"2018-07-26T15:32:43Z","git_url":"git://github.com/noc0lour/gnuradio.git","ssh_url":"git@github.com:noc0lour/gnuradio.git","clone_url":"https://github.com/noc0lour/gnuradio.git","svn_url":"https://github.com/noc0lour/gnuradio","homepage":"gnuradio.org","size":55611,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gnuradio:next","ref":"next","sha":"201afd9a330adda44fcde41a36efce20f5a0b46d","user":{"login":"gnuradio","id":1278659,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzg2NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1278659?v=4","gravatar_id":"","url":"https://api.github.com/users/gnuradio","html_url":"https://github.com/gnuradio","followers_url":"https://api.github.com/users/gnuradio/followers","following_url":"https://api.github.com/users/gnuradio/following{/other_user}","gists_url":"https://api.github.com/users/gnuradio/gists{/gist_id}","starred_url":"https://api.github.com/users/gnuradio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnuradio/subscriptions","organizations_url":"https://api.github.com/users/gnuradio/orgs","repos_url":"https://api.github.com/users/gnuradio/repos","events_url":"https://api.github.com/users/gnuradio/events{/privacy}","received_events_url":"https://api.github.com/users/gnuradio/received_events","type":"Organization","site_admin":false},"repo":{"id":3030065,"node_id":"MDEwOlJlcG9zaXRvcnkzMDMwMDY1","name":"gnuradio","full_name":"gnuradio/gnuradio","owner":{"login":"gnuradio","id":1278659,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzg2NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1278659?v=4","gravatar_id":"","url":"https://api.github.com/users/gnuradio","html_url":"https://github.com/gnuradio","followers_url":"https://api.github.com/users/gnuradio/followers","following_url":"https://api.github.com/users/gnuradio/following{/other_user}","gists_url":"https://api.github.com/users/gnuradio/gists{/gist_id}","starred_url":"https://api.github.com/users/gnuradio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnuradio/subscriptions","organizations_url":"https://api.github.com/users/gnuradio/orgs","repos_url":"https://api.github.com/users/gnuradio/repos","events_url":"https://api.github.com/users/gnuradio/events{/privacy}","received_events_url":"https://api.github.com/users/gnuradio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gnuradio/gnuradio","description":"GNU Radio","fork":false,"url":"https://api.github.com/repos/gnuradio/gnuradio","forks_url":"https://api.github.com/repos/gnuradio/gnuradio/forks","keys_url":"https://api.github.com/repos/gnuradio/gnuradio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gnuradio/gnuradio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gnuradio/gnuradio/teams","hooks_url":"https://api.github.com/repos/gnuradio/gnuradio/hooks","issue_events_url":"https://api.github.com/repos/gnuradio/gnuradio/issues/events{/number}","events_url":"https://api.github.com/repos/gnuradio/gnuradio/events","assignees_url":"https://api.github.com/repos/gnuradio/gnuradio/assignees{/user}","branches_url":"https://api.github.com/repos/gnuradio/gnuradio/branches{/branch}","tags_url":"https://api.github.com/repos/gnuradio/gnuradio/tags","blobs_url":"https://api.github.com/repos/gnuradio/gnuradio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gnuradio/gnuradio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gnuradio/gnuradio/git/refs{/sha}","trees_url":"https://api.github.com/repos/gnuradio/gnuradio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gnuradio/gnuradio/statuses/{sha}","languages_url":"https://api.github.com/repos/gnuradio/gnuradio/languages","stargazers_url":"https://api.github.com/repos/gnuradio/gnuradio/stargazers","contributors_url":"https://api.github.com/repos/gnuradio/gnuradio/contributors","subscribers_url":"https://api.github.com/repos/gnuradio/gnuradio/subscribers","subscription_url":"https://api.github.com/repos/gnuradio/gnuradio/subscription","commits_url":"https://api.github.com/repos/gnuradio/gnuradio/commits{/sha}","git_commits_url":"https://api.github.com/repos/gnuradio/gnuradio/git/commits{/sha}","comments_url":"https://api.github.com/repos/gnuradio/gnuradio/comments{/number}","issue_comment_url":"https://api.github.com/repos/gnuradio/gnuradio/issues/comments{/number}","contents_url":"https://api.github.com/repos/gnuradio/gnuradio/contents/{+path}","compare_url":"https://api.github.com/repos/gnuradio/gnuradio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gnuradio/gnuradio/merges","archive_url":"https://api.github.com/repos/gnuradio/gnuradio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gnuradio/gnuradio/downloads","issues_url":"https://api.github.com/repos/gnuradio/gnuradio/issues{/number}","pulls_url":"https://api.github.com/repos/gnuradio/gnuradio/pulls{/number}","milestones_url":"https://api.github.com/repos/gnuradio/gnuradio/milestones{/number}","notifications_url":"https://api.github.com/repos/gnuradio/gnuradio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gnuradio/gnuradio/labels{/name}","releases_url":"https://api.github.com/repos/gnuradio/gnuradio/releases{/id}","deployments_url":"https://api.github.com/repos/gnuradio/gnuradio/deployments","created_at":"2011-12-21T22:05:37Z","updated_at":"2018-07-26T02:41:17Z","pushed_at":"2018-07-26T18:09:18Z","git_url":"git://github.com/gnuradio/gnuradio.git","ssh_url":"git@github.com:gnuradio/gnuradio.git","clone_url":"https://github.com/gnuradio/gnuradio.git","svn_url":"https://github.com/gnuradio/gnuradio","homepage":"https://gnuradio.org","size":49873,"stargazers_count":1277,"watchers_count":1277,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":840,"mirror_url":null,"archived":false,"open_issues_count":270,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":840,"open_issues":270,"watchers":1277,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gnuradio/gnuradio/pulls/1915"},"html":{"href":"https://github.com/gnuradio/gnuradio/pull/1915"},"issue":{"href":"https://api.github.com/repos/gnuradio/gnuradio/issues/1915"},"comments":{"href":"https://api.github.com/repos/gnuradio/gnuradio/issues/1915/comments"},"review_comments":{"href":"https://api.github.com/repos/gnuradio/gnuradio/pulls/1915/comments"},"review_comment":{"href":"https://api.github.com/repos/gnuradio/gnuradio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gnuradio/gnuradio/pulls/1915/commits"},"statuses":{"href":"https://api.github.com/repos/gnuradio/gnuradio/statuses/7c61683cfd4d2bebb29af4b93bc86067976b6b06"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"noc0lour"}}