{"action":"created","issue":{"url":"https://api.github.com/repos/yswery/PHP-DNS-SERVER/issues/48","repository_url":"https://api.github.com/repos/yswery/PHP-DNS-SERVER","labels_url":"https://api.github.com/repos/yswery/PHP-DNS-SERVER/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/yswery/PHP-DNS-SERVER/issues/48/comments","events_url":"https://api.github.com/repos/yswery/PHP-DNS-SERVER/issues/48/events","html_url":"https://github.com/yswery/PHP-DNS-SERVER/issues/48","id":325383375,"node_id":"MDU6SXNzdWUzMjUzODMzNzU=","number":48,"title":"Question regarding DNS question","user":{"login":"ivanstan","id":1379480,"node_id":"MDQ6VXNlcjEzNzk0ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/1379480?v=4","gravatar_id":"","url":"https://api.github.com/users/ivanstan","html_url":"https://github.com/ivanstan","followers_url":"https://api.github.com/users/ivanstan/followers","following_url":"https://api.github.com/users/ivanstan/following{/other_user}","gists_url":"https://api.github.com/users/ivanstan/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanstan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanstan/subscriptions","organizations_url":"https://api.github.com/users/ivanstan/orgs","repos_url":"https://api.github.com/users/ivanstan/repos","events_url":"https://api.github.com/users/ivanstan/events{/privacy}","received_events_url":"https://api.github.com/users/ivanstan/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-22T17:01:17Z","updated_at":"2018-09-16T04:13:12Z","closed_at":"2018-09-16T04:13:12Z","author_association":"CONTRIBUTOR","body":"@yswery please take a look at: \r\n\r\nhttps://github.com/yswery/PHP-DNS-SERVER/blob/master/src/JsonResolver.php:61\r\n```\r\n    /**\r\n     * @param array $question\r\n     * @return array\r\n     */\r\n    public function getAnswer(array $question)\r\n    {\r\n        $q_name = $question[0]['qname'];\r\n        $q_type = $question[0]['qtype'];\r\n        $q_class = $question[0]['qclass'];\r\n        $domain = trim($q_name, '.');\r\n        $type = RecordTypeEnum::get_name($q_type);\r\n```\r\n\r\nI don't understand why are we sending array of questions to the resolver->getAnswer() instead of just one question? We are always catching the first array element and resolving that as a question. Is it perhaps possible that user can ask for multiple queries and get the answers within a single request?"},"comment":{"url":"https://api.github.com/repos/yswery/PHP-DNS-SERVER/issues/comments/421689184","html_url":"https://github.com/yswery/PHP-DNS-SERVER/issues/48#issuecomment-421689184","issue_url":"https://api.github.com/repos/yswery/PHP-DNS-SERVER/issues/48","id":421689184,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTY4OTE4NA==","user":{"login":"samuelwilliams","id":806430,"node_id":"MDQ6VXNlcjgwNjQzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/806430?v=4","gravatar_id":"","url":"https://api.github.com/users/samuelwilliams","html_url":"https://github.com/samuelwilliams","followers_url":"https://api.github.com/users/samuelwilliams/followers","following_url":"https://api.github.com/users/samuelwilliams/following{/other_user}","gists_url":"https://api.github.com/users/samuelwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelwilliams/subscriptions","organizations_url":"https://api.github.com/users/samuelwilliams/orgs","repos_url":"https://api.github.com/users/samuelwilliams/repos","events_url":"https://api.github.com/users/samuelwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/samuelwilliams/received_events","type":"User","site_admin":false},"created_at":"2018-09-16T04:13:12Z","updated_at":"2018-09-16T04:13:12Z","author_association":"COLLABORATOR","body":"This has been addressed in branch version-1"}}
{"actor":{"display_login":"samuelwilliams"}}