{"action":"created","comment":{"url":"https://api.github.com/repos/JGCRI/xanthos/pulls/comments/238785464","pull_request_review_id":181413371,"id":238785464,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODc4NTQ2NA==","diff_hunk":"@@ -143,7 +143,7 @@ def __init__(self, config_obj):\n                     'TempMinFile variable not found for the ABCD runoff module; Snowmelt will not be accounted for.')\n                 self.tmin = None\n             else:\n-                self.tmin = self.load_to_array(self.s.TempMinFile, varname=self.s.TempMinVarName)\n+                self.tmin = self.load_to_array(self.s.TempMinFile, varname=self.s.TempMinVarName, nan_to_num=True)","path":"xanthos/data_reader/data_load.py","position":5,"original_position":5,"commit_id":"63af4bd96802111a06fe97f453a643045407e6d0","original_commit_id":"63af4bd96802111a06fe97f453a643045407e6d0","user":{"login":"crvernon","id":3947069,"node_id":"MDQ6VXNlcjM5NDcwNjk=","avatar_url":"https://avatars1.githubusercontent.com/u/3947069?v=4","gravatar_id":"","url":"https://api.github.com/users/crvernon","html_url":"https://github.com/crvernon","followers_url":"https://api.github.com/users/crvernon/followers","following_url":"https://api.github.com/users/crvernon/following{/other_user}","gists_url":"https://api.github.com/users/crvernon/gists{/gist_id}","starred_url":"https://api.github.com/users/crvernon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crvernon/subscriptions","organizations_url":"https://api.github.com/users/crvernon/orgs","repos_url":"https://api.github.com/users/crvernon/repos","events_url":"https://api.github.com/users/crvernon/events{/privacy}","received_events_url":"https://api.github.com/users/crvernon/received_events","type":"User","site_admin":false},"body":"The requirements of the _abcd_ model are that there will not no NaNs represented in the data.  So  we should always warn and convert NaNs when present when using the _abcd_ model.","created_at":"2018-12-04T18:34:06Z","updated_at":"2018-12-04T18:34:06Z","html_url":"https://github.com/JGCRI/xanthos/pull/31#discussion_r238785464","pull_request_url":"https://api.github.com/repos/JGCRI/xanthos/pulls/31","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/JGCRI/xanthos/pulls/comments/238785464"},"html":{"href":"https://github.com/JGCRI/xanthos/pull/31#discussion_r238785464"},"pull_request":{"href":"https://api.github.com/repos/JGCRI/xanthos/pulls/31"}},"in_reply_to_id":238782026},"pull_request":{"url":"https://api.github.com/repos/JGCRI/xanthos/pulls/31","id":235910338,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1OTEwMzM4","html_url":"https://github.com/JGCRI/xanthos/pull/31","diff_url":"https://github.com/JGCRI/xanthos/pull/31.diff","patch_url":"https://github.com/JGCRI/xanthos/pull/31.patch","issue_url":"https://api.github.com/repos/JGCRI/xanthos/issues/31","number":31,"state":"open","locked":false,"title":"Add Thornthwaite ABCD None configuration","user":{"login":"calebbraun","id":12344924,"node_id":"MDQ6VXNlcjEyMzQ0OTI0","avatar_url":"https://avatars3.githubusercontent.com/u/12344924?v=4","gravatar_id":"","url":"https://api.github.com/users/calebbraun","html_url":"https://github.com/calebbraun","followers_url":"https://api.github.com/users/calebbraun/followers","following_url":"https://api.github.com/users/calebbraun/following{/other_user}","gists_url":"https://api.github.com/users/calebbraun/gists{/gist_id}","starred_url":"https://api.github.com/users/calebbraun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calebbraun/subscriptions","organizations_url":"https://api.github.com/users/calebbraun/orgs","repos_url":"https://api.github.com/users/calebbraun/repos","events_url":"https://api.github.com/users/calebbraun/events{/privacy}","received_events_url":"https://api.github.com/users/calebbraun/received_events","type":"User","site_admin":false},"body":"This configuration is the fastest for producing runoff outputs.\r\n\r\n- Also implements better handling of logs, when an instance of Xanthos is run more than once","created_at":"2018-12-04T18:17:52Z","updated_at":"2018-12-04T18:34:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c31990d7a9215c505dcbab7cb79d294d93b9fdb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JGCRI/xanthos/pulls/31/commits","review_comments_url":"https://api.github.com/repos/JGCRI/xanthos/pulls/31/comments","review_comment_url":"https://api.github.com/repos/JGCRI/xanthos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JGCRI/xanthos/issues/31/comments","statuses_url":"https://api.github.com/repos/JGCRI/xanthos/statuses/63af4bd96802111a06fe97f453a643045407e6d0","head":{"label":"JGCRI:trn_abcd_none","ref":"trn_abcd_none","sha":"63af4bd96802111a06fe97f453a643045407e6d0","user":{"login":"JGCRI","id":8431983,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MzE5ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/8431983?v=4","gravatar_id":"","url":"https://api.github.com/users/JGCRI","html_url":"https://github.com/JGCRI","followers_url":"https://api.github.com/users/JGCRI/followers","following_url":"https://api.github.com/users/JGCRI/following{/other_user}","gists_url":"https://api.github.com/users/JGCRI/gists{/gist_id}","starred_url":"https://api.github.com/users/JGCRI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JGCRI/subscriptions","organizations_url":"https://api.github.com/users/JGCRI/orgs","repos_url":"https://api.github.com/users/JGCRI/repos","events_url":"https://api.github.com/users/JGCRI/events{/privacy}","received_events_url":"https://api.github.com/users/JGCRI/received_events","type":"Organization","site_admin":false},"repo":{"id":88797535,"node_id":"MDEwOlJlcG9zaXRvcnk4ODc5NzUzNQ==","name":"xanthos","full_name":"JGCRI/xanthos","private":false,"owner":{"login":"JGCRI","id":8431983,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MzE5ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/8431983?v=4","gravatar_id":"","url":"https://api.github.com/users/JGCRI","html_url":"https://github.com/JGCRI","followers_url":"https://api.github.com/users/JGCRI/followers","following_url":"https://api.github.com/users/JGCRI/following{/other_user}","gists_url":"https://api.github.com/users/JGCRI/gists{/gist_id}","starred_url":"https://api.github.com/users/JGCRI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JGCRI/subscriptions","organizations_url":"https://api.github.com/users/JGCRI/orgs","repos_url":"https://api.github.com/users/JGCRI/repos","events_url":"https://api.github.com/users/JGCRI/events{/privacy}","received_events_url":"https://api.github.com/users/JGCRI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JGCRI/xanthos","description":"An extensible global hydrologic model","fork":false,"url":"https://api.github.com/repos/JGCRI/xanthos","forks_url":"https://api.github.com/repos/JGCRI/xanthos/forks","keys_url":"https://api.github.com/repos/JGCRI/xanthos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JGCRI/xanthos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JGCRI/xanthos/teams","hooks_url":"https://api.github.com/repos/JGCRI/xanthos/hooks","issue_events_url":"https://api.github.com/repos/JGCRI/xanthos/issues/events{/number}","events_url":"https://api.github.com/repos/JGCRI/xanthos/events","assignees_url":"https://api.github.com/repos/JGCRI/xanthos/assignees{/user}","branches_url":"https://api.github.com/repos/JGCRI/xanthos/branches{/branch}","tags_url":"https://api.github.com/repos/JGCRI/xanthos/tags","blobs_url":"https://api.github.com/repos/JGCRI/xanthos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JGCRI/xanthos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JGCRI/xanthos/git/refs{/sha}","trees_url":"https://api.github.com/repos/JGCRI/xanthos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JGCRI/xanthos/statuses/{sha}","languages_url":"https://api.github.com/repos/JGCRI/xanthos/languages","stargazers_url":"https://api.github.com/repos/JGCRI/xanthos/stargazers","contributors_url":"https://api.github.com/repos/JGCRI/xanthos/contributors","subscribers_url":"https://api.github.com/repos/JGCRI/xanthos/subscribers","subscription_url":"https://api.github.com/repos/JGCRI/xanthos/subscription","commits_url":"https://api.github.com/repos/JGCRI/xanthos/commits{/sha}","git_commits_url":"https://api.github.com/repos/JGCRI/xanthos/git/commits{/sha}","comments_url":"https://api.github.com/repos/JGCRI/xanthos/comments{/number}","issue_comment_url":"https://api.github.com/repos/JGCRI/xanthos/issues/comments{/number}","contents_url":"https://api.github.com/repos/JGCRI/xanthos/contents/{+path}","compare_url":"https://api.github.com/repos/JGCRI/xanthos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JGCRI/xanthos/merges","archive_url":"https://api.github.com/repos/JGCRI/xanthos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JGCRI/xanthos/downloads","issues_url":"https://api.github.com/repos/JGCRI/xanthos/issues{/number}","pulls_url":"https://api.github.com/repos/JGCRI/xanthos/pulls{/number}","milestones_url":"https://api.github.com/repos/JGCRI/xanthos/milestones{/number}","notifications_url":"https://api.github.com/repos/JGCRI/xanthos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JGCRI/xanthos/labels{/name}","releases_url":"https://api.github.com/repos/JGCRI/xanthos/releases{/id}","deployments_url":"https://api.github.com/repos/JGCRI/xanthos/deployments","created_at":"2017-04-19T22:47:48Z","updated_at":"2018-11-29T18:12:51Z","pushed_at":"2018-12-04T18:17:52Z","git_url":"git://github.com/JGCRI/xanthos.git","ssh_url":"git@github.com:JGCRI/xanthos.git","clone_url":"https://github.com/JGCRI/xanthos.git","svn_url":"https://github.com/JGCRI/xanthos","homepage":"","size":261001,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":7,"watchers":12,"default_branch":"master"}},"base":{"label":"JGCRI:master","ref":"master","sha":"4303d1b53d9003840309091e8691411ffe67fe67","user":{"login":"JGCRI","id":8431983,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MzE5ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/8431983?v=4","gravatar_id":"","url":"https://api.github.com/users/JGCRI","html_url":"https://github.com/JGCRI","followers_url":"https://api.github.com/users/JGCRI/followers","following_url":"https://api.github.com/users/JGCRI/following{/other_user}","gists_url":"https://api.github.com/users/JGCRI/gists{/gist_id}","starred_url":"https://api.github.com/users/JGCRI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JGCRI/subscriptions","organizations_url":"https://api.github.com/users/JGCRI/orgs","repos_url":"https://api.github.com/users/JGCRI/repos","events_url":"https://api.github.com/users/JGCRI/events{/privacy}","received_events_url":"https://api.github.com/users/JGCRI/received_events","type":"Organization","site_admin":false},"repo":{"id":88797535,"node_id":"MDEwOlJlcG9zaXRvcnk4ODc5NzUzNQ==","name":"xanthos","full_name":"JGCRI/xanthos","private":false,"owner":{"login":"JGCRI","id":8431983,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MzE5ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/8431983?v=4","gravatar_id":"","url":"https://api.github.com/users/JGCRI","html_url":"https://github.com/JGCRI","followers_url":"https://api.github.com/users/JGCRI/followers","following_url":"https://api.github.com/users/JGCRI/following{/other_user}","gists_url":"https://api.github.com/users/JGCRI/gists{/gist_id}","starred_url":"https://api.github.com/users/JGCRI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JGCRI/subscriptions","organizations_url":"https://api.github.com/users/JGCRI/orgs","repos_url":"https://api.github.com/users/JGCRI/repos","events_url":"https://api.github.com/users/JGCRI/events{/privacy}","received_events_url":"https://api.github.com/users/JGCRI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JGCRI/xanthos","description":"An extensible global hydrologic model","fork":false,"url":"https://api.github.com/repos/JGCRI/xanthos","forks_url":"https://api.github.com/repos/JGCRI/xanthos/forks","keys_url":"https://api.github.com/repos/JGCRI/xanthos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JGCRI/xanthos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JGCRI/xanthos/teams","hooks_url":"https://api.github.com/repos/JGCRI/xanthos/hooks","issue_events_url":"https://api.github.com/repos/JGCRI/xanthos/issues/events{/number}","events_url":"https://api.github.com/repos/JGCRI/xanthos/events","assignees_url":"https://api.github.com/repos/JGCRI/xanthos/assignees{/user}","branches_url":"https://api.github.com/repos/JGCRI/xanthos/branches{/branch}","tags_url":"https://api.github.com/repos/JGCRI/xanthos/tags","blobs_url":"https://api.github.com/repos/JGCRI/xanthos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JGCRI/xanthos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JGCRI/xanthos/git/refs{/sha}","trees_url":"https://api.github.com/repos/JGCRI/xanthos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JGCRI/xanthos/statuses/{sha}","languages_url":"https://api.github.com/repos/JGCRI/xanthos/languages","stargazers_url":"https://api.github.com/repos/JGCRI/xanthos/stargazers","contributors_url":"https://api.github.com/repos/JGCRI/xanthos/contributors","subscribers_url":"https://api.github.com/repos/JGCRI/xanthos/subscribers","subscription_url":"https://api.github.com/repos/JGCRI/xanthos/subscription","commits_url":"https://api.github.com/repos/JGCRI/xanthos/commits{/sha}","git_commits_url":"https://api.github.com/repos/JGCRI/xanthos/git/commits{/sha}","comments_url":"https://api.github.com/repos/JGCRI/xanthos/comments{/number}","issue_comment_url":"https://api.github.com/repos/JGCRI/xanthos/issues/comments{/number}","contents_url":"https://api.github.com/repos/JGCRI/xanthos/contents/{+path}","compare_url":"https://api.github.com/repos/JGCRI/xanthos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JGCRI/xanthos/merges","archive_url":"https://api.github.com/repos/JGCRI/xanthos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JGCRI/xanthos/downloads","issues_url":"https://api.github.com/repos/JGCRI/xanthos/issues{/number}","pulls_url":"https://api.github.com/repos/JGCRI/xanthos/pulls{/number}","milestones_url":"https://api.github.com/repos/JGCRI/xanthos/milestones{/number}","notifications_url":"https://api.github.com/repos/JGCRI/xanthos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JGCRI/xanthos/labels{/name}","releases_url":"https://api.github.com/repos/JGCRI/xanthos/releases{/id}","deployments_url":"https://api.github.com/repos/JGCRI/xanthos/deployments","created_at":"2017-04-19T22:47:48Z","updated_at":"2018-11-29T18:12:51Z","pushed_at":"2018-12-04T18:17:52Z","git_url":"git://github.com/JGCRI/xanthos.git","ssh_url":"git@github.com:JGCRI/xanthos.git","clone_url":"https://github.com/JGCRI/xanthos.git","svn_url":"https://github.com/JGCRI/xanthos","homepage":"","size":261001,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":7,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JGCRI/xanthos/pulls/31"},"html":{"href":"https://github.com/JGCRI/xanthos/pull/31"},"issue":{"href":"https://api.github.com/repos/JGCRI/xanthos/issues/31"},"comments":{"href":"https://api.github.com/repos/JGCRI/xanthos/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/JGCRI/xanthos/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/JGCRI/xanthos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JGCRI/xanthos/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/JGCRI/xanthos/statuses/63af4bd96802111a06fe97f453a643045407e6d0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"crvernon"}}