{"action":"created","comment":{"url":"https://api.github.com/repos/Valloric/ycmd/pulls/comments/173628035","pull_request_review_id":102856676,"id":173628035,"diff_hunk":"@@ -233,5 +234,5 @@ def _RandomName():\n \n \n def _GlobalYcmExtraConfFileLocation():\n-  return os.path.expanduser(\n-    user_options_store.Value( 'global_ycm_extra_conf' ) )\n+  return os.path.expandvars( os.path.expanduser(","path":"ycmd/extra_conf_store.py","position":28,"original_position":28,"commit_id":"1189260f3219354e0fc652a8e68f7472bc2f4e02","original_commit_id":"1189260f3219354e0fc652a8e68f7472bc2f4e02","user":{"login":"puremourning","id":10584846,"avatar_url":"https://avatars0.githubusercontent.com/u/10584846?v=4","gravatar_id":"","url":"https://api.github.com/users/puremourning","html_url":"https://github.com/puremourning","followers_url":"https://api.github.com/users/puremourning/followers","following_url":"https://api.github.com/users/puremourning/following{/other_user}","gists_url":"https://api.github.com/users/puremourning/gists{/gist_id}","starred_url":"https://api.github.com/users/puremourning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puremourning/subscriptions","organizations_url":"https://api.github.com/users/puremourning/orgs","repos_url":"https://api.github.com/users/puremourning/repos","events_url":"https://api.github.com/users/puremourning/events{/privacy}","received_events_url":"https://api.github.com/users/puremourning/received_events","type":"User","site_admin":false},"body":"Maybe we should use vim's `expand()` function instead of Python's ?\r\n\r\nI wonder if that would be more obvious to users? Just a thought.","created_at":"2018-03-10T17:14:11Z","updated_at":"2018-03-10T17:14:12Z","html_url":"https://github.com/Valloric/ycmd/pull/951#discussion_r173628035","pull_request_url":"https://api.github.com/repos/Valloric/ycmd/pulls/951","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Valloric/ycmd/pulls/comments/173628035"},"html":{"href":"https://github.com/Valloric/ycmd/pull/951#discussion_r173628035"},"pull_request":{"href":"https://api.github.com/repos/Valloric/ycmd/pulls/951"}}},"pull_request":{"url":"https://api.github.com/repos/Valloric/ycmd/pulls/951","id":174179455,"html_url":"https://github.com/Valloric/ycmd/pull/951","diff_url":"https://github.com/Valloric/ycmd/pull/951.diff","patch_url":"https://github.com/Valloric/ycmd/pull/951.patch","issue_url":"https://api.github.com/repos/Valloric/ycmd/issues/951","number":951,"state":"open","locked":false,"title":"[READY] Expand environment variables in extra conf options","user":{"login":"micbou","id":10026824,"avatar_url":"https://avatars2.githubusercontent.com/u/10026824?v=4","gravatar_id":"","url":"https://api.github.com/users/micbou","html_url":"https://github.com/micbou","followers_url":"https://api.github.com/users/micbou/followers","following_url":"https://api.github.com/users/micbou/following{/other_user}","gists_url":"https://api.github.com/users/micbou/gists{/gist_id}","starred_url":"https://api.github.com/users/micbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micbou/subscriptions","organizations_url":"https://api.github.com/users/micbou/orgs","repos_url":"https://api.github.com/users/micbou/repos","events_url":"https://api.github.com/users/micbou/events{/privacy}","received_events_url":"https://api.github.com/users/micbou/received_events","type":"User","site_admin":false},"body":"This PR adds support for environment variables in the `extra_conf_globlist` and `global_ycm_extra_conf` options.\r\n\r\nFixes https://github.com/Valloric/YouCompleteMe/issues/2944.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/valloric/ycmd/951)\r\n<!-- Reviewable:end -->\r\n","created_at":"2018-03-10T17:11:40Z","updated_at":"2018-03-10T17:14:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"486f62ee40fb60832509be67729dd5380c170618","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Valloric/ycmd/pulls/951/commits","review_comments_url":"https://api.github.com/repos/Valloric/ycmd/pulls/951/comments","review_comment_url":"https://api.github.com/repos/Valloric/ycmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Valloric/ycmd/issues/951/comments","statuses_url":"https://api.github.com/repos/Valloric/ycmd/statuses/1189260f3219354e0fc652a8e68f7472bc2f4e02","head":{"label":"micbou:extra-conf-expand-vars","ref":"extra-conf-expand-vars","sha":"1189260f3219354e0fc652a8e68f7472bc2f4e02","user":{"login":"micbou","id":10026824,"avatar_url":"https://avatars2.githubusercontent.com/u/10026824?v=4","gravatar_id":"","url":"https://api.github.com/users/micbou","html_url":"https://github.com/micbou","followers_url":"https://api.github.com/users/micbou/followers","following_url":"https://api.github.com/users/micbou/following{/other_user}","gists_url":"https://api.github.com/users/micbou/gists{/gist_id}","starred_url":"https://api.github.com/users/micbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micbou/subscriptions","organizations_url":"https://api.github.com/users/micbou/orgs","repos_url":"https://api.github.com/users/micbou/repos","events_url":"https://api.github.com/users/micbou/events{/privacy}","received_events_url":"https://api.github.com/users/micbou/received_events","type":"User","site_admin":false},"repo":{"id":31660902,"name":"ycmd","full_name":"micbou/ycmd","owner":{"login":"micbou","id":10026824,"avatar_url":"https://avatars2.githubusercontent.com/u/10026824?v=4","gravatar_id":"","url":"https://api.github.com/users/micbou","html_url":"https://github.com/micbou","followers_url":"https://api.github.com/users/micbou/followers","following_url":"https://api.github.com/users/micbou/following{/other_user}","gists_url":"https://api.github.com/users/micbou/gists{/gist_id}","starred_url":"https://api.github.com/users/micbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micbou/subscriptions","organizations_url":"https://api.github.com/users/micbou/orgs","repos_url":"https://api.github.com/users/micbou/repos","events_url":"https://api.github.com/users/micbou/events{/privacy}","received_events_url":"https://api.github.com/users/micbou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/micbou/ycmd","description":"A code-completion & code-comprehension server","fork":true,"url":"https://api.github.com/repos/micbou/ycmd","forks_url":"https://api.github.com/repos/micbou/ycmd/forks","keys_url":"https://api.github.com/repos/micbou/ycmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/micbou/ycmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/micbou/ycmd/teams","hooks_url":"https://api.github.com/repos/micbou/ycmd/hooks","issue_events_url":"https://api.github.com/repos/micbou/ycmd/issues/events{/number}","events_url":"https://api.github.com/repos/micbou/ycmd/events","assignees_url":"https://api.github.com/repos/micbou/ycmd/assignees{/user}","branches_url":"https://api.github.com/repos/micbou/ycmd/branches{/branch}","tags_url":"https://api.github.com/repos/micbou/ycmd/tags","blobs_url":"https://api.github.com/repos/micbou/ycmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/micbou/ycmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/micbou/ycmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/micbou/ycmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/micbou/ycmd/statuses/{sha}","languages_url":"https://api.github.com/repos/micbou/ycmd/languages","stargazers_url":"https://api.github.com/repos/micbou/ycmd/stargazers","contributors_url":"https://api.github.com/repos/micbou/ycmd/contributors","subscribers_url":"https://api.github.com/repos/micbou/ycmd/subscribers","subscription_url":"https://api.github.com/repos/micbou/ycmd/subscription","commits_url":"https://api.github.com/repos/micbou/ycmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/micbou/ycmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/micbou/ycmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/micbou/ycmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/micbou/ycmd/contents/{+path}","compare_url":"https://api.github.com/repos/micbou/ycmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/micbou/ycmd/merges","archive_url":"https://api.github.com/repos/micbou/ycmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/micbou/ycmd/downloads","issues_url":"https://api.github.com/repos/micbou/ycmd/issues{/number}","pulls_url":"https://api.github.com/repos/micbou/ycmd/pulls{/number}","milestones_url":"https://api.github.com/repos/micbou/ycmd/milestones{/number}","notifications_url":"https://api.github.com/repos/micbou/ycmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/micbou/ycmd/labels{/name}","releases_url":"https://api.github.com/repos/micbou/ycmd/releases{/id}","deployments_url":"https://api.github.com/repos/micbou/ycmd/deployments","created_at":"2015-03-04T14:26:37Z","updated_at":"2016-11-12T20:31:42Z","pushed_at":"2018-03-10T17:05:48Z","git_url":"git://github.com/micbou/ycmd.git","ssh_url":"git@github.com:micbou/ycmd.git","clone_url":"https://github.com/micbou/ycmd.git","svn_url":"https://github.com/micbou/ycmd","homepage":null,"size":19001,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Valloric:master","ref":"master","sha":"b8ccbbfa9c68298692c05e73c2e44ca8e1ddc5d5","user":{"login":"Valloric","id":919444,"avatar_url":"https://avatars0.githubusercontent.com/u/919444?v=4","gravatar_id":"","url":"https://api.github.com/users/Valloric","html_url":"https://github.com/Valloric","followers_url":"https://api.github.com/users/Valloric/followers","following_url":"https://api.github.com/users/Valloric/following{/other_user}","gists_url":"https://api.github.com/users/Valloric/gists{/gist_id}","starred_url":"https://api.github.com/users/Valloric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Valloric/subscriptions","organizations_url":"https://api.github.com/users/Valloric/orgs","repos_url":"https://api.github.com/users/Valloric/repos","events_url":"https://api.github.com/users/Valloric/events{/privacy}","received_events_url":"https://api.github.com/users/Valloric/received_events","type":"User","site_admin":false},"repo":{"id":19832415,"name":"ycmd","full_name":"Valloric/ycmd","owner":{"login":"Valloric","id":919444,"avatar_url":"https://avatars0.githubusercontent.com/u/919444?v=4","gravatar_id":"","url":"https://api.github.com/users/Valloric","html_url":"https://github.com/Valloric","followers_url":"https://api.github.com/users/Valloric/followers","following_url":"https://api.github.com/users/Valloric/following{/other_user}","gists_url":"https://api.github.com/users/Valloric/gists{/gist_id}","starred_url":"https://api.github.com/users/Valloric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Valloric/subscriptions","organizations_url":"https://api.github.com/users/Valloric/orgs","repos_url":"https://api.github.com/users/Valloric/repos","events_url":"https://api.github.com/users/Valloric/events{/privacy}","received_events_url":"https://api.github.com/users/Valloric/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Valloric/ycmd","description":"A code-completion & code-comprehension server","fork":false,"url":"https://api.github.com/repos/Valloric/ycmd","forks_url":"https://api.github.com/repos/Valloric/ycmd/forks","keys_url":"https://api.github.com/repos/Valloric/ycmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Valloric/ycmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Valloric/ycmd/teams","hooks_url":"https://api.github.com/repos/Valloric/ycmd/hooks","issue_events_url":"https://api.github.com/repos/Valloric/ycmd/issues/events{/number}","events_url":"https://api.github.com/repos/Valloric/ycmd/events","assignees_url":"https://api.github.com/repos/Valloric/ycmd/assignees{/user}","branches_url":"https://api.github.com/repos/Valloric/ycmd/branches{/branch}","tags_url":"https://api.github.com/repos/Valloric/ycmd/tags","blobs_url":"https://api.github.com/repos/Valloric/ycmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Valloric/ycmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Valloric/ycmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/Valloric/ycmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Valloric/ycmd/statuses/{sha}","languages_url":"https://api.github.com/repos/Valloric/ycmd/languages","stargazers_url":"https://api.github.com/repos/Valloric/ycmd/stargazers","contributors_url":"https://api.github.com/repos/Valloric/ycmd/contributors","subscribers_url":"https://api.github.com/repos/Valloric/ycmd/subscribers","subscription_url":"https://api.github.com/repos/Valloric/ycmd/subscription","commits_url":"https://api.github.com/repos/Valloric/ycmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/Valloric/ycmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/Valloric/ycmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/Valloric/ycmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/Valloric/ycmd/contents/{+path}","compare_url":"https://api.github.com/repos/Valloric/ycmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Valloric/ycmd/merges","archive_url":"https://api.github.com/repos/Valloric/ycmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Valloric/ycmd/downloads","issues_url":"https://api.github.com/repos/Valloric/ycmd/issues{/number}","pulls_url":"https://api.github.com/repos/Valloric/ycmd/pulls{/number}","milestones_url":"https://api.github.com/repos/Valloric/ycmd/milestones{/number}","notifications_url":"https://api.github.com/repos/Valloric/ycmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Valloric/ycmd/labels{/name}","releases_url":"https://api.github.com/repos/Valloric/ycmd/releases{/id}","deployments_url":"https://api.github.com/repos/Valloric/ycmd/deployments","created_at":"2014-05-15T19:30:17Z","updated_at":"2018-03-10T06:24:38Z","pushed_at":"2018-03-10T17:11:45Z","git_url":"git://github.com/Valloric/ycmd.git","ssh_url":"git@github.com:Valloric/ycmd.git","clone_url":"https://github.com/Valloric/ycmd.git","svn_url":"https://github.com/Valloric/ycmd","homepage":"https://valloric.github.io/ycmd/","size":19830,"stargazers_count":1064,"watchers_count":1064,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":578,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":578,"open_issues":33,"watchers":1064,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Valloric/ycmd/pulls/951"},"html":{"href":"https://github.com/Valloric/ycmd/pull/951"},"issue":{"href":"https://api.github.com/repos/Valloric/ycmd/issues/951"},"comments":{"href":"https://api.github.com/repos/Valloric/ycmd/issues/951/comments"},"review_comments":{"href":"https://api.github.com/repos/Valloric/ycmd/pulls/951/comments"},"review_comment":{"href":"https://api.github.com/repos/Valloric/ycmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Valloric/ycmd/pulls/951/commits"},"statuses":{"href":"https://api.github.com/repos/Valloric/ycmd/statuses/1189260f3219354e0fc652a8e68f7472bc2f4e02"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"puremourning"}}