{"action":"created","comment":{"url":"https://api.github.com/repos/adsabs/resolver_service/pulls/comments/168319514","pull_request_review_id":96663327,"id":168319514,"diff_hunk":"@@ -327,20 +609,132 @@ def test_link_data(self):\n         )\n \n \n-    # return 404 for not finding any records\n     def test_link_data_error_bibcode(self):\n+        \"\"\"\n+        return 404 for not finding any records\n+        :return:\n+        \"\"\"\n         results = get_records(bibcode='errorbibcode', link_type='DATA')\n         response = LinkRequest(bibcode='errorbibcode', link_type='DATA').request_link_type_data(results)","path":"resolversrv/tests/unittests/test_db_query.py","position":643,"original_position":643,"commit_id":"6c869db9bee7c16d84e82fd487928030b9017362","original_commit_id":"6c869db9bee7c16d84e82fd487928030b9017362","user":{"login":"romanchyla","id":411794,"avatar_url":"https://avatars2.githubusercontent.com/u/411794?v=4","gravatar_id":"","url":"https://api.github.com/users/romanchyla","html_url":"https://github.com/romanchyla","followers_url":"https://api.github.com/users/romanchyla/followers","following_url":"https://api.github.com/users/romanchyla/following{/other_user}","gists_url":"https://api.github.com/users/romanchyla/gists{/gist_id}","starred_url":"https://api.github.com/users/romanchyla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romanchyla/subscriptions","organizations_url":"https://api.github.com/users/romanchyla/orgs","repos_url":"https://api.github.com/users/romanchyla/repos","events_url":"https://api.github.com/users/romanchyla/events{/privacy}","received_events_url":"https://api.github.com/users/romanchyla/received_events","type":"User","site_admin":false},"body":"minor point, but got me wonder -- you are creating an instance, the instance seems to be defined by the initialization arguments (bibcode, link_type)\r\n\r\n1) can the api be simpler if you rename `request_link_type_data` to `get_response` ?\r\n\r\nif 1) doesn't make sense, is the 'link_type` necessary? could you just do:\r\n\r\n2) `LinkRequest(bibcode='errorbibcode').request_type(type='DATA', results)` ?\r\n\r\ni guess my main point is: if link_type is 'data', there doesn't need to be a different method for every type","created_at":"2018-02-14T21:45:11Z","updated_at":"2018-02-14T22:00:54Z","html_url":"https://github.com/adsabs/resolver_service/pull/5#discussion_r168319514","pull_request_url":"https://api.github.com/repos/adsabs/resolver_service/pulls/5","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/adsabs/resolver_service/pulls/comments/168319514"},"html":{"href":"https://github.com/adsabs/resolver_service/pull/5#discussion_r168319514"},"pull_request":{"href":"https://api.github.com/repos/adsabs/resolver_service/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/adsabs/resolver_service/pulls/5","id":163926596,"html_url":"https://github.com/adsabs/resolver_service/pull/5","diff_url":"https://github.com/adsabs/resolver_service/pull/5.diff","patch_url":"https://github.com/adsabs/resolver_service/pull/5.patch","issue_url":"https://api.github.com/repos/adsabs/resolver_service/issues/5","number":5,"state":"open","locked":false,"title":"added endpoint populate to accept data and write to db","user":{"login":"golnazads","id":28757512,"avatar_url":"https://avatars3.githubusercontent.com/u/28757512?v=4","gravatar_id":"","url":"https://api.github.com/users/golnazads","html_url":"https://github.com/golnazads","followers_url":"https://api.github.com/users/golnazads/followers","following_url":"https://api.github.com/users/golnazads/following{/other_user}","gists_url":"https://api.github.com/users/golnazads/gists{/gist_id}","starred_url":"https://api.github.com/users/golnazads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golnazads/subscriptions","organizations_url":"https://api.github.com/users/golnazads/orgs","repos_url":"https://api.github.com/users/golnazads/repos","events_url":"https://api.github.com/users/golnazads/events{/privacy}","received_events_url":"https://api.github.com/users/golnazads/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-01-19T09:53:08Z","updated_at":"2018-02-14T22:00:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd73602fafade59c38a24ac13e615436798fe258","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/adsabs/resolver_service/pulls/5/commits","review_comments_url":"https://api.github.com/repos/adsabs/resolver_service/pulls/5/comments","review_comment_url":"https://api.github.com/repos/adsabs/resolver_service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adsabs/resolver_service/issues/5/comments","statuses_url":"https://api.github.com/repos/adsabs/resolver_service/statuses/6c869db9bee7c16d84e82fd487928030b9017362","head":{"label":"golnazads:master","ref":"master","sha":"6c869db9bee7c16d84e82fd487928030b9017362","user":{"login":"golnazads","id":28757512,"avatar_url":"https://avatars3.githubusercontent.com/u/28757512?v=4","gravatar_id":"","url":"https://api.github.com/users/golnazads","html_url":"https://github.com/golnazads","followers_url":"https://api.github.com/users/golnazads/followers","following_url":"https://api.github.com/users/golnazads/following{/other_user}","gists_url":"https://api.github.com/users/golnazads/gists{/gist_id}","starred_url":"https://api.github.com/users/golnazads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golnazads/subscriptions","organizations_url":"https://api.github.com/users/golnazads/orgs","repos_url":"https://api.github.com/users/golnazads/repos","events_url":"https://api.github.com/users/golnazads/events{/privacy}","received_events_url":"https://api.github.com/users/golnazads/received_events","type":"User","site_admin":false},"repo":{"id":117722433,"name":"resolver_service","full_name":"golnazads/resolver_service","owner":{"login":"golnazads","id":28757512,"avatar_url":"https://avatars3.githubusercontent.com/u/28757512?v=4","gravatar_id":"","url":"https://api.github.com/users/golnazads","html_url":"https://github.com/golnazads","followers_url":"https://api.github.com/users/golnazads/followers","following_url":"https://api.github.com/users/golnazads/following{/other_user}","gists_url":"https://api.github.com/users/golnazads/gists{/gist_id}","starred_url":"https://api.github.com/users/golnazads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golnazads/subscriptions","organizations_url":"https://api.github.com/users/golnazads/orgs","repos_url":"https://api.github.com/users/golnazads/repos","events_url":"https://api.github.com/users/golnazads/events{/privacy}","received_events_url":"https://api.github.com/users/golnazads/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/golnazads/resolver_service","description":"Linkout service to send users to external resources such as publisher's full text, data links, etc.","fork":true,"url":"https://api.github.com/repos/golnazads/resolver_service","forks_url":"https://api.github.com/repos/golnazads/resolver_service/forks","keys_url":"https://api.github.com/repos/golnazads/resolver_service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/golnazads/resolver_service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/golnazads/resolver_service/teams","hooks_url":"https://api.github.com/repos/golnazads/resolver_service/hooks","issue_events_url":"https://api.github.com/repos/golnazads/resolver_service/issues/events{/number}","events_url":"https://api.github.com/repos/golnazads/resolver_service/events","assignees_url":"https://api.github.com/repos/golnazads/resolver_service/assignees{/user}","branches_url":"https://api.github.com/repos/golnazads/resolver_service/branches{/branch}","tags_url":"https://api.github.com/repos/golnazads/resolver_service/tags","blobs_url":"https://api.github.com/repos/golnazads/resolver_service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/golnazads/resolver_service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/golnazads/resolver_service/git/refs{/sha}","trees_url":"https://api.github.com/repos/golnazads/resolver_service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/golnazads/resolver_service/statuses/{sha}","languages_url":"https://api.github.com/repos/golnazads/resolver_service/languages","stargazers_url":"https://api.github.com/repos/golnazads/resolver_service/stargazers","contributors_url":"https://api.github.com/repos/golnazads/resolver_service/contributors","subscribers_url":"https://api.github.com/repos/golnazads/resolver_service/subscribers","subscription_url":"https://api.github.com/repos/golnazads/resolver_service/subscription","commits_url":"https://api.github.com/repos/golnazads/resolver_service/commits{/sha}","git_commits_url":"https://api.github.com/repos/golnazads/resolver_service/git/commits{/sha}","comments_url":"https://api.github.com/repos/golnazads/resolver_service/comments{/number}","issue_comment_url":"https://api.github.com/repos/golnazads/resolver_service/issues/comments{/number}","contents_url":"https://api.github.com/repos/golnazads/resolver_service/contents/{+path}","compare_url":"https://api.github.com/repos/golnazads/resolver_service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/golnazads/resolver_service/merges","archive_url":"https://api.github.com/repos/golnazads/resolver_service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/golnazads/resolver_service/downloads","issues_url":"https://api.github.com/repos/golnazads/resolver_service/issues{/number}","pulls_url":"https://api.github.com/repos/golnazads/resolver_service/pulls{/number}","milestones_url":"https://api.github.com/repos/golnazads/resolver_service/milestones{/number}","notifications_url":"https://api.github.com/repos/golnazads/resolver_service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/golnazads/resolver_service/labels{/name}","releases_url":"https://api.github.com/repos/golnazads/resolver_service/releases{/id}","deployments_url":"https://api.github.com/repos/golnazads/resolver_service/deployments","created_at":"2018-01-16T18:17:01Z","updated_at":"2018-01-21T16:37:42Z","pushed_at":"2018-02-14T00:08:12Z","git_url":"git://github.com/golnazads/resolver_service.git","ssh_url":"git@github.com:golnazads/resolver_service.git","clone_url":"https://github.com/golnazads/resolver_service.git","svn_url":"https://github.com/golnazads/resolver_service","homepage":"","size":82,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"adsabs:master","ref":"master","sha":"fdeb3911bc6691534eecc4424bc49d74befb1d6c","user":{"login":"adsabs","id":1004839,"avatar_url":"https://avatars1.githubusercontent.com/u/1004839?v=4","gravatar_id":"","url":"https://api.github.com/users/adsabs","html_url":"https://github.com/adsabs","followers_url":"https://api.github.com/users/adsabs/followers","following_url":"https://api.github.com/users/adsabs/following{/other_user}","gists_url":"https://api.github.com/users/adsabs/gists{/gist_id}","starred_url":"https://api.github.com/users/adsabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adsabs/subscriptions","organizations_url":"https://api.github.com/users/adsabs/orgs","repos_url":"https://api.github.com/users/adsabs/repos","events_url":"https://api.github.com/users/adsabs/events{/privacy}","received_events_url":"https://api.github.com/users/adsabs/received_events","type":"Organization","site_admin":false},"repo":{"id":102512848,"name":"resolver_service","full_name":"adsabs/resolver_service","owner":{"login":"adsabs","id":1004839,"avatar_url":"https://avatars1.githubusercontent.com/u/1004839?v=4","gravatar_id":"","url":"https://api.github.com/users/adsabs","html_url":"https://github.com/adsabs","followers_url":"https://api.github.com/users/adsabs/followers","following_url":"https://api.github.com/users/adsabs/following{/other_user}","gists_url":"https://api.github.com/users/adsabs/gists{/gist_id}","starred_url":"https://api.github.com/users/adsabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adsabs/subscriptions","organizations_url":"https://api.github.com/users/adsabs/orgs","repos_url":"https://api.github.com/users/adsabs/repos","events_url":"https://api.github.com/users/adsabs/events{/privacy}","received_events_url":"https://api.github.com/users/adsabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adsabs/resolver_service","description":"Linkout service to send users to external resources such as publisher's full text, data links, etc.","fork":false,"url":"https://api.github.com/repos/adsabs/resolver_service","forks_url":"https://api.github.com/repos/adsabs/resolver_service/forks","keys_url":"https://api.github.com/repos/adsabs/resolver_service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adsabs/resolver_service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adsabs/resolver_service/teams","hooks_url":"https://api.github.com/repos/adsabs/resolver_service/hooks","issue_events_url":"https://api.github.com/repos/adsabs/resolver_service/issues/events{/number}","events_url":"https://api.github.com/repos/adsabs/resolver_service/events","assignees_url":"https://api.github.com/repos/adsabs/resolver_service/assignees{/user}","branches_url":"https://api.github.com/repos/adsabs/resolver_service/branches{/branch}","tags_url":"https://api.github.com/repos/adsabs/resolver_service/tags","blobs_url":"https://api.github.com/repos/adsabs/resolver_service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adsabs/resolver_service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adsabs/resolver_service/git/refs{/sha}","trees_url":"https://api.github.com/repos/adsabs/resolver_service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adsabs/resolver_service/statuses/{sha}","languages_url":"https://api.github.com/repos/adsabs/resolver_service/languages","stargazers_url":"https://api.github.com/repos/adsabs/resolver_service/stargazers","contributors_url":"https://api.github.com/repos/adsabs/resolver_service/contributors","subscribers_url":"https://api.github.com/repos/adsabs/resolver_service/subscribers","subscription_url":"https://api.github.com/repos/adsabs/resolver_service/subscription","commits_url":"https://api.github.com/repos/adsabs/resolver_service/commits{/sha}","git_commits_url":"https://api.github.com/repos/adsabs/resolver_service/git/commits{/sha}","comments_url":"https://api.github.com/repos/adsabs/resolver_service/comments{/number}","issue_comment_url":"https://api.github.com/repos/adsabs/resolver_service/issues/comments{/number}","contents_url":"https://api.github.com/repos/adsabs/resolver_service/contents/{+path}","compare_url":"https://api.github.com/repos/adsabs/resolver_service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adsabs/resolver_service/merges","archive_url":"https://api.github.com/repos/adsabs/resolver_service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adsabs/resolver_service/downloads","issues_url":"https://api.github.com/repos/adsabs/resolver_service/issues{/number}","pulls_url":"https://api.github.com/repos/adsabs/resolver_service/pulls{/number}","milestones_url":"https://api.github.com/repos/adsabs/resolver_service/milestones{/number}","notifications_url":"https://api.github.com/repos/adsabs/resolver_service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adsabs/resolver_service/labels{/name}","releases_url":"https://api.github.com/repos/adsabs/resolver_service/releases{/id}","deployments_url":"https://api.github.com/repos/adsabs/resolver_service/deployments","created_at":"2017-09-05T17:50:14Z","updated_at":"2018-01-21T16:37:54Z","pushed_at":"2018-02-14T00:08:12Z","git_url":"git://github.com/adsabs/resolver_service.git","ssh_url":"git@github.com:adsabs/resolver_service.git","clone_url":"https://github.com/adsabs/resolver_service.git","svn_url":"https://github.com/adsabs/resolver_service","homepage":"","size":48,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adsabs/resolver_service/pulls/5"},"html":{"href":"https://github.com/adsabs/resolver_service/pull/5"},"issue":{"href":"https://api.github.com/repos/adsabs/resolver_service/issues/5"},"comments":{"href":"https://api.github.com/repos/adsabs/resolver_service/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/adsabs/resolver_service/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/adsabs/resolver_service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adsabs/resolver_service/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/adsabs/resolver_service/statuses/6c869db9bee7c16d84e82fd487928030b9017362"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"romanchyla"}}