{"action":"created","issue":{"url":"https://api.github.com/repos/openhab/openhab2-addons/issues/3720","repository_url":"https://api.github.com/repos/openhab/openhab2-addons","labels_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/3720/labels{/name}","comments_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/3720/comments","events_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/3720/events","html_url":"https://github.com/openhab/openhab2-addons/pull/3720","id":339580154,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMTk4ODA4","number":3720,"title":"[dsmr] Initial contribution, updated version","user":{"login":"Hilbrand","id":1272873,"node_id":"MDQ6VXNlcjEyNzI4NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1272873?v=4","gravatar_id":"","url":"https://api.github.com/users/Hilbrand","html_url":"https://github.com/Hilbrand","followers_url":"https://api.github.com/users/Hilbrand/followers","following_url":"https://api.github.com/users/Hilbrand/following{/other_user}","gists_url":"https://api.github.com/users/Hilbrand/gists{/gist_id}","starred_url":"https://api.github.com/users/Hilbrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hilbrand/subscriptions","organizations_url":"https://api.github.com/users/Hilbrand/orgs","repos_url":"https://api.github.com/users/Hilbrand/repos","events_url":"https://api.github.com/users/Hilbrand/events{/privacy}","received_events_url":"https://api.github.com/users/Hilbrand/received_events","type":"User","site_admin":false},"labels":[{"id":159935827,"node_id":"MDU6TGFiZWwxNTk5MzU4Mjc=","url":"https://api.github.com/repos/openhab/openhab2-addons/labels/newbinding","name":"newbinding","color":"5319e7","default":false}],"state":"closed","locked":false,"assignee":{"login":"kaikreuzer","id":3244965,"node_id":"MDQ6VXNlcjMyNDQ5NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/3244965?v=4","gravatar_id":"","url":"https://api.github.com/users/kaikreuzer","html_url":"https://github.com/kaikreuzer","followers_url":"https://api.github.com/users/kaikreuzer/followers","following_url":"https://api.github.com/users/kaikreuzer/following{/other_user}","gists_url":"https://api.github.com/users/kaikreuzer/gists{/gist_id}","starred_url":"https://api.github.com/users/kaikreuzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaikreuzer/subscriptions","organizations_url":"https://api.github.com/users/kaikreuzer/orgs","repos_url":"https://api.github.com/users/kaikreuzer/repos","events_url":"https://api.github.com/users/kaikreuzer/events{/privacy}","received_events_url":"https://api.github.com/users/kaikreuzer/received_events","type":"User","site_admin":false},"assignees":[{"login":"kaikreuzer","id":3244965,"node_id":"MDQ6VXNlcjMyNDQ5NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/3244965?v=4","gravatar_id":"","url":"https://api.github.com/users/kaikreuzer","html_url":"https://github.com/kaikreuzer","followers_url":"https://api.github.com/users/kaikreuzer/followers","following_url":"https://api.github.com/users/kaikreuzer/following{/other_user}","gists_url":"https://api.github.com/users/kaikreuzer/gists{/gist_id}","starred_url":"https://api.github.com/users/kaikreuzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaikreuzer/subscriptions","organizations_url":"https://api.github.com/users/kaikreuzer/orgs","repos_url":"https://api.github.com/users/kaikreuzer/repos","events_url":"https://api.github.com/users/kaikreuzer/events{/privacy}","received_events_url":"https://api.github.com/users/kaikreuzer/received_events","type":"User","site_admin":false}],"milestone":null,"comments":15,"created_at":"2018-07-09T19:38:01Z","updated_at":"2018-08-30T18:59:49Z","closed_at":"2018-08-28T14:46:36Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/3720","html_url":"https://github.com/openhab/openhab2-addons/pull/3720","diff_url":"https://github.com/openhab/openhab2-addons/pull/3720.diff","patch_url":"https://github.com/openhab/openhab2-addons/pull/3720.patch"},"body":"This is the updated version of the new DSMR binding for openHAB 2. It supersedes PR #2289 and closes issue #1608. In cooperation with @mvolaart I proceeded working on this binding to get a mergeable version and create a new PR that I can easily update.\r\n\r\nFor more details and configuration see the README.md file as part of this PR.\r\n\r\nA version is available in the [Eclipse Market place](https://marketplace.eclipse.org/content/dutch-smart-meter-reading-dsmr-binding/). You should be able to install it via PaperUI (or disable/enable marketplace to refresh the binding list if you don't see the binding). \r\nThe jar file (same as in the Eclipse Market place) is available at: https://github.com/Hilbrand/openhab2-addons/releases/download/DSMR/org.openhab.binding.dsmr-2.4.0-SNAPSHOT.jar\r\n\r\n### Updating from an older version of this binding\r\nThe things and bridges have remained the same, but it now has some refresh configuration options. If you have an earlier version of this binding running, it might work by replacing the binding jar. However it now uses QuantityType and thus is very likely not compatible with openHAB versions below 2.4.0-SNAPSHOT. And even if you are already running that version due to this changes you might need to re-add the things if you added them via PaperUI.\r\n\r\n### Some background\r\nPR #2289 has been around for over a year. During that period, with some intervals, the code was reviewed and updated. The last half year nothing happened. Because I wanted this binding to work for me, I started to make changes to the code for myself. These changes became larger as I tried to get it to work for me to the point that they were nearing a stable code base. At that point the code had diverted significantly. To avoid others, especially @mvolaart, to do double work on the code I addressed this issue in the PR. Because of limited time @mvolaart gave me the ok to continue working on this binding and have it merged. \r\n\r\n### For reviewers\r\nThe original pr already has had quite some review comments. I believe all the issues mentioned in the pr that were open are addressed. But there are also some significant changes. This means a large part of the code needs to be reviewed again. In general all the xml files have mostly remained the same (except for the change to quantity type). And the parsing of the messages also remained the same. A good start might be to look at the last commit in this PR (this is the commit follows the commits from the original PR).  That commit also contains a list of functional and technical changes. Since I can't attach reviewers I'll tag people who have reviewed before or wanted to be informed: @martinvw @wborn @gedejong or feel free to add additional reviews. The more, the better as it can speedup merging this pr. I don't doubt there are some comments to make :smile:\r\n\r\n### Notes on not yet added serial transport/serial-over-tcp\r\nOne feature was to add serial-over-tcp. I wanted to add this, but it turns out I found at least 3 ways serial-over-tcp can be done. The first is serial-over-tcp (RFC2217). This is planned to be supported out of the box in Smart Home. The second is having a virtual serial port that communicates over tcp. Probably this can achieved with the current implementation. The third would be to make a tcp connection and just send the serial data over tcp. Because of these choices I did prepare the code, but didn't proceed implementing support as it needs to be based on real use cases to see if there is extra work needed or if it will work out of the box.\r\nPart of making it work would be to use the smart home serial transport module. This is not yet done as the module interface lacks some methods interfacing with the serial library that are used in this binding. It might be needed to add those methods to the module. But that would make this binding depend on the process of that support and I didn't want it introduce a blocking issue. But once these issues are worked out in the future, migrating would be fairly easy."},"comment":{"url":"https://api.github.com/repos/openhab/openhab2-addons/issues/comments/417430609","html_url":"https://github.com/openhab/openhab2-addons/pull/3720#issuecomment-417430609","issue_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/3720","id":417430609,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzQzMDYwOQ==","user":{"login":"martinvw","id":2625279,"node_id":"MDQ6VXNlcjI2MjUyNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2625279?v=4","gravatar_id":"","url":"https://api.github.com/users/martinvw","html_url":"https://github.com/martinvw","followers_url":"https://api.github.com/users/martinvw/followers","following_url":"https://api.github.com/users/martinvw/following{/other_user}","gists_url":"https://api.github.com/users/martinvw/gists{/gist_id}","starred_url":"https://api.github.com/users/martinvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinvw/subscriptions","organizations_url":"https://api.github.com/users/martinvw/orgs","repos_url":"https://api.github.com/users/martinvw/repos","events_url":"https://api.github.com/users/martinvw/events{/privacy}","received_events_url":"https://api.github.com/users/martinvw/received_events","type":"User","site_admin":false},"created_at":"2018-08-30T18:59:49Z","updated_at":"2018-08-30T18:59:49Z","author_association":"MEMBER","body":"So I triggered the wrong build 😅"}}
{"actor":{"display_login":"martinvw"}}