{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/comments/201123728","pull_request_review_id":135564184,"id":201123728,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTEyMzcyOA==","diff_hunk":"@@ -23,14 +23,14 @@\n -->\n \n <playlist xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xsi:noNamespaceSchemaLocation=\"../../../TestConfig/playlist.xsd\">\n+\t<include>variables.mk</include>\n \t<test>\n \t\t<testCaseName>cmdLineTester_getPid</testCaseName>\n \t\t<variations>\n \t\t\t<variation>NoOptions</variation>\n \t\t</variations>\n-\t\t<command>$(JAVA_COMMAND) $(JVM_OPTIONS) -DTESTDIR=$(Q)$(TEST_RESROOT)$(Q) -DRESJAR=$(CMDLINETESTER_RESJAR) -DEXE='$(JAVA_COMMAND) $(JVM_OPTIONS)' -DTESTSJARPATH=$(Q)$(TEST_RESROOT)$(D)runtimemxbeanTests.jar$(Q) -jar $(CMDLINETESTER_JAR) -config $(Q)$(TEST_RESROOT)$(D)getPidTest.xml$(Q) \\\n-\t\t-explainExcludes -xids all,$(PLATFORM),$(VARIATION) -xlist $(Q)$(TEST_RESROOT)$(D)exclude.xml$(Q) -nonZeroExitWhenError; \\\n-\t\t$(TEST_STATUS)</command>\n+\t\t<command>$(JAVA_COMMAND) $(JVM_OPTIONS) -DTESTDIR=$(Q)$(TEST_RESROOT)$(Q) -DRESJAR=$(CMDLINETESTER_RESJAR) -DEXE='$(JAVA_COMMAND) $(JVM_OPTIONS)' -DTESTSJARPATH=$(Q)$(TEST_RESROOT)$(PATH)runtimemxbeanTests.jar$(Q) -jar $(CMDLINETESTER_JAR) -config $(Q)$(TEST_RESROOT)$(PATH)getPidTest.xml$(Q) -explainExcludes -nonZeroExitWhenError; \\\n+ \t\t$(TEST_STATUS)</command>","path":"test/functional/cmdLineTests/runtimemxbeanTests/playlist.xml","position":14,"original_position":14,"commit_id":"516407429a02bed3f2c78413752a4f5655c35b03","original_commit_id":"516407429a02bed3f2c78413752a4f5655c35b03","user":{"login":"llxia","id":19273206,"node_id":"MDQ6VXNlcjE5MjczMjA2","avatar_url":"https://avatars0.githubusercontent.com/u/19273206?v=4","gravatar_id":"","url":"https://api.github.com/users/llxia","html_url":"https://github.com/llxia","followers_url":"https://api.github.com/users/llxia/followers","following_url":"https://api.github.com/users/llxia/following{/other_user}","gists_url":"https://api.github.com/users/llxia/gists{/gist_id}","starred_url":"https://api.github.com/users/llxia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llxia/subscriptions","organizations_url":"https://api.github.com/users/llxia/orgs","repos_url":"https://api.github.com/users/llxia/repos","events_url":"https://api.github.com/users/llxia/events{/privacy}","received_events_url":"https://api.github.com/users/llxia/received_events","type":"User","site_admin":false},"body":"cmd is incomplete. It should be\r\n``` -explainExcludes -xids all,$(PLATFORM),$(VARIATION) -xlist $(Q)$(TEST_RESROOT)$(D)exclude.xml$(Q) -nonZeroExitWhenError; ```","created_at":"2018-07-09T19:42:47Z","updated_at":"2018-07-09T19:42:47Z","html_url":"https://github.com/eclipse/openj9/pull/2357#discussion_r201123728","pull_request_url":"https://api.github.com/repos/eclipse/openj9/pulls/2357","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments/201123728"},"html":{"href":"https://github.com/eclipse/openj9/pull/2357#discussion_r201123728"},"pull_request":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/2357"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/2357","id":200171243,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMTcxMjQz","html_url":"https://github.com/eclipse/openj9/pull/2357","diff_url":"https://github.com/eclipse/openj9/pull/2357.diff","patch_url":"https://github.com/eclipse/openj9/pull/2357.patch","issue_url":"https://api.github.com/repos/eclipse/openj9/issues/2357","number":2357,"state":"open","locked":false,"title":"Fix getPid failure in Windows","user":{"login":"Ailloviee","id":19404096,"node_id":"MDQ6VXNlcjE5NDA0MDk2","avatar_url":"https://avatars2.githubusercontent.com/u/19404096?v=4","gravatar_id":"","url":"https://api.github.com/users/Ailloviee","html_url":"https://github.com/Ailloviee","followers_url":"https://api.github.com/users/Ailloviee/followers","following_url":"https://api.github.com/users/Ailloviee/following{/other_user}","gists_url":"https://api.github.com/users/Ailloviee/gists{/gist_id}","starred_url":"https://api.github.com/users/Ailloviee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ailloviee/subscriptions","organizations_url":"https://api.github.com/users/Ailloviee/orgs","repos_url":"https://api.github.com/users/Ailloviee/repos","events_url":"https://api.github.com/users/Ailloviee/events{/privacy}","received_events_url":"https://api.github.com/users/Ailloviee/received_events","type":"User","site_admin":false},"body":"Revert changes made previously on #1638\r\n\r\nAdded test case in getPidTest.pl for getting pid in Windows.\r\n\r\nSigned-off-by: Charles_Zheng <Juntian.Zheng@ibm.com>","created_at":"2018-07-09T17:39:51Z","updated_at":"2018-07-09T19:42:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c201415866cc6c8c94c5a3343327cf3dc62a400b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":697962334,"node_id":"MDU6TGFiZWw2OTc5NjIzMzQ=","url":"https://api.github.com/repos/eclipse/openj9/labels/comp:test","name":"comp:test","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/openj9/pulls/2357/commits","review_comments_url":"https://api.github.com/repos/eclipse/openj9/pulls/2357/comments","review_comment_url":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/openj9/issues/2357/comments","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/516407429a02bed3f2c78413752a4f5655c35b03","head":{"label":"Ailloviee:getPidFix_v4","ref":"getPidFix_v4","sha":"516407429a02bed3f2c78413752a4f5655c35b03","user":{"login":"Ailloviee","id":19404096,"node_id":"MDQ6VXNlcjE5NDA0MDk2","avatar_url":"https://avatars2.githubusercontent.com/u/19404096?v=4","gravatar_id":"","url":"https://api.github.com/users/Ailloviee","html_url":"https://github.com/Ailloviee","followers_url":"https://api.github.com/users/Ailloviee/followers","following_url":"https://api.github.com/users/Ailloviee/following{/other_user}","gists_url":"https://api.github.com/users/Ailloviee/gists{/gist_id}","starred_url":"https://api.github.com/users/Ailloviee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ailloviee/subscriptions","organizations_url":"https://api.github.com/users/Ailloviee/orgs","repos_url":"https://api.github.com/users/Ailloviee/repos","events_url":"https://api.github.com/users/Ailloviee/events{/privacy}","received_events_url":"https://api.github.com/users/Ailloviee/received_events","type":"User","site_admin":false},"repo":{"id":132646816,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI2NDY4MTY=","name":"openj9","full_name":"Ailloviee/openj9","owner":{"login":"Ailloviee","id":19404096,"node_id":"MDQ6VXNlcjE5NDA0MDk2","avatar_url":"https://avatars2.githubusercontent.com/u/19404096?v=4","gravatar_id":"","url":"https://api.github.com/users/Ailloviee","html_url":"https://github.com/Ailloviee","followers_url":"https://api.github.com/users/Ailloviee/followers","following_url":"https://api.github.com/users/Ailloviee/following{/other_user}","gists_url":"https://api.github.com/users/Ailloviee/gists{/gist_id}","starred_url":"https://api.github.com/users/Ailloviee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ailloviee/subscriptions","organizations_url":"https://api.github.com/users/Ailloviee/orgs","repos_url":"https://api.github.com/users/Ailloviee/repos","events_url":"https://api.github.com/users/Ailloviee/events{/privacy}","received_events_url":"https://api.github.com/users/Ailloviee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ailloviee/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput.   Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":true,"url":"https://api.github.com/repos/Ailloviee/openj9","forks_url":"https://api.github.com/repos/Ailloviee/openj9/forks","keys_url":"https://api.github.com/repos/Ailloviee/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ailloviee/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ailloviee/openj9/teams","hooks_url":"https://api.github.com/repos/Ailloviee/openj9/hooks","issue_events_url":"https://api.github.com/repos/Ailloviee/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/Ailloviee/openj9/events","assignees_url":"https://api.github.com/repos/Ailloviee/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/Ailloviee/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/Ailloviee/openj9/tags","blobs_url":"https://api.github.com/repos/Ailloviee/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ailloviee/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ailloviee/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ailloviee/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ailloviee/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/Ailloviee/openj9/languages","stargazers_url":"https://api.github.com/repos/Ailloviee/openj9/stargazers","contributors_url":"https://api.github.com/repos/Ailloviee/openj9/contributors","subscribers_url":"https://api.github.com/repos/Ailloviee/openj9/subscribers","subscription_url":"https://api.github.com/repos/Ailloviee/openj9/subscription","commits_url":"https://api.github.com/repos/Ailloviee/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ailloviee/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ailloviee/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ailloviee/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ailloviee/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/Ailloviee/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ailloviee/openj9/merges","archive_url":"https://api.github.com/repos/Ailloviee/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ailloviee/openj9/downloads","issues_url":"https://api.github.com/repos/Ailloviee/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/Ailloviee/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/Ailloviee/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/Ailloviee/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ailloviee/openj9/labels{/name}","releases_url":"https://api.github.com/repos/Ailloviee/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/Ailloviee/openj9/deployments","created_at":"2018-05-08T18:08:05Z","updated_at":"2018-05-17T19:18:44Z","pushed_at":"2018-07-09T18:53:36Z","git_url":"git://github.com/Ailloviee/openj9.git","ssh_url":"git@github.com:Ailloviee/openj9.git","clone_url":"https://github.com/Ailloviee/openj9.git","svn_url":"https://github.com/Ailloviee/openj9","homepage":"","size":32163,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"3ffa77b03564e5c9fc47a836958f38ccd8bb2f83","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":101408117,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE0MDgxMTc=","name":"openj9","full_name":"eclipse/openj9","owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput.   Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":false,"url":"https://api.github.com/repos/eclipse/openj9","forks_url":"https://api.github.com/repos/eclipse/openj9/forks","keys_url":"https://api.github.com/repos/eclipse/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/openj9/teams","hooks_url":"https://api.github.com/repos/eclipse/openj9/hooks","issue_events_url":"https://api.github.com/repos/eclipse/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/openj9/events","assignees_url":"https://api.github.com/repos/eclipse/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/openj9/tags","blobs_url":"https://api.github.com/repos/eclipse/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/openj9/languages","stargazers_url":"https://api.github.com/repos/eclipse/openj9/stargazers","contributors_url":"https://api.github.com/repos/eclipse/openj9/contributors","subscribers_url":"https://api.github.com/repos/eclipse/openj9/subscribers","subscription_url":"https://api.github.com/repos/eclipse/openj9/subscription","commits_url":"https://api.github.com/repos/eclipse/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/openj9/merges","archive_url":"https://api.github.com/repos/eclipse/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/openj9/downloads","issues_url":"https://api.github.com/repos/eclipse/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/openj9/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/openj9/deployments","created_at":"2017-08-25T13:46:07Z","updated_at":"2018-07-09T19:36:50Z","pushed_at":"2018-07-09T19:22:27Z","git_url":"git://github.com/eclipse/openj9.git","ssh_url":"git@github.com:eclipse/openj9.git","clone_url":"https://github.com/eclipse/openj9.git","svn_url":"https://github.com/eclipse/openj9","homepage":"","size":31831,"stargazers_count":1292,"watchers_count":1292,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":262,"mirror_url":null,"archived":false,"open_issues_count":419,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":262,"open_issues":419,"watchers":1292,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/2357"},"html":{"href":"https://github.com/eclipse/openj9/pull/2357"},"issue":{"href":"https://api.github.com/repos/eclipse/openj9/issues/2357"},"comments":{"href":"https://api.github.com/repos/eclipse/openj9/issues/2357/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/2357/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/2357/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/openj9/statuses/516407429a02bed3f2c78413752a4f5655c35b03"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"llxia"}}