{"action":"created","comment":{"url":"https://api.github.com/repos/stympy/faker/pulls/comments/245308279","pull_request_review_id":189381050,"id":245308279,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTMwODI3OQ==","diff_hunk":"@@ -0,0 +1,7 @@\n+# Faker::Quotes::Yoda\n+\n+Available since version 1.9.0.\n+\n+```ruby\n+Faker::Quotes::Yoda.quote #=> \"Use your feelings, Obi-Wan, and find him you will.\"","path":"doc/unreleased/quotes/yoda.md","position":6,"original_position":6,"commit_id":"2628a647728e6e121ebb01efd8bfb35a271bcdbb","original_commit_id":"2628a647728e6e121ebb01efd8bfb35a271bcdbb","user":{"login":"stympy","id":1070,"node_id":"MDQ6VXNlcjEwNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1070?v=4","gravatar_id":"","url":"https://api.github.com/users/stympy","html_url":"https://github.com/stympy","followers_url":"https://api.github.com/users/stympy/followers","following_url":"https://api.github.com/users/stympy/following{/other_user}","gists_url":"https://api.github.com/users/stympy/gists{/gist_id}","starred_url":"https://api.github.com/users/stympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stympy/subscriptions","organizations_url":"https://api.github.com/users/stympy/orgs","repos_url":"https://api.github.com/users/stympy/repos","events_url":"https://api.github.com/users/stympy/events{/privacy}","received_events_url":"https://api.github.com/users/stympy/received_events","type":"User","site_admin":false},"body":"I agree that it feels redundant. I don't see a problem with having both Faker::Quotes.yoda and Faker::Quotes::Shakespeare, but I'm open to hearing any contrary opinions. :)","created_at":"2019-01-04T14:15:13Z","updated_at":"2019-01-04T14:15:13Z","html_url":"https://github.com/stympy/faker/pull/1504#discussion_r245308279","pull_request_url":"https://api.github.com/repos/stympy/faker/pulls/1504","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/stympy/faker/pulls/comments/245308279"},"html":{"href":"https://github.com/stympy/faker/pull/1504#discussion_r245308279"},"pull_request":{"href":"https://api.github.com/repos/stympy/faker/pulls/1504"}},"in_reply_to_id":245305771},"pull_request":{"url":"https://api.github.com/repos/stympy/faker/pulls/1504","id":241644779,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNjQ0Nzc5","html_url":"https://github.com/stympy/faker/pull/1504","diff_url":"https://github.com/stympy/faker/pull/1504.diff","patch_url":"https://github.com/stympy/faker/pull/1504.patch","issue_url":"https://api.github.com/repos/stympy/faker/issues/1504","number":1504,"state":"open","locked":false,"title":"Add Quotes namespace","user":{"login":"vbrazo","id":1292556,"node_id":"MDQ6VXNlcjEyOTI1NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1292556?v=4","gravatar_id":"","url":"https://api.github.com/users/vbrazo","html_url":"https://github.com/vbrazo","followers_url":"https://api.github.com/users/vbrazo/followers","following_url":"https://api.github.com/users/vbrazo/following{/other_user}","gists_url":"https://api.github.com/users/vbrazo/gists{/gist_id}","starred_url":"https://api.github.com/users/vbrazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbrazo/subscriptions","organizations_url":"https://api.github.com/users/vbrazo/orgs","repos_url":"https://api.github.com/users/vbrazo/repos","events_url":"https://api.github.com/users/vbrazo/events{/privacy}","received_events_url":"https://api.github.com/users/vbrazo/received_events","type":"User","site_admin":false},"body":"## Checklist\r\n- [x] Add Quotes namespace\r\n- [x] Deprecates `Faker::FamousLastWords` => `Faker::Quotes::FamousLastWords`\r\n- [x] Deprecates `Faker::Matz` => `Faker::Quotes::Matz`\r\n- [x] Deprecates `Faker::MostInterestingManInTheWorld` => `Faker::Quotes::MostInterestingManInTheWorld` \r\n- [x] Deprecates `Faker::Robin` => `Faker::Quotes::Robin`\r\n- [x] Deprecates `Faker::SingularSiegler` => `Faker::Quotes::SingularSiegler`\r\n- [x] Deprecates `Faker::Yoda` => `Faker::Quotes::Yoda`\r\n\r\nThis PR is related to https://github.com/stympy/faker/issues/1318.","created_at":"2019-01-01T18:02:30Z","updated_at":"2019-01-04T14:15:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0c9e7e4a0e221a510d9f0b27e7531f7d9a19ca3","assignee":{"login":"vbrazo","id":1292556,"node_id":"MDQ6VXNlcjEyOTI1NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1292556?v=4","gravatar_id":"","url":"https://api.github.com/users/vbrazo","html_url":"https://github.com/vbrazo","followers_url":"https://api.github.com/users/vbrazo/followers","following_url":"https://api.github.com/users/vbrazo/following{/other_user}","gists_url":"https://api.github.com/users/vbrazo/gists{/gist_id}","starred_url":"https://api.github.com/users/vbrazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbrazo/subscriptions","organizations_url":"https://api.github.com/users/vbrazo/orgs","repos_url":"https://api.github.com/users/vbrazo/repos","events_url":"https://api.github.com/users/vbrazo/events{/privacy}","received_events_url":"https://api.github.com/users/vbrazo/received_events","type":"User","site_admin":false},"assignees":[{"login":"vbrazo","id":1292556,"node_id":"MDQ6VXNlcjEyOTI1NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1292556?v=4","gravatar_id":"","url":"https://api.github.com/users/vbrazo","html_url":"https://github.com/vbrazo","followers_url":"https://api.github.com/users/vbrazo/followers","following_url":"https://api.github.com/users/vbrazo/following{/other_user}","gists_url":"https://api.github.com/users/vbrazo/gists{/gist_id}","starred_url":"https://api.github.com/users/vbrazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbrazo/subscriptions","organizations_url":"https://api.github.com/users/vbrazo/orgs","repos_url":"https://api.github.com/users/vbrazo/repos","events_url":"https://api.github.com/users/vbrazo/events{/privacy}","received_events_url":"https://api.github.com/users/vbrazo/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":950713853,"node_id":"MDU6TGFiZWw5NTA3MTM4NTM=","url":"https://api.github.com/repos/stympy/faker/labels/Deprecation","name":"Deprecation","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/stympy/faker/pulls/1504/commits","review_comments_url":"https://api.github.com/repos/stympy/faker/pulls/1504/comments","review_comment_url":"https://api.github.com/repos/stympy/faker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stympy/faker/issues/1504/comments","statuses_url":"https://api.github.com/repos/stympy/faker/statuses/2628a647728e6e121ebb01efd8bfb35a271bcdbb","head":{"label":"vbrazo:features/add-quotes-namespace","ref":"features/add-quotes-namespace","sha":"2628a647728e6e121ebb01efd8bfb35a271bcdbb","user":{"login":"vbrazo","id":1292556,"node_id":"MDQ6VXNlcjEyOTI1NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1292556?v=4","gravatar_id":"","url":"https://api.github.com/users/vbrazo","html_url":"https://github.com/vbrazo","followers_url":"https://api.github.com/users/vbrazo/followers","following_url":"https://api.github.com/users/vbrazo/following{/other_user}","gists_url":"https://api.github.com/users/vbrazo/gists{/gist_id}","starred_url":"https://api.github.com/users/vbrazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbrazo/subscriptions","organizations_url":"https://api.github.com/users/vbrazo/orgs","repos_url":"https://api.github.com/users/vbrazo/repos","events_url":"https://api.github.com/users/vbrazo/events{/privacy}","received_events_url":"https://api.github.com/users/vbrazo/received_events","type":"User","site_admin":false},"repo":{"id":126910825,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY5MTA4MjU=","name":"faker","full_name":"vbrazo/faker","private":false,"owner":{"login":"vbrazo","id":1292556,"node_id":"MDQ6VXNlcjEyOTI1NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1292556?v=4","gravatar_id":"","url":"https://api.github.com/users/vbrazo","html_url":"https://github.com/vbrazo","followers_url":"https://api.github.com/users/vbrazo/followers","following_url":"https://api.github.com/users/vbrazo/following{/other_user}","gists_url":"https://api.github.com/users/vbrazo/gists{/gist_id}","starred_url":"https://api.github.com/users/vbrazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbrazo/subscriptions","organizations_url":"https://api.github.com/users/vbrazo/orgs","repos_url":"https://api.github.com/users/vbrazo/repos","events_url":"https://api.github.com/users/vbrazo/events{/privacy}","received_events_url":"https://api.github.com/users/vbrazo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vbrazo/faker","description":"A library for generating fake data such as names, addresses, and phone numbers.","fork":true,"url":"https://api.github.com/repos/vbrazo/faker","forks_url":"https://api.github.com/repos/vbrazo/faker/forks","keys_url":"https://api.github.com/repos/vbrazo/faker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vbrazo/faker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vbrazo/faker/teams","hooks_url":"https://api.github.com/repos/vbrazo/faker/hooks","issue_events_url":"https://api.github.com/repos/vbrazo/faker/issues/events{/number}","events_url":"https://api.github.com/repos/vbrazo/faker/events","assignees_url":"https://api.github.com/repos/vbrazo/faker/assignees{/user}","branches_url":"https://api.github.com/repos/vbrazo/faker/branches{/branch}","tags_url":"https://api.github.com/repos/vbrazo/faker/tags","blobs_url":"https://api.github.com/repos/vbrazo/faker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vbrazo/faker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vbrazo/faker/git/refs{/sha}","trees_url":"https://api.github.com/repos/vbrazo/faker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vbrazo/faker/statuses/{sha}","languages_url":"https://api.github.com/repos/vbrazo/faker/languages","stargazers_url":"https://api.github.com/repos/vbrazo/faker/stargazers","contributors_url":"https://api.github.com/repos/vbrazo/faker/contributors","subscribers_url":"https://api.github.com/repos/vbrazo/faker/subscribers","subscription_url":"https://api.github.com/repos/vbrazo/faker/subscription","commits_url":"https://api.github.com/repos/vbrazo/faker/commits{/sha}","git_commits_url":"https://api.github.com/repos/vbrazo/faker/git/commits{/sha}","comments_url":"https://api.github.com/repos/vbrazo/faker/comments{/number}","issue_comment_url":"https://api.github.com/repos/vbrazo/faker/issues/comments{/number}","contents_url":"https://api.github.com/repos/vbrazo/faker/contents/{+path}","compare_url":"https://api.github.com/repos/vbrazo/faker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vbrazo/faker/merges","archive_url":"https://api.github.com/repos/vbrazo/faker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vbrazo/faker/downloads","issues_url":"https://api.github.com/repos/vbrazo/faker/issues{/number}","pulls_url":"https://api.github.com/repos/vbrazo/faker/pulls{/number}","milestones_url":"https://api.github.com/repos/vbrazo/faker/milestones{/number}","notifications_url":"https://api.github.com/repos/vbrazo/faker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vbrazo/faker/labels{/name}","releases_url":"https://api.github.com/repos/vbrazo/faker/releases{/id}","deployments_url":"https://api.github.com/repos/vbrazo/faker/deployments","created_at":"2018-03-27T01:26:38Z","updated_at":"2018-10-22T18:29:57Z","pushed_at":"2019-01-01T20:02:39Z","git_url":"git://github.com/vbrazo/faker.git","ssh_url":"git@github.com:vbrazo/faker.git","clone_url":"https://github.com/vbrazo/faker.git","svn_url":"https://github.com/vbrazo/faker","homepage":"","size":4451,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stympy:master","ref":"master","sha":"9cb9131722dceb6263dc2becef61604194351b2a","user":{"login":"stympy","id":1070,"node_id":"MDQ6VXNlcjEwNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1070?v=4","gravatar_id":"","url":"https://api.github.com/users/stympy","html_url":"https://github.com/stympy","followers_url":"https://api.github.com/users/stympy/followers","following_url":"https://api.github.com/users/stympy/following{/other_user}","gists_url":"https://api.github.com/users/stympy/gists{/gist_id}","starred_url":"https://api.github.com/users/stympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stympy/subscriptions","organizations_url":"https://api.github.com/users/stympy/orgs","repos_url":"https://api.github.com/users/stympy/repos","events_url":"https://api.github.com/users/stympy/events{/privacy}","received_events_url":"https://api.github.com/users/stympy/received_events","type":"User","site_admin":false},"repo":{"id":96395,"node_id":"MDEwOlJlcG9zaXRvcnk5NjM5NQ==","name":"faker","full_name":"stympy/faker","private":false,"owner":{"login":"stympy","id":1070,"node_id":"MDQ6VXNlcjEwNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1070?v=4","gravatar_id":"","url":"https://api.github.com/users/stympy","html_url":"https://github.com/stympy","followers_url":"https://api.github.com/users/stympy/followers","following_url":"https://api.github.com/users/stympy/following{/other_user}","gists_url":"https://api.github.com/users/stympy/gists{/gist_id}","starred_url":"https://api.github.com/users/stympy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stympy/subscriptions","organizations_url":"https://api.github.com/users/stympy/orgs","repos_url":"https://api.github.com/users/stympy/repos","events_url":"https://api.github.com/users/stympy/events{/privacy}","received_events_url":"https://api.github.com/users/stympy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/stympy/faker","description":"A library for generating fake data such as names, addresses, and phone numbers.","fork":false,"url":"https://api.github.com/repos/stympy/faker","forks_url":"https://api.github.com/repos/stympy/faker/forks","keys_url":"https://api.github.com/repos/stympy/faker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stympy/faker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stympy/faker/teams","hooks_url":"https://api.github.com/repos/stympy/faker/hooks","issue_events_url":"https://api.github.com/repos/stympy/faker/issues/events{/number}","events_url":"https://api.github.com/repos/stympy/faker/events","assignees_url":"https://api.github.com/repos/stympy/faker/assignees{/user}","branches_url":"https://api.github.com/repos/stympy/faker/branches{/branch}","tags_url":"https://api.github.com/repos/stympy/faker/tags","blobs_url":"https://api.github.com/repos/stympy/faker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stympy/faker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stympy/faker/git/refs{/sha}","trees_url":"https://api.github.com/repos/stympy/faker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stympy/faker/statuses/{sha}","languages_url":"https://api.github.com/repos/stympy/faker/languages","stargazers_url":"https://api.github.com/repos/stympy/faker/stargazers","contributors_url":"https://api.github.com/repos/stympy/faker/contributors","subscribers_url":"https://api.github.com/repos/stympy/faker/subscribers","subscription_url":"https://api.github.com/repos/stympy/faker/subscription","commits_url":"https://api.github.com/repos/stympy/faker/commits{/sha}","git_commits_url":"https://api.github.com/repos/stympy/faker/git/commits{/sha}","comments_url":"https://api.github.com/repos/stympy/faker/comments{/number}","issue_comment_url":"https://api.github.com/repos/stympy/faker/issues/comments{/number}","contents_url":"https://api.github.com/repos/stympy/faker/contents/{+path}","compare_url":"https://api.github.com/repos/stympy/faker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stympy/faker/merges","archive_url":"https://api.github.com/repos/stympy/faker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stympy/faker/downloads","issues_url":"https://api.github.com/repos/stympy/faker/issues{/number}","pulls_url":"https://api.github.com/repos/stympy/faker/pulls{/number}","milestones_url":"https://api.github.com/repos/stympy/faker/milestones{/number}","notifications_url":"https://api.github.com/repos/stympy/faker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stympy/faker/labels{/name}","releases_url":"https://api.github.com/repos/stympy/faker/releases{/id}","deployments_url":"https://api.github.com/repos/stympy/faker/deployments","created_at":"2008-12-24T17:20:37Z","updated_at":"2019-01-03T16:01:29Z","pushed_at":"2019-01-01T20:02:41Z","git_url":"git://github.com/stympy/faker.git","ssh_url":"git@github.com:stympy/faker.git","clone_url":"https://github.com/stympy/faker.git","svn_url":"https://github.com/stympy/faker","homepage":"","size":4285,"stargazers_count":7281,"watchers_count":7281,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1867,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1867,"open_issues":56,"watchers":7281,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stympy/faker/pulls/1504"},"html":{"href":"https://github.com/stympy/faker/pull/1504"},"issue":{"href":"https://api.github.com/repos/stympy/faker/issues/1504"},"comments":{"href":"https://api.github.com/repos/stympy/faker/issues/1504/comments"},"review_comments":{"href":"https://api.github.com/repos/stympy/faker/pulls/1504/comments"},"review_comment":{"href":"https://api.github.com/repos/stympy/faker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stympy/faker/pulls/1504/commits"},"statuses":{"href":"https://api.github.com/repos/stympy/faker/statuses/2628a647728e6e121ebb01efd8bfb35a271bcdbb"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"stympy"}}