{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/7539","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/7539/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/7539/comments","events_url":"https://api.github.com/repos/istio/istio/issues/7539/events","html_url":"https://github.com/istio/istio/pull/7539","id":346302491,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MTk5MDM3","number":7539,"title":"cloudfoundry performance improvements","user":{"login":"zachgersh","id":689411,"node_id":"MDQ6VXNlcjY4OTQxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/689411?v=4","gravatar_id":"","url":"https://api.github.com/users/zachgersh","html_url":"https://github.com/zachgersh","followers_url":"https://api.github.com/users/zachgersh/followers","following_url":"https://api.github.com/users/zachgersh/following{/other_user}","gists_url":"https://api.github.com/users/zachgersh/gists{/gist_id}","starred_url":"https://api.github.com/users/zachgersh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachgersh/subscriptions","organizations_url":"https://api.github.com/users/zachgersh/orgs","repos_url":"https://api.github.com/users/zachgersh/repos","events_url":"https://api.github.com/users/zachgersh/events{/privacy}","received_events_url":"https://api.github.com/users/zachgersh/received_events","type":"User","site_admin":false},"labels":[{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-31T18:16:10Z","updated_at":"2018-07-31T18:16:16Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/7539","html_url":"https://github.com/istio/istio/pull/7539","diff_url":"https://github.com/istio/istio/pull/7539.diff","patch_url":"https://github.com/istio/istio/pull/7539.patch"},"body":"Held off on this until master opened up again.\r\n\r\nThese changes were to help us meet cloudfoundry performance targets.\r\n\r\nThe highlights:\r\n\r\nMoved from a monitor to a controller (allowed us to change caching / locking behavior). This also meant we could add specialized lookup behavior for the only config types we support.\r\n\r\nAdded small cache layer to copilot route fetching in the service registry (wanted to make sure we weren't slamming copilot with requests)\r\n\r\nRefactored Less behavior on hostname sort - this improved performance (there is a benchmark now) due to the fact that building clusters CONTINUOUSLY calls for destination rules. There ends up being a hot spot (pprof shows this) down into the sort. This is also why the String() method was removed from hostname (it adds overhead and speed through this code path is important).\r\n\r\nThanks a bunch to @ZackButcher for a whole host of his suggestions."},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/409318017","html_url":"https://github.com/istio/istio/pull/7539#issuecomment-409318017","issue_url":"https://api.github.com/repos/istio/istio/issues/7539","id":409318017,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTMxODAxNw==","user":{"login":"istio-testing","id":25311884,"node_id":"MDQ6VXNlcjI1MzExODg0","avatar_url":"https://avatars1.githubusercontent.com/u/25311884?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-testing","html_url":"https://github.com/istio-testing","followers_url":"https://api.github.com/users/istio-testing/followers","following_url":"https://api.github.com/users/istio-testing/following{/other_user}","gists_url":"https://api.github.com/users/istio-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-testing/subscriptions","organizations_url":"https://api.github.com/users/istio-testing/orgs","repos_url":"https://api.github.com/users/istio-testing/repos","events_url":"https://api.github.com/users/istio-testing/events{/privacy}","received_events_url":"https://api.github.com/users/istio-testing/received_events","type":"User","site_admin":false},"created_at":"2018-07-31T18:16:16Z","updated_at":"2018-07-31T18:16:16Z","author_association":"COLLABORATOR","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/istio/istio/pull/7539#\" title=\"Author self-approved\">zachgersh</a>*\nTo fully approve this pull request, please assign additional approvers.\nWe suggest the following additional approver: **nmittler**\n\nIf they are not already assigned, you can assign the PR to them by writing `/assign @nmittler` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pilot/OWNERS](https://github.com/istio/istio/blob/master/pilot/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"nmittler\"]} -->"}}
{"actor":{"display_login":"istio-testing"}}