{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/rally/pulls/comments/180401871","pull_request_review_id":110813292,"id":180401871,"diff_hunk":"@@ -12,7 +12,12 @@ class EsClientFactory:\n     Abstracts how the Elasticsearch client is created. Intended for testing.\n     \"\"\"\n     def __init__(self, hosts, client_options):\n-        logger.info(\"Creating ES client connected to %s with options [%s]\" % (hosts, client_options))\n+        masked_client_options = dict(client_options)\n+        if masked_client_options.has_key(\"basic_auth_password\"):\n+            masked_client_options[\"basic_auth_password\"] = \"*****\"\n+        if masked_client_options.has_key(\"http_auth\"):\n+            masked_client_options[\"http_auth\"] = (client_options[\"basic_auth_user\"], \"*****\")\n+        logger.info(\"Creating ES client connected to %s with options [%s]\" % (hosts, masked_client_options))","path":"esrally/client.py","position":10,"original_position":10,"commit_id":"afd2f641513422ecefab39ba96caff23e34c80ca","original_commit_id":"afd2f641513422ecefab39ba96caff23e34c80ca","user":{"login":"suckowbiz","id":13817930,"avatar_url":"https://avatars1.githubusercontent.com/u/13817930?v=4","gravatar_id":"","url":"https://api.github.com/users/suckowbiz","html_url":"https://github.com/suckowbiz","followers_url":"https://api.github.com/users/suckowbiz/followers","following_url":"https://api.github.com/users/suckowbiz/following{/other_user}","gists_url":"https://api.github.com/users/suckowbiz/gists{/gist_id}","starred_url":"https://api.github.com/users/suckowbiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suckowbiz/subscriptions","organizations_url":"https://api.github.com/users/suckowbiz/orgs","repos_url":"https://api.github.com/users/suckowbiz/repos","events_url":"https://api.github.com/users/suckowbiz/events{/privacy}","received_events_url":"https://api.github.com/users/suckowbiz/received_events","type":"User","site_admin":false},"body":"Of course.","created_at":"2018-04-10T12:31:02Z","updated_at":"2018-04-10T12:31:02Z","html_url":"https://github.com/elastic/rally/pull/464#discussion_r180401871","pull_request_url":"https://api.github.com/repos/elastic/rally/pulls/464","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/elastic/rally/pulls/comments/180401871"},"html":{"href":"https://github.com/elastic/rally/pull/464#discussion_r180401871"},"pull_request":{"href":"https://api.github.com/repos/elastic/rally/pulls/464"}},"in_reply_to_id":180386602},"pull_request":{"url":"https://api.github.com/repos/elastic/rally/pulls/464","id":180551134,"html_url":"https://github.com/elastic/rally/pull/464","diff_url":"https://github.com/elastic/rally/pull/464.diff","patch_url":"https://github.com/elastic/rally/pull/464.patch","issue_url":"https://api.github.com/repos/elastic/rally/issues/464","number":464,"state":"open","locked":false,"title":"esrally must not log clear text user passwords","user":{"login":"suckowbiz","id":13817930,"avatar_url":"https://avatars1.githubusercontent.com/u/13817930?v=4","gravatar_id":"","url":"https://api.github.com/users/suckowbiz","html_url":"https://github.com/suckowbiz","followers_url":"https://api.github.com/users/suckowbiz/followers","following_url":"https://api.github.com/users/suckowbiz/following{/other_user}","gists_url":"https://api.github.com/users/suckowbiz/gists{/gist_id}","starred_url":"https://api.github.com/users/suckowbiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suckowbiz/subscriptions","organizations_url":"https://api.github.com/users/suckowbiz/orgs","repos_url":"https://api.github.com/users/suckowbiz/repos","events_url":"https://api.github.com/users/suckowbiz/events{/privacy}","received_events_url":"https://api.github.com/users/suckowbiz/received_events","type":"User","site_admin":false},"body":"esrally 0.9.4 logs the basic auth password in clear text:\r\n\r\n```\r\n2018-04-08 07:00:00,100 PID:42 rally.client INFO Creating ES client connected to [{'host': '1.2.3.4', 'port': 9200}, {'host': '1.2.3.5', 'port': 9200}] with options [{'use_ssl': True, 'verify_certs': False, 'basic_auth_user': 'me', 'basic_auth_password': 'mypassword', 'http_auth': ('me', 'password')}]\r\n```\r\n\r\nesrally must not do this to enable usage in enterprise environments.\r\n\r\nPlease accept PR (following).","created_at":"2018-04-10T10:06:23Z","updated_at":"2018-04-10T12:31:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd1a97f7a9ba9e593d8291092f706275a1dc100a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":448334106,"url":"https://api.github.com/repos/elastic/rally/labels/:Load%20Driver","name":":Load Driver","color":"006b75","default":false},{"id":297818931,"url":"https://api.github.com/repos/elastic/rally/labels/:Metrics","name":":Metrics","color":"006b75","default":false},{"id":293505213,"url":"https://api.github.com/repos/elastic/rally/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/rally/pulls/464/commits","review_comments_url":"https://api.github.com/repos/elastic/rally/pulls/464/comments","review_comment_url":"https://api.github.com/repos/elastic/rally/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/rally/issues/464/comments","statuses_url":"https://api.github.com/repos/elastic/rally/statuses/afd2f641513422ecefab39ba96caff23e34c80ca","head":{"label":"suckowbiz:master","ref":"master","sha":"afd2f641513422ecefab39ba96caff23e34c80ca","user":{"login":"suckowbiz","id":13817930,"avatar_url":"https://avatars1.githubusercontent.com/u/13817930?v=4","gravatar_id":"","url":"https://api.github.com/users/suckowbiz","html_url":"https://github.com/suckowbiz","followers_url":"https://api.github.com/users/suckowbiz/followers","following_url":"https://api.github.com/users/suckowbiz/following{/other_user}","gists_url":"https://api.github.com/users/suckowbiz/gists{/gist_id}","starred_url":"https://api.github.com/users/suckowbiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suckowbiz/subscriptions","organizations_url":"https://api.github.com/users/suckowbiz/orgs","repos_url":"https://api.github.com/users/suckowbiz/repos","events_url":"https://api.github.com/users/suckowbiz/events{/privacy}","received_events_url":"https://api.github.com/users/suckowbiz/received_events","type":"User","site_admin":false},"repo":{"id":128905832,"name":"rally","full_name":"suckowbiz/rally","owner":{"login":"suckowbiz","id":13817930,"avatar_url":"https://avatars1.githubusercontent.com/u/13817930?v=4","gravatar_id":"","url":"https://api.github.com/users/suckowbiz","html_url":"https://github.com/suckowbiz","followers_url":"https://api.github.com/users/suckowbiz/followers","following_url":"https://api.github.com/users/suckowbiz/following{/other_user}","gists_url":"https://api.github.com/users/suckowbiz/gists{/gist_id}","starred_url":"https://api.github.com/users/suckowbiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suckowbiz/subscriptions","organizations_url":"https://api.github.com/users/suckowbiz/orgs","repos_url":"https://api.github.com/users/suckowbiz/repos","events_url":"https://api.github.com/users/suckowbiz/events{/privacy}","received_events_url":"https://api.github.com/users/suckowbiz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/suckowbiz/rally","description":"Macrobenchmarking framework for Elasticsearch","fork":true,"url":"https://api.github.com/repos/suckowbiz/rally","forks_url":"https://api.github.com/repos/suckowbiz/rally/forks","keys_url":"https://api.github.com/repos/suckowbiz/rally/keys{/key_id}","collaborators_url":"https://api.github.com/repos/suckowbiz/rally/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/suckowbiz/rally/teams","hooks_url":"https://api.github.com/repos/suckowbiz/rally/hooks","issue_events_url":"https://api.github.com/repos/suckowbiz/rally/issues/events{/number}","events_url":"https://api.github.com/repos/suckowbiz/rally/events","assignees_url":"https://api.github.com/repos/suckowbiz/rally/assignees{/user}","branches_url":"https://api.github.com/repos/suckowbiz/rally/branches{/branch}","tags_url":"https://api.github.com/repos/suckowbiz/rally/tags","blobs_url":"https://api.github.com/repos/suckowbiz/rally/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/suckowbiz/rally/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/suckowbiz/rally/git/refs{/sha}","trees_url":"https://api.github.com/repos/suckowbiz/rally/git/trees{/sha}","statuses_url":"https://api.github.com/repos/suckowbiz/rally/statuses/{sha}","languages_url":"https://api.github.com/repos/suckowbiz/rally/languages","stargazers_url":"https://api.github.com/repos/suckowbiz/rally/stargazers","contributors_url":"https://api.github.com/repos/suckowbiz/rally/contributors","subscribers_url":"https://api.github.com/repos/suckowbiz/rally/subscribers","subscription_url":"https://api.github.com/repos/suckowbiz/rally/subscription","commits_url":"https://api.github.com/repos/suckowbiz/rally/commits{/sha}","git_commits_url":"https://api.github.com/repos/suckowbiz/rally/git/commits{/sha}","comments_url":"https://api.github.com/repos/suckowbiz/rally/comments{/number}","issue_comment_url":"https://api.github.com/repos/suckowbiz/rally/issues/comments{/number}","contents_url":"https://api.github.com/repos/suckowbiz/rally/contents/{+path}","compare_url":"https://api.github.com/repos/suckowbiz/rally/compare/{base}...{head}","merges_url":"https://api.github.com/repos/suckowbiz/rally/merges","archive_url":"https://api.github.com/repos/suckowbiz/rally/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/suckowbiz/rally/downloads","issues_url":"https://api.github.com/repos/suckowbiz/rally/issues{/number}","pulls_url":"https://api.github.com/repos/suckowbiz/rally/pulls{/number}","milestones_url":"https://api.github.com/repos/suckowbiz/rally/milestones{/number}","notifications_url":"https://api.github.com/repos/suckowbiz/rally/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/suckowbiz/rally/labels{/name}","releases_url":"https://api.github.com/repos/suckowbiz/rally/releases{/id}","deployments_url":"https://api.github.com/repos/suckowbiz/rally/deployments","created_at":"2018-04-10T09:12:32Z","updated_at":"2018-04-10T09:55:02Z","pushed_at":"2018-04-10T09:55:01Z","git_url":"git://github.com/suckowbiz/rally.git","ssh_url":"git@github.com:suckowbiz/rally.git","clone_url":"https://github.com/suckowbiz/rally.git","svn_url":"https://github.com/suckowbiz/rally","homepage":"","size":3909,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"f245f685dcd625ac4d7f0fa151a885a4366f85a6","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":47140131,"name":"rally","full_name":"elastic/rally","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/rally","description":"Macrobenchmarking framework for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/rally","forks_url":"https://api.github.com/repos/elastic/rally/forks","keys_url":"https://api.github.com/repos/elastic/rally/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/rally/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/rally/teams","hooks_url":"https://api.github.com/repos/elastic/rally/hooks","issue_events_url":"https://api.github.com/repos/elastic/rally/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/rally/events","assignees_url":"https://api.github.com/repos/elastic/rally/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/rally/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/rally/tags","blobs_url":"https://api.github.com/repos/elastic/rally/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/rally/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/rally/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/rally/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/rally/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/rally/languages","stargazers_url":"https://api.github.com/repos/elastic/rally/stargazers","contributors_url":"https://api.github.com/repos/elastic/rally/contributors","subscribers_url":"https://api.github.com/repos/elastic/rally/subscribers","subscription_url":"https://api.github.com/repos/elastic/rally/subscription","commits_url":"https://api.github.com/repos/elastic/rally/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/rally/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/rally/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/rally/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/rally/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/rally/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/rally/merges","archive_url":"https://api.github.com/repos/elastic/rally/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/rally/downloads","issues_url":"https://api.github.com/repos/elastic/rally/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/rally/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/rally/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/rally/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/rally/labels{/name}","releases_url":"https://api.github.com/repos/elastic/rally/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/rally/deployments","created_at":"2015-11-30T19:11:43Z","updated_at":"2018-04-10T11:14:50Z","pushed_at":"2018-04-10T11:14:47Z","git_url":"git://github.com/elastic/rally.git","ssh_url":"git@github.com:elastic/rally.git","clone_url":"https://github.com/elastic/rally.git","svn_url":"https://github.com/elastic/rally","homepage":"","size":3909,"stargazers_count":445,"watchers_count":445,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":83,"open_issues":36,"watchers":445,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/rally/pulls/464"},"html":{"href":"https://github.com/elastic/rally/pull/464"},"issue":{"href":"https://api.github.com/repos/elastic/rally/issues/464"},"comments":{"href":"https://api.github.com/repos/elastic/rally/issues/464/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/rally/pulls/464/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/rally/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/rally/pulls/464/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/rally/statuses/afd2f641513422ecefab39ba96caff23e34c80ca"}},"author_association":"NONE"}}
{"actor":{"display_login":"suckowbiz"}}