{"action":"created","issue":{"url":"https://api.github.com/repos/mui-org/material-ui/issues/13349","repository_url":"https://api.github.com/repos/mui-org/material-ui","labels_url":"https://api.github.com/repos/mui-org/material-ui/issues/13349/labels{/name}","comments_url":"https://api.github.com/repos/mui-org/material-ui/issues/13349/comments","events_url":"https://api.github.com/repos/mui-org/material-ui/issues/13349/events","html_url":"https://github.com/mui-org/material-ui/issues/13349","id":372648361,"node_id":"MDU6SXNzdWUzNzI2NDgzNjE=","number":13349,"title":"Modal onClose error: Cannot read property 'removeAttribute' of null","user":{"login":"jadbox","id":595843,"node_id":"MDQ6VXNlcjU5NTg0Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/595843?v=4","gravatar_id":"","url":"https://api.github.com/users/jadbox","html_url":"https://github.com/jadbox","followers_url":"https://api.github.com/users/jadbox/followers","following_url":"https://api.github.com/users/jadbox/following{/other_user}","gists_url":"https://api.github.com/users/jadbox/gists{/gist_id}","starred_url":"https://api.github.com/users/jadbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jadbox/subscriptions","organizations_url":"https://api.github.com/users/jadbox/orgs","repos_url":"https://api.github.com/users/jadbox/repos","events_url":"https://api.github.com/users/jadbox/events{/privacy}","received_events_url":"https://api.github.com/users/jadbox/received_events","type":"User","site_admin":false},"labels":[{"id":122764862,"node_id":"MDU6TGFiZWwxMjI3NjQ4NjI=","url":"https://api.github.com/repos/mui-org/material-ui/labels/bug","name":"bug","color":"e11d21","default":true},{"id":743690779,"node_id":"MDU6TGFiZWw3NDM2OTA3Nzk=","url":"https://api.github.com/repos/mui-org/material-ui/labels/component:%20Modal","name":"component: Modal","color":"ffffff","default":false}],"state":"open","locked":false,"assignee":{"login":"oliviertassinari","id":3165635,"node_id":"MDQ6VXNlcjMxNjU2MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/3165635?v=4","gravatar_id":"","url":"https://api.github.com/users/oliviertassinari","html_url":"https://github.com/oliviertassinari","followers_url":"https://api.github.com/users/oliviertassinari/followers","following_url":"https://api.github.com/users/oliviertassinari/following{/other_user}","gists_url":"https://api.github.com/users/oliviertassinari/gists{/gist_id}","starred_url":"https://api.github.com/users/oliviertassinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliviertassinari/subscriptions","organizations_url":"https://api.github.com/users/oliviertassinari/orgs","repos_url":"https://api.github.com/users/oliviertassinari/repos","events_url":"https://api.github.com/users/oliviertassinari/events{/privacy}","received_events_url":"https://api.github.com/users/oliviertassinari/received_events","type":"User","site_admin":false},"assignees":[{"login":"oliviertassinari","id":3165635,"node_id":"MDQ6VXNlcjMxNjU2MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/3165635?v=4","gravatar_id":"","url":"https://api.github.com/users/oliviertassinari","html_url":"https://github.com/oliviertassinari","followers_url":"https://api.github.com/users/oliviertassinari/followers","following_url":"https://api.github.com/users/oliviertassinari/following{/other_user}","gists_url":"https://api.github.com/users/oliviertassinari/gists{/gist_id}","starred_url":"https://api.github.com/users/oliviertassinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliviertassinari/subscriptions","organizations_url":"https://api.github.com/users/oliviertassinari/orgs","repos_url":"https://api.github.com/users/oliviertassinari/repos","events_url":"https://api.github.com/users/oliviertassinari/events{/privacy}","received_events_url":"https://api.github.com/users/oliviertassinari/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-10-22T18:47:18Z","updated_at":"2018-10-23T02:09:44Z","closed_at":null,"author_association":"NONE","body":"I'm following this exact example, but when I open up the menu and click to close the menu... then the application crashes with the below error:\r\n\r\nExample used:\r\nhttps://material-ui.com/demos/menus/#selected-menus\r\n\r\nDeps:\r\n\"@material-ui/core\": \"^3.3.0\",\r\n\"@material-ui/icons\": \"^3.0.1\",\r\n\"typescript\": \"^3.1.3\"\r\n\r\n```\r\nmanageAriaHidden.js:28 Uncaught TypeError: Cannot read property 'removeAttribute' of null\r\n    at ariaHidden (manageAriaHidden.js:28)\r\n    at ModalManager.remove (ModalManager.js:188)\r\n    at Modal._this.handleClose (Modal.js:145)\r\n    at Modal.componentDidUpdate (Modal.js:221)\r\n    at commitLifeCycles (react-dom.development.js:14693)\r\n    at commitAllLifeCycles (react-dom.development.js:15905)\r\n    at HTMLUnknownElement.callCallback (react-dom.development.js:145)\r\n    at Object.invokeGuardedCallbackDev (react-dom.development.js:195)\r\n    at invokeGuardedCallback (react-dom.development.js:248)\r\n    at commitRoot (react-dom.development.js:16075)\r\n    at completeRoot (react-dom.development.js:17463)\r\n    at performWorkOnRoot (react-dom.development.js:17391)\r\n    at performWork (react-dom.development.js:17295)\r\n    at performSyncWork (react-dom.development.js:17267)\r\n    at interactiveUpdates$1 (react-dom.development.js:17558)\r\n    at interactiveUpdates (react-dom.development.js:2208)\r\n    at dispatchInteractiveEvent (react-dom.development.js:4913)\r\nariaHidden @ manageAriaHidden.js:28\r\nremove @ ModalManager.js:188\r\nModal._this.handleClose @ Modal.js:145\r\ncomponentDidUpdate @ Modal.js:221\r\ncommitLifeCycles @ react-dom.development.js:14693\r\ncommitAllLifeCycles @ react-dom.development.js:15905\r\ncallCallback @ react-dom.development.js:145\r\ninvokeGuardedCallbackDev @ react-dom.development.js:195\r\ninvokeGuardedCallback @ react-dom.development.js:248\r\ncommitRoot @ react-dom.development.js:16075\r\ncompleteRoot @ react-dom.development.js:17463\r\nperformWorkOnRoot @ react-dom.development.js:17391\r\nperformWork @ react-dom.development.js:17295\r\nperformSyncWork @ react-dom.development.js:17267\r\ninteractiveUpdates$1 @ react-dom.development.js:17558\r\ninteractiveUpdates @ react-dom.development.js:2208\r\ndispatchInteractiveEvent @ react-dom.development.js:4913\r\nindex.js:2178 The above error occurred in the <Modal> component:\r\n    in Modal (created by WithStyles(Modal))\r\n    in WithStyles(Modal) (created by Popover)\r\n    in Popover (created by WithStyles(Popover))\r\n    in WithStyles(Popover) (created by Menu)\r\n    in Menu (created by WithStyles(Menu))\r\n    in WithStyles(Menu) (created by AudioSettings)\r\n    in div (created by AudioSettings)\r\n    in div (created by DialogContent)\r\n    in DialogContent (created by WithStyles(DialogContent))\r\n    in WithStyles(DialogContent) (created by AudioSettings)\r\n    in div (created by Paper)\r\n    in Paper (created by WithStyles(Paper))\r\n    in WithStyles(Paper) (created by Dialog)\r\n    in Transition (created by Fade)\r\n    in Fade (created by WithTheme(Fade))\r\n    in WithTheme(Fade) (created by Dialog)\r\n    in RootRef (created by Modal)\r\n    in div (created by Modal)\r\n    in Portal (created by Modal)\r\n    in Modal (created by WithStyles(Modal))\r\n    in WithStyles(Modal) (created by Dialog)\r\n    in Dialog (created by WithStyles(Dialog))\r\n    in WithStyles(Dialog) (created by AudioSettings)\r\n    in AudioSettings (created by WithStyles(AudioSettings))\r\n    in WithStyles(AudioSettings) (created by WithRoot)\r\n    in MuiThemeProvider (created by WithRoot)\r\n    in WithRoot (created by FloatMenu)\r\n    in FloatMenu (created by WithStyles(FloatMenu))\r\n    in WithStyles(FloatMenu) (created by WithRoot)\r\n    in MuiThemeProvider (created by WithRoot)\r\n    in WithRoot (created by NamespacesConsumerComponent)\r\n    in NamespacesConsumerComponent (created by WithMergedOptions)\r\n    in WithMergedOptions (created by Context.Consumer)\r\n    in WithContext (created by LoadNamespace)\r\n    in LoadNamespace (created by WithMergedOptions)\r\n    in WithMergedOptions (created by Context.Consumer)\r\n    in LoadNamespace(WithRoot) (created by inject-LoadNamespace(WithRoot)-with-store)\r\n    in inject-LoadNamespace(WithRoot)-with-store (created by DebateScene)\r\n    in DebateScene (created by WithStyles(DebateScene))\r\n    in WithStyles(DebateScene) (created by WithRoot)\r\n    in MuiThemeProvider (created by WithRoot)\r\n    in WithRoot (created by NamespacesConsumerComponent)\r\n    in NamespacesConsumerComponent (created by WithMergedOptions)\r\n    in WithMergedOptions (created by Context.Consumer)\r\n    in WithContext (created by LoadNamespace)\r\n    in LoadNamespace (created by WithMergedOptions)\r\n    in WithMergedOptions (created by Context.Consumer)\r\n    in LoadNamespace(WithRoot) (created by DebateScene)\r\n    in DebateScene (created by WithStyles(DebateScene))\r\n    in WithStyles(DebateScene) (created by WithRoot)\r\n    in MuiThemeProvider (created by WithRoot)\r\n    in WithRoot (created by NamespacesConsumerComponent)\r\n    in NamespacesConsumerComponent (created by WithMergedOptions)\r\n    in WithMergedOptions (created by Context.Consumer)\r\n    in WithContext (created by LoadNamespace)\r\n    in LoadNamespace (created by WithMergedOptions)\r\n    in WithMergedOptions (created by Context.Consumer)\r\n    in LoadNamespace(WithRoot) (created by LoadableComponent)\r\n    in LoadableComponent (created by Route)\r\n    in Route (created by DTCRouter)\r\n\r\nConsider adding an error boundary to your tree to customize error handling behavior.\r\nVisit https://fb.me/react-error-boundaries to learn more about error boundaries.\r\n__stack_frame_overlay_proxy_console__ @ index.js:2178\r\nlogCapturedError @ react-dom.development.js:14550\r\nlogError @ react-dom.development.js:14586\r\nupdate.callback @ react-dom.development.js:15273\r\ncallCallback @ react-dom.development.js:11133\r\ncommitUpdateEffects @ react-dom.development.js:11172\r\ncommitUpdateQueue @ react-dom.development.js:11160\r\ncommitLifeCycles @ react-dom.development.js:14721\r\ncommitAllLifeCycles @ react-dom.development.js:15905\r\ncallCallback @ react-dom.development.js:145\r\ninvokeGuardedCallbackDev @ react-dom.development.js:195\r\ninvokeGuardedCallback @ react-dom.development.js:248\r\ncommitRoot @ react-dom.development.js:16075\r\ncompleteRoot @ react-dom.development.js:17463\r\nperformWorkOnRoot @ react-dom.development.js:17391\r\nperformWork @ react-dom.development.js:17295\r\nperformSyncWork @ react-dom.development.js:17267\r\ninteractiveUpdates$1 @ react-dom.development.js:17558\r\ninteractiveUpdates @ react-dom.development.js:2208\r\ndispatchInteractiveEvent @ react-dom.development.js:4913\r\nmanageAriaHidden.js:28 Uncaught TypeError: Cannot read property 'removeAttribute' of null\r\n    at ariaHidden (manageAriaHidden.js:28)\r\n    at ModalManager.remove (ModalManager.js:188)\r\n    at Modal._this.handleClose (Modal.js:145)\r\n    at Modal.componentDidUpdate (Modal.js:221)\r\n    at commitLifeCycles (react-dom.development.js:14693)\r\n    at commitAllLifeCycles (react-dom.development.js:15905)\r\n    at HTMLUnknownElement.callCallback (react-dom.development.js:145)\r\n    at Object.invokeGuardedCallbackDev (react-dom.development.js:195)\r\n    at invokeGuardedCallback (react-dom.development.js:248)\r\n    at commitRoot (react-dom.development.js:16075)\r\n    at completeRoot (react-dom.development.js:17463)\r\n    at performWorkOnRoot (react-dom.development.js:17391)\r\n    at performWork (react-dom.development.js:17295)\r\n    at performSyncWork (react-dom.development.js:17267)\r\n    at interactiveUpdates$1 (react-dom.development.js:17558)\r\n    at interactiveUpdates (react-dom.development.js:2208)\r\n    at dispatchInteractiveEvent (react-dom.development.js:4913)\r\n```"},"comment":{"url":"https://api.github.com/repos/mui-org/material-ui/issues/comments/432060192","html_url":"https://github.com/mui-org/material-ui/issues/13349#issuecomment-432060192","issue_url":"https://api.github.com/repos/mui-org/material-ui/issues/13349","id":432060192,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjA2MDE5Mg==","user":{"login":"jeffy-g","id":26692481,"node_id":"MDQ6VXNlcjI2NjkyNDgx","avatar_url":"https://avatars3.githubusercontent.com/u/26692481?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffy-g","html_url":"https://github.com/jeffy-g","followers_url":"https://api.github.com/users/jeffy-g/followers","following_url":"https://api.github.com/users/jeffy-g/following{/other_user}","gists_url":"https://api.github.com/users/jeffy-g/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffy-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffy-g/subscriptions","organizations_url":"https://api.github.com/users/jeffy-g/orgs","repos_url":"https://api.github.com/users/jeffy-g/repos","events_url":"https://api.github.com/users/jeffy-g/events{/privacy}","received_events_url":"https://api.github.com/users/jeffy-g/received_events","type":"User","site_admin":false},"created_at":"2018-10-23T02:09:44Z","updated_at":"2018-10-23T02:09:44Z","author_association":"NONE","body":"I encountered this problem earlier.\r\n\r\n[manageAriaHidden.js#ariaHidden](https://github.com/mui-org/material-ui/blob/master/packages/material-ui/src/Modal/manageAriaHidden.js \"export function ariaHidden(node, show)\") check code(`null`?) was deleted...\r\n"}}
{"actor":{"display_login":"jeffy-g"}}