{"action":"created","comment":{"url":"https://api.github.com/repos/Haaretz/htz-frontend/pulls/comments/244527658","pull_request_review_id":188432229,"id":244527658,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDUyNzY1OA==","diff_hunk":"@@ -43,7 +43,8 @@ class OsakaWithOutbrain extends React.Component {\n     // eslint-disable-next-line react/prop-types\n     const { promotedElement, hostname, canonicalUrl, } = this.props;\n     const url = canonicalUrl ? this.changeSubDomain(canonicalUrl) : '';\n-    const promoted = promotedElement[0].banners[0];\n+    console.log(5424532, this.props);\n+    const promoted = promotedElement[0].content.banners[0];","path":"packages/components/htz-components/src/components/Osaka/OsakaController.js","position":7,"original_position":6,"commit_id":"e351f614cccba707dffefc0fab389ec9357dcb33","original_commit_id":"69d8a2d4091c08f70f82ac9c5e863bc1df763f86","user":{"login":"yehudagoldner","id":2182058,"node_id":"MDQ6VXNlcjIxODIwNTg=","avatar_url":"https://avatars3.githubusercontent.com/u/2182058?v=4","gravatar_id":"","url":"https://api.github.com/users/yehudagoldner","html_url":"https://github.com/yehudagoldner","followers_url":"https://api.github.com/users/yehudagoldner/followers","following_url":"https://api.github.com/users/yehudagoldner/following{/other_user}","gists_url":"https://api.github.com/users/yehudagoldner/gists{/gist_id}","starred_url":"https://api.github.com/users/yehudagoldner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yehudagoldner/subscriptions","organizations_url":"https://api.github.com/users/yehudagoldner/orgs","repos_url":"https://api.github.com/users/yehudagoldner/repos","events_url":"https://api.github.com/users/yehudagoldner/events{/privacy}","received_events_url":"https://api.github.com/users/yehudagoldner/received_events","type":"User","site_admin":false},"body":"well, it worked so far :) \r\ni will verify the element exist anyway","created_at":"2018-12-30T08:48:37Z","updated_at":"2018-12-30T08:48:37Z","html_url":"https://github.com/Haaretz/htz-frontend/pull/1310#discussion_r244527658","pull_request_url":"https://api.github.com/repos/Haaretz/htz-frontend/pulls/1310","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Haaretz/htz-frontend/pulls/comments/244527658"},"html":{"href":"https://github.com/Haaretz/htz-frontend/pull/1310#discussion_r244527658"},"pull_request":{"href":"https://api.github.com/repos/Haaretz/htz-frontend/pulls/1310"}},"in_reply_to_id":244013628},"pull_request":{"url":"https://api.github.com/repos/Haaretz/htz-frontend/pulls/1310","id":240948141,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwOTQ4MTQx","html_url":"https://github.com/Haaretz/htz-frontend/pull/1310","diff_url":"https://github.com/Haaretz/htz-frontend/pull/1310.diff","patch_url":"https://github.com/Haaretz/htz-frontend/pull/1310.patch","issue_url":"https://api.github.com/repos/Haaretz/htz-frontend/issues/1310","number":1310,"state":"open","locked":false,"title":"fix(osaka): make it compatable with the new papi version","user":{"login":"yehudagoldner","id":2182058,"node_id":"MDQ6VXNlcjIxODIwNTg=","avatar_url":"https://avatars3.githubusercontent.com/u/2182058?v=4","gravatar_id":"","url":"https://api.github.com/users/yehudagoldner","html_url":"https://github.com/yehudagoldner","followers_url":"https://api.github.com/users/yehudagoldner/followers","following_url":"https://api.github.com/users/yehudagoldner/following{/other_user}","gists_url":"https://api.github.com/users/yehudagoldner/gists{/gist_id}","starred_url":"https://api.github.com/users/yehudagoldner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yehudagoldner/subscriptions","organizations_url":"https://api.github.com/users/yehudagoldner/orgs","repos_url":"https://api.github.com/users/yehudagoldner/repos","events_url":"https://api.github.com/users/yehudagoldner/events{/privacy}","received_events_url":"https://api.github.com/users/yehudagoldner/received_events","type":"User","site_admin":false},"body":"affects: @haaretz/htz-components\r\n\r\n<!-- START doctoc generated TOC please keep comment here to allow auto update -->\r\n<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->\r\n**Table of Contents**\r\n\r\n- [Description](#description)\r\n- [Checklist](#checklist)\r\n\r\n<!-- END doctoc generated TOC please keep comment here to allow auto update -->\r\n\r\n**Related issue(s):** #0\r\n\r\n## Description\r\n<!-- Technical description of the task -->\r\n\r\n\r\n<!-- Delete if none -->\r\n**Notes:**\r\n<!-- Extra notes on implementation, concerns, things to notice in review -->\r\n\r\n\r\n## Checklist\r\n\r\nDesign:\r\n  * [ ] Approved by designer\r\n\r\nUsability:\r\n  * [ ] Developer\r\n  * [ ] Project manager\r\n\r\nTests\r\n  <!-- remove irrelevant (but not incompolete) entries -->\r\n  * [ ] UI snapshot testing \r\n  * [ ] Unit testing\r\n  * [ ] Integration testing\r\n  * [ ] E2E testing\r\n","created_at":"2018-12-26T09:32:11Z","updated_at":"2018-12-30T08:48:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93ea2ebbba730bce04decf12a68a560d63ea361d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Haaretz/htz-frontend/pulls/1310/commits","review_comments_url":"https://api.github.com/repos/Haaretz/htz-frontend/pulls/1310/comments","review_comment_url":"https://api.github.com/repos/Haaretz/htz-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Haaretz/htz-frontend/issues/1310/comments","statuses_url":"https://api.github.com/repos/Haaretz/htz-frontend/statuses/e351f614cccba707dffefc0fab389ec9357dcb33","head":{"label":"Haaretz:fix/osaka-fix","ref":"fix/osaka-fix","sha":"e351f614cccba707dffefc0fab389ec9357dcb33","user":{"login":"Haaretz","id":12641584,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjQxNTg0","avatar_url":"https://avatars1.githubusercontent.com/u/12641584?v=4","gravatar_id":"","url":"https://api.github.com/users/Haaretz","html_url":"https://github.com/Haaretz","followers_url":"https://api.github.com/users/Haaretz/followers","following_url":"https://api.github.com/users/Haaretz/following{/other_user}","gists_url":"https://api.github.com/users/Haaretz/gists{/gist_id}","starred_url":"https://api.github.com/users/Haaretz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Haaretz/subscriptions","organizations_url":"https://api.github.com/users/Haaretz/orgs","repos_url":"https://api.github.com/users/Haaretz/repos","events_url":"https://api.github.com/users/Haaretz/events{/privacy}","received_events_url":"https://api.github.com/users/Haaretz/received_events","type":"Organization","site_admin":false},"repo":{"id":101068622,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEwNjg2MjI=","name":"htz-frontend","full_name":"Haaretz/htz-frontend","private":false,"owner":{"login":"Haaretz","id":12641584,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjQxNTg0","avatar_url":"https://avatars1.githubusercontent.com/u/12641584?v=4","gravatar_id":"","url":"https://api.github.com/users/Haaretz","html_url":"https://github.com/Haaretz","followers_url":"https://api.github.com/users/Haaretz/followers","following_url":"https://api.github.com/users/Haaretz/following{/other_user}","gists_url":"https://api.github.com/users/Haaretz/gists{/gist_id}","starred_url":"https://api.github.com/users/Haaretz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Haaretz/subscriptions","organizations_url":"https://api.github.com/users/Haaretz/orgs","repos_url":"https://api.github.com/users/Haaretz/repos","events_url":"https://api.github.com/users/Haaretz/events{/privacy}","received_events_url":"https://api.github.com/users/Haaretz/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Haaretz/htz-frontend","description":"Source for Haaretz frontend app(s)","fork":false,"url":"https://api.github.com/repos/Haaretz/htz-frontend","forks_url":"https://api.github.com/repos/Haaretz/htz-frontend/forks","keys_url":"https://api.github.com/repos/Haaretz/htz-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Haaretz/htz-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Haaretz/htz-frontend/teams","hooks_url":"https://api.github.com/repos/Haaretz/htz-frontend/hooks","issue_events_url":"https://api.github.com/repos/Haaretz/htz-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/Haaretz/htz-frontend/events","assignees_url":"https://api.github.com/repos/Haaretz/htz-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/Haaretz/htz-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/Haaretz/htz-frontend/tags","blobs_url":"https://api.github.com/repos/Haaretz/htz-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Haaretz/htz-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Haaretz/htz-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/Haaretz/htz-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Haaretz/htz-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/Haaretz/htz-frontend/languages","stargazers_url":"https://api.github.com/repos/Haaretz/htz-frontend/stargazers","contributors_url":"https://api.github.com/repos/Haaretz/htz-frontend/contributors","subscribers_url":"https://api.github.com/repos/Haaretz/htz-frontend/subscribers","subscription_url":"https://api.github.com/repos/Haaretz/htz-frontend/subscription","commits_url":"https://api.github.com/repos/Haaretz/htz-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/Haaretz/htz-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/Haaretz/htz-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/Haaretz/htz-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/Haaretz/htz-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/Haaretz/htz-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Haaretz/htz-frontend/merges","archive_url":"https://api.github.com/repos/Haaretz/htz-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Haaretz/htz-frontend/downloads","issues_url":"https://api.github.com/repos/Haaretz/htz-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/Haaretz/htz-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/Haaretz/htz-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/Haaretz/htz-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Haaretz/htz-frontend/labels{/name}","releases_url":"https://api.github.com/repos/Haaretz/htz-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/Haaretz/htz-frontend/deployments","created_at":"2017-08-22T13:55:37Z","updated_at":"2018-12-27T15:09:46Z","pushed_at":"2018-12-30T08:28:44Z","git_url":"git://github.com/Haaretz/htz-frontend.git","ssh_url":"git@github.com:Haaretz/htz-frontend.git","clone_url":"https://github.com/Haaretz/htz-frontend.git","svn_url":"https://github.com/Haaretz/htz-frontend","homepage":"https://haaretz.github.io/htz-frontend/docs","size":19472,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":280,"license":null,"forks":2,"open_issues":280,"watchers":5,"default_branch":"master"}},"base":{"label":"Haaretz:master","ref":"master","sha":"1837315d0be56f7186b4f88f172e3ba1dc02ca90","user":{"login":"Haaretz","id":12641584,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjQxNTg0","avatar_url":"https://avatars1.githubusercontent.com/u/12641584?v=4","gravatar_id":"","url":"https://api.github.com/users/Haaretz","html_url":"https://github.com/Haaretz","followers_url":"https://api.github.com/users/Haaretz/followers","following_url":"https://api.github.com/users/Haaretz/following{/other_user}","gists_url":"https://api.github.com/users/Haaretz/gists{/gist_id}","starred_url":"https://api.github.com/users/Haaretz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Haaretz/subscriptions","organizations_url":"https://api.github.com/users/Haaretz/orgs","repos_url":"https://api.github.com/users/Haaretz/repos","events_url":"https://api.github.com/users/Haaretz/events{/privacy}","received_events_url":"https://api.github.com/users/Haaretz/received_events","type":"Organization","site_admin":false},"repo":{"id":101068622,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEwNjg2MjI=","name":"htz-frontend","full_name":"Haaretz/htz-frontend","private":false,"owner":{"login":"Haaretz","id":12641584,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNjQxNTg0","avatar_url":"https://avatars1.githubusercontent.com/u/12641584?v=4","gravatar_id":"","url":"https://api.github.com/users/Haaretz","html_url":"https://github.com/Haaretz","followers_url":"https://api.github.com/users/Haaretz/followers","following_url":"https://api.github.com/users/Haaretz/following{/other_user}","gists_url":"https://api.github.com/users/Haaretz/gists{/gist_id}","starred_url":"https://api.github.com/users/Haaretz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Haaretz/subscriptions","organizations_url":"https://api.github.com/users/Haaretz/orgs","repos_url":"https://api.github.com/users/Haaretz/repos","events_url":"https://api.github.com/users/Haaretz/events{/privacy}","received_events_url":"https://api.github.com/users/Haaretz/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Haaretz/htz-frontend","description":"Source for Haaretz frontend app(s)","fork":false,"url":"https://api.github.com/repos/Haaretz/htz-frontend","forks_url":"https://api.github.com/repos/Haaretz/htz-frontend/forks","keys_url":"https://api.github.com/repos/Haaretz/htz-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Haaretz/htz-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Haaretz/htz-frontend/teams","hooks_url":"https://api.github.com/repos/Haaretz/htz-frontend/hooks","issue_events_url":"https://api.github.com/repos/Haaretz/htz-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/Haaretz/htz-frontend/events","assignees_url":"https://api.github.com/repos/Haaretz/htz-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/Haaretz/htz-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/Haaretz/htz-frontend/tags","blobs_url":"https://api.github.com/repos/Haaretz/htz-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Haaretz/htz-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Haaretz/htz-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/Haaretz/htz-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Haaretz/htz-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/Haaretz/htz-frontend/languages","stargazers_url":"https://api.github.com/repos/Haaretz/htz-frontend/stargazers","contributors_url":"https://api.github.com/repos/Haaretz/htz-frontend/contributors","subscribers_url":"https://api.github.com/repos/Haaretz/htz-frontend/subscribers","subscription_url":"https://api.github.com/repos/Haaretz/htz-frontend/subscription","commits_url":"https://api.github.com/repos/Haaretz/htz-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/Haaretz/htz-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/Haaretz/htz-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/Haaretz/htz-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/Haaretz/htz-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/Haaretz/htz-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Haaretz/htz-frontend/merges","archive_url":"https://api.github.com/repos/Haaretz/htz-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Haaretz/htz-frontend/downloads","issues_url":"https://api.github.com/repos/Haaretz/htz-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/Haaretz/htz-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/Haaretz/htz-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/Haaretz/htz-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Haaretz/htz-frontend/labels{/name}","releases_url":"https://api.github.com/repos/Haaretz/htz-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/Haaretz/htz-frontend/deployments","created_at":"2017-08-22T13:55:37Z","updated_at":"2018-12-27T15:09:46Z","pushed_at":"2018-12-30T08:28:44Z","git_url":"git://github.com/Haaretz/htz-frontend.git","ssh_url":"git@github.com:Haaretz/htz-frontend.git","clone_url":"https://github.com/Haaretz/htz-frontend.git","svn_url":"https://github.com/Haaretz/htz-frontend","homepage":"https://haaretz.github.io/htz-frontend/docs","size":19472,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":280,"license":null,"forks":2,"open_issues":280,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Haaretz/htz-frontend/pulls/1310"},"html":{"href":"https://github.com/Haaretz/htz-frontend/pull/1310"},"issue":{"href":"https://api.github.com/repos/Haaretz/htz-frontend/issues/1310"},"comments":{"href":"https://api.github.com/repos/Haaretz/htz-frontend/issues/1310/comments"},"review_comments":{"href":"https://api.github.com/repos/Haaretz/htz-frontend/pulls/1310/comments"},"review_comment":{"href":"https://api.github.com/repos/Haaretz/htz-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Haaretz/htz-frontend/pulls/1310/commits"},"statuses":{"href":"https://api.github.com/repos/Haaretz/htz-frontend/statuses/e351f614cccba707dffefc0fab389ec9357dcb33"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yehudagoldner"}}