{"action":"created","comment":{"url":"https://api.github.com/repos/pmodels/mpich/pulls/comments/204095413","pull_request_review_id":139121048,"id":204095413,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDA5NTQxMw==","diff_hunk":"@@ -71,7 +71,8 @@ static int decode_buffer(const char *str, char *dest, int length, int *num_decod\n         str++;\n         hex[1] = *str;\n         str++;\n-        sscanf(hex, \"%X\", &value);\n+        if (0 == sscanf(hex, \"%X\", &value))\n+            return MPL_STR_TRUNCATED;","path":"src/mpl/src/str/mpl_argstr.c","position":6,"original_position":6,"commit_id":"addd3bde367bc1c8fa8049f2092ead74b0f312b0","original_commit_id":"8e9d4ea7221c3388e74a3d9bf6e7b9ee06c3b888","user":{"login":"wesbland","id":1561207,"node_id":"MDQ6VXNlcjE1NjEyMDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1561207?v=4","gravatar_id":"","url":"https://api.github.com/users/wesbland","html_url":"https://github.com/wesbland","followers_url":"https://api.github.com/users/wesbland/followers","following_url":"https://api.github.com/users/wesbland/following{/other_user}","gists_url":"https://api.github.com/users/wesbland/gists{/gist_id}","starred_url":"https://api.github.com/users/wesbland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesbland/subscriptions","organizations_url":"https://api.github.com/users/wesbland/orgs","repos_url":"https://api.github.com/users/wesbland/repos","events_url":"https://api.github.com/users/wesbland/events{/privacy}","received_events_url":"https://api.github.com/users/wesbland/received_events","type":"User","site_admin":false},"body":"It's either that or `MPL_STR_FAIL`. I do think getting `0` here is an error case though, unless I'm not understanding the logic correctly.","created_at":"2018-07-20T16:13:09Z","updated_at":"2018-07-20T16:13:09Z","html_url":"https://github.com/pmodels/mpich/pull/3223#discussion_r204095413","pull_request_url":"https://api.github.com/repos/pmodels/mpich/pulls/3223","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pmodels/mpich/pulls/comments/204095413"},"html":{"href":"https://github.com/pmodels/mpich/pull/3223#discussion_r204095413"},"pull_request":{"href":"https://api.github.com/repos/pmodels/mpich/pulls/3223"}},"in_reply_to_id":204073804},"pull_request":{"url":"https://api.github.com/repos/pmodels/mpich/pulls/3223","id":201337995,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMzM3OTk1","html_url":"https://github.com/pmodels/mpich/pull/3223","diff_url":"https://github.com/pmodels/mpich/pull/3223.diff","patch_url":"https://github.com/pmodels/mpich/pull/3223.patch","issue_url":"https://api.github.com/repos/pmodels/mpich/issues/3223","number":3223,"state":"open","locked":false,"title":"Hydra Coverity Fixes","user":{"login":"wesbland","id":1561207,"node_id":"MDQ6VXNlcjE1NjEyMDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1561207?v=4","gravatar_id":"","url":"https://api.github.com/users/wesbland","html_url":"https://github.com/wesbland","followers_url":"https://api.github.com/users/wesbland/followers","following_url":"https://api.github.com/users/wesbland/following{/other_user}","gists_url":"https://api.github.com/users/wesbland/gists{/gist_id}","starred_url":"https://api.github.com/users/wesbland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesbland/subscriptions","organizations_url":"https://api.github.com/users/wesbland/orgs","repos_url":"https://api.github.com/users/wesbland/repos","events_url":"https://api.github.com/users/wesbland/events{/privacy}","received_events_url":"https://api.github.com/users/wesbland/received_events","type":"User","site_admin":false},"body":"Fix a number of Coverity defects in Hydra\r\n\r\n66319, 66320, 66331, 66330, 66334, 66335, 66339, 66340, 66341, 66346, 66347, 66348\r\n","created_at":"2018-07-13T16:17:29Z","updated_at":"2018-07-20T16:13:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00a2ef85bd79d044757f945be0ac9b60b78ef813","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/pmodels/mpich/milestones/25","html_url":"https://github.com/pmodels/mpich/milestone/25","labels_url":"https://api.github.com/repos/pmodels/mpich/milestones/25/labels","id":2070460,"node_id":"MDk6TWlsZXN0b25lMjA3MDQ2MA==","number":25,"title":"mpich-3.3","description":"This is a feature-oriented release, with a large number of major features planned (full list below).  The features are more of a wish-list, so they do not hold-up the release.\r\n\r\n'''Major Features:'''\r\n  1. MPICH/CH4\r\n     1. Scalable communication with large number of peers\r\n     1. Improvements for fine-grained communication (message rate and such)\r\n     1. OFI support\r\n     1. UCX support\r\n     1. Portals4 support\r\n  1. MPI+thread optimizations\r\n      * Thread arbitration optimizations\r\n      * Fine-grained threading optimizations\r\n  1. Topology function improvements (Comm_split_type and Cart/graph_create)\r\n  1. Derived datatypes\r\n      * Loop computation optimizations (DAME infrastructure)\r\n      * Dataloop comparison functionality\r\n  1. ptmalloc support\r\n","creator":{"login":"mpichbot","id":20957824,"node_id":"MDQ6VXNlcjIwOTU3ODI0","avatar_url":"https://avatars3.githubusercontent.com/u/20957824?v=4","gravatar_id":"","url":"https://api.github.com/users/mpichbot","html_url":"https://github.com/mpichbot","followers_url":"https://api.github.com/users/mpichbot/followers","following_url":"https://api.github.com/users/mpichbot/following{/other_user}","gists_url":"https://api.github.com/users/mpichbot/gists{/gist_id}","starred_url":"https://api.github.com/users/mpichbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpichbot/subscriptions","organizations_url":"https://api.github.com/users/mpichbot/orgs","repos_url":"https://api.github.com/users/mpichbot/repos","events_url":"https://api.github.com/users/mpichbot/events{/privacy}","received_events_url":"https://api.github.com/users/mpichbot/received_events","type":"User","site_admin":false},"open_issues":111,"closed_issues":31,"state":"open","created_at":"2016-10-14T14:51:11Z","updated_at":"2018-07-20T15:39:28Z","due_on":"2018-06-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pmodels/mpich/pulls/3223/commits","review_comments_url":"https://api.github.com/repos/pmodels/mpich/pulls/3223/comments","review_comment_url":"https://api.github.com/repos/pmodels/mpich/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pmodels/mpich/issues/3223/comments","statuses_url":"https://api.github.com/repos/pmodels/mpich/statuses/addd3bde367bc1c8fa8049f2092ead74b0f312b0","head":{"label":"wesbland:coverity_fixes","ref":"coverity_fixes","sha":"addd3bde367bc1c8fa8049f2092ead74b0f312b0","user":{"login":"wesbland","id":1561207,"node_id":"MDQ6VXNlcjE1NjEyMDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1561207?v=4","gravatar_id":"","url":"https://api.github.com/users/wesbland","html_url":"https://github.com/wesbland","followers_url":"https://api.github.com/users/wesbland/followers","following_url":"https://api.github.com/users/wesbland/following{/other_user}","gists_url":"https://api.github.com/users/wesbland/gists{/gist_id}","starred_url":"https://api.github.com/users/wesbland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesbland/subscriptions","organizations_url":"https://api.github.com/users/wesbland/orgs","repos_url":"https://api.github.com/users/wesbland/repos","events_url":"https://api.github.com/users/wesbland/events{/privacy}","received_events_url":"https://api.github.com/users/wesbland/received_events","type":"User","site_admin":false},"repo":{"id":71567749,"node_id":"MDEwOlJlcG9zaXRvcnk3MTU2Nzc0OQ==","name":"mpich","full_name":"wesbland/mpich","owner":{"login":"wesbland","id":1561207,"node_id":"MDQ6VXNlcjE1NjEyMDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1561207?v=4","gravatar_id":"","url":"https://api.github.com/users/wesbland","html_url":"https://github.com/wesbland","followers_url":"https://api.github.com/users/wesbland/followers","following_url":"https://api.github.com/users/wesbland/following{/other_user}","gists_url":"https://api.github.com/users/wesbland/gists{/gist_id}","starred_url":"https://api.github.com/users/wesbland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesbland/subscriptions","organizations_url":"https://api.github.com/users/wesbland/orgs","repos_url":"https://api.github.com/users/wesbland/repos","events_url":"https://api.github.com/users/wesbland/events{/privacy}","received_events_url":"https://api.github.com/users/wesbland/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wesbland/mpich","description":"Clone of Official MPICH Repository","fork":true,"url":"https://api.github.com/repos/wesbland/mpich","forks_url":"https://api.github.com/repos/wesbland/mpich/forks","keys_url":"https://api.github.com/repos/wesbland/mpich/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wesbland/mpich/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wesbland/mpich/teams","hooks_url":"https://api.github.com/repos/wesbland/mpich/hooks","issue_events_url":"https://api.github.com/repos/wesbland/mpich/issues/events{/number}","events_url":"https://api.github.com/repos/wesbland/mpich/events","assignees_url":"https://api.github.com/repos/wesbland/mpich/assignees{/user}","branches_url":"https://api.github.com/repos/wesbland/mpich/branches{/branch}","tags_url":"https://api.github.com/repos/wesbland/mpich/tags","blobs_url":"https://api.github.com/repos/wesbland/mpich/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wesbland/mpich/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wesbland/mpich/git/refs{/sha}","trees_url":"https://api.github.com/repos/wesbland/mpich/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wesbland/mpich/statuses/{sha}","languages_url":"https://api.github.com/repos/wesbland/mpich/languages","stargazers_url":"https://api.github.com/repos/wesbland/mpich/stargazers","contributors_url":"https://api.github.com/repos/wesbland/mpich/contributors","subscribers_url":"https://api.github.com/repos/wesbland/mpich/subscribers","subscription_url":"https://api.github.com/repos/wesbland/mpich/subscription","commits_url":"https://api.github.com/repos/wesbland/mpich/commits{/sha}","git_commits_url":"https://api.github.com/repos/wesbland/mpich/git/commits{/sha}","comments_url":"https://api.github.com/repos/wesbland/mpich/comments{/number}","issue_comment_url":"https://api.github.com/repos/wesbland/mpich/issues/comments{/number}","contents_url":"https://api.github.com/repos/wesbland/mpich/contents/{+path}","compare_url":"https://api.github.com/repos/wesbland/mpich/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wesbland/mpich/merges","archive_url":"https://api.github.com/repos/wesbland/mpich/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wesbland/mpich/downloads","issues_url":"https://api.github.com/repos/wesbland/mpich/issues{/number}","pulls_url":"https://api.github.com/repos/wesbland/mpich/pulls{/number}","milestones_url":"https://api.github.com/repos/wesbland/mpich/milestones{/number}","notifications_url":"https://api.github.com/repos/wesbland/mpich/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wesbland/mpich/labels{/name}","releases_url":"https://api.github.com/repos/wesbland/mpich/releases{/id}","deployments_url":"https://api.github.com/repos/wesbland/mpich/deployments","created_at":"2016-10-21T13:34:58Z","updated_at":"2017-05-23T13:56:07Z","pushed_at":"2018-07-20T15:38:02Z","git_url":"git://github.com/wesbland/mpich.git","ssh_url":"git@github.com:wesbland/mpich.git","clone_url":"https://github.com/wesbland/mpich.git","svn_url":"https://github.com/wesbland/mpich","homepage":"http://www.mpich.org","size":57007,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pmodels:master","ref":"master","sha":"7af0e7d0f5d0b8148544607e0c6121d9d1dbffba","user":{"login":"pmodels","id":15700567,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NzAwNTY3","avatar_url":"https://avatars2.githubusercontent.com/u/15700567?v=4","gravatar_id":"","url":"https://api.github.com/users/pmodels","html_url":"https://github.com/pmodels","followers_url":"https://api.github.com/users/pmodels/followers","following_url":"https://api.github.com/users/pmodels/following{/other_user}","gists_url":"https://api.github.com/users/pmodels/gists{/gist_id}","starred_url":"https://api.github.com/users/pmodels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmodels/subscriptions","organizations_url":"https://api.github.com/users/pmodels/orgs","repos_url":"https://api.github.com/users/pmodels/repos","events_url":"https://api.github.com/users/pmodels/events{/privacy}","received_events_url":"https://api.github.com/users/pmodels/received_events","type":"Organization","site_admin":false},"repo":{"id":70918679,"node_id":"MDEwOlJlcG9zaXRvcnk3MDkxODY3OQ==","name":"mpich","full_name":"pmodels/mpich","owner":{"login":"pmodels","id":15700567,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NzAwNTY3","avatar_url":"https://avatars2.githubusercontent.com/u/15700567?v=4","gravatar_id":"","url":"https://api.github.com/users/pmodels","html_url":"https://github.com/pmodels","followers_url":"https://api.github.com/users/pmodels/followers","following_url":"https://api.github.com/users/pmodels/following{/other_user}","gists_url":"https://api.github.com/users/pmodels/gists{/gist_id}","starred_url":"https://api.github.com/users/pmodels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmodels/subscriptions","organizations_url":"https://api.github.com/users/pmodels/orgs","repos_url":"https://api.github.com/users/pmodels/repos","events_url":"https://api.github.com/users/pmodels/events{/privacy}","received_events_url":"https://api.github.com/users/pmodels/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pmodels/mpich","description":"Official MPICH Repository","fork":false,"url":"https://api.github.com/repos/pmodels/mpich","forks_url":"https://api.github.com/repos/pmodels/mpich/forks","keys_url":"https://api.github.com/repos/pmodels/mpich/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmodels/mpich/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmodels/mpich/teams","hooks_url":"https://api.github.com/repos/pmodels/mpich/hooks","issue_events_url":"https://api.github.com/repos/pmodels/mpich/issues/events{/number}","events_url":"https://api.github.com/repos/pmodels/mpich/events","assignees_url":"https://api.github.com/repos/pmodels/mpich/assignees{/user}","branches_url":"https://api.github.com/repos/pmodels/mpich/branches{/branch}","tags_url":"https://api.github.com/repos/pmodels/mpich/tags","blobs_url":"https://api.github.com/repos/pmodels/mpich/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmodels/mpich/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmodels/mpich/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmodels/mpich/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmodels/mpich/statuses/{sha}","languages_url":"https://api.github.com/repos/pmodels/mpich/languages","stargazers_url":"https://api.github.com/repos/pmodels/mpich/stargazers","contributors_url":"https://api.github.com/repos/pmodels/mpich/contributors","subscribers_url":"https://api.github.com/repos/pmodels/mpich/subscribers","subscription_url":"https://api.github.com/repos/pmodels/mpich/subscription","commits_url":"https://api.github.com/repos/pmodels/mpich/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmodels/mpich/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmodels/mpich/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmodels/mpich/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmodels/mpich/contents/{+path}","compare_url":"https://api.github.com/repos/pmodels/mpich/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmodels/mpich/merges","archive_url":"https://api.github.com/repos/pmodels/mpich/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmodels/mpich/downloads","issues_url":"https://api.github.com/repos/pmodels/mpich/issues{/number}","pulls_url":"https://api.github.com/repos/pmodels/mpich/pulls{/number}","milestones_url":"https://api.github.com/repos/pmodels/mpich/milestones{/number}","notifications_url":"https://api.github.com/repos/pmodels/mpich/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmodels/mpich/labels{/name}","releases_url":"https://api.github.com/repos/pmodels/mpich/releases{/id}","deployments_url":"https://api.github.com/repos/pmodels/mpich/deployments","created_at":"2016-10-14T14:39:42Z","updated_at":"2018-07-20T15:39:51Z","pushed_at":"2018-07-20T16:10:09Z","git_url":"git://github.com/pmodels/mpich.git","ssh_url":"git@github.com:pmodels/mpich.git","clone_url":"https://github.com/pmodels/mpich.git","svn_url":"https://github.com/pmodels/mpich","homepage":"http://www.mpich.org","size":57022,"stargazers_count":100,"watchers_count":100,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"archived":false,"open_issues_count":416,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":94,"open_issues":416,"watchers":100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pmodels/mpich/pulls/3223"},"html":{"href":"https://github.com/pmodels/mpich/pull/3223"},"issue":{"href":"https://api.github.com/repos/pmodels/mpich/issues/3223"},"comments":{"href":"https://api.github.com/repos/pmodels/mpich/issues/3223/comments"},"review_comments":{"href":"https://api.github.com/repos/pmodels/mpich/pulls/3223/comments"},"review_comment":{"href":"https://api.github.com/repos/pmodels/mpich/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pmodels/mpich/pulls/3223/commits"},"statuses":{"href":"https://api.github.com/repos/pmodels/mpich/statuses/addd3bde367bc1c8fa8049f2092ead74b0f312b0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wesbland"}}