{"action":"created","comment":{"url":"https://api.github.com/repos/poseidon/typhoon/pulls/comments/169160695","pull_request_review_id":97642153,"id":169160695,"diff_hunk":"@@ -7,37 +7,49 @@ resource \"aws_route53_record\" \"apiserver\" {\n \n   # AWS recommends their special \"alias\" records for ELBs\n   alias {\n-    name                   = \"${aws_elb.apiserver.dns_name}\"\n-    zone_id                = \"${aws_elb.apiserver.zone_id}\"\n+    name                   = \"${aws_lb.apiserver.dns_name}\"\n+    zone_id                = \"${aws_lb.apiserver.zone_id}\"\n     evaluate_target_health = true\n   }\n }\n \n # Controller Network Load Balancer\n-resource \"aws_elb\" \"apiserver\" {\n-  name            = \"${var.cluster_name}-apiserver\"\n-  subnets         = [\"${aws_subnet.public.*.id}\"]\n-  security_groups = [\"${aws_security_group.controller.id}\"]\n-\n-  listener {\n-    lb_port           = 443\n-    lb_protocol       = \"tcp\"\n-    instance_port     = 443\n-    instance_protocol = \"tcp\"\n-  }\n+resource \"aws_lb\" \"apiserver\" {\n+  name               = \"${var.cluster_name}-apiserver\"\n+  load_balancer_type = \"network\"\n+  subnets            = [\"${aws_subnet.public.*.id}\"]\n+}\n \n-  instances = [\"${aws_instance.controllers.*.id}\"]\n+resource \"aws_lb_target_group\" \"apiserver\" {\n+  name     = \"${var.cluster_name}-apiserver\"\n+  port     = 443\n+  protocol = \"TCP\"\n+  vpc_id   = \"${aws_vpc.network.id}\"\n \n   # Kubelet HTTP health check\n   health_check {\n-    target              = \"SSL:443\"\n+    protocol            = \"TCP\"\n     healthy_threshold   = 2\n-    unhealthy_threshold = 4\n-    timeout             = 5\n-    interval            = 6\n+    unhealthy_threshold = 2","path":"aws/container-linux/kubernetes/elb.tf","position":45,"original_position":45,"commit_id":"4f83695ffc5c02bf34b9b77f6fa8c65d1ae4ef9e","original_commit_id":"4f83695ffc5c02bf34b9b77f6fa8c65d1ae4ef9e","user":{"login":"dghubble","id":2253428,"avatar_url":"https://avatars2.githubusercontent.com/u/2253428?v=4","gravatar_id":"","url":"https://api.github.com/users/dghubble","html_url":"https://github.com/dghubble","followers_url":"https://api.github.com/users/dghubble/followers","following_url":"https://api.github.com/users/dghubble/following{/other_user}","gists_url":"https://api.github.com/users/dghubble/gists{/gist_id}","starred_url":"https://api.github.com/users/dghubble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dghubble/subscriptions","organizations_url":"https://api.github.com/users/dghubble/orgs","repos_url":"https://api.github.com/users/dghubble/repos","events_url":"https://api.github.com/users/dghubble/events{/privacy}","received_events_url":"https://api.github.com/users/dghubble/received_events","type":"User","site_admin":false},"body":"Restore the original health check values please. Let's not slip in unrelated changes.","created_at":"2018-02-19T19:51:59Z","updated_at":"2018-02-19T19:54:36Z","html_url":"https://github.com/poseidon/typhoon/pull/136#discussion_r169160695","pull_request_url":"https://api.github.com/repos/poseidon/typhoon/pulls/136","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/poseidon/typhoon/pulls/comments/169160695"},"html":{"href":"https://github.com/poseidon/typhoon/pull/136#discussion_r169160695"},"pull_request":{"href":"https://api.github.com/repos/poseidon/typhoon/pulls/136"}}},"pull_request":{"url":"https://api.github.com/repos/poseidon/typhoon/pulls/136","id":169622497,"html_url":"https://github.com/poseidon/typhoon/pull/136","diff_url":"https://github.com/poseidon/typhoon/pull/136.diff","patch_url":"https://github.com/poseidon/typhoon/pull/136.patch","issue_url":"https://api.github.com/repos/poseidon/typhoon/issues/136","number":136,"state":"open","locked":false,"title":"AWS NLB - controllers","user":{"login":"pms1969","id":2762128,"avatar_url":"https://avatars2.githubusercontent.com/u/2762128?v=4","gravatar_id":"","url":"https://api.github.com/users/pms1969","html_url":"https://github.com/pms1969","followers_url":"https://api.github.com/users/pms1969/followers","following_url":"https://api.github.com/users/pms1969/following{/other_user}","gists_url":"https://api.github.com/users/pms1969/gists{/gist_id}","starred_url":"https://api.github.com/users/pms1969/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pms1969/subscriptions","organizations_url":"https://api.github.com/users/pms1969/orgs","repos_url":"https://api.github.com/users/pms1969/repos","events_url":"https://api.github.com/users/pms1969/events{/privacy}","received_events_url":"https://api.github.com/users/pms1969/received_events","type":"User","site_admin":false},"body":"Controller load balancer set to an AWS NLB\r\n\r\nTesting\r\ndeployed/destroyed/applied all addons.\r\n\r\nref: #130","created_at":"2018-02-16T13:20:43Z","updated_at":"2018-02-19T19:54:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ccefad8a684759836384cf3f26e01fc73cdd184","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/poseidon/typhoon/pulls/136/commits","review_comments_url":"https://api.github.com/repos/poseidon/typhoon/pulls/136/comments","review_comment_url":"https://api.github.com/repos/poseidon/typhoon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/poseidon/typhoon/issues/136/comments","statuses_url":"https://api.github.com/repos/poseidon/typhoon/statuses/4f83695ffc5c02bf34b9b77f6fa8c65d1ae4ef9e","head":{"label":"finbourne:feature/aws-nlb-controllers","ref":"feature/aws-nlb-controllers","sha":"4f83695ffc5c02bf34b9b77f6fa8c65d1ae4ef9e","user":{"login":"finbourne","id":22306292,"avatar_url":"https://avatars3.githubusercontent.com/u/22306292?v=4","gravatar_id":"","url":"https://api.github.com/users/finbourne","html_url":"https://github.com/finbourne","followers_url":"https://api.github.com/users/finbourne/followers","following_url":"https://api.github.com/users/finbourne/following{/other_user}","gists_url":"https://api.github.com/users/finbourne/gists{/gist_id}","starred_url":"https://api.github.com/users/finbourne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finbourne/subscriptions","organizations_url":"https://api.github.com/users/finbourne/orgs","repos_url":"https://api.github.com/users/finbourne/repos","events_url":"https://api.github.com/users/finbourne/events{/privacy}","received_events_url":"https://api.github.com/users/finbourne/received_events","type":"Organization","site_admin":false},"repo":{"id":121617787,"name":"typhoon","full_name":"finbourne/typhoon","owner":{"login":"finbourne","id":22306292,"avatar_url":"https://avatars3.githubusercontent.com/u/22306292?v=4","gravatar_id":"","url":"https://api.github.com/users/finbourne","html_url":"https://github.com/finbourne","followers_url":"https://api.github.com/users/finbourne/followers","following_url":"https://api.github.com/users/finbourne/following{/other_user}","gists_url":"https://api.github.com/users/finbourne/gists{/gist_id}","starred_url":"https://api.github.com/users/finbourne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finbourne/subscriptions","organizations_url":"https://api.github.com/users/finbourne/orgs","repos_url":"https://api.github.com/users/finbourne/repos","events_url":"https://api.github.com/users/finbourne/events{/privacy}","received_events_url":"https://api.github.com/users/finbourne/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/finbourne/typhoon","description":"Minimal and free Kubernetes distribution","fork":true,"url":"https://api.github.com/repos/finbourne/typhoon","forks_url":"https://api.github.com/repos/finbourne/typhoon/forks","keys_url":"https://api.github.com/repos/finbourne/typhoon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/finbourne/typhoon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/finbourne/typhoon/teams","hooks_url":"https://api.github.com/repos/finbourne/typhoon/hooks","issue_events_url":"https://api.github.com/repos/finbourne/typhoon/issues/events{/number}","events_url":"https://api.github.com/repos/finbourne/typhoon/events","assignees_url":"https://api.github.com/repos/finbourne/typhoon/assignees{/user}","branches_url":"https://api.github.com/repos/finbourne/typhoon/branches{/branch}","tags_url":"https://api.github.com/repos/finbourne/typhoon/tags","blobs_url":"https://api.github.com/repos/finbourne/typhoon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/finbourne/typhoon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/finbourne/typhoon/git/refs{/sha}","trees_url":"https://api.github.com/repos/finbourne/typhoon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/finbourne/typhoon/statuses/{sha}","languages_url":"https://api.github.com/repos/finbourne/typhoon/languages","stargazers_url":"https://api.github.com/repos/finbourne/typhoon/stargazers","contributors_url":"https://api.github.com/repos/finbourne/typhoon/contributors","subscribers_url":"https://api.github.com/repos/finbourne/typhoon/subscribers","subscription_url":"https://api.github.com/repos/finbourne/typhoon/subscription","commits_url":"https://api.github.com/repos/finbourne/typhoon/commits{/sha}","git_commits_url":"https://api.github.com/repos/finbourne/typhoon/git/commits{/sha}","comments_url":"https://api.github.com/repos/finbourne/typhoon/comments{/number}","issue_comment_url":"https://api.github.com/repos/finbourne/typhoon/issues/comments{/number}","contents_url":"https://api.github.com/repos/finbourne/typhoon/contents/{+path}","compare_url":"https://api.github.com/repos/finbourne/typhoon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/finbourne/typhoon/merges","archive_url":"https://api.github.com/repos/finbourne/typhoon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/finbourne/typhoon/downloads","issues_url":"https://api.github.com/repos/finbourne/typhoon/issues{/number}","pulls_url":"https://api.github.com/repos/finbourne/typhoon/pulls{/number}","milestones_url":"https://api.github.com/repos/finbourne/typhoon/milestones{/number}","notifications_url":"https://api.github.com/repos/finbourne/typhoon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/finbourne/typhoon/labels{/name}","releases_url":"https://api.github.com/repos/finbourne/typhoon/releases{/id}","deployments_url":"https://api.github.com/repos/finbourne/typhoon/deployments","created_at":"2018-02-15T10:43:34Z","updated_at":"2018-02-15T10:43:36Z","pushed_at":"2018-02-16T15:05:01Z","git_url":"git://github.com/finbourne/typhoon.git","ssh_url":"git@github.com:finbourne/typhoon.git","clone_url":"https://github.com/finbourne/typhoon.git","svn_url":"https://github.com/finbourne/typhoon","homepage":"https://typhoon.psdn.io/","size":2389,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"poseidon:master","ref":"master","sha":"c8313751d7ec4af5766cc93c7cd29ccbc2cb7a7d","user":{"login":"poseidon","id":31020170,"avatar_url":"https://avatars2.githubusercontent.com/u/31020170?v=4","gravatar_id":"","url":"https://api.github.com/users/poseidon","html_url":"https://github.com/poseidon","followers_url":"https://api.github.com/users/poseidon/followers","following_url":"https://api.github.com/users/poseidon/following{/other_user}","gists_url":"https://api.github.com/users/poseidon/gists{/gist_id}","starred_url":"https://api.github.com/users/poseidon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poseidon/subscriptions","organizations_url":"https://api.github.com/users/poseidon/orgs","repos_url":"https://api.github.com/users/poseidon/repos","events_url":"https://api.github.com/users/poseidon/events{/privacy}","received_events_url":"https://api.github.com/users/poseidon/received_events","type":"Organization","site_admin":false},"repo":{"id":99544448,"name":"typhoon","full_name":"poseidon/typhoon","owner":{"login":"poseidon","id":31020170,"avatar_url":"https://avatars2.githubusercontent.com/u/31020170?v=4","gravatar_id":"","url":"https://api.github.com/users/poseidon","html_url":"https://github.com/poseidon","followers_url":"https://api.github.com/users/poseidon/followers","following_url":"https://api.github.com/users/poseidon/following{/other_user}","gists_url":"https://api.github.com/users/poseidon/gists{/gist_id}","starred_url":"https://api.github.com/users/poseidon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poseidon/subscriptions","organizations_url":"https://api.github.com/users/poseidon/orgs","repos_url":"https://api.github.com/users/poseidon/repos","events_url":"https://api.github.com/users/poseidon/events{/privacy}","received_events_url":"https://api.github.com/users/poseidon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/poseidon/typhoon","description":"Minimal and free Kubernetes distribution","fork":false,"url":"https://api.github.com/repos/poseidon/typhoon","forks_url":"https://api.github.com/repos/poseidon/typhoon/forks","keys_url":"https://api.github.com/repos/poseidon/typhoon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poseidon/typhoon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poseidon/typhoon/teams","hooks_url":"https://api.github.com/repos/poseidon/typhoon/hooks","issue_events_url":"https://api.github.com/repos/poseidon/typhoon/issues/events{/number}","events_url":"https://api.github.com/repos/poseidon/typhoon/events","assignees_url":"https://api.github.com/repos/poseidon/typhoon/assignees{/user}","branches_url":"https://api.github.com/repos/poseidon/typhoon/branches{/branch}","tags_url":"https://api.github.com/repos/poseidon/typhoon/tags","blobs_url":"https://api.github.com/repos/poseidon/typhoon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poseidon/typhoon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poseidon/typhoon/git/refs{/sha}","trees_url":"https://api.github.com/repos/poseidon/typhoon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poseidon/typhoon/statuses/{sha}","languages_url":"https://api.github.com/repos/poseidon/typhoon/languages","stargazers_url":"https://api.github.com/repos/poseidon/typhoon/stargazers","contributors_url":"https://api.github.com/repos/poseidon/typhoon/contributors","subscribers_url":"https://api.github.com/repos/poseidon/typhoon/subscribers","subscription_url":"https://api.github.com/repos/poseidon/typhoon/subscription","commits_url":"https://api.github.com/repos/poseidon/typhoon/commits{/sha}","git_commits_url":"https://api.github.com/repos/poseidon/typhoon/git/commits{/sha}","comments_url":"https://api.github.com/repos/poseidon/typhoon/comments{/number}","issue_comment_url":"https://api.github.com/repos/poseidon/typhoon/issues/comments{/number}","contents_url":"https://api.github.com/repos/poseidon/typhoon/contents/{+path}","compare_url":"https://api.github.com/repos/poseidon/typhoon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poseidon/typhoon/merges","archive_url":"https://api.github.com/repos/poseidon/typhoon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poseidon/typhoon/downloads","issues_url":"https://api.github.com/repos/poseidon/typhoon/issues{/number}","pulls_url":"https://api.github.com/repos/poseidon/typhoon/pulls{/number}","milestones_url":"https://api.github.com/repos/poseidon/typhoon/milestones{/number}","notifications_url":"https://api.github.com/repos/poseidon/typhoon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poseidon/typhoon/labels{/name}","releases_url":"https://api.github.com/repos/poseidon/typhoon/releases{/id}","deployments_url":"https://api.github.com/repos/poseidon/typhoon/deployments","created_at":"2017-08-07T06:30:19Z","updated_at":"2018-02-19T19:23:43Z","pushed_at":"2018-02-16T15:07:23Z","git_url":"git://github.com/poseidon/typhoon.git","ssh_url":"git@github.com:poseidon/typhoon.git","clone_url":"https://github.com/poseidon/typhoon.git","svn_url":"https://github.com/poseidon/typhoon","homepage":"https://typhoon.psdn.io/","size":2383,"stargazers_count":324,"watchers_count":324,"language":"HCL","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":67,"open_issues":19,"watchers":324,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/poseidon/typhoon/pulls/136"},"html":{"href":"https://github.com/poseidon/typhoon/pull/136"},"issue":{"href":"https://api.github.com/repos/poseidon/typhoon/issues/136"},"comments":{"href":"https://api.github.com/repos/poseidon/typhoon/issues/136/comments"},"review_comments":{"href":"https://api.github.com/repos/poseidon/typhoon/pulls/136/comments"},"review_comment":{"href":"https://api.github.com/repos/poseidon/typhoon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/poseidon/typhoon/pulls/136/commits"},"statuses":{"href":"https://api.github.com/repos/poseidon/typhoon/statuses/4f83695ffc5c02bf34b9b77f6fa8c65d1ae4ef9e"}},"author_association":"NONE"}}
{"actor":{"display_login":"dghubble"}}