{"action":"created","comment":{"url":"https://api.github.com/repos/bsm/bfs/pulls/comments/183815722","pull_request_review_id":114884955,"id":183815722,"diff_hunk":"@@ -0,0 +1,84 @@\n+package bfsos_test\n+\n+import (\n+\t\"fmt\"\n+\t\"io/ioutil\"\n+\t\"os\"\n+\t\"path/filepath\"\n+\t\"testing\"\n+\n+\t\"github.com/bsm/bfs/bfsos\"\n+\t\"github.com/bsm/bfs/testdata/lint\"\n+\n+\t. \"github.com/onsi/ginkgo\"\n+\t. \"github.com/onsi/gomega\"\n+)\n+\n+const (\n+\ttmpRoot     = \"testdata/tmp\"\n+\treadonlyDir = \"testdata/tmp/readonly\"\n+)\n+\n+var _ = Describe(\"Bucket\", func() {\n+\tvar rootDir, tmpDir string\n+\tvar data = lint.Data{}\n+\n+\tBeforeEach(func() {\n+\t\tif os.Getenv(\"BFSOS_TEST\") == \"\" {\n+\t\t\tSkip(\"test is disabled, enable via BFSOS_TEST\")\n+\t\t}\n+\n+\t\tExpect(os.MkdirAll(tmpRoot, 0755)).To(Succeed())","path":"bfsos/bfsos_test.go","position":31,"original_position":31,"commit_id":"2ffe87d320e2856d61a0ed46a63403af5bc93756","original_commit_id":"2ffe87d320e2856d61a0ed46a63403af5bc93756","user":{"login":"dim","id":16614,"avatar_url":"https://avatars1.githubusercontent.com/u/16614?v=4","gravatar_id":"","url":"https://api.github.com/users/dim","html_url":"https://github.com/dim","followers_url":"https://api.github.com/users/dim/followers","following_url":"https://api.github.com/users/dim/following{/other_user}","gists_url":"https://api.github.com/users/dim/gists{/gist_id}","starred_url":"https://api.github.com/users/dim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dim/subscriptions","organizations_url":"https://api.github.com/users/dim/orgs","repos_url":"https://api.github.com/users/dim/repos","events_url":"https://api.github.com/users/dim/events{/privacy}","received_events_url":"https://api.github.com/users/dim/received_events","type":"User","site_admin":false},"body":"can we do this instead:\r\n\r\n```\r\ntmpRoot, err = ioutil.TempDir(\"\", \"bfsfs\")\r\n...\r\nrootDir = filepath.Join(tmpRoot, \"root\")\r\ntmpDir = filepath.Join(tmpRoot, \"tmp\")\r\n```","created_at":"2018-04-24T17:23:50Z","updated_at":"2018-04-24T17:34:57Z","html_url":"https://github.com/bsm/bfs/pull/1#discussion_r183815722","pull_request_url":"https://api.github.com/repos/bsm/bfs/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/bsm/bfs/pulls/comments/183815722"},"html":{"href":"https://github.com/bsm/bfs/pull/1#discussion_r183815722"},"pull_request":{"href":"https://api.github.com/repos/bsm/bfs/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/bsm/bfs/pulls/1","id":183806273,"html_url":"https://github.com/bsm/bfs/pull/1","diff_url":"https://github.com/bsm/bfs/pull/1.diff","patch_url":"https://github.com/bsm/bfs/pull/1.patch","issue_url":"https://api.github.com/repos/bsm/bfs/issues/1","number":1,"state":"open","locked":false,"title":"bfsos - local file system adapter","user":{"login":"mxmCherry","id":5172338,"avatar_url":"https://avatars1.githubusercontent.com/u/5172338?v=4","gravatar_id":"","url":"https://api.github.com/users/mxmCherry","html_url":"https://github.com/mxmCherry","followers_url":"https://api.github.com/users/mxmCherry/followers","following_url":"https://api.github.com/users/mxmCherry/following{/other_user}","gists_url":"https://api.github.com/users/mxmCherry/gists{/gist_id}","starred_url":"https://api.github.com/users/mxmCherry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxmCherry/subscriptions","organizations_url":"https://api.github.com/users/mxmCherry/orgs","repos_url":"https://api.github.com/users/mxmCherry/repos","events_url":"https://api.github.com/users/mxmCherry/events{/privacy}","received_events_url":"https://api.github.com/users/mxmCherry/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-24T17:14:46Z","updated_at":"2018-04-24T17:34:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"292b4304c58faf5248ac4a705143dbc467d16705","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bsm/bfs/pulls/1/commits","review_comments_url":"https://api.github.com/repos/bsm/bfs/pulls/1/comments","review_comment_url":"https://api.github.com/repos/bsm/bfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bsm/bfs/issues/1/comments","statuses_url":"https://api.github.com/repos/bsm/bfs/statuses/2ffe87d320e2856d61a0ed46a63403af5bc93756","head":{"label":"mxmCherry:feature/bfsos","ref":"feature/bfsos","sha":"2ffe87d320e2856d61a0ed46a63403af5bc93756","user":{"login":"mxmCherry","id":5172338,"avatar_url":"https://avatars1.githubusercontent.com/u/5172338?v=4","gravatar_id":"","url":"https://api.github.com/users/mxmCherry","html_url":"https://github.com/mxmCherry","followers_url":"https://api.github.com/users/mxmCherry/followers","following_url":"https://api.github.com/users/mxmCherry/following{/other_user}","gists_url":"https://api.github.com/users/mxmCherry/gists{/gist_id}","starred_url":"https://api.github.com/users/mxmCherry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxmCherry/subscriptions","organizations_url":"https://api.github.com/users/mxmCherry/orgs","repos_url":"https://api.github.com/users/mxmCherry/repos","events_url":"https://api.github.com/users/mxmCherry/events{/privacy}","received_events_url":"https://api.github.com/users/mxmCherry/received_events","type":"User","site_admin":false},"repo":{"id":130864084,"name":"bfs","full_name":"mxmCherry/bfs","owner":{"login":"mxmCherry","id":5172338,"avatar_url":"https://avatars1.githubusercontent.com/u/5172338?v=4","gravatar_id":"","url":"https://api.github.com/users/mxmCherry","html_url":"https://github.com/mxmCherry","followers_url":"https://api.github.com/users/mxmCherry/followers","following_url":"https://api.github.com/users/mxmCherry/following{/other_user}","gists_url":"https://api.github.com/users/mxmCherry/gists{/gist_id}","starred_url":"https://api.github.com/users/mxmCherry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxmCherry/subscriptions","organizations_url":"https://api.github.com/users/mxmCherry/orgs","repos_url":"https://api.github.com/users/mxmCherry/repos","events_url":"https://api.github.com/users/mxmCherry/events{/privacy}","received_events_url":"https://api.github.com/users/mxmCherry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mxmCherry/bfs","description":"Multi-adapter bucket-based file system abstraction. #golang","fork":true,"url":"https://api.github.com/repos/mxmCherry/bfs","forks_url":"https://api.github.com/repos/mxmCherry/bfs/forks","keys_url":"https://api.github.com/repos/mxmCherry/bfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mxmCherry/bfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mxmCherry/bfs/teams","hooks_url":"https://api.github.com/repos/mxmCherry/bfs/hooks","issue_events_url":"https://api.github.com/repos/mxmCherry/bfs/issues/events{/number}","events_url":"https://api.github.com/repos/mxmCherry/bfs/events","assignees_url":"https://api.github.com/repos/mxmCherry/bfs/assignees{/user}","branches_url":"https://api.github.com/repos/mxmCherry/bfs/branches{/branch}","tags_url":"https://api.github.com/repos/mxmCherry/bfs/tags","blobs_url":"https://api.github.com/repos/mxmCherry/bfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mxmCherry/bfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mxmCherry/bfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mxmCherry/bfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mxmCherry/bfs/statuses/{sha}","languages_url":"https://api.github.com/repos/mxmCherry/bfs/languages","stargazers_url":"https://api.github.com/repos/mxmCherry/bfs/stargazers","contributors_url":"https://api.github.com/repos/mxmCherry/bfs/contributors","subscribers_url":"https://api.github.com/repos/mxmCherry/bfs/subscribers","subscription_url":"https://api.github.com/repos/mxmCherry/bfs/subscription","commits_url":"https://api.github.com/repos/mxmCherry/bfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mxmCherry/bfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mxmCherry/bfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mxmCherry/bfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mxmCherry/bfs/contents/{+path}","compare_url":"https://api.github.com/repos/mxmCherry/bfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mxmCherry/bfs/merges","archive_url":"https://api.github.com/repos/mxmCherry/bfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mxmCherry/bfs/downloads","issues_url":"https://api.github.com/repos/mxmCherry/bfs/issues{/number}","pulls_url":"https://api.github.com/repos/mxmCherry/bfs/pulls{/number}","milestones_url":"https://api.github.com/repos/mxmCherry/bfs/milestones{/number}","notifications_url":"https://api.github.com/repos/mxmCherry/bfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mxmCherry/bfs/labels{/name}","releases_url":"https://api.github.com/repos/mxmCherry/bfs/releases{/id}","deployments_url":"https://api.github.com/repos/mxmCherry/bfs/deployments","created_at":"2018-04-24T14:07:34Z","updated_at":"2018-04-24T14:07:41Z","pushed_at":"2018-04-24T17:13:59Z","git_url":"git://github.com/mxmCherry/bfs.git","ssh_url":"git@github.com:mxmCherry/bfs.git","clone_url":"https://github.com/mxmCherry/bfs.git","svn_url":"https://github.com/mxmCherry/bfs","homepage":null,"size":28,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bsm:master","ref":"master","sha":"a50168de346b223c45c725c6736ad960fc235d79","user":{"login":"bsm","id":260474,"avatar_url":"https://avatars3.githubusercontent.com/u/260474?v=4","gravatar_id":"","url":"https://api.github.com/users/bsm","html_url":"https://github.com/bsm","followers_url":"https://api.github.com/users/bsm/followers","following_url":"https://api.github.com/users/bsm/following{/other_user}","gists_url":"https://api.github.com/users/bsm/gists{/gist_id}","starred_url":"https://api.github.com/users/bsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsm/subscriptions","organizations_url":"https://api.github.com/users/bsm/orgs","repos_url":"https://api.github.com/users/bsm/repos","events_url":"https://api.github.com/users/bsm/events{/privacy}","received_events_url":"https://api.github.com/users/bsm/received_events","type":"User","site_admin":false},"repo":{"id":129373391,"name":"bfs","full_name":"bsm/bfs","owner":{"login":"bsm","id":260474,"avatar_url":"https://avatars3.githubusercontent.com/u/260474?v=4","gravatar_id":"","url":"https://api.github.com/users/bsm","html_url":"https://github.com/bsm","followers_url":"https://api.github.com/users/bsm/followers","following_url":"https://api.github.com/users/bsm/following{/other_user}","gists_url":"https://api.github.com/users/bsm/gists{/gist_id}","starred_url":"https://api.github.com/users/bsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsm/subscriptions","organizations_url":"https://api.github.com/users/bsm/orgs","repos_url":"https://api.github.com/users/bsm/repos","events_url":"https://api.github.com/users/bsm/events{/privacy}","received_events_url":"https://api.github.com/users/bsm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bsm/bfs","description":"Multi-adapter bucket-based file system abstraction. #golang","fork":false,"url":"https://api.github.com/repos/bsm/bfs","forks_url":"https://api.github.com/repos/bsm/bfs/forks","keys_url":"https://api.github.com/repos/bsm/bfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsm/bfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsm/bfs/teams","hooks_url":"https://api.github.com/repos/bsm/bfs/hooks","issue_events_url":"https://api.github.com/repos/bsm/bfs/issues/events{/number}","events_url":"https://api.github.com/repos/bsm/bfs/events","assignees_url":"https://api.github.com/repos/bsm/bfs/assignees{/user}","branches_url":"https://api.github.com/repos/bsm/bfs/branches{/branch}","tags_url":"https://api.github.com/repos/bsm/bfs/tags","blobs_url":"https://api.github.com/repos/bsm/bfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsm/bfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsm/bfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsm/bfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsm/bfs/statuses/{sha}","languages_url":"https://api.github.com/repos/bsm/bfs/languages","stargazers_url":"https://api.github.com/repos/bsm/bfs/stargazers","contributors_url":"https://api.github.com/repos/bsm/bfs/contributors","subscribers_url":"https://api.github.com/repos/bsm/bfs/subscribers","subscription_url":"https://api.github.com/repos/bsm/bfs/subscription","commits_url":"https://api.github.com/repos/bsm/bfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsm/bfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsm/bfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsm/bfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsm/bfs/contents/{+path}","compare_url":"https://api.github.com/repos/bsm/bfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsm/bfs/merges","archive_url":"https://api.github.com/repos/bsm/bfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsm/bfs/downloads","issues_url":"https://api.github.com/repos/bsm/bfs/issues{/number}","pulls_url":"https://api.github.com/repos/bsm/bfs/pulls{/number}","milestones_url":"https://api.github.com/repos/bsm/bfs/milestones{/number}","notifications_url":"https://api.github.com/repos/bsm/bfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsm/bfs/labels{/name}","releases_url":"https://api.github.com/repos/bsm/bfs/releases{/id}","deployments_url":"https://api.github.com/repos/bsm/bfs/deployments","created_at":"2018-04-13T08:33:41Z","updated_at":"2018-04-23T11:44:52Z","pushed_at":"2018-04-24T17:14:46Z","git_url":"git://github.com/bsm/bfs.git","ssh_url":"git@github.com:bsm/bfs.git","clone_url":"https://github.com/bsm/bfs.git","svn_url":"https://github.com/bsm/bfs","homepage":null,"size":24,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bsm/bfs/pulls/1"},"html":{"href":"https://github.com/bsm/bfs/pull/1"},"issue":{"href":"https://api.github.com/repos/bsm/bfs/issues/1"},"comments":{"href":"https://api.github.com/repos/bsm/bfs/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/bsm/bfs/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/bsm/bfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bsm/bfs/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/bsm/bfs/statuses/2ffe87d320e2856d61a0ed46a63403af5bc93756"}},"author_association":"NONE"}}
{"actor":{"display_login":"dim"}}