{"action":"created","issue":{"url":"https://api.github.com/repos/openfaas/openfaas-cloud/issues/177","repository_url":"https://api.github.com/repos/openfaas/openfaas-cloud","labels_url":"https://api.github.com/repos/openfaas/openfaas-cloud/issues/177/labels{/name}","comments_url":"https://api.github.com/repos/openfaas/openfaas-cloud/issues/177/comments","events_url":"https://api.github.com/repos/openfaas/openfaas-cloud/issues/177/events","html_url":"https://github.com/openfaas/openfaas-cloud/pull/177","id":360395489,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NjY0OTE5","number":177,"title":"[WIP] Expose additional metrics","user":{"login":"ivanayov","id":4160133,"node_id":"MDQ6VXNlcjQxNjAxMzM=","avatar_url":"https://avatars3.githubusercontent.com/u/4160133?v=4","gravatar_id":"","url":"https://api.github.com/users/ivanayov","html_url":"https://github.com/ivanayov","followers_url":"https://api.github.com/users/ivanayov/followers","following_url":"https://api.github.com/users/ivanayov/following{/other_user}","gists_url":"https://api.github.com/users/ivanayov/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanayov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanayov/subscriptions","organizations_url":"https://api.github.com/users/ivanayov/orgs","repos_url":"https://api.github.com/users/ivanayov/repos","events_url":"https://api.github.com/users/ivanayov/events{/privacy}","received_events_url":"https://api.github.com/users/ivanayov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-14T17:44:30Z","updated_at":"2018-09-14T17:45:55Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openfaas/openfaas-cloud/pulls/177","html_url":"https://github.com/openfaas/openfaas-cloud/pull/177","diff_url":"https://github.com/openfaas/openfaas-cloud/pull/177.diff","patch_url":"https://github.com/openfaas/openfaas-cloud/pull/177.patch"},"body":"Signed-off-by: Ivana Yovcheva <iyovcheva@vmware.com>\r\nSigned-off-by: Bart Smykla <bsmykla@vmware.com>\r\n\r\n## Description\r\n\r\nThis function gets metricts from Prometheus for the number of\r\n2xx and non 2xx status codes returned after function invocation.\r\nIt prints the result in json format like:\r\n```\r\n{\r\n  success: 35\r\n  failure: 3\r\n}\r\n```\r\n\r\nWork done, but needs review and additional testing.\r\n\r\nResolves #162 \r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n\r\nInvoked with request `http://127.0.0.1:8080/function/test-metrics`, where `test-metrics` was invoked several times, reproducing 2xx and non 2xx status codes.\r\n\r\n## Checklist:\r\n\r\nI have:\r\n\r\n- [ ] updated the documentation if required - TODO\r\n- [x] read the [CONTRIBUTION](https://github.com/openfaas/faas/blob/master/CONTRIBUTING.md) guide\r\n- [x] signed-off my commits with `git commit -s`\r\n- [x] added unit tests"},"comment":{"url":"https://api.github.com/repos/openfaas/openfaas-cloud/issues/comments/421433903","html_url":"https://github.com/openfaas/openfaas-cloud/pull/177#issuecomment-421433903","issue_url":"https://api.github.com/repos/openfaas/openfaas-cloud/issues/177","id":421433903,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTQzMzkwMw==","user":{"login":"ivanayov","id":4160133,"node_id":"MDQ6VXNlcjQxNjAxMzM=","avatar_url":"https://avatars3.githubusercontent.com/u/4160133?v=4","gravatar_id":"","url":"https://api.github.com/users/ivanayov","html_url":"https://github.com/ivanayov","followers_url":"https://api.github.com/users/ivanayov/followers","following_url":"https://api.github.com/users/ivanayov/following{/other_user}","gists_url":"https://api.github.com/users/ivanayov/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanayov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanayov/subscriptions","organizations_url":"https://api.github.com/users/ivanayov/orgs","repos_url":"https://api.github.com/users/ivanayov/repos","events_url":"https://api.github.com/users/ivanayov/events{/privacy}","received_events_url":"https://api.github.com/users/ivanayov/received_events","type":"User","site_admin":false},"created_at":"2018-09-14T17:45:55Z","updated_at":"2018-09-14T17:45:55Z","author_association":"MEMBER","body":"Needs vendor update.\r\nTo simplify review, check only `expose-metrics/` files and `stack.yml`"}}
{"actor":{"display_login":"ivanayov"}}