{"action":"closed","issue":{"url":"https://api.github.com/repos/lando/lando/issues/740","repository_url":"https://api.github.com/repos/lando/lando","labels_url":"https://api.github.com/repos/lando/lando/issues/740/labels{/name}","comments_url":"https://api.github.com/repos/lando/lando/issues/740/comments","events_url":"https://api.github.com/repos/lando/lando/issues/740/events","html_url":"https://github.com/lando/lando/issues/740","id":302553283,"number":740,"title":"How to properly override Lando's base php 7.1 image using .lando.yml","user":{"login":"tylerssn","id":4887071,"avatar_url":"https://avatars0.githubusercontent.com/u/4887071?v=4","gravatar_id":"","url":"https://api.github.com/users/tylerssn","html_url":"https://github.com/tylerssn","followers_url":"https://api.github.com/users/tylerssn/followers","following_url":"https://api.github.com/users/tylerssn/following{/other_user}","gists_url":"https://api.github.com/users/tylerssn/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerssn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerssn/subscriptions","organizations_url":"https://api.github.com/users/tylerssn/orgs","repos_url":"https://api.github.com/users/tylerssn/repos","events_url":"https://api.github.com/users/tylerssn/events{/privacy}","received_events_url":"https://api.github.com/users/tylerssn/received_events","type":"User","site_admin":false},"labels":[{"id":515022119,"url":"https://api.github.com/repos/lando/lando/labels/feature","name":"feature","color":"128A0C","default":false}],"state":"closed","locked":false,"assignee":{"login":"pirog","id":713424,"avatar_url":"https://avatars2.githubusercontent.com/u/713424?v=4","gravatar_id":"","url":"https://api.github.com/users/pirog","html_url":"https://github.com/pirog","followers_url":"https://api.github.com/users/pirog/followers","following_url":"https://api.github.com/users/pirog/following{/other_user}","gists_url":"https://api.github.com/users/pirog/gists{/gist_id}","starred_url":"https://api.github.com/users/pirog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pirog/subscriptions","organizations_url":"https://api.github.com/users/pirog/orgs","repos_url":"https://api.github.com/users/pirog/repos","events_url":"https://api.github.com/users/pirog/events{/privacy}","received_events_url":"https://api.github.com/users/pirog/received_events","type":"User","site_admin":false},"assignees":[{"login":"pirog","id":713424,"avatar_url":"https://avatars2.githubusercontent.com/u/713424?v=4","gravatar_id":"","url":"https://api.github.com/users/pirog","html_url":"https://github.com/pirog","followers_url":"https://api.github.com/users/pirog/followers","following_url":"https://api.github.com/users/pirog/following{/other_user}","gists_url":"https://api.github.com/users/pirog/gists{/gist_id}","starred_url":"https://api.github.com/users/pirog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pirog/subscriptions","organizations_url":"https://api.github.com/users/pirog/orgs","repos_url":"https://api.github.com/users/pirog/repos","events_url":"https://api.github.com/users/pirog/events{/privacy}","received_events_url":"https://api.github.com/users/pirog/received_events","type":"User","site_admin":false},{"login":"dustinleblanc","id":3948808,"avatar_url":"https://avatars3.githubusercontent.com/u/3948808?v=4","gravatar_id":"","url":"https://api.github.com/users/dustinleblanc","html_url":"https://github.com/dustinleblanc","followers_url":"https://api.github.com/users/dustinleblanc/followers","following_url":"https://api.github.com/users/dustinleblanc/following{/other_user}","gists_url":"https://api.github.com/users/dustinleblanc/gists{/gist_id}","starred_url":"https://api.github.com/users/dustinleblanc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dustinleblanc/subscriptions","organizations_url":"https://api.github.com/users/dustinleblanc/orgs","repos_url":"https://api.github.com/users/dustinleblanc/repos","events_url":"https://api.github.com/users/dustinleblanc/events{/privacy}","received_events_url":"https://api.github.com/users/dustinleblanc/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/lando/lando/milestones/14","html_url":"https://github.com/lando/lando/milestone/14","labels_url":"https://api.github.com/repos/lando/lando/milestones/14/labels","id":3307633,"number":14,"title":"3.0.0-beta.45","description":"* Build process changes\r\n* Bug fixes","creator":{"login":"pirog","id":713424,"avatar_url":"https://avatars2.githubusercontent.com/u/713424?v=4","gravatar_id":"","url":"https://api.github.com/users/pirog","html_url":"https://github.com/pirog","followers_url":"https://api.github.com/users/pirog/followers","following_url":"https://api.github.com/users/pirog/following{/other_user}","gists_url":"https://api.github.com/users/pirog/gists{/gist_id}","starred_url":"https://api.github.com/users/pirog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pirog/subscriptions","organizations_url":"https://api.github.com/users/pirog/orgs","repos_url":"https://api.github.com/users/pirog/repos","events_url":"https://api.github.com/users/pirog/events{/privacy}","received_events_url":"https://api.github.com/users/pirog/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":13,"state":"open","created_at":"2018-04-30T04:25:51Z","updated_at":"2018-05-17T03:33:43Z","due_on":"2018-05-11T07:00:00Z","closed_at":null},"comments":7,"created_at":"2018-03-06T03:42:01Z","updated_at":"2018-05-17T03:33:43Z","closed_at":"2018-05-17T03:33:43Z","author_association":"NONE","body":"I am hoping to \"cache\" some of my build steps in a docker image that extends the base Lando PHP 7.1 image. In the past, I have implemented this in Lando by manually building the Dockerfile image and then adding `image: image:tag` to the service override. However, I'd rather point to a Dockerfile  and have Lando perform the build for me.\r\n\r\nI've tried each of the YML configurations below but the `appserver` and `nginx` containers fail to launch. No errors are thrown during the build.\r\n\r\n**What is your lando version and operating system?** *MacOS*\r\n\r\n```yml\r\n#.lando.yml\r\n# --attempt 1\r\n...\r\nservices:\r\n  appserver:\r\n    type: php:7.1\r\n    overrides:\r\n      services:\r\n        build: ${PWD}/dev/lando/dockerfiles/appserver\r\n        image: php:7.1\r\n...\r\n```\r\n\r\n```yml\r\n#.lando.yml\r\n# --attempt 2\r\n...\r\nservices:\r\n  appserver:\r\n    type: php:7.1\r\n    overrides:\r\n      services:\r\n        build: ${PWD}/dev/lando/dockerfiles/appserver \r\n...\r\n```\r\n```yml\r\n#.lando.yml\r\n# --attempt 3\r\n...\r\nservices:\r\n  appserver:\r\n    type: php:7.1\r\n    overrides:\r\n      services:\r\n        build:\r\n          context: ${PWD}/dev/lando/dockerfiles/appserver\r\n...\r\n```\r\n\r\n```dockerfile\r\n# dev/lando/dockerfiles/appserver/Dockerfile\r\nFROM devwithlando/php:7.1-fpm\r\n\r\nRUN apt-get -yqq update\r\n\r\n##########\r\n# PHP-INTL - OroCommerce Dependencies\r\n# Lando ships with INTL but we need a more recent version\r\nRUN apt-get -yqq install zlib1g-dev libicu-dev g++\r\n\r\nRUN curl -sS -o /tmp/icu.tar.gz -L http://download.icu-project.org/files/icu4c/57.1/icu4c-57_1-src.tgz \\\r\n    && tar -zxf /tmp/icu.tar.gz -C /tmp \\\r\n    && cd /tmp/icu/source \\\r\n    && ./configure --prefix=/usr/local \\\r\n    && make \\\r\n    && make install\r\n\r\nRUN docker-php-ext-configure intl --with-icu-dir=/usr/local\r\nRUN docker-php-ext-install intl\r\n\r\n##########\r\n# PHP-TIDY - OroCommerce Dependencies\r\nRUN apt-get -yqq install libtidy-dev\r\nRUN docker-php-ext-install tidy\r\nRUN docker-php-ext-enable tidy\r\n```"}}
{"actor":{"display_login":"pirog"}}