{"action":"created","issue":{"url":"https://api.github.com/repos/strongbox/strongbox/issues/660","repository_url":"https://api.github.com/repos/strongbox/strongbox","labels_url":"https://api.github.com/repos/strongbox/strongbox/issues/660/labels{/name}","comments_url":"https://api.github.com/repos/strongbox/strongbox/issues/660/comments","events_url":"https://api.github.com/repos/strongbox/strongbox/issues/660/events","html_url":"https://github.com/strongbox/strongbox/issues/660","id":307813994,"number":660,"title":"Refactor the UserController to use form validation and return proper responses on failed validation","user":{"login":"steve-todorov","id":2303663,"avatar_url":"https://avatars1.githubusercontent.com/u/2303663?v=4","gravatar_id":"","url":"https://api.github.com/users/steve-todorov","html_url":"https://github.com/steve-todorov","followers_url":"https://api.github.com/users/steve-todorov/followers","following_url":"https://api.github.com/users/steve-todorov/following{/other_user}","gists_url":"https://api.github.com/users/steve-todorov/gists{/gist_id}","starred_url":"https://api.github.com/users/steve-todorov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steve-todorov/subscriptions","organizations_url":"https://api.github.com/users/steve-todorov/orgs","repos_url":"https://api.github.com/users/steve-todorov/repos","events_url":"https://api.github.com/users/steve-todorov/events{/privacy}","received_events_url":"https://api.github.com/users/steve-todorov/received_events","type":"User","site_admin":false},"labels":[{"id":50354934,"url":"https://api.github.com/repos/strongbox/strongbox/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":728531994,"url":"https://api.github.com/repos/strongbox/strongbox/labels/good%20first%20issue","name":"good first issue","color":"856bf9","default":true},{"id":728532179,"url":"https://api.github.com/repos/strongbox/strongbox/labels/help%20wanted","name":"help wanted","color":"1aba09","default":true}],"state":"open","locked":false,"assignee":{"login":"ptirador","id":6933533,"avatar_url":"https://avatars1.githubusercontent.com/u/6933533?v=4","gravatar_id":"","url":"https://api.github.com/users/ptirador","html_url":"https://github.com/ptirador","followers_url":"https://api.github.com/users/ptirador/followers","following_url":"https://api.github.com/users/ptirador/following{/other_user}","gists_url":"https://api.github.com/users/ptirador/gists{/gist_id}","starred_url":"https://api.github.com/users/ptirador/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptirador/subscriptions","organizations_url":"https://api.github.com/users/ptirador/orgs","repos_url":"https://api.github.com/users/ptirador/repos","events_url":"https://api.github.com/users/ptirador/events{/privacy}","received_events_url":"https://api.github.com/users/ptirador/received_events","type":"User","site_admin":false},"assignees":[{"login":"ptirador","id":6933533,"avatar_url":"https://avatars1.githubusercontent.com/u/6933533?v=4","gravatar_id":"","url":"https://api.github.com/users/ptirador","html_url":"https://github.com/ptirador","followers_url":"https://api.github.com/users/ptirador/followers","following_url":"https://api.github.com/users/ptirador/following{/other_user}","gists_url":"https://api.github.com/users/ptirador/gists{/gist_id}","starred_url":"https://api.github.com/users/ptirador/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptirador/subscriptions","organizations_url":"https://api.github.com/users/ptirador/orgs","repos_url":"https://api.github.com/users/ptirador/repos","events_url":"https://api.github.com/users/ptirador/events{/privacy}","received_events_url":"https://api.github.com/users/ptirador/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2018-03-22T21:03:44Z","updated_at":"2018-03-30T17:06:15Z","closed_at":null,"author_association":"OWNER","body":"The `UserController` needs to be refactored so that it uses spring form validation. Also, make sure that the controller returns the proper responses according to the [How-To-Implement-Spring-Controllers](https://github.com/strongbox/strongbox/wiki/How-To-Implement-Spring-Controllers) when there is an error in the validation. "},"comment":{"url":"https://api.github.com/repos/strongbox/strongbox/issues/comments/377571852","html_url":"https://github.com/strongbox/strongbox/issues/660#issuecomment-377571852","issue_url":"https://api.github.com/repos/strongbox/strongbox/issues/660","id":377571852,"user":{"login":"carlspring","id":1436265,"avatar_url":"https://avatars3.githubusercontent.com/u/1436265?v=4","gravatar_id":"","url":"https://api.github.com/users/carlspring","html_url":"https://github.com/carlspring","followers_url":"https://api.github.com/users/carlspring/followers","following_url":"https://api.github.com/users/carlspring/following{/other_user}","gists_url":"https://api.github.com/users/carlspring/gists{/gist_id}","starred_url":"https://api.github.com/users/carlspring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlspring/subscriptions","organizations_url":"https://api.github.com/users/carlspring/orgs","repos_url":"https://api.github.com/users/carlspring/repos","events_url":"https://api.github.com/users/carlspring/events{/privacy}","received_events_url":"https://api.github.com/users/carlspring/received_events","type":"User","site_admin":false},"created_at":"2018-03-30T17:06:15Z","updated_at":"2018-03-30T17:06:15Z","author_association":"OWNER","body":"@ptirador ,\r\n\r\nYes, you are right. There are the also these follow-up issues:\r\n* There's `org.carlspring.strongbox.security.User` and `org.carlspring.strongbox.users.domain.User`, vs. `org.carlspring.strongbox.controllers.users.UserInput`. I think there is some duplication here that needs to be sorted out. I don't personally support the idea of having multiple classes with the same name under the same project. I think that some one of the `User` classes needs to be removed, or merged into, or replaced by the `UserInput` class. Perhaps I'm missing something here...? @fuss86 / @sbespalov : What are your thoughts on this?\r\n* There's `org.carlspring.strongbox.security.Users` which I would say should also be removed. @ptirador : Would you like to look into this?\r\n"}}
{"actor":{"display_login":"carlspring"}}