{"action":"created","comment":{"url":"https://api.github.com/repos/lightbend/fdp-sample-applications/pulls/comments/226383144","pull_request_review_id":166190861,"id":226383144,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjM4MzE0NA==","diff_hunk":"@@ -348,11 +348,11 @@ $ helm install --name kstream ./helm\n $ kubectl logs <pod name where the application runs>\n ```\n \n-Same technique can be used to deploy all the sample applications in Kubernetes.\n+Same technique can be used to deploy all the sample applications in Kubernetes or OpenShift.\n \n ### Using the traefik Ingress Controller\n \n-`kstream` application publishes a REST end point and allows users to query on various application state information. In Kubernetes this can be done in a way so that the user gets one fixed end point irrespective of the ways the underlying PODs are distributed across the cluster. Even in case of PODs getting restarted on a different node, it would be great to still have the fixed end point. We use the traefik ingress controller for this.\n+`kstream` application publishes a REST end point and allows users to query on various application state information. In Kubernetes or OpenShift this can be done in a way so that the user gets one fixed end point irrespective of the ways the underlying PODs are distributed across the cluster. Even in case of PODs getting restarted on a different node, it would be great to still have the fixed end point. We use the traefik ingress controller for this.\n \n > Ensure that the traefik ingress controller is installed in the cluster. Check that the dashboard is accessible through some end points like http://<public agent IP>:9901/dashboard/","path":"apps/kstream/README.md","position":27,"original_position":27,"commit_id":"de30f7f54b43a82a7180fc2984882586e75f0e50","original_commit_id":"de30f7f54b43a82a7180fc2984882586e75f0e50","user":{"login":"blublinsky","id":25286171,"node_id":"MDQ6VXNlcjI1Mjg2MTcx","avatar_url":"https://avatars3.githubusercontent.com/u/25286171?v=4","gravatar_id":"","url":"https://api.github.com/users/blublinsky","html_url":"https://github.com/blublinsky","followers_url":"https://api.github.com/users/blublinsky/followers","following_url":"https://api.github.com/users/blublinsky/following{/other_user}","gists_url":"https://api.github.com/users/blublinsky/gists{/gist_id}","starred_url":"https://api.github.com/users/blublinsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blublinsky/subscriptions","organizations_url":"https://api.github.com/users/blublinsky/orgs","repos_url":"https://api.github.com/users/blublinsky/repos","events_url":"https://api.github.com/users/blublinsky/events{/privacy}","received_events_url":"https://api.github.com/users/blublinsky/received_events","type":"User","site_admin":false},"body":"I think we want to remove this and write something like:\r\nTo expose service on kubernetes use Ingress (on vanila kubernetes) or Route (on OpenShift)","created_at":"2018-10-18T16:46:20Z","updated_at":"2018-10-18T16:51:26Z","html_url":"https://github.com/lightbend/fdp-sample-applications/pull/11#discussion_r226383144","pull_request_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/pulls/11","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/lightbend/fdp-sample-applications/pulls/comments/226383144"},"html":{"href":"https://github.com/lightbend/fdp-sample-applications/pull/11#discussion_r226383144"},"pull_request":{"href":"https://api.github.com/repos/lightbend/fdp-sample-applications/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/lightbend/fdp-sample-applications/pulls/11","id":224015402,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MDE1NDAy","html_url":"https://github.com/lightbend/fdp-sample-applications/pull/11","diff_url":"https://github.com/lightbend/fdp-sample-applications/pull/11.diff","patch_url":"https://github.com/lightbend/fdp-sample-applications/pull/11.patch","issue_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/issues/11","number":11,"state":"open","locked":false,"title":"Improved the documentation on using Kubernetes or OpenShift.","user":{"login":"deanwampler","id":3991,"node_id":"MDQ6VXNlcjM5OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/3991?v=4","gravatar_id":"","url":"https://api.github.com/users/deanwampler","html_url":"https://github.com/deanwampler","followers_url":"https://api.github.com/users/deanwampler/followers","following_url":"https://api.github.com/users/deanwampler/following{/other_user}","gists_url":"https://api.github.com/users/deanwampler/gists{/gist_id}","starred_url":"https://api.github.com/users/deanwampler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deanwampler/subscriptions","organizations_url":"https://api.github.com/users/deanwampler/orgs","repos_url":"https://api.github.com/users/deanwampler/repos","events_url":"https://api.github.com/users/deanwampler/events{/privacy}","received_events_url":"https://api.github.com/users/deanwampler/received_events","type":"User","site_admin":false},"body":"No changes to KillrWeather, as Boris is working a PR for it.","created_at":"2018-10-18T16:09:50Z","updated_at":"2018-10-18T16:51:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b30d09fba6859deb0e001dd0efed82bfee1c6c46","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/pulls/11/commits","review_comments_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/pulls/11/comments","review_comment_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/issues/11/comments","statuses_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/statuses/de30f7f54b43a82a7180fc2984882586e75f0e50","head":{"label":"lightbend:deanw-k8s-improvements","ref":"deanw-k8s-improvements","sha":"de30f7f54b43a82a7180fc2984882586e75f0e50","user":{"login":"lightbend","id":16247783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjQ3Nzgz","avatar_url":"https://avatars3.githubusercontent.com/u/16247783?v=4","gravatar_id":"","url":"https://api.github.com/users/lightbend","html_url":"https://github.com/lightbend","followers_url":"https://api.github.com/users/lightbend/followers","following_url":"https://api.github.com/users/lightbend/following{/other_user}","gists_url":"https://api.github.com/users/lightbend/gists{/gist_id}","starred_url":"https://api.github.com/users/lightbend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightbend/subscriptions","organizations_url":"https://api.github.com/users/lightbend/orgs","repos_url":"https://api.github.com/users/lightbend/repos","events_url":"https://api.github.com/users/lightbend/events{/privacy}","received_events_url":"https://api.github.com/users/lightbend/received_events","type":"Organization","site_admin":false},"repo":{"id":143271819,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyNzE4MTk=","name":"fdp-sample-applications","full_name":"lightbend/fdp-sample-applications","private":false,"owner":{"login":"lightbend","id":16247783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjQ3Nzgz","avatar_url":"https://avatars3.githubusercontent.com/u/16247783?v=4","gravatar_id":"","url":"https://api.github.com/users/lightbend","html_url":"https://github.com/lightbend","followers_url":"https://api.github.com/users/lightbend/followers","following_url":"https://api.github.com/users/lightbend/following{/other_user}","gists_url":"https://api.github.com/users/lightbend/gists{/gist_id}","starred_url":"https://api.github.com/users/lightbend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightbend/subscriptions","organizations_url":"https://api.github.com/users/lightbend/orgs","repos_url":"https://api.github.com/users/lightbend/repos","events_url":"https://api.github.com/users/lightbend/events{/privacy}","received_events_url":"https://api.github.com/users/lightbend/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lightbend/fdp-sample-applications","description":"All sample applications for Fast Data Platform","fork":false,"url":"https://api.github.com/repos/lightbend/fdp-sample-applications","forks_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/forks","keys_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/teams","hooks_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/hooks","issue_events_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/issues/events{/number}","events_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/events","assignees_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/assignees{/user}","branches_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/branches{/branch}","tags_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/tags","blobs_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/git/refs{/sha}","trees_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/statuses/{sha}","languages_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/languages","stargazers_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/stargazers","contributors_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/contributors","subscribers_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/subscribers","subscription_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/subscription","commits_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/commits{/sha}","git_commits_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/git/commits{/sha}","comments_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/comments{/number}","issue_comment_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/issues/comments{/number}","contents_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/contents/{+path}","compare_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/merges","archive_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/downloads","issues_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/issues{/number}","pulls_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/pulls{/number}","milestones_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/milestones{/number}","notifications_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/labels{/name}","releases_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/releases{/id}","deployments_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/deployments","created_at":"2018-08-02T09:19:59Z","updated_at":"2018-10-18T04:00:14Z","pushed_at":"2018-10-18T16:09:50Z","git_url":"git://github.com/lightbend/fdp-sample-applications.git","ssh_url":"git@github.com:lightbend/fdp-sample-applications.git","clone_url":"https://github.com/lightbend/fdp-sample-applications.git","svn_url":"https://github.com/lightbend/fdp-sample-applications","homepage":null,"size":58249,"stargazers_count":7,"watchers_count":7,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":2,"watchers":7,"default_branch":"develop"}},"base":{"label":"lightbend:develop","ref":"develop","sha":"d49957375924934356b79306d9471605028d82a5","user":{"login":"lightbend","id":16247783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjQ3Nzgz","avatar_url":"https://avatars3.githubusercontent.com/u/16247783?v=4","gravatar_id":"","url":"https://api.github.com/users/lightbend","html_url":"https://github.com/lightbend","followers_url":"https://api.github.com/users/lightbend/followers","following_url":"https://api.github.com/users/lightbend/following{/other_user}","gists_url":"https://api.github.com/users/lightbend/gists{/gist_id}","starred_url":"https://api.github.com/users/lightbend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightbend/subscriptions","organizations_url":"https://api.github.com/users/lightbend/orgs","repos_url":"https://api.github.com/users/lightbend/repos","events_url":"https://api.github.com/users/lightbend/events{/privacy}","received_events_url":"https://api.github.com/users/lightbend/received_events","type":"Organization","site_admin":false},"repo":{"id":143271819,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyNzE4MTk=","name":"fdp-sample-applications","full_name":"lightbend/fdp-sample-applications","private":false,"owner":{"login":"lightbend","id":16247783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjQ3Nzgz","avatar_url":"https://avatars3.githubusercontent.com/u/16247783?v=4","gravatar_id":"","url":"https://api.github.com/users/lightbend","html_url":"https://github.com/lightbend","followers_url":"https://api.github.com/users/lightbend/followers","following_url":"https://api.github.com/users/lightbend/following{/other_user}","gists_url":"https://api.github.com/users/lightbend/gists{/gist_id}","starred_url":"https://api.github.com/users/lightbend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightbend/subscriptions","organizations_url":"https://api.github.com/users/lightbend/orgs","repos_url":"https://api.github.com/users/lightbend/repos","events_url":"https://api.github.com/users/lightbend/events{/privacy}","received_events_url":"https://api.github.com/users/lightbend/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lightbend/fdp-sample-applications","description":"All sample applications for Fast Data Platform","fork":false,"url":"https://api.github.com/repos/lightbend/fdp-sample-applications","forks_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/forks","keys_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/teams","hooks_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/hooks","issue_events_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/issues/events{/number}","events_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/events","assignees_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/assignees{/user}","branches_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/branches{/branch}","tags_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/tags","blobs_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/git/refs{/sha}","trees_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/statuses/{sha}","languages_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/languages","stargazers_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/stargazers","contributors_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/contributors","subscribers_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/subscribers","subscription_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/subscription","commits_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/commits{/sha}","git_commits_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/git/commits{/sha}","comments_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/comments{/number}","issue_comment_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/issues/comments{/number}","contents_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/contents/{+path}","compare_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/merges","archive_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/downloads","issues_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/issues{/number}","pulls_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/pulls{/number}","milestones_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/milestones{/number}","notifications_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/labels{/name}","releases_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/releases{/id}","deployments_url":"https://api.github.com/repos/lightbend/fdp-sample-applications/deployments","created_at":"2018-08-02T09:19:59Z","updated_at":"2018-10-18T04:00:14Z","pushed_at":"2018-10-18T16:09:50Z","git_url":"git://github.com/lightbend/fdp-sample-applications.git","ssh_url":"git@github.com:lightbend/fdp-sample-applications.git","clone_url":"https://github.com/lightbend/fdp-sample-applications.git","svn_url":"https://github.com/lightbend/fdp-sample-applications","homepage":null,"size":58249,"stargazers_count":7,"watchers_count":7,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":2,"watchers":7,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/lightbend/fdp-sample-applications/pulls/11"},"html":{"href":"https://github.com/lightbend/fdp-sample-applications/pull/11"},"issue":{"href":"https://api.github.com/repos/lightbend/fdp-sample-applications/issues/11"},"comments":{"href":"https://api.github.com/repos/lightbend/fdp-sample-applications/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/lightbend/fdp-sample-applications/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/lightbend/fdp-sample-applications/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lightbend/fdp-sample-applications/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/lightbend/fdp-sample-applications/statuses/de30f7f54b43a82a7180fc2984882586e75f0e50"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"blublinsky"}}