{"action":"created","comment":{"url":"https://api.github.com/repos/exercism/go/pulls/comments/230544532","pull_request_review_id":171315843,"id":230544532,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDU0NDUzMg==","diff_hunk":"@@ -46,12 +70,14 @@ var testCases = []struct {\n \tslice\t\t[]int\n \tkey\t\tint\n \tx\tint\n+\terr\tstring\n }{ {{range .J.Cases}}\n {\n \tdescription:\t{{printf \"%q\"  .Description}},\n \tslice:\t\t{{printf \"%#v\" .Input.Array}},\n \tkey:\t\t{{printf \"%d\"  .Input.Value}},\n-\tx:\t{{printf \"%d\"  .Expected}},\n+\tx:\t{{printf \"%d\"  .Expected.ValueInt}},\n+\terr:\t{{printf \"%q\"  .Expected.ValueString}},","path":"exercises/binary-search/.meta/gen.go","position":52,"original_position":52,"commit_id":"ce662d279bbe753b8d8c2d6010322d8da729390b","original_commit_id":"ce662d279bbe753b8d8c2d6010322d8da729390b","user":{"login":"leenipper","id":17682173,"node_id":"MDQ6VXNlcjE3NjgyMTcz","avatar_url":"https://avatars2.githubusercontent.com/u/17682173?v=4","gravatar_id":"","url":"https://api.github.com/users/leenipper","html_url":"https://github.com/leenipper","followers_url":"https://api.github.com/users/leenipper/followers","following_url":"https://api.github.com/users/leenipper/following{/other_user}","gists_url":"https://api.github.com/users/leenipper/gists{/gist_id}","starred_url":"https://api.github.com/users/leenipper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leenipper/subscriptions","organizations_url":"https://api.github.com/users/leenipper/orgs","repos_url":"https://api.github.com/users/leenipper/repos","events_url":"https://api.github.com/users/leenipper/events{/privacy}","received_events_url":"https://api.github.com/users/leenipper/received_events","type":"User","site_admin":false},"body":"Perhaps align the {{printf ...   using tabs.  The template text string isn't subject to 'go fmt', but it looks better aligned (to me at least).  Maybe also the types for x, and err within the struct above.","created_at":"2018-11-03T04:09:23Z","updated_at":"2018-11-03T04:16:28Z","html_url":"https://github.com/exercism/go/pull/1169#discussion_r230544532","pull_request_url":"https://api.github.com/repos/exercism/go/pulls/1169","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/exercism/go/pulls/comments/230544532"},"html":{"href":"https://github.com/exercism/go/pull/1169#discussion_r230544532"},"pull_request":{"href":"https://api.github.com/repos/exercism/go/pulls/1169"}}},"pull_request":{"url":"https://api.github.com/repos/exercism/go/pulls/1169","id":220056966,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMDU2OTY2","html_url":"https://github.com/exercism/go/pull/1169","diff_url":"https://github.com/exercism/go/pull/1169.diff","patch_url":"https://github.com/exercism/go/pull/1169.patch","issue_url":"https://api.github.com/repos/exercism/go/issues/1169","number":1169,"state":"open","locked":false,"title":"binary-search: update generator to align with upstream problem-specifications","user":{"login":"ilmanzo","id":1872816,"node_id":"MDQ6VXNlcjE4NzI4MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1872816?v=4","gravatar_id":"","url":"https://api.github.com/users/ilmanzo","html_url":"https://github.com/ilmanzo","followers_url":"https://api.github.com/users/ilmanzo/followers","following_url":"https://api.github.com/users/ilmanzo/following{/other_user}","gists_url":"https://api.github.com/users/ilmanzo/gists{/gist_id}","starred_url":"https://api.github.com/users/ilmanzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilmanzo/subscriptions","organizations_url":"https://api.github.com/users/ilmanzo/orgs","repos_url":"https://api.github.com/users/ilmanzo/repos","events_url":"https://api.github.com/users/ilmanzo/events{/privacy}","received_events_url":"https://api.github.com/users/ilmanzo/received_events","type":"User","site_admin":false},"body":"since from [last commit](https://github.com/exercism/problem-specifications/commit/e0ffb0085591467aa946962310d3da6fbbbf9483) the json has changed format, we'd need to manage the 'expected' field both as a value and as an error object. For now I'd keep the old format , adding just an extra 'error' field to the test suite.","created_at":"2018-10-03T14:23:58Z","updated_at":"2018-11-03T04:16:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c7ca9c3cded721cfbcfcea20f21e4e61462e422","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/exercism/go/pulls/1169/commits","review_comments_url":"https://api.github.com/repos/exercism/go/pulls/1169/comments","review_comment_url":"https://api.github.com/repos/exercism/go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exercism/go/issues/1169/comments","statuses_url":"https://api.github.com/repos/exercism/go/statuses/ce662d279bbe753b8d8c2d6010322d8da729390b","head":{"label":"ilmanzo:binary-search","ref":"binary-search","sha":"ce662d279bbe753b8d8c2d6010322d8da729390b","user":{"login":"ilmanzo","id":1872816,"node_id":"MDQ6VXNlcjE4NzI4MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1872816?v=4","gravatar_id":"","url":"https://api.github.com/users/ilmanzo","html_url":"https://github.com/ilmanzo","followers_url":"https://api.github.com/users/ilmanzo/followers","following_url":"https://api.github.com/users/ilmanzo/following{/other_user}","gists_url":"https://api.github.com/users/ilmanzo/gists{/gist_id}","starred_url":"https://api.github.com/users/ilmanzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilmanzo/subscriptions","organizations_url":"https://api.github.com/users/ilmanzo/orgs","repos_url":"https://api.github.com/users/ilmanzo/repos","events_url":"https://api.github.com/users/ilmanzo/events{/privacy}","received_events_url":"https://api.github.com/users/ilmanzo/received_events","type":"User","site_admin":false},"repo":{"id":118275557,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgyNzU1NTc=","name":"go","full_name":"ilmanzo/go","private":false,"owner":{"login":"ilmanzo","id":1872816,"node_id":"MDQ6VXNlcjE4NzI4MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1872816?v=4","gravatar_id":"","url":"https://api.github.com/users/ilmanzo","html_url":"https://github.com/ilmanzo","followers_url":"https://api.github.com/users/ilmanzo/followers","following_url":"https://api.github.com/users/ilmanzo/following{/other_user}","gists_url":"https://api.github.com/users/ilmanzo/gists{/gist_id}","starred_url":"https://api.github.com/users/ilmanzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilmanzo/subscriptions","organizations_url":"https://api.github.com/users/ilmanzo/orgs","repos_url":"https://api.github.com/users/ilmanzo/repos","events_url":"https://api.github.com/users/ilmanzo/events{/privacy}","received_events_url":"https://api.github.com/users/ilmanzo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ilmanzo/go","description":"Exercism exercises in Go.","fork":true,"url":"https://api.github.com/repos/ilmanzo/go","forks_url":"https://api.github.com/repos/ilmanzo/go/forks","keys_url":"https://api.github.com/repos/ilmanzo/go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ilmanzo/go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ilmanzo/go/teams","hooks_url":"https://api.github.com/repos/ilmanzo/go/hooks","issue_events_url":"https://api.github.com/repos/ilmanzo/go/issues/events{/number}","events_url":"https://api.github.com/repos/ilmanzo/go/events","assignees_url":"https://api.github.com/repos/ilmanzo/go/assignees{/user}","branches_url":"https://api.github.com/repos/ilmanzo/go/branches{/branch}","tags_url":"https://api.github.com/repos/ilmanzo/go/tags","blobs_url":"https://api.github.com/repos/ilmanzo/go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ilmanzo/go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ilmanzo/go/git/refs{/sha}","trees_url":"https://api.github.com/repos/ilmanzo/go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ilmanzo/go/statuses/{sha}","languages_url":"https://api.github.com/repos/ilmanzo/go/languages","stargazers_url":"https://api.github.com/repos/ilmanzo/go/stargazers","contributors_url":"https://api.github.com/repos/ilmanzo/go/contributors","subscribers_url":"https://api.github.com/repos/ilmanzo/go/subscribers","subscription_url":"https://api.github.com/repos/ilmanzo/go/subscription","commits_url":"https://api.github.com/repos/ilmanzo/go/commits{/sha}","git_commits_url":"https://api.github.com/repos/ilmanzo/go/git/commits{/sha}","comments_url":"https://api.github.com/repos/ilmanzo/go/comments{/number}","issue_comment_url":"https://api.github.com/repos/ilmanzo/go/issues/comments{/number}","contents_url":"https://api.github.com/repos/ilmanzo/go/contents/{+path}","compare_url":"https://api.github.com/repos/ilmanzo/go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ilmanzo/go/merges","archive_url":"https://api.github.com/repos/ilmanzo/go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ilmanzo/go/downloads","issues_url":"https://api.github.com/repos/ilmanzo/go/issues{/number}","pulls_url":"https://api.github.com/repos/ilmanzo/go/pulls{/number}","milestones_url":"https://api.github.com/repos/ilmanzo/go/milestones{/number}","notifications_url":"https://api.github.com/repos/ilmanzo/go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ilmanzo/go/labels{/name}","releases_url":"https://api.github.com/repos/ilmanzo/go/releases{/id}","deployments_url":"https://api.github.com/repos/ilmanzo/go/deployments","created_at":"2018-01-20T19:51:17Z","updated_at":"2018-10-06T15:39:59Z","pushed_at":"2018-10-06T15:39:57Z","git_url":"git://github.com/ilmanzo/go.git","ssh_url":"git@github.com:ilmanzo/go.git","clone_url":"https://github.com/ilmanzo/go.git","svn_url":"https://github.com/ilmanzo/go","homepage":"http://exercism.io/languages/go","size":2691,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"exercism:master","ref":"master","sha":"eae040ff95b7eee1be8edbabdf5e175d5ddf6475","user":{"login":"exercism","id":5624255,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2MjQyNTU=","avatar_url":"https://avatars0.githubusercontent.com/u/5624255?v=4","gravatar_id":"","url":"https://api.github.com/users/exercism","html_url":"https://github.com/exercism","followers_url":"https://api.github.com/users/exercism/followers","following_url":"https://api.github.com/users/exercism/following{/other_user}","gists_url":"https://api.github.com/users/exercism/gists{/gist_id}","starred_url":"https://api.github.com/users/exercism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exercism/subscriptions","organizations_url":"https://api.github.com/users/exercism/orgs","repos_url":"https://api.github.com/users/exercism/repos","events_url":"https://api.github.com/users/exercism/events{/privacy}","received_events_url":"https://api.github.com/users/exercism/received_events","type":"Organization","site_admin":false},"repo":{"id":17273223,"node_id":"MDEwOlJlcG9zaXRvcnkxNzI3MzIyMw==","name":"go","full_name":"exercism/go","private":false,"owner":{"login":"exercism","id":5624255,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2MjQyNTU=","avatar_url":"https://avatars0.githubusercontent.com/u/5624255?v=4","gravatar_id":"","url":"https://api.github.com/users/exercism","html_url":"https://github.com/exercism","followers_url":"https://api.github.com/users/exercism/followers","following_url":"https://api.github.com/users/exercism/following{/other_user}","gists_url":"https://api.github.com/users/exercism/gists{/gist_id}","starred_url":"https://api.github.com/users/exercism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exercism/subscriptions","organizations_url":"https://api.github.com/users/exercism/orgs","repos_url":"https://api.github.com/users/exercism/repos","events_url":"https://api.github.com/users/exercism/events{/privacy}","received_events_url":"https://api.github.com/users/exercism/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/exercism/go","description":"Exercism exercises in Go.","fork":false,"url":"https://api.github.com/repos/exercism/go","forks_url":"https://api.github.com/repos/exercism/go/forks","keys_url":"https://api.github.com/repos/exercism/go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exercism/go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exercism/go/teams","hooks_url":"https://api.github.com/repos/exercism/go/hooks","issue_events_url":"https://api.github.com/repos/exercism/go/issues/events{/number}","events_url":"https://api.github.com/repos/exercism/go/events","assignees_url":"https://api.github.com/repos/exercism/go/assignees{/user}","branches_url":"https://api.github.com/repos/exercism/go/branches{/branch}","tags_url":"https://api.github.com/repos/exercism/go/tags","blobs_url":"https://api.github.com/repos/exercism/go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exercism/go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exercism/go/git/refs{/sha}","trees_url":"https://api.github.com/repos/exercism/go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exercism/go/statuses/{sha}","languages_url":"https://api.github.com/repos/exercism/go/languages","stargazers_url":"https://api.github.com/repos/exercism/go/stargazers","contributors_url":"https://api.github.com/repos/exercism/go/contributors","subscribers_url":"https://api.github.com/repos/exercism/go/subscribers","subscription_url":"https://api.github.com/repos/exercism/go/subscription","commits_url":"https://api.github.com/repos/exercism/go/commits{/sha}","git_commits_url":"https://api.github.com/repos/exercism/go/git/commits{/sha}","comments_url":"https://api.github.com/repos/exercism/go/comments{/number}","issue_comment_url":"https://api.github.com/repos/exercism/go/issues/comments{/number}","contents_url":"https://api.github.com/repos/exercism/go/contents/{+path}","compare_url":"https://api.github.com/repos/exercism/go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exercism/go/merges","archive_url":"https://api.github.com/repos/exercism/go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exercism/go/downloads","issues_url":"https://api.github.com/repos/exercism/go/issues{/number}","pulls_url":"https://api.github.com/repos/exercism/go/pulls{/number}","milestones_url":"https://api.github.com/repos/exercism/go/milestones{/number}","notifications_url":"https://api.github.com/repos/exercism/go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exercism/go/labels{/name}","releases_url":"https://api.github.com/repos/exercism/go/releases{/id}","deployments_url":"https://api.github.com/repos/exercism/go/deployments","created_at":"2014-02-28T02:51:19Z","updated_at":"2018-11-01T23:42:29Z","pushed_at":"2018-11-02T04:24:18Z","git_url":"git://github.com/exercism/go.git","ssh_url":"git@github.com:exercism/go.git","clone_url":"https://github.com/exercism/go.git","svn_url":"https://github.com/exercism/go","homepage":"http://exercism.io/languages/go","size":2698,"stargazers_count":317,"watchers_count":317,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":197,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":197,"open_issues":33,"watchers":317,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/exercism/go/pulls/1169"},"html":{"href":"https://github.com/exercism/go/pull/1169"},"issue":{"href":"https://api.github.com/repos/exercism/go/issues/1169"},"comments":{"href":"https://api.github.com/repos/exercism/go/issues/1169/comments"},"review_comments":{"href":"https://api.github.com/repos/exercism/go/pulls/1169/comments"},"review_comment":{"href":"https://api.github.com/repos/exercism/go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exercism/go/pulls/1169/commits"},"statuses":{"href":"https://api.github.com/repos/exercism/go/statuses/ce662d279bbe753b8d8c2d6010322d8da729390b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"leenipper"}}