{"action":"created","issue":{"url":"https://api.github.com/repos/openssl/openssl/issues/7130","repository_url":"https://api.github.com/repos/openssl/openssl","labels_url":"https://api.github.com/repos/openssl/openssl/issues/7130/labels{/name}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/7130/comments","events_url":"https://api.github.com/repos/openssl/openssl/issues/7130/events","html_url":"https://github.com/openssl/openssl/issues/7130","id":357493205,"node_id":"MDU6SXNzdWUzNTc0OTMyMDU=","number":7130,"title":"Remove the NULL checks of function parameters","user":{"login":"InfoHunter","id":799430,"node_id":"MDQ6VXNlcjc5OTQzMA==","avatar_url":"https://avatars3.githubusercontent.com/u/799430?v=4","gravatar_id":"","url":"https://api.github.com/users/InfoHunter","html_url":"https://github.com/InfoHunter","followers_url":"https://api.github.com/users/InfoHunter/followers","following_url":"https://api.github.com/users/InfoHunter/following{/other_user}","gists_url":"https://api.github.com/users/InfoHunter/gists{/gist_id}","starred_url":"https://api.github.com/users/InfoHunter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InfoHunter/subscriptions","organizations_url":"https://api.github.com/users/InfoHunter/orgs","repos_url":"https://api.github.com/users/InfoHunter/repos","events_url":"https://api.github.com/users/InfoHunter/events{/privacy}","received_events_url":"https://api.github.com/users/InfoHunter/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/openssl/openssl/milestones/11","html_url":"https://github.com/openssl/openssl/milestone/11","labels_url":"https://api.github.com/repos/openssl/openssl/milestones/11/labels","id":3024154,"node_id":"MDk6TWlsZXN0b25lMzAyNDE1NA==","number":11,"title":"Post 1.1.1","description":"","creator":{"login":"kaduk","id":1894506,"node_id":"MDQ6VXNlcjE4OTQ1MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1894506?v=4","gravatar_id":"","url":"https://api.github.com/users/kaduk","html_url":"https://github.com/kaduk","followers_url":"https://api.github.com/users/kaduk/followers","following_url":"https://api.github.com/users/kaduk/following{/other_user}","gists_url":"https://api.github.com/users/kaduk/gists{/gist_id}","starred_url":"https://api.github.com/users/kaduk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaduk/subscriptions","organizations_url":"https://api.github.com/users/kaduk/orgs","repos_url":"https://api.github.com/users/kaduk/repos","events_url":"https://api.github.com/users/kaduk/events{/privacy}","received_events_url":"https://api.github.com/users/kaduk/received_events","type":"User","site_admin":false},"open_issues":239,"closed_issues":50,"state":"open","created_at":"2018-01-09T21:08:23Z","updated_at":"2018-09-12T00:00:25Z","due_on":null,"closed_at":null},"comments":30,"created_at":"2018-09-06T04:35:28Z","updated_at":"2018-09-14T02:52:47Z","closed_at":null,"author_association":"MEMBER","body":"This issue is derived from this comment: https://github.com/openssl/openssl/pull/7113#discussion_r215185781\r\n\r\nThe main idea here is the NULL-checks for parameters should not be done as what the functions do in current code.\r\n\r\nThis is not addressed in PR #7113 , but it should be done later after 1.1.1 has been released.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/openssl/openssl/issues/comments/421214866","html_url":"https://github.com/openssl/openssl/issues/7130#issuecomment-421214866","issue_url":"https://api.github.com/repos/openssl/openssl/issues/7130","id":421214866,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTIxNDg2Ng==","user":{"login":"t-j-h","id":7409473,"node_id":"MDQ6VXNlcjc0MDk0NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/7409473?v=4","gravatar_id":"","url":"https://api.github.com/users/t-j-h","html_url":"https://github.com/t-j-h","followers_url":"https://api.github.com/users/t-j-h/followers","following_url":"https://api.github.com/users/t-j-h/following{/other_user}","gists_url":"https://api.github.com/users/t-j-h/gists{/gist_id}","starred_url":"https://api.github.com/users/t-j-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t-j-h/subscriptions","organizations_url":"https://api.github.com/users/t-j-h/orgs","repos_url":"https://api.github.com/users/t-j-h/repos","events_url":"https://api.github.com/users/t-j-h/events{/privacy}","received_events_url":"https://api.github.com/users/t-j-h/received_events","type":"User","site_admin":false},"created_at":"2018-09-14T02:52:47Z","updated_at":"2018-09-14T02:52:47Z","author_association":"MEMBER","body":"I would be okay with just always compiled in checks. Adding assert options defeats the purpose given code must be tested with the checks in place and will take advantage of those checks otherwise they serve little point. \r\n\r\nBut I did want everyone to see that there are actually four options not two and the assert-in-debug is the wrong approach."}}
{"actor":{"display_login":"t-j-h"}}