{"action":"created","comment":{"url":"https://api.github.com/repos/whole-tale/girder_wholetale/pulls/comments/195263635","pull_request_review_id":128596965,"id":195263635,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTI2MzYzNQ==","diff_hunk":"@@ -44,15 +44,16 @@ def create_minimum_eml(tale,\n                        user,\n                        item_ids,\n                        eml_pid,\n-                       external_data):\n+                       external_data=dict()):\n     \"\"\"\n     Creates a bare minimum EML record for a package.\n \n     :param tale: The tale that is being packaged.\n     :param user: The user that hit the endpoint\n     :param item_ids: A lsit of the item ids of the objects that are going to be packaged\n     :param eml_pid: The PID for the eml document. Assume that this is the package doi\n-    :param external_data: A dict with any parameters needed for a file describing external objects\n+    :param external_data: A dict with any parameters needed for a file describing external objects.\n+     An example is occasionally needing the size of the object, so throw it","path":"server/dataone_package.py","position":null,"original_position":15,"commit_id":"13b72c167f6fd23fd39fa70a025dd608521a0091","original_commit_id":"8124a11c1ecf4cdea1e66d9f7ae2ef75684ad7f0","user":{"login":"amoeba","id":563,"node_id":"MDQ6VXNlcjU2Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/563?v=4","gravatar_id":"","url":"https://api.github.com/users/amoeba","html_url":"https://github.com/amoeba","followers_url":"https://api.github.com/users/amoeba/followers","following_url":"https://api.github.com/users/amoeba/following{/other_user}","gists_url":"https://api.github.com/users/amoeba/gists{/gist_id}","starred_url":"https://api.github.com/users/amoeba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amoeba/subscriptions","organizations_url":"https://api.github.com/users/amoeba/orgs","repos_url":"https://api.github.com/users/amoeba/repos","events_url":"https://api.github.com/users/amoeba/events{/privacy}","received_events_url":"https://api.github.com/users/amoeba/received_events","type":"User","site_admin":false},"body":"Is this sentence incomplete?","created_at":"2018-06-13T23:13:45Z","updated_at":"2018-06-13T23:13:45Z","html_url":"https://github.com/whole-tale/girder_wholetale/pull/93#discussion_r195263635","pull_request_url":"https://api.github.com/repos/whole-tale/girder_wholetale/pulls/93","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/whole-tale/girder_wholetale/pulls/comments/195263635"},"html":{"href":"https://github.com/whole-tale/girder_wholetale/pull/93#discussion_r195263635"},"pull_request":{"href":"https://api.github.com/repos/whole-tale/girder_wholetale/pulls/93"}}},"pull_request":{"url":"https://api.github.com/repos/whole-tale/girder_wholetale/pulls/93","id":193743925,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNzQzOTI1","html_url":"https://github.com/whole-tale/girder_wholetale/pull/93","diff_url":"https://github.com/whole-tale/girder_wholetale/pull/93.diff","patch_url":"https://github.com/whole-tale/girder_wholetale/pull/93.patch","issue_url":"https://api.github.com/repos/whole-tale/girder_wholetale/issues/93","number":93,"state":"open","locked":false,"title":"Add Support for A Globus/Remote File Descriptor","user":{"login":"ThomasThelen","id":9289652,"node_id":"MDQ6VXNlcjkyODk2NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/9289652?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomasThelen","html_url":"https://github.com/ThomasThelen","followers_url":"https://api.github.com/users/ThomasThelen/followers","following_url":"https://api.github.com/users/ThomasThelen/following{/other_user}","gists_url":"https://api.github.com/users/ThomasThelen/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasThelen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasThelen/subscriptions","organizations_url":"https://api.github.com/users/ThomasThelen/orgs","repos_url":"https://api.github.com/users/ThomasThelen/repos","events_url":"https://api.github.com/users/ThomasThelen/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasThelen/received_events","type":"User","site_admin":false},"body":"Changes in dataone_package.py:\r\n   I added a parameter to create_minimul_eml that holds any useful information about the globus description file. I made it a dict in case we need to add more parameters to beef the EML up rather than adding n function parameters. The only element in it is the file size.\r\n  I broke the code that was getting executed in the item loop into functions so that they can get called if there is a globus file.\r\n  I also broke the old md5 function up so that it can be used more independently elsewhere.\r\n  The biggest addition is `create_external_reference_file`. This is responsible for downloading the remote resource and getting it's md5. We download the file and store the bytes in a `NamedTemporaryFile`, and then compute the md5 of it.\r\n\r\nChanges in dataone_upload.py\r\n  You'll see that calls to create_upload_eml and create_minimum_eml have the dict mentioned above.\r\n  I added a new function, `create_upload_remote_file` which handles creating and uploading the globus reference file.\r\n\r\nI also threw in an experimental requirements.txt file-I may take a look at the library this weekend to see if I can update the requirements.","created_at":"2018-06-08T23:31:22Z","updated_at":"2018-06-13T23:13:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65a0cd316b4e40d992110445f28226cafa1b1d6a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/whole-tale/girder_wholetale/pulls/93/commits","review_comments_url":"https://api.github.com/repos/whole-tale/girder_wholetale/pulls/93/comments","review_comment_url":"https://api.github.com/repos/whole-tale/girder_wholetale/pulls/comments{/number}","comments_url":"https://api.github.com/repos/whole-tale/girder_wholetale/issues/93/comments","statuses_url":"https://api.github.com/repos/whole-tale/girder_wholetale/statuses/13b72c167f6fd23fd39fa70a025dd608521a0091","head":{"label":"ThomasThelen:dataone_publishing","ref":"dataone_publishing","sha":"13b72c167f6fd23fd39fa70a025dd608521a0091","user":{"login":"ThomasThelen","id":9289652,"node_id":"MDQ6VXNlcjkyODk2NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/9289652?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomasThelen","html_url":"https://github.com/ThomasThelen","followers_url":"https://api.github.com/users/ThomasThelen/followers","following_url":"https://api.github.com/users/ThomasThelen/following{/other_user}","gists_url":"https://api.github.com/users/ThomasThelen/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasThelen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasThelen/subscriptions","organizations_url":"https://api.github.com/users/ThomasThelen/orgs","repos_url":"https://api.github.com/users/ThomasThelen/repos","events_url":"https://api.github.com/users/ThomasThelen/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasThelen/received_events","type":"User","site_admin":false},"repo":{"id":125545653,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU1NDU2NTM=","name":"girder_wholetale","full_name":"ThomasThelen/girder_wholetale","owner":{"login":"ThomasThelen","id":9289652,"node_id":"MDQ6VXNlcjkyODk2NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/9289652?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomasThelen","html_url":"https://github.com/ThomasThelen","followers_url":"https://api.github.com/users/ThomasThelen/followers","following_url":"https://api.github.com/users/ThomasThelen/following{/other_user}","gists_url":"https://api.github.com/users/ThomasThelen/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasThelen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasThelen/subscriptions","organizations_url":"https://api.github.com/users/ThomasThelen/orgs","repos_url":"https://api.github.com/users/ThomasThelen/repos","events_url":"https://api.github.com/users/ThomasThelen/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasThelen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ThomasThelen/girder_wholetale","description":"Girder plugin providing basic Whole Tale functionality","fork":true,"url":"https://api.github.com/repos/ThomasThelen/girder_wholetale","forks_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/forks","keys_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/teams","hooks_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/hooks","issue_events_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/issues/events{/number}","events_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/events","assignees_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/assignees{/user}","branches_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/branches{/branch}","tags_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/tags","blobs_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/git/refs{/sha}","trees_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/statuses/{sha}","languages_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/languages","stargazers_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/stargazers","contributors_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/contributors","subscribers_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/subscribers","subscription_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/subscription","commits_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/commits{/sha}","git_commits_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/git/commits{/sha}","comments_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/comments{/number}","issue_comment_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/issues/comments{/number}","contents_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/contents/{+path}","compare_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/merges","archive_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/downloads","issues_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/issues{/number}","pulls_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/pulls{/number}","milestones_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/milestones{/number}","notifications_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/labels{/name}","releases_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/releases{/id}","deployments_url":"https://api.github.com/repos/ThomasThelen/girder_wholetale/deployments","created_at":"2018-03-16T16:59:07Z","updated_at":"2018-04-30T16:49:24Z","pushed_at":"2018-06-13T23:03:35Z","git_url":"git://github.com/ThomasThelen/girder_wholetale.git","ssh_url":"git@github.com:ThomasThelen/girder_wholetale.git","clone_url":"https://github.com/ThomasThelen/girder_wholetale.git","svn_url":"https://github.com/ThomasThelen/girder_wholetale","homepage":"","size":539,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"whole-tale:dataone_publishing","ref":"dataone_publishing","sha":"aa384189957d551d3f2a032b98f396b9bdaba682","user":{"login":"whole-tale","id":13108471,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTA4NDcx","avatar_url":"https://avatars2.githubusercontent.com/u/13108471?v=4","gravatar_id":"","url":"https://api.github.com/users/whole-tale","html_url":"https://github.com/whole-tale","followers_url":"https://api.github.com/users/whole-tale/followers","following_url":"https://api.github.com/users/whole-tale/following{/other_user}","gists_url":"https://api.github.com/users/whole-tale/gists{/gist_id}","starred_url":"https://api.github.com/users/whole-tale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whole-tale/subscriptions","organizations_url":"https://api.github.com/users/whole-tale/orgs","repos_url":"https://api.github.com/users/whole-tale/repos","events_url":"https://api.github.com/users/whole-tale/events{/privacy}","received_events_url":"https://api.github.com/users/whole-tale/received_events","type":"Organization","site_admin":false},"repo":{"id":66147054,"node_id":"MDEwOlJlcG9zaXRvcnk2NjE0NzA1NA==","name":"girder_wholetale","full_name":"whole-tale/girder_wholetale","owner":{"login":"whole-tale","id":13108471,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTA4NDcx","avatar_url":"https://avatars2.githubusercontent.com/u/13108471?v=4","gravatar_id":"","url":"https://api.github.com/users/whole-tale","html_url":"https://github.com/whole-tale","followers_url":"https://api.github.com/users/whole-tale/followers","following_url":"https://api.github.com/users/whole-tale/following{/other_user}","gists_url":"https://api.github.com/users/whole-tale/gists{/gist_id}","starred_url":"https://api.github.com/users/whole-tale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whole-tale/subscriptions","organizations_url":"https://api.github.com/users/whole-tale/orgs","repos_url":"https://api.github.com/users/whole-tale/repos","events_url":"https://api.github.com/users/whole-tale/events{/privacy}","received_events_url":"https://api.github.com/users/whole-tale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/whole-tale/girder_wholetale","description":"Girder plugin providing basic Whole Tale functionality","fork":true,"url":"https://api.github.com/repos/whole-tale/girder_wholetale","forks_url":"https://api.github.com/repos/whole-tale/girder_wholetale/forks","keys_url":"https://api.github.com/repos/whole-tale/girder_wholetale/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whole-tale/girder_wholetale/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whole-tale/girder_wholetale/teams","hooks_url":"https://api.github.com/repos/whole-tale/girder_wholetale/hooks","issue_events_url":"https://api.github.com/repos/whole-tale/girder_wholetale/issues/events{/number}","events_url":"https://api.github.com/repos/whole-tale/girder_wholetale/events","assignees_url":"https://api.github.com/repos/whole-tale/girder_wholetale/assignees{/user}","branches_url":"https://api.github.com/repos/whole-tale/girder_wholetale/branches{/branch}","tags_url":"https://api.github.com/repos/whole-tale/girder_wholetale/tags","blobs_url":"https://api.github.com/repos/whole-tale/girder_wholetale/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whole-tale/girder_wholetale/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whole-tale/girder_wholetale/git/refs{/sha}","trees_url":"https://api.github.com/repos/whole-tale/girder_wholetale/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whole-tale/girder_wholetale/statuses/{sha}","languages_url":"https://api.github.com/repos/whole-tale/girder_wholetale/languages","stargazers_url":"https://api.github.com/repos/whole-tale/girder_wholetale/stargazers","contributors_url":"https://api.github.com/repos/whole-tale/girder_wholetale/contributors","subscribers_url":"https://api.github.com/repos/whole-tale/girder_wholetale/subscribers","subscription_url":"https://api.github.com/repos/whole-tale/girder_wholetale/subscription","commits_url":"https://api.github.com/repos/whole-tale/girder_wholetale/commits{/sha}","git_commits_url":"https://api.github.com/repos/whole-tale/girder_wholetale/git/commits{/sha}","comments_url":"https://api.github.com/repos/whole-tale/girder_wholetale/comments{/number}","issue_comment_url":"https://api.github.com/repos/whole-tale/girder_wholetale/issues/comments{/number}","contents_url":"https://api.github.com/repos/whole-tale/girder_wholetale/contents/{+path}","compare_url":"https://api.github.com/repos/whole-tale/girder_wholetale/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whole-tale/girder_wholetale/merges","archive_url":"https://api.github.com/repos/whole-tale/girder_wholetale/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whole-tale/girder_wholetale/downloads","issues_url":"https://api.github.com/repos/whole-tale/girder_wholetale/issues{/number}","pulls_url":"https://api.github.com/repos/whole-tale/girder_wholetale/pulls{/number}","milestones_url":"https://api.github.com/repos/whole-tale/girder_wholetale/milestones{/number}","notifications_url":"https://api.github.com/repos/whole-tale/girder_wholetale/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whole-tale/girder_wholetale/labels{/name}","releases_url":"https://api.github.com/repos/whole-tale/girder_wholetale/releases{/id}","deployments_url":"https://api.github.com/repos/whole-tale/girder_wholetale/deployments","created_at":"2016-08-20T13:01:58Z","updated_at":"2018-06-08T18:05:30Z","pushed_at":"2018-06-13T23:03:36Z","git_url":"git://github.com/whole-tale/girder_wholetale.git","ssh_url":"git@github.com:whole-tale/girder_wholetale.git","clone_url":"https://github.com/whole-tale/girder_wholetale.git","svn_url":"https://github.com/whole-tale/girder_wholetale","homepage":"","size":541,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":3,"open_issues":29,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/whole-tale/girder_wholetale/pulls/93"},"html":{"href":"https://github.com/whole-tale/girder_wholetale/pull/93"},"issue":{"href":"https://api.github.com/repos/whole-tale/girder_wholetale/issues/93"},"comments":{"href":"https://api.github.com/repos/whole-tale/girder_wholetale/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/whole-tale/girder_wholetale/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/whole-tale/girder_wholetale/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/whole-tale/girder_wholetale/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/whole-tale/girder_wholetale/statuses/13b72c167f6fd23fd39fa70a025dd608521a0091"}},"author_association":"NONE"}}
{"actor":{"display_login":"amoeba"}}