{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift-nio/pulls/comments/179807063","pull_request_review_id":110118610,"id":179807063,"diff_hunk":"@@ -171,7 +171,7 @@ public class HTTPServerUpgradeHandler: ChannelInboundHandler {\n     /// The core of the upgrade handling logic.\n     private func handleUpgrade(ctx: ChannelHandlerContext, request: HTTPRequestHead, requestedProtocols: [String]) -> Bool {\n         let connectionHeader = Set(request.headers.getCanonicalForm(\"connection\").map { $0.lowercased() })\n-        let allHeaderNames = Set(request.headers.map { $0.name.lowercased() })\n+        let allHeaderNames: Set<String> = Set(request.headers.map { $0.name.lowercased() })","path":"Sources/NIOHTTP1/HTTPUpgradeHandler.swift","position":5,"original_position":5,"commit_id":"80bda4d8174930b65c305771849fb659eda0ec8d","original_commit_id":"80bda4d8174930b65c305771849fb659eda0ec8d","user":{"login":"Lukasa","id":1382556,"avatar_url":"https://avatars1.githubusercontent.com/u/1382556?v=4","gravatar_id":"","url":"https://api.github.com/users/Lukasa","html_url":"https://github.com/Lukasa","followers_url":"https://api.github.com/users/Lukasa/followers","following_url":"https://api.github.com/users/Lukasa/following{/other_user}","gists_url":"https://api.github.com/users/Lukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukasa/subscriptions","organizations_url":"https://api.github.com/users/Lukasa/orgs","repos_url":"https://api.github.com/users/Lukasa/repos","events_url":"https://api.github.com/users/Lukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Lukasa/received_events","type":"User","site_admin":false},"body":"Why does this need an explicit type now?","created_at":"2018-04-06T16:17:08Z","updated_at":"2018-04-06T16:17:35Z","html_url":"https://github.com/apple/swift-nio/pull/291#discussion_r179807063","pull_request_url":"https://api.github.com/repos/apple/swift-nio/pulls/291","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apple/swift-nio/pulls/comments/179807063"},"html":{"href":"https://github.com/apple/swift-nio/pull/291#discussion_r179807063"},"pull_request":{"href":"https://api.github.com/repos/apple/swift-nio/pulls/291"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift-nio/pulls/291","id":179986411,"html_url":"https://github.com/apple/swift-nio/pull/291","diff_url":"https://github.com/apple/swift-nio/pull/291.diff","patch_url":"https://github.com/apple/swift-nio/pull/291.patch","issue_url":"https://api.github.com/repos/apple/swift-nio/issues/291","number":291,"state":"open","locked":false,"title":"[DONT-MERGE-YET] Implement lazy headers parsing","user":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars3.githubusercontent.com/u/439362?v=4","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"body":"Motivation:\r\n\r\nWe are currently parsing each header eagly which means we need to convert from bytes to String frequently. The reality is that most of the times the user is not really interested in all the headers and so it is kind of wasteful to do so.\r\n\r\nModification:\r\n\r\nRewrite our internal storage of HTTPHeaders to use a ByteBuffer as internal storage and so only parse headers on demand.\r\n\r\nResult:\r\n\r\nLess overhead for parsing headers.","created_at":"2018-04-06T15:47:59Z","updated_at":"2018-04-06T16:17:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a67b56fe7086e0b3524669752846e95d9f6f6cce","assignee":null,"assignees":[],"requested_reviewers":[{"login":"weissi","id":624238,"avatar_url":"https://avatars2.githubusercontent.com/u/624238?v=4","gravatar_id":"","url":"https://api.github.com/users/weissi","html_url":"https://github.com/weissi","followers_url":"https://api.github.com/users/weissi/followers","following_url":"https://api.github.com/users/weissi/following{/other_user}","gists_url":"https://api.github.com/users/weissi/gists{/gist_id}","starred_url":"https://api.github.com/users/weissi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weissi/subscriptions","organizations_url":"https://api.github.com/users/weissi/orgs","repos_url":"https://api.github.com/users/weissi/repos","events_url":"https://api.github.com/users/weissi/events{/privacy}","received_events_url":"https://api.github.com/users/weissi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift-nio/pulls/291/commits","review_comments_url":"https://api.github.com/repos/apple/swift-nio/pulls/291/comments","review_comment_url":"https://api.github.com/repos/apple/swift-nio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift-nio/issues/291/comments","statuses_url":"https://api.github.com/repos/apple/swift-nio/statuses/80bda4d8174930b65c305771849fb659eda0ec8d","head":{"label":"normanmaurer:http_work","ref":"http_work","sha":"80bda4d8174930b65c305771849fb659eda0ec8d","user":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars3.githubusercontent.com/u/439362?v=4","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"repo":{"id":123526297,"name":"swift-nio","full_name":"normanmaurer/swift-nio","owner":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars3.githubusercontent.com/u/439362?v=4","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/normanmaurer/swift-nio","description":"Event-driven network application framework for high performance protocol servers & clients, non-blocking.","fork":true,"url":"https://api.github.com/repos/normanmaurer/swift-nio","forks_url":"https://api.github.com/repos/normanmaurer/swift-nio/forks","keys_url":"https://api.github.com/repos/normanmaurer/swift-nio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/normanmaurer/swift-nio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/normanmaurer/swift-nio/teams","hooks_url":"https://api.github.com/repos/normanmaurer/swift-nio/hooks","issue_events_url":"https://api.github.com/repos/normanmaurer/swift-nio/issues/events{/number}","events_url":"https://api.github.com/repos/normanmaurer/swift-nio/events","assignees_url":"https://api.github.com/repos/normanmaurer/swift-nio/assignees{/user}","branches_url":"https://api.github.com/repos/normanmaurer/swift-nio/branches{/branch}","tags_url":"https://api.github.com/repos/normanmaurer/swift-nio/tags","blobs_url":"https://api.github.com/repos/normanmaurer/swift-nio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/normanmaurer/swift-nio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/normanmaurer/swift-nio/git/refs{/sha}","trees_url":"https://api.github.com/repos/normanmaurer/swift-nio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/normanmaurer/swift-nio/statuses/{sha}","languages_url":"https://api.github.com/repos/normanmaurer/swift-nio/languages","stargazers_url":"https://api.github.com/repos/normanmaurer/swift-nio/stargazers","contributors_url":"https://api.github.com/repos/normanmaurer/swift-nio/contributors","subscribers_url":"https://api.github.com/repos/normanmaurer/swift-nio/subscribers","subscription_url":"https://api.github.com/repos/normanmaurer/swift-nio/subscription","commits_url":"https://api.github.com/repos/normanmaurer/swift-nio/commits{/sha}","git_commits_url":"https://api.github.com/repos/normanmaurer/swift-nio/git/commits{/sha}","comments_url":"https://api.github.com/repos/normanmaurer/swift-nio/comments{/number}","issue_comment_url":"https://api.github.com/repos/normanmaurer/swift-nio/issues/comments{/number}","contents_url":"https://api.github.com/repos/normanmaurer/swift-nio/contents/{+path}","compare_url":"https://api.github.com/repos/normanmaurer/swift-nio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/normanmaurer/swift-nio/merges","archive_url":"https://api.github.com/repos/normanmaurer/swift-nio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/normanmaurer/swift-nio/downloads","issues_url":"https://api.github.com/repos/normanmaurer/swift-nio/issues{/number}","pulls_url":"https://api.github.com/repos/normanmaurer/swift-nio/pulls{/number}","milestones_url":"https://api.github.com/repos/normanmaurer/swift-nio/milestones{/number}","notifications_url":"https://api.github.com/repos/normanmaurer/swift-nio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/normanmaurer/swift-nio/labels{/name}","releases_url":"https://api.github.com/repos/normanmaurer/swift-nio/releases{/id}","deployments_url":"https://api.github.com/repos/normanmaurer/swift-nio/deployments","created_at":"2018-03-02T03:37:41Z","updated_at":"2018-03-28T18:11:50Z","pushed_at":"2018-04-06T15:47:43Z","git_url":"git://github.com/normanmaurer/swift-nio.git","ssh_url":"git@github.com:normanmaurer/swift-nio.git","clone_url":"https://github.com/normanmaurer/swift-nio.git","svn_url":"https://github.com/normanmaurer/swift-nio","homepage":"","size":3105,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"e6b8da38b5d4bd217108f4c1fd12327c955e862e","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":120498971,"name":"swift-nio","full_name":"apple/swift-nio","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift-nio","description":"Event-driven network application framework for high performance protocol servers & clients, non-blocking.","fork":false,"url":"https://api.github.com/repos/apple/swift-nio","forks_url":"https://api.github.com/repos/apple/swift-nio/forks","keys_url":"https://api.github.com/repos/apple/swift-nio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift-nio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift-nio/teams","hooks_url":"https://api.github.com/repos/apple/swift-nio/hooks","issue_events_url":"https://api.github.com/repos/apple/swift-nio/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift-nio/events","assignees_url":"https://api.github.com/repos/apple/swift-nio/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift-nio/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift-nio/tags","blobs_url":"https://api.github.com/repos/apple/swift-nio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift-nio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift-nio/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift-nio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift-nio/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift-nio/languages","stargazers_url":"https://api.github.com/repos/apple/swift-nio/stargazers","contributors_url":"https://api.github.com/repos/apple/swift-nio/contributors","subscribers_url":"https://api.github.com/repos/apple/swift-nio/subscribers","subscription_url":"https://api.github.com/repos/apple/swift-nio/subscription","commits_url":"https://api.github.com/repos/apple/swift-nio/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift-nio/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift-nio/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift-nio/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift-nio/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift-nio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift-nio/merges","archive_url":"https://api.github.com/repos/apple/swift-nio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift-nio/downloads","issues_url":"https://api.github.com/repos/apple/swift-nio/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift-nio/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift-nio/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift-nio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift-nio/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift-nio/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift-nio/deployments","created_at":"2018-02-06T17:47:31Z","updated_at":"2018-04-06T15:38:25Z","pushed_at":"2018-04-06T15:48:00Z","git_url":"git://github.com/apple/swift-nio.git","ssh_url":"git@github.com:apple/swift-nio.git","clone_url":"https://github.com/apple/swift-nio.git","svn_url":"https://github.com/apple/swift-nio","homepage":"","size":4530,"stargazers_count":3355,"watchers_count":3355,"language":"Swift","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":128,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":128,"open_issues":51,"watchers":3355,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift-nio/pulls/291"},"html":{"href":"https://github.com/apple/swift-nio/pull/291"},"issue":{"href":"https://api.github.com/repos/apple/swift-nio/issues/291"},"comments":{"href":"https://api.github.com/repos/apple/swift-nio/issues/291/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift-nio/pulls/291/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift-nio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift-nio/pulls/291/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift-nio/statuses/80bda4d8174930b65c305771849fb659eda0ec8d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Lukasa"}}