{"push_id":2451659836,"size":17,"distinct_size":4,"ref":"refs/heads/rpatterns14","head":"de416ecf80ce68217f91f4e5bf50bc7d43c7337a","before":"87adfec2ed07ee9e2d960106e423ab8c99896d3b","commits":[{"sha":"e00aff992c3dcf50383dfa09e42d6d33f37a214e","author":{"name":"Neal Gafter","email":"0498adfa5f8634de2b30977d8d3c8c76c4d288f3@gafter.com"},"message":"Address issues from previous recursive-patterns code reviews\n\nFixes #25663\n\n### From https://github.com/dotnet/roslyn/pull/24059\n\n- In `CheckConsistentDecision`, use some notation like `v != null --> !(v == null)` for more clarity than the English language comment.\n- Add a private constructor to prevent construction of `DagStateEquivalence`\n- Hint creation of builder size in `CheckSwitchErrors`\n- Suppress subsumption errors on switch expression case if the pattern has an error.\n- In `LowerTest`, we have special handling for decisions on constant-valued input. But such decisions should already have been removed from the decision dag. Assert that this situation cannot occur and remove the special handling code.\n- Merge two cases in `switch (sortedNodes[0])` in `LowerDecisionDag`\n- Comment on `GetDagNodeLabel` is now less redundant.\n\n### From https://github.com/dotnet/roslyn/pull/25544\n\n- In `AwaitExpressionSpiller.cs`, move `VisitSwitchDispatch` to right before `VisitThrowStatement` so it is in the same place where `VisitSwitchStatement` used to be to make deltas more clear in the end.\n- Remove `params` overload `public BoundStatement Switch(BoundExpression ex, params SyntheticSwitchSection[] sections)` and force caller to properly construct an immutable array.","distinct":false,"url":"https://api.github.com/repos/gafter/roslyn/commits/e00aff992c3dcf50383dfa09e42d6d33f37a214e"},{"sha":"734a8c8f011871a9e7151749543fc04bec074818","author":{"name":"Neal Gafter","email":"0498adfa5f8634de2b30977d8d3c8c76c4d288f3@gafter.com"},"message":"Report an error when discard pattern is used but there is a _ in scope\nNote that this error does not apply to the discard *designation*, only the discard *pattern*.\nSince the discard designation is new in C#8, this is not a breaking change.\n\nReport an error if a constant named '_' is used as a constant pattern.\nThis error has been confirmed by the LDM on 2017-11-20\n\nAlso report a warning if a type named '_' is used in an is-type expression.\nThis requires compat council confirmation.\n\nOpen issues in https://github.com/dotnet/csharplang/issues/1054 describe pending LDM decisions for potentialy breaking scenarios.","distinct":false,"url":"https://api.github.com/repos/gafter/roslyn/commits/734a8c8f011871a9e7151749543fc04bec074818"},{"sha":"83561e682ba332819fcafeff48525e2adfeffdf8","author":{"name":"Neal Gafter","email":"0498adfa5f8634de2b30977d8d3c8c76c4d288f3@gafter.com"},"message":"Fix an infinite loop in property parsing.","distinct":false,"url":"https://api.github.com/repos/gafter/roslyn/commits/83561e682ba332819fcafeff48525e2adfeffdf8"},{"sha":"31f1fb6b52c121a2c42a13031477d0ad99c5d1fc","author":{"name":"Neal Gafter","email":"0498adfa5f8634de2b30977d8d3c8c76c4d288f3@gafter.com"},"message":"Use `IsMakingProgress` in pattern parsing.\nSimplify expressions in `IsPossibleSubpatternElement`","distinct":false,"url":"https://api.github.com/repos/gafter/roslyn/commits/31f1fb6b52c121a2c42a13031477d0ad99c5d1fc"},{"sha":"6309c2a2f359eb1e74e2db2e0aa69e5d61e1b7d0","author":{"name":"Neal Gafter","email":"0498adfa5f8634de2b30977d8d3c8c76c4d288f3@gafter.com"},"message":"Add compiler breaking changes doc\nAnd other minor changes per review.","distinct":false,"url":"https://api.github.com/repos/gafter/roslyn/commits/6309c2a2f359eb1e74e2db2e0aa69e5d61e1b7d0"},{"sha":"469f2b4c117f162e729e17972ffb9cbfc84feeca","author":{"name":"Neal Gafter","email":"0498adfa5f8634de2b30977d8d3c8c76c4d288f3@gafter.com"},"message":"Move local functions to the end of a test method.","distinct":false,"url":"https://api.github.com/repos/gafter/roslyn/commits/469f2b4c117f162e729e17972ffb9cbfc84feeca"},{"sha":"8dd08abbd2594771c12804b281c723ac1deaaed8","author":{"name":"Neal Gafter","email":"0498adfa5f8634de2b30977d8d3c8c76c4d288f3@gafter.com"},"message":"Merge branch 'features/recursive-patterns' of https://github.com/dotnet/roslyn into rpatterns13","distinct":false,"url":"https://api.github.com/repos/gafter/roslyn/commits/8dd08abbd2594771c12804b281c723ac1deaaed8"},{"sha":"7b273cb74027f25c020fa977c7089b03fce66750","author":{"name":"Neal Gafter","email":"0498adfa5f8634de2b30977d8d3c8c76c4d288f3@gafter.com"},"message":"Address review comments in https://github.com/dotnet/roslyn/pull/25697","distinct":false,"url":"https://api.github.com/repos/gafter/roslyn/commits/7b273cb74027f25c020fa977c7089b03fce66750"},{"sha":"ef298593426e9a6d23ecb38ea0e4dcb802fe6887","author":{"name":"Neal Gafter","email":"0498adfa5f8634de2b30977d8d3c8c76c4d288f3@gafter.com"},"message":"Merge from features/recursive-patterns","distinct":false,"url":"https://api.github.com/repos/gafter/roslyn/commits/ef298593426e9a6d23ecb38ea0e4dcb802fe6887"},{"sha":"bc3c38d7d8e679fa3f291d23005b76532fd6de27","author":{"name":"Neal Gafter","email":"0498adfa5f8634de2b30977d8d3c8c76c4d288f3@gafter.com"},"message":"Use LookupSymbolsInternal when we don't need to diagnose failure to find.","distinct":false,"url":"https://api.github.com/repos/gafter/roslyn/commits/bc3c38d7d8e679fa3f291d23005b76532fd6de27"},{"sha":"c1c25010756f1ac04ba69ca34f7b9ff8eff040de","author":{"name":"Neal Gafter","email":"0498adfa5f8634de2b30977d8d3c8c76c4d288f3@gafter.com"},"message":"Merge branch 'features/recursive-patterns' of https://github.com/dotnet/roslyn into rpatterns15","distinct":false,"url":"https://api.github.com/repos/gafter/roslyn/commits/c1c25010756f1ac04ba69ca34f7b9ff8eff040de"},{"sha":"1ce793107081e6c2c50c2a31995de5b2c579dcf1","author":{"name":"Neal Gafter","email":"0498adfa5f8634de2b30977d8d3c8c76c4d288f3@gafter.com"},"message":"Merge branch 'features/recursive-patterns' of https://github.com/dotnet/roslyn into rpatterns16","distinct":false,"url":"https://api.github.com/repos/gafter/roslyn/commits/1ce793107081e6c2c50c2a31995de5b2c579dcf1"},{"sha":"3b409f5382c8302660fee9b8911f08e1468c898a","author":{"name":"Neal Gafter","email":"0498adfa5f8634de2b30977d8d3c8c76c4d288f3@gafter.com"},"message":"Merge pull request #25783 from gafter/rpatterns16\n\nrecursive-patterns(16) Fix an infinite loop in property parsing.","distinct":true,"url":"https://api.github.com/repos/gafter/roslyn/commits/3b409f5382c8302660fee9b8911f08e1468c898a"},{"sha":"52581b38113909746823f30581f16a7f9f59e767","author":{"name":"Neal Gafter","email":"0498adfa5f8634de2b30977d8d3c8c76c4d288f3@gafter.com"},"message":"Merge pull request #25767 from gafter/rpatterns13\n\nrecursive-patterns(13): Address issues from previous recursive-patterns code reviews","distinct":true,"url":"https://api.github.com/repos/gafter/roslyn/commits/52581b38113909746823f30581f16a7f9f59e767"},{"sha":"8831cf8c708885a29db5034b731abc75d064ca00","author":{"name":"Neal Gafter","email":"0498adfa5f8634de2b30977d8d3c8c76c4d288f3@gafter.com"},"message":"Minor changes and additional test for recirsive-patterns(15)","distinct":false,"url":"https://api.github.com/repos/gafter/roslyn/commits/8831cf8c708885a29db5034b731abc75d064ca00"},{"sha":"e1954120e4dc47999accb91d47a01b5fd364e97e","author":{"name":"Neal Gafter","email":"0498adfa5f8634de2b30977d8d3c8c76c4d288f3@gafter.com"},"message":"Merge pull request #25779 from gafter/rpatterns15\n\nrecursive-patterns(15) Report an error when discard pattern is used but there is a _ in scope","distinct":true,"url":"https://api.github.com/repos/gafter/roslyn/commits/e1954120e4dc47999accb91d47a01b5fd364e97e"},{"sha":"de416ecf80ce68217f91f4e5bf50bc7d43c7337a","author":{"name":"Neal Gafter","email":"0498adfa5f8634de2b30977d8d3c8c76c4d288f3@gafter.com"},"message":"Merge branch 'features/recursive-patterns' of https://github.com/dotnet/roslyn into rpatterns14","distinct":true,"url":"https://api.github.com/repos/gafter/roslyn/commits/de416ecf80ce68217f91f4e5bf50bc7d43c7337a"}]}
{"actor":{"display_login":"gafter"}}