{"action":"created","issue":{"url":"https://api.github.com/repos/forkdelta/forkdelta.github.io/issues/106","repository_url":"https://api.github.com/repos/forkdelta/forkdelta.github.io","labels_url":"https://api.github.com/repos/forkdelta/forkdelta.github.io/issues/106/labels{/name}","comments_url":"https://api.github.com/repos/forkdelta/forkdelta.github.io/issues/106/comments","events_url":"https://api.github.com/repos/forkdelta/forkdelta.github.io/issues/106/events","html_url":"https://github.com/forkdelta/forkdelta.github.io/pull/106","id":300118933,"number":106,"title":"working on a new layout","user":{"login":"activescott","id":213716,"avatar_url":"https://avatars1.githubusercontent.com/u/213716?v=4","gravatar_id":"","url":"https://api.github.com/users/activescott","html_url":"https://github.com/activescott","followers_url":"https://api.github.com/users/activescott/followers","following_url":"https://api.github.com/users/activescott/following{/other_user}","gists_url":"https://api.github.com/users/activescott/gists{/gist_id}","starred_url":"https://api.github.com/users/activescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activescott/subscriptions","organizations_url":"https://api.github.com/users/activescott/orgs","repos_url":"https://api.github.com/users/activescott/repos","events_url":"https://api.github.com/users/activescott/events{/privacy}","received_events_url":"https://api.github.com/users/activescott/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-02-26T06:00:20Z","updated_at":"2018-03-20T03:21:23Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/forkdelta/forkdelta.github.io/pulls/106","html_url":"https://github.com/forkdelta/forkdelta.github.io/pull/106","diff_url":"https://github.com/forkdelta/forkdelta.github.io/pull/106.diff","patch_url":"https://github.com/forkdelta/forkdelta.github.io/pull/106.patch"},"body":"**Please don't pull this yet until all todos below are resolved.**\r\n\r\nI'm sending this PR now to get feedback on the approach and to keep my status public.\r\n\r\n-----\r\n\r\nThis gets rid of a lot of the specific height settings that made the layout difficult to work with. Benefits are:\r\n- More robust layout in general with less jumping around and odd behavior on specific browsers (like the intermittent #102)\r\n- Responsive layout on narrow/mobile devices (now it renders each widget box on a screen at a time even on very small devices)\r\n- Divides the rows of widgets into equal parts to reduce jagged \"lines\" in the layout\r\n\r\n# TODO:\r\n- [x] Font sizes somehow got bigger for some reason (trades, orderbook, volume)\r\n- [x] New Order content is too wide, causing scrollbars\r\n- [x] I believe there are a lot of style classes not used anywhere anymore. Remove them from black.css\r\n"},"comment":{"url":"https://api.github.com/repos/forkdelta/forkdelta.github.io/issues/comments/374460219","html_url":"https://github.com/forkdelta/forkdelta.github.io/pull/106#issuecomment-374460219","issue_url":"https://api.github.com/repos/forkdelta/forkdelta.github.io/issues/106","id":374460219,"user":{"login":"JonathonDunford","id":5281151,"avatar_url":"https://avatars1.githubusercontent.com/u/5281151?v=4","gravatar_id":"","url":"https://api.github.com/users/JonathonDunford","html_url":"https://github.com/JonathonDunford","followers_url":"https://api.github.com/users/JonathonDunford/followers","following_url":"https://api.github.com/users/JonathonDunford/following{/other_user}","gists_url":"https://api.github.com/users/JonathonDunford/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathonDunford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathonDunford/subscriptions","organizations_url":"https://api.github.com/users/JonathonDunford/orgs","repos_url":"https://api.github.com/users/JonathonDunford/repos","events_url":"https://api.github.com/users/JonathonDunford/events{/privacy}","received_events_url":"https://api.github.com/users/JonathonDunford/received_events","type":"User","site_admin":false},"created_at":"2018-03-20T03:21:22Z","updated_at":"2018-03-20T03:21:22Z","author_association":"OWNER","body":"@activescott \r\n\r\n**Issue 1:**\r\n\r\nCheck out this screenshot.\r\nI am on a 1920x1080 monitor.\r\nThe table for balances/deposits/etc. need to be full width.\r\n\r\nhttps://imgur.com/a/JDKWi\r\n\r\n**Issue 2:**\r\n\r\nSome of the scroll bars aren't styled. Check in Chrome.\r\n\r\nCheck this screenshot: https://imgur.com/a/ej6fV\r\n\r\n**Issue 3:**\r\n\r\nOn Mobile, the same problem as Issue 1 happens.\r\n\r\nALSO, the bottom of the \"Make sure XXX\" text gets cut off and the whole block becomes scrollable. Can we make it all in view without having to scroll the separate section?\r\n\r\n**Issue 4:**\r\n\r\nThe order section cuts off for me on mobile as well. \r\n\r\nI fixed these issues on our live CSS by setting minimum widths on mobile."}}
{"actor":{"display_login":"JonathonDunford"}}