{"action":"created","issue":{"url":"https://api.github.com/repos/shopware/shopware/issues/1561","repository_url":"https://api.github.com/repos/shopware/shopware","labels_url":"https://api.github.com/repos/shopware/shopware/issues/1561/labels{/name}","comments_url":"https://api.github.com/repos/shopware/shopware/issues/1561/comments","events_url":"https://api.github.com/repos/shopware/shopware/issues/1561/events","html_url":"https://github.com/shopware/shopware/pull/1561","id":303052037,"number":1561,"title":"Add number range for doc_3/storno bill","user":{"login":"pascalheidman-bedarf","id":25795962,"avatar_url":"https://avatars1.githubusercontent.com/u/25795962?v=4","gravatar_id":"","url":"https://api.github.com/users/pascalheidman-bedarf","html_url":"https://github.com/pascalheidman-bedarf","followers_url":"https://api.github.com/users/pascalheidman-bedarf/followers","following_url":"https://api.github.com/users/pascalheidman-bedarf/following{/other_user}","gists_url":"https://api.github.com/users/pascalheidman-bedarf/gists{/gist_id}","starred_url":"https://api.github.com/users/pascalheidman-bedarf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascalheidman-bedarf/subscriptions","organizations_url":"https://api.github.com/users/pascalheidman-bedarf/orgs","repos_url":"https://api.github.com/users/pascalheidman-bedarf/repos","events_url":"https://api.github.com/users/pascalheidman-bedarf/events{/privacy}","received_events_url":"https://api.github.com/users/pascalheidman-bedarf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-07T10:55:23Z","updated_at":"2018-03-09T10:30:13Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/shopware/shopware/pulls/1561","html_url":"https://github.com/shopware/shopware/pull/1561","diff_url":"https://github.com/shopware/shopware/pull/1561.diff","patch_url":"https://github.com/shopware/shopware/pull/1561.patch"},"body":"### 1. Why is this change necessary?\r\nAdd default number range for storno bills as this is lacking right now. Therefore storno bills title read _\"Reversal invoice for invoice No. \"_.\r\n\r\n### 2. What does this change do, exactly?\r\nAdd entry to s_order_number table to have a concrete number range for storno bills\r\n\r\n### 3. Describe each step to reproduce the issue or behaviour.\r\nWithout this PR create a storno bill and you will see that the created document has no number range (therefore name _0.pdf_) and inside the document is the addressed title without a number.\r\nWith an added number range index the functionality can find a valid number.\r\n\r\n### 4. Please link to the relevant issues (if any).\r\n- https://github.com/shopware/shopware/pull/1560 This PR does basically the same as the referenced PR just using migrations instead of direct editing the install sql.\r\n\r\n### 5. Which documentation changes (if any) need to be made because of this PR?\r\n\r\n\r\n### 6. Checklist\r\n\r\n- [ ] I have written tests and verified that they fail without my change\r\n- [x] I have squashed any insignificant commits\r\n- [ ] This change has comments for package types, values, functions, and non-obvious lines of code\r\n- [x] I have read the contribution requirements and fulfil them."},"comment":{"url":"https://api.github.com/repos/shopware/shopware/issues/comments/371775208","html_url":"https://github.com/shopware/shopware/pull/1561#issuecomment-371775208","issue_url":"https://api.github.com/repos/shopware/shopware/issues/1561","id":371775208,"user":{"login":"shopwareBot","id":4725494,"avatar_url":"https://avatars1.githubusercontent.com/u/4725494?v=4","gravatar_id":"","url":"https://api.github.com/users/shopwareBot","html_url":"https://github.com/shopwareBot","followers_url":"https://api.github.com/users/shopwareBot/followers","following_url":"https://api.github.com/users/shopwareBot/following{/other_user}","gists_url":"https://api.github.com/users/shopwareBot/gists{/gist_id}","starred_url":"https://api.github.com/users/shopwareBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopwareBot/subscriptions","organizations_url":"https://api.github.com/users/shopwareBot/orgs","repos_url":"https://api.github.com/users/shopwareBot/repos","events_url":"https://api.github.com/users/shopwareBot/events{/privacy}","received_events_url":"https://api.github.com/users/shopwareBot/received_events","type":"User","site_admin":false},"created_at":"2018-03-09T10:30:13Z","updated_at":"2018-03-09T10:30:13Z","author_association":"NONE","body":"Hello,\n\nthank you for creating this pull request.\nI have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-21358\n\nPlease use this issue to track the state of your pull request."}}
{"actor":{"display_login":"shopwareBot"}}