{"action":"created","issue":{"url":"https://api.github.com/repos/MARKETProtocol/MARKET.js/issues/140","repository_url":"https://api.github.com/repos/MARKETProtocol/MARKET.js","labels_url":"https://api.github.com/repos/MARKETProtocol/MARKET.js/issues/140/labels{/name}","comments_url":"https://api.github.com/repos/MARKETProtocol/MARKET.js/issues/140/comments","events_url":"https://api.github.com/repos/MARKETProtocol/MARKET.js/issues/140/events","html_url":"https://github.com/MARKETProtocol/MARKET.js/issues/140","id":351662935,"node_id":"MDU6SXNzdWUzNTE2NjI5MzU=","number":140,"title":"add method for approveCollateralDepositAsync()","user":{"login":"pelsasser","id":15096737,"node_id":"MDQ6VXNlcjE1MDk2NzM3","avatar_url":"https://avatars1.githubusercontent.com/u/15096737?v=4","gravatar_id":"","url":"https://api.github.com/users/pelsasser","html_url":"https://github.com/pelsasser","followers_url":"https://api.github.com/users/pelsasser/followers","following_url":"https://api.github.com/users/pelsasser/following{/other_user}","gists_url":"https://api.github.com/users/pelsasser/gists{/gist_id}","starred_url":"https://api.github.com/users/pelsasser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelsasser/subscriptions","organizations_url":"https://api.github.com/users/pelsasser/orgs","repos_url":"https://api.github.com/users/pelsasser/repos","events_url":"https://api.github.com/users/pelsasser/events{/privacy}","received_events_url":"https://api.github.com/users/pelsasser/received_events","type":"User","site_admin":false},"labels":[{"id":918385848,"node_id":"MDU6TGFiZWw5MTgzODU4NDg=","url":"https://api.github.com/repos/MARKETProtocol/MARKET.js/labels/Good%20First%20Issue","name":"Good First Issue","color":"7057ff","default":false},{"id":918385846,"node_id":"MDU6TGFiZWw5MTgzODU4NDY=","url":"https://api.github.com/repos/MARKETProtocol/MARKET.js/labels/Help%20Wanted","name":"Help Wanted","color":"008672","default":false},{"id":918425252,"node_id":"MDU6TGFiZWw5MTg0MjUyNTI=","url":"https://api.github.com/repos/MARKETProtocol/MARKET.js/labels/Priority:%20High","name":"Priority: High","color":"eb6420","default":false},{"id":918425234,"node_id":"MDU6TGFiZWw5MTg0MjUyMzQ=","url":"https://api.github.com/repos/MARKETProtocol/MARKET.js/labels/Status:%20Available","name":"Status: Available","color":"bfe5bf","default":false},{"id":918425246,"node_id":"MDU6TGFiZWw5MTg0MjUyNDY=","url":"https://api.github.com/repos/MARKETProtocol/MARKET.js/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"84b6eb","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-17T16:41:40Z","updated_at":"2018-08-21T15:31:50Z","closed_at":null,"author_association":"MEMBER","body":"## Before you `start work`\r\n\r\nPlease read our contribution [guidelines](https://docs.marketprotocol.io/#contributing) and if there is a bounty involved  please also see [here](https://docs.marketprotocol.io/#gitcoin-and-bounties)\r\n\r\nIf you have ongoing work from other bounties with us where funding has not been released, please do not pick up a new issue.  We would like to involve as many contributors as possible and parallelize the work flow as much as possible.\r\n\r\nPlease make sure to comment in the issue here immediately after starting work so we know your plans for implementation and a timeline.\r\n\r\nPlease also note that in order for work to be accepted, all code must be accompanied by test cases as well.\r\n\r\n### User Story\r\nAs a user of market.js, I would really like to never worry about which contract address to use for which function call.  It get's confusing when I need to call an erc20 approve function on the collateral pool address, but market.js doesn't use those addresses any longer in its api.\r\n\r\nAn example can be seen here - https://github.com/MARKETProtocol/dApp/blob/bfe8b9f80915cd2ad325b729a126364e6aaff462/src/util/marketjs/marketMiddleware.js#L58\r\n\r\n\r\n### Why Is this Needed?\r\n*Summary*: simplify our api further and avoid confusion\r\n\r\n\r\n### Description\r\n*Type*: Feature\r\n\r\n### Solution\r\n*Summary*: add new function to simplify approve methods\r\n\r\n\r\n### Definition of Done\r\n- [ ] add `approveCollateralDepositAsync` method that accepts a market contract address (like all of our other functions), but creates the approval for the address of the MarketCollateralPool that is linked.  See `depositCollateralAsync` as an example, it uses the MarketContractAddress to find the linked MArketCollateralPool\r\n- [ ] add needed tests\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/MARKETProtocol/MARKET.js/issues/comments/414717403","html_url":"https://github.com/MARKETProtocol/MARKET.js/issues/140#issuecomment-414717403","issue_url":"https://api.github.com/repos/MARKETProtocol/MARKET.js/issues/140","id":414717403,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDcxNzQwMw==","user":{"login":"gitcoinbot","id":27903976,"node_id":"MDQ6VXNlcjI3OTAzOTc2","avatar_url":"https://avatars2.githubusercontent.com/u/27903976?v=4","gravatar_id":"","url":"https://api.github.com/users/gitcoinbot","html_url":"https://github.com/gitcoinbot","followers_url":"https://api.github.com/users/gitcoinbot/followers","following_url":"https://api.github.com/users/gitcoinbot/following{/other_user}","gists_url":"https://api.github.com/users/gitcoinbot/gists{/gist_id}","starred_url":"https://api.github.com/users/gitcoinbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitcoinbot/subscriptions","organizations_url":"https://api.github.com/users/gitcoinbot/orgs","repos_url":"https://api.github.com/users/gitcoinbot/repos","events_url":"https://api.github.com/users/gitcoinbot/events{/privacy}","received_events_url":"https://api.github.com/users/gitcoinbot/received_events","type":"User","site_admin":false},"created_at":"2018-08-21T15:31:50Z","updated_at":"2018-08-21T15:31:50Z","author_association":"NONE","body":"Issue Status: 1. **Open** 2. Started 3. Submitted 4. Done \n\n<hr>\n\n__This issue now has a funding of 0.3 ETH (83.23 USD @ $277.44/ETH)  attached to it.__\n\n * If you would like to work on this issue you can 'start work' [on the Gitcoin Issue Details page](https://gitcoin.co/issue/MARKETProtocol/MARKET.js/140/990).\n* Want to chip in? Add your own contribution [here](https://gitcoin.co/issue/MARKETProtocol/MARKET.js/140/990).\n* Questions? Checkout <a href='https://gitcoin.co/help'>Gitcoin Help</a> or the <a href='https://gitcoin.co/slack'>Gitcoin Slack</a>\n* $19,327.74 more funded OSS Work available on the [Gitcoin Issue Explorer](https://gitcoin.co/explorer)\n"}}
{"actor":{"display_login":"gitcoinbot"}}