{"push_id":2888867140,"size":12,"distinct_size":12,"ref":"refs/heads/lexer-stringliteral","head":"7b744cef824a2552971f1bc9600a27184acc718d","before":"038f47b69e1f46b70377bbc6566e51d9f962c594","commits":[{"sha":"776985af63792090db3b7b3987c52a7c1b8b2ab3","author":{"name":"Rintaro Ishizaki","email":"608792c47d349e08ac6d34c7d43a55323f331b0e@apple.com"},"message":"[Lexer] Add formStringLiteralToken dedicated for forming string literal","distinct":true,"url":"https://api.github.com/repos/rintaro/swift/commits/776985af63792090db3b7b3987c52a7c1b8b2ab3"},{"sha":"45c5c56e2acffd013e9196e54641b9f3b4dd9ae9","author":{"name":"Rintaro Ishizaki","email":"608792c47d349e08ac6d34c7d43a55323f331b0e@apple.com"},"message":"[Lexer] Fix double diagnostics for unterminated string literal\n\nWe should not emit diagnostics in skipToEndOfInterpolatedExpression()","distinct":true,"url":"https://api.github.com/repos/rintaro/swift/commits/45c5c56e2acffd013e9196e54641b9f3b4dd9ae9"},{"sha":"22764947b85a5f825979524d821558b46dc9dc31","author":{"name":"Rintaro Ishizaki","email":"608792c47d349e08ac6d34c7d43a55323f331b0e@apple.com"},"message":"[Lexer] Simplify handling quotes in skipToEndOfInterpolatedExpression()\n\nNFC","distinct":true,"url":"https://api.github.com/repos/rintaro/swift/commits/22764947b85a5f825979524d821558b46dc9dc31"},{"sha":"7b55f589f80f8df4de1c62742acb164276693e98","author":{"name":"Rintaro Ishizaki","email":"608792c47d349e08ac6d34c7d43a55323f331b0e@apple.com"},"message":"[Lexer] Don't emit diagnostics in skipToEndOfInterpolatedExpression()\n\nRemoved Diags parameter from it.\nSkipped bytes are revisited by main lexer function anyway. So emitting\ndiagnostics in it causes duplicated errors.","distinct":true,"url":"https://api.github.com/repos/rintaro/swift/commits/7b55f589f80f8df4de1c62742acb164276693e98"},{"sha":"93b4ad8af7e0e3a29c09873f996488144a5786ad","author":{"name":"Rintaro Ishizaki","email":"608792c47d349e08ac6d34c7d43a55323f331b0e@apple.com"},"message":"[Lexer] Add assertion in advanceIfCustomDelimiter()\n\nCurPtr[-1] must be '#' when called.","distinct":true,"url":"https://api.github.com/repos/rintaro/swift/commits/93b4ad8af7e0e3a29c09873f996488144a5786ad"},{"sha":"df802f8cb0fd16d7bc57c33ebd5773b7d0cb2964","author":{"name":"Rintaro Ishizaki","email":"608792c47d349e08ac6d34c7d43a55323f331b0e@apple.com"},"message":"[Lexer] Advance pointer to the end of end-quote in lexCharacter\n\nThis simplifies main lexStringLiteral loop","distinct":true,"url":"https://api.github.com/repos/rintaro/swift/commits/df802f8cb0fd16d7bc57c33ebd5773b7d0cb2964"},{"sha":"dbe82fdc5c49e419dffed845d481e2e5b62dfa86","author":{"name":"Rintaro Ishizaki","email":"608792c47d349e08ac6d34c7d43a55323f331b0e@apple.com"},"message":"[Lexer] Remove unnecessary logic from lexCharacter\n\nEOF and newline (in non-multiline string literal) must be handled by\ncall site. lexCharacter doesn't need to handle them. Added assertion\ninstead.","distinct":true,"url":"https://api.github.com/repos/rintaro/swift/commits/dbe82fdc5c49e419dffed845d481e2e5b62dfa86"},{"sha":"ed135c4bc0092e35b0607b5b704ab16cd069df53","author":{"name":"Rintaro Ishizaki","email":"608792c47d349e08ac6d34c7d43a55323f331b0e@apple.com"},"message":"[Lexer] Code tweaks in lexStringLiteral()\n\nNFC. Reorder code to improve readability.","distinct":true,"url":"https://api.github.com/repos/rintaro/swift/commits/ed135c4bc0092e35b0607b5b704ab16cd069df53"},{"sha":"816bd603d189845716a1c75e2ca409a856213b5c","author":{"name":"Rintaro Ishizaki","email":"608792c47d349e08ac6d34c7d43a55323f331b0e@apple.com"},"message":"[Lexer] Improve diagnostics for single-quote string literal\n\nIgnore the contents of interpolation.","distinct":true,"url":"https://api.github.com/repos/rintaro/swift/commits/816bd603d189845716a1c75e2ca409a856213b5c"},{"sha":"8aed77c6f94dc67bf7ad9c6c64b7e4ab802ac23d","author":{"name":"Rintaro Ishizaki","email":"608792c47d349e08ac6d34c7d43a55323f331b0e@apple.com"},"message":"[Lexer] Factor out diagnostics for single-quoted string literal\n\nFor readability.","distinct":true,"url":"https://api.github.com/repos/rintaro/swift/commits/8aed77c6f94dc67bf7ad9c6c64b7e4ab802ac23d"},{"sha":"396ff5ad1e7ad55c46d772c8344d41fe53891e6f","author":{"name":"Rintaro Ishizaki","email":"608792c47d349e08ac6d34c7d43a55323f331b0e@apple.com"},"message":"[Lexer] Improve fix-it to remove \"too long\" delimiter in string literal\n\nFix-it to remove extra '#'s at once.","distinct":true,"url":"https://api.github.com/repos/rintaro/swift/commits/396ff5ad1e7ad55c46d772c8344d41fe53891e6f"},{"sha":"7b744cef824a2552971f1bc9600a27184acc718d","author":{"name":"Rintaro Ishizaki","email":"608792c47d349e08ac6d34c7d43a55323f331b0e@apple.com"},"message":"[Lexer] Add a couple of test cases for extended escaping str literal","distinct":true,"url":"https://api.github.com/repos/rintaro/swift/commits/7b744cef824a2552971f1bc9600a27184acc718d"}]}
{"actor":{"display_login":"rintaro"}}