{"action":"created","comment":{"url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/comments/168339761","pull_request_review_id":96691131,"id":168339761,"diff_hunk":"@@ -115,60 +116,54 @@ export class AggregateReportFormSettingsResolve implements Resolve<AggregateRepo\n     settings.includeStateResults = query.includeState;\n     settings.schoolYears = query.schoolYears;\n     settings.subjects = query.subjectCodes;\n+    settings.valueDisplayType = query.valueDisplayType;\n \n-    if (query.achievementLevelDisplayType) {\n-      settings.performanceLevelDisplayType = query.achievementLevelDisplayType;\n-    }\n+    settings.completenesses = Utils.isNullOrEmpty(query.completenessCodes)\n+      ? valuesOf(options.completenesses)\n+      : query.completenessCodes;","path":"webapp/src/main/webapp/src/app/aggregate-report/aggregate-report-form-settings.resolve.ts","position":46,"original_position":46,"commit_id":"3f3efcc8ebe83ff92092278710bc794a35f96856","original_commit_id":"3f3efcc8ebe83ff92092278710bc794a35f96856","user":{"login":"esotrope","id":23462925,"avatar_url":"https://avatars3.githubusercontent.com/u/23462925?v=4","gravatar_id":"","url":"https://api.github.com/users/esotrope","html_url":"https://github.com/esotrope","followers_url":"https://api.github.com/users/esotrope/followers","following_url":"https://api.github.com/users/esotrope/following{/other_user}","gists_url":"https://api.github.com/users/esotrope/gists{/gist_id}","starred_url":"https://api.github.com/users/esotrope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esotrope/subscriptions","organizations_url":"https://api.github.com/users/esotrope/orgs","repos_url":"https://api.github.com/users/esotrope/repos","events_url":"https://api.github.com/users/esotrope/events{/privacy}","received_events_url":"https://api.github.com/users/esotrope/received_events","type":"User","site_admin":false},"body":"So it works when the default setting is All.\r\nIt does not work otherwise - because - how we optimize report query mapping on the front end. We remove the field from the query if All of the options are selected. See AggregateReportRequestMapper.\r\n\r\nWe could avoid this complication/confusion by doing the query \"simplification\" on the backend.\r\nWhich is what I'm thinking we should probably be doing. The backend should accept a sub-optimal query and simplify/optimize it for its own performance since backend performance is a backend concern right?\r\n\r\n@agorina thoughts?\r\n","created_at":"2018-02-14T23:08:12Z","updated_at":"2018-02-14T23:08:12Z","html_url":"https://github.com/SmarterApp/RDW_Reporting/pull/909#discussion_r168339761","pull_request_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/909","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/comments/168339761"},"html":{"href":"https://github.com/SmarterApp/RDW_Reporting/pull/909#discussion_r168339761"},"pull_request":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/909"}},"in_reply_to_id":168332882},"pull_request":{"url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/909","id":169241111,"html_url":"https://github.com/SmarterApp/RDW_Reporting/pull/909","diff_url":"https://github.com/SmarterApp/RDW_Reporting/pull/909.diff","patch_url":"https://github.com/SmarterApp/RDW_Reporting/pull/909.patch","issue_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/909","number":909,"state":"open","locked":false,"title":"Defect/update query admin conditions not reflecting query","user":{"login":"esotrope","id":23462925,"avatar_url":"https://avatars3.githubusercontent.com/u/23462925?v=4","gravatar_id":"","url":"https://api.github.com/users/esotrope","html_url":"https://github.com/esotrope","followers_url":"https://api.github.com/users/esotrope/followers","following_url":"https://api.github.com/users/esotrope/following{/other_user}","gists_url":"https://api.github.com/users/esotrope/gists{/gist_id}","starred_url":"https://api.github.com/users/esotrope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esotrope/subscriptions","organizations_url":"https://api.github.com/users/esotrope/orgs","repos_url":"https://api.github.com/users/esotrope/repos","events_url":"https://api.github.com/users/esotrope/events{/privacy}","received_events_url":"https://api.github.com/users/esotrope/received_events","type":"User","site_admin":false},"body":"fixes DWR-1434 and more","created_at":"2018-02-14T22:35:37Z","updated_at":"2018-02-14T23:08:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ffd41926b311bb6cbb0e3c485ef5cee5894c8b8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dsnyder-fairway","id":33040425,"avatar_url":"https://avatars1.githubusercontent.com/u/33040425?v=4","gravatar_id":"","url":"https://api.github.com/users/dsnyder-fairway","html_url":"https://github.com/dsnyder-fairway","followers_url":"https://api.github.com/users/dsnyder-fairway/followers","following_url":"https://api.github.com/users/dsnyder-fairway/following{/other_user}","gists_url":"https://api.github.com/users/dsnyder-fairway/gists{/gist_id}","starred_url":"https://api.github.com/users/dsnyder-fairway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsnyder-fairway/subscriptions","organizations_url":"https://api.github.com/users/dsnyder-fairway/orgs","repos_url":"https://api.github.com/users/dsnyder-fairway/repos","events_url":"https://api.github.com/users/dsnyder-fairway/events{/privacy}","received_events_url":"https://api.github.com/users/dsnyder-fairway/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/909/commits","review_comments_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/909/comments","review_comment_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/909/comments","statuses_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/statuses/3f3efcc8ebe83ff92092278710bc794a35f96856","head":{"label":"SmarterApp:defect/update-query-admin-conditions-not-reflecting-query","ref":"defect/update-query-admin-conditions-not-reflecting-query","sha":"3f3efcc8ebe83ff92092278710bc794a35f96856","user":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars0.githubusercontent.com/u/7026395?v=4","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"repo":{"id":81362154,"name":"RDW_Reporting","full_name":"SmarterApp/RDW_Reporting","owner":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars0.githubusercontent.com/u/7026395?v=4","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SmarterApp/RDW_Reporting","description":"RDW reporting tier (web app, backend services, etc.)","fork":false,"url":"https://api.github.com/repos/SmarterApp/RDW_Reporting","forks_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/forks","keys_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/teams","hooks_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/hooks","issue_events_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/events{/number}","events_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/events","assignees_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/assignees{/user}","branches_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/branches{/branch}","tags_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/tags","blobs_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/refs{/sha}","trees_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/statuses/{sha}","languages_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/languages","stargazers_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/stargazers","contributors_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/contributors","subscribers_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/subscribers","subscription_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/subscription","commits_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/commits{/sha}","git_commits_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/commits{/sha}","comments_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/comments{/number}","issue_comment_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/comments{/number}","contents_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/contents/{+path}","compare_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/merges","archive_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/downloads","issues_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues{/number}","pulls_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls{/number}","milestones_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/milestones{/number}","notifications_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/labels{/name}","releases_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/releases{/id}","deployments_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/deployments","created_at":"2017-02-08T18:31:23Z","updated_at":"2017-08-01T00:10:23Z","pushed_at":"2018-02-14T23:07:44Z","git_url":"git://github.com/SmarterApp/RDW_Reporting.git","ssh_url":"git@github.com:SmarterApp/RDW_Reporting.git","clone_url":"https://github.com/SmarterApp/RDW_Reporting.git","svn_url":"https://github.com/SmarterApp/RDW_Reporting","homepage":null,"size":22534,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":2,"watchers":0,"default_branch":"develop"}},"base":{"label":"SmarterApp:develop","ref":"develop","sha":"b666f8dcba0996f24076c88e3e297fa0f75eb2da","user":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars0.githubusercontent.com/u/7026395?v=4","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"repo":{"id":81362154,"name":"RDW_Reporting","full_name":"SmarterApp/RDW_Reporting","owner":{"login":"SmarterApp","id":7026395,"avatar_url":"https://avatars0.githubusercontent.com/u/7026395?v=4","gravatar_id":"","url":"https://api.github.com/users/SmarterApp","html_url":"https://github.com/SmarterApp","followers_url":"https://api.github.com/users/SmarterApp/followers","following_url":"https://api.github.com/users/SmarterApp/following{/other_user}","gists_url":"https://api.github.com/users/SmarterApp/gists{/gist_id}","starred_url":"https://api.github.com/users/SmarterApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmarterApp/subscriptions","organizations_url":"https://api.github.com/users/SmarterApp/orgs","repos_url":"https://api.github.com/users/SmarterApp/repos","events_url":"https://api.github.com/users/SmarterApp/events{/privacy}","received_events_url":"https://api.github.com/users/SmarterApp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SmarterApp/RDW_Reporting","description":"RDW reporting tier (web app, backend services, etc.)","fork":false,"url":"https://api.github.com/repos/SmarterApp/RDW_Reporting","forks_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/forks","keys_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/teams","hooks_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/hooks","issue_events_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/events{/number}","events_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/events","assignees_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/assignees{/user}","branches_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/branches{/branch}","tags_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/tags","blobs_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/refs{/sha}","trees_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/statuses/{sha}","languages_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/languages","stargazers_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/stargazers","contributors_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/contributors","subscribers_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/subscribers","subscription_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/subscription","commits_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/commits{/sha}","git_commits_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/git/commits{/sha}","comments_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/comments{/number}","issue_comment_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/comments{/number}","contents_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/contents/{+path}","compare_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/merges","archive_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/downloads","issues_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues{/number}","pulls_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls{/number}","milestones_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/milestones{/number}","notifications_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/labels{/name}","releases_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/releases{/id}","deployments_url":"https://api.github.com/repos/SmarterApp/RDW_Reporting/deployments","created_at":"2017-02-08T18:31:23Z","updated_at":"2017-08-01T00:10:23Z","pushed_at":"2018-02-14T23:07:44Z","git_url":"git://github.com/SmarterApp/RDW_Reporting.git","ssh_url":"git@github.com:SmarterApp/RDW_Reporting.git","clone_url":"https://github.com/SmarterApp/RDW_Reporting.git","svn_url":"https://github.com/SmarterApp/RDW_Reporting","homepage":null,"size":22534,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":2,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/909"},"html":{"href":"https://github.com/SmarterApp/RDW_Reporting/pull/909"},"issue":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/909"},"comments":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/issues/909/comments"},"review_comments":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/909/comments"},"review_comment":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/pulls/909/commits"},"statuses":{"href":"https://api.github.com/repos/SmarterApp/RDW_Reporting/statuses/3f3efcc8ebe83ff92092278710bc794a35f96856"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"esotrope"}}