{"action":"created","comment":{"url":"https://api.github.com/repos/flathub/flathub/pulls/comments/231256709","pull_request_review_id":172188316,"id":231256709,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTI1NjcwOQ==","diff_hunk":"@@ -0,0 +1,54 @@\n+name: widelands\n+buildsystem: cmake-ninja\n+builddir: true\n+config-opts:\n+  - -DCMAKE_BUILD_TYPE=Release\n+  - -DCMAKE_INSTALL_PREFIX=/app/bin\n+  - -DWL_INSTALL_BASEDIR=/app/share/widelands\n+  - -DWL_INSTALL_DATADIR=/app/share/widelands\n+  - -DBOOST_ROOT=/app\n+  - -DGLEW_ROOT=/app\n+  - -DGLEW_GLEW_LIBRARY=/app/lib/libGLEW.so\n+  - -DGLEW_INCLUDE_DIR=/app/include/GL\n+  # https://wl.widelands.org/forum/topic/1343/?page=3 & https://wl.widelands.org/forum/post/9857/\n+  - -DGLEW_LIBRARY:FILEPATH=/app/lib/libGLEW.a\n+  - -DOPENGL_glu_LIBRARY=/app/lib/libGLU.a\n+  - -DOPTION_BUILD_WEBSITE_TOOLS=OFF\n+sources:\n+  # Source0\n+  - type: archive\n+    url: https://launchpad.net/widelands/build19/build19/+download/widelands-build19-src-gcc7.tar.bz2\n+    sha256: ef73b8cf5a7c680bad5caade907f1cc6ee88dd3729470b9214a3c72658585458\n+  # Source1 - Numix-Circle - numix-icon-theme-circle-0.1.0-13.git5a11140.el7.src.rpm\n+  - type: file\n+    path: widelands.svg\n+    sha256: 4f860318acb3271b7cf6dcc6ba53fa265977d66894597195bea3b82d35b22335\n+  # Patch0\n+  - type: patch\n+    path: widelands-build19-ppc64le.patch\n+    strip-components: 1\n+    only-arches:\n+      - ppc64le\n+    sha256: 6ecebb71541c726c591e15ea693a01beb0173fa2040283153d958df456ce735b\n+  # Patch1\n+  # https://bugs.launchpad.net/widelands/+bug/1760581\n+  - type: patch\n+    path: widelands-build19-icu-bidi.patch\n+    strip-components: 1\n+    sha256: 651f6d7ea6843752032872c4a20014418d52c5fa01dc72d4ede1d4f030206742\n+  - type: file","path":"widelands.yaml","position":39,"original_position":39,"commit_id":"4b76d59262f97c3072304f13dbe4a3e1fc2be742","original_commit_id":"371bb09ad019c452859884b410cbf12ea12d8d7c","user":{"login":"scx","id":510369,"node_id":"MDQ6VXNlcjUxMDM2OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/510369?v=4","gravatar_id":"","url":"https://api.github.com/users/scx","html_url":"https://github.com/scx","followers_url":"https://api.github.com/users/scx/followers","following_url":"https://api.github.com/users/scx/following{/other_user}","gists_url":"https://api.github.com/users/scx/gists{/gist_id}","starred_url":"https://api.github.com/users/scx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scx/subscriptions","organizations_url":"https://api.github.com/users/scx/orgs","repos_url":"https://api.github.com/users/scx/repos","events_url":"https://api.github.com/users/scx/events{/privacy}","received_events_url":"https://api.github.com/users/scx/received_events","type":"User","site_admin":false},"body":"> We concluded that these scripts are largely overcomplicated and there should be at most one, not multiple files.\r\n\r\nI see only one person who complain about that... In this particular case, one script should be enough, but in general, a division into pre-install and post-install actions is required.","created_at":"2018-11-06T19:18:15Z","updated_at":"2018-11-06T19:18:15Z","html_url":"https://github.com/flathub/flathub/pull/394#discussion_r231256709","pull_request_url":"https://api.github.com/repos/flathub/flathub/pulls/394","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/flathub/flathub/pulls/comments/231256709"},"html":{"href":"https://github.com/flathub/flathub/pull/394#discussion_r231256709"},"pull_request":{"href":"https://api.github.com/repos/flathub/flathub/pulls/394"}},"in_reply_to_id":230944314},"pull_request":{"url":"https://api.github.com/repos/flathub/flathub/pulls/394","id":188535095,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg4NTM1MDk1","html_url":"https://github.com/flathub/flathub/pull/394","diff_url":"https://github.com/flathub/flathub/pull/394.diff","patch_url":"https://github.com/flathub/flathub/pull/394.patch","issue_url":"https://api.github.com/repos/flathub/flathub/issues/394","number":394,"state":"open","locked":false,"title":"org.widelands.widelands (widelands-flatpak)","user":{"login":"scx","id":510369,"node_id":"MDQ6VXNlcjUxMDM2OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/510369?v=4","gravatar_id":"","url":"https://api.github.com/users/scx","html_url":"https://github.com/scx","followers_url":"https://api.github.com/users/scx/followers","following_url":"https://api.github.com/users/scx/following{/other_user}","gists_url":"https://api.github.com/users/scx/gists{/gist_id}","starred_url":"https://api.github.com/users/scx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scx/subscriptions","organizations_url":"https://api.github.com/users/scx/orgs","repos_url":"https://api.github.com/users/scx/repos","events_url":"https://api.github.com/users/scx/events{/privacy}","received_events_url":"https://api.github.com/users/scx/received_events","type":"User","site_admin":false},"body":"**Widelands** is an open source (GPLed), realtime-strategy game.\r\n\r\nSee `README.md` for details.","created_at":"2018-05-16T19:25:51Z","updated_at":"2018-11-06T19:18:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4482c8c5e0fdd6811cbc1522069521d8982c0e33","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":693658182,"node_id":"MDU6TGFiZWw2OTM2NTgxODI=","url":"https://api.github.com/repos/flathub/flathub/labels/awaiting-changes","name":"awaiting-changes","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flathub/flathub/pulls/394/commits","review_comments_url":"https://api.github.com/repos/flathub/flathub/pulls/394/comments","review_comment_url":"https://api.github.com/repos/flathub/flathub/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flathub/flathub/issues/394/comments","statuses_url":"https://api.github.com/repos/flathub/flathub/statuses/4b76d59262f97c3072304f13dbe4a3e1fc2be742","head":{"label":"scx:org.widelands.widelands","ref":"org.widelands.widelands","sha":"4b76d59262f97c3072304f13dbe4a3e1fc2be742","user":{"login":"scx","id":510369,"node_id":"MDQ6VXNlcjUxMDM2OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/510369?v=4","gravatar_id":"","url":"https://api.github.com/users/scx","html_url":"https://github.com/scx","followers_url":"https://api.github.com/users/scx/followers","following_url":"https://api.github.com/users/scx/following{/other_user}","gists_url":"https://api.github.com/users/scx/gists{/gist_id}","starred_url":"https://api.github.com/users/scx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scx/subscriptions","organizations_url":"https://api.github.com/users/scx/orgs","repos_url":"https://api.github.com/users/scx/repos","events_url":"https://api.github.com/users/scx/events{/privacy}","received_events_url":"https://api.github.com/users/scx/received_events","type":"User","site_admin":false},"repo":{"id":132365928,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIzNjU5Mjg=","name":"flathub","full_name":"scx/flathub","private":false,"owner":{"login":"scx","id":510369,"node_id":"MDQ6VXNlcjUxMDM2OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/510369?v=4","gravatar_id":"","url":"https://api.github.com/users/scx","html_url":"https://github.com/scx","followers_url":"https://api.github.com/users/scx/followers","following_url":"https://api.github.com/users/scx/following{/other_user}","gists_url":"https://api.github.com/users/scx/gists{/gist_id}","starred_url":"https://api.github.com/users/scx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scx/subscriptions","organizations_url":"https://api.github.com/users/scx/orgs","repos_url":"https://api.github.com/users/scx/repos","events_url":"https://api.github.com/users/scx/events{/privacy}","received_events_url":"https://api.github.com/users/scx/received_events","type":"User","site_admin":false},"html_url":"https://github.com/scx/flathub","description":"Pull requests for new applications to be added","fork":true,"url":"https://api.github.com/repos/scx/flathub","forks_url":"https://api.github.com/repos/scx/flathub/forks","keys_url":"https://api.github.com/repos/scx/flathub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scx/flathub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scx/flathub/teams","hooks_url":"https://api.github.com/repos/scx/flathub/hooks","issue_events_url":"https://api.github.com/repos/scx/flathub/issues/events{/number}","events_url":"https://api.github.com/repos/scx/flathub/events","assignees_url":"https://api.github.com/repos/scx/flathub/assignees{/user}","branches_url":"https://api.github.com/repos/scx/flathub/branches{/branch}","tags_url":"https://api.github.com/repos/scx/flathub/tags","blobs_url":"https://api.github.com/repos/scx/flathub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scx/flathub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scx/flathub/git/refs{/sha}","trees_url":"https://api.github.com/repos/scx/flathub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scx/flathub/statuses/{sha}","languages_url":"https://api.github.com/repos/scx/flathub/languages","stargazers_url":"https://api.github.com/repos/scx/flathub/stargazers","contributors_url":"https://api.github.com/repos/scx/flathub/contributors","subscribers_url":"https://api.github.com/repos/scx/flathub/subscribers","subscription_url":"https://api.github.com/repos/scx/flathub/subscription","commits_url":"https://api.github.com/repos/scx/flathub/commits{/sha}","git_commits_url":"https://api.github.com/repos/scx/flathub/git/commits{/sha}","comments_url":"https://api.github.com/repos/scx/flathub/comments{/number}","issue_comment_url":"https://api.github.com/repos/scx/flathub/issues/comments{/number}","contents_url":"https://api.github.com/repos/scx/flathub/contents/{+path}","compare_url":"https://api.github.com/repos/scx/flathub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scx/flathub/merges","archive_url":"https://api.github.com/repos/scx/flathub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scx/flathub/downloads","issues_url":"https://api.github.com/repos/scx/flathub/issues{/number}","pulls_url":"https://api.github.com/repos/scx/flathub/pulls{/number}","milestones_url":"https://api.github.com/repos/scx/flathub/milestones{/number}","notifications_url":"https://api.github.com/repos/scx/flathub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scx/flathub/labels{/name}","releases_url":"https://api.github.com/repos/scx/flathub/releases{/id}","deployments_url":"https://api.github.com/repos/scx/flathub/deployments","created_at":"2018-05-06T18:39:26Z","updated_at":"2018-05-06T18:39:28Z","pushed_at":"2018-11-05T23:02:58Z","git_url":"git://github.com/scx/flathub.git","ssh_url":"git@github.com:scx/flathub.git","clone_url":"https://github.com/scx/flathub.git","svn_url":"https://github.com/scx/flathub","homepage":"https://flathub.org","size":150683,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flathub:new-pr","ref":"new-pr","sha":"746ea89cc4ff85ad2dbc05fb47efde23de4062f8","user":{"login":"flathub","id":27268838,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MjY4ODM4","avatar_url":"https://avatars2.githubusercontent.com/u/27268838?v=4","gravatar_id":"","url":"https://api.github.com/users/flathub","html_url":"https://github.com/flathub","followers_url":"https://api.github.com/users/flathub/followers","following_url":"https://api.github.com/users/flathub/following{/other_user}","gists_url":"https://api.github.com/users/flathub/gists{/gist_id}","starred_url":"https://api.github.com/users/flathub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flathub/subscriptions","organizations_url":"https://api.github.com/users/flathub/orgs","repos_url":"https://api.github.com/users/flathub/repos","events_url":"https://api.github.com/users/flathub/events{/privacy}","received_events_url":"https://api.github.com/users/flathub/received_events","type":"Organization","site_admin":false},"repo":{"id":88860262,"node_id":"MDEwOlJlcG9zaXRvcnk4ODg2MDI2Mg==","name":"flathub","full_name":"flathub/flathub","private":false,"owner":{"login":"flathub","id":27268838,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3MjY4ODM4","avatar_url":"https://avatars2.githubusercontent.com/u/27268838?v=4","gravatar_id":"","url":"https://api.github.com/users/flathub","html_url":"https://github.com/flathub","followers_url":"https://api.github.com/users/flathub/followers","following_url":"https://api.github.com/users/flathub/following{/other_user}","gists_url":"https://api.github.com/users/flathub/gists{/gist_id}","starred_url":"https://api.github.com/users/flathub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flathub/subscriptions","organizations_url":"https://api.github.com/users/flathub/orgs","repos_url":"https://api.github.com/users/flathub/repos","events_url":"https://api.github.com/users/flathub/events{/privacy}","received_events_url":"https://api.github.com/users/flathub/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flathub/flathub","description":"Pull requests for new applications to be added","fork":false,"url":"https://api.github.com/repos/flathub/flathub","forks_url":"https://api.github.com/repos/flathub/flathub/forks","keys_url":"https://api.github.com/repos/flathub/flathub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flathub/flathub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flathub/flathub/teams","hooks_url":"https://api.github.com/repos/flathub/flathub/hooks","issue_events_url":"https://api.github.com/repos/flathub/flathub/issues/events{/number}","events_url":"https://api.github.com/repos/flathub/flathub/events","assignees_url":"https://api.github.com/repos/flathub/flathub/assignees{/user}","branches_url":"https://api.github.com/repos/flathub/flathub/branches{/branch}","tags_url":"https://api.github.com/repos/flathub/flathub/tags","blobs_url":"https://api.github.com/repos/flathub/flathub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flathub/flathub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flathub/flathub/git/refs{/sha}","trees_url":"https://api.github.com/repos/flathub/flathub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flathub/flathub/statuses/{sha}","languages_url":"https://api.github.com/repos/flathub/flathub/languages","stargazers_url":"https://api.github.com/repos/flathub/flathub/stargazers","contributors_url":"https://api.github.com/repos/flathub/flathub/contributors","subscribers_url":"https://api.github.com/repos/flathub/flathub/subscribers","subscription_url":"https://api.github.com/repos/flathub/flathub/subscription","commits_url":"https://api.github.com/repos/flathub/flathub/commits{/sha}","git_commits_url":"https://api.github.com/repos/flathub/flathub/git/commits{/sha}","comments_url":"https://api.github.com/repos/flathub/flathub/comments{/number}","issue_comment_url":"https://api.github.com/repos/flathub/flathub/issues/comments{/number}","contents_url":"https://api.github.com/repos/flathub/flathub/contents/{+path}","compare_url":"https://api.github.com/repos/flathub/flathub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flathub/flathub/merges","archive_url":"https://api.github.com/repos/flathub/flathub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flathub/flathub/downloads","issues_url":"https://api.github.com/repos/flathub/flathub/issues{/number}","pulls_url":"https://api.github.com/repos/flathub/flathub/pulls{/number}","milestones_url":"https://api.github.com/repos/flathub/flathub/milestones{/number}","notifications_url":"https://api.github.com/repos/flathub/flathub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flathub/flathub/labels{/name}","releases_url":"https://api.github.com/repos/flathub/flathub/releases{/id}","deployments_url":"https://api.github.com/repos/flathub/flathub/deployments","created_at":"2017-04-20T11:55:49Z","updated_at":"2018-10-28T07:42:19Z","pushed_at":"2018-11-06T17:59:58Z","git_url":"git://github.com/flathub/flathub.git","ssh_url":"git@github.com:flathub/flathub.git","clone_url":"https://github.com/flathub/flathub.git","svn_url":"https://github.com/flathub/flathub","homepage":"https://flathub.org","size":33,"stargazers_count":192,"watchers_count":192,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":241,"mirror_url":null,"archived":false,"open_issues_count":99,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":241,"open_issues":99,"watchers":192,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flathub/flathub/pulls/394"},"html":{"href":"https://github.com/flathub/flathub/pull/394"},"issue":{"href":"https://api.github.com/repos/flathub/flathub/issues/394"},"comments":{"href":"https://api.github.com/repos/flathub/flathub/issues/394/comments"},"review_comments":{"href":"https://api.github.com/repos/flathub/flathub/pulls/394/comments"},"review_comment":{"href":"https://api.github.com/repos/flathub/flathub/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flathub/flathub/pulls/394/commits"},"statuses":{"href":"https://api.github.com/repos/flathub/flathub/statuses/4b76d59262f97c3072304f13dbe4a3e1fc2be742"}},"author_association":"NONE"}}
{"actor":{"display_login":"scx"}}