{"action":"created","comment":{"url":"https://api.github.com/repos/paparazzi/paparazzi/pulls/comments/238995824","pull_request_review_id":181669774,"id":238995824,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODk5NTgyNA==","diff_hunk":"@@ -2,8 +2,8 @@\n   <rows>\n     <widget NAME=\"map2d\" SIZE=\"500\">\n       <papget type=\"message_field\" display=\"text\" x=\"5\" y=\"125\">\n-        <property name=\"field\" value=\"BAT:energy\"/>\n-        <property name=\"scale\" value=\"1\"/>\n+        <property name=\"field\" value=\"Energy:charge\"/>","path":"conf/gcs/solar.xml","position":6,"original_position":6,"commit_id":"a24758384ecff6723c11451dbfaa316c3817ac6a","original_commit_id":"a24758384ecff6723c11451dbfaa316c3817ac6a","user":{"login":"kirkscheper","id":2835523,"node_id":"MDQ6VXNlcjI4MzU1MjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2835523?v=4","gravatar_id":"","url":"https://api.github.com/users/kirkscheper","html_url":"https://github.com/kirkscheper","followers_url":"https://api.github.com/users/kirkscheper/followers","following_url":"https://api.github.com/users/kirkscheper/following{/other_user}","gists_url":"https://api.github.com/users/kirkscheper/gists{/gist_id}","starred_url":"https://api.github.com/users/kirkscheper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirkscheper/subscriptions","organizations_url":"https://api.github.com/users/kirkscheper/orgs","repos_url":"https://api.github.com/users/kirkscheper/repos","events_url":"https://api.github.com/users/kirkscheper/events{/privacy}","received_events_url":"https://api.github.com/users/kirkscheper/received_events","type":"User","site_admin":false},"body":"tnx","created_at":"2018-12-05T09:53:49Z","updated_at":"2018-12-05T09:54:29Z","html_url":"https://github.com/paparazzi/paparazzi/pull/2360#discussion_r238995824","pull_request_url":"https://api.github.com/repos/paparazzi/paparazzi/pulls/2360","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/paparazzi/paparazzi/pulls/comments/238995824"},"html":{"href":"https://github.com/paparazzi/paparazzi/pull/2360#discussion_r238995824"},"pull_request":{"href":"https://api.github.com/repos/paparazzi/paparazzi/pulls/2360"}},"in_reply_to_id":238844076},"pull_request":{"url":"https://api.github.com/repos/paparazzi/paparazzi/pulls/2360","id":233987407,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzOTg3NDA3","html_url":"https://github.com/paparazzi/paparazzi/pull/2360","diff_url":"https://github.com/paparazzi/paparazzi/pull/2360.diff","patch_url":"https://github.com/paparazzi/paparazzi/pull/2360.patch","issue_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/2360","number":2360,"state":"open","locked":false,"title":"upgrade voltage and current to float","user":{"login":"kirkscheper","id":2835523,"node_id":"MDQ6VXNlcjI4MzU1MjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2835523?v=4","gravatar_id":"","url":"https://api.github.com/users/kirkscheper","html_url":"https://github.com/kirkscheper","followers_url":"https://api.github.com/users/kirkscheper/followers","following_url":"https://api.github.com/users/kirkscheper/following{/other_user}","gists_url":"https://api.github.com/users/kirkscheper/gists{/gist_id}","starred_url":"https://api.github.com/users/kirkscheper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirkscheper/subscriptions","organizations_url":"https://api.github.com/users/kirkscheper/orgs","repos_url":"https://api.github.com/users/kirkscheper/repos","events_url":"https://api.github.com/users/kirkscheper/events{/privacy}","received_events_url":"https://api.github.com/users/kirkscheper/received_events","type":"User","site_admin":false},"body":"This should comprehensively address #2313. This was much more work than I had first thought it would be but I think this updates the voltage and current in every part of pprz. Additionally, I clarified the difference between charge and energy in the electrical module and messages.\r\n\r\nNote, some of the components of the BAT message have been removed as they were already contained in the (ROTORCRAFT_)NAV_STATUS messages.\r\n\r\nI tested this in sim, nps and on a bebop but this will need a thorough review before merging. I look forward to your comments!","created_at":"2018-11-27T16:55:50Z","updated_at":"2018-12-05T09:54:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48b5987184a70a645a27da926fc5087d8a89f87c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/paparazzi/paparazzi/pulls/2360/commits","review_comments_url":"https://api.github.com/repos/paparazzi/paparazzi/pulls/2360/comments","review_comment_url":"https://api.github.com/repos/paparazzi/paparazzi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/2360/comments","statuses_url":"https://api.github.com/repos/paparazzi/paparazzi/statuses/a24758384ecff6723c11451dbfaa316c3817ac6a","head":{"label":"paparazzi:bat_energy","ref":"bat_energy","sha":"a24758384ecff6723c11451dbfaa316c3817ac6a","user":{"login":"paparazzi","id":318080,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxODA4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/318080?v=4","gravatar_id":"","url":"https://api.github.com/users/paparazzi","html_url":"https://github.com/paparazzi","followers_url":"https://api.github.com/users/paparazzi/followers","following_url":"https://api.github.com/users/paparazzi/following{/other_user}","gists_url":"https://api.github.com/users/paparazzi/gists{/gist_id}","starred_url":"https://api.github.com/users/paparazzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paparazzi/subscriptions","organizations_url":"https://api.github.com/users/paparazzi/orgs","repos_url":"https://api.github.com/users/paparazzi/repos","events_url":"https://api.github.com/users/paparazzi/events{/privacy}","received_events_url":"https://api.github.com/users/paparazzi/received_events","type":"Organization","site_admin":false},"repo":{"id":1068018,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY4MDE4","name":"paparazzi","full_name":"paparazzi/paparazzi","private":false,"owner":{"login":"paparazzi","id":318080,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxODA4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/318080?v=4","gravatar_id":"","url":"https://api.github.com/users/paparazzi","html_url":"https://github.com/paparazzi","followers_url":"https://api.github.com/users/paparazzi/followers","following_url":"https://api.github.com/users/paparazzi/following{/other_user}","gists_url":"https://api.github.com/users/paparazzi/gists{/gist_id}","starred_url":"https://api.github.com/users/paparazzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paparazzi/subscriptions","organizations_url":"https://api.github.com/users/paparazzi/orgs","repos_url":"https://api.github.com/users/paparazzi/repos","events_url":"https://api.github.com/users/paparazzi/events{/privacy}","received_events_url":"https://api.github.com/users/paparazzi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/paparazzi/paparazzi","description":"Paparazzi is a free and open-source hardware and software project for unmanned (air) vehicles. This is the main software repository.","fork":false,"url":"https://api.github.com/repos/paparazzi/paparazzi","forks_url":"https://api.github.com/repos/paparazzi/paparazzi/forks","keys_url":"https://api.github.com/repos/paparazzi/paparazzi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paparazzi/paparazzi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paparazzi/paparazzi/teams","hooks_url":"https://api.github.com/repos/paparazzi/paparazzi/hooks","issue_events_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/events{/number}","events_url":"https://api.github.com/repos/paparazzi/paparazzi/events","assignees_url":"https://api.github.com/repos/paparazzi/paparazzi/assignees{/user}","branches_url":"https://api.github.com/repos/paparazzi/paparazzi/branches{/branch}","tags_url":"https://api.github.com/repos/paparazzi/paparazzi/tags","blobs_url":"https://api.github.com/repos/paparazzi/paparazzi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paparazzi/paparazzi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paparazzi/paparazzi/git/refs{/sha}","trees_url":"https://api.github.com/repos/paparazzi/paparazzi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paparazzi/paparazzi/statuses/{sha}","languages_url":"https://api.github.com/repos/paparazzi/paparazzi/languages","stargazers_url":"https://api.github.com/repos/paparazzi/paparazzi/stargazers","contributors_url":"https://api.github.com/repos/paparazzi/paparazzi/contributors","subscribers_url":"https://api.github.com/repos/paparazzi/paparazzi/subscribers","subscription_url":"https://api.github.com/repos/paparazzi/paparazzi/subscription","commits_url":"https://api.github.com/repos/paparazzi/paparazzi/commits{/sha}","git_commits_url":"https://api.github.com/repos/paparazzi/paparazzi/git/commits{/sha}","comments_url":"https://api.github.com/repos/paparazzi/paparazzi/comments{/number}","issue_comment_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/comments{/number}","contents_url":"https://api.github.com/repos/paparazzi/paparazzi/contents/{+path}","compare_url":"https://api.github.com/repos/paparazzi/paparazzi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paparazzi/paparazzi/merges","archive_url":"https://api.github.com/repos/paparazzi/paparazzi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paparazzi/paparazzi/downloads","issues_url":"https://api.github.com/repos/paparazzi/paparazzi/issues{/number}","pulls_url":"https://api.github.com/repos/paparazzi/paparazzi/pulls{/number}","milestones_url":"https://api.github.com/repos/paparazzi/paparazzi/milestones{/number}","notifications_url":"https://api.github.com/repos/paparazzi/paparazzi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paparazzi/paparazzi/labels{/name}","releases_url":"https://api.github.com/repos/paparazzi/paparazzi/releases{/id}","deployments_url":"https://api.github.com/repos/paparazzi/paparazzi/deployments","created_at":"2010-11-10T11:14:08Z","updated_at":"2018-12-04T07:48:48Z","pushed_at":"2018-12-04T11:43:05Z","git_url":"git://github.com/paparazzi/paparazzi.git","ssh_url":"git@github.com:paparazzi/paparazzi.git","clone_url":"https://github.com/paparazzi/paparazzi.git","svn_url":"https://github.com/paparazzi/paparazzi","homepage":"http://paparazziuav.org","size":75731,"stargazers_count":898,"watchers_count":898,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":828,"mirror_url":null,"archived":false,"open_issues_count":86,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":828,"open_issues":86,"watchers":898,"default_branch":"master"}},"base":{"label":"paparazzi:master","ref":"master","sha":"f264ef2bed038a294d3b57f15978850d6bdc4dd3","user":{"login":"paparazzi","id":318080,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxODA4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/318080?v=4","gravatar_id":"","url":"https://api.github.com/users/paparazzi","html_url":"https://github.com/paparazzi","followers_url":"https://api.github.com/users/paparazzi/followers","following_url":"https://api.github.com/users/paparazzi/following{/other_user}","gists_url":"https://api.github.com/users/paparazzi/gists{/gist_id}","starred_url":"https://api.github.com/users/paparazzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paparazzi/subscriptions","organizations_url":"https://api.github.com/users/paparazzi/orgs","repos_url":"https://api.github.com/users/paparazzi/repos","events_url":"https://api.github.com/users/paparazzi/events{/privacy}","received_events_url":"https://api.github.com/users/paparazzi/received_events","type":"Organization","site_admin":false},"repo":{"id":1068018,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY4MDE4","name":"paparazzi","full_name":"paparazzi/paparazzi","private":false,"owner":{"login":"paparazzi","id":318080,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxODA4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/318080?v=4","gravatar_id":"","url":"https://api.github.com/users/paparazzi","html_url":"https://github.com/paparazzi","followers_url":"https://api.github.com/users/paparazzi/followers","following_url":"https://api.github.com/users/paparazzi/following{/other_user}","gists_url":"https://api.github.com/users/paparazzi/gists{/gist_id}","starred_url":"https://api.github.com/users/paparazzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paparazzi/subscriptions","organizations_url":"https://api.github.com/users/paparazzi/orgs","repos_url":"https://api.github.com/users/paparazzi/repos","events_url":"https://api.github.com/users/paparazzi/events{/privacy}","received_events_url":"https://api.github.com/users/paparazzi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/paparazzi/paparazzi","description":"Paparazzi is a free and open-source hardware and software project for unmanned (air) vehicles. This is the main software repository.","fork":false,"url":"https://api.github.com/repos/paparazzi/paparazzi","forks_url":"https://api.github.com/repos/paparazzi/paparazzi/forks","keys_url":"https://api.github.com/repos/paparazzi/paparazzi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paparazzi/paparazzi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paparazzi/paparazzi/teams","hooks_url":"https://api.github.com/repos/paparazzi/paparazzi/hooks","issue_events_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/events{/number}","events_url":"https://api.github.com/repos/paparazzi/paparazzi/events","assignees_url":"https://api.github.com/repos/paparazzi/paparazzi/assignees{/user}","branches_url":"https://api.github.com/repos/paparazzi/paparazzi/branches{/branch}","tags_url":"https://api.github.com/repos/paparazzi/paparazzi/tags","blobs_url":"https://api.github.com/repos/paparazzi/paparazzi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paparazzi/paparazzi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paparazzi/paparazzi/git/refs{/sha}","trees_url":"https://api.github.com/repos/paparazzi/paparazzi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paparazzi/paparazzi/statuses/{sha}","languages_url":"https://api.github.com/repos/paparazzi/paparazzi/languages","stargazers_url":"https://api.github.com/repos/paparazzi/paparazzi/stargazers","contributors_url":"https://api.github.com/repos/paparazzi/paparazzi/contributors","subscribers_url":"https://api.github.com/repos/paparazzi/paparazzi/subscribers","subscription_url":"https://api.github.com/repos/paparazzi/paparazzi/subscription","commits_url":"https://api.github.com/repos/paparazzi/paparazzi/commits{/sha}","git_commits_url":"https://api.github.com/repos/paparazzi/paparazzi/git/commits{/sha}","comments_url":"https://api.github.com/repos/paparazzi/paparazzi/comments{/number}","issue_comment_url":"https://api.github.com/repos/paparazzi/paparazzi/issues/comments{/number}","contents_url":"https://api.github.com/repos/paparazzi/paparazzi/contents/{+path}","compare_url":"https://api.github.com/repos/paparazzi/paparazzi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paparazzi/paparazzi/merges","archive_url":"https://api.github.com/repos/paparazzi/paparazzi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paparazzi/paparazzi/downloads","issues_url":"https://api.github.com/repos/paparazzi/paparazzi/issues{/number}","pulls_url":"https://api.github.com/repos/paparazzi/paparazzi/pulls{/number}","milestones_url":"https://api.github.com/repos/paparazzi/paparazzi/milestones{/number}","notifications_url":"https://api.github.com/repos/paparazzi/paparazzi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paparazzi/paparazzi/labels{/name}","releases_url":"https://api.github.com/repos/paparazzi/paparazzi/releases{/id}","deployments_url":"https://api.github.com/repos/paparazzi/paparazzi/deployments","created_at":"2010-11-10T11:14:08Z","updated_at":"2018-12-04T07:48:48Z","pushed_at":"2018-12-04T11:43:05Z","git_url":"git://github.com/paparazzi/paparazzi.git","ssh_url":"git@github.com:paparazzi/paparazzi.git","clone_url":"https://github.com/paparazzi/paparazzi.git","svn_url":"https://github.com/paparazzi/paparazzi","homepage":"http://paparazziuav.org","size":75731,"stargazers_count":898,"watchers_count":898,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":828,"mirror_url":null,"archived":false,"open_issues_count":86,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":828,"open_issues":86,"watchers":898,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paparazzi/paparazzi/pulls/2360"},"html":{"href":"https://github.com/paparazzi/paparazzi/pull/2360"},"issue":{"href":"https://api.github.com/repos/paparazzi/paparazzi/issues/2360"},"comments":{"href":"https://api.github.com/repos/paparazzi/paparazzi/issues/2360/comments"},"review_comments":{"href":"https://api.github.com/repos/paparazzi/paparazzi/pulls/2360/comments"},"review_comment":{"href":"https://api.github.com/repos/paparazzi/paparazzi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paparazzi/paparazzi/pulls/2360/commits"},"statuses":{"href":"https://api.github.com/repos/paparazzi/paparazzi/statuses/a24758384ecff6723c11451dbfaa316c3817ac6a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kirkscheper"}}