{"action":"created","comment":{"url":"https://api.github.com/repos/docker/cli/pulls/comments/171199721","pull_request_review_id":100009168,"id":171199721,"diff_hunk":"@@ -35,6 +35,7 @@ func TestValidateExternalNetworks(t *testing.T) {\n \t\t\texpectedMsg:  \"Unexpected\",\n \t\t},\n \t\t{\n+\t\t\t// FIXME(vdemeester) that doesn't work under windows, the check needs to be smarter","path":"cli/command/stack/swarm/deploy_composefile_test.go","position":4,"original_position":4,"commit_id":"8da068fc46d48d2159392e16b0d27ebdb8bb515d","original_commit_id":"e39587da7477a6544b8d0772e0ef7ecf46465727","user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars0.githubusercontent.com/u/6508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"body":"definitely, but probably need to be \"skipped\" for now, and follow-up on a fix PR for that problem only 👼 ","created_at":"2018-02-28T10:25:16Z","updated_at":"2018-02-28T10:25:16Z","html_url":"https://github.com/docker/cli/pull/906#discussion_r171199721","pull_request_url":"https://api.github.com/repos/docker/cli/pulls/906","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/docker/cli/pulls/comments/171199721"},"html":{"href":"https://github.com/docker/cli/pull/906#discussion_r171199721"},"pull_request":{"href":"https://api.github.com/repos/docker/cli/pulls/906"}},"in_reply_to_id":170972686},"pull_request":{"url":"https://api.github.com/repos/docker/cli/pulls/906","id":171705888,"html_url":"https://github.com/docker/cli/pull/906","diff_url":"https://github.com/docker/cli/pull/906.diff","patch_url":"https://github.com/docker/cli/pull/906.patch","issue_url":"https://api.github.com/repos/docker/cli/issues/906","number":906,"state":"open","locked":false,"title":"Fixes some unit tests to be able to run them on windows","user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars0.githubusercontent.com/u/6508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"body":"Some of them are skipped for now (because the feature is not supported\r\nor needs more work), some of them are fixed.\r\n\r\nThere is still some errors, but it's a start 👼 🙏 \r\n\r\nSigned-off-by: Vincent Demeester <vincent@sbr.pm>\r\n","created_at":"2018-02-27T15:59:09Z","updated_at":"2018-02-28T10:25:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f91908647ed7623b515052c00588f4e1514ab2c0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":585916071,"url":"https://api.github.com/repos/docker/cli/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/docker/cli/pulls/906/commits","review_comments_url":"https://api.github.com/repos/docker/cli/pulls/906/comments","review_comment_url":"https://api.github.com/repos/docker/cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/cli/issues/906/comments","statuses_url":"https://api.github.com/repos/docker/cli/statuses/8da068fc46d48d2159392e16b0d27ebdb8bb515d","head":{"label":"vdemeester:fix-some-windows-unit-tests","ref":"fix-some-windows-unit-tests","sha":"8da068fc46d48d2159392e16b0d27ebdb8bb515d","user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars0.githubusercontent.com/u/6508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"repo":{"id":88662366,"name":"cli","full_name":"vdemeester/cli","owner":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars0.githubusercontent.com/u/6508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vdemeester/cli","description":"The Docker CLI","fork":true,"url":"https://api.github.com/repos/vdemeester/cli","forks_url":"https://api.github.com/repos/vdemeester/cli/forks","keys_url":"https://api.github.com/repos/vdemeester/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vdemeester/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vdemeester/cli/teams","hooks_url":"https://api.github.com/repos/vdemeester/cli/hooks","issue_events_url":"https://api.github.com/repos/vdemeester/cli/issues/events{/number}","events_url":"https://api.github.com/repos/vdemeester/cli/events","assignees_url":"https://api.github.com/repos/vdemeester/cli/assignees{/user}","branches_url":"https://api.github.com/repos/vdemeester/cli/branches{/branch}","tags_url":"https://api.github.com/repos/vdemeester/cli/tags","blobs_url":"https://api.github.com/repos/vdemeester/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vdemeester/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vdemeester/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/vdemeester/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vdemeester/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/vdemeester/cli/languages","stargazers_url":"https://api.github.com/repos/vdemeester/cli/stargazers","contributors_url":"https://api.github.com/repos/vdemeester/cli/contributors","subscribers_url":"https://api.github.com/repos/vdemeester/cli/subscribers","subscription_url":"https://api.github.com/repos/vdemeester/cli/subscription","commits_url":"https://api.github.com/repos/vdemeester/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/vdemeester/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/vdemeester/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/vdemeester/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/vdemeester/cli/contents/{+path}","compare_url":"https://api.github.com/repos/vdemeester/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vdemeester/cli/merges","archive_url":"https://api.github.com/repos/vdemeester/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vdemeester/cli/downloads","issues_url":"https://api.github.com/repos/vdemeester/cli/issues{/number}","pulls_url":"https://api.github.com/repos/vdemeester/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/vdemeester/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/vdemeester/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vdemeester/cli/labels{/name}","releases_url":"https://api.github.com/repos/vdemeester/cli/releases{/id}","deployments_url":"https://api.github.com/repos/vdemeester/cli/deployments","created_at":"2017-04-18T19:26:23Z","updated_at":"2017-04-18T19:26:25Z","pushed_at":"2018-02-28T09:35:29Z","git_url":"git://github.com/vdemeester/cli.git","ssh_url":"git@github.com:vdemeester/cli.git","clone_url":"https://github.com/vdemeester/cli.git","svn_url":"https://github.com/vdemeester/cli","homepage":null,"size":16799,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"2851c007fe1074855a57314fb299e74944eedf20","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars1.githubusercontent.com/u/5429470?v=4","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":88013053,"name":"cli","full_name":"docker/cli","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars1.githubusercontent.com/u/5429470?v=4","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/cli","description":"The Docker CLI","fork":false,"url":"https://api.github.com/repos/docker/cli","forks_url":"https://api.github.com/repos/docker/cli/forks","keys_url":"https://api.github.com/repos/docker/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/cli/teams","hooks_url":"https://api.github.com/repos/docker/cli/hooks","issue_events_url":"https://api.github.com/repos/docker/cli/issues/events{/number}","events_url":"https://api.github.com/repos/docker/cli/events","assignees_url":"https://api.github.com/repos/docker/cli/assignees{/user}","branches_url":"https://api.github.com/repos/docker/cli/branches{/branch}","tags_url":"https://api.github.com/repos/docker/cli/tags","blobs_url":"https://api.github.com/repos/docker/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/cli/languages","stargazers_url":"https://api.github.com/repos/docker/cli/stargazers","contributors_url":"https://api.github.com/repos/docker/cli/contributors","subscribers_url":"https://api.github.com/repos/docker/cli/subscribers","subscription_url":"https://api.github.com/repos/docker/cli/subscription","commits_url":"https://api.github.com/repos/docker/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/cli/contents/{+path}","compare_url":"https://api.github.com/repos/docker/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/cli/merges","archive_url":"https://api.github.com/repos/docker/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/cli/downloads","issues_url":"https://api.github.com/repos/docker/cli/issues{/number}","pulls_url":"https://api.github.com/repos/docker/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/cli/labels{/name}","releases_url":"https://api.github.com/repos/docker/cli/releases{/id}","deployments_url":"https://api.github.com/repos/docker/cli/deployments","created_at":"2017-04-12T05:27:42Z","updated_at":"2018-02-28T09:49:46Z","pushed_at":"2018-02-28T10:12:57Z","git_url":"git://github.com/docker/cli.git","ssh_url":"git@github.com:docker/cli.git","clone_url":"https://github.com/docker/cli.git","svn_url":"https://github.com/docker/cli","homepage":null,"size":16670,"stargazers_count":540,"watchers_count":540,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":355,"mirror_url":null,"archived":false,"open_issues_count":181,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":355,"open_issues":181,"watchers":540,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/cli/pulls/906"},"html":{"href":"https://github.com/docker/cli/pull/906"},"issue":{"href":"https://api.github.com/repos/docker/cli/issues/906"},"comments":{"href":"https://api.github.com/repos/docker/cli/issues/906/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/cli/pulls/906/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/cli/pulls/906/commits"},"statuses":{"href":"https://api.github.com/repos/docker/cli/statuses/8da068fc46d48d2159392e16b0d27ebdb8bb515d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vdemeester"}}