{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-daffodil/pulls/comments/167231077","pull_request_review_id":95422938,"id":167231077,"diff_hunk":"@@ -50,7 +48,8 @@ class TestCLISaveParser {\n     val shell = Util.start(\"\")\n \n     try {\n-      String.format(\"%s save-parser -s %s -r matrix %s\", Util.binPath, testSchemaFile, savedParserFile.getName()) !","path":"daffodil-cli/src/test/scala/org/apache/daffodil/saving/TestCLISaveParser.scala","position":17,"original_position":17,"commit_id":"dd94686668be82635842df65f44474a13176e5d9","original_commit_id":"dd94686668be82635842df65f44474a13176e5d9","user":{"login":"stevedlawrence","id":3180601,"avatar_url":"https://avatars2.githubusercontent.com/u/3180601?v=4","gravatar_id":"","url":"https://api.github.com/users/stevedlawrence","html_url":"https://github.com/stevedlawrence","followers_url":"https://api.github.com/users/stevedlawrence/followers","following_url":"https://api.github.com/users/stevedlawrence/following{/other_user}","gists_url":"https://api.github.com/users/stevedlawrence/gists{/gist_id}","starred_url":"https://api.github.com/users/stevedlawrence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevedlawrence/subscriptions","organizations_url":"https://api.github.com/users/stevedlawrence/orgs","repos_url":"https://api.github.com/users/stevedlawrence/repos","events_url":"https://api.github.com/users/stevedlawrence/events{/privacy}","received_events_url":"https://api.github.com/users/stevedlawrence/received_events","type":"User","site_admin":false},"body":"These tests used the scala ``!`` to execute the command to save a parser, then used expected to run the command to use the saved parser. We only configure Expect to have the daffodil-lib/src/test stuff on the classpath, so this wouldn't be able to find built-in-formats.xsd. So instead use Expect to execute this command so it's gets the right classpath info.","created_at":"2018-02-09T13:49:13Z","updated_at":"2018-02-09T13:52:57Z","html_url":"https://github.com/apache/incubator-daffodil/pull/38#discussion_r167231077","pull_request_url":"https://api.github.com/repos/apache/incubator-daffodil/pulls/38","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-daffodil/pulls/comments/167231077"},"html":{"href":"https://github.com/apache/incubator-daffodil/pull/38#discussion_r167231077"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-daffodil/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-daffodil/pulls/38","id":168242610,"html_url":"https://github.com/apache/incubator-daffodil/pull/38","diff_url":"https://github.com/apache/incubator-daffodil/pull/38.diff","patch_url":"https://github.com/apache/incubator-daffodil/pull/38.patch","issue_url":"https://api.github.com/repos/apache/incubator-daffodil/issues/38","number":38,"state":"open","locked":false,"title":"Move built-in-formats.xsd to test and the backwards compatibility added for it","user":{"login":"stevedlawrence","id":3180601,"avatar_url":"https://avatars2.githubusercontent.com/u/3180601?v=4","gravatar_id":"","url":"https://api.github.com/users/stevedlawrence","html_url":"https://github.com/stevedlawrence","followers_url":"https://api.github.com/users/stevedlawrence/followers","following_url":"https://api.github.com/users/stevedlawrence/following{/other_user}","gists_url":"https://api.github.com/users/stevedlawrence/gists{/gist_id}","starred_url":"https://api.github.com/users/stevedlawrence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevedlawrence/subscriptions","organizations_url":"https://api.github.com/users/stevedlawrence/orgs","repos_url":"https://api.github.com/users/stevedlawrence/repos","events_url":"https://api.github.com/users/stevedlawrence/events{/privacy}","received_events_url":"https://api.github.com/users/stevedlawrence/received_events","type":"User","site_admin":false},"body":"A handful of schemas use built-in-formats.xsd as a method to get a\r\ndefault set of DFDL properties. This used to be in the\r\nedu/illinois/ncsa/daffodil namespace, but was moved to\r\norg/apache/daffodil with the move to Apache incubation. This move would\r\nhave broken schemas, so code was added to provide backwards\r\ncompatability. This code essentially replaced instances of\r\nedu/illinois/ncsa with org/apache/daffodil, but that could break things\r\nif actual schema files were in edu/illinois/ncsa, which is legit and\r\ndoes happen.\r\n\r\nHowever, built-in-formats.xsd is intended to only be used for testing\r\nand not actual schemas. The GeneralPurposeFormat.xsd from IBM is\r\nprovided for this purpose and should be used instead. So move\r\nbuilt-in-format.xsd to src/test/resources and remove the broken\r\nbackwards compatibility hack. Also update sbt subproject dependencies so\r\ntest projects depend on the core \"test\" so that built-in-formats.xsd is\r\non the test classpath. Also update CLI test infrastructure to modify\r\nDAFFODIL_CLASSPATH to include the daffodil-lib test resource directory\r\nfor the same reason.\r\n\r\nDAFFODIL-1897","created_at":"2018-02-09T13:42:18Z","updated_at":"2018-02-09T13:52:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebaa92635a5e987d4c0a694e896beef5cb0932ed","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-daffodil/pulls/38/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-daffodil/pulls/38/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-daffodil/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-daffodil/issues/38/comments","statuses_url":"https://api.github.com/repos/apache/incubator-daffodil/statuses/dd94686668be82635842df65f44474a13176e5d9","head":{"label":"stevedlawrence:daffodil-1897-built-in-formats","ref":"daffodil-1897-built-in-formats","sha":"dd94686668be82635842df65f44474a13176e5d9","user":{"login":"stevedlawrence","id":3180601,"avatar_url":"https://avatars2.githubusercontent.com/u/3180601?v=4","gravatar_id":"","url":"https://api.github.com/users/stevedlawrence","html_url":"https://github.com/stevedlawrence","followers_url":"https://api.github.com/users/stevedlawrence/followers","following_url":"https://api.github.com/users/stevedlawrence/following{/other_user}","gists_url":"https://api.github.com/users/stevedlawrence/gists{/gist_id}","starred_url":"https://api.github.com/users/stevedlawrence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevedlawrence/subscriptions","organizations_url":"https://api.github.com/users/stevedlawrence/orgs","repos_url":"https://api.github.com/users/stevedlawrence/repos","events_url":"https://api.github.com/users/stevedlawrence/events{/privacy}","received_events_url":"https://api.github.com/users/stevedlawrence/received_events","type":"User","site_admin":false},"repo":{"id":108402545,"name":"incubator-daffodil","full_name":"stevedlawrence/incubator-daffodil","owner":{"login":"stevedlawrence","id":3180601,"avatar_url":"https://avatars2.githubusercontent.com/u/3180601?v=4","gravatar_id":"","url":"https://api.github.com/users/stevedlawrence","html_url":"https://github.com/stevedlawrence","followers_url":"https://api.github.com/users/stevedlawrence/followers","following_url":"https://api.github.com/users/stevedlawrence/following{/other_user}","gists_url":"https://api.github.com/users/stevedlawrence/gists{/gist_id}","starred_url":"https://api.github.com/users/stevedlawrence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevedlawrence/subscriptions","organizations_url":"https://api.github.com/users/stevedlawrence/orgs","repos_url":"https://api.github.com/users/stevedlawrence/repos","events_url":"https://api.github.com/users/stevedlawrence/events{/privacy}","received_events_url":"https://api.github.com/users/stevedlawrence/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stevedlawrence/incubator-daffodil","description":"Mirror of Apache daffodil (Incubating)","fork":true,"url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil","forks_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/forks","keys_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/teams","hooks_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/hooks","issue_events_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/issues/events{/number}","events_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/events","assignees_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/assignees{/user}","branches_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/branches{/branch}","tags_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/tags","blobs_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/git/refs{/sha}","trees_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/statuses/{sha}","languages_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/languages","stargazers_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/stargazers","contributors_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/contributors","subscribers_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/subscribers","subscription_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/subscription","commits_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/commits{/sha}","git_commits_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/git/commits{/sha}","comments_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/comments{/number}","issue_comment_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/issues/comments{/number}","contents_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/contents/{+path}","compare_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/merges","archive_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/downloads","issues_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/issues{/number}","pulls_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/pulls{/number}","milestones_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/milestones{/number}","notifications_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/labels{/name}","releases_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/releases{/id}","deployments_url":"https://api.github.com/repos/stevedlawrence/incubator-daffodil/deployments","created_at":"2017-10-26T11:30:02Z","updated_at":"2017-10-26T11:30:17Z","pushed_at":"2018-02-09T13:41:35Z","git_url":"git://github.com/stevedlawrence/incubator-daffodil.git","ssh_url":"git@github.com:stevedlawrence/incubator-daffodil.git","clone_url":"https://github.com/stevedlawrence/incubator-daffodil.git","svn_url":"https://github.com/stevedlawrence/incubator-daffodil","homepage":null,"size":171375,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"add8c5a6f82f25073475a4d6c7ae94fb5ca6e01a","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":101730006,"name":"incubator-daffodil","full_name":"apache/incubator-daffodil","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-daffodil","description":"Apache Daffodil (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-daffodil","forks_url":"https://api.github.com/repos/apache/incubator-daffodil/forks","keys_url":"https://api.github.com/repos/apache/incubator-daffodil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-daffodil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-daffodil/teams","hooks_url":"https://api.github.com/repos/apache/incubator-daffodil/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-daffodil/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-daffodil/events","assignees_url":"https://api.github.com/repos/apache/incubator-daffodil/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-daffodil/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-daffodil/tags","blobs_url":"https://api.github.com/repos/apache/incubator-daffodil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-daffodil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-daffodil/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-daffodil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-daffodil/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-daffodil/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-daffodil/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-daffodil/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-daffodil/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-daffodil/subscription","commits_url":"https://api.github.com/repos/apache/incubator-daffodil/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-daffodil/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-daffodil/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-daffodil/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-daffodil/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-daffodil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-daffodil/merges","archive_url":"https://api.github.com/repos/apache/incubator-daffodil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-daffodil/downloads","issues_url":"https://api.github.com/repos/apache/incubator-daffodil/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-daffodil/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-daffodil/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-daffodil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-daffodil/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-daffodil/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-daffodil/deployments","created_at":"2017-08-29T07:00:10Z","updated_at":"2018-01-09T19:13:54Z","pushed_at":"2018-02-09T13:42:19Z","git_url":"git://github.com/apache/incubator-daffodil.git","ssh_url":"git@github.com:apache/incubator-daffodil.git","clone_url":"https://github.com/apache/incubator-daffodil.git","svn_url":"https://github.com/apache/incubator-daffodil","homepage":"https://daffodil.apache.org/","size":171374,"stargazers_count":2,"watchers_count":2,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-daffodil/pulls/38"},"html":{"href":"https://github.com/apache/incubator-daffodil/pull/38"},"issue":{"href":"https://api.github.com/repos/apache/incubator-daffodil/issues/38"},"comments":{"href":"https://api.github.com/repos/apache/incubator-daffodil/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-daffodil/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-daffodil/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-daffodil/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-daffodil/statuses/dd94686668be82635842df65f44474a13176e5d9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"stevedlawrence"}}