{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/205202394","pull_request_review_id":140426431,"id":205202394,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTIwMjM5NA==","diff_hunk":"@@ -617,7 +617,7 @@ int PGBackend::be_scan_list(\n   return 0;\n }\n \n-bool PGBackend::be_compare_scrub_objects(\n+void PGBackend::be_compare_scrub_objects(","path":"src/osd/PGBackend.cc","position":5,"original_position":5,"commit_id":"974133378d15ded9dbe37d0d0db44f96f01955e7","original_commit_id":"a5631be4c0eed681ff2656930c6803bf21b355af","user":{"login":"liewegas","id":433031,"node_id":"MDQ6VXNlcjQzMzAzMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/433031?v=4","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},"body":"fwiw i think the error return is still nicer for the caller.  otherwise they have to call ss.str() with constructs a std::string and test it for empty.\r\n","created_at":"2018-07-25T17:45:33Z","updated_at":"2018-07-25T17:45:33Z","html_url":"https://github.com/ceph/ceph/pull/23217#discussion_r205202394","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/23217","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/205202394"},"html":{"href":"https://github.com/ceph/ceph/pull/23217#discussion_r205202394"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/23217"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/23217","id":203651069,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNjUxMDY5","html_url":"https://github.com/ceph/ceph/pull/23217","diff_url":"https://github.com/ceph/ceph/pull/23217.diff","patch_url":"https://github.com/ceph/ceph/pull/23217.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/23217","number":23217,"state":"open","locked":false,"title":"osd: Allow repair of an object with a bad data_digest in object_info on all replicas","user":{"login":"dzafman","id":2467610,"node_id":"MDQ6VXNlcjI0Njc2MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/2467610?v=4","gravatar_id":"","url":"https://api.github.com/users/dzafman","html_url":"https://github.com/dzafman","followers_url":"https://api.github.com/users/dzafman/followers","following_url":"https://api.github.com/users/dzafman/following{/other_user}","gists_url":"https://api.github.com/users/dzafman/gists{/gist_id}","starred_url":"https://api.github.com/users/dzafman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzafman/subscriptions","organizations_url":"https://api.github.com/users/dzafman/orgs","repos_url":"https://api.github.com/users/dzafman/repos","events_url":"https://api.github.com/users/dzafman/events{/privacy}","received_events_url":"https://api.github.com/users/dzafman/received_events","type":"User","site_admin":false},"body":"Fixes: https://tracker.ceph.com/issues/25085","created_at":"2018-07-24T20:51:27Z","updated_at":"2018-07-25T17:45:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79aa3e39a208f71f989b692922785126d518a4a3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jdurgin","id":1022584,"node_id":"MDQ6VXNlcjEwMjI1ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1022584?v=4","gravatar_id":"","url":"https://api.github.com/users/jdurgin","html_url":"https://github.com/jdurgin","followers_url":"https://api.github.com/users/jdurgin/followers","following_url":"https://api.github.com/users/jdurgin/following{/other_user}","gists_url":"https://api.github.com/users/jdurgin/gists{/gist_id}","starred_url":"https://api.github.com/users/jdurgin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdurgin/subscriptions","organizations_url":"https://api.github.com/users/jdurgin/orgs","repos_url":"https://api.github.com/users/jdurgin/repos","events_url":"https://api.github.com/users/jdurgin/events{/privacy}","received_events_url":"https://api.github.com/users/jdurgin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":144329561,"node_id":"MDU6TGFiZWwxNDQzMjk1NjE=","url":"https://api.github.com/repos/ceph/ceph/labels/core","name":"core","color":"0041a2","default":false},{"id":134774006,"node_id":"MDU6TGFiZWwxMzQ3NzQwMDY=","url":"https://api.github.com/repos/ceph/ceph/labels/feature","name":"feature","color":"00ff24","default":false},{"id":148431321,"node_id":"MDU6TGFiZWwxNDg0MzEzMjE=","url":"https://api.github.com/repos/ceph/ceph/labels/needs-qa","name":"needs-qa","color":"fad8c7","default":false},{"id":340048817,"node_id":"MDU6TGFiZWwzNDAwNDg4MTc=","url":"https://api.github.com/repos/ceph/ceph/labels/needs-review","name":"needs-review","color":"d4c5f9","default":false},{"id":219859248,"node_id":"MDU6TGFiZWwyMTk4NTkyNDg=","url":"https://api.github.com/repos/ceph/ceph/labels/wip-kefu-testing","name":"wip-kefu-testing","color":"bfdadc","default":false},{"id":225858212,"node_id":"MDU6TGFiZWwyMjU4NTgyMTI=","url":"https://api.github.com/repos/ceph/ceph/labels/wip-zafman-testing","name":"wip-zafman-testing","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/23217/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/23217/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/23217/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/974133378d15ded9dbe37d0d0db44f96f01955e7","head":{"label":"dzafman:wip-25085","ref":"wip-25085","sha":"974133378d15ded9dbe37d0d0db44f96f01955e7","user":{"login":"dzafman","id":2467610,"node_id":"MDQ6VXNlcjI0Njc2MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/2467610?v=4","gravatar_id":"","url":"https://api.github.com/users/dzafman","html_url":"https://github.com/dzafman","followers_url":"https://api.github.com/users/dzafman/followers","following_url":"https://api.github.com/users/dzafman/following{/other_user}","gists_url":"https://api.github.com/users/dzafman/gists{/gist_id}","starred_url":"https://api.github.com/users/dzafman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzafman/subscriptions","organizations_url":"https://api.github.com/users/dzafman/orgs","repos_url":"https://api.github.com/users/dzafman/repos","events_url":"https://api.github.com/users/dzafman/events{/privacy}","received_events_url":"https://api.github.com/users/dzafman/received_events","type":"User","site_admin":false},"repo":{"id":7757983,"node_id":"MDEwOlJlcG9zaXRvcnk3NzU3OTgz","name":"ceph","full_name":"dzafman/ceph","owner":{"login":"dzafman","id":2467610,"node_id":"MDQ6VXNlcjI0Njc2MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/2467610?v=4","gravatar_id":"","url":"https://api.github.com/users/dzafman","html_url":"https://github.com/dzafman","followers_url":"https://api.github.com/users/dzafman/followers","following_url":"https://api.github.com/users/dzafman/following{/other_user}","gists_url":"https://api.github.com/users/dzafman/gists{/gist_id}","starred_url":"https://api.github.com/users/dzafman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzafman/subscriptions","organizations_url":"https://api.github.com/users/dzafman/orgs","repos_url":"https://api.github.com/users/dzafman/repos","events_url":"https://api.github.com/users/dzafman/events{/privacy}","received_events_url":"https://api.github.com/users/dzafman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dzafman/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/dzafman/ceph","forks_url":"https://api.github.com/repos/dzafman/ceph/forks","keys_url":"https://api.github.com/repos/dzafman/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dzafman/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dzafman/ceph/teams","hooks_url":"https://api.github.com/repos/dzafman/ceph/hooks","issue_events_url":"https://api.github.com/repos/dzafman/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/dzafman/ceph/events","assignees_url":"https://api.github.com/repos/dzafman/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/dzafman/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/dzafman/ceph/tags","blobs_url":"https://api.github.com/repos/dzafman/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dzafman/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dzafman/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/dzafman/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dzafman/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/dzafman/ceph/languages","stargazers_url":"https://api.github.com/repos/dzafman/ceph/stargazers","contributors_url":"https://api.github.com/repos/dzafman/ceph/contributors","subscribers_url":"https://api.github.com/repos/dzafman/ceph/subscribers","subscription_url":"https://api.github.com/repos/dzafman/ceph/subscription","commits_url":"https://api.github.com/repos/dzafman/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/dzafman/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/dzafman/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/dzafman/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/dzafman/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/dzafman/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dzafman/ceph/merges","archive_url":"https://api.github.com/repos/dzafman/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dzafman/ceph/downloads","issues_url":"https://api.github.com/repos/dzafman/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/dzafman/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/dzafman/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/dzafman/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dzafman/ceph/labels{/name}","releases_url":"https://api.github.com/repos/dzafman/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/dzafman/ceph/deployments","created_at":"2013-01-22T18:07:43Z","updated_at":"2014-06-25T02:23:55Z","pushed_at":"2018-07-25T17:20:43Z","git_url":"git://github.com/dzafman/ceph.git","ssh_url":"git@github.com:dzafman/ceph.git","clone_url":"https://github.com/dzafman/ceph.git","svn_url":"https://github.com/dzafman/ceph","homepage":"http://ceph.com","size":296929,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"af88fa27dd2738ddac880b7cad7784ba5699abf4","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"node_id":"MDEwOlJlcG9zaXRvcnkyMzEwNDk1","name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-07-25T17:04:21Z","pushed_at":"2018-07-25T17:22:10Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":300021,"stargazers_count":4851,"watchers_count":4851,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2545,"mirror_url":null,"archived":false,"open_issues_count":737,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2545,"open_issues":737,"watchers":4851,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/23217"},"html":{"href":"https://github.com/ceph/ceph/pull/23217"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/23217"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/23217/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/23217/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/23217/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/974133378d15ded9dbe37d0d0db44f96f01955e7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"liewegas"}}