{"action":"created","comment":{"url":"https://api.github.com/repos/benoitc/gunicorn/pulls/comments/226156253","pull_request_review_id":165910227,"id":226156253,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjE1NjI1Mw==","diff_hunk":"@@ -386,3 +386,56 @@ def test_umask_config(options, expected):\n     with AltArgs(cmdline):\n         app = NoConfigApp()\n     assert app.cfg.umask == expected\n+\n+\n+@pytest.mark.skipif(sys.version_info < (3, 0) or sys.version_info > (3, 6),\n+    reason=\"requires python3.0-3.6\")\n+@pytest.mark.parametrize(\"options, expected\", [\n+    ([\"--ssl-version\", \"SSLv3\"], 1),\n+    ([\"--ssl-version\", \"1\"], 1),\n+])\n+def test_ssl_version_named_constants_python_30_to_36(options, expected):\n+    _test_ssl_version(options, expected)\n+\n+\n+@pytest.mark.skipif(sys.version_info < (3, 0),","path":"tests/test_config.py","position":null,"original_position":16,"commit_id":"154009abbf0b193cd0fe849022ca20029b688a02","original_commit_id":"06c6efa468e26d995089a71345096dc62ab5278e","user":{"login":"javabrett","id":1103477,"node_id":"MDQ6VXNlcjExMDM0Nzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1103477?v=4","gravatar_id":"","url":"https://api.github.com/users/javabrett","html_url":"https://github.com/javabrett","followers_url":"https://api.github.com/users/javabrett/followers","following_url":"https://api.github.com/users/javabrett/following{/other_user}","gists_url":"https://api.github.com/users/javabrett/gists{/gist_id}","starred_url":"https://api.github.com/users/javabrett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javabrett/subscriptions","organizations_url":"https://api.github.com/users/javabrett/orgs","repos_url":"https://api.github.com/users/javabrett/repos","events_url":"https://api.github.com/users/javabrett/events{/privacy}","received_events_url":"https://api.github.com/users/javabrett/received_events","type":"User","site_admin":false},"body":"Done, removed.","created_at":"2018-10-18T03:06:08Z","updated_at":"2018-10-18T03:06:08Z","html_url":"https://github.com/benoitc/gunicorn/pull/1890#discussion_r226156253","pull_request_url":"https://api.github.com/repos/benoitc/gunicorn/pulls/1890","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/benoitc/gunicorn/pulls/comments/226156253"},"html":{"href":"https://github.com/benoitc/gunicorn/pull/1890#discussion_r226156253"},"pull_request":{"href":"https://api.github.com/repos/benoitc/gunicorn/pulls/1890"}},"in_reply_to_id":224777254},"pull_request":{"url":"https://api.github.com/repos/benoitc/gunicorn/pulls/1890","id":220981510,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTgxNTEw","html_url":"https://github.com/benoitc/gunicorn/pull/1890","diff_url":"https://github.com/benoitc/gunicorn/pull/1890.diff","patch_url":"https://github.com/benoitc/gunicorn/pull/1890.patch","issue_url":"https://api.github.com/repos/benoitc/gunicorn/issues/1890","number":1890,"state":"open","locked":false,"title":"Ssl version named contants","user":{"login":"javabrett","id":1103477,"node_id":"MDQ6VXNlcjExMDM0Nzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1103477?v=4","gravatar_id":"","url":"https://api.github.com/users/javabrett","html_url":"https://github.com/javabrett","followers_url":"https://api.github.com/users/javabrett/followers","following_url":"https://api.github.com/users/javabrett/following{/other_user}","gists_url":"https://api.github.com/users/javabrett/gists{/gist_id}","starred_url":"https://api.github.com/users/javabrett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javabrett/subscriptions","organizations_url":"https://api.github.com/users/javabrett/orgs","repos_url":"https://api.github.com/users/javabrett/repos","events_url":"https://api.github.com/users/javabrett/events{/privacy}","received_events_url":"https://api.github.com/users/javabrett/received_events","type":"User","site_admin":false},"body":"I found that I had this old contribution lying around without a matching PR.\r\n\r\nFixes #1454 , fixes #1114 .  /cc @tilgovi .","created_at":"2018-10-07T23:41:30Z","updated_at":"2018-10-18T03:06:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e810b4fde2bbd6aae6206d96bc86a88fd32cf8ad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/benoitc/gunicorn/pulls/1890/commits","review_comments_url":"https://api.github.com/repos/benoitc/gunicorn/pulls/1890/comments","review_comment_url":"https://api.github.com/repos/benoitc/gunicorn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/benoitc/gunicorn/issues/1890/comments","statuses_url":"https://api.github.com/repos/benoitc/gunicorn/statuses/154009abbf0b193cd0fe849022ca20029b688a02","head":{"label":"javabrett:ssl-version-named-contants","ref":"ssl-version-named-contants","sha":"154009abbf0b193cd0fe849022ca20029b688a02","user":{"login":"javabrett","id":1103477,"node_id":"MDQ6VXNlcjExMDM0Nzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1103477?v=4","gravatar_id":"","url":"https://api.github.com/users/javabrett","html_url":"https://github.com/javabrett","followers_url":"https://api.github.com/users/javabrett/followers","following_url":"https://api.github.com/users/javabrett/following{/other_user}","gists_url":"https://api.github.com/users/javabrett/gists{/gist_id}","starred_url":"https://api.github.com/users/javabrett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javabrett/subscriptions","organizations_url":"https://api.github.com/users/javabrett/orgs","repos_url":"https://api.github.com/users/javabrett/repos","events_url":"https://api.github.com/users/javabrett/events{/privacy}","received_events_url":"https://api.github.com/users/javabrett/received_events","type":"User","site_admin":false},"repo":{"id":117056360,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcwNTYzNjA=","name":"gunicorn","full_name":"javabrett/gunicorn","private":false,"owner":{"login":"javabrett","id":1103477,"node_id":"MDQ6VXNlcjExMDM0Nzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1103477?v=4","gravatar_id":"","url":"https://api.github.com/users/javabrett","html_url":"https://github.com/javabrett","followers_url":"https://api.github.com/users/javabrett/followers","following_url":"https://api.github.com/users/javabrett/following{/other_user}","gists_url":"https://api.github.com/users/javabrett/gists{/gist_id}","starred_url":"https://api.github.com/users/javabrett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javabrett/subscriptions","organizations_url":"https://api.github.com/users/javabrett/orgs","repos_url":"https://api.github.com/users/javabrett/repos","events_url":"https://api.github.com/users/javabrett/events{/privacy}","received_events_url":"https://api.github.com/users/javabrett/received_events","type":"User","site_admin":false},"html_url":"https://github.com/javabrett/gunicorn","description":"gunicorn 'Green Unicorn' is a WSGI HTTP Server for UNIX, fast clients and sleepy applications.","fork":true,"url":"https://api.github.com/repos/javabrett/gunicorn","forks_url":"https://api.github.com/repos/javabrett/gunicorn/forks","keys_url":"https://api.github.com/repos/javabrett/gunicorn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/javabrett/gunicorn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/javabrett/gunicorn/teams","hooks_url":"https://api.github.com/repos/javabrett/gunicorn/hooks","issue_events_url":"https://api.github.com/repos/javabrett/gunicorn/issues/events{/number}","events_url":"https://api.github.com/repos/javabrett/gunicorn/events","assignees_url":"https://api.github.com/repos/javabrett/gunicorn/assignees{/user}","branches_url":"https://api.github.com/repos/javabrett/gunicorn/branches{/branch}","tags_url":"https://api.github.com/repos/javabrett/gunicorn/tags","blobs_url":"https://api.github.com/repos/javabrett/gunicorn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/javabrett/gunicorn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/javabrett/gunicorn/git/refs{/sha}","trees_url":"https://api.github.com/repos/javabrett/gunicorn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/javabrett/gunicorn/statuses/{sha}","languages_url":"https://api.github.com/repos/javabrett/gunicorn/languages","stargazers_url":"https://api.github.com/repos/javabrett/gunicorn/stargazers","contributors_url":"https://api.github.com/repos/javabrett/gunicorn/contributors","subscribers_url":"https://api.github.com/repos/javabrett/gunicorn/subscribers","subscription_url":"https://api.github.com/repos/javabrett/gunicorn/subscription","commits_url":"https://api.github.com/repos/javabrett/gunicorn/commits{/sha}","git_commits_url":"https://api.github.com/repos/javabrett/gunicorn/git/commits{/sha}","comments_url":"https://api.github.com/repos/javabrett/gunicorn/comments{/number}","issue_comment_url":"https://api.github.com/repos/javabrett/gunicorn/issues/comments{/number}","contents_url":"https://api.github.com/repos/javabrett/gunicorn/contents/{+path}","compare_url":"https://api.github.com/repos/javabrett/gunicorn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/javabrett/gunicorn/merges","archive_url":"https://api.github.com/repos/javabrett/gunicorn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/javabrett/gunicorn/downloads","issues_url":"https://api.github.com/repos/javabrett/gunicorn/issues{/number}","pulls_url":"https://api.github.com/repos/javabrett/gunicorn/pulls{/number}","milestones_url":"https://api.github.com/repos/javabrett/gunicorn/milestones{/number}","notifications_url":"https://api.github.com/repos/javabrett/gunicorn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/javabrett/gunicorn/labels{/name}","releases_url":"https://api.github.com/repos/javabrett/gunicorn/releases{/id}","deployments_url":"https://api.github.com/repos/javabrett/gunicorn/deployments","created_at":"2018-01-11T05:51:58Z","updated_at":"2018-01-11T05:52:01Z","pushed_at":"2018-10-18T03:05:38Z","git_url":"git://github.com/javabrett/gunicorn.git","ssh_url":"git@github.com:javabrett/gunicorn.git","clone_url":"https://github.com/javabrett/gunicorn.git","svn_url":"https://github.com/javabrett/gunicorn","homepage":"http://www.gunicorn.org","size":3871,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"benoitc:master","ref":"master","sha":"bb0b366b26046ecc3f3ec53a02ecfb605cfeec0c","user":{"login":"benoitc","id":14498,"node_id":"MDQ6VXNlcjE0NDk4","avatar_url":"https://avatars1.githubusercontent.com/u/14498?v=4","gravatar_id":"","url":"https://api.github.com/users/benoitc","html_url":"https://github.com/benoitc","followers_url":"https://api.github.com/users/benoitc/followers","following_url":"https://api.github.com/users/benoitc/following{/other_user}","gists_url":"https://api.github.com/users/benoitc/gists{/gist_id}","starred_url":"https://api.github.com/users/benoitc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benoitc/subscriptions","organizations_url":"https://api.github.com/users/benoitc/orgs","repos_url":"https://api.github.com/users/benoitc/repos","events_url":"https://api.github.com/users/benoitc/events{/privacy}","received_events_url":"https://api.github.com/users/benoitc/received_events","type":"User","site_admin":false},"repo":{"id":390510,"node_id":"MDEwOlJlcG9zaXRvcnkzOTA1MTA=","name":"gunicorn","full_name":"benoitc/gunicorn","private":false,"owner":{"login":"benoitc","id":14498,"node_id":"MDQ6VXNlcjE0NDk4","avatar_url":"https://avatars1.githubusercontent.com/u/14498?v=4","gravatar_id":"","url":"https://api.github.com/users/benoitc","html_url":"https://github.com/benoitc","followers_url":"https://api.github.com/users/benoitc/followers","following_url":"https://api.github.com/users/benoitc/following{/other_user}","gists_url":"https://api.github.com/users/benoitc/gists{/gist_id}","starred_url":"https://api.github.com/users/benoitc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benoitc/subscriptions","organizations_url":"https://api.github.com/users/benoitc/orgs","repos_url":"https://api.github.com/users/benoitc/repos","events_url":"https://api.github.com/users/benoitc/events{/privacy}","received_events_url":"https://api.github.com/users/benoitc/received_events","type":"User","site_admin":false},"html_url":"https://github.com/benoitc/gunicorn","description":"gunicorn 'Green Unicorn' is a WSGI HTTP Server for UNIX, fast clients and sleepy applications.","fork":false,"url":"https://api.github.com/repos/benoitc/gunicorn","forks_url":"https://api.github.com/repos/benoitc/gunicorn/forks","keys_url":"https://api.github.com/repos/benoitc/gunicorn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benoitc/gunicorn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benoitc/gunicorn/teams","hooks_url":"https://api.github.com/repos/benoitc/gunicorn/hooks","issue_events_url":"https://api.github.com/repos/benoitc/gunicorn/issues/events{/number}","events_url":"https://api.github.com/repos/benoitc/gunicorn/events","assignees_url":"https://api.github.com/repos/benoitc/gunicorn/assignees{/user}","branches_url":"https://api.github.com/repos/benoitc/gunicorn/branches{/branch}","tags_url":"https://api.github.com/repos/benoitc/gunicorn/tags","blobs_url":"https://api.github.com/repos/benoitc/gunicorn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benoitc/gunicorn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benoitc/gunicorn/git/refs{/sha}","trees_url":"https://api.github.com/repos/benoitc/gunicorn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benoitc/gunicorn/statuses/{sha}","languages_url":"https://api.github.com/repos/benoitc/gunicorn/languages","stargazers_url":"https://api.github.com/repos/benoitc/gunicorn/stargazers","contributors_url":"https://api.github.com/repos/benoitc/gunicorn/contributors","subscribers_url":"https://api.github.com/repos/benoitc/gunicorn/subscribers","subscription_url":"https://api.github.com/repos/benoitc/gunicorn/subscription","commits_url":"https://api.github.com/repos/benoitc/gunicorn/commits{/sha}","git_commits_url":"https://api.github.com/repos/benoitc/gunicorn/git/commits{/sha}","comments_url":"https://api.github.com/repos/benoitc/gunicorn/comments{/number}","issue_comment_url":"https://api.github.com/repos/benoitc/gunicorn/issues/comments{/number}","contents_url":"https://api.github.com/repos/benoitc/gunicorn/contents/{+path}","compare_url":"https://api.github.com/repos/benoitc/gunicorn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benoitc/gunicorn/merges","archive_url":"https://api.github.com/repos/benoitc/gunicorn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benoitc/gunicorn/downloads","issues_url":"https://api.github.com/repos/benoitc/gunicorn/issues{/number}","pulls_url":"https://api.github.com/repos/benoitc/gunicorn/pulls{/number}","milestones_url":"https://api.github.com/repos/benoitc/gunicorn/milestones{/number}","notifications_url":"https://api.github.com/repos/benoitc/gunicorn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benoitc/gunicorn/labels{/name}","releases_url":"https://api.github.com/repos/benoitc/gunicorn/releases{/id}","deployments_url":"https://api.github.com/repos/benoitc/gunicorn/deployments","created_at":"2009-11-30T18:18:08Z","updated_at":"2018-10-18T01:21:28Z","pushed_at":"2018-10-18T03:05:39Z","git_url":"git://github.com/benoitc/gunicorn.git","ssh_url":"git@github.com:benoitc/gunicorn.git","clone_url":"https://github.com/benoitc/gunicorn.git","svn_url":"https://github.com/benoitc/gunicorn","homepage":"http://www.gunicorn.org","size":3851,"stargazers_count":5188,"watchers_count":5188,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1011,"mirror_url":null,"archived":false,"open_issues_count":211,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1011,"open_issues":211,"watchers":5188,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/benoitc/gunicorn/pulls/1890"},"html":{"href":"https://github.com/benoitc/gunicorn/pull/1890"},"issue":{"href":"https://api.github.com/repos/benoitc/gunicorn/issues/1890"},"comments":{"href":"https://api.github.com/repos/benoitc/gunicorn/issues/1890/comments"},"review_comments":{"href":"https://api.github.com/repos/benoitc/gunicorn/pulls/1890/comments"},"review_comment":{"href":"https://api.github.com/repos/benoitc/gunicorn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/benoitc/gunicorn/pulls/1890/commits"},"statuses":{"href":"https://api.github.com/repos/benoitc/gunicorn/statuses/154009abbf0b193cd0fe849022ca20029b688a02"}},"author_association":"NONE"}}
{"actor":{"display_login":"javabrett"}}