{"action":"created","issue":{"url":"https://api.github.com/repos/trellis-ldp/trellis/issues/263","repository_url":"https://api.github.com/repos/trellis-ldp/trellis","labels_url":"https://api.github.com/repos/trellis-ldp/trellis/issues/263/labels{/name}","comments_url":"https://api.github.com/repos/trellis-ldp/trellis/issues/263/comments","events_url":"https://api.github.com/repos/trellis-ldp/trellis/issues/263/events","html_url":"https://github.com/trellis-ldp/trellis/issues/263","id":374397430,"node_id":"MDU6SXNzdWUzNzQzOTc0MzA=","number":263,"title":"Evaluate methods in MementoService interface","user":{"login":"acoburn","id":1265883,"node_id":"MDQ6VXNlcjEyNjU4ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1265883?v=4","gravatar_id":"","url":"https://api.github.com/users/acoburn","html_url":"https://github.com/acoburn","followers_url":"https://api.github.com/users/acoburn/followers","following_url":"https://api.github.com/users/acoburn/following{/other_user}","gists_url":"https://api.github.com/users/acoburn/gists{/gist_id}","starred_url":"https://api.github.com/users/acoburn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acoburn/subscriptions","organizations_url":"https://api.github.com/users/acoburn/orgs","repos_url":"https://api.github.com/users/acoburn/repos","events_url":"https://api.github.com/users/acoburn/events{/privacy}","received_events_url":"https://api.github.com/users/acoburn/received_events","type":"User","site_admin":false},"labels":[{"id":780611020,"node_id":"MDU6TGFiZWw3ODA2MTEwMjA=","url":"https://api.github.com/repos/trellis-ldp/trellis/labels/area/api","name":"area/api","color":"b60205","default":false},{"id":507934586,"node_id":"MDU6TGFiZWw1MDc5MzQ1ODY=","url":"https://api.github.com/repos/trellis-ldp/trellis/labels/question","name":"question","color":"cc317c","default":true}],"state":"open","locked":false,"assignee":{"login":"ajs6f","id":110994,"node_id":"MDQ6VXNlcjExMDk5NA==","avatar_url":"https://avatars1.githubusercontent.com/u/110994?v=4","gravatar_id":"","url":"https://api.github.com/users/ajs6f","html_url":"https://github.com/ajs6f","followers_url":"https://api.github.com/users/ajs6f/followers","following_url":"https://api.github.com/users/ajs6f/following{/other_user}","gists_url":"https://api.github.com/users/ajs6f/gists{/gist_id}","starred_url":"https://api.github.com/users/ajs6f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajs6f/subscriptions","organizations_url":"https://api.github.com/users/ajs6f/orgs","repos_url":"https://api.github.com/users/ajs6f/repos","events_url":"https://api.github.com/users/ajs6f/events{/privacy}","received_events_url":"https://api.github.com/users/ajs6f/received_events","type":"User","site_admin":false},"assignees":[{"login":"ajs6f","id":110994,"node_id":"MDQ6VXNlcjExMDk5NA==","avatar_url":"https://avatars1.githubusercontent.com/u/110994?v=4","gravatar_id":"","url":"https://api.github.com/users/ajs6f","html_url":"https://github.com/ajs6f","followers_url":"https://api.github.com/users/ajs6f/followers","following_url":"https://api.github.com/users/ajs6f/following{/other_user}","gists_url":"https://api.github.com/users/ajs6f/gists{/gist_id}","starred_url":"https://api.github.com/users/ajs6f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajs6f/subscriptions","organizations_url":"https://api.github.com/users/ajs6f/orgs","repos_url":"https://api.github.com/users/ajs6f/repos","events_url":"https://api.github.com/users/ajs6f/events{/privacy}","received_events_url":"https://api.github.com/users/ajs6f/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/trellis-ldp/trellis/milestones/6","html_url":"https://github.com/trellis-ldp/trellis/milestone/6","labels_url":"https://api.github.com/repos/trellis-ldp/trellis/milestones/6/labels","id":3258716,"node_id":"MDk6TWlsZXN0b25lMzI1ODcxNg==","number":6,"title":"0.8.0 Release","description":"","creator":{"login":"acoburn","id":1265883,"node_id":"MDQ6VXNlcjEyNjU4ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1265883?v=4","gravatar_id":"","url":"https://api.github.com/users/acoburn","html_url":"https://github.com/acoburn","followers_url":"https://api.github.com/users/acoburn/followers","following_url":"https://api.github.com/users/acoburn/following{/other_user}","gists_url":"https://api.github.com/users/acoburn/gists{/gist_id}","starred_url":"https://api.github.com/users/acoburn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acoburn/subscriptions","organizations_url":"https://api.github.com/users/acoburn/orgs","repos_url":"https://api.github.com/users/acoburn/repos","events_url":"https://api.github.com/users/acoburn/events{/privacy}","received_events_url":"https://api.github.com/users/acoburn/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":55,"state":"open","created_at":"2018-04-11T12:17:29Z","updated_at":"2018-11-04T17:09:07Z","due_on":null,"closed_at":null},"comments":24,"created_at":"2018-10-26T14:00:37Z","updated_at":"2018-11-04T18:52:48Z","closed_at":null,"author_association":"MEMBER","body":"The `MementoService` contains the following methods that need to be implemented by a persistence layer:\r\n\r\n```java\r\nCompletableFuture<Void> put(IRI identifier, Instant time, Stream<Quad> data);\r\n \r\nCompletableFuture<Void> delete(IRI identifier, Instant time);\r\n\r\nCompletableFuture<Resource> get(IRI identifier, Instant time);\r\n\r\nCompletableFuture<List<Instant>> list(IRI identifier);\r\n```\r\n\r\nThis issue is a placeholder to evaluate the design of this interface. For example, would it be better for `list` to return a `Stream<Instant>` (and be renamed)? Also, the `delete` method isn't currently used anywhere in the code: should it be removed until such time that it would really be used? Or would it be useful to keep it there for now? (removing it reduces the burden of implementation somewhat)"},"comment":{"url":"https://api.github.com/repos/trellis-ldp/trellis/issues/comments/435695517","html_url":"https://github.com/trellis-ldp/trellis/issues/263#issuecomment-435695517","issue_url":"https://api.github.com/repos/trellis-ldp/trellis/issues/263","id":435695517,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTY5NTUxNw==","user":{"login":"ajs6f","id":110994,"node_id":"MDQ6VXNlcjExMDk5NA==","avatar_url":"https://avatars1.githubusercontent.com/u/110994?v=4","gravatar_id":"","url":"https://api.github.com/users/ajs6f","html_url":"https://github.com/ajs6f","followers_url":"https://api.github.com/users/ajs6f/followers","following_url":"https://api.github.com/users/ajs6f/following{/other_user}","gists_url":"https://api.github.com/users/ajs6f/gists{/gist_id}","starred_url":"https://api.github.com/users/ajs6f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajs6f/subscriptions","organizations_url":"https://api.github.com/users/ajs6f/orgs","repos_url":"https://api.github.com/users/ajs6f/repos","events_url":"https://api.github.com/users/ajs6f/events{/privacy}","received_events_url":"https://api.github.com/users/ajs6f/received_events","type":"User","site_admin":false},"created_at":"2018-11-04T18:52:48Z","updated_at":"2018-11-04T18:52:48Z","author_association":"MEMBER","body":"Making a PR now..."}}
{"actor":{"display_login":"ajs6f"}}