{"action":"created","comment":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/pulls/comments/210032061","pull_request_review_id":146163343,"id":210032061,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDAzMjA2MQ==","diff_hunk":"@@ -50,6 +50,19 @@ resource \"pagerduty_extension\" \"slack\"{\n   endpoint_url = \"https://generic_webhook_url/XXXXXX/BBBBBB\"\n   extension_schema = \"${data.pagerduty_extension_schema.webhook.id}\"\n   extension_objects    = [\"${pagerduty_service.example.id}\"]\n+\n+  config = <<EOF\n+{\n+\t\"restrict\": \"any\",\n+\t\"notify_types\": {\n+\t\t\t\"resolve\": false,\n+\t\t\t\"acknowledge\": false,\n+\t\t\t\"assignments\": false\n+\t},\n+  \"access_token\": \"XXX\"","path":"website/docs/r/extension.html.markdown","position":13,"original_position":13,"commit_id":"43422b517d17de01fac38cd7639e7749d757066d","original_commit_id":"43422b517d17de01fac38cd7639e7749d757066d","user":{"login":"heimweh","id":13624191,"node_id":"MDQ6VXNlcjEzNjI0MTkx","avatar_url":"https://avatars1.githubusercontent.com/u/13624191?v=4","gravatar_id":"","url":"https://api.github.com/users/heimweh","html_url":"https://github.com/heimweh","followers_url":"https://api.github.com/users/heimweh/followers","following_url":"https://api.github.com/users/heimweh/following{/other_user}","gists_url":"https://api.github.com/users/heimweh/gists{/gist_id}","starred_url":"https://api.github.com/users/heimweh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heimweh/subscriptions","organizations_url":"https://api.github.com/users/heimweh/orgs","repos_url":"https://api.github.com/users/heimweh/repos","events_url":"https://api.github.com/users/heimweh/events{/privacy}","received_events_url":"https://api.github.com/users/heimweh/received_events","type":"User","site_admin":false},"body":"No biggie but the indentation here looks a bit off :)","created_at":"2018-08-14T17:11:32Z","updated_at":"2018-08-14T17:12:06Z","html_url":"https://github.com/terraform-providers/terraform-provider-pagerduty/pull/84#discussion_r210032061","pull_request_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/pulls/84","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/pulls/comments/210032061"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-pagerduty/pull/84#discussion_r210032061"},"pull_request":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/pulls/84"}}},"pull_request":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/pulls/84","id":186954096,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg2OTU0MDk2","html_url":"https://github.com/terraform-providers/terraform-provider-pagerduty/pull/84","diff_url":"https://github.com/terraform-providers/terraform-provider-pagerduty/pull/84.diff","patch_url":"https://github.com/terraform-providers/terraform-provider-pagerduty/pull/84.patch","issue_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/issues/84","number":84,"state":"open","locked":false,"title":"Manage extension configuration as plain JSON","user":{"login":"pdecat","id":318490,"node_id":"MDQ6VXNlcjMxODQ5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/318490?v=4","gravatar_id":"","url":"https://api.github.com/users/pdecat","html_url":"https://github.com/pdecat","followers_url":"https://api.github.com/users/pdecat/followers","following_url":"https://api.github.com/users/pdecat/following{/other_user}","gists_url":"https://api.github.com/users/pdecat/gists{/gist_id}","starred_url":"https://api.github.com/users/pdecat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdecat/subscriptions","organizations_url":"https://api.github.com/users/pdecat/orgs","repos_url":"https://api.github.com/users/pdecat/repos","events_url":"https://api.github.com/users/pdecat/events{/privacy}","received_events_url":"https://api.github.com/users/pdecat/received_events","type":"User","site_admin":false},"body":"This PR adds support to manage the configuration of extensions.\r\n\r\nIt is done as plain JSON as the configuration part differs from vendor to vendor: https://v2.developer.pagerduty.com/v2/page/api-reference#!/Extension_Schemas/get_extension_schemas\r\n\r\nTODO:\r\n\r\n- [x] add documentation\r\n- [x] update vendored go-pagerduty dependency once https://github.com/heimweh/go-pagerduty/pull/22 is merged\r\n\r\nNote: upgrading terraform dependencies as done in https://github.com/pdecat/terraform-provider-pagerduty/tree/upgrade-terraform-deps would allow for more readable terraform configuration snippets using structured `locals` and advanced `jsonencode()`:\r\n\r\n```\r\nlocals {\r\n  extension_config_slack = {\r\n    restrict = \"any\"\r\n\r\n    notify_types {\r\n      resolve     = false\r\n      acknowledge = false\r\n      assignments = false\r\n    }\r\n  }\r\n}\r\n\r\nresource \"pagerduty_extension\" \"foo\"{\r\n...\r\n  config = \"${jsonencode(local.extension_config_slack)}\"\r\n}\r\n```","created_at":"2018-05-09T15:16:06Z","updated_at":"2018-08-14T17:12:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a13b4ac26652918114fde03375ce2da30213cf20","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/pulls/84/commits","review_comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/pulls/84/comments","review_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/issues/84/comments","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/statuses/43422b517d17de01fac38cd7639e7749d757066d","head":{"label":"pdecat:f-extension-config","ref":"f-extension-config","sha":"43422b517d17de01fac38cd7639e7749d757066d","user":{"login":"pdecat","id":318490,"node_id":"MDQ6VXNlcjMxODQ5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/318490?v=4","gravatar_id":"","url":"https://api.github.com/users/pdecat","html_url":"https://github.com/pdecat","followers_url":"https://api.github.com/users/pdecat/followers","following_url":"https://api.github.com/users/pdecat/following{/other_user}","gists_url":"https://api.github.com/users/pdecat/gists{/gist_id}","starred_url":"https://api.github.com/users/pdecat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdecat/subscriptions","organizations_url":"https://api.github.com/users/pdecat/orgs","repos_url":"https://api.github.com/users/pdecat/repos","events_url":"https://api.github.com/users/pdecat/events{/privacy}","received_events_url":"https://api.github.com/users/pdecat/received_events","type":"User","site_admin":false},"repo":{"id":105018772,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUwMTg3NzI=","name":"terraform-provider-pagerduty","full_name":"pdecat/terraform-provider-pagerduty","owner":{"login":"pdecat","id":318490,"node_id":"MDQ6VXNlcjMxODQ5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/318490?v=4","gravatar_id":"","url":"https://api.github.com/users/pdecat","html_url":"https://github.com/pdecat","followers_url":"https://api.github.com/users/pdecat/followers","following_url":"https://api.github.com/users/pdecat/following{/other_user}","gists_url":"https://api.github.com/users/pdecat/gists{/gist_id}","starred_url":"https://api.github.com/users/pdecat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdecat/subscriptions","organizations_url":"https://api.github.com/users/pdecat/orgs","repos_url":"https://api.github.com/users/pdecat/repos","events_url":"https://api.github.com/users/pdecat/events{/privacy}","received_events_url":"https://api.github.com/users/pdecat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pdecat/terraform-provider-pagerduty","description":"Terraform pagerduty provider","fork":true,"url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty","forks_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/forks","keys_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/teams","hooks_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/hooks","issue_events_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/issues/events{/number}","events_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/events","assignees_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/assignees{/user}","branches_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/branches{/branch}","tags_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/tags","blobs_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/git/refs{/sha}","trees_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/statuses/{sha}","languages_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/languages","stargazers_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/stargazers","contributors_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/contributors","subscribers_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/subscribers","subscription_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/subscription","commits_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/commits{/sha}","git_commits_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/git/commits{/sha}","comments_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/comments{/number}","issue_comment_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/issues/comments{/number}","contents_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/contents/{+path}","compare_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/merges","archive_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/downloads","issues_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/issues{/number}","pulls_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/pulls{/number}","milestones_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/milestones{/number}","notifications_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/labels{/name}","releases_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/releases{/id}","deployments_url":"https://api.github.com/repos/pdecat/terraform-provider-pagerduty/deployments","created_at":"2017-09-27T13:00:54Z","updated_at":"2018-05-31T17:57:41Z","pushed_at":"2018-08-14T16:34:56Z","git_url":"git://github.com/pdecat/terraform-provider-pagerduty.git","ssh_url":"git@github.com:pdecat/terraform-provider-pagerduty.git","clone_url":"https://github.com/pdecat/terraform-provider-pagerduty.git","svn_url":"https://github.com/pdecat/terraform-provider-pagerduty","homepage":"","size":4289,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"terraform-providers:master","ref":"master","sha":"bf929ed4479518c779d62df3540ab403446c4534","user":{"login":"terraform-providers","id":29154831,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTU0ODMx","avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"repo":{"id":93446054,"node_id":"MDEwOlJlcG9zaXRvcnk5MzQ0NjA1NA==","name":"terraform-provider-pagerduty","full_name":"terraform-providers/terraform-provider-pagerduty","owner":{"login":"terraform-providers","id":29154831,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTU0ODMx","avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/terraform-providers/terraform-provider-pagerduty","description":"Terraform PagerDuty provider","fork":false,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty","forks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/forks","keys_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/teams","hooks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/hooks","issue_events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/issues/events{/number}","events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/events","assignees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/assignees{/user}","branches_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/branches{/branch}","tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/tags","blobs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/git/refs{/sha}","trees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/statuses/{sha}","languages_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/languages","stargazers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/stargazers","contributors_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/contributors","subscribers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/subscribers","subscription_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/subscription","commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/commits{/sha}","git_commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/git/commits{/sha}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/comments{/number}","issue_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/issues/comments{/number}","contents_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/contents/{+path}","compare_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/merges","archive_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/downloads","issues_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/issues{/number}","pulls_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/pulls{/number}","milestones_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/milestones{/number}","notifications_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/labels{/name}","releases_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/releases{/id}","deployments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/deployments","created_at":"2017-06-05T20:53:58Z","updated_at":"2018-08-14T13:48:58Z","pushed_at":"2018-08-14T16:34:58Z","git_url":"git://github.com/terraform-providers/terraform-provider-pagerduty.git","ssh_url":"git@github.com:terraform-providers/terraform-provider-pagerduty.git","clone_url":"https://github.com/terraform-providers/terraform-provider-pagerduty.git","svn_url":"https://github.com/terraform-providers/terraform-provider-pagerduty","homepage":"https://www.terraform.io/docs/providers/pagerduty/","size":2143,"stargazers_count":27,"watchers_count":27,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":23,"open_issues":12,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/pulls/84"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-pagerduty/pull/84"},"issue":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/issues/84"},"comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-pagerduty/statuses/43422b517d17de01fac38cd7639e7749d757066d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"heimweh"}}