{"action":"created","issue":{"url":"https://api.github.com/repos/MDAnalysis/pmda/issues/66","repository_url":"https://api.github.com/repos/MDAnalysis/pmda","labels_url":"https://api.github.com/repos/MDAnalysis/pmda/issues/66/labels{/name}","comments_url":"https://api.github.com/repos/MDAnalysis/pmda/issues/66/comments","events_url":"https://api.github.com/repos/MDAnalysis/pmda/issues/66/events","html_url":"https://github.com/MDAnalysis/pmda/pull/66","id":362183181,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2OTY4Mjkz","number":66,"title":"update to dask 0.18.0","user":{"login":"kain88-de","id":4302678,"node_id":"MDQ6VXNlcjQzMDI2Nzg=","avatar_url":"https://avatars0.githubusercontent.com/u/4302678?v=4","gravatar_id":"","url":"https://api.github.com/users/kain88-de","html_url":"https://github.com/kain88-de","followers_url":"https://api.github.com/users/kain88-de/followers","following_url":"https://api.github.com/users/kain88-de/following{/other_user}","gists_url":"https://api.github.com/users/kain88-de/gists{/gist_id}","starred_url":"https://api.github.com/users/kain88-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kain88-de/subscriptions","organizations_url":"https://api.github.com/users/kain88-de/orgs","repos_url":"https://api.github.com/users/kain88-de/repos","events_url":"https://api.github.com/users/kain88-de/events{/privacy}","received_events_url":"https://api.github.com/users/kain88-de/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-09-20T13:17:20Z","updated_at":"2018-10-30T19:55:26Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/MDAnalysis/pmda/pulls/66","html_url":"https://github.com/MDAnalysis/pmda/pull/66","diff_url":"https://github.com/MDAnalysis/pmda/pull/66.diff","patch_url":"https://github.com/MDAnalysis/pmda/pull/66.patch"},"body":"\r\nChanges made in this Pull Request:\r\n - https://github.com/dask/dask/pull/3448\r\n\r\n\r\nPR Checklist\r\n------------\r\n - [ ] Tests?\r\n - [ ] Docs?\r\n - [ ] CHANGELOG updated?\r\n - [ ] Issue raised/referenced?\r\n"},"comment":{"url":"https://api.github.com/repos/MDAnalysis/pmda/issues/comments/434446216","html_url":"https://github.com/MDAnalysis/pmda/pull/66#issuecomment-434446216","issue_url":"https://api.github.com/repos/MDAnalysis/pmda/issues/66","id":434446216,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDQ0NjIxNg==","user":{"login":"orbeckst","id":237980,"node_id":"MDQ6VXNlcjIzNzk4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/237980?v=4","gravatar_id":"","url":"https://api.github.com/users/orbeckst","html_url":"https://github.com/orbeckst","followers_url":"https://api.github.com/users/orbeckst/followers","following_url":"https://api.github.com/users/orbeckst/following{/other_user}","gists_url":"https://api.github.com/users/orbeckst/gists{/gist_id}","starred_url":"https://api.github.com/users/orbeckst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orbeckst/subscriptions","organizations_url":"https://api.github.com/users/orbeckst/orgs","repos_url":"https://api.github.com/users/orbeckst/repos","events_url":"https://api.github.com/users/orbeckst/events{/privacy}","received_events_url":"https://api.github.com/users/orbeckst/received_events","type":"User","site_admin":false},"created_at":"2018-10-30T19:55:26Z","updated_at":"2018-10-30T19:55:26Z","author_association":"MEMBER","body":"From my reading, [setting the scheduler on `compute()`](http://docs.dask.org/en/latest/scheduling.html#configuration)\r\n```python\r\nx.compute(scheduler='threads')\r\n```\r\nis still supported. I _think_ as long as all our `compute()` calls also contain the scheduler, we should be ok, even though\r\n```python\r\nclient = Client(...)  # Connect to distributed cluster and override default\r\n```\r\nwill set the global defaults.\r\n\r\nOr do I misunderstand how this is working now?\r\n\r\n> The correct solution seems to rather be we remove the scheduler and get keyword arguments completely.\r\n\r\nI think you're right that this is the medium term correct solution so that using PMDA conforms to how people use Dask. In the short term (i.e., for this PR at least!) I'd like to move ahead with our current scheduler argument because it is still correct.\r\n\r\nOr do you see a problem? \r\n\r\n\r\n"}}
{"actor":{"display_login":"orbeckst"}}