{"action":"created","issue":{"url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/issues/2118","repository_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform","labels_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/issues/2118/labels{/name}","comments_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/issues/2118/comments","events_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/issues/2118/events","html_url":"https://github.com/dnnsoftware/Dnn.Platform/pull/2118","id":331741352,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0Mzk4NDE1","number":2118,"title":"Fix breaking dll rename of SharpZipLib - issue #2095","user":{"login":"iJungleboy","id":5321186,"node_id":"MDQ6VXNlcjUzMjExODY=","avatar_url":"https://avatars3.githubusercontent.com/u/5321186?v=4","gravatar_id":"","url":"https://api.github.com/users/iJungleboy","html_url":"https://github.com/iJungleboy","followers_url":"https://api.github.com/users/iJungleboy/followers","following_url":"https://api.github.com/users/iJungleboy/following{/other_user}","gists_url":"https://api.github.com/users/iJungleboy/gists{/gist_id}","starred_url":"https://api.github.com/users/iJungleboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iJungleboy/subscriptions","organizations_url":"https://api.github.com/users/iJungleboy/orgs","repos_url":"https://api.github.com/users/iJungleboy/repos","events_url":"https://api.github.com/users/iJungleboy/events{/privacy}","received_events_url":"https://api.github.com/users/iJungleboy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-06-12T20:28:36Z","updated_at":"2018-06-19T14:03:57Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/pulls/2118","html_url":"https://github.com/dnnsoftware/Dnn.Platform/pull/2118","diff_url":"https://github.com/dnnsoftware/Dnn.Platform/pull/2118.diff","patch_url":"https://github.com/dnnsoftware/Dnn.Platform/pull/2118.patch"},"body":"<!-- \r\n  Please make sure that there is a correcponding issue created and reference it in the PR by writing\r\n  `Fixes #123` or `Closes #123`. \r\n  A PR without an accompanying issue will be accepted and merged on a very rare occasion\r\n-->\r\n\r\n## Summary\r\nFixes #2095 by registering an assembly-resolver that is used by .net when an assembly isn't found. So if something tries to get SharpZipLib.dll and fails, this resolver will kick in and tell .net that it's in the new assembly `ICSharpCode.SharpZipLib`. \r\n\r\nI also added a readme.md explaining it some more, and the \"register assembly handler\" must happen very early, which is why I needed to put it into the application start. \r\n"},"comment":{"url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/issues/comments/398410426","html_url":"https://github.com/dnnsoftware/Dnn.Platform/pull/2118#issuecomment-398410426","issue_url":"https://api.github.com/repos/dnnsoftware/Dnn.Platform/issues/2118","id":398410426,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODQxMDQyNg==","user":{"login":"ohine","id":1687117,"node_id":"MDQ6VXNlcjE2ODcxMTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1687117?v=4","gravatar_id":"","url":"https://api.github.com/users/ohine","html_url":"https://github.com/ohine","followers_url":"https://api.github.com/users/ohine/followers","following_url":"https://api.github.com/users/ohine/following{/other_user}","gists_url":"https://api.github.com/users/ohine/gists{/gist_id}","starred_url":"https://api.github.com/users/ohine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ohine/subscriptions","organizations_url":"https://api.github.com/users/ohine/orgs","repos_url":"https://api.github.com/users/ohine/repos","events_url":"https://api.github.com/users/ohine/events{/privacy}","received_events_url":"https://api.github.com/users/ohine/received_events","type":"User","site_admin":false},"created_at":"2018-06-19T14:03:57Z","updated_at":"2018-06-19T14:03:57Z","author_association":"CONTRIBUTOR","body":"Maybe @ashishpd might know some history on that function/class and it's purpose in the platform?\r\n\r\nhttps://github.com/dnnsoftware/Dnn.Platform/blob/6387dd1a7e55cdd994d567cdb76733fbd63819dc/DNN%20Platform/Library/Framework/Reflections/TypeLocator.cs#L69-L124"}}
{"actor":{"display_login":"ohine"}}