{"action":"created","issue":{"url":"https://api.github.com/repos/bh107/bohrium/issues/527","repository_url":"https://api.github.com/repos/bh107/bohrium","labels_url":"https://api.github.com/repos/bh107/bohrium/issues/527/labels{/name}","comments_url":"https://api.github.com/repos/bh107/bohrium/issues/527/comments","events_url":"https://api.github.com/repos/bh107/bohrium/issues/527/events","html_url":"https://github.com/bh107/bohrium/pull/527","id":312200734,"number":527,"title":"Fix randn on python 3","user":{"login":"dionhaefner","id":11994217,"avatar_url":"https://avatars0.githubusercontent.com/u/11994217?v=4","gravatar_id":"","url":"https://api.github.com/users/dionhaefner","html_url":"https://github.com/dionhaefner","followers_url":"https://api.github.com/users/dionhaefner/followers","following_url":"https://api.github.com/users/dionhaefner/following{/other_user}","gists_url":"https://api.github.com/users/dionhaefner/gists{/gist_id}","starred_url":"https://api.github.com/users/dionhaefner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dionhaefner/subscriptions","organizations_url":"https://api.github.com/users/dionhaefner/orgs","repos_url":"https://api.github.com/users/dionhaefner/repos","events_url":"https://api.github.com/users/dionhaefner/events{/privacy}","received_events_url":"https://api.github.com/users/dionhaefner/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-04-07T11:56:00Z","updated_at":"2018-04-08T19:57:26Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/bh107/bohrium/pulls/527","html_url":"https://github.com/bh107/bohrium/pull/527","diff_url":"https://github.com/bh107/bohrium/pull/527.diff","patch_url":"https://github.com/bh107/bohrium/pull/527.patch"},"body":"Using `bh.random.randn` on Python 3 gave\r\n\r\n```python\r\n>>> bh.random.randn(10, 10)\r\nTraceback (most recent call last):\r\n  File \"<stdin>\", line 1, in <module>\r\n  File \"random123.pyx\", line 556, in random123.RandomState.randn\r\n  File \"random123.pyx\", line 691, in random123.RandomState.standard_normal\r\n  File \"random123.pyx\", line 259, in random123.RandomState.random_sample\r\n  File \"random123.pyx\", line 213, in random123.RandomState.random123\r\n  File \"bhary.pyx\", line 95, in bhary.fix_biclass_wrapper.inner\r\n  File \"/home/dion/.virtualenvs/veros3/lib/python3.6/site-packages/bohrium/array_manipulation.py\", line 372, in reshape\r\n    return numpy.ndarray.reshape(a, newshape, **kwargs)\r\nTypeError: 'float' object cannot be interpreted as an integer\r\n```\r\n\r\nthe cause being that `/` defaults to float division on Python 3."},"comment":{"url":"https://api.github.com/repos/bh107/bohrium/issues/comments/379577819","html_url":"https://github.com/bh107/bohrium/pull/527#issuecomment-379577819","issue_url":"https://api.github.com/repos/bh107/bohrium/issues/527","id":379577819,"user":{"login":"dionhaefner","id":11994217,"avatar_url":"https://avatars0.githubusercontent.com/u/11994217?v=4","gravatar_id":"","url":"https://api.github.com/users/dionhaefner","html_url":"https://github.com/dionhaefner","followers_url":"https://api.github.com/users/dionhaefner/followers","following_url":"https://api.github.com/users/dionhaefner/following{/other_user}","gists_url":"https://api.github.com/users/dionhaefner/gists{/gist_id}","starred_url":"https://api.github.com/users/dionhaefner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dionhaefner/subscriptions","organizations_url":"https://api.github.com/users/dionhaefner/orgs","repos_url":"https://api.github.com/users/dionhaefner/repos","events_url":"https://api.github.com/users/dionhaefner/events{/privacy}","received_events_url":"https://api.github.com/users/dionhaefner/received_events","type":"User","site_admin":false},"created_at":"2018-04-08T19:57:26Z","updated_at":"2018-04-08T19:57:26Z","author_association":"CONTRIBUTOR","body":"What do you mean by full test? Obviously can't test it against NumPy, since that uses a different RNG, doesn't it?"}}
{"actor":{"display_login":"dionhaefner"}}