{"action":"created","issue":{"url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/issues/164","repository_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack","labels_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/issues/164/labels{/name}","comments_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/issues/164/comments","events_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/issues/164/events","html_url":"https://github.com/ashleygwilliams/wasm-pack/pull/164","id":331322237,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MDgxOTA0","number":164,"title":"Fix spinners","user":{"login":"migerh","id":368715,"node_id":"MDQ6VXNlcjM2ODcxNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/368715?v=4","gravatar_id":"","url":"https://api.github.com/users/migerh","html_url":"https://github.com/migerh","followers_url":"https://api.github.com/users/migerh/followers","following_url":"https://api.github.com/users/migerh/following{/other_user}","gists_url":"https://api.github.com/users/migerh/gists{/gist_id}","starred_url":"https://api.github.com/users/migerh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/migerh/subscriptions","organizations_url":"https://api.github.com/users/migerh/orgs","repos_url":"https://api.github.com/users/migerh/repos","events_url":"https://api.github.com/users/migerh/events{/privacy}","received_events_url":"https://api.github.com/users/migerh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"mgattozzi","id":3514399,"node_id":"MDQ6VXNlcjM1MTQzOTk=","avatar_url":"https://avatars3.githubusercontent.com/u/3514399?v=4","gravatar_id":"","url":"https://api.github.com/users/mgattozzi","html_url":"https://github.com/mgattozzi","followers_url":"https://api.github.com/users/mgattozzi/followers","following_url":"https://api.github.com/users/mgattozzi/following{/other_user}","gists_url":"https://api.github.com/users/mgattozzi/gists{/gist_id}","starred_url":"https://api.github.com/users/mgattozzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgattozzi/subscriptions","organizations_url":"https://api.github.com/users/mgattozzi/orgs","repos_url":"https://api.github.com/users/mgattozzi/repos","events_url":"https://api.github.com/users/mgattozzi/events{/privacy}","received_events_url":"https://api.github.com/users/mgattozzi/received_events","type":"User","site_admin":false},"assignees":[{"login":"mgattozzi","id":3514399,"node_id":"MDQ6VXNlcjM1MTQzOTk=","avatar_url":"https://avatars3.githubusercontent.com/u/3514399?v=4","gravatar_id":"","url":"https://api.github.com/users/mgattozzi","html_url":"https://github.com/mgattozzi","followers_url":"https://api.github.com/users/mgattozzi/followers","following_url":"https://api.github.com/users/mgattozzi/following{/other_user}","gists_url":"https://api.github.com/users/mgattozzi/gists{/gist_id}","starred_url":"https://api.github.com/users/mgattozzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgattozzi/subscriptions","organizations_url":"https://api.github.com/users/mgattozzi/orgs","repos_url":"https://api.github.com/users/mgattozzi/repos","events_url":"https://api.github.com/users/mgattozzi/events{/privacy}","received_events_url":"https://api.github.com/users/mgattozzi/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/milestones/4","html_url":"https://github.com/ashleygwilliams/wasm-pack/milestone/4","labels_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/milestones/4/labels","id":3279310,"node_id":"MDk6TWlsZXN0b25lMzI3OTMxMA==","number":4,"title":"0.4.0","description":"","creator":{"login":"ashleygwilliams","id":1163554,"node_id":"MDQ6VXNlcjExNjM1NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1163554?v=4","gravatar_id":"","url":"https://api.github.com/users/ashleygwilliams","html_url":"https://github.com/ashleygwilliams","followers_url":"https://api.github.com/users/ashleygwilliams/followers","following_url":"https://api.github.com/users/ashleygwilliams/following{/other_user}","gists_url":"https://api.github.com/users/ashleygwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/ashleygwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashleygwilliams/subscriptions","organizations_url":"https://api.github.com/users/ashleygwilliams/orgs","repos_url":"https://api.github.com/users/ashleygwilliams/repos","events_url":"https://api.github.com/users/ashleygwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/ashleygwilliams/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":15,"state":"open","created_at":"2018-04-18T21:38:17Z","updated_at":"2018-06-13T20:34:50Z","due_on":"2018-06-13T07:00:00Z","closed_at":null},"comments":9,"created_at":"2018-06-11T19:39:06Z","updated_at":"2018-06-14T06:00:41Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/pulls/164","html_url":"https://github.com/ashleygwilliams/wasm-pack/pull/164","diff_url":"https://github.com/ashleygwilliams/wasm-pack/pull/164.diff","patch_url":"https://github.com/ashleygwilliams/wasm-pack/pull/164.patch"},"body":"This is an attempt to fix #145.\r\n\r\nSince I'm new to rust there are a few things I'm not sure about, e.g. the use of RwLock to not have to deal with mutable ProgressOutput instance in the rest of the codebase and how to properly cache the infos/warnings/errors until the spinner is finished. If there are better ways - some pointers in the right direction would be appreciated.\r\n\r\nThis is not my first attempt to fix the spinners, but it is the first one that does not cause more problems than it solves:\r\n\r\n* Using multibar does not work properly while running a child process.\r\n* Instantiating a new spinner and not add it to a multibar breaks as soon an error/warning/info is emitted. The last of these immediate outputs will get absorbed by the spinner as well (see example in #145).\r\n* Keeping a single spinner the whole time and using the indicatif prefix feature to keep the previous spinners output as well as infos/warnings/errors did not work out so well either: The prefix would be output again and again on every tick of a spinner, spamming the terminal.\r\n\r\n\r\nMake sure these boxes are checked! 📦✅\r\n\r\n- [x] You have the latest version of `rustfmt` installed and have your cloned directory set to nightly\r\n- [x] You ran `rustfmt` on the code base before submitting\r\n- [x] You reference which issue is being closed in the PR text\r\n\r\n✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨\r\n\r\nThanks for creating/maintaining wasm-pack :)"},"comment":{"url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/issues/comments/397180689","html_url":"https://github.com/ashleygwilliams/wasm-pack/pull/164#issuecomment-397180689","issue_url":"https://api.github.com/repos/ashleygwilliams/wasm-pack/issues/164","id":397180689,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzE4MDY4OQ==","user":{"login":"migerh","id":368715,"node_id":"MDQ6VXNlcjM2ODcxNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/368715?v=4","gravatar_id":"","url":"https://api.github.com/users/migerh","html_url":"https://github.com/migerh","followers_url":"https://api.github.com/users/migerh/followers","following_url":"https://api.github.com/users/migerh/following{/other_user}","gists_url":"https://api.github.com/users/migerh/gists{/gist_id}","starred_url":"https://api.github.com/users/migerh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/migerh/subscriptions","organizations_url":"https://api.github.com/users/migerh/orgs","repos_url":"https://api.github.com/users/migerh/repos","events_url":"https://api.github.com/users/migerh/events{/privacy}","received_events_url":"https://api.github.com/users/migerh/received_events","type":"User","site_admin":false},"created_at":"2018-06-14T06:00:41Z","updated_at":"2018-06-14T06:00:41Z","author_association":"NONE","body":"> @mgattozzi or @migerh could one of you file an issue about the refactoring we'd like to see for this later?\r\n\r\nDone: #179 "}}
{"actor":{"display_login":"migerh"}}