{"action":"created","comment":{"url":"https://api.github.com/repos/obspy/obspy/pulls/comments/183360164","pull_request_review_id":114341108,"id":183360164,"diff_hunk":"@@ -1109,7 +1109,8 @@ def nordpick(event):\n                 else:\n                     amp = None\n                 coda = ' '\n-                if amplitude.magnitude_hint.upper() == 'ML':\n+                mag_hint = (amplitude.magnitude_hint or amplitude.type)\n+                if mag_hint is not None and mag_hint.upper() in ['AML', 'ML']:\n                     phase_hint = 'IAML'","path":"obspy/io/nordic/core.py","position":16,"original_position":16,"commit_id":"cd478047ff2572a90f1397a002ab4dc45706ebc5","original_commit_id":"104de40fd971ddfab65dab46d7d5a12740f738e4","user":{"login":"megies","id":1842780,"avatar_url":"https://avatars1.githubusercontent.com/u/1842780?v=4","gravatar_id":"","url":"https://api.github.com/users/megies","html_url":"https://github.com/megies","followers_url":"https://api.github.com/users/megies/followers","following_url":"https://api.github.com/users/megies/following{/other_user}","gists_url":"https://api.github.com/users/megies/gists{/gist_id}","starred_url":"https://api.github.com/users/megies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/megies/subscriptions","organizations_url":"https://api.github.com/users/megies/orgs","repos_url":"https://api.github.com/users/megies/repos","events_url":"https://api.github.com/users/megies/events{/privacy}","received_events_url":"https://api.github.com/users/megies/received_events","type":"User","site_admin":false},"body":"Ah well, maybe I'm just looking at the QuakeML standards a bit differently and it's OK that way. The `phase_hint` might be slightly misused, but hey if you guys actually using this format think it's fine this way, that's good enough for me.","created_at":"2018-04-23T11:24:44Z","updated_at":"2018-04-23T11:24:45Z","html_url":"https://github.com/obspy/obspy/pull/2021#discussion_r183360164","pull_request_url":"https://api.github.com/repos/obspy/obspy/pulls/2021","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/obspy/obspy/pulls/comments/183360164"},"html":{"href":"https://github.com/obspy/obspy/pull/2021#discussion_r183360164"},"pull_request":{"href":"https://api.github.com/repos/obspy/obspy/pulls/2021"}},"in_reply_to_id":180784217},"pull_request":{"url":"https://api.github.com/repos/obspy/obspy/pulls/2021","id":156587109,"html_url":"https://github.com/obspy/obspy/pull/2021","diff_url":"https://github.com/obspy/obspy/pull/2021.diff","patch_url":"https://github.com/obspy/obspy/pull/2021.patch","issue_url":"https://api.github.com/repos/obspy/obspy/issues/2021","number":2021,"state":"open","locked":false,"title":"nordic: Bug-fix amplitude and wavefile write","user":{"login":"calum-chamberlain","id":10913395,"avatar_url":"https://avatars0.githubusercontent.com/u/10913395?v=4","gravatar_id":"","url":"https://api.github.com/users/calum-chamberlain","html_url":"https://github.com/calum-chamberlain","followers_url":"https://api.github.com/users/calum-chamberlain/followers","following_url":"https://api.github.com/users/calum-chamberlain/following{/other_user}","gists_url":"https://api.github.com/users/calum-chamberlain/gists{/gist_id}","starred_url":"https://api.github.com/users/calum-chamberlain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calum-chamberlain/subscriptions","organizations_url":"https://api.github.com/users/calum-chamberlain/orgs","repos_url":"https://api.github.com/users/calum-chamberlain/repos","events_url":"https://api.github.com/users/calum-chamberlain/events{/privacy}","received_events_url":"https://api.github.com/users/calum-chamberlain/received_events","type":"User","site_admin":false},"body":"- Wavefile lines were not correctly justified when full paths were given\r\n- amplitudes were not handled when `magnitude_hint` was `None`\r\n\r\n### PR Checklist\r\n- [x] Correct base branch selected? `master` for new fetures, `maintenance_...` for bug fixes\r\n- [x] This PR is not directly related to an existing issue (which has no PR yet).\r\n~~- [ ] If the PR is making changes to documentation, docs pages can be built automatically.\r\n      Just remove the space in the following string after the + sign: \"+ DOCS\"~~\r\n~~- [ ] If any network modules should be tested for the PR, add them as a comma separated list\r\n      (e.g. `clients.fdsn,clients.arclink`) after the colon in the following magic string: \"+TESTS:\"\r\n      (you can also add \"ALL\" to just simply run all tests across all modules)~~\r\n- [x] All tests still pass.\r\n- [x] Any new features or fixed regressions are be covered via new tests.\r\n~~- [ ] Any new or changed features have are fully documented.~~\r\n- [x] Significant changes have been added to `CHANGELOG.txt` .\r\n~~- [ ] First time contributors have added your name to `CONTRIBUTORS.txt` .~~\r\n\r\nThis PR needs a new test including amplitudes without magntiude_hint and with type and without type defined.  It also needs a test with a wavefile with a full path given.","created_at":"2017-12-05T22:05:28Z","updated_at":"2018-04-23T11:24:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9218d913f4a2ba58720d2b26451e67670769f137","assignee":{"login":"calum-chamberlain","id":10913395,"avatar_url":"https://avatars0.githubusercontent.com/u/10913395?v=4","gravatar_id":"","url":"https://api.github.com/users/calum-chamberlain","html_url":"https://github.com/calum-chamberlain","followers_url":"https://api.github.com/users/calum-chamberlain/followers","following_url":"https://api.github.com/users/calum-chamberlain/following{/other_user}","gists_url":"https://api.github.com/users/calum-chamberlain/gists{/gist_id}","starred_url":"https://api.github.com/users/calum-chamberlain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calum-chamberlain/subscriptions","organizations_url":"https://api.github.com/users/calum-chamberlain/orgs","repos_url":"https://api.github.com/users/calum-chamberlain/repos","events_url":"https://api.github.com/users/calum-chamberlain/events{/privacy}","received_events_url":"https://api.github.com/users/calum-chamberlain/received_events","type":"User","site_admin":false},"assignees":[{"login":"calum-chamberlain","id":10913395,"avatar_url":"https://avatars0.githubusercontent.com/u/10913395?v=4","gravatar_id":"","url":"https://api.github.com/users/calum-chamberlain","html_url":"https://github.com/calum-chamberlain","followers_url":"https://api.github.com/users/calum-chamberlain/followers","following_url":"https://api.github.com/users/calum-chamberlain/following{/other_user}","gists_url":"https://api.github.com/users/calum-chamberlain/gists{/gist_id}","starred_url":"https://api.github.com/users/calum-chamberlain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calum-chamberlain/subscriptions","organizations_url":"https://api.github.com/users/calum-chamberlain/orgs","repos_url":"https://api.github.com/users/calum-chamberlain/repos","events_url":"https://api.github.com/users/calum-chamberlain/events{/privacy}","received_events_url":"https://api.github.com/users/calum-chamberlain/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":289116267,"url":"https://api.github.com/repos/obspy/obspy/labels/.io","name":".io","color":"0404B4","default":false},{"id":13498870,"url":"https://api.github.com/repos/obspy/obspy/labels/bug","name":"bug","color":"fc2929","default":true}],"milestone":{"url":"https://api.github.com/repos/obspy/obspy/milestones/17","html_url":"https://github.com/obspy/obspy/milestone/17","labels_url":"https://api.github.com/repos/obspy/obspy/milestones/17/labels","id":2117207,"number":17,"title":"1.1.1","description":"","creator":{"login":"megies","id":1842780,"avatar_url":"https://avatars1.githubusercontent.com/u/1842780?v=4","gravatar_id":"","url":"https://api.github.com/users/megies","html_url":"https://github.com/megies","followers_url":"https://api.github.com/users/megies/followers","following_url":"https://api.github.com/users/megies/following{/other_user}","gists_url":"https://api.github.com/users/megies/gists{/gist_id}","starred_url":"https://api.github.com/users/megies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/megies/subscriptions","organizations_url":"https://api.github.com/users/megies/orgs","repos_url":"https://api.github.com/users/megies/repos","events_url":"https://api.github.com/users/megies/events{/privacy}","received_events_url":"https://api.github.com/users/megies/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":38,"state":"open","created_at":"2016-11-06T15:20:15Z","updated_at":"2018-04-19T14:17:57Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/obspy/obspy/pulls/2021/commits","review_comments_url":"https://api.github.com/repos/obspy/obspy/pulls/2021/comments","review_comment_url":"https://api.github.com/repos/obspy/obspy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/obspy/obspy/issues/2021/comments","statuses_url":"https://api.github.com/repos/obspy/obspy/statuses/cd478047ff2572a90f1397a002ab4dc45706ebc5","head":{"label":"obspy:patch-nordic-amps","ref":"patch-nordic-amps","sha":"cd478047ff2572a90f1397a002ab4dc45706ebc5","user":{"login":"obspy","id":1701221,"avatar_url":"https://avatars2.githubusercontent.com/u/1701221?v=4","gravatar_id":"","url":"https://api.github.com/users/obspy","html_url":"https://github.com/obspy","followers_url":"https://api.github.com/users/obspy/followers","following_url":"https://api.github.com/users/obspy/following{/other_user}","gists_url":"https://api.github.com/users/obspy/gists{/gist_id}","starred_url":"https://api.github.com/users/obspy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obspy/subscriptions","organizations_url":"https://api.github.com/users/obspy/orgs","repos_url":"https://api.github.com/users/obspy/repos","events_url":"https://api.github.com/users/obspy/events{/privacy}","received_events_url":"https://api.github.com/users/obspy/received_events","type":"Organization","site_admin":false},"repo":{"id":5731348,"name":"obspy","full_name":"obspy/obspy","owner":{"login":"obspy","id":1701221,"avatar_url":"https://avatars2.githubusercontent.com/u/1701221?v=4","gravatar_id":"","url":"https://api.github.com/users/obspy","html_url":"https://github.com/obspy","followers_url":"https://api.github.com/users/obspy/followers","following_url":"https://api.github.com/users/obspy/following{/other_user}","gists_url":"https://api.github.com/users/obspy/gists{/gist_id}","starred_url":"https://api.github.com/users/obspy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obspy/subscriptions","organizations_url":"https://api.github.com/users/obspy/orgs","repos_url":"https://api.github.com/users/obspy/repos","events_url":"https://api.github.com/users/obspy/events{/privacy}","received_events_url":"https://api.github.com/users/obspy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/obspy/obspy","description":"ObsPy: A Python Toolbox for seismology/seismological observatories.","fork":false,"url":"https://api.github.com/repos/obspy/obspy","forks_url":"https://api.github.com/repos/obspy/obspy/forks","keys_url":"https://api.github.com/repos/obspy/obspy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/obspy/obspy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/obspy/obspy/teams","hooks_url":"https://api.github.com/repos/obspy/obspy/hooks","issue_events_url":"https://api.github.com/repos/obspy/obspy/issues/events{/number}","events_url":"https://api.github.com/repos/obspy/obspy/events","assignees_url":"https://api.github.com/repos/obspy/obspy/assignees{/user}","branches_url":"https://api.github.com/repos/obspy/obspy/branches{/branch}","tags_url":"https://api.github.com/repos/obspy/obspy/tags","blobs_url":"https://api.github.com/repos/obspy/obspy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/obspy/obspy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/obspy/obspy/git/refs{/sha}","trees_url":"https://api.github.com/repos/obspy/obspy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/obspy/obspy/statuses/{sha}","languages_url":"https://api.github.com/repos/obspy/obspy/languages","stargazers_url":"https://api.github.com/repos/obspy/obspy/stargazers","contributors_url":"https://api.github.com/repos/obspy/obspy/contributors","subscribers_url":"https://api.github.com/repos/obspy/obspy/subscribers","subscription_url":"https://api.github.com/repos/obspy/obspy/subscription","commits_url":"https://api.github.com/repos/obspy/obspy/commits{/sha}","git_commits_url":"https://api.github.com/repos/obspy/obspy/git/commits{/sha}","comments_url":"https://api.github.com/repos/obspy/obspy/comments{/number}","issue_comment_url":"https://api.github.com/repos/obspy/obspy/issues/comments{/number}","contents_url":"https://api.github.com/repos/obspy/obspy/contents/{+path}","compare_url":"https://api.github.com/repos/obspy/obspy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/obspy/obspy/merges","archive_url":"https://api.github.com/repos/obspy/obspy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/obspy/obspy/downloads","issues_url":"https://api.github.com/repos/obspy/obspy/issues{/number}","pulls_url":"https://api.github.com/repos/obspy/obspy/pulls{/number}","milestones_url":"https://api.github.com/repos/obspy/obspy/milestones{/number}","notifications_url":"https://api.github.com/repos/obspy/obspy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/obspy/obspy/labels{/name}","releases_url":"https://api.github.com/repos/obspy/obspy/releases{/id}","deployments_url":"https://api.github.com/repos/obspy/obspy/deployments","created_at":"2012-09-08T19:17:46Z","updated_at":"2018-04-22T03:54:36Z","pushed_at":"2018-04-20T23:40:57Z","git_url":"git://github.com/obspy/obspy.git","ssh_url":"git@github.com:obspy/obspy.git","clone_url":"https://github.com/obspy/obspy.git","svn_url":"https://github.com/obspy/obspy","homepage":"https://www.obspy.org","size":108600,"stargazers_count":383,"watchers_count":383,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":250,"mirror_url":null,"archived":false,"open_issues_count":273,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":250,"open_issues":273,"watchers":383,"default_branch":"master"}},"base":{"label":"obspy:maintenance_1.1.x","ref":"maintenance_1.1.x","sha":"9c1f9ce711ac55555c13326c433654c50c9733c2","user":{"login":"obspy","id":1701221,"avatar_url":"https://avatars2.githubusercontent.com/u/1701221?v=4","gravatar_id":"","url":"https://api.github.com/users/obspy","html_url":"https://github.com/obspy","followers_url":"https://api.github.com/users/obspy/followers","following_url":"https://api.github.com/users/obspy/following{/other_user}","gists_url":"https://api.github.com/users/obspy/gists{/gist_id}","starred_url":"https://api.github.com/users/obspy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obspy/subscriptions","organizations_url":"https://api.github.com/users/obspy/orgs","repos_url":"https://api.github.com/users/obspy/repos","events_url":"https://api.github.com/users/obspy/events{/privacy}","received_events_url":"https://api.github.com/users/obspy/received_events","type":"Organization","site_admin":false},"repo":{"id":5731348,"name":"obspy","full_name":"obspy/obspy","owner":{"login":"obspy","id":1701221,"avatar_url":"https://avatars2.githubusercontent.com/u/1701221?v=4","gravatar_id":"","url":"https://api.github.com/users/obspy","html_url":"https://github.com/obspy","followers_url":"https://api.github.com/users/obspy/followers","following_url":"https://api.github.com/users/obspy/following{/other_user}","gists_url":"https://api.github.com/users/obspy/gists{/gist_id}","starred_url":"https://api.github.com/users/obspy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obspy/subscriptions","organizations_url":"https://api.github.com/users/obspy/orgs","repos_url":"https://api.github.com/users/obspy/repos","events_url":"https://api.github.com/users/obspy/events{/privacy}","received_events_url":"https://api.github.com/users/obspy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/obspy/obspy","description":"ObsPy: A Python Toolbox for seismology/seismological observatories.","fork":false,"url":"https://api.github.com/repos/obspy/obspy","forks_url":"https://api.github.com/repos/obspy/obspy/forks","keys_url":"https://api.github.com/repos/obspy/obspy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/obspy/obspy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/obspy/obspy/teams","hooks_url":"https://api.github.com/repos/obspy/obspy/hooks","issue_events_url":"https://api.github.com/repos/obspy/obspy/issues/events{/number}","events_url":"https://api.github.com/repos/obspy/obspy/events","assignees_url":"https://api.github.com/repos/obspy/obspy/assignees{/user}","branches_url":"https://api.github.com/repos/obspy/obspy/branches{/branch}","tags_url":"https://api.github.com/repos/obspy/obspy/tags","blobs_url":"https://api.github.com/repos/obspy/obspy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/obspy/obspy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/obspy/obspy/git/refs{/sha}","trees_url":"https://api.github.com/repos/obspy/obspy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/obspy/obspy/statuses/{sha}","languages_url":"https://api.github.com/repos/obspy/obspy/languages","stargazers_url":"https://api.github.com/repos/obspy/obspy/stargazers","contributors_url":"https://api.github.com/repos/obspy/obspy/contributors","subscribers_url":"https://api.github.com/repos/obspy/obspy/subscribers","subscription_url":"https://api.github.com/repos/obspy/obspy/subscription","commits_url":"https://api.github.com/repos/obspy/obspy/commits{/sha}","git_commits_url":"https://api.github.com/repos/obspy/obspy/git/commits{/sha}","comments_url":"https://api.github.com/repos/obspy/obspy/comments{/number}","issue_comment_url":"https://api.github.com/repos/obspy/obspy/issues/comments{/number}","contents_url":"https://api.github.com/repos/obspy/obspy/contents/{+path}","compare_url":"https://api.github.com/repos/obspy/obspy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/obspy/obspy/merges","archive_url":"https://api.github.com/repos/obspy/obspy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/obspy/obspy/downloads","issues_url":"https://api.github.com/repos/obspy/obspy/issues{/number}","pulls_url":"https://api.github.com/repos/obspy/obspy/pulls{/number}","milestones_url":"https://api.github.com/repos/obspy/obspy/milestones{/number}","notifications_url":"https://api.github.com/repos/obspy/obspy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/obspy/obspy/labels{/name}","releases_url":"https://api.github.com/repos/obspy/obspy/releases{/id}","deployments_url":"https://api.github.com/repos/obspy/obspy/deployments","created_at":"2012-09-08T19:17:46Z","updated_at":"2018-04-22T03:54:36Z","pushed_at":"2018-04-20T23:40:57Z","git_url":"git://github.com/obspy/obspy.git","ssh_url":"git@github.com:obspy/obspy.git","clone_url":"https://github.com/obspy/obspy.git","svn_url":"https://github.com/obspy/obspy","homepage":"https://www.obspy.org","size":108600,"stargazers_count":383,"watchers_count":383,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":250,"mirror_url":null,"archived":false,"open_issues_count":273,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":250,"open_issues":273,"watchers":383,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/obspy/obspy/pulls/2021"},"html":{"href":"https://github.com/obspy/obspy/pull/2021"},"issue":{"href":"https://api.github.com/repos/obspy/obspy/issues/2021"},"comments":{"href":"https://api.github.com/repos/obspy/obspy/issues/2021/comments"},"review_comments":{"href":"https://api.github.com/repos/obspy/obspy/pulls/2021/comments"},"review_comment":{"href":"https://api.github.com/repos/obspy/obspy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/obspy/obspy/pulls/2021/commits"},"statuses":{"href":"https://api.github.com/repos/obspy/obspy/statuses/cd478047ff2572a90f1397a002ab4dc45706ebc5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"megies"}}