{"action":"created","issue":{"url":"https://api.github.com/repos/benlime/vscode-hex-pm-intellisense/issues/2","repository_url":"https://api.github.com/repos/benlime/vscode-hex-pm-intellisense","labels_url":"https://api.github.com/repos/benlime/vscode-hex-pm-intellisense/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/benlime/vscode-hex-pm-intellisense/issues/2/comments","events_url":"https://api.github.com/repos/benlime/vscode-hex-pm-intellisense/issues/2/events","html_url":"https://github.com/benlime/vscode-hex-pm-intellisense/pull/2","id":309145417,"number":2,"title":"Improve deps block detection. Fixes benlime/vscode-hex-pm-intellisense#1.","user":{"login":"xmbhasin","id":13490604,"avatar_url":"https://avatars1.githubusercontent.com/u/13490604?v=4","gravatar_id":"","url":"https://api.github.com/users/xmbhasin","html_url":"https://github.com/xmbhasin","followers_url":"https://api.github.com/users/xmbhasin/followers","following_url":"https://api.github.com/users/xmbhasin/following{/other_user}","gists_url":"https://api.github.com/users/xmbhasin/gists{/gist_id}","starred_url":"https://api.github.com/users/xmbhasin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmbhasin/subscriptions","organizations_url":"https://api.github.com/users/xmbhasin/orgs","repos_url":"https://api.github.com/users/xmbhasin/repos","events_url":"https://api.github.com/users/xmbhasin/events{/privacy}","received_events_url":"https://api.github.com/users/xmbhasin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-27T21:45:43Z","updated_at":"2018-04-06T03:38:03Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/benlime/vscode-hex-pm-intellisense/pulls/2","html_url":"https://github.com/benlime/vscode-hex-pm-intellisense/pull/2","diff_url":"https://github.com/benlime/vscode-hex-pm-intellisense/pull/2.diff","patch_url":"https://github.com/benlime/vscode-hex-pm-intellisense/pull/2.patch"},"body":"I tried to simplify the solution and the code in `src/shouldProvide.ts`, removing the need for checks on the text to the right of the cursor. I added some `console.log()` calls as comments for debugging and some assumptions the extension currently makes in order to work.\r\n\r\nI tried using regex but things got complicated quickly so I dropped it. But without regex certain assumptions have to be made: eg that the `deps` function doesn't contain `end` as part of an anonymous function or some other block or that there isn't extra whitespace in the head `defp deps do`.\r\n\r\nIntegration tests would be great for working out more flexible detection of the `deps` block."},"comment":{"url":"https://api.github.com/repos/benlime/vscode-hex-pm-intellisense/issues/comments/379139581","html_url":"https://github.com/benlime/vscode-hex-pm-intellisense/pull/2#issuecomment-379139581","issue_url":"https://api.github.com/repos/benlime/vscode-hex-pm-intellisense/issues/2","id":379139581,"user":{"login":"benlime","id":981344,"avatar_url":"https://avatars0.githubusercontent.com/u/981344?v=4","gravatar_id":"","url":"https://api.github.com/users/benlime","html_url":"https://github.com/benlime","followers_url":"https://api.github.com/users/benlime/followers","following_url":"https://api.github.com/users/benlime/following{/other_user}","gists_url":"https://api.github.com/users/benlime/gists{/gist_id}","starred_url":"https://api.github.com/users/benlime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlime/subscriptions","organizations_url":"https://api.github.com/users/benlime/orgs","repos_url":"https://api.github.com/users/benlime/repos","events_url":"https://api.github.com/users/benlime/events{/privacy}","received_events_url":"https://api.github.com/users/benlime/received_events","type":"User","site_admin":false},"created_at":"2018-04-06T03:38:03Z","updated_at":"2018-04-06T03:38:03Z","author_association":"OWNER","body":"Thanks again for your contribution. I'm back and I will have a look at the changes until tomorrow. and hopefully put in a merge. :)"}}
{"actor":{"display_login":"benlime"}}