{"action":"created","comment":{"url":"https://api.github.com/repos/yarnpkg/yarn/pulls/comments/181582327","pull_request_review_id":112237319,"id":181582327,"diff_hunk":"@@ -61,7 +61,7 @@ type ProcessFn = (\n export function spawn(\n   program: string,\n   args: Array<string>,\n-  opts?: child_process$spawnOpts & {process?: ProcessFn} = {},\n+  opts?: child_process$spawnOpts & {detached?: boolean, process?: ProcessFn} = {},","path":"src/util/child.js","position":5,"original_position":5,"commit_id":"e70c8492c341f3881b6b90d0f9c4788f53c0a0d2","original_commit_id":"e70c8492c341f3881b6b90d0f9c4788f53c0a0d2","user":{"login":"BYK","id":126780,"avatar_url":"https://avatars3.githubusercontent.com/u/126780?v=4","gravatar_id":"","url":"https://api.github.com/users/BYK","html_url":"https://github.com/BYK","followers_url":"https://api.github.com/users/BYK/followers","following_url":"https://api.github.com/users/BYK/following{/other_user}","gists_url":"https://api.github.com/users/BYK/gists{/gist_id}","starred_url":"https://api.github.com/users/BYK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BYK/subscriptions","organizations_url":"https://api.github.com/users/BYK/orgs","repos_url":"https://api.github.com/users/BYK/repos","events_url":"https://api.github.com/users/BYK/events{/privacy}","received_events_url":"https://api.github.com/users/BYK/received_events","type":"User","site_admin":false},"body":"Yes to both :)","created_at":"2018-04-15T13:09:09Z","updated_at":"2018-04-15T13:09:09Z","html_url":"https://github.com/yarnpkg/yarn/pull/5632#discussion_r181582327","pull_request_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/5632","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/comments/181582327"},"html":{"href":"https://github.com/yarnpkg/yarn/pull/5632#discussion_r181582327"},"pull_request":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/5632"}},"in_reply_to_id":181451989},"pull_request":{"url":"https://api.github.com/repos/yarnpkg/yarn/pulls/5632","id":180462438,"html_url":"https://github.com/yarnpkg/yarn/pull/5632","diff_url":"https://github.com/yarnpkg/yarn/pull/5632.diff","patch_url":"https://github.com/yarnpkg/yarn/pull/5632.patch","issue_url":"https://api.github.com/repos/yarnpkg/yarn/issues/5632","number":5632,"state":"open","locked":false,"title":"fix(build): Stop scripts from trying to read user input during install","user":{"login":"iarna","id":983798,"avatar_url":"https://avatars1.githubusercontent.com/u/983798?v=4","gravatar_id":"","url":"https://api.github.com/users/iarna","html_url":"https://github.com/iarna","followers_url":"https://api.github.com/users/iarna/followers","following_url":"https://api.github.com/users/iarna/following{/other_user}","gists_url":"https://api.github.com/users/iarna/gists{/gist_id}","starred_url":"https://api.github.com/users/iarna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iarna/subscriptions","organizations_url":"https://api.github.com/users/iarna/orgs","repos_url":"https://api.github.com/users/iarna/repos","events_url":"https://api.github.com/users/iarna/events{/privacy}","received_events_url":"https://api.github.com/users/iarna/received_events","type":"User","site_admin":false},"body":"@byk mentioned to me that this was a problem you all had been having and while doing research for npm running lifecycle scripts in parallel I came across this solution and thought I'd share it with y'all:\r\n\r\nThis is a bug fix to the problem where lifecycle scripts that try to go interactive hang yarn installs with no indication as to why.\r\n\r\nThis sets stdin to /dev/null and, on unix-like systems, detaches the process from the terminal making it unable to read /dev/tty.\r\n\r\nPreviously with the spinner enabled was impossible to give input to an interactive script on stdin, because a pipe was kept open from the main yarn process to the child process but it was never written to.  Interactive scripts could previously use /dev/tty on unix-likes to bypass this, however the fact that scripts are run in parallel means that if two scripts go interactive in this manner that they'll step on each other.\r\n\r\nThis does not change the behavior if the spinner is disabled.","created_at":"2018-04-10T00:40:18Z","updated_at":"2018-04-15T13:09:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f57cae2f84c0c7d1a557c571ce5604ece906861f","assignee":{"login":"BYK","id":126780,"avatar_url":"https://avatars3.githubusercontent.com/u/126780?v=4","gravatar_id":"","url":"https://api.github.com/users/BYK","html_url":"https://github.com/BYK","followers_url":"https://api.github.com/users/BYK/followers","following_url":"https://api.github.com/users/BYK/following{/other_user}","gists_url":"https://api.github.com/users/BYK/gists{/gist_id}","starred_url":"https://api.github.com/users/BYK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BYK/subscriptions","organizations_url":"https://api.github.com/users/BYK/orgs","repos_url":"https://api.github.com/users/BYK/repos","events_url":"https://api.github.com/users/BYK/events{/privacy}","received_events_url":"https://api.github.com/users/BYK/received_events","type":"User","site_admin":false},"assignees":[{"login":"BYK","id":126780,"avatar_url":"https://avatars3.githubusercontent.com/u/126780?v=4","gravatar_id":"","url":"https://api.github.com/users/BYK","html_url":"https://github.com/BYK","followers_url":"https://api.github.com/users/BYK/followers","following_url":"https://api.github.com/users/BYK/following{/other_user}","gists_url":"https://api.github.com/users/BYK/gists{/gist_id}","starred_url":"https://api.github.com/users/BYK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BYK/subscriptions","organizations_url":"https://api.github.com/users/BYK/orgs","repos_url":"https://api.github.com/users/BYK/repos","events_url":"https://api.github.com/users/BYK/events{/privacy}","received_events_url":"https://api.github.com/users/BYK/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"rally25rs","id":38535,"avatar_url":"https://avatars3.githubusercontent.com/u/38535?v=4","gravatar_id":"","url":"https://api.github.com/users/rally25rs","html_url":"https://github.com/rally25rs","followers_url":"https://api.github.com/users/rally25rs/followers","following_url":"https://api.github.com/users/rally25rs/following{/other_user}","gists_url":"https://api.github.com/users/rally25rs/gists{/gist_id}","starred_url":"https://api.github.com/users/rally25rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rally25rs/subscriptions","organizations_url":"https://api.github.com/users/rally25rs/orgs","repos_url":"https://api.github.com/users/rally25rs/repos","events_url":"https://api.github.com/users/rally25rs/events{/privacy}","received_events_url":"https://api.github.com/users/rally25rs/received_events","type":"User","site_admin":false},{"login":"bestander","id":2121048,"avatar_url":"https://avatars3.githubusercontent.com/u/2121048?v=4","gravatar_id":"","url":"https://api.github.com/users/bestander","html_url":"https://github.com/bestander","followers_url":"https://api.github.com/users/bestander/followers","following_url":"https://api.github.com/users/bestander/following{/other_user}","gists_url":"https://api.github.com/users/bestander/gists{/gist_id}","starred_url":"https://api.github.com/users/bestander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bestander/subscriptions","organizations_url":"https://api.github.com/users/bestander/orgs","repos_url":"https://api.github.com/users/bestander/repos","events_url":"https://api.github.com/users/bestander/events{/privacy}","received_events_url":"https://api.github.com/users/bestander/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/5632/commits","review_comments_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/5632/comments","review_comment_url":"https://api.github.com/repos/yarnpkg/yarn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yarnpkg/yarn/issues/5632/comments","statuses_url":"https://api.github.com/repos/yarnpkg/yarn/statuses/e70c8492c341f3881b6b90d0f9c4788f53c0a0d2","head":{"label":"iarna:patch-1","ref":"patch-1","sha":"e70c8492c341f3881b6b90d0f9c4788f53c0a0d2","user":{"login":"iarna","id":983798,"avatar_url":"https://avatars1.githubusercontent.com/u/983798?v=4","gravatar_id":"","url":"https://api.github.com/users/iarna","html_url":"https://github.com/iarna","followers_url":"https://api.github.com/users/iarna/followers","following_url":"https://api.github.com/users/iarna/following{/other_user}","gists_url":"https://api.github.com/users/iarna/gists{/gist_id}","starred_url":"https://api.github.com/users/iarna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iarna/subscriptions","organizations_url":"https://api.github.com/users/iarna/orgs","repos_url":"https://api.github.com/users/iarna/repos","events_url":"https://api.github.com/users/iarna/events{/privacy}","received_events_url":"https://api.github.com/users/iarna/received_events","type":"User","site_admin":false},"repo":{"id":128849529,"name":"yarn","full_name":"iarna/yarn","owner":{"login":"iarna","id":983798,"avatar_url":"https://avatars1.githubusercontent.com/u/983798?v=4","gravatar_id":"","url":"https://api.github.com/users/iarna","html_url":"https://github.com/iarna","followers_url":"https://api.github.com/users/iarna/followers","following_url":"https://api.github.com/users/iarna/following{/other_user}","gists_url":"https://api.github.com/users/iarna/gists{/gist_id}","starred_url":"https://api.github.com/users/iarna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iarna/subscriptions","organizations_url":"https://api.github.com/users/iarna/orgs","repos_url":"https://api.github.com/users/iarna/repos","events_url":"https://api.github.com/users/iarna/events{/privacy}","received_events_url":"https://api.github.com/users/iarna/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iarna/yarn","description":"📦🐈 Fast, reliable, and secure dependency management.","fork":true,"url":"https://api.github.com/repos/iarna/yarn","forks_url":"https://api.github.com/repos/iarna/yarn/forks","keys_url":"https://api.github.com/repos/iarna/yarn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iarna/yarn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iarna/yarn/teams","hooks_url":"https://api.github.com/repos/iarna/yarn/hooks","issue_events_url":"https://api.github.com/repos/iarna/yarn/issues/events{/number}","events_url":"https://api.github.com/repos/iarna/yarn/events","assignees_url":"https://api.github.com/repos/iarna/yarn/assignees{/user}","branches_url":"https://api.github.com/repos/iarna/yarn/branches{/branch}","tags_url":"https://api.github.com/repos/iarna/yarn/tags","blobs_url":"https://api.github.com/repos/iarna/yarn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iarna/yarn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iarna/yarn/git/refs{/sha}","trees_url":"https://api.github.com/repos/iarna/yarn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iarna/yarn/statuses/{sha}","languages_url":"https://api.github.com/repos/iarna/yarn/languages","stargazers_url":"https://api.github.com/repos/iarna/yarn/stargazers","contributors_url":"https://api.github.com/repos/iarna/yarn/contributors","subscribers_url":"https://api.github.com/repos/iarna/yarn/subscribers","subscription_url":"https://api.github.com/repos/iarna/yarn/subscription","commits_url":"https://api.github.com/repos/iarna/yarn/commits{/sha}","git_commits_url":"https://api.github.com/repos/iarna/yarn/git/commits{/sha}","comments_url":"https://api.github.com/repos/iarna/yarn/comments{/number}","issue_comment_url":"https://api.github.com/repos/iarna/yarn/issues/comments{/number}","contents_url":"https://api.github.com/repos/iarna/yarn/contents/{+path}","compare_url":"https://api.github.com/repos/iarna/yarn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iarna/yarn/merges","archive_url":"https://api.github.com/repos/iarna/yarn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iarna/yarn/downloads","issues_url":"https://api.github.com/repos/iarna/yarn/issues{/number}","pulls_url":"https://api.github.com/repos/iarna/yarn/pulls{/number}","milestones_url":"https://api.github.com/repos/iarna/yarn/milestones{/number}","notifications_url":"https://api.github.com/repos/iarna/yarn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iarna/yarn/labels{/name}","releases_url":"https://api.github.com/repos/iarna/yarn/releases{/id}","deployments_url":"https://api.github.com/repos/iarna/yarn/deployments","created_at":"2018-04-10T00:25:08Z","updated_at":"2018-04-10T00:25:16Z","pushed_at":"2018-04-12T09:40:16Z","git_url":"git://github.com/iarna/yarn.git","ssh_url":"git@github.com:iarna/yarn.git","clone_url":"https://github.com/iarna/yarn.git","svn_url":"https://github.com/iarna/yarn","homepage":"https://yarnpkg.com","size":115359,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yarnpkg:master","ref":"master","sha":"6a4ef66ac5875226e3bd2448bd86ff01bee2a253","user":{"login":"yarnpkg","id":22247014,"avatar_url":"https://avatars3.githubusercontent.com/u/22247014?v=4","gravatar_id":"","url":"https://api.github.com/users/yarnpkg","html_url":"https://github.com/yarnpkg","followers_url":"https://api.github.com/users/yarnpkg/followers","following_url":"https://api.github.com/users/yarnpkg/following{/other_user}","gists_url":"https://api.github.com/users/yarnpkg/gists{/gist_id}","starred_url":"https://api.github.com/users/yarnpkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarnpkg/subscriptions","organizations_url":"https://api.github.com/users/yarnpkg/orgs","repos_url":"https://api.github.com/users/yarnpkg/repos","events_url":"https://api.github.com/users/yarnpkg/events{/privacy}","received_events_url":"https://api.github.com/users/yarnpkg/received_events","type":"Organization","site_admin":false},"repo":{"id":49970642,"name":"yarn","full_name":"yarnpkg/yarn","owner":{"login":"yarnpkg","id":22247014,"avatar_url":"https://avatars3.githubusercontent.com/u/22247014?v=4","gravatar_id":"","url":"https://api.github.com/users/yarnpkg","html_url":"https://github.com/yarnpkg","followers_url":"https://api.github.com/users/yarnpkg/followers","following_url":"https://api.github.com/users/yarnpkg/following{/other_user}","gists_url":"https://api.github.com/users/yarnpkg/gists{/gist_id}","starred_url":"https://api.github.com/users/yarnpkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarnpkg/subscriptions","organizations_url":"https://api.github.com/users/yarnpkg/orgs","repos_url":"https://api.github.com/users/yarnpkg/repos","events_url":"https://api.github.com/users/yarnpkg/events{/privacy}","received_events_url":"https://api.github.com/users/yarnpkg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yarnpkg/yarn","description":"📦🐈 Fast, reliable, and secure dependency management.","fork":false,"url":"https://api.github.com/repos/yarnpkg/yarn","forks_url":"https://api.github.com/repos/yarnpkg/yarn/forks","keys_url":"https://api.github.com/repos/yarnpkg/yarn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarnpkg/yarn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarnpkg/yarn/teams","hooks_url":"https://api.github.com/repos/yarnpkg/yarn/hooks","issue_events_url":"https://api.github.com/repos/yarnpkg/yarn/issues/events{/number}","events_url":"https://api.github.com/repos/yarnpkg/yarn/events","assignees_url":"https://api.github.com/repos/yarnpkg/yarn/assignees{/user}","branches_url":"https://api.github.com/repos/yarnpkg/yarn/branches{/branch}","tags_url":"https://api.github.com/repos/yarnpkg/yarn/tags","blobs_url":"https://api.github.com/repos/yarnpkg/yarn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarnpkg/yarn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarnpkg/yarn/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarnpkg/yarn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarnpkg/yarn/statuses/{sha}","languages_url":"https://api.github.com/repos/yarnpkg/yarn/languages","stargazers_url":"https://api.github.com/repos/yarnpkg/yarn/stargazers","contributors_url":"https://api.github.com/repos/yarnpkg/yarn/contributors","subscribers_url":"https://api.github.com/repos/yarnpkg/yarn/subscribers","subscription_url":"https://api.github.com/repos/yarnpkg/yarn/subscription","commits_url":"https://api.github.com/repos/yarnpkg/yarn/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarnpkg/yarn/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarnpkg/yarn/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarnpkg/yarn/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarnpkg/yarn/contents/{+path}","compare_url":"https://api.github.com/repos/yarnpkg/yarn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarnpkg/yarn/merges","archive_url":"https://api.github.com/repos/yarnpkg/yarn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarnpkg/yarn/downloads","issues_url":"https://api.github.com/repos/yarnpkg/yarn/issues{/number}","pulls_url":"https://api.github.com/repos/yarnpkg/yarn/pulls{/number}","milestones_url":"https://api.github.com/repos/yarnpkg/yarn/milestones{/number}","notifications_url":"https://api.github.com/repos/yarnpkg/yarn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarnpkg/yarn/labels{/name}","releases_url":"https://api.github.com/repos/yarnpkg/yarn/releases{/id}","deployments_url":"https://api.github.com/repos/yarnpkg/yarn/deployments","created_at":"2016-01-19T17:39:16Z","updated_at":"2018-04-15T13:04:37Z","pushed_at":"2018-04-15T13:05:21Z","git_url":"git://github.com/yarnpkg/yarn.git","ssh_url":"git@github.com:yarnpkg/yarn.git","clone_url":"https://github.com/yarnpkg/yarn.git","svn_url":"https://github.com/yarnpkg/yarn","homepage":"https://yarnpkg.com","size":115411,"stargazers_count":31185,"watchers_count":31185,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1725,"mirror_url":null,"archived":false,"open_issues_count":1110,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1725,"open_issues":1110,"watchers":31185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/5632"},"html":{"href":"https://github.com/yarnpkg/yarn/pull/5632"},"issue":{"href":"https://api.github.com/repos/yarnpkg/yarn/issues/5632"},"comments":{"href":"https://api.github.com/repos/yarnpkg/yarn/issues/5632/comments"},"review_comments":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/5632/comments"},"review_comment":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yarnpkg/yarn/pulls/5632/commits"},"statuses":{"href":"https://api.github.com/repos/yarnpkg/yarn/statuses/e70c8492c341f3881b6b90d0f9c4788f53c0a0d2"}},"author_association":"NONE"}}
{"actor":{"display_login":"BYK"}}