{"action":"created","comment":{"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/comments/187380300","pull_request_review_id":119148720,"id":187380300,"diff_hunk":"@@ -192,14 +192,13 @@ private function getOfflineAutoRenewalRecurContributions() {\n     $manualPaymentProcessorsIDs = implode(',', $manualPaymentProcessors);\n \n     $query = 'SELECT ccr.id as contribution_recur_id, ccr.installments  \n-              FROM civicrm_contribution_recur ccr \n-              LEFT JOIN  civicrm_membership cm \n-                ON ccr.id = cm.contribution_recur_id \n-              WHERE ccr.auto_renew = 1 \n-                AND (ccr.payment_processor_id IS NULL OR ccr.payment_processor_id IN (' . $manualPaymentProcessorsIDs . '))\n-                AND (ccr.contribution_status_id != ' . $cancelledStatusID . ' OR  ccr.contribution_status_id != ' . $refundedStatusID . ')\n-                AND cm.end_date <= CURDATE() \n-              GROUP BY ccr.id';\n+                FROM civicrm_contribution_recur ccr ","path":"CRM/MembershipExtras/Job/OfflineAutoRenewal.php","position":12,"original_position":12,"commit_id":"182f243e6778ed45b11c5502829eff63c1a1d7c3","original_commit_id":"182f243e6778ed45b11c5502829eff63c1a1d7c3","user":{"login":"omarabuhussein","id":6275540,"avatar_url":"https://avatars1.githubusercontent.com/u/6275540?v=4","gravatar_id":"","url":"https://api.github.com/users/omarabuhussein","html_url":"https://github.com/omarabuhussein","followers_url":"https://api.github.com/users/omarabuhussein/followers","following_url":"https://api.github.com/users/omarabuhussein/following{/other_user}","gists_url":"https://api.github.com/users/omarabuhussein/gists{/gist_id}","starred_url":"https://api.github.com/users/omarabuhussein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omarabuhussein/subscriptions","organizations_url":"https://api.github.com/users/omarabuhussein/orgs","repos_url":"https://api.github.com/users/omarabuhussein/repos","events_url":"https://api.github.com/users/omarabuhussein/events{/privacy}","received_events_url":"https://api.github.com/users/omarabuhussein/received_events","type":"User","site_admin":false},"body":"did u changed anything in this query ? or u just changed the format ?","created_at":"2018-05-10T16:15:58Z","updated_at":"2018-05-10T16:54:53Z","html_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras/pull/20#discussion_r187380300","pull_request_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/20","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/comments/187380300"},"html":{"href":"https://github.com/compucorp/uk.co.compucorp.membershipextras/pull/20#discussion_r187380300"},"pull_request":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/20","id":187045203,"html_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras/pull/20","diff_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras/pull/20.diff","patch_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras/pull/20.patch","issue_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/20","number":20,"state":"open","locked":false,"title":"BASW-91: Add Setting to Choose Default Payment Processor","user":{"login":"MiyaNoctem","id":21999940,"avatar_url":"https://avatars0.githubusercontent.com/u/21999940?v=4","gravatar_id":"","url":"https://api.github.com/users/MiyaNoctem","html_url":"https://github.com/MiyaNoctem","followers_url":"https://api.github.com/users/MiyaNoctem/followers","following_url":"https://api.github.com/users/MiyaNoctem/following{/other_user}","gists_url":"https://api.github.com/users/MiyaNoctem/gists{/gist_id}","starred_url":"https://api.github.com/users/MiyaNoctem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiyaNoctem/subscriptions","organizations_url":"https://api.github.com/users/MiyaNoctem/orgs","repos_url":"https://api.github.com/users/MiyaNoctem/repos","events_url":"https://api.github.com/users/MiyaNoctem/events{/privacy}","received_events_url":"https://api.github.com/users/MiyaNoctem/received_events","type":"User","site_admin":false},"body":"## Overview\r\nWe need an option on *Administer > Payment Plan Settings*, to select the payment processor that should be used when creating payment plans to pay for memberships. This new setting should:\r\n\r\n1. Be called \"Offline payment processor for back office\" with helptext \"Select the payment processor that should be used when creating payment plans via CiviCRM admin interface such as new/ renew membership.\".\r\n2. Show a list containing all payment processors that use a payment processor type of \"Payment_Manual\" payment class.\r\n3. Be required and should default to the offline payment processor this extension creates.\r\n4. When creating a payment plan using new/renew membership admin interface, the id of the payment processor selected in the setting should be used as the recurring contribution payment processor id.\r\n\r\n## Before\r\nPayment plans were created with the hard-coded payment processor this extension creates.\r\n\r\n## After\r\nAdded a new setting to choose payment processor from all processors of Manual Payment type. This processor is then used when creating and renewing memberships with a payment plan.\r\n","created_at":"2018-05-09T21:28:27Z","updated_at":"2018-05-10T16:54:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d185216c4873960c32b1eeeaa04433cf7585d2ea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/20/commits","review_comments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/20/comments","review_comment_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/comments{/number}","comments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/20/comments","statuses_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/statuses/182f243e6778ed45b11c5502829eff63c1a1d7c3","head":{"label":"compucorp:BASW-91-payment-plan-default-processor","ref":"BASW-91-payment-plan-default-processor","sha":"182f243e6778ed45b11c5502829eff63c1a1d7c3","user":{"login":"compucorp","id":2040164,"avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"repo":{"id":119543283,"name":"uk.co.compucorp.membershipextras","full_name":"compucorp/uk.co.compucorp.membershipextras","owner":{"login":"compucorp","id":2040164,"avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras","description":null,"fork":false,"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras","forks_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/forks","keys_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/teams","hooks_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/hooks","issue_events_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/events{/number}","events_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/events","assignees_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/assignees{/user}","branches_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/branches{/branch}","tags_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/tags","blobs_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/refs{/sha}","trees_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/statuses/{sha}","languages_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/languages","stargazers_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/stargazers","contributors_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/contributors","subscribers_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/subscribers","subscription_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/subscription","commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/commits{/sha}","git_commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/commits{/sha}","comments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/comments{/number}","issue_comment_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/comments{/number}","contents_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/contents/{+path}","compare_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/merges","archive_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/downloads","issues_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues{/number}","pulls_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls{/number}","milestones_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/milestones{/number}","notifications_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/labels{/name}","releases_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/releases{/id}","deployments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/deployments","created_at":"2018-01-30T13:57:44Z","updated_at":"2018-05-10T10:43:12Z","pushed_at":"2018-05-10T12:05:45Z","git_url":"git://github.com/compucorp/uk.co.compucorp.membershipextras.git","ssh_url":"git@github.com:compucorp/uk.co.compucorp.membershipextras.git","clone_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras.git","svn_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras","homepage":null,"size":144,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"develop"}},"base":{"label":"compucorp:develop","ref":"develop","sha":"38c2669f8a8315b512b3a5a88a583fa0f4892c5d","user":{"login":"compucorp","id":2040164,"avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"repo":{"id":119543283,"name":"uk.co.compucorp.membershipextras","full_name":"compucorp/uk.co.compucorp.membershipextras","owner":{"login":"compucorp","id":2040164,"avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras","description":null,"fork":false,"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras","forks_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/forks","keys_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/teams","hooks_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/hooks","issue_events_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/events{/number}","events_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/events","assignees_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/assignees{/user}","branches_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/branches{/branch}","tags_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/tags","blobs_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/refs{/sha}","trees_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/statuses/{sha}","languages_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/languages","stargazers_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/stargazers","contributors_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/contributors","subscribers_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/subscribers","subscription_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/subscription","commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/commits{/sha}","git_commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/git/commits{/sha}","comments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/comments{/number}","issue_comment_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/comments{/number}","contents_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/contents/{+path}","compare_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/merges","archive_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/downloads","issues_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues{/number}","pulls_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls{/number}","milestones_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/milestones{/number}","notifications_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/labels{/name}","releases_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/releases{/id}","deployments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/deployments","created_at":"2018-01-30T13:57:44Z","updated_at":"2018-05-10T10:43:12Z","pushed_at":"2018-05-10T12:05:45Z","git_url":"git://github.com/compucorp/uk.co.compucorp.membershipextras.git","ssh_url":"git@github.com:compucorp/uk.co.compucorp.membershipextras.git","clone_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras.git","svn_url":"https://github.com/compucorp/uk.co.compucorp.membershipextras","homepage":null,"size":144,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/20"},"html":{"href":"https://github.com/compucorp/uk.co.compucorp.membershipextras/pull/20"},"issue":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/20"},"comments":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.membershipextras/statuses/182f243e6778ed45b11c5502829eff63c1a1d7c3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"omarabuhussein"}}