{"action":"created","issue":{"url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/issues/51","repository_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts","labels_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/issues/51/labels{/name}","comments_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/issues/51/comments","events_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/issues/51/events","html_url":"https://github.com/AppStoreFoundation/asf-contracts/pull/51","id":335369771,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MDg0ODky","number":51,"title":"build(docker): Add docker setup for development","user":{"login":"tcrosado","id":5559074,"node_id":"MDQ6VXNlcjU1NTkwNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5559074?v=4","gravatar_id":"","url":"https://api.github.com/users/tcrosado","html_url":"https://github.com/tcrosado","followers_url":"https://api.github.com/users/tcrosado/followers","following_url":"https://api.github.com/users/tcrosado/following{/other_user}","gists_url":"https://api.github.com/users/tcrosado/gists{/gist_id}","starred_url":"https://api.github.com/users/tcrosado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcrosado/subscriptions","organizations_url":"https://api.github.com/users/tcrosado/orgs","repos_url":"https://api.github.com/users/tcrosado/repos","events_url":"https://api.github.com/users/tcrosado/events{/privacy}","received_events_url":"https://api.github.com/users/tcrosado/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-25T11:39:22Z","updated_at":"2018-06-26T08:54:28Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/pulls/51","html_url":"https://github.com/AppStoreFoundation/asf-contracts/pull/51","diff_url":"https://github.com/AppStoreFoundation/asf-contracts/pull/51.diff","patch_url":"https://github.com/AppStoreFoundation/asf-contracts/pull/51.patch"},"body":"Now the development setup can be done using a docker container (based on [lead4good/truffle](https://hub.docker.com/r/lead4good/truffle/) image).\r\nTo build the image you should execute:\r\n`docker-compose build` \r\nIn order to start the container, execute:\r\n`docker-compose up`\r\nWait a bit for ganache to display develpment addresses and later execute on a separate terminal:\r\n`docker exec -it AppCoinsDev  bash` \r\n\r\nThis will open a bash shell on the docker container where you can execute the usual development commands such as `truffle compile`.\r\n\r\nRelated to this pull request I made some decisions that should be reviewed:\r\n - ganache-cli is running on debug mode (is it necessary?)\r\n - docker exec commands are running as root on the container, should it be changed to an unprivileged user?\r\n- should documentation about the docker setup be added to this PR or add it to a new PR later?\r\n"},"comment":{"url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/issues/comments/400233147","html_url":"https://github.com/AppStoreFoundation/asf-contracts/pull/51#issuecomment-400233147","issue_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/issues/51","id":400233147,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDIzMzE0Nw==","user":{"login":"tcrosado","id":5559074,"node_id":"MDQ6VXNlcjU1NTkwNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5559074?v=4","gravatar_id":"","url":"https://api.github.com/users/tcrosado","html_url":"https://github.com/tcrosado","followers_url":"https://api.github.com/users/tcrosado/followers","following_url":"https://api.github.com/users/tcrosado/following{/other_user}","gists_url":"https://api.github.com/users/tcrosado/gists{/gist_id}","starred_url":"https://api.github.com/users/tcrosado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcrosado/subscriptions","organizations_url":"https://api.github.com/users/tcrosado/orgs","repos_url":"https://api.github.com/users/tcrosado/repos","events_url":"https://api.github.com/users/tcrosado/events{/privacy}","received_events_url":"https://api.github.com/users/tcrosado/received_events","type":"User","site_admin":false},"created_at":"2018-06-26T08:54:28Z","updated_at":"2018-06-26T08:54:28Z","author_association":"CONTRIBUTOR","body":"ganache-cli is now running in normal mode and instructions for setup were added "}}
{"actor":{"display_login":"tcrosado"}}