{"action":"created","issue":{"url":"https://api.github.com/repos/sony/nmos-cpp/issues/1","repository_url":"https://api.github.com/repos/sony/nmos-cpp","labels_url":"https://api.github.com/repos/sony/nmos-cpp/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/sony/nmos-cpp/issues/1/comments","events_url":"https://api.github.com/repos/sony/nmos-cpp/issues/1/events","html_url":"https://github.com/sony/nmos-cpp/pull/1","id":299409879,"number":1,"title":"Fixed trailing / behind resource in registration API. As described in…","user":{"login":"cylonbrain","id":441892,"avatar_url":"https://avatars0.githubusercontent.com/u/441892?v=4","gravatar_id":"","url":"https://api.github.com/users/cylonbrain","html_url":"https://github.com/cylonbrain","followers_url":"https://api.github.com/users/cylonbrain/followers","following_url":"https://api.github.com/users/cylonbrain/following{/other_user}","gists_url":"https://api.github.com/users/cylonbrain/gists{/gist_id}","starred_url":"https://api.github.com/users/cylonbrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cylonbrain/subscriptions","organizations_url":"https://api.github.com/users/cylonbrain/orgs","repos_url":"https://api.github.com/users/cylonbrain/repos","events_url":"https://api.github.com/users/cylonbrain/events{/privacy}","received_events_url":"https://api.github.com/users/cylonbrain/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-22T16:03:16Z","updated_at":"2018-02-22T17:40:27Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/sony/nmos-cpp/pulls/1","html_url":"https://github.com/sony/nmos-cpp/pull/1","diff_url":"https://github.com/sony/nmos-cpp/pull/1.diff","patch_url":"https://github.com/sony/nmos-cpp/pull/1.patch"},"body":"… RegistrationAPI \"/resource\""},"comment":{"url":"https://api.github.com/repos/sony/nmos-cpp/issues/comments/367760740","html_url":"https://github.com/sony/nmos-cpp/pull/1#issuecomment-367760740","issue_url":"https://api.github.com/repos/sony/nmos-cpp/issues/1","id":367760740,"user":{"login":"garethsb-sony","id":31761158,"avatar_url":"https://avatars3.githubusercontent.com/u/31761158?v=4","gravatar_id":"","url":"https://api.github.com/users/garethsb-sony","html_url":"https://github.com/garethsb-sony","followers_url":"https://api.github.com/users/garethsb-sony/followers","following_url":"https://api.github.com/users/garethsb-sony/following{/other_user}","gists_url":"https://api.github.com/users/garethsb-sony/gists{/gist_id}","starred_url":"https://api.github.com/users/garethsb-sony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethsb-sony/subscriptions","organizations_url":"https://api.github.com/users/garethsb-sony/orgs","repos_url":"https://api.github.com/users/garethsb-sony/repos","events_url":"https://api.github.com/users/garethsb-sony/events{/privacy}","received_events_url":"https://api.github.com/users/garethsb-sony/received_events","type":"User","site_admin":false},"created_at":"2018-02-22T17:40:27Z","updated_at":"2018-02-22T17:40:27Z","author_association":"CONTRIBUTOR","body":"Thanks for the PR!\r\n\r\nI think the proposed change to nmos/registration_api.cpp (used in **nmos-cpp-registry**) is incorrect as things stand. The current implementation follows the example in the specification at:\r\nhttps://github.com/AMWA-TV/nmos-discovery-registration/blob/v1.2.x/examples/registrationapi-v1.1-base-get-200.json\r\n\r\nHowever I agree the first change to nmos/node_registration.cpp (used in **nmos-cpp-node**) for the POST to /resource may be a good idea. This has been discussed previously, resulting in @andrewbonney drafting the following guidance in https://github.com/AMWA-TV/nmos-discovery-registration/issues/15:\r\n\r\n> A server implementing the APIs MUST support PUT/PATCH/POST/DELETE/OPTIONS (ie. write related) operations on the non-trailing slash version of each resource. The implementation MAY additionally support the same methods on the trailing slash version but this is not strictly required.\r\n\r\nUnfortunately, I don’t think that has yet been merged into the spec. Thanks for reminding me of this! It’s possible that when it is, the response for the API “base” response should be changed also.\r\n\r\nAs for the other change to nmos/node_registration.cpp for the DELETE, unless I’m mistaken the ``path`` to be appended at that point doesn’t contain a leading slash, so the trailing slash on ``\"/resource/\"`` is required?\r\n"}}
{"actor":{"display_login":"garethsb-sony"}}