{"action":"created","comment":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/219658144","pull_request_review_id":157895506,"id":219658144,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTY1ODE0NA==","diff_hunk":"@@ -17,6 +17,11 @@\n \n _VF = torch._C._VariableFunctions\n \n+def weak_script(fn):","path":"torch/nn/functional.py","position":4,"original_position":4,"commit_id":"fbf9edc79f743776e7a699283d83a46249202e64","original_commit_id":"fbf9edc79f743776e7a699283d83a46249202e64","user":{"login":"driazati","id":9407960,"node_id":"MDQ6VXNlcjk0MDc5NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/9407960?v=4","gravatar_id":"","url":"https://api.github.com/users/driazati","html_url":"https://github.com/driazati","followers_url":"https://api.github.com/users/driazati/followers","following_url":"https://api.github.com/users/driazati/following{/other_user}","gists_url":"https://api.github.com/users/driazati/gists{/gist_id}","starred_url":"https://api.github.com/users/driazati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driazati/subscriptions","organizations_url":"https://api.github.com/users/driazati/orgs","repos_url":"https://api.github.com/users/driazati/repos","events_url":"https://api.github.com/users/driazati/events{/privacy}","received_events_url":"https://api.github.com/users/driazati/received_events","type":"User","site_admin":false},"body":"This redefinition is not great, but there's a circular dependency between `torch.jit` and `torch.nn` if it's included here. Any ideas to fix?","created_at":"2018-09-22T01:53:06Z","updated_at":"2018-09-22T01:53:06Z","html_url":"https://github.com/pytorch/pytorch/pull/11963#discussion_r219658144","pull_request_url":"https://api.github.com/repos/pytorch/pytorch/pulls/11963","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/219658144"},"html":{"href":"https://github.com/pytorch/pytorch/pull/11963#discussion_r219658144"},"pull_request":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/11963"}}},"pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/11963","id":217433382,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NDMzMzgy","html_url":"https://github.com/pytorch/pytorch/pull/11963","diff_url":"https://github.com/pytorch/pytorch/pull/11963.diff","patch_url":"https://github.com/pytorch/pytorch/pull/11963.patch","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/11963","number":11963,"state":"open","locked":false,"title":"[jit][WIP] Add weak script mode for script functions","user":{"login":"driazati","id":9407960,"node_id":"MDQ6VXNlcjk0MDc5NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/9407960?v=4","gravatar_id":"","url":"https://api.github.com/users/driazati","html_url":"https://github.com/driazati","followers_url":"https://api.github.com/users/driazati/followers","following_url":"https://api.github.com/users/driazati/following{/other_user}","gists_url":"https://api.github.com/users/driazati/gists{/gist_id}","starred_url":"https://api.github.com/users/driazati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driazati/subscriptions","organizations_url":"https://api.github.com/users/driazati/orgs","repos_url":"https://api.github.com/users/driazati/repos","events_url":"https://api.github.com/users/driazati/events{/privacy}","received_events_url":"https://api.github.com/users/driazati/received_events","type":"User","site_admin":false},"body":"This PR is the start of weak script mode for functions\r\n\r\nWeak scripts allow you to compile a graph from Python code at runtime by annotating with `torch.jit.weak_script` for use in the JIT without affecting eager execution. Scripts are compiled lazily on the first call in a graph to avoid long Python startup times.\r\n\r\n```python\r\nimport torch\r\n\r\ndef reference(x):\r\n    y = torch.nn.functional.softsign(x)\r\n    return torch.nn.functional.tanhshrink(x) + y\r\n\r\nscripted = torch.jit.script(reference)\r\n\r\nx = torch.randn(4)\r\n\r\n# this should cause fn to compile and run graph\r\nscript_out = scripted(x)\r\n\r\n# this should run fn from Python (without calling into C++)\r\nexpected_out = reference(x)\r\n```","created_at":"2018-09-22T01:52:12Z","updated_at":"2018-09-22T01:53:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9a7c26758d5b69e5c50d61b6be0521e1661e247","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ezyang","id":13564,"node_id":"MDQ6VXNlcjEzNTY0","avatar_url":"https://avatars0.githubusercontent.com/u/13564?v=4","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},{"login":"zdevito","id":370202,"node_id":"MDQ6VXNlcjM3MDIwMg==","avatar_url":"https://avatars0.githubusercontent.com/u/370202?v=4","gravatar_id":"","url":"https://api.github.com/users/zdevito","html_url":"https://github.com/zdevito","followers_url":"https://api.github.com/users/zdevito/followers","following_url":"https://api.github.com/users/zdevito/following{/other_user}","gists_url":"https://api.github.com/users/zdevito/gists{/gist_id}","starred_url":"https://api.github.com/users/zdevito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zdevito/subscriptions","organizations_url":"https://api.github.com/users/zdevito/orgs","repos_url":"https://api.github.com/users/zdevito/repos","events_url":"https://api.github.com/users/zdevito/events{/privacy}","received_events_url":"https://api.github.com/users/zdevito/received_events","type":"User","site_admin":false},{"login":"colesbury","id":655866,"node_id":"MDQ6VXNlcjY1NTg2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/655866?v=4","gravatar_id":"","url":"https://api.github.com/users/colesbury","html_url":"https://github.com/colesbury","followers_url":"https://api.github.com/users/colesbury/followers","following_url":"https://api.github.com/users/colesbury/following{/other_user}","gists_url":"https://api.github.com/users/colesbury/gists{/gist_id}","starred_url":"https://api.github.com/users/colesbury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colesbury/subscriptions","organizations_url":"https://api.github.com/users/colesbury/orgs","repos_url":"https://api.github.com/users/colesbury/repos","events_url":"https://api.github.com/users/colesbury/events{/privacy}","received_events_url":"https://api.github.com/users/colesbury/received_events","type":"User","site_admin":false},{"login":"soumith","id":1310570,"node_id":"MDQ6VXNlcjEzMTA1NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1310570?v=4","gravatar_id":"","url":"https://api.github.com/users/soumith","html_url":"https://github.com/soumith","followers_url":"https://api.github.com/users/soumith/followers","following_url":"https://api.github.com/users/soumith/following{/other_user}","gists_url":"https://api.github.com/users/soumith/gists{/gist_id}","starred_url":"https://api.github.com/users/soumith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soumith/subscriptions","organizations_url":"https://api.github.com/users/soumith/orgs","repos_url":"https://api.github.com/users/soumith/repos","events_url":"https://api.github.com/users/soumith/events{/privacy}","received_events_url":"https://api.github.com/users/soumith/received_events","type":"User","site_admin":false},{"login":"gchanan","id":3768583,"node_id":"MDQ6VXNlcjM3Njg1ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/3768583?v=4","gravatar_id":"","url":"https://api.github.com/users/gchanan","html_url":"https://github.com/gchanan","followers_url":"https://api.github.com/users/gchanan/followers","following_url":"https://api.github.com/users/gchanan/following{/other_user}","gists_url":"https://api.github.com/users/gchanan/gists{/gist_id}","starred_url":"https://api.github.com/users/gchanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gchanan/subscriptions","organizations_url":"https://api.github.com/users/gchanan/orgs","repos_url":"https://api.github.com/users/gchanan/repos","events_url":"https://api.github.com/users/gchanan/events{/privacy}","received_events_url":"https://api.github.com/users/gchanan/received_events","type":"User","site_admin":false},{"login":"apaszke","id":4583066,"node_id":"MDQ6VXNlcjQ1ODMwNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/4583066?v=4","gravatar_id":"","url":"https://api.github.com/users/apaszke","html_url":"https://github.com/apaszke","followers_url":"https://api.github.com/users/apaszke/followers","following_url":"https://api.github.com/users/apaszke/following{/other_user}","gists_url":"https://api.github.com/users/apaszke/gists{/gist_id}","starred_url":"https://api.github.com/users/apaszke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apaszke/subscriptions","organizations_url":"https://api.github.com/users/apaszke/orgs","repos_url":"https://api.github.com/users/apaszke/repos","events_url":"https://api.github.com/users/apaszke/events{/privacy}","received_events_url":"https://api.github.com/users/apaszke/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/pytorch/pulls/11963/commits","review_comments_url":"https://api.github.com/repos/pytorch/pytorch/pulls/11963/comments","review_comment_url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/11963/comments","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/fbf9edc79f743776e7a699283d83a46249202e64","head":{"label":"driazati:weak_script","ref":"weak_script","sha":"fbf9edc79f743776e7a699283d83a46249202e64","user":{"login":"driazati","id":9407960,"node_id":"MDQ6VXNlcjk0MDc5NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/9407960?v=4","gravatar_id":"","url":"https://api.github.com/users/driazati","html_url":"https://github.com/driazati","followers_url":"https://api.github.com/users/driazati/followers","following_url":"https://api.github.com/users/driazati/following{/other_user}","gists_url":"https://api.github.com/users/driazati/gists{/gist_id}","starred_url":"https://api.github.com/users/driazati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driazati/subscriptions","organizations_url":"https://api.github.com/users/driazati/orgs","repos_url":"https://api.github.com/users/driazati/repos","events_url":"https://api.github.com/users/driazati/events{/privacy}","received_events_url":"https://api.github.com/users/driazati/received_events","type":"User","site_admin":false},"repo":{"id":142357224,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIzNTcyMjQ=","name":"pytorch","full_name":"driazati/pytorch","private":false,"owner":{"login":"driazati","id":9407960,"node_id":"MDQ6VXNlcjk0MDc5NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/9407960?v=4","gravatar_id":"","url":"https://api.github.com/users/driazati","html_url":"https://github.com/driazati","followers_url":"https://api.github.com/users/driazati/followers","following_url":"https://api.github.com/users/driazati/following{/other_user}","gists_url":"https://api.github.com/users/driazati/gists{/gist_id}","starred_url":"https://api.github.com/users/driazati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driazati/subscriptions","organizations_url":"https://api.github.com/users/driazati/orgs","repos_url":"https://api.github.com/users/driazati/repos","events_url":"https://api.github.com/users/driazati/events{/privacy}","received_events_url":"https://api.github.com/users/driazati/received_events","type":"User","site_admin":false},"html_url":"https://github.com/driazati/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/driazati/pytorch","forks_url":"https://api.github.com/repos/driazati/pytorch/forks","keys_url":"https://api.github.com/repos/driazati/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/driazati/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/driazati/pytorch/teams","hooks_url":"https://api.github.com/repos/driazati/pytorch/hooks","issue_events_url":"https://api.github.com/repos/driazati/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/driazati/pytorch/events","assignees_url":"https://api.github.com/repos/driazati/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/driazati/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/driazati/pytorch/tags","blobs_url":"https://api.github.com/repos/driazati/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/driazati/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/driazati/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/driazati/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/driazati/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/driazati/pytorch/languages","stargazers_url":"https://api.github.com/repos/driazati/pytorch/stargazers","contributors_url":"https://api.github.com/repos/driazati/pytorch/contributors","subscribers_url":"https://api.github.com/repos/driazati/pytorch/subscribers","subscription_url":"https://api.github.com/repos/driazati/pytorch/subscription","commits_url":"https://api.github.com/repos/driazati/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/driazati/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/driazati/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/driazati/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/driazati/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/driazati/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/driazati/pytorch/merges","archive_url":"https://api.github.com/repos/driazati/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/driazati/pytorch/downloads","issues_url":"https://api.github.com/repos/driazati/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/driazati/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/driazati/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/driazati/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/driazati/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/driazati/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/driazati/pytorch/deployments","created_at":"2018-07-25T21:46:55Z","updated_at":"2018-09-21T20:24:38Z","pushed_at":"2018-09-22T01:44:34Z","git_url":"git://github.com/driazati/pytorch.git","ssh_url":"git@github.com:driazati/pytorch.git","clone_url":"https://github.com/driazati/pytorch.git","svn_url":"https://github.com/driazati/pytorch","homepage":"http://pytorch.org","size":75388,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"de11fe0c8381bc8fa4182f247226d1f606d79678","user":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"node_id":"MDEwOlJlcG9zaXRvcnk2NTYwMDk3NQ==","name":"pytorch","full_name":"pytorch/pytorch","private":false,"owner":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2018-09-21T23:36:45Z","pushed_at":"2018-09-22T01:52:14Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"http://pytorch.org","size":76034,"stargazers_count":18890,"watchers_count":18890,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4531,"mirror_url":null,"archived":false,"open_issues_count":1744,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4531,"open_issues":1744,"watchers":18890,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/11963"},"html":{"href":"https://github.com/pytorch/pytorch/pull/11963"},"issue":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/11963"},"comments":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/11963/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/11963/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/11963/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/pytorch/statuses/fbf9edc79f743776e7a699283d83a46249202e64"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"driazati"}}