{"action":"created","comment":{"url":"https://api.github.com/repos/flang-compiler/f18/pulls/comments/231648738","pull_request_review_id":172663904,"id":231648738,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTY0ODczOA==","diff_hunk":"@@ -1547,8 +1558,8 @@ bool ModuleVisitor::Pre(const parser::Module &x) {\n   const auto &name{\n       std::get<parser::Statement<parser::ModuleStmt>>(x.t).statement.v.source};\n   auto &subpPart{std::get<std::optional<parser::ModuleSubprogramPart>>(x.t)};\n-  auto &symbol{BeginModule(name, false, subpPart)};\n-  MakeSymbol(name, symbol.details());\n+  BeginModule(name, false, subpPart);","path":"lib/semantics/resolve-names.cc","position":178,"original_position":178,"commit_id":"b90cadfc53c6e31c5f289eadc382bc3908811b86","original_commit_id":"b90cadfc53c6e31c5f289eadc382bc3908811b86","user":{"login":"tskeith","id":20650530,"node_id":"MDQ6VXNlcjIwNjUwNTMw","avatar_url":"https://avatars2.githubusercontent.com/u/20650530?v=4","gravatar_id":"","url":"https://api.github.com/users/tskeith","html_url":"https://github.com/tskeith","followers_url":"https://api.github.com/users/tskeith/followers","following_url":"https://api.github.com/users/tskeith/following{/other_user}","gists_url":"https://api.github.com/users/tskeith/gists{/gist_id}","starred_url":"https://api.github.com/users/tskeith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tskeith/subscriptions","organizations_url":"https://api.github.com/users/tskeith/orgs","repos_url":"https://api.github.com/users/tskeith/repos","events_url":"https://api.github.com/users/tskeith/events{/privacy}","received_events_url":"https://api.github.com/users/tskeith/received_events","type":"User","site_admin":false},"body":"Regarding symbol ownership: Yes, Symbols are all owned by Scopes, which are in a tree rooted at the global scope, which is in the SemanticsContext. That's why we can freely use pointers and references to Symbols and Scopes without worrying about lifetimes.","created_at":"2018-11-07T19:37:12Z","updated_at":"2018-11-07T19:37:12Z","html_url":"https://github.com/flang-compiler/f18/pull/223#discussion_r231648738","pull_request_url":"https://api.github.com/repos/flang-compiler/f18/pulls/223","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/flang-compiler/f18/pulls/comments/231648738"},"html":{"href":"https://github.com/flang-compiler/f18/pull/223#discussion_r231648738"},"pull_request":{"href":"https://api.github.com/repos/flang-compiler/f18/pulls/223"}},"in_reply_to_id":231642283},"pull_request":{"url":"https://api.github.com/repos/flang-compiler/f18/pulls/223","id":228888490,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4ODg4NDkw","html_url":"https://github.com/flang-compiler/f18/pull/223","diff_url":"https://github.com/flang-compiler/f18/pull/223.diff","patch_url":"https://github.com/flang-compiler/f18/pull/223.patch","issue_url":"https://api.github.com/repos/flang-compiler/f18/issues/223","number":223,"state":"open","locked":false,"title":"Resolve expressions in symbols","user":{"login":"tskeith","id":20650530,"node_id":"MDQ6VXNlcjIwNjUwNTMw","avatar_url":"https://avatars2.githubusercontent.com/u/20650530?v=4","gravatar_id":"","url":"https://api.github.com/users/tskeith","html_url":"https://github.com/tskeith","followers_url":"https://api.github.com/users/tskeith/followers","following_url":"https://api.github.com/users/tskeith/following{/other_user}","gists_url":"https://api.github.com/users/tskeith/gists{/gist_id}","starred_url":"https://api.github.com/users/tskeith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tskeith/subscriptions","organizations_url":"https://api.github.com/users/tskeith/orgs","repos_url":"https://api.github.com/users/tskeith/repos","events_url":"https://api.github.com/users/tskeith/events{/privacy}","received_events_url":"https://api.github.com/users/tskeith/received_events","type":"User","site_admin":false},"body":"The \"Resolve expressions in symbols\" commit contains the main part of these changes. The others are refactorings.","created_at":"2018-11-07T01:20:50Z","updated_at":"2018-11-07T19:37:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2b4b5c27e860469861228601fb986ae5386e6e2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jeanPerier","id":11905461,"node_id":"MDQ6VXNlcjExOTA1NDYx","avatar_url":"https://avatars3.githubusercontent.com/u/11905461?v=4","gravatar_id":"","url":"https://api.github.com/users/jeanPerier","html_url":"https://github.com/jeanPerier","followers_url":"https://api.github.com/users/jeanPerier/followers","following_url":"https://api.github.com/users/jeanPerier/following{/other_user}","gists_url":"https://api.github.com/users/jeanPerier/gists{/gist_id}","starred_url":"https://api.github.com/users/jeanPerier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeanPerier/subscriptions","organizations_url":"https://api.github.com/users/jeanPerier/orgs","repos_url":"https://api.github.com/users/jeanPerier/repos","events_url":"https://api.github.com/users/jeanPerier/events{/privacy}","received_events_url":"https://api.github.com/users/jeanPerier/received_events","type":"User","site_admin":false},{"login":"vdonaldson","id":37090318,"node_id":"MDQ6VXNlcjM3MDkwMzE4","avatar_url":"https://avatars1.githubusercontent.com/u/37090318?v=4","gravatar_id":"","url":"https://api.github.com/users/vdonaldson","html_url":"https://github.com/vdonaldson","followers_url":"https://api.github.com/users/vdonaldson/followers","following_url":"https://api.github.com/users/vdonaldson/following{/other_user}","gists_url":"https://api.github.com/users/vdonaldson/gists{/gist_id}","starred_url":"https://api.github.com/users/vdonaldson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdonaldson/subscriptions","organizations_url":"https://api.github.com/users/vdonaldson/orgs","repos_url":"https://api.github.com/users/vdonaldson/repos","events_url":"https://api.github.com/users/vdonaldson/events{/privacy}","received_events_url":"https://api.github.com/users/vdonaldson/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/flang-compiler/f18/pulls/223/commits","review_comments_url":"https://api.github.com/repos/flang-compiler/f18/pulls/223/comments","review_comment_url":"https://api.github.com/repos/flang-compiler/f18/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flang-compiler/f18/issues/223/comments","statuses_url":"https://api.github.com/repos/flang-compiler/f18/statuses/b90cadfc53c6e31c5f289eadc382bc3908811b86","head":{"label":"flang-compiler:tsk5","ref":"tsk5","sha":"b90cadfc53c6e31c5f289eadc382bc3908811b86","user":{"login":"flang-compiler","id":27519978,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NTE5OTc4","avatar_url":"https://avatars2.githubusercontent.com/u/27519978?v=4","gravatar_id":"","url":"https://api.github.com/users/flang-compiler","html_url":"https://github.com/flang-compiler","followers_url":"https://api.github.com/users/flang-compiler/followers","following_url":"https://api.github.com/users/flang-compiler/following{/other_user}","gists_url":"https://api.github.com/users/flang-compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/flang-compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flang-compiler/subscriptions","organizations_url":"https://api.github.com/users/flang-compiler/orgs","repos_url":"https://api.github.com/users/flang-compiler/repos","events_url":"https://api.github.com/users/flang-compiler/events{/privacy}","received_events_url":"https://api.github.com/users/flang-compiler/received_events","type":"Organization","site_admin":false},"repo":{"id":118970343,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg5NzAzNDM=","name":"f18","full_name":"flang-compiler/f18","private":false,"owner":{"login":"flang-compiler","id":27519978,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NTE5OTc4","avatar_url":"https://avatars2.githubusercontent.com/u/27519978?v=4","gravatar_id":"","url":"https://api.github.com/users/flang-compiler","html_url":"https://github.com/flang-compiler","followers_url":"https://api.github.com/users/flang-compiler/followers","following_url":"https://api.github.com/users/flang-compiler/following{/other_user}","gists_url":"https://api.github.com/users/flang-compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/flang-compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flang-compiler/subscriptions","organizations_url":"https://api.github.com/users/flang-compiler/orgs","repos_url":"https://api.github.com/users/flang-compiler/repos","events_url":"https://api.github.com/users/flang-compiler/events{/privacy}","received_events_url":"https://api.github.com/users/flang-compiler/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flang-compiler/f18","description":"F18 is a front-end for Fortran intended to replace the existing front-end in the Flang compiler","fork":false,"url":"https://api.github.com/repos/flang-compiler/f18","forks_url":"https://api.github.com/repos/flang-compiler/f18/forks","keys_url":"https://api.github.com/repos/flang-compiler/f18/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flang-compiler/f18/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flang-compiler/f18/teams","hooks_url":"https://api.github.com/repos/flang-compiler/f18/hooks","issue_events_url":"https://api.github.com/repos/flang-compiler/f18/issues/events{/number}","events_url":"https://api.github.com/repos/flang-compiler/f18/events","assignees_url":"https://api.github.com/repos/flang-compiler/f18/assignees{/user}","branches_url":"https://api.github.com/repos/flang-compiler/f18/branches{/branch}","tags_url":"https://api.github.com/repos/flang-compiler/f18/tags","blobs_url":"https://api.github.com/repos/flang-compiler/f18/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flang-compiler/f18/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flang-compiler/f18/git/refs{/sha}","trees_url":"https://api.github.com/repos/flang-compiler/f18/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flang-compiler/f18/statuses/{sha}","languages_url":"https://api.github.com/repos/flang-compiler/f18/languages","stargazers_url":"https://api.github.com/repos/flang-compiler/f18/stargazers","contributors_url":"https://api.github.com/repos/flang-compiler/f18/contributors","subscribers_url":"https://api.github.com/repos/flang-compiler/f18/subscribers","subscription_url":"https://api.github.com/repos/flang-compiler/f18/subscription","commits_url":"https://api.github.com/repos/flang-compiler/f18/commits{/sha}","git_commits_url":"https://api.github.com/repos/flang-compiler/f18/git/commits{/sha}","comments_url":"https://api.github.com/repos/flang-compiler/f18/comments{/number}","issue_comment_url":"https://api.github.com/repos/flang-compiler/f18/issues/comments{/number}","contents_url":"https://api.github.com/repos/flang-compiler/f18/contents/{+path}","compare_url":"https://api.github.com/repos/flang-compiler/f18/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flang-compiler/f18/merges","archive_url":"https://api.github.com/repos/flang-compiler/f18/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flang-compiler/f18/downloads","issues_url":"https://api.github.com/repos/flang-compiler/f18/issues{/number}","pulls_url":"https://api.github.com/repos/flang-compiler/f18/pulls{/number}","milestones_url":"https://api.github.com/repos/flang-compiler/f18/milestones{/number}","notifications_url":"https://api.github.com/repos/flang-compiler/f18/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flang-compiler/f18/labels{/name}","releases_url":"https://api.github.com/repos/flang-compiler/f18/releases{/id}","deployments_url":"https://api.github.com/repos/flang-compiler/f18/deployments","created_at":"2018-01-25T21:34:19Z","updated_at":"2018-11-05T20:46:26Z","pushed_at":"2018-11-07T10:27:43Z","git_url":"git://github.com/flang-compiler/f18.git","ssh_url":"git@github.com:flang-compiler/f18.git","clone_url":"https://github.com/flang-compiler/f18.git","svn_url":"https://github.com/flang-compiler/f18","homepage":"","size":3022,"stargazers_count":63,"watchers_count":63,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8,"open_issues":10,"watchers":63,"default_branch":"master"}},"base":{"label":"flang-compiler:master","ref":"master","sha":"11b472741de3465a3ecd915276b3f6517baa0bbf","user":{"login":"flang-compiler","id":27519978,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NTE5OTc4","avatar_url":"https://avatars2.githubusercontent.com/u/27519978?v=4","gravatar_id":"","url":"https://api.github.com/users/flang-compiler","html_url":"https://github.com/flang-compiler","followers_url":"https://api.github.com/users/flang-compiler/followers","following_url":"https://api.github.com/users/flang-compiler/following{/other_user}","gists_url":"https://api.github.com/users/flang-compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/flang-compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flang-compiler/subscriptions","organizations_url":"https://api.github.com/users/flang-compiler/orgs","repos_url":"https://api.github.com/users/flang-compiler/repos","events_url":"https://api.github.com/users/flang-compiler/events{/privacy}","received_events_url":"https://api.github.com/users/flang-compiler/received_events","type":"Organization","site_admin":false},"repo":{"id":118970343,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg5NzAzNDM=","name":"f18","full_name":"flang-compiler/f18","private":false,"owner":{"login":"flang-compiler","id":27519978,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NTE5OTc4","avatar_url":"https://avatars2.githubusercontent.com/u/27519978?v=4","gravatar_id":"","url":"https://api.github.com/users/flang-compiler","html_url":"https://github.com/flang-compiler","followers_url":"https://api.github.com/users/flang-compiler/followers","following_url":"https://api.github.com/users/flang-compiler/following{/other_user}","gists_url":"https://api.github.com/users/flang-compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/flang-compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flang-compiler/subscriptions","organizations_url":"https://api.github.com/users/flang-compiler/orgs","repos_url":"https://api.github.com/users/flang-compiler/repos","events_url":"https://api.github.com/users/flang-compiler/events{/privacy}","received_events_url":"https://api.github.com/users/flang-compiler/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flang-compiler/f18","description":"F18 is a front-end for Fortran intended to replace the existing front-end in the Flang compiler","fork":false,"url":"https://api.github.com/repos/flang-compiler/f18","forks_url":"https://api.github.com/repos/flang-compiler/f18/forks","keys_url":"https://api.github.com/repos/flang-compiler/f18/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flang-compiler/f18/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flang-compiler/f18/teams","hooks_url":"https://api.github.com/repos/flang-compiler/f18/hooks","issue_events_url":"https://api.github.com/repos/flang-compiler/f18/issues/events{/number}","events_url":"https://api.github.com/repos/flang-compiler/f18/events","assignees_url":"https://api.github.com/repos/flang-compiler/f18/assignees{/user}","branches_url":"https://api.github.com/repos/flang-compiler/f18/branches{/branch}","tags_url":"https://api.github.com/repos/flang-compiler/f18/tags","blobs_url":"https://api.github.com/repos/flang-compiler/f18/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flang-compiler/f18/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flang-compiler/f18/git/refs{/sha}","trees_url":"https://api.github.com/repos/flang-compiler/f18/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flang-compiler/f18/statuses/{sha}","languages_url":"https://api.github.com/repos/flang-compiler/f18/languages","stargazers_url":"https://api.github.com/repos/flang-compiler/f18/stargazers","contributors_url":"https://api.github.com/repos/flang-compiler/f18/contributors","subscribers_url":"https://api.github.com/repos/flang-compiler/f18/subscribers","subscription_url":"https://api.github.com/repos/flang-compiler/f18/subscription","commits_url":"https://api.github.com/repos/flang-compiler/f18/commits{/sha}","git_commits_url":"https://api.github.com/repos/flang-compiler/f18/git/commits{/sha}","comments_url":"https://api.github.com/repos/flang-compiler/f18/comments{/number}","issue_comment_url":"https://api.github.com/repos/flang-compiler/f18/issues/comments{/number}","contents_url":"https://api.github.com/repos/flang-compiler/f18/contents/{+path}","compare_url":"https://api.github.com/repos/flang-compiler/f18/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flang-compiler/f18/merges","archive_url":"https://api.github.com/repos/flang-compiler/f18/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flang-compiler/f18/downloads","issues_url":"https://api.github.com/repos/flang-compiler/f18/issues{/number}","pulls_url":"https://api.github.com/repos/flang-compiler/f18/pulls{/number}","milestones_url":"https://api.github.com/repos/flang-compiler/f18/milestones{/number}","notifications_url":"https://api.github.com/repos/flang-compiler/f18/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flang-compiler/f18/labels{/name}","releases_url":"https://api.github.com/repos/flang-compiler/f18/releases{/id}","deployments_url":"https://api.github.com/repos/flang-compiler/f18/deployments","created_at":"2018-01-25T21:34:19Z","updated_at":"2018-11-05T20:46:26Z","pushed_at":"2018-11-07T10:27:43Z","git_url":"git://github.com/flang-compiler/f18.git","ssh_url":"git@github.com:flang-compiler/f18.git","clone_url":"https://github.com/flang-compiler/f18.git","svn_url":"https://github.com/flang-compiler/f18","homepage":"","size":3022,"stargazers_count":63,"watchers_count":63,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8,"open_issues":10,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flang-compiler/f18/pulls/223"},"html":{"href":"https://github.com/flang-compiler/f18/pull/223"},"issue":{"href":"https://api.github.com/repos/flang-compiler/f18/issues/223"},"comments":{"href":"https://api.github.com/repos/flang-compiler/f18/issues/223/comments"},"review_comments":{"href":"https://api.github.com/repos/flang-compiler/f18/pulls/223/comments"},"review_comment":{"href":"https://api.github.com/repos/flang-compiler/f18/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flang-compiler/f18/pulls/223/commits"},"statuses":{"href":"https://api.github.com/repos/flang-compiler/f18/statuses/b90cadfc53c6e31c5f289eadc382bc3908811b86"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"tskeith"}}