{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/py-evm/pulls/comments/227618943","pull_request_review_id":167701666,"id":227618943,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzYxODk0Mw==","diff_hunk":"@@ -0,0 +1,23 @@\n+#!/usr/bin/env bash\n+\n+set -e\n+set -u","path":".circleci/install_rocksdb.sh","position":4,"original_position":4,"commit_id":"0b1a67b135b8411d429fd38e0e5cbb0e4c36fc4d","original_commit_id":"0b1a67b135b8411d429fd38e0e5cbb0e4c36fc4d","user":{"login":"pipermerriam","id":824194,"node_id":"MDQ6VXNlcjgyNDE5NA==","avatar_url":"https://avatars3.githubusercontent.com/u/824194?v=4","gravatar_id":"","url":"https://api.github.com/users/pipermerriam","html_url":"https://github.com/pipermerriam","followers_url":"https://api.github.com/users/pipermerriam/followers","following_url":"https://api.github.com/users/pipermerriam/following{/other_user}","gists_url":"https://api.github.com/users/pipermerriam/gists{/gist_id}","starred_url":"https://api.github.com/users/pipermerriam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pipermerriam/subscriptions","organizations_url":"https://api.github.com/users/pipermerriam/orgs","repos_url":"https://api.github.com/users/pipermerriam/repos","events_url":"https://api.github.com/users/pipermerriam/events{/privacy}","received_events_url":"https://api.github.com/users/pipermerriam/received_events","type":"User","site_admin":false},"body":"TIL there is a longform.","created_at":"2018-10-24T01:41:07Z","updated_at":"2018-10-24T01:41:07Z","html_url":"https://github.com/ethereum/py-evm/pull/1416#discussion_r227618943","pull_request_url":"https://api.github.com/repos/ethereum/py-evm/pulls/1416","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ethereum/py-evm/pulls/comments/227618943"},"html":{"href":"https://github.com/ethereum/py-evm/pull/1416#discussion_r227618943"},"pull_request":{"href":"https://api.github.com/repos/ethereum/py-evm/pulls/1416"}},"in_reply_to_id":227592787},"pull_request":{"url":"https://api.github.com/repos/ethereum/py-evm/pulls/1416","id":224390282,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MzkwMjgy","html_url":"https://github.com/ethereum/py-evm/pull/1416","diff_url":"https://github.com/ethereum/py-evm/pull/1416.diff","patch_url":"https://github.com/ethereum/py-evm/pull/1416.patch","issue_url":"https://api.github.com/repos/ethereum/py-evm/issues/1416","number":1416,"state":"open","locked":false,"title":"Base implementation of RocksDB support","user":{"login":"pipermerriam","id":824194,"node_id":"MDQ6VXNlcjgyNDE5NA==","avatar_url":"https://avatars3.githubusercontent.com/u/824194?v=4","gravatar_id":"","url":"https://api.github.com/users/pipermerriam","html_url":"https://github.com/pipermerriam","followers_url":"https://api.github.com/users/pipermerriam/followers","following_url":"https://api.github.com/users/pipermerriam/following{/other_user}","gists_url":"https://api.github.com/users/pipermerriam/gists{/gist_id}","starred_url":"https://api.github.com/users/pipermerriam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pipermerriam/subscriptions","organizations_url":"https://api.github.com/users/pipermerriam/orgs","repos_url":"https://api.github.com/users/pipermerriam/repos","events_url":"https://api.github.com/users/pipermerriam/events{/privacy}","received_events_url":"https://api.github.com/users/pipermerriam/received_events","type":"User","site_admin":false},"body":"### What was wrong?\r\n\r\nLevelDB doesn't support having multiple processes reading from the same database.  We worked around this by having a dedicated database process which has a direct handle on the database and all other processes interact with it over multiprocessing pipes.\r\n\r\nThis is not ideal.  It incurs extra overhead both with respect to performance and code complexity.\r\n\r\n### How was it fixed?\r\n\r\nImplemented a RocksDB backend which uses an alternate underlying database called rocksdb -> https://rocksdb.org/\r\n\r\nThis PR establishes the database backend class and adds a CLI argument to allow opt-in use of the new database backend.  A subsequent PR will tackle removal of the database process entirely.\r\n\r\n#### Cute Animal Picture\r\n\r\n![put a cute animal picture link inside the parentheses]()\r\n","created_at":"2018-10-19T19:39:35Z","updated_at":"2018-10-24T01:41:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6e0c50bb777372a3acfb3ed01c389c58ae2a78f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":831115091,"node_id":"MDU6TGFiZWw4MzExMTUwOTE=","url":"https://api.github.com/repos/ethereum/py-evm/labels/PR%20state:%20needs%20review","name":"PR state: needs review","color":"34daed","default":false},{"id":983629919,"node_id":"MDU6TGFiZWw5ODM2Mjk5MTk=","url":"https://api.github.com/repos/ethereum/py-evm/labels/effort:%20E2%20days","name":"effort: E2 days","color":"bfe5bf","default":false},{"id":983615867,"node_id":"MDU6TGFiZWw5ODM2MTU4Njc=","url":"https://api.github.com/repos/ethereum/py-evm/labels/type:%20refactor","name":"type: refactor","color":"eeeeee","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/py-evm/pulls/1416/commits","review_comments_url":"https://api.github.com/repos/ethereum/py-evm/pulls/1416/comments","review_comment_url":"https://api.github.com/repos/ethereum/py-evm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/py-evm/issues/1416/comments","statuses_url":"https://api.github.com/repos/ethereum/py-evm/statuses/0b1a67b135b8411d429fd38e0e5cbb0e4c36fc4d","head":{"label":"pipermerriam:piper/rocksdb","ref":"piper/rocksdb","sha":"0b1a67b135b8411d429fd38e0e5cbb0e4c36fc4d","user":{"login":"pipermerriam","id":824194,"node_id":"MDQ6VXNlcjgyNDE5NA==","avatar_url":"https://avatars3.githubusercontent.com/u/824194?v=4","gravatar_id":"","url":"https://api.github.com/users/pipermerriam","html_url":"https://github.com/pipermerriam","followers_url":"https://api.github.com/users/pipermerriam/followers","following_url":"https://api.github.com/users/pipermerriam/following{/other_user}","gists_url":"https://api.github.com/users/pipermerriam/gists{/gist_id}","starred_url":"https://api.github.com/users/pipermerriam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pipermerriam/subscriptions","organizations_url":"https://api.github.com/users/pipermerriam/orgs","repos_url":"https://api.github.com/users/pipermerriam/repos","events_url":"https://api.github.com/users/pipermerriam/events{/privacy}","received_events_url":"https://api.github.com/users/pipermerriam/received_events","type":"User","site_admin":false},"repo":{"id":112370752,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIzNzA3NTI=","name":"py-evm","full_name":"pipermerriam/py-evm","private":false,"owner":{"login":"pipermerriam","id":824194,"node_id":"MDQ6VXNlcjgyNDE5NA==","avatar_url":"https://avatars3.githubusercontent.com/u/824194?v=4","gravatar_id":"","url":"https://api.github.com/users/pipermerriam","html_url":"https://github.com/pipermerriam","followers_url":"https://api.github.com/users/pipermerriam/followers","following_url":"https://api.github.com/users/pipermerriam/following{/other_user}","gists_url":"https://api.github.com/users/pipermerriam/gists{/gist_id}","starred_url":"https://api.github.com/users/pipermerriam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pipermerriam/subscriptions","organizations_url":"https://api.github.com/users/pipermerriam/orgs","repos_url":"https://api.github.com/users/pipermerriam/repos","events_url":"https://api.github.com/users/pipermerriam/events{/privacy}","received_events_url":"https://api.github.com/users/pipermerriam/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pipermerriam/py-evm","description":"A Python implementation of the Ethereum Virtual Machine","fork":true,"url":"https://api.github.com/repos/pipermerriam/py-evm","forks_url":"https://api.github.com/repos/pipermerriam/py-evm/forks","keys_url":"https://api.github.com/repos/pipermerriam/py-evm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pipermerriam/py-evm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pipermerriam/py-evm/teams","hooks_url":"https://api.github.com/repos/pipermerriam/py-evm/hooks","issue_events_url":"https://api.github.com/repos/pipermerriam/py-evm/issues/events{/number}","events_url":"https://api.github.com/repos/pipermerriam/py-evm/events","assignees_url":"https://api.github.com/repos/pipermerriam/py-evm/assignees{/user}","branches_url":"https://api.github.com/repos/pipermerriam/py-evm/branches{/branch}","tags_url":"https://api.github.com/repos/pipermerriam/py-evm/tags","blobs_url":"https://api.github.com/repos/pipermerriam/py-evm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pipermerriam/py-evm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pipermerriam/py-evm/git/refs{/sha}","trees_url":"https://api.github.com/repos/pipermerriam/py-evm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pipermerriam/py-evm/statuses/{sha}","languages_url":"https://api.github.com/repos/pipermerriam/py-evm/languages","stargazers_url":"https://api.github.com/repos/pipermerriam/py-evm/stargazers","contributors_url":"https://api.github.com/repos/pipermerriam/py-evm/contributors","subscribers_url":"https://api.github.com/repos/pipermerriam/py-evm/subscribers","subscription_url":"https://api.github.com/repos/pipermerriam/py-evm/subscription","commits_url":"https://api.github.com/repos/pipermerriam/py-evm/commits{/sha}","git_commits_url":"https://api.github.com/repos/pipermerriam/py-evm/git/commits{/sha}","comments_url":"https://api.github.com/repos/pipermerriam/py-evm/comments{/number}","issue_comment_url":"https://api.github.com/repos/pipermerriam/py-evm/issues/comments{/number}","contents_url":"https://api.github.com/repos/pipermerriam/py-evm/contents/{+path}","compare_url":"https://api.github.com/repos/pipermerriam/py-evm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pipermerriam/py-evm/merges","archive_url":"https://api.github.com/repos/pipermerriam/py-evm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pipermerriam/py-evm/downloads","issues_url":"https://api.github.com/repos/pipermerriam/py-evm/issues{/number}","pulls_url":"https://api.github.com/repos/pipermerriam/py-evm/pulls{/number}","milestones_url":"https://api.github.com/repos/pipermerriam/py-evm/milestones{/number}","notifications_url":"https://api.github.com/repos/pipermerriam/py-evm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pipermerriam/py-evm/labels{/name}","releases_url":"https://api.github.com/repos/pipermerriam/py-evm/releases{/id}","deployments_url":"https://api.github.com/repos/pipermerriam/py-evm/deployments","created_at":"2017-11-28T18:07:13Z","updated_at":"2018-10-08T16:45:36Z","pushed_at":"2018-10-23T22:01:43Z","git_url":"git://github.com/pipermerriam/py-evm.git","ssh_url":"git@github.com:pipermerriam/py-evm.git","clone_url":"https://github.com/pipermerriam/py-evm.git","svn_url":"https://github.com/pipermerriam/py-evm","homepage":"","size":6109,"stargazers_count":30,"watchers_count":30,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":0,"watchers":30,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"e48b279bb53928ea1a6941109398b2ad6afb67bb","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":77478378,"node_id":"MDEwOlJlcG9zaXRvcnk3NzQ3ODM3OA==","name":"py-evm","full_name":"ethereum/py-evm","private":false,"owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethereum/py-evm","description":"A Python implementation of the Ethereum Virtual Machine","fork":false,"url":"https://api.github.com/repos/ethereum/py-evm","forks_url":"https://api.github.com/repos/ethereum/py-evm/forks","keys_url":"https://api.github.com/repos/ethereum/py-evm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/py-evm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/py-evm/teams","hooks_url":"https://api.github.com/repos/ethereum/py-evm/hooks","issue_events_url":"https://api.github.com/repos/ethereum/py-evm/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/py-evm/events","assignees_url":"https://api.github.com/repos/ethereum/py-evm/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/py-evm/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/py-evm/tags","blobs_url":"https://api.github.com/repos/ethereum/py-evm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/py-evm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/py-evm/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/py-evm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/py-evm/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/py-evm/languages","stargazers_url":"https://api.github.com/repos/ethereum/py-evm/stargazers","contributors_url":"https://api.github.com/repos/ethereum/py-evm/contributors","subscribers_url":"https://api.github.com/repos/ethereum/py-evm/subscribers","subscription_url":"https://api.github.com/repos/ethereum/py-evm/subscription","commits_url":"https://api.github.com/repos/ethereum/py-evm/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/py-evm/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/py-evm/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/py-evm/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/py-evm/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/py-evm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/py-evm/merges","archive_url":"https://api.github.com/repos/ethereum/py-evm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/py-evm/downloads","issues_url":"https://api.github.com/repos/ethereum/py-evm/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/py-evm/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/py-evm/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/py-evm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/py-evm/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/py-evm/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/py-evm/deployments","created_at":"2016-12-27T19:36:00Z","updated_at":"2018-10-23T01:35:15Z","pushed_at":"2018-10-23T22:01:45Z","git_url":"git://github.com/ethereum/py-evm.git","ssh_url":"git@github.com:ethereum/py-evm.git","clone_url":"https://github.com/ethereum/py-evm.git","svn_url":"https://github.com/ethereum/py-evm","homepage":"https://trinity.ethereum.org/","size":5845,"stargazers_count":702,"watchers_count":702,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":309,"mirror_url":null,"archived":false,"open_issues_count":128,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":309,"open_issues":128,"watchers":702,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/py-evm/pulls/1416"},"html":{"href":"https://github.com/ethereum/py-evm/pull/1416"},"issue":{"href":"https://api.github.com/repos/ethereum/py-evm/issues/1416"},"comments":{"href":"https://api.github.com/repos/ethereum/py-evm/issues/1416/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/py-evm/pulls/1416/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/py-evm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/py-evm/pulls/1416/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/py-evm/statuses/0b1a67b135b8411d429fd38e0e5cbb0e4c36fc4d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"pipermerriam"}}