{"action":"created","comment":{"url":"https://api.github.com/repos/arfc/saltproc/pulls/comments/212828274","pull_request_review_id":149538882,"id":212828274,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjgyODI3NA==","diff_hunk":"@@ -379,10 +672,15 @@ def run_serpent(self):\n         else:\n             args = (self.exec_path,\n                     '-omp', str(self.cores), self.input_file)\n-        popen = subprocess.Popen(args, stdout=subprocess.PIPE)\n-        print(popen.stdout.read())\n-\n-    def remove_iso(self, target_iso, removal_eff):\n+        print('RUNNNIN')\n+        try:\n+            output = subprocess.check_output(args)\n+        except subprocess.CalledProcessError as e:\n+            print(e.output)\n+            raise ValueError('\\nSEPRENT FAILED\\n')\n+        print('DONES')","path":"saltproc/saltproc.py","position":857,"original_position":857,"commit_id":"ec4b3ca831dd5bb247da63c41196236ad04d78b8","original_commit_id":"ec4b3ca831dd5bb247da63c41196236ad04d78b8","user":{"login":"katyhuff","id":393899,"node_id":"MDQ6VXNlcjM5Mzg5OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/393899?v=4","gravatar_id":"","url":"https://api.github.com/users/katyhuff","html_url":"https://github.com/katyhuff","followers_url":"https://api.github.com/users/katyhuff/followers","following_url":"https://api.github.com/users/katyhuff/following{/other_user}","gists_url":"https://api.github.com/users/katyhuff/gists{/gist_id}","starred_url":"https://api.github.com/users/katyhuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katyhuff/subscriptions","organizations_url":"https://api.github.com/users/katyhuff/orgs","repos_url":"https://api.github.com/users/katyhuff/repos","events_url":"https://api.github.com/users/katyhuff/events{/privacy}","received_events_url":"https://api.github.com/users/katyhuff/received_events","type":"User","site_admin":false},"body":"dones?","created_at":"2018-08-26T14:30:40Z","updated_at":"2018-08-26T14:40:21Z","html_url":"https://github.com/arfc/saltproc/pull/29#discussion_r212828274","pull_request_url":"https://api.github.com/repos/arfc/saltproc/pulls/29","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/arfc/saltproc/pulls/comments/212828274"},"html":{"href":"https://github.com/arfc/saltproc/pull/29#discussion_r212828274"},"pull_request":{"href":"https://api.github.com/repos/arfc/saltproc/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/arfc/saltproc/pulls/29","id":209295412,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5Mjk1NDEy","html_url":"https://github.com/arfc/saltproc/pull/29","diff_url":"https://github.com/arfc/saltproc/pull/29.diff","patch_url":"https://github.com/arfc/saltproc/pull/29.patch","issue_url":"https://api.github.com/repos/arfc/saltproc/issues/29","number":29,"state":"open","locked":false,"title":"Saltproc capability addition and UI improvement","user":{"login":"jbae11","id":20345275,"node_id":"MDQ6VXNlcjIwMzQ1Mjc1","avatar_url":"https://avatars1.githubusercontent.com/u/20345275?v=4","gravatar_id":"","url":"https://api.github.com/users/jbae11","html_url":"https://github.com/jbae11","followers_url":"https://api.github.com/users/jbae11/followers","following_url":"https://api.github.com/users/jbae11/following{/other_user}","gists_url":"https://api.github.com/users/jbae11/gists{/gist_id}","starred_url":"https://api.github.com/users/jbae11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbae11/subscriptions","organizations_url":"https://api.github.com/users/jbae11/orgs","repos_url":"https://api.github.com/users/jbae11/repos","events_url":"https://api.github.com/users/jbae11/events{/privacy}","received_events_url":"https://api.github.com/users/jbae11/received_events","type":"User","site_admin":false},"body":"This PR includes addition of the following capabilities:\r\n\r\n1. user-input reprocessing scheme (solves #19)\r\n2. Two-region simulation\r\n3. input file (`run_saltproc.py`) to drive saltproc run (solves #27, #28 )\r\n4. more unit tests\r\n5. 'Smarter' looking up isotopes from the xs library (solves #18)\r\n6. Continuous integration (solves #26)\r\n7. Saving runinfo (user input parameters) into db (solves #24)\r\n8. conversion from .bumat to .dep file (solves #22 )","created_at":"2018-08-18T05:20:30Z","updated_at":"2018-08-26T14:40:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dcf92a725fa02bb07b2eb9f0fb07bea6f36285e6","assignee":{"login":"jbae11","id":20345275,"node_id":"MDQ6VXNlcjIwMzQ1Mjc1","avatar_url":"https://avatars1.githubusercontent.com/u/20345275?v=4","gravatar_id":"","url":"https://api.github.com/users/jbae11","html_url":"https://github.com/jbae11","followers_url":"https://api.github.com/users/jbae11/followers","following_url":"https://api.github.com/users/jbae11/following{/other_user}","gists_url":"https://api.github.com/users/jbae11/gists{/gist_id}","starred_url":"https://api.github.com/users/jbae11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbae11/subscriptions","organizations_url":"https://api.github.com/users/jbae11/orgs","repos_url":"https://api.github.com/users/jbae11/repos","events_url":"https://api.github.com/users/jbae11/events{/privacy}","received_events_url":"https://api.github.com/users/jbae11/received_events","type":"User","site_admin":false},"assignees":[{"login":"jbae11","id":20345275,"node_id":"MDQ6VXNlcjIwMzQ1Mjc1","avatar_url":"https://avatars1.githubusercontent.com/u/20345275?v=4","gravatar_id":"","url":"https://api.github.com/users/jbae11","html_url":"https://github.com/jbae11","followers_url":"https://api.github.com/users/jbae11/followers","following_url":"https://api.github.com/users/jbae11/following{/other_user}","gists_url":"https://api.github.com/users/jbae11/gists{/gist_id}","starred_url":"https://api.github.com/users/jbae11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbae11/subscriptions","organizations_url":"https://api.github.com/users/jbae11/orgs","repos_url":"https://api.github.com/users/jbae11/repos","events_url":"https://api.github.com/users/jbae11/events{/privacy}","received_events_url":"https://api.github.com/users/jbae11/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"andrewryh","id":20629016,"node_id":"MDQ6VXNlcjIwNjI5MDE2","avatar_url":"https://avatars0.githubusercontent.com/u/20629016?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewryh","html_url":"https://github.com/andrewryh","followers_url":"https://api.github.com/users/andrewryh/followers","following_url":"https://api.github.com/users/andrewryh/following{/other_user}","gists_url":"https://api.github.com/users/andrewryh/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewryh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewryh/subscriptions","organizations_url":"https://api.github.com/users/andrewryh/orgs","repos_url":"https://api.github.com/users/andrewryh/repos","events_url":"https://api.github.com/users/andrewryh/events{/privacy}","received_events_url":"https://api.github.com/users/andrewryh/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":709562065,"node_id":"MDU6TGFiZWw3MDk1NjIwNjU=","url":"https://api.github.com/repos/arfc/saltproc/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/arfc/saltproc/pulls/29/commits","review_comments_url":"https://api.github.com/repos/arfc/saltproc/pulls/29/comments","review_comment_url":"https://api.github.com/repos/arfc/saltproc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arfc/saltproc/issues/29/comments","statuses_url":"https://api.github.com/repos/arfc/saltproc/statuses/ec4b3ca831dd5bb247da63c41196236ad04d78b8","head":{"label":"jbae11:combined","ref":"combined","sha":"ec4b3ca831dd5bb247da63c41196236ad04d78b8","user":{"login":"jbae11","id":20345275,"node_id":"MDQ6VXNlcjIwMzQ1Mjc1","avatar_url":"https://avatars1.githubusercontent.com/u/20345275?v=4","gravatar_id":"","url":"https://api.github.com/users/jbae11","html_url":"https://github.com/jbae11","followers_url":"https://api.github.com/users/jbae11/followers","following_url":"https://api.github.com/users/jbae11/following{/other_user}","gists_url":"https://api.github.com/users/jbae11/gists{/gist_id}","starred_url":"https://api.github.com/users/jbae11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbae11/subscriptions","organizations_url":"https://api.github.com/users/jbae11/orgs","repos_url":"https://api.github.com/users/jbae11/repos","events_url":"https://api.github.com/users/jbae11/events{/privacy}","received_events_url":"https://api.github.com/users/jbae11/received_events","type":"User","site_admin":false},"repo":{"id":122673824,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI2NzM4MjQ=","name":"saltproc","full_name":"jbae11/saltproc","owner":{"login":"jbae11","id":20345275,"node_id":"MDQ6VXNlcjIwMzQ1Mjc1","avatar_url":"https://avatars1.githubusercontent.com/u/20345275?v=4","gravatar_id":"","url":"https://api.github.com/users/jbae11","html_url":"https://github.com/jbae11","followers_url":"https://api.github.com/users/jbae11/followers","following_url":"https://api.github.com/users/jbae11/following{/other_user}","gists_url":"https://api.github.com/users/jbae11/gists{/gist_id}","starred_url":"https://api.github.com/users/jbae11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbae11/subscriptions","organizations_url":"https://api.github.com/users/jbae11/orgs","repos_url":"https://api.github.com/users/jbae11/repos","events_url":"https://api.github.com/users/jbae11/events{/privacy}","received_events_url":"https://api.github.com/users/jbae11/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jbae11/saltproc","description":"Online reprocessing for molten salt reactors","fork":true,"url":"https://api.github.com/repos/jbae11/saltproc","forks_url":"https://api.github.com/repos/jbae11/saltproc/forks","keys_url":"https://api.github.com/repos/jbae11/saltproc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbae11/saltproc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbae11/saltproc/teams","hooks_url":"https://api.github.com/repos/jbae11/saltproc/hooks","issue_events_url":"https://api.github.com/repos/jbae11/saltproc/issues/events{/number}","events_url":"https://api.github.com/repos/jbae11/saltproc/events","assignees_url":"https://api.github.com/repos/jbae11/saltproc/assignees{/user}","branches_url":"https://api.github.com/repos/jbae11/saltproc/branches{/branch}","tags_url":"https://api.github.com/repos/jbae11/saltproc/tags","blobs_url":"https://api.github.com/repos/jbae11/saltproc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbae11/saltproc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbae11/saltproc/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbae11/saltproc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbae11/saltproc/statuses/{sha}","languages_url":"https://api.github.com/repos/jbae11/saltproc/languages","stargazers_url":"https://api.github.com/repos/jbae11/saltproc/stargazers","contributors_url":"https://api.github.com/repos/jbae11/saltproc/contributors","subscribers_url":"https://api.github.com/repos/jbae11/saltproc/subscribers","subscription_url":"https://api.github.com/repos/jbae11/saltproc/subscription","commits_url":"https://api.github.com/repos/jbae11/saltproc/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbae11/saltproc/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbae11/saltproc/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbae11/saltproc/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbae11/saltproc/contents/{+path}","compare_url":"https://api.github.com/repos/jbae11/saltproc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbae11/saltproc/merges","archive_url":"https://api.github.com/repos/jbae11/saltproc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbae11/saltproc/downloads","issues_url":"https://api.github.com/repos/jbae11/saltproc/issues{/number}","pulls_url":"https://api.github.com/repos/jbae11/saltproc/pulls{/number}","milestones_url":"https://api.github.com/repos/jbae11/saltproc/milestones{/number}","notifications_url":"https://api.github.com/repos/jbae11/saltproc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbae11/saltproc/labels{/name}","releases_url":"https://api.github.com/repos/jbae11/saltproc/releases{/id}","deployments_url":"https://api.github.com/repos/jbae11/saltproc/deployments","created_at":"2018-02-23T21:19:35Z","updated_at":"2018-06-22T16:48:16Z","pushed_at":"2018-08-26T02:20:14Z","git_url":"git://github.com/jbae11/saltproc.git","ssh_url":"git@github.com:jbae11/saltproc.git","clone_url":"https://github.com/jbae11/saltproc.git","svn_url":"https://github.com/jbae11/saltproc","homepage":null,"size":28155,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"arfc:master","ref":"master","sha":"c58c1ac16011bce62822a7460c9346828863a117","user":{"login":"arfc","id":17805598,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODA1NTk4","avatar_url":"https://avatars2.githubusercontent.com/u/17805598?v=4","gravatar_id":"","url":"https://api.github.com/users/arfc","html_url":"https://github.com/arfc","followers_url":"https://api.github.com/users/arfc/followers","following_url":"https://api.github.com/users/arfc/following{/other_user}","gists_url":"https://api.github.com/users/arfc/gists{/gist_id}","starred_url":"https://api.github.com/users/arfc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arfc/subscriptions","organizations_url":"https://api.github.com/users/arfc/orgs","repos_url":"https://api.github.com/users/arfc/repos","events_url":"https://api.github.com/users/arfc/events{/privacy}","received_events_url":"https://api.github.com/users/arfc/received_events","type":"Organization","site_admin":false},"repo":{"id":105661474,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU2NjE0NzQ=","name":"saltproc","full_name":"arfc/saltproc","owner":{"login":"arfc","id":17805598,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODA1NTk4","avatar_url":"https://avatars2.githubusercontent.com/u/17805598?v=4","gravatar_id":"","url":"https://api.github.com/users/arfc","html_url":"https://github.com/arfc","followers_url":"https://api.github.com/users/arfc/followers","following_url":"https://api.github.com/users/arfc/following{/other_user}","gists_url":"https://api.github.com/users/arfc/gists{/gist_id}","starred_url":"https://api.github.com/users/arfc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arfc/subscriptions","organizations_url":"https://api.github.com/users/arfc/orgs","repos_url":"https://api.github.com/users/arfc/repos","events_url":"https://api.github.com/users/arfc/events{/privacy}","received_events_url":"https://api.github.com/users/arfc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/arfc/saltproc","description":"Online reprocessing for molten salt reactors","fork":false,"url":"https://api.github.com/repos/arfc/saltproc","forks_url":"https://api.github.com/repos/arfc/saltproc/forks","keys_url":"https://api.github.com/repos/arfc/saltproc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arfc/saltproc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arfc/saltproc/teams","hooks_url":"https://api.github.com/repos/arfc/saltproc/hooks","issue_events_url":"https://api.github.com/repos/arfc/saltproc/issues/events{/number}","events_url":"https://api.github.com/repos/arfc/saltproc/events","assignees_url":"https://api.github.com/repos/arfc/saltproc/assignees{/user}","branches_url":"https://api.github.com/repos/arfc/saltproc/branches{/branch}","tags_url":"https://api.github.com/repos/arfc/saltproc/tags","blobs_url":"https://api.github.com/repos/arfc/saltproc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arfc/saltproc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arfc/saltproc/git/refs{/sha}","trees_url":"https://api.github.com/repos/arfc/saltproc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arfc/saltproc/statuses/{sha}","languages_url":"https://api.github.com/repos/arfc/saltproc/languages","stargazers_url":"https://api.github.com/repos/arfc/saltproc/stargazers","contributors_url":"https://api.github.com/repos/arfc/saltproc/contributors","subscribers_url":"https://api.github.com/repos/arfc/saltproc/subscribers","subscription_url":"https://api.github.com/repos/arfc/saltproc/subscription","commits_url":"https://api.github.com/repos/arfc/saltproc/commits{/sha}","git_commits_url":"https://api.github.com/repos/arfc/saltproc/git/commits{/sha}","comments_url":"https://api.github.com/repos/arfc/saltproc/comments{/number}","issue_comment_url":"https://api.github.com/repos/arfc/saltproc/issues/comments{/number}","contents_url":"https://api.github.com/repos/arfc/saltproc/contents/{+path}","compare_url":"https://api.github.com/repos/arfc/saltproc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arfc/saltproc/merges","archive_url":"https://api.github.com/repos/arfc/saltproc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arfc/saltproc/downloads","issues_url":"https://api.github.com/repos/arfc/saltproc/issues{/number}","pulls_url":"https://api.github.com/repos/arfc/saltproc/pulls{/number}","milestones_url":"https://api.github.com/repos/arfc/saltproc/milestones{/number}","notifications_url":"https://api.github.com/repos/arfc/saltproc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arfc/saltproc/labels{/name}","releases_url":"https://api.github.com/repos/arfc/saltproc/releases{/id}","deployments_url":"https://api.github.com/repos/arfc/saltproc/deployments","created_at":"2017-10-03T14:27:42Z","updated_at":"2018-07-29T13:57:25Z","pushed_at":"2018-08-26T02:20:16Z","git_url":"git://github.com/arfc/saltproc.git","ssh_url":"git@github.com:arfc/saltproc.git","clone_url":"https://github.com/arfc/saltproc.git","svn_url":"https://github.com/arfc/saltproc","homepage":null,"size":8112,"stargazers_count":0,"watchers_count":0,"language":"Matlab","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":14,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arfc/saltproc/pulls/29"},"html":{"href":"https://github.com/arfc/saltproc/pull/29"},"issue":{"href":"https://api.github.com/repos/arfc/saltproc/issues/29"},"comments":{"href":"https://api.github.com/repos/arfc/saltproc/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/arfc/saltproc/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/arfc/saltproc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arfc/saltproc/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/arfc/saltproc/statuses/ec4b3ca831dd5bb247da63c41196236ad04d78b8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"katyhuff"}}