{"action":"created","issue":{"url":"https://api.github.com/repos/Yucked/Veronica/issues/56","repository_url":"https://api.github.com/repos/Yucked/Veronica","labels_url":"https://api.github.com/repos/Yucked/Veronica/issues/56/labels{/name}","comments_url":"https://api.github.com/repos/Yucked/Veronica/issues/56/comments","events_url":"https://api.github.com/repos/Yucked/Veronica/issues/56/events","html_url":"https://github.com/Yucked/Veronica/issues/56","id":378996280,"node_id":"MDU6SXNzdWUzNzg5OTYyODA=","number":56,"title":"About the rewrite","user":{"login":"FurkanKambay","id":8467416,"node_id":"MDQ6VXNlcjg0Njc0MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/8467416?v=4","gravatar_id":"","url":"https://api.github.com/users/FurkanKambay","html_url":"https://github.com/FurkanKambay","followers_url":"https://api.github.com/users/FurkanKambay/followers","following_url":"https://api.github.com/users/FurkanKambay/following{/other_user}","gists_url":"https://api.github.com/users/FurkanKambay/gists{/gist_id}","starred_url":"https://api.github.com/users/FurkanKambay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FurkanKambay/subscriptions","organizations_url":"https://api.github.com/users/FurkanKambay/orgs","repos_url":"https://api.github.com/users/FurkanKambay/repos","events_url":"https://api.github.com/users/FurkanKambay/events{/privacy}","received_events_url":"https://api.github.com/users/FurkanKambay/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-09T02:20:33Z","updated_at":"2018-11-09T17:42:03Z","closed_at":null,"author_association":"NONE","body":"Just some things I saw while sleepless. Will take a look after my winter sleep.\r\n(Just suggestions, pick and choose, ofc)\r\n\r\nGoing \"top to bottom\" —if you will— on the repo homepage:\r\n\r\n> OCD enabled\r\n\r\n- The repo description: \"ongoing\"* and non-title case.\r\n- How 'bout enabling projects and making use of issues more (I think the repo has a very low issue/commit rate meaning you commit way too often. - Not sure if you care but if you do, this point will prob' be helpful)\r\n- No license intended?\r\n- Please try to write better commit messages, LOL 🤣  (Although, I applaud your bravery 'cause I wouldn't have been able to bring myself to push with those messages because of my OCD)\r\n- Make use of branches? master for prod, dev for, well, dev.\r\n- The directory and project structure\r\n  - .sln file and directory (why did you .gitignore solution files exactly?)\r\n  - .editorconfig of your style (File encodings, EOL, dotnet style rules...)\r\n\r\n> OCD still enabled\r\n\r\nI might open a PR for some things tomorrow (or next week based on for how long I \"snooze\" it 😄)\r\n\r\nP.S. I haven't even tried the bot on Discord yet. I literally just saw the repo on my recommended sidebar."},"comment":{"url":"https://api.github.com/repos/Yucked/Veronica/issues/comments/437437611","html_url":"https://github.com/Yucked/Veronica/issues/56#issuecomment-437437611","issue_url":"https://api.github.com/repos/Yucked/Veronica/issues/56","id":437437611,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzQzNzYxMQ==","user":{"login":"Yucked","id":20461656,"node_id":"MDQ6VXNlcjIwNDYxNjU2","avatar_url":"https://avatars0.githubusercontent.com/u/20461656?v=4","gravatar_id":"","url":"https://api.github.com/users/Yucked","html_url":"https://github.com/Yucked","followers_url":"https://api.github.com/users/Yucked/followers","following_url":"https://api.github.com/users/Yucked/following{/other_user}","gists_url":"https://api.github.com/users/Yucked/gists{/gist_id}","starred_url":"https://api.github.com/users/Yucked/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yucked/subscriptions","organizations_url":"https://api.github.com/users/Yucked/orgs","repos_url":"https://api.github.com/users/Yucked/repos","events_url":"https://api.github.com/users/Yucked/events{/privacy}","received_events_url":"https://api.github.com/users/Yucked/received_events","type":"User","site_admin":false},"created_at":"2018-11-09T17:42:03Z","updated_at":"2018-11-09T17:42:03Z","author_association":"OWNER","body":"Generally speaking since *rarely* anyone uses .Net FX for bot building and .Net Core is like the recommended standard since it's cross platform, running `dotnet new console` or any other template doesn't create a .sln file. I do technically use command line to create a project template since it's fast then use Jetbrains Rider for programming and Visual Studio for debugging thoroughly. But again if you're using .sln for multiple projects that's great, I myself am using it but once the complete rewrite is finished, most of the projected references will be removed and actually packages will be used.\r\n\r\nAnd, aren't common ways technically LTS ways or perhaps the old ways of doing things? I'm just trying to keep things simple and to the point.\r\n\r\nYes, I've tried doing the directory way and it looks atrocious as if nothing has been added to the repository. But if anything use can always open the repo in visual studio, make a change and save it then close it, which will open up the dialog about saving sln and viola. It's not a necessary thing and the whole project doesn't depend on it either.\r\n\r\nYes, references are for debugging purposes. Which is why there is a headline on top saying \"On going rewrite\". Not to forget Victoria is a library I wrote for .Net bots to provide music support via Lavalink."}}
{"actor":{"display_login":"Yucked"}}