{"action":"created","issue":{"url":"https://api.github.com/repos/PokeAlarm/PokeAlarm/issues/612","repository_url":"https://api.github.com/repos/PokeAlarm/PokeAlarm","labels_url":"https://api.github.com/repos/PokeAlarm/PokeAlarm/issues/612/labels{/name}","comments_url":"https://api.github.com/repos/PokeAlarm/PokeAlarm/issues/612/comments","events_url":"https://api.github.com/repos/PokeAlarm/PokeAlarm/issues/612/events","html_url":"https://github.com/PokeAlarm/PokeAlarm/pull/612","id":298432804,"number":612,"title":"GMaps Improvements","user":{"login":"kvangent","id":10712294,"avatar_url":"https://avatars1.githubusercontent.com/u/10712294?v=4","gravatar_id":"","url":"https://api.github.com/users/kvangent","html_url":"https://github.com/kvangent","followers_url":"https://api.github.com/users/kvangent/followers","following_url":"https://api.github.com/users/kvangent/following{/other_user}","gists_url":"https://api.github.com/users/kvangent/gists{/gist_id}","starred_url":"https://api.github.com/users/kvangent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvangent/subscriptions","organizations_url":"https://api.github.com/users/kvangent/orgs","repos_url":"https://api.github.com/users/kvangent/repos","events_url":"https://api.github.com/users/kvangent/events{/privacy}","received_events_url":"https://api.github.com/users/kvangent/received_events","type":"User","site_admin":false},"labels":[{"id":814460294,"url":"https://api.github.com/repos/PokeAlarm/PokeAlarm/labels/bug%20fix","name":"bug fix","color":"e06771","default":false},{"id":741481148,"url":"https://api.github.com/repos/PokeAlarm/PokeAlarm/labels/needs%20wiki%20update","name":"needs wiki update","color":"79ef6e","default":false},{"id":415608409,"url":"https://api.github.com/repos/PokeAlarm/PokeAlarm/labels/new%20feature","name":"new feature","color":"84b6eb","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-02-20T00:03:04Z","updated_at":"2018-02-23T00:43:57Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/PokeAlarm/PokeAlarm/pulls/612","html_url":"https://github.com/PokeAlarm/PokeAlarm/pull/612","diff_url":"https://github.com/PokeAlarm/PokeAlarm/pull/612.diff","patch_url":"https://github.com/PokeAlarm/PokeAlarm/pull/612.patch"},"body":"<!--       PULL REQUESTS CREATED NOT USING ONE OF THE BELOW         --->\r\n<!--      ISSUE TEMPLATES WILL BE CLOSED WITHOUT ANY RESPONSE       --->\r\n<!--       PULL REQUESTS CREATED NOT USING ONE OF THE BELOW         --->\r\n<!--      ISSUE TEMPLATES WILL BE CLOSED WITHOUT ANY RESPONSE       --->\r\n<!--       PULL REQUESTS CREATED NOT USING ONE OF THE BELOW         --->\r\n<!--      ISSUE TEMPLATES WILL BE CLOSED WITHOUT ANY RESPONSE       --->\r\n<!--       PULL REQUESTS CREATED NOT USING ONE OF THE BELOW         --->\r\n<!--      ISSUE TEMPLATES WILL BE CLOSED WITHOUT ANY RESPONSE       --->\r\n\r\n\r\n<!--\r\n Please make all PRs to the dev branch. The dev branch will be\r\n periodically pulled into the master branch. This allows time for\r\n the changes and documentation to be tested before being exposed to\r\n a wider population.\r\n--->\r\n\r\n## Description\r\n<!-- In detail, describe what your PR adds to PokeAlarm -->\r\nThis is a rewrite of the Google Maps API calls used for DTS. It removes the official google python client and instead handles the requests directly to give more control over how they are handled. This will allow for better error handling and won't timeout for extended periods of time when the API Quota has been reached.\r\n\r\nAdditionally, it removes the automatic DTS detection and instead adds explicit config options to enable the use of DTS. This is to reduce issues users are experiencing with accidentally overusing their quota. (as a side effect I've cleaned up the config.ini.example as well)\r\n\r\nSome of the Distance Matrix DTS have been renamed, and are as follows:\r\n* `<walking_distance>` and `<walking_duration>`\r\n* `<biking_distance>` and `<biking_duration>`\r\n* `<driving_distance>` and `<driving_duration>`\r\n* `<transit_distance>` and `<transit_duration>` - (these two are new)\r\n\r\n## Type of Change\r\n<!-- Place a single 'x' into the correct box, ex: [x] -->\r\n- [X] Bug fix (non-breaking change which fixes an issue)\r\n- [X] New feature (non-breaking change which adds functionality)\r\n- [X] Breaking change (would cause existing functionality to change)\r\n\r\n## Motivation and Context\r\n<!---\r\n Why is this change required? What problem does it solve?\r\n If it fixes an open issue, please link to the issue here.\r\n-->\r\nThe official GMaps client repeatedly spams the API server until it times out, which can cause several seconds of blocking when trying to trigger a notification. Additionally, some users were hitting their quotas by accident because they were using APIs they didn't know they had enabled.\r\n\r\n## Wiki Update\r\n<!--\r\n Does this feature require an update to the wiki? If so, please submit\r\n the required change to https://github.com/RocketMap/PokeAlarmWiki.\r\n If your feature requires a wiki update, you may submit it for review\r\n but it will not be accepted until the wiki update is complete.\r\n--->\r\n- [X] This change requires an update to the Wiki.\r\n- [ ] This change does not require an update to the Wiki."},"comment":{"url":"https://api.github.com/repos/PokeAlarm/PokeAlarm/issues/comments/367872413","html_url":"https://github.com/PokeAlarm/PokeAlarm/pull/612#issuecomment-367872413","issue_url":"https://api.github.com/repos/PokeAlarm/PokeAlarm/issues/612","id":367872413,"user":{"login":"The-Real-Ketchum-Dev","id":36284019,"avatar_url":"https://avatars0.githubusercontent.com/u/36284019?v=4","gravatar_id":"","url":"https://api.github.com/users/The-Real-Ketchum-Dev","html_url":"https://github.com/The-Real-Ketchum-Dev","followers_url":"https://api.github.com/users/The-Real-Ketchum-Dev/followers","following_url":"https://api.github.com/users/The-Real-Ketchum-Dev/following{/other_user}","gists_url":"https://api.github.com/users/The-Real-Ketchum-Dev/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Real-Ketchum-Dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Real-Ketchum-Dev/subscriptions","organizations_url":"https://api.github.com/users/The-Real-Ketchum-Dev/orgs","repos_url":"https://api.github.com/users/The-Real-Ketchum-Dev/repos","events_url":"https://api.github.com/users/The-Real-Ketchum-Dev/events{/privacy}","received_events_url":"https://api.github.com/users/The-Real-Ketchum-Dev/received_events","type":"User","site_admin":false},"created_at":"2018-02-23T00:43:57Z","updated_at":"2018-02-23T00:43:57Z","author_association":"NONE","body":"@kvangent unless something has changed with custom_dts then no.. It worked before adding this PR"}}
{"actor":{"display_login":"The-Real-Ketchum-Dev"}}