{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/pulls/comments/203683051","pull_request_review_id":138618778,"id":203683051,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzY4MzA1MQ==","diff_hunk":"@@ -1,24 +1,31 @@\n BUILD_VERSION := $(shell cat VERSION)\n+BUILD_DATE := $(shell date '+%Y%m%d')","path":"Makefile","position":2,"original_position":2,"commit_id":"19c9cb80ee2d6a98a98d3e796b99d5a818ef7b94","original_commit_id":"19c9cb80ee2d6a98a98d3e796b99d5a818ef7b94","user":{"login":"Wynndow","id":13836290,"node_id":"MDQ6VXNlcjEzODM2Mjkw","avatar_url":"https://avatars1.githubusercontent.com/u/13836290?v=4","gravatar_id":"","url":"https://api.github.com/users/Wynndow","html_url":"https://github.com/Wynndow","followers_url":"https://api.github.com/users/Wynndow/followers","following_url":"https://api.github.com/users/Wynndow/following{/other_user}","gists_url":"https://api.github.com/users/Wynndow/gists{/gist_id}","starred_url":"https://api.github.com/users/Wynndow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wynndow/subscriptions","organizations_url":"https://api.github.com/users/Wynndow/orgs","repos_url":"https://api.github.com/users/Wynndow/repos","events_url":"https://api.github.com/users/Wynndow/events{/privacy}","received_events_url":"https://api.github.com/users/Wynndow/received_events","type":"User","site_admin":false},"body":"Could it be worth adding a timestamp to this? It's not unfeasible that we'd have two builds in one day?","created_at":"2018-07-19T10:51:50Z","updated_at":"2018-07-19T10:51:51Z","html_url":"https://github.com/alphagov/digitalmarketplace-docker-base/pull/33#discussion_r203683051","pull_request_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/pulls/33","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/pulls/comments/203683051"},"html":{"href":"https://github.com/alphagov/digitalmarketplace-docker-base/pull/33#discussion_r203683051"},"pull_request":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/pulls/33","id":202181862,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMTgxODYy","html_url":"https://github.com/alphagov/digitalmarketplace-docker-base/pull/33","diff_url":"https://github.com/alphagov/digitalmarketplace-docker-base/pull/33.diff","patch_url":"https://github.com/alphagov/digitalmarketplace-docker-base/pull/33.patch","issue_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/issues/33","number":33,"state":"open","locked":false,"title":"Move to rolling versions","user":{"login":"lfdebrux","id":503614,"node_id":"MDQ6VXNlcjUwMzYxNA==","avatar_url":"https://avatars3.githubusercontent.com/u/503614?v=4","gravatar_id":"","url":"https://api.github.com/users/lfdebrux","html_url":"https://github.com/lfdebrux","followers_url":"https://api.github.com/users/lfdebrux/followers","following_url":"https://api.github.com/users/lfdebrux/following{/other_user}","gists_url":"https://api.github.com/users/lfdebrux/gists{/gist_id}","starred_url":"https://api.github.com/users/lfdebrux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfdebrux/subscriptions","organizations_url":"https://api.github.com/users/lfdebrux/orgs","repos_url":"https://api.github.com/users/lfdebrux/repos","events_url":"https://api.github.com/users/lfdebrux/events{/privacy}","received_events_url":"https://api.github.com/users/lfdebrux/received_events","type":"User","site_admin":false},"body":"This PR has two commits, that together form part of a line of work to make maintaining our base Docker images easier.\r\n\r\nThe first change is to move the python image we are based on to `python:3.6-slim-stretch`. Because this no longer pins the minor version, it means we don't have to change our Dockerfile regularly to keep up with the up-to-date images on Docker Hub.\r\n\r\nThe second change is to create an additional tag in our image build process, that includes the date of the build. This should make sure that we retain a modicum of history in our Docker images for tracing/reverting potential breakages.\r\n\r\nBecause the `VERSION` has also been changed in these commits, these changes won't affect apps until they upgrade their base image to `3.3.0`. If we don't want to go full rolling release straight away, we can pin apps to a specific version and build date; however, the vision is that at some point there will be a pipeline for upgrading Docker images for apps separate from changing their Dockerfiles. That's still some way off though.","created_at":"2018-07-18T08:55:30Z","updated_at":"2018-07-19T10:51:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96267f0d45a0652ba7558856b3ea6ca8f5be4283","assignee":null,"assignees":[],"requested_reviewers":[{"login":"risicle","id":807447,"node_id":"MDQ6VXNlcjgwNzQ0Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/807447?v=4","gravatar_id":"","url":"https://api.github.com/users/risicle","html_url":"https://github.com/risicle","followers_url":"https://api.github.com/users/risicle/followers","following_url":"https://api.github.com/users/risicle/following{/other_user}","gists_url":"https://api.github.com/users/risicle/gists{/gist_id}","starred_url":"https://api.github.com/users/risicle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/risicle/subscriptions","organizations_url":"https://api.github.com/users/risicle/orgs","repos_url":"https://api.github.com/users/risicle/repos","events_url":"https://api.github.com/users/risicle/events{/privacy}","received_events_url":"https://api.github.com/users/risicle/received_events","type":"User","site_admin":false},{"login":"benvand","id":3469840,"node_id":"MDQ6VXNlcjM0Njk4NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/3469840?v=4","gravatar_id":"","url":"https://api.github.com/users/benvand","html_url":"https://github.com/benvand","followers_url":"https://api.github.com/users/benvand/followers","following_url":"https://api.github.com/users/benvand/following{/other_user}","gists_url":"https://api.github.com/users/benvand/gists{/gist_id}","starred_url":"https://api.github.com/users/benvand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benvand/subscriptions","organizations_url":"https://api.github.com/users/benvand/orgs","repos_url":"https://api.github.com/users/benvand/repos","events_url":"https://api.github.com/users/benvand/events{/privacy}","received_events_url":"https://api.github.com/users/benvand/received_events","type":"User","site_admin":false},{"login":"louzoid-gds","id":31240444,"node_id":"MDQ6VXNlcjMxMjQwNDQ0","avatar_url":"https://avatars0.githubusercontent.com/u/31240444?v=4","gravatar_id":"","url":"https://api.github.com/users/louzoid-gds","html_url":"https://github.com/louzoid-gds","followers_url":"https://api.github.com/users/louzoid-gds/followers","following_url":"https://api.github.com/users/louzoid-gds/following{/other_user}","gists_url":"https://api.github.com/users/louzoid-gds/gists{/gist_id}","starred_url":"https://api.github.com/users/louzoid-gds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louzoid-gds/subscriptions","organizations_url":"https://api.github.com/users/louzoid-gds/orgs","repos_url":"https://api.github.com/users/louzoid-gds/repos","events_url":"https://api.github.com/users/louzoid-gds/events{/privacy}","received_events_url":"https://api.github.com/users/louzoid-gds/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/pulls/33/commits","review_comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/pulls/33/comments","review_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/issues/33/comments","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/statuses/19c9cb80ee2d6a98a98d3e796b99d5a818ef7b94","head":{"label":"alphagov:ldeb-move-to-rolling-versions","ref":"ldeb-move-to-rolling-versions","sha":"19c9cb80ee2d6a98a98d3e796b99d5a818ef7b94","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":90141445,"node_id":"MDEwOlJlcG9zaXRvcnk5MDE0MTQ0NQ==","name":"digitalmarketplace-docker-base","full_name":"alphagov/digitalmarketplace-docker-base","owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/digitalmarketplace-docker-base","description":"Digital Marketplace base docker images","fork":false,"url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base","forks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/forks","keys_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/teams","hooks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/hooks","issue_events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/events","assignees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/tags","blobs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/languages","stargazers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/stargazers","contributors_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/contributors","subscribers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/subscribers","subscription_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/subscription","commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/merges","archive_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/downloads","issues_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/deployments","created_at":"2017-05-03T11:26:43Z","updated_at":"2018-06-18T15:15:29Z","pushed_at":"2018-07-18T08:55:30Z","git_url":"git://github.com/alphagov/digitalmarketplace-docker-base.git","ssh_url":"git@github.com:alphagov/digitalmarketplace-docker-base.git","clone_url":"https://github.com/alphagov/digitalmarketplace-docker-base.git","svn_url":"https://github.com/alphagov/digitalmarketplace-docker-base","homepage":null,"size":52,"stargazers_count":1,"watchers_count":1,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"f0e7dd6a8c77db87361378268a3ab34bc57c3f18","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":90141445,"node_id":"MDEwOlJlcG9zaXRvcnk5MDE0MTQ0NQ==","name":"digitalmarketplace-docker-base","full_name":"alphagov/digitalmarketplace-docker-base","owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/digitalmarketplace-docker-base","description":"Digital Marketplace base docker images","fork":false,"url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base","forks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/forks","keys_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/teams","hooks_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/hooks","issue_events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/events","assignees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/tags","blobs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/languages","stargazers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/stargazers","contributors_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/contributors","subscribers_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/subscribers","subscription_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/subscription","commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/merges","archive_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/downloads","issues_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/deployments","created_at":"2017-05-03T11:26:43Z","updated_at":"2018-06-18T15:15:29Z","pushed_at":"2018-07-18T08:55:30Z","git_url":"git://github.com/alphagov/digitalmarketplace-docker-base.git","ssh_url":"git@github.com:alphagov/digitalmarketplace-docker-base.git","clone_url":"https://github.com/alphagov/digitalmarketplace-docker-base.git","svn_url":"https://github.com/alphagov/digitalmarketplace-docker-base","homepage":null,"size":52,"stargazers_count":1,"watchers_count":1,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/pulls/33"},"html":{"href":"https://github.com/alphagov/digitalmarketplace-docker-base/pull/33"},"issue":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/issues/33"},"comments":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/digitalmarketplace-docker-base/statuses/19c9cb80ee2d6a98a98d3e796b99d5a818ef7b94"}},"author_association":"NONE"}}
{"actor":{"display_login":"Wynndow"}}