{"action":"created","issue":{"url":"https://api.github.com/repos/HelloZeroNet/ZeroNet/issues/1683","repository_url":"https://api.github.com/repos/HelloZeroNet/ZeroNet","labels_url":"https://api.github.com/repos/HelloZeroNet/ZeroNet/issues/1683/labels{/name}","comments_url":"https://api.github.com/repos/HelloZeroNet/ZeroNet/issues/1683/comments","events_url":"https://api.github.com/repos/HelloZeroNet/ZeroNet/issues/1683/events","html_url":"https://github.com/HelloZeroNet/ZeroNet/pull/1683","id":367426050,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODY2NTI2","number":1683,"title":"Allow using other domain resolver plugins along with Zeroname","user":{"login":"geekless","id":1287690,"node_id":"MDQ6VXNlcjEyODc2OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1287690?v=4","gravatar_id":"","url":"https://api.github.com/users/geekless","html_url":"https://github.com/geekless","followers_url":"https://api.github.com/users/geekless/followers","following_url":"https://api.github.com/users/geekless/following{/other_user}","gists_url":"https://api.github.com/users/geekless/gists{/gist_id}","starred_url":"https://api.github.com/users/geekless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geekless/subscriptions","organizations_url":"https://api.github.com/users/geekless/orgs","repos_url":"https://api.github.com/users/geekless/repos","events_url":"https://api.github.com/users/geekless/events{/privacy}","received_events_url":"https://api.github.com/users/geekless/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-10-06T05:37:31Z","updated_at":"2018-10-08T18:20:31Z","closed_at":"2018-10-08T13:19:44Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/HelloZeroNet/ZeroNet/pulls/1683","html_url":"https://github.com/HelloZeroNet/ZeroNet/pull/1683","diff_url":"https://github.com/HelloZeroNet/ZeroNet/pull/1683.diff","patch_url":"https://github.com/HelloZeroNet/ZeroNet/pull/1683.patch"},"body":"Fixes several closely related bugs in Zeroname Plugin, those prevent correct work of other domain resolvers:\r\n\r\n1. get(), isDomain(): when an address doesn't look like a valid domain, pass control to the next plugin in a chain.\r\n\r\n3. Move the .bit-domain matching logic to a separate method isBitDomain().\r\n\r\n2. get(), need(): use isBitDomain(), not isDomain() to check if domain resolving is needed in order to not interfere with other domain resolvers.\r\n\r\n4. Also rewrite isAddress() to make it look similar to the new implementation of isDomain()."},"comment":{"url":"https://api.github.com/repos/HelloZeroNet/ZeroNet/issues/comments/427932248","html_url":"https://github.com/HelloZeroNet/ZeroNet/pull/1683#issuecomment-427932248","issue_url":"https://api.github.com/repos/HelloZeroNet/ZeroNet/issues/1683","id":427932248,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzkzMjI0OA==","user":{"login":"DaniellMesquita","id":6765277,"node_id":"MDQ6VXNlcjY3NjUyNzc=","avatar_url":"https://avatars2.githubusercontent.com/u/6765277?v=4","gravatar_id":"","url":"https://api.github.com/users/DaniellMesquita","html_url":"https://github.com/DaniellMesquita","followers_url":"https://api.github.com/users/DaniellMesquita/followers","following_url":"https://api.github.com/users/DaniellMesquita/following{/other_user}","gists_url":"https://api.github.com/users/DaniellMesquita/gists{/gist_id}","starred_url":"https://api.github.com/users/DaniellMesquita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaniellMesquita/subscriptions","organizations_url":"https://api.github.com/users/DaniellMesquita/orgs","repos_url":"https://api.github.com/users/DaniellMesquita/repos","events_url":"https://api.github.com/users/DaniellMesquita/events{/privacy}","received_events_url":"https://api.github.com/users/DaniellMesquita/received_events","type":"User","site_admin":false},"created_at":"2018-10-08T18:20:31Z","updated_at":"2018-10-08T18:20:31Z","author_association":"CONTRIBUTOR","body":"Not possible to use kaffie ID, because the names aren't unique"}}
{"actor":{"display_login":"DaniellMesquita"}}