{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/pulls/comments/182809863","pull_request_review_id":113684840,"id":182809863,"diff_hunk":"@@ -1,31 +1,32 @@\n-/*---------------------------------------------------------------------------------------------\r\n- *  Copyright (c) Microsoft Corporation. All rights reserved.\r\n- *  Licensed under the MIT License. See License.txt in the project root for license information.\r\n- *--------------------------------------------------------------------------------------------*/\r\n-\r\n-export const deploymentFileName: string = '.deployment';\r\n-export const deploymentFile: string = `[config]\r\n-SCM_DO_BUILD_DURING_DEPLOYMENT=true`;\r\n-\r\n-export const extensionPrefix: string = 'appService';\r\n-export enum runtimes {\r\n-    node = 'node',\r\n-    php = 'php',\r\n-    dotnetcore = 'dotnetcore',\r\n-    ruby = 'ruby'\r\n-}\r\n-\r\n-export function getIgnoredFoldersForDeployment(runtime: string): string[] | undefined {\r\n-    switch (runtime) {\r\n-        case runtimes.node:\r\n-            return ['node_modules{,/**}'];\r\n-        default:\r\n-            return undefined;\r\n-    }\r\n-}\r\n-\r\n-export enum configurationSettings {\r\n-    zipIgnorePattern = 'zipIgnorePattern',\r\n-    showBuildDuringDeployPrompt = 'showBuildDuringDeployPrompt',\r\n-    showRemoteFiles = 'showRemoteFiles'\r\n-}\r\n+/*---------------------------------------------------------------------------------------------\n+ *  Copyright (c) Microsoft Corporation. All rights reserved.\n+ *  Licensed under the MIT License. See License.txt in the project root for license information.\n+ *--------------------------------------------------------------------------------------------*/","path":"src/constants.ts","position":35,"original_position":35,"commit_id":"4eca12890a87a1a62bc7af3e5752ab403868c277","original_commit_id":"4eca12890a87a1a62bc7af3e5752ab403868c277","user":{"login":"EricJizbaMSFT","id":11282622,"avatar_url":"https://avatars2.githubusercontent.com/u/11282622?v=4","gravatar_id":"","url":"https://api.github.com/users/EricJizbaMSFT","html_url":"https://github.com/EricJizbaMSFT","followers_url":"https://api.github.com/users/EricJizbaMSFT/followers","following_url":"https://api.github.com/users/EricJizbaMSFT/following{/other_user}","gists_url":"https://api.github.com/users/EricJizbaMSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/EricJizbaMSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricJizbaMSFT/subscriptions","organizations_url":"https://api.github.com/users/EricJizbaMSFT/orgs","repos_url":"https://api.github.com/users/EricJizbaMSFT/repos","events_url":"https://api.github.com/users/EricJizbaMSFT/events{/privacy}","received_events_url":"https://api.github.com/users/EricJizbaMSFT/received_events","type":"User","site_admin":false},"body":"Maybe it's the line-endings that's causing the problem? You can check the status bar in VS Code:\r\n![screen shot 2018-04-19 at 9 32 04 am](https://user-images.githubusercontent.com/11282622/39005276-a7ac08f8-43b4-11e8-8099-1f975a248ecc.png)\r\n\r\nLooks like it should be 'CLRF' for this file (we don't have a strict LF vs CLRF rule - it should just remain constant per file after it was created). If yours doesn't say CLRF, you can click that in the status bar and it should prompt you to switch line endings:\r\n![screen shot 2018-04-19 at 9 34 50 am](https://user-images.githubusercontent.com/11282622/39005382-ee6a119a-43b4-11e8-8e0f-3e0cfc00a212.png)\r\n\r\n","created_at":"2018-04-19T16:35:31Z","updated_at":"2018-04-19T16:40:39Z","html_url":"https://github.com/Microsoft/vscode-azureappservice/pull/393#discussion_r182809863","pull_request_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/pulls/393","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-azureappservice/pulls/comments/182809863"},"html":{"href":"https://github.com/Microsoft/vscode-azureappservice/pull/393#discussion_r182809863"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vscode-azureappservice/pulls/393"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/pulls/393","id":180569079,"html_url":"https://github.com/Microsoft/vscode-azureappservice/pull/393","diff_url":"https://github.com/Microsoft/vscode-azureappservice/pull/393.diff","patch_url":"https://github.com/Microsoft/vscode-azureappservice/pull/393.patch","issue_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/issues/393","number":393,"state":"open","locked":false,"title":"Add 'deploySubpath' setting","user":{"login":"sunmorgus","id":2287216,"avatar_url":"https://avatars2.githubusercontent.com/u/2287216?v=4","gravatar_id":"","url":"https://api.github.com/users/sunmorgus","html_url":"https://github.com/sunmorgus","followers_url":"https://api.github.com/users/sunmorgus/followers","following_url":"https://api.github.com/users/sunmorgus/following{/other_user}","gists_url":"https://api.github.com/users/sunmorgus/gists{/gist_id}","starred_url":"https://api.github.com/users/sunmorgus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunmorgus/subscriptions","organizations_url":"https://api.github.com/users/sunmorgus/orgs","repos_url":"https://api.github.com/users/sunmorgus/repos","events_url":"https://api.github.com/users/sunmorgus/events{/privacy}","received_events_url":"https://api.github.com/users/sunmorgus/received_events","type":"User","site_admin":false},"body":"Added 'deploySubpath' setting, related to #389 ","created_at":"2018-04-10T11:20:59Z","updated_at":"2018-04-19T16:40:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"941fcabbf0338ddfc5f6ea5ecf000b7fa7b5bf05","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/pulls/393/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/pulls/393/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/issues/393/comments","statuses_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/statuses/4eca12890a87a1a62bc7af3e5752ab403868c277","head":{"label":"sunmorgus:master","ref":"master","sha":"4eca12890a87a1a62bc7af3e5752ab403868c277","user":{"login":"sunmorgus","id":2287216,"avatar_url":"https://avatars2.githubusercontent.com/u/2287216?v=4","gravatar_id":"","url":"https://api.github.com/users/sunmorgus","html_url":"https://github.com/sunmorgus","followers_url":"https://api.github.com/users/sunmorgus/followers","following_url":"https://api.github.com/users/sunmorgus/following{/other_user}","gists_url":"https://api.github.com/users/sunmorgus/gists{/gist_id}","starred_url":"https://api.github.com/users/sunmorgus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunmorgus/subscriptions","organizations_url":"https://api.github.com/users/sunmorgus/orgs","repos_url":"https://api.github.com/users/sunmorgus/repos","events_url":"https://api.github.com/users/sunmorgus/events{/privacy}","received_events_url":"https://api.github.com/users/sunmorgus/received_events","type":"User","site_admin":false},"repo":{"id":127062960,"name":"vscode-azureappservice","full_name":"sunmorgus/vscode-azureappservice","owner":{"login":"sunmorgus","id":2287216,"avatar_url":"https://avatars2.githubusercontent.com/u/2287216?v=4","gravatar_id":"","url":"https://api.github.com/users/sunmorgus","html_url":"https://github.com/sunmorgus","followers_url":"https://api.github.com/users/sunmorgus/followers","following_url":"https://api.github.com/users/sunmorgus/following{/other_user}","gists_url":"https://api.github.com/users/sunmorgus/gists{/gist_id}","starred_url":"https://api.github.com/users/sunmorgus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunmorgus/subscriptions","organizations_url":"https://api.github.com/users/sunmorgus/orgs","repos_url":"https://api.github.com/users/sunmorgus/repos","events_url":"https://api.github.com/users/sunmorgus/events{/privacy}","received_events_url":"https://api.github.com/users/sunmorgus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sunmorgus/vscode-azureappservice","description":"Azure App Service extension for VS Code","fork":true,"url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice","forks_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/forks","keys_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/teams","hooks_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/hooks","issue_events_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/issues/events{/number}","events_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/events","assignees_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/assignees{/user}","branches_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/branches{/branch}","tags_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/tags","blobs_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/git/refs{/sha}","trees_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/statuses/{sha}","languages_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/languages","stargazers_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/stargazers","contributors_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/contributors","subscribers_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/subscribers","subscription_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/subscription","commits_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/commits{/sha}","git_commits_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/git/commits{/sha}","comments_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/comments{/number}","issue_comment_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/issues/comments{/number}","contents_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/contents/{+path}","compare_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/merges","archive_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/downloads","issues_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/issues{/number}","pulls_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/pulls{/number}","milestones_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/milestones{/number}","notifications_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/labels{/name}","releases_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/releases{/id}","deployments_url":"https://api.github.com/repos/sunmorgus/vscode-azureappservice/deployments","created_at":"2018-03-28T00:49:20Z","updated_at":"2018-04-19T11:26:30Z","pushed_at":"2018-04-19T11:26:28Z","git_url":"git://github.com/sunmorgus/vscode-azureappservice.git","ssh_url":"git@github.com:sunmorgus/vscode-azureappservice.git","clone_url":"https://github.com/sunmorgus/vscode-azureappservice.git","svn_url":"https://github.com/sunmorgus/vscode-azureappservice","homepage":"https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azureappservice","size":1249,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"3b29c7fe7c0c80036df2e84333dd46d4ee9f55df","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":98935458,"name":"vscode-azureappservice","full_name":"Microsoft/vscode-azureappservice","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vscode-azureappservice","description":"Azure App Service extension for VS Code","fork":false,"url":"https://api.github.com/repos/Microsoft/vscode-azureappservice","forks_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-azureappservice/deployments","created_at":"2017-07-31T22:30:17Z","updated_at":"2018-04-17T20:44:56Z","pushed_at":"2018-04-19T11:26:29Z","git_url":"git://github.com/Microsoft/vscode-azureappservice.git","ssh_url":"git@github.com:Microsoft/vscode-azureappservice.git","clone_url":"https://github.com/Microsoft/vscode-azureappservice.git","svn_url":"https://github.com/Microsoft/vscode-azureappservice","homepage":"https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azureappservice","size":1216,"stargazers_count":16,"watchers_count":16,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":9,"open_issues":56,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-azureappservice/pulls/393"},"html":{"href":"https://github.com/Microsoft/vscode-azureappservice/pull/393"},"issue":{"href":"https://api.github.com/repos/Microsoft/vscode-azureappservice/issues/393"},"comments":{"href":"https://api.github.com/repos/Microsoft/vscode-azureappservice/issues/393/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vscode-azureappservice/pulls/393/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vscode-azureappservice/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vscode-azureappservice/pulls/393/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vscode-azureappservice/statuses/4eca12890a87a1a62bc7af3e5752ab403868c277"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"EricJizbaMSFT"}}