{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/13799","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/13799/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/13799/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/13799/events","html_url":"https://github.com/bitcoin/bitcoin/pull/13799","id":345642588,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NzE3MDI4","number":13799,"title":"Ignore unknown config file options; warn instead of error","user":{"login":"sipa","id":548488,"node_id":"MDQ6VXNlcjU0ODQ4OA==","avatar_url":"https://avatars1.githubusercontent.com/u/548488?v=4","gravatar_id":"","url":"https://api.github.com/users/sipa","html_url":"https://github.com/sipa","followers_url":"https://api.github.com/users/sipa/followers","following_url":"https://api.github.com/users/sipa/following{/other_user}","gists_url":"https://api.github.com/users/sipa/gists{/gist_id}","starred_url":"https://api.github.com/users/sipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sipa/subscriptions","organizations_url":"https://api.github.com/users/sipa/orgs","repos_url":"https://api.github.com/users/sipa/repos","events_url":"https://api.github.com/users/sipa/events{/privacy}","received_events_url":"https://api.github.com/users/sipa/received_events","type":"User","site_admin":false},"labels":[{"id":241832923,"node_id":"MDU6TGFiZWwyNDE4MzI5MjM=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Utils/log/libs","name":"Utils/log/libs","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/33","html_url":"https://github.com/bitcoin/bitcoin/milestone/33","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/33/labels","id":2931889,"node_id":"MDk6TWlsZXN0b25lMjkzMTg4OQ==","number":33,"title":"0.17.0","description":"","creator":{"login":"MarcoFalke","id":6399679,"node_id":"MDQ6VXNlcjYzOTk2Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/6399679?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":66,"state":"open","created_at":"2017-11-22T18:54:09Z","updated_at":"2018-07-30T19:46:17Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2018-07-30T07:31:35Z","updated_at":"2018-07-30T20:29:10Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13799","html_url":"https://github.com/bitcoin/bitcoin/pull/13799","diff_url":"https://github.com/bitcoin/bitcoin/pull/13799.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/13799.patch"},"body":"As reported by @satwo on IRC a few days ago, the current mechanism of treating unknown config file options as errors is problematic for options like `-rpcclienttimeout` which aren't defined for `bitcoind`.\r\n\r\nA full solution would be to either make all binaries be aware of each other's options, or to permit config file options that only apply to specific binaries (`bitcoind`, `bitcoin-qt`, `bitcoin-cli`). Both of these seem too invasive to introduce for 0.17.\r\n\r\nAs a compromise, this PR makes it ignores those options, but still warn about it in the log file."},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/408999252","html_url":"https://github.com/bitcoin/bitcoin/pull/13799#issuecomment-408999252","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/13799","id":408999252,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODk5OTI1Mg==","user":{"login":"achow101","id":3782274,"node_id":"MDQ6VXNlcjM3ODIyNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3782274?v=4","gravatar_id":"","url":"https://api.github.com/users/achow101","html_url":"https://github.com/achow101","followers_url":"https://api.github.com/users/achow101/followers","following_url":"https://api.github.com/users/achow101/following{/other_user}","gists_url":"https://api.github.com/users/achow101/gists{/gist_id}","starred_url":"https://api.github.com/users/achow101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achow101/subscriptions","organizations_url":"https://api.github.com/users/achow101/orgs","repos_url":"https://api.github.com/users/achow101/repos","events_url":"https://api.github.com/users/achow101/events{/privacy}","received_events_url":"https://api.github.com/users/achow101/received_events","type":"User","site_admin":false},"created_at":"2018-07-30T20:29:10Z","updated_at":"2018-07-30T20:29:10Z","author_association":"MEMBER","body":"Right now, to get around this problem, we already have a bunch of hidden arguments. I think it would be reasonable, at least for 0.17, to just extend that list to include the bitcoin-cli arguments. Then later we can add more invasive changes to actually fix the problem."}}
{"actor":{"display_login":"achow101"}}