{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments/209303918","pull_request_review_id":145297446,"id":209303918,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTMwMzkxOA==","diff_hunk":"@@ -853,9 +853,9 @@ respective `destinationDir`. If you left `destinationDir` empty, then the\n secrets are placed in the working directory of the builder image.\n \n The same rule is used when a `destinationDir` is a relative path; the secrets\n-are placed in the paths that are relative to the image's working directory. The\n-`destinationDir` must exist or an error will occur. No directory paths are\n-created during the copy process.\n+are placed in the paths that are relative to the image's working directory.\n+The `destinationDir` is created if it does not exist in the builder image.\n+However, the parent directory of `destinationDir` must exist or an error will occur.","path":"dev_guide/builds/build_inputs.adoc","position":9,"original_position":9,"commit_id":"c08dcdd22e716b65c794f8e2ec414fe83bb9c5e9","original_commit_id":"c08dcdd22e716b65c794f8e2ec414fe83bb9c5e9","user":{"login":"bparees","id":4974046,"node_id":"MDQ6VXNlcjQ5NzQwNDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4974046?v=4","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"body":"i still find this phrasing confusing.  \"destinationDir\" is the name of the field, so \"./foo/bar\" is the destinationDir.  The parent dir is whatever \".\" is.\r\n\r\nSince \"foo/bar\" won't be created if they don't exist (only \"foo\" will be created), it sounds like the behavior (for both relative and absolute paths) is:\r\n\r\n\"If the final directory in the destinationDir path does not exist, it will be created.  If any other directory in the destinationDir path does not exist, the build will fail\"\r\n\r\nright?\r\n","created_at":"2018-08-10T15:47:22Z","updated_at":"2018-08-10T15:47:23Z","html_url":"https://github.com/openshift/openshift-docs/pull/11467#discussion_r209303918","pull_request_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/11467","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments/209303918"},"html":{"href":"https://github.com/openshift/openshift-docs/pull/11467#discussion_r209303918"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/11467"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-docs/pulls/11467","id":207353701,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MzUzNzAx","html_url":"https://github.com/openshift/openshift-docs/pull/11467","diff_url":"https://github.com/openshift/openshift-docs/pull/11467.diff","patch_url":"https://github.com/openshift/openshift-docs/pull/11467.patch","issue_url":"https://api.github.com/repos/openshift/openshift-docs/issues/11467","number":11467,"state":"open","locked":false,"title":"Clarify s2i Secrets/ConfigMap Behavior","user":{"login":"adambkaplan","id":1538838,"node_id":"MDQ6VXNlcjE1Mzg4Mzg=","avatar_url":"https://avatars3.githubusercontent.com/u/1538838?v=4","gravatar_id":"","url":"https://api.github.com/users/adambkaplan","html_url":"https://github.com/adambkaplan","followers_url":"https://api.github.com/users/adambkaplan/followers","following_url":"https://api.github.com/users/adambkaplan/following{/other_user}","gists_url":"https://api.github.com/users/adambkaplan/gists{/gist_id}","starred_url":"https://api.github.com/users/adambkaplan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adambkaplan/subscriptions","organizations_url":"https://api.github.com/users/adambkaplan/orgs","repos_url":"https://api.github.com/users/adambkaplan/repos","events_url":"https://api.github.com/users/adambkaplan/events{/privacy}","received_events_url":"https://api.github.com/users/adambkaplan/received_events","type":"User","site_admin":false},"body":"When Secrets and ConfigMaps are added to an s2i build, the `destinationDir` is created if it does not exist.\r\n\r\nBug [1613744](https://bugzilla.redhat.com/show_bug.cgi?id=1613744)","created_at":"2018-08-09T15:20:59Z","updated_at":"2018-08-10T15:47:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5243c3e6cf7d87af84750f864213fd903c7afdac","assignee":{"login":"bmcelvee","id":24275422,"node_id":"MDQ6VXNlcjI0Mjc1NDIy","avatar_url":"https://avatars1.githubusercontent.com/u/24275422?v=4","gravatar_id":"","url":"https://api.github.com/users/bmcelvee","html_url":"https://github.com/bmcelvee","followers_url":"https://api.github.com/users/bmcelvee/followers","following_url":"https://api.github.com/users/bmcelvee/following{/other_user}","gists_url":"https://api.github.com/users/bmcelvee/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcelvee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcelvee/subscriptions","organizations_url":"https://api.github.com/users/bmcelvee/orgs","repos_url":"https://api.github.com/users/bmcelvee/repos","events_url":"https://api.github.com/users/bmcelvee/events{/privacy}","received_events_url":"https://api.github.com/users/bmcelvee/received_events","type":"User","site_admin":false},"assignees":[{"login":"bmcelvee","id":24275422,"node_id":"MDQ6VXNlcjI0Mjc1NDIy","avatar_url":"https://avatars1.githubusercontent.com/u/24275422?v=4","gravatar_id":"","url":"https://api.github.com/users/bmcelvee","html_url":"https://github.com/bmcelvee","followers_url":"https://api.github.com/users/bmcelvee/followers","following_url":"https://api.github.com/users/bmcelvee/following{/other_user}","gists_url":"https://api.github.com/users/bmcelvee/gists{/gist_id}","starred_url":"https://api.github.com/users/bmcelvee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmcelvee/subscriptions","organizations_url":"https://api.github.com/users/bmcelvee/orgs","repos_url":"https://api.github.com/users/bmcelvee/repos","events_url":"https://api.github.com/users/bmcelvee/events{/privacy}","received_events_url":"https://api.github.com/users/bmcelvee/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":752694670,"node_id":"MDU6TGFiZWw3NTI2OTQ2NzA=","url":"https://api.github.com/repos/openshift/openshift-docs/labels/size/XS","name":"size/XS","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/11467/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/11467/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-docs/issues/11467/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-docs/statuses/c08dcdd22e716b65c794f8e2ec414fe83bb9c5e9","head":{"label":"adambkaplan:bugfix/s2i-injection","ref":"bugfix/s2i-injection","sha":"c08dcdd22e716b65c794f8e2ec414fe83bb9c5e9","user":{"login":"adambkaplan","id":1538838,"node_id":"MDQ6VXNlcjE1Mzg4Mzg=","avatar_url":"https://avatars3.githubusercontent.com/u/1538838?v=4","gravatar_id":"","url":"https://api.github.com/users/adambkaplan","html_url":"https://github.com/adambkaplan","followers_url":"https://api.github.com/users/adambkaplan/followers","following_url":"https://api.github.com/users/adambkaplan/following{/other_user}","gists_url":"https://api.github.com/users/adambkaplan/gists{/gist_id}","starred_url":"https://api.github.com/users/adambkaplan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adambkaplan/subscriptions","organizations_url":"https://api.github.com/users/adambkaplan/orgs","repos_url":"https://api.github.com/users/adambkaplan/repos","events_url":"https://api.github.com/users/adambkaplan/events{/privacy}","received_events_url":"https://api.github.com/users/adambkaplan/received_events","type":"User","site_admin":false},"repo":{"id":134888530,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ4ODg1MzA=","name":"openshift-docs","full_name":"adambkaplan/openshift-docs","owner":{"login":"adambkaplan","id":1538838,"node_id":"MDQ6VXNlcjE1Mzg4Mzg=","avatar_url":"https://avatars3.githubusercontent.com/u/1538838?v=4","gravatar_id":"","url":"https://api.github.com/users/adambkaplan","html_url":"https://github.com/adambkaplan","followers_url":"https://api.github.com/users/adambkaplan/followers","following_url":"https://api.github.com/users/adambkaplan/following{/other_user}","gists_url":"https://api.github.com/users/adambkaplan/gists{/gist_id}","starred_url":"https://api.github.com/users/adambkaplan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adambkaplan/subscriptions","organizations_url":"https://api.github.com/users/adambkaplan/orgs","repos_url":"https://api.github.com/users/adambkaplan/repos","events_url":"https://api.github.com/users/adambkaplan/events{/privacy}","received_events_url":"https://api.github.com/users/adambkaplan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adambkaplan/openshift-docs","description":"OpenShift Documentation","fork":true,"url":"https://api.github.com/repos/adambkaplan/openshift-docs","forks_url":"https://api.github.com/repos/adambkaplan/openshift-docs/forks","keys_url":"https://api.github.com/repos/adambkaplan/openshift-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adambkaplan/openshift-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adambkaplan/openshift-docs/teams","hooks_url":"https://api.github.com/repos/adambkaplan/openshift-docs/hooks","issue_events_url":"https://api.github.com/repos/adambkaplan/openshift-docs/issues/events{/number}","events_url":"https://api.github.com/repos/adambkaplan/openshift-docs/events","assignees_url":"https://api.github.com/repos/adambkaplan/openshift-docs/assignees{/user}","branches_url":"https://api.github.com/repos/adambkaplan/openshift-docs/branches{/branch}","tags_url":"https://api.github.com/repos/adambkaplan/openshift-docs/tags","blobs_url":"https://api.github.com/repos/adambkaplan/openshift-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adambkaplan/openshift-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adambkaplan/openshift-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/adambkaplan/openshift-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adambkaplan/openshift-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/adambkaplan/openshift-docs/languages","stargazers_url":"https://api.github.com/repos/adambkaplan/openshift-docs/stargazers","contributors_url":"https://api.github.com/repos/adambkaplan/openshift-docs/contributors","subscribers_url":"https://api.github.com/repos/adambkaplan/openshift-docs/subscribers","subscription_url":"https://api.github.com/repos/adambkaplan/openshift-docs/subscription","commits_url":"https://api.github.com/repos/adambkaplan/openshift-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/adambkaplan/openshift-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/adambkaplan/openshift-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/adambkaplan/openshift-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/adambkaplan/openshift-docs/contents/{+path}","compare_url":"https://api.github.com/repos/adambkaplan/openshift-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adambkaplan/openshift-docs/merges","archive_url":"https://api.github.com/repos/adambkaplan/openshift-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adambkaplan/openshift-docs/downloads","issues_url":"https://api.github.com/repos/adambkaplan/openshift-docs/issues{/number}","pulls_url":"https://api.github.com/repos/adambkaplan/openshift-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/adambkaplan/openshift-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/adambkaplan/openshift-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adambkaplan/openshift-docs/labels{/name}","releases_url":"https://api.github.com/repos/adambkaplan/openshift-docs/releases{/id}","deployments_url":"https://api.github.com/repos/adambkaplan/openshift-docs/deployments","created_at":"2018-05-25T17:56:59Z","updated_at":"2018-08-09T15:12:05Z","pushed_at":"2018-08-10T15:17:52Z","git_url":"git://github.com/adambkaplan/openshift-docs.git","ssh_url":"git@github.com:adambkaplan/openshift-docs.git","clone_url":"https://github.com/adambkaplan/openshift-docs.git","svn_url":"https://github.com/adambkaplan/openshift-docs","homepage":"https://docs.openshift.org/latest/welcome/index.html","size":75518,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"67d2547d140e8f46048d663b172d5a99c4b4b5c2","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":21740844,"node_id":"MDEwOlJlcG9zaXRvcnkyMTc0MDg0NA==","name":"openshift-docs","full_name":"openshift/openshift-docs","owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-docs","description":"OpenShift Documentation","fork":false,"url":"https://api.github.com/repos/openshift/openshift-docs","forks_url":"https://api.github.com/repos/openshift/openshift-docs/forks","keys_url":"https://api.github.com/repos/openshift/openshift-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-docs/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-docs/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-docs/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-docs/events","assignees_url":"https://api.github.com/repos/openshift/openshift-docs/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-docs/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-docs/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-docs/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-docs/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-docs/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-docs/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-docs/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-docs/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-docs/merges","archive_url":"https://api.github.com/repos/openshift/openshift-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-docs/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-docs/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-docs/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-docs/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-docs/deployments","created_at":"2014-07-11T15:14:42Z","updated_at":"2018-08-10T14:44:15Z","pushed_at":"2018-08-10T15:17:54Z","git_url":"git://github.com/openshift/openshift-docs.git","ssh_url":"git@github.com:openshift/openshift-docs.git","clone_url":"https://github.com/openshift/openshift-docs.git","svn_url":"https://github.com/openshift/openshift-docs","homepage":"https://docs.openshift.org/latest/welcome/index.html","size":78794,"stargazers_count":183,"watchers_count":183,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":564,"mirror_url":null,"archived":false,"open_issues_count":149,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":564,"open_issues":149,"watchers":183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/11467"},"html":{"href":"https://github.com/openshift/openshift-docs/pull/11467"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-docs/issues/11467"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-docs/issues/11467/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/11467/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/11467/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-docs/statuses/c08dcdd22e716b65c794f8e2ec414fe83bb9c5e9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bparees"}}