{"action":"opened","number":801,"pull_request":{"url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/pulls/801","id":228439989,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NDM5OTg5","html_url":"https://github.com/watson-developer-cloud/node-sdk/pull/801","diff_url":"https://github.com/watson-developer-cloud/node-sdk/pull/801.diff","patch_url":"https://github.com/watson-developer-cloud/node-sdk/pull/801.patch","issue_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/issues/801","number":801,"state":"open","locked":false,"title":"build: fix travis script, stop testing node 4","user":{"login":"dpopp07","id":9168931,"node_id":"MDQ6VXNlcjkxNjg5MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/9168931?v=4","gravatar_id":"","url":"https://api.github.com/users/dpopp07","html_url":"https://github.com/dpopp07","followers_url":"https://api.github.com/users/dpopp07/followers","following_url":"https://api.github.com/users/dpopp07/following{/other_user}","gists_url":"https://api.github.com/users/dpopp07/gists{/gist_id}","starred_url":"https://api.github.com/users/dpopp07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpopp07/subscriptions","organizations_url":"https://api.github.com/users/dpopp07/orgs","repos_url":"https://api.github.com/users/dpopp07/repos","events_url":"https://api.github.com/users/dpopp07/events{/privacy}","received_events_url":"https://api.github.com/users/dpopp07/received_events","type":"User","site_admin":false},"body":"This PR addresses two things:\r\n\r\n1. The Travis docs state that:\r\n> TRAVIS_PULL_REQUEST is set to the pull request number if the current job is a pull request build, or false if it’s not.\r\nCurrently, we are checking if `TRAVIS_PULL_REQUEST` is `true` and running unit tests if so:\r\n```\r\n- if [ \"${TRAVIS_PULL_REQUEST}\" = \"true\" ]; then npm run test-unit; fi\r\n```\r\nI noticed that this hasn't been working and isn't actually running the unit tests on PR builds. I am guess this is because we are checking for `true` when it should be a number. I changed the script to use `if/else` logic to determine what to do on PR builds.\r\n\r\n2. Regarding my PR for incorporating the new unit tests - `jest` does not run on Node v4.x (most major tools have dropped support for Node v4). Rather than use an older version of `jest` and try to make it work, Mike and Taj suggested deprecating support for Node 4, stopping the Node 4 tests, and warning users that support will be dropped in the next major version.","created_at":"2018-11-05T17:59:30Z","updated_at":"2018-11-05T17:59:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/pulls/801/commits","review_comments_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/pulls/801/comments","review_comment_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/issues/801/comments","statuses_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/statuses/fb755d25d826fde192a23cff0904fa40204c98bd","head":{"label":"watson-developer-cloud:update-travis-script","ref":"update-travis-script","sha":"fb755d25d826fde192a23cff0904fa40204c98bd","user":{"login":"watson-developer-cloud","id":10017763,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDE3NzYz","avatar_url":"https://avatars2.githubusercontent.com/u/10017763?v=4","gravatar_id":"","url":"https://api.github.com/users/watson-developer-cloud","html_url":"https://github.com/watson-developer-cloud","followers_url":"https://api.github.com/users/watson-developer-cloud/followers","following_url":"https://api.github.com/users/watson-developer-cloud/following{/other_user}","gists_url":"https://api.github.com/users/watson-developer-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/watson-developer-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watson-developer-cloud/subscriptions","organizations_url":"https://api.github.com/users/watson-developer-cloud/orgs","repos_url":"https://api.github.com/users/watson-developer-cloud/repos","events_url":"https://api.github.com/users/watson-developer-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/watson-developer-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":27840307,"node_id":"MDEwOlJlcG9zaXRvcnkyNzg0MDMwNw==","name":"node-sdk","full_name":"watson-developer-cloud/node-sdk","private":false,"owner":{"login":"watson-developer-cloud","id":10017763,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDE3NzYz","avatar_url":"https://avatars2.githubusercontent.com/u/10017763?v=4","gravatar_id":"","url":"https://api.github.com/users/watson-developer-cloud","html_url":"https://github.com/watson-developer-cloud","followers_url":"https://api.github.com/users/watson-developer-cloud/followers","following_url":"https://api.github.com/users/watson-developer-cloud/following{/other_user}","gists_url":"https://api.github.com/users/watson-developer-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/watson-developer-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watson-developer-cloud/subscriptions","organizations_url":"https://api.github.com/users/watson-developer-cloud/orgs","repos_url":"https://api.github.com/users/watson-developer-cloud/repos","events_url":"https://api.github.com/users/watson-developer-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/watson-developer-cloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/watson-developer-cloud/node-sdk","description":":comet: Node.js library to access IBM Watson services.","fork":false,"url":"https://api.github.com/repos/watson-developer-cloud/node-sdk","forks_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/forks","keys_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/teams","hooks_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/hooks","issue_events_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/events","assignees_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/tags","blobs_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/languages","stargazers_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/stargazers","contributors_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/contributors","subscribers_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/subscribers","subscription_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/subscription","commits_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/merges","archive_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/downloads","issues_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/labels{/name}","releases_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/deployments","created_at":"2014-12-10T21:20:48Z","updated_at":"2018-11-04T18:24:31Z","pushed_at":"2018-11-05T17:50:58Z","git_url":"git://github.com/watson-developer-cloud/node-sdk.git","ssh_url":"git@github.com:watson-developer-cloud/node-sdk.git","clone_url":"https://github.com/watson-developer-cloud/node-sdk.git","svn_url":"https://github.com/watson-developer-cloud/node-sdk","homepage":"https://www.npmjs.com/package/watson-developer-cloud","size":135539,"stargazers_count":1140,"watchers_count":1140,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":569,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":569,"open_issues":14,"watchers":1140,"default_branch":"master"}},"base":{"label":"watson-developer-cloud:master","ref":"master","sha":"2668ad1f942ef18f6885501c42adb89f3e0ef71c","user":{"login":"watson-developer-cloud","id":10017763,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDE3NzYz","avatar_url":"https://avatars2.githubusercontent.com/u/10017763?v=4","gravatar_id":"","url":"https://api.github.com/users/watson-developer-cloud","html_url":"https://github.com/watson-developer-cloud","followers_url":"https://api.github.com/users/watson-developer-cloud/followers","following_url":"https://api.github.com/users/watson-developer-cloud/following{/other_user}","gists_url":"https://api.github.com/users/watson-developer-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/watson-developer-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watson-developer-cloud/subscriptions","organizations_url":"https://api.github.com/users/watson-developer-cloud/orgs","repos_url":"https://api.github.com/users/watson-developer-cloud/repos","events_url":"https://api.github.com/users/watson-developer-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/watson-developer-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":27840307,"node_id":"MDEwOlJlcG9zaXRvcnkyNzg0MDMwNw==","name":"node-sdk","full_name":"watson-developer-cloud/node-sdk","private":false,"owner":{"login":"watson-developer-cloud","id":10017763,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDE3NzYz","avatar_url":"https://avatars2.githubusercontent.com/u/10017763?v=4","gravatar_id":"","url":"https://api.github.com/users/watson-developer-cloud","html_url":"https://github.com/watson-developer-cloud","followers_url":"https://api.github.com/users/watson-developer-cloud/followers","following_url":"https://api.github.com/users/watson-developer-cloud/following{/other_user}","gists_url":"https://api.github.com/users/watson-developer-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/watson-developer-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watson-developer-cloud/subscriptions","organizations_url":"https://api.github.com/users/watson-developer-cloud/orgs","repos_url":"https://api.github.com/users/watson-developer-cloud/repos","events_url":"https://api.github.com/users/watson-developer-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/watson-developer-cloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/watson-developer-cloud/node-sdk","description":":comet: Node.js library to access IBM Watson services.","fork":false,"url":"https://api.github.com/repos/watson-developer-cloud/node-sdk","forks_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/forks","keys_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/teams","hooks_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/hooks","issue_events_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/events","assignees_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/tags","blobs_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/languages","stargazers_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/stargazers","contributors_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/contributors","subscribers_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/subscribers","subscription_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/subscription","commits_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/merges","archive_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/downloads","issues_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/labels{/name}","releases_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/watson-developer-cloud/node-sdk/deployments","created_at":"2014-12-10T21:20:48Z","updated_at":"2018-11-04T18:24:31Z","pushed_at":"2018-11-05T17:50:58Z","git_url":"git://github.com/watson-developer-cloud/node-sdk.git","ssh_url":"git@github.com:watson-developer-cloud/node-sdk.git","clone_url":"https://github.com/watson-developer-cloud/node-sdk.git","svn_url":"https://github.com/watson-developer-cloud/node-sdk","homepage":"https://www.npmjs.com/package/watson-developer-cloud","size":135539,"stargazers_count":1140,"watchers_count":1140,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":569,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":569,"open_issues":14,"watchers":1140,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/watson-developer-cloud/node-sdk/pulls/801"},"html":{"href":"https://github.com/watson-developer-cloud/node-sdk/pull/801"},"issue":{"href":"https://api.github.com/repos/watson-developer-cloud/node-sdk/issues/801"},"comments":{"href":"https://api.github.com/repos/watson-developer-cloud/node-sdk/issues/801/comments"},"review_comments":{"href":"https://api.github.com/repos/watson-developer-cloud/node-sdk/pulls/801/comments"},"review_comment":{"href":"https://api.github.com/repos/watson-developer-cloud/node-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/watson-developer-cloud/node-sdk/pulls/801/commits"},"statuses":{"href":"https://api.github.com/repos/watson-developer-cloud/node-sdk/statuses/fb755d25d826fde192a23cff0904fa40204c98bd"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":11,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"dpopp07"}}