{"action":"created","comment":{"url":"https://api.github.com/repos/ergoplatform/ergo/pulls/comments/242575089","pull_request_review_id":186117148,"id":242575089,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjU3NTA4OQ==","diff_hunk":"@@ -4,21 +4,29 @@ import akka.actor.{ActorRef, ActorRefFactory}\n import akka.http.scaladsl.server.Route\n import akka.pattern.ask\n import io.circe.syntax._\n-import org.ergoplatform.local.ErgoStatsCollector.{GetNodeInfo, NodeInfo}\n+import org.ergoplatform.local.ErgoStatsCollector.{GetNodeInfo, GetParameters, NodeInfo}\n+import org.ergoplatform.settings.Parameters\n import scorex.core.api.http.ApiResponse\n import scorex.core.settings.RESTApiSettings\n import scorex.core.utils.NetworkTimeProvider\n \n+import org.ergoplatform.settings.ParametersSerializer.jsonEncoder\n+\n case class InfoRoute(statsCollector: ActorRef,\n                      settings: RESTApiSettings,\n                      timeProvider: NetworkTimeProvider)\n                     (implicit val context: ActorRefFactory) extends ErgoBaseApiRoute {\n   override val route: Route = withCors {\n-    info\n+    info ~ params","path":"src/main/scala/org/ergoplatform/api/InfoRoute.scala","position":null,"original_position":19,"commit_id":"69b1a6c9fabd4e580da686d6651a78735e93d6bb","original_commit_id":"74b2116619eea75e057a83bb5cca74859b1b75e8","user":{"login":"kushti","id":1972441,"node_id":"MDQ6VXNlcjE5NzI0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1972441?v=4","gravatar_id":"","url":"https://api.github.com/users/kushti","html_url":"https://github.com/kushti","followers_url":"https://api.github.com/users/kushti/followers","following_url":"https://api.github.com/users/kushti/following{/other_user}","gists_url":"https://api.github.com/users/kushti/gists{/gist_id}","starred_url":"https://api.github.com/users/kushti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kushti/subscriptions","organizations_url":"https://api.github.com/users/kushti/orgs","repos_url":"https://api.github.com/users/kushti/repos","events_url":"https://api.github.com/users/kushti/events{/privacy}","received_events_url":"https://api.github.com/users/kushti/received_events","type":"User","site_admin":false},"body":"Fixed somehow: now parameters are under /info resulting object. ","created_at":"2018-12-18T15:11:56Z","updated_at":"2018-12-18T15:11:57Z","html_url":"https://github.com/ergoplatform/ergo/pull/540#discussion_r242575089","pull_request_url":"https://api.github.com/repos/ergoplatform/ergo/pulls/540","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ergoplatform/ergo/pulls/comments/242575089"},"html":{"href":"https://github.com/ergoplatform/ergo/pull/540#discussion_r242575089"},"pull_request":{"href":"https://api.github.com/repos/ergoplatform/ergo/pulls/540"}},"in_reply_to_id":236691377},"pull_request":{"url":"https://api.github.com/repos/ergoplatform/ergo/pulls/540","id":228663050,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NjYzMDUw","html_url":"https://github.com/ergoplatform/ergo/pull/540","diff_url":"https://github.com/ergoplatform/ergo/pull/540.diff","patch_url":"https://github.com/ergoplatform/ergo/pull/540.patch","issue_url":"https://api.github.com/repos/ergoplatform/ergo/issues/540","number":540,"state":"open","locked":false,"title":"Voting system","user":{"login":"kushti","id":1972441,"node_id":"MDQ6VXNlcjE5NzI0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1972441?v=4","gravatar_id":"","url":"https://api.github.com/users/kushti","html_url":"https://github.com/kushti","followers_url":"https://api.github.com/users/kushti/followers","following_url":"https://api.github.com/users/kushti/following{/other_user}","gists_url":"https://api.github.com/users/kushti/gists{/gist_id}","starred_url":"https://api.github.com/users/kushti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kushti/subscriptions","organizations_url":"https://api.github.com/users/kushti/orgs","repos_url":"https://api.github.com/users/kushti/repos","events_url":"https://api.github.com/users/kushti/events{/privacy}","received_events_url":"https://api.github.com/users/kushti/received_events","type":"User","site_admin":false},"body":"Many parameters can be changed on-the-fly via miners voting, namely instruction costs, computational cost limit per block,\r\nblock size limit, storage fee factor, block version, and so on. Voting for the block version~(so for a soft-fork)\r\nlasts for 32 epochs~(see epoch length below), and requires 90 percent of the miners to vote for the change.\r\nFor less critical changes~(such as block size limit), simple majority is enough. We will further refer to the changes\r\nof the first kind as to foundational changes, we call the changes of the second kind as to everyday changes.\r\nPer block, a miner can vote for two everyday changes and also one foundational change.\r\n","created_at":"2018-11-06T11:43:10Z","updated_at":"2018-12-18T15:11:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08ed7131c2eea6c7b8c44fb57e053a1fb4011b8f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":721365848,"node_id":"MDU6TGFiZWw3MjEzNjU4NDg=","url":"https://api.github.com/repos/ergoplatform/ergo/labels/ready%20for%20merge","name":"ready for merge","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ergoplatform/ergo/pulls/540/commits","review_comments_url":"https://api.github.com/repos/ergoplatform/ergo/pulls/540/comments","review_comment_url":"https://api.github.com/repos/ergoplatform/ergo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ergoplatform/ergo/issues/540/comments","statuses_url":"https://api.github.com/repos/ergoplatform/ergo/statuses/69b1a6c9fabd4e580da686d6651a78735e93d6bb","head":{"label":"ergoplatform:voting","ref":"voting","sha":"69b1a6c9fabd4e580da686d6651a78735e93d6bb","user":{"login":"ergoplatform","id":27490654,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NDkwNjU0","avatar_url":"https://avatars0.githubusercontent.com/u/27490654?v=4","gravatar_id":"","url":"https://api.github.com/users/ergoplatform","html_url":"https://github.com/ergoplatform","followers_url":"https://api.github.com/users/ergoplatform/followers","following_url":"https://api.github.com/users/ergoplatform/following{/other_user}","gists_url":"https://api.github.com/users/ergoplatform/gists{/gist_id}","starred_url":"https://api.github.com/users/ergoplatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ergoplatform/subscriptions","organizations_url":"https://api.github.com/users/ergoplatform/orgs","repos_url":"https://api.github.com/users/ergoplatform/repos","events_url":"https://api.github.com/users/ergoplatform/events{/privacy}","received_events_url":"https://api.github.com/users/ergoplatform/received_events","type":"Organization","site_admin":false},"repo":{"id":94215475,"node_id":"MDEwOlJlcG9zaXRvcnk5NDIxNTQ3NQ==","name":"ergo","full_name":"ergoplatform/ergo","private":false,"owner":{"login":"ergoplatform","id":27490654,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NDkwNjU0","avatar_url":"https://avatars0.githubusercontent.com/u/27490654?v=4","gravatar_id":"","url":"https://api.github.com/users/ergoplatform","html_url":"https://github.com/ergoplatform","followers_url":"https://api.github.com/users/ergoplatform/followers","following_url":"https://api.github.com/users/ergoplatform/following{/other_user}","gists_url":"https://api.github.com/users/ergoplatform/gists{/gist_id}","starred_url":"https://api.github.com/users/ergoplatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ergoplatform/subscriptions","organizations_url":"https://api.github.com/users/ergoplatform/orgs","repos_url":"https://api.github.com/users/ergoplatform/repos","events_url":"https://api.github.com/users/ergoplatform/events{/privacy}","received_events_url":"https://api.github.com/users/ergoplatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ergoplatform/ergo","description":"Ergo protocol description & reference implementation","fork":false,"url":"https://api.github.com/repos/ergoplatform/ergo","forks_url":"https://api.github.com/repos/ergoplatform/ergo/forks","keys_url":"https://api.github.com/repos/ergoplatform/ergo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ergoplatform/ergo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ergoplatform/ergo/teams","hooks_url":"https://api.github.com/repos/ergoplatform/ergo/hooks","issue_events_url":"https://api.github.com/repos/ergoplatform/ergo/issues/events{/number}","events_url":"https://api.github.com/repos/ergoplatform/ergo/events","assignees_url":"https://api.github.com/repos/ergoplatform/ergo/assignees{/user}","branches_url":"https://api.github.com/repos/ergoplatform/ergo/branches{/branch}","tags_url":"https://api.github.com/repos/ergoplatform/ergo/tags","blobs_url":"https://api.github.com/repos/ergoplatform/ergo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ergoplatform/ergo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ergoplatform/ergo/git/refs{/sha}","trees_url":"https://api.github.com/repos/ergoplatform/ergo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ergoplatform/ergo/statuses/{sha}","languages_url":"https://api.github.com/repos/ergoplatform/ergo/languages","stargazers_url":"https://api.github.com/repos/ergoplatform/ergo/stargazers","contributors_url":"https://api.github.com/repos/ergoplatform/ergo/contributors","subscribers_url":"https://api.github.com/repos/ergoplatform/ergo/subscribers","subscription_url":"https://api.github.com/repos/ergoplatform/ergo/subscription","commits_url":"https://api.github.com/repos/ergoplatform/ergo/commits{/sha}","git_commits_url":"https://api.github.com/repos/ergoplatform/ergo/git/commits{/sha}","comments_url":"https://api.github.com/repos/ergoplatform/ergo/comments{/number}","issue_comment_url":"https://api.github.com/repos/ergoplatform/ergo/issues/comments{/number}","contents_url":"https://api.github.com/repos/ergoplatform/ergo/contents/{+path}","compare_url":"https://api.github.com/repos/ergoplatform/ergo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ergoplatform/ergo/merges","archive_url":"https://api.github.com/repos/ergoplatform/ergo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ergoplatform/ergo/downloads","issues_url":"https://api.github.com/repos/ergoplatform/ergo/issues{/number}","pulls_url":"https://api.github.com/repos/ergoplatform/ergo/pulls{/number}","milestones_url":"https://api.github.com/repos/ergoplatform/ergo/milestones{/number}","notifications_url":"https://api.github.com/repos/ergoplatform/ergo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ergoplatform/ergo/labels{/name}","releases_url":"https://api.github.com/repos/ergoplatform/ergo/releases{/id}","deployments_url":"https://api.github.com/repos/ergoplatform/ergo/deployments","created_at":"2017-06-13T13:23:11Z","updated_at":"2018-12-18T08:58:37Z","pushed_at":"2018-12-18T15:10:20Z","git_url":"git://github.com/ergoplatform/ergo.git","ssh_url":"git@github.com:ergoplatform/ergo.git","clone_url":"https://github.com/ergoplatform/ergo.git","svn_url":"https://github.com/ergoplatform/ergo","homepage":"https://ergoplatform.org/","size":32065,"stargazers_count":59,"watchers_count":59,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":22,"open_issues":56,"watchers":59,"default_branch":"master"}},"base":{"label":"ergoplatform:v2.0","ref":"v2.0","sha":"cd22a12838e940eabeb6a7d89f2df8da4d1e4449","user":{"login":"ergoplatform","id":27490654,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NDkwNjU0","avatar_url":"https://avatars0.githubusercontent.com/u/27490654?v=4","gravatar_id":"","url":"https://api.github.com/users/ergoplatform","html_url":"https://github.com/ergoplatform","followers_url":"https://api.github.com/users/ergoplatform/followers","following_url":"https://api.github.com/users/ergoplatform/following{/other_user}","gists_url":"https://api.github.com/users/ergoplatform/gists{/gist_id}","starred_url":"https://api.github.com/users/ergoplatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ergoplatform/subscriptions","organizations_url":"https://api.github.com/users/ergoplatform/orgs","repos_url":"https://api.github.com/users/ergoplatform/repos","events_url":"https://api.github.com/users/ergoplatform/events{/privacy}","received_events_url":"https://api.github.com/users/ergoplatform/received_events","type":"Organization","site_admin":false},"repo":{"id":94215475,"node_id":"MDEwOlJlcG9zaXRvcnk5NDIxNTQ3NQ==","name":"ergo","full_name":"ergoplatform/ergo","private":false,"owner":{"login":"ergoplatform","id":27490654,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NDkwNjU0","avatar_url":"https://avatars0.githubusercontent.com/u/27490654?v=4","gravatar_id":"","url":"https://api.github.com/users/ergoplatform","html_url":"https://github.com/ergoplatform","followers_url":"https://api.github.com/users/ergoplatform/followers","following_url":"https://api.github.com/users/ergoplatform/following{/other_user}","gists_url":"https://api.github.com/users/ergoplatform/gists{/gist_id}","starred_url":"https://api.github.com/users/ergoplatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ergoplatform/subscriptions","organizations_url":"https://api.github.com/users/ergoplatform/orgs","repos_url":"https://api.github.com/users/ergoplatform/repos","events_url":"https://api.github.com/users/ergoplatform/events{/privacy}","received_events_url":"https://api.github.com/users/ergoplatform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ergoplatform/ergo","description":"Ergo protocol description & reference implementation","fork":false,"url":"https://api.github.com/repos/ergoplatform/ergo","forks_url":"https://api.github.com/repos/ergoplatform/ergo/forks","keys_url":"https://api.github.com/repos/ergoplatform/ergo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ergoplatform/ergo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ergoplatform/ergo/teams","hooks_url":"https://api.github.com/repos/ergoplatform/ergo/hooks","issue_events_url":"https://api.github.com/repos/ergoplatform/ergo/issues/events{/number}","events_url":"https://api.github.com/repos/ergoplatform/ergo/events","assignees_url":"https://api.github.com/repos/ergoplatform/ergo/assignees{/user}","branches_url":"https://api.github.com/repos/ergoplatform/ergo/branches{/branch}","tags_url":"https://api.github.com/repos/ergoplatform/ergo/tags","blobs_url":"https://api.github.com/repos/ergoplatform/ergo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ergoplatform/ergo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ergoplatform/ergo/git/refs{/sha}","trees_url":"https://api.github.com/repos/ergoplatform/ergo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ergoplatform/ergo/statuses/{sha}","languages_url":"https://api.github.com/repos/ergoplatform/ergo/languages","stargazers_url":"https://api.github.com/repos/ergoplatform/ergo/stargazers","contributors_url":"https://api.github.com/repos/ergoplatform/ergo/contributors","subscribers_url":"https://api.github.com/repos/ergoplatform/ergo/subscribers","subscription_url":"https://api.github.com/repos/ergoplatform/ergo/subscription","commits_url":"https://api.github.com/repos/ergoplatform/ergo/commits{/sha}","git_commits_url":"https://api.github.com/repos/ergoplatform/ergo/git/commits{/sha}","comments_url":"https://api.github.com/repos/ergoplatform/ergo/comments{/number}","issue_comment_url":"https://api.github.com/repos/ergoplatform/ergo/issues/comments{/number}","contents_url":"https://api.github.com/repos/ergoplatform/ergo/contents/{+path}","compare_url":"https://api.github.com/repos/ergoplatform/ergo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ergoplatform/ergo/merges","archive_url":"https://api.github.com/repos/ergoplatform/ergo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ergoplatform/ergo/downloads","issues_url":"https://api.github.com/repos/ergoplatform/ergo/issues{/number}","pulls_url":"https://api.github.com/repos/ergoplatform/ergo/pulls{/number}","milestones_url":"https://api.github.com/repos/ergoplatform/ergo/milestones{/number}","notifications_url":"https://api.github.com/repos/ergoplatform/ergo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ergoplatform/ergo/labels{/name}","releases_url":"https://api.github.com/repos/ergoplatform/ergo/releases{/id}","deployments_url":"https://api.github.com/repos/ergoplatform/ergo/deployments","created_at":"2017-06-13T13:23:11Z","updated_at":"2018-12-18T08:58:37Z","pushed_at":"2018-12-18T15:10:20Z","git_url":"git://github.com/ergoplatform/ergo.git","ssh_url":"git@github.com:ergoplatform/ergo.git","clone_url":"https://github.com/ergoplatform/ergo.git","svn_url":"https://github.com/ergoplatform/ergo","homepage":"https://ergoplatform.org/","size":32065,"stargazers_count":59,"watchers_count":59,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":22,"open_issues":56,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ergoplatform/ergo/pulls/540"},"html":{"href":"https://github.com/ergoplatform/ergo/pull/540"},"issue":{"href":"https://api.github.com/repos/ergoplatform/ergo/issues/540"},"comments":{"href":"https://api.github.com/repos/ergoplatform/ergo/issues/540/comments"},"review_comments":{"href":"https://api.github.com/repos/ergoplatform/ergo/pulls/540/comments"},"review_comment":{"href":"https://api.github.com/repos/ergoplatform/ergo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ergoplatform/ergo/pulls/540/commits"},"statuses":{"href":"https://api.github.com/repos/ergoplatform/ergo/statuses/69b1a6c9fabd4e580da686d6651a78735e93d6bb"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kushti"}}