{"action":"created","issue":{"url":"https://api.github.com/repos/qbotics/Rpolyhedra/issues/21","repository_url":"https://api.github.com/repos/qbotics/Rpolyhedra","labels_url":"https://api.github.com/repos/qbotics/Rpolyhedra/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/qbotics/Rpolyhedra/issues/21/comments","events_url":"https://api.github.com/repos/qbotics/Rpolyhedra/issues/21/events","html_url":"https://github.com/qbotics/Rpolyhedra/issues/21","id":361133235,"node_id":"MDU6SXNzdWUzNjExMzMyMzU=","number":21,"title":"Test failures due to changes in R6","user":{"login":"wch","id":86978,"node_id":"MDQ6VXNlcjg2OTc4","avatar_url":"https://avatars3.githubusercontent.com/u/86978?v=4","gravatar_id":"","url":"https://api.github.com/users/wch","html_url":"https://github.com/wch","followers_url":"https://api.github.com/users/wch/followers","following_url":"https://api.github.com/users/wch/following{/other_user}","gists_url":"https://api.github.com/users/wch/gists{/gist_id}","starred_url":"https://api.github.com/users/wch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wch/subscriptions","organizations_url":"https://api.github.com/users/wch/orgs","repos_url":"https://api.github.com/users/wch/repos","events_url":"https://api.github.com/users/wch/events{/privacy}","received_events_url":"https://api.github.com/users/wch/received_events","type":"User","site_admin":false},"labels":[{"id":1061061479,"node_id":"MDU6TGFiZWwxMDYxMDYxNDc5","url":"https://api.github.com/repos/qbotics/Rpolyhedra/labels/R6","name":"R6","color":"142172","default":false},{"id":695942916,"node_id":"MDU6TGFiZWw2OTU5NDI5MTY=","url":"https://api.github.com/repos/qbotics/Rpolyhedra/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":{"login":"kenarab","id":2932950,"node_id":"MDQ6VXNlcjI5MzI5NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/2932950?v=4","gravatar_id":"","url":"https://api.github.com/users/kenarab","html_url":"https://github.com/kenarab","followers_url":"https://api.github.com/users/kenarab/followers","following_url":"https://api.github.com/users/kenarab/following{/other_user}","gists_url":"https://api.github.com/users/kenarab/gists{/gist_id}","starred_url":"https://api.github.com/users/kenarab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenarab/subscriptions","organizations_url":"https://api.github.com/users/kenarab/orgs","repos_url":"https://api.github.com/users/kenarab/repos","events_url":"https://api.github.com/users/kenarab/events{/privacy}","received_events_url":"https://api.github.com/users/kenarab/received_events","type":"User","site_admin":false},"assignees":[{"login":"kenarab","id":2932950,"node_id":"MDQ6VXNlcjI5MzI5NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/2932950?v=4","gravatar_id":"","url":"https://api.github.com/users/kenarab","html_url":"https://github.com/kenarab","followers_url":"https://api.github.com/users/kenarab/followers","following_url":"https://api.github.com/users/kenarab/following{/other_user}","gists_url":"https://api.github.com/users/kenarab/gists{/gist_id}","starred_url":"https://api.github.com/users/kenarab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenarab/subscriptions","organizations_url":"https://api.github.com/users/kenarab/orgs","repos_url":"https://api.github.com/users/kenarab/repos","events_url":"https://api.github.com/users/kenarab/events{/privacy}","received_events_url":"https://api.github.com/users/kenarab/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/qbotics/Rpolyhedra/milestones/4","html_url":"https://github.com/qbotics/Rpolyhedra/milestone/4","labels_url":"https://api.github.com/repos/qbotics/Rpolyhedra/milestones/4/labels","id":3256695,"node_id":"MDk6TWlsZXN0b25lMzI1NjY5NQ==","number":4,"title":"v0.2.7","description":"It will include Ropensci complaint suggestions","creator":{"login":"kenarab","id":2932950,"node_id":"MDQ6VXNlcjI5MzI5NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/2932950?v=4","gravatar_id":"","url":"https://api.github.com/users/kenarab","html_url":"https://github.com/kenarab","followers_url":"https://api.github.com/users/kenarab/followers","following_url":"https://api.github.com/users/kenarab/following{/other_user}","gists_url":"https://api.github.com/users/kenarab/gists{/gist_id}","starred_url":"https://api.github.com/users/kenarab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenarab/subscriptions","organizations_url":"https://api.github.com/users/kenarab/orgs","repos_url":"https://api.github.com/users/kenarab/repos","events_url":"https://api.github.com/users/kenarab/events{/privacy}","received_events_url":"https://api.github.com/users/kenarab/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":2,"state":"open","created_at":"2018-04-10T17:49:01Z","updated_at":"2018-10-01T23:27:56Z","due_on":"2018-09-20T07:00:00Z","closed_at":null},"comments":5,"created_at":"2018-09-18T04:41:18Z","updated_at":"2018-10-03T21:15:18Z","closed_at":null,"author_association":"NONE","body":"In [this code](https://github.com/qbotics/Rpolyhedra/blob/19a80f920fcc511e8d37811ad1827796de722ae9/R/db-lib.R#L586), the test compares a newly-created object with one that was saved previously. I don't know for sure, but it looks like the previously-saved objects are stored in an .rds file that is distributed with the package. When tested using the development version of R6, the test fails, because of some bug fixes to R6 which changed some internal code.\r\n\r\nThe failures look like this:\r\n\r\n```\r\n── 1. Failure: Scrape test rpolyhedra 5 regular solids (@test_rpolyhedra_lib.R#9\r\n`scraped.polyhedron` not equal to `expected.polyhedron`.\r\nComponent \"clone\": target, current do not match when deparsed\r\nComponent \"state\": Component \".__enclos_env__\": Component \"super\": Component \"clone\": target, current do not match when deparsed\r\nComponent \"state\": Component \"clone\": target, current do not match when deparsed\r\n\r\n── 2. Failure: Scrape test rpolyhedra 5 regular solids (@test_rpolyhedra_lib.R#9\r\n`scraped.polyhedron` not equal to `expected.polyhedron`.\r\nComponent \"clone\": target, current do not match when deparsed\r\nComponent \"state\": Component \".__enclos_env__\": Component \"super\": Component \"clone\": target, current do not match when deparsed\r\nComponent \"state\": Component \"clone\": target, current do not match when deparsed\r\n```\r\n\r\nThe problem is that `expect.equal` is too specific -- these tests will not pass if the version of R6 used to build the database of saved objects is different from the version of R6 that is used when running the tests. I strongly suggest not saving R6 objects and distributing them with the package. In general, it is not very safe to save environments and functions (which is what an R6 object essentially is) in an RDS file on one machine, and then load that RDS file on another machine. The version of R could be different, the version of R6 could be different, and so on.\r\n\r\nIn short, the tests fail if code in the R6 package changes. Please fix the test; I plan to submit R6 to CRAN in the next week or so.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/qbotics/Rpolyhedra/issues/comments/426806312","html_url":"https://github.com/qbotics/Rpolyhedra/issues/21#issuecomment-426806312","issue_url":"https://api.github.com/repos/qbotics/Rpolyhedra/issues/21","id":426806312,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjgwNjMxMg==","user":{"login":"kenarab","id":2932950,"node_id":"MDQ6VXNlcjI5MzI5NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/2932950?v=4","gravatar_id":"","url":"https://api.github.com/users/kenarab","html_url":"https://github.com/kenarab","followers_url":"https://api.github.com/users/kenarab/followers","following_url":"https://api.github.com/users/kenarab/following{/other_user}","gists_url":"https://api.github.com/users/kenarab/gists{/gist_id}","starred_url":"https://api.github.com/users/kenarab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenarab/subscriptions","organizations_url":"https://api.github.com/users/kenarab/orgs","repos_url":"https://api.github.com/users/kenarab/repos","events_url":"https://api.github.com/users/kenarab/events{/privacy}","received_events_url":"https://api.github.com/users/kenarab/received_events","type":"User","site_admin":false},"created_at":"2018-10-03T21:15:18Z","updated_at":"2018-10-03T21:15:18Z","author_association":"CONTRIBUTOR","body":"@wch. Rpolyhedra is already in CRAN from yesterday.\r\n\r\nThank you."}}
{"actor":{"display_login":"kenarab"}}