{"action":"created","comment":{"url":"https://api.github.com/repos/matrix-org/matrix-doc/pulls/comments/204745066","pull_request_review_id":139877272,"id":204745066,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDc0NTA2Ng==","diff_hunk":"@@ -0,0 +1,35 @@\n+# Copyright 2018 New Vector Ltd\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+#     http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+type: object\n+title: Transaction\n+description: Transaction\n+example:\n+  $ref: \"../examples/transaction.json\"\n+properties:\n+  origin:\n+    type: string\n+    description: |-\n+      The ``server_name`` of hoemserver sending this transaction","path":"api/server-server/definitions/transaction.yaml","position":23,"original_position":23,"commit_id":"569a83b37bd437e0949a7ed666216f26157dd039","original_commit_id":"2baf37074d481268d35046f0317e4606a73643a7","user":{"login":"anoadragon453","id":1342360,"node_id":"MDQ6VXNlcjEzNDIzNjA=","avatar_url":"https://avatars1.githubusercontent.com/u/1342360?v=4","gravatar_id":"","url":"https://api.github.com/users/anoadragon453","html_url":"https://github.com/anoadragon453","followers_url":"https://api.github.com/users/anoadragon453/followers","following_url":"https://api.github.com/users/anoadragon453/following{/other_user}","gists_url":"https://api.github.com/users/anoadragon453/gists{/gist_id}","starred_url":"https://api.github.com/users/anoadragon453/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anoadragon453/subscriptions","organizations_url":"https://api.github.com/users/anoadragon453/orgs","repos_url":"https://api.github.com/users/anoadragon453/repos","events_url":"https://api.github.com/users/anoadragon453/events{/privacy}","received_events_url":"https://api.github.com/users/anoadragon453/received_events","type":"User","site_admin":false},"body":"Mentioned in other PR","created_at":"2018-07-24T13:01:37Z","updated_at":"2018-07-24T13:01:38Z","html_url":"https://github.com/matrix-org/matrix-doc/pull/1413#discussion_r204745066","pull_request_url":"https://api.github.com/repos/matrix-org/matrix-doc/pulls/1413","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/matrix-org/matrix-doc/pulls/comments/204745066"},"html":{"href":"https://github.com/matrix-org/matrix-doc/pull/1413#discussion_r204745066"},"pull_request":{"href":"https://api.github.com/repos/matrix-org/matrix-doc/pulls/1413"}},"in_reply_to_id":202637827},"pull_request":{"url":"https://api.github.com/repos/matrix-org/matrix-doc/pulls/1413","id":201183799,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMTgzNzk5","html_url":"https://github.com/matrix-org/matrix-doc/pull/1413","diff_url":"https://github.com/matrix-org/matrix-doc/pull/1413.diff","patch_url":"https://github.com/matrix-org/matrix-doc/pull/1413.patch","issue_url":"https://api.github.com/repos/matrix-org/matrix-doc/issues/1413","number":1413,"state":"open","locked":false,"title":"Convert joins/invites to swagger","user":{"login":"turt2live","id":1190097,"node_id":"MDQ6VXNlcjExOTAwOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1190097?v=4","gravatar_id":"","url":"https://api.github.com/users/turt2live","html_url":"https://github.com/turt2live","followers_url":"https://api.github.com/users/turt2live/followers","following_url":"https://api.github.com/users/turt2live/following{/other_user}","gists_url":"https://api.github.com/users/turt2live/gists{/gist_id}","starred_url":"https://api.github.com/users/turt2live/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turt2live/subscriptions","organizations_url":"https://api.github.com/users/turt2live/orgs","repos_url":"https://api.github.com/users/turt2live/repos","events_url":"https://api.github.com/users/turt2live/events{/privacy}","received_events_url":"https://api.github.com/users/turt2live/received_events","type":"User","site_admin":false},"body":"This is based off of https://github.com/matrix-org/matrix-doc/pull/1406 to re-use the definitions. If reviewing this ahead of 1406 being merged, skip the first two commits.\r\n\r\nA later PR will improve the sections. The goal here is to convert the code blocks to swagger. Invites had their entire section replaced because the whole section described the endpoint.\r\n\r\nThird party invites are *not* included in this PR and will be a separate PR.\r\n\r\nRendered: https://matrix.org/speculator/spec/1413/server_server/unstable.html#get-matrix-federation-v1-make-join-roomid-userid","created_at":"2018-07-13T04:17:50Z","updated_at":"2018-07-24T13:01:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39ee3468eaffd52ea47383362bd1cb77d359d515","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"Spec Core Team","id":2820676,"node_id":"MDQ6VGVhbTI4MjA2NzY=","slug":"spec-core-team","description":"Core team members tasked with reviewing Matrix Spec Proposals","privacy":"closed","url":"https://api.github.com/teams/2820676","members_url":"https://api.github.com/teams/2820676/members{/member}","repositories_url":"https://api.github.com/teams/2820676/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/matrix-org/matrix-doc/pulls/1413/commits","review_comments_url":"https://api.github.com/repos/matrix-org/matrix-doc/pulls/1413/comments","review_comment_url":"https://api.github.com/repos/matrix-org/matrix-doc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matrix-org/matrix-doc/issues/1413/comments","statuses_url":"https://api.github.com/repos/matrix-org/matrix-doc/statuses/569a83b37bd437e0949a7ed666216f26157dd039","head":{"label":"turt2live:travis/s2s/join-swagger","ref":"travis/s2s/join-swagger","sha":"569a83b37bd437e0949a7ed666216f26157dd039","user":{"login":"turt2live","id":1190097,"node_id":"MDQ6VXNlcjExOTAwOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1190097?v=4","gravatar_id":"","url":"https://api.github.com/users/turt2live","html_url":"https://github.com/turt2live","followers_url":"https://api.github.com/users/turt2live/followers","following_url":"https://api.github.com/users/turt2live/following{/other_user}","gists_url":"https://api.github.com/users/turt2live/gists{/gist_id}","starred_url":"https://api.github.com/users/turt2live/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turt2live/subscriptions","organizations_url":"https://api.github.com/users/turt2live/orgs","repos_url":"https://api.github.com/users/turt2live/repos","events_url":"https://api.github.com/users/turt2live/events{/privacy}","received_events_url":"https://api.github.com/users/turt2live/received_events","type":"User","site_admin":false},"repo":{"id":81121581,"node_id":"MDEwOlJlcG9zaXRvcnk4MTEyMTU4MQ==","name":"matrix-doc","full_name":"turt2live/matrix-doc","owner":{"login":"turt2live","id":1190097,"node_id":"MDQ6VXNlcjExOTAwOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1190097?v=4","gravatar_id":"","url":"https://api.github.com/users/turt2live","html_url":"https://github.com/turt2live","followers_url":"https://api.github.com/users/turt2live/followers","following_url":"https://api.github.com/users/turt2live/following{/other_user}","gists_url":"https://api.github.com/users/turt2live/gists{/gist_id}","starred_url":"https://api.github.com/users/turt2live/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turt2live/subscriptions","organizations_url":"https://api.github.com/users/turt2live/orgs","repos_url":"https://api.github.com/users/turt2live/repos","events_url":"https://api.github.com/users/turt2live/events{/privacy}","received_events_url":"https://api.github.com/users/turt2live/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/turt2live/matrix-doc","description":"Matrix Documentation (including The Spec)","fork":true,"url":"https://api.github.com/repos/turt2live/matrix-doc","forks_url":"https://api.github.com/repos/turt2live/matrix-doc/forks","keys_url":"https://api.github.com/repos/turt2live/matrix-doc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/turt2live/matrix-doc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/turt2live/matrix-doc/teams","hooks_url":"https://api.github.com/repos/turt2live/matrix-doc/hooks","issue_events_url":"https://api.github.com/repos/turt2live/matrix-doc/issues/events{/number}","events_url":"https://api.github.com/repos/turt2live/matrix-doc/events","assignees_url":"https://api.github.com/repos/turt2live/matrix-doc/assignees{/user}","branches_url":"https://api.github.com/repos/turt2live/matrix-doc/branches{/branch}","tags_url":"https://api.github.com/repos/turt2live/matrix-doc/tags","blobs_url":"https://api.github.com/repos/turt2live/matrix-doc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/turt2live/matrix-doc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/turt2live/matrix-doc/git/refs{/sha}","trees_url":"https://api.github.com/repos/turt2live/matrix-doc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/turt2live/matrix-doc/statuses/{sha}","languages_url":"https://api.github.com/repos/turt2live/matrix-doc/languages","stargazers_url":"https://api.github.com/repos/turt2live/matrix-doc/stargazers","contributors_url":"https://api.github.com/repos/turt2live/matrix-doc/contributors","subscribers_url":"https://api.github.com/repos/turt2live/matrix-doc/subscribers","subscription_url":"https://api.github.com/repos/turt2live/matrix-doc/subscription","commits_url":"https://api.github.com/repos/turt2live/matrix-doc/commits{/sha}","git_commits_url":"https://api.github.com/repos/turt2live/matrix-doc/git/commits{/sha}","comments_url":"https://api.github.com/repos/turt2live/matrix-doc/comments{/number}","issue_comment_url":"https://api.github.com/repos/turt2live/matrix-doc/issues/comments{/number}","contents_url":"https://api.github.com/repos/turt2live/matrix-doc/contents/{+path}","compare_url":"https://api.github.com/repos/turt2live/matrix-doc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/turt2live/matrix-doc/merges","archive_url":"https://api.github.com/repos/turt2live/matrix-doc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/turt2live/matrix-doc/downloads","issues_url":"https://api.github.com/repos/turt2live/matrix-doc/issues{/number}","pulls_url":"https://api.github.com/repos/turt2live/matrix-doc/pulls{/number}","milestones_url":"https://api.github.com/repos/turt2live/matrix-doc/milestones{/number}","notifications_url":"https://api.github.com/repos/turt2live/matrix-doc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/turt2live/matrix-doc/labels{/name}","releases_url":"https://api.github.com/repos/turt2live/matrix-doc/releases{/id}","deployments_url":"https://api.github.com/repos/turt2live/matrix-doc/deployments","created_at":"2017-02-06T19:08:40Z","updated_at":"2018-06-05T21:56:48Z","pushed_at":"2018-07-23T16:33:04Z","git_url":"git://github.com/turt2live/matrix-doc.git","ssh_url":"git@github.com:turt2live/matrix-doc.git","clone_url":"https://github.com/turt2live/matrix-doc.git","svn_url":"https://github.com/turt2live/matrix-doc","homepage":null,"size":7338,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matrix-org:master","ref":"master","sha":"2e5f530cca62b8c7e971670a80cc3b8dc13eac99","user":{"login":"matrix-org","id":8418310,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MTgzMTA=","avatar_url":"https://avatars2.githubusercontent.com/u/8418310?v=4","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"repo":{"id":24998719,"node_id":"MDEwOlJlcG9zaXRvcnkyNDk5ODcxOQ==","name":"matrix-doc","full_name":"matrix-org/matrix-doc","owner":{"login":"matrix-org","id":8418310,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MTgzMTA=","avatar_url":"https://avatars2.githubusercontent.com/u/8418310?v=4","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matrix-org/matrix-doc","description":"Matrix Documentation (including The Spec)","fork":false,"url":"https://api.github.com/repos/matrix-org/matrix-doc","forks_url":"https://api.github.com/repos/matrix-org/matrix-doc/forks","keys_url":"https://api.github.com/repos/matrix-org/matrix-doc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matrix-org/matrix-doc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matrix-org/matrix-doc/teams","hooks_url":"https://api.github.com/repos/matrix-org/matrix-doc/hooks","issue_events_url":"https://api.github.com/repos/matrix-org/matrix-doc/issues/events{/number}","events_url":"https://api.github.com/repos/matrix-org/matrix-doc/events","assignees_url":"https://api.github.com/repos/matrix-org/matrix-doc/assignees{/user}","branches_url":"https://api.github.com/repos/matrix-org/matrix-doc/branches{/branch}","tags_url":"https://api.github.com/repos/matrix-org/matrix-doc/tags","blobs_url":"https://api.github.com/repos/matrix-org/matrix-doc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matrix-org/matrix-doc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matrix-org/matrix-doc/git/refs{/sha}","trees_url":"https://api.github.com/repos/matrix-org/matrix-doc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matrix-org/matrix-doc/statuses/{sha}","languages_url":"https://api.github.com/repos/matrix-org/matrix-doc/languages","stargazers_url":"https://api.github.com/repos/matrix-org/matrix-doc/stargazers","contributors_url":"https://api.github.com/repos/matrix-org/matrix-doc/contributors","subscribers_url":"https://api.github.com/repos/matrix-org/matrix-doc/subscribers","subscription_url":"https://api.github.com/repos/matrix-org/matrix-doc/subscription","commits_url":"https://api.github.com/repos/matrix-org/matrix-doc/commits{/sha}","git_commits_url":"https://api.github.com/repos/matrix-org/matrix-doc/git/commits{/sha}","comments_url":"https://api.github.com/repos/matrix-org/matrix-doc/comments{/number}","issue_comment_url":"https://api.github.com/repos/matrix-org/matrix-doc/issues/comments{/number}","contents_url":"https://api.github.com/repos/matrix-org/matrix-doc/contents/{+path}","compare_url":"https://api.github.com/repos/matrix-org/matrix-doc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matrix-org/matrix-doc/merges","archive_url":"https://api.github.com/repos/matrix-org/matrix-doc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matrix-org/matrix-doc/downloads","issues_url":"https://api.github.com/repos/matrix-org/matrix-doc/issues{/number}","pulls_url":"https://api.github.com/repos/matrix-org/matrix-doc/pulls{/number}","milestones_url":"https://api.github.com/repos/matrix-org/matrix-doc/milestones{/number}","notifications_url":"https://api.github.com/repos/matrix-org/matrix-doc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matrix-org/matrix-doc/labels{/name}","releases_url":"https://api.github.com/repos/matrix-org/matrix-doc/releases{/id}","deployments_url":"https://api.github.com/repos/matrix-org/matrix-doc/deployments","created_at":"2014-10-09T16:41:02Z","updated_at":"2018-07-24T10:43:49Z","pushed_at":"2018-07-24T10:51:25Z","git_url":"git://github.com/matrix-org/matrix-doc.git","ssh_url":"git@github.com:matrix-org/matrix-doc.git","clone_url":"https://github.com/matrix-org/matrix-doc.git","svn_url":"https://github.com/matrix-org/matrix-doc","homepage":null,"size":7405,"stargazers_count":155,"watchers_count":155,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":87,"mirror_url":null,"archived":false,"open_issues_count":548,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":87,"open_issues":548,"watchers":155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matrix-org/matrix-doc/pulls/1413"},"html":{"href":"https://github.com/matrix-org/matrix-doc/pull/1413"},"issue":{"href":"https://api.github.com/repos/matrix-org/matrix-doc/issues/1413"},"comments":{"href":"https://api.github.com/repos/matrix-org/matrix-doc/issues/1413/comments"},"review_comments":{"href":"https://api.github.com/repos/matrix-org/matrix-doc/pulls/1413/comments"},"review_comment":{"href":"https://api.github.com/repos/matrix-org/matrix-doc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matrix-org/matrix-doc/pulls/1413/commits"},"statuses":{"href":"https://api.github.com/repos/matrix-org/matrix-doc/statuses/569a83b37bd437e0949a7ed666216f26157dd039"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"anoadragon453"}}