{"action":"created","issue":{"url":"https://api.github.com/repos/processing/p5.js-web-editor/issues/731","repository_url":"https://api.github.com/repos/processing/p5.js-web-editor","labels_url":"https://api.github.com/repos/processing/p5.js-web-editor/issues/731/labels{/name}","comments_url":"https://api.github.com/repos/processing/p5.js-web-editor/issues/731/comments","events_url":"https://api.github.com/repos/processing/p5.js-web-editor/issues/731/events","html_url":"https://github.com/processing/p5.js-web-editor/pull/731","id":369837728,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNjczNTM0","number":731,"title":"[WIP] work on #541","user":{"login":"Vertmo","id":24356589,"node_id":"MDQ6VXNlcjI0MzU2NTg5","avatar_url":"https://avatars1.githubusercontent.com/u/24356589?v=4","gravatar_id":"","url":"https://api.github.com/users/Vertmo","html_url":"https://github.com/Vertmo","followers_url":"https://api.github.com/users/Vertmo/followers","following_url":"https://api.github.com/users/Vertmo/following{/other_user}","gists_url":"https://api.github.com/users/Vertmo/gists{/gist_id}","starred_url":"https://api.github.com/users/Vertmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vertmo/subscriptions","organizations_url":"https://api.github.com/users/Vertmo/orgs","repos_url":"https://api.github.com/users/Vertmo/repos","events_url":"https://api.github.com/users/Vertmo/events{/privacy}","received_events_url":"https://api.github.com/users/Vertmo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-10-13T20:23:05Z","updated_at":"2018-11-06T19:54:49Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/processing/p5.js-web-editor/pulls/731","html_url":"https://github.com/processing/p5.js-web-editor/pull/731","diff_url":"https://github.com/processing/p5.js-web-editor/pull/731.diff","patch_url":"https://github.com/processing/p5.js-web-editor/pull/731.patch"},"body":"Before your pull request is reviewed and merged, please ensure that:\r\n\r\n* [X] there are no linting errors -- `npm run lint`\r\n* [X] your code is in a uniquely-named feature branch and has been rebased on top of the latest master. If you're asked to make more changes, make sure you rebase onto master then too!\r\n* [X] your pull request is descriptively named and links to an issue number, i.e. `Fixes #123`\r\n* [ ] all the changes you wanted to do are made\r\n\r\nI started work on #541 (adding API keys to a user profile). I already worked on the design of the \"Advanced Settings\" page, which you can find by clicking on \"Advanced Settings\" in the `/account` page (or by navigating to `/account/advanced`).\r\nAs you can see by the mockup, users won't be able to see keys on their interface (since we'll store them hashed), so the only time they'll be able to copy them will be at creation (I took inspiration in GitHub's Personal Access Token system).\r\nNext, I'll be working on adding this keys to the database, and to add the logic to generate, hash them, and store them.\r\n"},"comment":{"url":"https://api.github.com/repos/processing/p5.js-web-editor/issues/comments/436386868","html_url":"https://github.com/processing/p5.js-web-editor/pull/731#issuecomment-436386868","issue_url":"https://api.github.com/repos/processing/p5.js-web-editor/issues/731","id":436386868,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjM4Njg2OA==","user":{"login":"Vertmo","id":24356589,"node_id":"MDQ6VXNlcjI0MzU2NTg5","avatar_url":"https://avatars1.githubusercontent.com/u/24356589?v=4","gravatar_id":"","url":"https://api.github.com/users/Vertmo","html_url":"https://github.com/Vertmo","followers_url":"https://api.github.com/users/Vertmo/followers","following_url":"https://api.github.com/users/Vertmo/following{/other_user}","gists_url":"https://api.github.com/users/Vertmo/gists{/gist_id}","starred_url":"https://api.github.com/users/Vertmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vertmo/subscriptions","organizations_url":"https://api.github.com/users/Vertmo/orgs","repos_url":"https://api.github.com/users/Vertmo/repos","events_url":"https://api.github.com/users/Vertmo/events{/privacy}","received_events_url":"https://api.github.com/users/Vertmo/received_events","type":"User","site_admin":false},"created_at":"2018-11-06T19:54:49Z","updated_at":"2018-11-06T19:54:49Z","author_association":"CONTRIBUTOR","body":"Locally yes, I added : \r\n`app.get('/temp', passport.authenticate('basic', { session: false }), (req, res) => res.json(req.user));` to `server/server.js`"}}
{"actor":{"display_login":"Vertmo"}}