{"action":"closed","number":1160,"pull_request":{"url":"https://api.github.com/repos/newsuk/times-components/pulls/1160","id":205485474,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NDg1NDc0","html_url":"https://github.com/newsuk/times-components/pull/1160","diff_url":"https://github.com/newsuk/times-components/pull/1160.diff","patch_url":"https://github.com/newsuk/times-components/pull/1160.patch","issue_url":"https://api.github.com/repos/newsuk/times-components/issues/1160","number":1160,"state":"closed","locked":false,"title":"fix(depend): add missing param for --only","user":{"login":"mcheshkov","id":1045163,"node_id":"MDQ6VXNlcjEwNDUxNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1045163?v=4","gravatar_id":"","url":"https://api.github.com/users/mcheshkov","html_url":"https://github.com/mcheshkov","followers_url":"https://api.github.com/users/mcheshkov/followers","following_url":"https://api.github.com/users/mcheshkov/following{/other_user}","gists_url":"https://api.github.com/users/mcheshkov/gists{/gist_id}","starred_url":"https://api.github.com/users/mcheshkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcheshkov/subscriptions","organizations_url":"https://api.github.com/users/mcheshkov/orgs","repos_url":"https://api.github.com/users/mcheshkov/repos","events_url":"https://api.github.com/users/mcheshkov/events{/privacy}","received_events_url":"https://api.github.com/users/mcheshkov/received_events","type":"User","site_admin":false},"body":"Without `<glob>` part commander interpret this option as boolean flag. Tests didn't catch this because commander is stubbed.\r\n\r\nWithout this change I get this:\r\n```\r\n$ npx @times-components/depend --only foo --list --lerna ./\r\nTypeError: glob pattern string required\r\n```\r\n\r\n<!--\r\nThank you for your PR!\r\n\r\nPlease provide clear instructions on how you verified your work.\r\n\r\nIf there are any visual changes, include screenshots and demo videos (try https://giphy.com/apps/giphycapture).\r\n\r\n:-)\r\n-->\r\n","created_at":"2018-08-01T16:40:12Z","updated_at":"2018-08-01T19:26:16Z","closed_at":"2018-08-01T19:26:16Z","merged_at":"2018-08-01T19:26:16Z","merge_commit_sha":"f15d4b0309cde89c8351a99e87d4f976a1ebceb4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/newsuk/times-components/pulls/1160/commits","review_comments_url":"https://api.github.com/repos/newsuk/times-components/pulls/1160/comments","review_comment_url":"https://api.github.com/repos/newsuk/times-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/newsuk/times-components/issues/1160/comments","statuses_url":"https://api.github.com/repos/newsuk/times-components/statuses/0bd4170a2e8dade40212df59afa498d8d21901fa","head":{"label":"mcheshkov:patch-1","ref":"patch-1","sha":"0bd4170a2e8dade40212df59afa498d8d21901fa","user":{"login":"mcheshkov","id":1045163,"node_id":"MDQ6VXNlcjEwNDUxNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1045163?v=4","gravatar_id":"","url":"https://api.github.com/users/mcheshkov","html_url":"https://github.com/mcheshkov","followers_url":"https://api.github.com/users/mcheshkov/followers","following_url":"https://api.github.com/users/mcheshkov/following{/other_user}","gists_url":"https://api.github.com/users/mcheshkov/gists{/gist_id}","starred_url":"https://api.github.com/users/mcheshkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcheshkov/subscriptions","organizations_url":"https://api.github.com/users/mcheshkov/orgs","repos_url":"https://api.github.com/users/mcheshkov/repos","events_url":"https://api.github.com/users/mcheshkov/events{/privacy}","received_events_url":"https://api.github.com/users/mcheshkov/received_events","type":"User","site_admin":false},"repo":{"id":143182054,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMxODIwNTQ=","name":"times-components","full_name":"mcheshkov/times-components","owner":{"login":"mcheshkov","id":1045163,"node_id":"MDQ6VXNlcjEwNDUxNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1045163?v=4","gravatar_id":"","url":"https://api.github.com/users/mcheshkov","html_url":"https://github.com/mcheshkov","followers_url":"https://api.github.com/users/mcheshkov/followers","following_url":"https://api.github.com/users/mcheshkov/following{/other_user}","gists_url":"https://api.github.com/users/mcheshkov/gists{/gist_id}","starred_url":"https://api.github.com/users/mcheshkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcheshkov/subscriptions","organizations_url":"https://api.github.com/users/mcheshkov/orgs","repos_url":"https://api.github.com/users/mcheshkov/repos","events_url":"https://api.github.com/users/mcheshkov/events{/privacy}","received_events_url":"https://api.github.com/users/mcheshkov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcheshkov/times-components","description":"A collection of reusable components used by The Times","fork":true,"url":"https://api.github.com/repos/mcheshkov/times-components","forks_url":"https://api.github.com/repos/mcheshkov/times-components/forks","keys_url":"https://api.github.com/repos/mcheshkov/times-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcheshkov/times-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcheshkov/times-components/teams","hooks_url":"https://api.github.com/repos/mcheshkov/times-components/hooks","issue_events_url":"https://api.github.com/repos/mcheshkov/times-components/issues/events{/number}","events_url":"https://api.github.com/repos/mcheshkov/times-components/events","assignees_url":"https://api.github.com/repos/mcheshkov/times-components/assignees{/user}","branches_url":"https://api.github.com/repos/mcheshkov/times-components/branches{/branch}","tags_url":"https://api.github.com/repos/mcheshkov/times-components/tags","blobs_url":"https://api.github.com/repos/mcheshkov/times-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcheshkov/times-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcheshkov/times-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcheshkov/times-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcheshkov/times-components/statuses/{sha}","languages_url":"https://api.github.com/repos/mcheshkov/times-components/languages","stargazers_url":"https://api.github.com/repos/mcheshkov/times-components/stargazers","contributors_url":"https://api.github.com/repos/mcheshkov/times-components/contributors","subscribers_url":"https://api.github.com/repos/mcheshkov/times-components/subscribers","subscription_url":"https://api.github.com/repos/mcheshkov/times-components/subscription","commits_url":"https://api.github.com/repos/mcheshkov/times-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcheshkov/times-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcheshkov/times-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcheshkov/times-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcheshkov/times-components/contents/{+path}","compare_url":"https://api.github.com/repos/mcheshkov/times-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcheshkov/times-components/merges","archive_url":"https://api.github.com/repos/mcheshkov/times-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcheshkov/times-components/downloads","issues_url":"https://api.github.com/repos/mcheshkov/times-components/issues{/number}","pulls_url":"https://api.github.com/repos/mcheshkov/times-components/pulls{/number}","milestones_url":"https://api.github.com/repos/mcheshkov/times-components/milestones{/number}","notifications_url":"https://api.github.com/repos/mcheshkov/times-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcheshkov/times-components/labels{/name}","releases_url":"https://api.github.com/repos/mcheshkov/times-components/releases{/id}","deployments_url":"https://api.github.com/repos/mcheshkov/times-components/deployments","created_at":"2018-08-01T16:33:48Z","updated_at":"2018-08-01T16:33:54Z","pushed_at":"2018-08-01T16:38:14Z","git_url":"git://github.com/mcheshkov/times-components.git","ssh_url":"git@github.com:mcheshkov/times-components.git","clone_url":"https://github.com/mcheshkov/times-components.git","svn_url":"https://github.com/mcheshkov/times-components","homepage":"http://components.thetimes.co.uk","size":53255,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"newsuk:master","ref":"master","sha":"123d77715a437dff54af3d6e4e178c5aec4d305c","user":{"login":"newsuk","id":736306,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNjMwNg==","avatar_url":"https://avatars1.githubusercontent.com/u/736306?v=4","gravatar_id":"","url":"https://api.github.com/users/newsuk","html_url":"https://github.com/newsuk","followers_url":"https://api.github.com/users/newsuk/followers","following_url":"https://api.github.com/users/newsuk/following{/other_user}","gists_url":"https://api.github.com/users/newsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/newsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newsuk/subscriptions","organizations_url":"https://api.github.com/users/newsuk/orgs","repos_url":"https://api.github.com/users/newsuk/repos","events_url":"https://api.github.com/users/newsuk/events{/privacy}","received_events_url":"https://api.github.com/users/newsuk/received_events","type":"Organization","site_admin":false},"repo":{"id":93151110,"node_id":"MDEwOlJlcG9zaXRvcnk5MzE1MTExMA==","name":"times-components","full_name":"newsuk/times-components","owner":{"login":"newsuk","id":736306,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczNjMwNg==","avatar_url":"https://avatars1.githubusercontent.com/u/736306?v=4","gravatar_id":"","url":"https://api.github.com/users/newsuk","html_url":"https://github.com/newsuk","followers_url":"https://api.github.com/users/newsuk/followers","following_url":"https://api.github.com/users/newsuk/following{/other_user}","gists_url":"https://api.github.com/users/newsuk/gists{/gist_id}","starred_url":"https://api.github.com/users/newsuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newsuk/subscriptions","organizations_url":"https://api.github.com/users/newsuk/orgs","repos_url":"https://api.github.com/users/newsuk/repos","events_url":"https://api.github.com/users/newsuk/events{/privacy}","received_events_url":"https://api.github.com/users/newsuk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/newsuk/times-components","description":"A collection of reusable components used by The Times","fork":false,"url":"https://api.github.com/repos/newsuk/times-components","forks_url":"https://api.github.com/repos/newsuk/times-components/forks","keys_url":"https://api.github.com/repos/newsuk/times-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/newsuk/times-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/newsuk/times-components/teams","hooks_url":"https://api.github.com/repos/newsuk/times-components/hooks","issue_events_url":"https://api.github.com/repos/newsuk/times-components/issues/events{/number}","events_url":"https://api.github.com/repos/newsuk/times-components/events","assignees_url":"https://api.github.com/repos/newsuk/times-components/assignees{/user}","branches_url":"https://api.github.com/repos/newsuk/times-components/branches{/branch}","tags_url":"https://api.github.com/repos/newsuk/times-components/tags","blobs_url":"https://api.github.com/repos/newsuk/times-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/newsuk/times-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/newsuk/times-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/newsuk/times-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/newsuk/times-components/statuses/{sha}","languages_url":"https://api.github.com/repos/newsuk/times-components/languages","stargazers_url":"https://api.github.com/repos/newsuk/times-components/stargazers","contributors_url":"https://api.github.com/repos/newsuk/times-components/contributors","subscribers_url":"https://api.github.com/repos/newsuk/times-components/subscribers","subscription_url":"https://api.github.com/repos/newsuk/times-components/subscription","commits_url":"https://api.github.com/repos/newsuk/times-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/newsuk/times-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/newsuk/times-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/newsuk/times-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/newsuk/times-components/contents/{+path}","compare_url":"https://api.github.com/repos/newsuk/times-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/newsuk/times-components/merges","archive_url":"https://api.github.com/repos/newsuk/times-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/newsuk/times-components/downloads","issues_url":"https://api.github.com/repos/newsuk/times-components/issues{/number}","pulls_url":"https://api.github.com/repos/newsuk/times-components/pulls{/number}","milestones_url":"https://api.github.com/repos/newsuk/times-components/milestones{/number}","notifications_url":"https://api.github.com/repos/newsuk/times-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/newsuk/times-components/labels{/name}","releases_url":"https://api.github.com/repos/newsuk/times-components/releases{/id}","deployments_url":"https://api.github.com/repos/newsuk/times-components/deployments","created_at":"2017-06-02T09:41:03Z","updated_at":"2018-08-01T14:12:35Z","pushed_at":"2018-08-01T19:26:16Z","git_url":"git://github.com/newsuk/times-components.git","ssh_url":"git@github.com:newsuk/times-components.git","clone_url":"https://github.com/newsuk/times-components.git","svn_url":"https://github.com/newsuk/times-components","homepage":"http://components.thetimes.co.uk","size":53267,"stargazers_count":92,"watchers_count":92,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":14,"open_issues":40,"watchers":92,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/1160"},"html":{"href":"https://github.com/newsuk/times-components/pull/1160"},"issue":{"href":"https://api.github.com/repos/newsuk/times-components/issues/1160"},"comments":{"href":"https://api.github.com/repos/newsuk/times-components/issues/1160/comments"},"review_comments":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/1160/comments"},"review_comment":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/newsuk/times-components/pulls/1160/commits"},"statuses":{"href":"https://api.github.com/repos/newsuk/times-components/statuses/0bd4170a2e8dade40212df59afa498d8d21901fa"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"craigbilner","id":12942968,"node_id":"MDQ6VXNlcjEyOTQyOTY4","avatar_url":"https://avatars2.githubusercontent.com/u/12942968?v=4","gravatar_id":"","url":"https://api.github.com/users/craigbilner","html_url":"https://github.com/craigbilner","followers_url":"https://api.github.com/users/craigbilner/followers","following_url":"https://api.github.com/users/craigbilner/following{/other_user}","gists_url":"https://api.github.com/users/craigbilner/gists{/gist_id}","starred_url":"https://api.github.com/users/craigbilner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigbilner/subscriptions","organizations_url":"https://api.github.com/users/craigbilner/orgs","repos_url":"https://api.github.com/users/craigbilner/repos","events_url":"https://api.github.com/users/craigbilner/events{/privacy}","received_events_url":"https://api.github.com/users/craigbilner/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"craigbilner"}}