{"action":"created","issue":{"url":"https://api.github.com/repos/jwilm/alacritty/issues/1078","repository_url":"https://api.github.com/repos/jwilm/alacritty","labels_url":"https://api.github.com/repos/jwilm/alacritty/issues/1078/labels{/name}","comments_url":"https://api.github.com/repos/jwilm/alacritty/issues/1078/comments","events_url":"https://api.github.com/repos/jwilm/alacritty/issues/1078/events","html_url":"https://github.com/jwilm/alacritty/pull/1078","id":293649619,"number":1078,"title":"Add proper underline and strikethrough support","user":{"login":"chrisduerr","id":8886672,"avatar_url":"https://avatars3.githubusercontent.com/u/8886672?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisduerr","html_url":"https://github.com/chrisduerr","followers_url":"https://api.github.com/users/chrisduerr/followers","following_url":"https://api.github.com/users/chrisduerr/following{/other_user}","gists_url":"https://api.github.com/users/chrisduerr/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisduerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisduerr/subscriptions","organizations_url":"https://api.github.com/users/chrisduerr/orgs","repos_url":"https://api.github.com/users/chrisduerr/repos","events_url":"https://api.github.com/users/chrisduerr/events{/privacy}","received_events_url":"https://api.github.com/users/chrisduerr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-02-01T19:13:01Z","updated_at":"2018-02-16T14:07:22Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/jwilm/alacritty/pulls/1078","html_url":"https://github.com/jwilm/alacritty/pull/1078","diff_url":"https://github.com/jwilm/alacritty/pull/1078.diff","patch_url":"https://github.com/jwilm/alacritty/pull/1078.patch"},"body":"Support for strikethrough has been added by inserting and removing a\r\n`STRIKE_THROUGH` flag on the cell.\r\n\r\nNow all strikethrough and underline drawing is also done through the\r\nrectangle renderer. So no glyphs are used to render underlines and\r\nstrikethrough.\r\nThe position is taken from the font metrics and should be accurate for\r\nlinux, however is not yet tested on macos.\r\n\r\nIt works by checking the underline state for each cell and then drawing\r\nfrom the start until the last position whenever an underline ended. This\r\nadds a few checks even if no underline is rendered but I was not able to\r\nmeasure any significant performance impact.\r\n\r\nFixes jwilm/alacritty#806.\r\nFixes jwilm/alacritty#31.\r\n\r\nDemo:\r\n![](https://u.teknik.io/Nwzo3.png)"},"comment":{"url":"https://api.github.com/repos/jwilm/alacritty/issues/comments/366244274","html_url":"https://github.com/jwilm/alacritty/pull/1078#issuecomment-366244274","issue_url":"https://api.github.com/repos/jwilm/alacritty/issues/1078","id":366244274,"user":{"login":"chrisduerr","id":8886672,"avatar_url":"https://avatars3.githubusercontent.com/u/8886672?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisduerr","html_url":"https://github.com/chrisduerr","followers_url":"https://api.github.com/users/chrisduerr/followers","following_url":"https://api.github.com/users/chrisduerr/following{/other_user}","gists_url":"https://api.github.com/users/chrisduerr/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisduerr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisduerr/subscriptions","organizations_url":"https://api.github.com/users/chrisduerr/orgs","repos_url":"https://api.github.com/users/chrisduerr/repos","events_url":"https://api.github.com/users/chrisduerr/events{/privacy}","received_events_url":"https://api.github.com/users/chrisduerr/received_events","type":"User","site_admin":false},"created_at":"2018-02-16T14:07:22Z","updated_at":"2018-02-16T14:07:22Z","author_association":"COLLABORATOR","body":"I'd classify the first GIF as a bug. It might be up to freetype standards (not sure, I'd have to look into it), but the underline should never be even a single pixel below the cell height.\r\n\r\nSince the cell height is the full height of the line, any pixel below that is part of the next line and should never contain content from the previous one. It's probably just a rounding/edge case thing, thanks for always being so quick to test things. :)"}}
{"actor":{"display_login":"chrisduerr"}}