{"action":"created","issue":{"url":"https://api.github.com/repos/ovity/octotree/issues/546","repository_url":"https://api.github.com/repos/ovity/octotree","labels_url":"https://api.github.com/repos/ovity/octotree/issues/546/labels{/name}","comments_url":"https://api.github.com/repos/ovity/octotree/issues/546/comments","events_url":"https://api.github.com/repos/ovity/octotree/issues/546/events","html_url":"https://github.com/ovity/octotree/issues/546","id":365343152,"node_id":"MDU6SXNzdWUzNjUzNDMxNTI=","number":546,"title":"Octotree's side panel shifts GitHub's header's content","user":{"login":"flawyte","id":1585006,"node_id":"MDQ6VXNlcjE1ODUwMDY=","avatar_url":"https://avatars3.githubusercontent.com/u/1585006?v=4","gravatar_id":"","url":"https://api.github.com/users/flawyte","html_url":"https://github.com/flawyte","followers_url":"https://api.github.com/users/flawyte/followers","following_url":"https://api.github.com/users/flawyte/following{/other_user}","gists_url":"https://api.github.com/users/flawyte/gists{/gist_id}","starred_url":"https://api.github.com/users/flawyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flawyte/subscriptions","organizations_url":"https://api.github.com/users/flawyte/orgs","repos_url":"https://api.github.com/users/flawyte/repos","events_url":"https://api.github.com/users/flawyte/events{/privacy}","received_events_url":"https://api.github.com/users/flawyte/received_events","type":"User","site_admin":false},"labels":[{"id":98398781,"node_id":"MDU6TGFiZWw5ODM5ODc4MQ==","url":"https://api.github.com/repos/ovity/octotree/labels/bug","name":"bug","color":"fc2929","default":true},{"id":98398784,"node_id":"MDU6TGFiZWw5ODM5ODc4NA==","url":"https://api.github.com/repos/ovity/octotree/labels/help%20wanted","name":"help wanted","color":"159818","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-10-01T07:43:48Z","updated_at":"2018-10-12T22:16:52Z","closed_at":null,"author_association":"NONE","body":"### Description\r\n\r\nThe title says it all. Here's a screenshot to help you see the problem :\r\n![Screenshot showing header's content being shifted](https://snag.gy/O68nEB.jpg)\r\n\r\nYou can see that the header's content gets shifted to the right when the Octotree panel is open (when it's closed too, but less).\r\n\r\nThough I don't know if it's really a bug or if it's intentional, because I used the DevTools to see what's going on and it happens because padding gets added to the header's content. But why is that?\r\n\r\n### Environment (if bug)\r\n\r\n* Octotree version: 2.4.9\r\n* Browser & version: Google Chrome 69.0.3497.100\r\n* OS & version: Windows 10"},"comment":{"url":"https://api.github.com/repos/ovity/octotree/issues/comments/429477918","html_url":"https://github.com/ovity/octotree/issues/546#issuecomment-429477918","issue_url":"https://api.github.com/repos/ovity/octotree/issues/546","id":429477918,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTQ3NzkxOA==","user":{"login":"flawyte","id":1585006,"node_id":"MDQ6VXNlcjE1ODUwMDY=","avatar_url":"https://avatars3.githubusercontent.com/u/1585006?v=4","gravatar_id":"","url":"https://api.github.com/users/flawyte","html_url":"https://github.com/flawyte","followers_url":"https://api.github.com/users/flawyte/followers","following_url":"https://api.github.com/users/flawyte/following{/other_user}","gists_url":"https://api.github.com/users/flawyte/gists{/gist_id}","starred_url":"https://api.github.com/users/flawyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flawyte/subscriptions","organizations_url":"https://api.github.com/users/flawyte/orgs","repos_url":"https://api.github.com/users/flawyte/repos","events_url":"https://api.github.com/users/flawyte/events{/privacy}","received_events_url":"https://api.github.com/users/flawyte/received_events","type":"User","site_admin":false},"created_at":"2018-10-12T22:16:52Z","updated_at":"2018-10-12T22:16:52Z","author_association":"NONE","body":"Okay I see. But it should only happen if needed (on small screens), right? Because if you have a \"big\" (classic) screen resolution such as 1920*1080, there's enough room for the sidebar to expand without overlapping the header or page's content, and thus Octotree doesn't need to push anything.\r\n\r\nSo maybe the best way is :\r\n- First, determine if there's room for Octotree's toggle button without it overlapping GitHub's logo\r\n- If not, shift header's content\r\n- Else, do nothing\r\n\r\nAnd the same would have to be done with the page's content when the sidebar is open.\r\n\r\nWhat do you think?"}}
{"actor":{"display_login":"flawyte"}}