{"action":"created","issue":{"url":"https://api.github.com/repos/linkerd/linkerd/issues/1887","repository_url":"https://api.github.com/repos/linkerd/linkerd","labels_url":"https://api.github.com/repos/linkerd/linkerd/issues/1887/labels{/name}","comments_url":"https://api.github.com/repos/linkerd/linkerd/issues/1887/comments","events_url":"https://api.github.com/repos/linkerd/linkerd/issues/1887/events","html_url":"https://github.com/linkerd/linkerd/issues/1887","id":310751863,"number":1887,"title":"Graceful shutdown unresponsive to shutdownGraceMs setting","user":{"login":"jacob-go","id":29705346,"avatar_url":"https://avatars0.githubusercontent.com/u/29705346?v=4","gravatar_id":"","url":"https://api.github.com/users/jacob-go","html_url":"https://github.com/jacob-go","followers_url":"https://api.github.com/users/jacob-go/followers","following_url":"https://api.github.com/users/jacob-go/following{/other_user}","gists_url":"https://api.github.com/users/jacob-go/gists{/gist_id}","starred_url":"https://api.github.com/users/jacob-go/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacob-go/subscriptions","organizations_url":"https://api.github.com/users/jacob-go/orgs","repos_url":"https://api.github.com/users/jacob-go/repos","events_url":"https://api.github.com/users/jacob-go/events{/privacy}","received_events_url":"https://api.github.com/users/jacob-go/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-04-03T09:04:56Z","updated_at":"2018-04-23T17:43:21Z","closed_at":null,"author_association":"NONE","body":"## Filing a Linkerd issue ##\r\n\r\nIssue Type:\r\n\r\n- [X] Bug report\r\n\r\n**What happened**:\r\nI was testing linker-to-linker architecture. Sent a sequence of non-stop requests to an endpoint behind a Linkerd proxy and restarted the proxy without stoping the requests. I witnessed that no matter the load, Linkerd get killed in about 2 seconds. \r\nI've searched after a setting for this period of time before termination, maybe explicitly configuring a larger interval. I've configured my `admin` block in the configuration file with `shutdownGraceMs: 10000` but still - Linkerd is terminated after 2 seconds. \r\n\r\n**What you expected to happen**:\r\nA) A more cohesive graceful shutdown, closing sockets/connections, draining the queue of requests until none is there and then terminating. \r\nB) Linkerd task would be terminated after the period of time configured in the `admin` block. \r\n\r\n**How to reproduce it (as minimally and precisely as possible)**:\r\n```\r\n---\r\nadmin:\r\n  ip: 0.0.0.0\r\n  port: 4447\r\n  shutdownGraceMs: 10000\r\n```\r\n\r\nThen see exact time of SIGTERM and exit in `stderr`:\r\n```\r\nI 0329 08:14:48.002 UTC THREAD29 TraceId:b229fc3755c0e29f: [/admin/shutdown] from <TASK_IP> quitting\r\nI0329 08:14:49.415153 18340 health_checker.cpp:165] Health checking stopped\r\nW0329 08:14:49.415153 18337 logging.cpp:91] RAW: Received signal SIGTERM from process 5704 of user 0; exiting\r\n```\r\n\r\n**Anything else we need to know?**:\r\nI think that maybe [this](https://github.com/linkerd/linkerd/issues/1834) issue is caused by the graceful shutdown issue. \r\n\r\n**Environment**:\r\n- linkerd/namerd version, config files: the only relevant config is in the `admin` block\r\n- Platform, version, and config files (Kubernetes, DC/OS, etc): DC/OS\r\n- Cloud provider or hardware configuration: AWS\r\n"},"comment":{"url":"https://api.github.com/repos/linkerd/linkerd/issues/comments/383661413","html_url":"https://github.com/linkerd/linkerd/issues/1887#issuecomment-383661413","issue_url":"https://api.github.com/repos/linkerd/linkerd/issues/1887","id":383661413,"user":{"login":"dadjeibaah","id":2197104,"avatar_url":"https://avatars2.githubusercontent.com/u/2197104?v=4","gravatar_id":"","url":"https://api.github.com/users/dadjeibaah","html_url":"https://github.com/dadjeibaah","followers_url":"https://api.github.com/users/dadjeibaah/followers","following_url":"https://api.github.com/users/dadjeibaah/following{/other_user}","gists_url":"https://api.github.com/users/dadjeibaah/gists{/gist_id}","starred_url":"https://api.github.com/users/dadjeibaah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadjeibaah/subscriptions","organizations_url":"https://api.github.com/users/dadjeibaah/orgs","repos_url":"https://api.github.com/users/dadjeibaah/repos","events_url":"https://api.github.com/users/dadjeibaah/events{/privacy}","received_events_url":"https://api.github.com/users/dadjeibaah/received_events","type":"User","site_admin":false},"created_at":"2018-04-23T17:43:21Z","updated_at":"2018-04-23T17:43:21Z","author_association":"CONTRIBUTOR","body":"I don't think, OTTOH, that sending a `SIGTERM` vs using the `/admin/shutdown` are any different.  I would like to make sure the tests closely match how the issue is manifested just in case the `/admin/shutdown` has some additional tear down tasks that I am not aware of. "}}
{"actor":{"display_login":"dadjeibaah"}}