{"action":"created","issue":{"url":"https://api.github.com/repos/vaelen/iot/issues/1","repository_url":"https://api.github.com/repos/vaelen/iot","labels_url":"https://api.github.com/repos/vaelen/iot/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/vaelen/iot/issues/1/comments","events_url":"https://api.github.com/repos/vaelen/iot/issues/1/events","html_url":"https://github.com/vaelen/iot/issues/1","id":306024991,"number":1,"title":"Couple of ideas for you","user":{"login":"danielbprice","id":2693615,"avatar_url":"https://avatars2.githubusercontent.com/u/2693615?v=4","gravatar_id":"","url":"https://api.github.com/users/danielbprice","html_url":"https://github.com/danielbprice","followers_url":"https://api.github.com/users/danielbprice/followers","following_url":"https://api.github.com/users/danielbprice/following{/other_user}","gists_url":"https://api.github.com/users/danielbprice/gists{/gist_id}","starred_url":"https://api.github.com/users/danielbprice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielbprice/subscriptions","organizations_url":"https://api.github.com/users/danielbprice/orgs","repos_url":"https://api.github.com/users/danielbprice/repos","events_url":"https://api.github.com/users/danielbprice/events{/privacy}","received_events_url":"https://api.github.com/users/danielbprice/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-16T18:01:54Z","updated_at":"2018-03-19T04:29:21Z","closed_at":null,"author_association":"NONE","body":"As I mentioned, this is really nice!  I've written my own but I spent a lot of my time working around the password problem (I guess I should have forked the code, as you did); there are a lot of nice details in your code.\r\n\r\nSome ideas if you are interested:\r\n- I made the top-level client an interface, to facilitate mocking.\r\n- I have a utility function which sets mqtt.DEBUG, mqtt.WARN, ... etc so that if you need it you can get the underlying MQTT debug information.\r\n- I opted for now to expose the MQTT token to callers, because I wasn't sure if a fixed timeout would be the right thing.  Dunno if that's really a good idea or not.  I guess I could wrap the token to make it less ugly.\r\n\r\nAnyway, well done."},"comment":{"url":"https://api.github.com/repos/vaelen/iot/issues/comments/374098483","html_url":"https://github.com/vaelen/iot/issues/1#issuecomment-374098483","issue_url":"https://api.github.com/repos/vaelen/iot/issues/1","id":374098483,"user":{"login":"vaelen","id":154691,"avatar_url":"https://avatars2.githubusercontent.com/u/154691?v=4","gravatar_id":"","url":"https://api.github.com/users/vaelen","html_url":"https://github.com/vaelen","followers_url":"https://api.github.com/users/vaelen/followers","following_url":"https://api.github.com/users/vaelen/following{/other_user}","gists_url":"https://api.github.com/users/vaelen/gists{/gist_id}","starred_url":"https://api.github.com/users/vaelen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaelen/subscriptions","organizations_url":"https://api.github.com/users/vaelen/orgs","repos_url":"https://api.github.com/users/vaelen/repos","events_url":"https://api.github.com/users/vaelen/events{/privacy}","received_events_url":"https://api.github.com/users/vaelen/received_events","type":"User","site_admin":false},"created_at":"2018-03-19T04:29:21Z","updated_at":"2018-03-19T04:29:21Z","author_association":"OWNER","body":"Thanks! I appreciate the feedback. :)"}}
{"actor":{"display_login":"vaelen"}}