{"action":"created","issue":{"url":"https://api.github.com/repos/arineng/jcrvalidator/issues/122","repository_url":"https://api.github.com/repos/arineng/jcrvalidator","labels_url":"https://api.github.com/repos/arineng/jcrvalidator/issues/122/labels{/name}","comments_url":"https://api.github.com/repos/arineng/jcrvalidator/issues/122/comments","events_url":"https://api.github.com/repos/arineng/jcrvalidator/issues/122/events","html_url":"https://github.com/arineng/jcrvalidator/pull/122","id":307620995,"number":122,"title":"Exclude min max annotations","user":{"login":"codalogic","id":1752198,"avatar_url":"https://avatars1.githubusercontent.com/u/1752198?v=4","gravatar_id":"","url":"https://api.github.com/users/codalogic","html_url":"https://github.com/codalogic","followers_url":"https://api.github.com/users/codalogic/followers","following_url":"https://api.github.com/users/codalogic/following{/other_user}","gists_url":"https://api.github.com/users/codalogic/gists{/gist_id}","starred_url":"https://api.github.com/users/codalogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codalogic/subscriptions","organizations_url":"https://api.github.com/users/codalogic/orgs","repos_url":"https://api.github.com/users/codalogic/repos","events_url":"https://api.github.com/users/codalogic/events{/privacy}","received_events_url":"https://api.github.com/users/codalogic/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-22T12:23:25Z","updated_at":"2018-03-22T14:12:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/arineng/jcrvalidator/pulls/122","html_url":"https://github.com/arineng/jcrvalidator/pull/122","diff_url":"https://github.com/arineng/jcrvalidator/pull/122.diff","patch_url":"https://github.com/arineng/jcrvalidator/pull/122.patch"},"body":"I've updated the parser and parser tests to support @{exclude-min}, @{exclude-max} and @{default ???}.\r\n\r\nNOTE WELL!...\r\n\r\nI haven't updated the validation side of things.  evaluate_value_rules.rb:53 and evaluate_value_rules.rb:94 look relevant, but I think you also do some rationalisation of specified annotations before the code gets to that stage (e.g. evaluate-rules.rb:223).  Rather than wade in and risk causing more trouble than good, I decided to leave that to you."},"comment":{"url":"https://api.github.com/repos/arineng/jcrvalidator/issues/comments/375320344","html_url":"https://github.com/arineng/jcrvalidator/pull/122#issuecomment-375320344","issue_url":"https://api.github.com/repos/arineng/jcrvalidator/issues/122","id":375320344,"user":{"login":"anewton1998","id":7232969,"avatar_url":"https://avatars2.githubusercontent.com/u/7232969?v=4","gravatar_id":"","url":"https://api.github.com/users/anewton1998","html_url":"https://github.com/anewton1998","followers_url":"https://api.github.com/users/anewton1998/followers","following_url":"https://api.github.com/users/anewton1998/following{/other_user}","gists_url":"https://api.github.com/users/anewton1998/gists{/gist_id}","starred_url":"https://api.github.com/users/anewton1998/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anewton1998/subscriptions","organizations_url":"https://api.github.com/users/anewton1998/orgs","repos_url":"https://api.github.com/users/anewton1998/repos","events_url":"https://api.github.com/users/anewton1998/events{/privacy}","received_events_url":"https://api.github.com/users/anewton1998/received_events","type":"User","site_admin":false},"created_at":"2018-03-22T14:12:27Z","updated_at":"2018-03-22T14:12:27Z","author_association":"CONTRIBUTOR","body":"Are we not doing `@{default $rule_name}`?"}}
{"actor":{"display_login":"anewton1998"}}