{"action":"created","comment":{"url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/comments/174570145","pull_request_review_id":103951187,"id":174570145,"diff_hunk":"@@ -52,7 +61,7 @@ $(d)/deps: $(SHARNESS_$(d)) $$(DEPS_$(d)) # use second expansion so coverage can\n test_sharness_deps: $(d)/deps\n .PHONY: test_sharness_deps\n \n-test_sharness_short: $(d)/aggregate\n+test_sharness_short: $(d)/aggregate $(d)/junit_xml","path":"test/sharness/Rules.mk","position":29,"original_position":29,"commit_id":"cf76cf2fad359d8beada1053e0f901522fd527af","original_commit_id":"cf76cf2fad359d8beada1053e0f901522fd527af","user":{"login":"Kubuxu","id":2259282,"avatar_url":"https://avatars3.githubusercontent.com/u/2259282?v=4","gravatar_id":"","url":"https://api.github.com/users/Kubuxu","html_url":"https://github.com/Kubuxu","followers_url":"https://api.github.com/users/Kubuxu/followers","following_url":"https://api.github.com/users/Kubuxu/following{/other_user}","gists_url":"https://api.github.com/users/Kubuxu/gists{/gist_id}","starred_url":"https://api.github.com/users/Kubuxu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kubuxu/subscriptions","organizations_url":"https://api.github.com/users/Kubuxu/orgs","repos_url":"https://api.github.com/users/Kubuxu/repos","events_url":"https://api.github.com/users/Kubuxu/events{/privacy}","received_events_url":"https://api.github.com/users/Kubuxu/received_events","type":"User","site_admin":false},"body":"Most users won't need the JUnit xmls so there is no reason to create them for them.","created_at":"2018-03-14T18:43:46Z","updated_at":"2018-03-14T18:43:46Z","html_url":"https://github.com/ipfs/go-ipfs/pull/4530#discussion_r174570145","pull_request_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/4530","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/comments/174570145"},"html":{"href":"https://github.com/ipfs/go-ipfs/pull/4530#discussion_r174570145"},"pull_request":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/4530"}}},"pull_request":{"url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/4530","id":160454037,"html_url":"https://github.com/ipfs/go-ipfs/pull/4530","diff_url":"https://github.com/ipfs/go-ipfs/pull/4530.diff","patch_url":"https://github.com/ipfs/go-ipfs/pull/4530.patch","issue_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/4530","number":4530,"state":"open","locked":false,"title":"sharness: Generate JUnit test reports","user":{"login":"magik6k","id":3867941,"avatar_url":"https://avatars0.githubusercontent.com/u/3867941?v=4","gravatar_id":"","url":"https://api.github.com/users/magik6k","html_url":"https://github.com/magik6k","followers_url":"https://api.github.com/users/magik6k/followers","following_url":"https://api.github.com/users/magik6k/following{/other_user}","gists_url":"https://api.github.com/users/magik6k/gists{/gist_id}","starred_url":"https://api.github.com/users/magik6k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magik6k/subscriptions","organizations_url":"https://api.github.com/users/magik6k/orgs","repos_url":"https://api.github.com/users/magik6k/repos","events_url":"https://api.github.com/users/magik6k/events{/privacy}","received_events_url":"https://api.github.com/users/magik6k/received_events","type":"User","site_admin":false},"body":"This makes sharness generate a JUnit XML report that can be used by Jenkins to view test results in a bit nicer form than a huge txt file (removing the fun of wasting few minutes to find the failure each time one happens). The report is saved as `test/sharness/test-results/sharness.xml`.\r\n\r\nExample report: https://ipfs.io/ipfs/QmZVCjX2L9DrbqYaVeVzTXZZUbyQvTM3mTUmzeMCoN8Pqc/sharness.xml - [HTML from junit2html](https://ipfs.io/ipfs/QmZVCjX2L9DrbqYaVeVzTXZZUbyQvTM3mTUmzeMCoN8Pqc/sharness.xml.html) - Jenkins should show failures at the top ([like here](https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fjs-ipfs-unixfs-engine/detail/PR-200/2/tests))\r\n\r\nSomewhat depends on https://github.com/ipfs/jenkins/pull/85","created_at":"2017-12-28T23:09:15Z","updated_at":"2018-03-14T18:43:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04ad8bc6617202abd5e092cd6fc20fda6e75f0e2","assignee":{"login":"magik6k","id":3867941,"avatar_url":"https://avatars0.githubusercontent.com/u/3867941?v=4","gravatar_id":"","url":"https://api.github.com/users/magik6k","html_url":"https://github.com/magik6k","followers_url":"https://api.github.com/users/magik6k/followers","following_url":"https://api.github.com/users/magik6k/following{/other_user}","gists_url":"https://api.github.com/users/magik6k/gists{/gist_id}","starred_url":"https://api.github.com/users/magik6k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magik6k/subscriptions","organizations_url":"https://api.github.com/users/magik6k/orgs","repos_url":"https://api.github.com/users/magik6k/repos","events_url":"https://api.github.com/users/magik6k/events{/privacy}","received_events_url":"https://api.github.com/users/magik6k/received_events","type":"User","site_admin":false},"assignees":[{"login":"magik6k","id":3867941,"avatar_url":"https://avatars0.githubusercontent.com/u/3867941?v=4","gravatar_id":"","url":"https://api.github.com/users/magik6k","html_url":"https://github.com/magik6k","followers_url":"https://api.github.com/users/magik6k/followers","following_url":"https://api.github.com/users/magik6k/following{/other_user}","gists_url":"https://api.github.com/users/magik6k/gists{/gist_id}","starred_url":"https://api.github.com/users/magik6k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magik6k/subscriptions","organizations_url":"https://api.github.com/users/magik6k/orgs","repos_url":"https://api.github.com/users/magik6k/repos","events_url":"https://api.github.com/users/magik6k/events{/privacy}","received_events_url":"https://api.github.com/users/magik6k/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":129070658,"url":"https://api.github.com/repos/ipfs/go-ipfs/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":314352911,"url":"https://api.github.com/repos/ipfs/go-ipfs/labels/needs%20review","name":"needs review","color":"0052cc","default":false},{"id":184384634,"url":"https://api.github.com/repos/ipfs/go-ipfs/labels/testing","name":"testing","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/4530/commits","review_comments_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/4530/comments","review_comment_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/4530/comments","statuses_url":"https://api.github.com/repos/ipfs/go-ipfs/statuses/cf76cf2fad359d8beada1053e0f901522fd527af","head":{"label":"ipfs:feat/sharness-junit","ref":"feat/sharness-junit","sha":"cf76cf2fad359d8beada1053e0f901522fd527af","user":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"repo":{"id":21233191,"name":"go-ipfs","full_name":"ipfs/go-ipfs","owner":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ipfs/go-ipfs","description":"IPFS implementation in go","fork":false,"url":"https://api.github.com/repos/ipfs/go-ipfs","forks_url":"https://api.github.com/repos/ipfs/go-ipfs/forks","keys_url":"https://api.github.com/repos/ipfs/go-ipfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipfs/go-ipfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipfs/go-ipfs/teams","hooks_url":"https://api.github.com/repos/ipfs/go-ipfs/hooks","issue_events_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/events{/number}","events_url":"https://api.github.com/repos/ipfs/go-ipfs/events","assignees_url":"https://api.github.com/repos/ipfs/go-ipfs/assignees{/user}","branches_url":"https://api.github.com/repos/ipfs/go-ipfs/branches{/branch}","tags_url":"https://api.github.com/repos/ipfs/go-ipfs/tags","blobs_url":"https://api.github.com/repos/ipfs/go-ipfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipfs/go-ipfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipfs/go-ipfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipfs/go-ipfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipfs/go-ipfs/statuses/{sha}","languages_url":"https://api.github.com/repos/ipfs/go-ipfs/languages","stargazers_url":"https://api.github.com/repos/ipfs/go-ipfs/stargazers","contributors_url":"https://api.github.com/repos/ipfs/go-ipfs/contributors","subscribers_url":"https://api.github.com/repos/ipfs/go-ipfs/subscribers","subscription_url":"https://api.github.com/repos/ipfs/go-ipfs/subscription","commits_url":"https://api.github.com/repos/ipfs/go-ipfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipfs/go-ipfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipfs/go-ipfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipfs/go-ipfs/contents/{+path}","compare_url":"https://api.github.com/repos/ipfs/go-ipfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipfs/go-ipfs/merges","archive_url":"https://api.github.com/repos/ipfs/go-ipfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipfs/go-ipfs/downloads","issues_url":"https://api.github.com/repos/ipfs/go-ipfs/issues{/number}","pulls_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls{/number}","milestones_url":"https://api.github.com/repos/ipfs/go-ipfs/milestones{/number}","notifications_url":"https://api.github.com/repos/ipfs/go-ipfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipfs/go-ipfs/labels{/name}","releases_url":"https://api.github.com/repos/ipfs/go-ipfs/releases{/id}","deployments_url":"https://api.github.com/repos/ipfs/go-ipfs/deployments","created_at":"2014-06-26T08:14:34Z","updated_at":"2018-03-14T18:08:30Z","pushed_at":"2018-03-14T18:30:22Z","git_url":"git://github.com/ipfs/go-ipfs.git","ssh_url":"git@github.com:ipfs/go-ipfs.git","clone_url":"https://github.com/ipfs/go-ipfs.git","svn_url":"https://github.com/ipfs/go-ipfs","homepage":"https://github.com/ipfs/ipfs","size":28940,"stargazers_count":4833,"watchers_count":4833,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":817,"mirror_url":null,"archived":false,"open_issues_count":876,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":817,"open_issues":876,"watchers":4833,"default_branch":"master"}},"base":{"label":"ipfs:master","ref":"master","sha":"ba3cd5b38d5b2e7b07312a3c61231073cdb81d86","user":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"repo":{"id":21233191,"name":"go-ipfs","full_name":"ipfs/go-ipfs","owner":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ipfs/go-ipfs","description":"IPFS implementation in go","fork":false,"url":"https://api.github.com/repos/ipfs/go-ipfs","forks_url":"https://api.github.com/repos/ipfs/go-ipfs/forks","keys_url":"https://api.github.com/repos/ipfs/go-ipfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipfs/go-ipfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipfs/go-ipfs/teams","hooks_url":"https://api.github.com/repos/ipfs/go-ipfs/hooks","issue_events_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/events{/number}","events_url":"https://api.github.com/repos/ipfs/go-ipfs/events","assignees_url":"https://api.github.com/repos/ipfs/go-ipfs/assignees{/user}","branches_url":"https://api.github.com/repos/ipfs/go-ipfs/branches{/branch}","tags_url":"https://api.github.com/repos/ipfs/go-ipfs/tags","blobs_url":"https://api.github.com/repos/ipfs/go-ipfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipfs/go-ipfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipfs/go-ipfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipfs/go-ipfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipfs/go-ipfs/statuses/{sha}","languages_url":"https://api.github.com/repos/ipfs/go-ipfs/languages","stargazers_url":"https://api.github.com/repos/ipfs/go-ipfs/stargazers","contributors_url":"https://api.github.com/repos/ipfs/go-ipfs/contributors","subscribers_url":"https://api.github.com/repos/ipfs/go-ipfs/subscribers","subscription_url":"https://api.github.com/repos/ipfs/go-ipfs/subscription","commits_url":"https://api.github.com/repos/ipfs/go-ipfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipfs/go-ipfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipfs/go-ipfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipfs/go-ipfs/contents/{+path}","compare_url":"https://api.github.com/repos/ipfs/go-ipfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipfs/go-ipfs/merges","archive_url":"https://api.github.com/repos/ipfs/go-ipfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipfs/go-ipfs/downloads","issues_url":"https://api.github.com/repos/ipfs/go-ipfs/issues{/number}","pulls_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls{/number}","milestones_url":"https://api.github.com/repos/ipfs/go-ipfs/milestones{/number}","notifications_url":"https://api.github.com/repos/ipfs/go-ipfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipfs/go-ipfs/labels{/name}","releases_url":"https://api.github.com/repos/ipfs/go-ipfs/releases{/id}","deployments_url":"https://api.github.com/repos/ipfs/go-ipfs/deployments","created_at":"2014-06-26T08:14:34Z","updated_at":"2018-03-14T18:08:30Z","pushed_at":"2018-03-14T18:30:22Z","git_url":"git://github.com/ipfs/go-ipfs.git","ssh_url":"git@github.com:ipfs/go-ipfs.git","clone_url":"https://github.com/ipfs/go-ipfs.git","svn_url":"https://github.com/ipfs/go-ipfs","homepage":"https://github.com/ipfs/ipfs","size":28940,"stargazers_count":4833,"watchers_count":4833,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":817,"mirror_url":null,"archived":false,"open_issues_count":876,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":817,"open_issues":876,"watchers":4833,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/4530"},"html":{"href":"https://github.com/ipfs/go-ipfs/pull/4530"},"issue":{"href":"https://api.github.com/repos/ipfs/go-ipfs/issues/4530"},"comments":{"href":"https://api.github.com/repos/ipfs/go-ipfs/issues/4530/comments"},"review_comments":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/4530/comments"},"review_comment":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/4530/commits"},"statuses":{"href":"https://api.github.com/repos/ipfs/go-ipfs/statuses/cf76cf2fad359d8beada1053e0f901522fd527af"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Kubuxu"}}