{"action":"created","issue":{"url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/7206","repository_url":"https://api.github.com/repos/shuyangzhou/liferay-portal","labels_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/7206/labels{/name}","comments_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/7206/comments","events_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/7206/events","html_url":"https://github.com/shuyangzhou/liferay-portal/pull/7206","id":391791156,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MjA2MzY2","number":7206,"title":"[TECHNICAL-SUPPORT] LPS-88427","user":{"login":"SamZiemer","id":8029905,"node_id":"MDQ6VXNlcjgwMjk5MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/8029905?v=4","gravatar_id":"","url":"https://api.github.com/users/SamZiemer","html_url":"https://github.com/SamZiemer","followers_url":"https://api.github.com/users/SamZiemer/followers","following_url":"https://api.github.com/users/SamZiemer/following{/other_user}","gists_url":"https://api.github.com/users/SamZiemer/gists{/gist_id}","starred_url":"https://api.github.com/users/SamZiemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamZiemer/subscriptions","organizations_url":"https://api.github.com/users/SamZiemer/orgs","repos_url":"https://api.github.com/users/SamZiemer/repos","events_url":"https://api.github.com/users/SamZiemer/events{/privacy}","received_events_url":"https://api.github.com/users/SamZiemer/received_events","type":"User","site_admin":false},"labels":[{"id":936910319,"node_id":"MDU6TGFiZWw5MzY5MTAzMTk=","url":"https://api.github.com/repos/shuyangzhou/liferay-portal/labels/ci:test:relevant%20-%20failure","name":"ci:test:relevant - failure","color":"fccdcc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-12-17T16:29:53Z","updated_at":"2018-12-18T19:03:37Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/7206","html_url":"https://github.com/shuyangzhou/liferay-portal/pull/7206","diff_url":"https://github.com/shuyangzhou/liferay-portal/pull/7206.diff","patch_url":"https://github.com/shuyangzhou/liferay-portal/pull/7206.patch"},"body":"/cc @diana-lin \r\n\r\n**LPS**: https://issues.liferay.com/browse/LPS-88427\r\n\r\nNotes from @diana-lin \r\n\r\n> **Problem**:  In 6.2, [LocalizationImpl.getLocalizationXmlFromPreferences (6.2.x)](https://github.com/liferay/liferay-portal/blob/6.2.x/portal-impl/src/com/liferay/portal/util/LocalizationImpl.java#L483-L517) returns the value passed in the parameter `defaultValue` if the portlet preferences are empty.  In master, the [LocalizationImpl.getLocalizationXmlFromPreferences (master)](https://github.com/liferay/liferay-portal/blob/master/portal-impl/src/com/liferay/portal/util/LocalizationImpl.java#L594-L645) returns `null` if the portlet preferences are empty.\r\n> \r\n> When looking at the implementation, it is apparent that the order of parameters is incorrect ([ref](https://github.com/liferay/liferay-portal/blob/master/portal-impl/src/com/liferay/portal/util/LocalizationImpl.java#L594-L645)).  Notice the order of input parameters `prefix` and `defaultValue` in the method signature\r\n> \r\n> ```\r\n> public String getLocalizationXmlFromPreferences(\r\n> \t\tPortletPreferences preferences, PortletRequest portletRequest,\r\n> \t\tString parameter, String prefix, String defaultValue) {\r\n>           ...\r\n> }\r\n> ```\r\n> \r\n> in comparison to the input parameters `prefix` and `defaultValue` in the method call\r\n> \r\n> ```\r\n> @Override\r\n> public String getLocalizationXmlFromPreferences(\r\n> \tPortletPreferences preferences, PortletRequest portletRequest,\r\n> \tString parameter, String defaultValue) {\r\n> \r\n> \treturn getLocalizationXmlFromPreferences(\r\n> \t\tpreferences, portletRequest, parameter, defaultValue, null);\r\n> }\r\n> ```\r\n> \r\n> **Solution**:  Change the order of the input parameters `null` and `defaultValue` in the method call."},"comment":{"url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/comments/448332908","html_url":"https://github.com/shuyangzhou/liferay-portal/pull/7206#issuecomment-448332908","issue_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/7206","id":448332908,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODMzMjkwOA==","user":{"login":"Preston-Crary","id":1714297,"node_id":"MDQ6VXNlcjE3MTQyOTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1714297?v=4","gravatar_id":"","url":"https://api.github.com/users/Preston-Crary","html_url":"https://github.com/Preston-Crary","followers_url":"https://api.github.com/users/Preston-Crary/followers","following_url":"https://api.github.com/users/Preston-Crary/following{/other_user}","gists_url":"https://api.github.com/users/Preston-Crary/gists{/gist_id}","starred_url":"https://api.github.com/users/Preston-Crary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Preston-Crary/subscriptions","organizations_url":"https://api.github.com/users/Preston-Crary/orgs","repos_url":"https://api.github.com/users/Preston-Crary/repos","events_url":"https://api.github.com/users/Preston-Crary/events{/privacy}","received_events_url":"https://api.github.com/users/Preston-Crary/received_events","type":"User","site_admin":false},"created_at":"2018-12-18T19:03:37Z","updated_at":"2018-12-18T19:03:37Z","author_association":"NONE","body":"Please see https://github.com/brianchandotcom/liferay-portal/pull/66028"}}
{"actor":{"display_login":"Preston-Crary"}}