{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/19398","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/19398/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/19398/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/19398/events","html_url":"https://github.com/nodejs/node/pull/19398","id":306034032,"number":19398,"title":"vm: move options checks from C++ to JS","user":{"login":"targos","id":2352663,"avatar_url":"https://avatars0.githubusercontent.com/u/2352663?v=4","gravatar_id":"","url":"https://api.github.com/users/targos","html_url":"https://github.com/targos","followers_url":"https://api.github.com/users/targos/followers","following_url":"https://api.github.com/users/targos/following{/other_user}","gists_url":"https://api.github.com/users/targos/gists{/gist_id}","starred_url":"https://api.github.com/users/targos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/targos/subscriptions","organizations_url":"https://api.github.com/users/targos/orgs","repos_url":"https://api.github.com/users/targos/repos","events_url":"https://api.github.com/users/targos/events{/privacy}","received_events_url":"https://api.github.com/users/targos/received_events","type":"User","site_admin":false},"labels":[{"id":155267502,"url":"https://api.github.com/repos/nodejs/node/labels/C++","name":"C++","color":"e11d21","default":false},{"id":458724661,"url":"https://api.github.com/repos/nodejs/node/labels/errors","name":"errors","color":"ededed","default":false},{"id":281232761,"url":"https://api.github.com/repos/nodejs/node/labels/lib%20/%20src","name":"lib / src","color":"fad8c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-03-16T18:31:13Z","updated_at":"2018-03-30T11:00:06Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/19398","html_url":"https://github.com/nodejs/node/pull/19398","diff_url":"https://github.com/nodejs/node/pull/19398.diff","patch_url":"https://github.com/nodejs/node/pull/19398.patch"},"body":"~I tried to keep the type checking as it was done in C++ (not very strict for some options).~ -> Now all options are checked more strictly.\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/377502067","html_url":"https://github.com/nodejs/node/pull/19398#issuecomment-377502067","issue_url":"https://api.github.com/repos/nodejs/node/issues/19398","id":377502067,"user":{"login":"targos","id":2352663,"avatar_url":"https://avatars0.githubusercontent.com/u/2352663?v=4","gravatar_id":"","url":"https://api.github.com/users/targos","html_url":"https://github.com/targos","followers_url":"https://api.github.com/users/targos/followers","following_url":"https://api.github.com/users/targos/following{/other_user}","gists_url":"https://api.github.com/users/targos/gists{/gist_id}","starred_url":"https://api.github.com/users/targos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/targos/subscriptions","organizations_url":"https://api.github.com/users/targos/orgs","repos_url":"https://api.github.com/users/targos/repos","events_url":"https://api.github.com/users/targos/events{/privacy}","received_events_url":"https://api.github.com/users/targos/received_events","type":"User","site_admin":false},"created_at":"2018-03-30T11:00:06Z","updated_at":"2018-03-30T11:00:06Z","author_association":"OWNER","body":"So... This breaks gulp 3 because it depends on \r\n- vinyl-fs, which depends on\r\n- graceful-fs, which depends on\r\n- [`natives`](https://github.com/isaacs/natives) that uses `process.binding('contextify').ContextifyScript` directly.\r\n\r\nHow do we proceed?\r\n\r\n/cc @nodejs/tsc "}}
{"actor":{"display_login":"targos"}}