{"action":"created","issue":{"url":"https://api.github.com/repos/jgrapht/jgrapht/issues/706","repository_url":"https://api.github.com/repos/jgrapht/jgrapht","labels_url":"https://api.github.com/repos/jgrapht/jgrapht/issues/706/labels{/name}","comments_url":"https://api.github.com/repos/jgrapht/jgrapht/issues/706/comments","events_url":"https://api.github.com/repos/jgrapht/jgrapht/issues/706/events","html_url":"https://github.com/jgrapht/jgrapht/pull/706","id":375354557,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2ODE3Mjk4","number":706,"title":"DOT graph and HTML-Like attributes, alternative","user":{"login":"PHaroZ","id":1915012,"node_id":"MDQ6VXNlcjE5MTUwMTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1915012?v=4","gravatar_id":"","url":"https://api.github.com/users/PHaroZ","html_url":"https://github.com/PHaroZ","followers_url":"https://api.github.com/users/PHaroZ/followers","following_url":"https://api.github.com/users/PHaroZ/following{/other_user}","gists_url":"https://api.github.com/users/PHaroZ/gists{/gist_id}","starred_url":"https://api.github.com/users/PHaroZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PHaroZ/subscriptions","organizations_url":"https://api.github.com/users/PHaroZ/orgs","repos_url":"https://api.github.com/users/PHaroZ/repos","events_url":"https://api.github.com/users/PHaroZ/events{/privacy}","received_events_url":"https://api.github.com/users/PHaroZ/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-30T07:30:23Z","updated_at":"2018-10-30T17:31:34Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/jgrapht/jgrapht/pulls/706","html_url":"https://github.com/jgrapht/jgrapht/pull/706","diff_url":"https://github.com/jgrapht/jgrapht/pull/706.diff","patch_url":"https://github.com/jgrapht/jgrapht/pull/706.patch"},"body":"Fixes support of HTML-like attribute in DOT graph export.\r\n\r\nThis is an alternative to #705 as it introduce a new `AttributeType.HTML`. More details in #698\r\n\r\n<!-- describe the changes you have made here: what, why, …\r\n     Link issues by using the following pattern: [#333](https://github.com/jgrapht/jgrapht/issues/333).\r\n     The title of the PR must not reference an issue, because GitHub does not support autolinking there. -->\r\n\r\n----\r\n\r\n- [x] I read and understood <https://github.com/jgrapht/jgrapht/wiki/Become-a-Contributor>\r\n- [x] I read and understood <https://github.com/jgrapht/jgrapht/wiki/How-to-make-your-first-%28code%29-contribution>\r\n- [x] I added [unit tests](https://github.com/jgrapht/jgrapht/wiki/Unit-testing)\r\n- [x] I added [documentation](https://github.com/jgrapht/jgrapht/wiki/How-to-write-documentation)\r\n- [x] I followed the [Coding and Style Conventions](https://github.com/jgrapht/jgrapht/wiki/Coding-and-Style-Conventions)\r\n- [x] I **have not** modified `HISTORY.md` or `CONTRIBUTORS.md`\r\n- [x] I ensured that [the git commit message is a good one](https://github.com/joelparkerhenderson/git_commit_message)\r\n"},"comment":{"url":"https://api.github.com/repos/jgrapht/jgrapht/issues/comments/434397073","html_url":"https://github.com/jgrapht/jgrapht/pull/706#issuecomment-434397073","issue_url":"https://api.github.com/repos/jgrapht/jgrapht/issues/706","id":434397073,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDM5NzA3Mw==","user":{"login":"d-michail","id":15940875,"node_id":"MDQ6VXNlcjE1OTQwODc1","avatar_url":"https://avatars0.githubusercontent.com/u/15940875?v=4","gravatar_id":"","url":"https://api.github.com/users/d-michail","html_url":"https://github.com/d-michail","followers_url":"https://api.github.com/users/d-michail/followers","following_url":"https://api.github.com/users/d-michail/following{/other_user}","gists_url":"https://api.github.com/users/d-michail/gists{/gist_id}","starred_url":"https://api.github.com/users/d-michail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-michail/subscriptions","organizations_url":"https://api.github.com/users/d-michail/orgs","repos_url":"https://api.github.com/users/d-michail/repos","events_url":"https://api.github.com/users/d-michail/events{/privacy}","received_events_url":"https://api.github.com/users/d-michail/received_events","type":"User","site_admin":false},"created_at":"2018-10-30T17:31:34Z","updated_at":"2018-10-30T17:31:34Z","author_association":"COLLABORATOR","body":"What I meant is that the user would provide the attributes. We do not want to force HTML output if it starts with `<` and ends with `>`. \r\n\r\nThe changes should happen only in `renderAttributes`. The exporter should just check whether the attribute type is `HTML` (as provided by the user). If it is `HTML` then it outputs without the `\\\"`. Otherwise it outputs with the `\\\"`.\r\n\r\nMaybe I want `label=<my label which is not html>`. This is not HTML and should be rendered as string.\r\n\r\n\r\n"}}
{"actor":{"display_login":"d-michail"}}