{"action":"created","comment":{"url":"https://api.github.com/repos/bvcms/bvcms/pulls/comments/225316316","pull_request_review_id":164895436,"id":225316316,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTMxNjMxNg==","diff_hunk":"@@ -0,0 +1,97 @@\n+﻿SET QUOTED_IDENTIFIER ON\n+SET ANSI_NULLS ON\n+GO\n+ALTER FUNCTION [dbo].[Contributions2]\n+(\n+\t@fd DATETIME, \n+\t@td DATETIME,\n+\t@campusid INT,\n+\t@pledges BIT,\n+\t@nontaxded BIT,\n+\t@includeUnclosed BIT\n+)\n+RETURNS TABLE \n+AS\n+RETURN \n+(\n+SELECT \n+\tp.FamilyId,\n+\tp.PeopleId,\n+    c.ContributionDate AS Date,\n+    \n+    CASE WHEN fa.HeadOfHouseholdId = sp.PeopleId\n+\t\t\tAND ISNULL(sp.ContributionOptionsId, CASE WHEN sp.MaritalStatusId = 20 THEN 2 ELSE 1 END) = 2","path":"CmsData/Migrations/20181013_update_contributions2_func.sql","position":23,"original_position":23,"commit_id":"b8f5ad9a755b23be96c6af94a81314d389ee8fe8","original_commit_id":"b8f5ad9a755b23be96c6af94a81314d389ee8fe8","user":{"login":"brondavies","id":2912683,"node_id":"MDQ6VXNlcjI5MTI2ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/2912683?v=4","gravatar_id":"","url":"https://api.github.com/users/brondavies","html_url":"https://github.com/brondavies","followers_url":"https://api.github.com/users/brondavies/followers","following_url":"https://api.github.com/users/brondavies/following{/other_user}","gists_url":"https://api.github.com/users/brondavies/gists{/gist_id}","starred_url":"https://api.github.com/users/brondavies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brondavies/subscriptions","organizations_url":"https://api.github.com/users/brondavies/orgs","repos_url":"https://api.github.com/users/brondavies/repos","events_url":"https://api.github.com/users/brondavies/events{/privacy}","received_events_url":"https://api.github.com/users/brondavies/received_events","type":"User","site_admin":false},"body":"We now have a `Married` flag on the MaritalStatus lookup table so that custom-created status lookups can be treated as \"Married\"  So, instead of `WHEN sp.MaritalStatusId = 2` join to the lookup table and check `MaritalStatus.Married=1`","created_at":"2018-10-15T21:04:36Z","updated_at":"2018-10-15T21:04:36Z","html_url":"https://github.com/bvcms/bvcms/pull/296#discussion_r225316316","pull_request_url":"https://api.github.com/repos/bvcms/bvcms/pulls/296","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bvcms/bvcms/pulls/comments/225316316"},"html":{"href":"https://github.com/bvcms/bvcms/pull/296#discussion_r225316316"},"pull_request":{"href":"https://api.github.com/repos/bvcms/bvcms/pulls/296"}}},"pull_request":{"url":"https://api.github.com/repos/bvcms/bvcms/pulls/296","id":222712239,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNzEyMjM5","html_url":"https://github.com/bvcms/bvcms/pull/296","diff_url":"https://github.com/bvcms/bvcms/pull/296.diff","patch_url":"https://github.com/bvcms/bvcms/pull/296.patch","issue_url":"https://api.github.com/repos/bvcms/bvcms/issues/296","number":296,"state":"open","locked":false,"title":"Giving dashboard","user":{"login":"davidcarroll","id":920203,"node_id":"MDQ6VXNlcjkyMDIwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/920203?v=4","gravatar_id":"","url":"https://api.github.com/users/davidcarroll","html_url":"https://github.com/davidcarroll","followers_url":"https://api.github.com/users/davidcarroll/followers","following_url":"https://api.github.com/users/davidcarroll/following{/other_user}","gists_url":"https://api.github.com/users/davidcarroll/gists{/gist_id}","starred_url":"https://api.github.com/users/davidcarroll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidcarroll/subscriptions","organizations_url":"https://api.github.com/users/davidcarroll/orgs","repos_url":"https://api.github.com/users/davidcarroll/repos","events_url":"https://api.github.com/users/davidcarroll/events{/privacy}","received_events_url":"https://api.github.com/users/davidcarroll/received_events","type":"User","site_admin":false},"body":"This PR will facilitate a recipe I am working on to display a Giving Dashboard.\r\n\r\nThe updated SQL function Contributions2 has 3 new columns to allow filtering contributions by Source and other things.\r\n\r\nThe change to ScriptController allows setting breakpoints in a Python script for debugging. Also, it removes a try catch during debugging so that the full stack trace will display on the dev machine.\r\n\r\nThe SQL function changes are needed ASAP so that the Giving Dashboard Python script can be tested and demoed to the client this week.","created_at":"2018-10-14T12:22:22Z","updated_at":"2018-10-15T21:04:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bvcms/bvcms/pulls/296/commits","review_comments_url":"https://api.github.com/repos/bvcms/bvcms/pulls/296/comments","review_comment_url":"https://api.github.com/repos/bvcms/bvcms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bvcms/bvcms/issues/296/comments","statuses_url":"https://api.github.com/repos/bvcms/bvcms/statuses/b8f5ad9a755b23be96c6af94a81314d389ee8fe8","head":{"label":"davidcarroll:GivingDashboard","ref":"GivingDashboard","sha":"b8f5ad9a755b23be96c6af94a81314d389ee8fe8","user":{"login":"davidcarroll","id":920203,"node_id":"MDQ6VXNlcjkyMDIwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/920203?v=4","gravatar_id":"","url":"https://api.github.com/users/davidcarroll","html_url":"https://github.com/davidcarroll","followers_url":"https://api.github.com/users/davidcarroll/followers","following_url":"https://api.github.com/users/davidcarroll/following{/other_user}","gists_url":"https://api.github.com/users/davidcarroll/gists{/gist_id}","starred_url":"https://api.github.com/users/davidcarroll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidcarroll/subscriptions","organizations_url":"https://api.github.com/users/davidcarroll/orgs","repos_url":"https://api.github.com/users/davidcarroll/repos","events_url":"https://api.github.com/users/davidcarroll/events{/privacy}","received_events_url":"https://api.github.com/users/davidcarroll/received_events","type":"User","site_admin":false},"repo":{"id":150130658,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAxMzA2NTg=","name":"bvcms","full_name":"davidcarroll/bvcms","private":false,"owner":{"login":"davidcarroll","id":920203,"node_id":"MDQ6VXNlcjkyMDIwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/920203?v=4","gravatar_id":"","url":"https://api.github.com/users/davidcarroll","html_url":"https://github.com/davidcarroll","followers_url":"https://api.github.com/users/davidcarroll/followers","following_url":"https://api.github.com/users/davidcarroll/following{/other_user}","gists_url":"https://api.github.com/users/davidcarroll/gists{/gist_id}","starred_url":"https://api.github.com/users/davidcarroll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidcarroll/subscriptions","organizations_url":"https://api.github.com/users/davidcarroll/orgs","repos_url":"https://api.github.com/users/davidcarroll/repos","events_url":"https://api.github.com/users/davidcarroll/events{/privacy}","received_events_url":"https://api.github.com/users/davidcarroll/received_events","type":"User","site_admin":false},"html_url":"https://github.com/davidcarroll/bvcms","description":"The open source church management system","fork":true,"url":"https://api.github.com/repos/davidcarroll/bvcms","forks_url":"https://api.github.com/repos/davidcarroll/bvcms/forks","keys_url":"https://api.github.com/repos/davidcarroll/bvcms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidcarroll/bvcms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidcarroll/bvcms/teams","hooks_url":"https://api.github.com/repos/davidcarroll/bvcms/hooks","issue_events_url":"https://api.github.com/repos/davidcarroll/bvcms/issues/events{/number}","events_url":"https://api.github.com/repos/davidcarroll/bvcms/events","assignees_url":"https://api.github.com/repos/davidcarroll/bvcms/assignees{/user}","branches_url":"https://api.github.com/repos/davidcarroll/bvcms/branches{/branch}","tags_url":"https://api.github.com/repos/davidcarroll/bvcms/tags","blobs_url":"https://api.github.com/repos/davidcarroll/bvcms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidcarroll/bvcms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidcarroll/bvcms/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidcarroll/bvcms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidcarroll/bvcms/statuses/{sha}","languages_url":"https://api.github.com/repos/davidcarroll/bvcms/languages","stargazers_url":"https://api.github.com/repos/davidcarroll/bvcms/stargazers","contributors_url":"https://api.github.com/repos/davidcarroll/bvcms/contributors","subscribers_url":"https://api.github.com/repos/davidcarroll/bvcms/subscribers","subscription_url":"https://api.github.com/repos/davidcarroll/bvcms/subscription","commits_url":"https://api.github.com/repos/davidcarroll/bvcms/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidcarroll/bvcms/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidcarroll/bvcms/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidcarroll/bvcms/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidcarroll/bvcms/contents/{+path}","compare_url":"https://api.github.com/repos/davidcarroll/bvcms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidcarroll/bvcms/merges","archive_url":"https://api.github.com/repos/davidcarroll/bvcms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidcarroll/bvcms/downloads","issues_url":"https://api.github.com/repos/davidcarroll/bvcms/issues{/number}","pulls_url":"https://api.github.com/repos/davidcarroll/bvcms/pulls{/number}","milestones_url":"https://api.github.com/repos/davidcarroll/bvcms/milestones{/number}","notifications_url":"https://api.github.com/repos/davidcarroll/bvcms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidcarroll/bvcms/labels{/name}","releases_url":"https://api.github.com/repos/davidcarroll/bvcms/releases{/id}","deployments_url":"https://api.github.com/repos/davidcarroll/bvcms/deployments","created_at":"2018-09-24T16:07:25Z","updated_at":"2018-10-13T19:24:11Z","pushed_at":"2018-10-13T19:23:54Z","git_url":"git://github.com/davidcarroll/bvcms.git","ssh_url":"git@github.com:davidcarroll/bvcms.git","clone_url":"https://github.com/davidcarroll/bvcms.git","svn_url":"https://github.com/davidcarroll/bvcms","homepage":"http://touchpointsoftware.com","size":103258,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bvcms:master","ref":"master","sha":"3b756602b52e98490968bb34594cf57e010e8f7e","user":{"login":"bvcms","id":1605964,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDU5NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1605964?v=4","gravatar_id":"","url":"https://api.github.com/users/bvcms","html_url":"https://github.com/bvcms","followers_url":"https://api.github.com/users/bvcms/followers","following_url":"https://api.github.com/users/bvcms/following{/other_user}","gists_url":"https://api.github.com/users/bvcms/gists{/gist_id}","starred_url":"https://api.github.com/users/bvcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvcms/subscriptions","organizations_url":"https://api.github.com/users/bvcms/orgs","repos_url":"https://api.github.com/users/bvcms/repos","events_url":"https://api.github.com/users/bvcms/events{/privacy}","received_events_url":"https://api.github.com/users/bvcms/received_events","type":"Organization","site_admin":false},"repo":{"id":9797512,"node_id":"MDEwOlJlcG9zaXRvcnk5Nzk3NTEy","name":"bvcms","full_name":"bvcms/bvcms","private":false,"owner":{"login":"bvcms","id":1605964,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDU5NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1605964?v=4","gravatar_id":"","url":"https://api.github.com/users/bvcms","html_url":"https://github.com/bvcms","followers_url":"https://api.github.com/users/bvcms/followers","following_url":"https://api.github.com/users/bvcms/following{/other_user}","gists_url":"https://api.github.com/users/bvcms/gists{/gist_id}","starred_url":"https://api.github.com/users/bvcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvcms/subscriptions","organizations_url":"https://api.github.com/users/bvcms/orgs","repos_url":"https://api.github.com/users/bvcms/repos","events_url":"https://api.github.com/users/bvcms/events{/privacy}","received_events_url":"https://api.github.com/users/bvcms/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bvcms/bvcms","description":"The open source church management system","fork":false,"url":"https://api.github.com/repos/bvcms/bvcms","forks_url":"https://api.github.com/repos/bvcms/bvcms/forks","keys_url":"https://api.github.com/repos/bvcms/bvcms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bvcms/bvcms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bvcms/bvcms/teams","hooks_url":"https://api.github.com/repos/bvcms/bvcms/hooks","issue_events_url":"https://api.github.com/repos/bvcms/bvcms/issues/events{/number}","events_url":"https://api.github.com/repos/bvcms/bvcms/events","assignees_url":"https://api.github.com/repos/bvcms/bvcms/assignees{/user}","branches_url":"https://api.github.com/repos/bvcms/bvcms/branches{/branch}","tags_url":"https://api.github.com/repos/bvcms/bvcms/tags","blobs_url":"https://api.github.com/repos/bvcms/bvcms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bvcms/bvcms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bvcms/bvcms/git/refs{/sha}","trees_url":"https://api.github.com/repos/bvcms/bvcms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bvcms/bvcms/statuses/{sha}","languages_url":"https://api.github.com/repos/bvcms/bvcms/languages","stargazers_url":"https://api.github.com/repos/bvcms/bvcms/stargazers","contributors_url":"https://api.github.com/repos/bvcms/bvcms/contributors","subscribers_url":"https://api.github.com/repos/bvcms/bvcms/subscribers","subscription_url":"https://api.github.com/repos/bvcms/bvcms/subscription","commits_url":"https://api.github.com/repos/bvcms/bvcms/commits{/sha}","git_commits_url":"https://api.github.com/repos/bvcms/bvcms/git/commits{/sha}","comments_url":"https://api.github.com/repos/bvcms/bvcms/comments{/number}","issue_comment_url":"https://api.github.com/repos/bvcms/bvcms/issues/comments{/number}","contents_url":"https://api.github.com/repos/bvcms/bvcms/contents/{+path}","compare_url":"https://api.github.com/repos/bvcms/bvcms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bvcms/bvcms/merges","archive_url":"https://api.github.com/repos/bvcms/bvcms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bvcms/bvcms/downloads","issues_url":"https://api.github.com/repos/bvcms/bvcms/issues{/number}","pulls_url":"https://api.github.com/repos/bvcms/bvcms/pulls{/number}","milestones_url":"https://api.github.com/repos/bvcms/bvcms/milestones{/number}","notifications_url":"https://api.github.com/repos/bvcms/bvcms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bvcms/bvcms/labels{/name}","releases_url":"https://api.github.com/repos/bvcms/bvcms/releases{/id}","deployments_url":"https://api.github.com/repos/bvcms/bvcms/deployments","created_at":"2013-05-01T18:38:13Z","updated_at":"2018-10-15T21:02:06Z","pushed_at":"2018-10-15T21:02:04Z","git_url":"git://github.com/bvcms/bvcms.git","ssh_url":"git@github.com:bvcms/bvcms.git","clone_url":"https://github.com/bvcms/bvcms.git","svn_url":"https://github.com/bvcms/bvcms","homepage":"http://touchpointsoftware.com","size":103285,"stargazers_count":61,"watchers_count":61,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":52,"open_issues":7,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bvcms/bvcms/pulls/296"},"html":{"href":"https://github.com/bvcms/bvcms/pull/296"},"issue":{"href":"https://api.github.com/repos/bvcms/bvcms/issues/296"},"comments":{"href":"https://api.github.com/repos/bvcms/bvcms/issues/296/comments"},"review_comments":{"href":"https://api.github.com/repos/bvcms/bvcms/pulls/296/comments"},"review_comment":{"href":"https://api.github.com/repos/bvcms/bvcms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bvcms/bvcms/pulls/296/commits"},"statuses":{"href":"https://api.github.com/repos/bvcms/bvcms/statuses/b8f5ad9a755b23be96c6af94a81314d389ee8fe8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"brondavies"}}