{"action":"created","issue":{"url":"https://api.github.com/repos/openhab/openhab2-addons/issues/4428","repository_url":"https://api.github.com/repos/openhab/openhab2-addons","labels_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/4428/labels{/name}","comments_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/4428/comments","events_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/4428/events","html_url":"https://github.com/openhab/openhab2-addons/pull/4428","id":393744409,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNjc4NDg3","number":4428,"title":"[hueemulation] Remove base type restriction from group items","user":{"login":"FlorianSW","id":4892966,"node_id":"MDQ6VXNlcjQ4OTI5NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/4892966?v=4","gravatar_id":"","url":"https://api.github.com/users/FlorianSW","html_url":"https://github.com/FlorianSW","followers_url":"https://api.github.com/users/FlorianSW/followers","following_url":"https://api.github.com/users/FlorianSW/following{/other_user}","gists_url":"https://api.github.com/users/FlorianSW/gists{/gist_id}","starred_url":"https://api.github.com/users/FlorianSW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FlorianSW/subscriptions","organizations_url":"https://api.github.com/users/FlorianSW/orgs","repos_url":"https://api.github.com/users/FlorianSW/repos","events_url":"https://api.github.com/users/FlorianSW/events{/privacy}","received_events_url":"https://api.github.com/users/FlorianSW/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-23T12:01:57Z","updated_at":"2018-12-30T18:58:28Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/4428","html_url":"https://github.com/openhab/openhab2-addons/pull/4428","diff_url":"https://github.com/openhab/openhab2-addons/pull/4428.diff","patch_url":"https://github.com/openhab/openhab2-addons/pull/4428.patch"},"body":"Given that this is not documented anywhere and given that the user already\r\nunderstands what they're doing when adding one of the hueemulation-used\r\ntags, restricting them to add a base type to a group doesn't seem to be\r\nreasonable. As this restriction makes debugging more complicated (\"Why\r\ndoes my group with the Lighting tag does not get discovered by\r\nhueemulation?\") this commit removes this restriction completely. As a\r\nresult, all groups with one of the supported tags, will be added to\r\nhueemulation discovery document.\r\n\r\nFixes #4379\r\n\r\nSigned-off-by: Florian <florian.schmidt.welzow@t-online.de>"},"comment":{"url":"https://api.github.com/repos/openhab/openhab2-addons/issues/comments/450580016","html_url":"https://github.com/openhab/openhab2-addons/pull/4428#issuecomment-450580016","issue_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/4428","id":450580016,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDU4MDAxNg==","user":{"login":"davidgraeff","id":66436,"node_id":"MDQ6VXNlcjY2NDM2","avatar_url":"https://avatars2.githubusercontent.com/u/66436?v=4","gravatar_id":"","url":"https://api.github.com/users/davidgraeff","html_url":"https://github.com/davidgraeff","followers_url":"https://api.github.com/users/davidgraeff/followers","following_url":"https://api.github.com/users/davidgraeff/following{/other_user}","gists_url":"https://api.github.com/users/davidgraeff/gists{/gist_id}","starred_url":"https://api.github.com/users/davidgraeff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidgraeff/subscriptions","organizations_url":"https://api.github.com/users/davidgraeff/orgs","repos_url":"https://api.github.com/users/davidgraeff/repos","events_url":"https://api.github.com/users/davidgraeff/events{/privacy}","received_events_url":"https://api.github.com/users/davidgraeff/received_events","type":"User","site_admin":false},"created_at":"2018-12-30T18:58:28Z","updated_at":"2018-12-30T18:58:28Z","author_association":"MEMBER","body":"I cannot test this at the moment, but when I looked at the changes a few days ago I remember that I saw a problem. \r\n@FlorianSW Can you please add a test or amend your test.\r\n1. Add an eligible group like in your current test\r\n1. Call the \"LightItems.updated()\" method with an updated group item that is not eligible anymore (correct tags removed)\r\n\r\nPlease check for \"ds.lights\" but also for \"ds.groups\", because group items are exposed as Hue Groups.\r\nThis test puts the support for groups on solid ground.\r\n\r\nThanks"}}
{"actor":{"display_login":"davidgraeff"}}