{"action":"created","issue":{"url":"https://api.github.com/repos/whatwg/dom/issues/582","repository_url":"https://api.github.com/repos/whatwg/dom","labels_url":"https://api.github.com/repos/whatwg/dom/issues/582/labels{/name}","comments_url":"https://api.github.com/repos/whatwg/dom/issues/582/comments","events_url":"https://api.github.com/repos/whatwg/dom/issues/582/events","html_url":"https://github.com/whatwg/dom/pull/582","id":302093146,"number":582,"title":"Change DOMTokenList's replace() to return boolean","user":{"login":"Zirro","id":3169418,"avatar_url":"https://avatars2.githubusercontent.com/u/3169418?v=4","gravatar_id":"","url":"https://api.github.com/users/Zirro","html_url":"https://github.com/Zirro","followers_url":"https://api.github.com/users/Zirro/followers","following_url":"https://api.github.com/users/Zirro/following{/other_user}","gists_url":"https://api.github.com/users/Zirro/gists{/gist_id}","starred_url":"https://api.github.com/users/Zirro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zirro/subscriptions","organizations_url":"https://api.github.com/users/Zirro/orgs","repos_url":"https://api.github.com/users/Zirro/repos","events_url":"https://api.github.com/users/Zirro/events{/privacy}","received_events_url":"https://api.github.com/users/Zirro/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-03-04T15:11:07Z","updated_at":"2018-03-12T15:00:54Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/whatwg/dom/pulls/582","html_url":"https://github.com/whatwg/dom/pull/582","diff_url":"https://github.com/whatwg/dom/pull/582.diff","patch_url":"https://github.com/whatwg/dom/pull/582.patch"},"body":"This specifies a return value for DOMTokenList's `replace(token, newToken)` method, making it return true if token was replaced by newToken and false otherwise. This is useful for code which takes different paths depending on whether a replacement occurred, avoiding the need for an extra condition using `contains()`.\n\nI have modified the [Element-classlist.html](https://github.com/w3c/web-platform-tests/blob/master/dom/nodes/Element-classlist.html) test to include [testing](https://gist.github.com/Zirro/b0fb873ccb86eb3bb6596833558abca4#file-element-classlist-html-L406) of this change, and will submit a pull request to the WPT repository if it is approved here.\n\nFixes #577.\n\n\n<!--\n    This comment and the below content is programatically generated.\n    You may add a comma-separated list of anchors you'd like a\n    direct link to below (e.g. #idl-serializers, #idl-sequence):\n\n    Don't remove this comment or modify anything below this line.\n    If you don't want a preview generated for this pull request,\n    just replace the whole of this comment's content by \"no preview\"\n    and remove what's below.\n-->\n***\n<a href=\"https://whatpr.org/dom/582.html\" title=\"Last updated on Mar 7, 2018, 6:10 PM GMT (fd0157c)\">Preview</a> | <a href=\"https://whatpr.org/dom/582/c05ca60...fd0157c.html\" title=\"Last updated on Mar 7, 2018, 6:10 PM GMT (fd0157c)\">Diff</a>"},"comment":{"url":"https://api.github.com/repos/whatwg/dom/issues/comments/372340376","html_url":"https://github.com/whatwg/dom/pull/582#issuecomment-372340376","issue_url":"https://api.github.com/repos/whatwg/dom/issues/582","id":372340376,"user":{"login":"Zirro","id":3169418,"avatar_url":"https://avatars2.githubusercontent.com/u/3169418?v=4","gravatar_id":"","url":"https://api.github.com/users/Zirro","html_url":"https://github.com/Zirro","followers_url":"https://api.github.com/users/Zirro/followers","following_url":"https://api.github.com/users/Zirro/following{/other_user}","gists_url":"https://api.github.com/users/Zirro/gists{/gist_id}","starred_url":"https://api.github.com/users/Zirro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zirro/subscriptions","organizations_url":"https://api.github.com/users/Zirro/orgs","repos_url":"https://api.github.com/users/Zirro/repos","events_url":"https://api.github.com/users/Zirro/events{/privacy}","received_events_url":"https://api.github.com/users/Zirro/received_events","type":"User","site_admin":false},"created_at":"2018-03-12T15:00:54Z","updated_at":"2018-03-12T15:00:54Z","author_association":"NONE","body":"@annevk 👍 Done:\r\n- https://bugzilla.mozilla.org/show_bug.cgi?id=1444909\r\n- https://bugs.webkit.org/show_bug.cgi?id=183567\r\n- https://bugs.chromium.org/p/chromium/issues/detail?id=820988\r\n- https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/16344078"}}
{"actor":{"display_login":"Zirro"}}