{"action":"created","issue":{"url":"https://api.github.com/repos/linagora/james-project/issues/1981","repository_url":"https://api.github.com/repos/linagora/james-project","labels_url":"https://api.github.com/repos/linagora/james-project/issues/1981/labels{/name}","comments_url":"https://api.github.com/repos/linagora/james-project/issues/1981/comments","events_url":"https://api.github.com/repos/linagora/james-project/issues/1981/events","html_url":"https://github.com/linagora/james-project/pull/1981","id":386242656,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MDMxMDMw","number":1981,"title":"James 2617 ElasticSearch 6 metrics","user":{"login":"rouazana","id":1398581,"node_id":"MDQ6VXNlcjEzOTg1ODE=","avatar_url":"https://avatars0.githubusercontent.com/u/1398581?v=4","gravatar_id":"","url":"https://api.github.com/users/rouazana","html_url":"https://github.com/rouazana","followers_url":"https://api.github.com/users/rouazana/followers","following_url":"https://api.github.com/users/rouazana/following{/other_user}","gists_url":"https://api.github.com/users/rouazana/gists{/gist_id}","starred_url":"https://api.github.com/users/rouazana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rouazana/subscriptions","organizations_url":"https://api.github.com/users/rouazana/orgs","repos_url":"https://api.github.com/users/rouazana/repos","events_url":"https://api.github.com/users/rouazana/events{/privacy}","received_events_url":"https://api.github.com/users/rouazana/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-30T15:50:15Z","updated_at":"2018-12-03T16:40:08Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/linagora/james-project/pulls/1981","html_url":"https://github.com/linagora/james-project/pull/1981","diff_url":"https://github.com/linagora/james-project/pull/1981.diff","patch_url":"https://github.com/linagora/james-project/pull/1981.patch"},"body":"Here is a PR to make James metrics compatible with Elastic Search 6.\r\n\r\nI was able to manually test that it's working fine with ES 6 and ES 2.\r\n\r\nFor the moment I was not able to update the integration tests because they rely on ES 2 protocol, I need to find a way to make them compatible with ES 6 and ES 2 at the same time."},"comment":{"url":"https://api.github.com/repos/linagora/james-project/issues/comments/443777494","html_url":"https://github.com/linagora/james-project/pull/1981#issuecomment-443777494","issue_url":"https://api.github.com/repos/linagora/james-project/issues/1981","id":443777494,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Mzc3NzQ5NA==","user":{"login":"rouazana","id":1398581,"node_id":"MDQ6VXNlcjEzOTg1ODE=","avatar_url":"https://avatars0.githubusercontent.com/u/1398581?v=4","gravatar_id":"","url":"https://api.github.com/users/rouazana","html_url":"https://github.com/rouazana","followers_url":"https://api.github.com/users/rouazana/followers","following_url":"https://api.github.com/users/rouazana/following{/other_user}","gists_url":"https://api.github.com/users/rouazana/gists{/gist_id}","starred_url":"https://api.github.com/users/rouazana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rouazana/subscriptions","organizations_url":"https://api.github.com/users/rouazana/orgs","repos_url":"https://api.github.com/users/rouazana/repos","events_url":"https://api.github.com/users/rouazana/events{/privacy}","received_events_url":"https://api.github.com/users/rouazana/received_events","type":"User","site_admin":false},"created_at":"2018-12-03T16:40:08Z","updated_at":"2018-12-03T16:40:08Z","author_association":"MEMBER","body":"Most comments are related to code I just imported. I did that because I just considered that as an external lib. And we don't review all the code of all the external libs we are using (shoud we? ^^).\r\nThis library is imported just for the purpose of dependency management. Being not maintained anymore, we need to get it in our source code to be able to use it. Alternatives are:\r\n1. just compile the jar and put it with James\r\n2. just import this library and don't care (what I did)\r\n3. fork the original repo and add some features to it (ES 6 support, update of libraries, etc.)\r\n\r\nI'm really uncomfortable making a local fork (I mean just inside the main James repository) and fix things inside it. We loose all the commit history, and (back/front)porting things will be a nightmare.\r\n\r\nIf you think we need to maintain a real version of this lib, and put it under org.james namespace to be able to release it, maybe we need to really fork the project? Then I'm ok considering your remarks."}}
{"actor":{"display_login":"rouazana"}}