{"action":"created","comment":{"url":"https://api.github.com/repos/resin-io/etcher/pulls/comments/170273124","pull_request_review_id":98938704,"id":170273124,"diff_hunk":"@@ -225,6 +225,18 @@ describe('Model: selectionState', function () {\n         m.chai.expect(selectionState.getSelectedDevices()).to.deep.equal([])\n       })\n     })\n+\n+    describe('.deselectOtherDrives()', function () {\n+      it('should deselect other drives', function () {\n+        selectionState.deselectOtherDrives('/dev/disk1')\n+        m.chai.expect(selectionState.getSelectedDevices()).to.not.include.members([ '/dev/disk2' ])\n+      })\n+\n+      it('should not remove the specified drive', function () {\n+        selectionState.deselectOtherDrives('/dev/sdb')\n+        m.chai.expect(selectionState.getSelectedDevices()).to.deep.equal([ this.drives[0].device ])","path":"tests/shared/models/selection-state.spec.js","position":153,"original_position":13,"commit_id":"98cae271af595d8c9db513bd1ec8a71b8fec2135","original_commit_id":"fe6323da950c9f21a24672397614e98e546e62fb","user":{"login":"lurch","id":476186,"avatar_url":"https://avatars2.githubusercontent.com/u/476186?v=4","gravatar_id":"","url":"https://api.github.com/users/lurch","html_url":"https://github.com/lurch","followers_url":"https://api.github.com/users/lurch/followers","following_url":"https://api.github.com/users/lurch/following{/other_user}","gists_url":"https://api.github.com/users/lurch/gists{/gist_id}","starred_url":"https://api.github.com/users/lurch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lurch/subscriptions","organizations_url":"https://api.github.com/users/lurch/orgs","repos_url":"https://api.github.com/users/lurch/repos","events_url":"https://api.github.com/users/lurch/events{/privacy}","received_events_url":"https://api.github.com/users/lurch/received_events","type":"User","site_admin":false},"body":"You've already got `/dev/sdb` on the line above, so it might be more logical for this line to say:\r\n```\r\nm.chai.expect(selectionState.getSelectedDevices()).to.deep.equal([ '/dev/sdb' ])\r\n```\r\n?","created_at":"2018-02-23T14:59:46Z","updated_at":"2018-02-23T14:59:46Z","html_url":"https://github.com/resin-io/etcher/pull/1736#discussion_r170273124","pull_request_url":"https://api.github.com/repos/resin-io/etcher/pulls/1736","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/resin-io/etcher/pulls/comments/170273124"},"html":{"href":"https://github.com/resin-io/etcher/pull/1736#discussion_r170273124"},"pull_request":{"href":"https://api.github.com/repos/resin-io/etcher/pulls/1736"}}},"pull_request":{"url":"https://api.github.com/repos/resin-io/etcher/pulls/1736","id":142083268,"html_url":"https://github.com/resin-io/etcher/pull/1736","diff_url":"https://github.com/resin-io/etcher/pull/1736.diff","patch_url":"https://github.com/resin-io/etcher/pull/1736.patch","issue_url":"https://api.github.com/repos/resin-io/etcher/issues/1736","number":1736,"state":"open","locked":false,"title":"feat: add drive multi-selection in store","user":{"login":"Shou","id":819413,"avatar_url":"https://avatars1.githubusercontent.com/u/819413?v=4","gravatar_id":"","url":"https://api.github.com/users/Shou","html_url":"https://github.com/Shou","followers_url":"https://api.github.com/users/Shou/followers","following_url":"https://api.github.com/users/Shou/following{/other_user}","gists_url":"https://api.github.com/users/Shou/gists{/gist_id}","starred_url":"https://api.github.com/users/Shou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shou/subscriptions","organizations_url":"https://api.github.com/users/Shou/orgs","repos_url":"https://api.github.com/users/Shou/repos","events_url":"https://api.github.com/users/Shou/events{/privacy}","received_events_url":"https://api.github.com/users/Shou/received_events","type":"User","site_admin":false},"body":"We lay the foundation for multi-selecting drives by implementing it into\r\nthe `store` and relevant modules interacting with the `store`.\r\n\r\nChangelog-Entry: Add drive multi-selection to the store.","created_at":"2017-09-20T12:14:32Z","updated_at":"2018-02-23T14:59:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"682ac8e9f31fde2a1daa3b27d597d0561a637867","assignee":{"login":"Shou","id":819413,"avatar_url":"https://avatars1.githubusercontent.com/u/819413?v=4","gravatar_id":"","url":"https://api.github.com/users/Shou","html_url":"https://github.com/Shou","followers_url":"https://api.github.com/users/Shou/followers","following_url":"https://api.github.com/users/Shou/following{/other_user}","gists_url":"https://api.github.com/users/Shou/gists{/gist_id}","starred_url":"https://api.github.com/users/Shou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shou/subscriptions","organizations_url":"https://api.github.com/users/Shou/orgs","repos_url":"https://api.github.com/users/Shou/repos","events_url":"https://api.github.com/users/Shou/events{/privacy}","received_events_url":"https://api.github.com/users/Shou/received_events","type":"User","site_admin":false},"assignees":[{"login":"Shou","id":819413,"avatar_url":"https://avatars1.githubusercontent.com/u/819413?v=4","gravatar_id":"","url":"https://api.github.com/users/Shou","html_url":"https://github.com/Shou","followers_url":"https://api.github.com/users/Shou/followers","following_url":"https://api.github.com/users/Shou/following{/other_user}","gists_url":"https://api.github.com/users/Shou/gists{/gist_id}","starred_url":"https://api.github.com/users/Shou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shou/subscriptions","organizations_url":"https://api.github.com/users/Shou/orgs","repos_url":"https://api.github.com/users/Shou/repos","events_url":"https://api.github.com/users/Shou/events{/privacy}","received_events_url":"https://api.github.com/users/Shou/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":310247012,"url":"https://api.github.com/repos/resin-io/etcher/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/resin-io/etcher/pulls/1736/commits","review_comments_url":"https://api.github.com/repos/resin-io/etcher/pulls/1736/comments","review_comment_url":"https://api.github.com/repos/resin-io/etcher/pulls/comments{/number}","comments_url":"https://api.github.com/repos/resin-io/etcher/issues/1736/comments","statuses_url":"https://api.github.com/repos/resin-io/etcher/statuses/98cae271af595d8c9db513bd1ec8a71b8fec2135","head":{"label":"resin-io:multi-select-drives","ref":"multi-select-drives","sha":"98cae271af595d8c9db513bd1ec8a71b8fec2135","user":{"login":"resin-io","id":6157842,"avatar_url":"https://avatars1.githubusercontent.com/u/6157842?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io","html_url":"https://github.com/resin-io","followers_url":"https://api.github.com/users/resin-io/followers","following_url":"https://api.github.com/users/resin-io/following{/other_user}","gists_url":"https://api.github.com/users/resin-io/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io/subscriptions","organizations_url":"https://api.github.com/users/resin-io/orgs","repos_url":"https://api.github.com/users/resin-io/repos","events_url":"https://api.github.com/users/resin-io/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io/received_events","type":"Organization","site_admin":false},"repo":{"id":45055693,"name":"etcher","full_name":"resin-io/etcher","owner":{"login":"resin-io","id":6157842,"avatar_url":"https://avatars1.githubusercontent.com/u/6157842?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io","html_url":"https://github.com/resin-io","followers_url":"https://api.github.com/users/resin-io/followers","following_url":"https://api.github.com/users/resin-io/following{/other_user}","gists_url":"https://api.github.com/users/resin-io/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io/subscriptions","organizations_url":"https://api.github.com/users/resin-io/orgs","repos_url":"https://api.github.com/users/resin-io/repos","events_url":"https://api.github.com/users/resin-io/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/resin-io/etcher","description":"Flash OS images to SD cards & USB drives, safely and easily.","fork":false,"url":"https://api.github.com/repos/resin-io/etcher","forks_url":"https://api.github.com/repos/resin-io/etcher/forks","keys_url":"https://api.github.com/repos/resin-io/etcher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/resin-io/etcher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/resin-io/etcher/teams","hooks_url":"https://api.github.com/repos/resin-io/etcher/hooks","issue_events_url":"https://api.github.com/repos/resin-io/etcher/issues/events{/number}","events_url":"https://api.github.com/repos/resin-io/etcher/events","assignees_url":"https://api.github.com/repos/resin-io/etcher/assignees{/user}","branches_url":"https://api.github.com/repos/resin-io/etcher/branches{/branch}","tags_url":"https://api.github.com/repos/resin-io/etcher/tags","blobs_url":"https://api.github.com/repos/resin-io/etcher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/resin-io/etcher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/resin-io/etcher/git/refs{/sha}","trees_url":"https://api.github.com/repos/resin-io/etcher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/resin-io/etcher/statuses/{sha}","languages_url":"https://api.github.com/repos/resin-io/etcher/languages","stargazers_url":"https://api.github.com/repos/resin-io/etcher/stargazers","contributors_url":"https://api.github.com/repos/resin-io/etcher/contributors","subscribers_url":"https://api.github.com/repos/resin-io/etcher/subscribers","subscription_url":"https://api.github.com/repos/resin-io/etcher/subscription","commits_url":"https://api.github.com/repos/resin-io/etcher/commits{/sha}","git_commits_url":"https://api.github.com/repos/resin-io/etcher/git/commits{/sha}","comments_url":"https://api.github.com/repos/resin-io/etcher/comments{/number}","issue_comment_url":"https://api.github.com/repos/resin-io/etcher/issues/comments{/number}","contents_url":"https://api.github.com/repos/resin-io/etcher/contents/{+path}","compare_url":"https://api.github.com/repos/resin-io/etcher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/resin-io/etcher/merges","archive_url":"https://api.github.com/repos/resin-io/etcher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/resin-io/etcher/downloads","issues_url":"https://api.github.com/repos/resin-io/etcher/issues{/number}","pulls_url":"https://api.github.com/repos/resin-io/etcher/pulls{/number}","milestones_url":"https://api.github.com/repos/resin-io/etcher/milestones{/number}","notifications_url":"https://api.github.com/repos/resin-io/etcher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/resin-io/etcher/labels{/name}","releases_url":"https://api.github.com/repos/resin-io/etcher/releases{/id}","deployments_url":"https://api.github.com/repos/resin-io/etcher/deployments","created_at":"2015-10-27T16:53:23Z","updated_at":"2018-02-23T14:19:19Z","pushed_at":"2018-02-23T14:58:34Z","git_url":"git://github.com/resin-io/etcher.git","ssh_url":"git@github.com:resin-io/etcher.git","clone_url":"https://github.com/resin-io/etcher.git","svn_url":"https://github.com/resin-io/etcher","homepage":"https://etcher.io","size":87397,"stargazers_count":9741,"watchers_count":9741,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":460,"mirror_url":null,"archived":false,"open_issues_count":203,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":460,"open_issues":203,"watchers":9741,"default_branch":"master"}},"base":{"label":"resin-io:master","ref":"master","sha":"2c0cdcf9472205e09ed960b213d34ac78097e123","user":{"login":"resin-io","id":6157842,"avatar_url":"https://avatars1.githubusercontent.com/u/6157842?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io","html_url":"https://github.com/resin-io","followers_url":"https://api.github.com/users/resin-io/followers","following_url":"https://api.github.com/users/resin-io/following{/other_user}","gists_url":"https://api.github.com/users/resin-io/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io/subscriptions","organizations_url":"https://api.github.com/users/resin-io/orgs","repos_url":"https://api.github.com/users/resin-io/repos","events_url":"https://api.github.com/users/resin-io/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io/received_events","type":"Organization","site_admin":false},"repo":{"id":45055693,"name":"etcher","full_name":"resin-io/etcher","owner":{"login":"resin-io","id":6157842,"avatar_url":"https://avatars1.githubusercontent.com/u/6157842?v=4","gravatar_id":"","url":"https://api.github.com/users/resin-io","html_url":"https://github.com/resin-io","followers_url":"https://api.github.com/users/resin-io/followers","following_url":"https://api.github.com/users/resin-io/following{/other_user}","gists_url":"https://api.github.com/users/resin-io/gists{/gist_id}","starred_url":"https://api.github.com/users/resin-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resin-io/subscriptions","organizations_url":"https://api.github.com/users/resin-io/orgs","repos_url":"https://api.github.com/users/resin-io/repos","events_url":"https://api.github.com/users/resin-io/events{/privacy}","received_events_url":"https://api.github.com/users/resin-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/resin-io/etcher","description":"Flash OS images to SD cards & USB drives, safely and easily.","fork":false,"url":"https://api.github.com/repos/resin-io/etcher","forks_url":"https://api.github.com/repos/resin-io/etcher/forks","keys_url":"https://api.github.com/repos/resin-io/etcher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/resin-io/etcher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/resin-io/etcher/teams","hooks_url":"https://api.github.com/repos/resin-io/etcher/hooks","issue_events_url":"https://api.github.com/repos/resin-io/etcher/issues/events{/number}","events_url":"https://api.github.com/repos/resin-io/etcher/events","assignees_url":"https://api.github.com/repos/resin-io/etcher/assignees{/user}","branches_url":"https://api.github.com/repos/resin-io/etcher/branches{/branch}","tags_url":"https://api.github.com/repos/resin-io/etcher/tags","blobs_url":"https://api.github.com/repos/resin-io/etcher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/resin-io/etcher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/resin-io/etcher/git/refs{/sha}","trees_url":"https://api.github.com/repos/resin-io/etcher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/resin-io/etcher/statuses/{sha}","languages_url":"https://api.github.com/repos/resin-io/etcher/languages","stargazers_url":"https://api.github.com/repos/resin-io/etcher/stargazers","contributors_url":"https://api.github.com/repos/resin-io/etcher/contributors","subscribers_url":"https://api.github.com/repos/resin-io/etcher/subscribers","subscription_url":"https://api.github.com/repos/resin-io/etcher/subscription","commits_url":"https://api.github.com/repos/resin-io/etcher/commits{/sha}","git_commits_url":"https://api.github.com/repos/resin-io/etcher/git/commits{/sha}","comments_url":"https://api.github.com/repos/resin-io/etcher/comments{/number}","issue_comment_url":"https://api.github.com/repos/resin-io/etcher/issues/comments{/number}","contents_url":"https://api.github.com/repos/resin-io/etcher/contents/{+path}","compare_url":"https://api.github.com/repos/resin-io/etcher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/resin-io/etcher/merges","archive_url":"https://api.github.com/repos/resin-io/etcher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/resin-io/etcher/downloads","issues_url":"https://api.github.com/repos/resin-io/etcher/issues{/number}","pulls_url":"https://api.github.com/repos/resin-io/etcher/pulls{/number}","milestones_url":"https://api.github.com/repos/resin-io/etcher/milestones{/number}","notifications_url":"https://api.github.com/repos/resin-io/etcher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/resin-io/etcher/labels{/name}","releases_url":"https://api.github.com/repos/resin-io/etcher/releases{/id}","deployments_url":"https://api.github.com/repos/resin-io/etcher/deployments","created_at":"2015-10-27T16:53:23Z","updated_at":"2018-02-23T14:19:19Z","pushed_at":"2018-02-23T14:58:34Z","git_url":"git://github.com/resin-io/etcher.git","ssh_url":"git@github.com:resin-io/etcher.git","clone_url":"https://github.com/resin-io/etcher.git","svn_url":"https://github.com/resin-io/etcher","homepage":"https://etcher.io","size":87397,"stargazers_count":9741,"watchers_count":9741,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":460,"mirror_url":null,"archived":false,"open_issues_count":203,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":460,"open_issues":203,"watchers":9741,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/resin-io/etcher/pulls/1736"},"html":{"href":"https://github.com/resin-io/etcher/pull/1736"},"issue":{"href":"https://api.github.com/repos/resin-io/etcher/issues/1736"},"comments":{"href":"https://api.github.com/repos/resin-io/etcher/issues/1736/comments"},"review_comments":{"href":"https://api.github.com/repos/resin-io/etcher/pulls/1736/comments"},"review_comment":{"href":"https://api.github.com/repos/resin-io/etcher/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/resin-io/etcher/pulls/1736/commits"},"statuses":{"href":"https://api.github.com/repos/resin-io/etcher/statuses/98cae271af595d8c9db513bd1ec8a71b8fec2135"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"lurch"}}