{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/196514247","pull_request_review_id":130081789,"id":196514247,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjUxNDI0Nw==","diff_hunk":"@@ -0,0 +1,20 @@\n+<!doctype html>","path":"validator/testdata/feature_tests/amp-yotpo.html","position":16,"original_position":1,"commit_id":"62e7febdc2d362d97645eea330d82b43f8cdc49e","original_commit_id":"a7a4ff1d54b45d15b69bf9c2ac035be7942e01f4","user":{"login":"aghassemi","id":2099009,"node_id":"MDQ6VXNlcjIwOTkwMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/2099009?v=4","gravatar_id":"","url":"https://api.github.com/users/aghassemi","html_url":"https://github.com/aghassemi","followers_url":"https://api.github.com/users/aghassemi/followers","following_url":"https://api.github.com/users/aghassemi/following{/other_user}","gists_url":"https://api.github.com/users/aghassemi/gists{/gist_id}","starred_url":"https://api.github.com/users/aghassemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aghassemi/subscriptions","organizations_url":"https://api.github.com/users/aghassemi/orgs","repos_url":"https://api.github.com/users/aghassemi/repos","events_url":"https://api.github.com/users/aghassemi/events{/privacy}","received_events_url":"https://api.github.com/users/aghassemi/received_events","type":"User","site_admin":false},"body":"added","created_at":"2018-06-19T17:31:47Z","updated_at":"2018-06-19T17:31:48Z","html_url":"https://github.com/ampproject/amphtml/pull/14521#discussion_r196514247","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/14521","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/196514247"},"html":{"href":"https://github.com/ampproject/amphtml/pull/14521#discussion_r196514247"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/14521"}},"in_reply_to_id":196499691},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/14521","id":180660851,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgwNjYwODUx","html_url":"https://github.com/ampproject/amphtml/pull/14521","diff_url":"https://github.com/ampproject/amphtml/pull/14521.diff","patch_url":"https://github.com/ampproject/amphtml/pull/14521.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/14521","number":14521,"state":"open","locked":false,"title":"✨ Add Yotpo widgets extension","user":{"login":"RanAbram","id":24430957,"node_id":"MDQ6VXNlcjI0NDMwOTU3","avatar_url":"https://avatars2.githubusercontent.com/u/24430957?v=4","gravatar_id":"","url":"https://api.github.com/users/RanAbram","html_url":"https://github.com/RanAbram","followers_url":"https://api.github.com/users/RanAbram/followers","following_url":"https://api.github.com/users/RanAbram/following{/other_user}","gists_url":"https://api.github.com/users/RanAbram/gists{/gist_id}","starred_url":"https://api.github.com/users/RanAbram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RanAbram/subscriptions","organizations_url":"https://api.github.com/users/RanAbram/orgs","repos_url":"https://api.github.com/users/RanAbram/repos","events_url":"https://api.github.com/users/RanAbram/events{/privacy}","received_events_url":"https://api.github.com/users/RanAbram/received_events","type":"User","site_admin":false},"body":"Hey,\r\n\r\nThis is the first draft for our Yotpo widgets amp implementation.\r\nAs we described in the intent-to-implement issue, we wanted to build thin iframe layer to\r\nwrapped our widgets.\r\n\r\nIn this draft we wrapped only few of our widgets in order to show you the direction we are heading to.\r\nBut before we are continue to implement the other widgets, we want to hear your though about it and to know if we are in the right way. So let us know if you got any suggestions or comments.\r\n\r\nWe also got few questions regarding this extension:\r\n1. Is there a way to get the original site url?\r\nWhen using `window.location.href` we receive the iframe url.\r\n2. What is the use of the `preconnect.preload` and `preconnect.url` methods? \r\nCause we manage to wrapped our widgets without it. Should we use them?\r\n3. How could we see that our extension works well before we are release it to our customers?\r\nWe used AMP local environment with `gulp` to test it. But we would like to test it in production as well\r\nbefore our customers start to use it.\r\n4. We saw that some of the integration test were failed. We couldn't understand the reason for it.\r\nCould you please explain us what we could do in order to fix them?\r\n\r\n\r\nRelated-to #13105 \r\n\r\nThanks!","created_at":"2018-04-10T16:33:33Z","updated_at":"2018-06-19T17:31:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddf3ff81dfbece3b8a53bed2c17e529f375ce0c3","assignee":{"login":"aghassemi","id":2099009,"node_id":"MDQ6VXNlcjIwOTkwMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/2099009?v=4","gravatar_id":"","url":"https://api.github.com/users/aghassemi","html_url":"https://github.com/aghassemi","followers_url":"https://api.github.com/users/aghassemi/followers","following_url":"https://api.github.com/users/aghassemi/following{/other_user}","gists_url":"https://api.github.com/users/aghassemi/gists{/gist_id}","starred_url":"https://api.github.com/users/aghassemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aghassemi/subscriptions","organizations_url":"https://api.github.com/users/aghassemi/orgs","repos_url":"https://api.github.com/users/aghassemi/repos","events_url":"https://api.github.com/users/aghassemi/events{/privacy}","received_events_url":"https://api.github.com/users/aghassemi/received_events","type":"User","site_admin":false},"assignees":[{"login":"aghassemi","id":2099009,"node_id":"MDQ6VXNlcjIwOTkwMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/2099009?v=4","gravatar_id":"","url":"https://api.github.com/users/aghassemi","html_url":"https://github.com/aghassemi","followers_url":"https://api.github.com/users/aghassemi/followers","following_url":"https://api.github.com/users/aghassemi/following{/other_user}","gists_url":"https://api.github.com/users/aghassemi/gists{/gist_id}","starred_url":"https://api.github.com/users/aghassemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aghassemi/subscriptions","organizations_url":"https://api.github.com/users/aghassemi/orgs","repos_url":"https://api.github.com/users/aghassemi/repos","events_url":"https://api.github.com/users/aghassemi/events{/privacy}","received_events_url":"https://api.github.com/users/aghassemi/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":596633554,"node_id":"MDU6TGFiZWw1OTY2MzM1NTQ=","url":"https://api.github.com/repos/ampproject/amphtml/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/14521/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/14521/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/14521/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/62e7febdc2d362d97645eea330d82b43f8cdc49e","head":{"label":"RanAbram:implement-amp-yotpo","ref":"implement-amp-yotpo","sha":"62e7febdc2d362d97645eea330d82b43f8cdc49e","user":{"login":"RanAbram","id":24430957,"node_id":"MDQ6VXNlcjI0NDMwOTU3","avatar_url":"https://avatars2.githubusercontent.com/u/24430957?v=4","gravatar_id":"","url":"https://api.github.com/users/RanAbram","html_url":"https://github.com/RanAbram","followers_url":"https://api.github.com/users/RanAbram/followers","following_url":"https://api.github.com/users/RanAbram/following{/other_user}","gists_url":"https://api.github.com/users/RanAbram/gists{/gist_id}","starred_url":"https://api.github.com/users/RanAbram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RanAbram/subscriptions","organizations_url":"https://api.github.com/users/RanAbram/orgs","repos_url":"https://api.github.com/users/RanAbram/repos","events_url":"https://api.github.com/users/RanAbram/events{/privacy}","received_events_url":"https://api.github.com/users/RanAbram/received_events","type":"User","site_admin":false},"repo":{"id":116514892,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY1MTQ4OTI=","name":"amphtml","full_name":"RanAbram/amphtml","owner":{"login":"RanAbram","id":24430957,"node_id":"MDQ6VXNlcjI0NDMwOTU3","avatar_url":"https://avatars2.githubusercontent.com/u/24430957?v=4","gravatar_id":"","url":"https://api.github.com/users/RanAbram","html_url":"https://github.com/RanAbram","followers_url":"https://api.github.com/users/RanAbram/followers","following_url":"https://api.github.com/users/RanAbram/following{/other_user}","gists_url":"https://api.github.com/users/RanAbram/gists{/gist_id}","starred_url":"https://api.github.com/users/RanAbram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RanAbram/subscriptions","organizations_url":"https://api.github.com/users/RanAbram/orgs","repos_url":"https://api.github.com/users/RanAbram/repos","events_url":"https://api.github.com/users/RanAbram/events{/privacy}","received_events_url":"https://api.github.com/users/RanAbram/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RanAbram/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/RanAbram/amphtml","forks_url":"https://api.github.com/repos/RanAbram/amphtml/forks","keys_url":"https://api.github.com/repos/RanAbram/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RanAbram/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RanAbram/amphtml/teams","hooks_url":"https://api.github.com/repos/RanAbram/amphtml/hooks","issue_events_url":"https://api.github.com/repos/RanAbram/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/RanAbram/amphtml/events","assignees_url":"https://api.github.com/repos/RanAbram/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/RanAbram/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/RanAbram/amphtml/tags","blobs_url":"https://api.github.com/repos/RanAbram/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RanAbram/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RanAbram/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/RanAbram/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RanAbram/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/RanAbram/amphtml/languages","stargazers_url":"https://api.github.com/repos/RanAbram/amphtml/stargazers","contributors_url":"https://api.github.com/repos/RanAbram/amphtml/contributors","subscribers_url":"https://api.github.com/repos/RanAbram/amphtml/subscribers","subscription_url":"https://api.github.com/repos/RanAbram/amphtml/subscription","commits_url":"https://api.github.com/repos/RanAbram/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/RanAbram/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/RanAbram/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/RanAbram/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/RanAbram/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/RanAbram/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RanAbram/amphtml/merges","archive_url":"https://api.github.com/repos/RanAbram/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RanAbram/amphtml/downloads","issues_url":"https://api.github.com/repos/RanAbram/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/RanAbram/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/RanAbram/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/RanAbram/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RanAbram/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/RanAbram/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/RanAbram/amphtml/deployments","created_at":"2018-01-06T20:54:36Z","updated_at":"2018-05-28T14:40:03Z","pushed_at":"2018-06-19T17:31:28Z","git_url":"git://github.com/RanAbram/amphtml.git","ssh_url":"git@github.com:RanAbram/amphtml.git","clone_url":"https://github.com/RanAbram/amphtml.git","svn_url":"https://github.com/RanAbram/amphtml","homepage":"https://www.ampproject.org","size":446029,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"85ebf5448a3fb5e66d124484997014ab4d6bb45a","user":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"node_id":"MDEwOlJlcG9zaXRvcnk0MTc2NjAwMg==","name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2018-06-19T16:49:06Z","pushed_at":"2018-06-19T17:31:29Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":460359,"stargazers_count":11695,"watchers_count":11695,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2453,"mirror_url":null,"archived":false,"open_issues_count":1312,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2453,"open_issues":1312,"watchers":11695,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/14521"},"html":{"href":"https://github.com/ampproject/amphtml/pull/14521"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/14521"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/14521/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/14521/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/14521/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/62e7febdc2d362d97645eea330d82b43f8cdc49e"}},"author_association":"NONE"}}
{"actor":{"display_login":"aghassemi"}}