{"action":"created","comment":{"url":"https://api.github.com/repos/witnet/witnet-rust/pulls/comments/222603690","pull_request_review_id":161513650,"id":222603690,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjYwMzY5MA==","diff_hunk":"@@ -1,25 +1,23 @@\n //! Module containing a Storage generic trait that can be implemented for different specific storage\n //! backends.\n \n-use crate::error::Result;\n+use crate::error::StorageResult;\n \n /// This is a generic trait that exposes a very simple key/value CRUD API for data storage.\n /// This trait can be easily implemented for any specific storage backend solution (databases,\n /// volatile memory, flat files, etc.)\n-pub trait Storage<ConnData, Key, Value> {\n-\n+pub trait Storage<Key, Value> {\n     /// Storage object constructor.\n     /// `connection_data` can be used for passing credentials, urls, paths, etc. down to the storage\n     /// backend.\n-    fn new(connection_data: ConnData) -> Result<Box<Self>>;\n+    fn new(connection_data: String) -> StorageResult<Box<Self>>;","path":"storage/src/storage.rs","position":17,"original_position":17,"commit_id":"bf011a2b76bc324a5505e28aca458f05e0260294","original_commit_id":"3f2ad060ef0fd909a50e7ca105b3f7758469af8a","user":{"login":"aesedepece","id":1316439,"node_id":"MDQ6VXNlcjEzMTY0Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1316439?v=4","gravatar_id":"","url":"https://api.github.com/users/aesedepece","html_url":"https://github.com/aesedepece","followers_url":"https://api.github.com/users/aesedepece/followers","following_url":"https://api.github.com/users/aesedepece/following{/other_user}","gists_url":"https://api.github.com/users/aesedepece/gists{/gist_id}","starred_url":"https://api.github.com/users/aesedepece/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aesedepece/subscriptions","organizations_url":"https://api.github.com/users/aesedepece/orgs","repos_url":"https://api.github.com/users/aesedepece/repos","events_url":"https://api.github.com/users/aesedepece/events{/privacy}","received_events_url":"https://api.github.com/users/aesedepece/received_events","type":"User","site_admin":false},"body":"As said before, we want `Storage` to be generic over different storage backends that may require different connection data types. Forcing a `String` here is doing the opposite.","created_at":"2018-10-04T09:46:05Z","updated_at":"2018-10-04T09:46:23Z","html_url":"https://github.com/witnet/witnet-rust/pull/27#discussion_r222603690","pull_request_url":"https://api.github.com/repos/witnet/witnet-rust/pulls/27","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/witnet/witnet-rust/pulls/comments/222603690"},"html":{"href":"https://github.com/witnet/witnet-rust/pull/27#discussion_r222603690"},"pull_request":{"href":"https://api.github.com/repos/witnet/witnet-rust/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/witnet/witnet-rust/pulls/27","id":220109831,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMTA5ODMx","html_url":"https://github.com/witnet/witnet-rust/pull/27","diff_url":"https://github.com/witnet/witnet-rust/pull/27.diff","patch_url":"https://github.com/witnet/witnet-rust/pull/27.patch","issue_url":"https://api.github.com/repos/witnet/witnet-rust/issues/27","number":27,"state":"open","locked":false,"title":"[WIP]refactor(err): introduce failure ","user":{"login":"csmoe","id":35686186,"node_id":"MDQ6VXNlcjM1Njg2MTg2","avatar_url":"https://avatars3.githubusercontent.com/u/35686186?v=4","gravatar_id":"","url":"https://api.github.com/users/csmoe","html_url":"https://github.com/csmoe","followers_url":"https://api.github.com/users/csmoe/followers","following_url":"https://api.github.com/users/csmoe/following{/other_user}","gists_url":"https://api.github.com/users/csmoe/gists{/gist_id}","starred_url":"https://api.github.com/users/csmoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csmoe/subscriptions","organizations_url":"https://api.github.com/users/csmoe/orgs","repos_url":"https://api.github.com/users/csmoe/repos","events_url":"https://api.github.com/users/csmoe/events{/privacy}","received_events_url":"https://api.github.com/users/csmoe/received_events","type":"User","site_admin":false},"body":"r? @aesedepece \r\n\r\nedit: wip for some unoptimized snippets.","created_at":"2018-10-03T16:58:17Z","updated_at":"2018-10-04T09:46:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"164c0cc653a94982f4675e22997fb0f12f3daf98","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/witnet/witnet-rust/pulls/27/commits","review_comments_url":"https://api.github.com/repos/witnet/witnet-rust/pulls/27/comments","review_comment_url":"https://api.github.com/repos/witnet/witnet-rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/witnet/witnet-rust/issues/27/comments","statuses_url":"https://api.github.com/repos/witnet/witnet-rust/statuses/bf011a2b76bc324a5505e28aca458f05e0260294","head":{"label":"csmoe:err","ref":"err","sha":"bf011a2b76bc324a5505e28aca458f05e0260294","user":{"login":"csmoe","id":35686186,"node_id":"MDQ6VXNlcjM1Njg2MTg2","avatar_url":"https://avatars3.githubusercontent.com/u/35686186?v=4","gravatar_id":"","url":"https://api.github.com/users/csmoe","html_url":"https://github.com/csmoe","followers_url":"https://api.github.com/users/csmoe/followers","following_url":"https://api.github.com/users/csmoe/following{/other_user}","gists_url":"https://api.github.com/users/csmoe/gists{/gist_id}","starred_url":"https://api.github.com/users/csmoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csmoe/subscriptions","organizations_url":"https://api.github.com/users/csmoe/orgs","repos_url":"https://api.github.com/users/csmoe/repos","events_url":"https://api.github.com/users/csmoe/events{/privacy}","received_events_url":"https://api.github.com/users/csmoe/received_events","type":"User","site_admin":false},"repo":{"id":130865870,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA4NjU4NzA=","name":"witnet-rust","full_name":"csmoe/witnet-rust","private":false,"owner":{"login":"csmoe","id":35686186,"node_id":"MDQ6VXNlcjM1Njg2MTg2","avatar_url":"https://avatars3.githubusercontent.com/u/35686186?v=4","gravatar_id":"","url":"https://api.github.com/users/csmoe","html_url":"https://github.com/csmoe","followers_url":"https://api.github.com/users/csmoe/followers","following_url":"https://api.github.com/users/csmoe/following{/other_user}","gists_url":"https://api.github.com/users/csmoe/gists{/gist_id}","starred_url":"https://api.github.com/users/csmoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csmoe/subscriptions","organizations_url":"https://api.github.com/users/csmoe/orgs","repos_url":"https://api.github.com/users/csmoe/repos","events_url":"https://api.github.com/users/csmoe/events{/privacy}","received_events_url":"https://api.github.com/users/csmoe/received_events","type":"User","site_admin":false},"html_url":"https://github.com/csmoe/witnet-rust","description":"An in-progress open source implementation of the Witnet protocol written in Rust.","fork":true,"url":"https://api.github.com/repos/csmoe/witnet-rust","forks_url":"https://api.github.com/repos/csmoe/witnet-rust/forks","keys_url":"https://api.github.com/repos/csmoe/witnet-rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/csmoe/witnet-rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/csmoe/witnet-rust/teams","hooks_url":"https://api.github.com/repos/csmoe/witnet-rust/hooks","issue_events_url":"https://api.github.com/repos/csmoe/witnet-rust/issues/events{/number}","events_url":"https://api.github.com/repos/csmoe/witnet-rust/events","assignees_url":"https://api.github.com/repos/csmoe/witnet-rust/assignees{/user}","branches_url":"https://api.github.com/repos/csmoe/witnet-rust/branches{/branch}","tags_url":"https://api.github.com/repos/csmoe/witnet-rust/tags","blobs_url":"https://api.github.com/repos/csmoe/witnet-rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/csmoe/witnet-rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/csmoe/witnet-rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/csmoe/witnet-rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/csmoe/witnet-rust/statuses/{sha}","languages_url":"https://api.github.com/repos/csmoe/witnet-rust/languages","stargazers_url":"https://api.github.com/repos/csmoe/witnet-rust/stargazers","contributors_url":"https://api.github.com/repos/csmoe/witnet-rust/contributors","subscribers_url":"https://api.github.com/repos/csmoe/witnet-rust/subscribers","subscription_url":"https://api.github.com/repos/csmoe/witnet-rust/subscription","commits_url":"https://api.github.com/repos/csmoe/witnet-rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/csmoe/witnet-rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/csmoe/witnet-rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/csmoe/witnet-rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/csmoe/witnet-rust/contents/{+path}","compare_url":"https://api.github.com/repos/csmoe/witnet-rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/csmoe/witnet-rust/merges","archive_url":"https://api.github.com/repos/csmoe/witnet-rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/csmoe/witnet-rust/downloads","issues_url":"https://api.github.com/repos/csmoe/witnet-rust/issues{/number}","pulls_url":"https://api.github.com/repos/csmoe/witnet-rust/pulls{/number}","milestones_url":"https://api.github.com/repos/csmoe/witnet-rust/milestones{/number}","notifications_url":"https://api.github.com/repos/csmoe/witnet-rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/csmoe/witnet-rust/labels{/name}","releases_url":"https://api.github.com/repos/csmoe/witnet-rust/releases{/id}","deployments_url":"https://api.github.com/repos/csmoe/witnet-rust/deployments","created_at":"2018-04-24T14:19:54Z","updated_at":"2018-10-03T11:23:13Z","pushed_at":"2018-10-04T09:15:25Z","git_url":"git://github.com/csmoe/witnet-rust.git","ssh_url":"git@github.com:csmoe/witnet-rust.git","clone_url":"https://github.com/csmoe/witnet-rust.git","svn_url":"https://github.com/csmoe/witnet-rust","homepage":"https://witnet.io","size":539,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"witnet:master","ref":"master","sha":"98d3c67a2de56a4f82109927da3ff5e8f653cf8e","user":{"login":"witnet","id":33759927,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNzU5OTI3","avatar_url":"https://avatars0.githubusercontent.com/u/33759927?v=4","gravatar_id":"","url":"https://api.github.com/users/witnet","html_url":"https://github.com/witnet","followers_url":"https://api.github.com/users/witnet/followers","following_url":"https://api.github.com/users/witnet/following{/other_user}","gists_url":"https://api.github.com/users/witnet/gists{/gist_id}","starred_url":"https://api.github.com/users/witnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/witnet/subscriptions","organizations_url":"https://api.github.com/users/witnet/orgs","repos_url":"https://api.github.com/users/witnet/repos","events_url":"https://api.github.com/users/witnet/events{/privacy}","received_events_url":"https://api.github.com/users/witnet/received_events","type":"Organization","site_admin":false},"repo":{"id":120209021,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAyMDkwMjE=","name":"witnet-rust","full_name":"witnet/witnet-rust","private":false,"owner":{"login":"witnet","id":33759927,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNzU5OTI3","avatar_url":"https://avatars0.githubusercontent.com/u/33759927?v=4","gravatar_id":"","url":"https://api.github.com/users/witnet","html_url":"https://github.com/witnet","followers_url":"https://api.github.com/users/witnet/followers","following_url":"https://api.github.com/users/witnet/following{/other_user}","gists_url":"https://api.github.com/users/witnet/gists{/gist_id}","starred_url":"https://api.github.com/users/witnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/witnet/subscriptions","organizations_url":"https://api.github.com/users/witnet/orgs","repos_url":"https://api.github.com/users/witnet/repos","events_url":"https://api.github.com/users/witnet/events{/privacy}","received_events_url":"https://api.github.com/users/witnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/witnet/witnet-rust","description":"An in-progress open source implementation of the Witnet protocol written in Rust.","fork":false,"url":"https://api.github.com/repos/witnet/witnet-rust","forks_url":"https://api.github.com/repos/witnet/witnet-rust/forks","keys_url":"https://api.github.com/repos/witnet/witnet-rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/witnet/witnet-rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/witnet/witnet-rust/teams","hooks_url":"https://api.github.com/repos/witnet/witnet-rust/hooks","issue_events_url":"https://api.github.com/repos/witnet/witnet-rust/issues/events{/number}","events_url":"https://api.github.com/repos/witnet/witnet-rust/events","assignees_url":"https://api.github.com/repos/witnet/witnet-rust/assignees{/user}","branches_url":"https://api.github.com/repos/witnet/witnet-rust/branches{/branch}","tags_url":"https://api.github.com/repos/witnet/witnet-rust/tags","blobs_url":"https://api.github.com/repos/witnet/witnet-rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/witnet/witnet-rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/witnet/witnet-rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/witnet/witnet-rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/witnet/witnet-rust/statuses/{sha}","languages_url":"https://api.github.com/repos/witnet/witnet-rust/languages","stargazers_url":"https://api.github.com/repos/witnet/witnet-rust/stargazers","contributors_url":"https://api.github.com/repos/witnet/witnet-rust/contributors","subscribers_url":"https://api.github.com/repos/witnet/witnet-rust/subscribers","subscription_url":"https://api.github.com/repos/witnet/witnet-rust/subscription","commits_url":"https://api.github.com/repos/witnet/witnet-rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/witnet/witnet-rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/witnet/witnet-rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/witnet/witnet-rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/witnet/witnet-rust/contents/{+path}","compare_url":"https://api.github.com/repos/witnet/witnet-rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/witnet/witnet-rust/merges","archive_url":"https://api.github.com/repos/witnet/witnet-rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/witnet/witnet-rust/downloads","issues_url":"https://api.github.com/repos/witnet/witnet-rust/issues{/number}","pulls_url":"https://api.github.com/repos/witnet/witnet-rust/pulls{/number}","milestones_url":"https://api.github.com/repos/witnet/witnet-rust/milestones{/number}","notifications_url":"https://api.github.com/repos/witnet/witnet-rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/witnet/witnet-rust/labels{/name}","releases_url":"https://api.github.com/repos/witnet/witnet-rust/releases{/id}","deployments_url":"https://api.github.com/repos/witnet/witnet-rust/deployments","created_at":"2018-02-04T17:59:46Z","updated_at":"2018-10-04T08:47:07Z","pushed_at":"2018-10-04T02:30:23Z","git_url":"git://github.com/witnet/witnet-rust.git","ssh_url":"git@github.com:witnet/witnet-rust.git","clone_url":"https://github.com/witnet/witnet-rust.git","svn_url":"https://github.com/witnet/witnet-rust","homepage":"https://docs.witnet.io","size":1117,"stargazers_count":22,"watchers_count":22,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":10,"open_issues":3,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/witnet/witnet-rust/pulls/27"},"html":{"href":"https://github.com/witnet/witnet-rust/pull/27"},"issue":{"href":"https://api.github.com/repos/witnet/witnet-rust/issues/27"},"comments":{"href":"https://api.github.com/repos/witnet/witnet-rust/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/witnet/witnet-rust/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/witnet/witnet-rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/witnet/witnet-rust/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/witnet/witnet-rust/statuses/bf011a2b76bc324a5505e28aca458f05e0260294"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"aesedepece"}}