{"action":"created","comment":{"url":"https://api.github.com/repos/runconduit/conduit/pulls/comments/194553878","pull_request_review_id":127748776,"id":194553878,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDU1Mzg3OA==","diff_hunk":"@@ -0,0 +1,17 @@\n+#!/bin/bash\n+\n+set -eu\n+\n+if [ $# -ne 0 ]; then\n+    echo \"no arguments allowed for $(basename $0), given: $@\" >&2\n+    exit 64\n+fi\n+\n+bindir=\"$( cd \"$( dirname \"${BASH_SOURCE[0]}\" )\" && pwd )\"\n+rootdir=\"$( cd $bindir/.. && pwd )\"\n+\n+docker build -f $rootdir/proxy/Dockerfile . \\\n+    --target build \\\n+    -t proxy-build \\\n+    --build-arg=PROXY_UNOPTIMIZED=1 &&","path":"bin/docker-test-proxy","position":16,"original_position":16,"commit_id":"c64559150f67f7d228eb744f629e9742b0d32d20","original_commit_id":"c64559150f67f7d228eb744f629e9742b0d32d20","user":{"login":"olix0r","id":240738,"node_id":"MDQ6VXNlcjI0MDczOA==","avatar_url":"https://avatars3.githubusercontent.com/u/240738?v=4","gravatar_id":"","url":"https://api.github.com/users/olix0r","html_url":"https://github.com/olix0r","followers_url":"https://api.github.com/users/olix0r/followers","following_url":"https://api.github.com/users/olix0r/following{/other_user}","gists_url":"https://api.github.com/users/olix0r/gists{/gist_id}","starred_url":"https://api.github.com/users/olix0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olix0r/subscriptions","organizations_url":"https://api.github.com/users/olix0r/orgs","repos_url":"https://api.github.com/users/olix0r/repos","events_url":"https://api.github.com/users/olix0r/events{/privacy}","received_events_url":"https://api.github.com/users/olix0r/received_events","type":"User","site_admin":false},"body":"I'd just remove the ` && ` since it's redundant\r\n\r\nyou may or may not want to use `docker_build proxy ... --target=build --build-arg=...`, since this will make it interact well with `DOCKER_TRACE`, rtc","created_at":"2018-06-11T21:28:35Z","updated_at":"2018-06-11T21:28:36Z","html_url":"https://github.com/runconduit/conduit/pull/1102#discussion_r194553878","pull_request_url":"https://api.github.com/repos/runconduit/conduit/pulls/1102","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/runconduit/conduit/pulls/comments/194553878"},"html":{"href":"https://github.com/runconduit/conduit/pull/1102#discussion_r194553878"},"pull_request":{"href":"https://api.github.com/repos/runconduit/conduit/pulls/1102"}}},"pull_request":{"url":"https://api.github.com/repos/runconduit/conduit/pulls/1102","id":194064586,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MDY0NTg2","html_url":"https://github.com/runconduit/conduit/pull/1102","diff_url":"https://github.com/runconduit/conduit/pull/1102.diff","patch_url":"https://github.com/runconduit/conduit/pull/1102.patch","issue_url":"https://api.github.com/repos/runconduit/conduit/issues/1102","number":1102,"state":"open","locked":false,"title":"Add a script for running proxy tests in Docker","user":{"login":"hawkw","id":2796466,"node_id":"MDQ6VXNlcjI3OTY0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/2796466?v=4","gravatar_id":"","url":"https://api.github.com/users/hawkw","html_url":"https://github.com/hawkw","followers_url":"https://api.github.com/users/hawkw/followers","following_url":"https://api.github.com/users/hawkw/following{/other_user}","gists_url":"https://api.github.com/users/hawkw/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkw/subscriptions","organizations_url":"https://api.github.com/users/hawkw/orgs","repos_url":"https://api.github.com/users/hawkw/repos","events_url":"https://api.github.com/users/hawkw/events{/privacy}","received_events_url":"https://api.github.com/users/hawkw/received_events","type":"User","site_admin":false},"body":"When developing features in the proxy, that rely on Linux-only OS features,\r\ndevelopers using other operating systems may find it inconvenient to test\r\ntheir changes. While we run CI builds on Linux, and may have access to Linux\r\ntesting environments, this is not as tightly integrated into the proxy \r\ndevelopment workflow as running a quick `cargo test` on the host OS.\r\n\r\nFor example, I found it inconvenient to test the `inotify` based filesystem\r\nwatch code I've been adding in recent commits, and had to do things like\r\nopening a WIP PR for a branch to get CI to run the tests. This workflow is not\r\nideal.\r\n\r\nThis PR adds an (admittedly somewhat hacky) script and Dockerfile for running\r\nthe proxy's tests in Docker. This accomplishes approximately the same goal as \r\nthe `PROXY_SKIP_TESTS` flag that we used to have, but with the advantage that \r\nwe no longer include the test dependencies in release builds. \r\n\r\nOf course, this also means that we no longer share any of the dependencies \r\nbetween the test docker build and the release docker build, which is a shame. \r\nIt might be worthwhile to re-introduce a dependencies image so that cached\r\nbuilds of the proxy's dependencies can be shared between the test and release\r\nDockerfiles. However, I thought that deserved to be discussed separately from\r\nthe changes I made in this branch.\r\n\r\nSigned-off-by: Eliza Weisman <eliza@buoyant.io>","created_at":"2018-06-11T18:27:48Z","updated_at":"2018-06-11T21:28:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f7fc5c47493c39194d4872dfb1349c69021bfcf","assignee":{"login":"hawkw","id":2796466,"node_id":"MDQ6VXNlcjI3OTY0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/2796466?v=4","gravatar_id":"","url":"https://api.github.com/users/hawkw","html_url":"https://github.com/hawkw","followers_url":"https://api.github.com/users/hawkw/followers","following_url":"https://api.github.com/users/hawkw/following{/other_user}","gists_url":"https://api.github.com/users/hawkw/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkw/subscriptions","organizations_url":"https://api.github.com/users/hawkw/orgs","repos_url":"https://api.github.com/users/hawkw/repos","events_url":"https://api.github.com/users/hawkw/events{/privacy}","received_events_url":"https://api.github.com/users/hawkw/received_events","type":"User","site_admin":false},"assignees":[{"login":"hawkw","id":2796466,"node_id":"MDQ6VXNlcjI3OTY0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/2796466?v=4","gravatar_id":"","url":"https://api.github.com/users/hawkw","html_url":"https://github.com/hawkw","followers_url":"https://api.github.com/users/hawkw/followers","following_url":"https://api.github.com/users/hawkw/following{/other_user}","gists_url":"https://api.github.com/users/hawkw/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkw/subscriptions","organizations_url":"https://api.github.com/users/hawkw/orgs","repos_url":"https://api.github.com/users/hawkw/repos","events_url":"https://api.github.com/users/hawkw/events{/privacy}","received_events_url":"https://api.github.com/users/hawkw/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"briansmith","id":16816,"node_id":"MDQ6VXNlcjE2ODE2","avatar_url":"https://avatars0.githubusercontent.com/u/16816?v=4","gravatar_id":"","url":"https://api.github.com/users/briansmith","html_url":"https://github.com/briansmith","followers_url":"https://api.github.com/users/briansmith/followers","following_url":"https://api.github.com/users/briansmith/following{/other_user}","gists_url":"https://api.github.com/users/briansmith/gists{/gist_id}","starred_url":"https://api.github.com/users/briansmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briansmith/subscriptions","organizations_url":"https://api.github.com/users/briansmith/orgs","repos_url":"https://api.github.com/users/briansmith/repos","events_url":"https://api.github.com/users/briansmith/events{/privacy}","received_events_url":"https://api.github.com/users/briansmith/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":782680695,"node_id":"MDU6TGFiZWw3ODI2ODA2OTU=","url":"https://api.github.com/repos/runconduit/conduit/labels/area/build","name":"area/build","color":"0052CC","default":false},{"id":773709989,"node_id":"MDU6TGFiZWw3NzM3MDk5ODk=","url":"https://api.github.com/repos/runconduit/conduit/labels/area/proxy","name":"area/proxy","color":"0052CC","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/runconduit/conduit/pulls/1102/commits","review_comments_url":"https://api.github.com/repos/runconduit/conduit/pulls/1102/comments","review_comment_url":"https://api.github.com/repos/runconduit/conduit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/runconduit/conduit/issues/1102/comments","statuses_url":"https://api.github.com/repos/runconduit/conduit/statuses/c64559150f67f7d228eb744f629e9742b0d32d20","head":{"label":"runconduit:eliza/docker-test-proxy","ref":"eliza/docker-test-proxy","sha":"c64559150f67f7d228eb744f629e9742b0d32d20","user":{"login":"runconduit","id":33942733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzOTQyNzMz","avatar_url":"https://avatars2.githubusercontent.com/u/33942733?v=4","gravatar_id":"","url":"https://api.github.com/users/runconduit","html_url":"https://github.com/runconduit","followers_url":"https://api.github.com/users/runconduit/followers","following_url":"https://api.github.com/users/runconduit/following{/other_user}","gists_url":"https://api.github.com/users/runconduit/gists{/gist_id}","starred_url":"https://api.github.com/users/runconduit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runconduit/subscriptions","organizations_url":"https://api.github.com/users/runconduit/orgs","repos_url":"https://api.github.com/users/runconduit/repos","events_url":"https://api.github.com/users/runconduit/events{/privacy}","received_events_url":"https://api.github.com/users/runconduit/received_events","type":"Organization","site_admin":false},"repo":{"id":113106184,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMxMDYxODQ=","name":"conduit","full_name":"runconduit/conduit","owner":{"login":"runconduit","id":33942733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzOTQyNzMz","avatar_url":"https://avatars2.githubusercontent.com/u/33942733?v=4","gravatar_id":"","url":"https://api.github.com/users/runconduit","html_url":"https://github.com/runconduit","followers_url":"https://api.github.com/users/runconduit/followers","following_url":"https://api.github.com/users/runconduit/following{/other_user}","gists_url":"https://api.github.com/users/runconduit/gists{/gist_id}","starred_url":"https://api.github.com/users/runconduit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runconduit/subscriptions","organizations_url":"https://api.github.com/users/runconduit/orgs","repos_url":"https://api.github.com/users/runconduit/repos","events_url":"https://api.github.com/users/runconduit/events{/privacy}","received_events_url":"https://api.github.com/users/runconduit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/runconduit/conduit","description":"Ultralight service mesh for Kubernetes","fork":false,"url":"https://api.github.com/repos/runconduit/conduit","forks_url":"https://api.github.com/repos/runconduit/conduit/forks","keys_url":"https://api.github.com/repos/runconduit/conduit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runconduit/conduit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runconduit/conduit/teams","hooks_url":"https://api.github.com/repos/runconduit/conduit/hooks","issue_events_url":"https://api.github.com/repos/runconduit/conduit/issues/events{/number}","events_url":"https://api.github.com/repos/runconduit/conduit/events","assignees_url":"https://api.github.com/repos/runconduit/conduit/assignees{/user}","branches_url":"https://api.github.com/repos/runconduit/conduit/branches{/branch}","tags_url":"https://api.github.com/repos/runconduit/conduit/tags","blobs_url":"https://api.github.com/repos/runconduit/conduit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runconduit/conduit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runconduit/conduit/git/refs{/sha}","trees_url":"https://api.github.com/repos/runconduit/conduit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runconduit/conduit/statuses/{sha}","languages_url":"https://api.github.com/repos/runconduit/conduit/languages","stargazers_url":"https://api.github.com/repos/runconduit/conduit/stargazers","contributors_url":"https://api.github.com/repos/runconduit/conduit/contributors","subscribers_url":"https://api.github.com/repos/runconduit/conduit/subscribers","subscription_url":"https://api.github.com/repos/runconduit/conduit/subscription","commits_url":"https://api.github.com/repos/runconduit/conduit/commits{/sha}","git_commits_url":"https://api.github.com/repos/runconduit/conduit/git/commits{/sha}","comments_url":"https://api.github.com/repos/runconduit/conduit/comments{/number}","issue_comment_url":"https://api.github.com/repos/runconduit/conduit/issues/comments{/number}","contents_url":"https://api.github.com/repos/runconduit/conduit/contents/{+path}","compare_url":"https://api.github.com/repos/runconduit/conduit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runconduit/conduit/merges","archive_url":"https://api.github.com/repos/runconduit/conduit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runconduit/conduit/downloads","issues_url":"https://api.github.com/repos/runconduit/conduit/issues{/number}","pulls_url":"https://api.github.com/repos/runconduit/conduit/pulls{/number}","milestones_url":"https://api.github.com/repos/runconduit/conduit/milestones{/number}","notifications_url":"https://api.github.com/repos/runconduit/conduit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runconduit/conduit/labels{/name}","releases_url":"https://api.github.com/repos/runconduit/conduit/releases{/id}","deployments_url":"https://api.github.com/repos/runconduit/conduit/deployments","created_at":"2017-12-04T23:16:56Z","updated_at":"2018-06-11T19:23:28Z","pushed_at":"2018-06-11T21:25:34Z","git_url":"git://github.com/runconduit/conduit.git","ssh_url":"git@github.com:runconduit/conduit.git","clone_url":"https://github.com/runconduit/conduit.git","svn_url":"https://github.com/runconduit/conduit","homepage":"https://conduit.io","size":5766,"stargazers_count":1806,"watchers_count":1806,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":110,"mirror_url":null,"archived":false,"open_issues_count":176,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":110,"open_issues":176,"watchers":1806,"default_branch":"master"}},"base":{"label":"runconduit:master","ref":"master","sha":"3ae8dcd3691ae8fd76e3b055021ef7907db8420d","user":{"login":"runconduit","id":33942733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzOTQyNzMz","avatar_url":"https://avatars2.githubusercontent.com/u/33942733?v=4","gravatar_id":"","url":"https://api.github.com/users/runconduit","html_url":"https://github.com/runconduit","followers_url":"https://api.github.com/users/runconduit/followers","following_url":"https://api.github.com/users/runconduit/following{/other_user}","gists_url":"https://api.github.com/users/runconduit/gists{/gist_id}","starred_url":"https://api.github.com/users/runconduit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runconduit/subscriptions","organizations_url":"https://api.github.com/users/runconduit/orgs","repos_url":"https://api.github.com/users/runconduit/repos","events_url":"https://api.github.com/users/runconduit/events{/privacy}","received_events_url":"https://api.github.com/users/runconduit/received_events","type":"Organization","site_admin":false},"repo":{"id":113106184,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMxMDYxODQ=","name":"conduit","full_name":"runconduit/conduit","owner":{"login":"runconduit","id":33942733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzOTQyNzMz","avatar_url":"https://avatars2.githubusercontent.com/u/33942733?v=4","gravatar_id":"","url":"https://api.github.com/users/runconduit","html_url":"https://github.com/runconduit","followers_url":"https://api.github.com/users/runconduit/followers","following_url":"https://api.github.com/users/runconduit/following{/other_user}","gists_url":"https://api.github.com/users/runconduit/gists{/gist_id}","starred_url":"https://api.github.com/users/runconduit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runconduit/subscriptions","organizations_url":"https://api.github.com/users/runconduit/orgs","repos_url":"https://api.github.com/users/runconduit/repos","events_url":"https://api.github.com/users/runconduit/events{/privacy}","received_events_url":"https://api.github.com/users/runconduit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/runconduit/conduit","description":"Ultralight service mesh for Kubernetes","fork":false,"url":"https://api.github.com/repos/runconduit/conduit","forks_url":"https://api.github.com/repos/runconduit/conduit/forks","keys_url":"https://api.github.com/repos/runconduit/conduit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runconduit/conduit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runconduit/conduit/teams","hooks_url":"https://api.github.com/repos/runconduit/conduit/hooks","issue_events_url":"https://api.github.com/repos/runconduit/conduit/issues/events{/number}","events_url":"https://api.github.com/repos/runconduit/conduit/events","assignees_url":"https://api.github.com/repos/runconduit/conduit/assignees{/user}","branches_url":"https://api.github.com/repos/runconduit/conduit/branches{/branch}","tags_url":"https://api.github.com/repos/runconduit/conduit/tags","blobs_url":"https://api.github.com/repos/runconduit/conduit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runconduit/conduit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runconduit/conduit/git/refs{/sha}","trees_url":"https://api.github.com/repos/runconduit/conduit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runconduit/conduit/statuses/{sha}","languages_url":"https://api.github.com/repos/runconduit/conduit/languages","stargazers_url":"https://api.github.com/repos/runconduit/conduit/stargazers","contributors_url":"https://api.github.com/repos/runconduit/conduit/contributors","subscribers_url":"https://api.github.com/repos/runconduit/conduit/subscribers","subscription_url":"https://api.github.com/repos/runconduit/conduit/subscription","commits_url":"https://api.github.com/repos/runconduit/conduit/commits{/sha}","git_commits_url":"https://api.github.com/repos/runconduit/conduit/git/commits{/sha}","comments_url":"https://api.github.com/repos/runconduit/conduit/comments{/number}","issue_comment_url":"https://api.github.com/repos/runconduit/conduit/issues/comments{/number}","contents_url":"https://api.github.com/repos/runconduit/conduit/contents/{+path}","compare_url":"https://api.github.com/repos/runconduit/conduit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runconduit/conduit/merges","archive_url":"https://api.github.com/repos/runconduit/conduit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runconduit/conduit/downloads","issues_url":"https://api.github.com/repos/runconduit/conduit/issues{/number}","pulls_url":"https://api.github.com/repos/runconduit/conduit/pulls{/number}","milestones_url":"https://api.github.com/repos/runconduit/conduit/milestones{/number}","notifications_url":"https://api.github.com/repos/runconduit/conduit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runconduit/conduit/labels{/name}","releases_url":"https://api.github.com/repos/runconduit/conduit/releases{/id}","deployments_url":"https://api.github.com/repos/runconduit/conduit/deployments","created_at":"2017-12-04T23:16:56Z","updated_at":"2018-06-11T19:23:28Z","pushed_at":"2018-06-11T21:25:34Z","git_url":"git://github.com/runconduit/conduit.git","ssh_url":"git@github.com:runconduit/conduit.git","clone_url":"https://github.com/runconduit/conduit.git","svn_url":"https://github.com/runconduit/conduit","homepage":"https://conduit.io","size":5766,"stargazers_count":1806,"watchers_count":1806,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":110,"mirror_url":null,"archived":false,"open_issues_count":176,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":110,"open_issues":176,"watchers":1806,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/runconduit/conduit/pulls/1102"},"html":{"href":"https://github.com/runconduit/conduit/pull/1102"},"issue":{"href":"https://api.github.com/repos/runconduit/conduit/issues/1102"},"comments":{"href":"https://api.github.com/repos/runconduit/conduit/issues/1102/comments"},"review_comments":{"href":"https://api.github.com/repos/runconduit/conduit/pulls/1102/comments"},"review_comment":{"href":"https://api.github.com/repos/runconduit/conduit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/runconduit/conduit/pulls/1102/commits"},"statuses":{"href":"https://api.github.com/repos/runconduit/conduit/statuses/c64559150f67f7d228eb744f629e9742b0d32d20"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"olix0r"}}