{"action":"created","issue":{"url":"https://api.github.com/repos/MARKETProtocol/types/issues/1","repository_url":"https://api.github.com/repos/MARKETProtocol/types","labels_url":"https://api.github.com/repos/MARKETProtocol/types/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/MARKETProtocol/types/issues/1/comments","events_url":"https://api.github.com/repos/MARKETProtocol/types/issues/1/events","html_url":"https://github.com/MARKETProtocol/types/pull/1","id":328929030,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMzEyNzEw","number":1,"title":"Convert ABIs to TypeScript","user":{"login":"ConnorChristie","id":1206980,"node_id":"MDQ6VXNlcjEyMDY5ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/1206980?v=4","gravatar_id":"","url":"https://api.github.com/users/ConnorChristie","html_url":"https://github.com/ConnorChristie","followers_url":"https://api.github.com/users/ConnorChristie/followers","following_url":"https://api.github.com/users/ConnorChristie/following{/other_user}","gists_url":"https://api.github.com/users/ConnorChristie/gists{/gist_id}","starred_url":"https://api.github.com/users/ConnorChristie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConnorChristie/subscriptions","organizations_url":"https://api.github.com/users/ConnorChristie/orgs","repos_url":"https://api.github.com/users/ConnorChristie/repos","events_url":"https://api.github.com/users/ConnorChristie/events{/privacy}","received_events_url":"https://api.github.com/users/ConnorChristie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-04T06:51:24Z","updated_at":"2018-06-04T13:52:34Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/MARKETProtocol/types/pulls/1","html_url":"https://github.com/MARKETProtocol/types/pull/1","diff_url":"https://github.com/MARKETProtocol/types/pull/1.diff","patch_url":"https://github.com/MARKETProtocol/types/pull/1.patch"},"body":"#### Description\r\nThis converts the ABIs into their Typescript representatives with unit tests to ensure all methods have been appropriately generated.\r\n\r\n#### Implementation details\r\n[Typechain](https://github.com/Neufund/TypeChain) is being used to generate types and the ABIs from which to generate the types is specified as a glob pattern in the package.json under config.typechain.include which is currently set to: `Market*|CollateralToken|OraclizeQueryTest|ERC20|OrderLib`\r\n\r\n#### Original issue\r\nhttps://github.com/MARKETProtocol/MARKET.js/issues/14\r\n\r\n#### TODO\r\n- [x] MarketToken tests\r\n- [ ] CollateralToken tests\r\n- [ ] ERC20 tests\r\n- [ ] MarketCollateralPool tests\r\n- [ ] MarketContract tests\r\n- [ ] MarketContractFactoryOraclize tests\r\n- [ ] MarketContractOraclize tests\r\n- [ ] MarketContractRegistry tests\r\n- [ ] OraclizeQueryTest tests\r\n- [ ] OrderLib tests\r\n\r\nThere are quite a few tests that have yet to be added which is quite laborious, if anyone is willing to help out, that would be very appreciated!\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/MARKETProtocol/types/issues/comments/394362256","html_url":"https://github.com/MARKETProtocol/types/pull/1#issuecomment-394362256","issue_url":"https://api.github.com/repos/MARKETProtocol/types/issues/1","id":394362256,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDM2MjI1Ng==","user":{"login":"pelsasser","id":15096737,"node_id":"MDQ6VXNlcjE1MDk2NzM3","avatar_url":"https://avatars1.githubusercontent.com/u/15096737?v=4","gravatar_id":"","url":"https://api.github.com/users/pelsasser","html_url":"https://github.com/pelsasser","followers_url":"https://api.github.com/users/pelsasser/followers","following_url":"https://api.github.com/users/pelsasser/following{/other_user}","gists_url":"https://api.github.com/users/pelsasser/gists{/gist_id}","starred_url":"https://api.github.com/users/pelsasser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelsasser/subscriptions","organizations_url":"https://api.github.com/users/pelsasser/orgs","repos_url":"https://api.github.com/users/pelsasser/repos","events_url":"https://api.github.com/users/pelsasser/events{/privacy}","received_events_url":"https://api.github.com/users/pelsasser/received_events","type":"User","site_admin":false},"created_at":"2018-06-04T13:52:34Z","updated_at":"2018-06-04T13:52:34Z","author_association":"MEMBER","body":"@ConnorChristie Thanks so much for the PR! We can definitely get some more hands on deck to help with all the testing, happy to stake some more issues with gitcoin to get some traction there once this gets merged. \r\n\r\nWill let @eswarasai coordinate that, but @ConnorChristie thanks for all your hard work!\r\n"}}
{"actor":{"display_login":"pelsasser"}}