{"action":"created","issue":{"url":"https://api.github.com/repos/groupon/ansible-silo/issues/52","repository_url":"https://api.github.com/repos/groupon/ansible-silo","labels_url":"https://api.github.com/repos/groupon/ansible-silo/issues/52/labels{/name}","comments_url":"https://api.github.com/repos/groupon/ansible-silo/issues/52/comments","events_url":"https://api.github.com/repos/groupon/ansible-silo/issues/52/events","html_url":"https://github.com/groupon/ansible-silo/issues/52","id":288722964,"number":52,"title":"Include bcrypt in base image","user":{"login":"bdlamprecht","id":7783306,"avatar_url":"https://avatars3.githubusercontent.com/u/7783306?v=4","gravatar_id":"","url":"https://api.github.com/users/bdlamprecht","html_url":"https://github.com/bdlamprecht","followers_url":"https://api.github.com/users/bdlamprecht/followers","following_url":"https://api.github.com/users/bdlamprecht/following{/other_user}","gists_url":"https://api.github.com/users/bdlamprecht/gists{/gist_id}","starred_url":"https://api.github.com/users/bdlamprecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdlamprecht/subscriptions","organizations_url":"https://api.github.com/users/bdlamprecht/orgs","repos_url":"https://api.github.com/users/bdlamprecht/repos","events_url":"https://api.github.com/users/bdlamprecht/events{/privacy}","received_events_url":"https://api.github.com/users/bdlamprecht/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-01-15T21:39:07Z","updated_at":"2018-02-22T16:22:31Z","closed_at":"2018-02-22T16:22:31Z","author_association":"NONE","body":"Hey, its me again... :blush: \r\nI've discovered that I need the python package `bcrypt>=3.1.3` which requires it to be compiled during the build stage.  \r\n\r\nWhile looking into the Dockerfile more closely, I see the that you also compile a number of python packages as well.\r\n\r\nFrom the file [base.Dockerfile](https://github.com/groupon/ansible-silo/blob/84403720ba55842ee2dc2ddea15d8a820b9dfa9f/base.Dockerfile#L88L108):\r\n```\r\n# Install some required python modules which need compiling\r\n    apk add --no-cache gcc=6.3.0-r4\\\r\n                       musl=1.1.16-r13\\\r\n                       musl-dev=1.1.16-r13\\\r\n                       musl-utils=1.1.16-r13\\\r\n                       binutils-libs=2.28-r2\\\r\n                       binutils=2.28-r2\\\r\n                       isl=0.17.1-r0\\\r\n                       libgomp=6.3.0-r4\\\r\n                       libatomic=6.3.0-r4\\\r\n                       pkgconf=1.3.7-r0\\\r\n                       libgcc=6.3.0-r4\\\r\n                       mpfr3=3.1.5-r0\\\r\n                       mpc1=1.0.3-r0\\\r\n                       libstdc++=6.3.0-r4\\\r\n                       zlib-dev=1.2.11-r0\\\r\n                       python2-dev=2.7.13-r1\\\r\n                       openssl-dev=1.0.2k-r0\\\r\n                       libffi-dev=3.2.1-r3\\\r\n                       libxml2-dev=2.9.4-r4\\\r\n                       libxslt-dev=1.1.29-r3 &&\\\r\n```\r\n\r\nWhat could I do to convince you to add `bcrypt` as well?\r\n\r\nAlternatively, if you're against that for what ever reason, I'm wondering if you could provide a way for the user to define which packages need to be compiled and included?  I have a feeling that would be somewhat more difficult to implement correctly, but thought I would ask anyways.\r\n\r\nAs always, I'm truly grateful for the help! :smile: "},"comment":{"url":"https://api.github.com/repos/groupon/ansible-silo/issues/comments/367735209","html_url":"https://github.com/groupon/ansible-silo/issues/52#issuecomment-367735209","issue_url":"https://api.github.com/repos/groupon/ansible-silo/issues/52","id":367735209,"user":{"login":"bdlamprecht","id":7783306,"avatar_url":"https://avatars3.githubusercontent.com/u/7783306?v=4","gravatar_id":"","url":"https://api.github.com/users/bdlamprecht","html_url":"https://github.com/bdlamprecht","followers_url":"https://api.github.com/users/bdlamprecht/followers","following_url":"https://api.github.com/users/bdlamprecht/following{/other_user}","gists_url":"https://api.github.com/users/bdlamprecht/gists{/gist_id}","starred_url":"https://api.github.com/users/bdlamprecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdlamprecht/subscriptions","organizations_url":"https://api.github.com/users/bdlamprecht/orgs","repos_url":"https://api.github.com/users/bdlamprecht/repos","events_url":"https://api.github.com/users/bdlamprecht/events{/privacy}","received_events_url":"https://api.github.com/users/bdlamprecht/received_events","type":"User","site_admin":false},"created_at":"2018-02-22T16:22:31Z","updated_at":"2018-02-22T16:22:31Z","author_association":"NONE","body":"Similar to issue #54:\r\n\r\nI've been able to solve this by rebuilding grpn/ansible-silo-base:3.0.0 and grpn/ansible-silo:3.0.0.\r\nI'm still working through some issues, but when I'm ready, I will submit a PR."}}
{"actor":{"display_login":"bdlamprecht"}}