{"action":"created","comment":{"url":"https://api.github.com/repos/aerogear/data-sync-server/pulls/comments/199717222","pull_request_review_id":133887870,"id":199717222,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTcxNzIyMg==","diff_hunk":"@@ -33,9 +54,29 @@ module.exports = function (dataSourceTypes, dataSourceClients, resolverMappingsJ\n }\n \n function buildPostgresResolver (dataSourceClient, requestMapping, responseMapping) {\n+  // use Handlebars.precompile to fail early during initialization\n+  try {\n+    Handlebars.precompile(requestMapping)\n+  } catch (ex) {\n+    console.error('Compilation error in requestMapping: ' + requestMapping)\n+    console.error(ex)\n+    throw new Error('Compilation error in requestMapping: ' + requestMapping)","path":"server/lib/resolverMaker.js","position":50,"original_position":50,"commit_id":"57a9d8659947343b1142289da6d1f3a90b231290","original_commit_id":"57a9d8659947343b1142289da6d1f3a90b231290","user":{"login":"aliok","id":376732,"node_id":"MDQ6VXNlcjM3NjczMg==","avatar_url":"https://avatars2.githubusercontent.com/u/376732?v=4","gravatar_id":"","url":"https://api.github.com/users/aliok","html_url":"https://github.com/aliok","followers_url":"https://api.github.com/users/aliok/followers","following_url":"https://api.github.com/users/aliok/following{/other_user}","gists_url":"https://api.github.com/users/aliok/gists{/gist_id}","starred_url":"https://api.github.com/users/aliok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliok/subscriptions","organizations_url":"https://api.github.com/users/aliok/orgs","repos_url":"https://api.github.com/users/aliok/repos","events_url":"https://api.github.com/users/aliok/events{/privacy}","received_events_url":"https://api.github.com/users/aliok/received_events","type":"User","site_admin":false},"body":"Good point. Let's keep that in mind.","created_at":"2018-07-03T08:06:17Z","updated_at":"2018-07-03T08:06:17Z","html_url":"https://github.com/aerogear/data-sync-server/pull/8#discussion_r199717222","pull_request_url":"https://api.github.com/repos/aerogear/data-sync-server/pulls/8","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aerogear/data-sync-server/pulls/comments/199717222"},"html":{"href":"https://github.com/aerogear/data-sync-server/pull/8#discussion_r199717222"},"pull_request":{"href":"https://api.github.com/repos/aerogear/data-sync-server/pulls/8"}},"in_reply_to_id":199516327},"pull_request":{"url":"https://api.github.com/repos/aerogear/data-sync-server/pulls/8","id":198675440,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4Njc1NDQw","html_url":"https://github.com/aerogear/data-sync-server/pull/8","diff_url":"https://github.com/aerogear/data-sync-server/pull/8.diff","patch_url":"https://github.com/aerogear/data-sync-server/pull/8.patch","issue_url":"https://api.github.com/repos/aerogear/data-sync-server/issues/8","number":8,"state":"closed","locked":false,"title":"AEROGEAR-3435: Add initial unit tests and handle some unhandled base cases","user":{"login":"aliok","id":376732,"node_id":"MDQ6VXNlcjM3NjczMg==","avatar_url":"https://avatars2.githubusercontent.com/u/376732?v=4","gravatar_id":"","url":"https://api.github.com/users/aliok","html_url":"https://github.com/aliok","followers_url":"https://api.github.com/users/aliok/followers","following_url":"https://api.github.com/users/aliok/following{/other_user}","gists_url":"https://api.github.com/users/aliok/gists{/gist_id}","starred_url":"https://api.github.com/users/aliok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliok/subscriptions","organizations_url":"https://api.github.com/users/aliok/orgs","repos_url":"https://api.github.com/users/aliok/repos","events_url":"https://api.github.com/users/aliok/events{/privacy}","received_events_url":"https://api.github.com/users/aliok/received_events","type":"User","site_admin":false},"body":"JIRA: https://issues.jboss.org/browse/AEROGEAR-3435\r\n\r\n- Introduced Ava testing framework\r\n- Added unit tests to where it makes sense.\r\n- While writing tests for base cases, I noticed there are some base cases not handled. I added handling for them.\r\n- Validate Handlebars templates in advance to fail early (was waiting until a query/mutation is executed to fail)\r\n- No integration tests!\r\n\r\nVerification:\r\n1. Do run npm test\r\n2. Do start the app, execute some stuff over Graphiql\r\n","created_at":"2018-07-02T13:12:36Z","updated_at":"2018-07-03T08:06:17Z","closed_at":"2018-07-02T14:14:25Z","merged_at":"2018-07-02T14:14:25Z","merge_commit_sha":"cd24370fb7b6b455472c507a65a6e727239b860c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aerogear/data-sync-server/pulls/8/commits","review_comments_url":"https://api.github.com/repos/aerogear/data-sync-server/pulls/8/comments","review_comment_url":"https://api.github.com/repos/aerogear/data-sync-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aerogear/data-sync-server/issues/8/comments","statuses_url":"https://api.github.com/repos/aerogear/data-sync-server/statuses/57a9d8659947343b1142289da6d1f3a90b231290","head":{"label":"aliok:AEROGEAR-3435-unit-tests-initial","ref":"AEROGEAR-3435-unit-tests-initial","sha":"57a9d8659947343b1142289da6d1f3a90b231290","user":{"login":"aliok","id":376732,"node_id":"MDQ6VXNlcjM3NjczMg==","avatar_url":"https://avatars2.githubusercontent.com/u/376732?v=4","gravatar_id":"","url":"https://api.github.com/users/aliok","html_url":"https://github.com/aliok","followers_url":"https://api.github.com/users/aliok/followers","following_url":"https://api.github.com/users/aliok/following{/other_user}","gists_url":"https://api.github.com/users/aliok/gists{/gist_id}","starred_url":"https://api.github.com/users/aliok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliok/subscriptions","organizations_url":"https://api.github.com/users/aliok/orgs","repos_url":"https://api.github.com/users/aliok/repos","events_url":"https://api.github.com/users/aliok/events{/privacy}","received_events_url":"https://api.github.com/users/aliok/received_events","type":"User","site_admin":false},"repo":{"id":139418707,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk0MTg3MDc=","name":"data-sync-server","full_name":"aliok/data-sync-server","owner":{"login":"aliok","id":376732,"node_id":"MDQ6VXNlcjM3NjczMg==","avatar_url":"https://avatars2.githubusercontent.com/u/376732?v=4","gravatar_id":"","url":"https://api.github.com/users/aliok","html_url":"https://github.com/aliok","followers_url":"https://api.github.com/users/aliok/followers","following_url":"https://api.github.com/users/aliok/following{/other_user}","gists_url":"https://api.github.com/users/aliok/gists{/gist_id}","starred_url":"https://api.github.com/users/aliok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliok/subscriptions","organizations_url":"https://api.github.com/users/aliok/orgs","repos_url":"https://api.github.com/users/aliok/repos","events_url":"https://api.github.com/users/aliok/events{/privacy}","received_events_url":"https://api.github.com/users/aliok/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aliok/data-sync-server","description":"GraphQL based data sync server for mobile, with backend integration capabilities","fork":true,"url":"https://api.github.com/repos/aliok/data-sync-server","forks_url":"https://api.github.com/repos/aliok/data-sync-server/forks","keys_url":"https://api.github.com/repos/aliok/data-sync-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aliok/data-sync-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aliok/data-sync-server/teams","hooks_url":"https://api.github.com/repos/aliok/data-sync-server/hooks","issue_events_url":"https://api.github.com/repos/aliok/data-sync-server/issues/events{/number}","events_url":"https://api.github.com/repos/aliok/data-sync-server/events","assignees_url":"https://api.github.com/repos/aliok/data-sync-server/assignees{/user}","branches_url":"https://api.github.com/repos/aliok/data-sync-server/branches{/branch}","tags_url":"https://api.github.com/repos/aliok/data-sync-server/tags","blobs_url":"https://api.github.com/repos/aliok/data-sync-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aliok/data-sync-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aliok/data-sync-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/aliok/data-sync-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aliok/data-sync-server/statuses/{sha}","languages_url":"https://api.github.com/repos/aliok/data-sync-server/languages","stargazers_url":"https://api.github.com/repos/aliok/data-sync-server/stargazers","contributors_url":"https://api.github.com/repos/aliok/data-sync-server/contributors","subscribers_url":"https://api.github.com/repos/aliok/data-sync-server/subscribers","subscription_url":"https://api.github.com/repos/aliok/data-sync-server/subscription","commits_url":"https://api.github.com/repos/aliok/data-sync-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/aliok/data-sync-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/aliok/data-sync-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/aliok/data-sync-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/aliok/data-sync-server/contents/{+path}","compare_url":"https://api.github.com/repos/aliok/data-sync-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aliok/data-sync-server/merges","archive_url":"https://api.github.com/repos/aliok/data-sync-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aliok/data-sync-server/downloads","issues_url":"https://api.github.com/repos/aliok/data-sync-server/issues{/number}","pulls_url":"https://api.github.com/repos/aliok/data-sync-server/pulls{/number}","milestones_url":"https://api.github.com/repos/aliok/data-sync-server/milestones{/number}","notifications_url":"https://api.github.com/repos/aliok/data-sync-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aliok/data-sync-server/labels{/name}","releases_url":"https://api.github.com/repos/aliok/data-sync-server/releases{/id}","deployments_url":"https://api.github.com/repos/aliok/data-sync-server/deployments","created_at":"2018-07-02T09:08:58Z","updated_at":"2018-07-02T09:09:00Z","pushed_at":"2018-07-02T14:14:30Z","git_url":"git://github.com/aliok/data-sync-server.git","ssh_url":"git@github.com:aliok/data-sync-server.git","clone_url":"https://github.com/aliok/data-sync-server.git","svn_url":"https://github.com/aliok/data-sync-server","homepage":null,"size":593,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aerogear:master","ref":"master","sha":"8326aedab77fd9f1b510d931b42866eccd75e768","user":{"login":"aerogear","id":954205,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1NDIwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/954205?v=4","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"repo":{"id":136392569,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYzOTI1Njk=","name":"data-sync-server","full_name":"aerogear/data-sync-server","owner":{"login":"aerogear","id":954205,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1NDIwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/954205?v=4","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aerogear/data-sync-server","description":"GraphQL based data sync server for mobile, with backend integration capabilities","fork":false,"url":"https://api.github.com/repos/aerogear/data-sync-server","forks_url":"https://api.github.com/repos/aerogear/data-sync-server/forks","keys_url":"https://api.github.com/repos/aerogear/data-sync-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aerogear/data-sync-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aerogear/data-sync-server/teams","hooks_url":"https://api.github.com/repos/aerogear/data-sync-server/hooks","issue_events_url":"https://api.github.com/repos/aerogear/data-sync-server/issues/events{/number}","events_url":"https://api.github.com/repos/aerogear/data-sync-server/events","assignees_url":"https://api.github.com/repos/aerogear/data-sync-server/assignees{/user}","branches_url":"https://api.github.com/repos/aerogear/data-sync-server/branches{/branch}","tags_url":"https://api.github.com/repos/aerogear/data-sync-server/tags","blobs_url":"https://api.github.com/repos/aerogear/data-sync-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aerogear/data-sync-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aerogear/data-sync-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/aerogear/data-sync-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aerogear/data-sync-server/statuses/{sha}","languages_url":"https://api.github.com/repos/aerogear/data-sync-server/languages","stargazers_url":"https://api.github.com/repos/aerogear/data-sync-server/stargazers","contributors_url":"https://api.github.com/repos/aerogear/data-sync-server/contributors","subscribers_url":"https://api.github.com/repos/aerogear/data-sync-server/subscribers","subscription_url":"https://api.github.com/repos/aerogear/data-sync-server/subscription","commits_url":"https://api.github.com/repos/aerogear/data-sync-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/aerogear/data-sync-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/aerogear/data-sync-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/aerogear/data-sync-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/aerogear/data-sync-server/contents/{+path}","compare_url":"https://api.github.com/repos/aerogear/data-sync-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aerogear/data-sync-server/merges","archive_url":"https://api.github.com/repos/aerogear/data-sync-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aerogear/data-sync-server/downloads","issues_url":"https://api.github.com/repos/aerogear/data-sync-server/issues{/number}","pulls_url":"https://api.github.com/repos/aerogear/data-sync-server/pulls{/number}","milestones_url":"https://api.github.com/repos/aerogear/data-sync-server/milestones{/number}","notifications_url":"https://api.github.com/repos/aerogear/data-sync-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aerogear/data-sync-server/labels{/name}","releases_url":"https://api.github.com/repos/aerogear/data-sync-server/releases{/id}","deployments_url":"https://api.github.com/repos/aerogear/data-sync-server/deployments","created_at":"2018-06-06T22:25:37Z","updated_at":"2018-07-02T14:14:27Z","pushed_at":"2018-07-02T16:19:05Z","git_url":"git://github.com/aerogear/data-sync-server.git","ssh_url":"git@github.com:aerogear/data-sync-server.git","clone_url":"https://github.com/aerogear/data-sync-server.git","svn_url":"https://github.com/aerogear/data-sync-server","homepage":null,"size":626,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":5,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aerogear/data-sync-server/pulls/8"},"html":{"href":"https://github.com/aerogear/data-sync-server/pull/8"},"issue":{"href":"https://api.github.com/repos/aerogear/data-sync-server/issues/8"},"comments":{"href":"https://api.github.com/repos/aerogear/data-sync-server/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/aerogear/data-sync-server/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/aerogear/data-sync-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aerogear/data-sync-server/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/aerogear/data-sync-server/statuses/57a9d8659947343b1142289da6d1f3a90b231290"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"aliok"}}