{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/204484991","pull_request_review_id":139570475,"id":204484991,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDQ4NDk5MQ==","diff_hunk":"@@ -73,6 +73,47 @@ TransactionException dev::eth::toTransactionException(Exception const& _e)\n \treturn TransactionException::Unknown;\n }\n \n+string dev::eth::transactionExceptionToErrorMessage(Exception const& _e)\n+{\n+\tif (!!dynamic_cast<ZeroSignatureTransaction const*>(&_e))","path":"libethereum/Transaction.cpp","position":6,"original_position":6,"commit_id":"0342b48bb0715f10f612e89f08a043856cff6414","original_commit_id":"0342b48bb0715f10f612e89f08a043856cff6414","user":{"login":"gumb0","id":1863135,"node_id":"MDQ6VXNlcjE4NjMxMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1863135?v=4","gravatar_id":"","url":"https://api.github.com/users/gumb0","html_url":"https://github.com/gumb0","followers_url":"https://api.github.com/users/gumb0/followers","following_url":"https://api.github.com/users/gumb0/following{/other_user}","gists_url":"https://api.github.com/users/gumb0/gists{/gist_id}","starred_url":"https://api.github.com/users/gumb0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gumb0/subscriptions","organizations_url":"https://api.github.com/users/gumb0/orgs","repos_url":"https://api.github.com/users/gumb0/repos","events_url":"https://api.github.com/users/gumb0/events{/privacy}","received_events_url":"https://api.github.com/users/gumb0/received_events","type":"User","site_admin":false},"body":"Wouldn't `throw _e` and then the series of `catch`es be less ugly than this series of casts?","created_at":"2018-07-23T17:12:48Z","updated_at":"2018-07-23T17:12:48Z","html_url":"https://github.com/ethereum/cpp-ethereum/pull/5117#discussion_r204484991","pull_request_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/5117","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/204484991"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/5117#discussion_r204484991"},"pull_request":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/5117"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/5117","id":201835158,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxODM1MTU4","html_url":"https://github.com/ethereum/cpp-ethereum/pull/5117","diff_url":"https://github.com/ethereum/cpp-ethereum/pull/5117.diff","patch_url":"https://github.com/ethereum/cpp-ethereum/pull/5117.patch","issue_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/5117","number":5117,"state":"open","locked":false,"title":"Update sendRawTransaction RPC code path to perform pre-import tx validation and return informative error messages","user":{"login":"halfalicious","id":15605026,"node_id":"MDQ6VXNlcjE1NjA1MDI2","avatar_url":"https://avatars1.githubusercontent.com/u/15605026?v=4","gravatar_id":"","url":"https://api.github.com/users/halfalicious","html_url":"https://github.com/halfalicious","followers_url":"https://api.github.com/users/halfalicious/followers","following_url":"https://api.github.com/users/halfalicious/following{/other_user}","gists_url":"https://api.github.com/users/halfalicious/gists{/gist_id}","starred_url":"https://api.github.com/users/halfalicious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halfalicious/subscriptions","organizations_url":"https://api.github.com/users/halfalicious/orgs","repos_url":"https://api.github.com/users/halfalicious/repos","events_url":"https://api.github.com/users/halfalicious/events{/privacy}","received_events_url":"https://api.github.com/users/halfalicious/received_events","type":"User","site_admin":false},"body":"Fix #5093 \r\n\r\nI've updated the `sendRawTransaction `RPC code path to perform pre-import tx validation and to return informative error messages, similar to how `sendTransaction `does things. I've also added a jsonrpc unit test which validates a positive case and a variety of the error cases.\r\n\r\nThe changes are straight-forward - I'm able to re-use the tx pre-submission validation and tx queue import code in `Client::submitTransaction` by moving it into a new function called `Client::importTransaction`. This also allows me to remove `Client::injectTransaction`. ","created_at":"2018-07-17T06:21:21Z","updated_at":"2018-07-23T17:12:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"504ee87d2b22008b94b16e7c3df0cb0c8280c9ee","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/5117/commits","review_comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/5117/comments","review_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/5117/comments","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/0342b48bb0715f10f612e89f08a043856cff6414","head":{"label":"halfalicious:5093_SendRawTx","ref":"5093_SendRawTx","sha":"0342b48bb0715f10f612e89f08a043856cff6414","user":{"login":"halfalicious","id":15605026,"node_id":"MDQ6VXNlcjE1NjA1MDI2","avatar_url":"https://avatars1.githubusercontent.com/u/15605026?v=4","gravatar_id":"","url":"https://api.github.com/users/halfalicious","html_url":"https://github.com/halfalicious","followers_url":"https://api.github.com/users/halfalicious/followers","following_url":"https://api.github.com/users/halfalicious/following{/other_user}","gists_url":"https://api.github.com/users/halfalicious/gists{/gist_id}","starred_url":"https://api.github.com/users/halfalicious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halfalicious/subscriptions","organizations_url":"https://api.github.com/users/halfalicious/orgs","repos_url":"https://api.github.com/users/halfalicious/repos","events_url":"https://api.github.com/users/halfalicious/events{/privacy}","received_events_url":"https://api.github.com/users/halfalicious/received_events","type":"User","site_admin":false},"repo":{"id":129848787,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk4NDg3ODc=","name":"cpp-ethereum","full_name":"halfalicious/cpp-ethereum","owner":{"login":"halfalicious","id":15605026,"node_id":"MDQ6VXNlcjE1NjA1MDI2","avatar_url":"https://avatars1.githubusercontent.com/u/15605026?v=4","gravatar_id":"","url":"https://api.github.com/users/halfalicious","html_url":"https://github.com/halfalicious","followers_url":"https://api.github.com/users/halfalicious/followers","following_url":"https://api.github.com/users/halfalicious/following{/other_user}","gists_url":"https://api.github.com/users/halfalicious/gists{/gist_id}","starred_url":"https://api.github.com/users/halfalicious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halfalicious/subscriptions","organizations_url":"https://api.github.com/users/halfalicious/orgs","repos_url":"https://api.github.com/users/halfalicious/repos","events_url":"https://api.github.com/users/halfalicious/events{/privacy}","received_events_url":"https://api.github.com/users/halfalicious/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/halfalicious/cpp-ethereum","description":"Ethereum C++ client","fork":true,"url":"https://api.github.com/repos/halfalicious/cpp-ethereum","forks_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/halfalicious/cpp-ethereum/deployments","created_at":"2018-04-17T05:03:51Z","updated_at":"2018-07-15T19:43:40Z","pushed_at":"2018-07-21T18:21:14Z","git_url":"git://github.com/halfalicious/cpp-ethereum.git","ssh_url":"git@github.com:halfalicious/cpp-ethereum.git","clone_url":"https://github.com/halfalicious/cpp-ethereum.git","svn_url":"https://github.com/halfalicious/cpp-ethereum","homepage":"http://cpp-ethereum.org","size":54633,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"61b200831769eab4bad941d6b9f6ce5d39f62b78","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15460666,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ2MDY2Ng==","name":"cpp-ethereum","full_name":"ethereum/cpp-ethereum","owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/cpp-ethereum","description":"Ethereum C++ client","fork":false,"url":"https://api.github.com/repos/ethereum/cpp-ethereum","forks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/cpp-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/deployments","created_at":"2013-12-26T21:26:06Z","updated_at":"2018-07-23T16:22:24Z","pushed_at":"2018-07-23T16:06:56Z","git_url":"git://github.com/ethereum/cpp-ethereum.git","ssh_url":"git@github.com:ethereum/cpp-ethereum.git","clone_url":"https://github.com/ethereum/cpp-ethereum.git","svn_url":"https://github.com/ethereum/cpp-ethereum","homepage":"http://cpp-ethereum.org","size":54656,"stargazers_count":3267,"watchers_count":3267,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2047,"mirror_url":null,"archived":false,"open_issues_count":314,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":2047,"open_issues":314,"watchers":3267,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/5117"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/5117"},"issue":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/5117"},"comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/5117/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/5117/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/5117/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/0342b48bb0715f10f612e89f08a043856cff6414"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gumb0"}}