{"action":"created","comment":{"url":"https://api.github.com/repos/status-im/status-go/pulls/comments/217308082","pull_request_review_id":154986376,"id":217308082,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzMwODA4Mg==","diff_hunk":"@@ -364,91 +274,142 @@ type NodeConfig struct {\n \tMailServerRegistryAddress string\n }\n \n-// NewNodeConfig creates new node configuration object\n-func NewNodeConfig(dataDir, clstrCfgFile, fleet string, networkID uint64) (*NodeConfig, error) {\n+// NewNodeConfigWithDefaults creates new node configuration object with some defaults suitable for adhoc use\n+func NewNodeConfigWithDefaults(dataDir, fleet string, networkID uint64) (*NodeConfig, error) {\n+\tnodeConfig, err := NewNodeConfig(dataDir, fleet, networkID)\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\n+\tif dataDir != \"\" {\n+\t\tnodeConfig.KeyStoreDir = path.Join(dataDir, \"keystore\")\n+\t\tnodeConfig.WhisperConfig.DataDir = path.Join(dataDir, \"wnode\")\n+\t}\n+\n+\tstatusConfigJSON, err := static.Asset(fmt.Sprintf(\"config/cli/fleet-%s.json\", fleet))\n+\tif err == nil {\n+\t\terr = LoadConfigFromJSON(string(statusConfigJSON), nodeConfig)\n+\t}\n+\tif err != nil {\n+\t\treturn nil, fmt.Errorf(\"Default config could not be loaded: %s\", err)\n+\t}\n+\n+\tnodeConfig.NoDiscovery = true","path":"params/config.go","position":238,"original_position":238,"commit_id":"a910d154601138279f047b842016ea42f5af4c08","original_commit_id":"a910d154601138279f047b842016ea42f5af4c08","user":{"login":"PombeirP","id":138074,"node_id":"MDQ6VXNlcjEzODA3NA==","avatar_url":"https://avatars1.githubusercontent.com/u/138074?v=4","gravatar_id":"","url":"https://api.github.com/users/PombeirP","html_url":"https://github.com/PombeirP","followers_url":"https://api.github.com/users/PombeirP/followers","following_url":"https://api.github.com/users/PombeirP/following{/other_user}","gists_url":"https://api.github.com/users/PombeirP/gists{/gist_id}","starred_url":"https://api.github.com/users/PombeirP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PombeirP/subscriptions","organizations_url":"https://api.github.com/users/PombeirP/orgs","repos_url":"https://api.github.com/users/PombeirP/repos","events_url":"https://api.github.com/users/PombeirP/events{/privacy}","received_events_url":"https://api.github.com/users/PombeirP/received_events","type":"User","site_admin":false},"body":"I tried to keep the existing values currently reported in `origin/develop`","created_at":"2018-09-13T08:53:18Z","updated_at":"2018-09-13T08:53:19Z","html_url":"https://github.com/status-im/status-go/pull/1183#discussion_r217308082","pull_request_url":"https://api.github.com/repos/status-im/status-go/pulls/1183","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/status-im/status-go/pulls/comments/217308082"},"html":{"href":"https://github.com/status-im/status-go/pull/1183#discussion_r217308082"},"pull_request":{"href":"https://api.github.com/repos/status-im/status-go/pulls/1183"}},"in_reply_to_id":217053263},"pull_request":{"url":"https://api.github.com/repos/status-im/status-go/pulls/1183","id":213336269,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMzM2MjY5","html_url":"https://github.com/status-im/status-go/pull/1183","diff_url":"https://github.com/status-im/status-go/pull/1183.diff","patch_url":"https://github.com/status-im/status-go/pull/1183.patch","issue_url":"https://api.github.com/repos/status-im/status-go/issues/1183","number":1183,"state":"open","locked":false,"title":"Refactor status-go configuration","user":{"login":"PombeirP","id":138074,"node_id":"MDQ6VXNlcjEzODA3NA==","avatar_url":"https://avatars1.githubusercontent.com/u/138074?v=4","gravatar_id":"","url":"https://api.github.com/users/PombeirP","html_url":"https://github.com/PombeirP","followers_url":"https://api.github.com/users/PombeirP/followers","following_url":"https://api.github.com/users/PombeirP/following{/other_user}","gists_url":"https://api.github.com/users/PombeirP/gists{/gist_id}","starred_url":"https://api.github.com/users/PombeirP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PombeirP/subscriptions","organizations_url":"https://api.github.com/users/PombeirP/orgs","repos_url":"https://api.github.com/users/PombeirP/repos","events_url":"https://api.github.com/users/PombeirP/events{/privacy}","received_events_url":"https://api.github.com/users/PombeirP/received_events","type":"User","site_admin":false},"body":"Important changes:\r\n- We now validate the configuration on `StatusBackend.startNode()`;\r\n- Node config fields which specified a file were removed. Fields that referenced a private key file were replaced with a hex encoding of the private key;\r\n- Each config struct has a `Validate` method which will check things such as whether we forgot to specify required directories, genesis is missing and cannot be calculated, or if there are conflicting settings specified;\r\n- Improved output of some test suits (e.g. some errors were not being brought to the attention of the dev);\r\n- Removed unused `WhisperConfig.FirebaseConfig` field;\r\n- There are 4 new config files under `static/config/cli`, `fleet-eth.beta.json` is used if the app is started without arguments. If we find it useful, we can expose a command line argument allowing to preload any of those files on demand, e.g. `-load=fleet-eth.staging,les-enabled`; \r\n- ~~Environment variables can be used to override configuration values. Example:~~\r\n    ``` sh\r\n    STATUSD_CLUSTERCONFIG_FLEET=eth.staging build/bin/statusd-c /home/pedro/Downloads/default.json -c /home/pedro/Downloads/cluster.json\r\n    ```\r\n    ~~`ClusterConfig.Fleet` will be set to `eth.staging` even though `default.json` specified `eth.beta`.~~\r\n\r\nNotes to reviewers:\r\n- Ended up not flattening the JSON since most of the problems we had were addressed (`nil` pointers and being able to override settings from command line env vars);\r\n- Let me know if there are additional validations we can put in place in the config that I might have missed;\r\n- Validation is done in the backend (`StartNode`) and in `params.LoadNodeConfig`. I didn't move it deeper in the call stack (e.g. `MakeNode`) since that would preclude tests from passing an empty `DataDir` for in-memory database.\r\n\r\nNew output of `statusd --help`: \r\n``` shell\r\nUsage: statusd [options]\r\nExamples:\r\n  statusd -c ./default.json                      # run node with configuration specified in ./default.json file\r\n  statusd -c ./default.json -c ./standalone.json # run node with configuration specified in ./default.json file, after merging ./standalone.json file\r\n  statusd -c ./default.json -metrics             # run node with configuration specified in ./default.json file, and expose ethereum metrics with debug_metrics jsonrpc call\r\n  statusd -c ./default.json -cli                 # run node with configuration specified in ./default.json file, and enable connection by statusd-cli on default port\r\n  STATUSD_CLUSTERCONFIG_FLEET=eth.staging \\\r\n    statusd -c ./default.json                    # run node with configuration specified in ./default.json file, and override ClusterConfig.Fleet value\r\n\r\nOptions:\r\n  -c value\r\n        JSON configuration file(s). Multiple configuration files can be specified, and will be merged in occurrence order\r\n  -cli\r\n        Enable debugging CLI server\r\n  -cli-port string\r\n        CLI server's listening port (default \"51515\")\r\n  -log-without-color\r\n        Disables log colors\r\n  -metrics\r\n        Expose ethereum metrics with debug_metrics jsonrpc call\r\n  -pprof\r\n        Enable runtime profiling via pprof\r\n  -pprof-port int\r\n        Port for runtime profiling via pprof (default 52525)\r\n  -sync-and-exit int\r\n        Timeout in minutes for blockchain sync and exit, zero means no timeout unless sync is finished (default -1)\r\n  -version\r\n        Print version and dump configuration\r\n```\r\n\r\nCloses #1180 \r\n","created_at":"2018-09-05T15:28:02Z","updated_at":"2018-09-13T08:53:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e16ee92830e31ad8777b71c2bd495b4a7eadaa5","assignee":{"login":"PombeirP","id":138074,"node_id":"MDQ6VXNlcjEzODA3NA==","avatar_url":"https://avatars1.githubusercontent.com/u/138074?v=4","gravatar_id":"","url":"https://api.github.com/users/PombeirP","html_url":"https://github.com/PombeirP","followers_url":"https://api.github.com/users/PombeirP/followers","following_url":"https://api.github.com/users/PombeirP/following{/other_user}","gists_url":"https://api.github.com/users/PombeirP/gists{/gist_id}","starred_url":"https://api.github.com/users/PombeirP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PombeirP/subscriptions","organizations_url":"https://api.github.com/users/PombeirP/orgs","repos_url":"https://api.github.com/users/PombeirP/repos","events_url":"https://api.github.com/users/PombeirP/events{/privacy}","received_events_url":"https://api.github.com/users/PombeirP/received_events","type":"User","site_admin":false},"assignees":[{"login":"PombeirP","id":138074,"node_id":"MDQ6VXNlcjEzODA3NA==","avatar_url":"https://avatars1.githubusercontent.com/u/138074?v=4","gravatar_id":"","url":"https://api.github.com/users/PombeirP","html_url":"https://github.com/PombeirP","followers_url":"https://api.github.com/users/PombeirP/followers","following_url":"https://api.github.com/users/PombeirP/following{/other_user}","gists_url":"https://api.github.com/users/PombeirP/gists{/gist_id}","starred_url":"https://api.github.com/users/PombeirP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PombeirP/subscriptions","organizations_url":"https://api.github.com/users/PombeirP/orgs","repos_url":"https://api.github.com/users/PombeirP/repos","events_url":"https://api.github.com/users/PombeirP/events{/privacy}","received_events_url":"https://api.github.com/users/PombeirP/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mandrigin","id":466427,"node_id":"MDQ6VXNlcjQ2NjQyNw==","avatar_url":"https://avatars0.githubusercontent.com/u/466427?v=4","gravatar_id":"","url":"https://api.github.com/users/mandrigin","html_url":"https://github.com/mandrigin","followers_url":"https://api.github.com/users/mandrigin/followers","following_url":"https://api.github.com/users/mandrigin/following{/other_user}","gists_url":"https://api.github.com/users/mandrigin/gists{/gist_id}","starred_url":"https://api.github.com/users/mandrigin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandrigin/subscriptions","organizations_url":"https://api.github.com/users/mandrigin/orgs","repos_url":"https://api.github.com/users/mandrigin/repos","events_url":"https://api.github.com/users/mandrigin/events{/privacy}","received_events_url":"https://api.github.com/users/mandrigin/received_events","type":"User","site_admin":false},{"login":"divan","id":880202,"node_id":"MDQ6VXNlcjg4MDIwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/880202?v=4","gravatar_id":"","url":"https://api.github.com/users/divan","html_url":"https://github.com/divan","followers_url":"https://api.github.com/users/divan/followers","following_url":"https://api.github.com/users/divan/following{/other_user}","gists_url":"https://api.github.com/users/divan/gists{/gist_id}","starred_url":"https://api.github.com/users/divan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divan/subscriptions","organizations_url":"https://api.github.com/users/divan/orgs","repos_url":"https://api.github.com/users/divan/repos","events_url":"https://api.github.com/users/divan/events{/privacy}","received_events_url":"https://api.github.com/users/divan/received_events","type":"User","site_admin":false},{"login":"dshulyak","id":1964576,"node_id":"MDQ6VXNlcjE5NjQ1NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1964576?v=4","gravatar_id":"","url":"https://api.github.com/users/dshulyak","html_url":"https://github.com/dshulyak","followers_url":"https://api.github.com/users/dshulyak/followers","following_url":"https://api.github.com/users/dshulyak/following{/other_user}","gists_url":"https://api.github.com/users/dshulyak/gists{/gist_id}","starred_url":"https://api.github.com/users/dshulyak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dshulyak/subscriptions","organizations_url":"https://api.github.com/users/dshulyak/orgs","repos_url":"https://api.github.com/users/dshulyak/repos","events_url":"https://api.github.com/users/dshulyak/events{/privacy}","received_events_url":"https://api.github.com/users/dshulyak/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/status-im/status-go/pulls/1183/commits","review_comments_url":"https://api.github.com/repos/status-im/status-go/pulls/1183/comments","review_comment_url":"https://api.github.com/repos/status-im/status-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/status-im/status-go/issues/1183/comments","statuses_url":"https://api.github.com/repos/status-im/status-go/statuses/a910d154601138279f047b842016ea42f5af4c08","head":{"label":"status-im:feature/1180-simple-config","ref":"feature/1180-simple-config","sha":"a910d154601138279f047b842016ea42f5af4c08","user":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":61047867,"node_id":"MDEwOlJlcG9zaXRvcnk2MTA0Nzg2Nw==","name":"status-go","full_name":"status-im/status-go","owner":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/status-im/status-go","description":"The Status module that consumes go-ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-go","forks_url":"https://api.github.com/repos/status-im/status-go/forks","keys_url":"https://api.github.com/repos/status-im/status-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-go/teams","hooks_url":"https://api.github.com/repos/status-im/status-go/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-go/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-go/events","assignees_url":"https://api.github.com/repos/status-im/status-go/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-go/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-go/tags","blobs_url":"https://api.github.com/repos/status-im/status-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-go/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-go/languages","stargazers_url":"https://api.github.com/repos/status-im/status-go/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-go/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-go/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-go/subscription","commits_url":"https://api.github.com/repos/status-im/status-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-go/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-go/merges","archive_url":"https://api.github.com/repos/status-im/status-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-go/downloads","issues_url":"https://api.github.com/repos/status-im/status-go/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-go/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-go/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-go/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-go/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-go/deployments","created_at":"2016-06-13T15:32:03Z","updated_at":"2018-09-13T06:50:43Z","pushed_at":"2018-09-13T07:47:00Z","git_url":"git://github.com/status-im/status-go.git","ssh_url":"git@github.com:status-im/status-go.git","clone_url":"https://github.com/status-im/status-go.git","svn_url":"https://github.com/status-im/status-go","homepage":"https://status.im","size":44217,"stargazers_count":454,"watchers_count":454,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":132,"mirror_url":null,"archived":false,"open_issues_count":71,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":132,"open_issues":71,"watchers":454,"default_branch":"develop"}},"base":{"label":"status-im:develop","ref":"develop","sha":"e8c6841f30748d4ba7b07a459ad81a1a3ef1690a","user":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":61047867,"node_id":"MDEwOlJlcG9zaXRvcnk2MTA0Nzg2Nw==","name":"status-go","full_name":"status-im/status-go","owner":{"login":"status-im","id":11767950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzY3OTUw","avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/status-im/status-go","description":"The Status module that consumes go-ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-go","forks_url":"https://api.github.com/repos/status-im/status-go/forks","keys_url":"https://api.github.com/repos/status-im/status-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-go/teams","hooks_url":"https://api.github.com/repos/status-im/status-go/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-go/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-go/events","assignees_url":"https://api.github.com/repos/status-im/status-go/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-go/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-go/tags","blobs_url":"https://api.github.com/repos/status-im/status-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-go/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-go/languages","stargazers_url":"https://api.github.com/repos/status-im/status-go/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-go/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-go/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-go/subscription","commits_url":"https://api.github.com/repos/status-im/status-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-go/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-go/merges","archive_url":"https://api.github.com/repos/status-im/status-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-go/downloads","issues_url":"https://api.github.com/repos/status-im/status-go/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-go/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-go/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-go/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-go/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-go/deployments","created_at":"2016-06-13T15:32:03Z","updated_at":"2018-09-13T06:50:43Z","pushed_at":"2018-09-13T07:47:00Z","git_url":"git://github.com/status-im/status-go.git","ssh_url":"git@github.com:status-im/status-go.git","clone_url":"https://github.com/status-im/status-go.git","svn_url":"https://github.com/status-im/status-go","homepage":"https://status.im","size":44217,"stargazers_count":454,"watchers_count":454,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":132,"mirror_url":null,"archived":false,"open_issues_count":71,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":132,"open_issues":71,"watchers":454,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/status-im/status-go/pulls/1183"},"html":{"href":"https://github.com/status-im/status-go/pull/1183"},"issue":{"href":"https://api.github.com/repos/status-im/status-go/issues/1183"},"comments":{"href":"https://api.github.com/repos/status-im/status-go/issues/1183/comments"},"review_comments":{"href":"https://api.github.com/repos/status-im/status-go/pulls/1183/comments"},"review_comment":{"href":"https://api.github.com/repos/status-im/status-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/status-im/status-go/pulls/1183/commits"},"statuses":{"href":"https://api.github.com/repos/status-im/status-go/statuses/a910d154601138279f047b842016ea42f5af4c08"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"PombeirP"}}