{"action":"created","comment":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments/223525872","pull_request_review_id":162674614,"id":223525872,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzUyNTg3Mg==","diff_hunk":"@@ -11,8 +11,18 @@ export class FacepileButton extends BaseComponent<IButtonProps, {}> {\n   protected _skipComponentRefResolution = true;\n \n   public render(): JSX.Element {\n-    const { theme, styles, className } = this.props;\n+    const { theme, className, styles } = this.props;\n \n-    return <BaseButton {...this.props} variantClassName={className} styles={getStyles(theme!, styles)} onRenderDescription={nullRender} />;\n+    const customStyles = getStyles(theme!, className, styles);\n+\n+    return (\n+      <BaseButton\n+        {...this.props}\n+        variantClassName=\"ms-Button--facepile\"\n+        className=\"\"","path":"packages/office-ui-fabric-react/src/components/Facepile/FacepileButton.tsx","position":14,"original_position":14,"commit_id":"2bf2f3fd8a3afab5708e79aca77aeedda1674f73","original_commit_id":"2bf2f3fd8a3afab5708e79aca77aeedda1674f73","user":{"login":"Vitalius1","id":29514833,"node_id":"MDQ6VXNlcjI5NTE0ODMz","avatar_url":"https://avatars2.githubusercontent.com/u/29514833?v=4","gravatar_id":"","url":"https://api.github.com/users/Vitalius1","html_url":"https://github.com/Vitalius1","followers_url":"https://api.github.com/users/Vitalius1/followers","following_url":"https://api.github.com/users/Vitalius1/following{/other_user}","gists_url":"https://api.github.com/users/Vitalius1/gists{/gist_id}","starred_url":"https://api.github.com/users/Vitalius1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vitalius1/subscriptions","organizations_url":"https://api.github.com/users/Vitalius1/orgs","repos_url":"https://api.github.com/users/Vitalius1/repos","events_url":"https://api.github.com/users/Vitalius1/events{/privacy}","received_events_url":"https://api.github.com/users/Vitalius1/received_events","type":"User","site_admin":false},"body":"Why do we need `className=\"\"`?","created_at":"2018-10-08T23:40:20Z","updated_at":"2018-10-08T23:40:29Z","html_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/6572#discussion_r223525872","pull_request_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/6572","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments/223525872"},"html":{"href":"https://github.com/OfficeDev/office-ui-fabric-react/pull/6572#discussion_r223525872"},"pull_request":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/6572"}}},"pull_request":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/6572","id":220525082,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNTI1MDgy","html_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/6572","diff_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/6572.diff","patch_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/6572.patch","issue_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/6572","number":6572,"state":"open","locked":false,"title":"Facepilebutton styles","user":{"login":"kkjeer","id":6687333,"node_id":"MDQ6VXNlcjY2ODczMzM=","avatar_url":"https://avatars1.githubusercontent.com/u/6687333?v=4","gravatar_id":"","url":"https://api.github.com/users/kkjeer","html_url":"https://github.com/kkjeer","followers_url":"https://api.github.com/users/kkjeer/followers","following_url":"https://api.github.com/users/kkjeer/following{/other_user}","gists_url":"https://api.github.com/users/kkjeer/gists{/gist_id}","starred_url":"https://api.github.com/users/kkjeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkjeer/subscriptions","organizations_url":"https://api.github.com/users/kkjeer/orgs","repos_url":"https://api.github.com/users/kkjeer/repos","events_url":"https://api.github.com/users/kkjeer/events{/privacy}","received_events_url":"https://api.github.com/users/kkjeer/received_events","type":"User","site_admin":false},"body":"#### Pull request checklist\r\n\r\n- [ ] Addresses an existing issue: Fixes #0000\r\n- [x] Include a change request file using `$ npm run change`\r\n\r\n#### Description of changes\r\n\r\nFixes the precedence for FacepileButton styling so that FacepileButtons can be styled by both a `styles` and a `className` prop. Styles are applied to FacepileButton in the following order:\r\n\r\n1. Base button styles\r\n2. className prop (styles applied from the FacepileComponent, can be customized using the Facepile styles prop, e.g. <Facepile styles={ { descriptiveOverflowButton: {...} } } />\r\n3. styles prop (styles applied from the FacepileComponent button props, e.g. <Facepile overflowButtonProps={ { styles: { root: {...}, rootHovered: {...}, ... } } } />\r\n\r\nThe `styles` prop overrides any `className` prop styles, which overrides the base button styles.\r\n\r\nAlso added a Screener test that includes custom button styles:\r\n<img width=\"220\" alt=\"screen shot 2018-10-04 at 2 36 37 pm\" src=\"https://user-images.githubusercontent.com/6687333/46504564-1b0adb00-c7e3-11e8-93cf-9fa790911bba.png\">\r\n\r\n\r\n#### Focus areas to test\r\n\r\n(optional)\r\n\r\n###### Microsoft Reviewers: [Open in CodeFlow](http://wpcp.azurewebsites.net/CodeFlowProtocolProxy2.php?pullrequest=https://github.com/OfficeDev/office-ui-fabric-react/pull/6572)\r\n\r\n","created_at":"2018-10-04T21:36:14Z","updated_at":"2018-10-08T23:40:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa280383594d34b89155e42900f535d11e916593","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/6572/commits","review_comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/6572/comments","review_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/6572/comments","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/2bf2f3fd8a3afab5708e79aca77aeedda1674f73","head":{"label":"kkjeer:facepilebutton-styles","ref":"facepilebutton-styles","sha":"2bf2f3fd8a3afab5708e79aca77aeedda1674f73","user":{"login":"kkjeer","id":6687333,"node_id":"MDQ6VXNlcjY2ODczMzM=","avatar_url":"https://avatars1.githubusercontent.com/u/6687333?v=4","gravatar_id":"","url":"https://api.github.com/users/kkjeer","html_url":"https://github.com/kkjeer","followers_url":"https://api.github.com/users/kkjeer/followers","following_url":"https://api.github.com/users/kkjeer/following{/other_user}","gists_url":"https://api.github.com/users/kkjeer/gists{/gist_id}","starred_url":"https://api.github.com/users/kkjeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkjeer/subscriptions","organizations_url":"https://api.github.com/users/kkjeer/orgs","repos_url":"https://api.github.com/users/kkjeer/repos","events_url":"https://api.github.com/users/kkjeer/events{/privacy}","received_events_url":"https://api.github.com/users/kkjeer/received_events","type":"User","site_admin":false},"repo":{"id":131622669,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE2MjI2Njk=","name":"office-ui-fabric-react","full_name":"kkjeer/office-ui-fabric-react","private":false,"owner":{"login":"kkjeer","id":6687333,"node_id":"MDQ6VXNlcjY2ODczMzM=","avatar_url":"https://avatars1.githubusercontent.com/u/6687333?v=4","gravatar_id":"","url":"https://api.github.com/users/kkjeer","html_url":"https://github.com/kkjeer","followers_url":"https://api.github.com/users/kkjeer/followers","following_url":"https://api.github.com/users/kkjeer/following{/other_user}","gists_url":"https://api.github.com/users/kkjeer/gists{/gist_id}","starred_url":"https://api.github.com/users/kkjeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkjeer/subscriptions","organizations_url":"https://api.github.com/users/kkjeer/orgs","repos_url":"https://api.github.com/users/kkjeer/repos","events_url":"https://api.github.com/users/kkjeer/events{/privacy}","received_events_url":"https://api.github.com/users/kkjeer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kkjeer/office-ui-fabric-react","description":"React components for building experiences for Office and Office 365.","fork":true,"url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react","forks_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/forks","keys_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/teams","hooks_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/hooks","issue_events_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/issues/events{/number}","events_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/events","assignees_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/assignees{/user}","branches_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/branches{/branch}","tags_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/tags","blobs_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/statuses/{sha}","languages_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/languages","stargazers_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/stargazers","contributors_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/contributors","subscribers_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/subscribers","subscription_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/subscription","commits_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/contents/{+path}","compare_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/merges","archive_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/downloads","issues_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/issues{/number}","pulls_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/pulls{/number}","milestones_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/milestones{/number}","notifications_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/labels{/name}","releases_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/releases{/id}","deployments_url":"https://api.github.com/repos/kkjeer/office-ui-fabric-react/deployments","created_at":"2018-04-30T17:00:00Z","updated_at":"2018-09-26T18:58:48Z","pushed_at":"2018-10-08T17:29:59Z","git_url":"git://github.com/kkjeer/office-ui-fabric-react.git","ssh_url":"git@github.com:kkjeer/office-ui-fabric-react.git","clone_url":"https://github.com/kkjeer/office-ui-fabric-react.git","svn_url":"https://github.com/kkjeer/office-ui-fabric-react","homepage":"https://developer.microsoft.com/en-us/fabric#/components","size":46452,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OfficeDev:master","ref":"master","sha":"3a53db9da65bbf980373336ef48dfda1ddae9db5","user":{"login":"OfficeDev","id":6789362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3ODkzNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"repo":{"id":60537144,"node_id":"MDEwOlJlcG9zaXRvcnk2MDUzNzE0NA==","name":"office-ui-fabric-react","full_name":"OfficeDev/office-ui-fabric-react","private":false,"owner":{"login":"OfficeDev","id":6789362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3ODkzNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OfficeDev/office-ui-fabric-react","description":"React components for building experiences for Office and Office 365.","fork":false,"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react","forks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/forks","keys_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/teams","hooks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/hooks","issue_events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/events{/number}","events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/events","assignees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/assignees{/user}","branches_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/branches{/branch}","tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/tags","blobs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/{sha}","languages_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/languages","stargazers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/stargazers","contributors_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contributors","subscribers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscribers","subscription_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscription","commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contents/{+path}","compare_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/merges","archive_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/downloads","issues_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues{/number}","pulls_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls{/number}","milestones_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/milestones{/number}","notifications_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/labels{/name}","releases_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/releases{/id}","deployments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/deployments","created_at":"2016-06-06T15:03:44Z","updated_at":"2018-10-08T22:47:47Z","pushed_at":"2018-10-08T23:33:55Z","git_url":"git://github.com/OfficeDev/office-ui-fabric-react.git","ssh_url":"git@github.com:OfficeDev/office-ui-fabric-react.git","clone_url":"https://github.com/OfficeDev/office-ui-fabric-react.git","svn_url":"https://github.com/OfficeDev/office-ui-fabric-react","homepage":"https://developer.microsoft.com/en-us/fabric#/components","size":43544,"stargazers_count":3359,"watchers_count":3359,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":761,"mirror_url":null,"archived":false,"open_issues_count":359,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":761,"open_issues":359,"watchers":3359,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/6572"},"html":{"href":"https://github.com/OfficeDev/office-ui-fabric-react/pull/6572"},"issue":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/6572"},"comments":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/6572/comments"},"review_comments":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/6572/comments"},"review_comment":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/6572/commits"},"statuses":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/2bf2f3fd8a3afab5708e79aca77aeedda1674f73"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Vitalius1"}}