{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments/183608776","pull_request_review_id":114636762,"id":183608776,"diff_hunk":"@@ -5661,17 +5670,20 @@ int mbedtls_ssl_setup( mbedtls_ssl_context *ssl,\n                        const mbedtls_ssl_config *conf )\n {\n     int ret;\n-    const size_t len = MBEDTLS_SSL_BUFFER_LEN;\n+    const size_t in_len = MBEDTLS_SSL_IN_BUFFER_LEN;\n+    const size_t out_len = MBEDTLS_SSL_OUT_BUFFER_LEN;\n \n     ssl->conf = conf;\n+    ssl->in_buf = NULL;\n+    ssl->out_buf = NULL;\n \n     /*\n      * Prepare base structures\n      */\n-    if( ( ssl-> in_buf = mbedtls_calloc( 1, len ) ) == NULL ||\n-        ( ssl->out_buf = mbedtls_calloc( 1, len ) ) == NULL )\n+    if( ( ssl->in_buf = mbedtls_calloc( 1, in_len ) ) == NULL ||","path":"library/ssl_tls.c","position":248,"original_position":248,"commit_id":"f7ab622e680fb98fb602574315afcf9001248e1b","original_commit_id":"f7ab622e680fb98fb602574315afcf9001248e1b","user":{"login":"projectgus","id":205573,"avatar_url":"https://avatars1.githubusercontent.com/u/205573?v=4","gravatar_id":"","url":"https://api.github.com/users/projectgus","html_url":"https://github.com/projectgus","followers_url":"https://api.github.com/users/projectgus/followers","following_url":"https://api.github.com/users/projectgus/following{/other_user}","gists_url":"https://api.github.com/users/projectgus/gists{/gist_id}","starred_url":"https://api.github.com/users/projectgus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectgus/subscriptions","organizations_url":"https://api.github.com/users/projectgus/orgs","repos_url":"https://api.github.com/users/projectgus/repos","events_url":"https://api.github.com/users/projectgus/events{/privacy}","received_events_url":"https://api.github.com/users/projectgus/received_events","type":"User","site_admin":false},"body":"(I've removed this construct as part of revisions in #536 )","created_at":"2018-04-24T05:29:44Z","updated_at":"2018-04-24T05:29:44Z","html_url":"https://github.com/ARMmbed/mbedtls/pull/1566#discussion_r183608776","pull_request_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1566","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments/183608776"},"html":{"href":"https://github.com/ARMmbed/mbedtls/pull/1566#discussion_r183608776"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1566"}},"in_reply_to_id":183442982},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1566","id":180917862,"html_url":"https://github.com/ARMmbed/mbedtls/pull/1566","diff_url":"https://github.com/ARMmbed/mbedtls/pull/1566.diff","patch_url":"https://github.com/ARMmbed/mbedtls/pull/1566.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1566","number":1566,"state":"open","locked":false,"title":"Asymmetric SSL buffers (RAM optimization)","user":{"login":"itayzafrir","id":30868205,"avatar_url":"https://avatars2.githubusercontent.com/u/30868205?v=4","gravatar_id":"","url":"https://api.github.com/users/itayzafrir","html_url":"https://github.com/itayzafrir","followers_url":"https://api.github.com/users/itayzafrir/followers","following_url":"https://api.github.com/users/itayzafrir/following{/other_user}","gists_url":"https://api.github.com/users/itayzafrir/gists{/gist_id}","starred_url":"https://api.github.com/users/itayzafrir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itayzafrir/subscriptions","organizations_url":"https://api.github.com/users/itayzafrir/orgs","repos_url":"https://api.github.com/users/itayzafrir/repos","events_url":"https://api.github.com/users/itayzafrir/events{/privacy}","received_events_url":"https://api.github.com/users/itayzafrir/received_events","type":"User","site_admin":false},"body":"## Description\r\nBased on #536 \r\n\r\nOptional configurations to differentiate between SSL in/out buffer lengths.\r\n\r\n## Status\r\n**READY**\r\n\r\n## Requires Backporting\r\n\r\nNO  \r\n\r\n## Todos\r\n- [X] Tests\r\n- [X] Documentation\r\n- [X] Changelog updated\r\n- [ ] Backported\r\n","created_at":"2018-04-11T14:12:51Z","updated_at":"2018-04-24T05:29:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3482162f16da4f00ff0391216d03301a028b9efa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":820027428,"url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/Arm%20Contribution","name":"Arm Contribution","color":"66e0ff","default":false},{"id":19280386,"url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":435765575,"url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/needs%20work","name":"needs work","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1566/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1566/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1566/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbedtls/statuses/f7ab622e680fb98fb602574315afcf9001248e1b","head":{"label":"itayzafrir:asymetric_ssl_buffers","ref":"asymetric_ssl_buffers","sha":"f7ab622e680fb98fb602574315afcf9001248e1b","user":{"login":"itayzafrir","id":30868205,"avatar_url":"https://avatars2.githubusercontent.com/u/30868205?v=4","gravatar_id":"","url":"https://api.github.com/users/itayzafrir","html_url":"https://github.com/itayzafrir","followers_url":"https://api.github.com/users/itayzafrir/followers","following_url":"https://api.github.com/users/itayzafrir/following{/other_user}","gists_url":"https://api.github.com/users/itayzafrir/gists{/gist_id}","starred_url":"https://api.github.com/users/itayzafrir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itayzafrir/subscriptions","organizations_url":"https://api.github.com/users/itayzafrir/orgs","repos_url":"https://api.github.com/users/itayzafrir/repos","events_url":"https://api.github.com/users/itayzafrir/events{/privacy}","received_events_url":"https://api.github.com/users/itayzafrir/received_events","type":"User","site_admin":false},"repo":{"id":122451245,"name":"mbedtls","full_name":"itayzafrir/mbedtls","owner":{"login":"itayzafrir","id":30868205,"avatar_url":"https://avatars2.githubusercontent.com/u/30868205?v=4","gravatar_id":"","url":"https://api.github.com/users/itayzafrir","html_url":"https://github.com/itayzafrir","followers_url":"https://api.github.com/users/itayzafrir/followers","following_url":"https://api.github.com/users/itayzafrir/following{/other_user}","gists_url":"https://api.github.com/users/itayzafrir/gists{/gist_id}","starred_url":"https://api.github.com/users/itayzafrir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itayzafrir/subscriptions","organizations_url":"https://api.github.com/users/itayzafrir/orgs","repos_url":"https://api.github.com/users/itayzafrir/repos","events_url":"https://api.github.com/users/itayzafrir/events{/privacy}","received_events_url":"https://api.github.com/users/itayzafrir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/itayzafrir/mbedtls","description":"An open source, portable, easy to use, readable and flexible SSL library","fork":true,"url":"https://api.github.com/repos/itayzafrir/mbedtls","forks_url":"https://api.github.com/repos/itayzafrir/mbedtls/forks","keys_url":"https://api.github.com/repos/itayzafrir/mbedtls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/itayzafrir/mbedtls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/itayzafrir/mbedtls/teams","hooks_url":"https://api.github.com/repos/itayzafrir/mbedtls/hooks","issue_events_url":"https://api.github.com/repos/itayzafrir/mbedtls/issues/events{/number}","events_url":"https://api.github.com/repos/itayzafrir/mbedtls/events","assignees_url":"https://api.github.com/repos/itayzafrir/mbedtls/assignees{/user}","branches_url":"https://api.github.com/repos/itayzafrir/mbedtls/branches{/branch}","tags_url":"https://api.github.com/repos/itayzafrir/mbedtls/tags","blobs_url":"https://api.github.com/repos/itayzafrir/mbedtls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/itayzafrir/mbedtls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/itayzafrir/mbedtls/git/refs{/sha}","trees_url":"https://api.github.com/repos/itayzafrir/mbedtls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/itayzafrir/mbedtls/statuses/{sha}","languages_url":"https://api.github.com/repos/itayzafrir/mbedtls/languages","stargazers_url":"https://api.github.com/repos/itayzafrir/mbedtls/stargazers","contributors_url":"https://api.github.com/repos/itayzafrir/mbedtls/contributors","subscribers_url":"https://api.github.com/repos/itayzafrir/mbedtls/subscribers","subscription_url":"https://api.github.com/repos/itayzafrir/mbedtls/subscription","commits_url":"https://api.github.com/repos/itayzafrir/mbedtls/commits{/sha}","git_commits_url":"https://api.github.com/repos/itayzafrir/mbedtls/git/commits{/sha}","comments_url":"https://api.github.com/repos/itayzafrir/mbedtls/comments{/number}","issue_comment_url":"https://api.github.com/repos/itayzafrir/mbedtls/issues/comments{/number}","contents_url":"https://api.github.com/repos/itayzafrir/mbedtls/contents/{+path}","compare_url":"https://api.github.com/repos/itayzafrir/mbedtls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/itayzafrir/mbedtls/merges","archive_url":"https://api.github.com/repos/itayzafrir/mbedtls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/itayzafrir/mbedtls/downloads","issues_url":"https://api.github.com/repos/itayzafrir/mbedtls/issues{/number}","pulls_url":"https://api.github.com/repos/itayzafrir/mbedtls/pulls{/number}","milestones_url":"https://api.github.com/repos/itayzafrir/mbedtls/milestones{/number}","notifications_url":"https://api.github.com/repos/itayzafrir/mbedtls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/itayzafrir/mbedtls/labels{/name}","releases_url":"https://api.github.com/repos/itayzafrir/mbedtls/releases{/id}","deployments_url":"https://api.github.com/repos/itayzafrir/mbedtls/deployments","created_at":"2018-02-22T08:34:07Z","updated_at":"2018-04-11T07:11:36Z","pushed_at":"2018-04-12T09:47:06Z","git_url":"git://github.com/itayzafrir/mbedtls.git","ssh_url":"git@github.com:itayzafrir/mbedtls.git","clone_url":"https://github.com/itayzafrir/mbedtls.git","svn_url":"https://github.com/itayzafrir/mbedtls","homepage":"https://tls.mbed.org","size":25643,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"ARMmbed:development","ref":"development","sha":"80aa3b8d6509be24cb67454e7a0519da20951faf","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":6687936,"name":"mbedtls","full_name":"ARMmbed/mbedtls","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbedtls","description":"An open source, portable, easy to use, readable and flexible SSL library","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbedtls","forks_url":"https://api.github.com/repos/ARMmbed/mbedtls/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbedtls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbedtls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbedtls/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbedtls/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbedtls/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbedtls/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbedtls/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbedtls/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbedtls/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbedtls/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbedtls/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbedtls/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbedtls/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbedtls/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbedtls/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbedtls/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbedtls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbedtls/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbedtls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbedtls/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbedtls/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbedtls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbedtls/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbedtls/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbedtls/deployments","created_at":"2012-11-14T13:13:13Z","updated_at":"2018-04-23T16:15:06Z","pushed_at":"2018-04-24T05:25:46Z","git_url":"git://github.com/ARMmbed/mbedtls.git","ssh_url":"git@github.com:ARMmbed/mbedtls.git","clone_url":"https://github.com/ARMmbed/mbedtls.git","svn_url":"https://github.com/ARMmbed/mbedtls","homepage":"https://tls.mbed.org","size":26554,"stargazers_count":1353,"watchers_count":1353,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":834,"mirror_url":null,"archived":false,"open_issues_count":420,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":834,"open_issues":420,"watchers":1353,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1566"},"html":{"href":"https://github.com/ARMmbed/mbedtls/pull/1566"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1566"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1566/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1566/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1566/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/statuses/f7ab622e680fb98fb602574315afcf9001248e1b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"projectgus"}}