{"action":"created","comment":{"url":"https://api.github.com/repos/apache/trafficserver/pulls/comments/212496989","pull_request_review_id":149145593,"id":212496989,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjQ5Njk4OQ==","diff_hunk":"@@ -352,6 +351,8 @@ TEST_CASE(\"Store STREAM Frame\", \"[quic]\")\n     CHECK(memcmp(stream_frame2->data(), \"\\x11\\x22\\x33\\x44\\x55\", stream_frame2->data_length()) == 0);\n     CHECK(stream_frame2->offset() == 0x100000000 + 5);\n     CHECK(stream_frame2->stream_id() == 0x01);\n+\n+    QUICFrameDeleter::delete_stream_frame(stream_frame2);","path":"iocore/net/quic/test/test_QUICFrame.cc","position":13,"original_position":13,"commit_id":"172aa759fc2b63a0226ee864af66c4feeb49c462","original_commit_id":"24c31cfab4d29d02c3cb9018a3221b2092871051","user":{"login":"maskit","id":153144,"node_id":"MDQ6VXNlcjE1MzE0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/153144?v=4","gravatar_id":"","url":"https://api.github.com/users/maskit","html_url":"https://github.com/maskit","followers_url":"https://api.github.com/users/maskit/followers","following_url":"https://api.github.com/users/maskit/following{/other_user}","gists_url":"https://api.github.com/users/maskit/gists{/gist_id}","starred_url":"https://api.github.com/users/maskit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maskit/subscriptions","organizations_url":"https://api.github.com/users/maskit/orgs","repos_url":"https://api.github.com/users/maskit/repos","events_url":"https://api.github.com/users/maskit/events{/privacy}","received_events_url":"https://api.github.com/users/maskit/received_events","type":"User","site_admin":false},"body":"Perhaps it has to be deleted, but it wouldn't detected because the memory is allocated with an internal allocator.","created_at":"2018-08-24T00:55:33Z","updated_at":"2018-08-24T00:55:33Z","html_url":"https://github.com/apache/trafficserver/pull/4154#discussion_r212496989","pull_request_url":"https://api.github.com/repos/apache/trafficserver/pulls/4154","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/comments/212496989"},"html":{"href":"https://github.com/apache/trafficserver/pull/4154#discussion_r212496989"},"pull_request":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/4154"}},"in_reply_to_id":212207054},"pull_request":{"url":"https://api.github.com/repos/apache/trafficserver/pulls/4154","id":210352820,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMzUyODIw","html_url":"https://github.com/apache/trafficserver/pull/4154","diff_url":"https://github.com/apache/trafficserver/pull/4154.diff","patch_url":"https://github.com/apache/trafficserver/pull/4154.patch","issue_url":"https://api.github.com/repos/apache/trafficserver/issues/4154","number":4154,"state":"open","locked":false,"title":"QUIC: fix memleaking in test_QUICFrame","user":{"login":"scw00","id":12470347,"node_id":"MDQ6VXNlcjEyNDcwMzQ3","avatar_url":"https://avatars2.githubusercontent.com/u/12470347?v=4","gravatar_id":"","url":"https://api.github.com/users/scw00","html_url":"https://github.com/scw00","followers_url":"https://api.github.com/users/scw00/followers","following_url":"https://api.github.com/users/scw00/following{/other_user}","gists_url":"https://api.github.com/users/scw00/gists{/gist_id}","starred_url":"https://api.github.com/users/scw00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scw00/subscriptions","organizations_url":"https://api.github.com/users/scw00/orgs","repos_url":"https://api.github.com/users/scw00/repos","events_url":"https://api.github.com/users/scw00/events{/privacy}","received_events_url":"https://api.github.com/users/scw00/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-23T07:19:55Z","updated_at":"2018-08-24T00:55:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffce513de7c44ee64d43b65bee1a923bb4c6fc30","assignee":{"login":"scw00","id":12470347,"node_id":"MDQ6VXNlcjEyNDcwMzQ3","avatar_url":"https://avatars2.githubusercontent.com/u/12470347?v=4","gravatar_id":"","url":"https://api.github.com/users/scw00","html_url":"https://github.com/scw00","followers_url":"https://api.github.com/users/scw00/followers","following_url":"https://api.github.com/users/scw00/following{/other_user}","gists_url":"https://api.github.com/users/scw00/gists{/gist_id}","starred_url":"https://api.github.com/users/scw00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scw00/subscriptions","organizations_url":"https://api.github.com/users/scw00/orgs","repos_url":"https://api.github.com/users/scw00/repos","events_url":"https://api.github.com/users/scw00/events{/privacy}","received_events_url":"https://api.github.com/users/scw00/received_events","type":"User","site_admin":false},"assignees":[{"login":"scw00","id":12470347,"node_id":"MDQ6VXNlcjEyNDcwMzQ3","avatar_url":"https://avatars2.githubusercontent.com/u/12470347?v=4","gravatar_id":"","url":"https://api.github.com/users/scw00","html_url":"https://github.com/scw00","followers_url":"https://api.github.com/users/scw00/followers","following_url":"https://api.github.com/users/scw00/following{/other_user}","gists_url":"https://api.github.com/users/scw00/gists{/gist_id}","starred_url":"https://api.github.com/users/scw00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scw00/subscriptions","organizations_url":"https://api.github.com/users/scw00/orgs","repos_url":"https://api.github.com/users/scw00/repos","events_url":"https://api.github.com/users/scw00/events{/privacy}","received_events_url":"https://api.github.com/users/scw00/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":616547375,"node_id":"MDU6TGFiZWw2MTY1NDczNzU=","url":"https://api.github.com/repos/apache/trafficserver/labels/QUIC","name":"QUIC","color":"0052cc","default":false}],"milestone":{"url":"https://api.github.com/repos/apache/trafficserver/milestones/17","html_url":"https://github.com/apache/trafficserver/milestone/17","labels_url":"https://api.github.com/repos/apache/trafficserver/milestones/17/labels","id":3173087,"node_id":"MDk6TWlsZXN0b25lMzE3MzA4Nw==","number":17,"title":"QUIC","description":"","creator":{"login":"zwoop","id":202131,"node_id":"MDQ6VXNlcjIwMjEzMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/202131?v=4","gravatar_id":"","url":"https://api.github.com/users/zwoop","html_url":"https://github.com/zwoop","followers_url":"https://api.github.com/users/zwoop/followers","following_url":"https://api.github.com/users/zwoop/following{/other_user}","gists_url":"https://api.github.com/users/zwoop/gists{/gist_id}","starred_url":"https://api.github.com/users/zwoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zwoop/subscriptions","organizations_url":"https://api.github.com/users/zwoop/orgs","repos_url":"https://api.github.com/users/zwoop/repos","events_url":"https://api.github.com/users/zwoop/events{/privacy}","received_events_url":"https://api.github.com/users/zwoop/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":75,"state":"open","created_at":"2018-03-09T01:29:14Z","updated_at":"2018-08-23T07:19:55Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/apache/trafficserver/pulls/4154/commits","review_comments_url":"https://api.github.com/repos/apache/trafficserver/pulls/4154/comments","review_comment_url":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/trafficserver/issues/4154/comments","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/172aa759fc2b63a0226ee864af66c4feeb49c462","head":{"label":"scw00:quic-latest","ref":"quic-latest","sha":"172aa759fc2b63a0226ee864af66c4feeb49c462","user":{"login":"scw00","id":12470347,"node_id":"MDQ6VXNlcjEyNDcwMzQ3","avatar_url":"https://avatars2.githubusercontent.com/u/12470347?v=4","gravatar_id":"","url":"https://api.github.com/users/scw00","html_url":"https://github.com/scw00","followers_url":"https://api.github.com/users/scw00/followers","following_url":"https://api.github.com/users/scw00/following{/other_user}","gists_url":"https://api.github.com/users/scw00/gists{/gist_id}","starred_url":"https://api.github.com/users/scw00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scw00/subscriptions","organizations_url":"https://api.github.com/users/scw00/orgs","repos_url":"https://api.github.com/users/scw00/repos","events_url":"https://api.github.com/users/scw00/events{/privacy}","received_events_url":"https://api.github.com/users/scw00/received_events","type":"User","site_admin":false},"repo":{"id":102797634,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI3OTc2MzQ=","name":"trafficserver","full_name":"scw00/trafficserver","owner":{"login":"scw00","id":12470347,"node_id":"MDQ6VXNlcjEyNDcwMzQ3","avatar_url":"https://avatars2.githubusercontent.com/u/12470347?v=4","gravatar_id":"","url":"https://api.github.com/users/scw00","html_url":"https://github.com/scw00","followers_url":"https://api.github.com/users/scw00/followers","following_url":"https://api.github.com/users/scw00/following{/other_user}","gists_url":"https://api.github.com/users/scw00/gists{/gist_id}","starred_url":"https://api.github.com/users/scw00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scw00/subscriptions","organizations_url":"https://api.github.com/users/scw00/orgs","repos_url":"https://api.github.com/users/scw00/repos","events_url":"https://api.github.com/users/scw00/events{/privacy}","received_events_url":"https://api.github.com/users/scw00/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scw00/trafficserver","description":"Mirror of Apache Traffic Server","fork":true,"url":"https://api.github.com/repos/scw00/trafficserver","forks_url":"https://api.github.com/repos/scw00/trafficserver/forks","keys_url":"https://api.github.com/repos/scw00/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scw00/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scw00/trafficserver/teams","hooks_url":"https://api.github.com/repos/scw00/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/scw00/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/scw00/trafficserver/events","assignees_url":"https://api.github.com/repos/scw00/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/scw00/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/scw00/trafficserver/tags","blobs_url":"https://api.github.com/repos/scw00/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scw00/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scw00/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/scw00/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scw00/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/scw00/trafficserver/languages","stargazers_url":"https://api.github.com/repos/scw00/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/scw00/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/scw00/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/scw00/trafficserver/subscription","commits_url":"https://api.github.com/repos/scw00/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/scw00/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/scw00/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/scw00/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/scw00/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/scw00/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scw00/trafficserver/merges","archive_url":"https://api.github.com/repos/scw00/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scw00/trafficserver/downloads","issues_url":"https://api.github.com/repos/scw00/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/scw00/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/scw00/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/scw00/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scw00/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/scw00/trafficserver/releases{/id}","deployments_url":"https://api.github.com/repos/scw00/trafficserver/deployments","created_at":"2017-09-08T00:06:56Z","updated_at":"2017-09-08T00:07:05Z","pushed_at":"2018-08-23T08:23:43Z","git_url":"git://github.com/scw00/trafficserver.git","ssh_url":"git@github.com:scw00/trafficserver.git","clone_url":"https://github.com/scw00/trafficserver.git","svn_url":"https://github.com/scw00/trafficserver","homepage":null,"size":86391,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:quic-latest","ref":"quic-latest","sha":"0a2fd364d8e3826fa5530760a8eaf03e1008e478","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":356066,"node_id":"MDEwOlJlcG9zaXRvcnkzNTYwNjY=","name":"trafficserver","full_name":"apache/trafficserver","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/trafficserver","description":"Mirror of Apache Traffic Server","fork":false,"url":"https://api.github.com/repos/apache/trafficserver","forks_url":"https://api.github.com/repos/apache/trafficserver/forks","keys_url":"https://api.github.com/repos/apache/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/trafficserver/teams","hooks_url":"https://api.github.com/repos/apache/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/apache/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/apache/trafficserver/events","assignees_url":"https://api.github.com/repos/apache/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/apache/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/apache/trafficserver/tags","blobs_url":"https://api.github.com/repos/apache/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/trafficserver/languages","stargazers_url":"https://api.github.com/repos/apache/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/apache/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/apache/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/apache/trafficserver/subscription","commits_url":"https://api.github.com/repos/apache/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/apache/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/trafficserver/merges","archive_url":"https://api.github.com/repos/apache/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/trafficserver/downloads","issues_url":"https://api.github.com/repos/apache/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/apache/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/apache/trafficserver/releases{/id}","deployments_url":"https://api.github.com/repos/apache/trafficserver/deployments","created_at":"2009-10-31T08:00:10Z","updated_at":"2018-08-23T19:13:27Z","pushed_at":"2018-08-23T19:13:15Z","git_url":"git://github.com/apache/trafficserver.git","ssh_url":"git@github.com:apache/trafficserver.git","clone_url":"https://github.com/apache/trafficserver.git","svn_url":"https://github.com/apache/trafficserver","homepage":null,"size":89312,"stargazers_count":792,"watchers_count":792,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":536,"mirror_url":null,"archived":false,"open_issues_count":349,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":536,"open_issues":349,"watchers":792,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/4154"},"html":{"href":"https://github.com/apache/trafficserver/pull/4154"},"issue":{"href":"https://api.github.com/repos/apache/trafficserver/issues/4154"},"comments":{"href":"https://api.github.com/repos/apache/trafficserver/issues/4154/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/4154/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/4154/commits"},"statuses":{"href":"https://api.github.com/repos/apache/trafficserver/statuses/172aa759fc2b63a0226ee864af66c4feeb49c462"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"maskit"}}