{"action":"created","comment":{"url":"https://api.github.com/repos/nulogy/design-system/pulls/comments/215024554","pull_request_review_id":152201059,"id":215024554,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTAyNDU1NA==","diff_hunk":"@@ -1,38 +1,98 @@\n import React from 'react';\n import styled from 'styled-components';\n+import { colour, space, font, radius, shadow } from '@nulogy/tokens';\n+import QuietButton from '../Button/QuietButton';\n \n-const borderStyle = ({ theme }) => `1px solid ${theme.colour.neutral[400]}`;\n+const borderWidth = 1;\n+\n+const withoutBorder = value => value - borderWidth;","path":"components/src/Tables/Table.js","position":9,"original_position":9,"commit_id":"35ae4541ce24f6c86ba463137014db8a446b236d","original_commit_id":"35ae4541ce24f6c86ba463137014db8a446b236d","user":{"login":"theinterned","id":2694,"node_id":"MDQ6VXNlcjI2OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2694?v=4","gravatar_id":"","url":"https://api.github.com/users/theinterned","html_url":"https://github.com/theinterned","followers_url":"https://api.github.com/users/theinterned/followers","following_url":"https://api.github.com/users/theinterned/following{/other_user}","gists_url":"https://api.github.com/users/theinterned/gists{/gist_id}","starred_url":"https://api.github.com/users/theinterned/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theinterned/subscriptions","organizations_url":"https://api.github.com/users/theinterned/orgs","repos_url":"https://api.github.com/users/theinterned/repos","events_url":"https://api.github.com/users/theinterned/events{/privacy}","received_events_url":"https://api.github.com/users/theinterned/received_events","type":"User","site_admin":false},"body":"also it is confusing to use the word `borderWidth` in this context as it is meant to apply to the `Table.Button` but I would expect it to indicate a border width for the Table or Cells.","created_at":"2018-09-04T18:41:17Z","updated_at":"2018-09-04T18:41:17Z","html_url":"https://github.com/nulogy/design-system/pull/29#discussion_r215024554","pull_request_url":"https://api.github.com/repos/nulogy/design-system/pulls/29","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nulogy/design-system/pulls/comments/215024554"},"html":{"href":"https://github.com/nulogy/design-system/pull/29#discussion_r215024554"},"pull_request":{"href":"https://api.github.com/repos/nulogy/design-system/pulls/29"}},"in_reply_to_id":215010908},"pull_request":{"url":"https://api.github.com/repos/nulogy/design-system/pulls/29","id":212396788,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMzk2Nzg4","html_url":"https://github.com/nulogy/design-system/pull/29","diff_url":"https://github.com/nulogy/design-system/pull/29.diff","patch_url":"https://github.com/nulogy/design-system/pull/29.patch","issue_url":"https://api.github.com/repos/nulogy/design-system/issues/29","number":29,"state":"open","locked":false,"title":"Nds 228 design and build table cell and row","user":{"login":"nikola-nulogy","id":39559724,"node_id":"MDQ6VXNlcjM5NTU5NzI0","avatar_url":"https://avatars0.githubusercontent.com/u/39559724?v=4","gravatar_id":"","url":"https://api.github.com/users/nikola-nulogy","html_url":"https://github.com/nikola-nulogy","followers_url":"https://api.github.com/users/nikola-nulogy/followers","following_url":"https://api.github.com/users/nikola-nulogy/following{/other_user}","gists_url":"https://api.github.com/users/nikola-nulogy/gists{/gist_id}","starred_url":"https://api.github.com/users/nikola-nulogy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikola-nulogy/subscriptions","organizations_url":"https://api.github.com/users/nikola-nulogy/orgs","repos_url":"https://api.github.com/users/nikola-nulogy/repos","events_url":"https://api.github.com/users/nikola-nulogy/events{/privacy}","received_events_url":"https://api.github.com/users/nikola-nulogy/received_events","type":"User","site_admin":false},"body":"### What I did\r\n- Styled Table component\r\n- Created CreateRow, ActionCell, CreateRowCell, Button and TextInput (temporarily needed)\r\n- Created Read Only, Edit Mode, and With Create Row sub-stories inside Table story\r\n\r\n### To Test\r\nRun storybook and access Table story","created_at":"2018-08-31T14:13:37Z","updated_at":"2018-09-04T18:41:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ba85bda372dce286f0662ea344a52603c7d79ad","assignee":null,"assignees":[],"requested_reviewers":[{"login":"matthewlyle","id":5273370,"node_id":"MDQ6VXNlcjUyNzMzNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/5273370?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewlyle","html_url":"https://github.com/matthewlyle","followers_url":"https://api.github.com/users/matthewlyle/followers","following_url":"https://api.github.com/users/matthewlyle/following{/other_user}","gists_url":"https://api.github.com/users/matthewlyle/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewlyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewlyle/subscriptions","organizations_url":"https://api.github.com/users/matthewlyle/orgs","repos_url":"https://api.github.com/users/matthewlyle/repos","events_url":"https://api.github.com/users/matthewlyle/events{/privacy}","received_events_url":"https://api.github.com/users/matthewlyle/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nulogy/design-system/pulls/29/commits","review_comments_url":"https://api.github.com/repos/nulogy/design-system/pulls/29/comments","review_comment_url":"https://api.github.com/repos/nulogy/design-system/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nulogy/design-system/issues/29/comments","statuses_url":"https://api.github.com/repos/nulogy/design-system/statuses/35ae4541ce24f6c86ba463137014db8a446b236d","head":{"label":"nulogy:NDS-228-design-and-build-table-cell-and-row","ref":"NDS-228-design-and-build-table-cell-and-row","sha":"35ae4541ce24f6c86ba463137014db8a446b236d","user":{"login":"nulogy","id":386955,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4Njk1NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/386955?v=4","gravatar_id":"","url":"https://api.github.com/users/nulogy","html_url":"https://github.com/nulogy","followers_url":"https://api.github.com/users/nulogy/followers","following_url":"https://api.github.com/users/nulogy/following{/other_user}","gists_url":"https://api.github.com/users/nulogy/gists{/gist_id}","starred_url":"https://api.github.com/users/nulogy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nulogy/subscriptions","organizations_url":"https://api.github.com/users/nulogy/orgs","repos_url":"https://api.github.com/users/nulogy/repos","events_url":"https://api.github.com/users/nulogy/events{/privacy}","received_events_url":"https://api.github.com/users/nulogy/received_events","type":"Organization","site_admin":false},"repo":{"id":137131881,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcxMzE4ODE=","name":"design-system","full_name":"nulogy/design-system","owner":{"login":"nulogy","id":386955,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4Njk1NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/386955?v=4","gravatar_id":"","url":"https://api.github.com/users/nulogy","html_url":"https://github.com/nulogy","followers_url":"https://api.github.com/users/nulogy/followers","following_url":"https://api.github.com/users/nulogy/following{/other_user}","gists_url":"https://api.github.com/users/nulogy/gists{/gist_id}","starred_url":"https://api.github.com/users/nulogy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nulogy/subscriptions","organizations_url":"https://api.github.com/users/nulogy/orgs","repos_url":"https://api.github.com/users/nulogy/repos","events_url":"https://api.github.com/users/nulogy/events{/privacy}","received_events_url":"https://api.github.com/users/nulogy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nulogy/design-system","description":"Nulogy's design system. Modern Enterprise Design for the Industrial Environment - http://nulogy.design","fork":false,"url":"https://api.github.com/repos/nulogy/design-system","forks_url":"https://api.github.com/repos/nulogy/design-system/forks","keys_url":"https://api.github.com/repos/nulogy/design-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nulogy/design-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nulogy/design-system/teams","hooks_url":"https://api.github.com/repos/nulogy/design-system/hooks","issue_events_url":"https://api.github.com/repos/nulogy/design-system/issues/events{/number}","events_url":"https://api.github.com/repos/nulogy/design-system/events","assignees_url":"https://api.github.com/repos/nulogy/design-system/assignees{/user}","branches_url":"https://api.github.com/repos/nulogy/design-system/branches{/branch}","tags_url":"https://api.github.com/repos/nulogy/design-system/tags","blobs_url":"https://api.github.com/repos/nulogy/design-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nulogy/design-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nulogy/design-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/nulogy/design-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nulogy/design-system/statuses/{sha}","languages_url":"https://api.github.com/repos/nulogy/design-system/languages","stargazers_url":"https://api.github.com/repos/nulogy/design-system/stargazers","contributors_url":"https://api.github.com/repos/nulogy/design-system/contributors","subscribers_url":"https://api.github.com/repos/nulogy/design-system/subscribers","subscription_url":"https://api.github.com/repos/nulogy/design-system/subscription","commits_url":"https://api.github.com/repos/nulogy/design-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/nulogy/design-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/nulogy/design-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/nulogy/design-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/nulogy/design-system/contents/{+path}","compare_url":"https://api.github.com/repos/nulogy/design-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nulogy/design-system/merges","archive_url":"https://api.github.com/repos/nulogy/design-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nulogy/design-system/downloads","issues_url":"https://api.github.com/repos/nulogy/design-system/issues{/number}","pulls_url":"https://api.github.com/repos/nulogy/design-system/pulls{/number}","milestones_url":"https://api.github.com/repos/nulogy/design-system/milestones{/number}","notifications_url":"https://api.github.com/repos/nulogy/design-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nulogy/design-system/labels{/name}","releases_url":"https://api.github.com/repos/nulogy/design-system/releases{/id}","deployments_url":"https://api.github.com/repos/nulogy/design-system/deployments","created_at":"2018-06-12T21:53:32Z","updated_at":"2018-08-31T17:11:09Z","pushed_at":"2018-09-04T17:38:35Z","git_url":"git://github.com/nulogy/design-system.git","ssh_url":"git@github.com:nulogy/design-system.git","clone_url":"https://github.com/nulogy/design-system.git","svn_url":"https://github.com/nulogy/design-system","homepage":null,"size":1104,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"nulogy:master","ref":"master","sha":"5348dcc0bec9d526fe30e16778674c7ca8b3ba93","user":{"login":"nulogy","id":386955,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4Njk1NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/386955?v=4","gravatar_id":"","url":"https://api.github.com/users/nulogy","html_url":"https://github.com/nulogy","followers_url":"https://api.github.com/users/nulogy/followers","following_url":"https://api.github.com/users/nulogy/following{/other_user}","gists_url":"https://api.github.com/users/nulogy/gists{/gist_id}","starred_url":"https://api.github.com/users/nulogy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nulogy/subscriptions","organizations_url":"https://api.github.com/users/nulogy/orgs","repos_url":"https://api.github.com/users/nulogy/repos","events_url":"https://api.github.com/users/nulogy/events{/privacy}","received_events_url":"https://api.github.com/users/nulogy/received_events","type":"Organization","site_admin":false},"repo":{"id":137131881,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcxMzE4ODE=","name":"design-system","full_name":"nulogy/design-system","owner":{"login":"nulogy","id":386955,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4Njk1NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/386955?v=4","gravatar_id":"","url":"https://api.github.com/users/nulogy","html_url":"https://github.com/nulogy","followers_url":"https://api.github.com/users/nulogy/followers","following_url":"https://api.github.com/users/nulogy/following{/other_user}","gists_url":"https://api.github.com/users/nulogy/gists{/gist_id}","starred_url":"https://api.github.com/users/nulogy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nulogy/subscriptions","organizations_url":"https://api.github.com/users/nulogy/orgs","repos_url":"https://api.github.com/users/nulogy/repos","events_url":"https://api.github.com/users/nulogy/events{/privacy}","received_events_url":"https://api.github.com/users/nulogy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nulogy/design-system","description":"Nulogy's design system. Modern Enterprise Design for the Industrial Environment - http://nulogy.design","fork":false,"url":"https://api.github.com/repos/nulogy/design-system","forks_url":"https://api.github.com/repos/nulogy/design-system/forks","keys_url":"https://api.github.com/repos/nulogy/design-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nulogy/design-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nulogy/design-system/teams","hooks_url":"https://api.github.com/repos/nulogy/design-system/hooks","issue_events_url":"https://api.github.com/repos/nulogy/design-system/issues/events{/number}","events_url":"https://api.github.com/repos/nulogy/design-system/events","assignees_url":"https://api.github.com/repos/nulogy/design-system/assignees{/user}","branches_url":"https://api.github.com/repos/nulogy/design-system/branches{/branch}","tags_url":"https://api.github.com/repos/nulogy/design-system/tags","blobs_url":"https://api.github.com/repos/nulogy/design-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nulogy/design-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nulogy/design-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/nulogy/design-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nulogy/design-system/statuses/{sha}","languages_url":"https://api.github.com/repos/nulogy/design-system/languages","stargazers_url":"https://api.github.com/repos/nulogy/design-system/stargazers","contributors_url":"https://api.github.com/repos/nulogy/design-system/contributors","subscribers_url":"https://api.github.com/repos/nulogy/design-system/subscribers","subscription_url":"https://api.github.com/repos/nulogy/design-system/subscription","commits_url":"https://api.github.com/repos/nulogy/design-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/nulogy/design-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/nulogy/design-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/nulogy/design-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/nulogy/design-system/contents/{+path}","compare_url":"https://api.github.com/repos/nulogy/design-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nulogy/design-system/merges","archive_url":"https://api.github.com/repos/nulogy/design-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nulogy/design-system/downloads","issues_url":"https://api.github.com/repos/nulogy/design-system/issues{/number}","pulls_url":"https://api.github.com/repos/nulogy/design-system/pulls{/number}","milestones_url":"https://api.github.com/repos/nulogy/design-system/milestones{/number}","notifications_url":"https://api.github.com/repos/nulogy/design-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nulogy/design-system/labels{/name}","releases_url":"https://api.github.com/repos/nulogy/design-system/releases{/id}","deployments_url":"https://api.github.com/repos/nulogy/design-system/deployments","created_at":"2018-06-12T21:53:32Z","updated_at":"2018-08-31T17:11:09Z","pushed_at":"2018-09-04T17:38:35Z","git_url":"git://github.com/nulogy/design-system.git","ssh_url":"git@github.com:nulogy/design-system.git","clone_url":"https://github.com/nulogy/design-system.git","svn_url":"https://github.com/nulogy/design-system","homepage":null,"size":1104,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nulogy/design-system/pulls/29"},"html":{"href":"https://github.com/nulogy/design-system/pull/29"},"issue":{"href":"https://api.github.com/repos/nulogy/design-system/issues/29"},"comments":{"href":"https://api.github.com/repos/nulogy/design-system/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/nulogy/design-system/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/nulogy/design-system/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nulogy/design-system/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/nulogy/design-system/statuses/35ae4541ce24f6c86ba463137014db8a446b236d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"theinterned"}}