{"action":"created","issue":{"url":"https://api.github.com/repos/bosnet/sebak/issues/566","repository_url":"https://api.github.com/repos/bosnet/sebak","labels_url":"https://api.github.com/repos/bosnet/sebak/issues/566/labels{/name}","comments_url":"https://api.github.com/repos/bosnet/sebak/issues/566/comments","events_url":"https://api.github.com/repos/bosnet/sebak/issues/566/events","html_url":"https://github.com/bosnet/sebak/pull/566","id":371813901,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MTc2MTY4","number":566,"title":"Tx pool reference refact","user":{"login":"kfangw","id":973304,"node_id":"MDQ6VXNlcjk3MzMwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/973304?v=4","gravatar_id":"","url":"https://api.github.com/users/kfangw","html_url":"https://github.com/kfangw","followers_url":"https://api.github.com/users/kfangw/followers","following_url":"https://api.github.com/users/kfangw/following{/other_user}","gists_url":"https://api.github.com/users/kfangw/gists{/gist_id}","starred_url":"https://api.github.com/users/kfangw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfangw/subscriptions","organizations_url":"https://api.github.com/users/kfangw/orgs","repos_url":"https://api.github.com/users/kfangw/repos","events_url":"https://api.github.com/users/kfangw/events{/privacy}","received_events_url":"https://api.github.com/users/kfangw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-19T05:39:42Z","updated_at":"2018-10-19T05:43:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/bosnet/sebak/pulls/566","html_url":"https://github.com/bosnet/sebak/pull/566","diff_url":"https://github.com/bosnet/sebak/pull/566.diff","patch_url":"https://github.com/bosnet/sebak/pull/566.patch"},"body":"### Github Issue\r\n#564 \r\n\r\n### Background\r\nFor #564, the API needs to have a reference for transaction pool.\r\nBut it can be referred by attribute of consensus.\r\nBy conceptually, the consensus does not need to hold the transaction pool.\r\n\r\n### Solution\r\nMove the reference for transaction pool from consensus to node runner\r\n\r\n### Possible Drawbacks\r\n<!--\r\n    What are the possible side-effects or negative impacts of the code change?\r\n-->\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/bosnet/sebak/issues/comments/431251209","html_url":"https://github.com/bosnet/sebak/pull/566#issuecomment-431251209","issue_url":"https://api.github.com/repos/bosnet/sebak/issues/566","id":431251209,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTI1MTIwOQ==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-10-19T05:43:29Z","updated_at":"2018-10-19T05:43:29Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/bosnet/sebak/pull/566?src=pr&el=h1) Report\n> Merging [#566](https://codecov.io/gh/bosnet/sebak/pull/566?src=pr&el=desc) into [master](https://codecov.io/gh/bosnet/sebak/commit/eda827fcd399fc4c515e05fc5840a939c1027a2f?src=pr&el=desc) will **increase** coverage by `0.08%`.\n> The diff coverage is `93.33%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/bosnet/sebak/pull/566/graphs/tree.svg?width=650&token=npRPkUTGpQ&height=150&src=pr)](https://codecov.io/gh/bosnet/sebak/pull/566?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master     #566      +/-   ##\n==========================================\n+ Coverage   64.88%   64.97%   +0.08%     \n==========================================\n  Files         114      114              \n  Lines        6897     6900       +3     \n==========================================\n+ Hits         4475     4483       +8     \n+ Misses       1896     1893       -3     \n+ Partials      526      524       -2\n```\n\n| Flag | Coverage Δ | |\n|---|---|---|\n| #integration_tests_node | `43.15% <86.66%> (+0.07%)` | :arrow_up: |\n| #unittests | `54.27% <88.88%> (+0.06%)` | :arrow_up: |\n\n| [Impacted Files](https://codecov.io/gh/bosnet/sebak/pull/566?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [lib/consensus/isaac.go](https://codecov.io/gh/bosnet/sebak/pull/566/diff?src=pr&el=tree#diff-bGliL2NvbnNlbnN1cy9pc2FhYy5nbw==) | `71.79% <100%> (-0.24%)` | :arrow_down: |\n| [lib/node/runner/checker\\_message.go](https://codecov.io/gh/bosnet/sebak/pull/566/diff?src=pr&el=tree#diff-bGliL25vZGUvcnVubmVyL2NoZWNrZXJfbWVzc2FnZS5nbw==) | `100% <100%> (+3.84%)` | :arrow_up: |\n| [lib/node/runner/api\\_transaction.go](https://codecov.io/gh/bosnet/sebak/pull/566/diff?src=pr&el=tree#diff-bGliL25vZGUvcnVubmVyL2FwaV90cmFuc2FjdGlvbi5nbw==) | `77.27% <100%> (ø)` | :arrow_up: |\n| [lib/node/runner/checker.go](https://codecov.io/gh/bosnet/sebak/pull/566/diff?src=pr&el=tree#diff-bGliL25vZGUvcnVubmVyL2NoZWNrZXIuZ28=) | `64.06% <100%> (+0.08%)` | :arrow_up: |\n| [lib/node/runner/api\\_node.go](https://codecov.io/gh/bosnet/sebak/pull/566/diff?src=pr&el=tree#diff-bGliL25vZGUvcnVubmVyL2FwaV9ub2RlLmdv) | `73.86% <100%> (+0.6%)` | :arrow_up: |\n| [lib/node/runner/checker\\_ballot\\_transaction.go](https://codecov.io/gh/bosnet/sebak/pull/566/diff?src=pr&el=tree#diff-bGliL25vZGUvcnVubmVyL2NoZWNrZXJfYmFsbG90X3RyYW5zYWN0aW9uLmdv) | `65.89% <50%> (ø)` | :arrow_up: |\n| [lib/node/runner/node\\_runner.go](https://codecov.io/gh/bosnet/sebak/pull/566/diff?src=pr&el=tree#diff-bGliL25vZGUvcnVubmVyL25vZGVfcnVubmVyLmdv) | `81.11% <92.3%> (+0.74%)` | :arrow_up: |\n| [lib/block/transaction\\_history.go](https://codecov.io/gh/bosnet/sebak/pull/566/diff?src=pr&el=tree#diff-bGliL2Jsb2NrL3RyYW5zYWN0aW9uX2hpc3RvcnkuZ28=) | `64.7% <0%> (+2.94%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/bosnet/sebak/pull/566?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/bosnet/sebak/pull/566?src=pr&el=footer). Last update [eda827f...dfc6484](https://codecov.io/gh/bosnet/sebak/pull/566?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}