{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/pulls/1","id":228067040,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MDY3MDQw","html_url":"https://github.com/TomStanton/VTOL-Bicopter-transition-mixes/pull/1","diff_url":"https://github.com/TomStanton/VTOL-Bicopter-transition-mixes/pull/1.diff","patch_url":"https://github.com/TomStanton/VTOL-Bicopter-transition-mixes/pull/1.patch","issue_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/issues/1","number":1,"state":"open","locked":false,"title":"Code cleanup","user":{"login":"DonnyCraft1","id":24552816,"node_id":"MDQ6VXNlcjI0NTUyODE2","avatar_url":"https://avatars1.githubusercontent.com/u/24552816?v=4","gravatar_id":"","url":"https://api.github.com/users/DonnyCraft1","html_url":"https://github.com/DonnyCraft1","followers_url":"https://api.github.com/users/DonnyCraft1/followers","following_url":"https://api.github.com/users/DonnyCraft1/following{/other_user}","gists_url":"https://api.github.com/users/DonnyCraft1/gists{/gist_id}","starred_url":"https://api.github.com/users/DonnyCraft1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonnyCraft1/subscriptions","organizations_url":"https://api.github.com/users/DonnyCraft1/orgs","repos_url":"https://api.github.com/users/DonnyCraft1/repos","events_url":"https://api.github.com/users/DonnyCraft1/events{/privacy}","received_events_url":"https://api.github.com/users/DonnyCraft1/received_events","type":"User","site_admin":false},"body":"**Hi Tom Stanton!**\r\nI just watched your [video](https://www.youtube.com/watch?v=gPEeCjVrTBw), and I think it's really cool what you have made.\r\nI would never be able to what you did.\r\n\r\nI just cleaned up the code a bit, and I hope you like it.\r\n\r\n---\r\nBy the way, I think the reason you did not understand that [if statement](https://youtu.be/gPEeCjVrTBw?t=267) (If that was what you ment), it's because it was kind of a mess.\r\n\r\n**Your version**\r\n```java\r\nif ((ch1.getValue()) > 1000 && (ch1.getValue()) < 2000) // \r\n  {throttleIN = ch1.getValue() - 1500;}\r\n\r\nelse  \r\n  {throttleIN = - 500;}\r\n```\r\n\r\n**A better way to write it (but with the exact same functionality)**\r\n```java\r\nif (ch1.getValue() > 1000 && ch1.getValue() < 2000) {\r\n  throttleIN = ch1.getValue() - 1500;\r\n} else {\r\n  throttleIN = -500;\r\n}\r\n```\r\n\r\n^^^ and this is also the way I wrote it in this pull request.\r\n\r\n---\r\n\r\nIt's up to you to choose to merge this pull request. But I hope you find it useful 👍 ","created_at":"2018-11-02T21:46:27Z","updated_at":"2018-11-02T21:46:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/pulls/1/commits","review_comments_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/pulls/1/comments","review_comment_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/issues/1/comments","statuses_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/statuses/3ce249e26e0fdd6b01fec2a359333f6e1b2bd9ab","head":{"label":"DonnyCraft1:master","ref":"master","sha":"3ce249e26e0fdd6b01fec2a359333f6e1b2bd9ab","user":{"login":"DonnyCraft1","id":24552816,"node_id":"MDQ6VXNlcjI0NTUyODE2","avatar_url":"https://avatars1.githubusercontent.com/u/24552816?v=4","gravatar_id":"","url":"https://api.github.com/users/DonnyCraft1","html_url":"https://github.com/DonnyCraft1","followers_url":"https://api.github.com/users/DonnyCraft1/followers","following_url":"https://api.github.com/users/DonnyCraft1/following{/other_user}","gists_url":"https://api.github.com/users/DonnyCraft1/gists{/gist_id}","starred_url":"https://api.github.com/users/DonnyCraft1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonnyCraft1/subscriptions","organizations_url":"https://api.github.com/users/DonnyCraft1/orgs","repos_url":"https://api.github.com/users/DonnyCraft1/repos","events_url":"https://api.github.com/users/DonnyCraft1/events{/privacy}","received_events_url":"https://api.github.com/users/DonnyCraft1/received_events","type":"User","site_admin":false},"repo":{"id":155921499,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU5MjE0OTk=","name":"VTOL-Bicopter-transition-mixes","full_name":"DonnyCraft1/VTOL-Bicopter-transition-mixes","private":false,"owner":{"login":"DonnyCraft1","id":24552816,"node_id":"MDQ6VXNlcjI0NTUyODE2","avatar_url":"https://avatars1.githubusercontent.com/u/24552816?v=4","gravatar_id":"","url":"https://api.github.com/users/DonnyCraft1","html_url":"https://github.com/DonnyCraft1","followers_url":"https://api.github.com/users/DonnyCraft1/followers","following_url":"https://api.github.com/users/DonnyCraft1/following{/other_user}","gists_url":"https://api.github.com/users/DonnyCraft1/gists{/gist_id}","starred_url":"https://api.github.com/users/DonnyCraft1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonnyCraft1/subscriptions","organizations_url":"https://api.github.com/users/DonnyCraft1/orgs","repos_url":"https://api.github.com/users/DonnyCraft1/repos","events_url":"https://api.github.com/users/DonnyCraft1/events{/privacy}","received_events_url":"https://api.github.com/users/DonnyCraft1/received_events","type":"User","site_admin":false},"html_url":"https://github.com/DonnyCraft1/VTOL-Bicopter-transition-mixes","description":"Transition mixes for a radio controlled VTOL bicopter","fork":true,"url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes","forks_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/forks","keys_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/teams","hooks_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/hooks","issue_events_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/issues/events{/number}","events_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/events","assignees_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/assignees{/user}","branches_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/branches{/branch}","tags_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/tags","blobs_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/git/refs{/sha}","trees_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/statuses/{sha}","languages_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/languages","stargazers_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/stargazers","contributors_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/contributors","subscribers_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/subscribers","subscription_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/subscription","commits_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/commits{/sha}","git_commits_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/git/commits{/sha}","comments_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/comments{/number}","issue_comment_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/issues/comments{/number}","contents_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/contents/{+path}","compare_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/merges","archive_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/downloads","issues_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/issues{/number}","pulls_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/pulls{/number}","milestones_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/milestones{/number}","notifications_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/labels{/name}","releases_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/releases{/id}","deployments_url":"https://api.github.com/repos/DonnyCraft1/VTOL-Bicopter-transition-mixes/deployments","created_at":"2018-11-02T21:05:38Z","updated_at":"2018-11-02T21:29:58Z","pushed_at":"2018-11-02T21:29:57Z","git_url":"git://github.com/DonnyCraft1/VTOL-Bicopter-transition-mixes.git","ssh_url":"git@github.com:DonnyCraft1/VTOL-Bicopter-transition-mixes.git","clone_url":"https://github.com/DonnyCraft1/VTOL-Bicopter-transition-mixes.git","svn_url":"https://github.com/DonnyCraft1/VTOL-Bicopter-transition-mixes","homepage":null,"size":2,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TomStanton:master","ref":"master","sha":"2f983f2b8ad6ed6af13ef9d96202dc8171656a53","user":{"login":"TomStanton","id":44671282,"node_id":"MDQ6VXNlcjQ0NjcxMjgy","avatar_url":"https://avatars1.githubusercontent.com/u/44671282?v=4","gravatar_id":"","url":"https://api.github.com/users/TomStanton","html_url":"https://github.com/TomStanton","followers_url":"https://api.github.com/users/TomStanton/followers","following_url":"https://api.github.com/users/TomStanton/following{/other_user}","gists_url":"https://api.github.com/users/TomStanton/gists{/gist_id}","starred_url":"https://api.github.com/users/TomStanton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomStanton/subscriptions","organizations_url":"https://api.github.com/users/TomStanton/orgs","repos_url":"https://api.github.com/users/TomStanton/repos","events_url":"https://api.github.com/users/TomStanton/events{/privacy}","received_events_url":"https://api.github.com/users/TomStanton/received_events","type":"User","site_admin":false},"repo":{"id":155710105,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU3MTAxMDU=","name":"VTOL-Bicopter-transition-mixes","full_name":"TomStanton/VTOL-Bicopter-transition-mixes","private":false,"owner":{"login":"TomStanton","id":44671282,"node_id":"MDQ6VXNlcjQ0NjcxMjgy","avatar_url":"https://avatars1.githubusercontent.com/u/44671282?v=4","gravatar_id":"","url":"https://api.github.com/users/TomStanton","html_url":"https://github.com/TomStanton","followers_url":"https://api.github.com/users/TomStanton/followers","following_url":"https://api.github.com/users/TomStanton/following{/other_user}","gists_url":"https://api.github.com/users/TomStanton/gists{/gist_id}","starred_url":"https://api.github.com/users/TomStanton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomStanton/subscriptions","organizations_url":"https://api.github.com/users/TomStanton/orgs","repos_url":"https://api.github.com/users/TomStanton/repos","events_url":"https://api.github.com/users/TomStanton/events{/privacy}","received_events_url":"https://api.github.com/users/TomStanton/received_events","type":"User","site_admin":false},"html_url":"https://github.com/TomStanton/VTOL-Bicopter-transition-mixes","description":"Transition mixes for a radio controlled VTOL bicopter","fork":false,"url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes","forks_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/forks","keys_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/teams","hooks_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/hooks","issue_events_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/issues/events{/number}","events_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/events","assignees_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/assignees{/user}","branches_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/branches{/branch}","tags_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/tags","blobs_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/git/refs{/sha}","trees_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/statuses/{sha}","languages_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/languages","stargazers_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/stargazers","contributors_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/contributors","subscribers_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/subscribers","subscription_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/subscription","commits_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/commits{/sha}","git_commits_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/git/commits{/sha}","comments_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/comments{/number}","issue_comment_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/issues/comments{/number}","contents_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/contents/{+path}","compare_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/merges","archive_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/downloads","issues_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/issues{/number}","pulls_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/pulls{/number}","milestones_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/milestones{/number}","notifications_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/labels{/name}","releases_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/releases{/id}","deployments_url":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/deployments","created_at":"2018-11-01T12:15:17Z","updated_at":"2018-11-02T21:18:22Z","pushed_at":"2018-11-02T11:37:31Z","git_url":"git://github.com/TomStanton/VTOL-Bicopter-transition-mixes.git","ssh_url":"git@github.com:TomStanton/VTOL-Bicopter-transition-mixes.git","clone_url":"https://github.com/TomStanton/VTOL-Bicopter-transition-mixes.git","svn_url":"https://github.com/TomStanton/VTOL-Bicopter-transition-mixes","homepage":null,"size":2,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/pulls/1"},"html":{"href":"https://github.com/TomStanton/VTOL-Bicopter-transition-mixes/pull/1"},"issue":{"href":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/issues/1"},"comments":{"href":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/TomStanton/VTOL-Bicopter-transition-mixes/statuses/3ce249e26e0fdd6b01fec2a359333f6e1b2bd9ab"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":44,"deletions":48,"changed_files":1}}
{"actor":{"display_login":"DonnyCraft1"}}