{"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/applitools/eyes.cypress/pulls/3","id":210001476,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMDAxNDc2","html_url":"https://github.com/applitools/eyes.cypress/pull/3","diff_url":"https://github.com/applitools/eyes.cypress/pull/3.diff","patch_url":"https://github.com/applitools/eyes.cypress/pull/3.patch","issue_url":"https://api.github.com/repos/applitools/eyes.cypress/issues/3","number":3,"state":"open","locked":false,"title":"\"abort is not a function\" when isDisabled is set to true","user":{"login":"justmoon","id":53233,"node_id":"MDQ6VXNlcjUzMjMz","avatar_url":"https://avatars1.githubusercontent.com/u/53233?v=4","gravatar_id":"","url":"https://api.github.com/users/justmoon","html_url":"https://github.com/justmoon","followers_url":"https://api.github.com/users/justmoon/followers","following_url":"https://api.github.com/users/justmoon/following{/other_user}","gists_url":"https://api.github.com/users/justmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/justmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justmoon/subscriptions","organizations_url":"https://api.github.com/users/justmoon/orgs","repos_url":"https://api.github.com/users/justmoon/repos","events_url":"https://api.github.com/users/justmoon/events{/privacy}","received_events_url":"https://api.github.com/users/justmoon/received_events","type":"User","site_admin":false},"body":"The `makeEyesOpen` function in `@applitools/rendering-grid-client` will return an object with no `abort` property:\r\n\r\n``` js\r\n    if (isDisabled) {\r\n      logger.log('openEyes: isDisabled=true, skipping checks');\r\n      return {\r\n        checkWindow: disabledFunc('checkWindow'),\r\n        close: disabledFunc('close'),\r\n      };\r\n    }\r\n```\r\n\r\nTherefore, `eyes.cypress` should not assume that property to be always present.\r\n\r\nOtherwise, an error `abort is not a function` will be triggered.\r\n\r\nThis patch checks whether `abort` is set and only calls aborts that are truthy.","created_at":"2018-08-22T02:00:28Z","updated_at":"2018-08-22T02:00:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/applitools/eyes.cypress/pulls/3/commits","review_comments_url":"https://api.github.com/repos/applitools/eyes.cypress/pulls/3/comments","review_comment_url":"https://api.github.com/repos/applitools/eyes.cypress/pulls/comments{/number}","comments_url":"https://api.github.com/repos/applitools/eyes.cypress/issues/3/comments","statuses_url":"https://api.github.com/repos/applitools/eyes.cypress/statuses/1a2d46d0f5fe7ca86d2a6ef20dd0c3e382267891","head":{"label":"justmoon:st-fix-abort-not-a-function","ref":"st-fix-abort-not-a-function","sha":"1a2d46d0f5fe7ca86d2a6ef20dd0c3e382267891","user":{"login":"justmoon","id":53233,"node_id":"MDQ6VXNlcjUzMjMz","avatar_url":"https://avatars1.githubusercontent.com/u/53233?v=4","gravatar_id":"","url":"https://api.github.com/users/justmoon","html_url":"https://github.com/justmoon","followers_url":"https://api.github.com/users/justmoon/followers","following_url":"https://api.github.com/users/justmoon/following{/other_user}","gists_url":"https://api.github.com/users/justmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/justmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justmoon/subscriptions","organizations_url":"https://api.github.com/users/justmoon/orgs","repos_url":"https://api.github.com/users/justmoon/repos","events_url":"https://api.github.com/users/justmoon/events{/privacy}","received_events_url":"https://api.github.com/users/justmoon/received_events","type":"User","site_admin":false},"repo":{"id":145641496,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU2NDE0OTY=","name":"eyes.cypress","full_name":"justmoon/eyes.cypress","owner":{"login":"justmoon","id":53233,"node_id":"MDQ6VXNlcjUzMjMz","avatar_url":"https://avatars1.githubusercontent.com/u/53233?v=4","gravatar_id":"","url":"https://api.github.com/users/justmoon","html_url":"https://github.com/justmoon","followers_url":"https://api.github.com/users/justmoon/followers","following_url":"https://api.github.com/users/justmoon/following{/other_user}","gists_url":"https://api.github.com/users/justmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/justmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justmoon/subscriptions","organizations_url":"https://api.github.com/users/justmoon/orgs","repos_url":"https://api.github.com/users/justmoon/repos","events_url":"https://api.github.com/users/justmoon/events{/privacy}","received_events_url":"https://api.github.com/users/justmoon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/justmoon/eyes.cypress","description":"Applitoos Eyes SDK for cypress.io","fork":true,"url":"https://api.github.com/repos/justmoon/eyes.cypress","forks_url":"https://api.github.com/repos/justmoon/eyes.cypress/forks","keys_url":"https://api.github.com/repos/justmoon/eyes.cypress/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justmoon/eyes.cypress/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justmoon/eyes.cypress/teams","hooks_url":"https://api.github.com/repos/justmoon/eyes.cypress/hooks","issue_events_url":"https://api.github.com/repos/justmoon/eyes.cypress/issues/events{/number}","events_url":"https://api.github.com/repos/justmoon/eyes.cypress/events","assignees_url":"https://api.github.com/repos/justmoon/eyes.cypress/assignees{/user}","branches_url":"https://api.github.com/repos/justmoon/eyes.cypress/branches{/branch}","tags_url":"https://api.github.com/repos/justmoon/eyes.cypress/tags","blobs_url":"https://api.github.com/repos/justmoon/eyes.cypress/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justmoon/eyes.cypress/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justmoon/eyes.cypress/git/refs{/sha}","trees_url":"https://api.github.com/repos/justmoon/eyes.cypress/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justmoon/eyes.cypress/statuses/{sha}","languages_url":"https://api.github.com/repos/justmoon/eyes.cypress/languages","stargazers_url":"https://api.github.com/repos/justmoon/eyes.cypress/stargazers","contributors_url":"https://api.github.com/repos/justmoon/eyes.cypress/contributors","subscribers_url":"https://api.github.com/repos/justmoon/eyes.cypress/subscribers","subscription_url":"https://api.github.com/repos/justmoon/eyes.cypress/subscription","commits_url":"https://api.github.com/repos/justmoon/eyes.cypress/commits{/sha}","git_commits_url":"https://api.github.com/repos/justmoon/eyes.cypress/git/commits{/sha}","comments_url":"https://api.github.com/repos/justmoon/eyes.cypress/comments{/number}","issue_comment_url":"https://api.github.com/repos/justmoon/eyes.cypress/issues/comments{/number}","contents_url":"https://api.github.com/repos/justmoon/eyes.cypress/contents/{+path}","compare_url":"https://api.github.com/repos/justmoon/eyes.cypress/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justmoon/eyes.cypress/merges","archive_url":"https://api.github.com/repos/justmoon/eyes.cypress/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justmoon/eyes.cypress/downloads","issues_url":"https://api.github.com/repos/justmoon/eyes.cypress/issues{/number}","pulls_url":"https://api.github.com/repos/justmoon/eyes.cypress/pulls{/number}","milestones_url":"https://api.github.com/repos/justmoon/eyes.cypress/milestones{/number}","notifications_url":"https://api.github.com/repos/justmoon/eyes.cypress/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justmoon/eyes.cypress/labels{/name}","releases_url":"https://api.github.com/repos/justmoon/eyes.cypress/releases{/id}","deployments_url":"https://api.github.com/repos/justmoon/eyes.cypress/deployments","created_at":"2018-08-22T01:52:39Z","updated_at":"2018-08-22T01:52:40Z","pushed_at":"2018-08-22T01:56:30Z","git_url":"git://github.com/justmoon/eyes.cypress.git","ssh_url":"git@github.com:justmoon/eyes.cypress.git","clone_url":"https://github.com/justmoon/eyes.cypress.git","svn_url":"https://github.com/justmoon/eyes.cypress","homepage":"","size":1298,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"applitools:master","ref":"master","sha":"7662c10c98182da09de665de1a5023c86718d67b","user":{"login":"applitools","id":8025560,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwMjU1NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/8025560?v=4","gravatar_id":"","url":"https://api.github.com/users/applitools","html_url":"https://github.com/applitools","followers_url":"https://api.github.com/users/applitools/followers","following_url":"https://api.github.com/users/applitools/following{/other_user}","gists_url":"https://api.github.com/users/applitools/gists{/gist_id}","starred_url":"https://api.github.com/users/applitools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/applitools/subscriptions","organizations_url":"https://api.github.com/users/applitools/orgs","repos_url":"https://api.github.com/users/applitools/repos","events_url":"https://api.github.com/users/applitools/events{/privacy}","received_events_url":"https://api.github.com/users/applitools/received_events","type":"Organization","site_admin":false},"repo":{"id":129746491,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk3NDY0OTE=","name":"eyes.cypress","full_name":"applitools/eyes.cypress","owner":{"login":"applitools","id":8025560,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwMjU1NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/8025560?v=4","gravatar_id":"","url":"https://api.github.com/users/applitools","html_url":"https://github.com/applitools","followers_url":"https://api.github.com/users/applitools/followers","following_url":"https://api.github.com/users/applitools/following{/other_user}","gists_url":"https://api.github.com/users/applitools/gists{/gist_id}","starred_url":"https://api.github.com/users/applitools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/applitools/subscriptions","organizations_url":"https://api.github.com/users/applitools/orgs","repos_url":"https://api.github.com/users/applitools/repos","events_url":"https://api.github.com/users/applitools/events{/privacy}","received_events_url":"https://api.github.com/users/applitools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/applitools/eyes.cypress","description":"Applitoos Eyes SDK for cypress.io","fork":false,"url":"https://api.github.com/repos/applitools/eyes.cypress","forks_url":"https://api.github.com/repos/applitools/eyes.cypress/forks","keys_url":"https://api.github.com/repos/applitools/eyes.cypress/keys{/key_id}","collaborators_url":"https://api.github.com/repos/applitools/eyes.cypress/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/applitools/eyes.cypress/teams","hooks_url":"https://api.github.com/repos/applitools/eyes.cypress/hooks","issue_events_url":"https://api.github.com/repos/applitools/eyes.cypress/issues/events{/number}","events_url":"https://api.github.com/repos/applitools/eyes.cypress/events","assignees_url":"https://api.github.com/repos/applitools/eyes.cypress/assignees{/user}","branches_url":"https://api.github.com/repos/applitools/eyes.cypress/branches{/branch}","tags_url":"https://api.github.com/repos/applitools/eyes.cypress/tags","blobs_url":"https://api.github.com/repos/applitools/eyes.cypress/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/applitools/eyes.cypress/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/applitools/eyes.cypress/git/refs{/sha}","trees_url":"https://api.github.com/repos/applitools/eyes.cypress/git/trees{/sha}","statuses_url":"https://api.github.com/repos/applitools/eyes.cypress/statuses/{sha}","languages_url":"https://api.github.com/repos/applitools/eyes.cypress/languages","stargazers_url":"https://api.github.com/repos/applitools/eyes.cypress/stargazers","contributors_url":"https://api.github.com/repos/applitools/eyes.cypress/contributors","subscribers_url":"https://api.github.com/repos/applitools/eyes.cypress/subscribers","subscription_url":"https://api.github.com/repos/applitools/eyes.cypress/subscription","commits_url":"https://api.github.com/repos/applitools/eyes.cypress/commits{/sha}","git_commits_url":"https://api.github.com/repos/applitools/eyes.cypress/git/commits{/sha}","comments_url":"https://api.github.com/repos/applitools/eyes.cypress/comments{/number}","issue_comment_url":"https://api.github.com/repos/applitools/eyes.cypress/issues/comments{/number}","contents_url":"https://api.github.com/repos/applitools/eyes.cypress/contents/{+path}","compare_url":"https://api.github.com/repos/applitools/eyes.cypress/compare/{base}...{head}","merges_url":"https://api.github.com/repos/applitools/eyes.cypress/merges","archive_url":"https://api.github.com/repos/applitools/eyes.cypress/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/applitools/eyes.cypress/downloads","issues_url":"https://api.github.com/repos/applitools/eyes.cypress/issues{/number}","pulls_url":"https://api.github.com/repos/applitools/eyes.cypress/pulls{/number}","milestones_url":"https://api.github.com/repos/applitools/eyes.cypress/milestones{/number}","notifications_url":"https://api.github.com/repos/applitools/eyes.cypress/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/applitools/eyes.cypress/labels{/name}","releases_url":"https://api.github.com/repos/applitools/eyes.cypress/releases{/id}","deployments_url":"https://api.github.com/repos/applitools/eyes.cypress/deployments","created_at":"2018-04-16T13:18:27Z","updated_at":"2018-08-20T07:10:46Z","pushed_at":"2018-08-20T07:10:44Z","git_url":"git://github.com/applitools/eyes.cypress.git","ssh_url":"git@github.com:applitools/eyes.cypress.git","clone_url":"https://github.com/applitools/eyes.cypress.git","svn_url":"https://github.com/applitools/eyes.cypress","homepage":"","size":1298,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/applitools/eyes.cypress/pulls/3"},"html":{"href":"https://github.com/applitools/eyes.cypress/pull/3"},"issue":{"href":"https://api.github.com/repos/applitools/eyes.cypress/issues/3"},"comments":{"href":"https://api.github.com/repos/applitools/eyes.cypress/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/applitools/eyes.cypress/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/applitools/eyes.cypress/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/applitools/eyes.cypress/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/applitools/eyes.cypress/statuses/1a2d46d0f5fe7ca86d2a6ef20dd0c3e382267891"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"justmoon"}}