{"action":"created","comment":{"url":"https://api.github.com/repos/alec-deason/shitty-rogue/pulls/comments/227203320","pull_request_review_id":167188341,"id":227203320,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzIwMzMyMA==","diff_hunk":"@@ -95,44 +95,44 @@ game.o: /usr/include/bits/waitstatus.h /usr/include/bits/floatn.h\n game.o: /usr/include/bits/floatn-common.h /usr/include/sys/types.h","path":"Makefile","position":49,"original_position":10,"commit_id":"8c57bb3d2b6030f31d91c594be3f749cff95b2e2","original_commit_id":"5bead852bb7fac4e28ce29512a55f30c8fa2b03a","user":{"login":"efexgee","id":817639,"node_id":"MDQ6VXNlcjgxNzYzOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/817639?v=4","gravatar_id":"","url":"https://api.github.com/users/efexgee","html_url":"https://github.com/efexgee","followers_url":"https://api.github.com/users/efexgee/followers","following_url":"https://api.github.com/users/efexgee/following{/other_user}","gists_url":"https://api.github.com/users/efexgee/gists{/gist_id}","starred_url":"https://api.github.com/users/efexgee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efexgee/subscriptions","organizations_url":"https://api.github.com/users/efexgee/orgs","repos_url":"https://api.github.com/users/efexgee/repos","events_url":"https://api.github.com/users/efexgee/events{/privacy}","received_events_url":"https://api.github.com/users/efexgee/received_events","type":"User","site_admin":false},"body":"I think you have addressed this in your new Makefile","created_at":"2018-10-23T02:35:33Z","updated_at":"2018-10-23T02:35:33Z","html_url":"https://github.com/alec-deason/shitty-rogue/pull/10#discussion_r227203320","pull_request_url":"https://api.github.com/repos/alec-deason/shitty-rogue/pulls/10","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/alec-deason/shitty-rogue/pulls/comments/227203320"},"html":{"href":"https://github.com/alec-deason/shitty-rogue/pull/10#discussion_r227203320"},"pull_request":{"href":"https://api.github.com/repos/alec-deason/shitty-rogue/pulls/10"}},"in_reply_to_id":226814780},"pull_request":{"url":"https://api.github.com/repos/alec-deason/shitty-rogue/pulls/10","id":223829784,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzODI5Nzg0","html_url":"https://github.com/alec-deason/shitty-rogue/pull/10","diff_url":"https://github.com/alec-deason/shitty-rogue/pull/10.diff","patch_url":"https://github.com/alec-deason/shitty-rogue/pull/10.patch","issue_url":"https://api.github.com/repos/alec-deason/shitty-rogue/issues/10","number":10,"state":"open","locked":false,"title":"Small bites","user":{"login":"efexgee","id":817639,"node_id":"MDQ6VXNlcjgxNzYzOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/817639?v=4","gravatar_id":"","url":"https://api.github.com/users/efexgee","html_url":"https://github.com/efexgee","followers_url":"https://api.github.com/users/efexgee/followers","following_url":"https://api.github.com/users/efexgee/following{/other_user}","gists_url":"https://api.github.com/users/efexgee/gists{/gist_id}","starred_url":"https://api.github.com/users/efexgee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efexgee/subscriptions","organizations_url":"https://api.github.com/users/efexgee/orgs","repos_url":"https://api.github.com/users/efexgee/repos","events_url":"https://api.github.com/users/efexgee/events{/privacy}","received_events_url":"https://api.github.com/users/efexgee/received_events","type":"User","site_admin":false},"body":"This PR turned into a mess. Mixed two things together. Prolly not for merging, but take a look at the game_cfg directory with the .h files and tell me whether that's too much. I think those are going to fill up pretty good and separating them is a good idea.\r\n\r\nI left a couple of #defines in their own .h files because they seemed like the sort of thing you would want to tweak while working on the code. That sort of stuff should not be hidden away in the cfg directory.","created_at":"2018-10-18T05:31:09Z","updated_at":"2018-10-23T02:35:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84e189697b637a7de3738d0a887fdb8520575672","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alec-deason/shitty-rogue/pulls/10/commits","review_comments_url":"https://api.github.com/repos/alec-deason/shitty-rogue/pulls/10/comments","review_comment_url":"https://api.github.com/repos/alec-deason/shitty-rogue/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alec-deason/shitty-rogue/issues/10/comments","statuses_url":"https://api.github.com/repos/alec-deason/shitty-rogue/statuses/8c57bb3d2b6030f31d91c594be3f749cff95b2e2","head":{"label":"efexgee:small-bites","ref":"small-bites","sha":"8c57bb3d2b6030f31d91c594be3f749cff95b2e2","user":{"login":"efexgee","id":817639,"node_id":"MDQ6VXNlcjgxNzYzOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/817639?v=4","gravatar_id":"","url":"https://api.github.com/users/efexgee","html_url":"https://github.com/efexgee","followers_url":"https://api.github.com/users/efexgee/followers","following_url":"https://api.github.com/users/efexgee/following{/other_user}","gists_url":"https://api.github.com/users/efexgee/gists{/gist_id}","starred_url":"https://api.github.com/users/efexgee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efexgee/subscriptions","organizations_url":"https://api.github.com/users/efexgee/orgs","repos_url":"https://api.github.com/users/efexgee/repos","events_url":"https://api.github.com/users/efexgee/events{/privacy}","received_events_url":"https://api.github.com/users/efexgee/received_events","type":"User","site_admin":false},"repo":{"id":150029243,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAwMjkyNDM=","name":"rouge","full_name":"efexgee/rouge","private":false,"owner":{"login":"efexgee","id":817639,"node_id":"MDQ6VXNlcjgxNzYzOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/817639?v=4","gravatar_id":"","url":"https://api.github.com/users/efexgee","html_url":"https://github.com/efexgee","followers_url":"https://api.github.com/users/efexgee/followers","following_url":"https://api.github.com/users/efexgee/following{/other_user}","gists_url":"https://api.github.com/users/efexgee/gists{/gist_id}","starred_url":"https://api.github.com/users/efexgee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efexgee/subscriptions","organizations_url":"https://api.github.com/users/efexgee/orgs","repos_url":"https://api.github.com/users/efexgee/repos","events_url":"https://api.github.com/users/efexgee/events{/privacy}","received_events_url":"https://api.github.com/users/efexgee/received_events","type":"User","site_admin":false},"html_url":"https://github.com/efexgee/rouge","description":null,"fork":true,"url":"https://api.github.com/repos/efexgee/rouge","forks_url":"https://api.github.com/repos/efexgee/rouge/forks","keys_url":"https://api.github.com/repos/efexgee/rouge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/efexgee/rouge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/efexgee/rouge/teams","hooks_url":"https://api.github.com/repos/efexgee/rouge/hooks","issue_events_url":"https://api.github.com/repos/efexgee/rouge/issues/events{/number}","events_url":"https://api.github.com/repos/efexgee/rouge/events","assignees_url":"https://api.github.com/repos/efexgee/rouge/assignees{/user}","branches_url":"https://api.github.com/repos/efexgee/rouge/branches{/branch}","tags_url":"https://api.github.com/repos/efexgee/rouge/tags","blobs_url":"https://api.github.com/repos/efexgee/rouge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/efexgee/rouge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/efexgee/rouge/git/refs{/sha}","trees_url":"https://api.github.com/repos/efexgee/rouge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/efexgee/rouge/statuses/{sha}","languages_url":"https://api.github.com/repos/efexgee/rouge/languages","stargazers_url":"https://api.github.com/repos/efexgee/rouge/stargazers","contributors_url":"https://api.github.com/repos/efexgee/rouge/contributors","subscribers_url":"https://api.github.com/repos/efexgee/rouge/subscribers","subscription_url":"https://api.github.com/repos/efexgee/rouge/subscription","commits_url":"https://api.github.com/repos/efexgee/rouge/commits{/sha}","git_commits_url":"https://api.github.com/repos/efexgee/rouge/git/commits{/sha}","comments_url":"https://api.github.com/repos/efexgee/rouge/comments{/number}","issue_comment_url":"https://api.github.com/repos/efexgee/rouge/issues/comments{/number}","contents_url":"https://api.github.com/repos/efexgee/rouge/contents/{+path}","compare_url":"https://api.github.com/repos/efexgee/rouge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/efexgee/rouge/merges","archive_url":"https://api.github.com/repos/efexgee/rouge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/efexgee/rouge/downloads","issues_url":"https://api.github.com/repos/efexgee/rouge/issues{/number}","pulls_url":"https://api.github.com/repos/efexgee/rouge/pulls{/number}","milestones_url":"https://api.github.com/repos/efexgee/rouge/milestones{/number}","notifications_url":"https://api.github.com/repos/efexgee/rouge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/efexgee/rouge/labels{/name}","releases_url":"https://api.github.com/repos/efexgee/rouge/releases{/id}","deployments_url":"https://api.github.com/repos/efexgee/rouge/deployments","created_at":"2018-09-23T22:01:29Z","updated_at":"2018-10-16T03:20:15Z","pushed_at":"2018-10-21T20:58:47Z","git_url":"git://github.com/efexgee/rouge.git","ssh_url":"git@github.com:efexgee/rouge.git","clone_url":"https://github.com/efexgee/rouge.git","svn_url":"https://github.com/efexgee/rouge","homepage":null,"size":511,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alec-deason:master","ref":"master","sha":"da59c6ca66a4b346b2d13b62688ac5c3d9bb6f30","user":{"login":"alec-deason","id":419770,"node_id":"MDQ6VXNlcjQxOTc3MA==","avatar_url":"https://avatars3.githubusercontent.com/u/419770?v=4","gravatar_id":"","url":"https://api.github.com/users/alec-deason","html_url":"https://github.com/alec-deason","followers_url":"https://api.github.com/users/alec-deason/followers","following_url":"https://api.github.com/users/alec-deason/following{/other_user}","gists_url":"https://api.github.com/users/alec-deason/gists{/gist_id}","starred_url":"https://api.github.com/users/alec-deason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alec-deason/subscriptions","organizations_url":"https://api.github.com/users/alec-deason/orgs","repos_url":"https://api.github.com/users/alec-deason/repos","events_url":"https://api.github.com/users/alec-deason/events{/privacy}","received_events_url":"https://api.github.com/users/alec-deason/received_events","type":"User","site_admin":false},"repo":{"id":149949452,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk5NDk0NTI=","name":"shitty-rogue","full_name":"alec-deason/shitty-rogue","private":false,"owner":{"login":"alec-deason","id":419770,"node_id":"MDQ6VXNlcjQxOTc3MA==","avatar_url":"https://avatars3.githubusercontent.com/u/419770?v=4","gravatar_id":"","url":"https://api.github.com/users/alec-deason","html_url":"https://github.com/alec-deason","followers_url":"https://api.github.com/users/alec-deason/followers","following_url":"https://api.github.com/users/alec-deason/following{/other_user}","gists_url":"https://api.github.com/users/alec-deason/gists{/gist_id}","starred_url":"https://api.github.com/users/alec-deason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alec-deason/subscriptions","organizations_url":"https://api.github.com/users/alec-deason/orgs","repos_url":"https://api.github.com/users/alec-deason/repos","events_url":"https://api.github.com/users/alec-deason/events{/privacy}","received_events_url":"https://api.github.com/users/alec-deason/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alec-deason/shitty-rogue","description":null,"fork":false,"url":"https://api.github.com/repos/alec-deason/shitty-rogue","forks_url":"https://api.github.com/repos/alec-deason/shitty-rogue/forks","keys_url":"https://api.github.com/repos/alec-deason/shitty-rogue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alec-deason/shitty-rogue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alec-deason/shitty-rogue/teams","hooks_url":"https://api.github.com/repos/alec-deason/shitty-rogue/hooks","issue_events_url":"https://api.github.com/repos/alec-deason/shitty-rogue/issues/events{/number}","events_url":"https://api.github.com/repos/alec-deason/shitty-rogue/events","assignees_url":"https://api.github.com/repos/alec-deason/shitty-rogue/assignees{/user}","branches_url":"https://api.github.com/repos/alec-deason/shitty-rogue/branches{/branch}","tags_url":"https://api.github.com/repos/alec-deason/shitty-rogue/tags","blobs_url":"https://api.github.com/repos/alec-deason/shitty-rogue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alec-deason/shitty-rogue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alec-deason/shitty-rogue/git/refs{/sha}","trees_url":"https://api.github.com/repos/alec-deason/shitty-rogue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alec-deason/shitty-rogue/statuses/{sha}","languages_url":"https://api.github.com/repos/alec-deason/shitty-rogue/languages","stargazers_url":"https://api.github.com/repos/alec-deason/shitty-rogue/stargazers","contributors_url":"https://api.github.com/repos/alec-deason/shitty-rogue/contributors","subscribers_url":"https://api.github.com/repos/alec-deason/shitty-rogue/subscribers","subscription_url":"https://api.github.com/repos/alec-deason/shitty-rogue/subscription","commits_url":"https://api.github.com/repos/alec-deason/shitty-rogue/commits{/sha}","git_commits_url":"https://api.github.com/repos/alec-deason/shitty-rogue/git/commits{/sha}","comments_url":"https://api.github.com/repos/alec-deason/shitty-rogue/comments{/number}","issue_comment_url":"https://api.github.com/repos/alec-deason/shitty-rogue/issues/comments{/number}","contents_url":"https://api.github.com/repos/alec-deason/shitty-rogue/contents/{+path}","compare_url":"https://api.github.com/repos/alec-deason/shitty-rogue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alec-deason/shitty-rogue/merges","archive_url":"https://api.github.com/repos/alec-deason/shitty-rogue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alec-deason/shitty-rogue/downloads","issues_url":"https://api.github.com/repos/alec-deason/shitty-rogue/issues{/number}","pulls_url":"https://api.github.com/repos/alec-deason/shitty-rogue/pulls{/number}","milestones_url":"https://api.github.com/repos/alec-deason/shitty-rogue/milestones{/number}","notifications_url":"https://api.github.com/repos/alec-deason/shitty-rogue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alec-deason/shitty-rogue/labels{/name}","releases_url":"https://api.github.com/repos/alec-deason/shitty-rogue/releases{/id}","deployments_url":"https://api.github.com/repos/alec-deason/shitty-rogue/deployments","created_at":"2018-09-23T05:01:13Z","updated_at":"2018-10-17T03:39:49Z","pushed_at":"2018-10-21T20:58:49Z","git_url":"git://github.com/alec-deason/shitty-rogue.git","ssh_url":"git@github.com:alec-deason/shitty-rogue.git","clone_url":"https://github.com/alec-deason/shitty-rogue.git","svn_url":"https://github.com/alec-deason/shitty-rogue","homepage":null,"size":504,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alec-deason/shitty-rogue/pulls/10"},"html":{"href":"https://github.com/alec-deason/shitty-rogue/pull/10"},"issue":{"href":"https://api.github.com/repos/alec-deason/shitty-rogue/issues/10"},"comments":{"href":"https://api.github.com/repos/alec-deason/shitty-rogue/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/alec-deason/shitty-rogue/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/alec-deason/shitty-rogue/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alec-deason/shitty-rogue/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/alec-deason/shitty-rogue/statuses/8c57bb3d2b6030f31d91c594be3f749cff95b2e2"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"efexgee"}}