{"action":"created","comment":{"url":"https://api.github.com/repos/zalando/patroni/pulls/comments/218396033","pull_request_review_id":156322241,"id":218396033,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODM5NjAzMw==","diff_hunk":"@@ -1224,8 +1224,8 @@ def controldata(self):\n         if self._version_file_exists() and self.state != 'creating replica':\n             try:\n                 data = subprocess.check_output([self._pgcommand('pg_controldata'), self._data_dir],\n-                                               env={'LANG': 'C', 'LC_ALL': 'C', 'PATH': os.environ['PATH'],\n-                                               'SYSTEMROOT': os.environ['SYSTEMROOT']})\n+                                               env={'LANG': 'C', 'LC_ALL': 'C', 'PATH': os.environ.get('PATH'),\n+                                               'SYSTEMROOT': os.environ.get('SYSTEMROOT')})","path":"patroni/postgresql.py","position":null,"original_position":7,"commit_id":"3f5136d65a2c6f00d61ffb9f3abfb1f60f3c3584","original_commit_id":"3f5136d65a2c6f00d61ffb9f3abfb1f60f3c3584","user":{"login":"CyberDem0n","id":3407345,"node_id":"MDQ6VXNlcjM0MDczNDU=","avatar_url":"https://avatars2.githubusercontent.com/u/3407345?v=4","gravatar_id":"","url":"https://api.github.com/users/CyberDem0n","html_url":"https://github.com/CyberDem0n","followers_url":"https://api.github.com/users/CyberDem0n/followers","following_url":"https://api.github.com/users/CyberDem0n/following{/other_user}","gists_url":"https://api.github.com/users/CyberDem0n/gists{/gist_id}","starred_url":"https://api.github.com/users/CyberDem0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyberDem0n/subscriptions","organizations_url":"https://api.github.com/users/CyberDem0n/orgs","repos_url":"https://api.github.com/users/CyberDem0n/repos","events_url":"https://api.github.com/users/CyberDem0n/events{/privacy}","received_events_url":"https://api.github.com/users/CyberDem0n/received_events","type":"User","site_admin":false},"body":"The value of the environment variable must be a string, but it this case the value of `SYSTEMROOT` would be `None`, therefore it fails on travis.","created_at":"2018-09-18T11:36:58Z","updated_at":"2018-09-18T11:36:58Z","html_url":"https://github.com/zalando/patroni/pull/799#discussion_r218396033","pull_request_url":"https://api.github.com/repos/zalando/patroni/pulls/799","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zalando/patroni/pulls/comments/218396033"},"html":{"href":"https://github.com/zalando/patroni/pull/799#discussion_r218396033"},"pull_request":{"href":"https://api.github.com/repos/zalando/patroni/pulls/799"}}},"pull_request":{"url":"https://api.github.com/repos/zalando/patroni/pulls/799","id":212060187,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMDYwMTg3","html_url":"https://github.com/zalando/patroni/pull/799","diff_url":"https://github.com/zalando/patroni/pull/799.diff","patch_url":"https://github.com/zalando/patroni/pull/799.patch","issue_url":"https://api.github.com/repos/zalando/patroni/issues/799","number":799,"state":"open","locked":false,"title":"Support for Windows","user":{"login":"pashagolub","id":9463113,"node_id":"MDQ6VXNlcjk0NjMxMTM=","avatar_url":"https://avatars0.githubusercontent.com/u/9463113?v=4","gravatar_id":"","url":"https://api.github.com/users/pashagolub","html_url":"https://github.com/pashagolub","followers_url":"https://api.github.com/users/pashagolub/followers","following_url":"https://api.github.com/users/pashagolub/following{/other_user}","gists_url":"https://api.github.com/users/pashagolub/gists{/gist_id}","starred_url":"https://api.github.com/users/pashagolub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pashagolub/subscriptions","organizations_url":"https://api.github.com/users/pashagolub/orgs","repos_url":"https://api.github.com/users/pashagolub/repos","events_url":"https://api.github.com/users/pashagolub/events{/privacy}","received_events_url":"https://api.github.com/users/pashagolub/received_events","type":"User","site_admin":false},"body":"Changes for Windows support:\r\n\r\n- On Windows, signal() can only be called with SIGABRT, SIGFPE, SIGILL, SIGINT, SIGSEGV, SIGTERM, or SIGBREAK. A ValueError will be raised in any other case.\r\n\r\n- fcntl module from the standard library available only on Linux","created_at":"2018-08-30T12:24:07Z","updated_at":"2018-09-18T11:36:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad71fd167042c9ea4c4f50cd65958330c267d50e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zalando/patroni/pulls/799/commits","review_comments_url":"https://api.github.com/repos/zalando/patroni/pulls/799/comments","review_comment_url":"https://api.github.com/repos/zalando/patroni/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zalando/patroni/issues/799/comments","statuses_url":"https://api.github.com/repos/zalando/patroni/statuses/3f5136d65a2c6f00d61ffb9f3abfb1f60f3c3584","head":{"label":"pashagolub:master","ref":"master","sha":"3f5136d65a2c6f00d61ffb9f3abfb1f60f3c3584","user":{"login":"pashagolub","id":9463113,"node_id":"MDQ6VXNlcjk0NjMxMTM=","avatar_url":"https://avatars0.githubusercontent.com/u/9463113?v=4","gravatar_id":"","url":"https://api.github.com/users/pashagolub","html_url":"https://github.com/pashagolub","followers_url":"https://api.github.com/users/pashagolub/followers","following_url":"https://api.github.com/users/pashagolub/following{/other_user}","gists_url":"https://api.github.com/users/pashagolub/gists{/gist_id}","starred_url":"https://api.github.com/users/pashagolub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pashagolub/subscriptions","organizations_url":"https://api.github.com/users/pashagolub/orgs","repos_url":"https://api.github.com/users/pashagolub/repos","events_url":"https://api.github.com/users/pashagolub/events{/privacy}","received_events_url":"https://api.github.com/users/pashagolub/received_events","type":"User","site_admin":false},"repo":{"id":144008821,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQwMDg4MjE=","name":"patroni","full_name":"pashagolub/patroni","private":false,"owner":{"login":"pashagolub","id":9463113,"node_id":"MDQ6VXNlcjk0NjMxMTM=","avatar_url":"https://avatars0.githubusercontent.com/u/9463113?v=4","gravatar_id":"","url":"https://api.github.com/users/pashagolub","html_url":"https://github.com/pashagolub","followers_url":"https://api.github.com/users/pashagolub/followers","following_url":"https://api.github.com/users/pashagolub/following{/other_user}","gists_url":"https://api.github.com/users/pashagolub/gists{/gist_id}","starred_url":"https://api.github.com/users/pashagolub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pashagolub/subscriptions","organizations_url":"https://api.github.com/users/pashagolub/orgs","repos_url":"https://api.github.com/users/pashagolub/repos","events_url":"https://api.github.com/users/pashagolub/events{/privacy}","received_events_url":"https://api.github.com/users/pashagolub/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pashagolub/patroni","description":"A template for PostgreSQL High Availability with ZooKeeper, etcd, or Consul","fork":true,"url":"https://api.github.com/repos/pashagolub/patroni","forks_url":"https://api.github.com/repos/pashagolub/patroni/forks","keys_url":"https://api.github.com/repos/pashagolub/patroni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pashagolub/patroni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pashagolub/patroni/teams","hooks_url":"https://api.github.com/repos/pashagolub/patroni/hooks","issue_events_url":"https://api.github.com/repos/pashagolub/patroni/issues/events{/number}","events_url":"https://api.github.com/repos/pashagolub/patroni/events","assignees_url":"https://api.github.com/repos/pashagolub/patroni/assignees{/user}","branches_url":"https://api.github.com/repos/pashagolub/patroni/branches{/branch}","tags_url":"https://api.github.com/repos/pashagolub/patroni/tags","blobs_url":"https://api.github.com/repos/pashagolub/patroni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pashagolub/patroni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pashagolub/patroni/git/refs{/sha}","trees_url":"https://api.github.com/repos/pashagolub/patroni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pashagolub/patroni/statuses/{sha}","languages_url":"https://api.github.com/repos/pashagolub/patroni/languages","stargazers_url":"https://api.github.com/repos/pashagolub/patroni/stargazers","contributors_url":"https://api.github.com/repos/pashagolub/patroni/contributors","subscribers_url":"https://api.github.com/repos/pashagolub/patroni/subscribers","subscription_url":"https://api.github.com/repos/pashagolub/patroni/subscription","commits_url":"https://api.github.com/repos/pashagolub/patroni/commits{/sha}","git_commits_url":"https://api.github.com/repos/pashagolub/patroni/git/commits{/sha}","comments_url":"https://api.github.com/repos/pashagolub/patroni/comments{/number}","issue_comment_url":"https://api.github.com/repos/pashagolub/patroni/issues/comments{/number}","contents_url":"https://api.github.com/repos/pashagolub/patroni/contents/{+path}","compare_url":"https://api.github.com/repos/pashagolub/patroni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pashagolub/patroni/merges","archive_url":"https://api.github.com/repos/pashagolub/patroni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pashagolub/patroni/downloads","issues_url":"https://api.github.com/repos/pashagolub/patroni/issues{/number}","pulls_url":"https://api.github.com/repos/pashagolub/patroni/pulls{/number}","milestones_url":"https://api.github.com/repos/pashagolub/patroni/milestones{/number}","notifications_url":"https://api.github.com/repos/pashagolub/patroni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pashagolub/patroni/labels{/name}","releases_url":"https://api.github.com/repos/pashagolub/patroni/releases{/id}","deployments_url":"https://api.github.com/repos/pashagolub/patroni/deployments","created_at":"2018-08-08T12:12:56Z","updated_at":"2018-09-18T10:29:27Z","pushed_at":"2018-09-18T10:29:26Z","git_url":"git://github.com/pashagolub/patroni.git","ssh_url":"git@github.com:pashagolub/patroni.git","clone_url":"https://github.com/pashagolub/patroni.git","svn_url":"https://github.com/pashagolub/patroni","homepage":"","size":4006,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zalando:master","ref":"master","sha":"2e9cb412e4ca07864e4b43e64960476cabd6eabf","user":{"login":"zalando","id":1564818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjQ4MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1564818?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"repo":{"id":38744670,"node_id":"MDEwOlJlcG9zaXRvcnkzODc0NDY3MA==","name":"patroni","full_name":"zalando/patroni","private":false,"owner":{"login":"zalando","id":1564818,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjQ4MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1564818?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando","html_url":"https://github.com/zalando","followers_url":"https://api.github.com/users/zalando/followers","following_url":"https://api.github.com/users/zalando/following{/other_user}","gists_url":"https://api.github.com/users/zalando/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando/subscriptions","organizations_url":"https://api.github.com/users/zalando/orgs","repos_url":"https://api.github.com/users/zalando/repos","events_url":"https://api.github.com/users/zalando/events{/privacy}","received_events_url":"https://api.github.com/users/zalando/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/zalando/patroni","description":"A template for PostgreSQL High Availability with ZooKeeper, etcd, or Consul","fork":false,"url":"https://api.github.com/repos/zalando/patroni","forks_url":"https://api.github.com/repos/zalando/patroni/forks","keys_url":"https://api.github.com/repos/zalando/patroni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando/patroni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando/patroni/teams","hooks_url":"https://api.github.com/repos/zalando/patroni/hooks","issue_events_url":"https://api.github.com/repos/zalando/patroni/issues/events{/number}","events_url":"https://api.github.com/repos/zalando/patroni/events","assignees_url":"https://api.github.com/repos/zalando/patroni/assignees{/user}","branches_url":"https://api.github.com/repos/zalando/patroni/branches{/branch}","tags_url":"https://api.github.com/repos/zalando/patroni/tags","blobs_url":"https://api.github.com/repos/zalando/patroni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando/patroni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando/patroni/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando/patroni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando/patroni/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando/patroni/languages","stargazers_url":"https://api.github.com/repos/zalando/patroni/stargazers","contributors_url":"https://api.github.com/repos/zalando/patroni/contributors","subscribers_url":"https://api.github.com/repos/zalando/patroni/subscribers","subscription_url":"https://api.github.com/repos/zalando/patroni/subscription","commits_url":"https://api.github.com/repos/zalando/patroni/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando/patroni/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando/patroni/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando/patroni/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando/patroni/contents/{+path}","compare_url":"https://api.github.com/repos/zalando/patroni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando/patroni/merges","archive_url":"https://api.github.com/repos/zalando/patroni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando/patroni/downloads","issues_url":"https://api.github.com/repos/zalando/patroni/issues{/number}","pulls_url":"https://api.github.com/repos/zalando/patroni/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando/patroni/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando/patroni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando/patroni/labels{/name}","releases_url":"https://api.github.com/repos/zalando/patroni/releases{/id}","deployments_url":"https://api.github.com/repos/zalando/patroni/deployments","created_at":"2015-07-08T09:27:19Z","updated_at":"2018-09-16T18:53:05Z","pushed_at":"2018-09-18T10:29:27Z","git_url":"git://github.com/zalando/patroni.git","ssh_url":"git@github.com:zalando/patroni.git","clone_url":"https://github.com/zalando/patroni.git","svn_url":"https://github.com/zalando/patroni","homepage":"","size":3800,"stargazers_count":1915,"watchers_count":1915,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":190,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":190,"open_issues":61,"watchers":1915,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zalando/patroni/pulls/799"},"html":{"href":"https://github.com/zalando/patroni/pull/799"},"issue":{"href":"https://api.github.com/repos/zalando/patroni/issues/799"},"comments":{"href":"https://api.github.com/repos/zalando/patroni/issues/799/comments"},"review_comments":{"href":"https://api.github.com/repos/zalando/patroni/pulls/799/comments"},"review_comment":{"href":"https://api.github.com/repos/zalando/patroni/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zalando/patroni/pulls/799/commits"},"statuses":{"href":"https://api.github.com/repos/zalando/patroni/statuses/3f5136d65a2c6f00d61ffb9f3abfb1f60f3c3584"}},"author_association":"NONE"}}
{"actor":{"display_login":"CyberDem0n"}}