{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/61657","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/61657/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/61657/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/61657/events","html_url":"https://github.com/Microsoft/vscode/issues/61657","id":373242277,"node_id":"MDU6SXNzdWUzNzMyNDIyNzc=","number":61657,"title":"Monaco.d.ts generation needs improvements","user":{"login":"joaomoreno","id":22350,"node_id":"MDQ6VXNlcjIyMzUw","avatar_url":"https://avatars3.githubusercontent.com/u/22350?v=4","gravatar_id":"","url":"https://api.github.com/users/joaomoreno","html_url":"https://github.com/joaomoreno","followers_url":"https://api.github.com/users/joaomoreno/followers","following_url":"https://api.github.com/users/joaomoreno/following{/other_user}","gists_url":"https://api.github.com/users/joaomoreno/gists{/gist_id}","starred_url":"https://api.github.com/users/joaomoreno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaomoreno/subscriptions","organizations_url":"https://api.github.com/users/joaomoreno/orgs","repos_url":"https://api.github.com/users/joaomoreno/repos","events_url":"https://api.github.com/users/joaomoreno/events{/privacy}","received_events_url":"https://api.github.com/users/joaomoreno/received_events","type":"User","site_admin":false},"labels":[{"id":589241670,"node_id":"MDU6TGFiZWw1ODkyNDE2NzA=","url":"https://api.github.com/repos/Microsoft/vscode/labels/engineering","name":"engineering","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":{"login":"alexandrudima","id":5047891,"node_id":"MDQ6VXNlcjUwNDc4OTE=","avatar_url":"https://avatars3.githubusercontent.com/u/5047891?v=4","gravatar_id":"","url":"https://api.github.com/users/alexandrudima","html_url":"https://github.com/alexandrudima","followers_url":"https://api.github.com/users/alexandrudima/followers","following_url":"https://api.github.com/users/alexandrudima/following{/other_user}","gists_url":"https://api.github.com/users/alexandrudima/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandrudima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandrudima/subscriptions","organizations_url":"https://api.github.com/users/alexandrudima/orgs","repos_url":"https://api.github.com/users/alexandrudima/repos","events_url":"https://api.github.com/users/alexandrudima/events{/privacy}","received_events_url":"https://api.github.com/users/alexandrudima/received_events","type":"User","site_admin":false},"assignees":[{"login":"alexandrudima","id":5047891,"node_id":"MDQ6VXNlcjUwNDc4OTE=","avatar_url":"https://avatars3.githubusercontent.com/u/5047891?v=4","gravatar_id":"","url":"https://api.github.com/users/alexandrudima","html_url":"https://github.com/alexandrudima","followers_url":"https://api.github.com/users/alexandrudima/followers","following_url":"https://api.github.com/users/alexandrudima/following{/other_user}","gists_url":"https://api.github.com/users/alexandrudima/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandrudima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandrudima/subscriptions","organizations_url":"https://api.github.com/users/alexandrudima/orgs","repos_url":"https://api.github.com/users/alexandrudima/repos","events_url":"https://api.github.com/users/alexandrudima/events{/privacy}","received_events_url":"https://api.github.com/users/alexandrudima/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Microsoft/vscode/milestones/78","html_url":"https://github.com/Microsoft/vscode/milestone/78","labels_url":"https://api.github.com/repos/Microsoft/vscode/milestones/78/labels","id":3639536,"node_id":"MDk6TWlsZXN0b25lMzYzOTUzNg==","number":78,"title":"October 2018","description":"","creator":{"login":"Tyriar","id":2193314,"node_id":"MDQ6VXNlcjIxOTMzMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2193314?v=4","gravatar_id":"","url":"https://api.github.com/users/Tyriar","html_url":"https://github.com/Tyriar","followers_url":"https://api.github.com/users/Tyriar/followers","following_url":"https://api.github.com/users/Tyriar/following{/other_user}","gists_url":"https://api.github.com/users/Tyriar/gists{/gist_id}","starred_url":"https://api.github.com/users/Tyriar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tyriar/subscriptions","organizations_url":"https://api.github.com/users/Tyriar/orgs","repos_url":"https://api.github.com/users/Tyriar/repos","events_url":"https://api.github.com/users/Tyriar/events{/privacy}","received_events_url":"https://api.github.com/users/Tyriar/received_events","type":"User","site_admin":false},"open_issues":161,"closed_issues":368,"state":"open","created_at":"2018-09-10T14:15:00Z","updated_at":"2018-10-24T14:34:37Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2018-10-23T23:23:13Z","updated_at":"2018-10-24T14:55:26Z","closed_at":"2018-10-24T14:17:27Z","author_association":"MEMBER","body":"For one, it's incredibly annoying when jumping between branches. It seems that I **always** have to restart gulp when switching branches due to `monaco.d.ts` (and now `standaloneEnums.ts` too). We can surely do better here.\r\n\r\nAlso, `monaco.d.ts` generation is hardly the most important thing in our build, why are its messages in ALL CAPS? Lets just make them play nicely with all our other messages.\r\n\r\n<img width=\"1113\" alt=\"image\" src=\"https://user-images.githubusercontent.com/22350/47396494-e4d4c300-d6df-11e8-9ff4-d75a26fb11ab.png\">\r\n\r\nOn top of all of this, can we perhaps find another way to do this that doesn't involve committing computed changes? It seems to me that this would be much better implemented using a continuous build check."},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/432692847","html_url":"https://github.com/Microsoft/vscode/issues/61657#issuecomment-432692847","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/61657","id":432692847,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjY5Mjg0Nw==","user":{"login":"joaomoreno","id":22350,"node_id":"MDQ6VXNlcjIyMzUw","avatar_url":"https://avatars3.githubusercontent.com/u/22350?v=4","gravatar_id":"","url":"https://api.github.com/users/joaomoreno","html_url":"https://github.com/joaomoreno","followers_url":"https://api.github.com/users/joaomoreno/followers","following_url":"https://api.github.com/users/joaomoreno/following{/other_user}","gists_url":"https://api.github.com/users/joaomoreno/gists{/gist_id}","starred_url":"https://api.github.com/users/joaomoreno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaomoreno/subscriptions","organizations_url":"https://api.github.com/users/joaomoreno/orgs","repos_url":"https://api.github.com/users/joaomoreno/repos","events_url":"https://api.github.com/users/joaomoreno/events{/privacy}","received_events_url":"https://api.github.com/users/joaomoreno/received_events","type":"User","site_admin":false},"created_at":"2018-10-24T14:55:26Z","updated_at":"2018-10-24T14:55:26Z","author_association":"MEMBER","body":"In my mind, the question is really about why is `monaco.d.ts` checked in? I know you have answered this to me, and I'm always forgetting... Is it because there are tools which fetch it directly from our GH repo or because you want people to be aware when they are changing editor API by having a modification marked in Git?"}}
{"actor":{"display_login":"joaomoreno"}}