{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/py-evm/pulls/comments/231471722","pull_request_review_id":172442352,"id":231471722,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTQ3MTcyMg==","diff_hunk":"@@ -33,33 +46,42 @@ def get_message_for_signing(self):\n             ))\n \n     @classmethod\n-    def create_unsigned_transaction(cls, *, nonce, gas_price, gas, to, value, data):\n+    def create_unsigned_transaction(cls,         # type: ignore\n+                                    *,\n+                                    nonce: int,\n+                                    gas_price: int,\n+                                    gas: int,\n+                                    to: Address,\n+                                    value: int,\n+                                    data: bytes) -> BaseTransaction:\n         return SpuriousDragonUnsignedTransaction(nonce, gas_price, gas, to, value, data)\n \n     @property\n-    def chain_id(self):\n+    def chain_id(self) -> Optional[int]:\n         if is_eip_155_signed_transaction(self):\n             return extract_chain_id(self.v)\n         else:\n             return None\n \n     @property\n-    def v_min(self):\n+    def v_min(self) -> int:     # type: ignore\n         if is_eip_155_signed_transaction(self):\n             return 35 + (2 * self.chain_id)\n         else:\n             return 27\n \n     @property\n-    def v_max(self):\n+    def v_max(self) -> int:     # type: ignore","path":"eth/vm/forks/spurious_dragon/transactions.py","position":65,"original_position":65,"commit_id":"9a45ec0b011d12be3817228c60f303498222ebbb","original_commit_id":"ff977b3de494997d437baef634eef354b4ec8bf8","user":{"login":"cburgdorf","id":521109,"node_id":"MDQ6VXNlcjUyMTEwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/521109?v=4","gravatar_id":"","url":"https://api.github.com/users/cburgdorf","html_url":"https://github.com/cburgdorf","followers_url":"https://api.github.com/users/cburgdorf/followers","following_url":"https://api.github.com/users/cburgdorf/following{/other_user}","gists_url":"https://api.github.com/users/cburgdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/cburgdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cburgdorf/subscriptions","organizations_url":"https://api.github.com/users/cburgdorf/orgs","repos_url":"https://api.github.com/users/cburgdorf/repos","events_url":"https://api.github.com/users/cburgdorf/events{/privacy}","received_events_url":"https://api.github.com/users/cburgdorf/received_events","type":"User","site_admin":false},"body":"interested to learn about the reason for the ignore here and above","created_at":"2018-11-07T11:34:58Z","updated_at":"2018-11-07T11:46:45Z","html_url":"https://github.com/ethereum/py-evm/pull/1451#discussion_r231471722","pull_request_url":"https://api.github.com/repos/ethereum/py-evm/pulls/1451","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ethereum/py-evm/pulls/comments/231471722"},"html":{"href":"https://github.com/ethereum/py-evm/pull/1451#discussion_r231471722"},"pull_request":{"href":"https://api.github.com/repos/ethereum/py-evm/pulls/1451"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/py-evm/pulls/1451","id":228982488,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4OTgyNDg4","html_url":"https://github.com/ethereum/py-evm/pull/1451","diff_url":"https://github.com/ethereum/py-evm/pull/1451.diff","patch_url":"https://github.com/ethereum/py-evm/pull/1451.patch","issue_url":"https://api.github.com/repos/ethereum/py-evm/issues/1451","number":1451,"state":"open","locked":false,"title":"Enables eth.vm Type Hinting","user":{"login":"Bhargavasomu","id":15922456,"node_id":"MDQ6VXNlcjE1OTIyNDU2","avatar_url":"https://avatars0.githubusercontent.com/u/15922456?v=4","gravatar_id":"","url":"https://api.github.com/users/Bhargavasomu","html_url":"https://github.com/Bhargavasomu","followers_url":"https://api.github.com/users/Bhargavasomu/followers","following_url":"https://api.github.com/users/Bhargavasomu/following{/other_user}","gists_url":"https://api.github.com/users/Bhargavasomu/gists{/gist_id}","starred_url":"https://api.github.com/users/Bhargavasomu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bhargavasomu/subscriptions","organizations_url":"https://api.github.com/users/Bhargavasomu/orgs","repos_url":"https://api.github.com/users/Bhargavasomu/repos","events_url":"https://api.github.com/users/Bhargavasomu/events{/privacy}","received_events_url":"https://api.github.com/users/Bhargavasomu/received_events","type":"User","site_admin":false},"body":"### What was wrong?\r\nNeeded type hinting for `eth.vm` as part of #1398 \r\n\r\n\r\n### How was it fixed?\r\nAdding Type Hints to `eth.vm`\r\n\r\n\r\n#### Cute Animal Picture\r\n\r\n![put a cute animal picture link inside the parentheses](https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcTqevhT_DUZJTEejxLke3VC5Su67JlWU8lAj6nbtLDeFlNjKmdS)\r\n","created_at":"2018-11-07T10:32:26Z","updated_at":"2018-11-07T11:46:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e98336b2fe6011e3fc09e241e89580c662cec034","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/py-evm/pulls/1451/commits","review_comments_url":"https://api.github.com/repos/ethereum/py-evm/pulls/1451/comments","review_comment_url":"https://api.github.com/repos/ethereum/py-evm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/py-evm/issues/1451/comments","statuses_url":"https://api.github.com/repos/ethereum/py-evm/statuses/9a45ec0b011d12be3817228c60f303498222ebbb","head":{"label":"Bhargavasomu:eth_vm_type_hinting","ref":"eth_vm_type_hinting","sha":"9a45ec0b011d12be3817228c60f303498222ebbb","user":{"login":"Bhargavasomu","id":15922456,"node_id":"MDQ6VXNlcjE1OTIyNDU2","avatar_url":"https://avatars0.githubusercontent.com/u/15922456?v=4","gravatar_id":"","url":"https://api.github.com/users/Bhargavasomu","html_url":"https://github.com/Bhargavasomu","followers_url":"https://api.github.com/users/Bhargavasomu/followers","following_url":"https://api.github.com/users/Bhargavasomu/following{/other_user}","gists_url":"https://api.github.com/users/Bhargavasomu/gists{/gist_id}","starred_url":"https://api.github.com/users/Bhargavasomu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bhargavasomu/subscriptions","organizations_url":"https://api.github.com/users/Bhargavasomu/orgs","repos_url":"https://api.github.com/users/Bhargavasomu/repos","events_url":"https://api.github.com/users/Bhargavasomu/events{/privacy}","received_events_url":"https://api.github.com/users/Bhargavasomu/received_events","type":"User","site_admin":false},"repo":{"id":151619944,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE2MTk5NDQ=","name":"py-evm","full_name":"Bhargavasomu/py-evm","private":false,"owner":{"login":"Bhargavasomu","id":15922456,"node_id":"MDQ6VXNlcjE1OTIyNDU2","avatar_url":"https://avatars0.githubusercontent.com/u/15922456?v=4","gravatar_id":"","url":"https://api.github.com/users/Bhargavasomu","html_url":"https://github.com/Bhargavasomu","followers_url":"https://api.github.com/users/Bhargavasomu/followers","following_url":"https://api.github.com/users/Bhargavasomu/following{/other_user}","gists_url":"https://api.github.com/users/Bhargavasomu/gists{/gist_id}","starred_url":"https://api.github.com/users/Bhargavasomu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bhargavasomu/subscriptions","organizations_url":"https://api.github.com/users/Bhargavasomu/orgs","repos_url":"https://api.github.com/users/Bhargavasomu/repos","events_url":"https://api.github.com/users/Bhargavasomu/events{/privacy}","received_events_url":"https://api.github.com/users/Bhargavasomu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Bhargavasomu/py-evm","description":"A Python implementation of the Ethereum Virtual Machine","fork":true,"url":"https://api.github.com/repos/Bhargavasomu/py-evm","forks_url":"https://api.github.com/repos/Bhargavasomu/py-evm/forks","keys_url":"https://api.github.com/repos/Bhargavasomu/py-evm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bhargavasomu/py-evm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bhargavasomu/py-evm/teams","hooks_url":"https://api.github.com/repos/Bhargavasomu/py-evm/hooks","issue_events_url":"https://api.github.com/repos/Bhargavasomu/py-evm/issues/events{/number}","events_url":"https://api.github.com/repos/Bhargavasomu/py-evm/events","assignees_url":"https://api.github.com/repos/Bhargavasomu/py-evm/assignees{/user}","branches_url":"https://api.github.com/repos/Bhargavasomu/py-evm/branches{/branch}","tags_url":"https://api.github.com/repos/Bhargavasomu/py-evm/tags","blobs_url":"https://api.github.com/repos/Bhargavasomu/py-evm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bhargavasomu/py-evm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bhargavasomu/py-evm/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bhargavasomu/py-evm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bhargavasomu/py-evm/statuses/{sha}","languages_url":"https://api.github.com/repos/Bhargavasomu/py-evm/languages","stargazers_url":"https://api.github.com/repos/Bhargavasomu/py-evm/stargazers","contributors_url":"https://api.github.com/repos/Bhargavasomu/py-evm/contributors","subscribers_url":"https://api.github.com/repos/Bhargavasomu/py-evm/subscribers","subscription_url":"https://api.github.com/repos/Bhargavasomu/py-evm/subscription","commits_url":"https://api.github.com/repos/Bhargavasomu/py-evm/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bhargavasomu/py-evm/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bhargavasomu/py-evm/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bhargavasomu/py-evm/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bhargavasomu/py-evm/contents/{+path}","compare_url":"https://api.github.com/repos/Bhargavasomu/py-evm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bhargavasomu/py-evm/merges","archive_url":"https://api.github.com/repos/Bhargavasomu/py-evm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bhargavasomu/py-evm/downloads","issues_url":"https://api.github.com/repos/Bhargavasomu/py-evm/issues{/number}","pulls_url":"https://api.github.com/repos/Bhargavasomu/py-evm/pulls{/number}","milestones_url":"https://api.github.com/repos/Bhargavasomu/py-evm/milestones{/number}","notifications_url":"https://api.github.com/repos/Bhargavasomu/py-evm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bhargavasomu/py-evm/labels{/name}","releases_url":"https://api.github.com/repos/Bhargavasomu/py-evm/releases{/id}","deployments_url":"https://api.github.com/repos/Bhargavasomu/py-evm/deployments","created_at":"2018-10-04T18:44:24Z","updated_at":"2018-10-13T14:54:02Z","pushed_at":"2018-11-07T11:37:43Z","git_url":"git://github.com/Bhargavasomu/py-evm.git","ssh_url":"git@github.com:Bhargavasomu/py-evm.git","clone_url":"https://github.com/Bhargavasomu/py-evm.git","svn_url":"https://github.com/Bhargavasomu/py-evm","homepage":"https://trinity.ethereum.org/","size":5855,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"2a65ca406fb08a07c9ed31048b6d5f80f897e53b","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":77478378,"node_id":"MDEwOlJlcG9zaXRvcnk3NzQ3ODM3OA==","name":"py-evm","full_name":"ethereum/py-evm","private":false,"owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethereum/py-evm","description":"A Python implementation of the Ethereum Virtual Machine","fork":false,"url":"https://api.github.com/repos/ethereum/py-evm","forks_url":"https://api.github.com/repos/ethereum/py-evm/forks","keys_url":"https://api.github.com/repos/ethereum/py-evm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/py-evm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/py-evm/teams","hooks_url":"https://api.github.com/repos/ethereum/py-evm/hooks","issue_events_url":"https://api.github.com/repos/ethereum/py-evm/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/py-evm/events","assignees_url":"https://api.github.com/repos/ethereum/py-evm/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/py-evm/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/py-evm/tags","blobs_url":"https://api.github.com/repos/ethereum/py-evm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/py-evm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/py-evm/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/py-evm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/py-evm/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/py-evm/languages","stargazers_url":"https://api.github.com/repos/ethereum/py-evm/stargazers","contributors_url":"https://api.github.com/repos/ethereum/py-evm/contributors","subscribers_url":"https://api.github.com/repos/ethereum/py-evm/subscribers","subscription_url":"https://api.github.com/repos/ethereum/py-evm/subscription","commits_url":"https://api.github.com/repos/ethereum/py-evm/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/py-evm/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/py-evm/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/py-evm/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/py-evm/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/py-evm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/py-evm/merges","archive_url":"https://api.github.com/repos/ethereum/py-evm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/py-evm/downloads","issues_url":"https://api.github.com/repos/ethereum/py-evm/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/py-evm/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/py-evm/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/py-evm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/py-evm/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/py-evm/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/py-evm/deployments","created_at":"2016-12-27T19:36:00Z","updated_at":"2018-11-07T01:50:10Z","pushed_at":"2018-11-07T11:37:44Z","git_url":"git://github.com/ethereum/py-evm.git","ssh_url":"git@github.com:ethereum/py-evm.git","clone_url":"https://github.com/ethereum/py-evm.git","svn_url":"https://github.com/ethereum/py-evm","homepage":"https://trinity.ethereum.org/","size":5927,"stargazers_count":718,"watchers_count":718,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":316,"mirror_url":null,"archived":false,"open_issues_count":129,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":316,"open_issues":129,"watchers":718,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/py-evm/pulls/1451"},"html":{"href":"https://github.com/ethereum/py-evm/pull/1451"},"issue":{"href":"https://api.github.com/repos/ethereum/py-evm/issues/1451"},"comments":{"href":"https://api.github.com/repos/ethereum/py-evm/issues/1451/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/py-evm/pulls/1451/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/py-evm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/py-evm/pulls/1451/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/py-evm/statuses/9a45ec0b011d12be3817228c60f303498222ebbb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cburgdorf"}}