{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/211792920","pull_request_review_id":148289690,"id":211792920,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTc5MjkyMA==","diff_hunk":"@@ -2324,7 +2327,7 @@ declare namespace Office {\n          * @param options Provides options to determine which event handler or handlers are removed.\n          * @param callback Optional. A function that is invoked when the callback returns, whose only parameter is of type {@link Office.AsyncResult}.\n          */\n-        removeHandlerAsync(eventType: Office.EventType, options?: RemoveHandlerOptions, callback?: (result: AsyncResult) => void): void;\n+        removeHandlerAsync(eventType: Office.EventType, options?: RemoveHandlerOptions, callback?: (result: AsyncResult<undefined>) => void): void;","path":"types/office-js/index.d.ts","position":93,"original_position":93,"commit_id":"8dcdf28b826c634114ba53d5a645bfcda49d8198","original_commit_id":"77ce4a023bbf41524098d198593297cb85a44b45","user":{"login":"Rick-Kirkham","id":9088056,"node_id":"MDQ6VXNlcjkwODgwNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/9088056?v=4","gravatar_id":"","url":"https://api.github.com/users/Rick-Kirkham","html_url":"https://github.com/Rick-Kirkham","followers_url":"https://api.github.com/users/Rick-Kirkham/followers","following_url":"https://api.github.com/users/Rick-Kirkham/following{/other_user}","gists_url":"https://api.github.com/users/Rick-Kirkham/gists{/gist_id}","starred_url":"https://api.github.com/users/Rick-Kirkham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rick-Kirkham/subscriptions","organizations_url":"https://api.github.com/users/Rick-Kirkham/orgs","repos_url":"https://api.github.com/users/Rick-Kirkham/repos","events_url":"https://api.github.com/users/Rick-Kirkham/events{/privacy}","received_events_url":"https://api.github.com/users/Rick-Kirkham/received_events","type":"User","site_admin":false},"body":"Why undefined? Do we know AsyncResult.value is always undefined when there's a callback to removeHandlerAsync?","created_at":"2018-08-21T23:43:00Z","updated_at":"2018-08-21T23:45:46Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28277#discussion_r211792920","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28277","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/211792920"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28277#discussion_r211792920"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28277"}}},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28277","id":209944803,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5OTQ0ODAz","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28277","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28277.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28277.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28277","number":28277,"state":"open","locked":false,"title":"[office-js] Making AsyncResult.value generic","user":{"login":"AlexJerabek","id":38896772,"node_id":"MDQ6VXNlcjM4ODk2Nzcy","avatar_url":"https://avatars3.githubusercontent.com/u/38896772?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexJerabek","html_url":"https://github.com/AlexJerabek","followers_url":"https://api.github.com/users/AlexJerabek/followers","following_url":"https://api.github.com/users/AlexJerabek/following{/other_user}","gists_url":"https://api.github.com/users/AlexJerabek/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexJerabek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexJerabek/subscriptions","organizations_url":"https://api.github.com/users/AlexJerabek/orgs","repos_url":"https://api.github.com/users/AlexJerabek/repos","events_url":"https://api.github.com/users/AlexJerabek/events{/privacy}","received_events_url":"https://api.github.com/users/AlexJerabek/received_events","type":"User","site_admin":false},"body":"Please fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [ ] Add or edit tests to reflect the change. (Run with `npm test`.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\n\r\nIf changing an existing definition:\r\n- [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://dev.office.com/reference/add-ins/shared/asyncresult\r\n- [x] Increase the version number in the header if appropriate.\r\n- [x] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.","created_at":"2018-08-21T20:22:33Z","updated_at":"2018-08-21T23:45:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"817bfee4dbd56a80a1cf535c04a3218dd3537ec8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":798737478,"node_id":"MDU6TGFiZWw3OTg3Mzc0Nzg=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Author%20is%20Owner","name":"Author is Owner","color":"6fede0","default":false},{"id":397523192,"node_id":"MDU6TGFiZWwzOTc1MjMxOTI=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Awaiting%20reviewer%20feedback","name":"Awaiting reviewer feedback","color":"0052cc","default":false},{"id":583294474,"node_id":"MDU6TGFiZWw1ODMyOTQ0NzQ=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Has%20Merge%20Conflict","name":"Has Merge Conflict","color":"b60205","default":false},{"id":646659088,"node_id":"MDU6TGFiZWw2NDY2NTkwODg=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Where%20is%20Travis?","name":"Where is Travis?","color":"EEEEEE","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28277/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28277/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28277/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/8dcdf28b826c634114ba53d5a645bfcda49d8198","head":{"label":"AlexJerabek:AlexJ-AsyncResultType","ref":"AlexJ-AsyncResultType","sha":"8dcdf28b826c634114ba53d5a645bfcda49d8198","user":{"login":"AlexJerabek","id":38896772,"node_id":"MDQ6VXNlcjM4ODk2Nzcy","avatar_url":"https://avatars3.githubusercontent.com/u/38896772?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexJerabek","html_url":"https://github.com/AlexJerabek","followers_url":"https://api.github.com/users/AlexJerabek/followers","following_url":"https://api.github.com/users/AlexJerabek/following{/other_user}","gists_url":"https://api.github.com/users/AlexJerabek/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexJerabek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexJerabek/subscriptions","organizations_url":"https://api.github.com/users/AlexJerabek/orgs","repos_url":"https://api.github.com/users/AlexJerabek/repos","events_url":"https://api.github.com/users/AlexJerabek/events{/privacy}","received_events_url":"https://api.github.com/users/AlexJerabek/received_events","type":"User","site_admin":false},"repo":{"id":135346154,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUzNDYxNTQ=","name":"DefinitelyTyped","full_name":"AlexJerabek/DefinitelyTyped","owner":{"login":"AlexJerabek","id":38896772,"node_id":"MDQ6VXNlcjM4ODk2Nzcy","avatar_url":"https://avatars3.githubusercontent.com/u/38896772?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexJerabek","html_url":"https://github.com/AlexJerabek","followers_url":"https://api.github.com/users/AlexJerabek/followers","following_url":"https://api.github.com/users/AlexJerabek/following{/other_user}","gists_url":"https://api.github.com/users/AlexJerabek/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexJerabek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexJerabek/subscriptions","organizations_url":"https://api.github.com/users/AlexJerabek/orgs","repos_url":"https://api.github.com/users/AlexJerabek/repos","events_url":"https://api.github.com/users/AlexJerabek/events{/privacy}","received_events_url":"https://api.github.com/users/AlexJerabek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlexJerabek/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped","forks_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/AlexJerabek/DefinitelyTyped/deployments","created_at":"2018-05-29T19:54:38Z","updated_at":"2018-08-21T23:02:37Z","pushed_at":"2018-08-21T23:44:17Z","git_url":"git://github.com/AlexJerabek/DefinitelyTyped.git","ssh_url":"git@github.com:AlexJerabek/DefinitelyTyped.git","clone_url":"https://github.com/AlexJerabek/DefinitelyTyped.git","svn_url":"https://github.com/AlexJerabek/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":348533,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"b77ae9d43b3df2caf0e23757d6b8bc96c3e8f1b9","user":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"node_id":"MDEwOlJlcG9zaXRvcnk2MDkzMzE2","name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","owner":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2018-08-21T20:58:56Z","pushed_at":"2018-08-21T23:44:23Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":349535,"stargazers_count":17021,"watchers_count":17021,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14212,"mirror_url":null,"archived":false,"open_issues_count":2359,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":14212,"open_issues":2359,"watchers":17021,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28277"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28277"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28277"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28277/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28277/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28277/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/8dcdf28b826c634114ba53d5a645bfcda49d8198"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Rick-Kirkham"}}