{"action":"closed","number":5619,"pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/5619","id":173596015,"html_url":"https://github.com/pytorch/pytorch/pull/5619","diff_url":"https://github.com/pytorch/pytorch/pull/5619.diff","patch_url":"https://github.com/pytorch/pytorch/pull/5619.patch","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/5619","number":5619,"state":"closed","locked":false,"title":"Prefix DataLoaderIter with underscore to discourage subclassing","user":{"login":"SsnL","id":5674597,"avatar_url":"https://avatars2.githubusercontent.com/u/5674597?v=4","gravatar_id":"","url":"https://api.github.com/users/SsnL","html_url":"https://github.com/SsnL","followers_url":"https://api.github.com/users/SsnL/followers","following_url":"https://api.github.com/users/SsnL/following{/other_user}","gists_url":"https://api.github.com/users/SsnL/gists{/gist_id}","starred_url":"https://api.github.com/users/SsnL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SsnL/subscriptions","organizations_url":"https://api.github.com/users/SsnL/orgs","repos_url":"https://api.github.com/users/SsnL/repos","events_url":"https://api.github.com/users/SsnL/events{/privacy}","received_events_url":"https://api.github.com/users/SsnL/received_events","type":"User","site_admin":false},"body":"Discourage subclassing `DataLoaderIter` so that errors like #5430 hopefully won't happen as often.\r\n\r\n@apaszke ","created_at":"2018-03-07T22:47:32Z","updated_at":"2018-03-08T10:09:51Z","closed_at":"2018-03-08T10:09:51Z","merged_at":"2018-03-08T10:09:51Z","merge_commit_sha":"04461fa28953f17f16791f615aa77eb5d10d5abc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/pytorch/pulls/5619/commits","review_comments_url":"https://api.github.com/repos/pytorch/pytorch/pulls/5619/comments","review_comment_url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/5619/comments","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/00a6e0ea0968b86cdc1b1d08871c2ed5ebaba357","head":{"label":"SsnL:dlset","ref":"dlset","sha":"00a6e0ea0968b86cdc1b1d08871c2ed5ebaba357","user":{"login":"SsnL","id":5674597,"avatar_url":"https://avatars2.githubusercontent.com/u/5674597?v=4","gravatar_id":"","url":"https://api.github.com/users/SsnL","html_url":"https://github.com/SsnL","followers_url":"https://api.github.com/users/SsnL/followers","following_url":"https://api.github.com/users/SsnL/following{/other_user}","gists_url":"https://api.github.com/users/SsnL/gists{/gist_id}","starred_url":"https://api.github.com/users/SsnL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SsnL/subscriptions","organizations_url":"https://api.github.com/users/SsnL/orgs","repos_url":"https://api.github.com/users/SsnL/repos","events_url":"https://api.github.com/users/SsnL/events{/privacy}","received_events_url":"https://api.github.com/users/SsnL/received_events","type":"User","site_admin":false},"repo":{"id":103305558,"name":"pytorch","full_name":"SsnL/pytorch","owner":{"login":"SsnL","id":5674597,"avatar_url":"https://avatars2.githubusercontent.com/u/5674597?v=4","gravatar_id":"","url":"https://api.github.com/users/SsnL","html_url":"https://github.com/SsnL","followers_url":"https://api.github.com/users/SsnL/followers","following_url":"https://api.github.com/users/SsnL/following{/other_user}","gists_url":"https://api.github.com/users/SsnL/gists{/gist_id}","starred_url":"https://api.github.com/users/SsnL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SsnL/subscriptions","organizations_url":"https://api.github.com/users/SsnL/orgs","repos_url":"https://api.github.com/users/SsnL/repos","events_url":"https://api.github.com/users/SsnL/events{/privacy}","received_events_url":"https://api.github.com/users/SsnL/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SsnL/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/SsnL/pytorch","forks_url":"https://api.github.com/repos/SsnL/pytorch/forks","keys_url":"https://api.github.com/repos/SsnL/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SsnL/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SsnL/pytorch/teams","hooks_url":"https://api.github.com/repos/SsnL/pytorch/hooks","issue_events_url":"https://api.github.com/repos/SsnL/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/SsnL/pytorch/events","assignees_url":"https://api.github.com/repos/SsnL/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/SsnL/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/SsnL/pytorch/tags","blobs_url":"https://api.github.com/repos/SsnL/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SsnL/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SsnL/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/SsnL/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SsnL/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/SsnL/pytorch/languages","stargazers_url":"https://api.github.com/repos/SsnL/pytorch/stargazers","contributors_url":"https://api.github.com/repos/SsnL/pytorch/contributors","subscribers_url":"https://api.github.com/repos/SsnL/pytorch/subscribers","subscription_url":"https://api.github.com/repos/SsnL/pytorch/subscription","commits_url":"https://api.github.com/repos/SsnL/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/SsnL/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/SsnL/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/SsnL/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/SsnL/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/SsnL/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SsnL/pytorch/merges","archive_url":"https://api.github.com/repos/SsnL/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SsnL/pytorch/downloads","issues_url":"https://api.github.com/repos/SsnL/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/SsnL/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/SsnL/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/SsnL/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SsnL/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/SsnL/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/SsnL/pytorch/deployments","created_at":"2017-09-12T18:13:43Z","updated_at":"2017-09-12T18:13:49Z","pushed_at":"2018-03-08T01:53:35Z","git_url":"git://github.com/SsnL/pytorch.git","ssh_url":"git@github.com:SsnL/pytorch.git","clone_url":"https://github.com/SsnL/pytorch.git","svn_url":"https://github.com/SsnL/pytorch","homepage":"http://pytorch.org","size":23979,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"9ebfece900c2e4c09684393538c94f46f1bcfe1b","user":{"login":"pytorch","id":21003710,"avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"name":"pytorch","full_name":"pytorch/pytorch","owner":{"login":"pytorch","id":21003710,"avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2018-03-08T09:47:17Z","pushed_at":"2018-03-08T10:09:51Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"http://pytorch.org","size":24153,"stargazers_count":12773,"watchers_count":12773,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2716,"mirror_url":null,"archived":false,"open_issues_count":807,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2716,"open_issues":807,"watchers":12773,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/5619"},"html":{"href":"https://github.com/pytorch/pytorch/pull/5619"},"issue":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/5619"},"comments":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/5619/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/5619/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/5619/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/pytorch/statuses/00a6e0ea0968b86cdc1b1d08871c2ed5ebaba357"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"apaszke","id":4583066,"avatar_url":"https://avatars3.githubusercontent.com/u/4583066?v=4","gravatar_id":"","url":"https://api.github.com/users/apaszke","html_url":"https://github.com/apaszke","followers_url":"https://api.github.com/users/apaszke/followers","following_url":"https://api.github.com/users/apaszke/following{/other_user}","gists_url":"https://api.github.com/users/apaszke/gists{/gist_id}","starred_url":"https://api.github.com/users/apaszke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apaszke/subscriptions","organizations_url":"https://api.github.com/users/apaszke/orgs","repos_url":"https://api.github.com/users/apaszke/repos","events_url":"https://api.github.com/users/apaszke/events{/privacy}","received_events_url":"https://api.github.com/users/apaszke/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":5,"changed_files":2}}
{"actor":{"display_login":"apaszke"}}