{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/22967","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/22967/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/22967/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/22967/events","html_url":"https://github.com/mantidproject/mantid/pull/22967","id":341898892,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxOTI1NDA0","number":22967,"title":"Remove newline chars in the script builder when writing history","user":{"login":"DavidFair","id":1817032,"node_id":"MDQ6VXNlcjE4MTcwMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/1817032?v=4","gravatar_id":"","url":"https://api.github.com/users/DavidFair","html_url":"https://github.com/DavidFair","followers_url":"https://api.github.com/users/DavidFair/followers","following_url":"https://api.github.com/users/DavidFair/following{/other_user}","gists_url":"https://api.github.com/users/DavidFair/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidFair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidFair/subscriptions","organizations_url":"https://api.github.com/users/DavidFair/orgs","repos_url":"https://api.github.com/users/DavidFair/repos","events_url":"https://api.github.com/users/DavidFair/events{/privacy}","received_events_url":"https://api.github.com/users/DavidFair/received_events","type":"User","site_admin":false},"labels":[{"id":177607615,"node_id":"MDU6TGFiZWwxNzc2MDc2MTU=","url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Framework","name":"Component: Framework","color":"009800","default":false},{"id":40046083,"node_id":"MDU6TGFiZWw0MDA0NjA4Mw==","url":"https://api.github.com/repos/mantidproject/mantid/labels/Misc:%20Bug","name":"Misc: Bug","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"keeeto","id":3697636,"node_id":"MDQ6VXNlcjM2OTc2MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/3697636?v=4","gravatar_id":"","url":"https://api.github.com/users/keeeto","html_url":"https://github.com/keeeto","followers_url":"https://api.github.com/users/keeeto/followers","following_url":"https://api.github.com/users/keeeto/following{/other_user}","gists_url":"https://api.github.com/users/keeeto/gists{/gist_id}","starred_url":"https://api.github.com/users/keeeto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keeeto/subscriptions","organizations_url":"https://api.github.com/users/keeeto/orgs","repos_url":"https://api.github.com/users/keeeto/repos","events_url":"https://api.github.com/users/keeeto/events{/privacy}","received_events_url":"https://api.github.com/users/keeeto/received_events","type":"User","site_admin":false},"assignees":[{"login":"keeeto","id":3697636,"node_id":"MDQ6VXNlcjM2OTc2MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/3697636?v=4","gravatar_id":"","url":"https://api.github.com/users/keeeto","html_url":"https://github.com/keeeto","followers_url":"https://api.github.com/users/keeeto/followers","following_url":"https://api.github.com/users/keeeto/following{/other_user}","gists_url":"https://api.github.com/users/keeeto/gists{/gist_id}","starred_url":"https://api.github.com/users/keeeto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keeeto/subscriptions","organizations_url":"https://api.github.com/users/keeeto/orgs","repos_url":"https://api.github.com/users/keeeto/repos","events_url":"https://api.github.com/users/keeeto/events{/privacy}","received_events_url":"https://api.github.com/users/keeeto/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/67","html_url":"https://github.com/mantidproject/mantid/milestone/67","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/67/labels","id":3113719,"node_id":"MDk6TWlsZXN0b25lMzExMzcxOQ==","number":67,"title":"Release 3.13","description":"Code Freeze: 29th June\r\nBeta Test: 3rd-17th July","creator":{"login":"NickDraper","id":1017173,"node_id":"MDQ6VXNlcjEwMTcxNzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1017173?v=4","gravatar_id":"","url":"https://api.github.com/users/NickDraper","html_url":"https://github.com/NickDraper","followers_url":"https://api.github.com/users/NickDraper/followers","following_url":"https://api.github.com/users/NickDraper/following{/other_user}","gists_url":"https://api.github.com/users/NickDraper/gists{/gist_id}","starred_url":"https://api.github.com/users/NickDraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickDraper/subscriptions","organizations_url":"https://api.github.com/users/NickDraper/orgs","repos_url":"https://api.github.com/users/NickDraper/repos","events_url":"https://api.github.com/users/NickDraper/events{/privacy}","received_events_url":"https://api.github.com/users/NickDraper/received_events","type":"User","site_admin":false},"open_issues":26,"closed_issues":617,"state":"open","created_at":"2018-02-13T15:37:12Z","updated_at":"2018-07-17T12:31:57Z","due_on":"2018-07-23T07:00:00Z","closed_at":null},"comments":0,"created_at":"2018-07-17T12:31:57Z","updated_at":"2018-07-17T12:49:36Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/22967","html_url":"https://github.com/mantidproject/mantid/pull/22967","diff_url":"https://github.com/mantidproject/mantid/pull/22967.diff","patch_url":"https://github.com/mantidproject/mantid/pull/22967.patch"},"body":"**Description of work.**\r\nRemoves newline characters in the script builder if they exist, for example in a shape geometry. \r\n\r\n**To test:**\r\n- Run the unit tests\r\n- Run the following script which will create a log entry for `SetSample` that has newline chars\r\n```\r\nfrom isis_powder import Polaris\r\n\r\nconfig_file_path = r\"/Users/keithbutler/Mantid/RecoveryMode/TestScripts/Polaris/polaris_config_example.yaml\"\r\npolaris_example = Polaris(config_file=config_file_path,\r\n                          user_name=\"Mantid\")                         \r\npolaris_example.create_vanadium( mode=\"Rietveld\", do_absorb_corrections=True, \r\n                                first_cycle_run_no=98531, multiple_scattering=False)\r\n```\r\n\r\n- Crash Mantid and check that the SetSample entry does not split across multiple lines. \r\n- Note: SetSample will not work due to serialising a Python dictionary incorrectly\r\n\r\nFixes #22898\r\n\r\nDoes this update require release notes?\r\n- [ ] Yes\r\n- [x] No\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)?\r\n- [ ] Are the unit tests small and test the class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] Do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant (user and developer) documentation been added/updated?\r\n\r\nDoes everything look good? Mark the review as **Approve**. A member of `@mantidproject/gatekeepers` will take care of it.\r\n"},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/405570135","html_url":"https://github.com/mantidproject/mantid/pull/22967#issuecomment-405570135","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/22967","id":405570135,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTU3MDEzNQ==","user":{"login":"keeeto","id":3697636,"node_id":"MDQ6VXNlcjM2OTc2MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/3697636?v=4","gravatar_id":"","url":"https://api.github.com/users/keeeto","html_url":"https://github.com/keeeto","followers_url":"https://api.github.com/users/keeeto/followers","following_url":"https://api.github.com/users/keeeto/following{/other_user}","gists_url":"https://api.github.com/users/keeeto/gists{/gist_id}","starred_url":"https://api.github.com/users/keeeto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keeeto/subscriptions","organizations_url":"https://api.github.com/users/keeeto/orgs","repos_url":"https://api.github.com/users/keeeto/repos","events_url":"https://api.github.com/users/keeeto/events{/privacy}","received_events_url":"https://api.github.com/users/keeeto/received_events","type":"User","site_admin":false},"created_at":"2018-07-17T12:49:36Z","updated_at":"2018-07-17T12:49:36Z","author_association":"CONTRIBUTOR","body":"@DavidFair - the `SetSample` command is now printing correctly as a single line, however I am still getting errors in this. \r\nAbout the types of value being set.\r\n`ValueError: Invalid value for property Geometry (Dictionary) \"{\"Center\":\"0,0,0\",\"Height\":\"4\",\"Radius\":\"0.25\",\"Shape\":\"Cylinder\"}\": Error setting value from string.\r\nUnknown property search object Center`"}}
{"actor":{"display_login":"keeeto"}}