{"action":"created","issue":{"url":"https://api.github.com/repos/fastai/fastai/issues/623","repository_url":"https://api.github.com/repos/fastai/fastai","labels_url":"https://api.github.com/repos/fastai/fastai/issues/623/labels{/name}","comments_url":"https://api.github.com/repos/fastai/fastai/issues/623/comments","events_url":"https://api.github.com/repos/fastai/fastai/issues/623/events","html_url":"https://github.com/fastai/fastai/pull/623","id":341194787,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDI3MDcw","number":623,"title":"add missing lesson1-breeds.ipynb notebook.","user":{"login":"stas00","id":10676103,"node_id":"MDQ6VXNlcjEwNjc2MTAz","avatar_url":"https://avatars2.githubusercontent.com/u/10676103?v=4","gravatar_id":"","url":"https://api.github.com/users/stas00","html_url":"https://github.com/stas00","followers_url":"https://api.github.com/users/stas00/followers","following_url":"https://api.github.com/users/stas00/following{/other_user}","gists_url":"https://api.github.com/users/stas00/gists{/gist_id}","starred_url":"https://api.github.com/users/stas00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stas00/subscriptions","organizations_url":"https://api.github.com/users/stas00/orgs","repos_url":"https://api.github.com/users/stas00/repos","events_url":"https://api.github.com/users/stas00/events{/privacy}","received_events_url":"https://api.github.com/users/stas00/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-14T00:45:54Z","updated_at":"2018-07-20T15:50:56Z","closed_at":"2018-07-19T16:46:22Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/fastai/fastai/pulls/623","html_url":"https://github.com/fastai/fastai/pull/623","diff_url":"https://github.com/fastai/fastai/pull/623.diff","patch_url":"https://github.com/fastai/fastai/pull/623.patch"},"body":"In the first few DL lessons Jeremy often works with dog breeds notebook (lesson1-breeds.ipynb), but says he can't give it us since the competition is unfinished and he doesn't want us to cheat.\r\n\r\nThe competition has been finished, so let's make this notebook available to all so it's easier to follow the video lessons.\r\n\r\nI found a copy of it in this repo https://github.com/tanakatsu/fastai-course1-v2. I can't tell whether it is identical to Jeremy's copy and how it was acquired. But it's probably better to have it in any form than none.\r\n\r\nI tested it that it runs to a successful completion as is.\r\n\r\nHere are the changes I have applied to lesson1-breeds.ipynb found under the github repo mentioned above:\r\n\r\n- cleaned up the corrections that were made due to the API changes made since the video lessons.\r\n- added a few notes where to find data needed for that notebook to run.\r\n- edited the last section to remove the non-working code and clarify that there are 2 methods.\r\n- removed the hardcoded section numbers (jupyter generates those automatically)."},"comment":{"url":"https://api.github.com/repos/fastai/fastai/issues/comments/406642271","html_url":"https://github.com/fastai/fastai/pull/623#issuecomment-406642271","issue_url":"https://api.github.com/repos/fastai/fastai/issues/623","id":406642271,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjY0MjI3MQ==","user":{"login":"jph00","id":346999,"node_id":"MDQ6VXNlcjM0Njk5OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/346999?v=4","gravatar_id":"","url":"https://api.github.com/users/jph00","html_url":"https://github.com/jph00","followers_url":"https://api.github.com/users/jph00/followers","following_url":"https://api.github.com/users/jph00/following{/other_user}","gists_url":"https://api.github.com/users/jph00/gists{/gist_id}","starred_url":"https://api.github.com/users/jph00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jph00/subscriptions","organizations_url":"https://api.github.com/users/jph00/orgs","repos_url":"https://api.github.com/users/jph00/repos","events_url":"https://api.github.com/users/jph00/events{/privacy}","received_events_url":"https://api.github.com/users/jph00/received_events","type":"User","site_admin":false},"created_at":"2018-07-20T15:50:56Z","updated_at":"2018-07-20T15:50:56Z","author_association":"MEMBER","body":"@stas00 I just commited my version of the nb to the repo as lesson1-breeds2.ipynb. Perhaps you can take a look and combine the best bits of the two notebooks, and do a PR that removes the 2nd notebook and updates the first appropriately?"}}
{"actor":{"display_login":"jph00"}}