{"action":"created","issue":{"url":"https://api.github.com/repos/crate/crate/issues/7480","repository_url":"https://api.github.com/repos/crate/crate","labels_url":"https://api.github.com/repos/crate/crate/issues/7480/labels{/name}","comments_url":"https://api.github.com/repos/crate/crate/issues/7480/comments","events_url":"https://api.github.com/repos/crate/crate/issues/7480/events","html_url":"https://github.com/crate/crate/pull/7480","id":335512314,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MTkzNjk4","number":7480,"title":"Fix error thrown when deleting/updating an empty parted table. ","user":{"login":"matriv","id":5058131,"node_id":"MDQ6VXNlcjUwNTgxMzE=","avatar_url":"https://avatars1.githubusercontent.com/u/5058131?v=4","gravatar_id":"","url":"https://api.github.com/users/matriv","html_url":"https://github.com/matriv","followers_url":"https://api.github.com/users/matriv/followers","following_url":"https://api.github.com/users/matriv/following{/other_user}","gists_url":"https://api.github.com/users/matriv/gists{/gist_id}","starred_url":"https://api.github.com/users/matriv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matriv/subscriptions","organizations_url":"https://api.github.com/users/matriv/orgs","repos_url":"https://api.github.com/users/matriv/repos","events_url":"https://api.github.com/users/matriv/events{/privacy}","received_events_url":"https://api.github.com/users/matriv/received_events","type":"User","site_admin":false},"labels":[{"id":751711498,"node_id":"MDU6TGFiZWw3NTE3MTE0OTg=","url":"https://api.github.com/repos/crate/crate/labels/v/2.3","name":"v/2.3","color":"fef2c0","default":false},{"id":908095786,"node_id":"MDU6TGFiZWw5MDgwOTU3ODY=","url":"https://api.github.com/repos/crate/crate/labels/v/3.0","name":"v/3.0","color":"fef2c0","default":false},{"id":947047463,"node_id":"MDU6TGFiZWw5NDcwNDc0NjM=","url":"https://api.github.com/repos/crate/crate/labels/v/3.1","name":"v/3.1","color":"fef2c0","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-06-25T18:10:48Z","updated_at":"2018-07-02T14:58:41Z","closed_at":"2018-07-02T14:38:31Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/crate/crate/pulls/7480","html_url":"https://github.com/crate/crate/pull/7480","diff_url":"https://github.com/crate/crate/pull/7480.diff","patch_url":"https://github.com/crate/crate/pull/7480.patch"},"body":"This is an alternative fix to https://github.com/crate/crate/pull/7465\r\nSince this change is big in terms of plans, I'd like some feedback before proceeding and adapting all unit tests.\r\n\r\nThe idea is that when operating on a table with no shards -> emptyCollectSource we don't use the ProjectionToProjectorVisitor any more so there is no projection added to the rowConsumer.\r\n\r\nThis fixes the issue with DELETE/UPDATE on an empty partitioned table, but creates an issue with Aggregations and GroupBy aggregations: The issue is that if there is an empty table, since no projection is added, we always need a final Merge phase with a final AggregationProjection that will convert the 0 rows to: `count=0` or `min(col) = null`, etc."},"comment":{"url":"https://api.github.com/repos/crate/crate/issues/comments/401834086","html_url":"https://github.com/crate/crate/pull/7480#issuecomment-401834086","issue_url":"https://api.github.com/repos/crate/crate/issues/7480","id":401834086,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTgzNDA4Ng==","user":{"login":"matriv","id":5058131,"node_id":"MDQ6VXNlcjUwNTgxMzE=","avatar_url":"https://avatars1.githubusercontent.com/u/5058131?v=4","gravatar_id":"","url":"https://api.github.com/users/matriv","html_url":"https://github.com/matriv","followers_url":"https://api.github.com/users/matriv/followers","following_url":"https://api.github.com/users/matriv/following{/other_user}","gists_url":"https://api.github.com/users/matriv/gists{/gist_id}","starred_url":"https://api.github.com/users/matriv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matriv/subscriptions","organizations_url":"https://api.github.com/users/matriv/orgs","repos_url":"https://api.github.com/users/matriv/repos","events_url":"https://api.github.com/users/matriv/events{/privacy}","received_events_url":"https://api.github.com/users/matriv/received_events","type":"User","site_admin":false},"created_at":"2018-07-02T14:58:41Z","updated_at":"2018-07-02T14:58:41Z","author_association":"MEMBER","body":"Backported to 2.3 with https://github.com/crate/crate/commit/8274cdf11c40aca5efc47bfd966b73363eb71317"}}
{"actor":{"display_login":"matriv"}}