{"action":"created","comment":{"url":"https://api.github.com/repos/cilium/cilium/pulls/comments/208899611","pull_request_review_id":144803220,"id":208899611,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODg5OTYxMQ==","diff_hunk":"@@ -866,6 +868,75 @@ var _ = Describe(\"RuntimePolicies\", func() {\n \n \t})\n \n+\tIt(\"Enforces ToFQDNs policy\", func() {\n+\t\tBy(\"Importing policy with ToFQDN rules\")\n+\t\t// notaname.cilium.io never returns IPs, and is there to test that the\n+\t\t// other name does get populated.\n+\t\tfqdnPolicy := `\n+[\n+  {\n+    \"labels\": [{\n+\t  \t\"key\": \"toFQDNs-runtime-test-policy\"\n+\t  }],\n+    \"endpointSelector\": {\n+      \"matchLabels\": {\n+        \"container:id.app1\": \"\"\n+      }\n+    },\n+    \"egress\": [\n+      {\n+        \"toPorts\": [{\n+          \"ports\":[{\"port\": \"53\", \"protocol\": \"ANY\"}]\n+        }]\n+      },\n+      {\n+        \"toFQDNs\": [\n+          {\n+            \"matchName\": \"cilium.io\"\n+          },\n+          {\n+            \"matchName\": \"notaname.cilium.io\"\n+          }\n+        ]\n+      }\n+    ]\n+  }\n+]`\n+\t\tpreImportPolicyRevision, err := vm.PolicyGetRevision()\n+\t\tExpect(err).To(BeNil(), \"Unable to get policy revision at start of test\", err)\n+\t\t_, err = vm.PolicyRenderAndImport(fqdnPolicy)\n+\t\tExpect(err).To(BeNil(), \"Unable to import policy: %s\", err)\n+\t\tdefer vm.PolicyDel(\"toFQDNs-runtime-test-policy=\")\n+\n+\t\t// The DNS poll will update the policy and regenerate. We know the initial\n+\t\t// import will increment the revision by 1, and the DNS update will\n+\t\t// increment it by 1 again. We can wait for two policy revisions to happen.\n+\t\t// Once we have an API to expose DNS->IP mappings we can also use that to\n+\t\t// ensure the lookup has completed more explicitly\n+\t\ttimeout_s := 3 * fqdn.DNSPollerInterval / time.Second // convert to seconds","path":"test/runtime/Policies.go","position":60,"original_position":60,"commit_id":"ca243332ec0d5907367af4d063cd34279717d90a","original_commit_id":"ca243332ec0d5907367af4d063cd34279717d90a","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"don't use underscores in Go names; var timeout_s should be timeoutS","created_at":"2018-08-09T11:49:29Z","updated_at":"2018-08-09T11:49:30Z","html_url":"https://github.com/cilium/cilium/pull/5148#discussion_r208899611","pull_request_url":"https://api.github.com/repos/cilium/cilium/pulls/5148","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments/208899611"},"html":{"href":"https://github.com/cilium/cilium/pull/5148#discussion_r208899611"},"pull_request":{"href":"https://api.github.com/repos/cilium/cilium/pulls/5148"}}},"pull_request":{"url":"https://api.github.com/repos/cilium/cilium/pulls/5148","id":207289644,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3Mjg5NjQ0","html_url":"https://github.com/cilium/cilium/pull/5148","diff_url":"https://github.com/cilium/cilium/pull/5148.diff","patch_url":"https://github.com/cilium/cilium/pull/5148.patch","issue_url":"https://api.github.com/repos/cilium/cilium/issues/5148","number":5148,"state":"open","locked":false,"title":"v1.2 backports 2018-08-09","user":{"login":"borkmann","id":677393,"node_id":"MDQ6VXNlcjY3NzM5Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/677393?v=4","gravatar_id":"","url":"https://api.github.com/users/borkmann","html_url":"https://github.com/borkmann","followers_url":"https://api.github.com/users/borkmann/followers","following_url":"https://api.github.com/users/borkmann/following{/other_user}","gists_url":"https://api.github.com/users/borkmann/gists{/gist_id}","starred_url":"https://api.github.com/users/borkmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borkmann/subscriptions","organizations_url":"https://api.github.com/users/borkmann/orgs","repos_url":"https://api.github.com/users/borkmann/repos","events_url":"https://api.github.com/users/borkmann/events{/privacy}","received_events_url":"https://api.github.com/users/borkmann/received_events","type":"User","site_admin":false},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cilium/cilium/5148)\n<!-- Reviewable:end -->\n","created_at":"2018-08-09T11:49:20Z","updated_at":"2018-08-09T11:49:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"745eaa93adb1caf6b8299daa4e07d22e46f36796","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"janitors","id":2519796,"node_id":"MDQ6VGVhbTI1MTk3OTY=","slug":"janitors","description":"Rotating team of janitors for unowned code","privacy":"closed","url":"https://api.github.com/teams/2519796","members_url":"https://api.github.com/teams/2519796/members{/member}","repositories_url":"https://api.github.com/teams/2519796/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cilium/cilium/pulls/5148/commits","review_comments_url":"https://api.github.com/repos/cilium/cilium/pulls/5148/comments","review_comment_url":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/5148/comments","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/ca243332ec0d5907367af4d063cd34279717d90a","head":{"label":"cilium:pr/v1.2-backports-2018-08-09","ref":"pr/v1.2-backports-2018-08-09","sha":"ca243332ec0d5907367af4d063cd34279717d90a","user":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"node_id":"MDEwOlJlcG9zaXRvcnk0ODEwOTIzOQ==","name":"cilium","full_name":"cilium/cilium","owner":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cilium/cilium","description":"HTTP, gRPC, and Kafka Aware Security and Networking for Containers with BPF and XDP","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2018-08-09T10:50:53Z","pushed_at":"2018-08-09T11:49:27Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":56326,"stargazers_count":2650,"watchers_count":2650,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":236,"mirror_url":null,"archived":false,"open_issues_count":514,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":236,"open_issues":514,"watchers":2650,"default_branch":"master"}},"base":{"label":"cilium:v1.2","ref":"v1.2","sha":"8b448b86b20a27f71c34ed8ffc035a2479b10be6","user":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"node_id":"MDEwOlJlcG9zaXRvcnk0ODEwOTIzOQ==","name":"cilium","full_name":"cilium/cilium","owner":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cilium/cilium","description":"HTTP, gRPC, and Kafka Aware Security and Networking for Containers with BPF and XDP","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2018-08-09T10:50:53Z","pushed_at":"2018-08-09T11:49:27Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":56326,"stargazers_count":2650,"watchers_count":2650,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":236,"mirror_url":null,"archived":false,"open_issues_count":514,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":236,"open_issues":514,"watchers":2650,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/5148"},"html":{"href":"https://github.com/cilium/cilium/pull/5148"},"issue":{"href":"https://api.github.com/repos/cilium/cilium/issues/5148"},"comments":{"href":"https://api.github.com/repos/cilium/cilium/issues/5148/comments"},"review_comments":{"href":"https://api.github.com/repos/cilium/cilium/pulls/5148/comments"},"review_comment":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cilium/cilium/pulls/5148/commits"},"statuses":{"href":"https://api.github.com/repos/cilium/cilium/statuses/ca243332ec0d5907367af4d063cd34279717d90a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"houndci-bot"}}