{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph-csi/issues/84","repository_url":"https://api.github.com/repos/ceph/ceph-csi","labels_url":"https://api.github.com/repos/ceph/ceph-csi/issues/84/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph-csi/issues/84/comments","events_url":"https://api.github.com/repos/ceph/ceph-csi/issues/84/events","html_url":"https://github.com/ceph/ceph-csi/pull/84","id":368138419,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMzgyMzU4","number":84,"title":"rbdplugin: idempotent DeleteVolume","user":{"login":"pohly","id":22076,"node_id":"MDQ6VXNlcjIyMDc2","avatar_url":"https://avatars1.githubusercontent.com/u/22076?v=4","gravatar_id":"","url":"https://api.github.com/users/pohly","html_url":"https://github.com/pohly","followers_url":"https://api.github.com/users/pohly/followers","following_url":"https://api.github.com/users/pohly/following{/other_user}","gists_url":"https://api.github.com/users/pohly/gists{/gist_id}","starred_url":"https://api.github.com/users/pohly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pohly/subscriptions","organizations_url":"https://api.github.com/users/pohly/orgs","repos_url":"https://api.github.com/users/pohly/repos","events_url":"https://api.github.com/users/pohly/events{/privacy}","received_events_url":"https://api.github.com/users/pohly/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-09T10:15:46Z","updated_at":"2018-10-09T15:04:59Z","closed_at":"2018-10-09T15:04:46Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ceph/ceph-csi/pulls/84","html_url":"https://github.com/ceph/ceph-csi/pull/84","diff_url":"https://github.com/ceph/ceph-csi/pull/84.diff","patch_url":"https://github.com/ceph/ceph-csi/pull/84.patch"},"body":"When the initial DeleteVolume times out (as it does on slow clusters\r\ndue to the low 10 second limit), the external-provisioner calls it\r\nagain. The CSI standard requires the second call to succeed if the\r\nvolume has been deleted in the meantime. This didn't work because\r\nDeleteVolume returned an error when failing to find the volume info\r\nfile:\r\n\r\n  rbdplugin: E1008 08:05:35.631783       1 utils.go:100] GRPC error: rbd: open err /var/lib/kubelet/plugins/csi-rbdplugin/controller/csi-rbd-622a252c-cad0-11e8-9112-deadbeef0101.json/open /var/lib/kubelet/plugins/csi-rbdplugin/controller/csi-rbd-622a252c-cad0-11e8-9112-deadbeef0101.json: no such file or directory\r\n\r\nThe fix is to treat a missing volume info file as \"volume already\r\ndeleted\" and return success. To detect this, the original os error\r\nmust be wrapped, otherwise the caller of loadVolInfo cannot determine\r\nthe root cause.\r\n\r\nNote that further work may be needed to make the driver really\r\nresilient, for example there are probably concurrency issues.\r\nBut for now this fixes: #82"},"comment":{"url":"https://api.github.com/repos/ceph/ceph-csi/issues/comments/428228972","html_url":"https://github.com/ceph/ceph-csi/pull/84#issuecomment-428228972","issue_url":"https://api.github.com/repos/ceph/ceph-csi/issues/84","id":428228972,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODIyODk3Mg==","user":{"login":"rootfs","id":7062400,"node_id":"MDQ6VXNlcjcwNjI0MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/7062400?v=4","gravatar_id":"","url":"https://api.github.com/users/rootfs","html_url":"https://github.com/rootfs","followers_url":"https://api.github.com/users/rootfs/followers","following_url":"https://api.github.com/users/rootfs/following{/other_user}","gists_url":"https://api.github.com/users/rootfs/gists{/gist_id}","starred_url":"https://api.github.com/users/rootfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rootfs/subscriptions","organizations_url":"https://api.github.com/users/rootfs/orgs","repos_url":"https://api.github.com/users/rootfs/repos","events_url":"https://api.github.com/users/rootfs/events{/privacy}","received_events_url":"https://api.github.com/users/rootfs/received_events","type":"User","site_admin":false},"created_at":"2018-10-09T15:04:59Z","updated_at":"2018-10-09T15:04:59Z","author_association":"MEMBER","body":"thanks!"}}
{"actor":{"display_login":"rootfs"}}