{"action":"created","issue":{"url":"https://api.github.com/repos/singnet/platform-contracts/issues/70","repository_url":"https://api.github.com/repos/singnet/platform-contracts","labels_url":"https://api.github.com/repos/singnet/platform-contracts/issues/70/labels{/name}","comments_url":"https://api.github.com/repos/singnet/platform-contracts/issues/70/comments","events_url":"https://api.github.com/repos/singnet/platform-contracts/issues/70/events","html_url":"https://github.com/singnet/platform-contracts/pull/70","id":378805641,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NDIyNzU1","number":70,"title":"WIP Remove paths and add metadataURI to Registry","user":{"login":"astroseger","id":3442052,"node_id":"MDQ6VXNlcjM0NDIwNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/3442052?v=4","gravatar_id":"","url":"https://api.github.com/users/astroseger","html_url":"https://github.com/astroseger","followers_url":"https://api.github.com/users/astroseger/followers","following_url":"https://api.github.com/users/astroseger/following{/other_user}","gists_url":"https://api.github.com/users/astroseger/gists{/gist_id}","starred_url":"https://api.github.com/users/astroseger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astroseger/subscriptions","organizations_url":"https://api.github.com/users/astroseger/orgs","repos_url":"https://api.github.com/users/astroseger/repos","events_url":"https://api.github.com/users/astroseger/events{/privacy}","received_events_url":"https://api.github.com/users/astroseger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-11-08T16:11:27Z","updated_at":"2018-11-11T15:45:40Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/singnet/platform-contracts/pulls/70","html_url":"https://github.com/singnet/platform-contracts/pull/70","diff_url":"https://github.com/singnet/platform-contracts/pull/70.diff","patch_url":"https://github.com/singnet/platform-contracts/pull/70.patch"},"body":"This pull request does:\r\n* rename metadataIPFSHash to metadataURI\r\n* add metadataURI to createServiceRegistration, updateServiceRegistration and getServiceRegistrationByName\r\n* remove path from ServiceRegistration and TypeRepositoryRegistration\r\n* remove Agent/Jobs\r\n\r\nRemoving paths and/or adding metadataURI to createServiceRegistration break old Agent/Job logic in daemon and snet-cli, so I decided to remove Agent/Jobs from contracts completely.\r\n \r\nAttention! This pull request will obviously break old Agent/Jobs CI."},"comment":{"url":"https://api.github.com/repos/singnet/platform-contracts/issues/comments/437680947","html_url":"https://github.com/singnet/platform-contracts/pull/70#issuecomment-437680947","issue_url":"https://api.github.com/repos/singnet/platform-contracts/issues/70","id":437680947,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzY4MDk0Nw==","user":{"login":"ksridharbabuus","id":7427804,"node_id":"MDQ6VXNlcjc0Mjc4MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/7427804?v=4","gravatar_id":"","url":"https://api.github.com/users/ksridharbabuus","html_url":"https://github.com/ksridharbabuus","followers_url":"https://api.github.com/users/ksridharbabuus/followers","following_url":"https://api.github.com/users/ksridharbabuus/following{/other_user}","gists_url":"https://api.github.com/users/ksridharbabuus/gists{/gist_id}","starred_url":"https://api.github.com/users/ksridharbabuus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksridharbabuus/subscriptions","organizations_url":"https://api.github.com/users/ksridharbabuus/orgs","repos_url":"https://api.github.com/users/ksridharbabuus/repos","events_url":"https://api.github.com/users/ksridharbabuus/events{/privacy}","received_events_url":"https://api.github.com/users/ksridharbabuus/received_events","type":"User","site_admin":false},"created_at":"2018-11-11T15:45:40Z","updated_at":"2018-11-11T15:45:40Z","author_association":"COLLABORATOR","body":"> \r\n> \r\n> @ksridharbabuus\r\n> About adding metadataURI to ServiceCreated and ServiceModified events. There is a problem. ServiceModified is emitted from updateServiceRegistration, addTagsToServiceRegistration and removeTagsFromServiceRegistration. But we change metadataURI only in updateServiceRegistration. It means that metadataURI in ServiceModified event in addTagsToServiceRegistration and removeTagsFromServiceRegistration does not make a lot of sense.\r\n> I see three possible solutions.\r\n> \r\n>     1. We could do nothing at the moment. We can add more information to events (or more events) later then it will be more clear what we need.\r\n> \r\n>     2. We could split  ServiceModified event to two events. ServiceMetadataModified and ServiceTagsModified\r\n> \r\n>     3. We could still go with your solution.\r\n> \r\n> \r\n> What do you think?\r\n> \r\n> About renaming uri to metadataURI in getTypeRepositoryByName. I want to point out that it is a type repository, so it should be renamed to repositoryURI, so I did it. If you suggest to rename repositoryURI to metadataURI then I propose to do it in is separate PR. I don't want to touch type repository registry much for now.\r\n\r\nI prefer to have the metadataURI in the events in case of any changes thats the only way we can track right now otherwise we will not even come to know that there is a change in the metadataURI.\r\nSince it is bytes field might even take more size in the events.\r\nThe only other option I can see is tracking offchain which might violates the decentralized principle.\r\n"}}
{"actor":{"display_login":"ksridharbabuus"}}