{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/171350145","pull_request_review_id":100185764,"id":171350145,"diff_hunk":"@@ -1,23 +1,33 @@\n { stdenv, fetchFromGitHub, cmake, makeWrapper, qttools\n-, libgcrypt, zlib, libmicrohttpd, libXtst, qtbase, libgpgerror, glibcLocales, libyubikey, yubikey-personalization, libXi, qtx11extras\n+, curl\n+, glibcLocales\n+, libXi\n+, libXtst\n+, libargon2\n+, libgcrypt\n+, libgpgerror\n+, libmicrohttpd\n+, libyubikey\n+, qtbase\n+, qtx11extras\n+, yubikey-personalization\n+, zlib\n , withKeePassHTTP ? true\n }:\n \n with stdenv.lib;\n \n stdenv.mkDerivation rec {\n   name = \"keepassxc-${version}\";\n-  version = \"2.2.4\";\n+  version = \"2.3.0\";\n \n   src = fetchFromGitHub {\n     owner = \"keepassxreboot\";\n     repo = \"keepassxc\";\n     rev = \"${version}\";\n-    sha256 = \"0q913v2ka6p7jr7c4w9fq8aqh5v6nxqgcv9h7zllk5p0amsf8d80\";\n+    sha256 = \"1zch1qbqgphhp2p2kvjlah8s337162m69yf4y00kcnfb3539ii5f\";\n   };\n \n-  patches = [ ./cmake.patch ./darwin.patch ];","path":"pkgs/applications/misc/keepassx/community.nix","position":34,"original_position":34,"commit_id":"27fce2ff8d3c824afe10cc26db1cd0f815b7bb7b","original_commit_id":"27fce2ff8d3c824afe10cc26db1cd0f815b7bb7b","user":{"login":"jonafato","id":392720,"avatar_url":"https://avatars3.githubusercontent.com/u/392720?v=4","gravatar_id":"","url":"https://api.github.com/users/jonafato","html_url":"https://github.com/jonafato","followers_url":"https://api.github.com/users/jonafato/followers","following_url":"https://api.github.com/users/jonafato/following{/other_user}","gists_url":"https://api.github.com/users/jonafato/gists{/gist_id}","starred_url":"https://api.github.com/users/jonafato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonafato/subscriptions","organizations_url":"https://api.github.com/users/jonafato/orgs","repos_url":"https://api.github.com/users/jonafato/repos","events_url":"https://api.github.com/users/jonafato/events{/privacy}","received_events_url":"https://api.github.com/users/jonafato/received_events","type":"User","site_admin":false},"body":"The `cmake.patch` file should be removed if it's no longer needed.","created_at":"2018-02-28T19:01:06Z","updated_at":"2018-02-28T19:04:22Z","html_url":"https://github.com/NixOS/nixpkgs/pull/36133#discussion_r171350145","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/36133","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/171350145"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/36133#discussion_r171350145"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/36133"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/36133","id":172022563,"html_url":"https://github.com/NixOS/nixpkgs/pull/36133","diff_url":"https://github.com/NixOS/nixpkgs/pull/36133.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/36133.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/36133","number":36133,"state":"open","locked":false,"title":"keepassxc: 2.2.4 -> 2.3.0","user":{"login":"zimbatm","id":3248,"avatar_url":"https://avatars0.githubusercontent.com/u/3248?v=4","gravatar_id":"","url":"https://api.github.com/users/zimbatm","html_url":"https://github.com/zimbatm","followers_url":"https://api.github.com/users/zimbatm/followers","following_url":"https://api.github.com/users/zimbatm/following{/other_user}","gists_url":"https://api.github.com/users/zimbatm/gists{/gist_id}","starred_url":"https://api.github.com/users/zimbatm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimbatm/subscriptions","organizations_url":"https://api.github.com/users/zimbatm/orgs","repos_url":"https://api.github.com/users/zimbatm/repos","events_url":"https://api.github.com/users/zimbatm/events{/privacy}","received_events_url":"https://api.github.com/users/zimbatm/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nHN-driven development. https://news.ycombinator.com/item?id=16483722\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-02-28T17:36:58Z","updated_at":"2018-02-28T19:04:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"325e8d247940ef50205cdf674e198917f5a4cae0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":731735222,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%201-10","name":"10.rebuild-darwin: 1-10","color":"eeffee","default":false},{"id":731733923,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false},{"id":290122734,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20package%20(new)","name":"8.has: package (new)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/36133/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/36133/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/36133/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/27fce2ff8d3c824afe10cc26db1cd0f815b7bb7b","head":{"label":"zimbatm:keepassxc-2.3.0","ref":"keepassxc-2.3.0","sha":"27fce2ff8d3c824afe10cc26db1cd0f815b7bb7b","user":{"login":"zimbatm","id":3248,"avatar_url":"https://avatars0.githubusercontent.com/u/3248?v=4","gravatar_id":"","url":"https://api.github.com/users/zimbatm","html_url":"https://github.com/zimbatm","followers_url":"https://api.github.com/users/zimbatm/followers","following_url":"https://api.github.com/users/zimbatm/following{/other_user}","gists_url":"https://api.github.com/users/zimbatm/gists{/gist_id}","starred_url":"https://api.github.com/users/zimbatm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimbatm/subscriptions","organizations_url":"https://api.github.com/users/zimbatm/orgs","repos_url":"https://api.github.com/users/zimbatm/repos","events_url":"https://api.github.com/users/zimbatm/events{/privacy}","received_events_url":"https://api.github.com/users/zimbatm/received_events","type":"User","site_admin":false},"repo":{"id":40831446,"name":"nixpkgs","full_name":"zimbatm/nixpkgs","owner":{"login":"zimbatm","id":3248,"avatar_url":"https://avatars0.githubusercontent.com/u/3248?v=4","gravatar_id":"","url":"https://api.github.com/users/zimbatm","html_url":"https://github.com/zimbatm","followers_url":"https://api.github.com/users/zimbatm/followers","following_url":"https://api.github.com/users/zimbatm/following{/other_user}","gists_url":"https://api.github.com/users/zimbatm/gists{/gist_id}","starred_url":"https://api.github.com/users/zimbatm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimbatm/subscriptions","organizations_url":"https://api.github.com/users/zimbatm/orgs","repos_url":"https://api.github.com/users/zimbatm/repos","events_url":"https://api.github.com/users/zimbatm/events{/privacy}","received_events_url":"https://api.github.com/users/zimbatm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zimbatm/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/zimbatm/nixpkgs","forks_url":"https://api.github.com/repos/zimbatm/nixpkgs/forks","keys_url":"https://api.github.com/repos/zimbatm/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zimbatm/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zimbatm/nixpkgs/teams","hooks_url":"https://api.github.com/repos/zimbatm/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/zimbatm/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/zimbatm/nixpkgs/events","assignees_url":"https://api.github.com/repos/zimbatm/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/zimbatm/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/zimbatm/nixpkgs/tags","blobs_url":"https://api.github.com/repos/zimbatm/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zimbatm/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zimbatm/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/zimbatm/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zimbatm/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/zimbatm/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/zimbatm/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/zimbatm/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/zimbatm/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/zimbatm/nixpkgs/subscription","commits_url":"https://api.github.com/repos/zimbatm/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/zimbatm/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/zimbatm/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/zimbatm/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/zimbatm/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/zimbatm/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zimbatm/nixpkgs/merges","archive_url":"https://api.github.com/repos/zimbatm/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zimbatm/nixpkgs/downloads","issues_url":"https://api.github.com/repos/zimbatm/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/zimbatm/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/zimbatm/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/zimbatm/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zimbatm/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/zimbatm/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/zimbatm/nixpkgs/deployments","created_at":"2015-08-16T17:52:31Z","updated_at":"2016-10-10T21:06:12Z","pushed_at":"2018-02-28T17:51:14Z","git_url":"git://github.com/zimbatm/nixpkgs.git","ssh_url":"git@github.com:zimbatm/nixpkgs.git","clone_url":"https://github.com/zimbatm/nixpkgs.git","svn_url":"https://github.com/zimbatm/nixpkgs","homepage":null,"size":632004,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"b70e3f02ae76cf6ef2f51405ca6c22abcf7a7246","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-02-28T14:54:44Z","pushed_at":"2018-02-28T18:53:19Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":728563,"stargazers_count":2249,"watchers_count":2249,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2585,"mirror_url":null,"archived":false,"open_issues_count":3028,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2585,"open_issues":3028,"watchers":2249,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/36133"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/36133"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/36133"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/36133/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/36133/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/36133/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/27fce2ff8d3c824afe10cc26db1cd0f815b7bb7b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jonafato"}}