{"action":"opened","number":1755,"pull_request":{"url":"https://api.github.com/repos/osrg/gobgp/pulls/1755","id":196338016,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MzM4MDE2","html_url":"https://github.com/osrg/gobgp/pull/1755","diff_url":"https://github.com/osrg/gobgp/pull/1755.diff","patch_url":"https://github.com/osrg/gobgp/pull/1755.patch","issue_url":"https://api.github.com/repos/osrg/gobgp/issues/1755","number":1755,"state":"open","locked":false,"title":"api: Allow multiple NLRIs in single MpReachNLRIAttribute","user":{"login":"iwaseyusuke","id":8063905,"node_id":"MDQ6VXNlcjgwNjM5MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/8063905?v=4","gravatar_id":"","url":"https://api.github.com/users/iwaseyusuke","html_url":"https://github.com/iwaseyusuke","followers_url":"https://api.github.com/users/iwaseyusuke/followers","following_url":"https://api.github.com/users/iwaseyusuke/following{/other_user}","gists_url":"https://api.github.com/users/iwaseyusuke/gists{/gist_id}","starred_url":"https://api.github.com/users/iwaseyusuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iwaseyusuke/subscriptions","organizations_url":"https://api.github.com/users/iwaseyusuke/orgs","repos_url":"https://api.github.com/users/iwaseyusuke/repos","events_url":"https://api.github.com/users/iwaseyusuke/events{/privacy}","received_events_url":"https://api.github.com/users/iwaseyusuke/received_events","type":"User","site_admin":false},"body":"Currently, api.UnmarshalPathAttributes() does not allow the multiple NLRIs in a single MpReachNLRIAttribute because when AddPath API supposes only single NLRI is composed. This assumption is equivalent to that \"message Path\" structure should have single NLRI for calling AddPath\r\nAPI.\r\n\r\nBut to represent the received UPDATE messages from peers, a single MpReachNLRIAttribute can contain the multiple NLRIs.\r\n\r\nThis patch fixes to allow the multiple NLRIs in a single MpReachNLRIAttribute and removes this constraint.\r\n\r\n---\r\nAlso this PR and https://github.com/osrg/gobgp/pull/1754 will solve the CI errors on https://github.com/osrg/gobgp/pull/1731","created_at":"2018-06-21T05:16:19Z","updated_at":"2018-06-21T05:16:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/osrg/gobgp/pulls/1755/commits","review_comments_url":"https://api.github.com/repos/osrg/gobgp/pulls/1755/comments","review_comment_url":"https://api.github.com/repos/osrg/gobgp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/osrg/gobgp/issues/1755/comments","statuses_url":"https://api.github.com/repos/osrg/gobgp/statuses/1ad5cf7fb1bd91bfcc8aecf025dfc13b5417cf49","head":{"label":"iwaseyusuke:api-Allow_multiple_NLRIs_in_single_MpReachNLRIAttribute","ref":"api-Allow_multiple_NLRIs_in_single_MpReachNLRIAttribute","sha":"1ad5cf7fb1bd91bfcc8aecf025dfc13b5417cf49","user":{"login":"iwaseyusuke","id":8063905,"node_id":"MDQ6VXNlcjgwNjM5MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/8063905?v=4","gravatar_id":"","url":"https://api.github.com/users/iwaseyusuke","html_url":"https://github.com/iwaseyusuke","followers_url":"https://api.github.com/users/iwaseyusuke/followers","following_url":"https://api.github.com/users/iwaseyusuke/following{/other_user}","gists_url":"https://api.github.com/users/iwaseyusuke/gists{/gist_id}","starred_url":"https://api.github.com/users/iwaseyusuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iwaseyusuke/subscriptions","organizations_url":"https://api.github.com/users/iwaseyusuke/orgs","repos_url":"https://api.github.com/users/iwaseyusuke/repos","events_url":"https://api.github.com/users/iwaseyusuke/events{/privacy}","received_events_url":"https://api.github.com/users/iwaseyusuke/received_events","type":"User","site_admin":false},"repo":{"id":69320710,"node_id":"MDEwOlJlcG9zaXRvcnk2OTMyMDcxMA==","name":"gobgp","full_name":"iwaseyusuke/gobgp","owner":{"login":"iwaseyusuke","id":8063905,"node_id":"MDQ6VXNlcjgwNjM5MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/8063905?v=4","gravatar_id":"","url":"https://api.github.com/users/iwaseyusuke","html_url":"https://github.com/iwaseyusuke","followers_url":"https://api.github.com/users/iwaseyusuke/followers","following_url":"https://api.github.com/users/iwaseyusuke/following{/other_user}","gists_url":"https://api.github.com/users/iwaseyusuke/gists{/gist_id}","starred_url":"https://api.github.com/users/iwaseyusuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iwaseyusuke/subscriptions","organizations_url":"https://api.github.com/users/iwaseyusuke/orgs","repos_url":"https://api.github.com/users/iwaseyusuke/repos","events_url":"https://api.github.com/users/iwaseyusuke/events{/privacy}","received_events_url":"https://api.github.com/users/iwaseyusuke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iwaseyusuke/gobgp","description":"BGP implemented in the Go Programming Language","fork":true,"url":"https://api.github.com/repos/iwaseyusuke/gobgp","forks_url":"https://api.github.com/repos/iwaseyusuke/gobgp/forks","keys_url":"https://api.github.com/repos/iwaseyusuke/gobgp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iwaseyusuke/gobgp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iwaseyusuke/gobgp/teams","hooks_url":"https://api.github.com/repos/iwaseyusuke/gobgp/hooks","issue_events_url":"https://api.github.com/repos/iwaseyusuke/gobgp/issues/events{/number}","events_url":"https://api.github.com/repos/iwaseyusuke/gobgp/events","assignees_url":"https://api.github.com/repos/iwaseyusuke/gobgp/assignees{/user}","branches_url":"https://api.github.com/repos/iwaseyusuke/gobgp/branches{/branch}","tags_url":"https://api.github.com/repos/iwaseyusuke/gobgp/tags","blobs_url":"https://api.github.com/repos/iwaseyusuke/gobgp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iwaseyusuke/gobgp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iwaseyusuke/gobgp/git/refs{/sha}","trees_url":"https://api.github.com/repos/iwaseyusuke/gobgp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iwaseyusuke/gobgp/statuses/{sha}","languages_url":"https://api.github.com/repos/iwaseyusuke/gobgp/languages","stargazers_url":"https://api.github.com/repos/iwaseyusuke/gobgp/stargazers","contributors_url":"https://api.github.com/repos/iwaseyusuke/gobgp/contributors","subscribers_url":"https://api.github.com/repos/iwaseyusuke/gobgp/subscribers","subscription_url":"https://api.github.com/repos/iwaseyusuke/gobgp/subscription","commits_url":"https://api.github.com/repos/iwaseyusuke/gobgp/commits{/sha}","git_commits_url":"https://api.github.com/repos/iwaseyusuke/gobgp/git/commits{/sha}","comments_url":"https://api.github.com/repos/iwaseyusuke/gobgp/comments{/number}","issue_comment_url":"https://api.github.com/repos/iwaseyusuke/gobgp/issues/comments{/number}","contents_url":"https://api.github.com/repos/iwaseyusuke/gobgp/contents/{+path}","compare_url":"https://api.github.com/repos/iwaseyusuke/gobgp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iwaseyusuke/gobgp/merges","archive_url":"https://api.github.com/repos/iwaseyusuke/gobgp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iwaseyusuke/gobgp/downloads","issues_url":"https://api.github.com/repos/iwaseyusuke/gobgp/issues{/number}","pulls_url":"https://api.github.com/repos/iwaseyusuke/gobgp/pulls{/number}","milestones_url":"https://api.github.com/repos/iwaseyusuke/gobgp/milestones{/number}","notifications_url":"https://api.github.com/repos/iwaseyusuke/gobgp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iwaseyusuke/gobgp/labels{/name}","releases_url":"https://api.github.com/repos/iwaseyusuke/gobgp/releases{/id}","deployments_url":"https://api.github.com/repos/iwaseyusuke/gobgp/deployments","created_at":"2016-09-27T04:56:24Z","updated_at":"2018-06-21T00:25:42Z","pushed_at":"2018-06-21T04:56:57Z","git_url":"git://github.com/iwaseyusuke/gobgp.git","ssh_url":"git@github.com:iwaseyusuke/gobgp.git","clone_url":"https://github.com/iwaseyusuke/gobgp.git","svn_url":"https://github.com/iwaseyusuke/gobgp","homepage":"http://osrg.github.io/gobgp/","size":11172,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"osrg:master","ref":"master","sha":"3e6eb608a2de03af275082d16e425e365a0e7739","user":{"login":"osrg","id":1179438,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzk0Mzg=","avatar_url":"https://avatars3.githubusercontent.com/u/1179438?v=4","gravatar_id":"","url":"https://api.github.com/users/osrg","html_url":"https://github.com/osrg","followers_url":"https://api.github.com/users/osrg/followers","following_url":"https://api.github.com/users/osrg/following{/other_user}","gists_url":"https://api.github.com/users/osrg/gists{/gist_id}","starred_url":"https://api.github.com/users/osrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osrg/subscriptions","organizations_url":"https://api.github.com/users/osrg/orgs","repos_url":"https://api.github.com/users/osrg/repos","events_url":"https://api.github.com/users/osrg/events{/privacy}","received_events_url":"https://api.github.com/users/osrg/received_events","type":"Organization","site_admin":false},"repo":{"id":24011030,"node_id":"MDEwOlJlcG9zaXRvcnkyNDAxMTAzMA==","name":"gobgp","full_name":"osrg/gobgp","owner":{"login":"osrg","id":1179438,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzk0Mzg=","avatar_url":"https://avatars3.githubusercontent.com/u/1179438?v=4","gravatar_id":"","url":"https://api.github.com/users/osrg","html_url":"https://github.com/osrg","followers_url":"https://api.github.com/users/osrg/followers","following_url":"https://api.github.com/users/osrg/following{/other_user}","gists_url":"https://api.github.com/users/osrg/gists{/gist_id}","starred_url":"https://api.github.com/users/osrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osrg/subscriptions","organizations_url":"https://api.github.com/users/osrg/orgs","repos_url":"https://api.github.com/users/osrg/repos","events_url":"https://api.github.com/users/osrg/events{/privacy}","received_events_url":"https://api.github.com/users/osrg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/osrg/gobgp","description":"BGP implemented in the Go Programming Language","fork":false,"url":"https://api.github.com/repos/osrg/gobgp","forks_url":"https://api.github.com/repos/osrg/gobgp/forks","keys_url":"https://api.github.com/repos/osrg/gobgp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osrg/gobgp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osrg/gobgp/teams","hooks_url":"https://api.github.com/repos/osrg/gobgp/hooks","issue_events_url":"https://api.github.com/repos/osrg/gobgp/issues/events{/number}","events_url":"https://api.github.com/repos/osrg/gobgp/events","assignees_url":"https://api.github.com/repos/osrg/gobgp/assignees{/user}","branches_url":"https://api.github.com/repos/osrg/gobgp/branches{/branch}","tags_url":"https://api.github.com/repos/osrg/gobgp/tags","blobs_url":"https://api.github.com/repos/osrg/gobgp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osrg/gobgp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osrg/gobgp/git/refs{/sha}","trees_url":"https://api.github.com/repos/osrg/gobgp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osrg/gobgp/statuses/{sha}","languages_url":"https://api.github.com/repos/osrg/gobgp/languages","stargazers_url":"https://api.github.com/repos/osrg/gobgp/stargazers","contributors_url":"https://api.github.com/repos/osrg/gobgp/contributors","subscribers_url":"https://api.github.com/repos/osrg/gobgp/subscribers","subscription_url":"https://api.github.com/repos/osrg/gobgp/subscription","commits_url":"https://api.github.com/repos/osrg/gobgp/commits{/sha}","git_commits_url":"https://api.github.com/repos/osrg/gobgp/git/commits{/sha}","comments_url":"https://api.github.com/repos/osrg/gobgp/comments{/number}","issue_comment_url":"https://api.github.com/repos/osrg/gobgp/issues/comments{/number}","contents_url":"https://api.github.com/repos/osrg/gobgp/contents/{+path}","compare_url":"https://api.github.com/repos/osrg/gobgp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osrg/gobgp/merges","archive_url":"https://api.github.com/repos/osrg/gobgp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osrg/gobgp/downloads","issues_url":"https://api.github.com/repos/osrg/gobgp/issues{/number}","pulls_url":"https://api.github.com/repos/osrg/gobgp/pulls{/number}","milestones_url":"https://api.github.com/repos/osrg/gobgp/milestones{/number}","notifications_url":"https://api.github.com/repos/osrg/gobgp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osrg/gobgp/labels{/name}","releases_url":"https://api.github.com/repos/osrg/gobgp/releases{/id}","deployments_url":"https://api.github.com/repos/osrg/gobgp/deployments","created_at":"2014-09-14T01:51:58Z","updated_at":"2018-06-20T10:04:58Z","pushed_at":"2018-06-21T05:12:03Z","git_url":"git://github.com/osrg/gobgp.git","ssh_url":"git@github.com:osrg/gobgp.git","clone_url":"https://github.com/osrg/gobgp.git","svn_url":"https://github.com/osrg/gobgp","homepage":"https://osrg.github.io/gobgp/","size":14843,"stargazers_count":1319,"watchers_count":1319,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":243,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":243,"open_issues":48,"watchers":1319,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/osrg/gobgp/pulls/1755"},"html":{"href":"https://github.com/osrg/gobgp/pull/1755"},"issue":{"href":"https://api.github.com/repos/osrg/gobgp/issues/1755"},"comments":{"href":"https://api.github.com/repos/osrg/gobgp/issues/1755/comments"},"review_comments":{"href":"https://api.github.com/repos/osrg/gobgp/pulls/1755/comments"},"review_comment":{"href":"https://api.github.com/repos/osrg/gobgp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/osrg/gobgp/pulls/1755/commits"},"statuses":{"href":"https://api.github.com/repos/osrg/gobgp/statuses/1ad5cf7fb1bd91bfcc8aecf025dfc13b5417cf49"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"iwaseyusuke"}}