{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/202849224","pull_request_review_id":137625403,"id":202849224,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjg0OTIyNA==","diff_hunk":"@@ -50,7 +51,7 @@ function parseParams(data) {\n     const params = JSON.parse(data);\n     let queryParams = '';\n     for (const p in params) {\n-      if (params.hasOwnProperty(p)) {\n+      if (hasOwn(params, p)) {","path":"ads/adincube.js","position":13,"original_position":13,"commit_id":"013a4598d5b5e861c1d082a25fce3a22d3425678","original_commit_id":"013a4598d5b5e861c1d082a25fce3a22d3425678","user":{"login":"danielrozenberg","id":1839738,"node_id":"MDQ6VXNlcjE4Mzk3Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/1839738?v=4","gravatar_id":"","url":"https://api.github.com/users/danielrozenberg","html_url":"https://github.com/danielrozenberg","followers_url":"https://api.github.com/users/danielrozenberg/followers","following_url":"https://api.github.com/users/danielrozenberg/following{/other_user}","gists_url":"https://api.github.com/users/danielrozenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/danielrozenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielrozenberg/subscriptions","organizations_url":"https://api.github.com/users/danielrozenberg/orgs","repos_url":"https://api.github.com/users/danielrozenberg/repos","events_url":"https://api.github.com/users/danielrozenberg/events{/privacy}","received_events_url":"https://api.github.com/users/danielrozenberg/received_events","type":"User","site_admin":false},"body":"I don't feel strongly one way or the other, but fyi this is a method that already exists in the repo","created_at":"2018-07-16T22:51:20Z","updated_at":"2018-07-16T22:51:20Z","html_url":"https://github.com/ampproject/amphtml/pull/16762#discussion_r202849224","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/16762","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/202849224"},"html":{"href":"https://github.com/ampproject/amphtml/pull/16762#discussion_r202849224"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/16762"}},"in_reply_to_id":202844633},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/16762","id":201775665,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNzc1NjY1","html_url":"https://github.com/ampproject/amphtml/pull/16762","diff_url":"https://github.com/ampproject/amphtml/pull/16762.diff","patch_url":"https://github.com/ampproject/amphtml/pull/16762.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/16762","number":16762,"state":"open","locked":false,"title":"🏗♻️ Forbid invoking hasOwnProperty directly","user":{"login":"danielrozenberg","id":1839738,"node_id":"MDQ6VXNlcjE4Mzk3Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/1839738?v=4","gravatar_id":"","url":"https://api.github.com/users/danielrozenberg","html_url":"https://github.com/danielrozenberg","followers_url":"https://api.github.com/users/danielrozenberg/followers","following_url":"https://api.github.com/users/danielrozenberg/following{/other_user}","gists_url":"https://api.github.com/users/danielrozenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/danielrozenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielrozenberg/subscriptions","organizations_url":"https://api.github.com/users/danielrozenberg/orgs","repos_url":"https://api.github.com/users/danielrozenberg/repos","events_url":"https://api.github.com/users/danielrozenberg/events{/privacy}","received_events_url":"https://api.github.com/users/danielrozenberg/received_events","type":"User","site_admin":false},"body":"Fixed #6548 + refactors all existing usage to use `hasOwn` from `src/utils/object`","created_at":"2018-07-16T22:18:40Z","updated_at":"2018-07-16T22:51:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd130723948b116f44b5ba3c46502415710c82a0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jridgewell","id":112982,"node_id":"MDQ6VXNlcjExMjk4Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/112982?v=4","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},{"login":"erwinmombay","id":354746,"node_id":"MDQ6VXNlcjM1NDc0Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/354746?v=4","gravatar_id":"","url":"https://api.github.com/users/erwinmombay","html_url":"https://github.com/erwinmombay","followers_url":"https://api.github.com/users/erwinmombay/followers","following_url":"https://api.github.com/users/erwinmombay/following{/other_user}","gists_url":"https://api.github.com/users/erwinmombay/gists{/gist_id}","starred_url":"https://api.github.com/users/erwinmombay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwinmombay/subscriptions","organizations_url":"https://api.github.com/users/erwinmombay/orgs","repos_url":"https://api.github.com/users/erwinmombay/repos","events_url":"https://api.github.com/users/erwinmombay/events{/privacy}","received_events_url":"https://api.github.com/users/erwinmombay/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":596633554,"node_id":"MDU6TGFiZWw1OTY2MzM1NTQ=","url":"https://api.github.com/repos/ampproject/amphtml/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/16762/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/16762/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/16762/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/013a4598d5b5e861c1d082a25fce3a22d3425678","head":{"label":"danielrozenberg:forbid-has-own-property","ref":"forbid-has-own-property","sha":"013a4598d5b5e861c1d082a25fce3a22d3425678","user":{"login":"danielrozenberg","id":1839738,"node_id":"MDQ6VXNlcjE4Mzk3Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/1839738?v=4","gravatar_id":"","url":"https://api.github.com/users/danielrozenberg","html_url":"https://github.com/danielrozenberg","followers_url":"https://api.github.com/users/danielrozenberg/followers","following_url":"https://api.github.com/users/danielrozenberg/following{/other_user}","gists_url":"https://api.github.com/users/danielrozenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/danielrozenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielrozenberg/subscriptions","organizations_url":"https://api.github.com/users/danielrozenberg/orgs","repos_url":"https://api.github.com/users/danielrozenberg/repos","events_url":"https://api.github.com/users/danielrozenberg/events{/privacy}","received_events_url":"https://api.github.com/users/danielrozenberg/received_events","type":"User","site_admin":false},"repo":{"id":103311490,"node_id":"MDEwOlJlcG9zaXRvcnkxMDMzMTE0OTA=","name":"amphtml","full_name":"danielrozenberg/amphtml","owner":{"login":"danielrozenberg","id":1839738,"node_id":"MDQ6VXNlcjE4Mzk3Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/1839738?v=4","gravatar_id":"","url":"https://api.github.com/users/danielrozenberg","html_url":"https://github.com/danielrozenberg","followers_url":"https://api.github.com/users/danielrozenberg/followers","following_url":"https://api.github.com/users/danielrozenberg/following{/other_user}","gists_url":"https://api.github.com/users/danielrozenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/danielrozenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielrozenberg/subscriptions","organizations_url":"https://api.github.com/users/danielrozenberg/orgs","repos_url":"https://api.github.com/users/danielrozenberg/repos","events_url":"https://api.github.com/users/danielrozenberg/events{/privacy}","received_events_url":"https://api.github.com/users/danielrozenberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danielrozenberg/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/danielrozenberg/amphtml","forks_url":"https://api.github.com/repos/danielrozenberg/amphtml/forks","keys_url":"https://api.github.com/repos/danielrozenberg/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielrozenberg/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielrozenberg/amphtml/teams","hooks_url":"https://api.github.com/repos/danielrozenberg/amphtml/hooks","issue_events_url":"https://api.github.com/repos/danielrozenberg/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/danielrozenberg/amphtml/events","assignees_url":"https://api.github.com/repos/danielrozenberg/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/danielrozenberg/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/danielrozenberg/amphtml/tags","blobs_url":"https://api.github.com/repos/danielrozenberg/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielrozenberg/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielrozenberg/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielrozenberg/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielrozenberg/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/danielrozenberg/amphtml/languages","stargazers_url":"https://api.github.com/repos/danielrozenberg/amphtml/stargazers","contributors_url":"https://api.github.com/repos/danielrozenberg/amphtml/contributors","subscribers_url":"https://api.github.com/repos/danielrozenberg/amphtml/subscribers","subscription_url":"https://api.github.com/repos/danielrozenberg/amphtml/subscription","commits_url":"https://api.github.com/repos/danielrozenberg/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielrozenberg/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielrozenberg/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielrozenberg/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielrozenberg/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/danielrozenberg/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielrozenberg/amphtml/merges","archive_url":"https://api.github.com/repos/danielrozenberg/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielrozenberg/amphtml/downloads","issues_url":"https://api.github.com/repos/danielrozenberg/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/danielrozenberg/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/danielrozenberg/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/danielrozenberg/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielrozenberg/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/danielrozenberg/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/danielrozenberg/amphtml/deployments","created_at":"2017-09-12T19:22:30Z","updated_at":"2018-07-16T22:26:23Z","pushed_at":"2018-07-16T22:27:15Z","git_url":"git://github.com/danielrozenberg/amphtml.git","ssh_url":"git@github.com:danielrozenberg/amphtml.git","clone_url":"https://github.com/danielrozenberg/amphtml.git","svn_url":"https://github.com/danielrozenberg/amphtml","homepage":"https://www.ampproject.org","size":484925,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"ad117438ec32ac9c4d5eb0d5f6c89072781621fb","user":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"node_id":"MDEwOlJlcG9zaXRvcnk0MTc2NjAwMg==","name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2018-07-16T22:37:46Z","pushed_at":"2018-07-16T22:50:51Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":484844,"stargazers_count":11767,"watchers_count":11767,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2496,"mirror_url":null,"archived":false,"open_issues_count":1352,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2496,"open_issues":1352,"watchers":11767,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/16762"},"html":{"href":"https://github.com/ampproject/amphtml/pull/16762"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/16762"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/16762/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/16762/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/16762/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/013a4598d5b5e861c1d082a25fce3a22d3425678"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"danielrozenberg"}}