{"action":"created","issue":{"url":"https://api.github.com/repos/apache/carbondata/issues/2914","repository_url":"https://api.github.com/repos/apache/carbondata","labels_url":"https://api.github.com/repos/apache/carbondata/issues/2914/labels{/name}","comments_url":"https://api.github.com/repos/apache/carbondata/issues/2914/comments","events_url":"https://api.github.com/repos/apache/carbondata/issues/2914/events","html_url":"https://github.com/apache/carbondata/pull/2914","id":379739870,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMTA2Mjg5","number":2914,"title":"[CARBONDATA-3093] Provide property builder for carbon properties.","user":{"login":"xubo245","id":8759816,"node_id":"MDQ6VXNlcjg3NTk4MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/8759816?v=4","gravatar_id":"","url":"https://api.github.com/users/xubo245","html_url":"https://github.com/xubo245","followers_url":"https://api.github.com/users/xubo245/followers","following_url":"https://api.github.com/users/xubo245/following{/other_user}","gists_url":"https://api.github.com/users/xubo245/gists{/gist_id}","starred_url":"https://api.github.com/users/xubo245/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xubo245/subscriptions","organizations_url":"https://api.github.com/users/xubo245/orgs","repos_url":"https://api.github.com/users/xubo245/repos","events_url":"https://api.github.com/users/xubo245/events{/privacy}","received_events_url":"https://api.github.com/users/xubo245/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":73,"created_at":"2018-11-12T11:42:56Z","updated_at":"2018-12-20T02:12:47Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/carbondata/pulls/2914","html_url":"https://github.com/apache/carbondata/pull/2914","diff_url":"https://github.com/apache/carbondata/pull/2914.diff","patch_url":"https://github.com/apache/carbondata/pull/2914.patch"},"body":"[CARBONDATA-3093] Provide property builder for carbon properties.\r\n\r\nThis PR was already Discussed in maillist：http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/Discussion-Refactor-dynamic-configuration-td67057.html\r\n\r\n## 1. Optimize the String implementation, we can provide property builder for it, then can use it in CarbonCommonConstant to replace current String implementation.\r\n\r\nFor example:\r\n\r\n```\r\n  public static final Property CSV_READ_BUFFER_SIZE = Property.buildIntProperty()\r\n      .name(\"carbon.csv.read.buffersize.byte\")\r\n      .defaultValue(1048576)\r\n      .minValue(10240)\r\n      .maxValue(10485760)\r\n      .doc(\"CSV_READ_BUFFER_SIZE, default value is 1mb.\" +\r\n          \"min value for csv read buffer size, 10 kb.\" +\r\n          \"max value for csv read buffer size, 10 mb\")\r\n      .build();\r\n```\r\n\r\n## 2.add interface for Property:\r\n```\r\norg.apache.carbondata.core.util.CarbonProperties#addProperty(org.apache.carbondata.core.util.Property, java.lang.String)\r\norg.apache.carbondata.core.util.CarbonProperties#addProperty(org.apache.carbondata.core.util.Property)\r\norg.apache.carbondata.core.util.CarbonProperties#getProperty(org.apache.carbondata.core.util.Property, java.lang.String)\r\n```\r\n\r\n## 3. fix some error:\r\n\r\n```\r\n CarbonProperties.getInstance()\r\n      .addProperty(CarbonCommonConstants.DEFAULT_ENABLE_AUTO_LOAD_MERGE, \"true\")\r\n```\r\n=>\r\n```\r\n    CarbonProperties.getInstance()\r\n      .addProperty(CarbonCommonConstants.ENABLE_AUTO_LOAD_MERGE, \"true\")\r\n```\r\n\r\n\r\nBe sure to do all of the following checklist to help us incorporate \r\nyour contribution quickly and easily:\r\n\r\n - [x] Any interfaces changed?\r\n  Add some interface\r\n - [x] Any backward compatibility impacted?\r\n No\r\n - [ ] Document update required?\r\nYes\r\n - [x] Testing done\r\n        Please provide details on \r\n        - Whether new unit test cases have been added or why no new tests are required?\r\n        - How it is tested? Please attach test report.\r\n        - Is it a performance related change? Please attach the performance test report.\r\n        - Any additional information to help reviewers in testing this change.\r\n       \r\nchange the test case\r\n - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. \r\nhttps://issues.apache.org/jira/browse/CARBONDATA-3092"},"comment":{"url":"https://api.github.com/repos/apache/carbondata/issues/comments/448833000","html_url":"https://github.com/apache/carbondata/pull/2914#issuecomment-448833000","issue_url":"https://api.github.com/repos/apache/carbondata/issues/2914","id":448833000,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODgzMzAwMA==","user":{"login":"CarbonDataQA","id":24402133,"node_id":"MDQ6VXNlcjI0NDAyMTMz","avatar_url":"https://avatars0.githubusercontent.com/u/24402133?v=4","gravatar_id":"","url":"https://api.github.com/users/CarbonDataQA","html_url":"https://github.com/CarbonDataQA","followers_url":"https://api.github.com/users/CarbonDataQA/followers","following_url":"https://api.github.com/users/CarbonDataQA/following{/other_user}","gists_url":"https://api.github.com/users/CarbonDataQA/gists{/gist_id}","starred_url":"https://api.github.com/users/CarbonDataQA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarbonDataQA/subscriptions","organizations_url":"https://api.github.com/users/CarbonDataQA/orgs","repos_url":"https://api.github.com/users/CarbonDataQA/repos","events_url":"https://api.github.com/users/CarbonDataQA/events{/privacy}","received_events_url":"https://api.github.com/users/CarbonDataQA/received_events","type":"User","site_admin":false},"created_at":"2018-12-20T02:12:47Z","updated_at":"2018-12-20T02:12:47Z","author_association":"NONE","body":"Build Failed  with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10112/\n"}}
{"actor":{"display_login":"CarbonDataQA"}}