{"action":"closed","issue":{"url":"https://api.github.com/repos/pybind/pybind11/issues/1554","repository_url":"https://api.github.com/repos/pybind/pybind11","labels_url":"https://api.github.com/repos/pybind/pybind11/issues/1554/labels{/name}","comments_url":"https://api.github.com/repos/pybind/pybind11/issues/1554/comments","events_url":"https://api.github.com/repos/pybind/pybind11/issues/1554/events","html_url":"https://github.com/pybind/pybind11/issues/1554","id":367245455,"node_id":"MDU6SXNzdWUzNjcyNDU0NTU=","number":1554,"title":"clang7 doesn't need experimental anymore ","user":{"login":"fantasticfears","id":297343,"node_id":"MDQ6VXNlcjI5NzM0Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/297343?v=4","gravatar_id":"","url":"https://api.github.com/users/fantasticfears","html_url":"https://github.com/fantasticfears","followers_url":"https://api.github.com/users/fantasticfears/followers","following_url":"https://api.github.com/users/fantasticfears/following{/other_user}","gists_url":"https://api.github.com/users/fantasticfears/gists{/gist_id}","starred_url":"https://api.github.com/users/fantasticfears/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fantasticfears/subscriptions","organizations_url":"https://api.github.com/users/fantasticfears/orgs","repos_url":"https://api.github.com/users/fantasticfears/repos","events_url":"https://api.github.com/users/fantasticfears/events{/privacy}","received_events_url":"https://api.github.com/users/fantasticfears/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-05T14:51:44Z","updated_at":"2018-10-25T13:47:12Z","closed_at":"2018-10-25T13:47:12Z","author_association":"NONE","body":"## Issue description\r\n\r\n`#include <pybind11/stl.h>` can't compile with clang++-7.0 because optional is no longer experimental.\r\n\r\nI tried to put macro detection code in `details/common.h` but it doesn't work.\r\n\r\n```\r\n#if defined(__clang__) && __clang_major__ >= 7\r\n#  define PYBIND11_CPP17\r\n#endif\r\n```\r\n\r\n## Reproducible example code\r\n\r\n```cpp\r\n#include \"pybind11/stl.h\"\r\n\r\nint main()\r\n{\r\n  return 0;\r\n}\r\n```\r\n"}}
{"actor":{"display_login":"fantasticfears"}}