{"action":"created","issue":{"url":"https://api.github.com/repos/ExchangeUnion/xud/issues/664","repository_url":"https://api.github.com/repos/ExchangeUnion/xud","labels_url":"https://api.github.com/repos/ExchangeUnion/xud/issues/664/labels{/name}","comments_url":"https://api.github.com/repos/ExchangeUnion/xud/issues/664/comments","events_url":"https://api.github.com/repos/ExchangeUnion/xud/issues/664/events","html_url":"https://github.com/ExchangeUnion/xud/issues/664","id":379765581,"node_id":"MDU6SXNzdWUzNzk3NjU1ODE=","number":664,"title":"Batching swaps","user":{"login":"sangaman","id":3440835,"node_id":"MDQ6VXNlcjM0NDA4MzU=","avatar_url":"https://avatars1.githubusercontent.com/u/3440835?v=4","gravatar_id":"","url":"https://api.github.com/users/sangaman","html_url":"https://github.com/sangaman","followers_url":"https://api.github.com/users/sangaman/followers","following_url":"https://api.github.com/users/sangaman/following{/other_user}","gists_url":"https://api.github.com/users/sangaman/gists{/gist_id}","starred_url":"https://api.github.com/users/sangaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sangaman/subscriptions","organizations_url":"https://api.github.com/users/sangaman/orgs","repos_url":"https://api.github.com/users/sangaman/repos","events_url":"https://api.github.com/users/sangaman/events{/privacy}","received_events_url":"https://api.github.com/users/sangaman/received_events","type":"User","site_admin":false},"labels":[{"id":832646559,"node_id":"MDU6TGFiZWw4MzI2NDY1NTk=","url":"https://api.github.com/repos/ExchangeUnion/xud/labels/question/tbd","name":"question/tbd","color":"d876e3","default":false},{"id":976823507,"node_id":"MDU6TGFiZWw5NzY4MjM1MDc=","url":"https://api.github.com/repos/ExchangeUnion/xud/labels/swaps","name":"swaps","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":{"login":"sangaman","id":3440835,"node_id":"MDQ6VXNlcjM0NDA4MzU=","avatar_url":"https://avatars1.githubusercontent.com/u/3440835?v=4","gravatar_id":"","url":"https://api.github.com/users/sangaman","html_url":"https://github.com/sangaman","followers_url":"https://api.github.com/users/sangaman/followers","following_url":"https://api.github.com/users/sangaman/following{/other_user}","gists_url":"https://api.github.com/users/sangaman/gists{/gist_id}","starred_url":"https://api.github.com/users/sangaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sangaman/subscriptions","organizations_url":"https://api.github.com/users/sangaman/orgs","repos_url":"https://api.github.com/users/sangaman/repos","events_url":"https://api.github.com/users/sangaman/events{/privacy}","received_events_url":"https://api.github.com/users/sangaman/received_events","type":"User","site_admin":false},"assignees":[{"login":"sangaman","id":3440835,"node_id":"MDQ6VXNlcjM0NDA4MzU=","avatar_url":"https://avatars1.githubusercontent.com/u/3440835?v=4","gravatar_id":"","url":"https://api.github.com/users/sangaman","html_url":"https://github.com/sangaman","followers_url":"https://api.github.com/users/sangaman/followers","following_url":"https://api.github.com/users/sangaman/following{/other_user}","gists_url":"https://api.github.com/users/sangaman/gists{/gist_id}","starred_url":"https://api.github.com/users/sangaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sangaman/subscriptions","organizations_url":"https://api.github.com/users/sangaman/orgs","repos_url":"https://api.github.com/users/sangaman/repos","events_url":"https://api.github.com/users/sangaman/events{/privacy}","received_events_url":"https://api.github.com/users/sangaman/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ExchangeUnion/xud/milestones/8","html_url":"https://github.com/ExchangeUnion/xud/milestone/8","labels_url":"https://api.github.com/repos/ExchangeUnion/xud/milestones/8/labels","id":3771651,"node_id":"MDk6TWlsZXN0b25lMzc3MTY1MQ==","number":8,"title":"1.0.0-alpha.5","description":"","creator":{"login":"kilrau","id":19181985,"node_id":"MDQ6VXNlcjE5MTgxOTg1","avatar_url":"https://avatars0.githubusercontent.com/u/19181985?v=4","gravatar_id":"","url":"https://api.github.com/users/kilrau","html_url":"https://github.com/kilrau","followers_url":"https://api.github.com/users/kilrau/followers","following_url":"https://api.github.com/users/kilrau/following{/other_user}","gists_url":"https://api.github.com/users/kilrau/gists{/gist_id}","starred_url":"https://api.github.com/users/kilrau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kilrau/subscriptions","organizations_url":"https://api.github.com/users/kilrau/orgs","repos_url":"https://api.github.com/users/kilrau/repos","events_url":"https://api.github.com/users/kilrau/events{/privacy}","received_events_url":"https://api.github.com/users/kilrau/received_events","type":"User","site_admin":false},"open_issues":37,"closed_issues":4,"state":"open","created_at":"2018-10-26T14:13:08Z","updated_at":"2018-11-20T12:21:20Z","due_on":"2018-11-30T08:00:00Z","closed_at":null},"comments":2,"created_at":"2018-11-12T12:58:44Z","updated_at":"2018-11-20T17:10:43Z","closed_at":null,"author_association":"COLLABORATOR","body":"This is an offshoot of discussion in #654. From @offerm\r\n\r\n> Consider that the taker order is matched with 3 different maker orders.\r\n> How many communications we will do between the peers:\r\n> for each orders:\r\n> - 2 packets on XUD (deal request, response)\r\n> - 4 packets on LNDBTC (setup the HTLC)\r\n> - 4 packets on LNDLTC (setup the HTLC)\r\n> - 4 packets on LNDLTC (resolve the HTLC)\r\n> - 4 packets on LNDBTC (resolve the HTLC\r\n> - 1 packet on XUD (error/complete)\r\n> \r\n> 19 packets for a swap operation. We have 3 of them so we have a total of 57\r\n> packets.\r\n> \r\n> If we do the aggregation we will only need 19 packets as we setup all the 3\r\n> orders together and we swap all the amounts together.\r\n\r\nI think that the benefit of batching packets on the xud side alone is minimal, given that it doesn't change the number of trips between peers a swap must make before being executed. Batching on the lnd side might be a different story, although I'm also not sure there because we're still able to setup HTLCs for multiple swaps in parallel.\r\n\r\nWould batching mean that multiple swaps would share the same `rHash`? The concern for me there would be that by combining payments, we increase the total payment size which could make it harder to find a single route that can support the entire amount."},"comment":{"url":"https://api.github.com/repos/ExchangeUnion/xud/issues/comments/440352342","html_url":"https://github.com/ExchangeUnion/xud/issues/664#issuecomment-440352342","issue_url":"https://api.github.com/repos/ExchangeUnion/xud/issues/664","id":440352342,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDM1MjM0Mg==","user":{"login":"kilrau","id":19181985,"node_id":"MDQ6VXNlcjE5MTgxOTg1","avatar_url":"https://avatars0.githubusercontent.com/u/19181985?v=4","gravatar_id":"","url":"https://api.github.com/users/kilrau","html_url":"https://github.com/kilrau","followers_url":"https://api.github.com/users/kilrau/followers","following_url":"https://api.github.com/users/kilrau/following{/other_user}","gists_url":"https://api.github.com/users/kilrau/gists{/gist_id}","starred_url":"https://api.github.com/users/kilrau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kilrau/subscriptions","organizations_url":"https://api.github.com/users/kilrau/orgs","repos_url":"https://api.github.com/users/kilrau/repos","events_url":"https://api.github.com/users/kilrau/events{/privacy}","received_events_url":"https://api.github.com/users/kilrau/received_events","type":"User","site_admin":false},"created_at":"2018-11-20T17:10:43Z","updated_at":"2018-11-20T17:10:43Z","author_association":"CONTRIBUTOR","body":"https://github.com/ExchangeUnion/xud/issues/622"}}
{"actor":{"display_login":"kilrau"}}