{"action":"created","comment":{"url":"https://api.github.com/repos/JoshGlazebrook/socks/pulls/comments/177635015","pull_request_review_id":107540519,"id":177635015,"diff_hunk":"@@ -441,7 +442,7 @@ class SocksClient extends EventEmitter implements SocksClient {\n       this.state = SocksClientState.Error;\n \n       // Destroy Socket\n-      if (!this._socket.destroyed) {\n+      if (this._socket instanceof net.Socket && !this._socket.destroyed) {","path":"src/client/socksclient.ts","position":40,"original_position":40,"commit_id":"f22120549c2b404b42438ee25601dd9523f404c1","original_commit_id":"f22120549c2b404b42438ee25601dd9523f404c1","user":{"login":"JoshGlazebrook","id":3260991,"avatar_url":"https://avatars2.githubusercontent.com/u/3260991?v=4","gravatar_id":"","url":"https://api.github.com/users/JoshGlazebrook","html_url":"https://github.com/JoshGlazebrook","followers_url":"https://api.github.com/users/JoshGlazebrook/followers","following_url":"https://api.github.com/users/JoshGlazebrook/following{/other_user}","gists_url":"https://api.github.com/users/JoshGlazebrook/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshGlazebrook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshGlazebrook/subscriptions","organizations_url":"https://api.github.com/users/JoshGlazebrook/orgs","repos_url":"https://api.github.com/users/JoshGlazebrook/repos","events_url":"https://api.github.com/users/JoshGlazebrook/events{/privacy}","received_events_url":"https://api.github.com/users/JoshGlazebrook/received_events","type":"User","site_admin":false},"body":"@castorw ","created_at":"2018-03-28T04:14:44Z","updated_at":"2018-03-28T04:14:44Z","html_url":"https://github.com/JoshGlazebrook/socks/pull/29#discussion_r177635015","pull_request_url":"https://api.github.com/repos/JoshGlazebrook/socks/pulls/29","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/JoshGlazebrook/socks/pulls/comments/177635015"},"html":{"href":"https://github.com/JoshGlazebrook/socks/pull/29#discussion_r177635015"},"pull_request":{"href":"https://api.github.com/repos/JoshGlazebrook/socks/pulls/29"}},"in_reply_to_id":176896999},"pull_request":{"url":"https://api.github.com/repos/JoshGlazebrook/socks/pulls/29","id":176926068,"html_url":"https://github.com/JoshGlazebrook/socks/pull/29","diff_url":"https://github.com/JoshGlazebrook/socks/pull/29.diff","patch_url":"https://github.com/JoshGlazebrook/socks/pull/29.patch","issue_url":"https://api.github.com/repos/JoshGlazebrook/socks/issues/29","number":29,"state":"open","locked":false,"title":"Support Duplex Streams for existing_socket","user":{"login":"castorw","id":6908529,"avatar_url":"https://avatars2.githubusercontent.com/u/6908529?v=4","gravatar_id":"","url":"https://api.github.com/users/castorw","html_url":"https://github.com/castorw","followers_url":"https://api.github.com/users/castorw/followers","following_url":"https://api.github.com/users/castorw/following{/other_user}","gists_url":"https://api.github.com/users/castorw/gists{/gist_id}","starred_url":"https://api.github.com/users/castorw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/castorw/subscriptions","organizations_url":"https://api.github.com/users/castorw/orgs","repos_url":"https://api.github.com/users/castorw/repos","events_url":"https://api.github.com/users/castorw/events{/privacy}","received_events_url":"https://api.github.com/users/castorw/received_events","type":"User","site_admin":false},"body":"Currently existing_socket needs to be an instance of `net.Socket` - this is limiting to developers who want to provide a specific stream connected to a proxy server (eg. pre-connected netcat stream). \r\n\r\nUpon providing such stream, the library can provide SOCKS protocol functionality including authentication.","created_at":"2018-03-22T22:23:19Z","updated_at":"2018-03-28T04:14:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf3766c01ebce080c3b69fa208f27acdf0e52456","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JoshGlazebrook/socks/pulls/29/commits","review_comments_url":"https://api.github.com/repos/JoshGlazebrook/socks/pulls/29/comments","review_comment_url":"https://api.github.com/repos/JoshGlazebrook/socks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JoshGlazebrook/socks/issues/29/comments","statuses_url":"https://api.github.com/repos/JoshGlazebrook/socks/statuses/f22120549c2b404b42438ee25601dd9523f404c1","head":{"label":"castorw:fix-allow-duplex-stream","ref":"fix-allow-duplex-stream","sha":"f22120549c2b404b42438ee25601dd9523f404c1","user":{"login":"castorw","id":6908529,"avatar_url":"https://avatars2.githubusercontent.com/u/6908529?v=4","gravatar_id":"","url":"https://api.github.com/users/castorw","html_url":"https://github.com/castorw","followers_url":"https://api.github.com/users/castorw/followers","following_url":"https://api.github.com/users/castorw/following{/other_user}","gists_url":"https://api.github.com/users/castorw/gists{/gist_id}","starred_url":"https://api.github.com/users/castorw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/castorw/subscriptions","organizations_url":"https://api.github.com/users/castorw/orgs","repos_url":"https://api.github.com/users/castorw/repos","events_url":"https://api.github.com/users/castorw/events{/privacy}","received_events_url":"https://api.github.com/users/castorw/received_events","type":"User","site_admin":false},"repo":{"id":126399604,"name":"socks","full_name":"castorw/socks","owner":{"login":"castorw","id":6908529,"avatar_url":"https://avatars2.githubusercontent.com/u/6908529?v=4","gravatar_id":"","url":"https://api.github.com/users/castorw","html_url":"https://github.com/castorw","followers_url":"https://api.github.com/users/castorw/followers","following_url":"https://api.github.com/users/castorw/following{/other_user}","gists_url":"https://api.github.com/users/castorw/gists{/gist_id}","starred_url":"https://api.github.com/users/castorw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/castorw/subscriptions","organizations_url":"https://api.github.com/users/castorw/orgs","repos_url":"https://api.github.com/users/castorw/repos","events_url":"https://api.github.com/users/castorw/events{/privacy}","received_events_url":"https://api.github.com/users/castorw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/castorw/socks","description":"Fully featured SOCKS proxy client supporting SOCKSv4, SOCKSv4a, and SOCKSv5. Includes Bind and Associate functionality.","fork":true,"url":"https://api.github.com/repos/castorw/socks","forks_url":"https://api.github.com/repos/castorw/socks/forks","keys_url":"https://api.github.com/repos/castorw/socks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/castorw/socks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/castorw/socks/teams","hooks_url":"https://api.github.com/repos/castorw/socks/hooks","issue_events_url":"https://api.github.com/repos/castorw/socks/issues/events{/number}","events_url":"https://api.github.com/repos/castorw/socks/events","assignees_url":"https://api.github.com/repos/castorw/socks/assignees{/user}","branches_url":"https://api.github.com/repos/castorw/socks/branches{/branch}","tags_url":"https://api.github.com/repos/castorw/socks/tags","blobs_url":"https://api.github.com/repos/castorw/socks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/castorw/socks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/castorw/socks/git/refs{/sha}","trees_url":"https://api.github.com/repos/castorw/socks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/castorw/socks/statuses/{sha}","languages_url":"https://api.github.com/repos/castorw/socks/languages","stargazers_url":"https://api.github.com/repos/castorw/socks/stargazers","contributors_url":"https://api.github.com/repos/castorw/socks/contributors","subscribers_url":"https://api.github.com/repos/castorw/socks/subscribers","subscription_url":"https://api.github.com/repos/castorw/socks/subscription","commits_url":"https://api.github.com/repos/castorw/socks/commits{/sha}","git_commits_url":"https://api.github.com/repos/castorw/socks/git/commits{/sha}","comments_url":"https://api.github.com/repos/castorw/socks/comments{/number}","issue_comment_url":"https://api.github.com/repos/castorw/socks/issues/comments{/number}","contents_url":"https://api.github.com/repos/castorw/socks/contents/{+path}","compare_url":"https://api.github.com/repos/castorw/socks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/castorw/socks/merges","archive_url":"https://api.github.com/repos/castorw/socks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/castorw/socks/downloads","issues_url":"https://api.github.com/repos/castorw/socks/issues{/number}","pulls_url":"https://api.github.com/repos/castorw/socks/pulls{/number}","milestones_url":"https://api.github.com/repos/castorw/socks/milestones{/number}","notifications_url":"https://api.github.com/repos/castorw/socks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/castorw/socks/labels{/name}","releases_url":"https://api.github.com/repos/castorw/socks/releases{/id}","deployments_url":"https://api.github.com/repos/castorw/socks/deployments","created_at":"2018-03-22T21:56:08Z","updated_at":"2018-03-22T22:32:09Z","pushed_at":"2018-03-22T22:32:08Z","git_url":"git://github.com/castorw/socks.git","ssh_url":"git@github.com:castorw/socks.git","clone_url":"https://github.com/castorw/socks.git","svn_url":"https://github.com/castorw/socks","homepage":"https://www.npmjs.com/package/socks","size":846,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JoshGlazebrook:master","ref":"master","sha":"e9268febf4ed531a4d1e59566a7ff5f7085da91c","user":{"login":"JoshGlazebrook","id":3260991,"avatar_url":"https://avatars2.githubusercontent.com/u/3260991?v=4","gravatar_id":"","url":"https://api.github.com/users/JoshGlazebrook","html_url":"https://github.com/JoshGlazebrook","followers_url":"https://api.github.com/users/JoshGlazebrook/followers","following_url":"https://api.github.com/users/JoshGlazebrook/following{/other_user}","gists_url":"https://api.github.com/users/JoshGlazebrook/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshGlazebrook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshGlazebrook/subscriptions","organizations_url":"https://api.github.com/users/JoshGlazebrook/orgs","repos_url":"https://api.github.com/users/JoshGlazebrook/repos","events_url":"https://api.github.com/users/JoshGlazebrook/events{/privacy}","received_events_url":"https://api.github.com/users/JoshGlazebrook/received_events","type":"User","site_admin":false},"repo":{"id":15078875,"name":"socks","full_name":"JoshGlazebrook/socks","owner":{"login":"JoshGlazebrook","id":3260991,"avatar_url":"https://avatars2.githubusercontent.com/u/3260991?v=4","gravatar_id":"","url":"https://api.github.com/users/JoshGlazebrook","html_url":"https://github.com/JoshGlazebrook","followers_url":"https://api.github.com/users/JoshGlazebrook/followers","following_url":"https://api.github.com/users/JoshGlazebrook/following{/other_user}","gists_url":"https://api.github.com/users/JoshGlazebrook/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshGlazebrook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshGlazebrook/subscriptions","organizations_url":"https://api.github.com/users/JoshGlazebrook/orgs","repos_url":"https://api.github.com/users/JoshGlazebrook/repos","events_url":"https://api.github.com/users/JoshGlazebrook/events{/privacy}","received_events_url":"https://api.github.com/users/JoshGlazebrook/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JoshGlazebrook/socks","description":"Fully featured SOCKS proxy client supporting SOCKSv4, SOCKSv4a, and SOCKSv5. Includes Bind and Associate functionality.","fork":false,"url":"https://api.github.com/repos/JoshGlazebrook/socks","forks_url":"https://api.github.com/repos/JoshGlazebrook/socks/forks","keys_url":"https://api.github.com/repos/JoshGlazebrook/socks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JoshGlazebrook/socks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JoshGlazebrook/socks/teams","hooks_url":"https://api.github.com/repos/JoshGlazebrook/socks/hooks","issue_events_url":"https://api.github.com/repos/JoshGlazebrook/socks/issues/events{/number}","events_url":"https://api.github.com/repos/JoshGlazebrook/socks/events","assignees_url":"https://api.github.com/repos/JoshGlazebrook/socks/assignees{/user}","branches_url":"https://api.github.com/repos/JoshGlazebrook/socks/branches{/branch}","tags_url":"https://api.github.com/repos/JoshGlazebrook/socks/tags","blobs_url":"https://api.github.com/repos/JoshGlazebrook/socks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JoshGlazebrook/socks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JoshGlazebrook/socks/git/refs{/sha}","trees_url":"https://api.github.com/repos/JoshGlazebrook/socks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JoshGlazebrook/socks/statuses/{sha}","languages_url":"https://api.github.com/repos/JoshGlazebrook/socks/languages","stargazers_url":"https://api.github.com/repos/JoshGlazebrook/socks/stargazers","contributors_url":"https://api.github.com/repos/JoshGlazebrook/socks/contributors","subscribers_url":"https://api.github.com/repos/JoshGlazebrook/socks/subscribers","subscription_url":"https://api.github.com/repos/JoshGlazebrook/socks/subscription","commits_url":"https://api.github.com/repos/JoshGlazebrook/socks/commits{/sha}","git_commits_url":"https://api.github.com/repos/JoshGlazebrook/socks/git/commits{/sha}","comments_url":"https://api.github.com/repos/JoshGlazebrook/socks/comments{/number}","issue_comment_url":"https://api.github.com/repos/JoshGlazebrook/socks/issues/comments{/number}","contents_url":"https://api.github.com/repos/JoshGlazebrook/socks/contents/{+path}","compare_url":"https://api.github.com/repos/JoshGlazebrook/socks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JoshGlazebrook/socks/merges","archive_url":"https://api.github.com/repos/JoshGlazebrook/socks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JoshGlazebrook/socks/downloads","issues_url":"https://api.github.com/repos/JoshGlazebrook/socks/issues{/number}","pulls_url":"https://api.github.com/repos/JoshGlazebrook/socks/pulls{/number}","milestones_url":"https://api.github.com/repos/JoshGlazebrook/socks/milestones{/number}","notifications_url":"https://api.github.com/repos/JoshGlazebrook/socks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JoshGlazebrook/socks/labels{/name}","releases_url":"https://api.github.com/repos/JoshGlazebrook/socks/releases{/id}","deployments_url":"https://api.github.com/repos/JoshGlazebrook/socks/deployments","created_at":"2013-12-10T14:10:14Z","updated_at":"2018-03-25T03:52:24Z","pushed_at":"2018-03-22T22:30:41Z","git_url":"git://github.com/JoshGlazebrook/socks.git","ssh_url":"git@github.com:JoshGlazebrook/socks.git","clone_url":"https://github.com/JoshGlazebrook/socks.git","svn_url":"https://github.com/JoshGlazebrook/socks","homepage":"https://www.npmjs.com/package/socks","size":821,"stargazers_count":64,"watchers_count":64,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":8,"open_issues":1,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JoshGlazebrook/socks/pulls/29"},"html":{"href":"https://github.com/JoshGlazebrook/socks/pull/29"},"issue":{"href":"https://api.github.com/repos/JoshGlazebrook/socks/issues/29"},"comments":{"href":"https://api.github.com/repos/JoshGlazebrook/socks/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/JoshGlazebrook/socks/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/JoshGlazebrook/socks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JoshGlazebrook/socks/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/JoshGlazebrook/socks/statuses/f22120549c2b404b42438ee25601dd9523f404c1"}},"author_association":"NONE"}}
{"actor":{"display_login":"JoshGlazebrook"}}