{"action":"created","comment":{"url":"https://api.github.com/repos/WOnder93/argon2/pulls/comments/197761003","pull_request_review_id":131564847,"id":197761003,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Nzc2MTAwMw==","diff_hunk":"@@ -134,7 +134,7 @@ void secure_wipe_memory(void *v, size_t n);\n  * @param mem Pointer to the memory\n  * @param s Memory size in bytes\n  */\n-void clear_internal_memory(void *v, size_t n);\n+ARGON2_API void clear_internal_memory(void *v, size_t n);","path":"lib/core.h","position":5,"original_position":5,"commit_id":"079e77f600365086f493dee0d35e9846cdf41096","original_commit_id":"079e77f600365086f493dee0d35e9846cdf41096","user":{"login":"dmikushin","id":5672874,"node_id":"MDQ6VXNlcjU2NzI4NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5672874?v=4","gravatar_id":"","url":"https://api.github.com/users/dmikushin","html_url":"https://github.com/dmikushin","followers_url":"https://api.github.com/users/dmikushin/followers","following_url":"https://api.github.com/users/dmikushin/following{/other_user}","gists_url":"https://api.github.com/users/dmikushin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmikushin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmikushin/subscriptions","organizations_url":"https://api.github.com/users/dmikushin/orgs","repos_url":"https://api.github.com/users/dmikushin/repos","events_url":"https://api.github.com/users/dmikushin/events{/privacy}","received_events_url":"https://api.github.com/users/dmikushin/received_events","type":"User","site_admin":false},"body":"From my perspective it looks like this. There are 3 projects: `argon2`, `argon2-exec` and `argon2-test`. The first one defines `clear_internal_memory`, two others make use of it in `test.c` and `run.c`.  Hence, there is a link error without export.","created_at":"2018-06-25T11:21:13Z","updated_at":"2018-06-25T11:21:13Z","html_url":"https://github.com/WOnder93/argon2/pull/1#discussion_r197761003","pull_request_url":"https://api.github.com/repos/WOnder93/argon2/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/WOnder93/argon2/pulls/comments/197761003"},"html":{"href":"https://github.com/WOnder93/argon2/pull/1#discussion_r197761003"},"pull_request":{"href":"https://api.github.com/repos/WOnder93/argon2/pulls/1"}},"in_reply_to_id":197758794},"pull_request":{"url":"https://api.github.com/repos/WOnder93/argon2/pulls/1","id":196977200,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2OTc3MjAw","html_url":"https://github.com/WOnder93/argon2/pull/1","diff_url":"https://github.com/WOnder93/argon2/pull/1.diff","patch_url":"https://github.com/WOnder93/argon2/pull/1.patch","issue_url":"https://api.github.com/repos/WOnder93/argon2/issues/1","number":1,"state":"open","locked":false,"title":"Fixes for Windows","user":{"login":"dmikushin","id":5672874,"node_id":"MDQ6VXNlcjU2NzI4NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5672874?v=4","gravatar_id":"","url":"https://api.github.com/users/dmikushin","html_url":"https://github.com/dmikushin","followers_url":"https://api.github.com/users/dmikushin/followers","following_url":"https://api.github.com/users/dmikushin/following{/other_user}","gists_url":"https://api.github.com/users/dmikushin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmikushin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmikushin/subscriptions","organizations_url":"https://api.github.com/users/dmikushin/orgs","repos_url":"https://api.github.com/users/dmikushin/repos","events_url":"https://api.github.com/users/dmikushin/events{/privacy}","received_events_url":"https://api.github.com/users/dmikushin/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-24T23:57:46Z","updated_at":"2018-06-25T11:21:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5cf12eeab2f0e350f6cbb7fb69727cb6d173906f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/WOnder93/argon2/pulls/1/commits","review_comments_url":"https://api.github.com/repos/WOnder93/argon2/pulls/1/comments","review_comment_url":"https://api.github.com/repos/WOnder93/argon2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WOnder93/argon2/issues/1/comments","statuses_url":"https://api.github.com/repos/WOnder93/argon2/statuses/079e77f600365086f493dee0d35e9846cdf41096","head":{"label":"dmikushin:master","ref":"master","sha":"079e77f600365086f493dee0d35e9846cdf41096","user":{"login":"dmikushin","id":5672874,"node_id":"MDQ6VXNlcjU2NzI4NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5672874?v=4","gravatar_id":"","url":"https://api.github.com/users/dmikushin","html_url":"https://github.com/dmikushin","followers_url":"https://api.github.com/users/dmikushin/followers","following_url":"https://api.github.com/users/dmikushin/following{/other_user}","gists_url":"https://api.github.com/users/dmikushin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmikushin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmikushin/subscriptions","organizations_url":"https://api.github.com/users/dmikushin/orgs","repos_url":"https://api.github.com/users/dmikushin/repos","events_url":"https://api.github.com/users/dmikushin/events{/privacy}","received_events_url":"https://api.github.com/users/dmikushin/received_events","type":"User","site_admin":false},"repo":{"id":138523864,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg1MjM4NjQ=","name":"argon2","full_name":"dmikushin/argon2","owner":{"login":"dmikushin","id":5672874,"node_id":"MDQ6VXNlcjU2NzI4NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5672874?v=4","gravatar_id":"","url":"https://api.github.com/users/dmikushin","html_url":"https://github.com/dmikushin","followers_url":"https://api.github.com/users/dmikushin/followers","following_url":"https://api.github.com/users/dmikushin/following{/other_user}","gists_url":"https://api.github.com/users/dmikushin/gists{/gist_id}","starred_url":"https://api.github.com/users/dmikushin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmikushin/subscriptions","organizations_url":"https://api.github.com/users/dmikushin/orgs","repos_url":"https://api.github.com/users/dmikushin/repos","events_url":"https://api.github.com/users/dmikushin/events{/privacy}","received_events_url":"https://api.github.com/users/dmikushin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmikushin/argon2","description":"A multi-arch library implementing the Argon2 password hashing algorithm.","fork":true,"url":"https://api.github.com/repos/dmikushin/argon2","forks_url":"https://api.github.com/repos/dmikushin/argon2/forks","keys_url":"https://api.github.com/repos/dmikushin/argon2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmikushin/argon2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmikushin/argon2/teams","hooks_url":"https://api.github.com/repos/dmikushin/argon2/hooks","issue_events_url":"https://api.github.com/repos/dmikushin/argon2/issues/events{/number}","events_url":"https://api.github.com/repos/dmikushin/argon2/events","assignees_url":"https://api.github.com/repos/dmikushin/argon2/assignees{/user}","branches_url":"https://api.github.com/repos/dmikushin/argon2/branches{/branch}","tags_url":"https://api.github.com/repos/dmikushin/argon2/tags","blobs_url":"https://api.github.com/repos/dmikushin/argon2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmikushin/argon2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmikushin/argon2/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmikushin/argon2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmikushin/argon2/statuses/{sha}","languages_url":"https://api.github.com/repos/dmikushin/argon2/languages","stargazers_url":"https://api.github.com/repos/dmikushin/argon2/stargazers","contributors_url":"https://api.github.com/repos/dmikushin/argon2/contributors","subscribers_url":"https://api.github.com/repos/dmikushin/argon2/subscribers","subscription_url":"https://api.github.com/repos/dmikushin/argon2/subscription","commits_url":"https://api.github.com/repos/dmikushin/argon2/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmikushin/argon2/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmikushin/argon2/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmikushin/argon2/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmikushin/argon2/contents/{+path}","compare_url":"https://api.github.com/repos/dmikushin/argon2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmikushin/argon2/merges","archive_url":"https://api.github.com/repos/dmikushin/argon2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmikushin/argon2/downloads","issues_url":"https://api.github.com/repos/dmikushin/argon2/issues{/number}","pulls_url":"https://api.github.com/repos/dmikushin/argon2/pulls{/number}","milestones_url":"https://api.github.com/repos/dmikushin/argon2/milestones{/number}","notifications_url":"https://api.github.com/repos/dmikushin/argon2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmikushin/argon2/labels{/name}","releases_url":"https://api.github.com/repos/dmikushin/argon2/releases{/id}","deployments_url":"https://api.github.com/repos/dmikushin/argon2/deployments","created_at":"2018-06-24T23:55:45Z","updated_at":"2018-06-25T09:54:24Z","pushed_at":"2018-06-25T09:54:22Z","git_url":"git://github.com/dmikushin/argon2.git","ssh_url":"git@github.com:dmikushin/argon2.git","clone_url":"https://github.com/dmikushin/argon2.git","svn_url":"https://github.com/dmikushin/argon2","homepage":null,"size":152,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"WOnder93:master","ref":"master","sha":"57478dff430e8906560f75db57b24bc3a2892615","user":{"login":"WOnder93","id":3041388,"node_id":"MDQ6VXNlcjMwNDEzODg=","avatar_url":"https://avatars1.githubusercontent.com/u/3041388?v=4","gravatar_id":"","url":"https://api.github.com/users/WOnder93","html_url":"https://github.com/WOnder93","followers_url":"https://api.github.com/users/WOnder93/followers","following_url":"https://api.github.com/users/WOnder93/following{/other_user}","gists_url":"https://api.github.com/users/WOnder93/gists{/gist_id}","starred_url":"https://api.github.com/users/WOnder93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WOnder93/subscriptions","organizations_url":"https://api.github.com/users/WOnder93/orgs","repos_url":"https://api.github.com/users/WOnder93/repos","events_url":"https://api.github.com/users/WOnder93/events{/privacy}","received_events_url":"https://api.github.com/users/WOnder93/received_events","type":"User","site_admin":false},"repo":{"id":65627007,"node_id":"MDEwOlJlcG9zaXRvcnk2NTYyNzAwNw==","name":"argon2","full_name":"WOnder93/argon2","owner":{"login":"WOnder93","id":3041388,"node_id":"MDQ6VXNlcjMwNDEzODg=","avatar_url":"https://avatars1.githubusercontent.com/u/3041388?v=4","gravatar_id":"","url":"https://api.github.com/users/WOnder93","html_url":"https://github.com/WOnder93","followers_url":"https://api.github.com/users/WOnder93/followers","following_url":"https://api.github.com/users/WOnder93/following{/other_user}","gists_url":"https://api.github.com/users/WOnder93/gists{/gist_id}","starred_url":"https://api.github.com/users/WOnder93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WOnder93/subscriptions","organizations_url":"https://api.github.com/users/WOnder93/orgs","repos_url":"https://api.github.com/users/WOnder93/repos","events_url":"https://api.github.com/users/WOnder93/events{/privacy}","received_events_url":"https://api.github.com/users/WOnder93/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WOnder93/argon2","description":"A multi-arch library implementing the Argon2 password hashing algorithm.","fork":false,"url":"https://api.github.com/repos/WOnder93/argon2","forks_url":"https://api.github.com/repos/WOnder93/argon2/forks","keys_url":"https://api.github.com/repos/WOnder93/argon2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WOnder93/argon2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WOnder93/argon2/teams","hooks_url":"https://api.github.com/repos/WOnder93/argon2/hooks","issue_events_url":"https://api.github.com/repos/WOnder93/argon2/issues/events{/number}","events_url":"https://api.github.com/repos/WOnder93/argon2/events","assignees_url":"https://api.github.com/repos/WOnder93/argon2/assignees{/user}","branches_url":"https://api.github.com/repos/WOnder93/argon2/branches{/branch}","tags_url":"https://api.github.com/repos/WOnder93/argon2/tags","blobs_url":"https://api.github.com/repos/WOnder93/argon2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WOnder93/argon2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WOnder93/argon2/git/refs{/sha}","trees_url":"https://api.github.com/repos/WOnder93/argon2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WOnder93/argon2/statuses/{sha}","languages_url":"https://api.github.com/repos/WOnder93/argon2/languages","stargazers_url":"https://api.github.com/repos/WOnder93/argon2/stargazers","contributors_url":"https://api.github.com/repos/WOnder93/argon2/contributors","subscribers_url":"https://api.github.com/repos/WOnder93/argon2/subscribers","subscription_url":"https://api.github.com/repos/WOnder93/argon2/subscription","commits_url":"https://api.github.com/repos/WOnder93/argon2/commits{/sha}","git_commits_url":"https://api.github.com/repos/WOnder93/argon2/git/commits{/sha}","comments_url":"https://api.github.com/repos/WOnder93/argon2/comments{/number}","issue_comment_url":"https://api.github.com/repos/WOnder93/argon2/issues/comments{/number}","contents_url":"https://api.github.com/repos/WOnder93/argon2/contents/{+path}","compare_url":"https://api.github.com/repos/WOnder93/argon2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WOnder93/argon2/merges","archive_url":"https://api.github.com/repos/WOnder93/argon2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WOnder93/argon2/downloads","issues_url":"https://api.github.com/repos/WOnder93/argon2/issues{/number}","pulls_url":"https://api.github.com/repos/WOnder93/argon2/pulls{/number}","milestones_url":"https://api.github.com/repos/WOnder93/argon2/milestones{/number}","notifications_url":"https://api.github.com/repos/WOnder93/argon2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WOnder93/argon2/labels{/name}","releases_url":"https://api.github.com/repos/WOnder93/argon2/releases{/id}","deployments_url":"https://api.github.com/repos/WOnder93/argon2/deployments","created_at":"2016-08-13T16:43:01Z","updated_at":"2018-02-10T16:03:52Z","pushed_at":"2018-06-25T09:54:23Z","git_url":"git://github.com/WOnder93/argon2.git","ssh_url":"git@github.com:WOnder93/argon2.git","clone_url":"https://github.com/WOnder93/argon2.git","svn_url":"https://github.com/WOnder93/argon2","homepage":null,"size":150,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WOnder93/argon2/pulls/1"},"html":{"href":"https://github.com/WOnder93/argon2/pull/1"},"issue":{"href":"https://api.github.com/repos/WOnder93/argon2/issues/1"},"comments":{"href":"https://api.github.com/repos/WOnder93/argon2/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/WOnder93/argon2/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/WOnder93/argon2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WOnder93/argon2/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/WOnder93/argon2/statuses/079e77f600365086f493dee0d35e9846cdf41096"}},"author_association":"NONE"}}
{"actor":{"display_login":"dmikushin"}}