{"action":"closed","number":195,"pull_request":{"url":"https://api.github.com/repos/eclipse/efxclipse-rt/pulls/195","id":177425594,"html_url":"https://github.com/eclipse/efxclipse-rt/pull/195","diff_url":"https://github.com/eclipse/efxclipse-rt/pull/195.diff","patch_url":"https://github.com/eclipse/efxclipse-rt/pull/195.patch","issue_url":"https://api.github.com/repos/eclipse/efxclipse-rt/issues/195","number":195,"state":"closed","locked":false,"title":"Implement the base field editors, as well as Apply/Restore defaults","user":{"login":"CamilleLetavernier","id":16717379,"avatar_url":"https://avatars3.githubusercontent.com/u/16717379?v=4","gravatar_id":"","url":"https://api.github.com/users/CamilleLetavernier","html_url":"https://github.com/CamilleLetavernier","followers_url":"https://api.github.com/users/CamilleLetavernier/followers","following_url":"https://api.github.com/users/CamilleLetavernier/following{/other_user}","gists_url":"https://api.github.com/users/CamilleLetavernier/gists{/gist_id}","starred_url":"https://api.github.com/users/CamilleLetavernier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CamilleLetavernier/subscriptions","organizations_url":"https://api.github.com/users/CamilleLetavernier/orgs","repos_url":"https://api.github.com/users/CamilleLetavernier/repos","events_url":"https://api.github.com/users/CamilleLetavernier/events{/privacy}","received_events_url":"https://api.github.com/users/CamilleLetavernier/received_events","type":"User","site_admin":false},"body":"This PR contains the following field editors:\r\n\r\n- Boolean\r\n- Integer\r\n- String\r\n- Color\r\n- Directory\r\n\r\nIt also implements the \"Apply\" (Persist) and \"Restore Defaults\" buttons and corresponding actions. Regarding the Restore Defaults, there is a variation between the current approach in EclipseFX and the way it is done in JFace.\r\n\r\nIn JFace, the FieldEditor is responsible for loading the Default value from the PreferenceStore (Memento), and the default value is propagated to the store only when \"Apply\" is pressed. In this PR, the value is reset on the Memento directly, and then the FieldEditor is updated.\r\n\r\nWe can easily change that; it would simply require a new method on the FieldEditor to restore the defaults. However, since the RestoreDefaults command is Optional in the API, I'm not sure what the initial intent was regarding the responsibility of implementing this action. Should each preference page override it? Or should we provide a generic restore defaults action, and rely on the Memento to provide the correct defaults?","created_at":"2018-03-26T12:08:46Z","updated_at":"2018-03-26T12:26:06Z","closed_at":"2018-03-26T12:26:05Z","merged_at":"2018-03-26T12:26:05Z","merge_commit_sha":"16d95c60776773fc8c055ddcd4e9c4dea2006c06","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/efxclipse-rt/pulls/195/commits","review_comments_url":"https://api.github.com/repos/eclipse/efxclipse-rt/pulls/195/comments","review_comment_url":"https://api.github.com/repos/eclipse/efxclipse-rt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/efxclipse-rt/issues/195/comments","statuses_url":"https://api.github.com/repos/eclipse/efxclipse-rt/statuses/be0fcc9df984f390d44f4d831a01e35ea69bec82","head":{"label":"CamilleLetavernier:194_Implement_a_Preference-Editor-System_similar_to_JFace-Preference","ref":"194_Implement_a_Preference-Editor-System_similar_to_JFace-Preference","sha":"be0fcc9df984f390d44f4d831a01e35ea69bec82","user":{"login":"CamilleLetavernier","id":16717379,"avatar_url":"https://avatars3.githubusercontent.com/u/16717379?v=4","gravatar_id":"","url":"https://api.github.com/users/CamilleLetavernier","html_url":"https://github.com/CamilleLetavernier","followers_url":"https://api.github.com/users/CamilleLetavernier/followers","following_url":"https://api.github.com/users/CamilleLetavernier/following{/other_user}","gists_url":"https://api.github.com/users/CamilleLetavernier/gists{/gist_id}","starred_url":"https://api.github.com/users/CamilleLetavernier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CamilleLetavernier/subscriptions","organizations_url":"https://api.github.com/users/CamilleLetavernier/orgs","repos_url":"https://api.github.com/users/CamilleLetavernier/repos","events_url":"https://api.github.com/users/CamilleLetavernier/events{/privacy}","received_events_url":"https://api.github.com/users/CamilleLetavernier/received_events","type":"User","site_admin":false},"repo":{"id":126822217,"name":"efxclipse-rt","full_name":"CamilleLetavernier/efxclipse-rt","owner":{"login":"CamilleLetavernier","id":16717379,"avatar_url":"https://avatars3.githubusercontent.com/u/16717379?v=4","gravatar_id":"","url":"https://api.github.com/users/CamilleLetavernier","html_url":"https://github.com/CamilleLetavernier","followers_url":"https://api.github.com/users/CamilleLetavernier/followers","following_url":"https://api.github.com/users/CamilleLetavernier/following{/other_user}","gists_url":"https://api.github.com/users/CamilleLetavernier/gists{/gist_id}","starred_url":"https://api.github.com/users/CamilleLetavernier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CamilleLetavernier/subscriptions","organizations_url":"https://api.github.com/users/CamilleLetavernier/orgs","repos_url":"https://api.github.com/users/CamilleLetavernier/repos","events_url":"https://api.github.com/users/CamilleLetavernier/events{/privacy}","received_events_url":"https://api.github.com/users/CamilleLetavernier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CamilleLetavernier/efxclipse-rt","description":null,"fork":true,"url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt","forks_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/forks","keys_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/teams","hooks_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/hooks","issue_events_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/issues/events{/number}","events_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/events","assignees_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/assignees{/user}","branches_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/branches{/branch}","tags_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/tags","blobs_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/git/refs{/sha}","trees_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/statuses/{sha}","languages_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/languages","stargazers_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/stargazers","contributors_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/contributors","subscribers_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/subscribers","subscription_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/subscription","commits_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/commits{/sha}","git_commits_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/git/commits{/sha}","comments_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/comments{/number}","issue_comment_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/issues/comments{/number}","contents_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/contents/{+path}","compare_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/merges","archive_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/downloads","issues_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/issues{/number}","pulls_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/pulls{/number}","milestones_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/milestones{/number}","notifications_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/labels{/name}","releases_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/releases{/id}","deployments_url":"https://api.github.com/repos/CamilleLetavernier/efxclipse-rt/deployments","created_at":"2018-03-26T12:01:16Z","updated_at":"2018-03-26T12:01:26Z","pushed_at":"2018-03-26T12:25:46Z","git_url":"git://github.com/CamilleLetavernier/efxclipse-rt.git","ssh_url":"git@github.com:CamilleLetavernier/efxclipse-rt.git","clone_url":"https://github.com/CamilleLetavernier/efxclipse-rt.git","svn_url":"https://github.com/CamilleLetavernier/efxclipse-rt","homepage":null,"size":71148,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:194_Implement_a_Preference-Editor-System_similar_to_JFace-Preference","ref":"194_Implement_a_Preference-Editor-System_similar_to_JFace-Preference","sha":"c22d8d05b9d43a6245fdb676eac5122c322c7965","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":81337522,"name":"efxclipse-rt","full_name":"eclipse/efxclipse-rt","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/efxclipse-rt","description":null,"fork":false,"url":"https://api.github.com/repos/eclipse/efxclipse-rt","forks_url":"https://api.github.com/repos/eclipse/efxclipse-rt/forks","keys_url":"https://api.github.com/repos/eclipse/efxclipse-rt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/efxclipse-rt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/efxclipse-rt/teams","hooks_url":"https://api.github.com/repos/eclipse/efxclipse-rt/hooks","issue_events_url":"https://api.github.com/repos/eclipse/efxclipse-rt/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/efxclipse-rt/events","assignees_url":"https://api.github.com/repos/eclipse/efxclipse-rt/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/efxclipse-rt/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/efxclipse-rt/tags","blobs_url":"https://api.github.com/repos/eclipse/efxclipse-rt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/efxclipse-rt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/efxclipse-rt/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/efxclipse-rt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/efxclipse-rt/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/efxclipse-rt/languages","stargazers_url":"https://api.github.com/repos/eclipse/efxclipse-rt/stargazers","contributors_url":"https://api.github.com/repos/eclipse/efxclipse-rt/contributors","subscribers_url":"https://api.github.com/repos/eclipse/efxclipse-rt/subscribers","subscription_url":"https://api.github.com/repos/eclipse/efxclipse-rt/subscription","commits_url":"https://api.github.com/repos/eclipse/efxclipse-rt/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/efxclipse-rt/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/efxclipse-rt/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/efxclipse-rt/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/efxclipse-rt/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/efxclipse-rt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/efxclipse-rt/merges","archive_url":"https://api.github.com/repos/eclipse/efxclipse-rt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/efxclipse-rt/downloads","issues_url":"https://api.github.com/repos/eclipse/efxclipse-rt/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/efxclipse-rt/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/efxclipse-rt/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/efxclipse-rt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/efxclipse-rt/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/efxclipse-rt/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/efxclipse-rt/deployments","created_at":"2017-02-08T14:21:24Z","updated_at":"2017-12-21T07:48:09Z","pushed_at":"2018-03-26T12:26:05Z","git_url":"git://github.com/eclipse/efxclipse-rt.git","ssh_url":"git@github.com:eclipse/efxclipse-rt.git","clone_url":"https://github.com/eclipse/efxclipse-rt.git","svn_url":"https://github.com/eclipse/efxclipse-rt","homepage":null,"size":71148,"stargazers_count":10,"watchers_count":10,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":26,"license":null,"forks":8,"open_issues":26,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/efxclipse-rt/pulls/195"},"html":{"href":"https://github.com/eclipse/efxclipse-rt/pull/195"},"issue":{"href":"https://api.github.com/repos/eclipse/efxclipse-rt/issues/195"},"comments":{"href":"https://api.github.com/repos/eclipse/efxclipse-rt/issues/195/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/efxclipse-rt/pulls/195/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/efxclipse-rt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/efxclipse-rt/pulls/195/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/efxclipse-rt/statuses/be0fcc9df984f390d44f4d831a01e35ea69bec82"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tomsontom","id":52631,"avatar_url":"https://avatars0.githubusercontent.com/u/52631?v=4","gravatar_id":"","url":"https://api.github.com/users/tomsontom","html_url":"https://github.com/tomsontom","followers_url":"https://api.github.com/users/tomsontom/followers","following_url":"https://api.github.com/users/tomsontom/following{/other_user}","gists_url":"https://api.github.com/users/tomsontom/gists{/gist_id}","starred_url":"https://api.github.com/users/tomsontom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomsontom/subscriptions","organizations_url":"https://api.github.com/users/tomsontom/orgs","repos_url":"https://api.github.com/users/tomsontom/repos","events_url":"https://api.github.com/users/tomsontom/events{/privacy}","received_events_url":"https://api.github.com/users/tomsontom/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":353,"deletions":43,"changed_files":10}}
{"actor":{"display_login":"tomsontom"}}