{"action":"created","comment":{"url":"https://api.github.com/repos/astropy/astropy/pulls/comments/193122464","pull_request_review_id":126032195,"id":193122464,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzEyMjQ2NA==","diff_hunk":"@@ -74,7 +74,23 @@ def test_array_comparison():\n                    '  at [0, 2]:\\n'\n                    '    a> 2\\n'\n                    '    b> 3\\n'\n-                   '  ...and at 78 more indices.\\n')\n+                   '  ...and at 6 more indices.\\n')\n+\n+\n+def test_diff_shaped_array_comparison():\n+    \"\"\"\n+    Test diff-ing two differently shaped arrays.\n+    \"\"\"\n+    f = io.StringIO()\n+    a = np.empty((1, 2, 3))\n+    b = np.empty((2, 3))","path":"astropy/utils/tests/test_diff.py","position":14,"original_position":14,"commit_id":"22352e4b490fd95566d5780a6cf71130ebd2db5c","original_commit_id":"22352e4b490fd95566d5780a6cf71130ebd2db5c","user":{"login":"mcara","id":5985250,"node_id":"MDQ6VXNlcjU5ODUyNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5985250?v=4","gravatar_id":"","url":"https://api.github.com/users/mcara","html_url":"https://github.com/mcara","followers_url":"https://api.github.com/users/mcara/followers","following_url":"https://api.github.com/users/mcara/following{/other_user}","gists_url":"https://api.github.com/users/mcara/gists{/gist_id}","starred_url":"https://api.github.com/users/mcara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcara/subscriptions","organizations_url":"https://api.github.com/users/mcara/orgs","repos_url":"https://api.github.com/users/mcara/repos","events_url":"https://api.github.com/users/mcara/events{/privacy}","received_events_url":"https://api.github.com/users/mcara/received_events","type":"User","site_admin":false},"body":"@pllim Oh, I was thinking about something else. Yes, this should work.","created_at":"2018-06-05T15:42:13Z","updated_at":"2018-06-05T15:42:13Z","html_url":"https://github.com/astropy/astropy/pull/7470#discussion_r193122464","pull_request_url":"https://api.github.com/repos/astropy/astropy/pulls/7470","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments/193122464"},"html":{"href":"https://github.com/astropy/astropy/pull/7470#discussion_r193122464"},"pull_request":{"href":"https://api.github.com/repos/astropy/astropy/pulls/7470"}},"in_reply_to_id":192878472},"pull_request":{"url":"https://api.github.com/repos/astropy/astropy/pulls/7470","id":188224585,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg4MjI0NTg1","html_url":"https://github.com/astropy/astropy/pull/7470","diff_url":"https://github.com/astropy/astropy/pull/7470.diff","patch_url":"https://github.com/astropy/astropy/pull/7470.patch","issue_url":"https://api.github.com/repos/astropy/astropy/issues/7470","number":7470,"state":"open","locked":false,"title":"Code revision in diff.py","user":{"login":"mcara","id":5985250,"node_id":"MDQ6VXNlcjU5ODUyNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5985250?v=4","gravatar_id":"","url":"https://api.github.com/users/mcara","html_url":"https://github.com/mcara","followers_url":"https://api.github.com/users/mcara/followers","following_url":"https://api.github.com/users/mcara/following{/other_user}","gists_url":"https://api.github.com/users/mcara/gists{/gist_id}","starred_url":"https://api.github.com/users/mcara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcara/subscriptions","organizations_url":"https://api.github.com/users/mcara/orgs","repos_url":"https://api.github.com/users/mcara/repos","events_url":"https://api.github.com/users/mcara/events{/privacy}","received_events_url":"https://api.github.com/users/mcara/received_events","type":"User","site_admin":false},"body":"This PR cleans up the code a little and moves constant (relative to the loop) operations out of the loop. See https://github.com/astropy/astropy/issues/7468 and the links provided there.\r\n\r\nEDIT: Fix #7468 . Follow up of #7444","created_at":"2018-05-15T19:01:12Z","updated_at":"2018-06-05T15:42:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"805eb5e6c09b1022908fbd6f3fe92da74902e7d5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":68702403,"node_id":"MDU6TGFiZWw2ODcwMjQwMw==","url":"https://api.github.com/repos/astropy/astropy/labels/Affects-dev","name":"Affects-dev","color":"d93f0b","default":false},{"id":316473427,"node_id":"MDU6TGFiZWwzMTY0NzM0Mjc=","url":"https://api.github.com/repos/astropy/astropy/labels/Refactoring","name":"Refactoring","color":"fef2c0","default":false},{"id":375279796,"node_id":"MDU6TGFiZWwzNzUyNzk3OTY=","url":"https://api.github.com/repos/astropy/astropy/labels/no-changelog-entry-needed","name":"no-changelog-entry-needed","color":"c2e0c6","default":false},{"id":42438611,"node_id":"MDU6TGFiZWw0MjQzODYxMQ==","url":"https://api.github.com/repos/astropy/astropy/labels/utils","name":"utils","color":"c7def8","default":false}],"milestone":{"url":"https://api.github.com/repos/astropy/astropy/milestones/52","html_url":"https://github.com/astropy/astropy/milestone/52","labels_url":"https://api.github.com/repos/astropy/astropy/milestones/52/labels","id":2929745,"node_id":"MDk6TWlsZXN0b25lMjkyOTc0NQ==","number":52,"title":"v3.1","description":"","creator":{"login":"eteq","id":346587,"node_id":"MDQ6VXNlcjM0NjU4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/346587?v=4","gravatar_id":"","url":"https://api.github.com/users/eteq","html_url":"https://github.com/eteq","followers_url":"https://api.github.com/users/eteq/followers","following_url":"https://api.github.com/users/eteq/following{/other_user}","gists_url":"https://api.github.com/users/eteq/gists{/gist_id}","starred_url":"https://api.github.com/users/eteq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eteq/subscriptions","organizations_url":"https://api.github.com/users/eteq/orgs","repos_url":"https://api.github.com/users/eteq/repos","events_url":"https://api.github.com/users/eteq/events{/privacy}","received_events_url":"https://api.github.com/users/eteq/received_events","type":"User","site_admin":false},"open_issues":75,"closed_issues":52,"state":"open","created_at":"2017-11-21T23:24:18Z","updated_at":"2018-06-04T22:23:42Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/astropy/astropy/pulls/7470/commits","review_comments_url":"https://api.github.com/repos/astropy/astropy/pulls/7470/comments","review_comment_url":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/7470/comments","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/22352e4b490fd95566d5780a6cf71130ebd2db5c","head":{"label":"mcara:fitsdiff-code-revision","ref":"fitsdiff-code-revision","sha":"22352e4b490fd95566d5780a6cf71130ebd2db5c","user":{"login":"mcara","id":5985250,"node_id":"MDQ6VXNlcjU5ODUyNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5985250?v=4","gravatar_id":"","url":"https://api.github.com/users/mcara","html_url":"https://github.com/mcara","followers_url":"https://api.github.com/users/mcara/followers","following_url":"https://api.github.com/users/mcara/following{/other_user}","gists_url":"https://api.github.com/users/mcara/gists{/gist_id}","starred_url":"https://api.github.com/users/mcara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcara/subscriptions","organizations_url":"https://api.github.com/users/mcara/orgs","repos_url":"https://api.github.com/users/mcara/repos","events_url":"https://api.github.com/users/mcara/events{/privacy}","received_events_url":"https://api.github.com/users/mcara/received_events","type":"User","site_admin":false},"repo":{"id":52904214,"node_id":"MDEwOlJlcG9zaXRvcnk1MjkwNDIxNA==","name":"astropy","full_name":"mcara/astropy","owner":{"login":"mcara","id":5985250,"node_id":"MDQ6VXNlcjU5ODUyNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5985250?v=4","gravatar_id":"","url":"https://api.github.com/users/mcara","html_url":"https://github.com/mcara","followers_url":"https://api.github.com/users/mcara/followers","following_url":"https://api.github.com/users/mcara/following{/other_user}","gists_url":"https://api.github.com/users/mcara/gists{/gist_id}","starred_url":"https://api.github.com/users/mcara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcara/subscriptions","organizations_url":"https://api.github.com/users/mcara/orgs","repos_url":"https://api.github.com/users/mcara/repos","events_url":"https://api.github.com/users/mcara/events{/privacy}","received_events_url":"https://api.github.com/users/mcara/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcara/astropy","description":"Repository for the Astropy core package","fork":true,"url":"https://api.github.com/repos/mcara/astropy","forks_url":"https://api.github.com/repos/mcara/astropy/forks","keys_url":"https://api.github.com/repos/mcara/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcara/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcara/astropy/teams","hooks_url":"https://api.github.com/repos/mcara/astropy/hooks","issue_events_url":"https://api.github.com/repos/mcara/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/mcara/astropy/events","assignees_url":"https://api.github.com/repos/mcara/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/mcara/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/mcara/astropy/tags","blobs_url":"https://api.github.com/repos/mcara/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcara/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcara/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcara/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcara/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/mcara/astropy/languages","stargazers_url":"https://api.github.com/repos/mcara/astropy/stargazers","contributors_url":"https://api.github.com/repos/mcara/astropy/contributors","subscribers_url":"https://api.github.com/repos/mcara/astropy/subscribers","subscription_url":"https://api.github.com/repos/mcara/astropy/subscription","commits_url":"https://api.github.com/repos/mcara/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcara/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcara/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcara/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcara/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/mcara/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcara/astropy/merges","archive_url":"https://api.github.com/repos/mcara/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcara/astropy/downloads","issues_url":"https://api.github.com/repos/mcara/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/mcara/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/mcara/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/mcara/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcara/astropy/labels{/name}","releases_url":"https://api.github.com/repos/mcara/astropy/releases{/id}","deployments_url":"https://api.github.com/repos/mcara/astropy/deployments","created_at":"2016-03-01T19:35:26Z","updated_at":"2018-05-15T17:00:28Z","pushed_at":"2018-05-17T18:26:31Z","git_url":"git://github.com/mcara/astropy.git","ssh_url":"git@github.com:mcara/astropy.git","clone_url":"https://github.com/mcara/astropy.git","svn_url":"https://github.com/mcara/astropy","homepage":"www.astropy.org","size":65995,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"astropy:master","ref":"master","sha":"515a7ceb167ad195b62bf4a62a009392c8894ebd","user":{"login":"astropy","id":847984,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0Nzk4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":2081289,"node_id":"MDEwOlJlcG9zaXRvcnkyMDgxMjg5","name":"astropy","full_name":"astropy/astropy","owner":{"login":"astropy","id":847984,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0Nzk4NA==","avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astropy/astropy","description":"Repository for the Astropy core package","fork":false,"url":"https://api.github.com/repos/astropy/astropy","forks_url":"https://api.github.com/repos/astropy/astropy/forks","keys_url":"https://api.github.com/repos/astropy/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astropy/teams","hooks_url":"https://api.github.com/repos/astropy/astropy/hooks","issue_events_url":"https://api.github.com/repos/astropy/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astropy/events","assignees_url":"https://api.github.com/repos/astropy/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astropy/tags","blobs_url":"https://api.github.com/repos/astropy/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astropy/languages","stargazers_url":"https://api.github.com/repos/astropy/astropy/stargazers","contributors_url":"https://api.github.com/repos/astropy/astropy/contributors","subscribers_url":"https://api.github.com/repos/astropy/astropy/subscribers","subscription_url":"https://api.github.com/repos/astropy/astropy/subscription","commits_url":"https://api.github.com/repos/astropy/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astropy/merges","archive_url":"https://api.github.com/repos/astropy/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astropy/downloads","issues_url":"https://api.github.com/repos/astropy/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astropy/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astropy/releases{/id}","deployments_url":"https://api.github.com/repos/astropy/astropy/deployments","created_at":"2011-07-21T01:33:49Z","updated_at":"2018-06-05T14:24:58Z","pushed_at":"2018-06-04T21:25:40Z","git_url":"git://github.com/astropy/astropy.git","ssh_url":"git@github.com:astropy/astropy.git","clone_url":"https://github.com/astropy/astropy.git","svn_url":"https://github.com/astropy/astropy","homepage":"www.astropy.org","size":71597,"stargazers_count":1616,"watchers_count":1616,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":874,"mirror_url":null,"archived":false,"open_issues_count":874,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":874,"open_issues":874,"watchers":1616,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/7470"},"html":{"href":"https://github.com/astropy/astropy/pull/7470"},"issue":{"href":"https://api.github.com/repos/astropy/astropy/issues/7470"},"comments":{"href":"https://api.github.com/repos/astropy/astropy/issues/7470/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astropy/pulls/7470/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/astropy/pulls/7470/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astropy/statuses/22352e4b490fd95566d5780a6cf71130ebd2db5c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mcara"}}