{"action":"created","comment":{"url":"https://api.github.com/repos/ska-sa/katdal/pulls/comments/228855365","pull_request_review_id":169215106,"id":228855365,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODg1NTM2NQ==","diff_hunk":"@@ -101,11 +103,15 @@ class VisibilityDataV4(DataSet):\n         (default is first antenna in use)\n     time_offset : float, optional\n         Offset to add to all correlator timestamps, in seconds\n+    applycal : string, optional\n+        Comma-separated calibration products to apply to vis/weights/flags\n+        (default is no calibration)","path":"katdal/visdatav4.py","position":17,"original_position":17,"commit_id":"af0bfda54417ff83dd1b8e2b0adbcd7b7a2960ac","original_commit_id":"af0bfda54417ff83dd1b8e2b0adbcd7b7a2960ac","user":{"login":"ludwigschwardt","id":392144,"node_id":"MDQ6VXNlcjM5MjE0NA==","avatar_url":"https://avatars0.githubusercontent.com/u/392144?v=4","gravatar_id":"","url":"https://api.github.com/users/ludwigschwardt","html_url":"https://github.com/ludwigschwardt","followers_url":"https://api.github.com/users/ludwigschwardt/followers","following_url":"https://api.github.com/users/ludwigschwardt/following{/other_user}","gists_url":"https://api.github.com/users/ludwigschwardt/gists{/gist_id}","starred_url":"https://api.github.com/users/ludwigschwardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ludwigschwardt/subscriptions","organizations_url":"https://api.github.com/users/ludwigschwardt/orgs","repos_url":"https://api.github.com/users/ludwigschwardt/repos","events_url":"https://api.github.com/users/ludwigschwardt/events{/privacy}","received_events_url":"https://api.github.com/users/ludwigschwardt/received_events","type":"User","site_admin":false},"body":"Fixed to accept both forms of product lists, and added a note to the docstring about the future of `applycal`.","created_at":"2018-10-29T09:45:23Z","updated_at":"2018-10-29T09:45:24Z","html_url":"https://github.com/ska-sa/katdal/pull/198#discussion_r228855365","pull_request_url":"https://api.github.com/repos/ska-sa/katdal/pulls/198","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ska-sa/katdal/pulls/comments/228855365"},"html":{"href":"https://github.com/ska-sa/katdal/pull/198#discussion_r228855365"},"pull_request":{"href":"https://api.github.com/repos/ska-sa/katdal/pulls/198"}},"in_reply_to_id":228830930},"pull_request":{"url":"https://api.github.com/repos/ska-sa/katdal/pulls/198","id":226138081,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MTM4MDgx","html_url":"https://github.com/ska-sa/katdal/pull/198","diff_url":"https://github.com/ska-sa/katdal/pull/198.diff","patch_url":"https://github.com/ska-sa/katdal/pull/198.patch","issue_url":"https://api.github.com/repos/ska-sa/katdal/issues/198","number":198,"state":"open","locked":false,"title":"Make L1: apply to weights and flags and plumb it into v4","user":{"login":"ludwigschwardt","id":392144,"node_id":"MDQ6VXNlcjM5MjE0NA==","avatar_url":"https://avatars0.githubusercontent.com/u/392144?v=4","gravatar_id":"","url":"https://api.github.com/users/ludwigschwardt","html_url":"https://github.com/ludwigschwardt","followers_url":"https://api.github.com/users/ludwigschwardt/followers","following_url":"https://api.github.com/users/ludwigschwardt/following{/other_user}","gists_url":"https://api.github.com/users/ludwigschwardt/gists{/gist_id}","starred_url":"https://api.github.com/users/ludwigschwardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ludwigschwardt/subscriptions","organizations_url":"https://api.github.com/users/ludwigschwardt/orgs","repos_url":"https://api.github.com/users/ludwigschwardt/repos","events_url":"https://api.github.com/users/ludwigschwardt/events{/privacy}","received_events_url":"https://api.github.com/users/ludwigschwardt/received_events","type":"User","site_admin":false},"body":"Apply calibration corrections to weights and flags. The weights are divided by the magnitude squared of the corrections. The flags are set to True wherever the gains were invalid. This is\r\ndone after the flags are combined, on the boolean level (as opposed to the \"raw\" uint8 level). Ideally a new \"cal_failure\" flag type should be introduced instead, but that is left for a future PR.\r\n\r\nEnable applycal upon opening a v4 data set, by listing the desired cal products to apply. This is disabled by default for now until the functionality has been thoroughly vetted.\r\n\r\nThere are still some issues with the final version running on real data, which seems to be due to the multi-threading introduced by the default dask scheduler. Adding a lock to `get_cal_product` seems to fix this, but I'm leaving that to another future investigation.\r\n\r\n","created_at":"2018-10-26T15:27:09Z","updated_at":"2018-10-29T09:45:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5ebc97a285e87673d0af46a23e6a9bef8cef8fa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ska-sa/katdal/pulls/198/commits","review_comments_url":"https://api.github.com/repos/ska-sa/katdal/pulls/198/comments","review_comment_url":"https://api.github.com/repos/ska-sa/katdal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ska-sa/katdal/issues/198/comments","statuses_url":"https://api.github.com/repos/ska-sa/katdal/statuses/af0bfda54417ff83dd1b8e2b0adbcd7b7a2960ac","head":{"label":"ska-sa:make-l1-weights-flags","ref":"make-l1-weights-flags","sha":"af0bfda54417ff83dd1b8e2b0adbcd7b7a2960ac","user":{"login":"ska-sa","id":1210238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAyMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/1210238?v=4","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"repo":{"id":12869013,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg2OTAxMw==","name":"katdal","full_name":"ska-sa/katdal","private":false,"owner":{"login":"ska-sa","id":1210238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAyMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/1210238?v=4","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ska-sa/katdal","description":"Data access library for the MeerKAT project","fork":false,"url":"https://api.github.com/repos/ska-sa/katdal","forks_url":"https://api.github.com/repos/ska-sa/katdal/forks","keys_url":"https://api.github.com/repos/ska-sa/katdal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ska-sa/katdal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ska-sa/katdal/teams","hooks_url":"https://api.github.com/repos/ska-sa/katdal/hooks","issue_events_url":"https://api.github.com/repos/ska-sa/katdal/issues/events{/number}","events_url":"https://api.github.com/repos/ska-sa/katdal/events","assignees_url":"https://api.github.com/repos/ska-sa/katdal/assignees{/user}","branches_url":"https://api.github.com/repos/ska-sa/katdal/branches{/branch}","tags_url":"https://api.github.com/repos/ska-sa/katdal/tags","blobs_url":"https://api.github.com/repos/ska-sa/katdal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ska-sa/katdal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ska-sa/katdal/git/refs{/sha}","trees_url":"https://api.github.com/repos/ska-sa/katdal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ska-sa/katdal/statuses/{sha}","languages_url":"https://api.github.com/repos/ska-sa/katdal/languages","stargazers_url":"https://api.github.com/repos/ska-sa/katdal/stargazers","contributors_url":"https://api.github.com/repos/ska-sa/katdal/contributors","subscribers_url":"https://api.github.com/repos/ska-sa/katdal/subscribers","subscription_url":"https://api.github.com/repos/ska-sa/katdal/subscription","commits_url":"https://api.github.com/repos/ska-sa/katdal/commits{/sha}","git_commits_url":"https://api.github.com/repos/ska-sa/katdal/git/commits{/sha}","comments_url":"https://api.github.com/repos/ska-sa/katdal/comments{/number}","issue_comment_url":"https://api.github.com/repos/ska-sa/katdal/issues/comments{/number}","contents_url":"https://api.github.com/repos/ska-sa/katdal/contents/{+path}","compare_url":"https://api.github.com/repos/ska-sa/katdal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ska-sa/katdal/merges","archive_url":"https://api.github.com/repos/ska-sa/katdal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ska-sa/katdal/downloads","issues_url":"https://api.github.com/repos/ska-sa/katdal/issues{/number}","pulls_url":"https://api.github.com/repos/ska-sa/katdal/pulls{/number}","milestones_url":"https://api.github.com/repos/ska-sa/katdal/milestones{/number}","notifications_url":"https://api.github.com/repos/ska-sa/katdal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ska-sa/katdal/labels{/name}","releases_url":"https://api.github.com/repos/ska-sa/katdal/releases{/id}","deployments_url":"https://api.github.com/repos/ska-sa/katdal/deployments","created_at":"2013-09-16T14:12:17Z","updated_at":"2018-10-26T12:45:10Z","pushed_at":"2018-10-26T15:27:10Z","git_url":"git://github.com/ska-sa/katdal.git","ssh_url":"git@github.com:ska-sa/katdal.git","clone_url":"https://github.com/ska-sa/katdal.git","svn_url":"https://github.com/ska-sa/katdal","homepage":"","size":1455,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":6,"open_issues":11,"watchers":3,"default_branch":"master"}},"base":{"label":"ska-sa:master","ref":"master","sha":"6d95bbd88d489866c75c7a95cda3a9662599d59e","user":{"login":"ska-sa","id":1210238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAyMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/1210238?v=4","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"repo":{"id":12869013,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg2OTAxMw==","name":"katdal","full_name":"ska-sa/katdal","private":false,"owner":{"login":"ska-sa","id":1210238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAyMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/1210238?v=4","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ska-sa/katdal","description":"Data access library for the MeerKAT project","fork":false,"url":"https://api.github.com/repos/ska-sa/katdal","forks_url":"https://api.github.com/repos/ska-sa/katdal/forks","keys_url":"https://api.github.com/repos/ska-sa/katdal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ska-sa/katdal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ska-sa/katdal/teams","hooks_url":"https://api.github.com/repos/ska-sa/katdal/hooks","issue_events_url":"https://api.github.com/repos/ska-sa/katdal/issues/events{/number}","events_url":"https://api.github.com/repos/ska-sa/katdal/events","assignees_url":"https://api.github.com/repos/ska-sa/katdal/assignees{/user}","branches_url":"https://api.github.com/repos/ska-sa/katdal/branches{/branch}","tags_url":"https://api.github.com/repos/ska-sa/katdal/tags","blobs_url":"https://api.github.com/repos/ska-sa/katdal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ska-sa/katdal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ska-sa/katdal/git/refs{/sha}","trees_url":"https://api.github.com/repos/ska-sa/katdal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ska-sa/katdal/statuses/{sha}","languages_url":"https://api.github.com/repos/ska-sa/katdal/languages","stargazers_url":"https://api.github.com/repos/ska-sa/katdal/stargazers","contributors_url":"https://api.github.com/repos/ska-sa/katdal/contributors","subscribers_url":"https://api.github.com/repos/ska-sa/katdal/subscribers","subscription_url":"https://api.github.com/repos/ska-sa/katdal/subscription","commits_url":"https://api.github.com/repos/ska-sa/katdal/commits{/sha}","git_commits_url":"https://api.github.com/repos/ska-sa/katdal/git/commits{/sha}","comments_url":"https://api.github.com/repos/ska-sa/katdal/comments{/number}","issue_comment_url":"https://api.github.com/repos/ska-sa/katdal/issues/comments{/number}","contents_url":"https://api.github.com/repos/ska-sa/katdal/contents/{+path}","compare_url":"https://api.github.com/repos/ska-sa/katdal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ska-sa/katdal/merges","archive_url":"https://api.github.com/repos/ska-sa/katdal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ska-sa/katdal/downloads","issues_url":"https://api.github.com/repos/ska-sa/katdal/issues{/number}","pulls_url":"https://api.github.com/repos/ska-sa/katdal/pulls{/number}","milestones_url":"https://api.github.com/repos/ska-sa/katdal/milestones{/number}","notifications_url":"https://api.github.com/repos/ska-sa/katdal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ska-sa/katdal/labels{/name}","releases_url":"https://api.github.com/repos/ska-sa/katdal/releases{/id}","deployments_url":"https://api.github.com/repos/ska-sa/katdal/deployments","created_at":"2013-09-16T14:12:17Z","updated_at":"2018-10-26T12:45:10Z","pushed_at":"2018-10-26T15:27:10Z","git_url":"git://github.com/ska-sa/katdal.git","ssh_url":"git@github.com:ska-sa/katdal.git","clone_url":"https://github.com/ska-sa/katdal.git","svn_url":"https://github.com/ska-sa/katdal","homepage":"","size":1455,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":6,"open_issues":11,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ska-sa/katdal/pulls/198"},"html":{"href":"https://github.com/ska-sa/katdal/pull/198"},"issue":{"href":"https://api.github.com/repos/ska-sa/katdal/issues/198"},"comments":{"href":"https://api.github.com/repos/ska-sa/katdal/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/ska-sa/katdal/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/ska-sa/katdal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ska-sa/katdal/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/ska-sa/katdal/statuses/af0bfda54417ff83dd1b8e2b0adbcd7b7a2960ac"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ludwigschwardt"}}