{"action":"created","issue":{"url":"https://api.github.com/repos/bazelbuild/rules_go/issues/1257","repository_url":"https://api.github.com/repos/bazelbuild/rules_go","labels_url":"https://api.github.com/repos/bazelbuild/rules_go/issues/1257/labels{/name}","comments_url":"https://api.github.com/repos/bazelbuild/rules_go/issues/1257/comments","events_url":"https://api.github.com/repos/bazelbuild/rules_go/issues/1257/events","html_url":"https://github.com/bazelbuild/rules_go/pull/1257","id":290135455,"number":1257,"title":"Don't include compilation mode in binary output filenames.","user":{"login":"jmillikin-stripe","id":28275929,"avatar_url":"https://avatars3.githubusercontent.com/u/28275929?v=4","gravatar_id":"","url":"https://api.github.com/users/jmillikin-stripe","html_url":"https://github.com/jmillikin-stripe","followers_url":"https://api.github.com/users/jmillikin-stripe/followers","following_url":"https://api.github.com/users/jmillikin-stripe/following{/other_user}","gists_url":"https://api.github.com/users/jmillikin-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/jmillikin-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmillikin-stripe/subscriptions","organizations_url":"https://api.github.com/users/jmillikin-stripe/orgs","repos_url":"https://api.github.com/users/jmillikin-stripe/repos","events_url":"https://api.github.com/users/jmillikin-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/jmillikin-stripe/received_events","type":"User","site_admin":false},"labels":[{"id":342134177,"url":"https://api.github.com/repos/bazelbuild/rules_go/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2018-01-19T23:14:54Z","updated_at":"2018-03-20T19:44:38Z","closed_at":"2018-03-20T19:44:38Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/bazelbuild/rules_go/pulls/1257","html_url":"https://github.com/bazelbuild/rules_go/pull/1257","diff_url":"https://github.com/bazelbuild/rules_go/pull/1257.diff","patch_url":"https://github.com/bazelbuild/rules_go/pull/1257.patch"},"body":"Fixes https://github.com/bazelbuild/rules_go/issues/1239\r\n\r\nThis should maintain nearly all of the caching benefits of the arch-specific filenames, because libraries are still built with the included mode. Binaries will need to be relinked if `-c` changes, but the filenames are consistent with other languages commonly used with Bazel."},"comment":{"url":"https://api.github.com/repos/bazelbuild/rules_go/issues/comments/374731767","html_url":"https://github.com/bazelbuild/rules_go/pull/1257#issuecomment-374731767","issue_url":"https://api.github.com/repos/bazelbuild/rules_go/issues/1257","id":374731767,"user":{"login":"jayconrod","id":164791,"avatar_url":"https://avatars3.githubusercontent.com/u/164791?v=4","gravatar_id":"","url":"https://api.github.com/users/jayconrod","html_url":"https://github.com/jayconrod","followers_url":"https://api.github.com/users/jayconrod/followers","following_url":"https://api.github.com/users/jayconrod/following{/other_user}","gists_url":"https://api.github.com/users/jayconrod/gists{/gist_id}","starred_url":"https://api.github.com/users/jayconrod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayconrod/subscriptions","organizations_url":"https://api.github.com/users/jayconrod/orgs","repos_url":"https://api.github.com/users/jayconrod/repos","events_url":"https://api.github.com/users/jayconrod/events{/privacy}","received_events_url":"https://api.github.com/users/jayconrod/received_events","type":"User","site_admin":false},"created_at":"2018-03-20T19:44:38Z","updated_at":"2018-03-20T19:44:38Z","author_association":"CONTRIBUTOR","body":"I'm planning to submit #1393 instead of this one. That PR adds an `out` parameter to `go_binary` that lets you set the output file to a custom name.\r\n\r\nIf you want to set `out` automatically for all binaries, I'd suggest wrapping `go_binary` in a macro. Something like this:\r\n\r\n```\r\nload(\"@io_bazel_rules_go//go:def.bzl\", _go_binary = \"go_binary\")\r\n\r\ndef go_binary(**kwargs):\r\n  kwargs.setdefault(\"out\", kwargs[\"name\"])\r\n  _go_binary(**kwargs)\r\n```\r\n"}}
{"actor":{"display_login":"jayconrod"}}