{"action":"closed","number":1174,"pull_request":{"url":"https://api.github.com/repos/neutrinojs/neutrino/pulls/1174","id":222679519,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNjc5NTE5","html_url":"https://github.com/neutrinojs/neutrino/pull/1174","diff_url":"https://github.com/neutrinojs/neutrino/pull/1174.diff","patch_url":"https://github.com/neutrinojs/neutrino/pull/1174.patch","issue_url":"https://api.github.com/repos/neutrinojs/neutrino/issues/1174","number":1174,"state":"closed","locked":false,"title":"Output generated files under an assets/ subdirectory","user":{"login":"edmorley","id":501702,"node_id":"MDQ6VXNlcjUwMTcwMg==","avatar_url":"https://avatars3.githubusercontent.com/u/501702?v=4","gravatar_id":"","url":"https://api.github.com/users/edmorley","html_url":"https://github.com/edmorley","followers_url":"https://api.github.com/users/edmorley/followers","following_url":"https://api.github.com/users/edmorley/following{/other_user}","gists_url":"https://api.github.com/users/edmorley/gists{/gist_id}","starred_url":"https://api.github.com/users/edmorley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edmorley/subscriptions","organizations_url":"https://api.github.com/users/edmorley/orgs","repos_url":"https://api.github.com/users/edmorley/repos","events_url":"https://api.github.com/users/edmorley/events{/privacy}","received_events_url":"https://api.github.com/users/edmorley/received_events","type":"User","site_admin":false},"body":"This makes it easier to write `Cache-Control` header rules for files with hashed filenames, since the web server rule can now just match the entire `assets/` directory rather than having to use false-positive prone regex to match the hash in the filename.\r\n\r\nIn addition, this PR removes some redundant configuration:\r\n* The `@neutrinojs/node` and `@neutrinojs/library` presets no longer set `output.filename` / `output.chunkFilename`, since they were previously only being set to the defaults anyway.\r\n* The `@neutrinojs/web` preset no longer sets `output.chunkFilename` since by default it inherits from `output.filename`, so setting both to the same value is redundant:\r\n  https://github.com/webpack/webpack/blob/v4.20.2/lib/WebpackOptionsDefaulter.js#L102-L112\r\n\r\nFixes #1172.","created_at":"2018-10-13T22:18:07Z","updated_at":"2018-10-15T12:12:04Z","closed_at":"2018-10-15T12:12:03Z","merged_at":"2018-10-15T12:12:03Z","merge_commit_sha":"6bef97a81e96bb1ca807260321399690d028277c","assignee":{"login":"edmorley","id":501702,"node_id":"MDQ6VXNlcjUwMTcwMg==","avatar_url":"https://avatars3.githubusercontent.com/u/501702?v=4","gravatar_id":"","url":"https://api.github.com/users/edmorley","html_url":"https://github.com/edmorley","followers_url":"https://api.github.com/users/edmorley/followers","following_url":"https://api.github.com/users/edmorley/following{/other_user}","gists_url":"https://api.github.com/users/edmorley/gists{/gist_id}","starred_url":"https://api.github.com/users/edmorley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edmorley/subscriptions","organizations_url":"https://api.github.com/users/edmorley/orgs","repos_url":"https://api.github.com/users/edmorley/repos","events_url":"https://api.github.com/users/edmorley/events{/privacy}","received_events_url":"https://api.github.com/users/edmorley/received_events","type":"User","site_admin":false},"assignees":[{"login":"edmorley","id":501702,"node_id":"MDQ6VXNlcjUwMTcwMg==","avatar_url":"https://avatars3.githubusercontent.com/u/501702?v=4","gravatar_id":"","url":"https://api.github.com/users/edmorley","html_url":"https://github.com/edmorley","followers_url":"https://api.github.com/users/edmorley/followers","following_url":"https://api.github.com/users/edmorley/following{/other_user}","gists_url":"https://api.github.com/users/edmorley/gists{/gist_id}","starred_url":"https://api.github.com/users/edmorley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edmorley/subscriptions","organizations_url":"https://api.github.com/users/edmorley/orgs","repos_url":"https://api.github.com/users/edmorley/repos","events_url":"https://api.github.com/users/edmorley/events{/privacy}","received_events_url":"https://api.github.com/users/edmorley/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"eliperelman","id":285899,"node_id":"MDQ6VXNlcjI4NTg5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/285899?v=4","gravatar_id":"","url":"https://api.github.com/users/eliperelman","html_url":"https://github.com/eliperelman","followers_url":"https://api.github.com/users/eliperelman/followers","following_url":"https://api.github.com/users/eliperelman/following{/other_user}","gists_url":"https://api.github.com/users/eliperelman/gists{/gist_id}","starred_url":"https://api.github.com/users/eliperelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliperelman/subscriptions","organizations_url":"https://api.github.com/users/eliperelman/orgs","repos_url":"https://api.github.com/users/eliperelman/repos","events_url":"https://api.github.com/users/eliperelman/events{/privacy}","received_events_url":"https://api.github.com/users/eliperelman/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":749140796,"node_id":"MDU6TGFiZWw3NDkxNDA3OTY=","url":"https://api.github.com/repos/neutrinojs/neutrino/labels/breaking%20change","name":"breaking change","color":"f2527f","default":false},{"id":567895827,"node_id":"MDU6TGFiZWw1Njc4OTU4Mjc=","url":"https://api.github.com/repos/neutrinojs/neutrino/labels/feature","name":"feature","color":"0e8a16","default":false}],"milestone":{"url":"https://api.github.com/repos/neutrinojs/neutrino/milestones/6","html_url":"https://github.com/neutrinojs/neutrino/milestone/6","labels_url":"https://api.github.com/repos/neutrinojs/neutrino/milestones/6/labels","id":3272176,"node_id":"MDk6TWlsZXN0b25lMzI3MjE3Ng==","number":6,"title":"v9","description":"This release is the next major version, which includes webpack 4, Babel 7 and ESLint 5.","creator":{"login":"eliperelman","id":285899,"node_id":"MDQ6VXNlcjI4NTg5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/285899?v=4","gravatar_id":"","url":"https://api.github.com/users/eliperelman","html_url":"https://github.com/eliperelman","followers_url":"https://api.github.com/users/eliperelman/followers","following_url":"https://api.github.com/users/eliperelman/following{/other_user}","gists_url":"https://api.github.com/users/eliperelman/gists{/gist_id}","starred_url":"https://api.github.com/users/eliperelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliperelman/subscriptions","organizations_url":"https://api.github.com/users/eliperelman/orgs","repos_url":"https://api.github.com/users/eliperelman/repos","events_url":"https://api.github.com/users/eliperelman/events{/privacy}","received_events_url":"https://api.github.com/users/eliperelman/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":230,"state":"open","created_at":"2018-04-16T22:31:33Z","updated_at":"2018-10-15T12:12:03Z","due_on":"2018-10-14T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/neutrinojs/neutrino/pulls/1174/commits","review_comments_url":"https://api.github.com/repos/neutrinojs/neutrino/pulls/1174/comments","review_comment_url":"https://api.github.com/repos/neutrinojs/neutrino/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neutrinojs/neutrino/issues/1174/comments","statuses_url":"https://api.github.com/repos/neutrinojs/neutrino/statuses/2a3861ebda626946c984868618e70861b5fb4f30","head":{"label":"edmorley:assets-dir","ref":"assets-dir","sha":"2a3861ebda626946c984868618e70861b5fb4f30","user":{"login":"edmorley","id":501702,"node_id":"MDQ6VXNlcjUwMTcwMg==","avatar_url":"https://avatars3.githubusercontent.com/u/501702?v=4","gravatar_id":"","url":"https://api.github.com/users/edmorley","html_url":"https://github.com/edmorley","followers_url":"https://api.github.com/users/edmorley/followers","following_url":"https://api.github.com/users/edmorley/following{/other_user}","gists_url":"https://api.github.com/users/edmorley/gists{/gist_id}","starred_url":"https://api.github.com/users/edmorley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edmorley/subscriptions","organizations_url":"https://api.github.com/users/edmorley/orgs","repos_url":"https://api.github.com/users/edmorley/repos","events_url":"https://api.github.com/users/edmorley/events{/privacy}","received_events_url":"https://api.github.com/users/edmorley/received_events","type":"User","site_admin":false},"repo":{"id":94134448,"node_id":"MDEwOlJlcG9zaXRvcnk5NDEzNDQ0OA==","name":"neutrino","full_name":"edmorley/neutrino","private":false,"owner":{"login":"edmorley","id":501702,"node_id":"MDQ6VXNlcjUwMTcwMg==","avatar_url":"https://avatars3.githubusercontent.com/u/501702?v=4","gravatar_id":"","url":"https://api.github.com/users/edmorley","html_url":"https://github.com/edmorley","followers_url":"https://api.github.com/users/edmorley/followers","following_url":"https://api.github.com/users/edmorley/following{/other_user}","gists_url":"https://api.github.com/users/edmorley/gists{/gist_id}","starred_url":"https://api.github.com/users/edmorley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edmorley/subscriptions","organizations_url":"https://api.github.com/users/edmorley/orgs","repos_url":"https://api.github.com/users/edmorley/repos","events_url":"https://api.github.com/users/edmorley/events{/privacy}","received_events_url":"https://api.github.com/users/edmorley/received_events","type":"User","site_admin":false},"html_url":"https://github.com/edmorley/neutrino","description":"Create and build modern JavaScript applications with zero initial configuration.","fork":true,"url":"https://api.github.com/repos/edmorley/neutrino","forks_url":"https://api.github.com/repos/edmorley/neutrino/forks","keys_url":"https://api.github.com/repos/edmorley/neutrino/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edmorley/neutrino/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edmorley/neutrino/teams","hooks_url":"https://api.github.com/repos/edmorley/neutrino/hooks","issue_events_url":"https://api.github.com/repos/edmorley/neutrino/issues/events{/number}","events_url":"https://api.github.com/repos/edmorley/neutrino/events","assignees_url":"https://api.github.com/repos/edmorley/neutrino/assignees{/user}","branches_url":"https://api.github.com/repos/edmorley/neutrino/branches{/branch}","tags_url":"https://api.github.com/repos/edmorley/neutrino/tags","blobs_url":"https://api.github.com/repos/edmorley/neutrino/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edmorley/neutrino/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edmorley/neutrino/git/refs{/sha}","trees_url":"https://api.github.com/repos/edmorley/neutrino/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edmorley/neutrino/statuses/{sha}","languages_url":"https://api.github.com/repos/edmorley/neutrino/languages","stargazers_url":"https://api.github.com/repos/edmorley/neutrino/stargazers","contributors_url":"https://api.github.com/repos/edmorley/neutrino/contributors","subscribers_url":"https://api.github.com/repos/edmorley/neutrino/subscribers","subscription_url":"https://api.github.com/repos/edmorley/neutrino/subscription","commits_url":"https://api.github.com/repos/edmorley/neutrino/commits{/sha}","git_commits_url":"https://api.github.com/repos/edmorley/neutrino/git/commits{/sha}","comments_url":"https://api.github.com/repos/edmorley/neutrino/comments{/number}","issue_comment_url":"https://api.github.com/repos/edmorley/neutrino/issues/comments{/number}","contents_url":"https://api.github.com/repos/edmorley/neutrino/contents/{+path}","compare_url":"https://api.github.com/repos/edmorley/neutrino/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edmorley/neutrino/merges","archive_url":"https://api.github.com/repos/edmorley/neutrino/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edmorley/neutrino/downloads","issues_url":"https://api.github.com/repos/edmorley/neutrino/issues{/number}","pulls_url":"https://api.github.com/repos/edmorley/neutrino/pulls{/number}","milestones_url":"https://api.github.com/repos/edmorley/neutrino/milestones{/number}","notifications_url":"https://api.github.com/repos/edmorley/neutrino/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edmorley/neutrino/labels{/name}","releases_url":"https://api.github.com/repos/edmorley/neutrino/releases{/id}","deployments_url":"https://api.github.com/repos/edmorley/neutrino/deployments","created_at":"2017-06-12T19:48:56Z","updated_at":"2018-10-01T11:57:06Z","pushed_at":"2018-10-14T17:12:50Z","git_url":"git://github.com/edmorley/neutrino.git","ssh_url":"git@github.com:edmorley/neutrino.git","clone_url":"https://github.com/edmorley/neutrino.git","svn_url":"https://github.com/edmorley/neutrino","homepage":"https://neutrino.js.org","size":7146,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neutrinojs:master","ref":"master","sha":"51b1658ec6357622cd94c12a140f3749db8c5fa5","user":{"login":"neutrinojs","id":21367267,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzY3MjY3","avatar_url":"https://avatars3.githubusercontent.com/u/21367267?v=4","gravatar_id":"","url":"https://api.github.com/users/neutrinojs","html_url":"https://github.com/neutrinojs","followers_url":"https://api.github.com/users/neutrinojs/followers","following_url":"https://api.github.com/users/neutrinojs/following{/other_user}","gists_url":"https://api.github.com/users/neutrinojs/gists{/gist_id}","starred_url":"https://api.github.com/users/neutrinojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neutrinojs/subscriptions","organizations_url":"https://api.github.com/users/neutrinojs/orgs","repos_url":"https://api.github.com/users/neutrinojs/repos","events_url":"https://api.github.com/users/neutrinojs/events{/privacy}","received_events_url":"https://api.github.com/users/neutrinojs/received_events","type":"Organization","site_admin":false},"repo":{"id":80793561,"node_id":"MDEwOlJlcG9zaXRvcnk4MDc5MzU2MQ==","name":"neutrino","full_name":"neutrinojs/neutrino","private":false,"owner":{"login":"neutrinojs","id":21367267,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzY3MjY3","avatar_url":"https://avatars3.githubusercontent.com/u/21367267?v=4","gravatar_id":"","url":"https://api.github.com/users/neutrinojs","html_url":"https://github.com/neutrinojs","followers_url":"https://api.github.com/users/neutrinojs/followers","following_url":"https://api.github.com/users/neutrinojs/following{/other_user}","gists_url":"https://api.github.com/users/neutrinojs/gists{/gist_id}","starred_url":"https://api.github.com/users/neutrinojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neutrinojs/subscriptions","organizations_url":"https://api.github.com/users/neutrinojs/orgs","repos_url":"https://api.github.com/users/neutrinojs/repos","events_url":"https://api.github.com/users/neutrinojs/events{/privacy}","received_events_url":"https://api.github.com/users/neutrinojs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/neutrinojs/neutrino","description":"Create and build modern JavaScript projects with zero initial configuration.","fork":false,"url":"https://api.github.com/repos/neutrinojs/neutrino","forks_url":"https://api.github.com/repos/neutrinojs/neutrino/forks","keys_url":"https://api.github.com/repos/neutrinojs/neutrino/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neutrinojs/neutrino/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neutrinojs/neutrino/teams","hooks_url":"https://api.github.com/repos/neutrinojs/neutrino/hooks","issue_events_url":"https://api.github.com/repos/neutrinojs/neutrino/issues/events{/number}","events_url":"https://api.github.com/repos/neutrinojs/neutrino/events","assignees_url":"https://api.github.com/repos/neutrinojs/neutrino/assignees{/user}","branches_url":"https://api.github.com/repos/neutrinojs/neutrino/branches{/branch}","tags_url":"https://api.github.com/repos/neutrinojs/neutrino/tags","blobs_url":"https://api.github.com/repos/neutrinojs/neutrino/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neutrinojs/neutrino/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neutrinojs/neutrino/git/refs{/sha}","trees_url":"https://api.github.com/repos/neutrinojs/neutrino/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neutrinojs/neutrino/statuses/{sha}","languages_url":"https://api.github.com/repos/neutrinojs/neutrino/languages","stargazers_url":"https://api.github.com/repos/neutrinojs/neutrino/stargazers","contributors_url":"https://api.github.com/repos/neutrinojs/neutrino/contributors","subscribers_url":"https://api.github.com/repos/neutrinojs/neutrino/subscribers","subscription_url":"https://api.github.com/repos/neutrinojs/neutrino/subscription","commits_url":"https://api.github.com/repos/neutrinojs/neutrino/commits{/sha}","git_commits_url":"https://api.github.com/repos/neutrinojs/neutrino/git/commits{/sha}","comments_url":"https://api.github.com/repos/neutrinojs/neutrino/comments{/number}","issue_comment_url":"https://api.github.com/repos/neutrinojs/neutrino/issues/comments{/number}","contents_url":"https://api.github.com/repos/neutrinojs/neutrino/contents/{+path}","compare_url":"https://api.github.com/repos/neutrinojs/neutrino/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neutrinojs/neutrino/merges","archive_url":"https://api.github.com/repos/neutrinojs/neutrino/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neutrinojs/neutrino/downloads","issues_url":"https://api.github.com/repos/neutrinojs/neutrino/issues{/number}","pulls_url":"https://api.github.com/repos/neutrinojs/neutrino/pulls{/number}","milestones_url":"https://api.github.com/repos/neutrinojs/neutrino/milestones{/number}","notifications_url":"https://api.github.com/repos/neutrinojs/neutrino/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neutrinojs/neutrino/labels{/name}","releases_url":"https://api.github.com/repos/neutrinojs/neutrino/releases{/id}","deployments_url":"https://api.github.com/repos/neutrinojs/neutrino/deployments","created_at":"2017-02-03T03:27:20Z","updated_at":"2018-10-15T09:42:51Z","pushed_at":"2018-10-15T12:12:03Z","git_url":"git://github.com/neutrinojs/neutrino.git","ssh_url":"git@github.com:neutrinojs/neutrino.git","clone_url":"https://github.com/neutrinojs/neutrino.git","svn_url":"https://github.com/neutrinojs/neutrino","homepage":"https://neutrinojs.org","size":7359,"stargazers_count":2828,"watchers_count":2828,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":182,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":182,"open_issues":34,"watchers":2828,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neutrinojs/neutrino/pulls/1174"},"html":{"href":"https://github.com/neutrinojs/neutrino/pull/1174"},"issue":{"href":"https://api.github.com/repos/neutrinojs/neutrino/issues/1174"},"comments":{"href":"https://api.github.com/repos/neutrinojs/neutrino/issues/1174/comments"},"review_comments":{"href":"https://api.github.com/repos/neutrinojs/neutrino/pulls/1174/comments"},"review_comment":{"href":"https://api.github.com/repos/neutrinojs/neutrino/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neutrinojs/neutrino/pulls/1174/commits"},"statuses":{"href":"https://api.github.com/repos/neutrinojs/neutrino/statuses/2a3861ebda626946c984868618e70861b5fb4f30"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"edmorley","id":501702,"node_id":"MDQ6VXNlcjUwMTcwMg==","avatar_url":"https://avatars3.githubusercontent.com/u/501702?v=4","gravatar_id":"","url":"https://api.github.com/users/edmorley","html_url":"https://github.com/edmorley","followers_url":"https://api.github.com/users/edmorley/followers","following_url":"https://api.github.com/users/edmorley/following{/other_user}","gists_url":"https://api.github.com/users/edmorley/gists{/gist_id}","starred_url":"https://api.github.com/users/edmorley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edmorley/subscriptions","organizations_url":"https://api.github.com/users/edmorley/orgs","repos_url":"https://api.github.com/users/edmorley/repos","events_url":"https://api.github.com/users/edmorley/events{/privacy}","received_events_url":"https://api.github.com/users/edmorley/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":38,"deletions":22,"changed_files":11}}
{"actor":{"display_login":"edmorley"}}