{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/pulls/comments/240356061","pull_request_review_id":183368285,"id":240356061,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDM1NjA2MQ==","diff_hunk":"@@ -66,6 +66,9 @@ on the status of your build.\n \n 7. In the **Payload Constraints** field, you can enter any of the top-level fields from the\n [Build object documentation](https://cloud.google.com/cloud-build/docs/api/reference/rest/v1/projects.builds#resource-build)\n-as the key, and a Java regular expression as the value. For example, to match on an image produced,\n-you can use the key `images` and the value `gcr\\.io/my-project-id/my-application:latest` (replacing\n-`my-project-id` and `my-application` with appropriate values).\n+as the key, and a Java regular expression as the value.\n+\n+8. In the **Expected Artifacts** field, you can add any build artifacts as expected artifacts. For example,\n+if the build produces a docker image, you can add an expected artifact of type *Docker* with a value of\n+`gcr.io/my-project-id/my-application` (replacing `my-project-id` and `my-application` with appropriate values). You","path":"setup/ci/gcb.md","position":11,"original_position":11,"commit_id":"aa7718c0c3a20ffa1c73fd7528363d1b5f0d8751","original_commit_id":"aa7718c0c3a20ffa1c73fd7528363d1b5f0d8751","user":{"login":"lwander","id":4874941,"node_id":"MDQ6VXNlcjQ4NzQ5NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/4874941?v=4","gravatar_id":"","url":"https://api.github.com/users/lwander","html_url":"https://github.com/lwander","followers_url":"https://api.github.com/users/lwander/followers","following_url":"https://api.github.com/users/lwander/following{/other_user}","gists_url":"https://api.github.com/users/lwander/gists{/gist_id}","starred_url":"https://api.github.com/users/lwander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwander/subscriptions","organizations_url":"https://api.github.com/users/lwander/orgs","repos_url":"https://api.github.com/users/lwander/repos","events_url":"https://api.github.com/users/lwander/events{/privacy}","received_events_url":"https://api.github.com/users/lwander/received_events","type":"User","site_admin":false},"body":"I would call out that images can be referenced by `:tag` here too -- we submit artifacts for both `gcr.io/image` and `gcr.io/image:tag` with references to `gcr.io/image@sha256:abc...`","created_at":"2018-12-10T19:51:20Z","updated_at":"2018-12-10T19:51:20Z","html_url":"https://github.com/spinnaker/spinnaker.github.io/pull/1142#discussion_r240356061","pull_request_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/pulls/1142","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/spinnaker.github.io/pulls/comments/240356061"},"html":{"href":"https://github.com/spinnaker/spinnaker.github.io/pull/1142#discussion_r240356061"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/spinnaker.github.io/pulls/1142"}}},"pull_request":{"url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/pulls/1142","id":237428833,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NDI4ODMz","html_url":"https://github.com/spinnaker/spinnaker.github.io/pull/1142","diff_url":"https://github.com/spinnaker/spinnaker.github.io/pull/1142.diff","patch_url":"https://github.com/spinnaker/spinnaker.github.io/pull/1142.patch","issue_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/issues/1142","number":1142,"state":"open","locked":false,"title":"docs(gcb): Add artifacts to GCB docs","user":{"login":"ezimanyi","id":1391982,"node_id":"MDQ6VXNlcjEzOTE5ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1391982?v=4","gravatar_id":"","url":"https://api.github.com/users/ezimanyi","html_url":"https://github.com/ezimanyi","followers_url":"https://api.github.com/users/ezimanyi/followers","following_url":"https://api.github.com/users/ezimanyi/following{/other_user}","gists_url":"https://api.github.com/users/ezimanyi/gists{/gist_id}","starred_url":"https://api.github.com/users/ezimanyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezimanyi/subscriptions","organizations_url":"https://api.github.com/users/ezimanyi/orgs","repos_url":"https://api.github.com/users/ezimanyi/repos","events_url":"https://api.github.com/users/ezimanyi/events{/privacy}","received_events_url":"https://api.github.com/users/ezimanyi/received_events","type":"User","site_admin":false},"body":"@ttomsu : You'd suggested improving the documentation here so it's more clear how to set up artifact support.  I just ran through the full set-up myself and everything worked following these steps.","created_at":"2018-12-10T18:55:17Z","updated_at":"2018-12-10T19:51:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90b1fc623c8c46528739fd984a2c3c9dbb5d3200","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dorbin","id":29312809,"node_id":"MDQ6VXNlcjI5MzEyODA5","avatar_url":"https://avatars1.githubusercontent.com/u/29312809?v=4","gravatar_id":"","url":"https://api.github.com/users/dorbin","html_url":"https://github.com/dorbin","followers_url":"https://api.github.com/users/dorbin/followers","following_url":"https://api.github.com/users/dorbin/following{/other_user}","gists_url":"https://api.github.com/users/dorbin/gists{/gist_id}","starred_url":"https://api.github.com/users/dorbin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dorbin/subscriptions","organizations_url":"https://api.github.com/users/dorbin/orgs","repos_url":"https://api.github.com/users/dorbin/repos","events_url":"https://api.github.com/users/dorbin/events{/privacy}","received_events_url":"https://api.github.com/users/dorbin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/pulls/1142/commits","review_comments_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/pulls/1142/comments","review_comment_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/issues/1142/comments","statuses_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/statuses/aa7718c0c3a20ffa1c73fd7528363d1b5f0d8751","head":{"label":"ezimanyi:gcb-artifacts","ref":"gcb-artifacts","sha":"aa7718c0c3a20ffa1c73fd7528363d1b5f0d8751","user":{"login":"ezimanyi","id":1391982,"node_id":"MDQ6VXNlcjEzOTE5ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1391982?v=4","gravatar_id":"","url":"https://api.github.com/users/ezimanyi","html_url":"https://github.com/ezimanyi","followers_url":"https://api.github.com/users/ezimanyi/followers","following_url":"https://api.github.com/users/ezimanyi/following{/other_user}","gists_url":"https://api.github.com/users/ezimanyi/gists{/gist_id}","starred_url":"https://api.github.com/users/ezimanyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezimanyi/subscriptions","organizations_url":"https://api.github.com/users/ezimanyi/orgs","repos_url":"https://api.github.com/users/ezimanyi/repos","events_url":"https://api.github.com/users/ezimanyi/events{/privacy}","received_events_url":"https://api.github.com/users/ezimanyi/received_events","type":"User","site_admin":false},"repo":{"id":118950431,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg5NTA0MzE=","name":"spinnaker.github.io","full_name":"ezimanyi/spinnaker.github.io","private":false,"owner":{"login":"ezimanyi","id":1391982,"node_id":"MDQ6VXNlcjEzOTE5ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1391982?v=4","gravatar_id":"","url":"https://api.github.com/users/ezimanyi","html_url":"https://github.com/ezimanyi","followers_url":"https://api.github.com/users/ezimanyi/followers","following_url":"https://api.github.com/users/ezimanyi/following{/other_user}","gists_url":"https://api.github.com/users/ezimanyi/gists{/gist_id}","starred_url":"https://api.github.com/users/ezimanyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezimanyi/subscriptions","organizations_url":"https://api.github.com/users/ezimanyi/orgs","repos_url":"https://api.github.com/users/ezimanyi/repos","events_url":"https://api.github.com/users/ezimanyi/events{/privacy}","received_events_url":"https://api.github.com/users/ezimanyi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ezimanyi/spinnaker.github.io","description":"spinnaker documentation site","fork":true,"url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io","forks_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/forks","keys_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/teams","hooks_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/hooks","issue_events_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/events","assignees_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/tags","blobs_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/languages","stargazers_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/stargazers","contributors_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/contributors","subscribers_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/subscribers","subscription_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/subscription","commits_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/merges","archive_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/downloads","issues_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/labels{/name}","releases_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/ezimanyi/spinnaker.github.io/deployments","created_at":"2018-01-25T18:20:21Z","updated_at":"2018-12-10T02:44:03Z","pushed_at":"2018-12-10T18:54:08Z","git_url":"git://github.com/ezimanyi/spinnaker.github.io.git","ssh_url":"git@github.com:ezimanyi/spinnaker.github.io.git","clone_url":"https://github.com/ezimanyi/spinnaker.github.io.git","svn_url":"https://github.com/ezimanyi/spinnaker.github.io","homepage":null,"size":63073,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"47bed95ba3667739524f41aab1efd50e53eee3d2","user":{"login":"spinnaker","id":7634182,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MzQxODI=","avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":86486443,"node_id":"MDEwOlJlcG9zaXRvcnk4NjQ4NjQ0Mw==","name":"spinnaker.github.io","full_name":"spinnaker/spinnaker.github.io","private":false,"owner":{"login":"spinnaker","id":7634182,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MzQxODI=","avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spinnaker/spinnaker.github.io","description":"spinnaker documentation site","fork":false,"url":"https://api.github.com/repos/spinnaker/spinnaker.github.io","forks_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/forks","keys_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/teams","hooks_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/events","assignees_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/tags","blobs_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/languages","stargazers_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/subscription","commits_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/merges","archive_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/downloads","issues_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/spinnaker.github.io/deployments","created_at":"2017-03-28T17:09:59Z","updated_at":"2018-12-10T18:48:55Z","pushed_at":"2018-12-10T18:55:17Z","git_url":"git://github.com/spinnaker/spinnaker.github.io.git","ssh_url":"git@github.com:spinnaker/spinnaker.github.io.git","clone_url":"https://github.com/spinnaker/spinnaker.github.io.git","svn_url":"https://github.com/spinnaker/spinnaker.github.io","homepage":null,"size":63076,"stargazers_count":29,"watchers_count":29,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":221,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":221,"open_issues":54,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/spinnaker.github.io/pulls/1142"},"html":{"href":"https://github.com/spinnaker/spinnaker.github.io/pull/1142"},"issue":{"href":"https://api.github.com/repos/spinnaker/spinnaker.github.io/issues/1142"},"comments":{"href":"https://api.github.com/repos/spinnaker/spinnaker.github.io/issues/1142/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/spinnaker.github.io/pulls/1142/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/spinnaker.github.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/spinnaker.github.io/pulls/1142/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/spinnaker.github.io/statuses/aa7718c0c3a20ffa1c73fd7528363d1b5f0d8751"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"lwander"}}