{"action":"created","comment":{"url":"https://api.github.com/repos/rwengine/openrw/pulls/comments/188004048","pull_request_review_id":119895769,"id":188004048,"diff_hunk":"@@ -4324,11 +4326,8 @@ bool opcode_0184(const ScriptArguments& args, const ScriptCharacter character, c\n     @arg arg2 \n */\n bool opcode_0185(const ScriptArguments& args, const ScriptVehicle vehicle, const ScriptInt arg2) {\n-    RW_UNIMPLEMENTED_OPCODE(0x0185);\n-    RW_UNUSED(vehicle);\n-    RW_UNUSED(arg2);\n     RW_UNUSED(args);\n-    return true;\n+    return vehicle->getHealth() <= arg2;","path":"rwengine/src/script/modules/GTA3ModuleImpl.inl","position":37,"original_position":37,"commit_id":"127c8168b3526072678098a7422d88990659403a","original_commit_id":"127c8168b3526072678098a7422d88990659403a","user":{"login":"husho","id":10241816,"avatar_url":"https://avatars2.githubusercontent.com/u/10241816?v=4","gravatar_id":"","url":"https://api.github.com/users/husho","html_url":"https://github.com/husho","followers_url":"https://api.github.com/users/husho/followers","following_url":"https://api.github.com/users/husho/following{/other_user}","gists_url":"https://api.github.com/users/husho/gists{/gist_id}","starred_url":"https://api.github.com/users/husho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/husho/subscriptions","organizations_url":"https://api.github.com/users/husho/orgs","repos_url":"https://api.github.com/users/husho/repos","events_url":"https://api.github.com/users/husho/events{/privacy}","received_events_url":"https://api.github.com/users/husho/received_events","type":"User","site_admin":false},"body":"So I decided to recheck this opcode in scm and logically it seems that it should be ```>```\r\nLesson learned - don't trust hex-rays decompiler. Sadly I can't really make sense out of FPU instructions, here's disassembly if someone's want to verify https://pastebin.com/raw/EQGyCKTB","created_at":"2018-05-14T15:47:58Z","updated_at":"2018-05-14T15:47:58Z","html_url":"https://github.com/rwengine/openrw/pull/448#discussion_r188004048","pull_request_url":"https://api.github.com/repos/rwengine/openrw/pulls/448","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rwengine/openrw/pulls/comments/188004048"},"html":{"href":"https://github.com/rwengine/openrw/pull/448#discussion_r188004048"},"pull_request":{"href":"https://api.github.com/repos/rwengine/openrw/pulls/448"}},"in_reply_to_id":187867552},"pull_request":{"url":"https://api.github.com/repos/rwengine/openrw/pulls/448","id":187171721,"html_url":"https://github.com/rwengine/openrw/pull/448","diff_url":"https://github.com/rwengine/openrw/pull/448.diff","patch_url":"https://github.com/rwengine/openrw/pull/448.patch","issue_url":"https://api.github.com/repos/rwengine/openrw/issues/448","number":448,"state":"open","locked":false,"title":"[Ready] Vehicle health","user":{"login":"husho","id":10241816,"avatar_url":"https://avatars2.githubusercontent.com/u/10241816?v=4","gravatar_id":"","url":"https://api.github.com/users/husho","html_url":"https://github.com/husho","followers_url":"https://api.github.com/users/husho/followers","following_url":"https://api.github.com/users/husho/following{/other_user}","gists_url":"https://api.github.com/users/husho/gists{/gist_id}","starred_url":"https://api.github.com/users/husho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/husho/subscriptions","organizations_url":"https://api.github.com/users/husho/orgs","repos_url":"https://api.github.com/users/husho/repos","events_url":"https://api.github.com/users/husho/events{/privacy}","received_events_url":"https://api.github.com/users/husho/received_events","type":"User","site_admin":false},"body":"Minor changes, but this should make more missions playable, because now it's possible to \"destroy\" vehicles.","created_at":"2018-05-10T11:47:47Z","updated_at":"2018-05-14T15:47:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ff6e52043d6ac785106eef3f1ea14e44d2e5bb2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rwengine/openrw/pulls/448/commits","review_comments_url":"https://api.github.com/repos/rwengine/openrw/pulls/448/comments","review_comment_url":"https://api.github.com/repos/rwengine/openrw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rwengine/openrw/issues/448/comments","statuses_url":"https://api.github.com/repos/rwengine/openrw/statuses/127c8168b3526072678098a7422d88990659403a","head":{"label":"husho:vehiclehealth","ref":"vehiclehealth","sha":"127c8168b3526072678098a7422d88990659403a","user":{"login":"husho","id":10241816,"avatar_url":"https://avatars2.githubusercontent.com/u/10241816?v=4","gravatar_id":"","url":"https://api.github.com/users/husho","html_url":"https://github.com/husho","followers_url":"https://api.github.com/users/husho/followers","following_url":"https://api.github.com/users/husho/following{/other_user}","gists_url":"https://api.github.com/users/husho/gists{/gist_id}","starred_url":"https://api.github.com/users/husho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/husho/subscriptions","organizations_url":"https://api.github.com/users/husho/orgs","repos_url":"https://api.github.com/users/husho/repos","events_url":"https://api.github.com/users/husho/events{/privacy}","received_events_url":"https://api.github.com/users/husho/received_events","type":"User","site_admin":false},"repo":{"id":132360336,"name":"openrw","full_name":"husho/openrw","owner":{"login":"husho","id":10241816,"avatar_url":"https://avatars2.githubusercontent.com/u/10241816?v=4","gravatar_id":"","url":"https://api.github.com/users/husho","html_url":"https://github.com/husho","followers_url":"https://api.github.com/users/husho/followers","following_url":"https://api.github.com/users/husho/following{/other_user}","gists_url":"https://api.github.com/users/husho/gists{/gist_id}","starred_url":"https://api.github.com/users/husho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/husho/subscriptions","organizations_url":"https://api.github.com/users/husho/orgs","repos_url":"https://api.github.com/users/husho/repos","events_url":"https://api.github.com/users/husho/events{/privacy}","received_events_url":"https://api.github.com/users/husho/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/husho/openrw","description":"OpenRW \"Open ReWrite\" is an un-official open source recreation of the classic Grand Theft Auto III game executable","fork":true,"url":"https://api.github.com/repos/husho/openrw","forks_url":"https://api.github.com/repos/husho/openrw/forks","keys_url":"https://api.github.com/repos/husho/openrw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/husho/openrw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/husho/openrw/teams","hooks_url":"https://api.github.com/repos/husho/openrw/hooks","issue_events_url":"https://api.github.com/repos/husho/openrw/issues/events{/number}","events_url":"https://api.github.com/repos/husho/openrw/events","assignees_url":"https://api.github.com/repos/husho/openrw/assignees{/user}","branches_url":"https://api.github.com/repos/husho/openrw/branches{/branch}","tags_url":"https://api.github.com/repos/husho/openrw/tags","blobs_url":"https://api.github.com/repos/husho/openrw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/husho/openrw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/husho/openrw/git/refs{/sha}","trees_url":"https://api.github.com/repos/husho/openrw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/husho/openrw/statuses/{sha}","languages_url":"https://api.github.com/repos/husho/openrw/languages","stargazers_url":"https://api.github.com/repos/husho/openrw/stargazers","contributors_url":"https://api.github.com/repos/husho/openrw/contributors","subscribers_url":"https://api.github.com/repos/husho/openrw/subscribers","subscription_url":"https://api.github.com/repos/husho/openrw/subscription","commits_url":"https://api.github.com/repos/husho/openrw/commits{/sha}","git_commits_url":"https://api.github.com/repos/husho/openrw/git/commits{/sha}","comments_url":"https://api.github.com/repos/husho/openrw/comments{/number}","issue_comment_url":"https://api.github.com/repos/husho/openrw/issues/comments{/number}","contents_url":"https://api.github.com/repos/husho/openrw/contents/{+path}","compare_url":"https://api.github.com/repos/husho/openrw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/husho/openrw/merges","archive_url":"https://api.github.com/repos/husho/openrw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/husho/openrw/downloads","issues_url":"https://api.github.com/repos/husho/openrw/issues{/number}","pulls_url":"https://api.github.com/repos/husho/openrw/pulls{/number}","milestones_url":"https://api.github.com/repos/husho/openrw/milestones{/number}","notifications_url":"https://api.github.com/repos/husho/openrw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/husho/openrw/labels{/name}","releases_url":"https://api.github.com/repos/husho/openrw/releases{/id}","deployments_url":"https://api.github.com/repos/husho/openrw/deployments","created_at":"2018-05-06T17:20:45Z","updated_at":"2018-05-12T02:27:55Z","pushed_at":"2018-05-14T10:54:35Z","git_url":"git://github.com/husho/openrw.git","ssh_url":"git@github.com:husho/openrw.git","clone_url":"https://github.com/husho/openrw.git","svn_url":"https://github.com/husho/openrw","homepage":"http://openrw.org","size":3221,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rwengine:master","ref":"master","sha":"98313141629bce1a753fe185954276b037226f8f","user":{"login":"rwengine","id":19520421,"avatar_url":"https://avatars0.githubusercontent.com/u/19520421?v=4","gravatar_id":"","url":"https://api.github.com/users/rwengine","html_url":"https://github.com/rwengine","followers_url":"https://api.github.com/users/rwengine/followers","following_url":"https://api.github.com/users/rwengine/following{/other_user}","gists_url":"https://api.github.com/users/rwengine/gists{/gist_id}","starred_url":"https://api.github.com/users/rwengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwengine/subscriptions","organizations_url":"https://api.github.com/users/rwengine/orgs","repos_url":"https://api.github.com/users/rwengine/repos","events_url":"https://api.github.com/users/rwengine/events{/privacy}","received_events_url":"https://api.github.com/users/rwengine/received_events","type":"Organization","site_admin":false},"repo":{"id":34529275,"name":"openrw","full_name":"rwengine/openrw","owner":{"login":"rwengine","id":19520421,"avatar_url":"https://avatars0.githubusercontent.com/u/19520421?v=4","gravatar_id":"","url":"https://api.github.com/users/rwengine","html_url":"https://github.com/rwengine","followers_url":"https://api.github.com/users/rwengine/followers","following_url":"https://api.github.com/users/rwengine/following{/other_user}","gists_url":"https://api.github.com/users/rwengine/gists{/gist_id}","starred_url":"https://api.github.com/users/rwengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwengine/subscriptions","organizations_url":"https://api.github.com/users/rwengine/orgs","repos_url":"https://api.github.com/users/rwengine/repos","events_url":"https://api.github.com/users/rwengine/events{/privacy}","received_events_url":"https://api.github.com/users/rwengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rwengine/openrw","description":"OpenRW \"Open ReWrite\" is an un-official open source recreation of the classic Grand Theft Auto III game executable","fork":false,"url":"https://api.github.com/repos/rwengine/openrw","forks_url":"https://api.github.com/repos/rwengine/openrw/forks","keys_url":"https://api.github.com/repos/rwengine/openrw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwengine/openrw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwengine/openrw/teams","hooks_url":"https://api.github.com/repos/rwengine/openrw/hooks","issue_events_url":"https://api.github.com/repos/rwengine/openrw/issues/events{/number}","events_url":"https://api.github.com/repos/rwengine/openrw/events","assignees_url":"https://api.github.com/repos/rwengine/openrw/assignees{/user}","branches_url":"https://api.github.com/repos/rwengine/openrw/branches{/branch}","tags_url":"https://api.github.com/repos/rwengine/openrw/tags","blobs_url":"https://api.github.com/repos/rwengine/openrw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwengine/openrw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwengine/openrw/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwengine/openrw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwengine/openrw/statuses/{sha}","languages_url":"https://api.github.com/repos/rwengine/openrw/languages","stargazers_url":"https://api.github.com/repos/rwengine/openrw/stargazers","contributors_url":"https://api.github.com/repos/rwengine/openrw/contributors","subscribers_url":"https://api.github.com/repos/rwengine/openrw/subscribers","subscription_url":"https://api.github.com/repos/rwengine/openrw/subscription","commits_url":"https://api.github.com/repos/rwengine/openrw/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwengine/openrw/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwengine/openrw/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwengine/openrw/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwengine/openrw/contents/{+path}","compare_url":"https://api.github.com/repos/rwengine/openrw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwengine/openrw/merges","archive_url":"https://api.github.com/repos/rwengine/openrw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwengine/openrw/downloads","issues_url":"https://api.github.com/repos/rwengine/openrw/issues{/number}","pulls_url":"https://api.github.com/repos/rwengine/openrw/pulls{/number}","milestones_url":"https://api.github.com/repos/rwengine/openrw/milestones{/number}","notifications_url":"https://api.github.com/repos/rwengine/openrw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwengine/openrw/labels{/name}","releases_url":"https://api.github.com/repos/rwengine/openrw/releases{/id}","deployments_url":"https://api.github.com/repos/rwengine/openrw/deployments","created_at":"2015-04-24T16:26:12Z","updated_at":"2018-05-14T07:56:59Z","pushed_at":"2018-05-14T11:13:29Z","git_url":"git://github.com/rwengine/openrw.git","ssh_url":"git@github.com:rwengine/openrw.git","clone_url":"https://github.com/rwengine/openrw.git","svn_url":"https://github.com/rwengine/openrw","homepage":"http://openrw.org","size":3161,"stargazers_count":660,"watchers_count":660,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":83,"open_issues":87,"watchers":660,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rwengine/openrw/pulls/448"},"html":{"href":"https://github.com/rwengine/openrw/pull/448"},"issue":{"href":"https://api.github.com/repos/rwengine/openrw/issues/448"},"comments":{"href":"https://api.github.com/repos/rwengine/openrw/issues/448/comments"},"review_comments":{"href":"https://api.github.com/repos/rwengine/openrw/pulls/448/comments"},"review_comment":{"href":"https://api.github.com/repos/rwengine/openrw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rwengine/openrw/pulls/448/commits"},"statuses":{"href":"https://api.github.com/repos/rwengine/openrw/statuses/127c8168b3526072678098a7422d88990659403a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"husho"}}