{"action":"created","issue":{"url":"https://api.github.com/repos/twitter/scrooge/issues/292","repository_url":"https://api.github.com/repos/twitter/scrooge","labels_url":"https://api.github.com/repos/twitter/scrooge/issues/292/labels{/name}","comments_url":"https://api.github.com/repos/twitter/scrooge/issues/292/comments","events_url":"https://api.github.com/repos/twitter/scrooge/issues/292/events","html_url":"https://github.com/twitter/scrooge/pull/292","id":325830726,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwMDcxNjc0","number":292,"title":"[fix] Don't use adapted args when calling Service.apply","user":{"login":"samschlegel","id":5514447,"node_id":"MDQ6VXNlcjU1MTQ0NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/5514447?v=4","gravatar_id":"","url":"https://api.github.com/users/samschlegel","html_url":"https://github.com/samschlegel","followers_url":"https://api.github.com/users/samschlegel/followers","following_url":"https://api.github.com/users/samschlegel/following{/other_user}","gists_url":"https://api.github.com/users/samschlegel/gists{/gist_id}","starred_url":"https://api.github.com/users/samschlegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samschlegel/subscriptions","organizations_url":"https://api.github.com/users/samschlegel/orgs","repos_url":"https://api.github.com/users/samschlegel/repos","events_url":"https://api.github.com/users/samschlegel/events{/privacy}","received_events_url":"https://api.github.com/users/samschlegel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-23T18:52:17Z","updated_at":"2018-05-31T11:38:11Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/twitter/scrooge/pulls/292","html_url":"https://github.com/twitter/scrooge/pull/292","diff_url":"https://github.com/twitter/scrooge/pull/292.diff","patch_url":"https://github.com/twitter/scrooge/pull/292.patch"},"body":"This fixes #277\r\n\r\nCurrently the generated code for FinagleService utilizes adapted args when calling `finagle.Service#apply`. For many people this generates a warning due to `-Ywarn-adapted-args`, and for some (ourselves included) causes the compilation to fail due to `-Yno-adapted-args`\r\n\r\nTo solve, we explicitly wrap arguments in a 2-tuple\r\n\r\nAs an aside, and this is a contentious topic, but I think it might be a good idea to add `-Yno-adapted-args` to the build scripts for scrooge, so that issues like this don't crop up in the future. It's a fairly common flag, and it's annoying to have to conditionally disable just for scrooge generated code. Though it will be removed in Scala 3 (scala/scala#6505), so might auto-tupling!"},"comment":{"url":"https://api.github.com/repos/twitter/scrooge/issues/comments/393502685","html_url":"https://github.com/twitter/scrooge/pull/292#issuecomment-393502685","issue_url":"https://api.github.com/repos/twitter/scrooge/issues/292","id":393502685,"node_id":"MDEyOklzc3VlQ29tbWVudDM5MzUwMjY4NQ==","user":{"login":"mosesn","id":156562,"node_id":"MDQ6VXNlcjE1NjU2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/156562?v=4","gravatar_id":"","url":"https://api.github.com/users/mosesn","html_url":"https://github.com/mosesn","followers_url":"https://api.github.com/users/mosesn/followers","following_url":"https://api.github.com/users/mosesn/following{/other_user}","gists_url":"https://api.github.com/users/mosesn/gists{/gist_id}","starred_url":"https://api.github.com/users/mosesn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mosesn/subscriptions","organizations_url":"https://api.github.com/users/mosesn/orgs","repos_url":"https://api.github.com/users/mosesn/repos","events_url":"https://api.github.com/users/mosesn/events{/privacy}","received_events_url":"https://api.github.com/users/mosesn/received_events","type":"User","site_admin":false},"created_at":"2018-05-31T11:38:11Z","updated_at":"2018-05-31T11:38:11Z","author_association":"CONTRIBUTOR","body":"@samschlegel whichever you prefer.  just lmk which you decide to do."}}
{"actor":{"display_login":"mosesn"}}