{"action":"created","comment":{"url":"https://api.github.com/repos/akvo/akvo-flow-mobile/pulls/comments/180670494","pull_request_review_id":111126728,"id":180670494,"diff_hunk":"@@ -455,12 +475,26 @@ private void displayForm(String surveyedLocaleId, User user) {\n                 formInstanceId, readOnly, mSurveyGroup);\n     }\n \n-    private void displaySelectedUser() {\n-        User user = FlowApp.getApp().getUser();\n-        if (user != null) {\n-            Toast.makeText(this, getString(R.string.logged_in_as) + \" \" + user.getName(),\n-                    Toast.LENGTH_LONG).show();\n-        }\n+    private void verifySelectedUser() {","path":"app/src/main/java/org/akvo/flow/activity/SurveyActivity.java","position":109,"original_position":109,"commit_id":"dcd772c3d739404b69f5610a80f605e985fd1baa","original_commit_id":"dcd772c3d739404b69f5610a80f605e985fd1baa","user":{"login":"muloem","id":533336,"avatar_url":"https://avatars2.githubusercontent.com/u/533336?v=4","gravatar_id":"","url":"https://api.github.com/users/muloem","html_url":"https://github.com/muloem","followers_url":"https://api.github.com/users/muloem/followers","following_url":"https://api.github.com/users/muloem/following{/other_user}","gists_url":"https://api.github.com/users/muloem/gists{/gist_id}","starred_url":"https://api.github.com/users/muloem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muloem/subscriptions","organizations_url":"https://api.github.com/users/muloem/orgs","repos_url":"https://api.github.com/users/muloem/repos","events_url":"https://api.github.com/users/muloem/events{/privacy}","received_events_url":"https://api.github.com/users/muloem/received_events","type":"User","site_admin":false},"body":"I was trying to understand why you changed this method to `verifySelectedUser()` because it seems to me the main objective stays the same., i.e. display the user, but before displaying we verify that the username exists.","created_at":"2018-04-11T08:19:17Z","updated_at":"2018-04-11T08:56:19Z","html_url":"https://github.com/akvo/akvo-flow-mobile/pull/1057#discussion_r180670494","pull_request_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/pulls/1057","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/akvo/akvo-flow-mobile/pulls/comments/180670494"},"html":{"href":"https://github.com/akvo/akvo-flow-mobile/pull/1057#discussion_r180670494"},"pull_request":{"href":"https://api.github.com/repos/akvo/akvo-flow-mobile/pulls/1057"}}},"pull_request":{"url":"https://api.github.com/repos/akvo/akvo-flow-mobile/pulls/1057","id":177709548,"html_url":"https://github.com/akvo/akvo-flow-mobile/pull/1057","diff_url":"https://github.com/akvo/akvo-flow-mobile/pull/1057.diff","patch_url":"https://github.com/akvo/akvo-flow-mobile/pull/1057.patch","issue_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/issues/1057","number":1057,"state":"open","locked":false,"title":"Improve current user access (connect #1056)","user":{"login":"valllllll2000","id":923280,"avatar_url":"https://avatars0.githubusercontent.com/u/923280?v=4","gravatar_id":"","url":"https://api.github.com/users/valllllll2000","html_url":"https://github.com/valllllll2000","followers_url":"https://api.github.com/users/valllllll2000/followers","following_url":"https://api.github.com/users/valllllll2000/following{/other_user}","gists_url":"https://api.github.com/users/valllllll2000/gists{/gist_id}","starred_url":"https://api.github.com/users/valllllll2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valllllll2000/subscriptions","organizations_url":"https://api.github.com/users/valllllll2000/orgs","repos_url":"https://api.github.com/users/valllllll2000/repos","events_url":"https://api.github.com/users/valllllll2000/events{/privacy}","received_events_url":"https://api.github.com/users/valllllll2000/received_events","type":"User","site_admin":false},"body":"#### Before the PR (what is the issue or what needed to be done)\r\nUser was stored in FlowApp and it had to be accessed through many places which prevented me from making the changes required in settings/delete everything\r\n#### The solution\r\nAccess current user with UseCase\r\nRemove user field from FlowApp\r\n#### Screenshots (if appropriate)\r\nNA\r\n#### Reviewer Checklist\r\n* [ ] Connect the issue\r\n* [ ] Test plan\r\n* [ ] Copyright header\r\n* [ ] Code formatting\r\n* [ ] Documentation\r\n","created_at":"2018-03-27T11:26:50Z","updated_at":"2018-04-11T08:56:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"516e80dfbbcfeba7c1cac7796b48450b36a5710b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":817314350,"url":"https://api.github.com/repos/akvo/akvo-flow-mobile/labels/DataPrivacy","name":"DataPrivacy","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/pulls/1057/commits","review_comments_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/pulls/1057/comments","review_comment_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/issues/1057/comments","statuses_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/statuses/dcd772c3d739404b69f5610a80f605e985fd1baa","head":{"label":"akvo:issue/1056-improve-user","ref":"issue/1056-improve-user","sha":"dcd772c3d739404b69f5610a80f605e985fd1baa","user":{"login":"akvo","id":159843,"avatar_url":"https://avatars0.githubusercontent.com/u/159843?v=4","gravatar_id":"","url":"https://api.github.com/users/akvo","html_url":"https://github.com/akvo","followers_url":"https://api.github.com/users/akvo/followers","following_url":"https://api.github.com/users/akvo/following{/other_user}","gists_url":"https://api.github.com/users/akvo/gists{/gist_id}","starred_url":"https://api.github.com/users/akvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akvo/subscriptions","organizations_url":"https://api.github.com/users/akvo/orgs","repos_url":"https://api.github.com/users/akvo/repos","events_url":"https://api.github.com/users/akvo/events{/privacy}","received_events_url":"https://api.github.com/users/akvo/received_events","type":"Organization","site_admin":false},"repo":{"id":5380818,"name":"akvo-flow-mobile","full_name":"akvo/akvo-flow-mobile","owner":{"login":"akvo","id":159843,"avatar_url":"https://avatars0.githubusercontent.com/u/159843?v=4","gravatar_id":"","url":"https://api.github.com/users/akvo","html_url":"https://github.com/akvo","followers_url":"https://api.github.com/users/akvo/followers","following_url":"https://api.github.com/users/akvo/following{/other_user}","gists_url":"https://api.github.com/users/akvo/gists{/gist_id}","starred_url":"https://api.github.com/users/akvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akvo/subscriptions","organizations_url":"https://api.github.com/users/akvo/orgs","repos_url":"https://api.github.com/users/akvo/repos","events_url":"https://api.github.com/users/akvo/events{/privacy}","received_events_url":"https://api.github.com/users/akvo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akvo/akvo-flow-mobile","description":"Akvo Flow app","fork":false,"url":"https://api.github.com/repos/akvo/akvo-flow-mobile","forks_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/forks","keys_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/teams","hooks_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/hooks","issue_events_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/events","assignees_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/tags","blobs_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/languages","stargazers_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/stargazers","contributors_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/contributors","subscribers_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/subscribers","subscription_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/subscription","commits_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/merges","archive_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/downloads","issues_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/labels{/name}","releases_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/deployments","created_at":"2012-08-11T15:36:16Z","updated_at":"2018-04-03T14:29:40Z","pushed_at":"2018-04-09T14:41:54Z","git_url":"git://github.com/akvo/akvo-flow-mobile.git","ssh_url":"git@github.com:akvo/akvo-flow-mobile.git","clone_url":"https://github.com/akvo/akvo-flow-mobile.git","svn_url":"https://github.com/akvo/akvo-flow-mobile","homepage":"","size":140191,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":100,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":13,"open_issues":100,"watchers":12,"default_branch":"develop"}},"base":{"label":"akvo:feature/secure-collected-data","ref":"feature/secure-collected-data","sha":"723392f4ad2188abd73a7d3d2b706c38fb2ca305","user":{"login":"akvo","id":159843,"avatar_url":"https://avatars0.githubusercontent.com/u/159843?v=4","gravatar_id":"","url":"https://api.github.com/users/akvo","html_url":"https://github.com/akvo","followers_url":"https://api.github.com/users/akvo/followers","following_url":"https://api.github.com/users/akvo/following{/other_user}","gists_url":"https://api.github.com/users/akvo/gists{/gist_id}","starred_url":"https://api.github.com/users/akvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akvo/subscriptions","organizations_url":"https://api.github.com/users/akvo/orgs","repos_url":"https://api.github.com/users/akvo/repos","events_url":"https://api.github.com/users/akvo/events{/privacy}","received_events_url":"https://api.github.com/users/akvo/received_events","type":"Organization","site_admin":false},"repo":{"id":5380818,"name":"akvo-flow-mobile","full_name":"akvo/akvo-flow-mobile","owner":{"login":"akvo","id":159843,"avatar_url":"https://avatars0.githubusercontent.com/u/159843?v=4","gravatar_id":"","url":"https://api.github.com/users/akvo","html_url":"https://github.com/akvo","followers_url":"https://api.github.com/users/akvo/followers","following_url":"https://api.github.com/users/akvo/following{/other_user}","gists_url":"https://api.github.com/users/akvo/gists{/gist_id}","starred_url":"https://api.github.com/users/akvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akvo/subscriptions","organizations_url":"https://api.github.com/users/akvo/orgs","repos_url":"https://api.github.com/users/akvo/repos","events_url":"https://api.github.com/users/akvo/events{/privacy}","received_events_url":"https://api.github.com/users/akvo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akvo/akvo-flow-mobile","description":"Akvo Flow app","fork":false,"url":"https://api.github.com/repos/akvo/akvo-flow-mobile","forks_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/forks","keys_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/teams","hooks_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/hooks","issue_events_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/events","assignees_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/tags","blobs_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/languages","stargazers_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/stargazers","contributors_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/contributors","subscribers_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/subscribers","subscription_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/subscription","commits_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/merges","archive_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/downloads","issues_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/labels{/name}","releases_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/akvo/akvo-flow-mobile/deployments","created_at":"2012-08-11T15:36:16Z","updated_at":"2018-04-03T14:29:40Z","pushed_at":"2018-04-09T14:41:54Z","git_url":"git://github.com/akvo/akvo-flow-mobile.git","ssh_url":"git@github.com:akvo/akvo-flow-mobile.git","clone_url":"https://github.com/akvo/akvo-flow-mobile.git","svn_url":"https://github.com/akvo/akvo-flow-mobile","homepage":"","size":140191,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":100,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":13,"open_issues":100,"watchers":12,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/akvo/akvo-flow-mobile/pulls/1057"},"html":{"href":"https://github.com/akvo/akvo-flow-mobile/pull/1057"},"issue":{"href":"https://api.github.com/repos/akvo/akvo-flow-mobile/issues/1057"},"comments":{"href":"https://api.github.com/repos/akvo/akvo-flow-mobile/issues/1057/comments"},"review_comments":{"href":"https://api.github.com/repos/akvo/akvo-flow-mobile/pulls/1057/comments"},"review_comment":{"href":"https://api.github.com/repos/akvo/akvo-flow-mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akvo/akvo-flow-mobile/pulls/1057/commits"},"statuses":{"href":"https://api.github.com/repos/akvo/akvo-flow-mobile/statuses/dcd772c3d739404b69f5610a80f605e985fd1baa"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"muloem"}}