{"action":"created","issue":{"url":"https://api.github.com/repos/renovatebot/renovate/issues/2294","repository_url":"https://api.github.com/repos/renovatebot/renovate","labels_url":"https://api.github.com/repos/renovatebot/renovate/issues/2294/labels{/name}","comments_url":"https://api.github.com/repos/renovatebot/renovate/issues/2294/comments","events_url":"https://api.github.com/repos/renovatebot/renovate/issues/2294/events","html_url":"https://github.com/renovatebot/renovate/issues/2294","id":343273534,"node_id":"MDU6SXNzdWUzNDMyNzM1MzQ=","number":2294,"title":"package-lock.json changes after merging a Renovate PR and running npm install","user":{"login":"felixfbecker","id":10532611,"node_id":"MDQ6VXNlcjEwNTMyNjEx","avatar_url":"https://avatars0.githubusercontent.com/u/10532611?v=4","gravatar_id":"","url":"https://api.github.com/users/felixfbecker","html_url":"https://github.com/felixfbecker","followers_url":"https://api.github.com/users/felixfbecker/followers","following_url":"https://api.github.com/users/felixfbecker/following{/other_user}","gists_url":"https://api.github.com/users/felixfbecker/gists{/gist_id}","starred_url":"https://api.github.com/users/felixfbecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixfbecker/subscriptions","organizations_url":"https://api.github.com/users/felixfbecker/orgs","repos_url":"https://api.github.com/users/felixfbecker/repos","events_url":"https://api.github.com/users/felixfbecker/events{/privacy}","received_events_url":"https://api.github.com/users/felixfbecker/received_events","type":"User","site_admin":false},"labels":[{"id":719084730,"node_id":"MDU6TGFiZWw3MTkwODQ3MzA=","url":"https://api.github.com/repos/renovatebot/renovate/labels/%23npm","name":"#npm","color":"fbca04","default":false},{"id":619246502,"node_id":"MDU6TGFiZWw2MTkyNDY1MDI=","url":"https://api.github.com/repos/renovatebot/renovate/labels/blocked","name":"blocked","color":"c5def5","default":false},{"id":619253275,"node_id":"MDU6TGFiZWw2MTkyNTMyNzU=","url":"https://api.github.com/repos/renovatebot/renovate/labels/pri4-low","name":"pri4-low","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":31,"created_at":"2018-07-20T23:23:19Z","updated_at":"2018-10-06T20:06:37Z","closed_at":null,"author_association":"NONE","body":"**What Renovate type are you using?**\r\nRenovate GitHub App\r\n\r\n**Describe the bug**\r\nAfter merging a Renovate PR and running `npm install` locally, package-lock.json changes.\r\n\r\nThis is unfortunate, because it means that the automation still requires a manual `npm install`, commit and push, at which point I could have just updated the dependency manually in the first place.\r\n\r\nI am running npm v6.2.0 (latest). What version is Renovate using?\r\n\r\n<details>\r\n<summary>Diff</summary>\r\n\r\n```diff\r\ndiff --git a/web/package-lock.json b/web/package-lock.json\r\nindex 350caa888a..d8d390e406 100644\r\n--- a/web/package-lock.json\r\n+++ b/web/package-lock.json\r\n@@ -6906,8 +6906,7 @@\r\n         \"ansi-regex\": {\r\n           \"version\": \"2.1.1\",\r\n           \"bundled\": true,\r\n-          \"dev\": true,\r\n-          \"optional\": true\r\n+          \"dev\": true\r\n         },\r\n         \"aproba\": {\r\n           \"version\": \"1.2.0\",\r\n@@ -6928,14 +6927,12 @@\r\n         \"balanced-match\": {\r\n           \"version\": \"1.0.0\",\r\n           \"bundled\": true,\r\n-          \"dev\": true,\r\n-          \"optional\": true\r\n+          \"dev\": true\r\n         },\r\n         \"brace-expansion\": {\r\n           \"version\": \"1.1.11\",\r\n           \"bundled\": true,\r\n           \"dev\": true,\r\n-          \"optional\": true,\r\n           \"requires\": {\r\n             \"balanced-match\": \"^1.0.0\",\r\n             \"concat-map\": \"0.0.1\"\r\n@@ -6950,20 +6947,17 @@\r\n         \"code-point-at\": {\r\n           \"version\": \"1.1.0\",\r\n           \"bundled\": true,\r\n-          \"dev\": true,\r\n-          \"optional\": true\r\n+          \"dev\": true\r\n         },\r\n         \"concat-map\": {\r\n           \"version\": \"0.0.1\",\r\n           \"bundled\": true,\r\n-          \"dev\": true,\r\n-          \"optional\": true\r\n+          \"dev\": true\r\n         },\r\n         \"console-control-strings\": {\r\n           \"version\": \"1.1.0\",\r\n           \"bundled\": true,\r\n-          \"dev\": true,\r\n-          \"optional\": true\r\n+          \"dev\": true\r\n         },\r\n         \"core-util-is\": {\r\n           \"version\": \"1.0.2\",\r\n@@ -7080,8 +7074,7 @@\r\n         \"inherits\": {\r\n           \"version\": \"2.0.3\",\r\n           \"bundled\": true,\r\n-          \"dev\": true,\r\n-          \"optional\": true\r\n+          \"dev\": true\r\n         },\r\n         \"ini\": {\r\n           \"version\": \"1.3.5\",\r\n@@ -7093,7 +7086,6 @@\r\n           \"version\": \"1.0.0\",\r\n           \"bundled\": true,\r\n           \"dev\": true,\r\n-          \"optional\": true,\r\n           \"requires\": {\r\n             \"number-is-nan\": \"^1.0.0\"\r\n           }\r\n@@ -7108,7 +7100,6 @@\r\n           \"version\": \"3.0.4\",\r\n           \"bundled\": true,\r\n           \"dev\": true,\r\n-          \"optional\": true,\r\n           \"requires\": {\r\n             \"brace-expansion\": \"^1.1.7\"\r\n           }\r\n@@ -7116,14 +7107,12 @@\r\n         \"minimist\": {\r\n           \"version\": \"0.0.8\",\r\n           \"bundled\": true,\r\n-          \"dev\": true,\r\n-          \"optional\": true\r\n+          \"dev\": true\r\n         },\r\n         \"minipass\": {\r\n           \"version\": \"2.2.4\",\r\n           \"bundled\": true,\r\n           \"dev\": true,\r\n-          \"optional\": true,\r\n           \"requires\": {\r\n             \"safe-buffer\": \"^5.1.1\",\r\n             \"yallist\": \"^3.0.0\"\r\n@@ -7142,7 +7131,6 @@\r\n           \"version\": \"0.5.1\",\r\n           \"bundled\": true,\r\n           \"dev\": true,\r\n-          \"optional\": true,\r\n           \"requires\": {\r\n             \"minimist\": \"0.0.8\"\r\n           }\r\n@@ -7223,8 +7211,7 @@\r\n         \"number-is-nan\": {\r\n           \"version\": \"1.0.1\",\r\n           \"bundled\": true,\r\n-          \"dev\": true,\r\n-          \"optional\": true\r\n+          \"dev\": true\r\n         },\r\n         \"object-assign\": {\r\n           \"version\": \"4.1.1\",\r\n@@ -7236,7 +7223,6 @@\r\n           \"version\": \"1.4.0\",\r\n           \"bundled\": true,\r\n           \"dev\": true,\r\n-          \"optional\": true,\r\n           \"requires\": {\r\n             \"wrappy\": \"1\"\r\n           }\r\n@@ -7322,8 +7308,7 @@\r\n         \"safe-buffer\": {\r\n           \"version\": \"5.1.1\",\r\n           \"bundled\": true,\r\n-          \"dev\": true,\r\n-          \"optional\": true\r\n+          \"dev\": true\r\n         },\r\n         \"safer-buffer\": {\r\n           \"version\": \"2.1.2\",\r\n@@ -7359,7 +7344,6 @@\r\n           \"version\": \"1.0.2\",\r\n           \"bundled\": true,\r\n           \"dev\": true,\r\n-          \"optional\": true,\r\n           \"requires\": {\r\n             \"code-point-at\": \"^1.0.0\",\r\n             \"is-fullwidth-code-point\": \"^1.0.0\",\r\n@@ -7379,7 +7363,6 @@\r\n           \"version\": \"3.0.1\",\r\n           \"bundled\": true,\r\n           \"dev\": true,\r\n-          \"optional\": true,\r\n           \"requires\": {\r\n             \"ansi-regex\": \"^2.0.0\"\r\n           }\r\n@@ -7423,14 +7406,12 @@\r\n         \"wrappy\": {\r\n           \"version\": \"1.0.2\",\r\n           \"bundled\": true,\r\n-          \"dev\": true,\r\n-          \"optional\": true\r\n+          \"dev\": true\r\n         },\r\n         \"yallist\": {\r\n           \"version\": \"3.0.2\",\r\n           \"bundled\": true,\r\n-          \"dev\": true,\r\n-          \"optional\": true\r\n+          \"dev\": true\r\n         }\r\n       }\r\n     },\r\n@@ -11277,7 +11258,6 @@\r\n           \"version\": \"0.1.4\",\r\n           \"bundled\": true,\r\n           \"dev\": true,\r\n-          \"optional\": true,\r\n           \"requires\": {\r\n             \"kind-of\": \"^3.0.2\",\r\n             \"longest\": \"^1.0.1\",\r\n@@ -12243,8 +12223,7 @@\r\n         \"longest\": {\r\n           \"version\": \"1.0.1\",\r\n           \"bundled\": true,\r\n-          \"dev\": true,\r\n-          \"optional\": true\r\n+          \"dev\": true\r\n         },\r\n         \"lru-cache\": {\r\n           \"version\": \"4.1.3\",\r\n```\r\n\r\n</details>\r\n"},"comment":{"url":"https://api.github.com/repos/renovatebot/renovate/issues/comments/427602610","html_url":"https://github.com/renovatebot/renovate/issues/2294#issuecomment-427602610","issue_url":"https://api.github.com/repos/renovatebot/renovate/issues/2294","id":427602610,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzYwMjYxMA==","user":{"login":"srilq","id":18026180,"node_id":"MDQ6VXNlcjE4MDI2MTgw","avatar_url":"https://avatars2.githubusercontent.com/u/18026180?v=4","gravatar_id":"","url":"https://api.github.com/users/srilq","html_url":"https://github.com/srilq","followers_url":"https://api.github.com/users/srilq/followers","following_url":"https://api.github.com/users/srilq/following{/other_user}","gists_url":"https://api.github.com/users/srilq/gists{/gist_id}","starred_url":"https://api.github.com/users/srilq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srilq/subscriptions","organizations_url":"https://api.github.com/users/srilq/orgs","repos_url":"https://api.github.com/users/srilq/repos","events_url":"https://api.github.com/users/srilq/events{/privacy}","received_events_url":"https://api.github.com/users/srilq/received_events","type":"User","site_admin":false},"created_at":"2018-10-06T20:06:37Z","updated_at":"2018-10-06T20:06:37Z","author_association":"NONE","body":"I feel like that fix might just flip the problem on its head by removing `optional: true` lines that end up getting re-added when running `npm install` locally? In some cases (maybe most cases) it would have a worse outcome, certainly if you're running Linux and you're on a team who are all running macOS.\r\n\r\nI also imagine it might make troubleshooting the npm issue more problematic if we're modifying the lockfile programatically. Perhaps a config option just adds complexity to the problem without guaranteeing to solve it? I think it's worth some investigation though."}}
{"actor":{"display_login":"srilq"}}