{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/reactive/pulls/comments/192364178","pull_request_review_id":125128179,"id":192364178,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjM2NDE3OA==","diff_hunk":"@@ -414,7 +414,7 @@ private void DrainQueue(ICancelable cancel)\n                         if (shouldWait)\n                         {\n                             var timer = new ManualResetEventSlim();\n-                            _scheduler.Schedule(waitTime, () => { timer.Set(); });\n+                            _scheduler.Schedule(timer, waitTime, (_, state) => { state.Set(); return Disposable.Empty; });","path":"Rx.NET/Source/src/System.Reactive/Linq/Observable/Delay.cs","position":null,"original_position":5,"commit_id":"037c341966410e9b374807e17622f130f58187be","original_commit_id":"f65870ff69b60e15d2d86f2cd6471cb0188ffcbd","user":{"login":"akarnokd","id":1269832,"node_id":"MDQ6VXNlcjEyNjk4MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/1269832?v=4","gravatar_id":"","url":"https://api.github.com/users/akarnokd","html_url":"https://github.com/akarnokd","followers_url":"https://api.github.com/users/akarnokd/followers","following_url":"https://api.github.com/users/akarnokd/following{/other_user}","gists_url":"https://api.github.com/users/akarnokd/gists{/gist_id}","starred_url":"https://api.github.com/users/akarnokd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akarnokd/subscriptions","organizations_url":"https://api.github.com/users/akarnokd/orgs","repos_url":"https://api.github.com/users/akarnokd/repos","events_url":"https://api.github.com/users/akarnokd/events{/privacy}","received_events_url":"https://api.github.com/users/akarnokd/received_events","type":"User","site_admin":false},"body":"I find the ordering of the parameters distracting with those Action overloads. I'd prefer this ordering and a renamed internal schedule method.","created_at":"2018-06-01T11:07:45Z","updated_at":"2018-06-01T11:07:45Z","html_url":"https://github.com/dotnet/reactive/pull/558#discussion_r192364178","pull_request_url":"https://api.github.com/repos/dotnet/reactive/pulls/558","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/reactive/pulls/comments/192364178"},"html":{"href":"https://github.com/dotnet/reactive/pull/558#discussion_r192364178"},"pull_request":{"href":"https://api.github.com/repos/dotnet/reactive/pulls/558"}},"in_reply_to_id":192343604},"pull_request":{"url":"https://api.github.com/repos/dotnet/reactive/pulls/558","id":191712783,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNzEyNzgz","html_url":"https://github.com/dotnet/reactive/pull/558","diff_url":"https://github.com/dotnet/reactive/pull/558.diff","patch_url":"https://github.com/dotnet/reactive/pull/558.patch","issue_url":"https://api.github.com/repos/dotnet/reactive/issues/558","number":558,"state":"open","locked":false,"title":"4.x: Use Schedule calls with state","user":{"login":"akarnokd","id":1269832,"node_id":"MDQ6VXNlcjEyNjk4MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/1269832?v=4","gravatar_id":"","url":"https://api.github.com/users/akarnokd","html_url":"https://github.com/akarnokd","followers_url":"https://api.github.com/users/akarnokd/followers","following_url":"https://api.github.com/users/akarnokd/following{/other_user}","gists_url":"https://api.github.com/users/akarnokd/gists{/gist_id}","starred_url":"https://api.github.com/users/akarnokd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akarnokd/subscriptions","organizations_url":"https://api.github.com/users/akarnokd/orgs","repos_url":"https://api.github.com/users/akarnokd/repos","events_url":"https://api.github.com/users/akarnokd/events{/privacy}","received_events_url":"https://api.github.com/users/akarnokd/received_events","type":"User","site_admin":false},"body":"This PR changes most of the no state argument `Schedule` calls into the state-aware `Schedule` calls. This should help avoid instantiating a new delegate because of the variable capture.","created_at":"2018-05-31T10:36:52Z","updated_at":"2018-06-01T11:07:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73f09d297ee3a38f2ff92697dd8ef85dcc6c73b9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/reactive/pulls/558/commits","review_comments_url":"https://api.github.com/repos/dotnet/reactive/pulls/558/comments","review_comment_url":"https://api.github.com/repos/dotnet/reactive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/reactive/issues/558/comments","statuses_url":"https://api.github.com/repos/dotnet/reactive/statuses/037c341966410e9b374807e17622f130f58187be","head":{"label":"akarnokd:AvoidStatelessSchedule","ref":"AvoidStatelessSchedule","sha":"037c341966410e9b374807e17622f130f58187be","user":{"login":"akarnokd","id":1269832,"node_id":"MDQ6VXNlcjEyNjk4MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/1269832?v=4","gravatar_id":"","url":"https://api.github.com/users/akarnokd","html_url":"https://github.com/akarnokd","followers_url":"https://api.github.com/users/akarnokd/followers","following_url":"https://api.github.com/users/akarnokd/following{/other_user}","gists_url":"https://api.github.com/users/akarnokd/gists{/gist_id}","starred_url":"https://api.github.com/users/akarnokd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akarnokd/subscriptions","organizations_url":"https://api.github.com/users/akarnokd/orgs","repos_url":"https://api.github.com/users/akarnokd/repos","events_url":"https://api.github.com/users/akarnokd/events{/privacy}","received_events_url":"https://api.github.com/users/akarnokd/received_events","type":"User","site_admin":false},"repo":{"id":65015379,"node_id":"MDEwOlJlcG9zaXRvcnk2NTAxNTM3OQ==","name":"Rx.NET","full_name":"akarnokd/Rx.NET","owner":{"login":"akarnokd","id":1269832,"node_id":"MDQ6VXNlcjEyNjk4MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/1269832?v=4","gravatar_id":"","url":"https://api.github.com/users/akarnokd","html_url":"https://github.com/akarnokd","followers_url":"https://api.github.com/users/akarnokd/followers","following_url":"https://api.github.com/users/akarnokd/following{/other_user}","gists_url":"https://api.github.com/users/akarnokd/gists{/gist_id}","starred_url":"https://api.github.com/users/akarnokd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akarnokd/subscriptions","organizations_url":"https://api.github.com/users/akarnokd/orgs","repos_url":"https://api.github.com/users/akarnokd/repos","events_url":"https://api.github.com/users/akarnokd/events{/privacy}","received_events_url":"https://api.github.com/users/akarnokd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akarnokd/Rx.NET","description":"The Reactive Extensions for .NET","fork":true,"url":"https://api.github.com/repos/akarnokd/Rx.NET","forks_url":"https://api.github.com/repos/akarnokd/Rx.NET/forks","keys_url":"https://api.github.com/repos/akarnokd/Rx.NET/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akarnokd/Rx.NET/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akarnokd/Rx.NET/teams","hooks_url":"https://api.github.com/repos/akarnokd/Rx.NET/hooks","issue_events_url":"https://api.github.com/repos/akarnokd/Rx.NET/issues/events{/number}","events_url":"https://api.github.com/repos/akarnokd/Rx.NET/events","assignees_url":"https://api.github.com/repos/akarnokd/Rx.NET/assignees{/user}","branches_url":"https://api.github.com/repos/akarnokd/Rx.NET/branches{/branch}","tags_url":"https://api.github.com/repos/akarnokd/Rx.NET/tags","blobs_url":"https://api.github.com/repos/akarnokd/Rx.NET/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akarnokd/Rx.NET/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akarnokd/Rx.NET/git/refs{/sha}","trees_url":"https://api.github.com/repos/akarnokd/Rx.NET/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akarnokd/Rx.NET/statuses/{sha}","languages_url":"https://api.github.com/repos/akarnokd/Rx.NET/languages","stargazers_url":"https://api.github.com/repos/akarnokd/Rx.NET/stargazers","contributors_url":"https://api.github.com/repos/akarnokd/Rx.NET/contributors","subscribers_url":"https://api.github.com/repos/akarnokd/Rx.NET/subscribers","subscription_url":"https://api.github.com/repos/akarnokd/Rx.NET/subscription","commits_url":"https://api.github.com/repos/akarnokd/Rx.NET/commits{/sha}","git_commits_url":"https://api.github.com/repos/akarnokd/Rx.NET/git/commits{/sha}","comments_url":"https://api.github.com/repos/akarnokd/Rx.NET/comments{/number}","issue_comment_url":"https://api.github.com/repos/akarnokd/Rx.NET/issues/comments{/number}","contents_url":"https://api.github.com/repos/akarnokd/Rx.NET/contents/{+path}","compare_url":"https://api.github.com/repos/akarnokd/Rx.NET/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akarnokd/Rx.NET/merges","archive_url":"https://api.github.com/repos/akarnokd/Rx.NET/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akarnokd/Rx.NET/downloads","issues_url":"https://api.github.com/repos/akarnokd/Rx.NET/issues{/number}","pulls_url":"https://api.github.com/repos/akarnokd/Rx.NET/pulls{/number}","milestones_url":"https://api.github.com/repos/akarnokd/Rx.NET/milestones{/number}","notifications_url":"https://api.github.com/repos/akarnokd/Rx.NET/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akarnokd/Rx.NET/labels{/name}","releases_url":"https://api.github.com/repos/akarnokd/Rx.NET/releases{/id}","deployments_url":"https://api.github.com/repos/akarnokd/Rx.NET/deployments","created_at":"2016-08-05T12:02:35Z","updated_at":"2018-05-28T21:59:36Z","pushed_at":"2018-06-01T10:58:02Z","git_url":"git://github.com/akarnokd/Rx.NET.git","ssh_url":"git@github.com:akarnokd/Rx.NET.git","clone_url":"https://github.com/akarnokd/Rx.NET.git","svn_url":"https://github.com/akarnokd/Rx.NET","homepage":"http://reactivex.io","size":30120,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"389881c4f6f312d4499ce620681c52848395e34b","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":12576526,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU3NjUyNg==","name":"reactive","full_name":"dotnet/reactive","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/reactive","description":"The Reactive Extensions for .NET","fork":false,"url":"https://api.github.com/repos/dotnet/reactive","forks_url":"https://api.github.com/repos/dotnet/reactive/forks","keys_url":"https://api.github.com/repos/dotnet/reactive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/reactive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/reactive/teams","hooks_url":"https://api.github.com/repos/dotnet/reactive/hooks","issue_events_url":"https://api.github.com/repos/dotnet/reactive/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/reactive/events","assignees_url":"https://api.github.com/repos/dotnet/reactive/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/reactive/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/reactive/tags","blobs_url":"https://api.github.com/repos/dotnet/reactive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/reactive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/reactive/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/reactive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/reactive/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/reactive/languages","stargazers_url":"https://api.github.com/repos/dotnet/reactive/stargazers","contributors_url":"https://api.github.com/repos/dotnet/reactive/contributors","subscribers_url":"https://api.github.com/repos/dotnet/reactive/subscribers","subscription_url":"https://api.github.com/repos/dotnet/reactive/subscription","commits_url":"https://api.github.com/repos/dotnet/reactive/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/reactive/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/reactive/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/reactive/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/reactive/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/reactive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/reactive/merges","archive_url":"https://api.github.com/repos/dotnet/reactive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/reactive/downloads","issues_url":"https://api.github.com/repos/dotnet/reactive/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/reactive/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/reactive/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/reactive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/reactive/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/reactive/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/reactive/deployments","created_at":"2013-09-03T22:33:51Z","updated_at":"2018-06-01T10:02:32Z","pushed_at":"2018-06-01T10:53:20Z","git_url":"git://github.com/dotnet/reactive.git","ssh_url":"git@github.com:dotnet/reactive.git","clone_url":"https://github.com/dotnet/reactive.git","svn_url":"https://github.com/dotnet/reactive","homepage":"http://reactivex.io","size":37362,"stargazers_count":2731,"watchers_count":2731,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":406,"mirror_url":null,"archived":false,"open_issues_count":137,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":406,"open_issues":137,"watchers":2731,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/reactive/pulls/558"},"html":{"href":"https://github.com/dotnet/reactive/pull/558"},"issue":{"href":"https://api.github.com/repos/dotnet/reactive/issues/558"},"comments":{"href":"https://api.github.com/repos/dotnet/reactive/issues/558/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/reactive/pulls/558/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/reactive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/reactive/pulls/558/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/reactive/statuses/037c341966410e9b374807e17622f130f58187be"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"akarnokd"}}