{"action":"created","comment":{"url":"https://api.github.com/repos/mpigsley/sectors-without-number/pulls/comments/190875832","pull_request_review_id":123348958,"id":190875832,"diff_hunk":"@@ -61,8 +62,16 @@ const mapDispatchToProps = (dispatch, props) => ({\n   addRouteLocation: key => dispatch(addRouteLocation(key)),\n   completeRoute: () => dispatch(completeRoute(props.intl)),\n   updateNavSettings: (key, value) => dispatch(updateNavSettings(key, value)),\n+  toEntity: (entityType, entityId) => {\n+    const route = `/sector/${\n+      props.match.params.sector\n+    }/${entityType}/${entityId}`;","path":"src/components/hex-map/index.js","position":17,"original_position":17,"commit_id":"8039aadcaf959632ed30ac8efcaa8ca443d89990","original_commit_id":"8039aadcaf959632ed30ac8efcaa8ca443d89990","user":{"login":"mpigsley","id":3017491,"avatar_url":"https://avatars3.githubusercontent.com/u/3017491?v=4","gravatar_id":"","url":"https://api.github.com/users/mpigsley","html_url":"https://github.com/mpigsley","followers_url":"https://api.github.com/users/mpigsley/followers","following_url":"https://api.github.com/users/mpigsley/following{/other_user}","gists_url":"https://api.github.com/users/mpigsley/gists{/gist_id}","starred_url":"https://api.github.com/users/mpigsley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpigsley/subscriptions","organizations_url":"https://api.github.com/users/mpigsley/orgs","repos_url":"https://api.github.com/users/mpigsley/repos","events_url":"https://api.github.com/users/mpigsley/events{/privacy}","received_events_url":"https://api.github.com/users/mpigsley/received_events","type":"User","site_admin":false},"body":"Not a fan of all this logic in the react-router definition for this component. Will probably move this some day.","created_at":"2018-05-25T12:17:46Z","updated_at":"2018-05-25T12:17:46Z","html_url":"https://github.com/mpigsley/sectors-without-number/pull/160#discussion_r190875832","pull_request_url":"https://api.github.com/repos/mpigsley/sectors-without-number/pulls/160","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mpigsley/sectors-without-number/pulls/comments/190875832"},"html":{"href":"https://github.com/mpigsley/sectors-without-number/pull/160#discussion_r190875832"},"pull_request":{"href":"https://api.github.com/repos/mpigsley/sectors-without-number/pulls/160"}}},"pull_request":{"url":"https://api.github.com/repos/mpigsley/sectors-without-number/pulls/160","id":190570325,"html_url":"https://github.com/mpigsley/sectors-without-number/pull/160","diff_url":"https://github.com/mpigsley/sectors-without-number/pull/160.diff","patch_url":"https://github.com/mpigsley/sectors-without-number/pull/160.patch","issue_url":"https://api.github.com/repos/mpigsley/sectors-without-number/issues/160","number":160,"state":"open","locked":false,"title":"Upgrade React Router","user":{"login":"mpigsley","id":3017491,"avatar_url":"https://avatars3.githubusercontent.com/u/3017491?v=4","gravatar_id":"","url":"https://api.github.com/users/mpigsley","html_url":"https://github.com/mpigsley","followers_url":"https://api.github.com/users/mpigsley/followers","following_url":"https://api.github.com/users/mpigsley/following{/other_user}","gists_url":"https://api.github.com/users/mpigsley/gists{/gist_id}","starred_url":"https://api.github.com/users/mpigsley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpigsley/subscriptions","organizations_url":"https://api.github.com/users/mpigsley/orgs","repos_url":"https://api.github.com/users/mpigsley/repos","events_url":"https://api.github.com/users/mpigsley/events{/privacy}","received_events_url":"https://api.github.com/users/mpigsley/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nI tried code splitting the overview but it left me with a super small chunk. It was not at all worth it. \r\n\r\nBUT, just for reference [I committed it](https://github.com/mpigsley/sectors-without-number/commit/2cbcef7c5be6e761f7fcc5ba14db7f85d3e8f6d2) and reverted it so I have something to look back on if/when I do this in the future.\r\n\r\nReact router upgrade is necessary though. It just makes things nice.\r\n\r\nResolves #159 ","created_at":"2018-05-25T12:16:00Z","updated_at":"2018-05-25T12:17:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bdc5f392816036302c17bb3637376a39c88dfd97","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mpigsley/sectors-without-number/pulls/160/commits","review_comments_url":"https://api.github.com/repos/mpigsley/sectors-without-number/pulls/160/comments","review_comment_url":"https://api.github.com/repos/mpigsley/sectors-without-number/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mpigsley/sectors-without-number/issues/160/comments","statuses_url":"https://api.github.com/repos/mpigsley/sectors-without-number/statuses/8039aadcaf959632ed30ac8efcaa8ca443d89990","head":{"label":"mpigsley:upgrade-react-router","ref":"upgrade-react-router","sha":"8039aadcaf959632ed30ac8efcaa8ca443d89990","user":{"login":"mpigsley","id":3017491,"avatar_url":"https://avatars3.githubusercontent.com/u/3017491?v=4","gravatar_id":"","url":"https://api.github.com/users/mpigsley","html_url":"https://github.com/mpigsley","followers_url":"https://api.github.com/users/mpigsley/followers","following_url":"https://api.github.com/users/mpigsley/following{/other_user}","gists_url":"https://api.github.com/users/mpigsley/gists{/gist_id}","starred_url":"https://api.github.com/users/mpigsley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpigsley/subscriptions","organizations_url":"https://api.github.com/users/mpigsley/orgs","repos_url":"https://api.github.com/users/mpigsley/repos","events_url":"https://api.github.com/users/mpigsley/events{/privacy}","received_events_url":"https://api.github.com/users/mpigsley/received_events","type":"User","site_admin":false},"repo":{"id":96460692,"name":"sectors-without-number","full_name":"mpigsley/sectors-without-number","owner":{"login":"mpigsley","id":3017491,"avatar_url":"https://avatars3.githubusercontent.com/u/3017491?v=4","gravatar_id":"","url":"https://api.github.com/users/mpigsley","html_url":"https://github.com/mpigsley","followers_url":"https://api.github.com/users/mpigsley/followers","following_url":"https://api.github.com/users/mpigsley/following{/other_user}","gists_url":"https://api.github.com/users/mpigsley/gists{/gist_id}","starred_url":"https://api.github.com/users/mpigsley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpigsley/subscriptions","organizations_url":"https://api.github.com/users/mpigsley/orgs","repos_url":"https://api.github.com/users/mpigsley/repos","events_url":"https://api.github.com/users/mpigsley/events{/privacy}","received_events_url":"https://api.github.com/users/mpigsley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mpigsley/sectors-without-number","description":"A random, revised edition compliant, stars without number sector generator","fork":false,"url":"https://api.github.com/repos/mpigsley/sectors-without-number","forks_url":"https://api.github.com/repos/mpigsley/sectors-without-number/forks","keys_url":"https://api.github.com/repos/mpigsley/sectors-without-number/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpigsley/sectors-without-number/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpigsley/sectors-without-number/teams","hooks_url":"https://api.github.com/repos/mpigsley/sectors-without-number/hooks","issue_events_url":"https://api.github.com/repos/mpigsley/sectors-without-number/issues/events{/number}","events_url":"https://api.github.com/repos/mpigsley/sectors-without-number/events","assignees_url":"https://api.github.com/repos/mpigsley/sectors-without-number/assignees{/user}","branches_url":"https://api.github.com/repos/mpigsley/sectors-without-number/branches{/branch}","tags_url":"https://api.github.com/repos/mpigsley/sectors-without-number/tags","blobs_url":"https://api.github.com/repos/mpigsley/sectors-without-number/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpigsley/sectors-without-number/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpigsley/sectors-without-number/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpigsley/sectors-without-number/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpigsley/sectors-without-number/statuses/{sha}","languages_url":"https://api.github.com/repos/mpigsley/sectors-without-number/languages","stargazers_url":"https://api.github.com/repos/mpigsley/sectors-without-number/stargazers","contributors_url":"https://api.github.com/repos/mpigsley/sectors-without-number/contributors","subscribers_url":"https://api.github.com/repos/mpigsley/sectors-without-number/subscribers","subscription_url":"https://api.github.com/repos/mpigsley/sectors-without-number/subscription","commits_url":"https://api.github.com/repos/mpigsley/sectors-without-number/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpigsley/sectors-without-number/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpigsley/sectors-without-number/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpigsley/sectors-without-number/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpigsley/sectors-without-number/contents/{+path}","compare_url":"https://api.github.com/repos/mpigsley/sectors-without-number/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpigsley/sectors-without-number/merges","archive_url":"https://api.github.com/repos/mpigsley/sectors-without-number/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpigsley/sectors-without-number/downloads","issues_url":"https://api.github.com/repos/mpigsley/sectors-without-number/issues{/number}","pulls_url":"https://api.github.com/repos/mpigsley/sectors-without-number/pulls{/number}","milestones_url":"https://api.github.com/repos/mpigsley/sectors-without-number/milestones{/number}","notifications_url":"https://api.github.com/repos/mpigsley/sectors-without-number/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpigsley/sectors-without-number/labels{/name}","releases_url":"https://api.github.com/repos/mpigsley/sectors-without-number/releases{/id}","deployments_url":"https://api.github.com/repos/mpigsley/sectors-without-number/deployments","created_at":"2017-07-06T18:32:20Z","updated_at":"2018-05-24T12:28:49Z","pushed_at":"2018-05-25T12:16:00Z","git_url":"git://github.com/mpigsley/sectors-without-number.git","ssh_url":"git@github.com:mpigsley/sectors-without-number.git","clone_url":"https://github.com/mpigsley/sectors-without-number.git","svn_url":"https://github.com/mpigsley/sectors-without-number","homepage":"https://sectorswithoutnumber.com","size":3417,"stargazers_count":30,"watchers_count":30,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":7,"open_issues":26,"watchers":30,"default_branch":"master"}},"base":{"label":"mpigsley:master","ref":"master","sha":"6a3bcaf8932f66fc45a955816e007caf1eae9db3","user":{"login":"mpigsley","id":3017491,"avatar_url":"https://avatars3.githubusercontent.com/u/3017491?v=4","gravatar_id":"","url":"https://api.github.com/users/mpigsley","html_url":"https://github.com/mpigsley","followers_url":"https://api.github.com/users/mpigsley/followers","following_url":"https://api.github.com/users/mpigsley/following{/other_user}","gists_url":"https://api.github.com/users/mpigsley/gists{/gist_id}","starred_url":"https://api.github.com/users/mpigsley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpigsley/subscriptions","organizations_url":"https://api.github.com/users/mpigsley/orgs","repos_url":"https://api.github.com/users/mpigsley/repos","events_url":"https://api.github.com/users/mpigsley/events{/privacy}","received_events_url":"https://api.github.com/users/mpigsley/received_events","type":"User","site_admin":false},"repo":{"id":96460692,"name":"sectors-without-number","full_name":"mpigsley/sectors-without-number","owner":{"login":"mpigsley","id":3017491,"avatar_url":"https://avatars3.githubusercontent.com/u/3017491?v=4","gravatar_id":"","url":"https://api.github.com/users/mpigsley","html_url":"https://github.com/mpigsley","followers_url":"https://api.github.com/users/mpigsley/followers","following_url":"https://api.github.com/users/mpigsley/following{/other_user}","gists_url":"https://api.github.com/users/mpigsley/gists{/gist_id}","starred_url":"https://api.github.com/users/mpigsley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpigsley/subscriptions","organizations_url":"https://api.github.com/users/mpigsley/orgs","repos_url":"https://api.github.com/users/mpigsley/repos","events_url":"https://api.github.com/users/mpigsley/events{/privacy}","received_events_url":"https://api.github.com/users/mpigsley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mpigsley/sectors-without-number","description":"A random, revised edition compliant, stars without number sector generator","fork":false,"url":"https://api.github.com/repos/mpigsley/sectors-without-number","forks_url":"https://api.github.com/repos/mpigsley/sectors-without-number/forks","keys_url":"https://api.github.com/repos/mpigsley/sectors-without-number/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpigsley/sectors-without-number/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpigsley/sectors-without-number/teams","hooks_url":"https://api.github.com/repos/mpigsley/sectors-without-number/hooks","issue_events_url":"https://api.github.com/repos/mpigsley/sectors-without-number/issues/events{/number}","events_url":"https://api.github.com/repos/mpigsley/sectors-without-number/events","assignees_url":"https://api.github.com/repos/mpigsley/sectors-without-number/assignees{/user}","branches_url":"https://api.github.com/repos/mpigsley/sectors-without-number/branches{/branch}","tags_url":"https://api.github.com/repos/mpigsley/sectors-without-number/tags","blobs_url":"https://api.github.com/repos/mpigsley/sectors-without-number/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpigsley/sectors-without-number/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpigsley/sectors-without-number/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpigsley/sectors-without-number/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpigsley/sectors-without-number/statuses/{sha}","languages_url":"https://api.github.com/repos/mpigsley/sectors-without-number/languages","stargazers_url":"https://api.github.com/repos/mpigsley/sectors-without-number/stargazers","contributors_url":"https://api.github.com/repos/mpigsley/sectors-without-number/contributors","subscribers_url":"https://api.github.com/repos/mpigsley/sectors-without-number/subscribers","subscription_url":"https://api.github.com/repos/mpigsley/sectors-without-number/subscription","commits_url":"https://api.github.com/repos/mpigsley/sectors-without-number/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpigsley/sectors-without-number/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpigsley/sectors-without-number/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpigsley/sectors-without-number/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpigsley/sectors-without-number/contents/{+path}","compare_url":"https://api.github.com/repos/mpigsley/sectors-without-number/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpigsley/sectors-without-number/merges","archive_url":"https://api.github.com/repos/mpigsley/sectors-without-number/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpigsley/sectors-without-number/downloads","issues_url":"https://api.github.com/repos/mpigsley/sectors-without-number/issues{/number}","pulls_url":"https://api.github.com/repos/mpigsley/sectors-without-number/pulls{/number}","milestones_url":"https://api.github.com/repos/mpigsley/sectors-without-number/milestones{/number}","notifications_url":"https://api.github.com/repos/mpigsley/sectors-without-number/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpigsley/sectors-without-number/labels{/name}","releases_url":"https://api.github.com/repos/mpigsley/sectors-without-number/releases{/id}","deployments_url":"https://api.github.com/repos/mpigsley/sectors-without-number/deployments","created_at":"2017-07-06T18:32:20Z","updated_at":"2018-05-24T12:28:49Z","pushed_at":"2018-05-25T12:16:00Z","git_url":"git://github.com/mpigsley/sectors-without-number.git","ssh_url":"git@github.com:mpigsley/sectors-without-number.git","clone_url":"https://github.com/mpigsley/sectors-without-number.git","svn_url":"https://github.com/mpigsley/sectors-without-number","homepage":"https://sectorswithoutnumber.com","size":3417,"stargazers_count":30,"watchers_count":30,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":7,"open_issues":26,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mpigsley/sectors-without-number/pulls/160"},"html":{"href":"https://github.com/mpigsley/sectors-without-number/pull/160"},"issue":{"href":"https://api.github.com/repos/mpigsley/sectors-without-number/issues/160"},"comments":{"href":"https://api.github.com/repos/mpigsley/sectors-without-number/issues/160/comments"},"review_comments":{"href":"https://api.github.com/repos/mpigsley/sectors-without-number/pulls/160/comments"},"review_comment":{"href":"https://api.github.com/repos/mpigsley/sectors-without-number/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mpigsley/sectors-without-number/pulls/160/commits"},"statuses":{"href":"https://api.github.com/repos/mpigsley/sectors-without-number/statuses/8039aadcaf959632ed30ac8efcaa8ca443d89990"}},"author_association":"OWNER"}}
{"actor":{"display_login":"mpigsley"}}