{"action":"created","issue":{"url":"https://api.github.com/repos/postcss/postcss/issues/1163","repository_url":"https://api.github.com/repos/postcss/postcss","labels_url":"https://api.github.com/repos/postcss/postcss/issues/1163/labels{/name}","comments_url":"https://api.github.com/repos/postcss/postcss/issues/1163/comments","events_url":"https://api.github.com/repos/postcss/postcss/issues/1163/events","html_url":"https://github.com/postcss/postcss/pull/1163","id":337273156,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NTEzMDc3","number":1163,"title":"Tried to speed up tokenizer using Uint32Array","user":{"login":"lily-moon","id":28871388,"node_id":"MDQ6VXNlcjI4ODcxMzg4","avatar_url":"https://avatars0.githubusercontent.com/u/28871388?v=4","gravatar_id":"","url":"https://api.github.com/users/lily-moon","html_url":"https://github.com/lily-moon","followers_url":"https://api.github.com/users/lily-moon/followers","following_url":"https://api.github.com/users/lily-moon/following{/other_user}","gists_url":"https://api.github.com/users/lily-moon/gists{/gist_id}","starred_url":"https://api.github.com/users/lily-moon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lily-moon/subscriptions","organizations_url":"https://api.github.com/users/lily-moon/orgs","repos_url":"https://api.github.com/users/lily-moon/repos","events_url":"https://api.github.com/users/lily-moon/events{/privacy}","received_events_url":"https://api.github.com/users/lily-moon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-07-01T08:14:10Z","updated_at":"2018-07-01T19:06:12Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/postcss/postcss/pulls/1163","html_url":"https://github.com/postcss/postcss/pull/1163","diff_url":"https://github.com/postcss/postcss/pull/1163.diff","patch_url":"https://github.com/postcss/postcss/pull/1163.patch"},"body":"I've changed tokenizer and parser code according to https://github.com/postcss/postcss/issues/1162. Tokenizer uses one instance of Uint32Array.\r\nTo make this work I also needed to fix tests.\r\n\r\nAs I see there is no change in perfomance. Moreover using one instance of Uint32Array in tokenizer leads to creating new instances in parser to fill array of tokens or brackets. \r\n\r\nAnd as a result, GC starts less frequently in tokenizer and more frequently in parser."},"comment":{"url":"https://api.github.com/repos/postcss/postcss/issues/comments/401626327","html_url":"https://github.com/postcss/postcss/pull/1163#issuecomment-401626327","issue_url":"https://api.github.com/repos/postcss/postcss/issues/1163","id":401626327,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTYyNjMyNw==","user":{"login":"lily-moon","id":28871388,"node_id":"MDQ6VXNlcjI4ODcxMzg4","avatar_url":"https://avatars0.githubusercontent.com/u/28871388?v=4","gravatar_id":"","url":"https://api.github.com/users/lily-moon","html_url":"https://github.com/lily-moon","followers_url":"https://api.github.com/users/lily-moon/followers","following_url":"https://api.github.com/users/lily-moon/following{/other_user}","gists_url":"https://api.github.com/users/lily-moon/gists{/gist_id}","starred_url":"https://api.github.com/users/lily-moon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lily-moon/subscriptions","organizations_url":"https://api.github.com/users/lily-moon/orgs","repos_url":"https://api.github.com/users/lily-moon/repos","events_url":"https://api.github.com/users/lily-moon/events{/privacy}","received_events_url":"https://api.github.com/users/lily-moon/received_events","type":"User","site_admin":false},"created_at":"2018-07-01T19:06:12Z","updated_at":"2018-07-01T19:06:12Z","author_association":"NONE","body":"perf test result is following:\r\n```\r\nPostCSS x 67.18 ops/sec ±4.58% (39 runs sampled)\r\nPostCSS dev x 54.98 ops/sec ±5.92% (61 runs sampled)\r\nFastest test is PostCSS at 1.22x faster than PostCSS dev\r\n\r\nPostCSS:     15 ms\r\nPostCSS dev: 18 ms (1.2 times slower)\r\n```"}}
{"actor":{"display_login":"lily-moon"}}