{"action":"created","comment":{"url":"https://api.github.com/repos/appium/WebDriverAgent/pulls/comments/184612499","pull_request_review_id":115844367,"id":184612499,"diff_hunk":"@@ -137,6 +137,13 @@ - (BOOL)fb_hasAnyVisibleLeafs\n \n - (BOOL)fb_isVisible\n {\n+  if ([FBConfiguration shouldLoadSnapshotWithAttributes]) {","path":"WebDriverAgentLib/Categories/XCUIElement+FBIsVisible.m","position":4,"original_position":4,"commit_id":"401948ed2c59e4d95ffa3149fbc39338ec30d80e","original_commit_id":"401948ed2c59e4d95ffa3149fbc39338ec30d80e","user":{"login":"mykola-mokhnach","id":7767781,"avatar_url":"https://avatars1.githubusercontent.com/u/7767781?v=4","gravatar_id":"","url":"https://api.github.com/users/mykola-mokhnach","html_url":"https://github.com/mykola-mokhnach","followers_url":"https://api.github.com/users/mykola-mokhnach/followers","following_url":"https://api.github.com/users/mykola-mokhnach/following{/other_user}","gists_url":"https://api.github.com/users/mykola-mokhnach/gists{/gist_id}","starred_url":"https://api.github.com/users/mykola-mokhnach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykola-mokhnach/subscriptions","organizations_url":"https://api.github.com/users/mykola-mokhnach/orgs","repos_url":"https://api.github.com/users/mykola-mokhnach/repos","events_url":"https://api.github.com/users/mykola-mokhnach/events{/privacy}","received_events_url":"https://api.github.com/users/mykola-mokhnach/received_events","type":"User","site_admin":false},"body":"It would be nice to add a comment there. Although, I'm still not quite sure about the general stability of this strategy (see the comment below regarding FB_XCAXAIsVisibleAttribute)","created_at":"2018-04-27T07:35:05Z","updated_at":"2018-04-27T07:35:05Z","html_url":"https://github.com/appium/WebDriverAgent/pull/80#discussion_r184612499","pull_request_url":"https://api.github.com/repos/appium/WebDriverAgent/pulls/80","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/appium/WebDriverAgent/pulls/comments/184612499"},"html":{"href":"https://github.com/appium/WebDriverAgent/pull/80#discussion_r184612499"},"pull_request":{"href":"https://api.github.com/repos/appium/WebDriverAgent/pulls/80"}},"in_reply_to_id":184461995},"pull_request":{"url":"https://api.github.com/repos/appium/WebDriverAgent/pulls/80","id":184396803,"html_url":"https://github.com/appium/WebDriverAgent/pull/80","diff_url":"https://github.com/appium/WebDriverAgent/pull/80.diff","patch_url":"https://github.com/appium/WebDriverAgent/pull/80.patch","issue_url":"https://api.github.com/repos/appium/WebDriverAgent/issues/80","number":80,"state":"open","locked":false,"title":"Improved get page source performance","user":{"login":"dmissmann","id":37073203,"avatar_url":"https://avatars0.githubusercontent.com/u/37073203?v=4","gravatar_id":"","url":"https://api.github.com/users/dmissmann","html_url":"https://github.com/dmissmann","followers_url":"https://api.github.com/users/dmissmann/followers","following_url":"https://api.github.com/users/dmissmann/following{/other_user}","gists_url":"https://api.github.com/users/dmissmann/gists{/gist_id}","starred_url":"https://api.github.com/users/dmissmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmissmann/subscriptions","organizations_url":"https://api.github.com/users/dmissmann/orgs","repos_url":"https://api.github.com/users/dmissmann/repos","events_url":"https://api.github.com/users/dmissmann/events{/privacy}","received_events_url":"https://api.github.com/users/dmissmann/received_events","type":"User","site_admin":false},"body":"In the case when getting the page source takes too long this seems to be due to requesting all attributes for each snapshot element individually. As it turns out we can request a snapshot with all required attributes resolved from `XCTestManager_ManagerInterface` by passing a list of wanted attributes.\r\n\r\nEnabling the new capability `shouldLoadSnapshotWithAttributes` in combination with `useJSONSource` reduces the response time from hitting the timeout of 60s to 1-2s (without `useJSONSource` about 8seconds for the same app and device).","created_at":"2018-04-26T16:29:40Z","updated_at":"2018-04-27T07:35:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"708cf4ccf029767fda1e6e2487e571ffb5b1edba","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/appium/WebDriverAgent/pulls/80/commits","review_comments_url":"https://api.github.com/repos/appium/WebDriverAgent/pulls/80/comments","review_comment_url":"https://api.github.com/repos/appium/WebDriverAgent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appium/WebDriverAgent/issues/80/comments","statuses_url":"https://api.github.com/repos/appium/WebDriverAgent/statuses/401948ed2c59e4d95ffa3149fbc39338ec30d80e","head":{"label":"dmissmann:GetPageSource","ref":"GetPageSource","sha":"401948ed2c59e4d95ffa3149fbc39338ec30d80e","user":{"login":"dmissmann","id":37073203,"avatar_url":"https://avatars0.githubusercontent.com/u/37073203?v=4","gravatar_id":"","url":"https://api.github.com/users/dmissmann","html_url":"https://github.com/dmissmann","followers_url":"https://api.github.com/users/dmissmann/followers","following_url":"https://api.github.com/users/dmissmann/following{/other_user}","gists_url":"https://api.github.com/users/dmissmann/gists{/gist_id}","starred_url":"https://api.github.com/users/dmissmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmissmann/subscriptions","organizations_url":"https://api.github.com/users/dmissmann/orgs","repos_url":"https://api.github.com/users/dmissmann/repos","events_url":"https://api.github.com/users/dmissmann/events{/privacy}","received_events_url":"https://api.github.com/users/dmissmann/received_events","type":"User","site_admin":false},"repo":{"id":130972676,"name":"WebDriverAgent","full_name":"dmissmann/WebDriverAgent","owner":{"login":"dmissmann","id":37073203,"avatar_url":"https://avatars0.githubusercontent.com/u/37073203?v=4","gravatar_id":"","url":"https://api.github.com/users/dmissmann","html_url":"https://github.com/dmissmann","followers_url":"https://api.github.com/users/dmissmann/followers","following_url":"https://api.github.com/users/dmissmann/following{/other_user}","gists_url":"https://api.github.com/users/dmissmann/gists{/gist_id}","starred_url":"https://api.github.com/users/dmissmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmissmann/subscriptions","organizations_url":"https://api.github.com/users/dmissmann/orgs","repos_url":"https://api.github.com/users/dmissmann/repos","events_url":"https://api.github.com/users/dmissmann/events{/privacy}","received_events_url":"https://api.github.com/users/dmissmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmissmann/WebDriverAgent","description":"A WebDriver server for iOS that runs inside the Simulator.","fork":true,"url":"https://api.github.com/repos/dmissmann/WebDriverAgent","forks_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/forks","keys_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/teams","hooks_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/hooks","issue_events_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/issues/events{/number}","events_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/events","assignees_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/assignees{/user}","branches_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/branches{/branch}","tags_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/tags","blobs_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/statuses/{sha}","languages_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/languages","stargazers_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/stargazers","contributors_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/contributors","subscribers_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/subscribers","subscription_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/subscription","commits_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/contents/{+path}","compare_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/merges","archive_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/downloads","issues_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/issues{/number}","pulls_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/pulls{/number}","milestones_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/milestones{/number}","notifications_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/labels{/name}","releases_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/releases{/id}","deployments_url":"https://api.github.com/repos/dmissmann/WebDriverAgent/deployments","created_at":"2018-04-25T08:10:53Z","updated_at":"2018-04-25T08:10:55Z","pushed_at":"2018-04-26T16:21:26Z","git_url":"git://github.com/dmissmann/WebDriverAgent.git","ssh_url":"git@github.com:dmissmann/WebDriverAgent.git","clone_url":"https://github.com/dmissmann/WebDriverAgent.git","svn_url":"https://github.com/dmissmann/WebDriverAgent","homepage":null,"size":41642,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appium:master","ref":"master","sha":"6ba18b33c14165af189644c5e87821ef47260fb7","user":{"login":"appium","id":3221291,"avatar_url":"https://avatars2.githubusercontent.com/u/3221291?v=4","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"repo":{"id":84954452,"name":"WebDriverAgent","full_name":"appium/WebDriverAgent","owner":{"login":"appium","id":3221291,"avatar_url":"https://avatars2.githubusercontent.com/u/3221291?v=4","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appium/WebDriverAgent","description":"A WebDriver server for iOS that runs inside the Simulator.","fork":true,"url":"https://api.github.com/repos/appium/WebDriverAgent","forks_url":"https://api.github.com/repos/appium/WebDriverAgent/forks","keys_url":"https://api.github.com/repos/appium/WebDriverAgent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appium/WebDriverAgent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appium/WebDriverAgent/teams","hooks_url":"https://api.github.com/repos/appium/WebDriverAgent/hooks","issue_events_url":"https://api.github.com/repos/appium/WebDriverAgent/issues/events{/number}","events_url":"https://api.github.com/repos/appium/WebDriverAgent/events","assignees_url":"https://api.github.com/repos/appium/WebDriverAgent/assignees{/user}","branches_url":"https://api.github.com/repos/appium/WebDriverAgent/branches{/branch}","tags_url":"https://api.github.com/repos/appium/WebDriverAgent/tags","blobs_url":"https://api.github.com/repos/appium/WebDriverAgent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appium/WebDriverAgent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appium/WebDriverAgent/git/refs{/sha}","trees_url":"https://api.github.com/repos/appium/WebDriverAgent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appium/WebDriverAgent/statuses/{sha}","languages_url":"https://api.github.com/repos/appium/WebDriverAgent/languages","stargazers_url":"https://api.github.com/repos/appium/WebDriverAgent/stargazers","contributors_url":"https://api.github.com/repos/appium/WebDriverAgent/contributors","subscribers_url":"https://api.github.com/repos/appium/WebDriverAgent/subscribers","subscription_url":"https://api.github.com/repos/appium/WebDriverAgent/subscription","commits_url":"https://api.github.com/repos/appium/WebDriverAgent/commits{/sha}","git_commits_url":"https://api.github.com/repos/appium/WebDriverAgent/git/commits{/sha}","comments_url":"https://api.github.com/repos/appium/WebDriverAgent/comments{/number}","issue_comment_url":"https://api.github.com/repos/appium/WebDriverAgent/issues/comments{/number}","contents_url":"https://api.github.com/repos/appium/WebDriverAgent/contents/{+path}","compare_url":"https://api.github.com/repos/appium/WebDriverAgent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appium/WebDriverAgent/merges","archive_url":"https://api.github.com/repos/appium/WebDriverAgent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appium/WebDriverAgent/downloads","issues_url":"https://api.github.com/repos/appium/WebDriverAgent/issues{/number}","pulls_url":"https://api.github.com/repos/appium/WebDriverAgent/pulls{/number}","milestones_url":"https://api.github.com/repos/appium/WebDriverAgent/milestones{/number}","notifications_url":"https://api.github.com/repos/appium/WebDriverAgent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appium/WebDriverAgent/labels{/name}","releases_url":"https://api.github.com/repos/appium/WebDriverAgent/releases{/id}","deployments_url":"https://api.github.com/repos/appium/WebDriverAgent/deployments","created_at":"2017-03-14T13:50:31Z","updated_at":"2018-04-18T18:21:19Z","pushed_at":"2018-04-26T16:29:41Z","git_url":"git://github.com/appium/WebDriverAgent.git","ssh_url":"git@github.com:appium/WebDriverAgent.git","clone_url":"https://github.com/appium/WebDriverAgent.git","svn_url":"https://github.com/appium/WebDriverAgent","homepage":null,"size":41631,"stargazers_count":11,"watchers_count":11,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":14,"open_issues":2,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appium/WebDriverAgent/pulls/80"},"html":{"href":"https://github.com/appium/WebDriverAgent/pull/80"},"issue":{"href":"https://api.github.com/repos/appium/WebDriverAgent/issues/80"},"comments":{"href":"https://api.github.com/repos/appium/WebDriverAgent/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/appium/WebDriverAgent/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/appium/WebDriverAgent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appium/WebDriverAgent/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/appium/WebDriverAgent/statuses/401948ed2c59e4d95ffa3149fbc39338ec30d80e"}},"author_association":"NONE"}}
{"actor":{"display_login":"mykola-mokhnach"}}