{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71302","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71302/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71302/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71302/events","html_url":"https://github.com/kubernetes/kubernetes/pull/71302","id":382962490,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNTQzOTQ2","number":71302,"title":"WIP - Verify unit test feature gates","user":{"login":"liggitt","id":980082,"node_id":"MDQ6VXNlcjk4MDA4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"labels":[{"id":136601536,"node_id":"MDU6TGFiZWwxMzY2MDE1MzY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/apiserver","name":"area/apiserver","color":"0052cc","default":false},{"id":116719829,"node_id":"MDU6TGFiZWwxMTY3MTk4Mjk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/kubelet","name":"area/kubelet","color":"0052cc","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":687500047,"node_id":"MDU6TGFiZWw2ODc1MDAwNDc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":122775691,"node_id":"MDU6TGFiZWwxMjI3NzU2OTE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/cleanup","name":"kind/cleanup","color":"c7def8","default":false},{"id":1111992057,"node_id":"MDU6TGFiZWwxMTExOTkyMDU3","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-priority","name":"needs-priority","color":"ededed","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":173493835,"node_id":"MDU6TGFiZWwxNzM0OTM4MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/api-machinery","name":"sig/api-machinery","color":"d2b48c","default":false},{"id":404091735,"node_id":"MDU6TGFiZWw0MDQwOTE3MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/apps","name":"sig/apps","color":"d2b48c","default":false},{"id":958178286,"node_id":"MDU6TGFiZWw5NTgxNzgyODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cloud-provider","name":"sig/cloud-provider","color":"d2b48c","default":false},{"id":116712108,"node_id":"MDU6TGFiZWwxMTY3MTIxMDg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/network","name":"sig/network","color":"d2b48c","default":false},{"id":173493665,"node_id":"MDU6TGFiZWwxNzM0OTM2NjU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/node","name":"sig/node","color":"d2b48c","default":false},{"id":125550211,"node_id":"MDU6TGFiZWwxMjU1NTAyMTE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/scheduling","name":"sig/scheduling","color":"d2b48c","default":false},{"id":483069764,"node_id":"MDU6TGFiZWw0ODMwNjk3NjQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/testing","name":"sig/testing","color":"d2b48c","default":false},{"id":253451057,"node_id":"MDU6TGFiZWwyNTM0NTEwNTc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-21T05:34:58Z","updated_at":"2018-11-21T15:21:34Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/71302","html_url":"https://github.com/kubernetes/kubernetes/pull/71302","diff_url":"https://github.com/kubernetes/kubernetes/pull/71302.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/71302.patch"},"body":"**What type of PR is this?**\r\n/kind cleanup\r\n\r\n**What this PR does / why we need it**:\r\n\r\nFollow-up to https://github.com/kubernetes/kubernetes/pull/71100\r\n\r\n* Tightens the DefaultFeatureGate interface to only allow read access.\r\n* Moves the mutable feature gate methods into a MutableFeatureGate interface\r\n* Switches all remaining unit tests to using the feature gate testing package that auto-restores original values\r\n\r\nTODO:\r\n* write verify script to ensure no test code uses DefaultMutableFeatureGate\r\n* write verify script to ensure test packages that deals in feature gates also has a TestMain that verifies the gate changes do not escape the package.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #71108\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Does this PR introduce a user-facing change?**:\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/440702729","html_url":"https://github.com/kubernetes/kubernetes/pull/71302#issuecomment-440702729","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71302","id":440702729,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDcwMjcyOQ==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-11-21T15:21:34Z","updated_at":"2018-11-21T15:21:34Z","author_association":"CONTRIBUTOR","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/71302#\" title=\"Author self-approved\">liggitt</a>*\nTo fully approve this pull request, please assign additional approvers.\nWe suggest the following additional approvers: **dchen1107**, **mikedanese**, **saad-ali**\n\nIf they are not already assigned, you can assign the PR to them by writing `/assign @dchen1107 @mikedanese @saad-ali` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[cmd/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cmd/OWNERS)**\n- ~~[hack/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/hack/OWNERS)~~ [liggitt]\n- ~~[pkg/api/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/api/OWNERS)~~ [liggitt]\n- ~~[pkg/apis/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/OWNERS)~~ [liggitt]\n- **[pkg/controller/daemon/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/daemon/OWNERS)**\n- **[pkg/controller/volume/persistentvolume/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/volume/persistentvolume/OWNERS)**\n- ~~[pkg/features/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/features/OWNERS)~~ [liggitt]\n- **[pkg/kubelet/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/OWNERS)**\n- ~~[staging/src/k8s.io/apiextensions-apiserver/pkg/features/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiextensions-apiserver/pkg/features/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/apiserver/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/OWNERS)~~ [liggitt]\n- ~~[test/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/OWNERS)~~ [liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"dchen1107\",\"mikedanese\",\"saad-ali\"]} -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}