{"action":"created","issue":{"url":"https://api.github.com/repos/helm/charts/issues/9581","repository_url":"https://api.github.com/repos/helm/charts","labels_url":"https://api.github.com/repos/helm/charts/issues/9581/labels{/name}","comments_url":"https://api.github.com/repos/helm/charts/issues/9581/comments","events_url":"https://api.github.com/repos/helm/charts/issues/9581/events","html_url":"https://github.com/helm/charts/pull/9581","id":384924858,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MDEyODQ4","number":9581,"title":"[incubator/kafka] Add support for Static Ips for Kafka External Load Balancer","user":{"login":"akshayzendesk","id":15615700,"node_id":"MDQ6VXNlcjE1NjE1NzAw","avatar_url":"https://avatars3.githubusercontent.com/u/15615700?v=4","gravatar_id":"","url":"https://api.github.com/users/akshayzendesk","html_url":"https://github.com/akshayzendesk","followers_url":"https://api.github.com/users/akshayzendesk/followers","following_url":"https://api.github.com/users/akshayzendesk/following{/other_user}","gists_url":"https://api.github.com/users/akshayzendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/akshayzendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akshayzendesk/subscriptions","organizations_url":"https://api.github.com/users/akshayzendesk/orgs","repos_url":"https://api.github.com/users/akshayzendesk/repos","events_url":"https://api.github.com/users/akshayzendesk/events{/privacy}","received_events_url":"https://api.github.com/users/akshayzendesk/received_events","type":"User","site_admin":false},"labels":[{"id":1037076588,"node_id":"MDU6TGFiZWwxMDM3MDc2NTg4","url":"https://api.github.com/repos/helm/charts/labels/Contribution%20Allowed","name":"Contribution Allowed","color":"3df47d","default":false},{"id":676475149,"node_id":"MDU6TGFiZWw2NzY0NzUxNDk=","url":"https://api.github.com/repos/helm/charts/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-27T18:18:07Z","updated_at":"2018-11-29T05:05:20Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/9581","html_url":"https://github.com/helm/charts/pull/9581","diff_url":"https://github.com/helm/charts/pull/9581.diff","patch_url":"https://github.com/helm/charts/pull/9581.patch"},"body":"Signed-off-by: Akshay Agrawal <aagrawal@zendesk.com>\r\n\r\n<!--\r\nThank you for contributing to helm/charts. Before you submit this PR we'd like to\r\nmake sure you are aware of our technical requirements and best practices:\r\n\r\n* https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements\r\n* https://github.com/helm/helm/tree/master/docs/chart_best_practices\r\n\r\nFor a quick overview across what we will look at reviewing your PR, please read\r\nour review guidelines:\r\n\r\n* https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md\r\n\r\nFollowing our best practices right from the start will accelerate the review process and\r\nhelp get your PR merged quicker.\r\n\r\nWhen updates to your PR are requested, please add new commits and do not squash the\r\nhistory. This will make it easier to identify new changes. The PR will be squashed\r\nanyways when it is merged. Thanks.\r\n\r\nFor fast feedback, please @-mention maintainers that are listed in the Chart.yaml file.\r\n\r\nPlease make sure you test your changes before you push them. Once pushed, a CircleCI\r\nwill run across your changes and do some initial checks and linting. These checks run\r\nvery quickly. Please check the results. We would like these checks to pass before we\r\neven continue reviewing your changes.\r\n-->\r\n\r\n#### What this PR does / why we need it:\r\nThis adds support for static IP's for Kafka External if type is \"LoadBalancer\". This can be used in cloud providers.\r\n\r\n#### Which issue this PR fixes\r\nN/A\r\n\r\n#### Special notes for your reviewer:\r\nWe are not making much changes here. Just adding support for static IP's in kafka external service.\r\n\r\n#### Checklist\r\n[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]\r\n- [x] [DCO](https://www.helm.sh/blog/helm-dco/index.html) signed\r\n- [x] Chart Version bumped\r\n- [x] Variables are documented in the README.md\r\n"},"comment":{"url":"https://api.github.com/repos/helm/charts/issues/comments/442707813","html_url":"https://github.com/helm/charts/pull/9581#issuecomment-442707813","issue_url":"https://api.github.com/repos/helm/charts/issues/9581","id":442707813,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjcwNzgxMw==","user":{"login":"benjigoldberg","id":6841489,"node_id":"MDQ6VXNlcjY4NDE0ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/6841489?v=4","gravatar_id":"","url":"https://api.github.com/users/benjigoldberg","html_url":"https://github.com/benjigoldberg","followers_url":"https://api.github.com/users/benjigoldberg/followers","following_url":"https://api.github.com/users/benjigoldberg/following{/other_user}","gists_url":"https://api.github.com/users/benjigoldberg/gists{/gist_id}","starred_url":"https://api.github.com/users/benjigoldberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjigoldberg/subscriptions","organizations_url":"https://api.github.com/users/benjigoldberg/orgs","repos_url":"https://api.github.com/users/benjigoldberg/repos","events_url":"https://api.github.com/users/benjigoldberg/events{/privacy}","received_events_url":"https://api.github.com/users/benjigoldberg/received_events","type":"User","site_admin":false},"created_at":"2018-11-29T05:05:20Z","updated_at":"2018-11-29T05:05:20Z","author_association":"COLLABORATOR","body":"/lgtm"}}
{"actor":{"display_login":"benjigoldberg"}}