{"action":"created","comment":{"url":"https://api.github.com/repos/leanprover/mathlib/pulls/comments/174634351","pull_request_review_id":104027318,"id":174634351,"diff_hunk":"@@ -55,9 +55,43 @@ Using simp in the middle of proofs is a simp anti-pattern, which will produce br\n \n Conversely, if you ever manage to close a goal with simp, then take a look at the line before you ran simp. Could you have run simp one line earlier? How far back did simp start working? Even for goals where you didn't use simp at all -- could you have used simp for your last line? What about the last-but one? And so on.\n \n+### Simp options.\n+\n+The behaviour of `simp` can be tweaked by simp variants and also by passing options to the algorithm. A good place to start is to look at the docstring for simp (write simp in VS Code and hover your mouse over it to see the docstring). Here are some examples, some of which are covered by the docstring and some of whichare not.\n+\n+1) `simp only [H1,H2,H3]` uses only lemmas `H1`, `H2`, and `H3` rather than `simp`s full collection of lemmas. Whyever might one want to do this in practice? Because sometimes simp simplifies things too much -- it might unfold things that you wanted to keep folded, for example. ","path":"docs/extras/simp.md","position":62,"original_position":8,"commit_id":"8ed8083af2a8f9b8be7724198be50d192fe904d5","original_commit_id":"8ed8083af2a8f9b8be7724198be50d192fe904d5","user":{"login":"digama0","id":868588,"avatar_url":"https://avatars3.githubusercontent.com/u/868588?v=4","gravatar_id":"","url":"https://api.github.com/users/digama0","html_url":"https://github.com/digama0","followers_url":"https://api.github.com/users/digama0/followers","following_url":"https://api.github.com/users/digama0/following{/other_user}","gists_url":"https://api.github.com/users/digama0/gists{/gist_id}","starred_url":"https://api.github.com/users/digama0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digama0/subscriptions","organizations_url":"https://api.github.com/users/digama0/orgs","repos_url":"https://api.github.com/users/digama0/repos","events_url":"https://api.github.com/users/digama0/events{/privacy}","received_events_url":"https://api.github.com/users/digama0/received_events","type":"User","site_admin":false},"body":"put spaces between `H1, H2, H3` (as subliminal style guide advice)","created_at":"2018-03-14T22:52:53Z","updated_at":"2018-03-14T23:00:59Z","html_url":"https://github.com/leanprover/mathlib/pull/82#discussion_r174634351","pull_request_url":"https://api.github.com/repos/leanprover/mathlib/pulls/82","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/leanprover/mathlib/pulls/comments/174634351"},"html":{"href":"https://github.com/leanprover/mathlib/pull/82#discussion_r174634351"},"pull_request":{"href":"https://api.github.com/repos/leanprover/mathlib/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/leanprover/mathlib/pulls/82","id":174248391,"html_url":"https://github.com/leanprover/mathlib/pull/82","diff_url":"https://github.com/leanprover/mathlib/pull/82.diff","patch_url":"https://github.com/leanprover/mathlib/pull/82.patch","issue_url":"https://api.github.com/repos/leanprover/mathlib/issues/82","number":82,"state":"open","locked":false,"title":"Docs simp notes","user":{"login":"kbuzzard","id":31867827,"avatar_url":"https://avatars3.githubusercontent.com/u/31867827?v=4","gravatar_id":"","url":"https://api.github.com/users/kbuzzard","html_url":"https://github.com/kbuzzard","followers_url":"https://api.github.com/users/kbuzzard/followers","following_url":"https://api.github.com/users/kbuzzard/following{/other_user}","gists_url":"https://api.github.com/users/kbuzzard/gists{/gist_id}","starred_url":"https://api.github.com/users/kbuzzard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbuzzard/subscriptions","organizations_url":"https://api.github.com/users/kbuzzard/orgs","repos_url":"https://api.github.com/users/kbuzzard/repos","events_url":"https://api.github.com/users/kbuzzard/events{/privacy}","received_events_url":"https://api.github.com/users/kbuzzard/received_events","type":"User","site_admin":false},"body":"[finally succeeded in adding only simp.md] \r\n\r\nI use these notes to remind myself what my favourite set_option simp options are.","created_at":"2018-03-11T23:12:28Z","updated_at":"2018-03-14T23:00:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06007fb0dcead56a4828a3b93c32ea1a340e69b3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/leanprover/mathlib/pulls/82/commits","review_comments_url":"https://api.github.com/repos/leanprover/mathlib/pulls/82/comments","review_comment_url":"https://api.github.com/repos/leanprover/mathlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/leanprover/mathlib/issues/82/comments","statuses_url":"https://api.github.com/repos/leanprover/mathlib/statuses/8ed8083af2a8f9b8be7724198be50d192fe904d5","head":{"label":"kbuzzard:docs-simp-notes","ref":"docs-simp-notes","sha":"8ed8083af2a8f9b8be7724198be50d192fe904d5","user":{"login":"kbuzzard","id":31867827,"avatar_url":"https://avatars3.githubusercontent.com/u/31867827?v=4","gravatar_id":"","url":"https://api.github.com/users/kbuzzard","html_url":"https://github.com/kbuzzard","followers_url":"https://api.github.com/users/kbuzzard/followers","following_url":"https://api.github.com/users/kbuzzard/following{/other_user}","gists_url":"https://api.github.com/users/kbuzzard/gists{/gist_id}","starred_url":"https://api.github.com/users/kbuzzard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbuzzard/subscriptions","organizations_url":"https://api.github.com/users/kbuzzard/orgs","repos_url":"https://api.github.com/users/kbuzzard/repos","events_url":"https://api.github.com/users/kbuzzard/events{/privacy}","received_events_url":"https://api.github.com/users/kbuzzard/received_events","type":"User","site_admin":false},"repo":{"id":110757758,"name":"mathlib","full_name":"kbuzzard/mathlib","owner":{"login":"kbuzzard","id":31867827,"avatar_url":"https://avatars3.githubusercontent.com/u/31867827?v=4","gravatar_id":"","url":"https://api.github.com/users/kbuzzard","html_url":"https://github.com/kbuzzard","followers_url":"https://api.github.com/users/kbuzzard/followers","following_url":"https://api.github.com/users/kbuzzard/following{/other_user}","gists_url":"https://api.github.com/users/kbuzzard/gists{/gist_id}","starred_url":"https://api.github.com/users/kbuzzard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbuzzard/subscriptions","organizations_url":"https://api.github.com/users/kbuzzard/orgs","repos_url":"https://api.github.com/users/kbuzzard/repos","events_url":"https://api.github.com/users/kbuzzard/events{/privacy}","received_events_url":"https://api.github.com/users/kbuzzard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kbuzzard/mathlib","description":"Lean mathematical components library","fork":true,"url":"https://api.github.com/repos/kbuzzard/mathlib","forks_url":"https://api.github.com/repos/kbuzzard/mathlib/forks","keys_url":"https://api.github.com/repos/kbuzzard/mathlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kbuzzard/mathlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kbuzzard/mathlib/teams","hooks_url":"https://api.github.com/repos/kbuzzard/mathlib/hooks","issue_events_url":"https://api.github.com/repos/kbuzzard/mathlib/issues/events{/number}","events_url":"https://api.github.com/repos/kbuzzard/mathlib/events","assignees_url":"https://api.github.com/repos/kbuzzard/mathlib/assignees{/user}","branches_url":"https://api.github.com/repos/kbuzzard/mathlib/branches{/branch}","tags_url":"https://api.github.com/repos/kbuzzard/mathlib/tags","blobs_url":"https://api.github.com/repos/kbuzzard/mathlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kbuzzard/mathlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kbuzzard/mathlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/kbuzzard/mathlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kbuzzard/mathlib/statuses/{sha}","languages_url":"https://api.github.com/repos/kbuzzard/mathlib/languages","stargazers_url":"https://api.github.com/repos/kbuzzard/mathlib/stargazers","contributors_url":"https://api.github.com/repos/kbuzzard/mathlib/contributors","subscribers_url":"https://api.github.com/repos/kbuzzard/mathlib/subscribers","subscription_url":"https://api.github.com/repos/kbuzzard/mathlib/subscription","commits_url":"https://api.github.com/repos/kbuzzard/mathlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/kbuzzard/mathlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/kbuzzard/mathlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/kbuzzard/mathlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/kbuzzard/mathlib/contents/{+path}","compare_url":"https://api.github.com/repos/kbuzzard/mathlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kbuzzard/mathlib/merges","archive_url":"https://api.github.com/repos/kbuzzard/mathlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kbuzzard/mathlib/downloads","issues_url":"https://api.github.com/repos/kbuzzard/mathlib/issues{/number}","pulls_url":"https://api.github.com/repos/kbuzzard/mathlib/pulls{/number}","milestones_url":"https://api.github.com/repos/kbuzzard/mathlib/milestones{/number}","notifications_url":"https://api.github.com/repos/kbuzzard/mathlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kbuzzard/mathlib/labels{/name}","releases_url":"https://api.github.com/repos/kbuzzard/mathlib/releases{/id}","deployments_url":"https://api.github.com/repos/kbuzzard/mathlib/deployments","created_at":"2017-11-14T23:40:18Z","updated_at":"2017-11-14T23:40:20Z","pushed_at":"2018-03-14T22:47:12Z","git_url":"git://github.com/kbuzzard/mathlib.git","ssh_url":"git@github.com:kbuzzard/mathlib.git","clone_url":"https://github.com/kbuzzard/mathlib.git","svn_url":"https://github.com/kbuzzard/mathlib","homepage":"","size":2195,"stargazers_count":0,"watchers_count":0,"language":"Lean","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"leanprover:master","ref":"master","sha":"64a8d564674608dc10539e97036767165d3fb51f","user":{"login":"leanprover","id":7233018,"avatar_url":"https://avatars3.githubusercontent.com/u/7233018?v=4","gravatar_id":"","url":"https://api.github.com/users/leanprover","html_url":"https://github.com/leanprover","followers_url":"https://api.github.com/users/leanprover/followers","following_url":"https://api.github.com/users/leanprover/following{/other_user}","gists_url":"https://api.github.com/users/leanprover/gists{/gist_id}","starred_url":"https://api.github.com/users/leanprover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leanprover/subscriptions","organizations_url":"https://api.github.com/users/leanprover/orgs","repos_url":"https://api.github.com/users/leanprover/repos","events_url":"https://api.github.com/users/leanprover/events{/privacy}","received_events_url":"https://api.github.com/users/leanprover/received_events","type":"Organization","site_admin":false},"repo":{"id":97922418,"name":"mathlib","full_name":"leanprover/mathlib","owner":{"login":"leanprover","id":7233018,"avatar_url":"https://avatars3.githubusercontent.com/u/7233018?v=4","gravatar_id":"","url":"https://api.github.com/users/leanprover","html_url":"https://github.com/leanprover","followers_url":"https://api.github.com/users/leanprover/followers","following_url":"https://api.github.com/users/leanprover/following{/other_user}","gists_url":"https://api.github.com/users/leanprover/gists{/gist_id}","starred_url":"https://api.github.com/users/leanprover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leanprover/subscriptions","organizations_url":"https://api.github.com/users/leanprover/orgs","repos_url":"https://api.github.com/users/leanprover/repos","events_url":"https://api.github.com/users/leanprover/events{/privacy}","received_events_url":"https://api.github.com/users/leanprover/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/leanprover/mathlib","description":"Lean mathematical components library","fork":false,"url":"https://api.github.com/repos/leanprover/mathlib","forks_url":"https://api.github.com/repos/leanprover/mathlib/forks","keys_url":"https://api.github.com/repos/leanprover/mathlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leanprover/mathlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leanprover/mathlib/teams","hooks_url":"https://api.github.com/repos/leanprover/mathlib/hooks","issue_events_url":"https://api.github.com/repos/leanprover/mathlib/issues/events{/number}","events_url":"https://api.github.com/repos/leanprover/mathlib/events","assignees_url":"https://api.github.com/repos/leanprover/mathlib/assignees{/user}","branches_url":"https://api.github.com/repos/leanprover/mathlib/branches{/branch}","tags_url":"https://api.github.com/repos/leanprover/mathlib/tags","blobs_url":"https://api.github.com/repos/leanprover/mathlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leanprover/mathlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leanprover/mathlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/leanprover/mathlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leanprover/mathlib/statuses/{sha}","languages_url":"https://api.github.com/repos/leanprover/mathlib/languages","stargazers_url":"https://api.github.com/repos/leanprover/mathlib/stargazers","contributors_url":"https://api.github.com/repos/leanprover/mathlib/contributors","subscribers_url":"https://api.github.com/repos/leanprover/mathlib/subscribers","subscription_url":"https://api.github.com/repos/leanprover/mathlib/subscription","commits_url":"https://api.github.com/repos/leanprover/mathlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/leanprover/mathlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/leanprover/mathlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/leanprover/mathlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/leanprover/mathlib/contents/{+path}","compare_url":"https://api.github.com/repos/leanprover/mathlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leanprover/mathlib/merges","archive_url":"https://api.github.com/repos/leanprover/mathlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leanprover/mathlib/downloads","issues_url":"https://api.github.com/repos/leanprover/mathlib/issues{/number}","pulls_url":"https://api.github.com/repos/leanprover/mathlib/pulls{/number}","milestones_url":"https://api.github.com/repos/leanprover/mathlib/milestones{/number}","notifications_url":"https://api.github.com/repos/leanprover/mathlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leanprover/mathlib/labels{/name}","releases_url":"https://api.github.com/repos/leanprover/mathlib/releases{/id}","deployments_url":"https://api.github.com/repos/leanprover/mathlib/deployments","created_at":"2017-07-21T08:02:10Z","updated_at":"2018-03-12T23:04:56Z","pushed_at":"2018-03-14T22:47:13Z","git_url":"git://github.com/leanprover/mathlib.git","ssh_url":"git@github.com:leanprover/mathlib.git","clone_url":"https://github.com/leanprover/mathlib.git","svn_url":"https://github.com/leanprover/mathlib","homepage":"","size":2164,"stargazers_count":20,"watchers_count":20,"language":"Lean","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":18,"open_issues":14,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/leanprover/mathlib/pulls/82"},"html":{"href":"https://github.com/leanprover/mathlib/pull/82"},"issue":{"href":"https://api.github.com/repos/leanprover/mathlib/issues/82"},"comments":{"href":"https://api.github.com/repos/leanprover/mathlib/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/leanprover/mathlib/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/leanprover/mathlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/leanprover/mathlib/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/leanprover/mathlib/statuses/8ed8083af2a8f9b8be7724198be50d192fe904d5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"digama0"}}