{"action":"closed","number":102,"pull_request":{"url":"https://api.github.com/repos/TestCentric/testcentric-gui/pulls/102","id":210969883,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTY5ODgz","html_url":"https://github.com/TestCentric/testcentric-gui/pull/102","diff_url":"https://github.com/TestCentric/testcentric-gui/pull/102.diff","patch_url":"https://github.com/TestCentric/testcentric-gui/pull/102.patch","issue_url":"https://api.github.com/repos/TestCentric/testcentric-gui/issues/102","number":102,"state":"closed","locked":false,"title":"Implement MVP for ErrorsAndFailuresView","user":{"login":"CharliePoole","id":2678661,"node_id":"MDQ6VXNlcjI2Nzg2NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/2678661?v=4","gravatar_id":"","url":"https://api.github.com/users/CharliePoole","html_url":"https://github.com/CharliePoole","followers_url":"https://api.github.com/users/CharliePoole/followers","following_url":"https://api.github.com/users/CharliePoole/following{/other_user}","gists_url":"https://api.github.com/users/CharliePoole/gists{/gist_id}","starred_url":"https://api.github.com/users/CharliePoole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CharliePoole/subscriptions","organizations_url":"https://api.github.com/users/CharliePoole/orgs","repos_url":"https://api.github.com/users/CharliePoole/repos","events_url":"https://api.github.com/users/CharliePoole/events{/privacy}","received_events_url":"https://api.github.com/users/CharliePoole/received_events","type":"User","site_admin":false},"body":"Part of issue #95. This PR deals with the ErrorsAndFailuresView.\r\n\r\nIn earlier PRs, I used a presenter-first approach, developing the interface and the presenter in parallel and only creating the view itself after I had a fully working presenter with all its tests passing.\r\n\r\nThis one is more complicated, for a few reasons:\r\n * The view originates events while others only responded to model events\r\n * The view contains three different relatively complex controls\r\n * This is the last of the three tab views so the ResultTabs control can be simultaneously simplified\r\n\r\nConsequently, I'm doing it bit by bit with some functionality remaining in the view control itself while other things are moved out to the presenter. IOW the architecture is hybrid for the time being.\r\n\r\n@mikkelbu @immeraufdemhund I'd like to develop this PR \"under review\" with each commit getting a review, provided one or both of you has the time.","created_at":"2018-08-26T20:43:00Z","updated_at":"2018-08-31T22:06:50Z","closed_at":"2018-08-31T22:06:50Z","merged_at":"2018-08-31T22:06:50Z","merge_commit_sha":"b1f671c1f35973573eada2745430b017b4fc0a94","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TestCentric/testcentric-gui/pulls/102/commits","review_comments_url":"https://api.github.com/repos/TestCentric/testcentric-gui/pulls/102/comments","review_comment_url":"https://api.github.com/repos/TestCentric/testcentric-gui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TestCentric/testcentric-gui/issues/102/comments","statuses_url":"https://api.github.com/repos/TestCentric/testcentric-gui/statuses/f68983451ac231ed02f4dd20d7f29e06dbd9a31d","head":{"label":"TestCentric:issue-95e","ref":"issue-95e","sha":"f68983451ac231ed02f4dd20d7f29e06dbd9a31d","user":{"login":"TestCentric","id":31354093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMzU0MDkz","avatar_url":"https://avatars2.githubusercontent.com/u/31354093?v=4","gravatar_id":"","url":"https://api.github.com/users/TestCentric","html_url":"https://github.com/TestCentric","followers_url":"https://api.github.com/users/TestCentric/followers","following_url":"https://api.github.com/users/TestCentric/following{/other_user}","gists_url":"https://api.github.com/users/TestCentric/gists{/gist_id}","starred_url":"https://api.github.com/users/TestCentric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TestCentric/subscriptions","organizations_url":"https://api.github.com/users/TestCentric/orgs","repos_url":"https://api.github.com/users/TestCentric/repos","events_url":"https://api.github.com/users/TestCentric/events{/privacy}","received_events_url":"https://api.github.com/users/TestCentric/received_events","type":"Organization","site_admin":false},"repo":{"id":124027822,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQwMjc4MjI=","name":"testcentric-gui","full_name":"TestCentric/testcentric-gui","owner":{"login":"TestCentric","id":31354093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMzU0MDkz","avatar_url":"https://avatars2.githubusercontent.com/u/31354093?v=4","gravatar_id":"","url":"https://api.github.com/users/TestCentric","html_url":"https://github.com/TestCentric","followers_url":"https://api.github.com/users/TestCentric/followers","following_url":"https://api.github.com/users/TestCentric/following{/other_user}","gists_url":"https://api.github.com/users/TestCentric/gists{/gist_id}","starred_url":"https://api.github.com/users/TestCentric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TestCentric/subscriptions","organizations_url":"https://api.github.com/users/TestCentric/orgs","repos_url":"https://api.github.com/users/TestCentric/repos","events_url":"https://api.github.com/users/TestCentric/events{/privacy}","received_events_url":"https://api.github.com/users/TestCentric/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TestCentric/testcentric-gui","description":"TestCentric GUI Runner for NUnit","fork":false,"url":"https://api.github.com/repos/TestCentric/testcentric-gui","forks_url":"https://api.github.com/repos/TestCentric/testcentric-gui/forks","keys_url":"https://api.github.com/repos/TestCentric/testcentric-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TestCentric/testcentric-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TestCentric/testcentric-gui/teams","hooks_url":"https://api.github.com/repos/TestCentric/testcentric-gui/hooks","issue_events_url":"https://api.github.com/repos/TestCentric/testcentric-gui/issues/events{/number}","events_url":"https://api.github.com/repos/TestCentric/testcentric-gui/events","assignees_url":"https://api.github.com/repos/TestCentric/testcentric-gui/assignees{/user}","branches_url":"https://api.github.com/repos/TestCentric/testcentric-gui/branches{/branch}","tags_url":"https://api.github.com/repos/TestCentric/testcentric-gui/tags","blobs_url":"https://api.github.com/repos/TestCentric/testcentric-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TestCentric/testcentric-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TestCentric/testcentric-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/TestCentric/testcentric-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TestCentric/testcentric-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/TestCentric/testcentric-gui/languages","stargazers_url":"https://api.github.com/repos/TestCentric/testcentric-gui/stargazers","contributors_url":"https://api.github.com/repos/TestCentric/testcentric-gui/contributors","subscribers_url":"https://api.github.com/repos/TestCentric/testcentric-gui/subscribers","subscription_url":"https://api.github.com/repos/TestCentric/testcentric-gui/subscription","commits_url":"https://api.github.com/repos/TestCentric/testcentric-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/TestCentric/testcentric-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/TestCentric/testcentric-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/TestCentric/testcentric-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/TestCentric/testcentric-gui/contents/{+path}","compare_url":"https://api.github.com/repos/TestCentric/testcentric-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TestCentric/testcentric-gui/merges","archive_url":"https://api.github.com/repos/TestCentric/testcentric-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TestCentric/testcentric-gui/downloads","issues_url":"https://api.github.com/repos/TestCentric/testcentric-gui/issues{/number}","pulls_url":"https://api.github.com/repos/TestCentric/testcentric-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/TestCentric/testcentric-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/TestCentric/testcentric-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TestCentric/testcentric-gui/labels{/name}","releases_url":"https://api.github.com/repos/TestCentric/testcentric-gui/releases{/id}","deployments_url":"https://api.github.com/repos/TestCentric/testcentric-gui/deployments","created_at":"2018-03-06T05:50:48Z","updated_at":"2018-08-27T06:45:54Z","pushed_at":"2018-08-31T22:06:50Z","git_url":"git://github.com/TestCentric/testcentric-gui.git","ssh_url":"git@github.com:TestCentric/testcentric-gui.git","clone_url":"https://github.com/TestCentric/testcentric-gui.git","svn_url":"https://github.com/TestCentric/testcentric-gui","homepage":"","size":881,"stargazers_count":5,"watchers_count":5,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":19,"watchers":5,"default_branch":"master"}},"base":{"label":"TestCentric:master","ref":"master","sha":"a02c1029c97cd1d64ba7a1efcfdc0ead97d1a3a8","user":{"login":"TestCentric","id":31354093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMzU0MDkz","avatar_url":"https://avatars2.githubusercontent.com/u/31354093?v=4","gravatar_id":"","url":"https://api.github.com/users/TestCentric","html_url":"https://github.com/TestCentric","followers_url":"https://api.github.com/users/TestCentric/followers","following_url":"https://api.github.com/users/TestCentric/following{/other_user}","gists_url":"https://api.github.com/users/TestCentric/gists{/gist_id}","starred_url":"https://api.github.com/users/TestCentric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TestCentric/subscriptions","organizations_url":"https://api.github.com/users/TestCentric/orgs","repos_url":"https://api.github.com/users/TestCentric/repos","events_url":"https://api.github.com/users/TestCentric/events{/privacy}","received_events_url":"https://api.github.com/users/TestCentric/received_events","type":"Organization","site_admin":false},"repo":{"id":124027822,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQwMjc4MjI=","name":"testcentric-gui","full_name":"TestCentric/testcentric-gui","owner":{"login":"TestCentric","id":31354093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMzU0MDkz","avatar_url":"https://avatars2.githubusercontent.com/u/31354093?v=4","gravatar_id":"","url":"https://api.github.com/users/TestCentric","html_url":"https://github.com/TestCentric","followers_url":"https://api.github.com/users/TestCentric/followers","following_url":"https://api.github.com/users/TestCentric/following{/other_user}","gists_url":"https://api.github.com/users/TestCentric/gists{/gist_id}","starred_url":"https://api.github.com/users/TestCentric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TestCentric/subscriptions","organizations_url":"https://api.github.com/users/TestCentric/orgs","repos_url":"https://api.github.com/users/TestCentric/repos","events_url":"https://api.github.com/users/TestCentric/events{/privacy}","received_events_url":"https://api.github.com/users/TestCentric/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TestCentric/testcentric-gui","description":"TestCentric GUI Runner for NUnit","fork":false,"url":"https://api.github.com/repos/TestCentric/testcentric-gui","forks_url":"https://api.github.com/repos/TestCentric/testcentric-gui/forks","keys_url":"https://api.github.com/repos/TestCentric/testcentric-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TestCentric/testcentric-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TestCentric/testcentric-gui/teams","hooks_url":"https://api.github.com/repos/TestCentric/testcentric-gui/hooks","issue_events_url":"https://api.github.com/repos/TestCentric/testcentric-gui/issues/events{/number}","events_url":"https://api.github.com/repos/TestCentric/testcentric-gui/events","assignees_url":"https://api.github.com/repos/TestCentric/testcentric-gui/assignees{/user}","branches_url":"https://api.github.com/repos/TestCentric/testcentric-gui/branches{/branch}","tags_url":"https://api.github.com/repos/TestCentric/testcentric-gui/tags","blobs_url":"https://api.github.com/repos/TestCentric/testcentric-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TestCentric/testcentric-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TestCentric/testcentric-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/TestCentric/testcentric-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TestCentric/testcentric-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/TestCentric/testcentric-gui/languages","stargazers_url":"https://api.github.com/repos/TestCentric/testcentric-gui/stargazers","contributors_url":"https://api.github.com/repos/TestCentric/testcentric-gui/contributors","subscribers_url":"https://api.github.com/repos/TestCentric/testcentric-gui/subscribers","subscription_url":"https://api.github.com/repos/TestCentric/testcentric-gui/subscription","commits_url":"https://api.github.com/repos/TestCentric/testcentric-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/TestCentric/testcentric-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/TestCentric/testcentric-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/TestCentric/testcentric-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/TestCentric/testcentric-gui/contents/{+path}","compare_url":"https://api.github.com/repos/TestCentric/testcentric-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TestCentric/testcentric-gui/merges","archive_url":"https://api.github.com/repos/TestCentric/testcentric-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TestCentric/testcentric-gui/downloads","issues_url":"https://api.github.com/repos/TestCentric/testcentric-gui/issues{/number}","pulls_url":"https://api.github.com/repos/TestCentric/testcentric-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/TestCentric/testcentric-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/TestCentric/testcentric-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TestCentric/testcentric-gui/labels{/name}","releases_url":"https://api.github.com/repos/TestCentric/testcentric-gui/releases{/id}","deployments_url":"https://api.github.com/repos/TestCentric/testcentric-gui/deployments","created_at":"2018-03-06T05:50:48Z","updated_at":"2018-08-27T06:45:54Z","pushed_at":"2018-08-31T22:06:50Z","git_url":"git://github.com/TestCentric/testcentric-gui.git","ssh_url":"git@github.com:TestCentric/testcentric-gui.git","clone_url":"https://github.com/TestCentric/testcentric-gui.git","svn_url":"https://github.com/TestCentric/testcentric-gui","homepage":"","size":881,"stargazers_count":5,"watchers_count":5,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":19,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TestCentric/testcentric-gui/pulls/102"},"html":{"href":"https://github.com/TestCentric/testcentric-gui/pull/102"},"issue":{"href":"https://api.github.com/repos/TestCentric/testcentric-gui/issues/102"},"comments":{"href":"https://api.github.com/repos/TestCentric/testcentric-gui/issues/102/comments"},"review_comments":{"href":"https://api.github.com/repos/TestCentric/testcentric-gui/pulls/102/comments"},"review_comment":{"href":"https://api.github.com/repos/TestCentric/testcentric-gui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TestCentric/testcentric-gui/pulls/102/commits"},"statuses":{"href":"https://api.github.com/repos/TestCentric/testcentric-gui/statuses/f68983451ac231ed02f4dd20d7f29e06dbd9a31d"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"CharliePoole","id":2678661,"node_id":"MDQ6VXNlcjI2Nzg2NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/2678661?v=4","gravatar_id":"","url":"https://api.github.com/users/CharliePoole","html_url":"https://github.com/CharliePoole","followers_url":"https://api.github.com/users/CharliePoole/followers","following_url":"https://api.github.com/users/CharliePoole/following{/other_user}","gists_url":"https://api.github.com/users/CharliePoole/gists{/gist_id}","starred_url":"https://api.github.com/users/CharliePoole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CharliePoole/subscriptions","organizations_url":"https://api.github.com/users/CharliePoole/orgs","repos_url":"https://api.github.com/users/CharliePoole/repos","events_url":"https://api.github.com/users/CharliePoole/events{/privacy}","received_events_url":"https://api.github.com/users/CharliePoole/received_events","type":"User","site_admin":false},"comments":7,"review_comments":8,"maintainer_can_modify":false,"commits":4,"additions":790,"deletions":639,"changed_files":24}}
{"actor":{"display_login":"CharliePoole"}}