{"action":"created","comment":{"url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/comments/171619493","pull_request_review_id":100504633,"id":171619493,"diff_hunk":"@@ -573,14 +576,31 @@ protected override string GenerateCommandLineCommands ()\n \t\t\t\targs.AddQuoted (gcc.Arguments.ToString ());\n \t\t\t}\n \n-\t\t\tforeach (var asm in References) {\n-\t\t\t\tif (IsFrameworkItem(asm)) {\n-\t\t\t\t\targs.AddQuoted (\"-r=\" + ResolveFrameworkFile(asm.ItemSpec));\n-\t\t\t\t} else {\n-\t\t\t\t\targs.AddQuoted (\"-r=\" + Path.GetFullPath (asm.ItemSpec));\n+\t\t\t// Generate a response file\n+\t\t\tvar responseFile = Path.GetFullPath (ResponseFilePath);\n+\n+\t\t\tif (File.Exists (responseFile))\n+\t\t\t\tFile.Delete (responseFile);\n+\n+\t\t\ttry {\n+\t\t\t\tusing (var fs = File.Create (responseFile)) {\n+\t\t\t\t\tusing (var writer = new StreamWriter (fs)) {\n+\t\t\t\t\t\tforeach (var asm in References) {\n+\t\t\t\t\t\t\tif (IsFrameworkItem (asm)) {\n+\t\t\t\t\t\t\t\twriter.Write (\" -r=\" + ResolveFrameworkFile (asm.ItemSpec));","path":"msbuild/Xamarin.iOS.Tasks.Core/Tasks/MTouchTaskBase.cs","position":30,"original_position":30,"commit_id":"2001a593a25b7f13320e3d0e1cd0f6815b818531","original_commit_id":"2001a593a25b7f13320e3d0e1cd0f6815b818531","user":{"login":"rolfbjarne","id":249268,"avatar_url":"https://avatars0.githubusercontent.com/u/249268?v=4","gravatar_id":"","url":"https://api.github.com/users/rolfbjarne","html_url":"https://github.com/rolfbjarne","followers_url":"https://api.github.com/users/rolfbjarne/followers","following_url":"https://api.github.com/users/rolfbjarne/following{/other_user}","gists_url":"https://api.github.com/users/rolfbjarne/gists{/gist_id}","starred_url":"https://api.github.com/users/rolfbjarne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolfbjarne/subscriptions","organizations_url":"https://api.github.com/users/rolfbjarne/orgs","repos_url":"https://api.github.com/users/rolfbjarne/repos","events_url":"https://api.github.com/users/rolfbjarne/events{/privacy}","received_events_url":"https://api.github.com/users/rolfbjarne/received_events","type":"User","site_admin":false},"body":"Yes, a reference with spaces in its path.","created_at":"2018-03-01T16:43:12Z","updated_at":"2018-03-01T16:43:13Z","html_url":"https://github.com/xamarin/xamarin-macios/pull/3635#discussion_r171619493","pull_request_url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/3635","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/comments/171619493"},"html":{"href":"https://github.com/xamarin/xamarin-macios/pull/3635#discussion_r171619493"},"pull_request":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/3635"}},"in_reply_to_id":171617029},"pull_request":{"url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/3635","id":172286433,"html_url":"https://github.com/xamarin/xamarin-macios/pull/3635","diff_url":"https://github.com/xamarin/xamarin-macios/pull/3635.diff","patch_url":"https://github.com/xamarin/xamarin-macios/pull/3635.patch","issue_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/3635","number":3635,"state":"open","locked":false,"title":"[msbuild] Use a response file for references in MTouchTaskBase","user":{"login":"VincentDondain","id":7839202,"avatar_url":"https://avatars3.githubusercontent.com/u/7839202?v=4","gravatar_id":"","url":"https://api.github.com/users/VincentDondain","html_url":"https://github.com/VincentDondain","followers_url":"https://api.github.com/users/VincentDondain/followers","following_url":"https://api.github.com/users/VincentDondain/following{/other_user}","gists_url":"https://api.github.com/users/VincentDondain/gists{/gist_id}","starred_url":"https://api.github.com/users/VincentDondain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VincentDondain/subscriptions","organizations_url":"https://api.github.com/users/VincentDondain/orgs","repos_url":"https://api.github.com/users/VincentDondain/repos","events_url":"https://api.github.com/users/VincentDondain/events{/privacy}","received_events_url":"https://api.github.com/users/VincentDondain/received_events","type":"User","site_admin":false},"body":"The cause of the warning: \"warning MSB6002: The command-line for the 'MTouch' task is too long\"\nwas the number of references that can be passed to `mtouch`. Now all those references (-r) are written in\na response file which in turn is passed to mtouch.\n\n- Fixes bug #56501: MSB6002 command-line for MTouch task is too long, > 32000 characters\n(https://bugzilla.xamarin.com/show_bug.cgi?id=56501)\n- The response file is created in the device sepcific folder, as `response-file.rsp`. It is re-created every time.\n- Added msbuild test to ensure the response file is created by `GenerateCommandLineCommands` and that\n  it includes all the references.","created_at":"2018-03-01T16:28:50Z","updated_at":"2018-03-01T16:43:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60f218293b04a31bb937c989bd8f55d7c2b69e20","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kzu","id":169707,"avatar_url":"https://avatars2.githubusercontent.com/u/169707?v=4","gravatar_id":"","url":"https://api.github.com/users/kzu","html_url":"https://github.com/kzu","followers_url":"https://api.github.com/users/kzu/followers","following_url":"https://api.github.com/users/kzu/following{/other_user}","gists_url":"https://api.github.com/users/kzu/gists{/gist_id}","starred_url":"https://api.github.com/users/kzu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kzu/subscriptions","organizations_url":"https://api.github.com/users/kzu/orgs","repos_url":"https://api.github.com/users/kzu/repos","events_url":"https://api.github.com/users/kzu/events{/privacy}","received_events_url":"https://api.github.com/users/kzu/received_events","type":"User","site_admin":false},{"login":"jstedfast","id":338984,"avatar_url":"https://avatars2.githubusercontent.com/u/338984?v=4","gravatar_id":"","url":"https://api.github.com/users/jstedfast","html_url":"https://github.com/jstedfast","followers_url":"https://api.github.com/users/jstedfast/followers","following_url":"https://api.github.com/users/jstedfast/following{/other_user}","gists_url":"https://api.github.com/users/jstedfast/gists{/gist_id}","starred_url":"https://api.github.com/users/jstedfast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jstedfast/subscriptions","organizations_url":"https://api.github.com/users/jstedfast/orgs","repos_url":"https://api.github.com/users/jstedfast/repos","events_url":"https://api.github.com/users/jstedfast/events{/privacy}","received_events_url":"https://api.github.com/users/jstedfast/received_events","type":"User","site_admin":false},{"login":"emaf","id":3286258,"avatar_url":"https://avatars3.githubusercontent.com/u/3286258?v=4","gravatar_id":"","url":"https://api.github.com/users/emaf","html_url":"https://github.com/emaf","followers_url":"https://api.github.com/users/emaf/followers","following_url":"https://api.github.com/users/emaf/following{/other_user}","gists_url":"https://api.github.com/users/emaf/gists{/gist_id}","starred_url":"https://api.github.com/users/emaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emaf/subscriptions","organizations_url":"https://api.github.com/users/emaf/orgs","repos_url":"https://api.github.com/users/emaf/repos","events_url":"https://api.github.com/users/emaf/events{/privacy}","received_events_url":"https://api.github.com/users/emaf/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":483439566,"url":"https://api.github.com/repos/xamarin/xamarin-macios/labels/run-all-tests","name":"run-all-tests","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/3635/commits","review_comments_url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/3635/comments","review_comment_url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/3635/comments","statuses_url":"https://api.github.com/repos/xamarin/xamarin-macios/statuses/2001a593a25b7f13320e3d0e1cd0f6815b818531","head":{"label":"VincentDondain:msbuild-response-file","ref":"msbuild-response-file","sha":"2001a593a25b7f13320e3d0e1cd0f6815b818531","user":{"login":"VincentDondain","id":7839202,"avatar_url":"https://avatars3.githubusercontent.com/u/7839202?v=4","gravatar_id":"","url":"https://api.github.com/users/VincentDondain","html_url":"https://github.com/VincentDondain","followers_url":"https://api.github.com/users/VincentDondain/followers","following_url":"https://api.github.com/users/VincentDondain/following{/other_user}","gists_url":"https://api.github.com/users/VincentDondain/gists{/gist_id}","starred_url":"https://api.github.com/users/VincentDondain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VincentDondain/subscriptions","organizations_url":"https://api.github.com/users/VincentDondain/orgs","repos_url":"https://api.github.com/users/VincentDondain/repos","events_url":"https://api.github.com/users/VincentDondain/events{/privacy}","received_events_url":"https://api.github.com/users/VincentDondain/received_events","type":"User","site_admin":false},"repo":{"id":57224502,"name":"xamarin-macios","full_name":"VincentDondain/xamarin-macios","owner":{"login":"VincentDondain","id":7839202,"avatar_url":"https://avatars3.githubusercontent.com/u/7839202?v=4","gravatar_id":"","url":"https://api.github.com/users/VincentDondain","html_url":"https://github.com/VincentDondain","followers_url":"https://api.github.com/users/VincentDondain/followers","following_url":"https://api.github.com/users/VincentDondain/following{/other_user}","gists_url":"https://api.github.com/users/VincentDondain/gists{/gist_id}","starred_url":"https://api.github.com/users/VincentDondain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VincentDondain/subscriptions","organizations_url":"https://api.github.com/users/VincentDondain/orgs","repos_url":"https://api.github.com/users/VincentDondain/repos","events_url":"https://api.github.com/users/VincentDondain/events{/privacy}","received_events_url":"https://api.github.com/users/VincentDondain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VincentDondain/xamarin-macios","description":"Bridges the worlds of .NET with the native APIs of Mac, iOS, tvOS, and watchOS.","fork":true,"url":"https://api.github.com/repos/VincentDondain/xamarin-macios","forks_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/forks","keys_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/teams","hooks_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/hooks","issue_events_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/issues/events{/number}","events_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/events","assignees_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/assignees{/user}","branches_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/branches{/branch}","tags_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/tags","blobs_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/git/refs{/sha}","trees_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/statuses/{sha}","languages_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/languages","stargazers_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/stargazers","contributors_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/contributors","subscribers_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/subscribers","subscription_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/subscription","commits_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/commits{/sha}","git_commits_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/git/commits{/sha}","comments_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/comments{/number}","issue_comment_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/issues/comments{/number}","contents_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/contents/{+path}","compare_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/merges","archive_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/downloads","issues_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/issues{/number}","pulls_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/pulls{/number}","milestones_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/milestones{/number}","notifications_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/labels{/name}","releases_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/releases{/id}","deployments_url":"https://api.github.com/repos/VincentDondain/xamarin-macios/deployments","created_at":"2016-04-27T15:28:35Z","updated_at":"2016-04-27T15:28:41Z","pushed_at":"2018-03-01T16:24:14Z","git_url":"git://github.com/VincentDondain/xamarin-macios.git","ssh_url":"git@github.com:VincentDondain/xamarin-macios.git","clone_url":"https://github.com/VincentDondain/xamarin-macios.git","svn_url":"https://github.com/VincentDondain/xamarin-macios","homepage":null,"size":71187,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xamarin:master","ref":"master","sha":"6c1bdea37591cad8c01a58cfec3b5f80cc1e0074","user":{"login":"xamarin","id":790012,"avatar_url":"https://avatars0.githubusercontent.com/u/790012?v=4","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"repo":{"id":56710511,"name":"xamarin-macios","full_name":"xamarin/xamarin-macios","owner":{"login":"xamarin","id":790012,"avatar_url":"https://avatars0.githubusercontent.com/u/790012?v=4","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xamarin/xamarin-macios","description":"Bridges the worlds of .NET with the native APIs of Mac, iOS, tvOS, and watchOS.","fork":false,"url":"https://api.github.com/repos/xamarin/xamarin-macios","forks_url":"https://api.github.com/repos/xamarin/xamarin-macios/forks","keys_url":"https://api.github.com/repos/xamarin/xamarin-macios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xamarin/xamarin-macios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xamarin/xamarin-macios/teams","hooks_url":"https://api.github.com/repos/xamarin/xamarin-macios/hooks","issue_events_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/events{/number}","events_url":"https://api.github.com/repos/xamarin/xamarin-macios/events","assignees_url":"https://api.github.com/repos/xamarin/xamarin-macios/assignees{/user}","branches_url":"https://api.github.com/repos/xamarin/xamarin-macios/branches{/branch}","tags_url":"https://api.github.com/repos/xamarin/xamarin-macios/tags","blobs_url":"https://api.github.com/repos/xamarin/xamarin-macios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xamarin/xamarin-macios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xamarin/xamarin-macios/git/refs{/sha}","trees_url":"https://api.github.com/repos/xamarin/xamarin-macios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xamarin/xamarin-macios/statuses/{sha}","languages_url":"https://api.github.com/repos/xamarin/xamarin-macios/languages","stargazers_url":"https://api.github.com/repos/xamarin/xamarin-macios/stargazers","contributors_url":"https://api.github.com/repos/xamarin/xamarin-macios/contributors","subscribers_url":"https://api.github.com/repos/xamarin/xamarin-macios/subscribers","subscription_url":"https://api.github.com/repos/xamarin/xamarin-macios/subscription","commits_url":"https://api.github.com/repos/xamarin/xamarin-macios/commits{/sha}","git_commits_url":"https://api.github.com/repos/xamarin/xamarin-macios/git/commits{/sha}","comments_url":"https://api.github.com/repos/xamarin/xamarin-macios/comments{/number}","issue_comment_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/comments{/number}","contents_url":"https://api.github.com/repos/xamarin/xamarin-macios/contents/{+path}","compare_url":"https://api.github.com/repos/xamarin/xamarin-macios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xamarin/xamarin-macios/merges","archive_url":"https://api.github.com/repos/xamarin/xamarin-macios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xamarin/xamarin-macios/downloads","issues_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues{/number}","pulls_url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls{/number}","milestones_url":"https://api.github.com/repos/xamarin/xamarin-macios/milestones{/number}","notifications_url":"https://api.github.com/repos/xamarin/xamarin-macios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xamarin/xamarin-macios/labels{/name}","releases_url":"https://api.github.com/repos/xamarin/xamarin-macios/releases{/id}","deployments_url":"https://api.github.com/repos/xamarin/xamarin-macios/deployments","created_at":"2016-04-20T18:24:26Z","updated_at":"2018-03-01T16:21:47Z","pushed_at":"2018-03-01T16:42:15Z","git_url":"git://github.com/xamarin/xamarin-macios.git","ssh_url":"git@github.com:xamarin/xamarin-macios.git","clone_url":"https://github.com/xamarin/xamarin-macios.git","svn_url":"https://github.com/xamarin/xamarin-macios","homepage":null,"size":75717,"stargazers_count":831,"watchers_count":831,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":188,"mirror_url":null,"archived":false,"open_issues_count":82,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":188,"open_issues":82,"watchers":831,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/3635"},"html":{"href":"https://github.com/xamarin/xamarin-macios/pull/3635"},"issue":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/issues/3635"},"comments":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/issues/3635/comments"},"review_comments":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/3635/comments"},"review_comment":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/3635/commits"},"statuses":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/statuses/2001a593a25b7f13320e3d0e1cd0f6815b818531"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rolfbjarne"}}