{"action":"closed","number":5254,"pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/5254","id":167012801,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY3MDEyODAx","html_url":"https://github.com/openssl/openssl/pull/5254","diff_url":"https://github.com/openssl/openssl/pull/5254.diff","patch_url":"https://github.com/openssl/openssl/pull/5254.patch","issue_url":"https://api.github.com/repos/openssl/openssl/issues/5254","number":5254,"state":"closed","locked":false,"title":"rsa/*: switch to BN_bn2binpad","user":{"login":"dot-asm","id":9038069,"node_id":"MDQ6VXNlcjkwMzgwNjk=","avatar_url":"https://avatars2.githubusercontent.com/u/9038069?v=4","gravatar_id":"","url":"https://api.github.com/users/dot-asm","html_url":"https://github.com/dot-asm","followers_url":"https://api.github.com/users/dot-asm/followers","following_url":"https://api.github.com/users/dot-asm/following{/other_user}","gists_url":"https://api.github.com/users/dot-asm/gists{/gist_id}","starred_url":"https://api.github.com/users/dot-asm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dot-asm/subscriptions","organizations_url":"https://api.github.com/users/dot-asm/orgs","repos_url":"https://api.github.com/users/dot-asm/repos","events_url":"https://api.github.com/users/dot-asm/events{/privacy}","received_events_url":"https://api.github.com/users/dot-asm/received_events","type":"User","site_admin":false},"body":"Labels mean rather intention to back-port this down to 1.0.2 than actual cherry-pick-ability. Open question is if one should make RSA_padding_check_SSLv23 and RSA_padding_check_X931 constant-time. They are not actually called. Not during `make test`. On related note one can even wonder if any of *_padding_check functions should be exported...","created_at":"2018-02-04T14:38:18Z","updated_at":"2018-07-14T11:43:06Z","closed_at":"2018-07-14T11:43:06Z","merged_at":null,"merge_commit_sha":"ba9d5937e3444e97fcf0cf5fe87bc0157d91e838","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":441165257,"node_id":"MDU6TGFiZWw0NDExNjUyNTc=","url":"https://api.github.com/repos/openssl/openssl/labels/1.0.2","name":"1.0.2","color":"bfdadc","default":false},{"id":441165399,"node_id":"MDU6TGFiZWw0NDExNjUzOTk=","url":"https://api.github.com/repos/openssl/openssl/labels/1.1.0","name":"1.1.0","color":"bfdadc","default":false},{"id":441165144,"node_id":"MDU6TGFiZWw0NDExNjUxNDQ=","url":"https://api.github.com/repos/openssl/openssl/labels/master","name":"master","color":"bfdadc","default":false},{"id":314766253,"node_id":"MDU6TGFiZWwzMTQ3NjYyNTM=","url":"https://api.github.com/repos/openssl/openssl/labels/ready","name":"ready","color":"009800","default":false}],"milestone":{"url":"https://api.github.com/repos/openssl/openssl/milestones/12","html_url":"https://github.com/openssl/openssl/milestone/12","labels_url":"https://api.github.com/repos/openssl/openssl/milestones/12/labels","id":3045922,"node_id":"MDk6TWlsZXN0b25lMzA0NTkyMg==","number":12,"title":"Assessed","description":"","creator":{"login":"mattcaswell","id":7422273,"node_id":"MDQ6VXNlcjc0MjIyNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/7422273?v=4","gravatar_id":"","url":"https://api.github.com/users/mattcaswell","html_url":"https://github.com/mattcaswell","followers_url":"https://api.github.com/users/mattcaswell/followers","following_url":"https://api.github.com/users/mattcaswell/following{/other_user}","gists_url":"https://api.github.com/users/mattcaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/mattcaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattcaswell/subscriptions","organizations_url":"https://api.github.com/users/mattcaswell/orgs","repos_url":"https://api.github.com/users/mattcaswell/repos","events_url":"https://api.github.com/users/mattcaswell/events{/privacy}","received_events_url":"https://api.github.com/users/mattcaswell/received_events","type":"User","site_admin":false},"open_issues":180,"closed_issues":22,"state":"open","created_at":"2018-01-18T16:36:46Z","updated_at":"2018-07-14T11:43:06Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/openssl/openssl/pulls/5254/commits","review_comments_url":"https://api.github.com/repos/openssl/openssl/pulls/5254/comments","review_comment_url":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/5254/comments","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/c194c602d238082c35449d2bd49e1cee08078d1d","head":{"label":"dot-asm:rsa_bn2binpad","ref":"rsa_bn2binpad","sha":"c194c602d238082c35449d2bd49e1cee08078d1d","user":{"login":"dot-asm","id":9038069,"node_id":"MDQ6VXNlcjkwMzgwNjk=","avatar_url":"https://avatars2.githubusercontent.com/u/9038069?v=4","gravatar_id":"","url":"https://api.github.com/users/dot-asm","html_url":"https://github.com/dot-asm","followers_url":"https://api.github.com/users/dot-asm/followers","following_url":"https://api.github.com/users/dot-asm/following{/other_user}","gists_url":"https://api.github.com/users/dot-asm/gists{/gist_id}","starred_url":"https://api.github.com/users/dot-asm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dot-asm/subscriptions","organizations_url":"https://api.github.com/users/dot-asm/orgs","repos_url":"https://api.github.com/users/dot-asm/repos","events_url":"https://api.github.com/users/dot-asm/events{/privacy}","received_events_url":"https://api.github.com/users/dot-asm/received_events","type":"User","site_admin":false},"repo":{"id":58874005,"node_id":"MDEwOlJlcG9zaXRvcnk1ODg3NDAwNQ==","name":"openssl","full_name":"dot-asm/openssl","owner":{"login":"dot-asm","id":9038069,"node_id":"MDQ6VXNlcjkwMzgwNjk=","avatar_url":"https://avatars2.githubusercontent.com/u/9038069?v=4","gravatar_id":"","url":"https://api.github.com/users/dot-asm","html_url":"https://github.com/dot-asm","followers_url":"https://api.github.com/users/dot-asm/followers","following_url":"https://api.github.com/users/dot-asm/following{/other_user}","gists_url":"https://api.github.com/users/dot-asm/gists{/gist_id}","starred_url":"https://api.github.com/users/dot-asm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dot-asm/subscriptions","organizations_url":"https://api.github.com/users/dot-asm/orgs","repos_url":"https://api.github.com/users/dot-asm/repos","events_url":"https://api.github.com/users/dot-asm/events{/privacy}","received_events_url":"https://api.github.com/users/dot-asm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dot-asm/openssl","description":"TLS/SSL and crypto library","fork":true,"url":"https://api.github.com/repos/dot-asm/openssl","forks_url":"https://api.github.com/repos/dot-asm/openssl/forks","keys_url":"https://api.github.com/repos/dot-asm/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dot-asm/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dot-asm/openssl/teams","hooks_url":"https://api.github.com/repos/dot-asm/openssl/hooks","issue_events_url":"https://api.github.com/repos/dot-asm/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/dot-asm/openssl/events","assignees_url":"https://api.github.com/repos/dot-asm/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/dot-asm/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/dot-asm/openssl/tags","blobs_url":"https://api.github.com/repos/dot-asm/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dot-asm/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dot-asm/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/dot-asm/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dot-asm/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/dot-asm/openssl/languages","stargazers_url":"https://api.github.com/repos/dot-asm/openssl/stargazers","contributors_url":"https://api.github.com/repos/dot-asm/openssl/contributors","subscribers_url":"https://api.github.com/repos/dot-asm/openssl/subscribers","subscription_url":"https://api.github.com/repos/dot-asm/openssl/subscription","commits_url":"https://api.github.com/repos/dot-asm/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/dot-asm/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/dot-asm/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/dot-asm/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/dot-asm/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/dot-asm/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dot-asm/openssl/merges","archive_url":"https://api.github.com/repos/dot-asm/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dot-asm/openssl/downloads","issues_url":"https://api.github.com/repos/dot-asm/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/dot-asm/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/dot-asm/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/dot-asm/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dot-asm/openssl/labels{/name}","releases_url":"https://api.github.com/repos/dot-asm/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/dot-asm/openssl/deployments","created_at":"2016-05-15T17:10:40Z","updated_at":"2018-07-14T11:39:47Z","pushed_at":"2018-07-14T11:39:44Z","git_url":"git://github.com/dot-asm/openssl.git","ssh_url":"git@github.com:dot-asm/openssl.git","clone_url":"https://github.com/dot-asm/openssl.git","svn_url":"https://github.com/dot-asm/openssl","homepage":"https://www.openssl.org","size":150594,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"openssl:master","ref":"master","sha":"1f4add418d3ef07da80be87bc4e696197c84468f","user":{"login":"openssl","id":3279138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzkxMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3279138?v=4","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"repo":{"id":7634677,"node_id":"MDEwOlJlcG9zaXRvcnk3NjM0Njc3","name":"openssl","full_name":"openssl/openssl","owner":{"login":"openssl","id":3279138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzkxMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3279138?v=4","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openssl/openssl","description":"TLS/SSL and crypto library","fork":false,"url":"https://api.github.com/repos/openssl/openssl","forks_url":"https://api.github.com/repos/openssl/openssl/forks","keys_url":"https://api.github.com/repos/openssl/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openssl/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openssl/openssl/teams","hooks_url":"https://api.github.com/repos/openssl/openssl/hooks","issue_events_url":"https://api.github.com/repos/openssl/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/openssl/openssl/events","assignees_url":"https://api.github.com/repos/openssl/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/openssl/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/openssl/openssl/tags","blobs_url":"https://api.github.com/repos/openssl/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openssl/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openssl/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/openssl/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/openssl/openssl/languages","stargazers_url":"https://api.github.com/repos/openssl/openssl/stargazers","contributors_url":"https://api.github.com/repos/openssl/openssl/contributors","subscribers_url":"https://api.github.com/repos/openssl/openssl/subscribers","subscription_url":"https://api.github.com/repos/openssl/openssl/subscription","commits_url":"https://api.github.com/repos/openssl/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/openssl/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/openssl/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/openssl/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/openssl/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/openssl/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openssl/openssl/merges","archive_url":"https://api.github.com/repos/openssl/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openssl/openssl/downloads","issues_url":"https://api.github.com/repos/openssl/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/openssl/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/openssl/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/openssl/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openssl/openssl/labels{/name}","releases_url":"https://api.github.com/repos/openssl/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/openssl/openssl/deployments","created_at":"2013-01-15T22:34:48Z","updated_at":"2018-07-14T11:39:46Z","pushed_at":"2018-07-14T11:41:07Z","git_url":"git://github.com/openssl/openssl.git","ssh_url":"git@github.com:openssl/openssl.git","clone_url":"https://github.com/openssl/openssl.git","svn_url":"https://github.com/openssl/openssl","homepage":"https://www.openssl.org","size":150778,"stargazers_count":7563,"watchers_count":7563,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3602,"mirror_url":null,"archived":false,"open_issues_count":415,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3602,"open_issues":415,"watchers":7563,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/5254"},"html":{"href":"https://github.com/openssl/openssl/pull/5254"},"issue":{"href":"https://api.github.com/repos/openssl/openssl/issues/5254"},"comments":{"href":"https://api.github.com/repos/openssl/openssl/issues/5254/comments"},"review_comments":{"href":"https://api.github.com/repos/openssl/openssl/pulls/5254/comments"},"review_comment":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openssl/openssl/pulls/5254/commits"},"statuses":{"href":"https://api.github.com/repos/openssl/openssl/statuses/c194c602d238082c35449d2bd49e1cee08078d1d"}},"author_association":"MEMBER","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":14,"review_comments":22,"maintainer_can_modify":false,"commits":2,"additions":79,"deletions":67,"changed_files":5}}
{"actor":{"display_login":"dot-asm"}}