{"action":"created","issue":{"url":"https://api.github.com/repos/pingcap/tidb/issues/7054","repository_url":"https://api.github.com/repos/pingcap/tidb","labels_url":"https://api.github.com/repos/pingcap/tidb/issues/7054/labels{/name}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/7054/comments","events_url":"https://api.github.com/repos/pingcap/tidb/issues/7054/events","html_url":"https://github.com/pingcap/tidb/pull/7054","id":341212175,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDM3OTYx","number":7054,"title":"distsql: move SelectResult to file \"select_result.go\"","user":{"login":"zz-jason","id":5268763,"node_id":"MDQ6VXNlcjUyNjg3NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/5268763?v=4","gravatar_id":"","url":"https://api.github.com/users/zz-jason","html_url":"https://github.com/zz-jason","followers_url":"https://api.github.com/users/zz-jason/followers","following_url":"https://api.github.com/users/zz-jason/following{/other_user}","gists_url":"https://api.github.com/users/zz-jason/gists{/gist_id}","starred_url":"https://api.github.com/users/zz-jason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zz-jason/subscriptions","organizations_url":"https://api.github.com/users/zz-jason/orgs","repos_url":"https://api.github.com/users/zz-jason/repos","events_url":"https://api.github.com/users/zz-jason/events{/privacy}","received_events_url":"https://api.github.com/users/zz-jason/received_events","type":"User","site_admin":false},"labels":[{"id":970807266,"node_id":"MDU6TGFiZWw5NzA4MDcyNjY=","url":"https://api.github.com/repos/pingcap/tidb/labels/component/executor","name":"component/executor","color":"000000","default":false},{"id":564574080,"node_id":"MDU6TGFiZWw1NjQ1NzQwODA=","url":"https://api.github.com/repos/pingcap/tidb/labels/status/LGT1","name":"status/LGT1","color":"d4c5f9","default":false},{"id":770872605,"node_id":"MDU6TGFiZWw3NzA4NzI2MDU=","url":"https://api.github.com/repos/pingcap/tidb/labels/status/all%20tests%20passed","name":"status/all tests passed","color":"2cbe4e","default":false},{"id":256872088,"node_id":"MDU6TGFiZWwyNTY4NzIwODg=","url":"https://api.github.com/repos/pingcap/tidb/labels/type/enhancement","name":"type/enhancement","color":"84b6eb","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/pingcap/tidb/milestones/11","html_url":"https://github.com/pingcap/tidb/milestone/11","labels_url":"https://api.github.com/repos/pingcap/tidb/milestones/11/labels","id":3254588,"node_id":"MDk6TWlsZXN0b25lMzI1NDU4OA==","number":11,"title":"2.1","description":"","creator":{"login":"shenli","id":1192573,"node_id":"MDQ6VXNlcjExOTI1NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1192573?v=4","gravatar_id":"","url":"https://api.github.com/users/shenli","html_url":"https://github.com/shenli","followers_url":"https://api.github.com/users/shenli/followers","following_url":"https://api.github.com/users/shenli/following{/other_user}","gists_url":"https://api.github.com/users/shenli/gists{/gist_id}","starred_url":"https://api.github.com/users/shenli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenli/subscriptions","organizations_url":"https://api.github.com/users/shenli/orgs","repos_url":"https://api.github.com/users/shenli/repos","events_url":"https://api.github.com/users/shenli/events{/privacy}","received_events_url":"https://api.github.com/users/shenli/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":25,"state":"open","created_at":"2018-04-10T03:42:16Z","updated_at":"2018-07-16T01:26:28Z","due_on":"2018-07-31T07:00:00Z","closed_at":null},"comments":3,"created_at":"2018-07-14T06:00:25Z","updated_at":"2018-07-16T03:29:23Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/7054","html_url":"https://github.com/pingcap/tidb/pull/7054","diff_url":"https://github.com/pingcap/tidb/pull/7054.diff","patch_url":"https://github.com/pingcap/tidb/pull/7054.patch"},"body":"<!--\r\nThank you for contributing to TiDB! Please read TiDB's [CONTRIBUTING](https://github.com/pingcap/tidb/blob/master/CONTRIBUTING.md) document **BEFORE** filing this PR.\r\n-->\r\n\r\n## What have you changed? (mandatory)\r\n\r\n1. Move `SelectResult` from file \"distsql/distsql.go\" to file \"distsql/select_result.go\"\r\n2. Remove `errInvalidResp` since it is not used.\r\n3. Remove `readRowFromChunk()` since it is not used as well.\r\n4. Add benchmark test: \"BenchmarkDecodeToChunk\" and \"BenchmarkReadRowsData\"\r\n\r\n<!--\r\nPlease explain **IN DETAIL** what the changes are in this PR and why they are needed:\r\n- Summarize your change (mandatory)\r\n- How does this PR work? Need a brief introduction for the changed logic (optional)\r\n- Separately describe each logical change and avoid lazy messages (optional)\r\n- Describe any limitations of the current code (optional)\r\n\r\nPlease **NOTE** that:\r\n- Do not assume reviewers understand the original issue\r\n-->\r\n\r\n## What is the type of the changes? (mandatory)\r\n\r\n- Improvement\r\n\r\n<!--\r\nThe currently defined types are listed below, please pick one of the types for this PR by removing the others.\r\n\r\n- New feature (non-breaking change which adds functionality)\r\n- Improvement (non-breaking change which is an improvement to an existing feature)\r\n- Bug fix (non-breaking change which fixes an issue)\r\n- Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n-->\r\n\r\n## How has this PR been tested? (mandatory)\r\n\r\nunit test\r\n\r\n<!--\r\nPlease describe the tests that you ran to verify your changes.\r\nHave you finished unit tests, integration tests, or manual tests?\r\nWhat additional tests would give you greater confidence in this change?\r\n-->\r\n\r\n## Does this PR affect documentation (docs/docs-cn) update? (mandatory)\r\n\r\nNo\r\n\r\n<!--\r\nIf there is document change, please file a PR in ([docs](https://github.com/pingcap/docs) or [docs-cn](https://github.com/pingcap/docs-cn)) and add the PR number here.\r\n-->\r\n\r\n## Does this PR affect tidb-ansible update? (mandatory)\r\nNo\r\n\r\n<!--\r\nIf there is a configuration or metrics change, please file a PR in [tidb-ansible](https://github.com/pingcap/tidb-ansible), and add the PR number here.\r\n-->\r\n\r\n## Does this PR need to be added to the release notes? (mandatory)\r\nNo\r\n<!--\r\nIf this PR needs to be added to the release notes, please:\r\n1. add the \"**release-note**\" label for this PR\r\n2. write your release note in the below block\r\n3. if the PR requires additional action from users switching to the new\r\n   release, describe the concrete action that users need to take in detail.\r\n\r\nAn example:\r\n```\r\nrelease note:\r\n// put your release notes for this PR here.\r\n\r\naction required:\r\n// put your required action in detail here.\r\n```\r\n-->\r\n\r\n\r\n## Refer to a related PR or issue link (optional)\r\n\r\n## Benchmark result if necessary (optional)\r\n\r\n## Add a few positive/negative examples (optional)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/pingcap/tidb/issues/comments/405142163","html_url":"https://github.com/pingcap/tidb/pull/7054#issuecomment-405142163","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/7054","id":405142163,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTE0MjE2Mw==","user":{"login":"zz-jason","id":5268763,"node_id":"MDQ6VXNlcjUyNjg3NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/5268763?v=4","gravatar_id":"","url":"https://api.github.com/users/zz-jason","html_url":"https://github.com/zz-jason","followers_url":"https://api.github.com/users/zz-jason/followers","following_url":"https://api.github.com/users/zz-jason/following{/other_user}","gists_url":"https://api.github.com/users/zz-jason/gists{/gist_id}","starred_url":"https://api.github.com/users/zz-jason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zz-jason/subscriptions","organizations_url":"https://api.github.com/users/zz-jason/orgs","repos_url":"https://api.github.com/users/zz-jason/repos","events_url":"https://api.github.com/users/zz-jason/events{/privacy}","received_events_url":"https://api.github.com/users/zz-jason/received_events","type":"User","site_admin":false},"created_at":"2018-07-16T03:29:23Z","updated_at":"2018-07-16T03:29:23Z","author_association":"MEMBER","body":"@coocood @zimulala PTAL"}}
{"actor":{"display_login":"zz-jason"}}