{"action":"closed","number":25,"pull_request":{"url":"https://api.github.com/repos/domainaware/parsedmarc/pulls/25","id":223282528,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMjgyNTI4","html_url":"https://github.com/domainaware/parsedmarc/pull/25","diff_url":"https://github.com/domainaware/parsedmarc/pull/25.diff","patch_url":"https://github.com/domainaware/parsedmarc/pull/25.patch","issue_url":"https://api.github.com/repos/domainaware/parsedmarc/issues/25","number":25,"state":"closed","locked":false,"title":"fix crash on missing comments","user":{"login":"brakhane","id":541637,"node_id":"MDQ6VXNlcjU0MTYzNw==","avatar_url":"https://avatars1.githubusercontent.com/u/541637?v=4","gravatar_id":"","url":"https://api.github.com/users/brakhane","html_url":"https://github.com/brakhane","followers_url":"https://api.github.com/users/brakhane/followers","following_url":"https://api.github.com/users/brakhane/following{/other_user}","gists_url":"https://api.github.com/users/brakhane/gists{/gist_id}","starred_url":"https://api.github.com/users/brakhane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brakhane/subscriptions","organizations_url":"https://api.github.com/users/brakhane/orgs","repos_url":"https://api.github.com/users/brakhane/repos","events_url":"https://api.github.com/users/brakhane/events{/privacy}","received_events_url":"https://api.github.com/users/brakhane/received_events","type":"User","site_admin":false},"body":"Some DMARC reports contain the \"comment\" field with a null value. This\r\nwould case a crash when trying to combine the comments into one.\r\n\r\nTherefore, handle None comments as well.\r\n\r\nAlso remove a buggy line; the reason object already exists in the list,\r\nso no need to append it (and even if we needed to append it, we would\r\nneed to iterate over a copy, otherwise we might end up in an endless\r\nloop)","created_at":"2018-10-16T14:52:53Z","updated_at":"2018-10-16T15:38:47Z","closed_at":"2018-10-16T15:38:47Z","merged_at":"2018-10-16T15:38:47Z","merge_commit_sha":"6a5d2c41052459c93533ca22a28f4f5025eef128","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/domainaware/parsedmarc/pulls/25/commits","review_comments_url":"https://api.github.com/repos/domainaware/parsedmarc/pulls/25/comments","review_comment_url":"https://api.github.com/repos/domainaware/parsedmarc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/domainaware/parsedmarc/issues/25/comments","statuses_url":"https://api.github.com/repos/domainaware/parsedmarc/statuses/71745f006de63edfb8d6f88958ea201ff0303a68","head":{"label":"inoio:fix-missing-comments","ref":"fix-missing-comments","sha":"71745f006de63edfb8d6f88958ea201ff0303a68","user":{"login":"inoio","id":1921935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjE5MzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1921935?v=4","gravatar_id":"","url":"https://api.github.com/users/inoio","html_url":"https://github.com/inoio","followers_url":"https://api.github.com/users/inoio/followers","following_url":"https://api.github.com/users/inoio/following{/other_user}","gists_url":"https://api.github.com/users/inoio/gists{/gist_id}","starred_url":"https://api.github.com/users/inoio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inoio/subscriptions","organizations_url":"https://api.github.com/users/inoio/orgs","repos_url":"https://api.github.com/users/inoio/repos","events_url":"https://api.github.com/users/inoio/events{/privacy}","received_events_url":"https://api.github.com/users/inoio/received_events","type":"Organization","site_admin":false},"repo":{"id":153301651,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMzMDE2NTE=","name":"parsedmarc","full_name":"inoio/parsedmarc","private":false,"owner":{"login":"inoio","id":1921935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjE5MzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1921935?v=4","gravatar_id":"","url":"https://api.github.com/users/inoio","html_url":"https://github.com/inoio","followers_url":"https://api.github.com/users/inoio/followers","following_url":"https://api.github.com/users/inoio/following{/other_user}","gists_url":"https://api.github.com/users/inoio/gists{/gist_id}","starred_url":"https://api.github.com/users/inoio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inoio/subscriptions","organizations_url":"https://api.github.com/users/inoio/orgs","repos_url":"https://api.github.com/users/inoio/repos","events_url":"https://api.github.com/users/inoio/events{/privacy}","received_events_url":"https://api.github.com/users/inoio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/inoio/parsedmarc","description":"A Python package and CLI for parsing aggregate and forensic DMARC reports","fork":true,"url":"https://api.github.com/repos/inoio/parsedmarc","forks_url":"https://api.github.com/repos/inoio/parsedmarc/forks","keys_url":"https://api.github.com/repos/inoio/parsedmarc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inoio/parsedmarc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inoio/parsedmarc/teams","hooks_url":"https://api.github.com/repos/inoio/parsedmarc/hooks","issue_events_url":"https://api.github.com/repos/inoio/parsedmarc/issues/events{/number}","events_url":"https://api.github.com/repos/inoio/parsedmarc/events","assignees_url":"https://api.github.com/repos/inoio/parsedmarc/assignees{/user}","branches_url":"https://api.github.com/repos/inoio/parsedmarc/branches{/branch}","tags_url":"https://api.github.com/repos/inoio/parsedmarc/tags","blobs_url":"https://api.github.com/repos/inoio/parsedmarc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inoio/parsedmarc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inoio/parsedmarc/git/refs{/sha}","trees_url":"https://api.github.com/repos/inoio/parsedmarc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inoio/parsedmarc/statuses/{sha}","languages_url":"https://api.github.com/repos/inoio/parsedmarc/languages","stargazers_url":"https://api.github.com/repos/inoio/parsedmarc/stargazers","contributors_url":"https://api.github.com/repos/inoio/parsedmarc/contributors","subscribers_url":"https://api.github.com/repos/inoio/parsedmarc/subscribers","subscription_url":"https://api.github.com/repos/inoio/parsedmarc/subscription","commits_url":"https://api.github.com/repos/inoio/parsedmarc/commits{/sha}","git_commits_url":"https://api.github.com/repos/inoio/parsedmarc/git/commits{/sha}","comments_url":"https://api.github.com/repos/inoio/parsedmarc/comments{/number}","issue_comment_url":"https://api.github.com/repos/inoio/parsedmarc/issues/comments{/number}","contents_url":"https://api.github.com/repos/inoio/parsedmarc/contents/{+path}","compare_url":"https://api.github.com/repos/inoio/parsedmarc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inoio/parsedmarc/merges","archive_url":"https://api.github.com/repos/inoio/parsedmarc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inoio/parsedmarc/downloads","issues_url":"https://api.github.com/repos/inoio/parsedmarc/issues{/number}","pulls_url":"https://api.github.com/repos/inoio/parsedmarc/pulls{/number}","milestones_url":"https://api.github.com/repos/inoio/parsedmarc/milestones{/number}","notifications_url":"https://api.github.com/repos/inoio/parsedmarc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inoio/parsedmarc/labels{/name}","releases_url":"https://api.github.com/repos/inoio/parsedmarc/releases{/id}","deployments_url":"https://api.github.com/repos/inoio/parsedmarc/deployments","created_at":"2018-10-16T14:38:44Z","updated_at":"2018-10-16T14:38:47Z","pushed_at":"2018-10-16T14:52:33Z","git_url":"git://github.com/inoio/parsedmarc.git","ssh_url":"git@github.com:inoio/parsedmarc.git","clone_url":"https://github.com/inoio/parsedmarc.git","svn_url":"https://github.com/inoio/parsedmarc","homepage":"https://domainaware.github.io/parsedmarc/","size":8196,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"domainaware:master","ref":"master","sha":"dff55f7abe6b6e43fdf219c3122546d35c771c1c","user":{"login":"domainaware","id":34143835,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTQzODM1","avatar_url":"https://avatars2.githubusercontent.com/u/34143835?v=4","gravatar_id":"","url":"https://api.github.com/users/domainaware","html_url":"https://github.com/domainaware","followers_url":"https://api.github.com/users/domainaware/followers","following_url":"https://api.github.com/users/domainaware/following{/other_user}","gists_url":"https://api.github.com/users/domainaware/gists{/gist_id}","starred_url":"https://api.github.com/users/domainaware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domainaware/subscriptions","organizations_url":"https://api.github.com/users/domainaware/orgs","repos_url":"https://api.github.com/users/domainaware/repos","events_url":"https://api.github.com/users/domainaware/events{/privacy}","received_events_url":"https://api.github.com/users/domainaware/received_events","type":"Organization","site_admin":false},"repo":{"id":120373756,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAzNzM3NTY=","name":"parsedmarc","full_name":"domainaware/parsedmarc","private":false,"owner":{"login":"domainaware","id":34143835,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTQzODM1","avatar_url":"https://avatars2.githubusercontent.com/u/34143835?v=4","gravatar_id":"","url":"https://api.github.com/users/domainaware","html_url":"https://github.com/domainaware","followers_url":"https://api.github.com/users/domainaware/followers","following_url":"https://api.github.com/users/domainaware/following{/other_user}","gists_url":"https://api.github.com/users/domainaware/gists{/gist_id}","starred_url":"https://api.github.com/users/domainaware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domainaware/subscriptions","organizations_url":"https://api.github.com/users/domainaware/orgs","repos_url":"https://api.github.com/users/domainaware/repos","events_url":"https://api.github.com/users/domainaware/events{/privacy}","received_events_url":"https://api.github.com/users/domainaware/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/domainaware/parsedmarc","description":"A Python package and CLI for parsing aggregate and forensic DMARC reports","fork":false,"url":"https://api.github.com/repos/domainaware/parsedmarc","forks_url":"https://api.github.com/repos/domainaware/parsedmarc/forks","keys_url":"https://api.github.com/repos/domainaware/parsedmarc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/domainaware/parsedmarc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/domainaware/parsedmarc/teams","hooks_url":"https://api.github.com/repos/domainaware/parsedmarc/hooks","issue_events_url":"https://api.github.com/repos/domainaware/parsedmarc/issues/events{/number}","events_url":"https://api.github.com/repos/domainaware/parsedmarc/events","assignees_url":"https://api.github.com/repos/domainaware/parsedmarc/assignees{/user}","branches_url":"https://api.github.com/repos/domainaware/parsedmarc/branches{/branch}","tags_url":"https://api.github.com/repos/domainaware/parsedmarc/tags","blobs_url":"https://api.github.com/repos/domainaware/parsedmarc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/domainaware/parsedmarc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/domainaware/parsedmarc/git/refs{/sha}","trees_url":"https://api.github.com/repos/domainaware/parsedmarc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/domainaware/parsedmarc/statuses/{sha}","languages_url":"https://api.github.com/repos/domainaware/parsedmarc/languages","stargazers_url":"https://api.github.com/repos/domainaware/parsedmarc/stargazers","contributors_url":"https://api.github.com/repos/domainaware/parsedmarc/contributors","subscribers_url":"https://api.github.com/repos/domainaware/parsedmarc/subscribers","subscription_url":"https://api.github.com/repos/domainaware/parsedmarc/subscription","commits_url":"https://api.github.com/repos/domainaware/parsedmarc/commits{/sha}","git_commits_url":"https://api.github.com/repos/domainaware/parsedmarc/git/commits{/sha}","comments_url":"https://api.github.com/repos/domainaware/parsedmarc/comments{/number}","issue_comment_url":"https://api.github.com/repos/domainaware/parsedmarc/issues/comments{/number}","contents_url":"https://api.github.com/repos/domainaware/parsedmarc/contents/{+path}","compare_url":"https://api.github.com/repos/domainaware/parsedmarc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/domainaware/parsedmarc/merges","archive_url":"https://api.github.com/repos/domainaware/parsedmarc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/domainaware/parsedmarc/downloads","issues_url":"https://api.github.com/repos/domainaware/parsedmarc/issues{/number}","pulls_url":"https://api.github.com/repos/domainaware/parsedmarc/pulls{/number}","milestones_url":"https://api.github.com/repos/domainaware/parsedmarc/milestones{/number}","notifications_url":"https://api.github.com/repos/domainaware/parsedmarc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/domainaware/parsedmarc/labels{/name}","releases_url":"https://api.github.com/repos/domainaware/parsedmarc/releases{/id}","deployments_url":"https://api.github.com/repos/domainaware/parsedmarc/deployments","created_at":"2018-02-05T23:08:59Z","updated_at":"2018-10-15T00:55:36Z","pushed_at":"2018-10-16T15:38:47Z","git_url":"git://github.com/domainaware/parsedmarc.git","ssh_url":"git@github.com:domainaware/parsedmarc.git","clone_url":"https://github.com/domainaware/parsedmarc.git","svn_url":"https://github.com/domainaware/parsedmarc","homepage":"https://domainaware.github.io/parsedmarc/","size":8196,"stargazers_count":22,"watchers_count":22,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":2,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/domainaware/parsedmarc/pulls/25"},"html":{"href":"https://github.com/domainaware/parsedmarc/pull/25"},"issue":{"href":"https://api.github.com/repos/domainaware/parsedmarc/issues/25"},"comments":{"href":"https://api.github.com/repos/domainaware/parsedmarc/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/domainaware/parsedmarc/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/domainaware/parsedmarc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/domainaware/parsedmarc/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/domainaware/parsedmarc/statuses/71745f006de63edfb8d6f88958ea201ff0303a68"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"seanthegeek","id":44679,"node_id":"MDQ6VXNlcjQ0Njc5","avatar_url":"https://avatars3.githubusercontent.com/u/44679?v=4","gravatar_id":"","url":"https://api.github.com/users/seanthegeek","html_url":"https://github.com/seanthegeek","followers_url":"https://api.github.com/users/seanthegeek/followers","following_url":"https://api.github.com/users/seanthegeek/following{/other_user}","gists_url":"https://api.github.com/users/seanthegeek/gists{/gist_id}","starred_url":"https://api.github.com/users/seanthegeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanthegeek/subscriptions","organizations_url":"https://api.github.com/users/seanthegeek/orgs","repos_url":"https://api.github.com/users/seanthegeek/repos","events_url":"https://api.github.com/users/seanthegeek/events{/privacy}","received_events_url":"https://api.github.com/users/seanthegeek/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"seanthegeek"}}