{"action":"closed","number":3386,"pull_request":{"url":"https://api.github.com/repos/FRRouting/frr/pulls/3386","id":234210696,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MjEwNjk2","html_url":"https://github.com/FRRouting/frr/pull/3386","diff_url":"https://github.com/FRRouting/frr/pull/3386.diff","patch_url":"https://github.com/FRRouting/frr/pull/3386.patch","issue_url":"https://api.github.com/repos/FRRouting/frr/issues/3386","number":3386,"state":"closed","locked":false,"title":"bgpd: bgp pbr ignores bgp fs entries with 0.0.0.0 ips written.","user":{"login":"pguibert6WIND","id":16295538,"node_id":"MDQ6VXNlcjE2Mjk1NTM4","avatar_url":"https://avatars2.githubusercontent.com/u/16295538?v=4","gravatar_id":"","url":"https://api.github.com/users/pguibert6WIND","html_url":"https://github.com/pguibert6WIND","followers_url":"https://api.github.com/users/pguibert6WIND/followers","following_url":"https://api.github.com/users/pguibert6WIND/following{/other_user}","gists_url":"https://api.github.com/users/pguibert6WIND/gists{/gist_id}","starred_url":"https://api.github.com/users/pguibert6WIND/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pguibert6WIND/subscriptions","organizations_url":"https://api.github.com/users/pguibert6WIND/orgs","repos_url":"https://api.github.com/users/pguibert6WIND/repos","events_url":"https://api.github.com/users/pguibert6WIND/events{/privacy}","received_events_url":"https://api.github.com/users/pguibert6WIND/received_events","type":"User","site_admin":false},"body":"when converting bgp fs entries to bgp pbr entries, the fields of the\r\nflowspec are analysed. In the case src ip or dst ip is set to 0.0.0.0,\r\nthat field is ignored, thus preventing from injecting a rule that can\r\nnot be injected into the pbr. ( because with ipset tools, you can not\r\ncreate a rule with 0.0.0.0 inside). This can be done by avoiding mentioning\r\nthe field in the bitmask structure used to convert data to pbr entries.\r\n\r\nPR=61620\r\nSigned-off-by: Philippe Guibert <philippe.guibert@6wind.com>\r\nAcked-by: Emmanuel Vize <emmanuel.vize@6wind.com>\r\n","created_at":"2018-11-28T09:50:48Z","updated_at":"2018-11-30T23:50:26Z","closed_at":"2018-11-30T23:50:26Z","merged_at":"2018-11-30T23:50:26Z","merge_commit_sha":"1b982ea43031fbbdab45faf0c132590144c28f6d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FRRouting/frr/pulls/3386/commits","review_comments_url":"https://api.github.com/repos/FRRouting/frr/pulls/3386/comments","review_comment_url":"https://api.github.com/repos/FRRouting/frr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FRRouting/frr/issues/3386/comments","statuses_url":"https://api.github.com/repos/FRRouting/frr/statuses/4c2876fb8d61cd3e2bf9668fdc10bd30140ef3af","head":{"label":"pguibert6WIND:bgp_fs_pbr_ignores_null_ip","ref":"bgp_fs_pbr_ignores_null_ip","sha":"4c2876fb8d61cd3e2bf9668fdc10bd30140ef3af","user":{"login":"pguibert6WIND","id":16295538,"node_id":"MDQ6VXNlcjE2Mjk1NTM4","avatar_url":"https://avatars2.githubusercontent.com/u/16295538?v=4","gravatar_id":"","url":"https://api.github.com/users/pguibert6WIND","html_url":"https://github.com/pguibert6WIND","followers_url":"https://api.github.com/users/pguibert6WIND/followers","following_url":"https://api.github.com/users/pguibert6WIND/following{/other_user}","gists_url":"https://api.github.com/users/pguibert6WIND/gists{/gist_id}","starred_url":"https://api.github.com/users/pguibert6WIND/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pguibert6WIND/subscriptions","organizations_url":"https://api.github.com/users/pguibert6WIND/orgs","repos_url":"https://api.github.com/users/pguibert6WIND/repos","events_url":"https://api.github.com/users/pguibert6WIND/events{/privacy}","received_events_url":"https://api.github.com/users/pguibert6WIND/received_events","type":"User","site_admin":false},"repo":{"id":78088116,"node_id":"MDEwOlJlcG9zaXRvcnk3ODA4ODExNg==","name":"frr","full_name":"pguibert6WIND/frr","private":false,"owner":{"login":"pguibert6WIND","id":16295538,"node_id":"MDQ6VXNlcjE2Mjk1NTM4","avatar_url":"https://avatars2.githubusercontent.com/u/16295538?v=4","gravatar_id":"","url":"https://api.github.com/users/pguibert6WIND","html_url":"https://github.com/pguibert6WIND","followers_url":"https://api.github.com/users/pguibert6WIND/followers","following_url":"https://api.github.com/users/pguibert6WIND/following{/other_user}","gists_url":"https://api.github.com/users/pguibert6WIND/gists{/gist_id}","starred_url":"https://api.github.com/users/pguibert6WIND/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pguibert6WIND/subscriptions","organizations_url":"https://api.github.com/users/pguibert6WIND/orgs","repos_url":"https://api.github.com/users/pguibert6WIND/repos","events_url":"https://api.github.com/users/pguibert6WIND/events{/privacy}","received_events_url":"https://api.github.com/users/pguibert6WIND/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pguibert6WIND/frr","description":"FRR - The FreeRangeRouting Protocol Suite forked from Quagga","fork":true,"url":"https://api.github.com/repos/pguibert6WIND/frr","forks_url":"https://api.github.com/repos/pguibert6WIND/frr/forks","keys_url":"https://api.github.com/repos/pguibert6WIND/frr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pguibert6WIND/frr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pguibert6WIND/frr/teams","hooks_url":"https://api.github.com/repos/pguibert6WIND/frr/hooks","issue_events_url":"https://api.github.com/repos/pguibert6WIND/frr/issues/events{/number}","events_url":"https://api.github.com/repos/pguibert6WIND/frr/events","assignees_url":"https://api.github.com/repos/pguibert6WIND/frr/assignees{/user}","branches_url":"https://api.github.com/repos/pguibert6WIND/frr/branches{/branch}","tags_url":"https://api.github.com/repos/pguibert6WIND/frr/tags","blobs_url":"https://api.github.com/repos/pguibert6WIND/frr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pguibert6WIND/frr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pguibert6WIND/frr/git/refs{/sha}","trees_url":"https://api.github.com/repos/pguibert6WIND/frr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pguibert6WIND/frr/statuses/{sha}","languages_url":"https://api.github.com/repos/pguibert6WIND/frr/languages","stargazers_url":"https://api.github.com/repos/pguibert6WIND/frr/stargazers","contributors_url":"https://api.github.com/repos/pguibert6WIND/frr/contributors","subscribers_url":"https://api.github.com/repos/pguibert6WIND/frr/subscribers","subscription_url":"https://api.github.com/repos/pguibert6WIND/frr/subscription","commits_url":"https://api.github.com/repos/pguibert6WIND/frr/commits{/sha}","git_commits_url":"https://api.github.com/repos/pguibert6WIND/frr/git/commits{/sha}","comments_url":"https://api.github.com/repos/pguibert6WIND/frr/comments{/number}","issue_comment_url":"https://api.github.com/repos/pguibert6WIND/frr/issues/comments{/number}","contents_url":"https://api.github.com/repos/pguibert6WIND/frr/contents/{+path}","compare_url":"https://api.github.com/repos/pguibert6WIND/frr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pguibert6WIND/frr/merges","archive_url":"https://api.github.com/repos/pguibert6WIND/frr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pguibert6WIND/frr/downloads","issues_url":"https://api.github.com/repos/pguibert6WIND/frr/issues{/number}","pulls_url":"https://api.github.com/repos/pguibert6WIND/frr/pulls{/number}","milestones_url":"https://api.github.com/repos/pguibert6WIND/frr/milestones{/number}","notifications_url":"https://api.github.com/repos/pguibert6WIND/frr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pguibert6WIND/frr/labels{/name}","releases_url":"https://api.github.com/repos/pguibert6WIND/frr/releases{/id}","deployments_url":"https://api.github.com/repos/pguibert6WIND/frr/deployments","created_at":"2017-01-05T06:56:15Z","updated_at":"2017-01-05T06:56:22Z","pushed_at":"2018-11-30T14:56:57Z","git_url":"git://github.com/pguibert6WIND/frr.git","ssh_url":"git@github.com:pguibert6WIND/frr.git","clone_url":"https://github.com/pguibert6WIND/frr.git","svn_url":"https://github.com/pguibert6WIND/frr","homepage":"","size":50682,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FRRouting:master","ref":"master","sha":"f17b99ed1709c8e6cc940d3dbad737d3be21ddc4","user":{"login":"FRRouting","id":24592672,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTkyNjcy","avatar_url":"https://avatars1.githubusercontent.com/u/24592672?v=4","gravatar_id":"","url":"https://api.github.com/users/FRRouting","html_url":"https://github.com/FRRouting","followers_url":"https://api.github.com/users/FRRouting/followers","following_url":"https://api.github.com/users/FRRouting/following{/other_user}","gists_url":"https://api.github.com/users/FRRouting/gists{/gist_id}","starred_url":"https://api.github.com/users/FRRouting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRRouting/subscriptions","organizations_url":"https://api.github.com/users/FRRouting/orgs","repos_url":"https://api.github.com/users/FRRouting/repos","events_url":"https://api.github.com/users/FRRouting/events{/privacy}","received_events_url":"https://api.github.com/users/FRRouting/received_events","type":"Organization","site_admin":false},"repo":{"id":76599439,"node_id":"MDEwOlJlcG9zaXRvcnk3NjU5OTQzOQ==","name":"frr","full_name":"FRRouting/frr","private":false,"owner":{"login":"FRRouting","id":24592672,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTkyNjcy","avatar_url":"https://avatars1.githubusercontent.com/u/24592672?v=4","gravatar_id":"","url":"https://api.github.com/users/FRRouting","html_url":"https://github.com/FRRouting","followers_url":"https://api.github.com/users/FRRouting/followers","following_url":"https://api.github.com/users/FRRouting/following{/other_user}","gists_url":"https://api.github.com/users/FRRouting/gists{/gist_id}","starred_url":"https://api.github.com/users/FRRouting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRRouting/subscriptions","organizations_url":"https://api.github.com/users/FRRouting/orgs","repos_url":"https://api.github.com/users/FRRouting/repos","events_url":"https://api.github.com/users/FRRouting/events{/privacy}","received_events_url":"https://api.github.com/users/FRRouting/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/FRRouting/frr","description":"The FRRouting Protocol Suite","fork":false,"url":"https://api.github.com/repos/FRRouting/frr","forks_url":"https://api.github.com/repos/FRRouting/frr/forks","keys_url":"https://api.github.com/repos/FRRouting/frr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FRRouting/frr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FRRouting/frr/teams","hooks_url":"https://api.github.com/repos/FRRouting/frr/hooks","issue_events_url":"https://api.github.com/repos/FRRouting/frr/issues/events{/number}","events_url":"https://api.github.com/repos/FRRouting/frr/events","assignees_url":"https://api.github.com/repos/FRRouting/frr/assignees{/user}","branches_url":"https://api.github.com/repos/FRRouting/frr/branches{/branch}","tags_url":"https://api.github.com/repos/FRRouting/frr/tags","blobs_url":"https://api.github.com/repos/FRRouting/frr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FRRouting/frr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FRRouting/frr/git/refs{/sha}","trees_url":"https://api.github.com/repos/FRRouting/frr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FRRouting/frr/statuses/{sha}","languages_url":"https://api.github.com/repos/FRRouting/frr/languages","stargazers_url":"https://api.github.com/repos/FRRouting/frr/stargazers","contributors_url":"https://api.github.com/repos/FRRouting/frr/contributors","subscribers_url":"https://api.github.com/repos/FRRouting/frr/subscribers","subscription_url":"https://api.github.com/repos/FRRouting/frr/subscription","commits_url":"https://api.github.com/repos/FRRouting/frr/commits{/sha}","git_commits_url":"https://api.github.com/repos/FRRouting/frr/git/commits{/sha}","comments_url":"https://api.github.com/repos/FRRouting/frr/comments{/number}","issue_comment_url":"https://api.github.com/repos/FRRouting/frr/issues/comments{/number}","contents_url":"https://api.github.com/repos/FRRouting/frr/contents/{+path}","compare_url":"https://api.github.com/repos/FRRouting/frr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FRRouting/frr/merges","archive_url":"https://api.github.com/repos/FRRouting/frr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FRRouting/frr/downloads","issues_url":"https://api.github.com/repos/FRRouting/frr/issues{/number}","pulls_url":"https://api.github.com/repos/FRRouting/frr/pulls{/number}","milestones_url":"https://api.github.com/repos/FRRouting/frr/milestones{/number}","notifications_url":"https://api.github.com/repos/FRRouting/frr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FRRouting/frr/labels{/name}","releases_url":"https://api.github.com/repos/FRRouting/frr/releases{/id}","deployments_url":"https://api.github.com/repos/FRRouting/frr/deployments","created_at":"2016-12-15T21:56:38Z","updated_at":"2018-11-30T23:36:32Z","pushed_at":"2018-11-30T23:50:25Z","git_url":"git://github.com/FRRouting/frr.git","ssh_url":"git@github.com:FRRouting/frr.git","clone_url":"https://github.com/FRRouting/frr.git","svn_url":"https://github.com/FRRouting/frr","homepage":"https://frrouting.org/","size":50007,"stargazers_count":724,"watchers_count":724,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":298,"mirror_url":null,"archived":false,"open_issues_count":350,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":298,"open_issues":350,"watchers":724,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/3386"},"html":{"href":"https://github.com/FRRouting/frr/pull/3386"},"issue":{"href":"https://api.github.com/repos/FRRouting/frr/issues/3386"},"comments":{"href":"https://api.github.com/repos/FRRouting/frr/issues/3386/comments"},"review_comments":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/3386/comments"},"review_comment":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FRRouting/frr/pulls/3386/commits"},"statuses":{"href":"https://api.github.com/repos/FRRouting/frr/statuses/4c2876fb8d61cd3e2bf9668fdc10bd30140ef3af"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"donaldsharp","id":10601296,"node_id":"MDQ6VXNlcjEwNjAxMjk2","avatar_url":"https://avatars3.githubusercontent.com/u/10601296?v=4","gravatar_id":"","url":"https://api.github.com/users/donaldsharp","html_url":"https://github.com/donaldsharp","followers_url":"https://api.github.com/users/donaldsharp/followers","following_url":"https://api.github.com/users/donaldsharp/following{/other_user}","gists_url":"https://api.github.com/users/donaldsharp/gists{/gist_id}","starred_url":"https://api.github.com/users/donaldsharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donaldsharp/subscriptions","organizations_url":"https://api.github.com/users/donaldsharp/orgs","repos_url":"https://api.github.com/users/donaldsharp/repos","events_url":"https://api.github.com/users/donaldsharp/events{/privacy}","received_events_url":"https://api.github.com/users/donaldsharp/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":11,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"donaldsharp"}}