{"action":"created","comment":{"url":"https://api.github.com/repos/ska-sa/katgui/pulls/comments/215947340","pull_request_review_id":153325626,"id":215947340,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTk0NzM0MA==","diff_hunk":"@@ -38,6 +39,67 @@\n         vm.useUnixTimestamps = $localStorage['useUnixTimestamps']? true: false;\n         vm.searchWidth = $localStorage['sensorGraphSearchWidth']? $localStorage['sensorGraphSearchWidth'] : 366;\n \n+        vm.selectedSensor = '';\n+        vm.getSelectedSensor = function(sensor) {\n+            vm.selectedSensor = sensor;\n+        }\n+\n+        vm.deriveCompoundTag = function(sensor) {\n+            try {\n+              compoundTag = sensor.attributes.katcp_name.replace(/\\./g, '_:_')\n+            } catch (error) {\n+                compoundTag = '';\n+                $log.error('Could not extract compound tag string ' + error);\n+            }\n+            return compoundTag\n+        }\n+\n+        vm.openUserLog = function() {\n+          UserLogService.listTags();\n+          var content = '';\n+          var endTime = '';\n+          var allocations = [];\n+          var assignedResources = [];\n+          var compoundTags = []\n+          var startTime = $rootScope.utcDateTime;\n+          if (vm.selectedSensor) {","path":"app/sensor-graph/sensor-graph.js","position":44,"original_position":44,"commit_id":"143c73303c341f4fb0480a03d305c15969f6ec60","original_commit_id":"143c73303c341f4fb0480a03d305c15969f6ec60","user":{"login":"ajoubertza","id":20420754,"node_id":"MDQ6VXNlcjIwNDIwNzU0","avatar_url":"https://avatars2.githubusercontent.com/u/20420754?v=4","gravatar_id":"","url":"https://api.github.com/users/ajoubertza","html_url":"https://github.com/ajoubertza","followers_url":"https://api.github.com/users/ajoubertza/followers","following_url":"https://api.github.com/users/ajoubertza/following{/other_user}","gists_url":"https://api.github.com/users/ajoubertza/gists{/gist_id}","starred_url":"https://api.github.com/users/ajoubertza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajoubertza/subscriptions","organizations_url":"https://api.github.com/users/ajoubertza/orgs","repos_url":"https://api.github.com/users/ajoubertza/repos","events_url":"https://api.github.com/users/ajoubertza/events{/privacy}","received_events_url":"https://api.github.com/users/ajoubertza/received_events","type":"User","site_admin":false},"body":"Does it really matter if a sensor is selected on the sensor graph page.  Isn't a check on  the length of `vm.sensorNames` sufficient?","created_at":"2018-09-07T12:49:14Z","updated_at":"2018-09-07T12:51:36Z","html_url":"https://github.com/ska-sa/katgui/pull/395#discussion_r215947340","pull_request_url":"https://api.github.com/repos/ska-sa/katgui/pulls/395","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ska-sa/katgui/pulls/comments/215947340"},"html":{"href":"https://github.com/ska-sa/katgui/pull/395#discussion_r215947340"},"pull_request":{"href":"https://api.github.com/repos/ska-sa/katgui/pulls/395"}}},"pull_request":{"url":"https://api.github.com/repos/ska-sa/katgui/pulls/395","id":213499963,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNDk5OTYz","html_url":"https://github.com/ska-sa/katgui/pull/395","diff_url":"https://github.com/ska-sa/katgui/pull/395.diff","patch_url":"https://github.com/ska-sa/katgui/pull/395.patch","issue_url":"https://api.github.com/repos/ska-sa/katgui/issues/395","number":395,"state":"open","locked":false,"title":"add a feature to be able to add user log from sensor graph and sensor…","user":{"login":"ofaletse","id":6682664,"node_id":"MDQ6VXNlcjY2ODI2NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6682664?v=4","gravatar_id":"","url":"https://api.github.com/users/ofaletse","html_url":"https://github.com/ofaletse","followers_url":"https://api.github.com/users/ofaletse/followers","following_url":"https://api.github.com/users/ofaletse/following{/other_user}","gists_url":"https://api.github.com/users/ofaletse/gists{/gist_id}","starred_url":"https://api.github.com/users/ofaletse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofaletse/subscriptions","organizations_url":"https://api.github.com/users/ofaletse/orgs","repos_url":"https://api.github.com/users/ofaletse/repos","events_url":"https://api.github.com/users/ofaletse/events{/privacy}","received_events_url":"https://api.github.com/users/ofaletse/received_events","type":"User","site_admin":false},"body":"Add a feature that will allow the user to be able to open and add user log from sensor list display and sensor graph display. A context menu is added to the table of sensor graph and sensor list.\r\nTo archive this an angular right click and context menu library was used.\r\n\r\n@bxaia and @ajoubertza may you please review.\r\n\r\nJira [MT-23](https://skaafrica.atlassian.net/browse/MT-23) \r\nJira [MT-11](https://skaafrica.atlassian.net/browse/MT-11)","created_at":"2018-09-06T05:36:22Z","updated_at":"2018-09-07T12:51:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98dad0dd80373ed2dece27fcd300f4fe49f32f9a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ska-sa/katgui/pulls/395/commits","review_comments_url":"https://api.github.com/repos/ska-sa/katgui/pulls/395/comments","review_comment_url":"https://api.github.com/repos/ska-sa/katgui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ska-sa/katgui/issues/395/comments","statuses_url":"https://api.github.com/repos/ska-sa/katgui/statuses/143c73303c341f4fb0480a03d305c15969f6ec60","head":{"label":"ska-sa:user/ofaletse/MT-11/MT-23/add_userLog_from_sensorList_and_sensorGraph","ref":"user/ofaletse/MT-11/MT-23/add_userLog_from_sensorList_and_sensorGraph","sha":"143c73303c341f4fb0480a03d305c15969f6ec60","user":{"login":"ska-sa","id":1210238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAyMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/1210238?v=4","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"repo":{"id":22711656,"node_id":"MDEwOlJlcG9zaXRvcnkyMjcxMTY1Ng==","name":"katgui","full_name":"ska-sa/katgui","owner":{"login":"ska-sa","id":1210238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAyMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/1210238?v=4","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ska-sa/katgui","description":"katgui web operator interface","fork":false,"url":"https://api.github.com/repos/ska-sa/katgui","forks_url":"https://api.github.com/repos/ska-sa/katgui/forks","keys_url":"https://api.github.com/repos/ska-sa/katgui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ska-sa/katgui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ska-sa/katgui/teams","hooks_url":"https://api.github.com/repos/ska-sa/katgui/hooks","issue_events_url":"https://api.github.com/repos/ska-sa/katgui/issues/events{/number}","events_url":"https://api.github.com/repos/ska-sa/katgui/events","assignees_url":"https://api.github.com/repos/ska-sa/katgui/assignees{/user}","branches_url":"https://api.github.com/repos/ska-sa/katgui/branches{/branch}","tags_url":"https://api.github.com/repos/ska-sa/katgui/tags","blobs_url":"https://api.github.com/repos/ska-sa/katgui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ska-sa/katgui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ska-sa/katgui/git/refs{/sha}","trees_url":"https://api.github.com/repos/ska-sa/katgui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ska-sa/katgui/statuses/{sha}","languages_url":"https://api.github.com/repos/ska-sa/katgui/languages","stargazers_url":"https://api.github.com/repos/ska-sa/katgui/stargazers","contributors_url":"https://api.github.com/repos/ska-sa/katgui/contributors","subscribers_url":"https://api.github.com/repos/ska-sa/katgui/subscribers","subscription_url":"https://api.github.com/repos/ska-sa/katgui/subscription","commits_url":"https://api.github.com/repos/ska-sa/katgui/commits{/sha}","git_commits_url":"https://api.github.com/repos/ska-sa/katgui/git/commits{/sha}","comments_url":"https://api.github.com/repos/ska-sa/katgui/comments{/number}","issue_comment_url":"https://api.github.com/repos/ska-sa/katgui/issues/comments{/number}","contents_url":"https://api.github.com/repos/ska-sa/katgui/contents/{+path}","compare_url":"https://api.github.com/repos/ska-sa/katgui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ska-sa/katgui/merges","archive_url":"https://api.github.com/repos/ska-sa/katgui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ska-sa/katgui/downloads","issues_url":"https://api.github.com/repos/ska-sa/katgui/issues{/number}","pulls_url":"https://api.github.com/repos/ska-sa/katgui/pulls{/number}","milestones_url":"https://api.github.com/repos/ska-sa/katgui/milestones{/number}","notifications_url":"https://api.github.com/repos/ska-sa/katgui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ska-sa/katgui/labels{/name}","releases_url":"https://api.github.com/repos/ska-sa/katgui/releases{/id}","deployments_url":"https://api.github.com/repos/ska-sa/katgui/deployments","created_at":"2014-08-07T06:56:37Z","updated_at":"2018-09-07T06:51:21Z","pushed_at":"2018-09-07T07:18:35Z","git_url":"git://github.com/ska-sa/katgui.git","ssh_url":"git@github.com:ska-sa/katgui.git","clone_url":"https://github.com/ska-sa/katgui.git","svn_url":"https://github.com/ska-sa/katgui","homepage":"","size":9739,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"ska-sa:master","ref":"master","sha":"540a6bc889778e33f5daca1b4fd52de705f85eaa","user":{"login":"ska-sa","id":1210238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAyMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/1210238?v=4","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"repo":{"id":22711656,"node_id":"MDEwOlJlcG9zaXRvcnkyMjcxMTY1Ng==","name":"katgui","full_name":"ska-sa/katgui","owner":{"login":"ska-sa","id":1210238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAyMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/1210238?v=4","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ska-sa/katgui","description":"katgui web operator interface","fork":false,"url":"https://api.github.com/repos/ska-sa/katgui","forks_url":"https://api.github.com/repos/ska-sa/katgui/forks","keys_url":"https://api.github.com/repos/ska-sa/katgui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ska-sa/katgui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ska-sa/katgui/teams","hooks_url":"https://api.github.com/repos/ska-sa/katgui/hooks","issue_events_url":"https://api.github.com/repos/ska-sa/katgui/issues/events{/number}","events_url":"https://api.github.com/repos/ska-sa/katgui/events","assignees_url":"https://api.github.com/repos/ska-sa/katgui/assignees{/user}","branches_url":"https://api.github.com/repos/ska-sa/katgui/branches{/branch}","tags_url":"https://api.github.com/repos/ska-sa/katgui/tags","blobs_url":"https://api.github.com/repos/ska-sa/katgui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ska-sa/katgui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ska-sa/katgui/git/refs{/sha}","trees_url":"https://api.github.com/repos/ska-sa/katgui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ska-sa/katgui/statuses/{sha}","languages_url":"https://api.github.com/repos/ska-sa/katgui/languages","stargazers_url":"https://api.github.com/repos/ska-sa/katgui/stargazers","contributors_url":"https://api.github.com/repos/ska-sa/katgui/contributors","subscribers_url":"https://api.github.com/repos/ska-sa/katgui/subscribers","subscription_url":"https://api.github.com/repos/ska-sa/katgui/subscription","commits_url":"https://api.github.com/repos/ska-sa/katgui/commits{/sha}","git_commits_url":"https://api.github.com/repos/ska-sa/katgui/git/commits{/sha}","comments_url":"https://api.github.com/repos/ska-sa/katgui/comments{/number}","issue_comment_url":"https://api.github.com/repos/ska-sa/katgui/issues/comments{/number}","contents_url":"https://api.github.com/repos/ska-sa/katgui/contents/{+path}","compare_url":"https://api.github.com/repos/ska-sa/katgui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ska-sa/katgui/merges","archive_url":"https://api.github.com/repos/ska-sa/katgui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ska-sa/katgui/downloads","issues_url":"https://api.github.com/repos/ska-sa/katgui/issues{/number}","pulls_url":"https://api.github.com/repos/ska-sa/katgui/pulls{/number}","milestones_url":"https://api.github.com/repos/ska-sa/katgui/milestones{/number}","notifications_url":"https://api.github.com/repos/ska-sa/katgui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ska-sa/katgui/labels{/name}","releases_url":"https://api.github.com/repos/ska-sa/katgui/releases{/id}","deployments_url":"https://api.github.com/repos/ska-sa/katgui/deployments","created_at":"2014-08-07T06:56:37Z","updated_at":"2018-09-07T06:51:21Z","pushed_at":"2018-09-07T07:18:35Z","git_url":"git://github.com/ska-sa/katgui.git","ssh_url":"git@github.com:ska-sa/katgui.git","clone_url":"https://github.com/ska-sa/katgui.git","svn_url":"https://github.com/ska-sa/katgui","homepage":"","size":9739,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ska-sa/katgui/pulls/395"},"html":{"href":"https://github.com/ska-sa/katgui/pull/395"},"issue":{"href":"https://api.github.com/repos/ska-sa/katgui/issues/395"},"comments":{"href":"https://api.github.com/repos/ska-sa/katgui/issues/395/comments"},"review_comments":{"href":"https://api.github.com/repos/ska-sa/katgui/pulls/395/comments"},"review_comment":{"href":"https://api.github.com/repos/ska-sa/katgui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ska-sa/katgui/pulls/395/commits"},"statuses":{"href":"https://api.github.com/repos/ska-sa/katgui/statuses/143c73303c341f4fb0480a03d305c15969f6ec60"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ajoubertza"}}