{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/171730956","pull_request_review_id":100637388,"id":171730956,"diff_hunk":"@@ -218,6 +228,39 @@ int Compiler::numArgsOfHWIntrinsic(NamedIntrinsic intrinsic)\n     return hwIntrinsicInfoArray[intrinsic - NI_HW_INTRINSIC_START - 1].numArgs;\n }\n \n+//------------------------------------------------------------------------\n+// numArgsOfHWIntrinsic: get the number of arguments based on baseType\n+//\n+// Arguments:\n+//    intrinsic -- id of the intrinsic function.\n+//    baseType  -- var_types type of intrinsic\n+//\n+// Return Value:\n+//     number of arguments\n+//\n+int Compiler::numArgsOfHWIntrinsic(NamedIntrinsic intrinsic, var_types baseType)\n+{\n+    assert(intrinsic != NI_Illegal);\n+    assert(intrinsic > NI_HW_INTRINSIC_START && intrinsic < NI_HW_INTRINSIC_END);\n+\n+    int numArgs = hwIntrinsicInfoArray[intrinsic - NI_HW_INTRINSIC_START - 1].numArgs;\n+    if (numArgs == -1)\n+    {\n+        switch (intrinsic)\n+        {\n+            case NI_SSE2_Shuffle:\n+                assert(hwIntrinsicArgsInfoArray[0].intrinsicID == intrinsic);\n+                assert((baseType >= TYP_BYTE) && (baseType <= TYP_DOUBLE));\n+                return hwIntrinsicArgsInfoArray[0].numArgs[baseType - TYP_BYTE];\n+\n+            default:\n+                break;\n+        }\n+    }\n+\n+    return numArgs;\n+}","path":"src/jit/hwintrinsicxarch.cpp","position":null,"original_position":58,"commit_id":"579a41cdf868d0cfba5bff071c782da0c59d1e0f","original_commit_id":"4079d8d958d0f16c6802882f0a86d8bf8c25a72f","user":{"login":"fiigii","id":1263030,"avatar_url":"https://avatars1.githubusercontent.com/u/1263030?v=4","gravatar_id":"","url":"https://api.github.com/users/fiigii","html_url":"https://github.com/fiigii","followers_url":"https://api.github.com/users/fiigii/followers","following_url":"https://api.github.com/users/fiigii/following{/other_user}","gists_url":"https://api.github.com/users/fiigii/gists{/gist_id}","starred_url":"https://api.github.com/users/fiigii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fiigii/subscriptions","organizations_url":"https://api.github.com/users/fiigii/orgs","repos_url":"https://api.github.com/users/fiigii/repos","events_url":"https://api.github.com/users/fiigii/events{/privacy}","received_events_url":"https://api.github.com/users/fiigii/received_events","type":"User","site_admin":false},"body":"> It introduces additional flag HW_Flag_UnfixedNumArgs which is not necessary \r\n\r\nYes, I just feel it more reliable, not strongly.","created_at":"2018-03-01T23:53:28Z","updated_at":"2018-03-01T23:53:28Z","html_url":"https://github.com/dotnet/coreclr/pull/15777#discussion_r171730956","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/15777","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/171730956"},"html":{"href":"https://github.com/dotnet/coreclr/pull/15777#discussion_r171730956"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/15777"}},"in_reply_to_id":171663941},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/15777","id":161528741,"html_url":"https://github.com/dotnet/coreclr/pull/15777","diff_url":"https://github.com/dotnet/coreclr/pull/15777.diff","patch_url":"https://github.com/dotnet/coreclr/pull/15777.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/15777","number":15777,"state":"open","locked":false,"title":"Implement Shuffle* Sse2 Intel hardware intrinsics ","user":{"login":"4creators","id":801959,"avatar_url":"https://avatars0.githubusercontent.com/u/801959?v=4","gravatar_id":"","url":"https://api.github.com/users/4creators","html_url":"https://github.com/4creators","followers_url":"https://api.github.com/users/4creators/followers","following_url":"https://api.github.com/users/4creators/following{/other_user}","gists_url":"https://api.github.com/users/4creators/gists{/gist_id}","starred_url":"https://api.github.com/users/4creators/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4creators/subscriptions","organizations_url":"https://api.github.com/users/4creators/orgs","repos_url":"https://api.github.com/users/4creators/repos","events_url":"https://api.github.com/users/4creators/events{/privacy}","received_events_url":"https://api.github.com/users/4creators/received_events","type":"User","site_admin":false},"body":"\r\n  ","created_at":"2018-01-07T16:32:25Z","updated_at":"2018-03-01T23:53:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0fe2a8432ec9f74337ac3392b986c466832bc988","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":196940911,"url":"https://api.github.com/repos/dotnet/coreclr/labels/area-CodeGen","name":"area-CodeGen","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/15777/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/15777/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/15777/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/579a41cdf868d0cfba5bff071c782da0c59d1e0f","head":{"label":"dotnetrt:sse2part2","ref":"sse2part2","sha":"579a41cdf868d0cfba5bff071c782da0c59d1e0f","user":{"login":"dotnetrt","id":30407351,"avatar_url":"https://avatars1.githubusercontent.com/u/30407351?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnetrt","html_url":"https://github.com/dotnetrt","followers_url":"https://api.github.com/users/dotnetrt/followers","following_url":"https://api.github.com/users/dotnetrt/following{/other_user}","gists_url":"https://api.github.com/users/dotnetrt/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnetrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnetrt/subscriptions","organizations_url":"https://api.github.com/users/dotnetrt/orgs","repos_url":"https://api.github.com/users/dotnetrt/repos","events_url":"https://api.github.com/users/dotnetrt/events{/privacy}","received_events_url":"https://api.github.com/users/dotnetrt/received_events","type":"Organization","site_admin":false},"repo":{"id":114872050,"name":"coreclr","full_name":"dotnetrt/coreclr","owner":{"login":"dotnetrt","id":30407351,"avatar_url":"https://avatars1.githubusercontent.com/u/30407351?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnetrt","html_url":"https://github.com/dotnetrt","followers_url":"https://api.github.com/users/dotnetrt/followers","following_url":"https://api.github.com/users/dotnetrt/following{/other_user}","gists_url":"https://api.github.com/users/dotnetrt/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnetrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnetrt/subscriptions","organizations_url":"https://api.github.com/users/dotnetrt/orgs","repos_url":"https://api.github.com/users/dotnetrt/repos","events_url":"https://api.github.com/users/dotnetrt/events{/privacy}","received_events_url":"https://api.github.com/users/dotnetrt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnetrt/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called System.Private.Corelib (or mscorlib). It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes. We welcome contributions.","fork":true,"url":"https://api.github.com/repos/dotnetrt/coreclr","forks_url":"https://api.github.com/repos/dotnetrt/coreclr/forks","keys_url":"https://api.github.com/repos/dotnetrt/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnetrt/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnetrt/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnetrt/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnetrt/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnetrt/coreclr/events","assignees_url":"https://api.github.com/repos/dotnetrt/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnetrt/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnetrt/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnetrt/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnetrt/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnetrt/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnetrt/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnetrt/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnetrt/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnetrt/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnetrt/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnetrt/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnetrt/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnetrt/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnetrt/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnetrt/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnetrt/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnetrt/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnetrt/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnetrt/coreclr/merges","archive_url":"https://api.github.com/repos/dotnetrt/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnetrt/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnetrt/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnetrt/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnetrt/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnetrt/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnetrt/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnetrt/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnetrt/coreclr/deployments","created_at":"2017-12-20T10:03:18Z","updated_at":"2017-12-20T10:04:28Z","pushed_at":"2018-03-01T23:47:08Z","git_url":"git://github.com/dotnetrt/coreclr.git","ssh_url":"git@github.com:dotnetrt/coreclr.git","clone_url":"https://github.com/dotnetrt/coreclr.git","svn_url":"https://github.com/dotnetrt/coreclr","homepage":"https://github.com/dotnet/core","size":209908,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"e93926660c0e1f0aad452ced770e5859e49b1060","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called System.Private.Corelib (or mscorlib). It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2018-03-01T21:42:54Z","pushed_at":"2018-03-01T23:51:42Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://github.com/dotnet/core","size":209538,"stargazers_count":8998,"watchers_count":8998,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2261,"mirror_url":null,"archived":false,"open_issues_count":1573,"license":null,"forks":2261,"open_issues":1573,"watchers":8998,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/15777"},"html":{"href":"https://github.com/dotnet/coreclr/pull/15777"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/15777"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/15777/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/15777/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/15777/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/579a41cdf868d0cfba5bff071c782da0c59d1e0f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fiigii"}}