{"action":"created","issue":{"url":"https://api.github.com/repos/SergeyChernonog/ProgTechJava2018/issues/5","repository_url":"https://api.github.com/repos/SergeyChernonog/ProgTechJava2018","labels_url":"https://api.github.com/repos/SergeyChernonog/ProgTechJava2018/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/SergeyChernonog/ProgTechJava2018/issues/5/comments","events_url":"https://api.github.com/repos/SergeyChernonog/ProgTechJava2018/issues/5/events","html_url":"https://github.com/SergeyChernonog/ProgTechJava2018/issues/5","id":298634390,"number":5,"title":"Upgrade tests","user":{"login":"JohnKhandygo","id":2545754,"avatar_url":"https://avatars3.githubusercontent.com/u/2545754?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnKhandygo","html_url":"https://github.com/JohnKhandygo","followers_url":"https://api.github.com/users/JohnKhandygo/followers","following_url":"https://api.github.com/users/JohnKhandygo/following{/other_user}","gists_url":"https://api.github.com/users/JohnKhandygo/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnKhandygo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnKhandygo/subscriptions","organizations_url":"https://api.github.com/users/JohnKhandygo/orgs","repos_url":"https://api.github.com/users/JohnKhandygo/repos","events_url":"https://api.github.com/users/JohnKhandygo/events{/privacy}","received_events_url":"https://api.github.com/users/JohnKhandygo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-20T15:23:27Z","updated_at":"2018-03-08T14:59:09Z","closed_at":null,"author_association":"NONE","body":"Тесты не покрывают некоторые случаи использования AdressBook (например, работа с полностью пустым AdressBook). При этом тест https://github.com/SergeyChernonog/ProgTechJava2018/blob/be477f6eade4abf2c8e554757ff797315b4f2c62/test/AddressBook/AddressBookTest.java#L24 по факту не тестирует ничего: Вы просто проверяете, что одинаковая модификация над одинаковыми объектами дают одинаковые объекты. Суть операции добавления в том, что добавленый объект затем может быть извлечен, и именно это надо проверить. Подобная шутка встречается в тестах достаточно часто."},"comment":{"url":"https://api.github.com/repos/SergeyChernonog/ProgTechJava2018/issues/comments/371511899","html_url":"https://github.com/SergeyChernonog/ProgTechJava2018/issues/5#issuecomment-371511899","issue_url":"https://api.github.com/repos/SergeyChernonog/ProgTechJava2018/issues/5","id":371511899,"user":{"login":"JohnKhandygo","id":2545754,"avatar_url":"https://avatars3.githubusercontent.com/u/2545754?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnKhandygo","html_url":"https://github.com/JohnKhandygo","followers_url":"https://api.github.com/users/JohnKhandygo/followers","following_url":"https://api.github.com/users/JohnKhandygo/following{/other_user}","gists_url":"https://api.github.com/users/JohnKhandygo/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnKhandygo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnKhandygo/subscriptions","organizations_url":"https://api.github.com/users/JohnKhandygo/orgs","repos_url":"https://api.github.com/users/JohnKhandygo/repos","events_url":"https://api.github.com/users/JohnKhandygo/events{/privacy}","received_events_url":"https://api.github.com/users/JohnKhandygo/received_events","type":"User","site_admin":false},"created_at":"2018-03-08T14:59:09Z","updated_at":"2018-03-08T14:59:09Z","author_association":"NONE","body":"Честно говоря, тесты не стали выглядеть сильно лучше. Попробуйте сделать их более атомарными, то есть такими, чтобы каждый тестовый метод покрывал один конкретный вариант использования."}}
{"actor":{"display_login":"JohnKhandygo"}}