{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/8969","repository_url":"https://api.github.com/repos/WordPress/gutenberg","labels_url":"https://api.github.com/repos/WordPress/gutenberg/issues/8969/labels{/name}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/8969/comments","events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/8969/events","html_url":"https://github.com/WordPress/gutenberg/pull/8969","id":350389934,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MjUxNjUy","number":8969,"title":"feat: Show sidebar in HTML edit mode for blocks","user":{"login":"tofumatt","id":90871,"node_id":"MDQ6VXNlcjkwODcx","avatar_url":"https://avatars2.githubusercontent.com/u/90871?v=4","gravatar_id":"","url":"https://api.github.com/users/tofumatt","html_url":"https://github.com/tofumatt","followers_url":"https://api.github.com/users/tofumatt/followers","following_url":"https://api.github.com/users/tofumatt/following{/other_user}","gists_url":"https://api.github.com/users/tofumatt/gists{/gist_id}","starred_url":"https://api.github.com/users/tofumatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tofumatt/subscriptions","organizations_url":"https://api.github.com/users/tofumatt/orgs","repos_url":"https://api.github.com/users/tofumatt/repos","events_url":"https://api.github.com/users/tofumatt/events{/privacy}","received_events_url":"https://api.github.com/users/tofumatt/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"tofumatt","id":90871,"node_id":"MDQ6VXNlcjkwODcx","avatar_url":"https://avatars2.githubusercontent.com/u/90871?v=4","gravatar_id":"","url":"https://api.github.com/users/tofumatt","html_url":"https://github.com/tofumatt","followers_url":"https://api.github.com/users/tofumatt/followers","following_url":"https://api.github.com/users/tofumatt/following{/other_user}","gists_url":"https://api.github.com/users/tofumatt/gists{/gist_id}","starred_url":"https://api.github.com/users/tofumatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tofumatt/subscriptions","organizations_url":"https://api.github.com/users/tofumatt/orgs","repos_url":"https://api.github.com/users/tofumatt/repos","events_url":"https://api.github.com/users/tofumatt/events{/privacy}","received_events_url":"https://api.github.com/users/tofumatt/received_events","type":"User","site_admin":false},"assignees":[{"login":"tofumatt","id":90871,"node_id":"MDQ6VXNlcjkwODcx","avatar_url":"https://avatars2.githubusercontent.com/u/90871?v=4","gravatar_id":"","url":"https://api.github.com/users/tofumatt","html_url":"https://github.com/tofumatt","followers_url":"https://api.github.com/users/tofumatt/followers","following_url":"https://api.github.com/users/tofumatt/following{/other_user}","gists_url":"https://api.github.com/users/tofumatt/gists{/gist_id}","starred_url":"https://api.github.com/users/tofumatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tofumatt/subscriptions","organizations_url":"https://api.github.com/users/tofumatt/orgs","repos_url":"https://api.github.com/users/tofumatt/repos","events_url":"https://api.github.com/users/tofumatt/events{/privacy}","received_events_url":"https://api.github.com/users/tofumatt/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/WordPress/gutenberg/milestones/61","html_url":"https://github.com/WordPress/gutenberg/milestone/61","labels_url":"https://api.github.com/repos/WordPress/gutenberg/milestones/61/labels","id":3554642,"node_id":"MDk6TWlsZXN0b25lMzU1NDY0Mg==","number":61,"title":"3.6","description":"","creator":{"login":"gziolo","id":699132,"node_id":"MDQ6VXNlcjY5OTEzMg==","avatar_url":"https://avatars2.githubusercontent.com/u/699132?v=4","gravatar_id":"","url":"https://api.github.com/users/gziolo","html_url":"https://github.com/gziolo","followers_url":"https://api.github.com/users/gziolo/followers","following_url":"https://api.github.com/users/gziolo/following{/other_user}","gists_url":"https://api.github.com/users/gziolo/gists{/gist_id}","starred_url":"https://api.github.com/users/gziolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gziolo/subscriptions","organizations_url":"https://api.github.com/users/gziolo/orgs","repos_url":"https://api.github.com/users/gziolo/repos","events_url":"https://api.github.com/users/gziolo/events{/privacy}","received_events_url":"https://api.github.com/users/gziolo/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":62,"state":"open","created_at":"2018-08-08T07:19:57Z","updated_at":"2018-08-16T16:43:54Z","due_on":"2018-08-16T07:00:00Z","closed_at":null},"comments":16,"created_at":"2018-08-14T11:34:26Z","updated_at":"2018-08-16T16:45:46Z","closed_at":"2018-08-16T16:43:54Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/WordPress/gutenberg/pulls/8969","html_url":"https://github.com/WordPress/gutenberg/pull/8969","diff_url":"https://github.com/WordPress/gutenberg/pull/8969.diff","patch_url":"https://github.com/WordPress/gutenberg/pull/8969.patch"},"body":"## Description\r\nFix #4413.\r\n\r\nWhen editing a block in HTML, the sidebar inspector controls would disappear because `BlockEdit` was not rendered–and `BlockEdit` contains the `InspectorControls` slot fill content for a block. This changes `BlockEdit` to always render, even in HTML mode, but be hidden when editing via HTML.\r\n\r\nI tried for a better way but it wasn't immediately apparent how to do that.\r\n\r\nI also tried for a more fluid updating of the block during HTML content editing, but this would cause issues with block validation mid-change. It might take some time to edit a block's HTML and during the edit it might appear externally modified even if the eventual change would be valid. So we don't update the `core/editor`/Redux state until `onBlur`, as we did before. This means things like an image's `alt` text property, being edited in HTML, won't be reflected in real-time in the sidebar inspector controls, though the sidebar's changes will be reflected in real-time in HTML. Once you click over to the sidebar though, the changes will appear, so there are no race conditions/missing content. It just doesn't look as fluid as I'd like, but the alternative is a very buggy experience.\r\n\r\n-----\r\n\r\nIt would be great to test a fair number of blocks with this to make sure it doesn't break anything or have a really janky UX anywhere.\r\n\r\n## How has this been tested?\r\nWrote e2e tests to ensure they're visible and tested this for a fair few blocks in Firefox, Chrome, and IE 11. I observed some weirdness with paragraph blocks but it's unrelated to this change and I think caused by #8950.\r\n\r\n## Screenshots\r\n\r\n### Before\r\n![2018-08-14 12 36 34](https://user-images.githubusercontent.com/90871/44089482-d644c162-9fbe-11e8-9ef3-de7ca99b71bc.gif)\r\n\r\n### After\r\n![2018-08-14 12 31 56](https://user-images.githubusercontent.com/90871/44089321-48b0841c-9fbe-11e8-8458-e73a1a083360.gif)\r\n\r\n## Types of changes\r\nNew feature.\r\n\r\n## Checklist:\r\n- [x] My code is tested.\r\n- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->\r\n- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->\r\n- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->"},"comment":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments/413610735","html_url":"https://github.com/WordPress/gutenberg/pull/8969#issuecomment-413610735","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/8969","id":413610735,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzYxMDczNQ==","user":{"login":"youknowriad","id":272444,"node_id":"MDQ6VXNlcjI3MjQ0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/272444?v=4","gravatar_id":"","url":"https://api.github.com/users/youknowriad","html_url":"https://github.com/youknowriad","followers_url":"https://api.github.com/users/youknowriad/followers","following_url":"https://api.github.com/users/youknowriad/following{/other_user}","gists_url":"https://api.github.com/users/youknowriad/gists{/gist_id}","starred_url":"https://api.github.com/users/youknowriad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youknowriad/subscriptions","organizations_url":"https://api.github.com/users/youknowriad/orgs","repos_url":"https://api.github.com/users/youknowriad/repos","events_url":"https://api.github.com/users/youknowriad/events{/privacy}","received_events_url":"https://api.github.com/users/youknowriad/received_events","type":"User","site_admin":false},"created_at":"2018-08-16T16:45:46Z","updated_at":"2018-08-16T16:45:46Z","author_association":"CONTRIBUTOR","body":"I just \"squashed\" your PR @tofumatt :P "}}
{"actor":{"display_login":"youknowriad"}}