{"action":"created","comment":{"url":"https://api.github.com/repos/tijhuisingenieurs/gistools/pulls/comments/165293677","pull_request_review_id":93206588,"id":165293677,"diff_hunk":"@@ -423,8 +425,52 @@ def fielddata_to_memcollections(filename, profile_plan_col=None, profile_id_fiel\n \n             log.warning('records toegevoegd %i', i + 1)\n \n+    # Extract fixed points from the geojson\n+    for fp_pk, point_ids in enumerate(json_dict['point_notes']):\n+\n+        fp = json_dict['point_notes'][point_ids]\n+        fixed_point = OrderedDict()\n+\n+        fixed_point['vp_pk'] = fp_pk\n+        fixed_point['ids'] = fp.get('id', '')\n+        fixed_point['project_id'] = project_id\n+        fixed_point['proj_name'] = proj_name\n+        fixed_point['type'] = fp.get('note_type', '')\n+        fixed_point['opm'] = fp.get('remarks', '').replace('\\n', '')\n+\n+        photo_list = fp.get('photos', None)\n+        photo_string = ''\n+\n+        if photo_list:\n+            for i in range(len(photo_list)):\n+                f_name = os.path.basename(photo_list[i]).split('.')[0]\n+                if i != (len(photo_list) - 1):\n+                    photo_string = photo_string + (f_name + \";\")\n+                else:\n+                    photo_string = photo_string + f_name\n+\n+        fixed_point['fotos'] = photo_string\n+\n+        fixed_point['datum'] = fp.get('datetime', '')\n+\n+        if fp.get('rd_coordinates') and not None in fp.get('rd_coordinates')[:2]:\n+            rd_coordinates = fp.get('rd_coordinates')\n+            fixed_point['x_coord'] = get_float(rd_coordinates[0])\n+            fixed_point['y_coord'] = get_float(rd_coordinates[1])\n+            if rd_coordinates[2] and rd_coordinates[2] != -99:\n+                fixed_point['z'] = get_float(rd_coordinates[2])\n+            else:\n+                fixed_point['z'] = -9999\n+            coordinates = (rd_coordinates[0], rd_coordinates[1])\n+","path":"tools/load_veldwerk_json.py","position":57,"original_position":66,"commit_id":"542d22861af2b2f9fd1102c7f15b7a43f764ae1a","original_commit_id":"9453fd661b1167120abd1b569b882c8bb0194d13","user":{"login":"bastiaan-roos","id":1068991,"avatar_url":"https://avatars3.githubusercontent.com/u/1068991?v=4","gravatar_id":"","url":"https://api.github.com/users/bastiaan-roos","html_url":"https://github.com/bastiaan-roos","followers_url":"https://api.github.com/users/bastiaan-roos/followers","following_url":"https://api.github.com/users/bastiaan-roos/following{/other_user}","gists_url":"https://api.github.com/users/bastiaan-roos/gists{/gist_id}","starred_url":"https://api.github.com/users/bastiaan-roos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bastiaan-roos/subscriptions","organizations_url":"https://api.github.com/users/bastiaan-roos/orgs","repos_url":"https://api.github.com/users/bastiaan-roos/repos","events_url":"https://api.github.com/users/bastiaan-roos/events{/privacy}","received_events_url":"https://api.github.com/users/bastiaan-roos/received_events","type":"User","site_admin":false},"body":"is inderdaad niet mooi. QGIS kan bijvoorbeeld omgaan met None waarden, maar arcGIS niet.\r\nz = null kan voorkomen als ze een punt op de kaart kiezen x en y kunnen null zijn als een punt wordt toegevoegd, terwijl er nog geen gps punt is ontvangen.\r\n","created_at":"2018-02-01T09:11:00Z","updated_at":"2018-02-01T09:11:00Z","html_url":"https://github.com/tijhuisingenieurs/gistools/pull/69#discussion_r165293677","pull_request_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/pulls/69","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/tijhuisingenieurs/gistools/pulls/comments/165293677"},"html":{"href":"https://github.com/tijhuisingenieurs/gistools/pull/69#discussion_r165293677"},"pull_request":{"href":"https://api.github.com/repos/tijhuisingenieurs/gistools/pulls/69"}},"in_reply_to_id":164992150},"pull_request":{"url":"https://api.github.com/repos/tijhuisingenieurs/gistools/pulls/69","id":165998412,"html_url":"https://github.com/tijhuisingenieurs/gistools/pull/69","diff_url":"https://github.com/tijhuisingenieurs/gistools/pull/69.diff","patch_url":"https://github.com/tijhuisingenieurs/gistools/pull/69.patch","issue_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/issues/69","number":69,"state":"open","locked":false,"title":"Tool 3a1","user":{"login":"elinevanelburg","id":33683617,"avatar_url":"https://avatars2.githubusercontent.com/u/33683617?v=4","gravatar_id":"","url":"https://api.github.com/users/elinevanelburg","html_url":"https://github.com/elinevanelburg","followers_url":"https://api.github.com/users/elinevanelburg/followers","following_url":"https://api.github.com/users/elinevanelburg/following{/other_user}","gists_url":"https://api.github.com/users/elinevanelburg/gists{/gist_id}","starred_url":"https://api.github.com/users/elinevanelburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elinevanelburg/subscriptions","organizations_url":"https://api.github.com/users/elinevanelburg/orgs","repos_url":"https://api.github.com/users/elinevanelburg/repos","events_url":"https://api.github.com/users/elinevanelburg/events{/privacy}","received_events_url":"https://api.github.com/users/elinevanelburg/received_events","type":"User","site_admin":false},"body":"Ik vind dit script behoorlijk ingewikkeld, vandaar dat ik even een review vraag. Ik heb nog niet alle wijzigingen verwerkt, eigenlijk alleen ervoor gezorgd dat de vaste punten naar een eigen shapefile worden uitgeschreven.","created_at":"2018-01-30T14:38:37Z","updated_at":"2018-02-01T09:11:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9cbb5f5442d46d001aa0e34718f79b79d6ee83fa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/pulls/69/commits","review_comments_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/pulls/69/comments","review_comment_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/issues/69/comments","statuses_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/statuses/542d22861af2b2f9fd1102c7f15b7a43f764ae1a","head":{"label":"tijhuisingenieurs:tool_3a1","ref":"tool_3a1","sha":"542d22861af2b2f9fd1102c7f15b7a43f764ae1a","user":{"login":"tijhuisingenieurs","id":25586205,"avatar_url":"https://avatars3.githubusercontent.com/u/25586205?v=4","gravatar_id":"","url":"https://api.github.com/users/tijhuisingenieurs","html_url":"https://github.com/tijhuisingenieurs","followers_url":"https://api.github.com/users/tijhuisingenieurs/followers","following_url":"https://api.github.com/users/tijhuisingenieurs/following{/other_user}","gists_url":"https://api.github.com/users/tijhuisingenieurs/gists{/gist_id}","starred_url":"https://api.github.com/users/tijhuisingenieurs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tijhuisingenieurs/subscriptions","organizations_url":"https://api.github.com/users/tijhuisingenieurs/orgs","repos_url":"https://api.github.com/users/tijhuisingenieurs/repos","events_url":"https://api.github.com/users/tijhuisingenieurs/events{/privacy}","received_events_url":"https://api.github.com/users/tijhuisingenieurs/received_events","type":"Organization","site_admin":false},"repo":{"id":81089958,"name":"gistools","full_name":"tijhuisingenieurs/gistools","owner":{"login":"tijhuisingenieurs","id":25586205,"avatar_url":"https://avatars3.githubusercontent.com/u/25586205?v=4","gravatar_id":"","url":"https://api.github.com/users/tijhuisingenieurs","html_url":"https://github.com/tijhuisingenieurs","followers_url":"https://api.github.com/users/tijhuisingenieurs/followers","following_url":"https://api.github.com/users/tijhuisingenieurs/following{/other_user}","gists_url":"https://api.github.com/users/tijhuisingenieurs/gists{/gist_id}","starred_url":"https://api.github.com/users/tijhuisingenieurs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tijhuisingenieurs/subscriptions","organizations_url":"https://api.github.com/users/tijhuisingenieurs/orgs","repos_url":"https://api.github.com/users/tijhuisingenieurs/repos","events_url":"https://api.github.com/users/tijhuisingenieurs/events{/privacy}","received_events_url":"https://api.github.com/users/tijhuisingenieurs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tijhuisingenieurs/gistools","description":"Several GIS tools","fork":false,"url":"https://api.github.com/repos/tijhuisingenieurs/gistools","forks_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/forks","keys_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/teams","hooks_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/hooks","issue_events_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/issues/events{/number}","events_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/events","assignees_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/assignees{/user}","branches_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/branches{/branch}","tags_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/tags","blobs_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/git/refs{/sha}","trees_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/statuses/{sha}","languages_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/languages","stargazers_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/stargazers","contributors_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/contributors","subscribers_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/subscribers","subscription_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/subscription","commits_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/commits{/sha}","git_commits_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/git/commits{/sha}","comments_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/comments{/number}","issue_comment_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/issues/comments{/number}","contents_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/contents/{+path}","compare_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/merges","archive_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/downloads","issues_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/issues{/number}","pulls_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/pulls{/number}","milestones_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/milestones{/number}","notifications_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/labels{/name}","releases_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/releases{/id}","deployments_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/deployments","created_at":"2017-02-06T13:30:00Z","updated_at":"2017-04-19T13:23:54Z","pushed_at":"2018-02-01T09:05:26Z","git_url":"git://github.com/tijhuisingenieurs/gistools.git","ssh_url":"git@github.com:tijhuisingenieurs/gistools.git","clone_url":"https://github.com/tijhuisingenieurs/gistools.git","svn_url":"https://github.com/tijhuisingenieurs/gistools","homepage":null,"size":587,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"tijhuisingenieurs:master","ref":"master","sha":"fb4b962f410453869fbde44b6a4f6f4c39df6ff6","user":{"login":"tijhuisingenieurs","id":25586205,"avatar_url":"https://avatars3.githubusercontent.com/u/25586205?v=4","gravatar_id":"","url":"https://api.github.com/users/tijhuisingenieurs","html_url":"https://github.com/tijhuisingenieurs","followers_url":"https://api.github.com/users/tijhuisingenieurs/followers","following_url":"https://api.github.com/users/tijhuisingenieurs/following{/other_user}","gists_url":"https://api.github.com/users/tijhuisingenieurs/gists{/gist_id}","starred_url":"https://api.github.com/users/tijhuisingenieurs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tijhuisingenieurs/subscriptions","organizations_url":"https://api.github.com/users/tijhuisingenieurs/orgs","repos_url":"https://api.github.com/users/tijhuisingenieurs/repos","events_url":"https://api.github.com/users/tijhuisingenieurs/events{/privacy}","received_events_url":"https://api.github.com/users/tijhuisingenieurs/received_events","type":"Organization","site_admin":false},"repo":{"id":81089958,"name":"gistools","full_name":"tijhuisingenieurs/gistools","owner":{"login":"tijhuisingenieurs","id":25586205,"avatar_url":"https://avatars3.githubusercontent.com/u/25586205?v=4","gravatar_id":"","url":"https://api.github.com/users/tijhuisingenieurs","html_url":"https://github.com/tijhuisingenieurs","followers_url":"https://api.github.com/users/tijhuisingenieurs/followers","following_url":"https://api.github.com/users/tijhuisingenieurs/following{/other_user}","gists_url":"https://api.github.com/users/tijhuisingenieurs/gists{/gist_id}","starred_url":"https://api.github.com/users/tijhuisingenieurs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tijhuisingenieurs/subscriptions","organizations_url":"https://api.github.com/users/tijhuisingenieurs/orgs","repos_url":"https://api.github.com/users/tijhuisingenieurs/repos","events_url":"https://api.github.com/users/tijhuisingenieurs/events{/privacy}","received_events_url":"https://api.github.com/users/tijhuisingenieurs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tijhuisingenieurs/gistools","description":"Several GIS tools","fork":false,"url":"https://api.github.com/repos/tijhuisingenieurs/gistools","forks_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/forks","keys_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/teams","hooks_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/hooks","issue_events_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/issues/events{/number}","events_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/events","assignees_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/assignees{/user}","branches_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/branches{/branch}","tags_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/tags","blobs_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/git/refs{/sha}","trees_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/statuses/{sha}","languages_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/languages","stargazers_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/stargazers","contributors_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/contributors","subscribers_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/subscribers","subscription_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/subscription","commits_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/commits{/sha}","git_commits_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/git/commits{/sha}","comments_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/comments{/number}","issue_comment_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/issues/comments{/number}","contents_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/contents/{+path}","compare_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/merges","archive_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/downloads","issues_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/issues{/number}","pulls_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/pulls{/number}","milestones_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/milestones{/number}","notifications_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/labels{/name}","releases_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/releases{/id}","deployments_url":"https://api.github.com/repos/tijhuisingenieurs/gistools/deployments","created_at":"2017-02-06T13:30:00Z","updated_at":"2017-04-19T13:23:54Z","pushed_at":"2018-02-01T09:05:26Z","git_url":"git://github.com/tijhuisingenieurs/gistools.git","ssh_url":"git@github.com:tijhuisingenieurs/gistools.git","clone_url":"https://github.com/tijhuisingenieurs/gistools.git","svn_url":"https://github.com/tijhuisingenieurs/gistools","homepage":null,"size":587,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tijhuisingenieurs/gistools/pulls/69"},"html":{"href":"https://github.com/tijhuisingenieurs/gistools/pull/69"},"issue":{"href":"https://api.github.com/repos/tijhuisingenieurs/gistools/issues/69"},"comments":{"href":"https://api.github.com/repos/tijhuisingenieurs/gistools/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/tijhuisingenieurs/gistools/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/tijhuisingenieurs/gistools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tijhuisingenieurs/gistools/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/tijhuisingenieurs/gistools/statuses/542d22861af2b2f9fd1102c7f15b7a43f764ae1a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bastiaan-roos"}}