{"action":"created","comment":{"url":"https://api.github.com/repos/louisdh/terminal/pulls/comments/166417570","pull_request_review_id":94476386,"id":166417570,"diff_hunk":"@@ -592,12 +636,16 @@\n \t\t\t\tCODE_SIGN_ENTITLEMENTS = OpenTerm/OpenTerm.entitlements;\n \t\t\t\t\"CODE_SIGN_IDENTITY[sdk=iphoneos*]\" = \"iPhone Developer\";\n \t\t\t\tCODE_SIGN_STYLE = Automatic;\n-                DEVELOPMENT_TEAM = 6G5LMQ72D8;\n+\t\t\t\tDEVELOPMENT_TEAM = VG8Z23C8YL;\n \t\t\t\tENABLE_BITCODE = NO;\n+\t\t\t\tFRAMEWORK_SEARCH_PATHS = (\n+\t\t\t\t\t\"$(inherited)\",\n+\t\t\t\t\t\"$(PROJECT_DIR)/Dependencies\",\n+\t\t\t\t);\n \t\t\t\tINFOPLIST_FILE = \"$(SRCROOT)/OpenTerm/Info.plist\";\n \t\t\t\tIPHONEOS_DEPLOYMENT_TARGET = 11.0;\n \t\t\t\tLD_RUNPATH_SEARCH_PATHS = \"$(inherited) @executable_path/Frameworks\";\n-                PRODUCT_BUNDLE_IDENTIFIER = com.silverfox.Terminal;\n+\t\t\t\tPRODUCT_BUNDLE_IDENTIFIER = \"Nicolas-Holzschuch-OpenTerm\";","path":"OpenTerm.xcodeproj/project.pbxproj","position":112,"original_position":112,"commit_id":"54d1135aad1b1e560dce529a59689c90ebd91e42","original_commit_id":"54d1135aad1b1e560dce529a59689c90ebd91e42","user":{"login":"louisdh","id":1129119,"avatar_url":"https://avatars0.githubusercontent.com/u/1129119?v=4","gravatar_id":"","url":"https://api.github.com/users/louisdh","html_url":"https://github.com/louisdh","followers_url":"https://api.github.com/users/louisdh/followers","following_url":"https://api.github.com/users/louisdh/following{/other_user}","gists_url":"https://api.github.com/users/louisdh/gists{/gist_id}","starred_url":"https://api.github.com/users/louisdh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louisdh/subscriptions","organizations_url":"https://api.github.com/users/louisdh/orgs","repos_url":"https://api.github.com/users/louisdh/repos","events_url":"https://api.github.com/users/louisdh/events{/privacy}","received_events_url":"https://api.github.com/users/louisdh/received_events","type":"User","site_admin":false},"body":"Please don't change the bundle identifier.","created_at":"2018-02-06T19:32:29Z","updated_at":"2018-02-06T19:33:49Z","html_url":"https://github.com/louisdh/terminal/pull/63#discussion_r166417570","pull_request_url":"https://api.github.com/repos/louisdh/terminal/pulls/63","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/louisdh/terminal/pulls/comments/166417570"},"html":{"href":"https://github.com/louisdh/terminal/pull/63#discussion_r166417570"},"pull_request":{"href":"https://api.github.com/repos/louisdh/terminal/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/louisdh/terminal/pulls/63","id":166606181,"html_url":"https://github.com/louisdh/terminal/pull/63","diff_url":"https://github.com/louisdh/terminal/pull/63.diff","patch_url":"https://github.com/louisdh/terminal/pull/63.patch","issue_url":"https://api.github.com/repos/louisdh/terminal/issues/63","number":63,"state":"open","locked":false,"title":"Moving iOS_system to dynamic libraries","user":{"login":"holzschu","id":8070736,"avatar_url":"https://avatars3.githubusercontent.com/u/8070736?v=4","gravatar_id":"","url":"https://api.github.com/users/holzschu","html_url":"https://github.com/holzschu","followers_url":"https://api.github.com/users/holzschu/followers","following_url":"https://api.github.com/users/holzschu/following{/other_user}","gists_url":"https://api.github.com/users/holzschu/gists{/gist_id}","starred_url":"https://api.github.com/users/holzschu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holzschu/subscriptions","organizations_url":"https://api.github.com/users/holzschu/orgs","repos_url":"https://api.github.com/users/holzschu/repos","events_url":"https://api.github.com/users/holzschu/events{/privacy}","received_events_url":"https://api.github.com/users/holzschu/received_events","type":"User","site_admin":false},"body":"As suggested by @IMcD23, all of ios_system is now based on dynamic libraries.\r\nVisible impact on OpenTerm: null (for the time being). The dynamic libraries (lib*.dylib) must be compiled (one target each) and embedded, but do not need to be linked with the main program. Only iOS_system.framework needs to be linked. Adding/removing functionalities is done by adding/removing dynamic libraries, with no impact on the project file (easier to merge / add future functions). \r\n\r\nPro: smaller memory footprint, faster launch.\r\nPro: easier to add new commands without having to change the Xcode project.\r\nCon: swift functions must be mangled in order to be called by ios_system. Not impossible, but not exactly easy to read either.\r\nCon: must add 7 dynamic libraries to the list of embedded libraries, +2 if you want Lua and Python, +6 if you want TeX.\r\n\r\nAdded bonus: two new commands, getoptString() and operatesOn(). Both take a command as argument. \r\ngetoptString() returns the string that is sent to getopt(), that is the list of flags accepted by the command. For \"rm\", that would be \"dfiPRrvW\". \r\noperatesOn() returns what the command expects as arguments: \"file\", \"directory\" or \"no\". \r\n\r\n2nd bonus: a #define, SIDELOADING, which avoids defining commands that don't make sense on the app store: chgrp, chown, df... (I kept the existing list, but if we start writing scripts, we will need to make chmod available).\r\n\r\n3rd bonus: Slight modifications to stdout in CommandExecutor.swift so commands know whether they're in a window or in a pipe, and react accordingly. ","created_at":"2018-02-01T17:44:01Z","updated_at":"2018-02-06T19:33:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9af218cd554fb0c60720709f711ad7a99c5e5ffd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/louisdh/terminal/pulls/63/commits","review_comments_url":"https://api.github.com/repos/louisdh/terminal/pulls/63/comments","review_comment_url":"https://api.github.com/repos/louisdh/terminal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/louisdh/terminal/issues/63/comments","statuses_url":"https://api.github.com/repos/louisdh/terminal/statuses/54d1135aad1b1e560dce529a59689c90ebd91e42","head":{"label":"holzschu:master","ref":"master","sha":"54d1135aad1b1e560dce529a59689c90ebd91e42","user":{"login":"holzschu","id":8070736,"avatar_url":"https://avatars3.githubusercontent.com/u/8070736?v=4","gravatar_id":"","url":"https://api.github.com/users/holzschu","html_url":"https://github.com/holzschu","followers_url":"https://api.github.com/users/holzschu/followers","following_url":"https://api.github.com/users/holzschu/following{/other_user}","gists_url":"https://api.github.com/users/holzschu/gists{/gist_id}","starred_url":"https://api.github.com/users/holzschu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holzschu/subscriptions","organizations_url":"https://api.github.com/users/holzschu/orgs","repos_url":"https://api.github.com/users/holzschu/repos","events_url":"https://api.github.com/users/holzschu/events{/privacy}","received_events_url":"https://api.github.com/users/holzschu/received_events","type":"User","site_admin":false},"repo":{"id":116574603,"name":"terminal","full_name":"holzschu/terminal","owner":{"login":"holzschu","id":8070736,"avatar_url":"https://avatars3.githubusercontent.com/u/8070736?v=4","gravatar_id":"","url":"https://api.github.com/users/holzschu","html_url":"https://github.com/holzschu","followers_url":"https://api.github.com/users/holzschu/followers","following_url":"https://api.github.com/users/holzschu/following{/other_user}","gists_url":"https://api.github.com/users/holzschu/gists{/gist_id}","starred_url":"https://api.github.com/users/holzschu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holzschu/subscriptions","organizations_url":"https://api.github.com/users/holzschu/orgs","repos_url":"https://api.github.com/users/holzschu/repos","events_url":"https://api.github.com/users/holzschu/events{/privacy}","received_events_url":"https://api.github.com/users/holzschu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/holzschu/terminal","description":"A sandboxed command line interface for iOS","fork":true,"url":"https://api.github.com/repos/holzschu/terminal","forks_url":"https://api.github.com/repos/holzschu/terminal/forks","keys_url":"https://api.github.com/repos/holzschu/terminal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holzschu/terminal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holzschu/terminal/teams","hooks_url":"https://api.github.com/repos/holzschu/terminal/hooks","issue_events_url":"https://api.github.com/repos/holzschu/terminal/issues/events{/number}","events_url":"https://api.github.com/repos/holzschu/terminal/events","assignees_url":"https://api.github.com/repos/holzschu/terminal/assignees{/user}","branches_url":"https://api.github.com/repos/holzschu/terminal/branches{/branch}","tags_url":"https://api.github.com/repos/holzschu/terminal/tags","blobs_url":"https://api.github.com/repos/holzschu/terminal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holzschu/terminal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holzschu/terminal/git/refs{/sha}","trees_url":"https://api.github.com/repos/holzschu/terminal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holzschu/terminal/statuses/{sha}","languages_url":"https://api.github.com/repos/holzschu/terminal/languages","stargazers_url":"https://api.github.com/repos/holzschu/terminal/stargazers","contributors_url":"https://api.github.com/repos/holzschu/terminal/contributors","subscribers_url":"https://api.github.com/repos/holzschu/terminal/subscribers","subscription_url":"https://api.github.com/repos/holzschu/terminal/subscription","commits_url":"https://api.github.com/repos/holzschu/terminal/commits{/sha}","git_commits_url":"https://api.github.com/repos/holzschu/terminal/git/commits{/sha}","comments_url":"https://api.github.com/repos/holzschu/terminal/comments{/number}","issue_comment_url":"https://api.github.com/repos/holzschu/terminal/issues/comments{/number}","contents_url":"https://api.github.com/repos/holzschu/terminal/contents/{+path}","compare_url":"https://api.github.com/repos/holzschu/terminal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holzschu/terminal/merges","archive_url":"https://api.github.com/repos/holzschu/terminal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holzschu/terminal/downloads","issues_url":"https://api.github.com/repos/holzschu/terminal/issues{/number}","pulls_url":"https://api.github.com/repos/holzschu/terminal/pulls{/number}","milestones_url":"https://api.github.com/repos/holzschu/terminal/milestones{/number}","notifications_url":"https://api.github.com/repos/holzschu/terminal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holzschu/terminal/labels{/name}","releases_url":"https://api.github.com/repos/holzschu/terminal/releases{/id}","deployments_url":"https://api.github.com/repos/holzschu/terminal/deployments","created_at":"2018-01-07T15:03:09Z","updated_at":"2018-01-14T07:12:34Z","pushed_at":"2018-02-03T06:49:50Z","git_url":"git://github.com/holzschu/terminal.git","ssh_url":"git@github.com:holzschu/terminal.git","clone_url":"https://github.com/holzschu/terminal.git","svn_url":"https://github.com/holzschu/terminal","homepage":null,"size":22986,"stargazers_count":1,"watchers_count":1,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"louisdh:master","ref":"master","sha":"6b19b79d1d18c3ca03bac3e7f07627a254d57b6f","user":{"login":"louisdh","id":1129119,"avatar_url":"https://avatars0.githubusercontent.com/u/1129119?v=4","gravatar_id":"","url":"https://api.github.com/users/louisdh","html_url":"https://github.com/louisdh","followers_url":"https://api.github.com/users/louisdh/followers","following_url":"https://api.github.com/users/louisdh/following{/other_user}","gists_url":"https://api.github.com/users/louisdh/gists{/gist_id}","starred_url":"https://api.github.com/users/louisdh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louisdh/subscriptions","organizations_url":"https://api.github.com/users/louisdh/orgs","repos_url":"https://api.github.com/users/louisdh/repos","events_url":"https://api.github.com/users/louisdh/events{/privacy}","received_events_url":"https://api.github.com/users/louisdh/received_events","type":"User","site_admin":false},"repo":{"id":116499200,"name":"terminal","full_name":"louisdh/terminal","owner":{"login":"louisdh","id":1129119,"avatar_url":"https://avatars0.githubusercontent.com/u/1129119?v=4","gravatar_id":"","url":"https://api.github.com/users/louisdh","html_url":"https://github.com/louisdh","followers_url":"https://api.github.com/users/louisdh/followers","following_url":"https://api.github.com/users/louisdh/following{/other_user}","gists_url":"https://api.github.com/users/louisdh/gists{/gist_id}","starred_url":"https://api.github.com/users/louisdh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louisdh/subscriptions","organizations_url":"https://api.github.com/users/louisdh/orgs","repos_url":"https://api.github.com/users/louisdh/repos","events_url":"https://api.github.com/users/louisdh/events{/privacy}","received_events_url":"https://api.github.com/users/louisdh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/louisdh/terminal","description":"OpenTerm, a sandboxed command line interface for iOS","fork":false,"url":"https://api.github.com/repos/louisdh/terminal","forks_url":"https://api.github.com/repos/louisdh/terminal/forks","keys_url":"https://api.github.com/repos/louisdh/terminal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/louisdh/terminal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/louisdh/terminal/teams","hooks_url":"https://api.github.com/repos/louisdh/terminal/hooks","issue_events_url":"https://api.github.com/repos/louisdh/terminal/issues/events{/number}","events_url":"https://api.github.com/repos/louisdh/terminal/events","assignees_url":"https://api.github.com/repos/louisdh/terminal/assignees{/user}","branches_url":"https://api.github.com/repos/louisdh/terminal/branches{/branch}","tags_url":"https://api.github.com/repos/louisdh/terminal/tags","blobs_url":"https://api.github.com/repos/louisdh/terminal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/louisdh/terminal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/louisdh/terminal/git/refs{/sha}","trees_url":"https://api.github.com/repos/louisdh/terminal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/louisdh/terminal/statuses/{sha}","languages_url":"https://api.github.com/repos/louisdh/terminal/languages","stargazers_url":"https://api.github.com/repos/louisdh/terminal/stargazers","contributors_url":"https://api.github.com/repos/louisdh/terminal/contributors","subscribers_url":"https://api.github.com/repos/louisdh/terminal/subscribers","subscription_url":"https://api.github.com/repos/louisdh/terminal/subscription","commits_url":"https://api.github.com/repos/louisdh/terminal/commits{/sha}","git_commits_url":"https://api.github.com/repos/louisdh/terminal/git/commits{/sha}","comments_url":"https://api.github.com/repos/louisdh/terminal/comments{/number}","issue_comment_url":"https://api.github.com/repos/louisdh/terminal/issues/comments{/number}","contents_url":"https://api.github.com/repos/louisdh/terminal/contents/{+path}","compare_url":"https://api.github.com/repos/louisdh/terminal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/louisdh/terminal/merges","archive_url":"https://api.github.com/repos/louisdh/terminal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/louisdh/terminal/downloads","issues_url":"https://api.github.com/repos/louisdh/terminal/issues{/number}","pulls_url":"https://api.github.com/repos/louisdh/terminal/pulls{/number}","milestones_url":"https://api.github.com/repos/louisdh/terminal/milestones{/number}","notifications_url":"https://api.github.com/repos/louisdh/terminal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/louisdh/terminal/labels{/name}","releases_url":"https://api.github.com/repos/louisdh/terminal/releases{/id}","deployments_url":"https://api.github.com/repos/louisdh/terminal/deployments","created_at":"2018-01-06T16:47:23Z","updated_at":"2018-02-06T14:34:11Z","pushed_at":"2018-02-06T19:26:26Z","git_url":"git://github.com/louisdh/terminal.git","ssh_url":"git@github.com:louisdh/terminal.git","clone_url":"https://github.com/louisdh/terminal.git","svn_url":"https://github.com/louisdh/terminal","homepage":"","size":22899,"stargazers_count":761,"watchers_count":761,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":55,"open_issues":29,"watchers":761,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/louisdh/terminal/pulls/63"},"html":{"href":"https://github.com/louisdh/terminal/pull/63"},"issue":{"href":"https://api.github.com/repos/louisdh/terminal/issues/63"},"comments":{"href":"https://api.github.com/repos/louisdh/terminal/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/louisdh/terminal/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/louisdh/terminal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/louisdh/terminal/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/louisdh/terminal/statuses/54d1135aad1b1e560dce529a59689c90ebd91e42"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"louisdh"}}