{"action":"created","comment":{"url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments/215398514","pull_request_review_id":152654537,"id":215398514,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTM5ODUxNA==","diff_hunk":"@@ -0,0 +1,93 @@\n+﻿using System.Collections.Generic;\n+using Generated.Playground;\n+using Improbable.Gdk.Core;\n+using Improbable.Gdk.Core.Commands;\n+using Improbable.Gdk.Core.GameObjectRepresentation;\n+using Improbable.Worker.Core;\n+using UnityEngine;\n+\n+#region Diagnostic control\n+\n+// Disable the \"variable is never assigned\" for injected fields.\n+#pragma warning disable 649\n+\n+#endregion\n+\n+namespace Playground.MonoBehaviours\n+{\n+    public class DeleteCubeCommandReceiver : MonoBehaviour\n+    {\n+        [Require] private CubeSpawner.Requirables.CommandRequestHandler commandRequestHandler;\n+        [Require] private CubeSpawner.Requirables.Writer writer;\n+        [Require] private WorldCommands.Requirables.WorldCommandRequestSender worldCommandRequestSender;\n+        [Require] private WorldCommands.Requirables.WorldCommandResponseHandler worldCommandResponseHandler;\n+\n+        private ILogDispatcher logDispatcher;\n+        private const string CouldNotDeleteEntityWithId = \"Could not delete entity with id {0}: {1}.\";\n+\n+        private const string TheEntityHasBeenUnexpectedlyRemovedFromTheList =\n+            \"The entity {0} has been unexpectedly removed from the list.\";\n+\n+        private readonly HashSet<long> sentRequestIds = new HashSet<long>();\n+\n+        public void OnEnable()\n+        {\n+            logDispatcher = GetComponent<SpatialOSComponent>().LogDispatcher;\n+            commandRequestHandler.OnDeleteSpawnedCubeRequest += OnDeleteSpawnedCubeRequest;\n+            worldCommandResponseHandler.OnDeleteEntityResponse += OnDeleteEntityResponse;\n+        }\n+\n+        private void OnDeleteSpawnedCubeRequest(CubeSpawner.DeleteSpawnedCube.RequestResponder requestResponder)","path":"workers/unity/Assets/Playground/Scripts/MonoBehaviours/DeleteCubeCommandReceiver.cs","position":40,"original_position":40,"commit_id":"195793644ebe88630e0953727bbccceeddac08f2","original_commit_id":"195793644ebe88630e0953727bbccceeddac08f2","user":{"login":"samiwh","id":14006669,"node_id":"MDQ6VXNlcjE0MDA2NjY5","avatar_url":"https://avatars0.githubusercontent.com/u/14006669?v=4","gravatar_id":"","url":"https://api.github.com/users/samiwh","html_url":"https://github.com/samiwh","followers_url":"https://api.github.com/users/samiwh/followers","following_url":"https://api.github.com/users/samiwh/following{/other_user}","gists_url":"https://api.github.com/users/samiwh/gists{/gist_id}","starred_url":"https://api.github.com/users/samiwh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samiwh/subscriptions","organizations_url":"https://api.github.com/users/samiwh/orgs","repos_url":"https://api.github.com/users/samiwh/repos","events_url":"https://api.github.com/users/samiwh/events{/privacy}","received_events_url":"https://api.github.com/users/samiwh/received_events","type":"User","site_admin":false},"body":"I confused this with the pre-existing types when reading this. Which means it will also cause confusion for which you are meant to use elsewhere. Also I got very confused about the lack of something to send the response when everything else has one.","created_at":"2018-09-05T19:31:57Z","updated_at":"2018-09-05T19:31:57Z","html_url":"https://github.com/spatialos/UnityGDK/pull/321#discussion_r215398514","pull_request_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/321","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments/215398514"},"html":{"href":"https://github.com/spatialos/UnityGDK/pull/321#discussion_r215398514"},"pull_request":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/321"}},"in_reply_to_id":215397742},"pull_request":{"url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/321","id":213386708,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMzg2NzA4","html_url":"https://github.com/spatialos/UnityGDK/pull/321","diff_url":"https://github.com/spatialos/UnityGDK/pull/321.diff","patch_url":"https://github.com/spatialos/UnityGDK/pull/321.patch","issue_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/321","number":321,"state":"open","locked":false,"title":"Demonstrate example usage for world commands","user":{"login":"firtina-improbable","id":31209570,"node_id":"MDQ6VXNlcjMxMjA5NTcw","avatar_url":"https://avatars1.githubusercontent.com/u/31209570?v=4","gravatar_id":"","url":"https://api.github.com/users/firtina-improbable","html_url":"https://github.com/firtina-improbable","followers_url":"https://api.github.com/users/firtina-improbable/followers","following_url":"https://api.github.com/users/firtina-improbable/following{/other_user}","gists_url":"https://api.github.com/users/firtina-improbable/gists{/gist_id}","starred_url":"https://api.github.com/users/firtina-improbable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firtina-improbable/subscriptions","organizations_url":"https://api.github.com/users/firtina-improbable/orgs","repos_url":"https://api.github.com/users/firtina-improbable/repos","events_url":"https://api.github.com/users/firtina-improbable/events{/privacy}","received_events_url":"https://api.github.com/users/firtina-improbable/received_events","type":"User","site_admin":false},"body":"**Contributions**: We are not currently taking public contributions - see our [contributions](CONTRIBUTING.md) policy. However, we are accepting issues and we do want your [feedback](../README.md#give-us-feedback).\r\n\r\n-------\r\n\r\n#### Description\r\nAdds example usage for entity reservation, creation and deletion\r\n\r\n![cube-spawning](https://user-images.githubusercontent.com/31209570/44998265-0355f200-afac-11e8-9057-c0deb22ce93c.gif)\r\n\r\n#### Tests\r\nThese are the tests for playground\r\n\r\n#### Primary reviewers\r\nIf your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.\r\n\r\n@MPeti01 + one non-monobehaviour team person","created_at":"2018-09-05T18:26:56Z","updated_at":"2018-09-05T19:31:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1512798c983a82ddf681144de341e6f97175c06b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"MPeti01","id":25401316,"node_id":"MDQ6VXNlcjI1NDAxMzE2","avatar_url":"https://avatars1.githubusercontent.com/u/25401316?v=4","gravatar_id":"","url":"https://api.github.com/users/MPeti01","html_url":"https://github.com/MPeti01","followers_url":"https://api.github.com/users/MPeti01/followers","following_url":"https://api.github.com/users/MPeti01/following{/other_user}","gists_url":"https://api.github.com/users/MPeti01/gists{/gist_id}","starred_url":"https://api.github.com/users/MPeti01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MPeti01/subscriptions","organizations_url":"https://api.github.com/users/MPeti01/orgs","repos_url":"https://api.github.com/users/MPeti01/repos","events_url":"https://api.github.com/users/MPeti01/events{/privacy}","received_events_url":"https://api.github.com/users/MPeti01/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":999948057,"node_id":"MDU6TGFiZWw5OTk5NDgwNTc=","url":"https://api.github.com/repos/spatialos/UnityGDK/labels/size/XL","name":"size/XL","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/321/commits","review_comments_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/321/comments","review_comment_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/321/comments","statuses_url":"https://api.github.com/repos/spatialos/UnityGDK/statuses/195793644ebe88630e0953727bbccceeddac08f2","head":{"label":"spatialos:feature/UTY-1064/world-commands-example-usage","ref":"feature/UTY-1064/world-commands-example-usage","sha":"195793644ebe88630e0953727bbccceeddac08f2","user":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"repo":{"id":137235993,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyMzU5OTM=","name":"UnityGDK","full_name":"spatialos/UnityGDK","owner":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spatialos/UnityGDK","description":"Unity GDK","fork":false,"url":"https://api.github.com/repos/spatialos/UnityGDK","forks_url":"https://api.github.com/repos/spatialos/UnityGDK/forks","keys_url":"https://api.github.com/repos/spatialos/UnityGDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spatialos/UnityGDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spatialos/UnityGDK/teams","hooks_url":"https://api.github.com/repos/spatialos/UnityGDK/hooks","issue_events_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/events{/number}","events_url":"https://api.github.com/repos/spatialos/UnityGDK/events","assignees_url":"https://api.github.com/repos/spatialos/UnityGDK/assignees{/user}","branches_url":"https://api.github.com/repos/spatialos/UnityGDK/branches{/branch}","tags_url":"https://api.github.com/repos/spatialos/UnityGDK/tags","blobs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spatialos/UnityGDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/spatialos/UnityGDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spatialos/UnityGDK/statuses/{sha}","languages_url":"https://api.github.com/repos/spatialos/UnityGDK/languages","stargazers_url":"https://api.github.com/repos/spatialos/UnityGDK/stargazers","contributors_url":"https://api.github.com/repos/spatialos/UnityGDK/contributors","subscribers_url":"https://api.github.com/repos/spatialos/UnityGDK/subscribers","subscription_url":"https://api.github.com/repos/spatialos/UnityGDK/subscription","commits_url":"https://api.github.com/repos/spatialos/UnityGDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/spatialos/UnityGDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/spatialos/UnityGDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/spatialos/UnityGDK/contents/{+path}","compare_url":"https://api.github.com/repos/spatialos/UnityGDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spatialos/UnityGDK/merges","archive_url":"https://api.github.com/repos/spatialos/UnityGDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spatialos/UnityGDK/downloads","issues_url":"https://api.github.com/repos/spatialos/UnityGDK/issues{/number}","pulls_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls{/number}","milestones_url":"https://api.github.com/repos/spatialos/UnityGDK/milestones{/number}","notifications_url":"https://api.github.com/repos/spatialos/UnityGDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spatialos/UnityGDK/labels{/name}","releases_url":"https://api.github.com/repos/spatialos/UnityGDK/releases{/id}","deployments_url":"https://api.github.com/repos/spatialos/UnityGDK/deployments","created_at":"2018-06-13T15:37:54Z","updated_at":"2018-09-05T19:17:02Z","pushed_at":"2018-09-05T19:24:43Z","git_url":"git://github.com/spatialos/UnityGDK.git","ssh_url":"git@github.com:spatialos/UnityGDK.git","clone_url":"https://github.com/spatialos/UnityGDK.git","svn_url":"https://github.com/spatialos/UnityGDK","homepage":null,"size":290281,"stargazers_count":83,"watchers_count":83,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":15,"watchers":83,"default_branch":"master"}},"base":{"label":"spatialos:feature/UTY-1064/world-commands-v2","ref":"feature/UTY-1064/world-commands-v2","sha":"f44757257c591b7c794ff48ebc59d6a938456b55","user":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"repo":{"id":137235993,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyMzU5OTM=","name":"UnityGDK","full_name":"spatialos/UnityGDK","owner":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spatialos/UnityGDK","description":"Unity GDK","fork":false,"url":"https://api.github.com/repos/spatialos/UnityGDK","forks_url":"https://api.github.com/repos/spatialos/UnityGDK/forks","keys_url":"https://api.github.com/repos/spatialos/UnityGDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spatialos/UnityGDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spatialos/UnityGDK/teams","hooks_url":"https://api.github.com/repos/spatialos/UnityGDK/hooks","issue_events_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/events{/number}","events_url":"https://api.github.com/repos/spatialos/UnityGDK/events","assignees_url":"https://api.github.com/repos/spatialos/UnityGDK/assignees{/user}","branches_url":"https://api.github.com/repos/spatialos/UnityGDK/branches{/branch}","tags_url":"https://api.github.com/repos/spatialos/UnityGDK/tags","blobs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spatialos/UnityGDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/spatialos/UnityGDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spatialos/UnityGDK/statuses/{sha}","languages_url":"https://api.github.com/repos/spatialos/UnityGDK/languages","stargazers_url":"https://api.github.com/repos/spatialos/UnityGDK/stargazers","contributors_url":"https://api.github.com/repos/spatialos/UnityGDK/contributors","subscribers_url":"https://api.github.com/repos/spatialos/UnityGDK/subscribers","subscription_url":"https://api.github.com/repos/spatialos/UnityGDK/subscription","commits_url":"https://api.github.com/repos/spatialos/UnityGDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/spatialos/UnityGDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/spatialos/UnityGDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/spatialos/UnityGDK/contents/{+path}","compare_url":"https://api.github.com/repos/spatialos/UnityGDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spatialos/UnityGDK/merges","archive_url":"https://api.github.com/repos/spatialos/UnityGDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spatialos/UnityGDK/downloads","issues_url":"https://api.github.com/repos/spatialos/UnityGDK/issues{/number}","pulls_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls{/number}","milestones_url":"https://api.github.com/repos/spatialos/UnityGDK/milestones{/number}","notifications_url":"https://api.github.com/repos/spatialos/UnityGDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spatialos/UnityGDK/labels{/name}","releases_url":"https://api.github.com/repos/spatialos/UnityGDK/releases{/id}","deployments_url":"https://api.github.com/repos/spatialos/UnityGDK/deployments","created_at":"2018-06-13T15:37:54Z","updated_at":"2018-09-05T19:17:02Z","pushed_at":"2018-09-05T19:24:43Z","git_url":"git://github.com/spatialos/UnityGDK.git","ssh_url":"git@github.com:spatialos/UnityGDK.git","clone_url":"https://github.com/spatialos/UnityGDK.git","svn_url":"https://github.com/spatialos/UnityGDK","homepage":null,"size":290281,"stargazers_count":83,"watchers_count":83,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":15,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/321"},"html":{"href":"https://github.com/spatialos/UnityGDK/pull/321"},"issue":{"href":"https://api.github.com/repos/spatialos/UnityGDK/issues/321"},"comments":{"href":"https://api.github.com/repos/spatialos/UnityGDK/issues/321/comments"},"review_comments":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/321/comments"},"review_comment":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/321/commits"},"statuses":{"href":"https://api.github.com/repos/spatialos/UnityGDK/statuses/195793644ebe88630e0953727bbccceeddac08f2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"samiwh"}}