{"action":"created","issue":{"url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/2137","repository_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push","labels_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/2137/labels{/name}","comments_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/2137/comments","events_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/2137/events","html_url":"https://github.com/phonegap/phonegap-plugin-push/pull/2137","id":286803109,"node_id":"MDExOlB1bGxSZXF1ZXN0MTYxNjY5MTMy","number":2137,"title":"🐛 Issue #2052: ServiceWorker.js Folder Instead of File","user":{"login":"macdonst","id":353180,"node_id":"MDQ6VXNlcjM1MzE4MA==","avatar_url":"https://avatars1.githubusercontent.com/u/353180?v=4","gravatar_id":"","url":"https://api.github.com/users/macdonst","html_url":"https://github.com/macdonst","followers_url":"https://api.github.com/users/macdonst/followers","following_url":"https://api.github.com/users/macdonst/following{/other_user}","gists_url":"https://api.github.com/users/macdonst/gists{/gist_id}","starred_url":"https://api.github.com/users/macdonst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macdonst/subscriptions","organizations_url":"https://api.github.com/users/macdonst/orgs","repos_url":"https://api.github.com/users/macdonst/repos","events_url":"https://api.github.com/users/macdonst/events{/privacy}","received_events_url":"https://api.github.com/users/macdonst/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"audreyso","id":22332296,"node_id":"MDQ6VXNlcjIyMzMyMjk2","avatar_url":"https://avatars0.githubusercontent.com/u/22332296?v=4","gravatar_id":"","url":"https://api.github.com/users/audreyso","html_url":"https://github.com/audreyso","followers_url":"https://api.github.com/users/audreyso/followers","following_url":"https://api.github.com/users/audreyso/following{/other_user}","gists_url":"https://api.github.com/users/audreyso/gists{/gist_id}","starred_url":"https://api.github.com/users/audreyso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/audreyso/subscriptions","organizations_url":"https://api.github.com/users/audreyso/orgs","repos_url":"https://api.github.com/users/audreyso/repos","events_url":"https://api.github.com/users/audreyso/events{/privacy}","received_events_url":"https://api.github.com/users/audreyso/received_events","type":"User","site_admin":false},"assignees":[{"login":"audreyso","id":22332296,"node_id":"MDQ6VXNlcjIyMzMyMjk2","avatar_url":"https://avatars0.githubusercontent.com/u/22332296?v=4","gravatar_id":"","url":"https://api.github.com/users/audreyso","html_url":"https://github.com/audreyso","followers_url":"https://api.github.com/users/audreyso/followers","following_url":"https://api.github.com/users/audreyso/following{/other_user}","gists_url":"https://api.github.com/users/audreyso/gists{/gist_id}","starred_url":"https://api.github.com/users/audreyso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/audreyso/subscriptions","organizations_url":"https://api.github.com/users/audreyso/orgs","repos_url":"https://api.github.com/users/audreyso/repos","events_url":"https://api.github.com/users/audreyso/events{/privacy}","received_events_url":"https://api.github.com/users/audreyso/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-01-08T16:29:35Z","updated_at":"2018-06-03T00:34:26Z","closed_at":"2018-02-28T18:40:07Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/pulls/2137","html_url":"https://github.com/phonegap/phonegap-plugin-push/pull/2137","diff_url":"https://github.com/phonegap/phonegap-plugin-push/pull/2137.diff","patch_url":"https://github.com/phonegap/phonegap-plugin-push/pull/2137.patch"},"body":"Trying to update plugin.xml/package.json to require at least cordova-plugin 5.0.3 or greater.\r\n\r\nHowever, when I do I get the following error:\r\n\r\n```\r\nInstalling \"phonegap-plugin-push\" for browser\r\n(node:7614) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): code: engine.platform or engine.scriptSrc is not defined in custom engine \"cordova-browser\" from plugin \"phonegap-plugin-push\" for browser warn\r\n```\r\n\r\nlooking into the code I think the root cause of the problem is that there is no `cordova-browser` in:\r\n\r\nhttps://github.com/apache/cordova-lib/blob/master/src/plugman/util/default-engines.js\r\n\r\nWhy?"},"comment":{"url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/comments/394126533","html_url":"https://github.com/phonegap/phonegap-plugin-push/pull/2137#issuecomment-394126533","issue_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/2137","id":394126533,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDEyNjUzMw==","user":{"login":"lock[bot]","id":33595554,"node_id":"MDM6Qm90MzM1OTU1NTQ=","avatar_url":"https://avatars1.githubusercontent.com/in/6672?v=4","gravatar_id":"","url":"https://api.github.com/users/lock%5Bbot%5D","html_url":"https://github.com/apps/lock","followers_url":"https://api.github.com/users/lock%5Bbot%5D/followers","following_url":"https://api.github.com/users/lock%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/lock%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/lock%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lock%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/lock%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/lock%5Bbot%5D/repos","events_url":"https://api.github.com/users/lock%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/lock%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-06-03T00:34:26Z","updated_at":"2018-06-03T00:34:26Z","author_association":"NONE","body":"This thread has been automatically locked."}}
{"actor":{"display_login":"lock"}}