{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/172849531","pull_request_review_id":101936214,"id":172849531,"diff_hunk":"@@ -16,7 +16,7 @@ def assert_dashboard_link(text)\n     within \"li[data-name='Host Configuration Status']\" do\n       click_link(text)\n     end\n-    assert_current_path hosts_path, :only_path => true\n+    assert_current_path hosts_path, :ignore_query => true","path":"test/integration/dashboard_test.rb","position":5,"original_position":5,"commit_id":"286767ba9b30849ea16ddbce5527254e3d65f2c7","original_commit_id":"08750d05746d2f98c84b1a4ad39b3916eec6651b","user":{"login":"tbrisker","id":1540531,"avatar_url":"https://avatars2.githubusercontent.com/u/1540531?v=4","gravatar_id":"","url":"https://api.github.com/users/tbrisker","html_url":"https://github.com/tbrisker","followers_url":"https://api.github.com/users/tbrisker/followers","following_url":"https://api.github.com/users/tbrisker/following{/other_user}","gists_url":"https://api.github.com/users/tbrisker/gists{/gist_id}","starred_url":"https://api.github.com/users/tbrisker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbrisker/subscriptions","organizations_url":"https://api.github.com/users/tbrisker/orgs","repos_url":"https://api.github.com/users/tbrisker/repos","events_url":"https://api.github.com/users/tbrisker/events{/privacy}","received_events_url":"https://api.github.com/users/tbrisker/received_events","type":"User","site_admin":false},"body":"no need afaict for `:ignore_query` here, `:only_path => true` is simply redundant on *_path helpers.","created_at":"2018-03-07T14:01:07Z","updated_at":"2018-03-07T14:02:39Z","html_url":"https://github.com/theforeman/foreman/pull/5250#discussion_r172849531","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/5250","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/172849531"},"html":{"href":"https://github.com/theforeman/foreman/pull/5250#discussion_r172849531"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/5250"}},"in_reply_to_id":168177021},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/5250","id":168947006,"html_url":"https://github.com/theforeman/foreman/pull/5250","diff_url":"https://github.com/theforeman/foreman/pull/5250.diff","patch_url":"https://github.com/theforeman/foreman/pull/5250.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/5250","number":5250,"state":"open","locked":false,"title":"Fixes #22575 - Clean up test report","user":{"login":"imtayadeway","id":1710874,"avatar_url":"https://avatars2.githubusercontent.com/u/1710874?v=4","gravatar_id":"","url":"https://api.github.com/users/imtayadeway","html_url":"https://github.com/imtayadeway","followers_url":"https://api.github.com/users/imtayadeway/followers","following_url":"https://api.github.com/users/imtayadeway/following{/other_user}","gists_url":"https://api.github.com/users/imtayadeway/gists{/gist_id}","starred_url":"https://api.github.com/users/imtayadeway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imtayadeway/subscriptions","organizations_url":"https://api.github.com/users/imtayadeway/orgs","repos_url":"https://api.github.com/users/imtayadeway/repos","events_url":"https://api.github.com/users/imtayadeway/events{/privacy}","received_events_url":"https://api.github.com/users/imtayadeway/received_events","type":"User","site_admin":false},"body":"This addresses most of the issues resulting in a noisy test report. This is probably best viewed as individual commits for an explanation of each issue. All but one deprecation notices were removed - the remaining one appears to be coming from Fog's internals so cannot be addressed here.\r\n\r\n<!---\r\n\r\nThank you for contributing to The Foreman, please read the\r\n[following guide](https://www.theforeman.org/contribute.html), in short:\r\n\r\n* [Create an issue](https://projects.theforeman.org/projects/foreman/issues)\r\n* Reference the issue via `Fixes #1234` or `Refs #1234` in the commit message\r\n* Prefer present-tense, imperative-style commit messages\r\n* Extract all strings for i18n, see [Translating section in the guide]\r\n(https://projects.theforeman.org/projects/foreman/wiki/Translating)\r\n* Prepend `[WIP]` for work in progress from bots triggering actions\r\n* Be patient, we will do our best to take a look as soon as we can\r\n* Explain the purpose of the PR, attach screenshots if applicable\r\n* Be nice and respectful\r\n\r\nWe are running bots that will poke you if you miss an item from the list :-)\r\n\r\n--->\r\n","created_at":"2018-02-13T20:25:05Z","updated_at":"2018-03-07T14:02:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b97fb3f093e772c11a23009d9d2cd0eb254153d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":79040160,"url":"https://api.github.com/repos/theforeman/foreman/labels/Needs%20re-review","name":"Needs re-review","color":"0052cc","default":false},{"id":79040689,"url":"https://api.github.com/repos/theforeman/foreman/labels/Needs%20testing","name":"Needs testing","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/5250/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/5250/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/5250/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/286767ba9b30849ea16ddbce5527254e3d65f2c7","head":{"label":"imtayadeway:clean-up-test-report","ref":"clean-up-test-report","sha":"286767ba9b30849ea16ddbce5527254e3d65f2c7","user":{"login":"imtayadeway","id":1710874,"avatar_url":"https://avatars2.githubusercontent.com/u/1710874?v=4","gravatar_id":"","url":"https://api.github.com/users/imtayadeway","html_url":"https://github.com/imtayadeway","followers_url":"https://api.github.com/users/imtayadeway/followers","following_url":"https://api.github.com/users/imtayadeway/following{/other_user}","gists_url":"https://api.github.com/users/imtayadeway/gists{/gist_id}","starred_url":"https://api.github.com/users/imtayadeway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imtayadeway/subscriptions","organizations_url":"https://api.github.com/users/imtayadeway/orgs","repos_url":"https://api.github.com/users/imtayadeway/repos","events_url":"https://api.github.com/users/imtayadeway/events{/privacy}","received_events_url":"https://api.github.com/users/imtayadeway/received_events","type":"User","site_admin":false},"repo":{"id":120641899,"name":"foreman","full_name":"imtayadeway/foreman","owner":{"login":"imtayadeway","id":1710874,"avatar_url":"https://avatars2.githubusercontent.com/u/1710874?v=4","gravatar_id":"","url":"https://api.github.com/users/imtayadeway","html_url":"https://github.com/imtayadeway","followers_url":"https://api.github.com/users/imtayadeway/followers","following_url":"https://api.github.com/users/imtayadeway/following{/other_user}","gists_url":"https://api.github.com/users/imtayadeway/gists{/gist_id}","starred_url":"https://api.github.com/users/imtayadeway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imtayadeway/subscriptions","organizations_url":"https://api.github.com/users/imtayadeway/orgs","repos_url":"https://api.github.com/users/imtayadeway/repos","events_url":"https://api.github.com/users/imtayadeway/events{/privacy}","received_events_url":"https://api.github.com/users/imtayadeway/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/imtayadeway/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/imtayadeway/foreman","forks_url":"https://api.github.com/repos/imtayadeway/foreman/forks","keys_url":"https://api.github.com/repos/imtayadeway/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/imtayadeway/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/imtayadeway/foreman/teams","hooks_url":"https://api.github.com/repos/imtayadeway/foreman/hooks","issue_events_url":"https://api.github.com/repos/imtayadeway/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/imtayadeway/foreman/events","assignees_url":"https://api.github.com/repos/imtayadeway/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/imtayadeway/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/imtayadeway/foreman/tags","blobs_url":"https://api.github.com/repos/imtayadeway/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/imtayadeway/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/imtayadeway/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/imtayadeway/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/imtayadeway/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/imtayadeway/foreman/languages","stargazers_url":"https://api.github.com/repos/imtayadeway/foreman/stargazers","contributors_url":"https://api.github.com/repos/imtayadeway/foreman/contributors","subscribers_url":"https://api.github.com/repos/imtayadeway/foreman/subscribers","subscription_url":"https://api.github.com/repos/imtayadeway/foreman/subscription","commits_url":"https://api.github.com/repos/imtayadeway/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/imtayadeway/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/imtayadeway/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/imtayadeway/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/imtayadeway/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/imtayadeway/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/imtayadeway/foreman/merges","archive_url":"https://api.github.com/repos/imtayadeway/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/imtayadeway/foreman/downloads","issues_url":"https://api.github.com/repos/imtayadeway/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/imtayadeway/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/imtayadeway/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/imtayadeway/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/imtayadeway/foreman/labels{/name}","releases_url":"https://api.github.com/repos/imtayadeway/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/imtayadeway/foreman/deployments","created_at":"2018-02-07T16:37:40Z","updated_at":"2018-02-07T16:37:46Z","pushed_at":"2018-03-02T18:36:20Z","git_url":"git://github.com/imtayadeway/foreman.git","ssh_url":"git@github.com:imtayadeway/foreman.git","clone_url":"https://github.com/imtayadeway/foreman.git","svn_url":"https://github.com/imtayadeway/foreman","homepage":"http://theforeman.org","size":69014,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"fb9ed6a21cc25d269563306d5566e18fc82be31e","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars2.githubusercontent.com/u/1439844?v=4","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars2.githubusercontent.com/u/1439844?v=4","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/foreman/deployments","created_at":"2009-07-23T15:07:00Z","updated_at":"2018-03-07T05:37:13Z","pushed_at":"2018-03-07T13:44:12Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":70320,"stargazers_count":1384,"watchers_count":1384,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":701,"mirror_url":null,"archived":false,"open_issues_count":115,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":701,"open_issues":115,"watchers":1384,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/5250"},"html":{"href":"https://github.com/theforeman/foreman/pull/5250"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/5250"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/5250/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/5250/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/5250/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/286767ba9b30849ea16ddbce5527254e3d65f2c7"}},"author_association":"NONE"}}
{"actor":{"display_login":"tbrisker"}}