{"action":"closed","number":3340,"pull_request":{"url":"https://api.github.com/repos/i3/i3/pulls/3340","id":204621270,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NjIxMjcw","html_url":"https://github.com/i3/i3/pull/3340","diff_url":"https://github.com/i3/i3/pull/3340.diff","patch_url":"https://github.com/i3/i3/pull/3340.patch","issue_url":"https://api.github.com/repos/i3/i3/issues/3340","number":3340,"state":"closed","locked":false,"title":"fix height offset calculation in pango text drawing","user":{"login":"PandorasFox","id":3235827,"node_id":"MDQ6VXNlcjMyMzU4Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/3235827?v=4","gravatar_id":"","url":"https://api.github.com/users/PandorasFox","html_url":"https://github.com/PandorasFox","followers_url":"https://api.github.com/users/PandorasFox/followers","following_url":"https://api.github.com/users/PandorasFox/following{/other_user}","gists_url":"https://api.github.com/users/PandorasFox/gists{/gist_id}","starred_url":"https://api.github.com/users/PandorasFox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PandorasFox/subscriptions","organizations_url":"https://api.github.com/users/PandorasFox/orgs","repos_url":"https://api.github.com/users/PandorasFox/repos","events_url":"https://api.github.com/users/PandorasFox/events{/privacy}","received_events_url":"https://api.github.com/users/PandorasFox/received_events","type":"User","site_admin":false},"body":"* difference is zero: dividing by two does nothing (that's fine)\r\n* difference is positive: halve the difference, subtract it from the height to center it\r\n* difference is negative: `abs` it, then do the same as above.\r\n\r\nWorks fine on my fresh laptop; dunno about older pango versions. I'm not exactly sure about what changed with things that are larger than given height.\r\n\r\nUnless I'm mistaken, this shouldn't affect anything where `height <= savedFont->height`. This just changes the previous case of subtracting the (positive) height difference when something was too tall (and thus shifting everything a decent amount above the bar canvas).\r\n\r\nThis handles it *well enough* for the case \"text too tall\". I'm not really sure if there's a \"good\" solution for this, since it's usually just one glyph that's messing up the height.\r\n\r\nFixes #3114","created_at":"2018-07-29T02:46:21Z","updated_at":"2018-07-29T10:10:27Z","closed_at":"2018-07-29T10:10:27Z","merged_at":"2018-07-29T10:10:27Z","merge_commit_sha":"715cea61af33b3600d2fc1e921126359a5629932","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/i3/i3/pulls/3340/commits","review_comments_url":"https://api.github.com/repos/i3/i3/pulls/3340/comments","review_comment_url":"https://api.github.com/repos/i3/i3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/i3/i3/issues/3340/comments","statuses_url":"https://api.github.com/repos/i3/i3/statuses/ad236dbaec4fc8fa0d35f80b1d0be640b68ae6ce","head":{"label":"PandorasFox:next","ref":"next","sha":"ad236dbaec4fc8fa0d35f80b1d0be640b68ae6ce","user":{"login":"PandorasFox","id":3235827,"node_id":"MDQ6VXNlcjMyMzU4Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/3235827?v=4","gravatar_id":"","url":"https://api.github.com/users/PandorasFox","html_url":"https://github.com/PandorasFox","followers_url":"https://api.github.com/users/PandorasFox/followers","following_url":"https://api.github.com/users/PandorasFox/following{/other_user}","gists_url":"https://api.github.com/users/PandorasFox/gists{/gist_id}","starred_url":"https://api.github.com/users/PandorasFox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PandorasFox/subscriptions","organizations_url":"https://api.github.com/users/PandorasFox/orgs","repos_url":"https://api.github.com/users/PandorasFox/repos","events_url":"https://api.github.com/users/PandorasFox/events{/privacy}","received_events_url":"https://api.github.com/users/PandorasFox/received_events","type":"User","site_admin":false},"repo":{"id":142724818,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI3MjQ4MTg=","name":"i3","full_name":"PandorasFox/i3","owner":{"login":"PandorasFox","id":3235827,"node_id":"MDQ6VXNlcjMyMzU4Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/3235827?v=4","gravatar_id":"","url":"https://api.github.com/users/PandorasFox","html_url":"https://github.com/PandorasFox","followers_url":"https://api.github.com/users/PandorasFox/followers","following_url":"https://api.github.com/users/PandorasFox/following{/other_user}","gists_url":"https://api.github.com/users/PandorasFox/gists{/gist_id}","starred_url":"https://api.github.com/users/PandorasFox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PandorasFox/subscriptions","organizations_url":"https://api.github.com/users/PandorasFox/orgs","repos_url":"https://api.github.com/users/PandorasFox/repos","events_url":"https://api.github.com/users/PandorasFox/events{/privacy}","received_events_url":"https://api.github.com/users/PandorasFox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PandorasFox/i3","description":"A tiling window manager","fork":true,"url":"https://api.github.com/repos/PandorasFox/i3","forks_url":"https://api.github.com/repos/PandorasFox/i3/forks","keys_url":"https://api.github.com/repos/PandorasFox/i3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PandorasFox/i3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PandorasFox/i3/teams","hooks_url":"https://api.github.com/repos/PandorasFox/i3/hooks","issue_events_url":"https://api.github.com/repos/PandorasFox/i3/issues/events{/number}","events_url":"https://api.github.com/repos/PandorasFox/i3/events","assignees_url":"https://api.github.com/repos/PandorasFox/i3/assignees{/user}","branches_url":"https://api.github.com/repos/PandorasFox/i3/branches{/branch}","tags_url":"https://api.github.com/repos/PandorasFox/i3/tags","blobs_url":"https://api.github.com/repos/PandorasFox/i3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PandorasFox/i3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PandorasFox/i3/git/refs{/sha}","trees_url":"https://api.github.com/repos/PandorasFox/i3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PandorasFox/i3/statuses/{sha}","languages_url":"https://api.github.com/repos/PandorasFox/i3/languages","stargazers_url":"https://api.github.com/repos/PandorasFox/i3/stargazers","contributors_url":"https://api.github.com/repos/PandorasFox/i3/contributors","subscribers_url":"https://api.github.com/repos/PandorasFox/i3/subscribers","subscription_url":"https://api.github.com/repos/PandorasFox/i3/subscription","commits_url":"https://api.github.com/repos/PandorasFox/i3/commits{/sha}","git_commits_url":"https://api.github.com/repos/PandorasFox/i3/git/commits{/sha}","comments_url":"https://api.github.com/repos/PandorasFox/i3/comments{/number}","issue_comment_url":"https://api.github.com/repos/PandorasFox/i3/issues/comments{/number}","contents_url":"https://api.github.com/repos/PandorasFox/i3/contents/{+path}","compare_url":"https://api.github.com/repos/PandorasFox/i3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PandorasFox/i3/merges","archive_url":"https://api.github.com/repos/PandorasFox/i3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PandorasFox/i3/downloads","issues_url":"https://api.github.com/repos/PandorasFox/i3/issues{/number}","pulls_url":"https://api.github.com/repos/PandorasFox/i3/pulls{/number}","milestones_url":"https://api.github.com/repos/PandorasFox/i3/milestones{/number}","notifications_url":"https://api.github.com/repos/PandorasFox/i3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PandorasFox/i3/labels{/name}","releases_url":"https://api.github.com/repos/PandorasFox/i3/releases{/id}","deployments_url":"https://api.github.com/repos/PandorasFox/i3/deployments","created_at":"2018-07-29T02:31:40Z","updated_at":"2018-07-29T02:32:29Z","pushed_at":"2018-07-29T02:32:28Z","git_url":"git://github.com/PandorasFox/i3.git","ssh_url":"git@github.com:PandorasFox/i3.git","clone_url":"https://github.com/PandorasFox/i3.git","svn_url":"https://github.com/PandorasFox/i3","homepage":"https://i3wm.org/","size":10691,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"next"}},"base":{"label":"i3:next","ref":"next","sha":"d7022c70112c0038d52b34ca6a54fed47bc2b657","user":{"login":"i3","id":7904352,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MDQzNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/7904352?v=4","gravatar_id":"","url":"https://api.github.com/users/i3","html_url":"https://github.com/i3","followers_url":"https://api.github.com/users/i3/followers","following_url":"https://api.github.com/users/i3/following{/other_user}","gists_url":"https://api.github.com/users/i3/gists{/gist_id}","starred_url":"https://api.github.com/users/i3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/i3/subscriptions","organizations_url":"https://api.github.com/users/i3/orgs","repos_url":"https://api.github.com/users/i3/repos","events_url":"https://api.github.com/users/i3/events{/privacy}","received_events_url":"https://api.github.com/users/i3/received_events","type":"Organization","site_admin":false},"repo":{"id":30291090,"node_id":"MDEwOlJlcG9zaXRvcnkzMDI5MTA5MA==","name":"i3","full_name":"i3/i3","owner":{"login":"i3","id":7904352,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MDQzNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/7904352?v=4","gravatar_id":"","url":"https://api.github.com/users/i3","html_url":"https://github.com/i3","followers_url":"https://api.github.com/users/i3/followers","following_url":"https://api.github.com/users/i3/following{/other_user}","gists_url":"https://api.github.com/users/i3/gists{/gist_id}","starred_url":"https://api.github.com/users/i3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/i3/subscriptions","organizations_url":"https://api.github.com/users/i3/orgs","repos_url":"https://api.github.com/users/i3/repos","events_url":"https://api.github.com/users/i3/events{/privacy}","received_events_url":"https://api.github.com/users/i3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/i3/i3","description":"A tiling window manager","fork":false,"url":"https://api.github.com/repos/i3/i3","forks_url":"https://api.github.com/repos/i3/i3/forks","keys_url":"https://api.github.com/repos/i3/i3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/i3/i3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/i3/i3/teams","hooks_url":"https://api.github.com/repos/i3/i3/hooks","issue_events_url":"https://api.github.com/repos/i3/i3/issues/events{/number}","events_url":"https://api.github.com/repos/i3/i3/events","assignees_url":"https://api.github.com/repos/i3/i3/assignees{/user}","branches_url":"https://api.github.com/repos/i3/i3/branches{/branch}","tags_url":"https://api.github.com/repos/i3/i3/tags","blobs_url":"https://api.github.com/repos/i3/i3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/i3/i3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/i3/i3/git/refs{/sha}","trees_url":"https://api.github.com/repos/i3/i3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/i3/i3/statuses/{sha}","languages_url":"https://api.github.com/repos/i3/i3/languages","stargazers_url":"https://api.github.com/repos/i3/i3/stargazers","contributors_url":"https://api.github.com/repos/i3/i3/contributors","subscribers_url":"https://api.github.com/repos/i3/i3/subscribers","subscription_url":"https://api.github.com/repos/i3/i3/subscription","commits_url":"https://api.github.com/repos/i3/i3/commits{/sha}","git_commits_url":"https://api.github.com/repos/i3/i3/git/commits{/sha}","comments_url":"https://api.github.com/repos/i3/i3/comments{/number}","issue_comment_url":"https://api.github.com/repos/i3/i3/issues/comments{/number}","contents_url":"https://api.github.com/repos/i3/i3/contents/{+path}","compare_url":"https://api.github.com/repos/i3/i3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/i3/i3/merges","archive_url":"https://api.github.com/repos/i3/i3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/i3/i3/downloads","issues_url":"https://api.github.com/repos/i3/i3/issues{/number}","pulls_url":"https://api.github.com/repos/i3/i3/pulls{/number}","milestones_url":"https://api.github.com/repos/i3/i3/milestones{/number}","notifications_url":"https://api.github.com/repos/i3/i3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/i3/i3/labels{/name}","releases_url":"https://api.github.com/repos/i3/i3/releases{/id}","deployments_url":"https://api.github.com/repos/i3/i3/deployments","created_at":"2015-02-04T09:23:51Z","updated_at":"2018-07-28T10:53:30Z","pushed_at":"2018-07-29T10:10:27Z","git_url":"git://github.com/i3/i3.git","ssh_url":"git@github.com:i3/i3.git","clone_url":"https://github.com/i3/i3.git","svn_url":"https://github.com/i3/i3","homepage":"https://i3wm.org/","size":10691,"stargazers_count":3349,"watchers_count":3349,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":383,"mirror_url":null,"archived":false,"open_issues_count":151,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":383,"open_issues":151,"watchers":3349,"default_branch":"next"}},"_links":{"self":{"href":"https://api.github.com/repos/i3/i3/pulls/3340"},"html":{"href":"https://github.com/i3/i3/pull/3340"},"issue":{"href":"https://api.github.com/repos/i3/i3/issues/3340"},"comments":{"href":"https://api.github.com/repos/i3/i3/issues/3340/comments"},"review_comments":{"href":"https://api.github.com/repos/i3/i3/pulls/3340/comments"},"review_comment":{"href":"https://api.github.com/repos/i3/i3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/i3/i3/pulls/3340/commits"},"statuses":{"href":"https://api.github.com/repos/i3/i3/statuses/ad236dbaec4fc8fa0d35f80b1d0be640b68ae6ce"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Airblader","id":2392216,"node_id":"MDQ6VXNlcjIzOTIyMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2392216?v=4","gravatar_id":"","url":"https://api.github.com/users/Airblader","html_url":"https://github.com/Airblader","followers_url":"https://api.github.com/users/Airblader/followers","following_url":"https://api.github.com/users/Airblader/following{/other_user}","gists_url":"https://api.github.com/users/Airblader/gists{/gist_id}","starred_url":"https://api.github.com/users/Airblader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Airblader/subscriptions","organizations_url":"https://api.github.com/users/Airblader/orgs","repos_url":"https://api.github.com/users/Airblader/repos","events_url":"https://api.github.com/users/Airblader/events{/privacy}","received_events_url":"https://api.github.com/users/Airblader/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"Airblader"}}