{"action":"created","comment":{"url":"https://api.github.com/repos/libopenstorage/stork/pulls/comments/202877057","pull_request_review_id":137198924,"id":202877057,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjg3NzA1Nw==","diff_hunk":"@@ -80,8 +87,28 @@ const (\n \tcloudSnapshotInitialDelay = 5 * time.Second\n \tcloudSnapshotFactor       = 1\n \tcloudSnapshotSteps        = math.MaxInt32\n+\n+\t// constants\n+\tcmdExecutorImage         = \"openstorage/cmdexecutor:latest\"\n+\tstorkServiceAccount      = \"stork-account\"\n+\tperPodCommandExecTimeout = 900 // 15 minutes\n+\n+\tdefaultRetryInterval = 5 * time.Second\n+\tdefaultRetryFactor   = 1\n+\tdefaultMaxRetrySteps = 12\n+\texecPodStepLow       = defaultMaxRetrySteps\n+\texecPodStepMed       = defaultMaxRetrySteps * 3\n+\texecPodStepsHigh     = math.MaxInt32\n+\n+\tpodsWithRunningCommandsKey = \"stork/pods-with-running-cmds\"\n )\n \n+// CommandTask tracks pods where commands for a taskID might still be running\n+type CommandTask struct {\n+\tTaskID string   `json:\"taskID\"`\n+\tPods   []string `json:\"pods\"`","path":"drivers/volume/portworx/portworx.go","position":62,"original_position":62,"commit_id":"b72bc8c01d403afb531bfe113c8714d9b2a43c87","original_commit_id":"b72bc8c01d403afb531bfe113c8714d9b2a43c87","user":{"login":"disrani-px","id":25230810,"node_id":"MDQ6VXNlcjI1MjMwODEw","avatar_url":"https://avatars3.githubusercontent.com/u/25230810?v=4","gravatar_id":"","url":"https://api.github.com/users/disrani-px","html_url":"https://github.com/disrani-px","followers_url":"https://api.github.com/users/disrani-px/followers","following_url":"https://api.github.com/users/disrani-px/following{/other_user}","gists_url":"https://api.github.com/users/disrani-px/gists{/gist_id}","starred_url":"https://api.github.com/users/disrani-px/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/disrani-px/subscriptions","organizations_url":"https://api.github.com/users/disrani-px/orgs","repos_url":"https://api.github.com/users/disrani-px/repos","events_url":"https://api.github.com/users/disrani-px/events{/privacy}","received_events_url":"https://api.github.com/users/disrani-px/received_events","type":"User","site_admin":false},"body":"Define another type which has name and namespace and use that here to avoid parsing the name","created_at":"2018-07-17T02:15:22Z","updated_at":"2018-07-17T02:44:07Z","html_url":"https://github.com/libopenstorage/stork/pull/118#discussion_r202877057","pull_request_url":"https://api.github.com/repos/libopenstorage/stork/pulls/118","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/libopenstorage/stork/pulls/comments/202877057"},"html":{"href":"https://github.com/libopenstorage/stork/pull/118#discussion_r202877057"},"pull_request":{"href":"https://api.github.com/repos/libopenstorage/stork/pulls/118"}}},"pull_request":{"url":"https://api.github.com/repos/libopenstorage/stork/pulls/118","id":201402645,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDAyNjQ1","html_url":"https://github.com/libopenstorage/stork/pull/118","diff_url":"https://github.com/libopenstorage/stork/pull/118.diff","patch_url":"https://github.com/libopenstorage/stork/pull/118.patch","issue_url":"https://api.github.com/repos/libopenstorage/stork/issues/118","number":118,"state":"open","locked":false,"title":" Add support for 3d snapshots","user":{"login":"harsh-px","id":26801153,"node_id":"MDQ6VXNlcjI2ODAxMTUz","avatar_url":"https://avatars1.githubusercontent.com/u/26801153?v=4","gravatar_id":"","url":"https://api.github.com/users/harsh-px","html_url":"https://github.com/harsh-px","followers_url":"https://api.github.com/users/harsh-px/followers","following_url":"https://api.github.com/users/harsh-px/following{/other_user}","gists_url":"https://api.github.com/users/harsh-px/gists{/gist_id}","starred_url":"https://api.github.com/users/harsh-px/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsh-px/subscriptions","organizations_url":"https://api.github.com/users/harsh-px/orgs","repos_url":"https://api.github.com/users/harsh-px/repos","events_url":"https://api.github.com/users/harsh-px/events{/privacy}","received_events_url":"https://api.github.com/users/harsh-px/received_events","type":"User","site_admin":false},"body":"1. Adds support for 3d snapshots\r\n2. Fixes cmdexecutor and it's invocation in driver to exit as soon as an error is encountered\r\n3. Adds positive and negative integration tests for 3d snapshots","created_at":"2018-07-13T21:18:06Z","updated_at":"2018-07-17T02:44:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f780b8f920859e182072f33c5eb3e8a52fb0c0b","assignee":{"login":"harsh-px","id":26801153,"node_id":"MDQ6VXNlcjI2ODAxMTUz","avatar_url":"https://avatars1.githubusercontent.com/u/26801153?v=4","gravatar_id":"","url":"https://api.github.com/users/harsh-px","html_url":"https://github.com/harsh-px","followers_url":"https://api.github.com/users/harsh-px/followers","following_url":"https://api.github.com/users/harsh-px/following{/other_user}","gists_url":"https://api.github.com/users/harsh-px/gists{/gist_id}","starred_url":"https://api.github.com/users/harsh-px/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsh-px/subscriptions","organizations_url":"https://api.github.com/users/harsh-px/orgs","repos_url":"https://api.github.com/users/harsh-px/repos","events_url":"https://api.github.com/users/harsh-px/events{/privacy}","received_events_url":"https://api.github.com/users/harsh-px/received_events","type":"User","site_admin":false},"assignees":[{"login":"harsh-px","id":26801153,"node_id":"MDQ6VXNlcjI2ODAxMTUz","avatar_url":"https://avatars1.githubusercontent.com/u/26801153?v=4","gravatar_id":"","url":"https://api.github.com/users/harsh-px","html_url":"https://github.com/harsh-px","followers_url":"https://api.github.com/users/harsh-px/followers","following_url":"https://api.github.com/users/harsh-px/following{/other_user}","gists_url":"https://api.github.com/users/harsh-px/gists{/gist_id}","starred_url":"https://api.github.com/users/harsh-px/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsh-px/subscriptions","organizations_url":"https://api.github.com/users/harsh-px/orgs","repos_url":"https://api.github.com/users/harsh-px/repos","events_url":"https://api.github.com/users/harsh-px/events{/privacy}","received_events_url":"https://api.github.com/users/harsh-px/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/libopenstorage/stork/pulls/118/commits","review_comments_url":"https://api.github.com/repos/libopenstorage/stork/pulls/118/comments","review_comment_url":"https://api.github.com/repos/libopenstorage/stork/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libopenstorage/stork/issues/118/comments","statuses_url":"https://api.github.com/repos/libopenstorage/stork/statuses/b72bc8c01d403afb531bfe113c8714d9b2a43c87","head":{"label":"harsh-px:3d-snaps","ref":"3d-snaps","sha":"b72bc8c01d403afb531bfe113c8714d9b2a43c87","user":{"login":"harsh-px","id":26801153,"node_id":"MDQ6VXNlcjI2ODAxMTUz","avatar_url":"https://avatars1.githubusercontent.com/u/26801153?v=4","gravatar_id":"","url":"https://api.github.com/users/harsh-px","html_url":"https://github.com/harsh-px","followers_url":"https://api.github.com/users/harsh-px/followers","following_url":"https://api.github.com/users/harsh-px/following{/other_user}","gists_url":"https://api.github.com/users/harsh-px/gists{/gist_id}","starred_url":"https://api.github.com/users/harsh-px/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsh-px/subscriptions","organizations_url":"https://api.github.com/users/harsh-px/orgs","repos_url":"https://api.github.com/users/harsh-px/repos","events_url":"https://api.github.com/users/harsh-px/events{/privacy}","received_events_url":"https://api.github.com/users/harsh-px/received_events","type":"User","site_admin":false},"repo":{"id":129169020,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkxNjkwMjA=","name":"stork","full_name":"harsh-px/stork","owner":{"login":"harsh-px","id":26801153,"node_id":"MDQ6VXNlcjI2ODAxMTUz","avatar_url":"https://avatars1.githubusercontent.com/u/26801153?v=4","gravatar_id":"","url":"https://api.github.com/users/harsh-px","html_url":"https://github.com/harsh-px","followers_url":"https://api.github.com/users/harsh-px/followers","following_url":"https://api.github.com/users/harsh-px/following{/other_user}","gists_url":"https://api.github.com/users/harsh-px/gists{/gist_id}","starred_url":"https://api.github.com/users/harsh-px/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsh-px/subscriptions","organizations_url":"https://api.github.com/users/harsh-px/orgs","repos_url":"https://api.github.com/users/harsh-px/repos","events_url":"https://api.github.com/users/harsh-px/events{/privacy}","received_events_url":"https://api.github.com/users/harsh-px/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/harsh-px/stork","description":"Stork - Storage Orchestration Runtime for Kubernetes","fork":true,"url":"https://api.github.com/repos/harsh-px/stork","forks_url":"https://api.github.com/repos/harsh-px/stork/forks","keys_url":"https://api.github.com/repos/harsh-px/stork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harsh-px/stork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harsh-px/stork/teams","hooks_url":"https://api.github.com/repos/harsh-px/stork/hooks","issue_events_url":"https://api.github.com/repos/harsh-px/stork/issues/events{/number}","events_url":"https://api.github.com/repos/harsh-px/stork/events","assignees_url":"https://api.github.com/repos/harsh-px/stork/assignees{/user}","branches_url":"https://api.github.com/repos/harsh-px/stork/branches{/branch}","tags_url":"https://api.github.com/repos/harsh-px/stork/tags","blobs_url":"https://api.github.com/repos/harsh-px/stork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harsh-px/stork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harsh-px/stork/git/refs{/sha}","trees_url":"https://api.github.com/repos/harsh-px/stork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harsh-px/stork/statuses/{sha}","languages_url":"https://api.github.com/repos/harsh-px/stork/languages","stargazers_url":"https://api.github.com/repos/harsh-px/stork/stargazers","contributors_url":"https://api.github.com/repos/harsh-px/stork/contributors","subscribers_url":"https://api.github.com/repos/harsh-px/stork/subscribers","subscription_url":"https://api.github.com/repos/harsh-px/stork/subscription","commits_url":"https://api.github.com/repos/harsh-px/stork/commits{/sha}","git_commits_url":"https://api.github.com/repos/harsh-px/stork/git/commits{/sha}","comments_url":"https://api.github.com/repos/harsh-px/stork/comments{/number}","issue_comment_url":"https://api.github.com/repos/harsh-px/stork/issues/comments{/number}","contents_url":"https://api.github.com/repos/harsh-px/stork/contents/{+path}","compare_url":"https://api.github.com/repos/harsh-px/stork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harsh-px/stork/merges","archive_url":"https://api.github.com/repos/harsh-px/stork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harsh-px/stork/downloads","issues_url":"https://api.github.com/repos/harsh-px/stork/issues{/number}","pulls_url":"https://api.github.com/repos/harsh-px/stork/pulls{/number}","milestones_url":"https://api.github.com/repos/harsh-px/stork/milestones{/number}","notifications_url":"https://api.github.com/repos/harsh-px/stork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harsh-px/stork/labels{/name}","releases_url":"https://api.github.com/repos/harsh-px/stork/releases{/id}","deployments_url":"https://api.github.com/repos/harsh-px/stork/deployments","created_at":"2018-04-12T00:14:44Z","updated_at":"2018-04-12T00:14:47Z","pushed_at":"2018-07-13T21:17:47Z","git_url":"git://github.com/harsh-px/stork.git","ssh_url":"git@github.com:harsh-px/stork.git","clone_url":"https://github.com/harsh-px/stork.git","svn_url":"https://github.com/harsh-px/stork","homepage":"","size":7345,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libopenstorage:master","ref":"master","sha":"ab453b9161a1446526d8563d00fccfa55c418bf1","user":{"login":"libopenstorage","id":13478636,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDc4NjM2","avatar_url":"https://avatars0.githubusercontent.com/u/13478636?v=4","gravatar_id":"","url":"https://api.github.com/users/libopenstorage","html_url":"https://github.com/libopenstorage","followers_url":"https://api.github.com/users/libopenstorage/followers","following_url":"https://api.github.com/users/libopenstorage/following{/other_user}","gists_url":"https://api.github.com/users/libopenstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/libopenstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libopenstorage/subscriptions","organizations_url":"https://api.github.com/users/libopenstorage/orgs","repos_url":"https://api.github.com/users/libopenstorage/repos","events_url":"https://api.github.com/users/libopenstorage/events{/privacy}","received_events_url":"https://api.github.com/users/libopenstorage/received_events","type":"Organization","site_admin":false},"repo":{"id":102562155,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI1NjIxNTU=","name":"stork","full_name":"libopenstorage/stork","owner":{"login":"libopenstorage","id":13478636,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDc4NjM2","avatar_url":"https://avatars0.githubusercontent.com/u/13478636?v=4","gravatar_id":"","url":"https://api.github.com/users/libopenstorage","html_url":"https://github.com/libopenstorage","followers_url":"https://api.github.com/users/libopenstorage/followers","following_url":"https://api.github.com/users/libopenstorage/following{/other_user}","gists_url":"https://api.github.com/users/libopenstorage/gists{/gist_id}","starred_url":"https://api.github.com/users/libopenstorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libopenstorage/subscriptions","organizations_url":"https://api.github.com/users/libopenstorage/orgs","repos_url":"https://api.github.com/users/libopenstorage/repos","events_url":"https://api.github.com/users/libopenstorage/events{/privacy}","received_events_url":"https://api.github.com/users/libopenstorage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libopenstorage/stork","description":"Stork - Storage Orchestration Runtime for Kubernetes","fork":false,"url":"https://api.github.com/repos/libopenstorage/stork","forks_url":"https://api.github.com/repos/libopenstorage/stork/forks","keys_url":"https://api.github.com/repos/libopenstorage/stork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libopenstorage/stork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libopenstorage/stork/teams","hooks_url":"https://api.github.com/repos/libopenstorage/stork/hooks","issue_events_url":"https://api.github.com/repos/libopenstorage/stork/issues/events{/number}","events_url":"https://api.github.com/repos/libopenstorage/stork/events","assignees_url":"https://api.github.com/repos/libopenstorage/stork/assignees{/user}","branches_url":"https://api.github.com/repos/libopenstorage/stork/branches{/branch}","tags_url":"https://api.github.com/repos/libopenstorage/stork/tags","blobs_url":"https://api.github.com/repos/libopenstorage/stork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libopenstorage/stork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libopenstorage/stork/git/refs{/sha}","trees_url":"https://api.github.com/repos/libopenstorage/stork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libopenstorage/stork/statuses/{sha}","languages_url":"https://api.github.com/repos/libopenstorage/stork/languages","stargazers_url":"https://api.github.com/repos/libopenstorage/stork/stargazers","contributors_url":"https://api.github.com/repos/libopenstorage/stork/contributors","subscribers_url":"https://api.github.com/repos/libopenstorage/stork/subscribers","subscription_url":"https://api.github.com/repos/libopenstorage/stork/subscription","commits_url":"https://api.github.com/repos/libopenstorage/stork/commits{/sha}","git_commits_url":"https://api.github.com/repos/libopenstorage/stork/git/commits{/sha}","comments_url":"https://api.github.com/repos/libopenstorage/stork/comments{/number}","issue_comment_url":"https://api.github.com/repos/libopenstorage/stork/issues/comments{/number}","contents_url":"https://api.github.com/repos/libopenstorage/stork/contents/{+path}","compare_url":"https://api.github.com/repos/libopenstorage/stork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libopenstorage/stork/merges","archive_url":"https://api.github.com/repos/libopenstorage/stork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libopenstorage/stork/downloads","issues_url":"https://api.github.com/repos/libopenstorage/stork/issues{/number}","pulls_url":"https://api.github.com/repos/libopenstorage/stork/pulls{/number}","milestones_url":"https://api.github.com/repos/libopenstorage/stork/milestones{/number}","notifications_url":"https://api.github.com/repos/libopenstorage/stork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libopenstorage/stork/labels{/name}","releases_url":"https://api.github.com/repos/libopenstorage/stork/releases{/id}","deployments_url":"https://api.github.com/repos/libopenstorage/stork/deployments","created_at":"2017-09-06T04:20:51Z","updated_at":"2018-07-16T22:37:38Z","pushed_at":"2018-07-16T22:37:36Z","git_url":"git://github.com/libopenstorage/stork.git","ssh_url":"git@github.com:libopenstorage/stork.git","clone_url":"https://github.com/libopenstorage/stork.git","svn_url":"https://github.com/libopenstorage/stork","homepage":"","size":7242,"stargazers_count":85,"watchers_count":85,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":10,"open_issues":8,"watchers":85,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libopenstorage/stork/pulls/118"},"html":{"href":"https://github.com/libopenstorage/stork/pull/118"},"issue":{"href":"https://api.github.com/repos/libopenstorage/stork/issues/118"},"comments":{"href":"https://api.github.com/repos/libopenstorage/stork/issues/118/comments"},"review_comments":{"href":"https://api.github.com/repos/libopenstorage/stork/pulls/118/comments"},"review_comment":{"href":"https://api.github.com/repos/libopenstorage/stork/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libopenstorage/stork/pulls/118/commits"},"statuses":{"href":"https://api.github.com/repos/libopenstorage/stork/statuses/b72bc8c01d403afb531bfe113c8714d9b2a43c87"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"disrani-px"}}