{"action":"created","comment":{"url":"https://api.github.com/repos/pact-foundation/pact-js/pulls/comments/220790732","pull_request_review_id":159280304,"id":220790732,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDc5MDczMg==","diff_hunk":"@@ -0,0 +1,53 @@\n+'use strict'\n+\n+const path = require('path')\n+const { Pact, Matchers } = require('../../../dist/pact')\n+const getMeCats = require('../').getMeCats\n+\n+describe(\"Cat's API\", () => {\n+  let url = 'http://localhost'\n+\n+  describe(\"another works\", () => {\n+    it('returns a successful body', async () => {\n+      // add expectations\n+      const EXPECTED_BODY = [\n+        { cat: 2 }, { cat: 3 }\n+      ]\n+\n+      const interaction = {","path":"examples/jest/__tests__/catAPI.spec.js","position":17,"original_position":17,"commit_id":"93c15727ef04f188950bdfcb22471635e8e84529","original_commit_id":"93c15727ef04f188950bdfcb22471635e8e84529","user":{"login":"TimothyJones","id":914369,"node_id":"MDQ6VXNlcjkxNDM2OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/914369?v=4","gravatar_id":"","url":"https://api.github.com/users/TimothyJones","html_url":"https://github.com/TimothyJones","followers_url":"https://api.github.com/users/TimothyJones/followers","following_url":"https://api.github.com/users/TimothyJones/following{/other_user}","gists_url":"https://api.github.com/users/TimothyJones/gists{/gist_id}","starred_url":"https://api.github.com/users/TimothyJones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimothyJones/subscriptions","organizations_url":"https://api.github.com/users/TimothyJones/orgs","repos_url":"https://api.github.com/users/TimothyJones/repos","events_url":"https://api.github.com/users/TimothyJones/events{/privacy}","received_events_url":"https://api.github.com/users/TimothyJones/received_events","type":"User","site_admin":false},"body":"I personally think this reads better in the `beforeEach()` block, because it's the Given part of the Given/When/Then (this also would match the other example tests in the Jest folder)","created_at":"2018-09-27T04:31:28Z","updated_at":"2018-09-27T04:44:46Z","html_url":"https://github.com/pact-foundation/pact-js/pull/211#discussion_r220790732","pull_request_url":"https://api.github.com/repos/pact-foundation/pact-js/pulls/211","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pact-foundation/pact-js/pulls/comments/220790732"},"html":{"href":"https://github.com/pact-foundation/pact-js/pull/211#discussion_r220790732"},"pull_request":{"href":"https://api.github.com/repos/pact-foundation/pact-js/pulls/211"}}},"pull_request":{"url":"https://api.github.com/repos/pact-foundation/pact-js/pulls/211","id":216617867,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NjE3ODY3","html_url":"https://github.com/pact-foundation/pact-js/pull/211","diff_url":"https://github.com/pact-foundation/pact-js/pull/211.diff","patch_url":"https://github.com/pact-foundation/pact-js/pull/211.patch","issue_url":"https://api.github.com/repos/pact-foundation/pact-js/issues/211","number":211,"state":"open","locked":false,"title":"feat(examples): add array bracket notation example to jest tests","user":{"login":"lirantal","id":316371,"node_id":"MDQ6VXNlcjMxNjM3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/316371?v=4","gravatar_id":"","url":"https://api.github.com/users/lirantal","html_url":"https://github.com/lirantal","followers_url":"https://api.github.com/users/lirantal/followers","following_url":"https://api.github.com/users/lirantal/following{/other_user}","gists_url":"https://api.github.com/users/lirantal/gists{/gist_id}","starred_url":"https://api.github.com/users/lirantal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lirantal/subscriptions","organizations_url":"https://api.github.com/users/lirantal/orgs","repos_url":"https://api.github.com/users/lirantal/repos","events_url":"https://api.github.com/users/lirantal/events{/privacy}","received_events_url":"https://api.github.com/users/lirantal/received_events","type":"User","site_admin":false},"body":"## Changes\r\n- Updated jest examples with an example reference on using query params with square bracket notation.\r\n- Updated best practice to include the interaction in the test case\r\n- Refactored the callback style to promises\r\n\r\n## Open questions:\r\n- Looks like when the tests run the pact file doesn't include the /cats route. Is that a bug in how the 'update' works or wrong setup on the jest tests ?\r\n- Do you see any benefit in using the individual pact test wrapper","created_at":"2018-09-19T12:17:56Z","updated_at":"2018-09-27T04:44:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d80e76dc49c9f7f303091ece23564505941497d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pact-foundation/pact-js/pulls/211/commits","review_comments_url":"https://api.github.com/repos/pact-foundation/pact-js/pulls/211/comments","review_comment_url":"https://api.github.com/repos/pact-foundation/pact-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pact-foundation/pact-js/issues/211/comments","statuses_url":"https://api.github.com/repos/pact-foundation/pact-js/statuses/93c15727ef04f188950bdfcb22471635e8e84529","head":{"label":"lirantal:feat/jest-example-queryparams-like","ref":"feat/jest-example-queryparams-like","sha":"93c15727ef04f188950bdfcb22471635e8e84529","user":{"login":"lirantal","id":316371,"node_id":"MDQ6VXNlcjMxNjM3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/316371?v=4","gravatar_id":"","url":"https://api.github.com/users/lirantal","html_url":"https://github.com/lirantal","followers_url":"https://api.github.com/users/lirantal/followers","following_url":"https://api.github.com/users/lirantal/following{/other_user}","gists_url":"https://api.github.com/users/lirantal/gists{/gist_id}","starred_url":"https://api.github.com/users/lirantal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lirantal/subscriptions","organizations_url":"https://api.github.com/users/lirantal/orgs","repos_url":"https://api.github.com/users/lirantal/repos","events_url":"https://api.github.com/users/lirantal/events{/privacy}","received_events_url":"https://api.github.com/users/lirantal/received_events","type":"User","site_admin":false},"repo":{"id":98600740,"node_id":"MDEwOlJlcG9zaXRvcnk5ODYwMDc0MA==","name":"pact-js","full_name":"lirantal/pact-js","private":false,"owner":{"login":"lirantal","id":316371,"node_id":"MDQ6VXNlcjMxNjM3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/316371?v=4","gravatar_id":"","url":"https://api.github.com/users/lirantal","html_url":"https://github.com/lirantal","followers_url":"https://api.github.com/users/lirantal/followers","following_url":"https://api.github.com/users/lirantal/following{/other_user}","gists_url":"https://api.github.com/users/lirantal/gists{/gist_id}","starred_url":"https://api.github.com/users/lirantal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lirantal/subscriptions","organizations_url":"https://api.github.com/users/lirantal/orgs","repos_url":"https://api.github.com/users/lirantal/repos","events_url":"https://api.github.com/users/lirantal/events{/privacy}","received_events_url":"https://api.github.com/users/lirantal/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lirantal/pact-js","description":"JS version of Pact. Enables consumer driven contract testing, providing a mock service and DSL for the consumer project, and interaction playback and verification for the service provider project","fork":true,"url":"https://api.github.com/repos/lirantal/pact-js","forks_url":"https://api.github.com/repos/lirantal/pact-js/forks","keys_url":"https://api.github.com/repos/lirantal/pact-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lirantal/pact-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lirantal/pact-js/teams","hooks_url":"https://api.github.com/repos/lirantal/pact-js/hooks","issue_events_url":"https://api.github.com/repos/lirantal/pact-js/issues/events{/number}","events_url":"https://api.github.com/repos/lirantal/pact-js/events","assignees_url":"https://api.github.com/repos/lirantal/pact-js/assignees{/user}","branches_url":"https://api.github.com/repos/lirantal/pact-js/branches{/branch}","tags_url":"https://api.github.com/repos/lirantal/pact-js/tags","blobs_url":"https://api.github.com/repos/lirantal/pact-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lirantal/pact-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lirantal/pact-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/lirantal/pact-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lirantal/pact-js/statuses/{sha}","languages_url":"https://api.github.com/repos/lirantal/pact-js/languages","stargazers_url":"https://api.github.com/repos/lirantal/pact-js/stargazers","contributors_url":"https://api.github.com/repos/lirantal/pact-js/contributors","subscribers_url":"https://api.github.com/repos/lirantal/pact-js/subscribers","subscription_url":"https://api.github.com/repos/lirantal/pact-js/subscription","commits_url":"https://api.github.com/repos/lirantal/pact-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/lirantal/pact-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/lirantal/pact-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/lirantal/pact-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/lirantal/pact-js/contents/{+path}","compare_url":"https://api.github.com/repos/lirantal/pact-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lirantal/pact-js/merges","archive_url":"https://api.github.com/repos/lirantal/pact-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lirantal/pact-js/downloads","issues_url":"https://api.github.com/repos/lirantal/pact-js/issues{/number}","pulls_url":"https://api.github.com/repos/lirantal/pact-js/pulls{/number}","milestones_url":"https://api.github.com/repos/lirantal/pact-js/milestones{/number}","notifications_url":"https://api.github.com/repos/lirantal/pact-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lirantal/pact-js/labels{/name}","releases_url":"https://api.github.com/repos/lirantal/pact-js/releases{/id}","deployments_url":"https://api.github.com/repos/lirantal/pact-js/deployments","created_at":"2017-07-28T02:46:39Z","updated_at":"2017-12-06T22:58:06Z","pushed_at":"2018-09-19T12:10:24Z","git_url":"git://github.com/lirantal/pact-js.git","ssh_url":"git@github.com:lirantal/pact-js.git","clone_url":"https://github.com/lirantal/pact-js.git","svn_url":"https://github.com/lirantal/pact-js","homepage":"http://docs.pact.io/","size":3535,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pact-foundation:master","ref":"master","sha":"2ba8dbef952249b88e0874fcf3e0b711f603bb2f","user":{"login":"pact-foundation","id":14811176,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODExMTc2","avatar_url":"https://avatars0.githubusercontent.com/u/14811176?v=4","gravatar_id":"","url":"https://api.github.com/users/pact-foundation","html_url":"https://github.com/pact-foundation","followers_url":"https://api.github.com/users/pact-foundation/followers","following_url":"https://api.github.com/users/pact-foundation/following{/other_user}","gists_url":"https://api.github.com/users/pact-foundation/gists{/gist_id}","starred_url":"https://api.github.com/users/pact-foundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pact-foundation/subscriptions","organizations_url":"https://api.github.com/users/pact-foundation/orgs","repos_url":"https://api.github.com/users/pact-foundation/repos","events_url":"https://api.github.com/users/pact-foundation/events{/privacy}","received_events_url":"https://api.github.com/users/pact-foundation/received_events","type":"Organization","site_admin":false},"repo":{"id":60344592,"node_id":"MDEwOlJlcG9zaXRvcnk2MDM0NDU5Mg==","name":"pact-js","full_name":"pact-foundation/pact-js","private":false,"owner":{"login":"pact-foundation","id":14811176,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODExMTc2","avatar_url":"https://avatars0.githubusercontent.com/u/14811176?v=4","gravatar_id":"","url":"https://api.github.com/users/pact-foundation","html_url":"https://github.com/pact-foundation","followers_url":"https://api.github.com/users/pact-foundation/followers","following_url":"https://api.github.com/users/pact-foundation/following{/other_user}","gists_url":"https://api.github.com/users/pact-foundation/gists{/gist_id}","starred_url":"https://api.github.com/users/pact-foundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pact-foundation/subscriptions","organizations_url":"https://api.github.com/users/pact-foundation/orgs","repos_url":"https://api.github.com/users/pact-foundation/repos","events_url":"https://api.github.com/users/pact-foundation/events{/privacy}","received_events_url":"https://api.github.com/users/pact-foundation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pact-foundation/pact-js","description":"JS version of Pact. Pact is a contract testing framework for HTTP APIs and non-HTTP asynchronous messaging systems.","fork":false,"url":"https://api.github.com/repos/pact-foundation/pact-js","forks_url":"https://api.github.com/repos/pact-foundation/pact-js/forks","keys_url":"https://api.github.com/repos/pact-foundation/pact-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pact-foundation/pact-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pact-foundation/pact-js/teams","hooks_url":"https://api.github.com/repos/pact-foundation/pact-js/hooks","issue_events_url":"https://api.github.com/repos/pact-foundation/pact-js/issues/events{/number}","events_url":"https://api.github.com/repos/pact-foundation/pact-js/events","assignees_url":"https://api.github.com/repos/pact-foundation/pact-js/assignees{/user}","branches_url":"https://api.github.com/repos/pact-foundation/pact-js/branches{/branch}","tags_url":"https://api.github.com/repos/pact-foundation/pact-js/tags","blobs_url":"https://api.github.com/repos/pact-foundation/pact-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pact-foundation/pact-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pact-foundation/pact-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/pact-foundation/pact-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pact-foundation/pact-js/statuses/{sha}","languages_url":"https://api.github.com/repos/pact-foundation/pact-js/languages","stargazers_url":"https://api.github.com/repos/pact-foundation/pact-js/stargazers","contributors_url":"https://api.github.com/repos/pact-foundation/pact-js/contributors","subscribers_url":"https://api.github.com/repos/pact-foundation/pact-js/subscribers","subscription_url":"https://api.github.com/repos/pact-foundation/pact-js/subscription","commits_url":"https://api.github.com/repos/pact-foundation/pact-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/pact-foundation/pact-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/pact-foundation/pact-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/pact-foundation/pact-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/pact-foundation/pact-js/contents/{+path}","compare_url":"https://api.github.com/repos/pact-foundation/pact-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pact-foundation/pact-js/merges","archive_url":"https://api.github.com/repos/pact-foundation/pact-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pact-foundation/pact-js/downloads","issues_url":"https://api.github.com/repos/pact-foundation/pact-js/issues{/number}","pulls_url":"https://api.github.com/repos/pact-foundation/pact-js/pulls{/number}","milestones_url":"https://api.github.com/repos/pact-foundation/pact-js/milestones{/number}","notifications_url":"https://api.github.com/repos/pact-foundation/pact-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pact-foundation/pact-js/labels{/name}","releases_url":"https://api.github.com/repos/pact-foundation/pact-js/releases{/id}","deployments_url":"https://api.github.com/repos/pact-foundation/pact-js/deployments","created_at":"2016-06-03T12:02:17Z","updated_at":"2018-09-25T22:42:21Z","pushed_at":"2018-09-27T04:05:50Z","git_url":"git://github.com/pact-foundation/pact-js.git","ssh_url":"git@github.com:pact-foundation/pact-js.git","clone_url":"https://github.com/pact-foundation/pact-js.git","svn_url":"https://github.com/pact-foundation/pact-js","homepage":"http://docs.pact.io/","size":3540,"stargazers_count":383,"watchers_count":383,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":111,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":111,"open_issues":21,"watchers":383,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pact-foundation/pact-js/pulls/211"},"html":{"href":"https://github.com/pact-foundation/pact-js/pull/211"},"issue":{"href":"https://api.github.com/repos/pact-foundation/pact-js/issues/211"},"comments":{"href":"https://api.github.com/repos/pact-foundation/pact-js/issues/211/comments"},"review_comments":{"href":"https://api.github.com/repos/pact-foundation/pact-js/pulls/211/comments"},"review_comment":{"href":"https://api.github.com/repos/pact-foundation/pact-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pact-foundation/pact-js/pulls/211/commits"},"statuses":{"href":"https://api.github.com/repos/pact-foundation/pact-js/statuses/93c15727ef04f188950bdfcb22471635e8e84529"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"TimothyJones"}}