{"action":"created","comment":{"url":"https://api.github.com/repos/colemanw/webform_civicrm/pulls/comments/237546298","pull_request_review_id":179871304,"id":237546298,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzU0NjI5OA==","diff_hunk":"@@ -1973,22 +1973,25 @@ class wf_crm_webform_postprocess extends wf_crm_webform_base {\n    * @return string\n    */\n   public function getIpnRedirectUrl($type) {\n-    $url = trim($this->node->webform['redirect_url']);\n-    if ($url == '<none>' || $type == 'cancel') {\n-      $url = url('node/' . $this->node->nid, array('absolute' => TRUE));\n-    }\n-    elseif ($url == '<confirmation>') {\n-      $query = array('sid' => $this->submission->sid);\n+    $confirmation_type = $this->node->getSetting('confirmation_type');","path":"includes/wf_crm_webform_postprocess.inc","position":181,"original_position":181,"commit_id":"50eeda0bcc88e283e137ce1cb246f13591746166","original_commit_id":"50eeda0bcc88e283e137ce1cb246f13591746166","user":{"login":"dsnopek","id":191561,"node_id":"MDQ6VXNlcjE5MTU2MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/191561?v=4","gravatar_id":"","url":"https://api.github.com/users/dsnopek","html_url":"https://github.com/dsnopek","followers_url":"https://api.github.com/users/dsnopek/followers","following_url":"https://api.github.com/users/dsnopek/following{/other_user}","gists_url":"https://api.github.com/users/dsnopek/gists{/gist_id}","starred_url":"https://api.github.com/users/dsnopek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsnopek/subscriptions","organizations_url":"https://api.github.com/users/dsnopek/orgs","repos_url":"https://api.github.com/users/dsnopek/repos","events_url":"https://api.github.com/users/dsnopek/events{/privacy}","received_events_url":"https://api.github.com/users/dsnopek/received_events","type":"User","site_admin":false},"body":"Where is this node coming from? I've been testing Webforms not attached to nodes, which even if attaching Webforms to nodes, that's really just like an entity reference. Is this meant to be looking at setting on the Webform object?","created_at":"2018-11-29T15:57:28Z","updated_at":"2018-11-29T15:57:28Z","html_url":"https://github.com/colemanw/webform_civicrm/pull/185#discussion_r237546298","pull_request_url":"https://api.github.com/repos/colemanw/webform_civicrm/pulls/185","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/colemanw/webform_civicrm/pulls/comments/237546298"},"html":{"href":"https://github.com/colemanw/webform_civicrm/pull/185#discussion_r237546298"},"pull_request":{"href":"https://api.github.com/repos/colemanw/webform_civicrm/pulls/185"}}},"pull_request":{"url":"https://api.github.com/repos/colemanw/webform_civicrm/pulls/185","id":233432531,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNDMyNTMx","html_url":"https://github.com/colemanw/webform_civicrm/pull/185","diff_url":"https://github.com/colemanw/webform_civicrm/pull/185.diff","patch_url":"https://github.com/colemanw/webform_civicrm/pull/185.patch","issue_url":"https://api.github.com/repos/colemanw/webform_civicrm/issues/185","number":185,"state":"open","locked":false,"title":"[WIP] Payments","user":{"login":"mglaman","id":3698644,"node_id":"MDQ6VXNlcjM2OTg2NDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3698644?v=4","gravatar_id":"","url":"https://api.github.com/users/mglaman","html_url":"https://github.com/mglaman","followers_url":"https://api.github.com/users/mglaman/followers","following_url":"https://api.github.com/users/mglaman/following{/other_user}","gists_url":"https://api.github.com/users/mglaman/gists{/gist_id}","starred_url":"https://api.github.com/users/mglaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mglaman/subscriptions","organizations_url":"https://api.github.com/users/mglaman/orgs","repos_url":"https://api.github.com/users/mglaman/repos","events_url":"https://api.github.com/users/mglaman/events{/privacy}","received_events_url":"https://api.github.com/users/mglaman/received_events","type":"User","site_admin":false},"body":"Overview\r\n----------------------------------------\r\nAdds the ability to use a contribution form to accept payments for a one-off donation or others.\r\n\r\nCurrently WIP. Opening for tracking of changes.\r\n\r\nTechnical Details\r\n----------------------------------------\r\n\r\nDone / highlights\r\n\r\n* Fixes setting `select` value options when inserting elements\r\n* `@todo add more`\r\n\r\nComments\r\n----------------------------------------\r\n`@todo add in more`\r\n","created_at":"2018-11-26T04:01:46Z","updated_at":"2018-11-29T15:57:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05e5bca113be76f1d487cbe6d1385d2c43dcad92","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/colemanw/webform_civicrm/pulls/185/commits","review_comments_url":"https://api.github.com/repos/colemanw/webform_civicrm/pulls/185/comments","review_comment_url":"https://api.github.com/repos/colemanw/webform_civicrm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/colemanw/webform_civicrm/issues/185/comments","statuses_url":"https://api.github.com/repos/colemanw/webform_civicrm/statuses/50eeda0bcc88e283e137ce1cb246f13591746166","head":{"label":"mglaman:payments","ref":"payments","sha":"50eeda0bcc88e283e137ce1cb246f13591746166","user":{"login":"mglaman","id":3698644,"node_id":"MDQ6VXNlcjM2OTg2NDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3698644?v=4","gravatar_id":"","url":"https://api.github.com/users/mglaman","html_url":"https://github.com/mglaman","followers_url":"https://api.github.com/users/mglaman/followers","following_url":"https://api.github.com/users/mglaman/following{/other_user}","gists_url":"https://api.github.com/users/mglaman/gists{/gist_id}","starred_url":"https://api.github.com/users/mglaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mglaman/subscriptions","organizations_url":"https://api.github.com/users/mglaman/orgs","repos_url":"https://api.github.com/users/mglaman/repos","events_url":"https://api.github.com/users/mglaman/events{/privacy}","received_events_url":"https://api.github.com/users/mglaman/received_events","type":"User","site_admin":false},"repo":{"id":146042139,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYwNDIxMzk=","name":"webform_civicrm","full_name":"mglaman/webform_civicrm","private":false,"owner":{"login":"mglaman","id":3698644,"node_id":"MDQ6VXNlcjM2OTg2NDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3698644?v=4","gravatar_id":"","url":"https://api.github.com/users/mglaman","html_url":"https://github.com/mglaman","followers_url":"https://api.github.com/users/mglaman/followers","following_url":"https://api.github.com/users/mglaman/following{/other_user}","gists_url":"https://api.github.com/users/mglaman/gists{/gist_id}","starred_url":"https://api.github.com/users/mglaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mglaman/subscriptions","organizations_url":"https://api.github.com/users/mglaman/orgs","repos_url":"https://api.github.com/users/mglaman/repos","events_url":"https://api.github.com/users/mglaman/events{/privacy}","received_events_url":"https://api.github.com/users/mglaman/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mglaman/webform_civicrm","description":"A powerful, flexible, user-friendly form builder for CiviCRM.","fork":true,"url":"https://api.github.com/repos/mglaman/webform_civicrm","forks_url":"https://api.github.com/repos/mglaman/webform_civicrm/forks","keys_url":"https://api.github.com/repos/mglaman/webform_civicrm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mglaman/webform_civicrm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mglaman/webform_civicrm/teams","hooks_url":"https://api.github.com/repos/mglaman/webform_civicrm/hooks","issue_events_url":"https://api.github.com/repos/mglaman/webform_civicrm/issues/events{/number}","events_url":"https://api.github.com/repos/mglaman/webform_civicrm/events","assignees_url":"https://api.github.com/repos/mglaman/webform_civicrm/assignees{/user}","branches_url":"https://api.github.com/repos/mglaman/webform_civicrm/branches{/branch}","tags_url":"https://api.github.com/repos/mglaman/webform_civicrm/tags","blobs_url":"https://api.github.com/repos/mglaman/webform_civicrm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mglaman/webform_civicrm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mglaman/webform_civicrm/git/refs{/sha}","trees_url":"https://api.github.com/repos/mglaman/webform_civicrm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mglaman/webform_civicrm/statuses/{sha}","languages_url":"https://api.github.com/repos/mglaman/webform_civicrm/languages","stargazers_url":"https://api.github.com/repos/mglaman/webform_civicrm/stargazers","contributors_url":"https://api.github.com/repos/mglaman/webform_civicrm/contributors","subscribers_url":"https://api.github.com/repos/mglaman/webform_civicrm/subscribers","subscription_url":"https://api.github.com/repos/mglaman/webform_civicrm/subscription","commits_url":"https://api.github.com/repos/mglaman/webform_civicrm/commits{/sha}","git_commits_url":"https://api.github.com/repos/mglaman/webform_civicrm/git/commits{/sha}","comments_url":"https://api.github.com/repos/mglaman/webform_civicrm/comments{/number}","issue_comment_url":"https://api.github.com/repos/mglaman/webform_civicrm/issues/comments{/number}","contents_url":"https://api.github.com/repos/mglaman/webform_civicrm/contents/{+path}","compare_url":"https://api.github.com/repos/mglaman/webform_civicrm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mglaman/webform_civicrm/merges","archive_url":"https://api.github.com/repos/mglaman/webform_civicrm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mglaman/webform_civicrm/downloads","issues_url":"https://api.github.com/repos/mglaman/webform_civicrm/issues{/number}","pulls_url":"https://api.github.com/repos/mglaman/webform_civicrm/pulls{/number}","milestones_url":"https://api.github.com/repos/mglaman/webform_civicrm/milestones{/number}","notifications_url":"https://api.github.com/repos/mglaman/webform_civicrm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mglaman/webform_civicrm/labels{/name}","releases_url":"https://api.github.com/repos/mglaman/webform_civicrm/releases{/id}","deployments_url":"https://api.github.com/repos/mglaman/webform_civicrm/deployments","created_at":"2018-08-24T21:36:26Z","updated_at":"2018-11-21T03:24:11Z","pushed_at":"2018-11-29T04:22:44Z","git_url":"git://github.com/mglaman/webform_civicrm.git","ssh_url":"git@github.com:mglaman/webform_civicrm.git","clone_url":"https://github.com/mglaman/webform_civicrm.git","svn_url":"https://github.com/mglaman/webform_civicrm","homepage":"https://www.drupal.org/project/webform_civicrm","size":2026,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":0,"default_branch":"8.x-5.x"}},"base":{"label":"colemanw:8.x-5.x","ref":"8.x-5.x","sha":"823e673f618a8d64a91a20955c46078760256a12","user":{"login":"colemanw","id":2874912,"node_id":"MDQ6VXNlcjI4NzQ5MTI=","avatar_url":"https://avatars3.githubusercontent.com/u/2874912?v=4","gravatar_id":"","url":"https://api.github.com/users/colemanw","html_url":"https://github.com/colemanw","followers_url":"https://api.github.com/users/colemanw/followers","following_url":"https://api.github.com/users/colemanw/following{/other_user}","gists_url":"https://api.github.com/users/colemanw/gists{/gist_id}","starred_url":"https://api.github.com/users/colemanw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colemanw/subscriptions","organizations_url":"https://api.github.com/users/colemanw/orgs","repos_url":"https://api.github.com/users/colemanw/repos","events_url":"https://api.github.com/users/colemanw/events{/privacy}","received_events_url":"https://api.github.com/users/colemanw/received_events","type":"User","site_admin":false},"repo":{"id":33629346,"node_id":"MDEwOlJlcG9zaXRvcnkzMzYyOTM0Ng==","name":"webform_civicrm","full_name":"colemanw/webform_civicrm","private":false,"owner":{"login":"colemanw","id":2874912,"node_id":"MDQ6VXNlcjI4NzQ5MTI=","avatar_url":"https://avatars3.githubusercontent.com/u/2874912?v=4","gravatar_id":"","url":"https://api.github.com/users/colemanw","html_url":"https://github.com/colemanw","followers_url":"https://api.github.com/users/colemanw/followers","following_url":"https://api.github.com/users/colemanw/following{/other_user}","gists_url":"https://api.github.com/users/colemanw/gists{/gist_id}","starred_url":"https://api.github.com/users/colemanw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colemanw/subscriptions","organizations_url":"https://api.github.com/users/colemanw/orgs","repos_url":"https://api.github.com/users/colemanw/repos","events_url":"https://api.github.com/users/colemanw/events{/privacy}","received_events_url":"https://api.github.com/users/colemanw/received_events","type":"User","site_admin":false},"html_url":"https://github.com/colemanw/webform_civicrm","description":"A powerful, flexible, user-friendly form builder for CiviCRM.","fork":false,"url":"https://api.github.com/repos/colemanw/webform_civicrm","forks_url":"https://api.github.com/repos/colemanw/webform_civicrm/forks","keys_url":"https://api.github.com/repos/colemanw/webform_civicrm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/colemanw/webform_civicrm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/colemanw/webform_civicrm/teams","hooks_url":"https://api.github.com/repos/colemanw/webform_civicrm/hooks","issue_events_url":"https://api.github.com/repos/colemanw/webform_civicrm/issues/events{/number}","events_url":"https://api.github.com/repos/colemanw/webform_civicrm/events","assignees_url":"https://api.github.com/repos/colemanw/webform_civicrm/assignees{/user}","branches_url":"https://api.github.com/repos/colemanw/webform_civicrm/branches{/branch}","tags_url":"https://api.github.com/repos/colemanw/webform_civicrm/tags","blobs_url":"https://api.github.com/repos/colemanw/webform_civicrm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/colemanw/webform_civicrm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/colemanw/webform_civicrm/git/refs{/sha}","trees_url":"https://api.github.com/repos/colemanw/webform_civicrm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/colemanw/webform_civicrm/statuses/{sha}","languages_url":"https://api.github.com/repos/colemanw/webform_civicrm/languages","stargazers_url":"https://api.github.com/repos/colemanw/webform_civicrm/stargazers","contributors_url":"https://api.github.com/repos/colemanw/webform_civicrm/contributors","subscribers_url":"https://api.github.com/repos/colemanw/webform_civicrm/subscribers","subscription_url":"https://api.github.com/repos/colemanw/webform_civicrm/subscription","commits_url":"https://api.github.com/repos/colemanw/webform_civicrm/commits{/sha}","git_commits_url":"https://api.github.com/repos/colemanw/webform_civicrm/git/commits{/sha}","comments_url":"https://api.github.com/repos/colemanw/webform_civicrm/comments{/number}","issue_comment_url":"https://api.github.com/repos/colemanw/webform_civicrm/issues/comments{/number}","contents_url":"https://api.github.com/repos/colemanw/webform_civicrm/contents/{+path}","compare_url":"https://api.github.com/repos/colemanw/webform_civicrm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/colemanw/webform_civicrm/merges","archive_url":"https://api.github.com/repos/colemanw/webform_civicrm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/colemanw/webform_civicrm/downloads","issues_url":"https://api.github.com/repos/colemanw/webform_civicrm/issues{/number}","pulls_url":"https://api.github.com/repos/colemanw/webform_civicrm/pulls{/number}","milestones_url":"https://api.github.com/repos/colemanw/webform_civicrm/milestones{/number}","notifications_url":"https://api.github.com/repos/colemanw/webform_civicrm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/colemanw/webform_civicrm/labels{/name}","releases_url":"https://api.github.com/repos/colemanw/webform_civicrm/releases{/id}","deployments_url":"https://api.github.com/repos/colemanw/webform_civicrm/deployments","created_at":"2015-04-08T20:04:31Z","updated_at":"2018-11-23T16:59:57Z","pushed_at":"2018-11-29T04:22:45Z","git_url":"git://github.com/colemanw/webform_civicrm.git","ssh_url":"git@github.com:colemanw/webform_civicrm.git","clone_url":"https://github.com/colemanw/webform_civicrm.git","svn_url":"https://github.com/colemanw/webform_civicrm","homepage":"https://www.drupal.org/project/webform_civicrm","size":1884,"stargazers_count":12,"watchers_count":12,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":19,"license":null,"forks":58,"open_issues":19,"watchers":12,"default_branch":"7.x-4.x"}},"_links":{"self":{"href":"https://api.github.com/repos/colemanw/webform_civicrm/pulls/185"},"html":{"href":"https://github.com/colemanw/webform_civicrm/pull/185"},"issue":{"href":"https://api.github.com/repos/colemanw/webform_civicrm/issues/185"},"comments":{"href":"https://api.github.com/repos/colemanw/webform_civicrm/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/colemanw/webform_civicrm/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/colemanw/webform_civicrm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/colemanw/webform_civicrm/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/colemanw/webform_civicrm/statuses/50eeda0bcc88e283e137ce1cb246f13591746166"}},"author_association":"NONE"}}
{"actor":{"display_login":"dsnopek"}}