{"action":"opened","number":144,"pull_request":{"url":"https://api.github.com/repos/dcos/dcos-windows/pulls/144","id":221750584,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNzUwNTg0","html_url":"https://github.com/dcos/dcos-windows/pull/144","diff_url":"https://github.com/dcos/dcos-windows/pull/144.diff","patch_url":"https://github.com/dcos/dcos-windows/pull/144.patch","issue_url":"https://api.github.com/repos/dcos/dcos-windows/issues/144","number":144,"state":"open","locked":false,"title":"Conditions specified in service units are not fatal","user":{"login":"aserdean","id":5985012,"node_id":"MDQ6VXNlcjU5ODUwMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/5985012?v=4","gravatar_id":"","url":"https://api.github.com/users/aserdean","html_url":"https://github.com/aserdean","followers_url":"https://api.github.com/users/aserdean/followers","following_url":"https://api.github.com/users/aserdean/following{/other_user}","gists_url":"https://api.github.com/users/aserdean/gists{/gist_id}","starred_url":"https://api.github.com/users/aserdean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aserdean/subscriptions","organizations_url":"https://api.github.com/users/aserdean/orgs","repos_url":"https://api.github.com/users/aserdean/repos","events_url":"https://api.github.com/users/aserdean/events{/privacy}","received_events_url":"https://api.github.com/users/aserdean/received_events","type":"User","site_admin":false},"body":"The function `EvaluateConditions` verify if the service should start.\r\n\r\nWe returned an error if the conditions were not met, this patch fixes that.\r\n\r\nSigned-off-by: Alin Gabriel Serdean <aserdean@ovn.org>","created_at":"2018-10-10T11:18:09Z","updated_at":"2018-10-10T11:18:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos-windows/pulls/144/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos-windows/pulls/144/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos-windows/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos-windows/issues/144/comments","statuses_url":"https://api.github.com/repos/dcos/dcos-windows/statuses/f416cbe7028b80d9ef9d3ba86a65e1e5e384374c","head":{"label":"aserdean:dev","ref":"dev","sha":"f416cbe7028b80d9ef9d3ba86a65e1e5e384374c","user":{"login":"aserdean","id":5985012,"node_id":"MDQ6VXNlcjU5ODUwMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/5985012?v=4","gravatar_id":"","url":"https://api.github.com/users/aserdean","html_url":"https://github.com/aserdean","followers_url":"https://api.github.com/users/aserdean/followers","following_url":"https://api.github.com/users/aserdean/following{/other_user}","gists_url":"https://api.github.com/users/aserdean/gists{/gist_id}","starred_url":"https://api.github.com/users/aserdean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aserdean/subscriptions","organizations_url":"https://api.github.com/users/aserdean/orgs","repos_url":"https://api.github.com/users/aserdean/repos","events_url":"https://api.github.com/users/aserdean/events{/privacy}","received_events_url":"https://api.github.com/users/aserdean/received_events","type":"User","site_admin":false},"repo":{"id":130866088,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA4NjYwODg=","name":"dcos-windows","full_name":"aserdean/dcos-windows","private":false,"owner":{"login":"aserdean","id":5985012,"node_id":"MDQ6VXNlcjU5ODUwMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/5985012?v=4","gravatar_id":"","url":"https://api.github.com/users/aserdean","html_url":"https://github.com/aserdean","followers_url":"https://api.github.com/users/aserdean/followers","following_url":"https://api.github.com/users/aserdean/following{/other_user}","gists_url":"https://api.github.com/users/aserdean/gists{/gist_id}","starred_url":"https://api.github.com/users/aserdean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aserdean/subscriptions","organizations_url":"https://api.github.com/users/aserdean/orgs","repos_url":"https://api.github.com/users/aserdean/repos","events_url":"https://api.github.com/users/aserdean/events{/privacy}","received_events_url":"https://api.github.com/users/aserdean/received_events","type":"User","site_admin":false},"html_url":"https://github.com/aserdean/dcos-windows","description":"Microsoft Windows support to DCOS","fork":true,"url":"https://api.github.com/repos/aserdean/dcos-windows","forks_url":"https://api.github.com/repos/aserdean/dcos-windows/forks","keys_url":"https://api.github.com/repos/aserdean/dcos-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aserdean/dcos-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aserdean/dcos-windows/teams","hooks_url":"https://api.github.com/repos/aserdean/dcos-windows/hooks","issue_events_url":"https://api.github.com/repos/aserdean/dcos-windows/issues/events{/number}","events_url":"https://api.github.com/repos/aserdean/dcos-windows/events","assignees_url":"https://api.github.com/repos/aserdean/dcos-windows/assignees{/user}","branches_url":"https://api.github.com/repos/aserdean/dcos-windows/branches{/branch}","tags_url":"https://api.github.com/repos/aserdean/dcos-windows/tags","blobs_url":"https://api.github.com/repos/aserdean/dcos-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aserdean/dcos-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aserdean/dcos-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/aserdean/dcos-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aserdean/dcos-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/aserdean/dcos-windows/languages","stargazers_url":"https://api.github.com/repos/aserdean/dcos-windows/stargazers","contributors_url":"https://api.github.com/repos/aserdean/dcos-windows/contributors","subscribers_url":"https://api.github.com/repos/aserdean/dcos-windows/subscribers","subscription_url":"https://api.github.com/repos/aserdean/dcos-windows/subscription","commits_url":"https://api.github.com/repos/aserdean/dcos-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/aserdean/dcos-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/aserdean/dcos-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/aserdean/dcos-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/aserdean/dcos-windows/contents/{+path}","compare_url":"https://api.github.com/repos/aserdean/dcos-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aserdean/dcos-windows/merges","archive_url":"https://api.github.com/repos/aserdean/dcos-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aserdean/dcos-windows/downloads","issues_url":"https://api.github.com/repos/aserdean/dcos-windows/issues{/number}","pulls_url":"https://api.github.com/repos/aserdean/dcos-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/aserdean/dcos-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/aserdean/dcos-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aserdean/dcos-windows/labels{/name}","releases_url":"https://api.github.com/repos/aserdean/dcos-windows/releases{/id}","deployments_url":"https://api.github.com/repos/aserdean/dcos-windows/deployments","created_at":"2018-04-24T14:21:30Z","updated_at":"2018-04-24T14:21:32Z","pushed_at":"2018-10-10T11:17:41Z","git_url":"git://github.com/aserdean/dcos-windows.git","ssh_url":"git@github.com:aserdean/dcos-windows.git","clone_url":"https://github.com/aserdean/dcos-windows.git","svn_url":"https://github.com/aserdean/dcos-windows","homepage":null,"size":894,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dcos:master","ref":"master","sha":"51778d2ec3cc98c7e2576b828d655c2b0fd5f757","user":{"login":"dcos","id":17648048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjQ4MDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":101694182,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE2OTQxODI=","name":"dcos-windows","full_name":"dcos/dcos-windows","private":false,"owner":{"login":"dcos","id":17648048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjQ4MDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dcos/dcos-windows","description":"Microsoft Windows support to DCOS","fork":false,"url":"https://api.github.com/repos/dcos/dcos-windows","forks_url":"https://api.github.com/repos/dcos/dcos-windows/forks","keys_url":"https://api.github.com/repos/dcos/dcos-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos-windows/teams","hooks_url":"https://api.github.com/repos/dcos/dcos-windows/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos-windows/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos-windows/events","assignees_url":"https://api.github.com/repos/dcos/dcos-windows/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos-windows/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos-windows/tags","blobs_url":"https://api.github.com/repos/dcos/dcos-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos-windows/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos-windows/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos-windows/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos-windows/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos-windows/subscription","commits_url":"https://api.github.com/repos/dcos/dcos-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos-windows/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos-windows/merges","archive_url":"https://api.github.com/repos/dcos/dcos-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos-windows/downloads","issues_url":"https://api.github.com/repos/dcos/dcos-windows/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos-windows/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos-windows/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos-windows/deployments","created_at":"2017-08-28T22:36:57Z","updated_at":"2018-10-09T20:03:02Z","pushed_at":"2018-10-09T20:13:52Z","git_url":"git://github.com/dcos/dcos-windows.git","ssh_url":"git@github.com:dcos/dcos-windows.git","clone_url":"https://github.com/dcos/dcos-windows.git","svn_url":"https://github.com/dcos/dcos-windows","homepage":null,"size":892,"stargazers_count":10,"watchers_count":10,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":12,"open_issues":1,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos-windows/pulls/144"},"html":{"href":"https://github.com/dcos/dcos-windows/pull/144"},"issue":{"href":"https://api.github.com/repos/dcos/dcos-windows/issues/144"},"comments":{"href":"https://api.github.com/repos/dcos/dcos-windows/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos-windows/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos-windows/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos-windows/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos-windows/statuses/f416cbe7028b80d9ef9d3ba86a65e1e5e384374c"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"aserdean"}}