{"action":"created","comment":{"url":"https://api.github.com/repos/DextApp/dext/pulls/comments/181566877","pull_request_review_id":112222390,"id":181566877,"diff_hunk":"@@ -277,29 +276,18 @@ const handleQueryCommand = (evt, { q: queryPhrase }, plugins) => {\n \n /**\n  * Retrieve item details and sends back the response.\n- * Loads from cache if necessary.\n  *\n  * @param {Event} evt\n  * @param {Object} item\n  */\n const handleItemDetailsRequest = (evt, item) => {\n-  // set empty content\n-  let content = '';\n-  // load from cache if available\n-  const configName = `${path.basename(item.plugin.path)}-itemDetails`;\n-  const cacheConf = new CacheConf({ configName });\n-  const cacheKey = JSON.stringify(item);\n-  if (cacheConf.has(cacheKey)) {\n-    content = cacheConf.get(cacheKey);\n-  } else {\n-    // otherwise, load from plugin\n-    // eslint-disable-next-line global-require, import/no-dynamic-require\n-    const plugin = require(item.plugin.path);\n-    content = retrieveItemDetails(item, plugin);\n-  }\n+  // otherwise, load from plugin\n+  // eslint-disable-next-line global-require, import/no-dynamic-require\n+  const plugin = require(item.plugin.path);\n+  // @todo - cache content\n+  const content = retrieveItemDetails(item, plugin);\n   // resolve and update the state\n   Promise.resolve(content).then(html => {\n-    cacheConf.set(cacheKey, html);","path":"app/main/index.js","position":39,"original_position":39,"commit_id":"352784e60efcfe6c0598b9748d793aea20187c57","original_commit_id":"352784e60efcfe6c0598b9748d793aea20187c57","user":{"login":"adnasa","id":462507,"avatar_url":"https://avatars1.githubusercontent.com/u/462507?v=4","gravatar_id":"","url":"https://api.github.com/users/adnasa","html_url":"https://github.com/adnasa","followers_url":"https://api.github.com/users/adnasa/followers","following_url":"https://api.github.com/users/adnasa/following{/other_user}","gists_url":"https://api.github.com/users/adnasa/gists{/gist_id}","starred_url":"https://api.github.com/users/adnasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adnasa/subscriptions","organizations_url":"https://api.github.com/users/adnasa/orgs","repos_url":"https://api.github.com/users/adnasa/repos","events_url":"https://api.github.com/users/adnasa/events{/privacy}","received_events_url":"https://api.github.com/users/adnasa/received_events","type":"User","site_admin":false},"body":"aah cool.\r\nIsn't it a matter of replacing this with `config.set()`, since `conf` actually inherits from `Conf` ? :bowtie: \r\n\r\nmaybe that doesn't work and I'm missing something.","created_at":"2018-04-15T00:08:50Z","updated_at":"2018-04-15T00:09:31Z","html_url":"https://github.com/DextApp/dext/pull/204#discussion_r181566877","pull_request_url":"https://api.github.com/repos/DextApp/dext/pulls/204","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/DextApp/dext/pulls/comments/181566877"},"html":{"href":"https://github.com/DextApp/dext/pull/204#discussion_r181566877"},"pull_request":{"href":"https://api.github.com/repos/DextApp/dext/pulls/204"}}},"pull_request":{"url":"https://api.github.com/repos/DextApp/dext/pulls/204","id":181673190,"html_url":"https://github.com/DextApp/dext/pull/204","diff_url":"https://github.com/DextApp/dext/pull/204.diff","patch_url":"https://github.com/DextApp/dext/pull/204.patch","issue_url":"https://api.github.com/repos/DextApp/dext/issues/204","number":204,"state":"open","locked":false,"title":"remove CacheConf; add tests for utils/conf","user":{"login":"vutran","id":1088312,"avatar_url":"https://avatars2.githubusercontent.com/u/1088312?v=4","gravatar_id":"","url":"https://api.github.com/users/vutran","html_url":"https://github.com/vutran","followers_url":"https://api.github.com/users/vutran/followers","following_url":"https://api.github.com/users/vutran/following{/other_user}","gists_url":"https://api.github.com/users/vutran/gists{/gist_id}","starred_url":"https://api.github.com/users/vutran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vutran/subscriptions","organizations_url":"https://api.github.com/users/vutran/orgs","repos_url":"https://api.github.com/users/vutran/repos","events_url":"https://api.github.com/users/vutran/events{/privacy}","received_events_url":"https://api.github.com/users/vutran/received_events","type":"User","site_admin":false},"body":"This diff removes `utils/CacheConf` (temporarily; a todo has been added for reimplementing caching which can be discussed in a new thread).\r\n\r\nThis also includes a spec file for `utils/conf`.","created_at":"2018-04-15T00:03:48Z","updated_at":"2018-04-15T00:09:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"032b20c7cd7d9e90062c770e7e8b69385b7cd25e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DextApp/dext/pulls/204/commits","review_comments_url":"https://api.github.com/repos/DextApp/dext/pulls/204/comments","review_comment_url":"https://api.github.com/repos/DextApp/dext/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DextApp/dext/issues/204/comments","statuses_url":"https://api.github.com/repos/DextApp/dext/statuses/352784e60efcfe6c0598b9748d793aea20187c57","head":{"label":"DextApp:197-consolidate-conf","ref":"197-consolidate-conf","sha":"352784e60efcfe6c0598b9748d793aea20187c57","user":{"login":"DextApp","id":22943047,"avatar_url":"https://avatars1.githubusercontent.com/u/22943047?v=4","gravatar_id":"","url":"https://api.github.com/users/DextApp","html_url":"https://github.com/DextApp","followers_url":"https://api.github.com/users/DextApp/followers","following_url":"https://api.github.com/users/DextApp/following{/other_user}","gists_url":"https://api.github.com/users/DextApp/gists{/gist_id}","starred_url":"https://api.github.com/users/DextApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DextApp/subscriptions","organizations_url":"https://api.github.com/users/DextApp/orgs","repos_url":"https://api.github.com/users/DextApp/repos","events_url":"https://api.github.com/users/DextApp/events{/privacy}","received_events_url":"https://api.github.com/users/DextApp/received_events","type":"Organization","site_admin":false},"repo":{"id":66712801,"name":"dext","full_name":"DextApp/dext","owner":{"login":"DextApp","id":22943047,"avatar_url":"https://avatars1.githubusercontent.com/u/22943047?v=4","gravatar_id":"","url":"https://api.github.com/users/DextApp","html_url":"https://github.com/DextApp","followers_url":"https://api.github.com/users/DextApp/followers","following_url":"https://api.github.com/users/DextApp/following{/other_user}","gists_url":"https://api.github.com/users/DextApp/gists{/gist_id}","starred_url":"https://api.github.com/users/DextApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DextApp/subscriptions","organizations_url":"https://api.github.com/users/DextApp/orgs","repos_url":"https://api.github.com/users/DextApp/repos","events_url":"https://api.github.com/users/DextApp/events{/privacy}","received_events_url":"https://api.github.com/users/DextApp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DextApp/dext","description":"🔍 A smart launcher. Powered by JavaScript.","fork":false,"url":"https://api.github.com/repos/DextApp/dext","forks_url":"https://api.github.com/repos/DextApp/dext/forks","keys_url":"https://api.github.com/repos/DextApp/dext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DextApp/dext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DextApp/dext/teams","hooks_url":"https://api.github.com/repos/DextApp/dext/hooks","issue_events_url":"https://api.github.com/repos/DextApp/dext/issues/events{/number}","events_url":"https://api.github.com/repos/DextApp/dext/events","assignees_url":"https://api.github.com/repos/DextApp/dext/assignees{/user}","branches_url":"https://api.github.com/repos/DextApp/dext/branches{/branch}","tags_url":"https://api.github.com/repos/DextApp/dext/tags","blobs_url":"https://api.github.com/repos/DextApp/dext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DextApp/dext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DextApp/dext/git/refs{/sha}","trees_url":"https://api.github.com/repos/DextApp/dext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DextApp/dext/statuses/{sha}","languages_url":"https://api.github.com/repos/DextApp/dext/languages","stargazers_url":"https://api.github.com/repos/DextApp/dext/stargazers","contributors_url":"https://api.github.com/repos/DextApp/dext/contributors","subscribers_url":"https://api.github.com/repos/DextApp/dext/subscribers","subscription_url":"https://api.github.com/repos/DextApp/dext/subscription","commits_url":"https://api.github.com/repos/DextApp/dext/commits{/sha}","git_commits_url":"https://api.github.com/repos/DextApp/dext/git/commits{/sha}","comments_url":"https://api.github.com/repos/DextApp/dext/comments{/number}","issue_comment_url":"https://api.github.com/repos/DextApp/dext/issues/comments{/number}","contents_url":"https://api.github.com/repos/DextApp/dext/contents/{+path}","compare_url":"https://api.github.com/repos/DextApp/dext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DextApp/dext/merges","archive_url":"https://api.github.com/repos/DextApp/dext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DextApp/dext/downloads","issues_url":"https://api.github.com/repos/DextApp/dext/issues{/number}","pulls_url":"https://api.github.com/repos/DextApp/dext/pulls{/number}","milestones_url":"https://api.github.com/repos/DextApp/dext/milestones{/number}","notifications_url":"https://api.github.com/repos/DextApp/dext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DextApp/dext/labels{/name}","releases_url":"https://api.github.com/repos/DextApp/dext/releases{/id}","deployments_url":"https://api.github.com/repos/DextApp/dext/deployments","created_at":"2016-08-27T12:11:22Z","updated_at":"2018-04-14T23:16:19Z","pushed_at":"2018-04-15T00:03:49Z","git_url":"git://github.com/DextApp/dext.git","ssh_url":"git@github.com:DextApp/dext.git","clone_url":"https://github.com/DextApp/dext.git","svn_url":"https://github.com/DextApp/dext","homepage":"","size":77489,"stargazers_count":607,"watchers_count":607,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":51,"open_issues":18,"watchers":607,"default_branch":"develop"}},"base":{"label":"DextApp:develop","ref":"develop","sha":"332acc3bccd8987dac3f548d54e3a26a06d4a7b3","user":{"login":"DextApp","id":22943047,"avatar_url":"https://avatars1.githubusercontent.com/u/22943047?v=4","gravatar_id":"","url":"https://api.github.com/users/DextApp","html_url":"https://github.com/DextApp","followers_url":"https://api.github.com/users/DextApp/followers","following_url":"https://api.github.com/users/DextApp/following{/other_user}","gists_url":"https://api.github.com/users/DextApp/gists{/gist_id}","starred_url":"https://api.github.com/users/DextApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DextApp/subscriptions","organizations_url":"https://api.github.com/users/DextApp/orgs","repos_url":"https://api.github.com/users/DextApp/repos","events_url":"https://api.github.com/users/DextApp/events{/privacy}","received_events_url":"https://api.github.com/users/DextApp/received_events","type":"Organization","site_admin":false},"repo":{"id":66712801,"name":"dext","full_name":"DextApp/dext","owner":{"login":"DextApp","id":22943047,"avatar_url":"https://avatars1.githubusercontent.com/u/22943047?v=4","gravatar_id":"","url":"https://api.github.com/users/DextApp","html_url":"https://github.com/DextApp","followers_url":"https://api.github.com/users/DextApp/followers","following_url":"https://api.github.com/users/DextApp/following{/other_user}","gists_url":"https://api.github.com/users/DextApp/gists{/gist_id}","starred_url":"https://api.github.com/users/DextApp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DextApp/subscriptions","organizations_url":"https://api.github.com/users/DextApp/orgs","repos_url":"https://api.github.com/users/DextApp/repos","events_url":"https://api.github.com/users/DextApp/events{/privacy}","received_events_url":"https://api.github.com/users/DextApp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DextApp/dext","description":"🔍 A smart launcher. Powered by JavaScript.","fork":false,"url":"https://api.github.com/repos/DextApp/dext","forks_url":"https://api.github.com/repos/DextApp/dext/forks","keys_url":"https://api.github.com/repos/DextApp/dext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DextApp/dext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DextApp/dext/teams","hooks_url":"https://api.github.com/repos/DextApp/dext/hooks","issue_events_url":"https://api.github.com/repos/DextApp/dext/issues/events{/number}","events_url":"https://api.github.com/repos/DextApp/dext/events","assignees_url":"https://api.github.com/repos/DextApp/dext/assignees{/user}","branches_url":"https://api.github.com/repos/DextApp/dext/branches{/branch}","tags_url":"https://api.github.com/repos/DextApp/dext/tags","blobs_url":"https://api.github.com/repos/DextApp/dext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DextApp/dext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DextApp/dext/git/refs{/sha}","trees_url":"https://api.github.com/repos/DextApp/dext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DextApp/dext/statuses/{sha}","languages_url":"https://api.github.com/repos/DextApp/dext/languages","stargazers_url":"https://api.github.com/repos/DextApp/dext/stargazers","contributors_url":"https://api.github.com/repos/DextApp/dext/contributors","subscribers_url":"https://api.github.com/repos/DextApp/dext/subscribers","subscription_url":"https://api.github.com/repos/DextApp/dext/subscription","commits_url":"https://api.github.com/repos/DextApp/dext/commits{/sha}","git_commits_url":"https://api.github.com/repos/DextApp/dext/git/commits{/sha}","comments_url":"https://api.github.com/repos/DextApp/dext/comments{/number}","issue_comment_url":"https://api.github.com/repos/DextApp/dext/issues/comments{/number}","contents_url":"https://api.github.com/repos/DextApp/dext/contents/{+path}","compare_url":"https://api.github.com/repos/DextApp/dext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DextApp/dext/merges","archive_url":"https://api.github.com/repos/DextApp/dext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DextApp/dext/downloads","issues_url":"https://api.github.com/repos/DextApp/dext/issues{/number}","pulls_url":"https://api.github.com/repos/DextApp/dext/pulls{/number}","milestones_url":"https://api.github.com/repos/DextApp/dext/milestones{/number}","notifications_url":"https://api.github.com/repos/DextApp/dext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DextApp/dext/labels{/name}","releases_url":"https://api.github.com/repos/DextApp/dext/releases{/id}","deployments_url":"https://api.github.com/repos/DextApp/dext/deployments","created_at":"2016-08-27T12:11:22Z","updated_at":"2018-04-14T23:16:19Z","pushed_at":"2018-04-15T00:03:49Z","git_url":"git://github.com/DextApp/dext.git","ssh_url":"git@github.com:DextApp/dext.git","clone_url":"https://github.com/DextApp/dext.git","svn_url":"https://github.com/DextApp/dext","homepage":"","size":77489,"stargazers_count":607,"watchers_count":607,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":51,"open_issues":18,"watchers":607,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/DextApp/dext/pulls/204"},"html":{"href":"https://github.com/DextApp/dext/pull/204"},"issue":{"href":"https://api.github.com/repos/DextApp/dext/issues/204"},"comments":{"href":"https://api.github.com/repos/DextApp/dext/issues/204/comments"},"review_comments":{"href":"https://api.github.com/repos/DextApp/dext/pulls/204/comments"},"review_comment":{"href":"https://api.github.com/repos/DextApp/dext/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DextApp/dext/pulls/204/commits"},"statuses":{"href":"https://api.github.com/repos/DextApp/dext/statuses/352784e60efcfe6c0598b9748d793aea20187c57"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"adnasa"}}