{"action":"created","issue":{"url":"https://api.github.com/repos/astroidmail/astroid/issues/438","repository_url":"https://api.github.com/repos/astroidmail/astroid","labels_url":"https://api.github.com/repos/astroidmail/astroid/issues/438/labels{/name}","comments_url":"https://api.github.com/repos/astroidmail/astroid/issues/438/comments","events_url":"https://api.github.com/repos/astroidmail/astroid/issues/438/events","html_url":"https://github.com/astroidmail/astroid/pull/438","id":275081132,"number":438,"title":"Message ID Generation Enhancements","user":{"login":"c-alpha","id":2213269,"avatar_url":"https://avatars2.githubusercontent.com/u/2213269?v=4","gravatar_id":"","url":"https://api.github.com/users/c-alpha","html_url":"https://github.com/c-alpha","followers_url":"https://api.github.com/users/c-alpha/followers","following_url":"https://api.github.com/users/c-alpha/following{/other_user}","gists_url":"https://api.github.com/users/c-alpha/gists{/gist_id}","starred_url":"https://api.github.com/users/c-alpha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c-alpha/subscriptions","organizations_url":"https://api.github.com/users/c-alpha/orgs","repos_url":"https://api.github.com/users/c-alpha/repos","events_url":"https://api.github.com/users/c-alpha/events{/privacy}","received_events_url":"https://api.github.com/users/c-alpha/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2017-11-18T13:56:53Z","updated_at":"2018-02-01T17:12:59Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/astroidmail/astroid/pulls/438","html_url":"https://github.com/astroidmail/astroid/pull/438","diff_url":"https://github.com/astroidmail/astroid/pull/438.diff","patch_url":"https://github.com/astroidmail/astroid/pull/438.patch"},"body":"### Enhancements to the left of the `@`\r\n- If `mail.message_id_user` configuration file parameter is empty, nothing is inserted. Previously, `.astroid` was forcibly inserted. To retain the same factory default behaviour, the default config file template has been updated to set this parameter to `astroid`. The `.` is still inserted if `mail.message_id_user` is not empty to retain compatibility with existing configurations.\r\n- The generation of the random part has been updated to use the full set of allowed characters as per RFC 5322 to increase entropy and reduce risk of collisions. As a consequence, the message id can no longer be used as a file name for temp files. Hence, the generation of temp file names has been decoupled from the message id generation. Previously, external editors could recognize astroid temp files as email messages from the `@<fqdn>` naming convention (as the message id was used as the file name). To retain this scheme, a new config variable `editor.external_tmpfile_suffix` was introduced, with a default value of `.eml`. Consequently, the version of the configuration file format had to be bumped up to 10. **This may break compatibility with existing configurations** since the auto-detection in an external editor's configuration will likely need to be updated to recognize the new naming convention. Alternatively, if and only if the new `%1` parameter (cf. rhs changes below) is **not** used, the new `editor.external_tmpfile_suffix` parameter can be set to the same value as the `mail.message_id_fqdn` parameter in the astroid configuration (and in this case the external editor config can remain unchanged).\r\n### Enhancements to the right of the `@`\r\n- The `mail.message_id_fqdn` can now contain a `%1`, which is dynamically replaced with the FQDN of the from address of the message being composed. The FQDN is updated whenever the from address is changed, either in an external editor or via the drop-down menu. This ensures that the FQDN part of the message id always matches the FQDN of the account used for sending.\r\n(NOTE: Instead of a %1 parameter, this could also be made a per-account parameter, which would give the same effect. END NOTE)"},"comment":{"url":"https://api.github.com/repos/astroidmail/astroid/issues/comments/362336229","html_url":"https://github.com/astroidmail/astroid/pull/438#issuecomment-362336229","issue_url":"https://api.github.com/repos/astroidmail/astroid/issues/438","id":362336229,"user":{"login":"gauteh","id":56827,"avatar_url":"https://avatars2.githubusercontent.com/u/56827?v=4","gravatar_id":"","url":"https://api.github.com/users/gauteh","html_url":"https://github.com/gauteh","followers_url":"https://api.github.com/users/gauteh/followers","following_url":"https://api.github.com/users/gauteh/following{/other_user}","gists_url":"https://api.github.com/users/gauteh/gists{/gist_id}","starred_url":"https://api.github.com/users/gauteh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gauteh/subscriptions","organizations_url":"https://api.github.com/users/gauteh/orgs","repos_url":"https://api.github.com/users/gauteh/repos","events_url":"https://api.github.com/users/gauteh/events{/privacy}","received_events_url":"https://api.github.com/users/gauteh/received_events","type":"User","site_admin":false},"created_at":"2018-02-01T17:12:59Z","updated_at":"2018-02-01T17:12:59Z","author_association":"OWNER","body":"tor. 1. feb. 2018 kl. 17:48 skrev c-alpha <notifications@github.com>:\n\n> I finally got to take care of this again.\n>\n> Now, I'm getting Boost version warnings when running cmake:\n>\n> CMake Warning at /usr/local/Cellar/cmake/3.10.2/share/cmake/Modules/FindBoost.cmake:801 (message):\n>   New Boost version may have incorrect or missing dependencies and imported\n>   targets\n> Call Stack (most recent call first):\n>   /usr/local/Cellar/cmake/3.10.2/share/cmake/Modules/FindBoost.cmake:907 (_Boost_COMPONENT_DEPENDENCIES)\n>   /usr/local/Cellar/cmake/3.10.2/share/cmake/Modules/FindBoost.cmake:1542 (_Boost_MISSING_DEPENDENCIES)\n>   CMakeLists.txt:102 (find_package)\n>\n> And when I run the executable I built, it crashes on a missing symbol:\n>\n> dyld: Symbol not found: _UCNV_FROM_U_CALLBACK_ESCAPE_59\n>   Referenced from: /usr/local/opt/webkitgtk@2.4.11/lib/libwebkitgtk-3.0.0.dylib\n>   Expected in: flat namespace\n>  in /usr/local/opt/webkitgtk@2.4.11/lib/libwebkitgtk-3.0.0.dylib\n> Abort trap: 6\n>\n> Are those two issues related? Any hints appreciated. Please don't tell me\n> I need to rebuild webkitgtk@2.4.11... @gauteh <https://github.com/gauteh>\n> ?\n>\n>\nDoes not look too good.. maybe somewhat related to #459?\n\nMaybe you have to start with a fresh build dir. I am making fast progress\nwith webkit2 extension version. So we need to have WebKit2 on Mac soon too.\n"}}
{"actor":{"display_login":"gauteh"}}