{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/pulls/comments/240313807","pull_request_review_id":183315555,"id":240313807,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDMxMzgwNw==","diff_hunk":"@@ -47,9 +48,10 @@ pub unsafe fn size(mem: i32) -> i32 {\n #[inline]\n #[cfg_attr(test, assert_instr(\"memory.grow\", mem = 0))]\n #[rustc_args_required_const(0)]\n-pub unsafe fn grow(mem: i32, delta: i32) -> i32 {\n+#[stable(feature = \"simd_wasm32\", since = \"1.33.0\")]\n+pub unsafe fn memory_grow(mem: u32, delta: usize) -> isize {","path":"coresimd/wasm32/memory.rs","position":21,"original_position":21,"commit_id":"a4f96892a4be509be1ee847f1cd3133581605081","original_commit_id":"a4f96892a4be509be1ee847f1cd3133581605081","user":{"login":"gnzlbg","id":904614,"node_id":"MDQ6VXNlcjkwNDYxNA==","avatar_url":"https://avatars0.githubusercontent.com/u/904614?v=4","gravatar_id":"","url":"https://api.github.com/users/gnzlbg","html_url":"https://github.com/gnzlbg","followers_url":"https://api.github.com/users/gnzlbg/followers","following_url":"https://api.github.com/users/gnzlbg/following{/other_user}","gists_url":"https://api.github.com/users/gnzlbg/gists{/gist_id}","starred_url":"https://api.github.com/users/gnzlbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnzlbg/subscriptions","organizations_url":"https://api.github.com/users/gnzlbg/orgs","repos_url":"https://api.github.com/users/gnzlbg/repos","events_url":"https://api.github.com/users/gnzlbg/events{/privacy}","received_events_url":"https://api.github.com/users/gnzlbg/received_events","type":"User","site_admin":false},"body":"Good point. User programs can use `as` to go either way anyways, and to me it feels that both approaches have downsides - using `isize` might mean that negative values might indicate success, while using `usize` will confuse those trying to use `-1` here to catch errors like the spec suggests =/","created_at":"2018-12-10T17:50:40Z","updated_at":"2018-12-10T17:50:40Z","html_url":"https://github.com/rust-lang-nursery/stdsimd/pull/613#discussion_r240313807","pull_request_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/pulls/613","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/stdsimd/pulls/comments/240313807"},"html":{"href":"https://github.com/rust-lang-nursery/stdsimd/pull/613#discussion_r240313807"},"pull_request":{"href":"https://api.github.com/repos/rust-lang-nursery/stdsimd/pulls/613"}},"in_reply_to_id":240308094},"pull_request":{"url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/pulls/613","id":237104318,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MTA0MzE4","html_url":"https://github.com/rust-lang-nursery/stdsimd/pull/613","diff_url":"https://github.com/rust-lang-nursery/stdsimd/pull/613.diff","patch_url":"https://github.com/rust-lang-nursery/stdsimd/pull/613.patch","issue_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/issues/613","number":613,"state":"open","locked":false,"title":"Stabilize wasm32 memory-related intrinsics","user":{"login":"alexcrichton","id":64996,"node_id":"MDQ6VXNlcjY0OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"body":"This commit stabilizes the wasm32 memory-related intrinsics, as\r\nspecified in rust-lang/rust#56292. The old intrinsics were removed and\r\nthe current intrinsics were updated in place, but it's the last breaking\r\nchange!","created_at":"2018-12-09T02:46:35Z","updated_at":"2018-12-10T17:50:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e47d4c895435fe823a6312b4a9d7b3418feab74","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/pulls/613/commits","review_comments_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/pulls/613/comments","review_comment_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/issues/613/comments","statuses_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/statuses/a4f96892a4be509be1ee847f1cd3133581605081","head":{"label":"alexcrichton:wasm32-memory","ref":"wasm32-memory","sha":"a4f96892a4be509be1ee847f1cd3133581605081","user":{"login":"alexcrichton","id":64996,"node_id":"MDQ6VXNlcjY0OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"repo":{"id":94808412,"node_id":"MDEwOlJlcG9zaXRvcnk5NDgwODQxMg==","name":"stdsimd","full_name":"alexcrichton/stdsimd","private":false,"owner":{"login":"alexcrichton","id":64996,"node_id":"MDQ6VXNlcjY0OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alexcrichton/stdsimd","description":"Experiments with adding SIMD support to Rust's standard library.","fork":true,"url":"https://api.github.com/repos/alexcrichton/stdsimd","forks_url":"https://api.github.com/repos/alexcrichton/stdsimd/forks","keys_url":"https://api.github.com/repos/alexcrichton/stdsimd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexcrichton/stdsimd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexcrichton/stdsimd/teams","hooks_url":"https://api.github.com/repos/alexcrichton/stdsimd/hooks","issue_events_url":"https://api.github.com/repos/alexcrichton/stdsimd/issues/events{/number}","events_url":"https://api.github.com/repos/alexcrichton/stdsimd/events","assignees_url":"https://api.github.com/repos/alexcrichton/stdsimd/assignees{/user}","branches_url":"https://api.github.com/repos/alexcrichton/stdsimd/branches{/branch}","tags_url":"https://api.github.com/repos/alexcrichton/stdsimd/tags","blobs_url":"https://api.github.com/repos/alexcrichton/stdsimd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexcrichton/stdsimd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexcrichton/stdsimd/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexcrichton/stdsimd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexcrichton/stdsimd/statuses/{sha}","languages_url":"https://api.github.com/repos/alexcrichton/stdsimd/languages","stargazers_url":"https://api.github.com/repos/alexcrichton/stdsimd/stargazers","contributors_url":"https://api.github.com/repos/alexcrichton/stdsimd/contributors","subscribers_url":"https://api.github.com/repos/alexcrichton/stdsimd/subscribers","subscription_url":"https://api.github.com/repos/alexcrichton/stdsimd/subscription","commits_url":"https://api.github.com/repos/alexcrichton/stdsimd/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexcrichton/stdsimd/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexcrichton/stdsimd/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexcrichton/stdsimd/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexcrichton/stdsimd/contents/{+path}","compare_url":"https://api.github.com/repos/alexcrichton/stdsimd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexcrichton/stdsimd/merges","archive_url":"https://api.github.com/repos/alexcrichton/stdsimd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexcrichton/stdsimd/downloads","issues_url":"https://api.github.com/repos/alexcrichton/stdsimd/issues{/number}","pulls_url":"https://api.github.com/repos/alexcrichton/stdsimd/pulls{/number}","milestones_url":"https://api.github.com/repos/alexcrichton/stdsimd/milestones{/number}","notifications_url":"https://api.github.com/repos/alexcrichton/stdsimd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexcrichton/stdsimd/labels{/name}","releases_url":"https://api.github.com/repos/alexcrichton/stdsimd/releases{/id}","deployments_url":"https://api.github.com/repos/alexcrichton/stdsimd/deployments","created_at":"2017-06-19T18:30:07Z","updated_at":"2017-06-19T18:30:09Z","pushed_at":"2018-12-09T02:46:22Z","git_url":"git://github.com/alexcrichton/stdsimd.git","ssh_url":"git@github.com:alexcrichton/stdsimd.git","clone_url":"https://github.com/alexcrichton/stdsimd.git","svn_url":"https://github.com/alexcrichton/stdsimd","homepage":null,"size":2451,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang-nursery:master","ref":"master","sha":"5facdde64f311854f2161a6dba38227c61e1d603","user":{"login":"rust-lang-nursery","id":14631425,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NjMxNDI1","avatar_url":"https://avatars1.githubusercontent.com/u/14631425?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"repo":{"id":74716300,"node_id":"MDEwOlJlcG9zaXRvcnk3NDcxNjMwMA==","name":"stdsimd","full_name":"rust-lang-nursery/stdsimd","private":false,"owner":{"login":"rust-lang-nursery","id":14631425,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NjMxNDI1","avatar_url":"https://avatars1.githubusercontent.com/u/14631425?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rust-lang-nursery/stdsimd","description":"Rust's standard library vendor-specific APIs and run-time feature detection","fork":false,"url":"https://api.github.com/repos/rust-lang-nursery/stdsimd","forks_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/forks","keys_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/teams","hooks_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/hooks","issue_events_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/events","assignees_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/tags","blobs_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/languages","stargazers_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/stargazers","contributors_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/contributors","subscribers_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/subscribers","subscription_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/subscription","commits_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/merges","archive_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/downloads","issues_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang-nursery/stdsimd/deployments","created_at":"2016-11-25T01:41:18Z","updated_at":"2018-12-10T11:54:12Z","pushed_at":"2018-12-09T02:46:36Z","git_url":"git://github.com/rust-lang-nursery/stdsimd.git","ssh_url":"git@github.com:rust-lang-nursery/stdsimd.git","clone_url":"https://github.com/rust-lang-nursery/stdsimd.git","svn_url":"https://github.com/rust-lang-nursery/stdsimd","homepage":"https://doc.rust-lang.org/stable/std/arch/","size":7143,"stargazers_count":306,"watchers_count":306,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":74,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":74,"open_issues":61,"watchers":306,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/stdsimd/pulls/613"},"html":{"href":"https://github.com/rust-lang-nursery/stdsimd/pull/613"},"issue":{"href":"https://api.github.com/repos/rust-lang-nursery/stdsimd/issues/613"},"comments":{"href":"https://api.github.com/repos/rust-lang-nursery/stdsimd/issues/613/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang-nursery/stdsimd/pulls/613/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang-nursery/stdsimd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang-nursery/stdsimd/pulls/613/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang-nursery/stdsimd/statuses/a4f96892a4be509be1ee847f1cd3133581605081"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"gnzlbg"}}