{"push_id":2298933018,"size":32,"distinct_size":0,"ref":"refs/heads/master","head":"e03cb134c37d509748a249c694c52bb8a5c2cc7e","before":"3763d1affd278a83e09eae2926926e3db1883026","commits":[{"sha":"5733e444c3a483c22635384e6f121152bc40533e","author":{"name":"Max Katz","email":"8150216d735b4d962e4338e78a00908d30a2dbfe@stonybrook.edu"},"message":"Pass the state for the source terms as an argument to the source constructor\n\nThis generalizes the algorithm so that one can choose which state MultiFab\nto send in for calculating the source terms. This is a step in the direction\nof enabling source term calculations at arbitrary times, which is useful for\nMOL, and also allows the old source terms to be either calculated with either\nS_old or Sborder (which can be useful if trying to reconstruct the source\nterms at a later time when Sborder is no longer available).\n\nThis changes results for diffusion if reactions are also enabled, since\ndiffusion was previously using the unreacted S_old state, not Sborder.","distinct":false,"url":"https://api.github.com/repos/AMReX-Astro/Castro/commits/5733e444c3a483c22635384e6f121152bc40533e"},{"sha":"9ba533738bc1ae173ba62cac1b156ec340d1d2e0","author":{"name":"Max Katz","email":"8150216d735b4d962e4338e78a00908d30a2dbfe@stonybrook.edu"},"message":"Update CHANGES","distinct":false,"url":"https://api.github.com/repos/AMReX-Astro/Castro/commits/9ba533738bc1ae173ba62cac1b156ec340d1d2e0"},{"sha":"9a8e5446ff38b654678c3b502eb3bf3ac7a8e5fc","author":{"name":"Max Katz","email":"8150216d735b4d962e4338e78a00908d30a2dbfe@stonybrook.edu"},"message":"Rework the relaxation process using the approach of Rosswog et al. (2004)\n\nIn the past, the wdmerger relaxation used a source-term based approach similar\nto that of Rosswog, Speith and Wynn (2004) and Dan et al. (2011), that balanced\nthe rotation force against the gravitational and hydrodynamic forces. This was\nrecently changed to a simpler method for various reasons, some of which were\nrelated to Castro code changes (e.g. no longer explicitly storing the hydrodynamic\nforce) and the desire to make it easier to simulate only a half-domain (z > 0)\nfor symmetric problems; and, because the earlier implementation was found to not\nbe that robust anyway. The reason for this is probably that we were not really\ndoing what Rosswog et al. recommended. Rather, we were doing a related but different\napproach where we updated the rotation force for the next timestep to balance\nagainst what the gravitational and hydrodynamic forces were in this last\ntimestep. This meant that the rotation update was always lagging by a timestep,\nwhich led to an ineffective method.\n\nThis commit actually does what Rosswog et al. recommends. At the end of the\ntimestep, we calculate what the rotation source term should have been in\nthat timestep to balance the gravitational and hydrodynamic forces, and subtract\noff the rotation source term that was applied and replace it with the more\naccurate one. This means the relaxation step does not lag. Since we no longer\nstore the source terms individually, this requires a little bit of programming\nlegwork to do, but we achieve the desired result.","distinct":false,"url":"https://api.github.com/repos/AMReX-Astro/Castro/commits/9a8e5446ff38b654678c3b502eb3bf3ac7a8e5fc"},{"sha":"0fdeb99f05db07fb83e7abeb69235aeb976c77fb","author":{"name":"Max Katz","email":"4ec38646be517081132e93f0bce55dba77c5109b@gmail.com"},"message":"Zero out array between uses","distinct":false,"url":"https://api.github.com/repos/AMReX-Astro/Castro/commits/0fdeb99f05db07fb83e7abeb69235aeb976c77fb"},{"sha":"35a92b38c333b3e1ae1162ec5ccb9fa1d95b21e3","author":{"name":"Max Katz","email":"4ec38646be517081132e93f0bce55dba77c5109b@gmail.com"},"message":"Subtract off new-time sources before recalculating rotation source","distinct":false,"url":"https://api.github.com/repos/AMReX-Astro/Castro/commits/35a92b38c333b3e1ae1162ec5ccb9fa1d95b21e3"},{"sha":"7b86a38fcedf1bbf1aec2465b35efd3a2e7ab77c","author":{"name":"Max Katz","email":"4ec38646be517081132e93f0bce55dba77c5109b@gmail.com"},"message":"Add rotational period to diagnostic outputs","distinct":false,"url":"https://api.github.com/repos/AMReX-Astro/Castro/commits/7b86a38fcedf1bbf1aec2465b35efd3a2e7ab77c"},{"sha":"e5c2116ccd1d7f3a3cfee1d42d994de5d3002c49","author":{"name":"Max Katz","email":"8150216d735b4d962e4338e78a00908d30a2dbfe@stonybrook.edu"},"message":"Add column numbers to diagnostic output","distinct":false,"url":"https://api.github.com/repos/AMReX-Astro/Castro/commits/e5c2116ccd1d7f3a3cfee1d42d994de5d3002c49"},{"sha":"0f0c130fc3139c42251925b5c83a2312df406204","author":{"name":"Max Katz","email":"8150216d735b4d962e4338e78a00908d30a2dbfe@stonybrook.edu"},"message":"Fix some issues with multi-level relaxation\n\nThis still has problems for more than two levels though","distinct":false,"url":"https://api.github.com/repos/AMReX-Astro/Castro/commits/0f0c130fc3139c42251925b5c83a2312df406204"},{"sha":"5e8eb0f6f5c254dcd0fd5b82e2dd207d04467df4","author":{"name":"Max Katz","email":"8150216d735b4d962e4338e78a00908d30a2dbfe@stonybrook.edu"},"message":"Use initializer lists in reducerealsum","distinct":false,"url":"https://api.github.com/repos/AMReX-Astro/Castro/commits/5e8eb0f6f5c254dcd0fd5b82e2dd207d04467df4"},{"sha":"9f51d8552708f7d50412d0caf8e9946b9d612ed5","author":{"name":"Max Katz","email":"8150216d735b4d962e4338e78a00908d30a2dbfe@stonybrook.edu"},"message":"Merge branch 'development' into wdmerger_relaxation\n\nConflicts:\n\tCHANGES\n\tSource/driver/Castro.H\n\tSource/driver/Castro_advance.cpp","distinct":false,"url":"https://api.github.com/repos/AMReX-Astro/Castro/commits/9f51d8552708f7d50412d0caf8e9946b9d612ed5"},{"sha":"9ca101df67e78ddc41a70acc1562fd96a424c8a4","author":{"name":"Max Katz","email":"8150216d735b4d962e4338e78a00908d30a2dbfe@stonybrook.edu"},"message":"For relaxation, only balance against gravitational force","distinct":false,"url":"https://api.github.com/repos/AMReX-Astro/Castro/commits/9ca101df67e78ddc41a70acc1562fd96a424c8a4"},{"sha":"a8c610d3d84ba034eda3b86258f6ff1e146b867b","author":{"name":"Michael Zingale","email":"1241aad6561a47fb237fbe4dd1804a3919244931@stonybrook.edu"},"message":"SDC_Source_Type, old_sources, and new_sources no longer exist","distinct":false,"url":"https://api.github.com/repos/AMReX-Astro/Castro/commits/a8c610d3d84ba034eda3b86258f6ff1e146b867b"},{"sha":"67363497c8ef173a909523401619d447cd731464","author":{"name":"Michael Zingale","email":"1241aad6561a47fb237fbe4dd1804a3919244931@stonybrook.edu"},"message":"update initialization","distinct":false,"url":"https://api.github.com/repos/AMReX-Astro/Castro/commits/67363497c8ef173a909523401619d447cd731464"},{"sha":"456c2a90856ae7df97d6f6bc31ec9622ffd6e790","author":{"name":"Michael Zingale","email":"1241aad6561a47fb237fbe4dd1804a3919244931@stonybrook.edu"},"message":"more updates to reflect latest code","distinct":false,"url":"https://api.github.com/repos/AMReX-Astro/Castro/commits/456c2a90856ae7df97d6f6bc31ec9622ffd6e790"},{"sha":"b5416ef654cbb151f5027648e82485f015cda813","author":{"name":"Max Katz","email":"8150216d735b4d962e4338e78a00908d30a2dbfe@stonybrook.edu"},"message":"Add wdmerger problem 5, a tidal disruption event setup","distinct":false,"url":"https://api.github.com/repos/AMReX-Astro/Castro/commits/b5416ef654cbb151f5027648e82485f015cda813"},{"sha":"711934b4bc046304a1b8aa00619d33755d522205","author":{"name":"Max Katz","email":"8150216d735b4d962e4338e78a00908d30a2dbfe@stonybrook.edu"},"message":"Add a TDE test setup","distinct":false,"url":"https://api.github.com/repos/AMReX-Astro/Castro/commits/711934b4bc046304a1b8aa00619d33755d522205"},{"sha":"5ab40b2e2f1444e5902b6806fa7ad4c12678d4fa","author":{"name":"Max Katz","email":"8150216d735b4d962e4338e78a00908d30a2dbfe@stonybrook.edu"},"message":"Add parameter for disabling point mass","distinct":false,"url":"https://api.github.com/repos/AMReX-Astro/Castro/commits/5ab40b2e2f1444e5902b6806fa7ad4c12678d4fa"},{"sha":"dd027ece828966d06bad27986c65b4c46d5d7f36","author":{"name":"Max Katz","email":"4ec38646be517081132e93f0bce55dba77c5109b@gmail.com"},"message":"Add option to disable initial orbital motion for TDE","distinct":false,"url":"https://api.github.com/repos/AMReX-Astro/Castro/commits/dd027ece828966d06bad27986c65b4c46d5d7f36"},{"sha":"c79b5eb74fc983c799529e028bf25966598fd193","author":{"name":"Max Katz","email":"4ec38646be517081132e93f0bce55dba77c5109b@gmail.com"},"message":"Fix error in subroutine name","distinct":false,"url":"https://api.github.com/repos/AMReX-Astro/Castro/commits/c79b5eb74fc983c799529e028bf25966598fd193"},{"sha":"c3f656dd7cc9c12713c69dc9ef34b9f17bac7311","author":{"name":"Michael Zingale","email":"1241aad6561a47fb237fbe4dd1804a3919244931@stonybrook.edu"},"message":"fix an indexing bug","distinct":false,"url":"https://api.github.com/repos/AMReX-Astro/Castro/commits/c3f656dd7cc9c12713c69dc9ef34b9f17bac7311"}]}
{"actor":{"display_login":"zingale"}}