{"action":"created","issue":{"url":"https://api.github.com/repos/redcap-tools/PyCap/issues/91","repository_url":"https://api.github.com/repos/redcap-tools/PyCap","labels_url":"https://api.github.com/repos/redcap-tools/PyCap/issues/91/labels{/name}","comments_url":"https://api.github.com/repos/redcap-tools/PyCap/issues/91/comments","events_url":"https://api.github.com/repos/redcap-tools/PyCap/issues/91/events","html_url":"https://github.com/redcap-tools/PyCap/pull/91","id":393535600,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNTM0NDE0","number":91,"title":"Export reports","user":{"login":"mcarmack","id":2894022,"node_id":"MDQ6VXNlcjI4OTQwMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/2894022?v=4","gravatar_id":"","url":"https://api.github.com/users/mcarmack","html_url":"https://github.com/mcarmack","followers_url":"https://api.github.com/users/mcarmack/followers","following_url":"https://api.github.com/users/mcarmack/following{/other_user}","gists_url":"https://api.github.com/users/mcarmack/gists{/gist_id}","starred_url":"https://api.github.com/users/mcarmack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcarmack/subscriptions","organizations_url":"https://api.github.com/users/mcarmack/orgs","repos_url":"https://api.github.com/users/mcarmack/repos","events_url":"https://api.github.com/users/mcarmack/events{/privacy}","received_events_url":"https://api.github.com/users/mcarmack/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-21T17:31:53Z","updated_at":"2018-12-26T13:59:55Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/redcap-tools/PyCap/pulls/91","html_url":"https://github.com/redcap-tools/PyCap/pull/91","diff_url":"https://github.com/redcap-tools/PyCap/pull/91.diff","patch_url":"https://github.com/redcap-tools/PyCap/pull/91.patch"},"body":"Hello-\r\n\r\nThis is my first pull request to this project- I hugely appreciate any feedback or improvements you may have!\r\n\r\nI added a method to wrap the redcap API \"export reports\" method.\r\n\r\nThree things I am looking to learn/incorporate into my code before this pull request is considered:\r\n\r\n1. I saw in other methods there is some handling of the format \"df\" - I assume dataframe? As far as I can see in the RedCap API documentation, the formats data is returned in will only be csv, json, xml, or odm (cdisc odm xml, odm version 1.3.1).  So is the handling of the format 'df' unnecessary within this method? I see it is used in 'export_records' pycap method (which has the same format/return format options as export reports, per RedCap API documentation), so I included it in my export_reports method. Please advise.\r\n\r\n2. It is unclear to me from the RedCap API documentation exactly what is returned from the API call. Apparently it is, \"Data from the project in the format and type specified ordered by the record (primary key of project) and then by event id\". This leads me to believe it will be a list of records from a single report. If so, I'm not sure why the method is called \"export reports\" instead of \"export report\". Also, will all fields be returned, or just those of the report?\r\n\r\n3. Testing! I do not understand how to test this method without having it be part of the version of pycap I am using. Also, I would like to write some tests for the test file, but I would also appreciate guidance on best practice for that. \r\n\r\nThank you again for your help!"},"comment":{"url":"https://api.github.com/repos/redcap-tools/PyCap/issues/comments/449970447","html_url":"https://github.com/redcap-tools/PyCap/pull/91#issuecomment-449970447","issue_url":"https://api.github.com/repos/redcap-tools/PyCap/issues/91","id":449970447,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTk3MDQ0Nw==","user":{"login":"sburns","id":440820,"node_id":"MDQ6VXNlcjQ0MDgyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/440820?v=4","gravatar_id":"","url":"https://api.github.com/users/sburns","html_url":"https://github.com/sburns","followers_url":"https://api.github.com/users/sburns/followers","following_url":"https://api.github.com/users/sburns/following{/other_user}","gists_url":"https://api.github.com/users/sburns/gists{/gist_id}","starred_url":"https://api.github.com/users/sburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sburns/subscriptions","organizations_url":"https://api.github.com/users/sburns/orgs","repos_url":"https://api.github.com/users/sburns/repos","events_url":"https://api.github.com/users/sburns/events{/privacy}","received_events_url":"https://api.github.com/users/sburns/received_events","type":"User","site_admin":false},"created_at":"2018-12-26T13:59:55Z","updated_at":"2018-12-26T13:59:55Z","author_association":"COLLABORATOR","body":"Hi @mcarmack, thanks for this Pull-Request! I'm trying to stay away from the computer this holiday break :) I'll be able to give more feedback next week. "}}
{"actor":{"display_login":"sburns"}}