{"action":"created","issue":{"url":"https://api.github.com/repos/sardana-org/sardana/issues/771","repository_url":"https://api.github.com/repos/sardana-org/sardana","labels_url":"https://api.github.com/repos/sardana-org/sardana/issues/771/labels{/name}","comments_url":"https://api.github.com/repos/sardana-org/sardana/issues/771/comments","events_url":"https://api.github.com/repos/sardana-org/sardana/issues/771/events","html_url":"https://github.com/sardana-org/sardana/issues/771","id":327330991,"node_id":"MDU6SXNzdWUzMjczMzA5OTE=","number":771,"title":"write comments to scan header","user":{"login":"dschick","id":13797420,"node_id":"MDQ6VXNlcjEzNzk3NDIw","avatar_url":"https://avatars1.githubusercontent.com/u/13797420?v=4","gravatar_id":"","url":"https://api.github.com/users/dschick","html_url":"https://github.com/dschick","followers_url":"https://api.github.com/users/dschick/followers","following_url":"https://api.github.com/users/dschick/following{/other_user}","gists_url":"https://api.github.com/users/dschick/gists{/gist_id}","starred_url":"https://api.github.com/users/dschick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschick/subscriptions","organizations_url":"https://api.github.com/users/dschick/orgs","repos_url":"https://api.github.com/users/dschick/repos","events_url":"https://api.github.com/users/dschick/events{/privacy}","received_events_url":"https://api.github.com/users/dschick/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":19,"created_at":"2018-05-29T13:53:03Z","updated_at":"2018-06-13T06:35:10Z","closed_at":null,"author_association":"NONE","body":"I would like to add some comments to the scan header of my data files.\r\nThis would be similar to the prescan-snapshot functionality.\r\nI am thinking of putting some env parameters such as strings (sample name, etc) into the scan header.\r\nI guess I could solve that problem using the available functionality with the prescan snapshot, by storing my comments in a TangoDeviceServer, right?\r\n\r\nAre there any other implementations possible which are general enough to work with any of the DataRecorders?\r\n\r\nDaniel"},"comment":{"url":"https://api.github.com/repos/sardana-org/sardana/issues/comments/396829560","html_url":"https://github.com/sardana-org/sardana/issues/771#issuecomment-396829560","issue_url":"https://api.github.com/repos/sardana-org/sardana/issues/771","id":396829560,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjgyOTU2MA==","user":{"login":"rhomspuron","id":10775781,"node_id":"MDQ6VXNlcjEwNzc1Nzgx","avatar_url":"https://avatars0.githubusercontent.com/u/10775781?v=4","gravatar_id":"","url":"https://api.github.com/users/rhomspuron","html_url":"https://github.com/rhomspuron","followers_url":"https://api.github.com/users/rhomspuron/followers","following_url":"https://api.github.com/users/rhomspuron/following{/other_user}","gists_url":"https://api.github.com/users/rhomspuron/gists{/gist_id}","starred_url":"https://api.github.com/users/rhomspuron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhomspuron/subscriptions","organizations_url":"https://api.github.com/users/rhomspuron/orgs","repos_url":"https://api.github.com/users/rhomspuron/repos","events_url":"https://api.github.com/users/rhomspuron/events{/privacy}","received_events_url":"https://api.github.com/users/rhomspuron/received_events","type":"User","site_admin":false},"created_at":"2018-06-13T06:35:10Z","updated_at":"2018-06-13T06:35:10Z","author_association":"CONTRIBUTOR","body":"@dschick  I have a doubt about:\r\n\r\n> when changing the offsets/dial position of motors with a macro it is a good idea to write a comment to the SPEC file about the changed motor offset.\r\n\r\nDo you want to include the comment on the next scan header or you want to include the comment between two scan? \r\n\r\nIt tested to put a comment between two scan:\r\n```\r\n21 0.333333333333 0.5 0.1 0.2 0.3 0.4 2.94404803276\r\n22 0.666666666667 0.5 0.1 0.2 0.3 0.4 3.04404803276\r\n23 1.0 0.5 nan nan nan nan 3.14404803276\r\n24 0.0 0.6 0.1 0.2 0.3 0.4 3.40590001106\r\n25 0.333333333333 0.6 nan nan nan nan 3.50590001106\r\n26 0.666666666667 0.6 nan nan nan nan 3.60590001106\r\n27 1.0 0.6 0.1 0.2 0.3 0.4 3.70590001106\r\n28 0.0 0.7 nan nan nan nan 3.99890209198\r\n29 0.333333333333 0.7 0.1 0.2 0.3 0.4 4.09890209198\r\n30 0.666666666667 0.7 nan nan nan nan 4.19890209198\r\n31 1.0 0.7 0.1 0.2 0.3 0.4 4.29890209198\r\n32 0.0 0.8 nan nan nan nan 4.59029198647\r\n33 0.333333333333 0.8 0.1 0.2 0.3 0.4 4.69029198647\r\n34 0.666666666667 0.8 nan nan nan nan 4.79029198647\r\n35 1.0 0.8 0.1 0.2 0.3 0.4 4.89029198647\r\n36 0.0 0.9 nan nan nan nan 5.18151498795\r\n37 0.333333333333 0.9 0.1 0.2 0.3 0.4 5.28151498795\r\n38 0.666666666667 0.9 nan nan nan nan 5.38151498795\r\n39 1.0 0.9 0.1 0.2 0.3 0.4 5.48151498795\r\n40 0.0 1.0 nan nan nan nan 5.77212716103\r\n41 0.333333333333 1.0 0.1 0.2 0.3 0.4 5.87212716103\r\n42 0.666666666667 1.0 nan nan nan nan 5.97212716103\r\n43 1.0 1.0 0.1 0.2 0.3 0.4 6.07212716103\r\n#C Acquisition ended at Thu Nov 23 16:32:25 2017\r\n\r\n\r\n#C this is a test to see it is possible to read on\r\n#C pymca\r\n\r\n\r\n#S 252 meshct mot13 0.0 1.0 3 mot14 0.0 1.0 10 0.1 False 0.0\r\n#U sicilia\r\n#D 1511451167.0\r\n#C Acquisition started at Thu Nov 23 16:32:47 2017\r\n#N 8\r\n#L Pt_No  mot13  mot14  ct13  ct14  ct15  ct16  dt\r\n0 0.0 0.0 0.1 0.2 0.3 0.4 0.01\r\n1 0.333333333333 0.0 nan nan nan nan 0.11\r\n2 0.666666666667 0.0 nan nan nan nan 0.21\r\n\r\n```\r\nIn this case, pymca reads the comment as part of the previous scan 251:\r\n![screenshot_20180613_082243](https://user-images.githubusercontent.com/10775781/41333691-ff126e6c-6ee2-11e8-858e-6dfdd2f67062.png)\r\n\r\nOne possible solution is to implement a macro on sardana to include this comments on the file, but it will not use the recorder because we will not have data.  The macro must include the comment on hdf5 file too.\r\n\r\nIf the idea is to include the comments on the next scan, the solution of the environment variable should do it. We can implement macros to clean, add and remove comments from this variable. \r\nWhat do you think?\r\n"}}
{"actor":{"display_login":"rhomspuron"}}