{"action":"created","issue":{"url":"https://api.github.com/repos/icetee/remote-ftp/issues/650","repository_url":"https://api.github.com/repos/icetee/remote-ftp","labels_url":"https://api.github.com/repos/icetee/remote-ftp/issues/650/labels{/name}","comments_url":"https://api.github.com/repos/icetee/remote-ftp/issues/650/comments","events_url":"https://api.github.com/repos/icetee/remote-ftp/issues/650/events","html_url":"https://github.com/icetee/remote-ftp/issues/650","id":202376228,"node_id":"MDU6SXNzdWUyMDIzNzYyMjg=","number":650,"title":"Add support for git-diff","user":{"login":"Wombosvideo","id":4274488,"node_id":"MDQ6VXNlcjQyNzQ0ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/4274488?v=4","gravatar_id":"","url":"https://api.github.com/users/Wombosvideo","html_url":"https://github.com/Wombosvideo","followers_url":"https://api.github.com/users/Wombosvideo/followers","following_url":"https://api.github.com/users/Wombosvideo/following{/other_user}","gists_url":"https://api.github.com/users/Wombosvideo/gists{/gist_id}","starred_url":"https://api.github.com/users/Wombosvideo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wombosvideo/subscriptions","organizations_url":"https://api.github.com/users/Wombosvideo/orgs","repos_url":"https://api.github.com/users/Wombosvideo/repos","events_url":"https://api.github.com/users/Wombosvideo/events{/privacy}","received_events_url":"https://api.github.com/users/Wombosvideo/received_events","type":"User","site_admin":false},"labels":[{"id":113613819,"node_id":"MDU6TGFiZWwxMTM2MTM4MTk=","url":"https://api.github.com/repos/icetee/remote-ftp/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-01-22T11:03:45Z","updated_at":"2018-06-10T00:02:06Z","closed_at":null,"author_association":"NONE","body":"**Feature request:**\r\nHey. I'd like to request an implementation of git-diff into the Remote-FTP Tree View because I really like how this packaged displays the new/removed/changed files in the default \"Tree View\". \r\n\r\n**Possible implementation:**\r\nFor me it would be enough to just display the same colors as in the \"Tree View\". This could however irritate some users as this way would not support external file-changes on the server. To prevent this, you could check for the \"last-access\" or \"last-changed\" or whatever this stuff's called server-side and check if it matches the local one (or do some md5 magic). And if  it does, display the local colors (same as \"Tree View\"). If it doesn't, you could display a little exclamation mark besides the file icon (when hovered, it says \"File not in sync with local version\")\r\n\r\n[Atom.io git-diff Package](https://atom.io/packages/git-diff)"},"comment":{"url":"https://api.github.com/repos/icetee/remote-ftp/issues/comments/396007690","html_url":"https://github.com/icetee/remote-ftp/issues/650#issuecomment-396007690","issue_url":"https://api.github.com/repos/icetee/remote-ftp/issues/650","id":396007690,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjAwNzY5MA==","user":{"login":"mertyildiran","id":2502080,"node_id":"MDQ6VXNlcjI1MDIwODA=","avatar_url":"https://avatars2.githubusercontent.com/u/2502080?v=4","gravatar_id":"","url":"https://api.github.com/users/mertyildiran","html_url":"https://github.com/mertyildiran","followers_url":"https://api.github.com/users/mertyildiran/followers","following_url":"https://api.github.com/users/mertyildiran/following{/other_user}","gists_url":"https://api.github.com/users/mertyildiran/gists{/gist_id}","starred_url":"https://api.github.com/users/mertyildiran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mertyildiran/subscriptions","organizations_url":"https://api.github.com/users/mertyildiran/orgs","repos_url":"https://api.github.com/users/mertyildiran/repos","events_url":"https://api.github.com/users/mertyildiran/events{/privacy}","received_events_url":"https://api.github.com/users/mertyildiran/received_events","type":"User","site_admin":false},"created_at":"2018-06-10T00:02:06Z","updated_at":"2018-06-10T00:02:06Z","author_association":"NONE","body":"@icetee I suggest publishing a modified version of [git-diff](https://github.com/atom/git-diff) with a name like `remote-ftp-git-diff`. \r\n\r\n`git-diff` package is not a complex package and modifying it for the purpose of using it with `remote-ftp` would not be so complicated. Changing a few lines like [this one](https://github.com/atom/git-diff/blob/master/lib/diff-list-view.js#L69), I believe will be enough. The modified version of `git-diff` should operate on the remote repository instead of the local repository. But showing `git-diff` result just on *Tree View* is **not enough** so it should also operate on the remote file(the file that the user is currently editing) instead of the local file to show `git-diff` result **in-line**.\r\n\r\nEither @icetee you or I can modify `git-diff` and publish such a package but as far as I'm concerned; it will be a difficult task for me while for you @icetee it would be much easier to develop that package. (or maybe some other contributor can do it easily)\r\n\r\nI desperately need `git-diff` feature for my personal use so @icetee please let me know if you will do it. Otherwise, please at least help me and answer my future questions about your `remote-ftp` package while I will be doing this(modifying [git-diff](https://github.com/atom/git-diff)) challenging - for me - task."}}
{"actor":{"display_login":"mertyildiran"}}