{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/205062277","pull_request_review_id":140256003,"id":205062277,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTA2MjI3Nw==","diff_hunk":"@@ -16,18 +15,14 @@ export class HeroService {\n     private exceptionService: ExceptionService,\n     private spinnerService: SpinnerService,\n     private toastService: ToastService,\n-    private http: Http\n+    private http: HttpClient\n   ) { }\n \n   getHero(id: number) {\n-    return this.http.get(`api/heroes/${id}`).pipe(\n-      map(response => response.json().data as Hero));\n+    return this.http.get<Hero>(`api/heroes/${id}`);\n   }\n \n   getHeroes() {\n-    return this.http.get(`api/heroes`).pipe(\n-      map(response => response.json().data as Hero[]));\n+    return this.http.get<Hero[]>(`api/heroes`);\n   }\n-","path":"aio/content/examples/styleguide/src/03-06/app/heroes/shared/hero.service.avoid.ts","position":30,"original_position":30,"commit_id":"eef345ad6880eaada4db7c8b9ad7ff5c1da7e4ea","original_commit_id":"eef345ad6880eaada4db7c8b9ad7ff5c1da7e4ea","user":{"login":"gkalpak","id":8604205,"node_id":"MDQ6VXNlcjg2MDQyMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8604205?v=4","gravatar_id":"","url":"https://api.github.com/users/gkalpak","html_url":"https://github.com/gkalpak","followers_url":"https://api.github.com/users/gkalpak/followers","following_url":"https://api.github.com/users/gkalpak/following{/other_user}","gists_url":"https://api.github.com/users/gkalpak/gists{/gist_id}","starred_url":"https://api.github.com/users/gkalpak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkalpak/subscriptions","organizations_url":"https://api.github.com/users/gkalpak/orgs","repos_url":"https://api.github.com/users/gkalpak/repos","events_url":"https://api.github.com/users/gkalpak/events{/privacy}","received_events_url":"https://api.github.com/users/gkalpak/received_events","type":"User","site_admin":false},"body":"This line should stay 😇 ","created_at":"2018-07-25T10:43:04Z","updated_at":"2018-07-25T10:43:35Z","html_url":"https://github.com/angular/angular/pull/24996#discussion_r205062277","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/24996","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/205062277"},"html":{"href":"https://github.com/angular/angular/pull/24996#discussion_r205062277"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/24996"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/24996","id":202836279,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyODM2Mjc5","html_url":"https://github.com/angular/angular/pull/24996","diff_url":"https://github.com/angular/angular/pull/24996.diff","patch_url":"https://github.com/angular/angular/pull/24996.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/24996","number":24996,"state":"open","locked":false,"title":"docs: refactor style guide example 03-06","user":{"login":"danielsogl","id":15234844,"node_id":"MDQ6VXNlcjE1MjM0ODQ0","avatar_url":"https://avatars2.githubusercontent.com/u/15234844?v=4","gravatar_id":"","url":"https://api.github.com/users/danielsogl","html_url":"https://github.com/danielsogl","followers_url":"https://api.github.com/users/danielsogl/followers","following_url":"https://api.github.com/users/danielsogl/following{/other_user}","gists_url":"https://api.github.com/users/danielsogl/gists{/gist_id}","starred_url":"https://api.github.com/users/danielsogl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielsogl/subscriptions","organizations_url":"https://api.github.com/users/danielsogl/orgs","repos_url":"https://api.github.com/users/danielsogl/repos","events_url":"https://api.github.com/users/danielsogl/events{/privacy}","received_events_url":"https://api.github.com/users/danielsogl/received_events","type":"User","site_admin":false},"body":"## PR Checklist\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n\r\n<!-- Please check the one that applies to this PR using \"x\". -->\r\n```\r\n[ ] Bugfix\r\n[ ] Feature\r\n[ ] Code style update (formatting, local variables)\r\n[ ] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[ ] CI related changes\r\n[x] Documentation content changes\r\n[ ] angular.io application / infrastructure changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\n## What is the current behavior?\r\n<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->\r\nStyle guide example 03-06 uses the old Angular Http module\r\n\r\n\r\n## What is the new behavior?\r\nUpdated the example to use thew new HttpClient \r\n\r\n\r\n## Does this PR introduce a breaking change?\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n\r\n<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->\r\n\r\n\r\n## Other information\r\n","created_at":"2018-07-20T12:34:13Z","updated_at":"2018-07-25T10:43:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cee370db72c4aa4fbb294c72635e45792a2f915c","assignee":{"login":"brandonroberts","id":42211,"node_id":"MDQ6VXNlcjQyMjEx","avatar_url":"https://avatars3.githubusercontent.com/u/42211?v=4","gravatar_id":"","url":"https://api.github.com/users/brandonroberts","html_url":"https://github.com/brandonroberts","followers_url":"https://api.github.com/users/brandonroberts/followers","following_url":"https://api.github.com/users/brandonroberts/following{/other_user}","gists_url":"https://api.github.com/users/brandonroberts/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonroberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonroberts/subscriptions","organizations_url":"https://api.github.com/users/brandonroberts/orgs","repos_url":"https://api.github.com/users/brandonroberts/repos","events_url":"https://api.github.com/users/brandonroberts/events{/privacy}","received_events_url":"https://api.github.com/users/brandonroberts/received_events","type":"User","site_admin":false},"assignees":[{"login":"brandonroberts","id":42211,"node_id":"MDQ6VXNlcjQyMjEx","avatar_url":"https://avatars3.githubusercontent.com/u/42211?v=4","gravatar_id":"","url":"https://api.github.com/users/brandonroberts","html_url":"https://github.com/brandonroberts","followers_url":"https://api.github.com/users/brandonroberts/followers","following_url":"https://api.github.com/users/brandonroberts/following{/other_user}","gists_url":"https://api.github.com/users/brandonroberts/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonroberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonroberts/subscriptions","organizations_url":"https://api.github.com/users/brandonroberts/orgs","repos_url":"https://api.github.com/users/brandonroberts/repos","events_url":"https://api.github.com/users/brandonroberts/events{/privacy}","received_events_url":"https://api.github.com/users/brandonroberts/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":135584804,"node_id":"MDU6TGFiZWwxMzU1ODQ4MDQ=","url":"https://api.github.com/repos/angular/angular/labels/PR%20action:%20cleanup","name":"PR action: cleanup","color":"e11d21","default":false},{"id":655699838,"node_id":"MDU6TGFiZWw2NTU2OTk4Mzg=","url":"https://api.github.com/repos/angular/angular/labels/PR%20target:%20master%20&%20patch","name":"PR target: master & patch","color":"5319e7","default":false},{"id":149476251,"node_id":"MDU6TGFiZWwxNDk0NzYyNTE=","url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":175085143,"node_id":"MDU6TGFiZWwxNzUwODUxNDM=","url":"https://api.github.com/repos/angular/angular/labels/comp:%20docs","name":"comp: docs","color":"c7def8","default":false},{"id":956271554,"node_id":"MDU6TGFiZWw5NTYyNzE1NTQ=","url":"https://api.github.com/repos/angular/angular/labels/docsarea:%20style-guide","name":"docsarea: style-guide","color":"f9d0c4","default":false},{"id":936514372,"node_id":"MDU6TGFiZWw5MzY1MTQzNzI=","url":"https://api.github.com/repos/angular/angular/labels/state:%20community","name":"state: community","color":"8fefd7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/24996/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/24996/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/24996/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/eef345ad6880eaada4db7c8b9ad7ff5c1da7e4ea","head":{"label":"danielsogl:refactor_03-06","ref":"refactor_03-06","sha":"eef345ad6880eaada4db7c8b9ad7ff5c1da7e4ea","user":{"login":"danielsogl","id":15234844,"node_id":"MDQ6VXNlcjE1MjM0ODQ0","avatar_url":"https://avatars2.githubusercontent.com/u/15234844?v=4","gravatar_id":"","url":"https://api.github.com/users/danielsogl","html_url":"https://github.com/danielsogl","followers_url":"https://api.github.com/users/danielsogl/followers","following_url":"https://api.github.com/users/danielsogl/following{/other_user}","gists_url":"https://api.github.com/users/danielsogl/gists{/gist_id}","starred_url":"https://api.github.com/users/danielsogl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielsogl/subscriptions","organizations_url":"https://api.github.com/users/danielsogl/orgs","repos_url":"https://api.github.com/users/danielsogl/repos","events_url":"https://api.github.com/users/danielsogl/events{/privacy}","received_events_url":"https://api.github.com/users/danielsogl/received_events","type":"User","site_admin":false},"repo":{"id":92619280,"node_id":"MDEwOlJlcG9zaXRvcnk5MjYxOTI4MA==","name":"angular","full_name":"danielsogl/angular","owner":{"login":"danielsogl","id":15234844,"node_id":"MDQ6VXNlcjE1MjM0ODQ0","avatar_url":"https://avatars2.githubusercontent.com/u/15234844?v=4","gravatar_id":"","url":"https://api.github.com/users/danielsogl","html_url":"https://github.com/danielsogl","followers_url":"https://api.github.com/users/danielsogl/followers","following_url":"https://api.github.com/users/danielsogl/following{/other_user}","gists_url":"https://api.github.com/users/danielsogl/gists{/gist_id}","starred_url":"https://api.github.com/users/danielsogl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielsogl/subscriptions","organizations_url":"https://api.github.com/users/danielsogl/orgs","repos_url":"https://api.github.com/users/danielsogl/repos","events_url":"https://api.github.com/users/danielsogl/events{/privacy}","received_events_url":"https://api.github.com/users/danielsogl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danielsogl/angular","description":"One framework. Mobile & desktop.","fork":true,"url":"https://api.github.com/repos/danielsogl/angular","forks_url":"https://api.github.com/repos/danielsogl/angular/forks","keys_url":"https://api.github.com/repos/danielsogl/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielsogl/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielsogl/angular/teams","hooks_url":"https://api.github.com/repos/danielsogl/angular/hooks","issue_events_url":"https://api.github.com/repos/danielsogl/angular/issues/events{/number}","events_url":"https://api.github.com/repos/danielsogl/angular/events","assignees_url":"https://api.github.com/repos/danielsogl/angular/assignees{/user}","branches_url":"https://api.github.com/repos/danielsogl/angular/branches{/branch}","tags_url":"https://api.github.com/repos/danielsogl/angular/tags","blobs_url":"https://api.github.com/repos/danielsogl/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielsogl/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielsogl/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielsogl/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielsogl/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/danielsogl/angular/languages","stargazers_url":"https://api.github.com/repos/danielsogl/angular/stargazers","contributors_url":"https://api.github.com/repos/danielsogl/angular/contributors","subscribers_url":"https://api.github.com/repos/danielsogl/angular/subscribers","subscription_url":"https://api.github.com/repos/danielsogl/angular/subscription","commits_url":"https://api.github.com/repos/danielsogl/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielsogl/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielsogl/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielsogl/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielsogl/angular/contents/{+path}","compare_url":"https://api.github.com/repos/danielsogl/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielsogl/angular/merges","archive_url":"https://api.github.com/repos/danielsogl/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielsogl/angular/downloads","issues_url":"https://api.github.com/repos/danielsogl/angular/issues{/number}","pulls_url":"https://api.github.com/repos/danielsogl/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/danielsogl/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/danielsogl/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielsogl/angular/labels{/name}","releases_url":"https://api.github.com/repos/danielsogl/angular/releases{/id}","deployments_url":"https://api.github.com/repos/danielsogl/angular/deployments","created_at":"2017-05-27T19:21:35Z","updated_at":"2018-07-24T14:29:03Z","pushed_at":"2018-07-25T10:22:18Z","git_url":"git://github.com/danielsogl/angular.git","ssh_url":"git@github.com:danielsogl/angular.git","clone_url":"https://github.com/danielsogl/angular.git","svn_url":"https://github.com/danielsogl/angular","homepage":"https://angular.io","size":81120,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"d4ac9698ba7dd829600ca4c8129fcbeae9cb4bed","user":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"node_id":"MDEwOlJlcG9zaXRvcnkyNDE5NTMzOQ==","name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"One framework. Mobile & desktop.","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2018-07-25T10:16:44Z","pushed_at":"2018-07-25T10:22:25Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":83341,"stargazers_count":38797,"watchers_count":38797,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9409,"mirror_url":null,"archived":false,"open_issues_count":2454,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9409,"open_issues":2454,"watchers":38797,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/24996"},"html":{"href":"https://github.com/angular/angular/pull/24996"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/24996"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/24996/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/24996/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/24996/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/eef345ad6880eaada4db7c8b9ad7ff5c1da7e4ea"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gkalpak"}}