{"push_id":2403389292,"size":7,"distinct_size":1,"ref":"refs/heads/master","head":"a365feee79cf3700b651371b6417822a074b595c","before":"2934d28388c0be312346b8999d5b3acc5f43959b","commits":[{"sha":"124576406c276a61ab92e9e71585f2044e6a6eea","author":{"name":"Maciej Borzecki","email":"cedf9a6bdf59622aa5600ca700f1dc0a172a9f1a@canonical.com"},"message":"userd: do not shadow the mocked function\n\nFixes vet warnings:\n userd/ui/ui.go:59:2: hasZenityExecutable declared but not used\n userd/ui/ui.go:67:2: hasKDialogExecutable declared but not used\n\nSigned-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>","distinct":false,"url":"https://api.github.com/repos/sergiocazzolato/snapd/commits/124576406c276a61ab92e9e71585f2044e6a6eea"},{"sha":"f0ead69b01af3269f89732b9451f6ffc61c12a24","author":{"name":"Maciej Borzecki","email":"cedf9a6bdf59622aa5600ca700f1dc0a172a9f1a@canonical.com"},"message":"snap: use proper name when providing multiple instance of example functions\n\nAccording to the docs:\n\n> Multiple examples can be provided for a given identifier by using a suffix\n> beginning with an underscore followed by a lowercase letter.\n\nFixes vet warning:\n snap/info_test.go:496: ExampleSplitSnapAppShort refers to unknown identifier: SplitSnapAppShort\n\nSigned-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>","distinct":false,"url":"https://api.github.com/repos/sergiocazzolato/snapd/commits/f0ead69b01af3269f89732b9451f6ffc61c12a24"},{"sha":"70ada8faeb4e2125eb97b282e563bd1349f0fd01","author":{"name":"Maciej Borzecki","email":"cedf9a6bdf59622aa5600ca700f1dc0a172a9f1a@canonical.com"},"message":"cmd/snap: use keyed field names in the tests\n\nFixes vet warning:\n  cmd/snap/interfaces_common_test.go:68: github.com/snapcore/snapd/cmd/snap.AttributePair composite literal uses unkeyed fields\n  cmd/snap/interfaces_common_test.go:69: github.com/snapcore/snapd/cmd/snap.AttributePair composite literal uses unkeyed fields\n\nSigned-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>","distinct":false,"url":"https://api.github.com/repos/sergiocazzolato/snapd/commits/70ada8faeb4e2125eb97b282e563bd1349f0fd01"},{"sha":"2661786d9e3ba1d5ff878162b6d3b8c3b51d18aa","author":{"name":"Maciej Borzecki","email":"cedf9a6bdf59622aa5600ca700f1dc0a172a9f1a@canonical.com"},"message":"advisor: do not copy the instances of bolt.DB\n\nFixes vet warning:\n advisor/backend.go:199: literal copies lock value from *db: github.com/snapcore/snapd/vendor/github.com/snapcore/bolt.DB contains sync.Pool contains sync.noCopy\n\nSigned-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>","distinct":false,"url":"https://api.github.com/repos/sergiocazzolato/snapd/commits/2661786d9e3ba1d5ff878162b6d3b8c3b51d18aa"},{"sha":"981bc0e73bc245d7af10a4296b67c7b26d6d45ad","author":{"name":"Maciej Borzecki","email":"cedf9a6bdf59622aa5600ca700f1dc0a172a9f1a@canonical.com"},"message":"overlord/ifacestate: workaround broken go vet in go 1.10\n\nWorkaround go vet 'internal compiler error' when methods are defined in test\nfiles and cross package imports are used. The original ticket is:\n  https://github.com/golang/go/issues/23701\n\nAlthough it is supposed to be fixed in 1.10 it does not appear to be so.\n\nError reported by go vet:\n\n  ./ifacestate_test.go:120:29: internal compiler error: no function definition for [0xc420a2fc80] FUNC-method(*ifacestate.InterfaceManager) func()\n\nSigned-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>","distinct":false,"url":"https://api.github.com/repos/sergiocazzolato/snapd/commits/981bc0e73bc245d7af10a4296b67c7b26d6d45ad"},{"sha":"f0e0c90bd0dc2c7fbda912ad0b030aae5761da2a","author":{"name":"Maciej Borzecki","email":"cedf9a6bdf59622aa5600ca700f1dc0a172a9f1a@canonical.com"},"message":"overlord/devicestate: workaround broken go vet in go 1.10\n\nWorkaround go vet 'internal compiler error' when methods are defined in test\nfiles and cross package imports are used. The original ticket is:\n  https://github.com/golang/go/issues/23701\n\nAlthough it is supposed to be fixed in 1.10 it does not appear to be so.\n\nError reported by go vet:\n\n./devicestate_test.go:403:38: internal compiler error: no function definition for [0xc4212363c0] FUNC-method(*devicestate.DeviceManager) func() asserts.KeypairManager\n\nSigned-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>","distinct":false,"url":"https://api.github.com/repos/sergiocazzolato/snapd/commits/f0e0c90bd0dc2c7fbda912ad0b030aae5761da2a"},{"sha":"a365feee79cf3700b651371b6417822a074b595c","author":{"name":"Sergio Cazzolato","email":"810feb78750fb9cff7a478b6159604d4f51cbac9@gmail.com"},"message":"Merge pull request #4837 from bboozzoo/bboozzoo/vet-cleanup\n\nmany: go vet cleanups","distinct":true,"url":"https://api.github.com/repos/sergiocazzolato/snapd/commits/a365feee79cf3700b651371b6417822a074b595c"}]}
{"actor":{"display_login":"sergiocazzolato"}}