{"action":"created","comment":{"url":"https://api.github.com/repos/Particular/ServiceControl/pulls/comments/206514893","pull_request_review_id":141939462,"id":206514893,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjUxNDg5Mw==","diff_hunk":"@@ -0,0 +1,61 @@\n+﻿namespace ServiceBus.Management.Infrastructure.Settings\n+{\n+    using System;\n+    using System.Threading.Tasks;\n+    using System.Xml.Linq;\n+    using NServiceBus;\n+    using NServiceBus.Features;\n+    using NServiceBus.Logging;\n+\n+    class DeprecatedConfigurationCheckFeature : Feature\n+    {\n+        public DeprecatedConfigurationCheckFeature()\n+        {\n+            EnableByDefault();\n+        }\n+\n+        protected override void Setup(FeatureConfigurationContext context) => context.RegisterStartupTask(b => b.Build<DeprecatedConfigurationCheck>());\n+\n+        class DeprecatedConfigurationCheck : FeatureStartupTask\n+        {\n+            protected override Task OnStart(IMessageSession session)\n+            {\n+                var config = XDocument.Load(AppDomain.CurrentDomain.SetupInformation.ConfigurationFile);","path":"src/ServiceControl/Infrastructure/Settings/DeprecatedConfigurationCheckFeature.cs","position":23,"original_position":23,"commit_id":"7bc45b2915991e4966f4acaca3c9f979ba0bfaa4","original_commit_id":"7bc45b2915991e4966f4acaca3c9f979ba0bfaa4","user":{"login":"WilliamBZA","id":1060960,"node_id":"MDQ6VXNlcjEwNjA5NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/1060960?v=4","gravatar_id":"","url":"https://api.github.com/users/WilliamBZA","html_url":"https://github.com/WilliamBZA","followers_url":"https://api.github.com/users/WilliamBZA/followers","following_url":"https://api.github.com/users/WilliamBZA/following{/other_user}","gists_url":"https://api.github.com/users/WilliamBZA/gists{/gist_id}","starred_url":"https://api.github.com/users/WilliamBZA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WilliamBZA/subscriptions","organizations_url":"https://api.github.com/users/WilliamBZA/orgs","repos_url":"https://api.github.com/users/WilliamBZA/repos","events_url":"https://api.github.com/users/WilliamBZA/events{/privacy}","received_events_url":"https://api.github.com/users/WilliamBZA/received_events","type":"User","site_admin":false},"body":"If there is no app.config file, ServiceControl won't start as there are config settings that are required. If all of the requried settings reside in the machine.config, then this code will return Task.CompletedTask and the user won't get warned about the config sections. [Docs for this property](https://msdn.microsoft.com/en-us/library/system.appdomainsetup.configurationfile.aspx)\r\n\r\nIf this code can't load the location specified by this property, it means the account that ServiceControl is running under doesn't have access to that disk location, in which case it shouldn't start anyway - at the very least, the codepath wouldn't actually get this far anyway.\r\n\r\nSo I don't know if there's any specific checks we need to do here, but I suspect not.","created_at":"2018-07-31T12:56:32Z","updated_at":"2018-07-31T12:56:32Z","html_url":"https://github.com/Particular/ServiceControl/pull/1335#discussion_r206514893","pull_request_url":"https://api.github.com/repos/Particular/ServiceControl/pulls/1335","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Particular/ServiceControl/pulls/comments/206514893"},"html":{"href":"https://github.com/Particular/ServiceControl/pull/1335#discussion_r206514893"},"pull_request":{"href":"https://api.github.com/repos/Particular/ServiceControl/pulls/1335"}},"in_reply_to_id":206507407},"pull_request":{"url":"https://api.github.com/repos/Particular/ServiceControl/pulls/1335","id":204729721,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NzI5NzIx","html_url":"https://github.com/Particular/ServiceControl/pull/1335","diff_url":"https://github.com/Particular/ServiceControl/pull/1335.diff","patch_url":"https://github.com/Particular/ServiceControl/pull/1335.patch","issue_url":"https://api.github.com/repos/Particular/ServiceControl/issues/1335","number":1335,"state":"open","locked":false,"title":"Add log warning if SC detects if any ConfigSection's are being used","user":{"login":"WilliamBZA","id":1060960,"node_id":"MDQ6VXNlcjEwNjA5NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/1060960?v=4","gravatar_id":"","url":"https://api.github.com/users/WilliamBZA","html_url":"https://github.com/WilliamBZA","followers_url":"https://api.github.com/users/WilliamBZA/followers","following_url":"https://api.github.com/users/WilliamBZA/following{/other_user}","gists_url":"https://api.github.com/users/WilliamBZA/gists{/gist_id}","starred_url":"https://api.github.com/users/WilliamBZA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WilliamBZA/subscriptions","organizations_url":"https://api.github.com/users/WilliamBZA/orgs","repos_url":"https://api.github.com/users/WilliamBZA/repos","events_url":"https://api.github.com/users/WilliamBZA/events{/privacy}","received_events_url":"https://api.github.com/users/WilliamBZA/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/Particular/ServiceControl/issues/1317","created_at":"2018-07-30T08:29:28Z","updated_at":"2018-07-31T12:56:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77a5b4ab76f1d85d213ef54efb7d25b51973667d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mikeminutillo","id":124014,"node_id":"MDQ6VXNlcjEyNDAxNA==","avatar_url":"https://avatars0.githubusercontent.com/u/124014?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeminutillo","html_url":"https://github.com/mikeminutillo","followers_url":"https://api.github.com/users/mikeminutillo/followers","following_url":"https://api.github.com/users/mikeminutillo/following{/other_user}","gists_url":"https://api.github.com/users/mikeminutillo/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeminutillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeminutillo/subscriptions","organizations_url":"https://api.github.com/users/mikeminutillo/orgs","repos_url":"https://api.github.com/users/mikeminutillo/repos","events_url":"https://api.github.com/users/mikeminutillo/events{/privacy}","received_events_url":"https://api.github.com/users/mikeminutillo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Particular/ServiceControl/pulls/1335/commits","review_comments_url":"https://api.github.com/repos/Particular/ServiceControl/pulls/1335/comments","review_comment_url":"https://api.github.com/repos/Particular/ServiceControl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Particular/ServiceControl/issues/1335/comments","statuses_url":"https://api.github.com/repos/Particular/ServiceControl/statuses/7bc45b2915991e4966f4acaca3c9f979ba0bfaa4","head":{"label":"Particular:asq-warning","ref":"asq-warning","sha":"7bc45b2915991e4966f4acaca3c9f979ba0bfaa4","user":{"login":"Particular","id":5038441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzg0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":7913469,"node_id":"MDEwOlJlcG9zaXRvcnk3OTEzNDY5","name":"ServiceControl","full_name":"Particular/ServiceControl","owner":{"login":"Particular","id":5038441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzg0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/ServiceControl","description":"Backend for ServiceInsight and ServicePulse","fork":false,"url":"https://api.github.com/repos/Particular/ServiceControl","forks_url":"https://api.github.com/repos/Particular/ServiceControl/forks","keys_url":"https://api.github.com/repos/Particular/ServiceControl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/ServiceControl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/ServiceControl/teams","hooks_url":"https://api.github.com/repos/Particular/ServiceControl/hooks","issue_events_url":"https://api.github.com/repos/Particular/ServiceControl/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/ServiceControl/events","assignees_url":"https://api.github.com/repos/Particular/ServiceControl/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/ServiceControl/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/ServiceControl/tags","blobs_url":"https://api.github.com/repos/Particular/ServiceControl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/ServiceControl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/ServiceControl/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/ServiceControl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/ServiceControl/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/ServiceControl/languages","stargazers_url":"https://api.github.com/repos/Particular/ServiceControl/stargazers","contributors_url":"https://api.github.com/repos/Particular/ServiceControl/contributors","subscribers_url":"https://api.github.com/repos/Particular/ServiceControl/subscribers","subscription_url":"https://api.github.com/repos/Particular/ServiceControl/subscription","commits_url":"https://api.github.com/repos/Particular/ServiceControl/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/ServiceControl/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/ServiceControl/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/ServiceControl/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/ServiceControl/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/ServiceControl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/ServiceControl/merges","archive_url":"https://api.github.com/repos/Particular/ServiceControl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/ServiceControl/downloads","issues_url":"https://api.github.com/repos/Particular/ServiceControl/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/ServiceControl/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/ServiceControl/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/ServiceControl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/ServiceControl/labels{/name}","releases_url":"https://api.github.com/repos/Particular/ServiceControl/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/ServiceControl/deployments","created_at":"2013-01-30T11:42:44Z","updated_at":"2018-07-23T05:01:17Z","pushed_at":"2018-07-31T12:27:25Z","git_url":"git://github.com/Particular/ServiceControl.git","ssh_url":"git@github.com:Particular/ServiceControl.git","clone_url":"https://github.com/Particular/ServiceControl.git","svn_url":"https://github.com/Particular/ServiceControl","homepage":"https://docs.particular.net/servicecontrol/","size":50105,"stargazers_count":17,"watchers_count":17,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":29,"open_issues":96,"watchers":17,"default_branch":"master"}},"base":{"label":"Particular:develop","ref":"develop","sha":"b86013052be52b27745fbf53fab02327b911f3c3","user":{"login":"Particular","id":5038441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzg0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":7913469,"node_id":"MDEwOlJlcG9zaXRvcnk3OTEzNDY5","name":"ServiceControl","full_name":"Particular/ServiceControl","owner":{"login":"Particular","id":5038441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwMzg0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/ServiceControl","description":"Backend for ServiceInsight and ServicePulse","fork":false,"url":"https://api.github.com/repos/Particular/ServiceControl","forks_url":"https://api.github.com/repos/Particular/ServiceControl/forks","keys_url":"https://api.github.com/repos/Particular/ServiceControl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/ServiceControl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/ServiceControl/teams","hooks_url":"https://api.github.com/repos/Particular/ServiceControl/hooks","issue_events_url":"https://api.github.com/repos/Particular/ServiceControl/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/ServiceControl/events","assignees_url":"https://api.github.com/repos/Particular/ServiceControl/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/ServiceControl/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/ServiceControl/tags","blobs_url":"https://api.github.com/repos/Particular/ServiceControl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/ServiceControl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/ServiceControl/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/ServiceControl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/ServiceControl/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/ServiceControl/languages","stargazers_url":"https://api.github.com/repos/Particular/ServiceControl/stargazers","contributors_url":"https://api.github.com/repos/Particular/ServiceControl/contributors","subscribers_url":"https://api.github.com/repos/Particular/ServiceControl/subscribers","subscription_url":"https://api.github.com/repos/Particular/ServiceControl/subscription","commits_url":"https://api.github.com/repos/Particular/ServiceControl/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/ServiceControl/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/ServiceControl/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/ServiceControl/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/ServiceControl/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/ServiceControl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/ServiceControl/merges","archive_url":"https://api.github.com/repos/Particular/ServiceControl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/ServiceControl/downloads","issues_url":"https://api.github.com/repos/Particular/ServiceControl/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/ServiceControl/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/ServiceControl/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/ServiceControl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/ServiceControl/labels{/name}","releases_url":"https://api.github.com/repos/Particular/ServiceControl/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/ServiceControl/deployments","created_at":"2013-01-30T11:42:44Z","updated_at":"2018-07-23T05:01:17Z","pushed_at":"2018-07-31T12:27:25Z","git_url":"git://github.com/Particular/ServiceControl.git","ssh_url":"git@github.com:Particular/ServiceControl.git","clone_url":"https://github.com/Particular/ServiceControl.git","svn_url":"https://github.com/Particular/ServiceControl","homepage":"https://docs.particular.net/servicecontrol/","size":50105,"stargazers_count":17,"watchers_count":17,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":29,"open_issues":96,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Particular/ServiceControl/pulls/1335"},"html":{"href":"https://github.com/Particular/ServiceControl/pull/1335"},"issue":{"href":"https://api.github.com/repos/Particular/ServiceControl/issues/1335"},"comments":{"href":"https://api.github.com/repos/Particular/ServiceControl/issues/1335/comments"},"review_comments":{"href":"https://api.github.com/repos/Particular/ServiceControl/pulls/1335/comments"},"review_comment":{"href":"https://api.github.com/repos/Particular/ServiceControl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Particular/ServiceControl/pulls/1335/commits"},"statuses":{"href":"https://api.github.com/repos/Particular/ServiceControl/statuses/7bc45b2915991e4966f4acaca3c9f979ba0bfaa4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"WilliamBZA"}}