{"action":"created","comment":{"url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/pulls/comments/221740897","pull_request_review_id":160465144,"id":221740897,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTc0MDg5Nw==","diff_hunk":"@@ -109,6 +109,23 @@ func (h *handler) ServeHTTP(w http.ResponseWriter, r *http.Request) {\n \t\treturn\n \t}\n \n+\t// If we have a request body, make sure the preamble\n+\t// knows that it should close the body if it wants to\n+\t// write before completing reading.\n+\t// FIXME: https://github.com/ipfs/go-ipfs/issues/5168\n+\t// FIXME: https://github.com/golang/go/issues/15527\n+\tvar bodyErrChan chan error\n+\tif r.Body != http.NoBody {\n+\t\tbodyErrChan = make(chan error)","path":"http/handler.go","position":11,"original_position":11,"commit_id":"a34b014ad24a6c97d5d075f1afcd8c398db33983","original_commit_id":"a34b014ad24a6c97d5d075f1afcd8c398db33983","user":{"login":"Stebalien","id":310393,"node_id":"MDQ6VXNlcjMxMDM5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/310393?v=4","gravatar_id":"","url":"https://api.github.com/users/Stebalien","html_url":"https://github.com/Stebalien","followers_url":"https://api.github.com/users/Stebalien/followers","following_url":"https://api.github.com/users/Stebalien/following{/other_user}","gists_url":"https://api.github.com/users/Stebalien/gists{/gist_id}","starred_url":"https://api.github.com/users/Stebalien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stebalien/subscriptions","organizations_url":"https://api.github.com/users/Stebalien/orgs","repos_url":"https://api.github.com/users/Stebalien/repos","events_url":"https://api.github.com/users/Stebalien/events{/privacy}","received_events_url":"https://api.github.com/users/Stebalien/received_events","type":"User","site_admin":false},"body":"Needs a buffer.","created_at":"2018-10-01T20:12:24Z","updated_at":"2018-10-01T20:20:41Z","html_url":"https://github.com/ipfs/go-ipfs-cmds/pull/116#discussion_r221740897","pull_request_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/pulls/116","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ipfs/go-ipfs-cmds/pulls/comments/221740897"},"html":{"href":"https://github.com/ipfs/go-ipfs-cmds/pull/116#discussion_r221740897"},"pull_request":{"href":"https://api.github.com/repos/ipfs/go-ipfs-cmds/pulls/116"}}},"pull_request":{"url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/pulls/116","id":214492265,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NDkyMjY1","html_url":"https://github.com/ipfs/go-ipfs-cmds/pull/116","diff_url":"https://github.com/ipfs/go-ipfs-cmds/pull/116.diff","patch_url":"https://github.com/ipfs/go-ipfs-cmds/pull/116.patch","issue_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/issues/116","number":116,"state":"open","locked":false,"title":"set the connection close header if we have a body to read","user":{"login":"Stebalien","id":310393,"node_id":"MDQ6VXNlcjMxMDM5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/310393?v=4","gravatar_id":"","url":"https://api.github.com/users/Stebalien","html_url":"https://github.com/Stebalien","followers_url":"https://api.github.com/users/Stebalien/followers","following_url":"https://api.github.com/users/Stebalien/following{/other_user}","gists_url":"https://api.github.com/users/Stebalien/gists{/gist_id}","starred_url":"https://api.github.com/users/Stebalien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stebalien/subscriptions","organizations_url":"https://api.github.com/users/Stebalien/orgs","repos_url":"https://api.github.com/users/Stebalien/repos","events_url":"https://api.github.com/users/Stebalien/events{/privacy}","received_events_url":"https://api.github.com/users/Stebalien/received_events","type":"User","site_admin":false},"body":"We can't stream a response while reading a body *unless* we've configured the connection to close after we're done sending a response.\r\n\r\nThis patch works around that issue by doing exactly that.\r\n\r\nFixes: https://github.com/ipfs/go-ipfs/issues/5168 (sort of)","created_at":"2018-09-11T02:06:40Z","updated_at":"2018-10-01T20:20:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebfa7d5ccd6b4b5529da6a37d5d1cf8d48d7281a","assignee":{"login":"keks","id":146678,"node_id":"MDQ6VXNlcjE0NjY3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/146678?v=4","gravatar_id":"","url":"https://api.github.com/users/keks","html_url":"https://github.com/keks","followers_url":"https://api.github.com/users/keks/followers","following_url":"https://api.github.com/users/keks/following{/other_user}","gists_url":"https://api.github.com/users/keks/gists{/gist_id}","starred_url":"https://api.github.com/users/keks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keks/subscriptions","organizations_url":"https://api.github.com/users/keks/orgs","repos_url":"https://api.github.com/users/keks/repos","events_url":"https://api.github.com/users/keks/events{/privacy}","received_events_url":"https://api.github.com/users/keks/received_events","type":"User","site_admin":false},"assignees":[{"login":"keks","id":146678,"node_id":"MDQ6VXNlcjE0NjY3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/146678?v=4","gravatar_id":"","url":"https://api.github.com/users/keks","html_url":"https://github.com/keks","followers_url":"https://api.github.com/users/keks/followers","following_url":"https://api.github.com/users/keks/following{/other_user}","gists_url":"https://api.github.com/users/keks/gists{/gist_id}","starred_url":"https://api.github.com/users/keks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keks/subscriptions","organizations_url":"https://api.github.com/users/keks/orgs","repos_url":"https://api.github.com/users/keks/repos","events_url":"https://api.github.com/users/keks/events{/privacy}","received_events_url":"https://api.github.com/users/keks/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"keks","id":146678,"node_id":"MDQ6VXNlcjE0NjY3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/146678?v=4","gravatar_id":"","url":"https://api.github.com/users/keks","html_url":"https://github.com/keks","followers_url":"https://api.github.com/users/keks/followers","following_url":"https://api.github.com/users/keks/following{/other_user}","gists_url":"https://api.github.com/users/keks/gists{/gist_id}","starred_url":"https://api.github.com/users/keks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keks/subscriptions","organizations_url":"https://api.github.com/users/keks/orgs","repos_url":"https://api.github.com/users/keks/repos","events_url":"https://api.github.com/users/keks/events{/privacy}","received_events_url":"https://api.github.com/users/keks/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":759298994,"node_id":"MDU6TGFiZWw3NTkyOTg5OTQ=","url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/pulls/116/commits","review_comments_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/pulls/116/comments","review_comment_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/issues/116/comments","statuses_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/statuses/a34b014ad24a6c97d5d075f1afcd8c398db33983","head":{"label":"ipfs:fix/go-ipfs-5168","ref":"fix/go-ipfs-5168","sha":"a34b014ad24a6c97d5d075f1afcd8c398db33983","user":{"login":"ipfs","id":10536621,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTM2NjIx","avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"repo":{"id":80315005,"node_id":"MDEwOlJlcG9zaXRvcnk4MDMxNTAwNQ==","name":"go-ipfs-cmds","full_name":"ipfs/go-ipfs-cmds","private":false,"owner":{"login":"ipfs","id":10536621,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTM2NjIx","avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ipfs/go-ipfs-cmds","description":"IPFS commands package","fork":false,"url":"https://api.github.com/repos/ipfs/go-ipfs-cmds","forks_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/forks","keys_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/teams","hooks_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/hooks","issue_events_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/issues/events{/number}","events_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/events","assignees_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/assignees{/user}","branches_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/branches{/branch}","tags_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/tags","blobs_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/statuses/{sha}","languages_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/languages","stargazers_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/stargazers","contributors_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/contributors","subscribers_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/subscribers","subscription_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/subscription","commits_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/contents/{+path}","compare_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/merges","archive_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/downloads","issues_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/issues{/number}","pulls_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/pulls{/number}","milestones_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/milestones{/number}","notifications_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/labels{/name}","releases_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/releases{/id}","deployments_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/deployments","created_at":"2017-01-28T22:27:18Z","updated_at":"2018-09-24T12:41:33Z","pushed_at":"2018-10-01T15:18:00Z","git_url":"git://github.com/ipfs/go-ipfs-cmds.git","ssh_url":"git@github.com:ipfs/go-ipfs-cmds.git","clone_url":"https://github.com/ipfs/go-ipfs-cmds.git","svn_url":"https://github.com/ipfs/go-ipfs-cmds","homepage":null,"size":958,"stargazers_count":16,"watchers_count":16,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":12,"open_issues":39,"watchers":16,"default_branch":"master"}},"base":{"label":"ipfs:master","ref":"master","sha":"46249b4612ea7b0c23f07b4d1b1bdb9f4c91a8d2","user":{"login":"ipfs","id":10536621,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTM2NjIx","avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"repo":{"id":80315005,"node_id":"MDEwOlJlcG9zaXRvcnk4MDMxNTAwNQ==","name":"go-ipfs-cmds","full_name":"ipfs/go-ipfs-cmds","private":false,"owner":{"login":"ipfs","id":10536621,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTM2NjIx","avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ipfs/go-ipfs-cmds","description":"IPFS commands package","fork":false,"url":"https://api.github.com/repos/ipfs/go-ipfs-cmds","forks_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/forks","keys_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/teams","hooks_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/hooks","issue_events_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/issues/events{/number}","events_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/events","assignees_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/assignees{/user}","branches_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/branches{/branch}","tags_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/tags","blobs_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/statuses/{sha}","languages_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/languages","stargazers_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/stargazers","contributors_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/contributors","subscribers_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/subscribers","subscription_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/subscription","commits_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/contents/{+path}","compare_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/merges","archive_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/downloads","issues_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/issues{/number}","pulls_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/pulls{/number}","milestones_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/milestones{/number}","notifications_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/labels{/name}","releases_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/releases{/id}","deployments_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/deployments","created_at":"2017-01-28T22:27:18Z","updated_at":"2018-09-24T12:41:33Z","pushed_at":"2018-10-01T15:18:00Z","git_url":"git://github.com/ipfs/go-ipfs-cmds.git","ssh_url":"git@github.com:ipfs/go-ipfs-cmds.git","clone_url":"https://github.com/ipfs/go-ipfs-cmds.git","svn_url":"https://github.com/ipfs/go-ipfs-cmds","homepage":null,"size":958,"stargazers_count":16,"watchers_count":16,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":12,"open_issues":39,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ipfs/go-ipfs-cmds/pulls/116"},"html":{"href":"https://github.com/ipfs/go-ipfs-cmds/pull/116"},"issue":{"href":"https://api.github.com/repos/ipfs/go-ipfs-cmds/issues/116"},"comments":{"href":"https://api.github.com/repos/ipfs/go-ipfs-cmds/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/ipfs/go-ipfs-cmds/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/ipfs/go-ipfs-cmds/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ipfs/go-ipfs-cmds/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/ipfs/go-ipfs-cmds/statuses/a34b014ad24a6c97d5d075f1afcd8c398db33983"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Stebalien"}}