{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/18623","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/18623/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/18623/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/18623/events","html_url":"https://github.com/magento/magento2/pull/18623","id":370174341,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyOTE0NDcz","number":18623,"title":"Add MAGE_RUN_TYPE+MAGE_RUN_CODE to FPC identifier","user":{"login":"amenk","id":1087128,"node_id":"MDQ6VXNlcjEwODcxMjg=","avatar_url":"https://avatars0.githubusercontent.com/u/1087128?v=4","gravatar_id":"","url":"https://api.github.com/users/amenk","html_url":"https://github.com/amenk","followers_url":"https://api.github.com/users/amenk/followers","following_url":"https://api.github.com/users/amenk/following{/other_user}","gists_url":"https://api.github.com/users/amenk/gists{/gist_id}","starred_url":"https://api.github.com/users/amenk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amenk/subscriptions","organizations_url":"https://api.github.com/users/amenk/orgs","repos_url":"https://api.github.com/users/amenk/repos","events_url":"https://api.github.com/users/amenk/events{/privacy}","received_events_url":"https://api.github.com/users/amenk/received_events","type":"User","site_admin":false},"labels":[{"id":947798305,"node_id":"MDU6TGFiZWw5NDc3OTgzMDU=","url":"https://api.github.com/repos/magento/magento2/labels/Component:%20Framework/App","name":"Component: Framework/App","color":"7fb703","default":false},{"id":721429227,"node_id":"MDU6TGFiZWw3MjE0MjkyMjc=","url":"https://api.github.com/repos/magento/magento2/labels/Release%20Line:%202.3","name":"Release Line: 2.3","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-15T13:53:26Z","updated_at":"2018-10-15T13:55:23Z","closed_at":"2018-10-15T13:53:32Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/18623","html_url":"https://github.com/magento/magento2/pull/18623","diff_url":"https://github.com/magento/magento2/pull/18623.diff","patch_url":"https://github.com/magento/magento2/pull/18623.patch"},"body":"### Description (*)\r\n\r\nCurrently Magento 2.2.6 full page cache does not work correctly, when using SetEnv or similar techniques on unchanged URLs\r\n\r\nSo the MAGE_RUN_TYPE and MAGE_RUN_CODE should be added to the FPC identifier to allow for such use cases.\r\n\r\nA common case is Magento 2 behind a reverse NGINX proxy.\r\n\r\n### Manual testing scenarios (*)\r\n\r\nSteps to reproduce, without proxy setup:\r\n1) In pub/.htaccess set\r\n\r\nSetEnv MAGE_RUN_TYPE store SetEnv MAGE_RUN_CODE italy\r\n\r\n2) Now open Frontend\r\n\r\n3) Now set\r\n\r\nSetEnv MAGE_RUN_TYPE store SetEnv MAGE_RUN_CODE english\r\n\r\n4) Now Open frontend, same URL\r\n\r\n-> Italian version is displayed\r\n\r\n### Contribution checklist (*)\r\n - [x] Pull request has a meaningful description of its purpose\r\n - [ x All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds on Travis CI are green)\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/429861798","html_url":"https://github.com/magento/magento2/pull/18623#issuecomment-429861798","issue_url":"https://api.github.com/repos/magento/magento2/issues/18623","id":429861798,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTg2MTc5OA==","user":{"login":"magento-cicd2","id":14279950,"node_id":"MDQ6VXNlcjE0Mjc5OTUw","avatar_url":"https://avatars2.githubusercontent.com/u/14279950?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-cicd2","html_url":"https://github.com/magento-cicd2","followers_url":"https://api.github.com/users/magento-cicd2/followers","following_url":"https://api.github.com/users/magento-cicd2/following{/other_user}","gists_url":"https://api.github.com/users/magento-cicd2/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-cicd2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-cicd2/subscriptions","organizations_url":"https://api.github.com/users/magento-cicd2/orgs","repos_url":"https://api.github.com/users/magento-cicd2/repos","events_url":"https://api.github.com/users/magento-cicd2/events{/privacy}","received_events_url":"https://api.github.com/users/magento-cicd2/received_events","type":"User","site_admin":false},"created_at":"2018-10-15T13:55:23Z","updated_at":"2018-10-15T13:55:23Z","author_association":"CONTRIBUTOR","body":"[![CLA assistant check](https://cla.dev.magento.com/pull/badge/not_signed)](https://cla.dev.magento.com/magento/magento2?pullRequest=18623) <br/>Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our [Contributor License Agreement](https://cla.dev.magento.com/magento/magento2?pullRequest=18623) before we can accept your contribution.<br/>"}}
{"actor":{"display_login":"magento-cicd2"}}