{"action":"created","comment":{"url":"https://api.github.com/repos/jellyfin/jellyfin/pulls/comments/240978730","pull_request_review_id":184132223,"id":240978730,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDk3ODczMA==","diff_hunk":"@@ -83,16 +85,43 @@ private static void SetSqliteProvider()\n             SQLitePCL.Batteries_V2.Init();\n         }\n \n-        private static ServerApplicationPaths CreateApplicationPaths(string applicationPath, string programDataPath)\n+        private static ServerApplicationPaths CreateApplicationPaths(\n+            string applicationPath,\n+            string programDataPath)\n         {\n-            if (string.IsNullOrEmpty(programDataPath))\n+            var appFolderPath = Path.GetDirectoryName(applicationPath);\n+\n+            if (!string.IsNullOrEmpty(programDataPath))\n             {\n-                programDataPath = ApplicationPathHelper.GetProgramDataPath(applicationPath);\n+                return new ServerApplicationPaths(\n+                    programDataPath,\n+                    appFolderPath,\n+                    Path.GetDirectoryName(applicationPath));\n             }\n \n-            var appFolderPath = Path.GetDirectoryName(applicationPath);\n-\n-            return new ServerApplicationPaths(programDataPath, appFolderPath, Path.GetDirectoryName(applicationPath));\n+            var useDebugPaths = false;\n+#if DEBUG","path":"MediaBrowser.Server.Mono/Program.cs","position":52,"original_position":52,"commit_id":"f96a64c16dc06afebad70d76a8544dea3456d916","original_commit_id":"f96a64c16dc06afebad70d76a8544dea3456d916","user":{"login":"BnMcG","id":2544180,"node_id":"MDQ6VXNlcjI1NDQxODA=","avatar_url":"https://avatars1.githubusercontent.com/u/2544180?v=4","gravatar_id":"","url":"https://api.github.com/users/BnMcG","html_url":"https://github.com/BnMcG","followers_url":"https://api.github.com/users/BnMcG/followers","following_url":"https://api.github.com/users/BnMcG/following{/other_user}","gists_url":"https://api.github.com/users/BnMcG/gists{/gist_id}","starred_url":"https://api.github.com/users/BnMcG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BnMcG/subscriptions","organizations_url":"https://api.github.com/users/BnMcG/orgs","repos_url":"https://api.github.com/users/BnMcG/repos","events_url":"https://api.github.com/users/BnMcG/events{/privacy}","received_events_url":"https://api.github.com/users/BnMcG/received_events","type":"User","site_admin":false},"body":"Moved pragma use outside of ApplicationPathHelper to make it testable.","created_at":"2018-12-12T11:32:42Z","updated_at":"2018-12-12T11:36:56Z","html_url":"https://github.com/jellyfin/jellyfin/pull/86#discussion_r240978730","pull_request_url":"https://api.github.com/repos/jellyfin/jellyfin/pulls/86","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/jellyfin/jellyfin/pulls/comments/240978730"},"html":{"href":"https://github.com/jellyfin/jellyfin/pull/86#discussion_r240978730"},"pull_request":{"href":"https://api.github.com/repos/jellyfin/jellyfin/pulls/86"}}},"pull_request":{"url":"https://api.github.com/repos/jellyfin/jellyfin/pulls/86","id":238004010,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MDA0MDEw","html_url":"https://github.com/jellyfin/jellyfin/pull/86","diff_url":"https://github.com/jellyfin/jellyfin/pull/86.diff","patch_url":"https://github.com/jellyfin/jellyfin/pull/86.patch","issue_url":"https://api.github.com/repos/jellyfin/jellyfin/issues/86","number":86,"state":"open","locked":false,"title":"[WIP] ApplicationPathHelper tests","user":{"login":"BnMcG","id":2544180,"node_id":"MDQ6VXNlcjI1NDQxODA=","avatar_url":"https://avatars1.githubusercontent.com/u/2544180?v=4","gravatar_id":"","url":"https://api.github.com/users/BnMcG","html_url":"https://github.com/BnMcG","followers_url":"https://api.github.com/users/BnMcG/followers","following_url":"https://api.github.com/users/BnMcG/following{/other_user}","gists_url":"https://api.github.com/users/BnMcG/gists{/gist_id}","starred_url":"https://api.github.com/users/BnMcG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BnMcG/subscriptions","organizations_url":"https://api.github.com/users/BnMcG/orgs","repos_url":"https://api.github.com/users/BnMcG/repos","events_url":"https://api.github.com/users/BnMcG/events{/privacy}","received_events_url":"https://api.github.com/users/BnMcG/received_events","type":"User","site_admin":false},"body":"Some refactoring to make this class testable. Using NUnit, Moq. Proof of concept for #67 ","created_at":"2018-12-12T11:31:13Z","updated_at":"2018-12-12T11:36:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0770e4f9695010e1494529822c852ebdd41d78fe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jellyfin/jellyfin/pulls/86/commits","review_comments_url":"https://api.github.com/repos/jellyfin/jellyfin/pulls/86/comments","review_comment_url":"https://api.github.com/repos/jellyfin/jellyfin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jellyfin/jellyfin/issues/86/comments","statuses_url":"https://api.github.com/repos/jellyfin/jellyfin/statuses/f96a64c16dc06afebad70d76a8544dea3456d916","head":{"label":"BnMcG:application-path-helper","ref":"application-path-helper","sha":"f96a64c16dc06afebad70d76a8544dea3456d916","user":{"login":"BnMcG","id":2544180,"node_id":"MDQ6VXNlcjI1NDQxODA=","avatar_url":"https://avatars1.githubusercontent.com/u/2544180?v=4","gravatar_id":"","url":"https://api.github.com/users/BnMcG","html_url":"https://github.com/BnMcG","followers_url":"https://api.github.com/users/BnMcG/followers","following_url":"https://api.github.com/users/BnMcG/following{/other_user}","gists_url":"https://api.github.com/users/BnMcG/gists{/gist_id}","starred_url":"https://api.github.com/users/BnMcG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BnMcG/subscriptions","organizations_url":"https://api.github.com/users/BnMcG/orgs","repos_url":"https://api.github.com/users/BnMcG/repos","events_url":"https://api.github.com/users/BnMcG/events{/privacy}","received_events_url":"https://api.github.com/users/BnMcG/received_events","type":"User","site_admin":false},"repo":{"id":161392187,"node_id":"MDEwOlJlcG9zaXRvcnkxNjEzOTIxODc=","name":"jellyfin","full_name":"BnMcG/jellyfin","private":false,"owner":{"login":"BnMcG","id":2544180,"node_id":"MDQ6VXNlcjI1NDQxODA=","avatar_url":"https://avatars1.githubusercontent.com/u/2544180?v=4","gravatar_id":"","url":"https://api.github.com/users/BnMcG","html_url":"https://github.com/BnMcG","followers_url":"https://api.github.com/users/BnMcG/followers","following_url":"https://api.github.com/users/BnMcG/following{/other_user}","gists_url":"https://api.github.com/users/BnMcG/gists{/gist_id}","starred_url":"https://api.github.com/users/BnMcG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BnMcG/subscriptions","organizations_url":"https://api.github.com/users/BnMcG/orgs","repos_url":"https://api.github.com/users/BnMcG/repos","events_url":"https://api.github.com/users/BnMcG/events{/privacy}","received_events_url":"https://api.github.com/users/BnMcG/received_events","type":"User","site_admin":false},"html_url":"https://github.com/BnMcG/jellyfin","description":"The Free Software Media Browser","fork":true,"url":"https://api.github.com/repos/BnMcG/jellyfin","forks_url":"https://api.github.com/repos/BnMcG/jellyfin/forks","keys_url":"https://api.github.com/repos/BnMcG/jellyfin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BnMcG/jellyfin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BnMcG/jellyfin/teams","hooks_url":"https://api.github.com/repos/BnMcG/jellyfin/hooks","issue_events_url":"https://api.github.com/repos/BnMcG/jellyfin/issues/events{/number}","events_url":"https://api.github.com/repos/BnMcG/jellyfin/events","assignees_url":"https://api.github.com/repos/BnMcG/jellyfin/assignees{/user}","branches_url":"https://api.github.com/repos/BnMcG/jellyfin/branches{/branch}","tags_url":"https://api.github.com/repos/BnMcG/jellyfin/tags","blobs_url":"https://api.github.com/repos/BnMcG/jellyfin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BnMcG/jellyfin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BnMcG/jellyfin/git/refs{/sha}","trees_url":"https://api.github.com/repos/BnMcG/jellyfin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BnMcG/jellyfin/statuses/{sha}","languages_url":"https://api.github.com/repos/BnMcG/jellyfin/languages","stargazers_url":"https://api.github.com/repos/BnMcG/jellyfin/stargazers","contributors_url":"https://api.github.com/repos/BnMcG/jellyfin/contributors","subscribers_url":"https://api.github.com/repos/BnMcG/jellyfin/subscribers","subscription_url":"https://api.github.com/repos/BnMcG/jellyfin/subscription","commits_url":"https://api.github.com/repos/BnMcG/jellyfin/commits{/sha}","git_commits_url":"https://api.github.com/repos/BnMcG/jellyfin/git/commits{/sha}","comments_url":"https://api.github.com/repos/BnMcG/jellyfin/comments{/number}","issue_comment_url":"https://api.github.com/repos/BnMcG/jellyfin/issues/comments{/number}","contents_url":"https://api.github.com/repos/BnMcG/jellyfin/contents/{+path}","compare_url":"https://api.github.com/repos/BnMcG/jellyfin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BnMcG/jellyfin/merges","archive_url":"https://api.github.com/repos/BnMcG/jellyfin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BnMcG/jellyfin/downloads","issues_url":"https://api.github.com/repos/BnMcG/jellyfin/issues{/number}","pulls_url":"https://api.github.com/repos/BnMcG/jellyfin/pulls{/number}","milestones_url":"https://api.github.com/repos/BnMcG/jellyfin/milestones{/number}","notifications_url":"https://api.github.com/repos/BnMcG/jellyfin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BnMcG/jellyfin/labels{/name}","releases_url":"https://api.github.com/repos/BnMcG/jellyfin/releases{/id}","deployments_url":"https://api.github.com/repos/BnMcG/jellyfin/deployments","created_at":"2018-12-11T20:51:11Z","updated_at":"2018-12-11T20:51:22Z","pushed_at":"2018-12-12T11:29:57Z","git_url":"git://github.com/BnMcG/jellyfin.git","ssh_url":"git@github.com:BnMcG/jellyfin.git","clone_url":"https://github.com/BnMcG/jellyfin.git","svn_url":"https://github.com/BnMcG/jellyfin","homepage":"","size":1340891,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jellyfin:master","ref":"master","sha":"f0c3789795f621f81e6e9a7cb584bad65b7d2634","user":{"login":"jellyfin","id":45698031,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1Njk4MDMx","avatar_url":"https://avatars2.githubusercontent.com/u/45698031?v=4","gravatar_id":"","url":"https://api.github.com/users/jellyfin","html_url":"https://github.com/jellyfin","followers_url":"https://api.github.com/users/jellyfin/followers","following_url":"https://api.github.com/users/jellyfin/following{/other_user}","gists_url":"https://api.github.com/users/jellyfin/gists{/gist_id}","starred_url":"https://api.github.com/users/jellyfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jellyfin/subscriptions","organizations_url":"https://api.github.com/users/jellyfin/orgs","repos_url":"https://api.github.com/users/jellyfin/repos","events_url":"https://api.github.com/users/jellyfin/events{/privacy}","received_events_url":"https://api.github.com/users/jellyfin/received_events","type":"Organization","site_admin":false},"repo":{"id":161012019,"node_id":"MDEwOlJlcG9zaXRvcnkxNjEwMTIwMTk=","name":"jellyfin","full_name":"jellyfin/jellyfin","private":false,"owner":{"login":"jellyfin","id":45698031,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1Njk4MDMx","avatar_url":"https://avatars2.githubusercontent.com/u/45698031?v=4","gravatar_id":"","url":"https://api.github.com/users/jellyfin","html_url":"https://github.com/jellyfin","followers_url":"https://api.github.com/users/jellyfin/followers","following_url":"https://api.github.com/users/jellyfin/following{/other_user}","gists_url":"https://api.github.com/users/jellyfin/gists{/gist_id}","starred_url":"https://api.github.com/users/jellyfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jellyfin/subscriptions","organizations_url":"https://api.github.com/users/jellyfin/orgs","repos_url":"https://api.github.com/users/jellyfin/repos","events_url":"https://api.github.com/users/jellyfin/events{/privacy}","received_events_url":"https://api.github.com/users/jellyfin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jellyfin/jellyfin","description":"The Free Software Media Browser","fork":false,"url":"https://api.github.com/repos/jellyfin/jellyfin","forks_url":"https://api.github.com/repos/jellyfin/jellyfin/forks","keys_url":"https://api.github.com/repos/jellyfin/jellyfin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jellyfin/jellyfin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jellyfin/jellyfin/teams","hooks_url":"https://api.github.com/repos/jellyfin/jellyfin/hooks","issue_events_url":"https://api.github.com/repos/jellyfin/jellyfin/issues/events{/number}","events_url":"https://api.github.com/repos/jellyfin/jellyfin/events","assignees_url":"https://api.github.com/repos/jellyfin/jellyfin/assignees{/user}","branches_url":"https://api.github.com/repos/jellyfin/jellyfin/branches{/branch}","tags_url":"https://api.github.com/repos/jellyfin/jellyfin/tags","blobs_url":"https://api.github.com/repos/jellyfin/jellyfin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jellyfin/jellyfin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jellyfin/jellyfin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jellyfin/jellyfin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jellyfin/jellyfin/statuses/{sha}","languages_url":"https://api.github.com/repos/jellyfin/jellyfin/languages","stargazers_url":"https://api.github.com/repos/jellyfin/jellyfin/stargazers","contributors_url":"https://api.github.com/repos/jellyfin/jellyfin/contributors","subscribers_url":"https://api.github.com/repos/jellyfin/jellyfin/subscribers","subscription_url":"https://api.github.com/repos/jellyfin/jellyfin/subscription","commits_url":"https://api.github.com/repos/jellyfin/jellyfin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jellyfin/jellyfin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jellyfin/jellyfin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jellyfin/jellyfin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jellyfin/jellyfin/contents/{+path}","compare_url":"https://api.github.com/repos/jellyfin/jellyfin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jellyfin/jellyfin/merges","archive_url":"https://api.github.com/repos/jellyfin/jellyfin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jellyfin/jellyfin/downloads","issues_url":"https://api.github.com/repos/jellyfin/jellyfin/issues{/number}","pulls_url":"https://api.github.com/repos/jellyfin/jellyfin/pulls{/number}","milestones_url":"https://api.github.com/repos/jellyfin/jellyfin/milestones{/number}","notifications_url":"https://api.github.com/repos/jellyfin/jellyfin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jellyfin/jellyfin/labels{/name}","releases_url":"https://api.github.com/repos/jellyfin/jellyfin/releases{/id}","deployments_url":"https://api.github.com/repos/jellyfin/jellyfin/deployments","created_at":"2018-12-09T06:36:45Z","updated_at":"2018-12-12T11:36:21Z","pushed_at":"2018-12-12T11:31:14Z","git_url":"git://github.com/jellyfin/jellyfin.git","ssh_url":"git@github.com:jellyfin/jellyfin.git","clone_url":"https://github.com/jellyfin/jellyfin.git","svn_url":"https://github.com/jellyfin/jellyfin","homepage":"","size":1340596,"stargazers_count":502,"watchers_count":502,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":18,"open_issues":40,"watchers":502,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jellyfin/jellyfin/pulls/86"},"html":{"href":"https://github.com/jellyfin/jellyfin/pull/86"},"issue":{"href":"https://api.github.com/repos/jellyfin/jellyfin/issues/86"},"comments":{"href":"https://api.github.com/repos/jellyfin/jellyfin/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/jellyfin/jellyfin/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/jellyfin/jellyfin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jellyfin/jellyfin/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/jellyfin/jellyfin/statuses/f96a64c16dc06afebad70d76a8544dea3456d916"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"BnMcG"}}