{"action":"created","comment":{"url":"https://api.github.com/repos/rdkit/rdkit/pulls/comments/209595802","pull_request_review_id":145636918,"id":209595802,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTU5NTgwMg==","diff_hunk":"@@ -7466,6 +7466,41 @@ void testGithub1928() {\n   BOOST_LOG(rdInfoLog) << \"Finished\" << std::endl;\n }\n \n+void testGithub1990() {\n+  BOOST_LOG(rdInfoLog) << \"-----------------------\\n Testing Github issue \"\n+                          \"1990: removeHs screws up bond stereo\"\n+                       << std::endl;\n+  {\n+    std::unique_ptr<RWMol> mol(SmilesToMol(\"F/C=C/F\"));\n+    TEST_ASSERT(mol);\n+    MolOps::addHs(*mol);\n+    MolOps::removeHs(*mol);\n+    TEST_ASSERT(mol->getNumAtoms() == 4);\n+    TEST_ASSERT(mol->getBondWithIdx(1)->getStereoAtoms().size() == 2);\n+  }\n+  {  // make sure that stereo is removed when it comes from Hs:","path":"Code/GraphMol/molopstest.cpp","position":16,"original_position":16,"commit_id":"58e77b704044fa311352b940e2c4154eea7451c3","original_commit_id":"58e77b704044fa311352b940e2c4154eea7451c3","user":{"login":"greglandrum","id":540511,"node_id":"MDQ6VXNlcjU0MDUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/540511?v=4","gravatar_id":"","url":"https://api.github.com/users/greglandrum","html_url":"https://github.com/greglandrum","followers_url":"https://api.github.com/users/greglandrum/followers","following_url":"https://api.github.com/users/greglandrum/following{/other_user}","gists_url":"https://api.github.com/users/greglandrum/gists{/gist_id}","starred_url":"https://api.github.com/users/greglandrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greglandrum/subscriptions","organizations_url":"https://api.github.com/users/greglandrum/orgs","repos_url":"https://api.github.com/users/greglandrum/repos","events_url":"https://api.github.com/users/greglandrum/events{/privacy}","received_events_url":"https://api.github.com/users/greglandrum/received_events","type":"User","site_admin":false},"body":"Ah. I was being stupid. Sorry.\r\nYes, the comment is misleading. I will fix it.","created_at":"2018-08-13T12:50:52Z","updated_at":"2018-08-13T12:50:52Z","html_url":"https://github.com/rdkit/rdkit/pull/1992#discussion_r209595802","pull_request_url":"https://api.github.com/repos/rdkit/rdkit/pulls/1992","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rdkit/rdkit/pulls/comments/209595802"},"html":{"href":"https://github.com/rdkit/rdkit/pull/1992#discussion_r209595802"},"pull_request":{"href":"https://api.github.com/repos/rdkit/rdkit/pulls/1992"}},"in_reply_to_id":209467732},"pull_request":{"url":"https://api.github.com/repos/rdkit/rdkit/pulls/1992","id":205525926,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NTI1OTI2","html_url":"https://github.com/rdkit/rdkit/pull/1992","diff_url":"https://github.com/rdkit/rdkit/pull/1992.diff","patch_url":"https://github.com/rdkit/rdkit/pull/1992.patch","issue_url":"https://api.github.com/repos/rdkit/rdkit/issues/1992","number":1992,"state":"open","locked":false,"title":"Fixes #1990","user":{"login":"greglandrum","id":540511,"node_id":"MDQ6VXNlcjU0MDUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/540511?v=4","gravatar_id":"","url":"https://api.github.com/users/greglandrum","html_url":"https://github.com/greglandrum","followers_url":"https://api.github.com/users/greglandrum/followers","following_url":"https://api.github.com/users/greglandrum/following{/other_user}","gists_url":"https://api.github.com/users/greglandrum/gists{/gist_id}","starred_url":"https://api.github.com/users/greglandrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greglandrum/subscriptions","organizations_url":"https://api.github.com/users/greglandrum/orgs","repos_url":"https://api.github.com/users/greglandrum/repos","events_url":"https://api.github.com/users/greglandrum/events{/privacy}","received_events_url":"https://api.github.com/users/greglandrum/received_events","type":"User","site_admin":false},"body":"makes sure we don't destroy a double bond's StereoAtoms just because a bond connected to one of its atoms is removed\r\n\r\n","created_at":"2018-08-01T19:18:19Z","updated_at":"2018-08-13T12:50:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fa096cf73d96fd71ad259bb8c3ef43688e028ab","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rdkit/rdkit/pulls/1992/commits","review_comments_url":"https://api.github.com/repos/rdkit/rdkit/pulls/1992/comments","review_comment_url":"https://api.github.com/repos/rdkit/rdkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rdkit/rdkit/issues/1992/comments","statuses_url":"https://api.github.com/repos/rdkit/rdkit/statuses/58e77b704044fa311352b940e2c4154eea7451c3","head":{"label":"greglandrum:fix/github1990","ref":"fix/github1990","sha":"58e77b704044fa311352b940e2c4154eea7451c3","user":{"login":"greglandrum","id":540511,"node_id":"MDQ6VXNlcjU0MDUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/540511?v=4","gravatar_id":"","url":"https://api.github.com/users/greglandrum","html_url":"https://github.com/greglandrum","followers_url":"https://api.github.com/users/greglandrum/followers","following_url":"https://api.github.com/users/greglandrum/following{/other_user}","gists_url":"https://api.github.com/users/greglandrum/gists{/gist_id}","starred_url":"https://api.github.com/users/greglandrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greglandrum/subscriptions","organizations_url":"https://api.github.com/users/greglandrum/orgs","repos_url":"https://api.github.com/users/greglandrum/repos","events_url":"https://api.github.com/users/greglandrum/events{/privacy}","received_events_url":"https://api.github.com/users/greglandrum/received_events","type":"User","site_admin":false},"repo":{"id":40303040,"node_id":"MDEwOlJlcG9zaXRvcnk0MDMwMzA0MA==","name":"rdkit","full_name":"greglandrum/rdkit","owner":{"login":"greglandrum","id":540511,"node_id":"MDQ6VXNlcjU0MDUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/540511?v=4","gravatar_id":"","url":"https://api.github.com/users/greglandrum","html_url":"https://github.com/greglandrum","followers_url":"https://api.github.com/users/greglandrum/followers","following_url":"https://api.github.com/users/greglandrum/following{/other_user}","gists_url":"https://api.github.com/users/greglandrum/gists{/gist_id}","starred_url":"https://api.github.com/users/greglandrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greglandrum/subscriptions","organizations_url":"https://api.github.com/users/greglandrum/orgs","repos_url":"https://api.github.com/users/greglandrum/repos","events_url":"https://api.github.com/users/greglandrum/events{/privacy}","received_events_url":"https://api.github.com/users/greglandrum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/greglandrum/rdkit","description":"The official sources for the RDKit library","fork":true,"url":"https://api.github.com/repos/greglandrum/rdkit","forks_url":"https://api.github.com/repos/greglandrum/rdkit/forks","keys_url":"https://api.github.com/repos/greglandrum/rdkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greglandrum/rdkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greglandrum/rdkit/teams","hooks_url":"https://api.github.com/repos/greglandrum/rdkit/hooks","issue_events_url":"https://api.github.com/repos/greglandrum/rdkit/issues/events{/number}","events_url":"https://api.github.com/repos/greglandrum/rdkit/events","assignees_url":"https://api.github.com/repos/greglandrum/rdkit/assignees{/user}","branches_url":"https://api.github.com/repos/greglandrum/rdkit/branches{/branch}","tags_url":"https://api.github.com/repos/greglandrum/rdkit/tags","blobs_url":"https://api.github.com/repos/greglandrum/rdkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greglandrum/rdkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greglandrum/rdkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/greglandrum/rdkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greglandrum/rdkit/statuses/{sha}","languages_url":"https://api.github.com/repos/greglandrum/rdkit/languages","stargazers_url":"https://api.github.com/repos/greglandrum/rdkit/stargazers","contributors_url":"https://api.github.com/repos/greglandrum/rdkit/contributors","subscribers_url":"https://api.github.com/repos/greglandrum/rdkit/subscribers","subscription_url":"https://api.github.com/repos/greglandrum/rdkit/subscription","commits_url":"https://api.github.com/repos/greglandrum/rdkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/greglandrum/rdkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/greglandrum/rdkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/greglandrum/rdkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/greglandrum/rdkit/contents/{+path}","compare_url":"https://api.github.com/repos/greglandrum/rdkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greglandrum/rdkit/merges","archive_url":"https://api.github.com/repos/greglandrum/rdkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greglandrum/rdkit/downloads","issues_url":"https://api.github.com/repos/greglandrum/rdkit/issues{/number}","pulls_url":"https://api.github.com/repos/greglandrum/rdkit/pulls{/number}","milestones_url":"https://api.github.com/repos/greglandrum/rdkit/milestones{/number}","notifications_url":"https://api.github.com/repos/greglandrum/rdkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greglandrum/rdkit/labels{/name}","releases_url":"https://api.github.com/repos/greglandrum/rdkit/releases{/id}","deployments_url":"https://api.github.com/repos/greglandrum/rdkit/deployments","created_at":"2015-08-06T12:14:42Z","updated_at":"2018-04-05T06:19:46Z","pushed_at":"2018-08-13T02:42:40Z","git_url":"git://github.com/greglandrum/rdkit.git","ssh_url":"git@github.com:greglandrum/rdkit.git","clone_url":"https://github.com/greglandrum/rdkit.git","svn_url":"https://github.com/greglandrum/rdkit","homepage":"","size":186531,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rdkit:master","ref":"master","sha":"9b11272eecfff7b9687291292659011b454244f2","user":{"login":"rdkit","id":2018047,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTgwNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/2018047?v=4","gravatar_id":"","url":"https://api.github.com/users/rdkit","html_url":"https://github.com/rdkit","followers_url":"https://api.github.com/users/rdkit/followers","following_url":"https://api.github.com/users/rdkit/following{/other_user}","gists_url":"https://api.github.com/users/rdkit/gists{/gist_id}","starred_url":"https://api.github.com/users/rdkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdkit/subscriptions","organizations_url":"https://api.github.com/users/rdkit/orgs","repos_url":"https://api.github.com/users/rdkit/repos","events_url":"https://api.github.com/users/rdkit/events{/privacy}","received_events_url":"https://api.github.com/users/rdkit/received_events","type":"Organization","site_admin":false},"repo":{"id":10009991,"node_id":"MDEwOlJlcG9zaXRvcnkxMDAwOTk5MQ==","name":"rdkit","full_name":"rdkit/rdkit","owner":{"login":"rdkit","id":2018047,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTgwNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/2018047?v=4","gravatar_id":"","url":"https://api.github.com/users/rdkit","html_url":"https://github.com/rdkit","followers_url":"https://api.github.com/users/rdkit/followers","following_url":"https://api.github.com/users/rdkit/following{/other_user}","gists_url":"https://api.github.com/users/rdkit/gists{/gist_id}","starred_url":"https://api.github.com/users/rdkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdkit/subscriptions","organizations_url":"https://api.github.com/users/rdkit/orgs","repos_url":"https://api.github.com/users/rdkit/repos","events_url":"https://api.github.com/users/rdkit/events{/privacy}","received_events_url":"https://api.github.com/users/rdkit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rdkit/rdkit","description":"The official sources for the RDKit library","fork":false,"url":"https://api.github.com/repos/rdkit/rdkit","forks_url":"https://api.github.com/repos/rdkit/rdkit/forks","keys_url":"https://api.github.com/repos/rdkit/rdkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rdkit/rdkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rdkit/rdkit/teams","hooks_url":"https://api.github.com/repos/rdkit/rdkit/hooks","issue_events_url":"https://api.github.com/repos/rdkit/rdkit/issues/events{/number}","events_url":"https://api.github.com/repos/rdkit/rdkit/events","assignees_url":"https://api.github.com/repos/rdkit/rdkit/assignees{/user}","branches_url":"https://api.github.com/repos/rdkit/rdkit/branches{/branch}","tags_url":"https://api.github.com/repos/rdkit/rdkit/tags","blobs_url":"https://api.github.com/repos/rdkit/rdkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rdkit/rdkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rdkit/rdkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/rdkit/rdkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rdkit/rdkit/statuses/{sha}","languages_url":"https://api.github.com/repos/rdkit/rdkit/languages","stargazers_url":"https://api.github.com/repos/rdkit/rdkit/stargazers","contributors_url":"https://api.github.com/repos/rdkit/rdkit/contributors","subscribers_url":"https://api.github.com/repos/rdkit/rdkit/subscribers","subscription_url":"https://api.github.com/repos/rdkit/rdkit/subscription","commits_url":"https://api.github.com/repos/rdkit/rdkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/rdkit/rdkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/rdkit/rdkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/rdkit/rdkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/rdkit/rdkit/contents/{+path}","compare_url":"https://api.github.com/repos/rdkit/rdkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rdkit/rdkit/merges","archive_url":"https://api.github.com/repos/rdkit/rdkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rdkit/rdkit/downloads","issues_url":"https://api.github.com/repos/rdkit/rdkit/issues{/number}","pulls_url":"https://api.github.com/repos/rdkit/rdkit/pulls{/number}","milestones_url":"https://api.github.com/repos/rdkit/rdkit/milestones{/number}","notifications_url":"https://api.github.com/repos/rdkit/rdkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rdkit/rdkit/labels{/name}","releases_url":"https://api.github.com/repos/rdkit/rdkit/releases{/id}","deployments_url":"https://api.github.com/repos/rdkit/rdkit/deployments","created_at":"2013-05-12T06:19:15Z","updated_at":"2018-08-13T12:45:49Z","pushed_at":"2018-08-13T12:45:42Z","git_url":"git://github.com/rdkit/rdkit.git","ssh_url":"git@github.com:rdkit/rdkit.git","clone_url":"https://github.com/rdkit/rdkit.git","svn_url":"https://github.com/rdkit/rdkit","homepage":"","size":137969,"stargazers_count":396,"watchers_count":396,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":227,"mirror_url":null,"archived":false,"open_issues_count":327,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":227,"open_issues":327,"watchers":396,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rdkit/rdkit/pulls/1992"},"html":{"href":"https://github.com/rdkit/rdkit/pull/1992"},"issue":{"href":"https://api.github.com/repos/rdkit/rdkit/issues/1992"},"comments":{"href":"https://api.github.com/repos/rdkit/rdkit/issues/1992/comments"},"review_comments":{"href":"https://api.github.com/repos/rdkit/rdkit/pulls/1992/comments"},"review_comment":{"href":"https://api.github.com/repos/rdkit/rdkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rdkit/rdkit/pulls/1992/commits"},"statuses":{"href":"https://api.github.com/repos/rdkit/rdkit/statuses/58e77b704044fa311352b940e2c4154eea7451c3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"greglandrum"}}