{"action":"created","issue":{"url":"https://api.github.com/repos/trilinos/Trilinos/issues/2219","repository_url":"https://api.github.com/repos/trilinos/Trilinos","labels_url":"https://api.github.com/repos/trilinos/Trilinos/issues/2219/labels{/name}","comments_url":"https://api.github.com/repos/trilinos/Trilinos/issues/2219/comments","events_url":"https://api.github.com/repos/trilinos/Trilinos/issues/2219/events","html_url":"https://github.com/trilinos/Trilinos/pull/2219","id":294909181,"number":2219,"title":"Tempus: Embedded explicit rk","user":{"login":"sconde","id":1556219,"avatar_url":"https://avatars2.githubusercontent.com/u/1556219?v=4","gravatar_id":"","url":"https://api.github.com/users/sconde","html_url":"https://github.com/sconde","followers_url":"https://api.github.com/users/sconde/followers","following_url":"https://api.github.com/users/sconde/following{/other_user}","gists_url":"https://api.github.com/users/sconde/gists{/gist_id}","starred_url":"https://api.github.com/users/sconde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sconde/subscriptions","organizations_url":"https://api.github.com/users/sconde/orgs","repos_url":"https://api.github.com/users/sconde/repos","events_url":"https://api.github.com/users/sconde/events{/privacy}","received_events_url":"https://api.github.com/users/sconde/received_events","type":"User","site_admin":false},"labels":[{"id":604664600,"url":"https://api.github.com/repos/trilinos/Trilinos/labels/Tempus","name":"Tempus","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":60,"created_at":"2018-02-06T20:53:55Z","updated_at":"2018-02-15T04:10:32Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/trilinos/Trilinos/pulls/2219","html_url":"https://github.com/trilinos/Trilinos/pull/2219","diff_url":"https://github.com/trilinos/Trilinos/pull/2219.diff","patch_url":"https://github.com/trilinos/Trilinos/pull/2219.patch"},"body":"<!---\r\nProvide a general summary of your changes in the Title above.  If this pull\r\nrequest pertains to a particular package in Trilinos, it's worthwhile to start\r\nthe title with \"PackageName:  \".\r\n-->\r\nAdd explicit embedded RK capability to Tempus. For explicit rk pairs, this will compute embedded solution and estimate local truncation error.  \r\n\r\nI also added the explicit Bogacki-Shampine 3(2) pair Butcher Tableau. This is the pair that is used in Matlab's ODE23. Additionally, updated the stepper parameterlist to tell stepper in PL to use Embedded or not. This will allow Embedded Butcher Tableau to be used in non-adaptive way (As regular RK). \r\n\r\nI updated the Explicit RK test: update ExplicitRK convegence test for Bogacki-Shampine 3rd order scheme, \r\ntesting the non-embedded Butcher Tableau by telling the stepper in the PL to not use embedded, and test the embedded RK by telling the stepper to use Embedded.¬\r\n\r\n<!---\r\nNote that anything between these delimiters is a comment that will not appear\r\nin the pull request description once created.\r\n-->\r\n\r\n<!---\r\nReplace <teamName> below with the appropriate Trilinos package/team name.\r\n-->\r\n@trilinos/tempus \r\n\r\n<!---\r\nReviewers:  If you know someone who is knowledgeable about what you are\r\nchanging, or perhaps someone who should be, and you would like them to review\r\nyour changes before they are accepted, select them from the Reviewers drop-down\r\non the right.\r\n-->\r\n\r\n<!---\r\nAssignees:  If you know anyone who should likely handle bringing this pull\r\nrequest to completion, select them from the Assignees drop-down on the right.\r\nIf you have write-access to Trilinos, this should likely be you.\r\n-->\r\n\r\n<!---\r\nLables:  Choose any applicable package names from the Labels drop-down on the\r\nright.  Additionally, choose a label to indicate the type of issue, for\r\ninstance, bug, build, documentation, enhancement, etc.\r\n-->\r\n\r\n<!---\r\n## Description\r\n Describe your changes in detail. -->\r\n\r\n<!--\r\n## Motivation and Context\r\n Why is this change required?  What problem does it solve? -->\r\n\r\n## Related Issues\r\n<!---\r\nIf applicable, let us know how this merge request is related to any other open\r\nissues or pull requests:\r\n-->\r\n* Closes \r\n* Blocks \r\n* Is blocked by #2204 \r\n* Follows \r\n* Precedes \r\n* Related to \r\n* Part of \r\n* Composed of \r\n\r\n## How Has This Been Tested?\r\nAll tests passed!\r\n\r\n[Tuesday-2018-02-06-13_32-build_tempus_dev-test.log](https://github.com/trilinos/Trilinos/files/1700750/Tuesday-2018-02-06-13_32-build_tempus_dev-test.log)\r\n\r\n<!---\r\nPlease describe in detail how you tested your changes.  Include details of your\r\ntesting environment and the tests you ran to see how your change affects other\r\nareas of the code.  Consider including configure, build, and test log files.\r\n-->\r\n\r\n## Screenshots\r\n![initial_result_vdp2](https://user-images.githubusercontent.com/1556219/35883552-cea7eaec-0b44-11e8-8462-b7844bb4acbd.png)\r\n\r\n<!--- Not obligatory, but is there anything pertinent that we should see? -->\r\n\r\n## Checklist\r\n<!---\r\nGo over all the following points, and put an `x` in all the boxes that apply.\r\nIf you are unsure about any of these, please ask&mdash;we are here to help.\r\n-->\r\n- [ ] My commit messages mention the appropriate GitHub issue numbers.\r\n- [x] My code follows the code style of the affected package(s).\r\n- [x] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the [code contribution guidelines](../blob/master/CONTRIBUTING.md) for this project.\r\n- [x] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n- [ ] No new compiler warnings were introduced.\r\n- [ ] These changes break backwards compatibility.\r\n\r\n## Additional Information\r\n<!--- Anything else we need to know in evaluating this merge request? -->\r\n"},"comment":{"url":"https://api.github.com/repos/trilinos/Trilinos/issues/comments/365820509","html_url":"https://github.com/trilinos/Trilinos/pull/2219#issuecomment-365820509","issue_url":"https://api.github.com/repos/trilinos/Trilinos/issues/2219","id":365820509,"user":{"login":"trilinos-autotester","id":26070492,"avatar_url":"https://avatars2.githubusercontent.com/u/26070492?v=4","gravatar_id":"","url":"https://api.github.com/users/trilinos-autotester","html_url":"https://github.com/trilinos-autotester","followers_url":"https://api.github.com/users/trilinos-autotester/followers","following_url":"https://api.github.com/users/trilinos-autotester/following{/other_user}","gists_url":"https://api.github.com/users/trilinos-autotester/gists{/gist_id}","starred_url":"https://api.github.com/users/trilinos-autotester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trilinos-autotester/subscriptions","organizations_url":"https://api.github.com/users/trilinos-autotester/orgs","repos_url":"https://api.github.com/users/trilinos-autotester/repos","events_url":"https://api.github.com/users/trilinos-autotester/events{/privacy}","received_events_url":"https://api.github.com/users/trilinos-autotester/received_events","type":"User","site_admin":false},"created_at":"2018-02-15T04:10:32Z","updated_at":"2018-02-15T04:10:32Z","author_association":"NONE","body":"Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging\n           THE LAST COMMIT TO THIS PULL REQUEST HAS NOT BEEN REVIEWED YET!"}}
{"actor":{"display_login":"trilinos-autotester"}}