{"action":"closed","number":3680,"pull_request":{"url":"https://api.github.com/repos/react-navigation/react-navigation/pulls/3680","id":173461591,"html_url":"https://github.com/react-navigation/react-navigation/pull/3680","diff_url":"https://github.com/react-navigation/react-navigation/pull/3680.diff","patch_url":"https://github.com/react-navigation/react-navigation/pull/3680.patch","issue_url":"https://api.github.com/repos/react-navigation/react-navigation/issues/3680","number":3680,"state":"closed","locked":false,"title":"Reworked headerBackImage navigation prop and rendering","user":{"login":"spaceye","id":1742712,"avatar_url":"https://avatars0.githubusercontent.com/u/1742712?v=4","gravatar_id":"","url":"https://api.github.com/users/spaceye","html_url":"https://github.com/spaceye","followers_url":"https://api.github.com/users/spaceye/followers","following_url":"https://api.github.com/users/spaceye/following{/other_user}","gists_url":"https://api.github.com/users/spaceye/gists{/gist_id}","starred_url":"https://api.github.com/users/spaceye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spaceye/subscriptions","organizations_url":"https://api.github.com/users/spaceye/orgs","repos_url":"https://api.github.com/users/spaceye/repos","events_url":"https://api.github.com/users/spaceye/events{/privacy}","received_events_url":"https://api.github.com/users/spaceye/received_events","type":"User","site_admin":false},"body":"**Motivation**\r\n\r\nCurrent headerBackImage navigation property allows for image customization but confines any such custom image to certain hardcoded geometry within corresponding components (i.e. `HeaderBackImage`).\r\n\r\nI've prepared with PR according with the discussion that we've had in #3629.\r\n\r\n**Test plan**\r\n\r\nI've added a new demo suite for this prop, ran it in Expo for both platforms, changed documentation on this prop as while we leave it unchanged we do change its meaning (resource -> element / component).\r\n\r\n**iOS**\r\n<img width=\"467\" alt=\"screen shot 2018-03-07 at 5 01 43 pm\" src=\"https://user-images.githubusercontent.com/1742712/37096423-97d335d4-2229-11e8-8813-8f9d10375666.png\">\r\n<img width=\"467\" alt=\"screen shot 2018-03-07 at 5 01 47 pm\" src=\"https://user-images.githubusercontent.com/1742712/37096427-9b904a04-2229-11e8-9ff9-2f05a6e2e314.png\">\r\n<img width=\"467\" alt=\"screen shot 2018-03-07 at 5 01 49 pm\" src=\"https://user-images.githubusercontent.com/1742712/37096432-9e0cfa02-2229-11e8-91bf-cab82d69b9a4.png\">\r\n\r\n**Android**\r\n<img width=\"488\" alt=\"screen shot 2018-03-07 at 5 05 31 pm\" src=\"https://user-images.githubusercontent.com/1742712/37096477-cec79ad0-2229-11e8-877f-90b3901f7139.png\">\r\n<img width=\"488\" alt=\"screen shot 2018-03-07 at 5 05 41 pm\" src=\"https://user-images.githubusercontent.com/1742712/37096483-d2561c12-2229-11e8-8b2f-ce9c3a5929e6.png\">\r\n<img width=\"488\" alt=\"screen shot 2018-03-07 at 5 05 44 pm\" src=\"https://user-images.githubusercontent.com/1742712/37096494-d5a90d52-2229-11e8-8a86-271e050d9047.png\">\r\n\r\n","created_at":"2018-03-07T14:06:16Z","updated_at":"2018-03-13T20:15:12Z","closed_at":"2018-03-13T20:15:12Z","merged_at":"2018-03-13T20:15:12Z","merge_commit_sha":"d017ed01b3b33b06d05ef157802a8902eec6afc0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"grabbou","id":2464966,"avatar_url":"https://avatars2.githubusercontent.com/u/2464966?v=4","gravatar_id":"","url":"https://api.github.com/users/grabbou","html_url":"https://github.com/grabbou","followers_url":"https://api.github.com/users/grabbou/followers","following_url":"https://api.github.com/users/grabbou/following{/other_user}","gists_url":"https://api.github.com/users/grabbou/gists{/gist_id}","starred_url":"https://api.github.com/users/grabbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grabbou/subscriptions","organizations_url":"https://api.github.com/users/grabbou/orgs","repos_url":"https://api.github.com/users/grabbou/repos","events_url":"https://api.github.com/users/grabbou/events{/privacy}","received_events_url":"https://api.github.com/users/grabbou/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/react-navigation/react-navigation/pulls/3680/commits","review_comments_url":"https://api.github.com/repos/react-navigation/react-navigation/pulls/3680/comments","review_comment_url":"https://api.github.com/repos/react-navigation/react-navigation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/react-navigation/react-navigation/issues/3680/comments","statuses_url":"https://api.github.com/repos/react-navigation/react-navigation/statuses/1f6799248ef4975770a56c1bada30f44cac11406","head":{"label":"spaceye:master","ref":"master","sha":"1f6799248ef4975770a56c1bada30f44cac11406","user":{"login":"spaceye","id":1742712,"avatar_url":"https://avatars0.githubusercontent.com/u/1742712?v=4","gravatar_id":"","url":"https://api.github.com/users/spaceye","html_url":"https://github.com/spaceye","followers_url":"https://api.github.com/users/spaceye/followers","following_url":"https://api.github.com/users/spaceye/following{/other_user}","gists_url":"https://api.github.com/users/spaceye/gists{/gist_id}","starred_url":"https://api.github.com/users/spaceye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spaceye/subscriptions","organizations_url":"https://api.github.com/users/spaceye/orgs","repos_url":"https://api.github.com/users/spaceye/repos","events_url":"https://api.github.com/users/spaceye/events{/privacy}","received_events_url":"https://api.github.com/users/spaceye/received_events","type":"User","site_admin":false},"repo":{"id":124202716,"name":"react-navigation","full_name":"spaceye/react-navigation","owner":{"login":"spaceye","id":1742712,"avatar_url":"https://avatars0.githubusercontent.com/u/1742712?v=4","gravatar_id":"","url":"https://api.github.com/users/spaceye","html_url":"https://github.com/spaceye","followers_url":"https://api.github.com/users/spaceye/followers","following_url":"https://api.github.com/users/spaceye/following{/other_user}","gists_url":"https://api.github.com/users/spaceye/gists{/gist_id}","starred_url":"https://api.github.com/users/spaceye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spaceye/subscriptions","organizations_url":"https://api.github.com/users/spaceye/orgs","repos_url":"https://api.github.com/users/spaceye/repos","events_url":"https://api.github.com/users/spaceye/events{/privacy}","received_events_url":"https://api.github.com/users/spaceye/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spaceye/react-navigation","description":"Routing and navigation for your React Native apps","fork":true,"url":"https://api.github.com/repos/spaceye/react-navigation","forks_url":"https://api.github.com/repos/spaceye/react-navigation/forks","keys_url":"https://api.github.com/repos/spaceye/react-navigation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spaceye/react-navigation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spaceye/react-navigation/teams","hooks_url":"https://api.github.com/repos/spaceye/react-navigation/hooks","issue_events_url":"https://api.github.com/repos/spaceye/react-navigation/issues/events{/number}","events_url":"https://api.github.com/repos/spaceye/react-navigation/events","assignees_url":"https://api.github.com/repos/spaceye/react-navigation/assignees{/user}","branches_url":"https://api.github.com/repos/spaceye/react-navigation/branches{/branch}","tags_url":"https://api.github.com/repos/spaceye/react-navigation/tags","blobs_url":"https://api.github.com/repos/spaceye/react-navigation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spaceye/react-navigation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spaceye/react-navigation/git/refs{/sha}","trees_url":"https://api.github.com/repos/spaceye/react-navigation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spaceye/react-navigation/statuses/{sha}","languages_url":"https://api.github.com/repos/spaceye/react-navigation/languages","stargazers_url":"https://api.github.com/repos/spaceye/react-navigation/stargazers","contributors_url":"https://api.github.com/repos/spaceye/react-navigation/contributors","subscribers_url":"https://api.github.com/repos/spaceye/react-navigation/subscribers","subscription_url":"https://api.github.com/repos/spaceye/react-navigation/subscription","commits_url":"https://api.github.com/repos/spaceye/react-navigation/commits{/sha}","git_commits_url":"https://api.github.com/repos/spaceye/react-navigation/git/commits{/sha}","comments_url":"https://api.github.com/repos/spaceye/react-navigation/comments{/number}","issue_comment_url":"https://api.github.com/repos/spaceye/react-navigation/issues/comments{/number}","contents_url":"https://api.github.com/repos/spaceye/react-navigation/contents/{+path}","compare_url":"https://api.github.com/repos/spaceye/react-navigation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spaceye/react-navigation/merges","archive_url":"https://api.github.com/repos/spaceye/react-navigation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spaceye/react-navigation/downloads","issues_url":"https://api.github.com/repos/spaceye/react-navigation/issues{/number}","pulls_url":"https://api.github.com/repos/spaceye/react-navigation/pulls{/number}","milestones_url":"https://api.github.com/repos/spaceye/react-navigation/milestones{/number}","notifications_url":"https://api.github.com/repos/spaceye/react-navigation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spaceye/react-navigation/labels{/name}","releases_url":"https://api.github.com/repos/spaceye/react-navigation/releases{/id}","deployments_url":"https://api.github.com/repos/spaceye/react-navigation/deployments","created_at":"2018-03-07T08:17:48Z","updated_at":"2018-03-07T08:17:51Z","pushed_at":"2018-03-09T20:16:51Z","git_url":"git://github.com/spaceye/react-navigation.git","ssh_url":"git@github.com:spaceye/react-navigation.git","clone_url":"https://github.com/spaceye/react-navigation.git","svn_url":"https://github.com/spaceye/react-navigation","homepage":"https://reactnavigation.org","size":10070,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"react-navigation:master","ref":"master","sha":"ac83cf804c9ece7a92ee78f1d93ed4b5868559c2","user":{"login":"react-navigation","id":29647600,"avatar_url":"https://avatars2.githubusercontent.com/u/29647600?v=4","gravatar_id":"","url":"https://api.github.com/users/react-navigation","html_url":"https://github.com/react-navigation","followers_url":"https://api.github.com/users/react-navigation/followers","following_url":"https://api.github.com/users/react-navigation/following{/other_user}","gists_url":"https://api.github.com/users/react-navigation/gists{/gist_id}","starred_url":"https://api.github.com/users/react-navigation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-navigation/subscriptions","organizations_url":"https://api.github.com/users/react-navigation/orgs","repos_url":"https://api.github.com/users/react-navigation/repos","events_url":"https://api.github.com/users/react-navigation/events{/privacy}","received_events_url":"https://api.github.com/users/react-navigation/received_events","type":"Organization","site_admin":false},"repo":{"id":80149262,"name":"react-navigation","full_name":"react-navigation/react-navigation","owner":{"login":"react-navigation","id":29647600,"avatar_url":"https://avatars2.githubusercontent.com/u/29647600?v=4","gravatar_id":"","url":"https://api.github.com/users/react-navigation","html_url":"https://github.com/react-navigation","followers_url":"https://api.github.com/users/react-navigation/followers","following_url":"https://api.github.com/users/react-navigation/following{/other_user}","gists_url":"https://api.github.com/users/react-navigation/gists{/gist_id}","starred_url":"https://api.github.com/users/react-navigation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-navigation/subscriptions","organizations_url":"https://api.github.com/users/react-navigation/orgs","repos_url":"https://api.github.com/users/react-navigation/repos","events_url":"https://api.github.com/users/react-navigation/events{/privacy}","received_events_url":"https://api.github.com/users/react-navigation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/react-navigation/react-navigation","description":"Routing and navigation for your React Native apps","fork":false,"url":"https://api.github.com/repos/react-navigation/react-navigation","forks_url":"https://api.github.com/repos/react-navigation/react-navigation/forks","keys_url":"https://api.github.com/repos/react-navigation/react-navigation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/react-navigation/react-navigation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/react-navigation/react-navigation/teams","hooks_url":"https://api.github.com/repos/react-navigation/react-navigation/hooks","issue_events_url":"https://api.github.com/repos/react-navigation/react-navigation/issues/events{/number}","events_url":"https://api.github.com/repos/react-navigation/react-navigation/events","assignees_url":"https://api.github.com/repos/react-navigation/react-navigation/assignees{/user}","branches_url":"https://api.github.com/repos/react-navigation/react-navigation/branches{/branch}","tags_url":"https://api.github.com/repos/react-navigation/react-navigation/tags","blobs_url":"https://api.github.com/repos/react-navigation/react-navigation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/react-navigation/react-navigation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/react-navigation/react-navigation/git/refs{/sha}","trees_url":"https://api.github.com/repos/react-navigation/react-navigation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/react-navigation/react-navigation/statuses/{sha}","languages_url":"https://api.github.com/repos/react-navigation/react-navigation/languages","stargazers_url":"https://api.github.com/repos/react-navigation/react-navigation/stargazers","contributors_url":"https://api.github.com/repos/react-navigation/react-navigation/contributors","subscribers_url":"https://api.github.com/repos/react-navigation/react-navigation/subscribers","subscription_url":"https://api.github.com/repos/react-navigation/react-navigation/subscription","commits_url":"https://api.github.com/repos/react-navigation/react-navigation/commits{/sha}","git_commits_url":"https://api.github.com/repos/react-navigation/react-navigation/git/commits{/sha}","comments_url":"https://api.github.com/repos/react-navigation/react-navigation/comments{/number}","issue_comment_url":"https://api.github.com/repos/react-navigation/react-navigation/issues/comments{/number}","contents_url":"https://api.github.com/repos/react-navigation/react-navigation/contents/{+path}","compare_url":"https://api.github.com/repos/react-navigation/react-navigation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/react-navigation/react-navigation/merges","archive_url":"https://api.github.com/repos/react-navigation/react-navigation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/react-navigation/react-navigation/downloads","issues_url":"https://api.github.com/repos/react-navigation/react-navigation/issues{/number}","pulls_url":"https://api.github.com/repos/react-navigation/react-navigation/pulls{/number}","milestones_url":"https://api.github.com/repos/react-navigation/react-navigation/milestones{/number}","notifications_url":"https://api.github.com/repos/react-navigation/react-navigation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/react-navigation/react-navigation/labels{/name}","releases_url":"https://api.github.com/repos/react-navigation/react-navigation/releases{/id}","deployments_url":"https://api.github.com/repos/react-navigation/react-navigation/deployments","created_at":"2017-01-26T19:51:40Z","updated_at":"2018-03-13T20:14:08Z","pushed_at":"2018-03-13T20:15:12Z","git_url":"git://github.com/react-navigation/react-navigation.git","ssh_url":"git@github.com:react-navigation/react-navigation.git","clone_url":"https://github.com/react-navigation/react-navigation.git","svn_url":"https://github.com/react-navigation/react-navigation","homepage":"https://reactnavigation.org","size":10168,"stargazers_count":10432,"watchers_count":10432,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2293,"mirror_url":null,"archived":false,"open_issues_count":132,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":2293,"open_issues":132,"watchers":10432,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/react-navigation/react-navigation/pulls/3680"},"html":{"href":"https://github.com/react-navigation/react-navigation/pull/3680"},"issue":{"href":"https://api.github.com/repos/react-navigation/react-navigation/issues/3680"},"comments":{"href":"https://api.github.com/repos/react-navigation/react-navigation/issues/3680/comments"},"review_comments":{"href":"https://api.github.com/repos/react-navigation/react-navigation/pulls/3680/comments"},"review_comment":{"href":"https://api.github.com/repos/react-navigation/react-navigation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/react-navigation/react-navigation/pulls/3680/commits"},"statuses":{"href":"https://api.github.com/repos/react-navigation/react-navigation/statuses/1f6799248ef4975770a56c1bada30f44cac11406"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"brentvatne","id":90494,"avatar_url":"https://avatars2.githubusercontent.com/u/90494?v=4","gravatar_id":"","url":"https://api.github.com/users/brentvatne","html_url":"https://github.com/brentvatne","followers_url":"https://api.github.com/users/brentvatne/followers","following_url":"https://api.github.com/users/brentvatne/following{/other_user}","gists_url":"https://api.github.com/users/brentvatne/gists{/gist_id}","starred_url":"https://api.github.com/users/brentvatne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brentvatne/subscriptions","organizations_url":"https://api.github.com/users/brentvatne/orgs","repos_url":"https://api.github.com/users/brentvatne/repos","events_url":"https://api.github.com/users/brentvatne/events{/privacy}","received_events_url":"https://api.github.com/users/brentvatne/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":218,"deletions":29,"changed_files":7}}
{"actor":{"display_login":"brentvatne"}}