{"action":"created","comment":{"url":"https://api.github.com/repos/root-project/root/pulls/comments/225936739","pull_request_review_id":165638628,"id":225936739,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTkzNjczOQ==","diff_hunk":"@@ -10,13 +10,30 @@\n \n ////////////////////////////////////////////////////////////////////////////////\n \n-/*\n-BEGIN_HTML\n-<p>\n-</p>\n-END_HTML\n-*/\n-//\n+/** \\class ParamHistFunc\n+ * \\ingroup HistFactory\n+ *   A class which maps the current values of a RooRealVar\n+ *  (or a set of RooRealVars) to one of a number of RooRealVars:\n+\n+ *  ParamHistFunc: {val1, val2, ...} -> {gamma (RooRealVar)}\n+ *  \n+ *  The intended interpretation is that each parameter in the\n+ *  range represent the height of a bin over the domain\n+ *  space.\n+\n+ *  The 'createParamSet' is an easy way to create these\n+ *  parameters from a set of observables. They are\n+ *  stored using the \"TH1\" ordering convention (as compared\n+ *  to the RooDataHist convention, which is used internally\n+ *  and one must map between the two).\n+\n+ *  All indices include '0'\n+\n+ *  gamma_i_j = paramSet[ size(i)*j + i ]\n+\n+ *  ie assuming the dimensions are 5*5:\n+ *  gamma_2_1 = paramSet[ 5*1 + 2 ] = paramSet[7]","path":"roofit/histfactory/src/ParamHistFunc.cxx","position":33,"original_position":33,"commit_id":"2c08791351be6c291616cf415dac438013fb25aa","original_commit_id":"2c08791351be6c291616cf415dac438013fb25aa","user":{"login":"dpiparo","id":7850302,"node_id":"MDQ6VXNlcjc4NTAzMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/7850302?v=4","gravatar_id":"","url":"https://api.github.com/users/dpiparo","html_url":"https://github.com/dpiparo","followers_url":"https://api.github.com/users/dpiparo/followers","following_url":"https://api.github.com/users/dpiparo/following{/other_user}","gists_url":"https://api.github.com/users/dpiparo/gists{/gist_id}","starred_url":"https://api.github.com/users/dpiparo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpiparo/subscriptions","organizations_url":"https://api.github.com/users/dpiparo/orgs","repos_url":"https://api.github.com/users/dpiparo/repos","events_url":"https://api.github.com/users/dpiparo/events{/privacy}","received_events_url":"https://api.github.com/users/dpiparo/received_events","type":"User","site_admin":false},"body":"say comment about formula block above.","created_at":"2018-10-17T13:50:32Z","updated_at":"2018-10-17T13:56:28Z","html_url":"https://github.com/root-project/root/pull/2812#discussion_r225936739","pull_request_url":"https://api.github.com/repos/root-project/root/pulls/2812","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/root-project/root/pulls/comments/225936739"},"html":{"href":"https://github.com/root-project/root/pull/2812#discussion_r225936739"},"pull_request":{"href":"https://api.github.com/repos/root-project/root/pulls/2812"}}},"pull_request":{"url":"https://api.github.com/repos/root-project/root/pulls/2812","id":223570946,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNTcwOTQ2","html_url":"https://github.com/root-project/root/pull/2812","diff_url":"https://github.com/root-project/root/pull/2812.diff","patch_url":"https://github.com/root-project/root/pull/2812.patch","issue_url":"https://api.github.com/repos/root-project/root/issues/2812","number":2812,"state":"open","locked":false,"title":"[RooFit] Improve doxygen","user":{"login":"hageboeck","id":16205615,"node_id":"MDQ6VXNlcjE2MjA1NjE1","avatar_url":"https://avatars2.githubusercontent.com/u/16205615?v=4","gravatar_id":"","url":"https://api.github.com/users/hageboeck","html_url":"https://github.com/hageboeck","followers_url":"https://api.github.com/users/hageboeck/followers","following_url":"https://api.github.com/users/hageboeck/following{/other_user}","gists_url":"https://api.github.com/users/hageboeck/gists{/gist_id}","starred_url":"https://api.github.com/users/hageboeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hageboeck/subscriptions","organizations_url":"https://api.github.com/users/hageboeck/orgs","repos_url":"https://api.github.com/users/hageboeck/repos","events_url":"https://api.github.com/users/hageboeck/events{/privacy}","received_events_url":"https://api.github.com/users/hageboeck/received_events","type":"User","site_admin":false},"body":"Re-format important roofit documentation to make doxygen understand it.\r\n\r\nAlso make histfactory classes show up in doxygen.","created_at":"2018-10-17T11:46:17Z","updated_at":"2018-10-17T13:56:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f2a6f542d439683db0dee0f47de5cab349dd1a4","assignee":{"login":"hageboeck","id":16205615,"node_id":"MDQ6VXNlcjE2MjA1NjE1","avatar_url":"https://avatars2.githubusercontent.com/u/16205615?v=4","gravatar_id":"","url":"https://api.github.com/users/hageboeck","html_url":"https://github.com/hageboeck","followers_url":"https://api.github.com/users/hageboeck/followers","following_url":"https://api.github.com/users/hageboeck/following{/other_user}","gists_url":"https://api.github.com/users/hageboeck/gists{/gist_id}","starred_url":"https://api.github.com/users/hageboeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hageboeck/subscriptions","organizations_url":"https://api.github.com/users/hageboeck/orgs","repos_url":"https://api.github.com/users/hageboeck/repos","events_url":"https://api.github.com/users/hageboeck/events{/privacy}","received_events_url":"https://api.github.com/users/hageboeck/received_events","type":"User","site_admin":false},"assignees":[{"login":"hageboeck","id":16205615,"node_id":"MDQ6VXNlcjE2MjA1NjE1","avatar_url":"https://avatars2.githubusercontent.com/u/16205615?v=4","gravatar_id":"","url":"https://api.github.com/users/hageboeck","html_url":"https://github.com/hageboeck","followers_url":"https://api.github.com/users/hageboeck/followers","following_url":"https://api.github.com/users/hageboeck/following{/other_user}","gists_url":"https://api.github.com/users/hageboeck/gists{/gist_id}","starred_url":"https://api.github.com/users/hageboeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hageboeck/subscriptions","organizations_url":"https://api.github.com/users/hageboeck/orgs","repos_url":"https://api.github.com/users/hageboeck/repos","events_url":"https://api.github.com/users/hageboeck/events{/privacy}","received_events_url":"https://api.github.com/users/hageboeck/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"couet","id":4697738,"node_id":"MDQ6VXNlcjQ2OTc3Mzg=","avatar_url":"https://avatars1.githubusercontent.com/u/4697738?v=4","gravatar_id":"","url":"https://api.github.com/users/couet","html_url":"https://github.com/couet","followers_url":"https://api.github.com/users/couet/followers","following_url":"https://api.github.com/users/couet/following{/other_user}","gists_url":"https://api.github.com/users/couet/gists{/gist_id}","starred_url":"https://api.github.com/users/couet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/couet/subscriptions","organizations_url":"https://api.github.com/users/couet/orgs","repos_url":"https://api.github.com/users/couet/repos","events_url":"https://api.github.com/users/couet/events{/privacy}","received_events_url":"https://api.github.com/users/couet/received_events","type":"User","site_admin":false},{"login":"lmoneta","id":5213559,"node_id":"MDQ6VXNlcjUyMTM1NTk=","avatar_url":"https://avatars1.githubusercontent.com/u/5213559?v=4","gravatar_id":"","url":"https://api.github.com/users/lmoneta","html_url":"https://github.com/lmoneta","followers_url":"https://api.github.com/users/lmoneta/followers","following_url":"https://api.github.com/users/lmoneta/following{/other_user}","gists_url":"https://api.github.com/users/lmoneta/gists{/gist_id}","starred_url":"https://api.github.com/users/lmoneta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmoneta/subscriptions","organizations_url":"https://api.github.com/users/lmoneta/orgs","repos_url":"https://api.github.com/users/lmoneta/repos","events_url":"https://api.github.com/users/lmoneta/events{/privacy}","received_events_url":"https://api.github.com/users/lmoneta/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/root-project/root/pulls/2812/commits","review_comments_url":"https://api.github.com/repos/root-project/root/pulls/2812/comments","review_comment_url":"https://api.github.com/repos/root-project/root/pulls/comments{/number}","comments_url":"https://api.github.com/repos/root-project/root/issues/2812/comments","statuses_url":"https://api.github.com/repos/root-project/root/statuses/2c08791351be6c291616cf415dac438013fb25aa","head":{"label":"hageboeck:RF_improveDoxygen","ref":"RF_improveDoxygen","sha":"2c08791351be6c291616cf415dac438013fb25aa","user":{"login":"hageboeck","id":16205615,"node_id":"MDQ6VXNlcjE2MjA1NjE1","avatar_url":"https://avatars2.githubusercontent.com/u/16205615?v=4","gravatar_id":"","url":"https://api.github.com/users/hageboeck","html_url":"https://github.com/hageboeck","followers_url":"https://api.github.com/users/hageboeck/followers","following_url":"https://api.github.com/users/hageboeck/following{/other_user}","gists_url":"https://api.github.com/users/hageboeck/gists{/gist_id}","starred_url":"https://api.github.com/users/hageboeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hageboeck/subscriptions","organizations_url":"https://api.github.com/users/hageboeck/orgs","repos_url":"https://api.github.com/users/hageboeck/repos","events_url":"https://api.github.com/users/hageboeck/events{/privacy}","received_events_url":"https://api.github.com/users/hageboeck/received_events","type":"User","site_admin":false},"repo":{"id":47613857,"node_id":"MDEwOlJlcG9zaXRvcnk0NzYxMzg1Nw==","name":"root","full_name":"hageboeck/root","private":false,"owner":{"login":"hageboeck","id":16205615,"node_id":"MDQ6VXNlcjE2MjA1NjE1","avatar_url":"https://avatars2.githubusercontent.com/u/16205615?v=4","gravatar_id":"","url":"https://api.github.com/users/hageboeck","html_url":"https://github.com/hageboeck","followers_url":"https://api.github.com/users/hageboeck/followers","following_url":"https://api.github.com/users/hageboeck/following{/other_user}","gists_url":"https://api.github.com/users/hageboeck/gists{/gist_id}","starred_url":"https://api.github.com/users/hageboeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hageboeck/subscriptions","organizations_url":"https://api.github.com/users/hageboeck/orgs","repos_url":"https://api.github.com/users/hageboeck/repos","events_url":"https://api.github.com/users/hageboeck/events{/privacy}","received_events_url":"https://api.github.com/users/hageboeck/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hageboeck/root","description":"Mirror of official ROOT git repository","fork":true,"url":"https://api.github.com/repos/hageboeck/root","forks_url":"https://api.github.com/repos/hageboeck/root/forks","keys_url":"https://api.github.com/repos/hageboeck/root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hageboeck/root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hageboeck/root/teams","hooks_url":"https://api.github.com/repos/hageboeck/root/hooks","issue_events_url":"https://api.github.com/repos/hageboeck/root/issues/events{/number}","events_url":"https://api.github.com/repos/hageboeck/root/events","assignees_url":"https://api.github.com/repos/hageboeck/root/assignees{/user}","branches_url":"https://api.github.com/repos/hageboeck/root/branches{/branch}","tags_url":"https://api.github.com/repos/hageboeck/root/tags","blobs_url":"https://api.github.com/repos/hageboeck/root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hageboeck/root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hageboeck/root/git/refs{/sha}","trees_url":"https://api.github.com/repos/hageboeck/root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hageboeck/root/statuses/{sha}","languages_url":"https://api.github.com/repos/hageboeck/root/languages","stargazers_url":"https://api.github.com/repos/hageboeck/root/stargazers","contributors_url":"https://api.github.com/repos/hageboeck/root/contributors","subscribers_url":"https://api.github.com/repos/hageboeck/root/subscribers","subscription_url":"https://api.github.com/repos/hageboeck/root/subscription","commits_url":"https://api.github.com/repos/hageboeck/root/commits{/sha}","git_commits_url":"https://api.github.com/repos/hageboeck/root/git/commits{/sha}","comments_url":"https://api.github.com/repos/hageboeck/root/comments{/number}","issue_comment_url":"https://api.github.com/repos/hageboeck/root/issues/comments{/number}","contents_url":"https://api.github.com/repos/hageboeck/root/contents/{+path}","compare_url":"https://api.github.com/repos/hageboeck/root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hageboeck/root/merges","archive_url":"https://api.github.com/repos/hageboeck/root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hageboeck/root/downloads","issues_url":"https://api.github.com/repos/hageboeck/root/issues{/number}","pulls_url":"https://api.github.com/repos/hageboeck/root/pulls{/number}","milestones_url":"https://api.github.com/repos/hageboeck/root/milestones{/number}","notifications_url":"https://api.github.com/repos/hageboeck/root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hageboeck/root/labels{/name}","releases_url":"https://api.github.com/repos/hageboeck/root/releases{/id}","deployments_url":"https://api.github.com/repos/hageboeck/root/deployments","created_at":"2015-12-08T10:01:03Z","updated_at":"2018-10-17T12:46:00Z","pushed_at":"2018-10-17T12:58:17Z","git_url":"git://github.com/hageboeck/root.git","ssh_url":"git@github.com:hageboeck/root.git","clone_url":"https://github.com/hageboeck/root.git","svn_url":"https://github.com/hageboeck/root","homepage":"http://root.cern.ch","size":709515,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"root-project:master","ref":"master","sha":"005ac4c57a9e4651959e0753bc8472932ba8b0b2","user":{"login":"root-project","id":6450093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NTAwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/6450093?v=4","gravatar_id":"","url":"https://api.github.com/users/root-project","html_url":"https://github.com/root-project","followers_url":"https://api.github.com/users/root-project/followers","following_url":"https://api.github.com/users/root-project/following{/other_user}","gists_url":"https://api.github.com/users/root-project/gists{/gist_id}","starred_url":"https://api.github.com/users/root-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-project/subscriptions","organizations_url":"https://api.github.com/users/root-project/orgs","repos_url":"https://api.github.com/users/root-project/repos","events_url":"https://api.github.com/users/root-project/events{/privacy}","received_events_url":"https://api.github.com/users/root-project/received_events","type":"Organization","site_admin":false},"repo":{"id":10994345,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk5NDM0NQ==","name":"root","full_name":"root-project/root","private":false,"owner":{"login":"root-project","id":6450093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NTAwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/6450093?v=4","gravatar_id":"","url":"https://api.github.com/users/root-project","html_url":"https://github.com/root-project","followers_url":"https://api.github.com/users/root-project/followers","following_url":"https://api.github.com/users/root-project/following{/other_user}","gists_url":"https://api.github.com/users/root-project/gists{/gist_id}","starred_url":"https://api.github.com/users/root-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-project/subscriptions","organizations_url":"https://api.github.com/users/root-project/orgs","repos_url":"https://api.github.com/users/root-project/repos","events_url":"https://api.github.com/users/root-project/events{/privacy}","received_events_url":"https://api.github.com/users/root-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/root-project/root","description":"The official repository for ROOT: analyzing, storing and visualizing big data","fork":false,"url":"https://api.github.com/repos/root-project/root","forks_url":"https://api.github.com/repos/root-project/root/forks","keys_url":"https://api.github.com/repos/root-project/root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/root-project/root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/root-project/root/teams","hooks_url":"https://api.github.com/repos/root-project/root/hooks","issue_events_url":"https://api.github.com/repos/root-project/root/issues/events{/number}","events_url":"https://api.github.com/repos/root-project/root/events","assignees_url":"https://api.github.com/repos/root-project/root/assignees{/user}","branches_url":"https://api.github.com/repos/root-project/root/branches{/branch}","tags_url":"https://api.github.com/repos/root-project/root/tags","blobs_url":"https://api.github.com/repos/root-project/root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/root-project/root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/root-project/root/git/refs{/sha}","trees_url":"https://api.github.com/repos/root-project/root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/root-project/root/statuses/{sha}","languages_url":"https://api.github.com/repos/root-project/root/languages","stargazers_url":"https://api.github.com/repos/root-project/root/stargazers","contributors_url":"https://api.github.com/repos/root-project/root/contributors","subscribers_url":"https://api.github.com/repos/root-project/root/subscribers","subscription_url":"https://api.github.com/repos/root-project/root/subscription","commits_url":"https://api.github.com/repos/root-project/root/commits{/sha}","git_commits_url":"https://api.github.com/repos/root-project/root/git/commits{/sha}","comments_url":"https://api.github.com/repos/root-project/root/comments{/number}","issue_comment_url":"https://api.github.com/repos/root-project/root/issues/comments{/number}","contents_url":"https://api.github.com/repos/root-project/root/contents/{+path}","compare_url":"https://api.github.com/repos/root-project/root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/root-project/root/merges","archive_url":"https://api.github.com/repos/root-project/root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/root-project/root/downloads","issues_url":"https://api.github.com/repos/root-project/root/issues{/number}","pulls_url":"https://api.github.com/repos/root-project/root/pulls{/number}","milestones_url":"https://api.github.com/repos/root-project/root/milestones{/number}","notifications_url":"https://api.github.com/repos/root-project/root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/root-project/root/labels{/name}","releases_url":"https://api.github.com/repos/root-project/root/releases{/id}","deployments_url":"https://api.github.com/repos/root-project/root/deployments","created_at":"2013-06-27T10:46:59Z","updated_at":"2018-10-17T12:52:32Z","pushed_at":"2018-10-17T12:58:19Z","git_url":"git://github.com/root-project/root.git","ssh_url":"git@github.com:root-project/root.git","clone_url":"https://github.com/root-project/root.git","svn_url":"https://github.com/root-project/root","homepage":"https://root.cern","size":713025,"stargazers_count":665,"watchers_count":665,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":467,"mirror_url":null,"archived":false,"open_issues_count":91,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":467,"open_issues":91,"watchers":665,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/root-project/root/pulls/2812"},"html":{"href":"https://github.com/root-project/root/pull/2812"},"issue":{"href":"https://api.github.com/repos/root-project/root/issues/2812"},"comments":{"href":"https://api.github.com/repos/root-project/root/issues/2812/comments"},"review_comments":{"href":"https://api.github.com/repos/root-project/root/pulls/2812/comments"},"review_comment":{"href":"https://api.github.com/repos/root-project/root/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/root-project/root/pulls/2812/commits"},"statuses":{"href":"https://api.github.com/repos/root-project/root/statuses/2c08791351be6c291616cf415dac438013fb25aa"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"dpiparo"}}