{"action":"created","issue":{"url":"https://api.github.com/repos/loot/loot-api/issues/36","repository_url":"https://api.github.com/repos/loot/loot-api","labels_url":"https://api.github.com/repos/loot/loot-api/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/loot/loot-api/issues/36/comments","events_url":"https://api.github.com/repos/loot/loot-api/issues/36/events","html_url":"https://github.com/loot/loot-api/issues/36","id":357952869,"node_id":"MDU6SXNzdWUzNTc5NTI4Njk=","number":36,"title":"Allow specifying whether to use ProductVersion or FileVersion for a version() condition","user":{"login":"Freso","id":177659,"node_id":"MDQ6VXNlcjE3NzY1OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/177659?v=4","gravatar_id":"","url":"https://api.github.com/users/Freso","html_url":"https://github.com/Freso","followers_url":"https://api.github.com/users/Freso/followers","following_url":"https://api.github.com/users/Freso/following{/other_user}","gists_url":"https://api.github.com/users/Freso/gists{/gist_id}","starred_url":"https://api.github.com/users/Freso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Freso/subscriptions","organizations_url":"https://api.github.com/users/Freso/orgs","repos_url":"https://api.github.com/users/Freso/repos","events_url":"https://api.github.com/users/Freso/events{/privacy}","received_events_url":"https://api.github.com/users/Freso/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-07T07:33:47Z","updated_at":"2018-09-07T16:15:20Z","closed_at":null,"author_association":"MEMBER","body":"`SkyrimSE.exe` has \"1.0.0.0\" in its `FileVersion` which is what LOOT currently uses for its `version()` condition, and has the \"real\" version (\"1.5.50.0\") in its `ProductVersion` field. This makes it so that there is currently no good way of comparing game versions for Skyrim SE.\r\n\r\nMaybe add `product_version()` and `file_version()` in addition to the current `version()`? Or add another optional parameter to `version()` to specify which to look at for EXE/DLLs (e.g., `version(file, version, comparator{, field})`)? (The latter approach could maybe also be used to handle how different mods use different \"versioning\" methods which could maybe also be named and included there? Not sure if this is currently an issue though, so maybe not worth considering for now.)\r\n\r\nSee https://github.com/loot/skyrimse/commit/2df100a0d42236bd03480c12e14ca00137a4d591 for an example of what is not currently possible for SSE."},"comment":{"url":"https://api.github.com/repos/loot/loot-api/issues/comments/419490205","html_url":"https://github.com/loot/loot-api/issues/36#issuecomment-419490205","issue_url":"https://api.github.com/repos/loot/loot-api/issues/36","id":419490205,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTQ5MDIwNQ==","user":{"login":"WrinklyNinja","id":2430738,"node_id":"MDQ6VXNlcjI0MzA3Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/2430738?v=4","gravatar_id":"","url":"https://api.github.com/users/WrinklyNinja","html_url":"https://github.com/WrinklyNinja","followers_url":"https://api.github.com/users/WrinklyNinja/followers","following_url":"https://api.github.com/users/WrinklyNinja/following{/other_user}","gists_url":"https://api.github.com/users/WrinklyNinja/gists{/gist_id}","starred_url":"https://api.github.com/users/WrinklyNinja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WrinklyNinja/subscriptions","organizations_url":"https://api.github.com/users/WrinklyNinja/orgs","repos_url":"https://api.github.com/users/WrinklyNinja/repos","events_url":"https://api.github.com/users/WrinklyNinja/events{/privacy}","received_events_url":"https://api.github.com/users/WrinklyNinja/received_events","type":"User","site_admin":false},"created_at":"2018-09-07T16:15:20Z","updated_at":"2018-09-07T16:15:20Z","author_association":"MEMBER","body":"Should any work on this wait until the next Skyrim SE update to see if they include the version in `FileVersion`, now that you've given that feedback?"}}
{"actor":{"display_login":"WrinklyNinja"}}