{"action":"opened","number":3218,"pull_request":{"url":"https://api.github.com/repos/raiden-network/raiden/pulls/3218","id":241805503,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxODA1NTAz","html_url":"https://github.com/raiden-network/raiden/pull/3218","diff_url":"https://github.com/raiden-network/raiden/pull/3218.diff","patch_url":"https://github.com/raiden-network/raiden/pull/3218.patch","issue_url":"https://api.github.com/repos/raiden-network/raiden/issues/3218","number":3218,"state":"open","locked":false,"title":"Finish test_different_view_of_last_bp_during_unlock and address related issues","user":{"login":"LefterisJP","id":1658405,"node_id":"MDQ6VXNlcjE2NTg0MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1658405?v=4","gravatar_id":"","url":"https://api.github.com/users/LefterisJP","html_url":"https://github.com/LefterisJP","followers_url":"https://api.github.com/users/LefterisJP/followers","following_url":"https://api.github.com/users/LefterisJP/following{/other_user}","gists_url":"https://api.github.com/users/LefterisJP/gists{/gist_id}","starred_url":"https://api.github.com/users/LefterisJP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LefterisJP/subscriptions","organizations_url":"https://api.github.com/users/LefterisJP/orgs","repos_url":"https://api.github.com/users/LefterisJP/repos","events_url":"https://api.github.com/users/LefterisJP/events{/privacy}","received_events_url":"https://api.github.com/users/LefterisJP/received_events","type":"User","site_admin":false},"body":"Fix #3217 Fix #3216 \r\n\r\nThis PR does the following:\r\n\r\n- Finishes the test left skipped after PR #3197. This tests all the other bullet points.\r\n- During testing we `stop()` and `start()` raiden again. This will also\r\n  stop and start the alarm task. After the initial stop of the alarm\r\n  task the `stop_event` was never set to False again so it never ran\r\n  after a restart.  Fixed by https://github.com/raiden-network/raiden/commit/4bb56d2de98d9b53c5bee74af85f3c21d19e4254\r\n  This may be a cause for other failing integration/stress tests that deal with node restarts.\r\n-  (#3217) If when we are handling `ContractSendChannelUpdateTransfer` we see\r\n  that the onchain state has already been updated with the nonce we were\r\n  about to send then don't send the transaction. Also if\r\n  updateNonClossingBalanceProof throws and the on chain state is already\r\n  up to date fail in a recoverable way.\r\n- (#3216) In some cases there can be a pending transaction left in the\r\n  transaction queues after the first run of the alarm task that would\r\n  have been invalidated if we get the events generated by all the\r\n  transactions sent during the first run of the alarm task. We address this by\r\n adding a poll of the new   block events between the first run of the alarm task\r\n and the initialization of the transaction queues.","created_at":"2019-01-02T17:45:07Z","updated_at":"2019-01-02T17:45:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/raiden-network/raiden/pulls/3218/commits","review_comments_url":"https://api.github.com/repos/raiden-network/raiden/pulls/3218/comments","review_comment_url":"https://api.github.com/repos/raiden-network/raiden/pulls/comments{/number}","comments_url":"https://api.github.com/repos/raiden-network/raiden/issues/3218/comments","statuses_url":"https://api.github.com/repos/raiden-network/raiden/statuses/5fc9fb5789e5ba3bb8bcd8c94358ba02cf01aa10","head":{"label":"LefterisJP:workon_update_non_closing_bp_multiple_sends","ref":"workon_update_non_closing_bp_multiple_sends","sha":"5fc9fb5789e5ba3bb8bcd8c94358ba02cf01aa10","user":{"login":"LefterisJP","id":1658405,"node_id":"MDQ6VXNlcjE2NTg0MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1658405?v=4","gravatar_id":"","url":"https://api.github.com/users/LefterisJP","html_url":"https://github.com/LefterisJP","followers_url":"https://api.github.com/users/LefterisJP/followers","following_url":"https://api.github.com/users/LefterisJP/following{/other_user}","gists_url":"https://api.github.com/users/LefterisJP/gists{/gist_id}","starred_url":"https://api.github.com/users/LefterisJP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LefterisJP/subscriptions","organizations_url":"https://api.github.com/users/LefterisJP/orgs","repos_url":"https://api.github.com/users/LefterisJP/repos","events_url":"https://api.github.com/users/LefterisJP/events{/privacy}","received_events_url":"https://api.github.com/users/LefterisJP/received_events","type":"User","site_admin":false},"repo":{"id":69238217,"node_id":"MDEwOlJlcG9zaXRvcnk2OTIzODIxNw==","name":"raiden","full_name":"LefterisJP/raiden","private":false,"owner":{"login":"LefterisJP","id":1658405,"node_id":"MDQ6VXNlcjE2NTg0MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1658405?v=4","gravatar_id":"","url":"https://api.github.com/users/LefterisJP","html_url":"https://github.com/LefterisJP","followers_url":"https://api.github.com/users/LefterisJP/followers","following_url":"https://api.github.com/users/LefterisJP/following{/other_user}","gists_url":"https://api.github.com/users/LefterisJP/gists{/gist_id}","starred_url":"https://api.github.com/users/LefterisJP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LefterisJP/subscriptions","organizations_url":"https://api.github.com/users/LefterisJP/orgs","repos_url":"https://api.github.com/users/LefterisJP/repos","events_url":"https://api.github.com/users/LefterisJP/events{/privacy}","received_events_url":"https://api.github.com/users/LefterisJP/received_events","type":"User","site_admin":false},"html_url":"https://github.com/LefterisJP/raiden","description":"Raiden Network","fork":true,"url":"https://api.github.com/repos/LefterisJP/raiden","forks_url":"https://api.github.com/repos/LefterisJP/raiden/forks","keys_url":"https://api.github.com/repos/LefterisJP/raiden/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LefterisJP/raiden/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LefterisJP/raiden/teams","hooks_url":"https://api.github.com/repos/LefterisJP/raiden/hooks","issue_events_url":"https://api.github.com/repos/LefterisJP/raiden/issues/events{/number}","events_url":"https://api.github.com/repos/LefterisJP/raiden/events","assignees_url":"https://api.github.com/repos/LefterisJP/raiden/assignees{/user}","branches_url":"https://api.github.com/repos/LefterisJP/raiden/branches{/branch}","tags_url":"https://api.github.com/repos/LefterisJP/raiden/tags","blobs_url":"https://api.github.com/repos/LefterisJP/raiden/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LefterisJP/raiden/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LefterisJP/raiden/git/refs{/sha}","trees_url":"https://api.github.com/repos/LefterisJP/raiden/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LefterisJP/raiden/statuses/{sha}","languages_url":"https://api.github.com/repos/LefterisJP/raiden/languages","stargazers_url":"https://api.github.com/repos/LefterisJP/raiden/stargazers","contributors_url":"https://api.github.com/repos/LefterisJP/raiden/contributors","subscribers_url":"https://api.github.com/repos/LefterisJP/raiden/subscribers","subscription_url":"https://api.github.com/repos/LefterisJP/raiden/subscription","commits_url":"https://api.github.com/repos/LefterisJP/raiden/commits{/sha}","git_commits_url":"https://api.github.com/repos/LefterisJP/raiden/git/commits{/sha}","comments_url":"https://api.github.com/repos/LefterisJP/raiden/comments{/number}","issue_comment_url":"https://api.github.com/repos/LefterisJP/raiden/issues/comments{/number}","contents_url":"https://api.github.com/repos/LefterisJP/raiden/contents/{+path}","compare_url":"https://api.github.com/repos/LefterisJP/raiden/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LefterisJP/raiden/merges","archive_url":"https://api.github.com/repos/LefterisJP/raiden/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LefterisJP/raiden/downloads","issues_url":"https://api.github.com/repos/LefterisJP/raiden/issues{/number}","pulls_url":"https://api.github.com/repos/LefterisJP/raiden/pulls{/number}","milestones_url":"https://api.github.com/repos/LefterisJP/raiden/milestones{/number}","notifications_url":"https://api.github.com/repos/LefterisJP/raiden/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LefterisJP/raiden/labels{/name}","releases_url":"https://api.github.com/repos/LefterisJP/raiden/releases{/id}","deployments_url":"https://api.github.com/repos/LefterisJP/raiden/deployments","created_at":"2016-09-26T10:14:16Z","updated_at":"2018-12-22T21:06:24Z","pushed_at":"2019-01-02T17:40:36Z","git_url":"git://github.com/LefterisJP/raiden.git","ssh_url":"git@github.com:LefterisJP/raiden.git","clone_url":"https://github.com/LefterisJP/raiden.git","svn_url":"https://github.com/LefterisJP/raiden","homepage":null,"size":14746,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"raiden-network:master","ref":"master","sha":"cf826441b00513069d563fff4e9c65636abfbb72","user":{"login":"raiden-network","id":19666847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NjY2ODQ3","avatar_url":"https://avatars1.githubusercontent.com/u/19666847?v=4","gravatar_id":"","url":"https://api.github.com/users/raiden-network","html_url":"https://github.com/raiden-network","followers_url":"https://api.github.com/users/raiden-network/followers","following_url":"https://api.github.com/users/raiden-network/following{/other_user}","gists_url":"https://api.github.com/users/raiden-network/gists{/gist_id}","starred_url":"https://api.github.com/users/raiden-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raiden-network/subscriptions","organizations_url":"https://api.github.com/users/raiden-network/orgs","repos_url":"https://api.github.com/users/raiden-network/repos","events_url":"https://api.github.com/users/raiden-network/events{/privacy}","received_events_url":"https://api.github.com/users/raiden-network/received_events","type":"Organization","site_admin":false},"repo":{"id":50646767,"node_id":"MDEwOlJlcG9zaXRvcnk1MDY0Njc2Nw==","name":"raiden","full_name":"raiden-network/raiden","private":false,"owner":{"login":"raiden-network","id":19666847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NjY2ODQ3","avatar_url":"https://avatars1.githubusercontent.com/u/19666847?v=4","gravatar_id":"","url":"https://api.github.com/users/raiden-network","html_url":"https://github.com/raiden-network","followers_url":"https://api.github.com/users/raiden-network/followers","following_url":"https://api.github.com/users/raiden-network/following{/other_user}","gists_url":"https://api.github.com/users/raiden-network/gists{/gist_id}","starred_url":"https://api.github.com/users/raiden-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raiden-network/subscriptions","organizations_url":"https://api.github.com/users/raiden-network/orgs","repos_url":"https://api.github.com/users/raiden-network/repos","events_url":"https://api.github.com/users/raiden-network/events{/privacy}","received_events_url":"https://api.github.com/users/raiden-network/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/raiden-network/raiden","description":"Raiden Network","fork":false,"url":"https://api.github.com/repos/raiden-network/raiden","forks_url":"https://api.github.com/repos/raiden-network/raiden/forks","keys_url":"https://api.github.com/repos/raiden-network/raiden/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raiden-network/raiden/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raiden-network/raiden/teams","hooks_url":"https://api.github.com/repos/raiden-network/raiden/hooks","issue_events_url":"https://api.github.com/repos/raiden-network/raiden/issues/events{/number}","events_url":"https://api.github.com/repos/raiden-network/raiden/events","assignees_url":"https://api.github.com/repos/raiden-network/raiden/assignees{/user}","branches_url":"https://api.github.com/repos/raiden-network/raiden/branches{/branch}","tags_url":"https://api.github.com/repos/raiden-network/raiden/tags","blobs_url":"https://api.github.com/repos/raiden-network/raiden/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raiden-network/raiden/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raiden-network/raiden/git/refs{/sha}","trees_url":"https://api.github.com/repos/raiden-network/raiden/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raiden-network/raiden/statuses/{sha}","languages_url":"https://api.github.com/repos/raiden-network/raiden/languages","stargazers_url":"https://api.github.com/repos/raiden-network/raiden/stargazers","contributors_url":"https://api.github.com/repos/raiden-network/raiden/contributors","subscribers_url":"https://api.github.com/repos/raiden-network/raiden/subscribers","subscription_url":"https://api.github.com/repos/raiden-network/raiden/subscription","commits_url":"https://api.github.com/repos/raiden-network/raiden/commits{/sha}","git_commits_url":"https://api.github.com/repos/raiden-network/raiden/git/commits{/sha}","comments_url":"https://api.github.com/repos/raiden-network/raiden/comments{/number}","issue_comment_url":"https://api.github.com/repos/raiden-network/raiden/issues/comments{/number}","contents_url":"https://api.github.com/repos/raiden-network/raiden/contents/{+path}","compare_url":"https://api.github.com/repos/raiden-network/raiden/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raiden-network/raiden/merges","archive_url":"https://api.github.com/repos/raiden-network/raiden/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raiden-network/raiden/downloads","issues_url":"https://api.github.com/repos/raiden-network/raiden/issues{/number}","pulls_url":"https://api.github.com/repos/raiden-network/raiden/pulls{/number}","milestones_url":"https://api.github.com/repos/raiden-network/raiden/milestones{/number}","notifications_url":"https://api.github.com/repos/raiden-network/raiden/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raiden-network/raiden/labels{/name}","releases_url":"https://api.github.com/repos/raiden-network/raiden/releases{/id}","deployments_url":"https://api.github.com/repos/raiden-network/raiden/deployments","created_at":"2016-01-29T07:40:47Z","updated_at":"2019-01-02T15:38:14Z","pushed_at":"2019-01-02T15:38:09Z","git_url":"git://github.com/raiden-network/raiden.git","ssh_url":"git@github.com:raiden-network/raiden.git","clone_url":"https://github.com/raiden-network/raiden.git","svn_url":"https://github.com/raiden-network/raiden","homepage":null,"size":14582,"stargazers_count":1622,"watchers_count":1622,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":340,"mirror_url":null,"archived":false,"open_issues_count":208,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":340,"open_issues":208,"watchers":1622,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/3218"},"html":{"href":"https://github.com/raiden-network/raiden/pull/3218"},"issue":{"href":"https://api.github.com/repos/raiden-network/raiden/issues/3218"},"comments":{"href":"https://api.github.com/repos/raiden-network/raiden/issues/3218/comments"},"review_comments":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/3218/comments"},"review_comment":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/3218/commits"},"statuses":{"href":"https://api.github.com/repos/raiden-network/raiden/statuses/5fc9fb5789e5ba3bb8bcd8c94358ba02cf01aa10"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":5,"additions":93,"deletions":20,"changed_files":5}}
{"actor":{"display_login":"LefterisJP"}}