{"action":"created","comment":{"url":"https://api.github.com/repos/chulab/super_resolution/pulls/comments/235849782","pull_request_review_id":177811798,"id":235849782,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTg0OTc4Mg==","diff_hunk":"@@ -15,23 +15,24 @@ def convolve_complex_1d(\n \n   Args:\n     tensor: `tf.Tensor` with shape `batch_dimensions + [convolution_dimension]`.\n-    filter: `tf.Tensor` with shape `[filter_length]`.\n+    filter: `tf.Tensor` with shape `[filter_length, num_channels]`.\n     padding: Type of padding. May be `VALID` or `SAME`.\n     stride: Stride size to use between convolutions.\n \n   Returns:\n-    `tf.Tensor` resulting from convolving `padding` with `tensor`.\n+    `tf.Tensor` resulting from convolving `padding` with `tensor`. Has shape\n+    `batch_dimensions + convolution_dimensions + [num_channels]`\n \n   Raises:\n     ValueError: If `tensor` and `filter` do not have compatible dtype or if\n       `filters` is not 1D.","path":"simulation/complex_convolution.py","position":25,"original_position":25,"commit_id":"31883fa24003470ef7bc81dd56a0a1137b178b4d","original_commit_id":"31883fa24003470ef7bc81dd56a0a1137b178b4d","user":{"login":"Noahyt","id":23128135,"node_id":"MDQ6VXNlcjIzMTI4MTM1","avatar_url":"https://avatars1.githubusercontent.com/u/23128135?v=4","gravatar_id":"","url":"https://api.github.com/users/Noahyt","html_url":"https://github.com/Noahyt","followers_url":"https://api.github.com/users/Noahyt/followers","following_url":"https://api.github.com/users/Noahyt/following{/other_user}","gists_url":"https://api.github.com/users/Noahyt/gists{/gist_id}","starred_url":"https://api.github.com/users/Noahyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Noahyt/subscriptions","organizations_url":"https://api.github.com/users/Noahyt/orgs","repos_url":"https://api.github.com/users/Noahyt/repos","events_url":"https://api.github.com/users/Noahyt/events{/privacy}","received_events_url":"https://api.github.com/users/Noahyt/received_events","type":"User","site_admin":false},"body":"Correct","created_at":"2018-11-23T05:39:20Z","updated_at":"2018-11-23T05:39:30Z","html_url":"https://github.com/chulab/super_resolution/pull/9#discussion_r235849782","pull_request_url":"https://api.github.com/repos/chulab/super_resolution/pulls/9","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/chulab/super_resolution/pulls/comments/235849782"},"html":{"href":"https://github.com/chulab/super_resolution/pull/9#discussion_r235849782"},"pull_request":{"href":"https://api.github.com/repos/chulab/super_resolution/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/chulab/super_resolution/pulls/9","id":233110179,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMTEwMTc5","html_url":"https://github.com/chulab/super_resolution/pull/9","diff_url":"https://github.com/chulab/super_resolution/pull/9.diff","patch_url":"https://github.com/chulab/super_resolution/pull/9.patch","issue_url":"https://api.github.com/repos/chulab/super_resolution/issues/9","number":9,"state":"open","locked":false,"title":"Implement multi-filter batch convolution.","user":{"login":"Noahyt","id":23128135,"node_id":"MDQ6VXNlcjIzMTI4MTM1","avatar_url":"https://avatars1.githubusercontent.com/u/23128135?v=4","gravatar_id":"","url":"https://api.github.com/users/Noahyt","html_url":"https://github.com/Noahyt","followers_url":"https://api.github.com/users/Noahyt/followers","following_url":"https://api.github.com/users/Noahyt/following{/other_user}","gists_url":"https://api.github.com/users/Noahyt/gists{/gist_id}","starred_url":"https://api.github.com/users/Noahyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Noahyt/subscriptions","organizations_url":"https://api.github.com/users/Noahyt/orgs","repos_url":"https://api.github.com/users/Noahyt/repos","events_url":"https://api.github.com/users/Noahyt/events{/privacy}","received_events_url":"https://api.github.com/users/Noahyt/received_events","type":"User","site_admin":false},"body":"CONTEXT: The image formation process is modeled by convolving a complex PSF with the scatterer distribution. In order to represent more orthogonal speckle patterns we will have to use multiple frequencies. This is equivalent to using multiple psfs when forming the image.\r\n\r\nSCOPE: Previously we could only convolve a single filter at a time with a batch of images.  This CL implements multi-filter convolution.","created_at":"2018-11-23T05:37:33Z","updated_at":"2018-11-23T05:39:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3077b23c0fb5b566d194e3779a027e1fa9012f27","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/chulab/super_resolution/pulls/9/commits","review_comments_url":"https://api.github.com/repos/chulab/super_resolution/pulls/9/comments","review_comment_url":"https://api.github.com/repos/chulab/super_resolution/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chulab/super_resolution/issues/9/comments","statuses_url":"https://api.github.com/repos/chulab/super_resolution/statuses/31883fa24003470ef7bc81dd56a0a1137b178b4d","head":{"label":"chulab:multi_dimension_complex_convolution","ref":"multi_dimension_complex_convolution","sha":"31883fa24003470ef7bc81dd56a0a1137b178b4d","user":{"login":"chulab","id":40500664,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNTAwNjY0","avatar_url":"https://avatars0.githubusercontent.com/u/40500664?v=4","gravatar_id":"","url":"https://api.github.com/users/chulab","html_url":"https://github.com/chulab","followers_url":"https://api.github.com/users/chulab/followers","following_url":"https://api.github.com/users/chulab/following{/other_user}","gists_url":"https://api.github.com/users/chulab/gists{/gist_id}","starred_url":"https://api.github.com/users/chulab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chulab/subscriptions","organizations_url":"https://api.github.com/users/chulab/orgs","repos_url":"https://api.github.com/users/chulab/repos","events_url":"https://api.github.com/users/chulab/events{/privacy}","received_events_url":"https://api.github.com/users/chulab/received_events","type":"Organization","site_admin":false},"repo":{"id":155778598,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU3Nzg1OTg=","name":"super_resolution","full_name":"chulab/super_resolution","private":false,"owner":{"login":"chulab","id":40500664,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNTAwNjY0","avatar_url":"https://avatars0.githubusercontent.com/u/40500664?v=4","gravatar_id":"","url":"https://api.github.com/users/chulab","html_url":"https://github.com/chulab","followers_url":"https://api.github.com/users/chulab/followers","following_url":"https://api.github.com/users/chulab/following{/other_user}","gists_url":"https://api.github.com/users/chulab/gists{/gist_id}","starred_url":"https://api.github.com/users/chulab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chulab/subscriptions","organizations_url":"https://api.github.com/users/chulab/orgs","repos_url":"https://api.github.com/users/chulab/repos","events_url":"https://api.github.com/users/chulab/events{/privacy}","received_events_url":"https://api.github.com/users/chulab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/chulab/super_resolution","description":"Repository for coherent imaging super resolution project.","fork":false,"url":"https://api.github.com/repos/chulab/super_resolution","forks_url":"https://api.github.com/repos/chulab/super_resolution/forks","keys_url":"https://api.github.com/repos/chulab/super_resolution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chulab/super_resolution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chulab/super_resolution/teams","hooks_url":"https://api.github.com/repos/chulab/super_resolution/hooks","issue_events_url":"https://api.github.com/repos/chulab/super_resolution/issues/events{/number}","events_url":"https://api.github.com/repos/chulab/super_resolution/events","assignees_url":"https://api.github.com/repos/chulab/super_resolution/assignees{/user}","branches_url":"https://api.github.com/repos/chulab/super_resolution/branches{/branch}","tags_url":"https://api.github.com/repos/chulab/super_resolution/tags","blobs_url":"https://api.github.com/repos/chulab/super_resolution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chulab/super_resolution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chulab/super_resolution/git/refs{/sha}","trees_url":"https://api.github.com/repos/chulab/super_resolution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chulab/super_resolution/statuses/{sha}","languages_url":"https://api.github.com/repos/chulab/super_resolution/languages","stargazers_url":"https://api.github.com/repos/chulab/super_resolution/stargazers","contributors_url":"https://api.github.com/repos/chulab/super_resolution/contributors","subscribers_url":"https://api.github.com/repos/chulab/super_resolution/subscribers","subscription_url":"https://api.github.com/repos/chulab/super_resolution/subscription","commits_url":"https://api.github.com/repos/chulab/super_resolution/commits{/sha}","git_commits_url":"https://api.github.com/repos/chulab/super_resolution/git/commits{/sha}","comments_url":"https://api.github.com/repos/chulab/super_resolution/comments{/number}","issue_comment_url":"https://api.github.com/repos/chulab/super_resolution/issues/comments{/number}","contents_url":"https://api.github.com/repos/chulab/super_resolution/contents/{+path}","compare_url":"https://api.github.com/repos/chulab/super_resolution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chulab/super_resolution/merges","archive_url":"https://api.github.com/repos/chulab/super_resolution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chulab/super_resolution/downloads","issues_url":"https://api.github.com/repos/chulab/super_resolution/issues{/number}","pulls_url":"https://api.github.com/repos/chulab/super_resolution/pulls{/number}","milestones_url":"https://api.github.com/repos/chulab/super_resolution/milestones{/number}","notifications_url":"https://api.github.com/repos/chulab/super_resolution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chulab/super_resolution/labels{/name}","releases_url":"https://api.github.com/repos/chulab/super_resolution/releases{/id}","deployments_url":"https://api.github.com/repos/chulab/super_resolution/deployments","created_at":"2018-11-01T21:34:03Z","updated_at":"2018-11-22T22:29:23Z","pushed_at":"2018-11-23T05:37:34Z","git_url":"git://github.com/chulab/super_resolution.git","ssh_url":"git@github.com:chulab/super_resolution.git","clone_url":"https://github.com/chulab/super_resolution.git","svn_url":"https://github.com/chulab/super_resolution","homepage":null,"size":22,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"chulab:master","ref":"master","sha":"3bbabb6dfb0181bf60a49f425a6a963a8cd2b885","user":{"login":"chulab","id":40500664,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNTAwNjY0","avatar_url":"https://avatars0.githubusercontent.com/u/40500664?v=4","gravatar_id":"","url":"https://api.github.com/users/chulab","html_url":"https://github.com/chulab","followers_url":"https://api.github.com/users/chulab/followers","following_url":"https://api.github.com/users/chulab/following{/other_user}","gists_url":"https://api.github.com/users/chulab/gists{/gist_id}","starred_url":"https://api.github.com/users/chulab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chulab/subscriptions","organizations_url":"https://api.github.com/users/chulab/orgs","repos_url":"https://api.github.com/users/chulab/repos","events_url":"https://api.github.com/users/chulab/events{/privacy}","received_events_url":"https://api.github.com/users/chulab/received_events","type":"Organization","site_admin":false},"repo":{"id":155778598,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU3Nzg1OTg=","name":"super_resolution","full_name":"chulab/super_resolution","private":false,"owner":{"login":"chulab","id":40500664,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNTAwNjY0","avatar_url":"https://avatars0.githubusercontent.com/u/40500664?v=4","gravatar_id":"","url":"https://api.github.com/users/chulab","html_url":"https://github.com/chulab","followers_url":"https://api.github.com/users/chulab/followers","following_url":"https://api.github.com/users/chulab/following{/other_user}","gists_url":"https://api.github.com/users/chulab/gists{/gist_id}","starred_url":"https://api.github.com/users/chulab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chulab/subscriptions","organizations_url":"https://api.github.com/users/chulab/orgs","repos_url":"https://api.github.com/users/chulab/repos","events_url":"https://api.github.com/users/chulab/events{/privacy}","received_events_url":"https://api.github.com/users/chulab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/chulab/super_resolution","description":"Repository for coherent imaging super resolution project.","fork":false,"url":"https://api.github.com/repos/chulab/super_resolution","forks_url":"https://api.github.com/repos/chulab/super_resolution/forks","keys_url":"https://api.github.com/repos/chulab/super_resolution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chulab/super_resolution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chulab/super_resolution/teams","hooks_url":"https://api.github.com/repos/chulab/super_resolution/hooks","issue_events_url":"https://api.github.com/repos/chulab/super_resolution/issues/events{/number}","events_url":"https://api.github.com/repos/chulab/super_resolution/events","assignees_url":"https://api.github.com/repos/chulab/super_resolution/assignees{/user}","branches_url":"https://api.github.com/repos/chulab/super_resolution/branches{/branch}","tags_url":"https://api.github.com/repos/chulab/super_resolution/tags","blobs_url":"https://api.github.com/repos/chulab/super_resolution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chulab/super_resolution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chulab/super_resolution/git/refs{/sha}","trees_url":"https://api.github.com/repos/chulab/super_resolution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chulab/super_resolution/statuses/{sha}","languages_url":"https://api.github.com/repos/chulab/super_resolution/languages","stargazers_url":"https://api.github.com/repos/chulab/super_resolution/stargazers","contributors_url":"https://api.github.com/repos/chulab/super_resolution/contributors","subscribers_url":"https://api.github.com/repos/chulab/super_resolution/subscribers","subscription_url":"https://api.github.com/repos/chulab/super_resolution/subscription","commits_url":"https://api.github.com/repos/chulab/super_resolution/commits{/sha}","git_commits_url":"https://api.github.com/repos/chulab/super_resolution/git/commits{/sha}","comments_url":"https://api.github.com/repos/chulab/super_resolution/comments{/number}","issue_comment_url":"https://api.github.com/repos/chulab/super_resolution/issues/comments{/number}","contents_url":"https://api.github.com/repos/chulab/super_resolution/contents/{+path}","compare_url":"https://api.github.com/repos/chulab/super_resolution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chulab/super_resolution/merges","archive_url":"https://api.github.com/repos/chulab/super_resolution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chulab/super_resolution/downloads","issues_url":"https://api.github.com/repos/chulab/super_resolution/issues{/number}","pulls_url":"https://api.github.com/repos/chulab/super_resolution/pulls{/number}","milestones_url":"https://api.github.com/repos/chulab/super_resolution/milestones{/number}","notifications_url":"https://api.github.com/repos/chulab/super_resolution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chulab/super_resolution/labels{/name}","releases_url":"https://api.github.com/repos/chulab/super_resolution/releases{/id}","deployments_url":"https://api.github.com/repos/chulab/super_resolution/deployments","created_at":"2018-11-01T21:34:03Z","updated_at":"2018-11-22T22:29:23Z","pushed_at":"2018-11-23T05:37:34Z","git_url":"git://github.com/chulab/super_resolution.git","ssh_url":"git@github.com:chulab/super_resolution.git","clone_url":"https://github.com/chulab/super_resolution.git","svn_url":"https://github.com/chulab/super_resolution","homepage":null,"size":22,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chulab/super_resolution/pulls/9"},"html":{"href":"https://github.com/chulab/super_resolution/pull/9"},"issue":{"href":"https://api.github.com/repos/chulab/super_resolution/issues/9"},"comments":{"href":"https://api.github.com/repos/chulab/super_resolution/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/chulab/super_resolution/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/chulab/super_resolution/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chulab/super_resolution/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/chulab/super_resolution/statuses/31883fa24003470ef7bc81dd56a0a1137b178b4d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Noahyt"}}