{"action":"created","comment":{"url":"https://api.github.com/repos/opentracing/opentracing-java/pulls/comments/229111383","pull_request_review_id":169533840,"id":229111383,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTExMTM4Mw==","diff_hunk":"@@ -0,0 +1,20 @@\n+/*\n+ * Copyright 2016-2018 The OpenTracing Authors\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except\n+ * in compliance with the License. You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software distributed under the License\n+ * is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express\n+ * or implied. See the License for the specific language governing permissions and limitations under\n+ * the License.\n+ */\n+package io.opentracing.tag;\n+\n+import io.opentracing.Span;\n+\n+public interface Tag<T> {\n+    String getKey();","path":"opentracing-api/src/main/java/io/opentracing/tag/Tag.java","position":19,"original_position":19,"commit_id":"19b1d3c3f8e6298b6d4bbf5bb8339b88d446f876","original_commit_id":"19b1d3c3f8e6298b6d4bbf5bb8339b88d446f876","user":{"login":"yurishkuro","id":3523016,"node_id":"MDQ6VXNlcjM1MjMwMTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3523016?v=4","gravatar_id":"","url":"https://api.github.com/users/yurishkuro","html_url":"https://github.com/yurishkuro","followers_url":"https://api.github.com/users/yurishkuro/followers","following_url":"https://api.github.com/users/yurishkuro/following{/other_user}","gists_url":"https://api.github.com/users/yurishkuro/gists{/gist_id}","starred_url":"https://api.github.com/users/yurishkuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurishkuro/subscriptions","organizations_url":"https://api.github.com/users/yurishkuro/orgs","repos_url":"https://api.github.com/users/yurishkuro/repos","events_url":"https://api.github.com/users/yurishkuro/events{/privacy}","received_events_url":"https://api.github.com/users/yurishkuro/received_events","type":"User","site_admin":false},"body":"How about setValue(Span, T) instead?","created_at":"2018-10-29T21:49:22Z","updated_at":"2018-10-29T21:51:31Z","html_url":"https://github.com/opentracing/opentracing-java/pull/317#discussion_r229111383","pull_request_url":"https://api.github.com/repos/opentracing/opentracing-java/pulls/317","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/opentracing/opentracing-java/pulls/comments/229111383"},"html":{"href":"https://github.com/opentracing/opentracing-java/pull/317#discussion_r229111383"},"pull_request":{"href":"https://api.github.com/repos/opentracing/opentracing-java/pulls/317"}}},"pull_request":{"url":"https://api.github.com/repos/opentracing/opentracing-java/pulls/317","id":225560878,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NTYwODc4","html_url":"https://github.com/opentracing/opentracing-java/pull/317","diff_url":"https://github.com/opentracing/opentracing-java/pull/317.diff","patch_url":"https://github.com/opentracing/opentracing-java/pull/317.patch","issue_url":"https://api.github.com/repos/opentracing/opentracing-java/issues/317","number":317,"state":"open","locked":false,"title":"Do not use AbstractTag<T> for Span.setTag(), but the actual impls.","user":{"login":"carlosalberto","id":260065,"node_id":"MDQ6VXNlcjI2MDA2NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/260065?v=4","gravatar_id":"","url":"https://api.github.com/users/carlosalberto","html_url":"https://github.com/carlosalberto","followers_url":"https://api.github.com/users/carlosalberto/followers","following_url":"https://api.github.com/users/carlosalberto/following{/other_user}","gists_url":"https://api.github.com/users/carlosalberto/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosalberto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosalberto/subscriptions","organizations_url":"https://api.github.com/users/carlosalberto/orgs","repos_url":"https://api.github.com/users/carlosalberto/repos","events_url":"https://api.github.com/users/carlosalberto/events{/privacy}","received_events_url":"https://api.github.com/users/carlosalberto/received_events","type":"User","site_admin":false},"body":"This is done to not use an abstract class for our public API,\r\nso we take overloads of BooleanTag, IntTag and StringTag.\r\n\r\nAddresses a small detail mentioned in #314 \r\n\r\n@yurishkuro @tylerbenson ","created_at":"2018-10-24T21:46:10Z","updated_at":"2018-10-29T21:51:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"982d9a45bb11a112d7f1dbb7aee7d808194572c3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/opentracing/opentracing-java/pulls/317/commits","review_comments_url":"https://api.github.com/repos/opentracing/opentracing-java/pulls/317/comments","review_comment_url":"https://api.github.com/repos/opentracing/opentracing-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opentracing/opentracing-java/issues/317/comments","statuses_url":"https://api.github.com/repos/opentracing/opentracing-java/statuses/19b1d3c3f8e6298b6d4bbf5bb8339b88d446f876","head":{"label":"carlosalberto:span_settag_with_types","ref":"span_settag_with_types","sha":"19b1d3c3f8e6298b6d4bbf5bb8339b88d446f876","user":{"login":"carlosalberto","id":260065,"node_id":"MDQ6VXNlcjI2MDA2NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/260065?v=4","gravatar_id":"","url":"https://api.github.com/users/carlosalberto","html_url":"https://github.com/carlosalberto","followers_url":"https://api.github.com/users/carlosalberto/followers","following_url":"https://api.github.com/users/carlosalberto/following{/other_user}","gists_url":"https://api.github.com/users/carlosalberto/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosalberto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosalberto/subscriptions","organizations_url":"https://api.github.com/users/carlosalberto/orgs","repos_url":"https://api.github.com/users/carlosalberto/repos","events_url":"https://api.github.com/users/carlosalberto/events{/privacy}","received_events_url":"https://api.github.com/users/carlosalberto/received_events","type":"User","site_admin":false},"repo":{"id":102029758,"node_id":"MDEwOlJlcG9zaXRvcnkxMDIwMjk3NTg=","name":"opentracing-java","full_name":"carlosalberto/opentracing-java","private":false,"owner":{"login":"carlosalberto","id":260065,"node_id":"MDQ6VXNlcjI2MDA2NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/260065?v=4","gravatar_id":"","url":"https://api.github.com/users/carlosalberto","html_url":"https://github.com/carlosalberto","followers_url":"https://api.github.com/users/carlosalberto/followers","following_url":"https://api.github.com/users/carlosalberto/following{/other_user}","gists_url":"https://api.github.com/users/carlosalberto/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosalberto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosalberto/subscriptions","organizations_url":"https://api.github.com/users/carlosalberto/orgs","repos_url":"https://api.github.com/users/carlosalberto/repos","events_url":"https://api.github.com/users/carlosalberto/events{/privacy}","received_events_url":"https://api.github.com/users/carlosalberto/received_events","type":"User","site_admin":false},"html_url":"https://github.com/carlosalberto/opentracing-java","description":"OpenTracing API for Java","fork":true,"url":"https://api.github.com/repos/carlosalberto/opentracing-java","forks_url":"https://api.github.com/repos/carlosalberto/opentracing-java/forks","keys_url":"https://api.github.com/repos/carlosalberto/opentracing-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carlosalberto/opentracing-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carlosalberto/opentracing-java/teams","hooks_url":"https://api.github.com/repos/carlosalberto/opentracing-java/hooks","issue_events_url":"https://api.github.com/repos/carlosalberto/opentracing-java/issues/events{/number}","events_url":"https://api.github.com/repos/carlosalberto/opentracing-java/events","assignees_url":"https://api.github.com/repos/carlosalberto/opentracing-java/assignees{/user}","branches_url":"https://api.github.com/repos/carlosalberto/opentracing-java/branches{/branch}","tags_url":"https://api.github.com/repos/carlosalberto/opentracing-java/tags","blobs_url":"https://api.github.com/repos/carlosalberto/opentracing-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carlosalberto/opentracing-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carlosalberto/opentracing-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/carlosalberto/opentracing-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carlosalberto/opentracing-java/statuses/{sha}","languages_url":"https://api.github.com/repos/carlosalberto/opentracing-java/languages","stargazers_url":"https://api.github.com/repos/carlosalberto/opentracing-java/stargazers","contributors_url":"https://api.github.com/repos/carlosalberto/opentracing-java/contributors","subscribers_url":"https://api.github.com/repos/carlosalberto/opentracing-java/subscribers","subscription_url":"https://api.github.com/repos/carlosalberto/opentracing-java/subscription","commits_url":"https://api.github.com/repos/carlosalberto/opentracing-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/carlosalberto/opentracing-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/carlosalberto/opentracing-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/carlosalberto/opentracing-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/carlosalberto/opentracing-java/contents/{+path}","compare_url":"https://api.github.com/repos/carlosalberto/opentracing-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carlosalberto/opentracing-java/merges","archive_url":"https://api.github.com/repos/carlosalberto/opentracing-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carlosalberto/opentracing-java/downloads","issues_url":"https://api.github.com/repos/carlosalberto/opentracing-java/issues{/number}","pulls_url":"https://api.github.com/repos/carlosalberto/opentracing-java/pulls{/number}","milestones_url":"https://api.github.com/repos/carlosalberto/opentracing-java/milestones{/number}","notifications_url":"https://api.github.com/repos/carlosalberto/opentracing-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carlosalberto/opentracing-java/labels{/name}","releases_url":"https://api.github.com/repos/carlosalberto/opentracing-java/releases{/id}","deployments_url":"https://api.github.com/repos/carlosalberto/opentracing-java/deployments","created_at":"2017-08-31T18:02:48Z","updated_at":"2017-08-31T18:02:50Z","pushed_at":"2018-10-29T15:18:27Z","git_url":"git://github.com/carlosalberto/opentracing-java.git","ssh_url":"git@github.com:carlosalberto/opentracing-java.git","clone_url":"https://github.com/carlosalberto/opentracing-java.git","svn_url":"https://github.com/carlosalberto/opentracing-java","homepage":"http://opentracing.io","size":887,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"opentracing:v0.32.0","ref":"v0.32.0","sha":"b6f63246af9688042097f65781357d66e29141d9","user":{"login":"opentracing","id":15482765,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NDgyNzY1","avatar_url":"https://avatars1.githubusercontent.com/u/15482765?v=4","gravatar_id":"","url":"https://api.github.com/users/opentracing","html_url":"https://github.com/opentracing","followers_url":"https://api.github.com/users/opentracing/followers","following_url":"https://api.github.com/users/opentracing/following{/other_user}","gists_url":"https://api.github.com/users/opentracing/gists{/gist_id}","starred_url":"https://api.github.com/users/opentracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentracing/subscriptions","organizations_url":"https://api.github.com/users/opentracing/orgs","repos_url":"https://api.github.com/users/opentracing/repos","events_url":"https://api.github.com/users/opentracing/events{/privacy}","received_events_url":"https://api.github.com/users/opentracing/received_events","type":"Organization","site_admin":false},"repo":{"id":48295629,"node_id":"MDEwOlJlcG9zaXRvcnk0ODI5NTYyOQ==","name":"opentracing-java","full_name":"opentracing/opentracing-java","private":false,"owner":{"login":"opentracing","id":15482765,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NDgyNzY1","avatar_url":"https://avatars1.githubusercontent.com/u/15482765?v=4","gravatar_id":"","url":"https://api.github.com/users/opentracing","html_url":"https://github.com/opentracing","followers_url":"https://api.github.com/users/opentracing/followers","following_url":"https://api.github.com/users/opentracing/following{/other_user}","gists_url":"https://api.github.com/users/opentracing/gists{/gist_id}","starred_url":"https://api.github.com/users/opentracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentracing/subscriptions","organizations_url":"https://api.github.com/users/opentracing/orgs","repos_url":"https://api.github.com/users/opentracing/repos","events_url":"https://api.github.com/users/opentracing/events{/privacy}","received_events_url":"https://api.github.com/users/opentracing/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/opentracing/opentracing-java","description":"OpenTracing API for Java","fork":false,"url":"https://api.github.com/repos/opentracing/opentracing-java","forks_url":"https://api.github.com/repos/opentracing/opentracing-java/forks","keys_url":"https://api.github.com/repos/opentracing/opentracing-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentracing/opentracing-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentracing/opentracing-java/teams","hooks_url":"https://api.github.com/repos/opentracing/opentracing-java/hooks","issue_events_url":"https://api.github.com/repos/opentracing/opentracing-java/issues/events{/number}","events_url":"https://api.github.com/repos/opentracing/opentracing-java/events","assignees_url":"https://api.github.com/repos/opentracing/opentracing-java/assignees{/user}","branches_url":"https://api.github.com/repos/opentracing/opentracing-java/branches{/branch}","tags_url":"https://api.github.com/repos/opentracing/opentracing-java/tags","blobs_url":"https://api.github.com/repos/opentracing/opentracing-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentracing/opentracing-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentracing/opentracing-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentracing/opentracing-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentracing/opentracing-java/statuses/{sha}","languages_url":"https://api.github.com/repos/opentracing/opentracing-java/languages","stargazers_url":"https://api.github.com/repos/opentracing/opentracing-java/stargazers","contributors_url":"https://api.github.com/repos/opentracing/opentracing-java/contributors","subscribers_url":"https://api.github.com/repos/opentracing/opentracing-java/subscribers","subscription_url":"https://api.github.com/repos/opentracing/opentracing-java/subscription","commits_url":"https://api.github.com/repos/opentracing/opentracing-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentracing/opentracing-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentracing/opentracing-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentracing/opentracing-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentracing/opentracing-java/contents/{+path}","compare_url":"https://api.github.com/repos/opentracing/opentracing-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentracing/opentracing-java/merges","archive_url":"https://api.github.com/repos/opentracing/opentracing-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentracing/opentracing-java/downloads","issues_url":"https://api.github.com/repos/opentracing/opentracing-java/issues{/number}","pulls_url":"https://api.github.com/repos/opentracing/opentracing-java/pulls{/number}","milestones_url":"https://api.github.com/repos/opentracing/opentracing-java/milestones{/number}","notifications_url":"https://api.github.com/repos/opentracing/opentracing-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentracing/opentracing-java/labels{/name}","releases_url":"https://api.github.com/repos/opentracing/opentracing-java/releases{/id}","deployments_url":"https://api.github.com/repos/opentracing/opentracing-java/deployments","created_at":"2015-12-19T20:07:30Z","updated_at":"2018-10-29T15:03:38Z","pushed_at":"2018-10-29T15:18:29Z","git_url":"git://github.com/opentracing/opentracing-java.git","ssh_url":"git@github.com:opentracing/opentracing-java.git","clone_url":"https://github.com/opentracing/opentracing-java.git","svn_url":"https://github.com/opentracing/opentracing-java","homepage":"http://opentracing.io","size":747,"stargazers_count":850,"watchers_count":850,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":187,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":187,"open_issues":49,"watchers":850,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opentracing/opentracing-java/pulls/317"},"html":{"href":"https://github.com/opentracing/opentracing-java/pull/317"},"issue":{"href":"https://api.github.com/repos/opentracing/opentracing-java/issues/317"},"comments":{"href":"https://api.github.com/repos/opentracing/opentracing-java/issues/317/comments"},"review_comments":{"href":"https://api.github.com/repos/opentracing/opentracing-java/pulls/317/comments"},"review_comment":{"href":"https://api.github.com/repos/opentracing/opentracing-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opentracing/opentracing-java/pulls/317/commits"},"statuses":{"href":"https://api.github.com/repos/opentracing/opentracing-java/statuses/19b1d3c3f8e6298b6d4bbf5bb8339b88d446f876"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yurishkuro"}}