{"action":"created","comment":{"url":"https://api.github.com/repos/riboseinc/rails-keyserver/pulls/comments/213536571","pull_request_review_id":150392503,"id":213536571,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzUzNjU3MQ==","diff_hunk":"@@ -11,10 +11,21 @@ def self.extension\n           :asc\n         end\n \n+        # TODO: These defaults belong in somewhere else?\n+        Engine.config.key_host = nil\n+\n+        Engine.config.uid_email_1   = \"notifications-noreply@example.com\"\n+        Engine.config.uid_name_1    = \"Rails Notifications\"\n+        Engine.config.uid_comment_1 = \"for system notifications\"\n+\n+        Engine.config.uid_email_2   = \"security.team@example.com\"\n+        Engine.config.uid_name_2    = \"Rails Security\"\n+        Engine.config.uid_comment_2 = \"for security advisories\"\n+\n         def url\n           RK::Engine.routes.url_helpers.api_v1_key_url(\n             \"#{fingerprint}.#{RK::Key::PGP.extension}\",\n-            host: Engine.key_host || \"localhost\",\n+            host: Engine.config.key_host || \"localhost\",","path":"app/models/rails/keyserver/key/pgp.rb","position":19,"original_position":19,"commit_id":"923fc248b5fb4ef69c687a3de451eb2f9e460085","original_commit_id":"923fc248b5fb4ef69c687a3de451eb2f9e460085","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Prefer single-quoted strings when you don't need string interpolation or special symbols.<br>Avoid comma after the last parameter of a method call.","created_at":"2018-08-29T03:44:05Z","updated_at":"2018-08-29T03:44:06Z","html_url":"https://github.com/riboseinc/rails-keyserver/pull/11#discussion_r213536571","pull_request_url":"https://api.github.com/repos/riboseinc/rails-keyserver/pulls/11","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/riboseinc/rails-keyserver/pulls/comments/213536571"},"html":{"href":"https://github.com/riboseinc/rails-keyserver/pull/11#discussion_r213536571"},"pull_request":{"href":"https://api.github.com/repos/riboseinc/rails-keyserver/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/riboseinc/rails-keyserver/pulls/11","id":211619294,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNjE5Mjk0","html_url":"https://github.com/riboseinc/rails-keyserver/pull/11","diff_url":"https://github.com/riboseinc/rails-keyserver/pull/11.diff","patch_url":"https://github.com/riboseinc/rails-keyserver/pull/11.patch","issue_url":"https://api.github.com/repos/riboseinc/rails-keyserver/issues/11","number":11,"state":"open","locked":false,"title":"Make more things configurable via  Engine.config","user":{"login":"ribose-jeffreylau","id":2649467,"node_id":"MDQ6VXNlcjI2NDk0Njc=","avatar_url":"https://avatars0.githubusercontent.com/u/2649467?v=4","gravatar_id":"","url":"https://api.github.com/users/ribose-jeffreylau","html_url":"https://github.com/ribose-jeffreylau","followers_url":"https://api.github.com/users/ribose-jeffreylau/followers","following_url":"https://api.github.com/users/ribose-jeffreylau/following{/other_user}","gists_url":"https://api.github.com/users/ribose-jeffreylau/gists{/gist_id}","starred_url":"https://api.github.com/users/ribose-jeffreylau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ribose-jeffreylau/subscriptions","organizations_url":"https://api.github.com/users/ribose-jeffreylau/orgs","repos_url":"https://api.github.com/users/ribose-jeffreylau/repos","events_url":"https://api.github.com/users/ribose-jeffreylau/events{/privacy}","received_events_url":"https://api.github.com/users/ribose-jeffreylau/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-29T03:43:55Z","updated_at":"2018-08-29T03:44:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a8e42803af220115dbd840276f1831ac6122ea1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/riboseinc/rails-keyserver/pulls/11/commits","review_comments_url":"https://api.github.com/repos/riboseinc/rails-keyserver/pulls/11/comments","review_comment_url":"https://api.github.com/repos/riboseinc/rails-keyserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/riboseinc/rails-keyserver/issues/11/comments","statuses_url":"https://api.github.com/repos/riboseinc/rails-keyserver/statuses/923fc248b5fb4ef69c687a3de451eb2f9e460085","head":{"label":"riboseinc:configs","ref":"configs","sha":"923fc248b5fb4ef69c687a3de451eb2f9e460085","user":{"login":"riboseinc","id":24904375,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTA0Mzc1","avatar_url":"https://avatars0.githubusercontent.com/u/24904375?v=4","gravatar_id":"","url":"https://api.github.com/users/riboseinc","html_url":"https://github.com/riboseinc","followers_url":"https://api.github.com/users/riboseinc/followers","following_url":"https://api.github.com/users/riboseinc/following{/other_user}","gists_url":"https://api.github.com/users/riboseinc/gists{/gist_id}","starred_url":"https://api.github.com/users/riboseinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riboseinc/subscriptions","organizations_url":"https://api.github.com/users/riboseinc/orgs","repos_url":"https://api.github.com/users/riboseinc/repos","events_url":"https://api.github.com/users/riboseinc/events{/privacy}","received_events_url":"https://api.github.com/users/riboseinc/received_events","type":"Organization","site_admin":false},"repo":{"id":145519425,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU1MTk0MjU=","name":"rails-keyserver","full_name":"riboseinc/rails-keyserver","owner":{"login":"riboseinc","id":24904375,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTA0Mzc1","avatar_url":"https://avatars0.githubusercontent.com/u/24904375?v=4","gravatar_id":"","url":"https://api.github.com/users/riboseinc","html_url":"https://github.com/riboseinc","followers_url":"https://api.github.com/users/riboseinc/followers","following_url":"https://api.github.com/users/riboseinc/following{/other_user}","gists_url":"https://api.github.com/users/riboseinc/gists{/gist_id}","starred_url":"https://api.github.com/users/riboseinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riboseinc/subscriptions","organizations_url":"https://api.github.com/users/riboseinc/orgs","repos_url":"https://api.github.com/users/riboseinc/repos","events_url":"https://api.github.com/users/riboseinc/events{/privacy}","received_events_url":"https://api.github.com/users/riboseinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/riboseinc/rails-keyserver","description":"A generic Rails engine for serving most kinds of keys","fork":false,"url":"https://api.github.com/repos/riboseinc/rails-keyserver","forks_url":"https://api.github.com/repos/riboseinc/rails-keyserver/forks","keys_url":"https://api.github.com/repos/riboseinc/rails-keyserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/riboseinc/rails-keyserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/riboseinc/rails-keyserver/teams","hooks_url":"https://api.github.com/repos/riboseinc/rails-keyserver/hooks","issue_events_url":"https://api.github.com/repos/riboseinc/rails-keyserver/issues/events{/number}","events_url":"https://api.github.com/repos/riboseinc/rails-keyserver/events","assignees_url":"https://api.github.com/repos/riboseinc/rails-keyserver/assignees{/user}","branches_url":"https://api.github.com/repos/riboseinc/rails-keyserver/branches{/branch}","tags_url":"https://api.github.com/repos/riboseinc/rails-keyserver/tags","blobs_url":"https://api.github.com/repos/riboseinc/rails-keyserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/riboseinc/rails-keyserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/riboseinc/rails-keyserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/riboseinc/rails-keyserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/riboseinc/rails-keyserver/statuses/{sha}","languages_url":"https://api.github.com/repos/riboseinc/rails-keyserver/languages","stargazers_url":"https://api.github.com/repos/riboseinc/rails-keyserver/stargazers","contributors_url":"https://api.github.com/repos/riboseinc/rails-keyserver/contributors","subscribers_url":"https://api.github.com/repos/riboseinc/rails-keyserver/subscribers","subscription_url":"https://api.github.com/repos/riboseinc/rails-keyserver/subscription","commits_url":"https://api.github.com/repos/riboseinc/rails-keyserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/riboseinc/rails-keyserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/riboseinc/rails-keyserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/riboseinc/rails-keyserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/riboseinc/rails-keyserver/contents/{+path}","compare_url":"https://api.github.com/repos/riboseinc/rails-keyserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/riboseinc/rails-keyserver/merges","archive_url":"https://api.github.com/repos/riboseinc/rails-keyserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/riboseinc/rails-keyserver/downloads","issues_url":"https://api.github.com/repos/riboseinc/rails-keyserver/issues{/number}","pulls_url":"https://api.github.com/repos/riboseinc/rails-keyserver/pulls{/number}","milestones_url":"https://api.github.com/repos/riboseinc/rails-keyserver/milestones{/number}","notifications_url":"https://api.github.com/repos/riboseinc/rails-keyserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/riboseinc/rails-keyserver/labels{/name}","releases_url":"https://api.github.com/repos/riboseinc/rails-keyserver/releases{/id}","deployments_url":"https://api.github.com/repos/riboseinc/rails-keyserver/deployments","created_at":"2018-08-21T06:47:50Z","updated_at":"2018-08-28T08:35:16Z","pushed_at":"2018-08-29T03:43:56Z","git_url":"git://github.com/riboseinc/rails-keyserver.git","ssh_url":"git@github.com:riboseinc/rails-keyserver.git","clone_url":"https://github.com/riboseinc/rails-keyserver.git","svn_url":"https://github.com/riboseinc/rails-keyserver","homepage":null,"size":112,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"riboseinc:master","ref":"master","sha":"1bc9cedf980cb15e52a7f230ba25a6e4b4528ea3","user":{"login":"riboseinc","id":24904375,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTA0Mzc1","avatar_url":"https://avatars0.githubusercontent.com/u/24904375?v=4","gravatar_id":"","url":"https://api.github.com/users/riboseinc","html_url":"https://github.com/riboseinc","followers_url":"https://api.github.com/users/riboseinc/followers","following_url":"https://api.github.com/users/riboseinc/following{/other_user}","gists_url":"https://api.github.com/users/riboseinc/gists{/gist_id}","starred_url":"https://api.github.com/users/riboseinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riboseinc/subscriptions","organizations_url":"https://api.github.com/users/riboseinc/orgs","repos_url":"https://api.github.com/users/riboseinc/repos","events_url":"https://api.github.com/users/riboseinc/events{/privacy}","received_events_url":"https://api.github.com/users/riboseinc/received_events","type":"Organization","site_admin":false},"repo":{"id":145519425,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU1MTk0MjU=","name":"rails-keyserver","full_name":"riboseinc/rails-keyserver","owner":{"login":"riboseinc","id":24904375,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTA0Mzc1","avatar_url":"https://avatars0.githubusercontent.com/u/24904375?v=4","gravatar_id":"","url":"https://api.github.com/users/riboseinc","html_url":"https://github.com/riboseinc","followers_url":"https://api.github.com/users/riboseinc/followers","following_url":"https://api.github.com/users/riboseinc/following{/other_user}","gists_url":"https://api.github.com/users/riboseinc/gists{/gist_id}","starred_url":"https://api.github.com/users/riboseinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riboseinc/subscriptions","organizations_url":"https://api.github.com/users/riboseinc/orgs","repos_url":"https://api.github.com/users/riboseinc/repos","events_url":"https://api.github.com/users/riboseinc/events{/privacy}","received_events_url":"https://api.github.com/users/riboseinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/riboseinc/rails-keyserver","description":"A generic Rails engine for serving most kinds of keys","fork":false,"url":"https://api.github.com/repos/riboseinc/rails-keyserver","forks_url":"https://api.github.com/repos/riboseinc/rails-keyserver/forks","keys_url":"https://api.github.com/repos/riboseinc/rails-keyserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/riboseinc/rails-keyserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/riboseinc/rails-keyserver/teams","hooks_url":"https://api.github.com/repos/riboseinc/rails-keyserver/hooks","issue_events_url":"https://api.github.com/repos/riboseinc/rails-keyserver/issues/events{/number}","events_url":"https://api.github.com/repos/riboseinc/rails-keyserver/events","assignees_url":"https://api.github.com/repos/riboseinc/rails-keyserver/assignees{/user}","branches_url":"https://api.github.com/repos/riboseinc/rails-keyserver/branches{/branch}","tags_url":"https://api.github.com/repos/riboseinc/rails-keyserver/tags","blobs_url":"https://api.github.com/repos/riboseinc/rails-keyserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/riboseinc/rails-keyserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/riboseinc/rails-keyserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/riboseinc/rails-keyserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/riboseinc/rails-keyserver/statuses/{sha}","languages_url":"https://api.github.com/repos/riboseinc/rails-keyserver/languages","stargazers_url":"https://api.github.com/repos/riboseinc/rails-keyserver/stargazers","contributors_url":"https://api.github.com/repos/riboseinc/rails-keyserver/contributors","subscribers_url":"https://api.github.com/repos/riboseinc/rails-keyserver/subscribers","subscription_url":"https://api.github.com/repos/riboseinc/rails-keyserver/subscription","commits_url":"https://api.github.com/repos/riboseinc/rails-keyserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/riboseinc/rails-keyserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/riboseinc/rails-keyserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/riboseinc/rails-keyserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/riboseinc/rails-keyserver/contents/{+path}","compare_url":"https://api.github.com/repos/riboseinc/rails-keyserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/riboseinc/rails-keyserver/merges","archive_url":"https://api.github.com/repos/riboseinc/rails-keyserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/riboseinc/rails-keyserver/downloads","issues_url":"https://api.github.com/repos/riboseinc/rails-keyserver/issues{/number}","pulls_url":"https://api.github.com/repos/riboseinc/rails-keyserver/pulls{/number}","milestones_url":"https://api.github.com/repos/riboseinc/rails-keyserver/milestones{/number}","notifications_url":"https://api.github.com/repos/riboseinc/rails-keyserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/riboseinc/rails-keyserver/labels{/name}","releases_url":"https://api.github.com/repos/riboseinc/rails-keyserver/releases{/id}","deployments_url":"https://api.github.com/repos/riboseinc/rails-keyserver/deployments","created_at":"2018-08-21T06:47:50Z","updated_at":"2018-08-28T08:35:16Z","pushed_at":"2018-08-29T03:43:56Z","git_url":"git://github.com/riboseinc/rails-keyserver.git","ssh_url":"git@github.com:riboseinc/rails-keyserver.git","clone_url":"https://github.com/riboseinc/rails-keyserver.git","svn_url":"https://github.com/riboseinc/rails-keyserver","homepage":null,"size":112,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/riboseinc/rails-keyserver/pulls/11"},"html":{"href":"https://github.com/riboseinc/rails-keyserver/pull/11"},"issue":{"href":"https://api.github.com/repos/riboseinc/rails-keyserver/issues/11"},"comments":{"href":"https://api.github.com/repos/riboseinc/rails-keyserver/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/riboseinc/rails-keyserver/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/riboseinc/rails-keyserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/riboseinc/rails-keyserver/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/riboseinc/rails-keyserver/statuses/923fc248b5fb4ef69c687a3de451eb2f9e460085"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houndci-bot"}}