{"action":"opened","number":280,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/pulls/280","id":201462130,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDYyMTMw","html_url":"https://github.com/puppetlabs/puppetlabs-puppetdb/pull/280","diff_url":"https://github.com/puppetlabs/puppetlabs-puppetdb/pull/280.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-puppetdb/pull/280.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/issues/280","number":280,"state":"open","locked":false,"title":"use of hard-coded passwords is a bad practice ","user":{"login":"akondasif","id":16780743,"node_id":"MDQ6VXNlcjE2NzgwNzQz","avatar_url":"https://avatars1.githubusercontent.com/u/16780743?v=4","gravatar_id":"","url":"https://api.github.com/users/akondasif","html_url":"https://github.com/akondasif","followers_url":"https://api.github.com/users/akondasif/followers","following_url":"https://api.github.com/users/akondasif/following{/other_user}","gists_url":"https://api.github.com/users/akondasif/gists{/gist_id}","starred_url":"https://api.github.com/users/akondasif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akondasif/subscriptions","organizations_url":"https://api.github.com/users/akondasif/orgs","repos_url":"https://api.github.com/users/akondasif/repos","events_url":"https://api.github.com/users/akondasif/events{/privacy}","received_events_url":"https://api.github.com/users/akondasif/received_events","type":"User","site_admin":false},"body":"> hard-coded default passwords as parameters is a bad practice\r\n\r\nGreetings,\r\n\r\nI am a security researcher, who is looking for security smells in Puppet scripts.\r\nI noticed instances of hard-coded passwords, which are against the best practices\r\nrecommended by Common Weakness Enumeration (CWE) [https://cwe.mitre.org/data/definitions/259.html] and also by other security practitioners.\r\nI suggest use of undef to mitigate this smell. Feedback is welcome.\r\n","created_at":"2018-07-14T17:53:06Z","updated_at":"2018-07-14T17:53:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/pulls/280/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/pulls/280/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/issues/280/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/statuses/f5c08dae6aaecc21585a45e5e23ef8a4a1237e5b","head":{"label":"akondasif:master","ref":"master","sha":"f5c08dae6aaecc21585a45e5e23ef8a4a1237e5b","user":{"login":"akondasif","id":16780743,"node_id":"MDQ6VXNlcjE2NzgwNzQz","avatar_url":"https://avatars1.githubusercontent.com/u/16780743?v=4","gravatar_id":"","url":"https://api.github.com/users/akondasif","html_url":"https://github.com/akondasif","followers_url":"https://api.github.com/users/akondasif/followers","following_url":"https://api.github.com/users/akondasif/following{/other_user}","gists_url":"https://api.github.com/users/akondasif/gists{/gist_id}","starred_url":"https://api.github.com/users/akondasif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akondasif/subscriptions","organizations_url":"https://api.github.com/users/akondasif/orgs","repos_url":"https://api.github.com/users/akondasif/repos","events_url":"https://api.github.com/users/akondasif/events{/privacy}","received_events_url":"https://api.github.com/users/akondasif/received_events","type":"User","site_admin":false},"repo":{"id":140966350,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA5NjYzNTA=","name":"puppetlabs-puppetdb","full_name":"akondasif/puppetlabs-puppetdb","owner":{"login":"akondasif","id":16780743,"node_id":"MDQ6VXNlcjE2NzgwNzQz","avatar_url":"https://avatars1.githubusercontent.com/u/16780743?v=4","gravatar_id":"","url":"https://api.github.com/users/akondasif","html_url":"https://github.com/akondasif","followers_url":"https://api.github.com/users/akondasif/followers","following_url":"https://api.github.com/users/akondasif/following{/other_user}","gists_url":"https://api.github.com/users/akondasif/gists{/gist_id}","starred_url":"https://api.github.com/users/akondasif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akondasif/subscriptions","organizations_url":"https://api.github.com/users/akondasif/orgs","repos_url":"https://api.github.com/users/akondasif/repos","events_url":"https://api.github.com/users/akondasif/events{/privacy}","received_events_url":"https://api.github.com/users/akondasif/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akondasif/puppetlabs-puppetdb","description":"A puppet module for installing and managing puppetdb","fork":true,"url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb","forks_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/forks","keys_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/teams","hooks_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/hooks","issue_events_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/events","assignees_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/tags","blobs_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/languages","stargazers_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/stargazers","contributors_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/contributors","subscribers_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/subscribers","subscription_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/subscription","commits_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/merges","archive_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/downloads","issues_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/releases{/id}","deployments_url":"https://api.github.com/repos/akondasif/puppetlabs-puppetdb/deployments","created_at":"2018-07-14T17:48:23Z","updated_at":"2018-07-14T17:52:23Z","pushed_at":"2018-07-14T17:52:21Z","git_url":"git://github.com/akondasif/puppetlabs-puppetdb.git","ssh_url":"git@github.com:akondasif/puppetlabs-puppetdb.git","clone_url":"https://github.com/akondasif/puppetlabs-puppetdb.git","svn_url":"https://github.com/akondasif/puppetlabs-puppetdb","homepage":"https://forge.puppetlabs.com/puppetlabs/puppetdb","size":697,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"78b9df2f20d623ad59259ad8b507cb322484473a","user":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":4653174,"node_id":"MDEwOlJlcG9zaXRvcnk0NjUzMTc0","name":"puppetlabs-puppetdb","full_name":"puppetlabs/puppetlabs-puppetdb","owner":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetlabs-puppetdb","description":"A puppet module for installing and managing puppetdb","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb","forks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/deployments","created_at":"2012-06-13T16:17:23Z","updated_at":"2018-07-11T20:48:58Z","pushed_at":"2018-07-12T21:54:34Z","git_url":"git://github.com/puppetlabs/puppetlabs-puppetdb.git","ssh_url":"git@github.com:puppetlabs/puppetlabs-puppetdb.git","clone_url":"https://github.com/puppetlabs/puppetlabs-puppetdb.git","svn_url":"https://github.com/puppetlabs/puppetlabs-puppetdb","homepage":"https://forge.puppetlabs.com/puppetlabs/puppetdb","size":697,"stargazers_count":49,"watchers_count":49,"language":"Puppet","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":178,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":178,"open_issues":25,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/pulls/280"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-puppetdb/pull/280"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/issues/280"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/issues/280/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/pulls/280/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/pulls/280/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppetdb/statuses/f5c08dae6aaecc21585a45e5e23ef8a4a1237e5b"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":3,"additions":11,"deletions":2,"changed_files":3}}
{"actor":{"display_login":"akondasif"}}