{"action":"closed","number":31,"pull_request":{"url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/pulls/31","id":172480514,"html_url":"https://github.com/3sidedcube/iOS-ThunderTable/pull/31","diff_url":"https://github.com/3sidedcube/iOS-ThunderTable/pull/31.diff","patch_url":"https://github.com/3sidedcube/iOS-ThunderTable/pull/31.patch","issue_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/issues/31","number":31,"state":"closed","locked":false,"title":"Feature/get set removal","user":{"login":"simonmitchell","id":9033831,"avatar_url":"https://avatars1.githubusercontent.com/u/9033831?v=4","gravatar_id":"","url":"https://api.github.com/users/simonmitchell","html_url":"https://github.com/simonmitchell","followers_url":"https://api.github.com/users/simonmitchell/followers","following_url":"https://api.github.com/users/simonmitchell/following{/other_user}","gists_url":"https://api.github.com/users/simonmitchell/gists{/gist_id}","starred_url":"https://api.github.com/users/simonmitchell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonmitchell/subscriptions","organizations_url":"https://api.github.com/users/simonmitchell/orgs","repos_url":"https://api.github.com/users/simonmitchell/repos","events_url":"https://api.github.com/users/simonmitchell/events{/privacy}","received_events_url":"https://api.github.com/users/simonmitchell/received_events","type":"User","site_admin":false},"body":"With the `Row` and `Section` protocols as `{ get set }` properties (And the default extensions to make them effectively optional) if you extended a class like so:\r\n\r\n```\r\nextension CNContact: Row {\r\n   var title: String? {\r\n      return givenName\r\n   }\r\n}\r\n```\r\n\r\nthe compiler wouldn't warn you (Because of default extension) but the row would display with a blank title because the added property is not `{ get set }` it is `{ get }`. To fix this, and because the properties don't really need to be `{ get set }` (Other than the special case of `image` on the `Row` protocol) we will change all of them to simply `{ get }`. This allows for all the following syntaxes, and means there is no need to change existing code:\r\n\r\n```\r\nclass Person: Row {\r\n   var title: String?\r\n}\r\n\r\nextension CNContact: Row {\r\n   var title: String? {\r\n      return givenName\r\n   }\r\n}\r\n\r\nextension CNContact: Row {\r\n   var title: String? {\r\n      get { return givenName }\r\n   }\r\n}\r\n\r\n//AND EVEN\r\nextension CNContact: Row {\r\n    var title: String? {\r\n        get { return givenName }\r\n        set { }\r\n    }\r\n}\r\n``` ","created_at":"2018-03-02T11:26:40Z","updated_at":"2018-03-02T13:53:10Z","closed_at":"2018-03-02T13:53:10Z","merged_at":"2018-03-02T13:53:10Z","merge_commit_sha":"87d03887fbc696a7baa8eb72acdc455378aebb98","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ryanbourneuk","id":1409585,"avatar_url":"https://avatars0.githubusercontent.com/u/1409585?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanbourneuk","html_url":"https://github.com/ryanbourneuk","followers_url":"https://api.github.com/users/ryanbourneuk/followers","following_url":"https://api.github.com/users/ryanbourneuk/following{/other_user}","gists_url":"https://api.github.com/users/ryanbourneuk/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanbourneuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanbourneuk/subscriptions","organizations_url":"https://api.github.com/users/ryanbourneuk/orgs","repos_url":"https://api.github.com/users/ryanbourneuk/repos","events_url":"https://api.github.com/users/ryanbourneuk/events{/privacy}","received_events_url":"https://api.github.com/users/ryanbourneuk/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/pulls/31/commits","review_comments_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/pulls/31/comments","review_comment_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/issues/31/comments","statuses_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/statuses/f9c09598b2f746ec9e7b6bde58ecc81b77446455","head":{"label":"3sidedcube:feature/get_set_removal","ref":"feature/get_set_removal","sha":"f9c09598b2f746ec9e7b6bde58ecc81b77446455","user":{"login":"3sidedcube","id":5849497,"avatar_url":"https://avatars1.githubusercontent.com/u/5849497?v=4","gravatar_id":"","url":"https://api.github.com/users/3sidedcube","html_url":"https://github.com/3sidedcube","followers_url":"https://api.github.com/users/3sidedcube/followers","following_url":"https://api.github.com/users/3sidedcube/following{/other_user}","gists_url":"https://api.github.com/users/3sidedcube/gists{/gist_id}","starred_url":"https://api.github.com/users/3sidedcube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3sidedcube/subscriptions","organizations_url":"https://api.github.com/users/3sidedcube/orgs","repos_url":"https://api.github.com/users/3sidedcube/repos","events_url":"https://api.github.com/users/3sidedcube/events{/privacy}","received_events_url":"https://api.github.com/users/3sidedcube/received_events","type":"Organization","site_admin":false},"repo":{"id":24840049,"name":"iOS-ThunderTable","full_name":"3sidedcube/iOS-ThunderTable","owner":{"login":"3sidedcube","id":5849497,"avatar_url":"https://avatars1.githubusercontent.com/u/5849497?v=4","gravatar_id":"","url":"https://api.github.com/users/3sidedcube","html_url":"https://github.com/3sidedcube","followers_url":"https://api.github.com/users/3sidedcube/followers","following_url":"https://api.github.com/users/3sidedcube/following{/other_user}","gists_url":"https://api.github.com/users/3sidedcube/gists{/gist_id}","starred_url":"https://api.github.com/users/3sidedcube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3sidedcube/subscriptions","organizations_url":"https://api.github.com/users/3sidedcube/orgs","repos_url":"https://api.github.com/users/3sidedcube/repos","events_url":"https://api.github.com/users/3sidedcube/events{/privacy}","received_events_url":"https://api.github.com/users/3sidedcube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/3sidedcube/iOS-ThunderTable","description":"A declarative wrapper approach to UITableView","fork":false,"url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable","forks_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/forks","keys_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/teams","hooks_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/hooks","issue_events_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/issues/events{/number}","events_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/events","assignees_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/assignees{/user}","branches_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/branches{/branch}","tags_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/tags","blobs_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/git/refs{/sha}","trees_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/statuses/{sha}","languages_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/languages","stargazers_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/stargazers","contributors_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/contributors","subscribers_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/subscribers","subscription_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/subscription","commits_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/commits{/sha}","git_commits_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/git/commits{/sha}","comments_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/comments{/number}","issue_comment_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/issues/comments{/number}","contents_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/contents/{+path}","compare_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/merges","archive_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/downloads","issues_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/issues{/number}","pulls_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/pulls{/number}","milestones_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/milestones{/number}","notifications_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/labels{/name}","releases_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/releases{/id}","deployments_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/deployments","created_at":"2014-10-06T09:23:34Z","updated_at":"2018-02-15T13:22:40Z","pushed_at":"2018-03-02T13:53:10Z","git_url":"git://github.com/3sidedcube/iOS-ThunderTable.git","ssh_url":"git@github.com:3sidedcube/iOS-ThunderTable.git","clone_url":"https://github.com/3sidedcube/iOS-ThunderTable.git","svn_url":"https://github.com/3sidedcube/iOS-ThunderTable","homepage":"","size":892,"stargazers_count":2,"watchers_count":2,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":4,"watchers":2,"default_branch":"master"}},"base":{"label":"3sidedcube:develop","ref":"develop","sha":"55afa66fdbcf5024cbc1d35c1fb74cc51ed8115a","user":{"login":"3sidedcube","id":5849497,"avatar_url":"https://avatars1.githubusercontent.com/u/5849497?v=4","gravatar_id":"","url":"https://api.github.com/users/3sidedcube","html_url":"https://github.com/3sidedcube","followers_url":"https://api.github.com/users/3sidedcube/followers","following_url":"https://api.github.com/users/3sidedcube/following{/other_user}","gists_url":"https://api.github.com/users/3sidedcube/gists{/gist_id}","starred_url":"https://api.github.com/users/3sidedcube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3sidedcube/subscriptions","organizations_url":"https://api.github.com/users/3sidedcube/orgs","repos_url":"https://api.github.com/users/3sidedcube/repos","events_url":"https://api.github.com/users/3sidedcube/events{/privacy}","received_events_url":"https://api.github.com/users/3sidedcube/received_events","type":"Organization","site_admin":false},"repo":{"id":24840049,"name":"iOS-ThunderTable","full_name":"3sidedcube/iOS-ThunderTable","owner":{"login":"3sidedcube","id":5849497,"avatar_url":"https://avatars1.githubusercontent.com/u/5849497?v=4","gravatar_id":"","url":"https://api.github.com/users/3sidedcube","html_url":"https://github.com/3sidedcube","followers_url":"https://api.github.com/users/3sidedcube/followers","following_url":"https://api.github.com/users/3sidedcube/following{/other_user}","gists_url":"https://api.github.com/users/3sidedcube/gists{/gist_id}","starred_url":"https://api.github.com/users/3sidedcube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3sidedcube/subscriptions","organizations_url":"https://api.github.com/users/3sidedcube/orgs","repos_url":"https://api.github.com/users/3sidedcube/repos","events_url":"https://api.github.com/users/3sidedcube/events{/privacy}","received_events_url":"https://api.github.com/users/3sidedcube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/3sidedcube/iOS-ThunderTable","description":"A declarative wrapper approach to UITableView","fork":false,"url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable","forks_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/forks","keys_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/teams","hooks_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/hooks","issue_events_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/issues/events{/number}","events_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/events","assignees_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/assignees{/user}","branches_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/branches{/branch}","tags_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/tags","blobs_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/git/refs{/sha}","trees_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/statuses/{sha}","languages_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/languages","stargazers_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/stargazers","contributors_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/contributors","subscribers_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/subscribers","subscription_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/subscription","commits_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/commits{/sha}","git_commits_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/git/commits{/sha}","comments_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/comments{/number}","issue_comment_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/issues/comments{/number}","contents_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/contents/{+path}","compare_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/merges","archive_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/downloads","issues_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/issues{/number}","pulls_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/pulls{/number}","milestones_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/milestones{/number}","notifications_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/labels{/name}","releases_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/releases{/id}","deployments_url":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/deployments","created_at":"2014-10-06T09:23:34Z","updated_at":"2018-02-15T13:22:40Z","pushed_at":"2018-03-02T13:53:10Z","git_url":"git://github.com/3sidedcube/iOS-ThunderTable.git","ssh_url":"git@github.com:3sidedcube/iOS-ThunderTable.git","clone_url":"https://github.com/3sidedcube/iOS-ThunderTable.git","svn_url":"https://github.com/3sidedcube/iOS-ThunderTable","homepage":"","size":892,"stargazers_count":2,"watchers_count":2,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/pulls/31"},"html":{"href":"https://github.com/3sidedcube/iOS-ThunderTable/pull/31"},"issue":{"href":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/issues/31"},"comments":{"href":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/3sidedcube/iOS-ThunderTable/statuses/f9c09598b2f746ec9e7b6bde58ecc81b77446455"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"simonmitchell","id":9033831,"avatar_url":"https://avatars1.githubusercontent.com/u/9033831?v=4","gravatar_id":"","url":"https://api.github.com/users/simonmitchell","html_url":"https://github.com/simonmitchell","followers_url":"https://api.github.com/users/simonmitchell/followers","following_url":"https://api.github.com/users/simonmitchell/following{/other_user}","gists_url":"https://api.github.com/users/simonmitchell/gists{/gist_id}","starred_url":"https://api.github.com/users/simonmitchell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonmitchell/subscriptions","organizations_url":"https://api.github.com/users/simonmitchell/orgs","repos_url":"https://api.github.com/users/simonmitchell/repos","events_url":"https://api.github.com/users/simonmitchell/events{/privacy}","received_events_url":"https://api.github.com/users/simonmitchell/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":42,"deletions":81,"changed_files":3}}
{"actor":{"display_login":"simonmitchell"}}