{"action":"created","issue":{"url":"https://api.github.com/repos/manavbhatia/mast-multiphysics/issues/6","repository_url":"https://api.github.com/repos/manavbhatia/mast-multiphysics","labels_url":"https://api.github.com/repos/manavbhatia/mast-multiphysics/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/manavbhatia/mast-multiphysics/issues/6/comments","events_url":"https://api.github.com/repos/manavbhatia/mast-multiphysics/issues/6/events","html_url":"https://github.com/manavbhatia/mast-multiphysics/pull/6","id":358801316,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NDQ5MzUw","number":6,"title":"Refactor CMake build using newer practices.","user":{"login":"jdeaton","id":17778287,"node_id":"MDQ6VXNlcjE3Nzc4Mjg3","avatar_url":"https://avatars1.githubusercontent.com/u/17778287?v=4","gravatar_id":"","url":"https://api.github.com/users/jdeaton","html_url":"https://github.com/jdeaton","followers_url":"https://api.github.com/users/jdeaton/followers","following_url":"https://api.github.com/users/jdeaton/following{/other_user}","gists_url":"https://api.github.com/users/jdeaton/gists{/gist_id}","starred_url":"https://api.github.com/users/jdeaton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdeaton/subscriptions","organizations_url":"https://api.github.com/users/jdeaton/orgs","repos_url":"https://api.github.com/users/jdeaton/repos","events_url":"https://api.github.com/users/jdeaton/events{/privacy}","received_events_url":"https://api.github.com/users/jdeaton/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-09-10T21:27:05Z","updated_at":"2018-10-23T21:36:21Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/manavbhatia/mast-multiphysics/pulls/6","html_url":"https://github.com/manavbhatia/mast-multiphysics/pull/6","diff_url":"https://github.com/manavbhatia/mast-multiphysics/pull/6.diff","patch_url":"https://github.com/manavbhatia/mast-multiphysics/pull/6.patch"},"body":"As part of putting together a Spack package for MAST I decided to try to take a cut at modernizing the CMake build process. I'm basing this on guidance I found in https://crascit.com/professional-cmake/, which seems to be and one of the few modern references of CMake I can find. The author is one of the primary contributors to CMake.\r\n\r\nThis branch starts from the MAST source tree and shows the outline for possibly a cleaner CMake implementation. I've currently only setup the basic CMakeLists.txt's, some modules for finding dependencies, a skeleton of the MAST library with only a few files pulled into the build, and a basic dummy example that links it all together.\r\n\r\nLet me know what you think. I believe if I keep just pushing changes to this pull request and it will keep updating and we can discuss."},"comment":{"url":"https://api.github.com/repos/manavbhatia/mast-multiphysics/issues/comments/432429421","html_url":"https://github.com/manavbhatia/mast-multiphysics/pull/6#issuecomment-432429421","issue_url":"https://api.github.com/repos/manavbhatia/mast-multiphysics/issues/6","id":432429421,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjQyOTQyMQ==","user":{"login":"jdeaton","id":17778287,"node_id":"MDQ6VXNlcjE3Nzc4Mjg3","avatar_url":"https://avatars1.githubusercontent.com/u/17778287?v=4","gravatar_id":"","url":"https://api.github.com/users/jdeaton","html_url":"https://github.com/jdeaton","followers_url":"https://api.github.com/users/jdeaton/followers","following_url":"https://api.github.com/users/jdeaton/following{/other_user}","gists_url":"https://api.github.com/users/jdeaton/gists{/gist_id}","starred_url":"https://api.github.com/users/jdeaton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdeaton/subscriptions","organizations_url":"https://api.github.com/users/jdeaton/orgs","repos_url":"https://api.github.com/users/jdeaton/repos","events_url":"https://api.github.com/users/jdeaton/events{/privacy}","received_events_url":"https://api.github.com/users/jdeaton/received_events","type":"User","site_admin":false},"created_at":"2018-10-23T21:36:21Z","updated_at":"2018-10-23T21:36:21Z","author_association":"NONE","body":"I think it makes sense to do that. I created an issue over on the main MAST repository to collect discussion related to examples: https://github.com/MASTmultiphysics/mast-multiphysics/issues/7.\r\n\r\nI think we can close this pull-request. There's a few more things I'm going to try to do with CMake related to the installation part, which I need to finish the MAST spack package. I'll open a new pull request against https://github.com/manavbhatia/mast-multiphysics/tree/jdeaton-cmake-refactor when I get it figured out."}}
{"actor":{"display_login":"jdeaton"}}