{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/docs/issues/2901","repository_url":"https://api.github.com/repos/cockroachdb/docs","labels_url":"https://api.github.com/repos/cockroachdb/docs/issues/2901/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/docs/issues/2901/comments","events_url":"https://api.github.com/repos/cockroachdb/docs/issues/2901/events","html_url":"https://github.com/cockroachdb/docs/pull/2901","id":313160920,"number":2901,"title":"Changing default rep factor doesn't affect system ranges","user":{"login":"jseldess","id":15893490,"avatar_url":"https://avatars2.githubusercontent.com/u/15893490?v=4","gravatar_id":"","url":"https://api.github.com/users/jseldess","html_url":"https://github.com/jseldess","followers_url":"https://api.github.com/users/jseldess/followers","following_url":"https://api.github.com/users/jseldess/following{/other_user}","gists_url":"https://api.github.com/users/jseldess/gists{/gist_id}","starred_url":"https://api.github.com/users/jseldess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jseldess/subscriptions","organizations_url":"https://api.github.com/users/jseldess/orgs","repos_url":"https://api.github.com/users/jseldess/repos","events_url":"https://api.github.com/users/jseldess/events{/privacy}","received_events_url":"https://api.github.com/users/jseldess/received_events","type":"User","site_admin":false},"labels":[{"id":808984040,"url":"https://api.github.com/repos/cockroachdb/docs/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-04-11T03:27:25Z","updated_at":"2018-04-27T19:58:11Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cockroachdb/docs/pulls/2901","html_url":"https://github.com/cockroachdb/docs/pull/2901","diff_url":"https://github.com/cockroachdb/docs/pull/2901.diff","patch_url":"https://github.com/cockroachdb/docs/pull/2901.patch"},"body":"- Add known limitation\r\n- Add warning to \"edit default replication zone\" example\r\n\r\nFixes #2858"},"comment":{"url":"https://api.github.com/repos/cockroachdb/docs/issues/comments/385077991","html_url":"https://github.com/cockroachdb/docs/pull/2901#issuecomment-385077991","issue_url":"https://api.github.com/repos/cockroachdb/docs/issues/2901","id":385077991,"user":{"login":"a-robinson","id":7085343,"avatar_url":"https://avatars3.githubusercontent.com/u/7085343?v=4","gravatar_id":"","url":"https://api.github.com/users/a-robinson","html_url":"https://github.com/a-robinson","followers_url":"https://api.github.com/users/a-robinson/followers","following_url":"https://api.github.com/users/a-robinson/following{/other_user}","gists_url":"https://api.github.com/users/a-robinson/gists{/gist_id}","starred_url":"https://api.github.com/users/a-robinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-robinson/subscriptions","organizations_url":"https://api.github.com/users/a-robinson/orgs","repos_url":"https://api.github.com/users/a-robinson/repos","events_url":"https://api.github.com/users/a-robinson/events{/privacy}","received_events_url":"https://api.github.com/users/a-robinson/received_events","type":"User","site_admin":false},"created_at":"2018-04-27T19:58:11Z","updated_at":"2018-04-27T19:58:11Z","author_association":"OWNER","body":"This looks great, Jesse! Thanks for sticking with it. <img class=\"emoji\" title=\":lgtm:\" alt=\":lgtm:\" align=\"absmiddle\" src=\"https://reviewable.io/lgtm.png\" height=\"20\" width=\"61\"/> \n\n---\n\nReviewed 5 of 5 files at r3.\nReview status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.\n\n---\n\n*[v2.0/configure-replication-zones.md, line 26 at r3](https://reviewable.io/reviews/cockroachdb/docs/2901#-LB7eDp3BzumY4v62m9q:-LB7eDp4AqVs8EaiamQQ:bnta3ua) ([raw file](https://github.com/cockroachdb/docs/blob/d685851ef069ff32b00f3942314453a3cb6c5c98/v2.0/configure-replication-zones.md#L26)):*\n> ```Markdown\n> Cluster | CockroachDB comes with a pre-configured `.default` replication zone that applies to all table data in the cluster not constrained by a database, table, or row-specific replication zone. This zone can be adjusted but not removed. See [View the Default Replication Zone](#view-the-default-replication-zone) and [Edit the Default Replication Zone](#edit-the-default-replication-zone) for more details.\n> Database | You can add replication zones for specific databases. See [Create a Replication Zone for a Database](#create-a-replication-zone-for-a-database) for more details.\n> Table | You can add replication zones for specific tables. See [Create a Replication Zone for a Table](#create-a-replication-zone-for-a-table) for more details.<br><br>CockroachDB comes with a pre-configured replication zone for one internal table, `system.jobs`, which stores metadata about long-running jobs such as schema changes and backups. Historical queries are never run against this table, so the pre-configured zone gives this table a lower-than-default `ttlseconds`.\n> ```\n\nMinor, but I'd phrase the last sentence as:\n\n\"Historical queries are never run against this table and the rows in it are updated frequently, so the pre-configured zone gives this table a lower-than-default `ttlseconds`.\"\n\nSee https://github.com/cockroachdb/cockroach/pull/21575 for the full original reasoning if you're curious\n\n---\n\n*[v2.0/configure-replication-zones.md, line 356 at r3](https://reviewable.io/reviews/cockroachdb/docs/2901#-LB7f8X50gOTq3N5zp_I:-LB7f8X50gOTq3N5zp_J:b-t5ypqg) ([raw file](https://github.com/cockroachdb/docs/blob/d685851ef069ff32b00f3942314453a3cb6c5c98/v2.0/configure-replication-zones.md#L356)):*\n> ```Markdown\n> Zone Name | Description\n> ----------|-----------------|------------\n> `.meta` | The \"meta\" ranges contain the authoritative information about the location of all data in the cluster.<br><br>Because historical queries are never run on meta ranges, its advantageous to keep these ranges smaller for reliable performance, so CockroachDB comes with a **pre-configured** `.meta` replication zone giving these ranges a lower-than-default `ttlseconds`.<br><br>If your cluster is running in multiple datacenters, it's a best practice to configure the meta ranges to have a copy in each datacenter.\n> ```\n\nThe second sentence's grammar is messed up. I'd say:\n\nBecause historical queries are never run on meta ranges and it is advantageous to keep these ranges smaller for reliable performance, CockroachDB comes with a **pre-configured** `.meta` replication zone giving these ranges a lower-than-default `ttlseconds`.\n\n---\n\n*[v2.0/configure-replication-zones.md, line 359 at r3](https://reviewable.io/reviews/cockroachdb/docs/2901#-LB7fYETEOLy4Rc1WXgG:-LB7fYETEOLy4Rc1WXgH:bvtcjg3) ([raw file](https://github.com/cockroachdb/docs/blob/d685851ef069ff32b00f3942314453a3cb6c5c98/v2.0/configure-replication-zones.md#L359)):*\n> ```Markdown\n> `.liveness` | <span class=\"version-tag\">New in v2.0:</span> The \"liveness\" range contains the authoritative information about which nodes are live at any given time.<br><br>Just as for \"meta\" ranges, historical queries are never run on the liveness range, so CockroachDB comes with a **pre-configured** `.liveness` replication zone giving this range a lower-than-default `ttlseconds`.<br><br>If this range is unavailable, the entire cluster will be unavailable, so giving it a high replication factor is strongly recommended.\n> `.timeseries` | The \"timeseries\" ranges contain monitoring data about the cluster that powers the graphs in CockroachDB's admin UI. If necessary, you can add a `.timeseries` replication zone to control the replication of this data.\n> `.system` | There are system ranges for a variety of other important internal data, including information needed to allocate new table IDs and track the health of a cluster's nodes. If necessary, you can add a `.system` replication zone to control the replication of this data.\n> ```\n\nWhile I'm throwing nits at you, I know I wrote this but in retrospect I'd replace the word \"health\" here with \"status\".\n\n---\n\n*[v2.0/known-limitations.md, line 15 at r2](https://reviewable.io/reviews/cockroachdb/docs/2901#-L9mjbPInbH68loOaEI1-r2-15:-LB7fh3q3Fwilv4acwuw:b4c9lyr) ([raw file](https://github.com/cockroachdb/docs/blob/b2fb028beb85d42b379f5faf38cec2a8fb72bb8f/v2.0/known-limitations.md#L15)):*\n<details><summary><i>Previously, jseldess (Jesse Seldess) wrote…</i></summary><blockquote>\n\nWhen put like that, I don't think we need to call this out as a \"limitation\" per se. It's more of a ux-gotcha, so hopefully covering it in the replication zone docs is enough. \n</blockquote></details>\n\n:thumbsup: \n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/cockroachdb/docs/2901#-:-LB7fitQ-QGkb23hYCIu:bzacq3y)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"a-robinson"}}