{"action":"created","comment":{"url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/comments/190643031","pull_request_review_id":123063529,"id":190643031,"diff_hunk":"@@ -88,3 +88,80 @@ ocil: |\n \n {{{ audit_syscall_check_ocil_clause_entry() }}}\n {{%- endmacro %}}\n+\n+\n+{{%- macro _firewalld_check(access_action, port, proto, service) %}}\n+    To determine if <code>firewalld</code> is configured to {{{ access_action }}} to <code>{{{ service }}}</code>\n+    on port <code>{{{ port }}}/{{{ proto }}}</code>, run the following command(s):\n+    {{% if port %}}\n+        <code>firewall-cmd --list-ports</code>\n+    {{% endif %}}\n+    {{% if service %}}\n+        <code>firewall-cmd --list-services</code>\n+    {{% endif %}}\n+{{%- endmacro %}}\n+\n+\n+{{%- macro firewalld_allow_access(port, proto, service) %}}\n+{{{ _firewalld_check(\"allow access\", port, proto, service) }}}\n+    If <code>firewalld</code> is configured to allow access through the firewall, something similar to the following will be output:\n+    {{% if service %}}\n+    If it is a service:\n+    <code>&gt;{{{ service }}}</code>\n+    {{% endif %}}\n+    {{% if port %}}\n+    If it is a port:\n+    <code>{{{ port }}}/{{{ proto }}}</code>\n+    {{% endif %}}\n+{{%- endmacro %}}\n+\n+\n+{{%- macro firewalld_prevent_access(port, proto, service) %}}\n+{{{ _firewalld_check(\"prevent access\", port, proto, service) }}}\n+    If <code>firewalld</code> is configured to prevent access, no output will be returned.\n+{{%- endmacro %}}\n+\n+\n+{{%- macro firewalld_prevent_desc(port, proto, service) %}}","path":"shared/modules/macros.jinja","position":38,"original_position":38,"commit_id":"3ad8688520ba443e867a92e730fdf9d6b5b2b223","original_commit_id":"3ad8688520ba443e867a92e730fdf9d6b5b2b223","user":{"login":"mpreisler","id":753153,"avatar_url":"https://avatars1.githubusercontent.com/u/753153?v=4","gravatar_id":"","url":"https://api.github.com/users/mpreisler","html_url":"https://github.com/mpreisler","followers_url":"https://api.github.com/users/mpreisler/followers","following_url":"https://api.github.com/users/mpreisler/following{/other_user}","gists_url":"https://api.github.com/users/mpreisler/gists{/gist_id}","starred_url":"https://api.github.com/users/mpreisler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpreisler/subscriptions","organizations_url":"https://api.github.com/users/mpreisler/orgs","repos_url":"https://api.github.com/users/mpreisler/repos","events_url":"https://api.github.com/users/mpreisler/events{/privacy}","received_events_url":"https://api.github.com/users/mpreisler/received_events","type":"User","site_admin":false},"body":"should probably be two macros, one for port/proto and one for service","created_at":"2018-05-24T16:02:23Z","updated_at":"2018-05-24T16:02:24Z","html_url":"https://github.com/OpenSCAP/scap-security-guide/pull/2861#discussion_r190643031","pull_request_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/2861","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/comments/190643031"},"html":{"href":"https://github.com/OpenSCAP/scap-security-guide/pull/2861#discussion_r190643031"},"pull_request":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/2861"}}},"pull_request":{"url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/2861","id":190286712,"html_url":"https://github.com/OpenSCAP/scap-security-guide/pull/2861","diff_url":"https://github.com/OpenSCAP/scap-security-guide/pull/2861.diff","patch_url":"https://github.com/OpenSCAP/scap-security-guide/pull/2861.patch","issue_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/2861","number":2861,"state":"open","locked":false,"title":"Continue converting XSLT macros to jinja. [WIP]","user":{"login":"matejak","id":2823847,"avatar_url":"https://avatars2.githubusercontent.com/u/2823847?v=4","gravatar_id":"","url":"https://api.github.com/users/matejak","html_url":"https://github.com/matejak","followers_url":"https://api.github.com/users/matejak/followers","following_url":"https://api.github.com/users/matejak/following{/other_user}","gists_url":"https://api.github.com/users/matejak/gists{/gist_id}","starred_url":"https://api.github.com/users/matejak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matejak/subscriptions","organizations_url":"https://api.github.com/users/matejak/orgs","repos_url":"https://api.github.com/users/matejak/repos","events_url":"https://api.github.com/users/matejak/events{/privacy}","received_events_url":"https://api.github.com/users/matejak/received_events","type":"User","site_admin":false},"body":"See #2835 for past PR with description.","created_at":"2018-05-24T13:18:13Z","updated_at":"2018-05-24T16:02:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e13bbbf69c3226d3a6dbcf91ea7445ef97366ec2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/milestones/36","html_url":"https://github.com/OpenSCAP/scap-security-guide/milestone/36","labels_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/milestones/36/labels","id":3156689,"number":36,"title":"0.1.40","description":"","creator":{"login":"yuumasato","id":7460169,"avatar_url":"https://avatars0.githubusercontent.com/u/7460169?v=4","gravatar_id":"","url":"https://api.github.com/users/yuumasato","html_url":"https://github.com/yuumasato","followers_url":"https://api.github.com/users/yuumasato/followers","following_url":"https://api.github.com/users/yuumasato/following{/other_user}","gists_url":"https://api.github.com/users/yuumasato/gists{/gist_id}","starred_url":"https://api.github.com/users/yuumasato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuumasato/subscriptions","organizations_url":"https://api.github.com/users/yuumasato/orgs","repos_url":"https://api.github.com/users/yuumasato/repos","events_url":"https://api.github.com/users/yuumasato/events{/privacy}","received_events_url":"https://api.github.com/users/yuumasato/received_events","type":"User","site_admin":false},"open_issues":25,"closed_issues":30,"state":"open","created_at":"2018-03-02T17:06:15Z","updated_at":"2018-05-24T13:18:30Z","due_on":"2018-07-02T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/2861/commits","review_comments_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/2861/comments","review_comment_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/2861/comments","statuses_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/statuses/3ad8688520ba443e867a92e730fdf9d6b5b2b223","head":{"label":"matejak:macro2jinja-2","ref":"macro2jinja-2","sha":"3ad8688520ba443e867a92e730fdf9d6b5b2b223","user":{"login":"matejak","id":2823847,"avatar_url":"https://avatars2.githubusercontent.com/u/2823847?v=4","gravatar_id":"","url":"https://api.github.com/users/matejak","html_url":"https://github.com/matejak","followers_url":"https://api.github.com/users/matejak/followers","following_url":"https://api.github.com/users/matejak/following{/other_user}","gists_url":"https://api.github.com/users/matejak/gists{/gist_id}","starred_url":"https://api.github.com/users/matejak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matejak/subscriptions","organizations_url":"https://api.github.com/users/matejak/orgs","repos_url":"https://api.github.com/users/matejak/repos","events_url":"https://api.github.com/users/matejak/events{/privacy}","received_events_url":"https://api.github.com/users/matejak/received_events","type":"User","site_admin":false},"repo":{"id":104354951,"name":"scap-security-guide","full_name":"matejak/scap-security-guide","owner":{"login":"matejak","id":2823847,"avatar_url":"https://avatars2.githubusercontent.com/u/2823847?v=4","gravatar_id":"","url":"https://api.github.com/users/matejak","html_url":"https://github.com/matejak","followers_url":"https://api.github.com/users/matejak/followers","following_url":"https://api.github.com/users/matejak/following{/other_user}","gists_url":"https://api.github.com/users/matejak/gists{/gist_id}","starred_url":"https://api.github.com/users/matejak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matejak/subscriptions","organizations_url":"https://api.github.com/users/matejak/orgs","repos_url":"https://api.github.com/users/matejak/repos","events_url":"https://api.github.com/users/matejak/events{/privacy}","received_events_url":"https://api.github.com/users/matejak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matejak/scap-security-guide","description":"Baseline compliance content in SCAP formats","fork":true,"url":"https://api.github.com/repos/matejak/scap-security-guide","forks_url":"https://api.github.com/repos/matejak/scap-security-guide/forks","keys_url":"https://api.github.com/repos/matejak/scap-security-guide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matejak/scap-security-guide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matejak/scap-security-guide/teams","hooks_url":"https://api.github.com/repos/matejak/scap-security-guide/hooks","issue_events_url":"https://api.github.com/repos/matejak/scap-security-guide/issues/events{/number}","events_url":"https://api.github.com/repos/matejak/scap-security-guide/events","assignees_url":"https://api.github.com/repos/matejak/scap-security-guide/assignees{/user}","branches_url":"https://api.github.com/repos/matejak/scap-security-guide/branches{/branch}","tags_url":"https://api.github.com/repos/matejak/scap-security-guide/tags","blobs_url":"https://api.github.com/repos/matejak/scap-security-guide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matejak/scap-security-guide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matejak/scap-security-guide/git/refs{/sha}","trees_url":"https://api.github.com/repos/matejak/scap-security-guide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matejak/scap-security-guide/statuses/{sha}","languages_url":"https://api.github.com/repos/matejak/scap-security-guide/languages","stargazers_url":"https://api.github.com/repos/matejak/scap-security-guide/stargazers","contributors_url":"https://api.github.com/repos/matejak/scap-security-guide/contributors","subscribers_url":"https://api.github.com/repos/matejak/scap-security-guide/subscribers","subscription_url":"https://api.github.com/repos/matejak/scap-security-guide/subscription","commits_url":"https://api.github.com/repos/matejak/scap-security-guide/commits{/sha}","git_commits_url":"https://api.github.com/repos/matejak/scap-security-guide/git/commits{/sha}","comments_url":"https://api.github.com/repos/matejak/scap-security-guide/comments{/number}","issue_comment_url":"https://api.github.com/repos/matejak/scap-security-guide/issues/comments{/number}","contents_url":"https://api.github.com/repos/matejak/scap-security-guide/contents/{+path}","compare_url":"https://api.github.com/repos/matejak/scap-security-guide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matejak/scap-security-guide/merges","archive_url":"https://api.github.com/repos/matejak/scap-security-guide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matejak/scap-security-guide/downloads","issues_url":"https://api.github.com/repos/matejak/scap-security-guide/issues{/number}","pulls_url":"https://api.github.com/repos/matejak/scap-security-guide/pulls{/number}","milestones_url":"https://api.github.com/repos/matejak/scap-security-guide/milestones{/number}","notifications_url":"https://api.github.com/repos/matejak/scap-security-guide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matejak/scap-security-guide/labels{/name}","releases_url":"https://api.github.com/repos/matejak/scap-security-guide/releases{/id}","deployments_url":"https://api.github.com/repos/matejak/scap-security-guide/deployments","created_at":"2017-09-21T13:57:44Z","updated_at":"2018-01-12T13:46:32Z","pushed_at":"2018-05-24T13:16:06Z","git_url":"git://github.com/matejak/scap-security-guide.git","ssh_url":"git@github.com:matejak/scap-security-guide.git","clone_url":"https://github.com/matejak/scap-security-guide.git","svn_url":"https://github.com/matejak/scap-security-guide","homepage":"https://www.open-scap.org/security-policies/scap-security-guide","size":21910,"stargazers_count":0,"watchers_count":0,"language":"XSLT","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenSCAP:master","ref":"master","sha":"c64a737c94a9348cc7dd1f0221aa749f1bfedb00","user":{"login":"OpenSCAP","id":7439934,"avatar_url":"https://avatars1.githubusercontent.com/u/7439934?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenSCAP","html_url":"https://github.com/OpenSCAP","followers_url":"https://api.github.com/users/OpenSCAP/followers","following_url":"https://api.github.com/users/OpenSCAP/following{/other_user}","gists_url":"https://api.github.com/users/OpenSCAP/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSCAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSCAP/subscriptions","organizations_url":"https://api.github.com/users/OpenSCAP/orgs","repos_url":"https://api.github.com/users/OpenSCAP/repos","events_url":"https://api.github.com/users/OpenSCAP/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSCAP/received_events","type":"Organization","site_admin":false},"repo":{"id":19279458,"name":"scap-security-guide","full_name":"OpenSCAP/scap-security-guide","owner":{"login":"OpenSCAP","id":7439934,"avatar_url":"https://avatars1.githubusercontent.com/u/7439934?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenSCAP","html_url":"https://github.com/OpenSCAP","followers_url":"https://api.github.com/users/OpenSCAP/followers","following_url":"https://api.github.com/users/OpenSCAP/following{/other_user}","gists_url":"https://api.github.com/users/OpenSCAP/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSCAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSCAP/subscriptions","organizations_url":"https://api.github.com/users/OpenSCAP/orgs","repos_url":"https://api.github.com/users/OpenSCAP/repos","events_url":"https://api.github.com/users/OpenSCAP/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSCAP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenSCAP/scap-security-guide","description":"Baseline compliance content in SCAP formats","fork":false,"url":"https://api.github.com/repos/OpenSCAP/scap-security-guide","forks_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/forks","keys_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/teams","hooks_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/hooks","issue_events_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/events{/number}","events_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/events","assignees_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/assignees{/user}","branches_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/branches{/branch}","tags_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/tags","blobs_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/languages","stargazers_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/stargazers","contributors_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/contributors","subscribers_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/subscribers","subscription_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/subscription","commits_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/contents/{+path}","compare_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/merges","archive_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/downloads","issues_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues{/number}","pulls_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/labels{/name}","releases_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/releases{/id}","deployments_url":"https://api.github.com/repos/OpenSCAP/scap-security-guide/deployments","created_at":"2014-04-29T14:32:02Z","updated_at":"2018-05-24T07:16:06Z","pushed_at":"2018-05-24T13:50:45Z","git_url":"git://github.com/OpenSCAP/scap-security-guide.git","ssh_url":"git@github.com:OpenSCAP/scap-security-guide.git","clone_url":"https://github.com/OpenSCAP/scap-security-guide.git","svn_url":"https://github.com/OpenSCAP/scap-security-guide","homepage":"https://www.open-scap.org/security-policies/scap-security-guide","size":21887,"stargazers_count":397,"watchers_count":397,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":217,"mirror_url":null,"archived":false,"open_issues_count":136,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":217,"open_issues":136,"watchers":397,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/2861"},"html":{"href":"https://github.com/OpenSCAP/scap-security-guide/pull/2861"},"issue":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/2861"},"comments":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/issues/2861/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/2861/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/pulls/2861/commits"},"statuses":{"href":"https://api.github.com/repos/OpenSCAP/scap-security-guide/statuses/3ad8688520ba443e867a92e730fdf9d6b5b2b223"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mpreisler"}}