{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/comments/180488443","pull_request_review_id":110917156,"id":180488443,"diff_hunk":"@@ -302,7 +316,14 @@\n   Optional[String] $email_smtp_domain = $::foreman::params::email_smtp_domain,\n   Enum['none', 'plain', 'login', 'cram-md5'] $email_smtp_authentication = $::foreman::params::email_smtp_authentication,\n   Optional[String] $email_smtp_user_name = $::foreman::params::email_smtp_user_name,\n-  Optional[String] $email_smtp_password = $::foreman::params::email_smtp_password,\n+  String $email_smtp_password = $::foreman::params::email_smtp_password,","path":"manifests/init.pp","position":null,"original_position":340,"commit_id":"d2b8d50fb55f6f4758a790e3a0ff3ba9e1cb4ee9","original_commit_id":"398f6324985f0a07e0626691b054febce16aad6f","user":{"login":"ares","id":109773,"avatar_url":"https://avatars0.githubusercontent.com/u/109773?v=4","gravatar_id":"","url":"https://api.github.com/users/ares","html_url":"https://github.com/ares","followers_url":"https://api.github.com/users/ares/followers","following_url":"https://api.github.com/users/ares/following{/other_user}","gists_url":"https://api.github.com/users/ares/gists{/gist_id}","starred_url":"https://api.github.com/users/ares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ares/subscriptions","organizations_url":"https://api.github.com/users/ares/orgs","repos_url":"https://api.github.com/users/ares/repos","events_url":"https://api.github.com/users/ares/events{/privacy}","received_events_url":"https://api.github.com/users/ares/received_events","type":"User","site_admin":false},"body":"no, certainly not, sorry :-)","created_at":"2018-04-10T16:37:44Z","updated_at":"2018-04-10T16:37:44Z","html_url":"https://github.com/theforeman/puppet-foreman/pull/637#discussion_r180488443","pull_request_url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/637","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/comments/180488443"},"html":{"href":"https://github.com/theforeman/puppet-foreman/pull/637#discussion_r180488443"},"pull_request":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/637"}},"in_reply_to_id":180376328},"pull_request":{"url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/637","id":180518318,"html_url":"https://github.com/theforeman/puppet-foreman/pull/637","diff_url":"https://github.com/theforeman/puppet-foreman/pull/637.diff","patch_url":"https://github.com/theforeman/puppet-foreman/pull/637.patch","issue_url":"https://api.github.com/repos/theforeman/puppet-foreman/issues/637","number":637,"state":"open","locked":false,"title":"Fixes #23101 - add telemetry options","user":{"login":"ares","id":109773,"avatar_url":"https://avatars0.githubusercontent.com/u/109773?v=4","gravatar_id":"","url":"https://api.github.com/users/ares","html_url":"https://github.com/ares","followers_url":"https://api.github.com/users/ares/followers","following_url":"https://api.github.com/users/ares/following{/other_user}","gists_url":"https://api.github.com/users/ares/gists{/gist_id}","starred_url":"https://api.github.com/users/ares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ares/subscriptions","organizations_url":"https://api.github.com/users/ares/orgs","repos_url":"https://api.github.com/users/ares/repos","events_url":"https://api.github.com/users/ares/events{/privacy}","received_events_url":"https://api.github.com/users/ares/received_events","type":"User","site_admin":false},"body":"@ekohl this would be really good to have in 1.18, otherwise every installer run disables telemetry configuration that users configured, cc @lzap \r\n\r\nnote that the biggest past is indentation of comments","created_at":"2018-04-10T07:58:30Z","updated_at":"2018-04-10T16:37:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0bbcf20c8117fa0637055c6d2288bbac55571d32","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":794028422,"url":"https://api.github.com/repos/theforeman/puppet-foreman/labels/Needs%20re-review","name":"Needs re-review","color":"0052cc","default":false},{"id":794028431,"url":"https://api.github.com/repos/theforeman/puppet-foreman/labels/Needs%20testing","name":"Needs testing","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/637/commits","review_comments_url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/637/comments","review_comment_url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/puppet-foreman/issues/637/comments","statuses_url":"https://api.github.com/repos/theforeman/puppet-foreman/statuses/d2b8d50fb55f6f4758a790e3a0ff3ba9e1cb4ee9","head":{"label":"ares:fix/23101","ref":"fix/23101","sha":"d2b8d50fb55f6f4758a790e3a0ff3ba9e1cb4ee9","user":{"login":"ares","id":109773,"avatar_url":"https://avatars0.githubusercontent.com/u/109773?v=4","gravatar_id":"","url":"https://api.github.com/users/ares","html_url":"https://github.com/ares","followers_url":"https://api.github.com/users/ares/followers","following_url":"https://api.github.com/users/ares/following{/other_user}","gists_url":"https://api.github.com/users/ares/gists{/gist_id}","starred_url":"https://api.github.com/users/ares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ares/subscriptions","organizations_url":"https://api.github.com/users/ares/orgs","repos_url":"https://api.github.com/users/ares/repos","events_url":"https://api.github.com/users/ares/events{/privacy}","received_events_url":"https://api.github.com/users/ares/received_events","type":"User","site_admin":false},"repo":{"id":11632774,"name":"puppet-foreman","full_name":"ares/puppet-foreman","owner":{"login":"ares","id":109773,"avatar_url":"https://avatars0.githubusercontent.com/u/109773?v=4","gravatar_id":"","url":"https://api.github.com/users/ares","html_url":"https://github.com/ares","followers_url":"https://api.github.com/users/ares/followers","following_url":"https://api.github.com/users/ares/following{/other_user}","gists_url":"https://api.github.com/users/ares/gists{/gist_id}","starred_url":"https://api.github.com/users/ares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ares/subscriptions","organizations_url":"https://api.github.com/users/ares/orgs","repos_url":"https://api.github.com/users/ares/repos","events_url":"https://api.github.com/users/ares/events{/privacy}","received_events_url":"https://api.github.com/users/ares/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ares/puppet-foreman","description":"Puppet module for Foreman","fork":true,"url":"https://api.github.com/repos/ares/puppet-foreman","forks_url":"https://api.github.com/repos/ares/puppet-foreman/forks","keys_url":"https://api.github.com/repos/ares/puppet-foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ares/puppet-foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ares/puppet-foreman/teams","hooks_url":"https://api.github.com/repos/ares/puppet-foreman/hooks","issue_events_url":"https://api.github.com/repos/ares/puppet-foreman/issues/events{/number}","events_url":"https://api.github.com/repos/ares/puppet-foreman/events","assignees_url":"https://api.github.com/repos/ares/puppet-foreman/assignees{/user}","branches_url":"https://api.github.com/repos/ares/puppet-foreman/branches{/branch}","tags_url":"https://api.github.com/repos/ares/puppet-foreman/tags","blobs_url":"https://api.github.com/repos/ares/puppet-foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ares/puppet-foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ares/puppet-foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/ares/puppet-foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ares/puppet-foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/ares/puppet-foreman/languages","stargazers_url":"https://api.github.com/repos/ares/puppet-foreman/stargazers","contributors_url":"https://api.github.com/repos/ares/puppet-foreman/contributors","subscribers_url":"https://api.github.com/repos/ares/puppet-foreman/subscribers","subscription_url":"https://api.github.com/repos/ares/puppet-foreman/subscription","commits_url":"https://api.github.com/repos/ares/puppet-foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/ares/puppet-foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/ares/puppet-foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/ares/puppet-foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/ares/puppet-foreman/contents/{+path}","compare_url":"https://api.github.com/repos/ares/puppet-foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ares/puppet-foreman/merges","archive_url":"https://api.github.com/repos/ares/puppet-foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ares/puppet-foreman/downloads","issues_url":"https://api.github.com/repos/ares/puppet-foreman/issues{/number}","pulls_url":"https://api.github.com/repos/ares/puppet-foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/ares/puppet-foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/ares/puppet-foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ares/puppet-foreman/labels{/name}","releases_url":"https://api.github.com/repos/ares/puppet-foreman/releases{/id}","deployments_url":"https://api.github.com/repos/ares/puppet-foreman/deployments","created_at":"2013-07-24T11:07:27Z","updated_at":"2014-06-19T09:47:08Z","pushed_at":"2018-04-10T16:37:35Z","git_url":"git://github.com/ares/puppet-foreman.git","ssh_url":"git@github.com:ares/puppet-foreman.git","clone_url":"https://github.com/ares/puppet-foreman.git","svn_url":"https://github.com/ares/puppet-foreman","homepage":"","size":988,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theforeman:master","ref":"master","sha":"68f58af4673f30b857f7793f74e4b131d4e1957d","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars2.githubusercontent.com/u/1439844?v=4","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":3449583,"name":"puppet-foreman","full_name":"theforeman/puppet-foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars2.githubusercontent.com/u/1439844?v=4","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/puppet-foreman","description":"Puppet module for Foreman","fork":false,"url":"https://api.github.com/repos/theforeman/puppet-foreman","forks_url":"https://api.github.com/repos/theforeman/puppet-foreman/forks","keys_url":"https://api.github.com/repos/theforeman/puppet-foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/puppet-foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/puppet-foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/puppet-foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/puppet-foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/puppet-foreman/events","assignees_url":"https://api.github.com/repos/theforeman/puppet-foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/puppet-foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/puppet-foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/puppet-foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/puppet-foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/puppet-foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/puppet-foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/puppet-foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/puppet-foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/puppet-foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/puppet-foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/puppet-foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/puppet-foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/puppet-foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/puppet-foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/puppet-foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/puppet-foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/puppet-foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/puppet-foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/puppet-foreman/merges","archive_url":"https://api.github.com/repos/theforeman/puppet-foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/puppet-foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/puppet-foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/puppet-foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/puppet-foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/puppet-foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/puppet-foreman/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/puppet-foreman/deployments","created_at":"2012-02-15T13:19:01Z","updated_at":"2018-04-09T13:55:01Z","pushed_at":"2018-04-10T16:37:36Z","git_url":"git://github.com/theforeman/puppet-foreman.git","ssh_url":"git@github.com:theforeman/puppet-foreman.git","clone_url":"https://github.com/theforeman/puppet-foreman.git","svn_url":"https://github.com/theforeman/puppet-foreman","homepage":"","size":1019,"stargazers_count":87,"watchers_count":87,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":223,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":223,"open_issues":16,"watchers":87,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/637"},"html":{"href":"https://github.com/theforeman/puppet-foreman/pull/637"},"issue":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/issues/637"},"comments":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/issues/637/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/637/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/637/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/statuses/d2b8d50fb55f6f4758a790e3a0ff3ba9e1cb4ee9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ares"}}