{"action":"created","comment":{"url":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/comments/209431172","pull_request_review_id":145451003,"id":209431172,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTQzMTE3Mg==","diff_hunk":"@@ -256,10 +256,12 @@ int16 CBattleEntity::GetWeaponDelay(bool tp)\n     if (!tp)\n     {\n         // Cap haste at appropriate levels.\n-        int16 hasteMagic = std::clamp<int16>(getMod(Mod::HASTE_MAGIC), -448, 448);\n-        int16 hasteAbility = std::clamp<int16>(getMod(Mod::HASTE_ABILITY), -256, 256);\n-        int16 hasteGear = std::clamp<int16>(getMod(Mod::HASTE_GEAR), -256, 256);\n-        WeaponDelay = (uint16)(WeaponDelay * ((1024.0f - hasteMagic - hasteAbility - hasteGear) / 1024.0f));\n+        int16 hasteMagic = std::clamp<int16>(getMod(Mod::HASTE_MAGIC), -4375, 4375); // 43.75% cap\n+        int16 hasteAbility = std::clamp<int16>(getMod(Mod::HASTE_ABILITY), -2500, 2500); // 25% cap","path":"src/map/entities/battleentity.cpp","position":9,"original_position":9,"commit_id":"838e826bfc66fff5df169bd46512a6319fd5d3ac","original_commit_id":"d7110d34db707b0fabf49a04996c7fb1b4b5abf1","user":{"login":"TeoTwawki","id":6871475,"node_id":"MDQ6VXNlcjY4NzE0NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/6871475?v=4","gravatar_id":"","url":"https://api.github.com/users/TeoTwawki","html_url":"https://github.com/TeoTwawki","followers_url":"https://api.github.com/users/TeoTwawki/followers","following_url":"https://api.github.com/users/TeoTwawki/following{/other_user}","gists_url":"https://api.github.com/users/TeoTwawki/gists{/gist_id}","starred_url":"https://api.github.com/users/TeoTwawki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeoTwawki/subscriptions","organizations_url":"https://api.github.com/users/TeoTwawki/orgs","repos_url":"https://api.github.com/users/TeoTwawki/repos","events_url":"https://api.github.com/users/TeoTwawki/events{/privacy}","received_events_url":"https://api.github.com/users/TeoTwawki/received_events","type":"User","site_admin":false},"body":"@teschnei per convo in discord the thing pdt does may in fact be placebo, dumping this on you, I didn't check and I don't want to, I don't have time to find a years old commit and see exactly what happened along the way to present day.","created_at":"2018-08-11T16:27:36Z","updated_at":"2018-08-11T16:27:36Z","html_url":"https://github.com/DarkstarProject/darkstar/pull/5174#discussion_r209431172","pull_request_url":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/5174","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/comments/209431172"},"html":{"href":"https://github.com/DarkstarProject/darkstar/pull/5174#discussion_r209431172"},"pull_request":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/5174"}},"in_reply_to_id":209426547},"pull_request":{"url":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/5174","id":207760014,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NzYwMDE0","html_url":"https://github.com/DarkstarProject/darkstar/pull/5174","diff_url":"https://github.com/DarkstarProject/darkstar/pull/5174.diff","patch_url":"https://github.com/DarkstarProject/darkstar/pull/5174.patch","issue_url":"https://api.github.com/repos/DarkstarProject/darkstar/issues/5174","number":5174,"state":"open","locked":false,"title":"Haste Rewrite","user":{"login":"nfaletra","id":11480851,"node_id":"MDQ6VXNlcjExNDgwODUx","avatar_url":"https://avatars1.githubusercontent.com/u/11480851?v=4","gravatar_id":"","url":"https://api.github.com/users/nfaletra","html_url":"https://github.com/nfaletra","followers_url":"https://api.github.com/users/nfaletra/followers","following_url":"https://api.github.com/users/nfaletra/following{/other_user}","gists_url":"https://api.github.com/users/nfaletra/gists{/gist_id}","starred_url":"https://api.github.com/users/nfaletra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfaletra/subscriptions","organizations_url":"https://api.github.com/users/nfaletra/orgs","repos_url":"https://api.github.com/users/nfaletra/repos","events_url":"https://api.github.com/users/nfaletra/events{/privacy}","received_events_url":"https://api.github.com/users/nfaletra/received_events","type":"User","site_admin":false},"body":"Addresses: https://github.com/DarkstarProject/darkstar/issues/5172\r\n\r\nTurned haste mods into a 0-10000 scale. The reason for the large scale was to get two decimal places in haste calculations without using floating point numbers. After the exact percentages are calculated, it then scales and truncates the appropriate variable (whether it be weapon delay or recast timers).\r\n\r\nI formatted most lua files to be up to date with current style guide-ness. Avoided the formatting the entirety of larger files. Makes it a little hard to see the haste changes. Sorry about that.\r\n\r\nSlow calculations were also affected since they are handled as an inverse Haste. That math has also been updated to a 0-10000 scale.\r\n\r\nMerit values for Desperate Blows Effect and Haste Samba Effect were also updated.\r\n\r\nDid some minor testing via spell casts that apply the correct effects (haste/slow) and equipped gear with haste mods to observe weapon delay being affected.","created_at":"2018-08-11T06:02:48Z","updated_at":"2018-08-11T16:27:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79912a1895c84019f1fb883bc899dec8cbb4bad5","assignee":{"login":"teschnei","id":1149183,"node_id":"MDQ6VXNlcjExNDkxODM=","avatar_url":"https://avatars3.githubusercontent.com/u/1149183?v=4","gravatar_id":"","url":"https://api.github.com/users/teschnei","html_url":"https://github.com/teschnei","followers_url":"https://api.github.com/users/teschnei/followers","following_url":"https://api.github.com/users/teschnei/following{/other_user}","gists_url":"https://api.github.com/users/teschnei/gists{/gist_id}","starred_url":"https://api.github.com/users/teschnei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teschnei/subscriptions","organizations_url":"https://api.github.com/users/teschnei/orgs","repos_url":"https://api.github.com/users/teschnei/repos","events_url":"https://api.github.com/users/teschnei/events{/privacy}","received_events_url":"https://api.github.com/users/teschnei/received_events","type":"User","site_admin":false},"assignees":[{"login":"teschnei","id":1149183,"node_id":"MDQ6VXNlcjExNDkxODM=","avatar_url":"https://avatars3.githubusercontent.com/u/1149183?v=4","gravatar_id":"","url":"https://api.github.com/users/teschnei","html_url":"https://github.com/teschnei","followers_url":"https://api.github.com/users/teschnei/followers","following_url":"https://api.github.com/users/teschnei/following{/other_user}","gists_url":"https://api.github.com/users/teschnei/gists{/gist_id}","starred_url":"https://api.github.com/users/teschnei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teschnei/subscriptions","organizations_url":"https://api.github.com/users/teschnei/orgs","repos_url":"https://api.github.com/users/teschnei/repos","events_url":"https://api.github.com/users/teschnei/events{/privacy}","received_events_url":"https://api.github.com/users/teschnei/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/5174/commits","review_comments_url":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/5174/comments","review_comment_url":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DarkstarProject/darkstar/issues/5174/comments","statuses_url":"https://api.github.com/repos/DarkstarProject/darkstar/statuses/838e826bfc66fff5df169bd46512a6319fd5d3ac","head":{"label":"nfaletra:hasteRewrite","ref":"hasteRewrite","sha":"838e826bfc66fff5df169bd46512a6319fd5d3ac","user":{"login":"nfaletra","id":11480851,"node_id":"MDQ6VXNlcjExNDgwODUx","avatar_url":"https://avatars1.githubusercontent.com/u/11480851?v=4","gravatar_id":"","url":"https://api.github.com/users/nfaletra","html_url":"https://github.com/nfaletra","followers_url":"https://api.github.com/users/nfaletra/followers","following_url":"https://api.github.com/users/nfaletra/following{/other_user}","gists_url":"https://api.github.com/users/nfaletra/gists{/gist_id}","starred_url":"https://api.github.com/users/nfaletra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfaletra/subscriptions","organizations_url":"https://api.github.com/users/nfaletra/orgs","repos_url":"https://api.github.com/users/nfaletra/repos","events_url":"https://api.github.com/users/nfaletra/events{/privacy}","received_events_url":"https://api.github.com/users/nfaletra/received_events","type":"User","site_admin":false},"repo":{"id":113487302,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM0ODczMDI=","name":"darkstar","full_name":"nfaletra/darkstar","owner":{"login":"nfaletra","id":11480851,"node_id":"MDQ6VXNlcjExNDgwODUx","avatar_url":"https://avatars1.githubusercontent.com/u/11480851?v=4","gravatar_id":"","url":"https://api.github.com/users/nfaletra","html_url":"https://github.com/nfaletra","followers_url":"https://api.github.com/users/nfaletra/followers","following_url":"https://api.github.com/users/nfaletra/following{/other_user}","gists_url":"https://api.github.com/users/nfaletra/gists{/gist_id}","starred_url":"https://api.github.com/users/nfaletra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfaletra/subscriptions","organizations_url":"https://api.github.com/users/nfaletra/orgs","repos_url":"https://api.github.com/users/nfaletra/repos","events_url":"https://api.github.com/users/nfaletra/events{/privacy}","received_events_url":"https://api.github.com/users/nfaletra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nfaletra/darkstar","description":"FFXI Server Emulator","fork":true,"url":"https://api.github.com/repos/nfaletra/darkstar","forks_url":"https://api.github.com/repos/nfaletra/darkstar/forks","keys_url":"https://api.github.com/repos/nfaletra/darkstar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nfaletra/darkstar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nfaletra/darkstar/teams","hooks_url":"https://api.github.com/repos/nfaletra/darkstar/hooks","issue_events_url":"https://api.github.com/repos/nfaletra/darkstar/issues/events{/number}","events_url":"https://api.github.com/repos/nfaletra/darkstar/events","assignees_url":"https://api.github.com/repos/nfaletra/darkstar/assignees{/user}","branches_url":"https://api.github.com/repos/nfaletra/darkstar/branches{/branch}","tags_url":"https://api.github.com/repos/nfaletra/darkstar/tags","blobs_url":"https://api.github.com/repos/nfaletra/darkstar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nfaletra/darkstar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nfaletra/darkstar/git/refs{/sha}","trees_url":"https://api.github.com/repos/nfaletra/darkstar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nfaletra/darkstar/statuses/{sha}","languages_url":"https://api.github.com/repos/nfaletra/darkstar/languages","stargazers_url":"https://api.github.com/repos/nfaletra/darkstar/stargazers","contributors_url":"https://api.github.com/repos/nfaletra/darkstar/contributors","subscribers_url":"https://api.github.com/repos/nfaletra/darkstar/subscribers","subscription_url":"https://api.github.com/repos/nfaletra/darkstar/subscription","commits_url":"https://api.github.com/repos/nfaletra/darkstar/commits{/sha}","git_commits_url":"https://api.github.com/repos/nfaletra/darkstar/git/commits{/sha}","comments_url":"https://api.github.com/repos/nfaletra/darkstar/comments{/number}","issue_comment_url":"https://api.github.com/repos/nfaletra/darkstar/issues/comments{/number}","contents_url":"https://api.github.com/repos/nfaletra/darkstar/contents/{+path}","compare_url":"https://api.github.com/repos/nfaletra/darkstar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nfaletra/darkstar/merges","archive_url":"https://api.github.com/repos/nfaletra/darkstar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nfaletra/darkstar/downloads","issues_url":"https://api.github.com/repos/nfaletra/darkstar/issues{/number}","pulls_url":"https://api.github.com/repos/nfaletra/darkstar/pulls{/number}","milestones_url":"https://api.github.com/repos/nfaletra/darkstar/milestones{/number}","notifications_url":"https://api.github.com/repos/nfaletra/darkstar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nfaletra/darkstar/labels{/name}","releases_url":"https://api.github.com/repos/nfaletra/darkstar/releases{/id}","deployments_url":"https://api.github.com/repos/nfaletra/darkstar/deployments","created_at":"2017-12-07T18:53:50Z","updated_at":"2018-08-10T15:10:00Z","pushed_at":"2018-08-11T06:27:15Z","git_url":"git://github.com/nfaletra/darkstar.git","ssh_url":"git@github.com:nfaletra/darkstar.git","clone_url":"https://github.com/nfaletra/darkstar.git","svn_url":"https://github.com/nfaletra/darkstar","homepage":"https://forums.dspt.info/index.php","size":207524,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DarkstarProject:master","ref":"master","sha":"ac97dc3306febd3d4d62aae54db433e03c5ea9f7","user":{"login":"DarkstarProject","id":6373714,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzNzM3MTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6373714?v=4","gravatar_id":"","url":"https://api.github.com/users/DarkstarProject","html_url":"https://github.com/DarkstarProject","followers_url":"https://api.github.com/users/DarkstarProject/followers","following_url":"https://api.github.com/users/DarkstarProject/following{/other_user}","gists_url":"https://api.github.com/users/DarkstarProject/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkstarProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkstarProject/subscriptions","organizations_url":"https://api.github.com/users/DarkstarProject/orgs","repos_url":"https://api.github.com/users/DarkstarProject/repos","events_url":"https://api.github.com/users/DarkstarProject/events{/privacy}","received_events_url":"https://api.github.com/users/DarkstarProject/received_events","type":"Organization","site_admin":false},"repo":{"id":15814642,"node_id":"MDEwOlJlcG9zaXRvcnkxNTgxNDY0Mg==","name":"darkstar","full_name":"DarkstarProject/darkstar","owner":{"login":"DarkstarProject","id":6373714,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzNzM3MTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6373714?v=4","gravatar_id":"","url":"https://api.github.com/users/DarkstarProject","html_url":"https://github.com/DarkstarProject","followers_url":"https://api.github.com/users/DarkstarProject/followers","following_url":"https://api.github.com/users/DarkstarProject/following{/other_user}","gists_url":"https://api.github.com/users/DarkstarProject/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkstarProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkstarProject/subscriptions","organizations_url":"https://api.github.com/users/DarkstarProject/orgs","repos_url":"https://api.github.com/users/DarkstarProject/repos","events_url":"https://api.github.com/users/DarkstarProject/events{/privacy}","received_events_url":"https://api.github.com/users/DarkstarProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DarkstarProject/darkstar","description":"FFXI Server Emulator","fork":false,"url":"https://api.github.com/repos/DarkstarProject/darkstar","forks_url":"https://api.github.com/repos/DarkstarProject/darkstar/forks","keys_url":"https://api.github.com/repos/DarkstarProject/darkstar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DarkstarProject/darkstar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DarkstarProject/darkstar/teams","hooks_url":"https://api.github.com/repos/DarkstarProject/darkstar/hooks","issue_events_url":"https://api.github.com/repos/DarkstarProject/darkstar/issues/events{/number}","events_url":"https://api.github.com/repos/DarkstarProject/darkstar/events","assignees_url":"https://api.github.com/repos/DarkstarProject/darkstar/assignees{/user}","branches_url":"https://api.github.com/repos/DarkstarProject/darkstar/branches{/branch}","tags_url":"https://api.github.com/repos/DarkstarProject/darkstar/tags","blobs_url":"https://api.github.com/repos/DarkstarProject/darkstar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DarkstarProject/darkstar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DarkstarProject/darkstar/git/refs{/sha}","trees_url":"https://api.github.com/repos/DarkstarProject/darkstar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DarkstarProject/darkstar/statuses/{sha}","languages_url":"https://api.github.com/repos/DarkstarProject/darkstar/languages","stargazers_url":"https://api.github.com/repos/DarkstarProject/darkstar/stargazers","contributors_url":"https://api.github.com/repos/DarkstarProject/darkstar/contributors","subscribers_url":"https://api.github.com/repos/DarkstarProject/darkstar/subscribers","subscription_url":"https://api.github.com/repos/DarkstarProject/darkstar/subscription","commits_url":"https://api.github.com/repos/DarkstarProject/darkstar/commits{/sha}","git_commits_url":"https://api.github.com/repos/DarkstarProject/darkstar/git/commits{/sha}","comments_url":"https://api.github.com/repos/DarkstarProject/darkstar/comments{/number}","issue_comment_url":"https://api.github.com/repos/DarkstarProject/darkstar/issues/comments{/number}","contents_url":"https://api.github.com/repos/DarkstarProject/darkstar/contents/{+path}","compare_url":"https://api.github.com/repos/DarkstarProject/darkstar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DarkstarProject/darkstar/merges","archive_url":"https://api.github.com/repos/DarkstarProject/darkstar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DarkstarProject/darkstar/downloads","issues_url":"https://api.github.com/repos/DarkstarProject/darkstar/issues{/number}","pulls_url":"https://api.github.com/repos/DarkstarProject/darkstar/pulls{/number}","milestones_url":"https://api.github.com/repos/DarkstarProject/darkstar/milestones{/number}","notifications_url":"https://api.github.com/repos/DarkstarProject/darkstar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DarkstarProject/darkstar/labels{/name}","releases_url":"https://api.github.com/repos/DarkstarProject/darkstar/releases{/id}","deployments_url":"https://api.github.com/repos/DarkstarProject/darkstar/deployments","created_at":"2014-01-11T01:31:17Z","updated_at":"2018-08-11T06:44:16Z","pushed_at":"2018-08-11T15:28:44Z","git_url":"git://github.com/DarkstarProject/darkstar.git","ssh_url":"git@github.com:DarkstarProject/darkstar.git","clone_url":"https://github.com/DarkstarProject/darkstar.git","svn_url":"https://github.com/DarkstarProject/darkstar","homepage":"https://forums.dspt.info/index.php","size":210375,"stargazers_count":349,"watchers_count":349,"language":"Lua","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":515,"mirror_url":null,"archived":false,"open_issues_count":425,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":515,"open_issues":425,"watchers":349,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/5174"},"html":{"href":"https://github.com/DarkstarProject/darkstar/pull/5174"},"issue":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/issues/5174"},"comments":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/issues/5174/comments"},"review_comments":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/5174/comments"},"review_comment":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/5174/commits"},"statuses":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/statuses/838e826bfc66fff5df169bd46512a6319fd5d3ac"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"TeoTwawki"}}