{"action":"created","comment":{"url":"https://api.github.com/repos/google/gapid/pulls/comments/245314949","pull_request_review_id":189390026,"id":245314949,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTMxNDk0OQ==","diff_hunk":"@@ -845,6 +845,7 @@ message RenderSettings {\n // Resources contains the full list of resources used by a capture.\n message Resources {\n   repeated ResourcesByType types = 1;\n+  map<string, api.ResourceType> resourceTypes = 2;","path":"gapis/service/service.proto","position":4,"original_position":4,"commit_id":"64c72077f09cffb5f44b8d4e6239bf28d150ca12","original_commit_id":"64c72077f09cffb5f44b8d4e6239bf28d150ca12","user":{"login":"AWoloszyn","id":9043212,"node_id":"MDQ6VXNlcjkwNDMyMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/9043212?v=4","gravatar_id":"","url":"https://api.github.com/users/AWoloszyn","html_url":"https://github.com/AWoloszyn","followers_url":"https://api.github.com/users/AWoloszyn/followers","following_url":"https://api.github.com/users/AWoloszyn/following{/other_user}","gists_url":"https://api.github.com/users/AWoloszyn/gists{/gist_id}","starred_url":"https://api.github.com/users/AWoloszyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AWoloszyn/subscriptions","organizations_url":"https://api.github.com/users/AWoloszyn/orgs","repos_url":"https://api.github.com/users/AWoloszyn/repos","events_url":"https://api.github.com/users/AWoloszyn/events{/privacy}","received_events_url":"https://api.github.com/users/AWoloszyn/received_events","type":"User","site_admin":false},"body":"Used above \r\ngapis/resolve/resource_data.go:141","created_at":"2019-01-04T14:40:30Z","updated_at":"2019-01-04T14:40:30Z","html_url":"https://github.com/google/gapid/pull/2512#discussion_r245314949","pull_request_url":"https://api.github.com/repos/google/gapid/pulls/2512","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/google/gapid/pulls/comments/245314949"},"html":{"href":"https://github.com/google/gapid/pull/2512#discussion_r245314949"},"pull_request":{"href":"https://api.github.com/repos/google/gapid/pulls/2512"}},"in_reply_to_id":245119760},"pull_request":{"url":"https://api.github.com/repos/google/gapid/pulls/2512","id":242092878,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMDkyODc4","html_url":"https://github.com/google/gapid/pull/2512","diff_url":"https://github.com/google/gapid/pull/2512.diff","patch_url":"https://github.com/google/gapid/pull/2512.patch","issue_url":"https://api.github.com/repos/google/gapid/issues/2512","number":2512,"state":"open","locked":false,"title":"Make AllResourceData resolvable based on resource type.","user":{"login":"AWoloszyn","id":9043212,"node_id":"MDQ6VXNlcjkwNDMyMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/9043212?v=4","gravatar_id":"","url":"https://api.github.com/users/AWoloszyn","html_url":"https://github.com/AWoloszyn","followers_url":"https://api.github.com/users/AWoloszyn/followers","following_url":"https://api.github.com/users/AWoloszyn/following{/other_user}","gists_url":"https://api.github.com/users/AWoloszyn/gists{/gist_id}","starred_url":"https://api.github.com/users/AWoloszyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AWoloszyn/subscriptions","organizations_url":"https://api.github.com/users/AWoloszyn/orgs","repos_url":"https://api.github.com/users/AWoloszyn/repos","events_url":"https://api.github.com/users/AWoloszyn/events{/privacy}","received_events_url":"https://api.github.com/users/AWoloszyn/received_events","type":"User","site_admin":false},"body":"This means that dump_resources does not have to actually\r\nkick off replays. It also means we don't have to store\r\nas much data if we do not need all of it.\r\n\r\nFixes https://github.com/google/gapid/issues/2435","created_at":"2019-01-03T19:47:25Z","updated_at":"2019-01-04T14:40:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5fdd6a848ecfbc0f55348fe354a593577519f3a7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pmuetschard","id":13356324,"node_id":"MDQ6VXNlcjEzMzU2MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/13356324?v=4","gravatar_id":"","url":"https://api.github.com/users/pmuetschard","html_url":"https://github.com/pmuetschard","followers_url":"https://api.github.com/users/pmuetschard/followers","following_url":"https://api.github.com/users/pmuetschard/following{/other_user}","gists_url":"https://api.github.com/users/pmuetschard/gists{/gist_id}","starred_url":"https://api.github.com/users/pmuetschard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmuetschard/subscriptions","organizations_url":"https://api.github.com/users/pmuetschard/orgs","repos_url":"https://api.github.com/users/pmuetschard/repos","events_url":"https://api.github.com/users/pmuetschard/events{/privacy}","received_events_url":"https://api.github.com/users/pmuetschard/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1100371644,"node_id":"MDU6TGFiZWwxMTAwMzcxNjQ0","url":"https://api.github.com/repos/google/gapid/labels/cla:%20yes","name":"cla: yes","color":"e8b66d","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/gapid/pulls/2512/commits","review_comments_url":"https://api.github.com/repos/google/gapid/pulls/2512/comments","review_comment_url":"https://api.github.com/repos/google/gapid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/gapid/issues/2512/comments","statuses_url":"https://api.github.com/repos/google/gapid/statuses/64c72077f09cffb5f44b8d4e6239bf28d150ca12","head":{"label":"AWoloszyn:all-res-data","ref":"all-res-data","sha":"64c72077f09cffb5f44b8d4e6239bf28d150ca12","user":{"login":"AWoloszyn","id":9043212,"node_id":"MDQ6VXNlcjkwNDMyMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/9043212?v=4","gravatar_id":"","url":"https://api.github.com/users/AWoloszyn","html_url":"https://github.com/AWoloszyn","followers_url":"https://api.github.com/users/AWoloszyn/followers","following_url":"https://api.github.com/users/AWoloszyn/following{/other_user}","gists_url":"https://api.github.com/users/AWoloszyn/gists{/gist_id}","starred_url":"https://api.github.com/users/AWoloszyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AWoloszyn/subscriptions","organizations_url":"https://api.github.com/users/AWoloszyn/orgs","repos_url":"https://api.github.com/users/AWoloszyn/repos","events_url":"https://api.github.com/users/AWoloszyn/events{/privacy}","received_events_url":"https://api.github.com/users/AWoloszyn/received_events","type":"User","site_admin":false},"repo":{"id":84079818,"node_id":"MDEwOlJlcG9zaXRvcnk4NDA3OTgxOA==","name":"gapid","full_name":"AWoloszyn/gapid","private":false,"owner":{"login":"AWoloszyn","id":9043212,"node_id":"MDQ6VXNlcjkwNDMyMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/9043212?v=4","gravatar_id":"","url":"https://api.github.com/users/AWoloszyn","html_url":"https://github.com/AWoloszyn","followers_url":"https://api.github.com/users/AWoloszyn/followers","following_url":"https://api.github.com/users/AWoloszyn/following{/other_user}","gists_url":"https://api.github.com/users/AWoloszyn/gists{/gist_id}","starred_url":"https://api.github.com/users/AWoloszyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AWoloszyn/subscriptions","organizations_url":"https://api.github.com/users/AWoloszyn/orgs","repos_url":"https://api.github.com/users/AWoloszyn/repos","events_url":"https://api.github.com/users/AWoloszyn/events{/privacy}","received_events_url":"https://api.github.com/users/AWoloszyn/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AWoloszyn/gapid","description":"Graphics API Debugger","fork":true,"url":"https://api.github.com/repos/AWoloszyn/gapid","forks_url":"https://api.github.com/repos/AWoloszyn/gapid/forks","keys_url":"https://api.github.com/repos/AWoloszyn/gapid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AWoloszyn/gapid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AWoloszyn/gapid/teams","hooks_url":"https://api.github.com/repos/AWoloszyn/gapid/hooks","issue_events_url":"https://api.github.com/repos/AWoloszyn/gapid/issues/events{/number}","events_url":"https://api.github.com/repos/AWoloszyn/gapid/events","assignees_url":"https://api.github.com/repos/AWoloszyn/gapid/assignees{/user}","branches_url":"https://api.github.com/repos/AWoloszyn/gapid/branches{/branch}","tags_url":"https://api.github.com/repos/AWoloszyn/gapid/tags","blobs_url":"https://api.github.com/repos/AWoloszyn/gapid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AWoloszyn/gapid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AWoloszyn/gapid/git/refs{/sha}","trees_url":"https://api.github.com/repos/AWoloszyn/gapid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AWoloszyn/gapid/statuses/{sha}","languages_url":"https://api.github.com/repos/AWoloszyn/gapid/languages","stargazers_url":"https://api.github.com/repos/AWoloszyn/gapid/stargazers","contributors_url":"https://api.github.com/repos/AWoloszyn/gapid/contributors","subscribers_url":"https://api.github.com/repos/AWoloszyn/gapid/subscribers","subscription_url":"https://api.github.com/repos/AWoloszyn/gapid/subscription","commits_url":"https://api.github.com/repos/AWoloszyn/gapid/commits{/sha}","git_commits_url":"https://api.github.com/repos/AWoloszyn/gapid/git/commits{/sha}","comments_url":"https://api.github.com/repos/AWoloszyn/gapid/comments{/number}","issue_comment_url":"https://api.github.com/repos/AWoloszyn/gapid/issues/comments{/number}","contents_url":"https://api.github.com/repos/AWoloszyn/gapid/contents/{+path}","compare_url":"https://api.github.com/repos/AWoloszyn/gapid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AWoloszyn/gapid/merges","archive_url":"https://api.github.com/repos/AWoloszyn/gapid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AWoloszyn/gapid/downloads","issues_url":"https://api.github.com/repos/AWoloszyn/gapid/issues{/number}","pulls_url":"https://api.github.com/repos/AWoloszyn/gapid/pulls{/number}","milestones_url":"https://api.github.com/repos/AWoloszyn/gapid/milestones{/number}","notifications_url":"https://api.github.com/repos/AWoloszyn/gapid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AWoloszyn/gapid/labels{/name}","releases_url":"https://api.github.com/repos/AWoloszyn/gapid/releases{/id}","deployments_url":"https://api.github.com/repos/AWoloszyn/gapid/deployments","created_at":"2017-03-06T14:01:20Z","updated_at":"2017-03-06T14:01:26Z","pushed_at":"2019-01-03T20:12:03Z","git_url":"git://github.com/AWoloszyn/gapid.git","ssh_url":"git@github.com:AWoloszyn/gapid.git","clone_url":"https://github.com/AWoloszyn/gapid.git","svn_url":"https://github.com/AWoloszyn/gapid","homepage":"","size":72210,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"952804997643f59abb2e514a38a097d056ba045c","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":81937787,"node_id":"MDEwOlJlcG9zaXRvcnk4MTkzNzc4Nw==","name":"gapid","full_name":"google/gapid","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/gapid","description":"Graphics API Debugger","fork":false,"url":"https://api.github.com/repos/google/gapid","forks_url":"https://api.github.com/repos/google/gapid/forks","keys_url":"https://api.github.com/repos/google/gapid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/gapid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/gapid/teams","hooks_url":"https://api.github.com/repos/google/gapid/hooks","issue_events_url":"https://api.github.com/repos/google/gapid/issues/events{/number}","events_url":"https://api.github.com/repos/google/gapid/events","assignees_url":"https://api.github.com/repos/google/gapid/assignees{/user}","branches_url":"https://api.github.com/repos/google/gapid/branches{/branch}","tags_url":"https://api.github.com/repos/google/gapid/tags","blobs_url":"https://api.github.com/repos/google/gapid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/gapid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/gapid/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/gapid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/gapid/statuses/{sha}","languages_url":"https://api.github.com/repos/google/gapid/languages","stargazers_url":"https://api.github.com/repos/google/gapid/stargazers","contributors_url":"https://api.github.com/repos/google/gapid/contributors","subscribers_url":"https://api.github.com/repos/google/gapid/subscribers","subscription_url":"https://api.github.com/repos/google/gapid/subscription","commits_url":"https://api.github.com/repos/google/gapid/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/gapid/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/gapid/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/gapid/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/gapid/contents/{+path}","compare_url":"https://api.github.com/repos/google/gapid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/gapid/merges","archive_url":"https://api.github.com/repos/google/gapid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/gapid/downloads","issues_url":"https://api.github.com/repos/google/gapid/issues{/number}","pulls_url":"https://api.github.com/repos/google/gapid/pulls{/number}","milestones_url":"https://api.github.com/repos/google/gapid/milestones{/number}","notifications_url":"https://api.github.com/repos/google/gapid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/gapid/labels{/name}","releases_url":"https://api.github.com/repos/google/gapid/releases{/id}","deployments_url":"https://api.github.com/repos/google/gapid/deployments","created_at":"2017-02-14T11:18:43Z","updated_at":"2019-01-04T05:41:12Z","pushed_at":"2019-01-04T01:32:35Z","git_url":"git://github.com/google/gapid.git","ssh_url":"git@github.com:google/gapid.git","clone_url":"https://github.com/google/gapid.git","svn_url":"https://github.com/google/gapid","homepage":"","size":72248,"stargazers_count":1003,"watchers_count":1003,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":166,"mirror_url":null,"archived":false,"open_issues_count":188,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":166,"open_issues":188,"watchers":1003,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/gapid/pulls/2512"},"html":{"href":"https://github.com/google/gapid/pull/2512"},"issue":{"href":"https://api.github.com/repos/google/gapid/issues/2512"},"comments":{"href":"https://api.github.com/repos/google/gapid/issues/2512/comments"},"review_comments":{"href":"https://api.github.com/repos/google/gapid/pulls/2512/comments"},"review_comment":{"href":"https://api.github.com/repos/google/gapid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/gapid/pulls/2512/commits"},"statuses":{"href":"https://api.github.com/repos/google/gapid/statuses/64c72077f09cffb5f44b8d4e6239bf28d150ca12"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"AWoloszyn"}}