{"action":"created","comment":{"url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/comments/233284253","pull_request_review_id":174662468,"id":233284253,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzI4NDI1Mw==","diff_hunk":"@@ -205,32 +216,34 @@ def print_func(name, handle, statlist):\n             f.write(o)\n         f.write('}\\n')\n \n-    f.write('''\n+    if name != 'operation':\n+        f.write('''\n void\n __wt_stat_''' + name + '''_aggregate(\n     WT_''' + name.upper() + '_STATS **from, WT_' + name.upper() + '''_STATS *to)\n {\n ''')\n-    # Connection level aggregation does not currently have any computation\n-    # of a maximum value; I'm leaving in support for it, but don't declare\n-    # a temporary variable until it's needed.\n-    for l in statlist:\n-        if 'max_aggregate' in l.flags:\n-            f.write('\\tint64_t v;\\n\\n')\n-            break;\n-    for l in statlist:\n-        if 'max_aggregate' in l.flags:\n-            o = '\\tif ((v = WT_STAT_READ(from, ' + l.name + ')) > ' +\\\n-                'to->' + l.name + ')\\n'\n-            if len(o) > 72:             # Account for the leading tab.\n-                o = o.replace(' > ', ' >\\n\\t    ')\n-            o +='\\t\\tto->' + l.name + ' = v;\\n'\n-        else:\n-            o = '\\tto->' + l.name + ' += WT_STAT_READ(from, ' + l.name + ');\\n'\n-            if len(o) > 72:             # Account for the leading tab.\n-                o = o.replace(' += ', ' +=\\n\\t    ')\n-        f.write(o)\n-    f.write('}\\n')\n+        # Connection level aggregation does not currently have any computation","path":"dist/stat.py","position":75,"original_position":75,"commit_id":"a818b52cd409eb7eb8fe4489d5616fb771bf157f","original_commit_id":"a818b52cd409eb7eb8fe4489d5616fb771bf157f","user":{"login":"nehakhatri5","id":30581300,"node_id":"MDQ6VXNlcjMwNTgxMzAw","avatar_url":"https://avatars3.githubusercontent.com/u/30581300?v=4","gravatar_id":"","url":"https://api.github.com/users/nehakhatri5","html_url":"https://github.com/nehakhatri5","followers_url":"https://api.github.com/users/nehakhatri5/followers","following_url":"https://api.github.com/users/nehakhatri5/following{/other_user}","gists_url":"https://api.github.com/users/nehakhatri5/gists{/gist_id}","starred_url":"https://api.github.com/users/nehakhatri5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nehakhatri5/subscriptions","organizations_url":"https://api.github.com/users/nehakhatri5/orgs","repos_url":"https://api.github.com/users/nehakhatri5/repos","events_url":"https://api.github.com/users/nehakhatri5/events{/privacy}","received_events_url":"https://api.github.com/users/nehakhatri5/received_events","type":"User","site_admin":false},"body":"Yes it is intentional, we do not want the `*_aggregate()` function for the new stat, so this function definition is conditional at line #219.","created_at":"2018-11-14T01:18:50Z","updated_at":"2018-11-14T01:18:50Z","html_url":"https://github.com/wiredtiger/wiredtiger/pull/4359#discussion_r233284253","pull_request_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/4359","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/comments/233284253"},"html":{"href":"https://github.com/wiredtiger/wiredtiger/pull/4359#discussion_r233284253"},"pull_request":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/4359"}},"in_reply_to_id":233247295},"pull_request":{"url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/4359","id":230358289,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMzU4Mjg5","html_url":"https://github.com/wiredtiger/wiredtiger/pull/4359","diff_url":"https://github.com/wiredtiger/wiredtiger/pull/4359.diff","patch_url":"https://github.com/wiredtiger/wiredtiger/pull/4359.patch","issue_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/4359","number":4359,"state":"open","locked":false,"title":"WT-4378 Create new auto functions and cursor for the session level statistics.","user":{"login":"nehakhatri5","id":30581300,"node_id":"MDQ6VXNlcjMwNTgxMzAw","avatar_url":"https://avatars3.githubusercontent.com/u/30581300?v=4","gravatar_id":"","url":"https://api.github.com/users/nehakhatri5","html_url":"https://github.com/nehakhatri5","followers_url":"https://api.github.com/users/nehakhatri5/followers","following_url":"https://api.github.com/users/nehakhatri5/following{/other_user}","gists_url":"https://api.github.com/users/nehakhatri5/gists{/gist_id}","starred_url":"https://api.github.com/users/nehakhatri5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nehakhatri5/subscriptions","organizations_url":"https://api.github.com/users/nehakhatri5/orgs","repos_url":"https://api.github.com/users/nehakhatri5/repos","events_url":"https://api.github.com/users/nehakhatri5/events{/privacy}","received_events_url":"https://api.github.com/users/nehakhatri5/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-13T06:07:35Z","updated_at":"2018-11-14T01:18:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e593436e89f43afd9ec5153a571df6ab964f0db7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/4359/commits","review_comments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/4359/comments","review_comment_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/4359/comments","statuses_url":"https://api.github.com/repos/wiredtiger/wiredtiger/statuses/a818b52cd409eb7eb8fe4489d5616fb771bf157f","head":{"label":"wiredtiger:wt-4378-new-stats-funcs-cur","ref":"wt-4378-new-stats-funcs-cur","sha":"a818b52cd409eb7eb8fe4489d5616fb771bf157f","user":{"login":"wiredtiger","id":1251095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTEwOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1251095?v=4","gravatar_id":"","url":"https://api.github.com/users/wiredtiger","html_url":"https://github.com/wiredtiger","followers_url":"https://api.github.com/users/wiredtiger/followers","following_url":"https://api.github.com/users/wiredtiger/following{/other_user}","gists_url":"https://api.github.com/users/wiredtiger/gists{/gist_id}","starred_url":"https://api.github.com/users/wiredtiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiredtiger/subscriptions","organizations_url":"https://api.github.com/users/wiredtiger/orgs","repos_url":"https://api.github.com/users/wiredtiger/repos","events_url":"https://api.github.com/users/wiredtiger/events{/privacy}","received_events_url":"https://api.github.com/users/wiredtiger/received_events","type":"Organization","site_admin":false},"repo":{"id":2944302,"node_id":"MDEwOlJlcG9zaXRvcnkyOTQ0MzAy","name":"wiredtiger","full_name":"wiredtiger/wiredtiger","private":false,"owner":{"login":"wiredtiger","id":1251095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTEwOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1251095?v=4","gravatar_id":"","url":"https://api.github.com/users/wiredtiger","html_url":"https://github.com/wiredtiger","followers_url":"https://api.github.com/users/wiredtiger/followers","following_url":"https://api.github.com/users/wiredtiger/following{/other_user}","gists_url":"https://api.github.com/users/wiredtiger/gists{/gist_id}","starred_url":"https://api.github.com/users/wiredtiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiredtiger/subscriptions","organizations_url":"https://api.github.com/users/wiredtiger/orgs","repos_url":"https://api.github.com/users/wiredtiger/repos","events_url":"https://api.github.com/users/wiredtiger/events{/privacy}","received_events_url":"https://api.github.com/users/wiredtiger/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wiredtiger/wiredtiger","description":"WiredTiger's source tree","fork":false,"url":"https://api.github.com/repos/wiredtiger/wiredtiger","forks_url":"https://api.github.com/repos/wiredtiger/wiredtiger/forks","keys_url":"https://api.github.com/repos/wiredtiger/wiredtiger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wiredtiger/wiredtiger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wiredtiger/wiredtiger/teams","hooks_url":"https://api.github.com/repos/wiredtiger/wiredtiger/hooks","issue_events_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/events{/number}","events_url":"https://api.github.com/repos/wiredtiger/wiredtiger/events","assignees_url":"https://api.github.com/repos/wiredtiger/wiredtiger/assignees{/user}","branches_url":"https://api.github.com/repos/wiredtiger/wiredtiger/branches{/branch}","tags_url":"https://api.github.com/repos/wiredtiger/wiredtiger/tags","blobs_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/refs{/sha}","trees_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wiredtiger/wiredtiger/statuses/{sha}","languages_url":"https://api.github.com/repos/wiredtiger/wiredtiger/languages","stargazers_url":"https://api.github.com/repos/wiredtiger/wiredtiger/stargazers","contributors_url":"https://api.github.com/repos/wiredtiger/wiredtiger/contributors","subscribers_url":"https://api.github.com/repos/wiredtiger/wiredtiger/subscribers","subscription_url":"https://api.github.com/repos/wiredtiger/wiredtiger/subscription","commits_url":"https://api.github.com/repos/wiredtiger/wiredtiger/commits{/sha}","git_commits_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/commits{/sha}","comments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/comments{/number}","issue_comment_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/comments{/number}","contents_url":"https://api.github.com/repos/wiredtiger/wiredtiger/contents/{+path}","compare_url":"https://api.github.com/repos/wiredtiger/wiredtiger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wiredtiger/wiredtiger/merges","archive_url":"https://api.github.com/repos/wiredtiger/wiredtiger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wiredtiger/wiredtiger/downloads","issues_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues{/number}","pulls_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls{/number}","milestones_url":"https://api.github.com/repos/wiredtiger/wiredtiger/milestones{/number}","notifications_url":"https://api.github.com/repos/wiredtiger/wiredtiger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wiredtiger/wiredtiger/labels{/name}","releases_url":"https://api.github.com/repos/wiredtiger/wiredtiger/releases{/id}","deployments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/deployments","created_at":"2011-12-09T00:43:19Z","updated_at":"2018-11-13T17:31:41Z","pushed_at":"2018-11-13T20:28:29Z","git_url":"git://github.com/wiredtiger/wiredtiger.git","ssh_url":"git@github.com:wiredtiger/wiredtiger.git","clone_url":"https://github.com/wiredtiger/wiredtiger.git","svn_url":"https://github.com/wiredtiger/wiredtiger","homepage":"http://source.wiredtiger.com/","size":83849,"stargazers_count":1270,"watchers_count":1270,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":214,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":214,"open_issues":9,"watchers":1270,"default_branch":"master"}},"base":{"label":"wiredtiger:develop","ref":"develop","sha":"849c21c26c879bb1195f211b63bdea74868094ea","user":{"login":"wiredtiger","id":1251095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTEwOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1251095?v=4","gravatar_id":"","url":"https://api.github.com/users/wiredtiger","html_url":"https://github.com/wiredtiger","followers_url":"https://api.github.com/users/wiredtiger/followers","following_url":"https://api.github.com/users/wiredtiger/following{/other_user}","gists_url":"https://api.github.com/users/wiredtiger/gists{/gist_id}","starred_url":"https://api.github.com/users/wiredtiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiredtiger/subscriptions","organizations_url":"https://api.github.com/users/wiredtiger/orgs","repos_url":"https://api.github.com/users/wiredtiger/repos","events_url":"https://api.github.com/users/wiredtiger/events{/privacy}","received_events_url":"https://api.github.com/users/wiredtiger/received_events","type":"Organization","site_admin":false},"repo":{"id":2944302,"node_id":"MDEwOlJlcG9zaXRvcnkyOTQ0MzAy","name":"wiredtiger","full_name":"wiredtiger/wiredtiger","private":false,"owner":{"login":"wiredtiger","id":1251095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTEwOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1251095?v=4","gravatar_id":"","url":"https://api.github.com/users/wiredtiger","html_url":"https://github.com/wiredtiger","followers_url":"https://api.github.com/users/wiredtiger/followers","following_url":"https://api.github.com/users/wiredtiger/following{/other_user}","gists_url":"https://api.github.com/users/wiredtiger/gists{/gist_id}","starred_url":"https://api.github.com/users/wiredtiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiredtiger/subscriptions","organizations_url":"https://api.github.com/users/wiredtiger/orgs","repos_url":"https://api.github.com/users/wiredtiger/repos","events_url":"https://api.github.com/users/wiredtiger/events{/privacy}","received_events_url":"https://api.github.com/users/wiredtiger/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wiredtiger/wiredtiger","description":"WiredTiger's source tree","fork":false,"url":"https://api.github.com/repos/wiredtiger/wiredtiger","forks_url":"https://api.github.com/repos/wiredtiger/wiredtiger/forks","keys_url":"https://api.github.com/repos/wiredtiger/wiredtiger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wiredtiger/wiredtiger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wiredtiger/wiredtiger/teams","hooks_url":"https://api.github.com/repos/wiredtiger/wiredtiger/hooks","issue_events_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/events{/number}","events_url":"https://api.github.com/repos/wiredtiger/wiredtiger/events","assignees_url":"https://api.github.com/repos/wiredtiger/wiredtiger/assignees{/user}","branches_url":"https://api.github.com/repos/wiredtiger/wiredtiger/branches{/branch}","tags_url":"https://api.github.com/repos/wiredtiger/wiredtiger/tags","blobs_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/refs{/sha}","trees_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wiredtiger/wiredtiger/statuses/{sha}","languages_url":"https://api.github.com/repos/wiredtiger/wiredtiger/languages","stargazers_url":"https://api.github.com/repos/wiredtiger/wiredtiger/stargazers","contributors_url":"https://api.github.com/repos/wiredtiger/wiredtiger/contributors","subscribers_url":"https://api.github.com/repos/wiredtiger/wiredtiger/subscribers","subscription_url":"https://api.github.com/repos/wiredtiger/wiredtiger/subscription","commits_url":"https://api.github.com/repos/wiredtiger/wiredtiger/commits{/sha}","git_commits_url":"https://api.github.com/repos/wiredtiger/wiredtiger/git/commits{/sha}","comments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/comments{/number}","issue_comment_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/comments{/number}","contents_url":"https://api.github.com/repos/wiredtiger/wiredtiger/contents/{+path}","compare_url":"https://api.github.com/repos/wiredtiger/wiredtiger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wiredtiger/wiredtiger/merges","archive_url":"https://api.github.com/repos/wiredtiger/wiredtiger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wiredtiger/wiredtiger/downloads","issues_url":"https://api.github.com/repos/wiredtiger/wiredtiger/issues{/number}","pulls_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls{/number}","milestones_url":"https://api.github.com/repos/wiredtiger/wiredtiger/milestones{/number}","notifications_url":"https://api.github.com/repos/wiredtiger/wiredtiger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wiredtiger/wiredtiger/labels{/name}","releases_url":"https://api.github.com/repos/wiredtiger/wiredtiger/releases{/id}","deployments_url":"https://api.github.com/repos/wiredtiger/wiredtiger/deployments","created_at":"2011-12-09T00:43:19Z","updated_at":"2018-11-13T17:31:41Z","pushed_at":"2018-11-13T20:28:29Z","git_url":"git://github.com/wiredtiger/wiredtiger.git","ssh_url":"git@github.com:wiredtiger/wiredtiger.git","clone_url":"https://github.com/wiredtiger/wiredtiger.git","svn_url":"https://github.com/wiredtiger/wiredtiger","homepage":"http://source.wiredtiger.com/","size":83849,"stargazers_count":1270,"watchers_count":1270,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":214,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":214,"open_issues":9,"watchers":1270,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/4359"},"html":{"href":"https://github.com/wiredtiger/wiredtiger/pull/4359"},"issue":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/4359"},"comments":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/issues/4359/comments"},"review_comments":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/4359/comments"},"review_comment":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/4359/commits"},"statuses":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/statuses/a818b52cd409eb7eb8fe4489d5616fb771bf157f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nehakhatri5"}}