{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/236902486","pull_request_review_id":179077639,"id":236902486,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjkwMjQ4Ng==","diff_hunk":"@@ -788,24 +788,12 @@ GenTree* Compiler::impHWIntrinsic(NamedIntrinsic        intrinsic,\n         }\n     }\n \n-    if ((HWIntrinsicInfo::IsOneTypeGeneric(intrinsic) || HWIntrinsicInfo::IsTwoTypeGeneric(intrinsic)) &&\n-        !HWIntrinsicInfo::HasSpecialImport(intrinsic))\n+    if (HWIntrinsicInfo::IsOneTypeGeneric(intrinsic) && !HWIntrinsicInfo::HasSpecialImport(intrinsic))","path":"src/jit/hwintrinsicxarch.cpp","position":6,"original_position":6,"commit_id":"61504851a6cba4fa4a902897b6acef252c63888d","original_commit_id":"61504851a6cba4fa4a902897b6acef252c63888d","user":{"login":"tannergooding","id":10487869,"node_id":"MDQ6VXNlcjEwNDg3ODY5","avatar_url":"https://avatars3.githubusercontent.com/u/10487869?v=4","gravatar_id":"","url":"https://api.github.com/users/tannergooding","html_url":"https://github.com/tannergooding","followers_url":"https://api.github.com/users/tannergooding/followers","following_url":"https://api.github.com/users/tannergooding/following{/other_user}","gists_url":"https://api.github.com/users/tannergooding/gists{/gist_id}","starred_url":"https://api.github.com/users/tannergooding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tannergooding/subscriptions","organizations_url":"https://api.github.com/users/tannergooding/orgs","repos_url":"https://api.github.com/users/tannergooding/repos","events_url":"https://api.github.com/users/tannergooding/events{/privacy}","received_events_url":"https://api.github.com/users/tannergooding/received_events","type":"User","site_admin":false},"body":"I'll remove that in a follow-up PR, after confirming that all the generic functions have been finally removed (when I started on this PR, we still had some non-helper methods which were generic, but which I think have since been exploded).","created_at":"2018-11-28T00:38:23Z","updated_at":"2018-11-28T00:38:23Z","html_url":"https://github.com/dotnet/coreclr/pull/21198#discussion_r236902486","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/21198","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/236902486"},"html":{"href":"https://github.com/dotnet/coreclr/pull/21198#discussion_r236902486"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/21198"}},"in_reply_to_id":236900635},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/21198","id":233684180,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNjg0MTgw","html_url":"https://github.com/dotnet/coreclr/pull/21198","diff_url":"https://github.com/dotnet/coreclr/pull/21198.diff","patch_url":"https://github.com/dotnet/coreclr/pull/21198.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/21198","number":21198,"state":"open","locked":false,"title":"Implement the S.R.I.VectorXXX `get_Zero` and `As` helper methods as JIT intrinsics","user":{"login":"tannergooding","id":10487869,"node_id":"MDQ6VXNlcjEwNDg3ODY5","avatar_url":"https://avatars3.githubusercontent.com/u/10487869?v=4","gravatar_id":"","url":"https://api.github.com/users/tannergooding","html_url":"https://github.com/tannergooding","followers_url":"https://api.github.com/users/tannergooding/followers","following_url":"https://api.github.com/users/tannergooding/following{/other_user}","gists_url":"https://api.github.com/users/tannergooding/gists{/gist_id}","starred_url":"https://api.github.com/users/tannergooding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tannergooding/subscriptions","organizations_url":"https://api.github.com/users/tannergooding/orgs","repos_url":"https://api.github.com/users/tannergooding/repos","events_url":"https://api.github.com/users/tannergooding/events{/privacy}","received_events_url":"https://api.github.com/users/tannergooding/received_events","type":"User","site_admin":false},"body":"CC. @CarolEidt, @fiigii, @eerhardt \r\n\r\nThis is just the first two. Still need to implement `CreateScalarUnsafe` and `ToVector256Unsafe` as JIT intrinsics, the other helper methods should be able to be implemented in managed code using intrinsics.","created_at":"2018-11-26T20:19:43Z","updated_at":"2018-11-28T00:38:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d2ddf1dfaf742fa708db5ea1e1957fe5031924a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/21198/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/21198/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/21198/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/61504851a6cba4fa4a902897b6acef252c63888d","head":{"label":"tannergooding:helper-intrinsics","ref":"helper-intrinsics","sha":"61504851a6cba4fa4a902897b6acef252c63888d","user":{"login":"tannergooding","id":10487869,"node_id":"MDQ6VXNlcjEwNDg3ODY5","avatar_url":"https://avatars3.githubusercontent.com/u/10487869?v=4","gravatar_id":"","url":"https://api.github.com/users/tannergooding","html_url":"https://github.com/tannergooding","followers_url":"https://api.github.com/users/tannergooding/followers","following_url":"https://api.github.com/users/tannergooding/following{/other_user}","gists_url":"https://api.github.com/users/tannergooding/gists{/gist_id}","starred_url":"https://api.github.com/users/tannergooding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tannergooding/subscriptions","organizations_url":"https://api.github.com/users/tannergooding/orgs","repos_url":"https://api.github.com/users/tannergooding/repos","events_url":"https://api.github.com/users/tannergooding/events{/privacy}","received_events_url":"https://api.github.com/users/tannergooding/received_events","type":"User","site_admin":false},"repo":{"id":32194373,"node_id":"MDEwOlJlcG9zaXRvcnkzMjE5NDM3Mw==","name":"coreclr","full_name":"tannergooding/coreclr","private":false,"owner":{"login":"tannergooding","id":10487869,"node_id":"MDQ6VXNlcjEwNDg3ODY5","avatar_url":"https://avatars3.githubusercontent.com/u/10487869?v=4","gravatar_id":"","url":"https://api.github.com/users/tannergooding","html_url":"https://github.com/tannergooding","followers_url":"https://api.github.com/users/tannergooding/followers","following_url":"https://api.github.com/users/tannergooding/following{/other_user}","gists_url":"https://api.github.com/users/tannergooding/gists{/gist_id}","starred_url":"https://api.github.com/users/tannergooding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tannergooding/subscriptions","organizations_url":"https://api.github.com/users/tannergooding/orgs","repos_url":"https://api.github.com/users/tannergooding/repos","events_url":"https://api.github.com/users/tannergooding/events{/privacy}","received_events_url":"https://api.github.com/users/tannergooding/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tannergooding/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/tannergooding/coreclr","forks_url":"https://api.github.com/repos/tannergooding/coreclr/forks","keys_url":"https://api.github.com/repos/tannergooding/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tannergooding/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tannergooding/coreclr/teams","hooks_url":"https://api.github.com/repos/tannergooding/coreclr/hooks","issue_events_url":"https://api.github.com/repos/tannergooding/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/tannergooding/coreclr/events","assignees_url":"https://api.github.com/repos/tannergooding/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/tannergooding/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/tannergooding/coreclr/tags","blobs_url":"https://api.github.com/repos/tannergooding/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tannergooding/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tannergooding/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/tannergooding/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tannergooding/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/tannergooding/coreclr/languages","stargazers_url":"https://api.github.com/repos/tannergooding/coreclr/stargazers","contributors_url":"https://api.github.com/repos/tannergooding/coreclr/contributors","subscribers_url":"https://api.github.com/repos/tannergooding/coreclr/subscribers","subscription_url":"https://api.github.com/repos/tannergooding/coreclr/subscription","commits_url":"https://api.github.com/repos/tannergooding/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/tannergooding/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/tannergooding/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/tannergooding/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/tannergooding/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/tannergooding/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tannergooding/coreclr/merges","archive_url":"https://api.github.com/repos/tannergooding/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tannergooding/coreclr/downloads","issues_url":"https://api.github.com/repos/tannergooding/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/tannergooding/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/tannergooding/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/tannergooding/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tannergooding/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/tannergooding/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/tannergooding/coreclr/deployments","created_at":"2015-03-14T03:37:19Z","updated_at":"2018-11-20T22:59:08Z","pushed_at":"2018-11-27T19:18:13Z","git_url":"git://github.com/tannergooding/coreclr.git","ssh_url":"git@github.com:tannergooding/coreclr.git","clone_url":"https://github.com/tannergooding/coreclr.git","svn_url":"https://github.com/tannergooding/coreclr","homepage":"","size":252154,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"2fa65846af4b98293b407656fa7d0837c390215f","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"node_id":"MDEwOlJlcG9zaXRvcnkzMDA5Mjg5Mw==","name":"coreclr","full_name":"dotnet/coreclr","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called System.Private.Corelib (or mscorlib). It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2018-11-28T00:33:44Z","pushed_at":"2018-11-28T00:33:26Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://github.com/dotnet/core","size":256678,"stargazers_count":10545,"watchers_count":10545,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2517,"mirror_url":null,"archived":false,"open_issues_count":2052,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2517,"open_issues":2052,"watchers":10545,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/21198"},"html":{"href":"https://github.com/dotnet/coreclr/pull/21198"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/21198"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/21198/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/21198/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/21198/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/61504851a6cba4fa4a902897b6acef252c63888d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tannergooding"}}