{"action":"created","comment":{"url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/pulls/comments/235122826","pull_request_review_id":176916870,"id":235122826,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTEyMjgyNg==","diff_hunk":"@@ -8,15 +8,55 @@ describe('RequestHandler', () => {\n     requestHandler = new RequestHandler();\n   });\n \n+  /*it('should return the correct response body with height for blocks last request', async () => {\n+    const expectedResponse: Response = {\n+      status: ResponseStatus.Succeeded,\n+      body: {\n+        'blockNumber': 1444118,\n+        'blockHash': '00000000000000c0e5f7ef7f5e7ff8bd61b41e04db4035ec7be67a59c50cbb64'\n+      }\n+    };\n+\n+    const fetchedResponse = await requestHandler.handleLastBlockRequest();\n+    console.info(fetchedResponse);\n+    expect(expectedResponse).toEqual(fetchedResponse);\n+  });*/\n+\n+  it('should return the correct response body with height for blocks request', async () => {","path":"tests/RequestHandler.spec.ts","position":18,"original_position":18,"commit_id":"5ef438b9b3898d86327484fc1163a4e8156004de","original_commit_id":"5ef438b9b3898d86327484fc1163a4e8156004de","user":{"login":"thehenrytsai","id":17891086,"node_id":"MDQ6VXNlcjE3ODkxMDg2","avatar_url":"https://avatars0.githubusercontent.com/u/17891086?v=4","gravatar_id":"","url":"https://api.github.com/users/thehenrytsai","html_url":"https://github.com/thehenrytsai","followers_url":"https://api.github.com/users/thehenrytsai/followers","following_url":"https://api.github.com/users/thehenrytsai/following{/other_user}","gists_url":"https://api.github.com/users/thehenrytsai/gists{/gist_id}","starred_url":"https://api.github.com/users/thehenrytsai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thehenrytsai/subscriptions","organizations_url":"https://api.github.com/users/thehenrytsai/orgs","repos_url":"https://api.github.com/users/thehenrytsai/repos","events_url":"https://api.github.com/users/thehenrytsai/events{/privacy}","received_events_url":"https://api.github.com/users/thehenrytsai/received_events","type":"User","site_admin":false},"body":"The added tests appear to be integration tests (which will be useful too), but unit tests are what's normally expected, there are more work to be done even if these integration tests are to be accepted. Such as:\r\n\r\n1. Test data injection.\r\n1. bitcored endpoint configuration.\r\n\r\nAt very least create issues to track this.","created_at":"2018-11-20T18:39:44Z","updated_at":"2018-11-20T18:39:44Z","html_url":"https://github.com/decentralized-identity/sidetree-bitcoin/pull/3#discussion_r235122826","pull_request_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/pulls/3","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/pulls/comments/235122826"},"html":{"href":"https://github.com/decentralized-identity/sidetree-bitcoin/pull/3#discussion_r235122826"},"pull_request":{"href":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/pulls/3","id":232097304,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMDk3MzA0","html_url":"https://github.com/decentralized-identity/sidetree-bitcoin/pull/3","diff_url":"https://github.com/decentralized-identity/sidetree-bitcoin/pull/3.diff","patch_url":"https://github.com/decentralized-identity/sidetree-bitcoin/pull/3.patch","issue_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/issues/3","number":3,"state":"open","locked":false,"title":"Back-end services","user":{"login":"srinathsetty","id":14947526,"node_id":"MDQ6VXNlcjE0OTQ3NTI2","avatar_url":"https://avatars2.githubusercontent.com/u/14947526?v=4","gravatar_id":"","url":"https://api.github.com/users/srinathsetty","html_url":"https://github.com/srinathsetty","followers_url":"https://api.github.com/users/srinathsetty/followers","following_url":"https://api.github.com/users/srinathsetty/following{/other_user}","gists_url":"https://api.github.com/users/srinathsetty/gists{/gist_id}","starred_url":"https://api.github.com/users/srinathsetty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srinathsetty/subscriptions","organizations_url":"https://api.github.com/users/srinathsetty/orgs","repos_url":"https://api.github.com/users/srinathsetty/repos","events_url":"https://api.github.com/users/srinathsetty/events{/privacy}","received_events_url":"https://api.github.com/users/srinathsetty/received_events","type":"User","site_admin":false},"body":"This pull request contains an end-to-end implementation the back-end services for the following REST APIs of the blockchain service layer: /transactions, /blocks/:hash, and /blocks/last.","created_at":"2018-11-19T20:10:32Z","updated_at":"2018-11-20T18:39:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44e0011ebe0572bbd1e2e2b49ea15702ed42b46d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"csuwildcat","id":131786,"node_id":"MDQ6VXNlcjEzMTc4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/131786?v=4","gravatar_id":"","url":"https://api.github.com/users/csuwildcat","html_url":"https://github.com/csuwildcat","followers_url":"https://api.github.com/users/csuwildcat/followers","following_url":"https://api.github.com/users/csuwildcat/following{/other_user}","gists_url":"https://api.github.com/users/csuwildcat/gists{/gist_id}","starred_url":"https://api.github.com/users/csuwildcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csuwildcat/subscriptions","organizations_url":"https://api.github.com/users/csuwildcat/orgs","repos_url":"https://api.github.com/users/csuwildcat/repos","events_url":"https://api.github.com/users/csuwildcat/events{/privacy}","received_events_url":"https://api.github.com/users/csuwildcat/received_events","type":"User","site_admin":false},{"login":"arvinda","id":4951270,"node_id":"MDQ6VXNlcjQ5NTEyNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/4951270?v=4","gravatar_id":"","url":"https://api.github.com/users/arvinda","html_url":"https://github.com/arvinda","followers_url":"https://api.github.com/users/arvinda/followers","following_url":"https://api.github.com/users/arvinda/following{/other_user}","gists_url":"https://api.github.com/users/arvinda/gists{/gist_id}","starred_url":"https://api.github.com/users/arvinda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvinda/subscriptions","organizations_url":"https://api.github.com/users/arvinda/orgs","repos_url":"https://api.github.com/users/arvinda/repos","events_url":"https://api.github.com/users/arvinda/events{/privacy}","received_events_url":"https://api.github.com/users/arvinda/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/pulls/3/commits","review_comments_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/pulls/3/comments","review_comment_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/issues/3/comments","statuses_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/statuses/5ef438b9b3898d86327484fc1163a4e8156004de","head":{"label":"decentralized-identity:backend","ref":"backend","sha":"5ef438b9b3898d86327484fc1163a4e8156004de","user":{"login":"decentralized-identity","id":23265915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjY1OTE1","avatar_url":"https://avatars3.githubusercontent.com/u/23265915?v=4","gravatar_id":"","url":"https://api.github.com/users/decentralized-identity","html_url":"https://github.com/decentralized-identity","followers_url":"https://api.github.com/users/decentralized-identity/followers","following_url":"https://api.github.com/users/decentralized-identity/following{/other_user}","gists_url":"https://api.github.com/users/decentralized-identity/gists{/gist_id}","starred_url":"https://api.github.com/users/decentralized-identity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decentralized-identity/subscriptions","organizations_url":"https://api.github.com/users/decentralized-identity/orgs","repos_url":"https://api.github.com/users/decentralized-identity/repos","events_url":"https://api.github.com/users/decentralized-identity/events{/privacy}","received_events_url":"https://api.github.com/users/decentralized-identity/received_events","type":"Organization","site_admin":false},"repo":{"id":147383135,"node_id":"MDEwOlJlcG9zaXRvcnkxNDczODMxMzU=","name":"sidetree-bitcoin","full_name":"decentralized-identity/sidetree-bitcoin","private":false,"owner":{"login":"decentralized-identity","id":23265915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjY1OTE1","avatar_url":"https://avatars3.githubusercontent.com/u/23265915?v=4","gravatar_id":"","url":"https://api.github.com/users/decentralized-identity","html_url":"https://github.com/decentralized-identity","followers_url":"https://api.github.com/users/decentralized-identity/followers","following_url":"https://api.github.com/users/decentralized-identity/following{/other_user}","gists_url":"https://api.github.com/users/decentralized-identity/gists{/gist_id}","starred_url":"https://api.github.com/users/decentralized-identity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decentralized-identity/subscriptions","organizations_url":"https://api.github.com/users/decentralized-identity/orgs","repos_url":"https://api.github.com/users/decentralized-identity/repos","events_url":"https://api.github.com/users/decentralized-identity/events{/privacy}","received_events_url":"https://api.github.com/users/decentralized-identity/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/decentralized-identity/sidetree-bitcoin","description":"Blockchain-specific code for the Sidetree-based DID Method implementation on Bitcoin","fork":false,"url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin","forks_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/forks","keys_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/teams","hooks_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/hooks","issue_events_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/events","assignees_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/tags","blobs_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/languages","stargazers_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/stargazers","contributors_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/contributors","subscribers_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/subscribers","subscription_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/subscription","commits_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/merges","archive_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/downloads","issues_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/deployments","created_at":"2018-09-04T17:28:18Z","updated_at":"2018-11-01T01:16:50Z","pushed_at":"2018-11-20T01:16:00Z","git_url":"git://github.com/decentralized-identity/sidetree-bitcoin.git","ssh_url":"git@github.com:decentralized-identity/sidetree-bitcoin.git","clone_url":"https://github.com/decentralized-identity/sidetree-bitcoin.git","svn_url":"https://github.com/decentralized-identity/sidetree-bitcoin","homepage":null,"size":85,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"decentralized-identity:master","ref":"master","sha":"0a2240c3076b9e7117b2cb0025d6dfaeee8fe6e6","user":{"login":"decentralized-identity","id":23265915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjY1OTE1","avatar_url":"https://avatars3.githubusercontent.com/u/23265915?v=4","gravatar_id":"","url":"https://api.github.com/users/decentralized-identity","html_url":"https://github.com/decentralized-identity","followers_url":"https://api.github.com/users/decentralized-identity/followers","following_url":"https://api.github.com/users/decentralized-identity/following{/other_user}","gists_url":"https://api.github.com/users/decentralized-identity/gists{/gist_id}","starred_url":"https://api.github.com/users/decentralized-identity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decentralized-identity/subscriptions","organizations_url":"https://api.github.com/users/decentralized-identity/orgs","repos_url":"https://api.github.com/users/decentralized-identity/repos","events_url":"https://api.github.com/users/decentralized-identity/events{/privacy}","received_events_url":"https://api.github.com/users/decentralized-identity/received_events","type":"Organization","site_admin":false},"repo":{"id":147383135,"node_id":"MDEwOlJlcG9zaXRvcnkxNDczODMxMzU=","name":"sidetree-bitcoin","full_name":"decentralized-identity/sidetree-bitcoin","private":false,"owner":{"login":"decentralized-identity","id":23265915,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjY1OTE1","avatar_url":"https://avatars3.githubusercontent.com/u/23265915?v=4","gravatar_id":"","url":"https://api.github.com/users/decentralized-identity","html_url":"https://github.com/decentralized-identity","followers_url":"https://api.github.com/users/decentralized-identity/followers","following_url":"https://api.github.com/users/decentralized-identity/following{/other_user}","gists_url":"https://api.github.com/users/decentralized-identity/gists{/gist_id}","starred_url":"https://api.github.com/users/decentralized-identity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decentralized-identity/subscriptions","organizations_url":"https://api.github.com/users/decentralized-identity/orgs","repos_url":"https://api.github.com/users/decentralized-identity/repos","events_url":"https://api.github.com/users/decentralized-identity/events{/privacy}","received_events_url":"https://api.github.com/users/decentralized-identity/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/decentralized-identity/sidetree-bitcoin","description":"Blockchain-specific code for the Sidetree-based DID Method implementation on Bitcoin","fork":false,"url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin","forks_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/forks","keys_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/teams","hooks_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/hooks","issue_events_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/events","assignees_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/tags","blobs_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/languages","stargazers_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/stargazers","contributors_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/contributors","subscribers_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/subscribers","subscription_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/subscription","commits_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/merges","archive_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/downloads","issues_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/deployments","created_at":"2018-09-04T17:28:18Z","updated_at":"2018-11-01T01:16:50Z","pushed_at":"2018-11-20T01:16:00Z","git_url":"git://github.com/decentralized-identity/sidetree-bitcoin.git","ssh_url":"git@github.com:decentralized-identity/sidetree-bitcoin.git","clone_url":"https://github.com/decentralized-identity/sidetree-bitcoin.git","svn_url":"https://github.com/decentralized-identity/sidetree-bitcoin","homepage":null,"size":85,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/pulls/3"},"html":{"href":"https://github.com/decentralized-identity/sidetree-bitcoin/pull/3"},"issue":{"href":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/issues/3"},"comments":{"href":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/decentralized-identity/sidetree-bitcoin/statuses/5ef438b9b3898d86327484fc1163a4e8156004de"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"thehenrytsai"}}