{"push_id":2505517512,"size":6,"distinct_size":6,"ref":"refs/heads/8685-instructor-search-page-add-tests-for-links-displayed-with-search-results","head":"835a6abdab35cb1f916843360c03c11d515783b3","before":"b5412d9c7d33d94a88052030d844c15f8439459f","commits":[{"sha":"2aba5e477b989f747661647e8427d48a716ea0ae","author":{"name":"Nashmia Riaz","email":"0a3a61eef8edd58af155f8839f54b20c39e3aa9a@hotmail.com"},"message":"[#8723] Instructor: Session Results: Comment box shrinks when canceling and adding comment again (#8724)","distinct":true,"url":"https://api.github.com/repos/dalessr/teammates/commits/2aba5e477b989f747661647e8427d48a716ea0ae"},{"sha":"ac3c4bfb73cec5016f39615a9ecc515bb3dc4fe1","author":{"name":"Haozhe321","email":"e3a1168180fdd2074d56f534e59afeaa3c3fe021@gmail.com"},"message":"[#7190] Use builder instead of telescoping constructor antipattern in FeedbackQuestionAttributes class (#8739)\n\n* Make Builder class\r\n\r\n* Replace instances of 2nd constructor for FeedbackQuestionAttributes\r\n\r\n* Modify copyOf\r\n\r\n* Modify builder methods for showResponse/GiverName/RecipientName\r\n\r\n* Modify FeedbackQuestionAttributesTest.java\r\n\r\n* Modify FeedbackQuestionDbTest.java\r\n\r\n* Modify FeedbackSessionsLogicTest.java\r\n\r\n* Change logic for getCopy()\r\n\r\n* Remove questionId from getcopy()\r\n\r\n* add testBuilderCopy()\r\n\r\n* Add testBuilderWithDefaultValues()\r\n\r\n* Fix style guide violation\r\n\r\n* Remove constructor in FeedbackQuestionAttribute and test for deep copy\r\n\r\n* Replace default constructor of FeedBackQuestionAttributes with builder instances\r\n\r\nIn InstructorFeedbackQuestionAddAction, InstructorFeedbackQuestionEditAction, InstructorFeedbackQuestionVisibilityMessageAction,\r\nreplace default constructor FeedBackQuestionAttributes with Builder instance.\r\nAdd overloaded method withQuestionMetaData(FeedbackQuestionDetails questionDetails) in Builder.\r\n\r\n* Add tests for FeedbackQuestionAttributes.test\r\n\r\n* Make constructor protected\r\n\r\n* Add condition to make sure builder method does not take in null value\r\n\r\n* Fix style guide violation\r\n\r\n* Add test for valueOf()\r\n\r\n* Implement test for valueOf(), and refactor code\r\n\r\n-Added the test for valueOf(), with the help of LocalServiceTestHelper to set up the environment for the unit testing.\r\n-Refactor InstructorFeedbackQuestionAddAction and InstructorFeedbackEditAction so that less lines are needed to check for\r\nnon-null parameters.\r\n-Added missing bits and pieces in various tests for Builder class\r\n-Change test in FeedbackQuestionsDbTest to use the new overloaded builder method in FeedbackQuestionAttributes\r\n\r\n* Remove copyOf() and corresponding test\r\n\r\n* Remove method buildWithoutVisibilityOption and change requestNonNullParamValue\r\n\r\nRemove the method buildWithoutVisibilityOption, replacing instances of it with build().\r\nMake corresponding changes to test.\r\nAlso change instance of requestParamValue to requestNonNullRequestValue\r\n\r\n* Fix style guide violation\r\n\r\n* Change implementation of test for valueOf()\r\n\r\nExtend BaseAttributesTest\r\nChange test for valueOf()\r\nAdd test for toEntity()\r\n\r\n* Add null check and shrink test for santisation\r\n\r\nAdd null check for methods removeIrrelevantVisibilityOptions() and removeVisibilities()\r\nShrink test for santisation to just check if it is called.\r\nChange createEntity() to createEntityWithoutExistenceCheck() so that the same Attribute can be used\r\nfor testing.","distinct":true,"url":"https://api.github.com/repos/dalessr/teammates/commits/ac3c4bfb73cec5016f39615a9ecc515bb3dc4fe1"},{"sha":"85810c67a7b79e15b8cc6fad8f44743348e49160","author":{"name":"Wen Xin","email":"422812b6deb28c33a19662d14ed66aed13115790@u.nus.edu"},"message":"Instructor: update on number of char left for Session Name input #8475 (#8476)\n\n* content:add js function and modify tags to display char left count\r\n\r\n* test: modify expected test data\r\n\r\n* style: remove one new line\r\n\r\n* content:add a place holder number for the char count\r\n\r\n* content:use js to add and update the char length update div in jsps\r\n\r\n* test:change expected test result using godmode\r\n\r\n* style: to satisfy lint\r\n\r\n* style:minor change to comment and module name\r\n\r\n* content/test:modify based on review given\r\n\r\n* style:to satisfy lint\r\n\r\n* test:modify expected result\r\n\r\n* style: remove unnecessary white space and css changes\r\n\r\n* style:rename the js file\r\n\r\n* content:fix typos and logic errors\r\n\r\n* content:rename the js file\r\n\r\n* style:fix typo\r\n\r\n* test:modify expected test data\r\n\r\n* content/test:modify display area html and corresponding test data","distinct":true,"url":"https://api.github.com/repos/dalessr/teammates/commits/85810c67a7b79e15b8cc6fad8f44743348e49160"},{"sha":"85ad8daa9b3f13b89a82a4fb15a0ece95319bcdd","author":{"name":"Pedro Lara Benitez","email":"d5b12501d7bda1d8ee3aceb5f5ea75b7cf2dfb99@gmail.com"},"message":"Use Java 8 map.putIfAbsent and map.computeIfAbsent #8215 (#8783)\n\n* change some methods to use java8 .putIfAbsent, .computeIfAbsent and .computeIfPresent\r\n\r\n* Fix code style\r\n\r\n* Change to make the code cleaner\r\n\r\n* Fix code style\r\n\r\n* Change in StaticsPerInstitute","distinct":true,"url":"https://api.github.com/repos/dalessr/teammates/commits/85ad8daa9b3f13b89a82a4fb15a0ece95319bcdd"},{"sha":"fa0e8ff2c6f8e9c504ed4eaefa1eb6c25e7e9c5f","author":{"name":"John Yong","email":"af36f6b9f1ecd0d2582b5246606cc7e74e3dcab2@gmail.com"},"message":"[#8800] Remove the need to specify application URL in build.properties (#8801)","distinct":true,"url":"https://api.github.com/repos/dalessr/teammates/commits/fa0e8ff2c6f8e9c504ed4eaefa1eb6c25e7e9c5f"},{"sha":"835a6abdab35cb1f916843360c03c11d515783b3","author":{"name":"John Yong","email":"af36f6b9f1ecd0d2582b5246606cc7e74e3dcab2@gmail.com"},"message":"Merge branch 'master' into 8685-instructor-search-page-add-tests-for-links-displayed-with-search-results","distinct":true,"url":"https://api.github.com/repos/dalessr/teammates/commits/835a6abdab35cb1f916843360c03c11d515783b3"}]}
{"actor":{"display_login":"whipermr5"}}