{"action":"created","issue":{"url":"https://api.github.com/repos/Haivision/srt/issues/269","repository_url":"https://api.github.com/repos/Haivision/srt","labels_url":"https://api.github.com/repos/Haivision/srt/issues/269/labels{/name}","comments_url":"https://api.github.com/repos/Haivision/srt/issues/269/comments","events_url":"https://api.github.com/repos/Haivision/srt/issues/269/events","html_url":"https://github.com/Haivision/srt/issues/269","id":294153132,"number":269,"title":"stransmit: EOF character to sender process with wrong passphrase ends receiver process ","user":{"login":"tbarron-xyz","id":20335115,"avatar_url":"https://avatars0.githubusercontent.com/u/20335115?v=4","gravatar_id":"","url":"https://api.github.com/users/tbarron-xyz","html_url":"https://github.com/tbarron-xyz","followers_url":"https://api.github.com/users/tbarron-xyz/followers","following_url":"https://api.github.com/users/tbarron-xyz/following{/other_user}","gists_url":"https://api.github.com/users/tbarron-xyz/gists{/gist_id}","starred_url":"https://api.github.com/users/tbarron-xyz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbarron-xyz/subscriptions","organizations_url":"https://api.github.com/users/tbarron-xyz/orgs","repos_url":"https://api.github.com/users/tbarron-xyz/repos","events_url":"https://api.github.com/users/tbarron-xyz/events{/privacy}","received_events_url":"https://api.github.com/users/tbarron-xyz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-03T23:09:13Z","updated_at":"2018-02-06T08:16:35Z","closed_at":null,"author_association":"NONE","body":"Steps to reproduce:\r\n\r\n* Terminal #1\r\n    * `stransmit srt://:49000?passphrase=abc file://con`\r\n* Terminal #2 \r\n    * `stransmit file://con srt://localhost:49000` (note no passphrase; wrong passphrase also produces this behavior)\r\n    * Press `Ctrl + D` to send an EOF character to the send\r\n* Terminal #1\r\n    * Observe that your stransmit process has exited\r\n\r\nExpected behavior: Receiver process does not exit unless the sender process has the correct passphrase.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Haivision/srt/issues/comments/363344310","html_url":"https://github.com/Haivision/srt/issues/269#issuecomment-363344310","issue_url":"https://api.github.com/repos/Haivision/srt/issues/269","id":363344310,"user":{"login":"ethouris","id":9600392,"avatar_url":"https://avatars0.githubusercontent.com/u/9600392?v=4","gravatar_id":"","url":"https://api.github.com/users/ethouris","html_url":"https://github.com/ethouris","followers_url":"https://api.github.com/users/ethouris/followers","following_url":"https://api.github.com/users/ethouris/following{/other_user}","gists_url":"https://api.github.com/users/ethouris/gists{/gist_id}","starred_url":"https://api.github.com/users/ethouris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethouris/subscriptions","organizations_url":"https://api.github.com/users/ethouris/orgs","repos_url":"https://api.github.com/users/ethouris/repos","events_url":"https://api.github.com/users/ethouris/events{/privacy}","received_events_url":"https://api.github.com/users/ethouris/received_events","type":"User","site_admin":false},"created_at":"2018-02-06T08:16:35Z","updated_at":"2018-02-06T08:16:35Z","author_association":"COLLABORATOR","body":"The stransmit application has grown up initially as a testing tool only. We are working currently on providing the stransmit application that is more suitable for users, and e.g. supports reconnecting and can be reliably interrupted. Note that the most \"fresh\" version is in `dev` branch, although we plan to merge it back to `master` soon.\r\n\r\nThe older version did not reject the connection on wrong passphrase because of the old handshake implementation, which actually did the connection handshake the old UDT-derived method, and any SRT extended things (which includes latency exchange and encryption) were done after the connection is established. The newest version contains the \"integrated handshake\", so the processing of encryption things are in the handshake, so error in this process causes connection to be rejected. Both sides must be version 1.3.0 at least, otherwise the process runs the old way. The SRTO_MINVERSION socket option can be used to reject connection when the peer's version is older than given one."}}
{"actor":{"display_login":"ethouris"}}