{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65186","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65186/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65186/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65186/events","html_url":"https://github.com/kubernetes/kubernetes/pull/65186","id":333325263,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NTY3ODIy","number":65186,"title":"Remove resources from system addon manifests","user":{"login":"vantuvt","id":37354032,"node_id":"MDQ6VXNlcjM3MzU0MDMy","avatar_url":"https://avatars3.githubusercontent.com/u/37354032?v=4","gravatar_id":"","url":"https://api.github.com/users/vantuvt","html_url":"https://github.com/vantuvt","followers_url":"https://api.github.com/users/vantuvt/followers","following_url":"https://api.github.com/users/vantuvt/following{/other_user}","gists_url":"https://api.github.com/users/vantuvt/gists{/gist_id}","starred_url":"https://api.github.com/users/vantuvt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vantuvt/subscriptions","organizations_url":"https://api.github.com/users/vantuvt/orgs","repos_url":"https://api.github.com/users/vantuvt/repos","events_url":"https://api.github.com/users/vantuvt/events{/privacy}","received_events_url":"https://api.github.com/users/vantuvt/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450934,"node_id":"MDU6TGFiZWwyNTM0NTA5MzQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":{"login":"bowei","id":837034,"node_id":"MDQ6VXNlcjgzNzAzNA==","avatar_url":"https://avatars1.githubusercontent.com/u/837034?v=4","gravatar_id":"","url":"https://api.github.com/users/bowei","html_url":"https://github.com/bowei","followers_url":"https://api.github.com/users/bowei/followers","following_url":"https://api.github.com/users/bowei/following{/other_user}","gists_url":"https://api.github.com/users/bowei/gists{/gist_id}","starred_url":"https://api.github.com/users/bowei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bowei/subscriptions","organizations_url":"https://api.github.com/users/bowei/orgs","repos_url":"https://api.github.com/users/bowei/repos","events_url":"https://api.github.com/users/bowei/events{/privacy}","received_events_url":"https://api.github.com/users/bowei/received_events","type":"User","site_admin":false},"assignees":[{"login":"bowei","id":837034,"node_id":"MDQ6VXNlcjgzNzAzNA==","avatar_url":"https://avatars1.githubusercontent.com/u/837034?v=4","gravatar_id":"","url":"https://api.github.com/users/bowei","html_url":"https://github.com/bowei","followers_url":"https://api.github.com/users/bowei/followers","following_url":"https://api.github.com/users/bowei/following{/other_user}","gists_url":"https://api.github.com/users/bowei/gists{/gist_id}","starred_url":"https://api.github.com/users/bowei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bowei/subscriptions","organizations_url":"https://api.github.com/users/bowei/orgs","repos_url":"https://api.github.com/users/bowei/repos","events_url":"https://api.github.com/users/bowei/events{/privacy}","received_events_url":"https://api.github.com/users/bowei/received_events","type":"User","site_admin":false},{"login":"kawych","id":1265228,"node_id":"MDQ6VXNlcjEyNjUyMjg=","avatar_url":"https://avatars3.githubusercontent.com/u/1265228?v=4","gravatar_id":"","url":"https://api.github.com/users/kawych","html_url":"https://github.com/kawych","followers_url":"https://api.github.com/users/kawych/followers","following_url":"https://api.github.com/users/kawych/following{/other_user}","gists_url":"https://api.github.com/users/kawych/gists{/gist_id}","starred_url":"https://api.github.com/users/kawych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kawych/subscriptions","organizations_url":"https://api.github.com/users/kawych/orgs","repos_url":"https://api.github.com/users/kawych/repos","events_url":"https://api.github.com/users/kawych/events{/privacy}","received_events_url":"https://api.github.com/users/kawych/received_events","type":"User","site_admin":false},{"login":"floreks","id":2285385,"node_id":"MDQ6VXNlcjIyODUzODU=","avatar_url":"https://avatars3.githubusercontent.com/u/2285385?v=4","gravatar_id":"","url":"https://api.github.com/users/floreks","html_url":"https://github.com/floreks","followers_url":"https://api.github.com/users/floreks/followers","following_url":"https://api.github.com/users/floreks/following{/other_user}","gists_url":"https://api.github.com/users/floreks/gists{/gist_id}","starred_url":"https://api.github.com/users/floreks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floreks/subscriptions","organizations_url":"https://api.github.com/users/floreks/orgs","repos_url":"https://api.github.com/users/floreks/repos","events_url":"https://api.github.com/users/floreks/events{/privacy}","received_events_url":"https://api.github.com/users/floreks/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-06-18T15:42:26Z","updated_at":"2018-06-19T15:06:20Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/65186","html_url":"https://github.com/kubernetes/kubernetes/pull/65186","diff_url":"https://github.com/kubernetes/kubernetes/pull/65186.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/65186.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nUpdate the setup-addon-manifests function to remove all fields contained\r\nwithin and including the BEGIN_RESOURCES and END_RESOURCES markers, which have\r\nbeen embedded as comments. The BEGIN_RESOURCE and END_RESOURCE markers were\r\nchosen to be consistent with existing markers, such as, BEGIN_PROMETHEUS_TO_SD\r\nand END_PROMETHEUS_TO_SD.\r\n\r\nThis logic is guarded by the ENABLE_SYSTEM_ADDON_VERTICAL_SCALING\r\nenvironment variable, which is set to false by default rendering this change\r\nbenign. The removal of resource-related fields is necessary to enable\r\nvertical scaling of system pods. Otherwise, the addon manager will undo\r\nany changes specified by a scaler whenever it reconciles an addon's\r\ndefinition.\r\n\r\nNote that not all system manifests have been updated. Additional\r\nfollow-up changes may be needed pending further testing.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/398433334","html_url":"https://github.com/kubernetes/kubernetes/pull/65186#issuecomment-398433334","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65186","id":398433334,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODQzMzMzNA==","user":{"login":"vantuvt","id":37354032,"node_id":"MDQ6VXNlcjM3MzU0MDMy","avatar_url":"https://avatars3.githubusercontent.com/u/37354032?v=4","gravatar_id":"","url":"https://api.github.com/users/vantuvt","html_url":"https://github.com/vantuvt","followers_url":"https://api.github.com/users/vantuvt/followers","following_url":"https://api.github.com/users/vantuvt/following{/other_user}","gists_url":"https://api.github.com/users/vantuvt/gists{/gist_id}","starred_url":"https://api.github.com/users/vantuvt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vantuvt/subscriptions","organizations_url":"https://api.github.com/users/vantuvt/orgs","repos_url":"https://api.github.com/users/vantuvt/repos","events_url":"https://api.github.com/users/vantuvt/events{/privacy}","received_events_url":"https://api.github.com/users/vantuvt/received_events","type":"User","site_admin":false},"created_at":"2018-06-19T15:06:20Z","updated_at":"2018-06-19T15:06:20Z","author_association":"CONTRIBUTOR","body":"I apologize if the way I've made the corrections doesn't follow best practices. I'm still learning what the proper workflow is for working with Github and the Kubernetes project. Please feel free to point me to docs describing best practices.\r\n\r\n@kawych - Thank you for catching the debug logging. That was only intended for dev testing purposes. It has been removed.\r\n\r\nI've also removed the changes to dashboard-controller.yaml as it was not necessary."}}
{"actor":{"display_login":"vantuvt"}}