{"action":"closed","number":4,"pull_request":{"url":"https://api.github.com/repos/singer-io/tap-bronto/pulls/4","id":184655857,"html_url":"https://github.com/singer-io/tap-bronto/pull/4","diff_url":"https://github.com/singer-io/tap-bronto/pull/4.diff","patch_url":"https://github.com/singer-io/tap-bronto/pull/4.patch","issue_url":"https://api.github.com/repos/singer-io/tap-bronto/issues/4","number":4,"state":"closed","locked":false,"title":"Use metadata to determine replication-method in sync mode","user":{"login":"dmosorast","id":30501696,"avatar_url":"https://avatars0.githubusercontent.com/u/30501696?v=4","gravatar_id":"","url":"https://api.github.com/users/dmosorast","html_url":"https://github.com/dmosorast","followers_url":"https://api.github.com/users/dmosorast/followers","following_url":"https://api.github.com/users/dmosorast/following{/other_user}","gists_url":"https://api.github.com/users/dmosorast/gists{/gist_id}","starred_url":"https://api.github.com/users/dmosorast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmosorast/subscriptions","organizations_url":"https://api.github.com/users/dmosorast/orgs","repos_url":"https://api.github.com/users/dmosorast/repos","events_url":"https://api.github.com/users/dmosorast/events{/privacy}","received_events_url":"https://api.github.com/users/dmosorast/received_events","type":"User","site_admin":false},"body":"This PR addresses an issue where the replication method is not discovered properly, resulting in this error:\r\n\r\n```\r\n2018-04-26 13:15:05,067Z    tap - ERROR Unknown replication method None!\r\n2018-04-26 13:15:05,067Z    tap - ERROR Failed to sync endpoint, moving on!\r\n```\r\n\r\nThis appears to have been an oversight in the metadata conversion of `selected`, `selected-by-default`, etc... The tap will now use metadata to find the replication method, as is the current standard.","created_at":"2018-04-27T15:31:20Z","updated_at":"2018-04-27T15:34:32Z","closed_at":"2018-04-27T15:34:32Z","merged_at":"2018-04-27T15:34:32Z","merge_commit_sha":"2ca17ab2cee26541c489ead0b0fbaa89af5caa76","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/singer-io/tap-bronto/pulls/4/commits","review_comments_url":"https://api.github.com/repos/singer-io/tap-bronto/pulls/4/comments","review_comment_url":"https://api.github.com/repos/singer-io/tap-bronto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/singer-io/tap-bronto/issues/4/comments","statuses_url":"https://api.github.com/repos/singer-io/tap-bronto/statuses/aa25088ac97e7e914464e9ef6a7d15bd2a62bfc6","head":{"label":"singer-io:fix/use-metadata-for-replication-method","ref":"fix/use-metadata-for-replication-method","sha":"aa25088ac97e7e914464e9ef6a7d15bd2a62bfc6","user":{"login":"singer-io","id":25538203,"avatar_url":"https://avatars0.githubusercontent.com/u/25538203?v=4","gravatar_id":"","url":"https://api.github.com/users/singer-io","html_url":"https://github.com/singer-io","followers_url":"https://api.github.com/users/singer-io/followers","following_url":"https://api.github.com/users/singer-io/following{/other_user}","gists_url":"https://api.github.com/users/singer-io/gists{/gist_id}","starred_url":"https://api.github.com/users/singer-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singer-io/subscriptions","organizations_url":"https://api.github.com/users/singer-io/orgs","repos_url":"https://api.github.com/users/singer-io/repos","events_url":"https://api.github.com/users/singer-io/events{/privacy}","received_events_url":"https://api.github.com/users/singer-io/received_events","type":"Organization","site_admin":false},"repo":{"id":125409726,"name":"tap-bronto","full_name":"singer-io/tap-bronto","owner":{"login":"singer-io","id":25538203,"avatar_url":"https://avatars0.githubusercontent.com/u/25538203?v=4","gravatar_id":"","url":"https://api.github.com/users/singer-io","html_url":"https://github.com/singer-io","followers_url":"https://api.github.com/users/singer-io/followers","following_url":"https://api.github.com/users/singer-io/following{/other_user}","gists_url":"https://api.github.com/users/singer-io/gists{/gist_id}","starred_url":"https://api.github.com/users/singer-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singer-io/subscriptions","organizations_url":"https://api.github.com/users/singer-io/orgs","repos_url":"https://api.github.com/users/singer-io/repos","events_url":"https://api.github.com/users/singer-io/events{/privacy}","received_events_url":"https://api.github.com/users/singer-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/singer-io/tap-bronto","description":null,"fork":false,"url":"https://api.github.com/repos/singer-io/tap-bronto","forks_url":"https://api.github.com/repos/singer-io/tap-bronto/forks","keys_url":"https://api.github.com/repos/singer-io/tap-bronto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/singer-io/tap-bronto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/singer-io/tap-bronto/teams","hooks_url":"https://api.github.com/repos/singer-io/tap-bronto/hooks","issue_events_url":"https://api.github.com/repos/singer-io/tap-bronto/issues/events{/number}","events_url":"https://api.github.com/repos/singer-io/tap-bronto/events","assignees_url":"https://api.github.com/repos/singer-io/tap-bronto/assignees{/user}","branches_url":"https://api.github.com/repos/singer-io/tap-bronto/branches{/branch}","tags_url":"https://api.github.com/repos/singer-io/tap-bronto/tags","blobs_url":"https://api.github.com/repos/singer-io/tap-bronto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/singer-io/tap-bronto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/singer-io/tap-bronto/git/refs{/sha}","trees_url":"https://api.github.com/repos/singer-io/tap-bronto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/singer-io/tap-bronto/statuses/{sha}","languages_url":"https://api.github.com/repos/singer-io/tap-bronto/languages","stargazers_url":"https://api.github.com/repos/singer-io/tap-bronto/stargazers","contributors_url":"https://api.github.com/repos/singer-io/tap-bronto/contributors","subscribers_url":"https://api.github.com/repos/singer-io/tap-bronto/subscribers","subscription_url":"https://api.github.com/repos/singer-io/tap-bronto/subscription","commits_url":"https://api.github.com/repos/singer-io/tap-bronto/commits{/sha}","git_commits_url":"https://api.github.com/repos/singer-io/tap-bronto/git/commits{/sha}","comments_url":"https://api.github.com/repos/singer-io/tap-bronto/comments{/number}","issue_comment_url":"https://api.github.com/repos/singer-io/tap-bronto/issues/comments{/number}","contents_url":"https://api.github.com/repos/singer-io/tap-bronto/contents/{+path}","compare_url":"https://api.github.com/repos/singer-io/tap-bronto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/singer-io/tap-bronto/merges","archive_url":"https://api.github.com/repos/singer-io/tap-bronto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/singer-io/tap-bronto/downloads","issues_url":"https://api.github.com/repos/singer-io/tap-bronto/issues{/number}","pulls_url":"https://api.github.com/repos/singer-io/tap-bronto/pulls{/number}","milestones_url":"https://api.github.com/repos/singer-io/tap-bronto/milestones{/number}","notifications_url":"https://api.github.com/repos/singer-io/tap-bronto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/singer-io/tap-bronto/labels{/name}","releases_url":"https://api.github.com/repos/singer-io/tap-bronto/releases{/id}","deployments_url":"https://api.github.com/repos/singer-io/tap-bronto/deployments","created_at":"2018-03-15T18:25:48Z","updated_at":"2018-04-12T20:01:01Z","pushed_at":"2018-04-27T15:34:32Z","git_url":"git://github.com/singer-io/tap-bronto.git","ssh_url":"git@github.com:singer-io/tap-bronto.git","clone_url":"https://github.com/singer-io/tap-bronto.git","svn_url":"https://github.com/singer-io/tap-bronto","homepage":null,"size":55,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"singer-io:master","ref":"master","sha":"2af2dbb8288fc1134640e834bdc4e6ecaa4cbfda","user":{"login":"singer-io","id":25538203,"avatar_url":"https://avatars0.githubusercontent.com/u/25538203?v=4","gravatar_id":"","url":"https://api.github.com/users/singer-io","html_url":"https://github.com/singer-io","followers_url":"https://api.github.com/users/singer-io/followers","following_url":"https://api.github.com/users/singer-io/following{/other_user}","gists_url":"https://api.github.com/users/singer-io/gists{/gist_id}","starred_url":"https://api.github.com/users/singer-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singer-io/subscriptions","organizations_url":"https://api.github.com/users/singer-io/orgs","repos_url":"https://api.github.com/users/singer-io/repos","events_url":"https://api.github.com/users/singer-io/events{/privacy}","received_events_url":"https://api.github.com/users/singer-io/received_events","type":"Organization","site_admin":false},"repo":{"id":125409726,"name":"tap-bronto","full_name":"singer-io/tap-bronto","owner":{"login":"singer-io","id":25538203,"avatar_url":"https://avatars0.githubusercontent.com/u/25538203?v=4","gravatar_id":"","url":"https://api.github.com/users/singer-io","html_url":"https://github.com/singer-io","followers_url":"https://api.github.com/users/singer-io/followers","following_url":"https://api.github.com/users/singer-io/following{/other_user}","gists_url":"https://api.github.com/users/singer-io/gists{/gist_id}","starred_url":"https://api.github.com/users/singer-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singer-io/subscriptions","organizations_url":"https://api.github.com/users/singer-io/orgs","repos_url":"https://api.github.com/users/singer-io/repos","events_url":"https://api.github.com/users/singer-io/events{/privacy}","received_events_url":"https://api.github.com/users/singer-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/singer-io/tap-bronto","description":null,"fork":false,"url":"https://api.github.com/repos/singer-io/tap-bronto","forks_url":"https://api.github.com/repos/singer-io/tap-bronto/forks","keys_url":"https://api.github.com/repos/singer-io/tap-bronto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/singer-io/tap-bronto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/singer-io/tap-bronto/teams","hooks_url":"https://api.github.com/repos/singer-io/tap-bronto/hooks","issue_events_url":"https://api.github.com/repos/singer-io/tap-bronto/issues/events{/number}","events_url":"https://api.github.com/repos/singer-io/tap-bronto/events","assignees_url":"https://api.github.com/repos/singer-io/tap-bronto/assignees{/user}","branches_url":"https://api.github.com/repos/singer-io/tap-bronto/branches{/branch}","tags_url":"https://api.github.com/repos/singer-io/tap-bronto/tags","blobs_url":"https://api.github.com/repos/singer-io/tap-bronto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/singer-io/tap-bronto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/singer-io/tap-bronto/git/refs{/sha}","trees_url":"https://api.github.com/repos/singer-io/tap-bronto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/singer-io/tap-bronto/statuses/{sha}","languages_url":"https://api.github.com/repos/singer-io/tap-bronto/languages","stargazers_url":"https://api.github.com/repos/singer-io/tap-bronto/stargazers","contributors_url":"https://api.github.com/repos/singer-io/tap-bronto/contributors","subscribers_url":"https://api.github.com/repos/singer-io/tap-bronto/subscribers","subscription_url":"https://api.github.com/repos/singer-io/tap-bronto/subscription","commits_url":"https://api.github.com/repos/singer-io/tap-bronto/commits{/sha}","git_commits_url":"https://api.github.com/repos/singer-io/tap-bronto/git/commits{/sha}","comments_url":"https://api.github.com/repos/singer-io/tap-bronto/comments{/number}","issue_comment_url":"https://api.github.com/repos/singer-io/tap-bronto/issues/comments{/number}","contents_url":"https://api.github.com/repos/singer-io/tap-bronto/contents/{+path}","compare_url":"https://api.github.com/repos/singer-io/tap-bronto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/singer-io/tap-bronto/merges","archive_url":"https://api.github.com/repos/singer-io/tap-bronto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/singer-io/tap-bronto/downloads","issues_url":"https://api.github.com/repos/singer-io/tap-bronto/issues{/number}","pulls_url":"https://api.github.com/repos/singer-io/tap-bronto/pulls{/number}","milestones_url":"https://api.github.com/repos/singer-io/tap-bronto/milestones{/number}","notifications_url":"https://api.github.com/repos/singer-io/tap-bronto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/singer-io/tap-bronto/labels{/name}","releases_url":"https://api.github.com/repos/singer-io/tap-bronto/releases{/id}","deployments_url":"https://api.github.com/repos/singer-io/tap-bronto/deployments","created_at":"2018-03-15T18:25:48Z","updated_at":"2018-04-12T20:01:01Z","pushed_at":"2018-04-27T15:34:32Z","git_url":"git://github.com/singer-io/tap-bronto.git","ssh_url":"git@github.com:singer-io/tap-bronto.git","clone_url":"https://github.com/singer-io/tap-bronto.git","svn_url":"https://github.com/singer-io/tap-bronto","homepage":null,"size":55,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/singer-io/tap-bronto/pulls/4"},"html":{"href":"https://github.com/singer-io/tap-bronto/pull/4"},"issue":{"href":"https://api.github.com/repos/singer-io/tap-bronto/issues/4"},"comments":{"href":"https://api.github.com/repos/singer-io/tap-bronto/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/singer-io/tap-bronto/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/singer-io/tap-bronto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/singer-io/tap-bronto/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/singer-io/tap-bronto/statuses/aa25088ac97e7e914464e9ef6a7d15bd2a62bfc6"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dmosorast","id":30501696,"avatar_url":"https://avatars0.githubusercontent.com/u/30501696?v=4","gravatar_id":"","url":"https://api.github.com/users/dmosorast","html_url":"https://github.com/dmosorast","followers_url":"https://api.github.com/users/dmosorast/followers","following_url":"https://api.github.com/users/dmosorast/following{/other_user}","gists_url":"https://api.github.com/users/dmosorast/gists{/gist_id}","starred_url":"https://api.github.com/users/dmosorast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmosorast/subscriptions","organizations_url":"https://api.github.com/users/dmosorast/orgs","repos_url":"https://api.github.com/users/dmosorast/repos","events_url":"https://api.github.com/users/dmosorast/events{/privacy}","received_events_url":"https://api.github.com/users/dmosorast/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"dmosorast"}}