{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/219989890","pull_request_review_id":158294736,"id":219989890,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTk4OTg5MA==","diff_hunk":"@@ -146,6 +160,384 @@ public void shouldImmediatelyEmitEventsWithZeroEmitAfter() {\n         }\n     }\n \n+    @Test(expected = ProcessorStateException.class)","path":"streams/src/test/java/org/apache/kafka/streams/kstream/internals/SuppressScenarioTest.java","position":53,"original_position":53,"commit_id":"70d74df94f29e1689459726039a2d313addc7fd2","original_commit_id":"70d74df94f29e1689459726039a2d313addc7fd2","user":{"login":"vvcephei","id":832787,"node_id":"MDQ6VXNlcjgzMjc4Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/832787?v=4","gravatar_id":"","url":"https://api.github.com/users/vvcephei","html_url":"https://github.com/vvcephei","followers_url":"https://api.github.com/users/vvcephei/followers","following_url":"https://api.github.com/users/vvcephei/following{/other_user}","gists_url":"https://api.github.com/users/vvcephei/gists{/gist_id}","starred_url":"https://api.github.com/users/vvcephei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvcephei/subscriptions","organizations_url":"https://api.github.com/users/vvcephei/orgs","repos_url":"https://api.github.com/users/vvcephei/repos","events_url":"https://api.github.com/users/vvcephei/events{/privacy}","received_events_url":"https://api.github.com/users/vvcephei/received_events","type":"User","site_admin":false},"body":"Note that we're expecting exceptions for now. This will be removed in Part 3.","created_at":"2018-09-24T21:08:21Z","updated_at":"2018-09-24T21:14:41Z","html_url":"https://github.com/apache/kafka/pull/5687#discussion_r219989890","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/5687","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/219989890"},"html":{"href":"https://github.com/apache/kafka/pull/5687#discussion_r219989890"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/5687"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/5687","id":217785089,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3Nzg1MDg5","html_url":"https://github.com/apache/kafka/pull/5687","diff_url":"https://github.com/apache/kafka/pull/5687.diff","patch_url":"https://github.com/apache/kafka/pull/5687.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/5687","number":5687,"state":"open","locked":false,"title":"KAFKA-7223: add unit tests in preparation for suppression","user":{"login":"vvcephei","id":832787,"node_id":"MDQ6VXNlcjgzMjc4Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/832787?v=4","gravatar_id":"","url":"https://api.github.com/users/vvcephei","html_url":"https://github.com/vvcephei","followers_url":"https://api.github.com/users/vvcephei/followers","following_url":"https://api.github.com/users/vvcephei/following{/other_user}","gists_url":"https://api.github.com/users/vvcephei/gists{/gist_id}","starred_url":"https://api.github.com/users/vvcephei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvcephei/subscriptions","organizations_url":"https://api.github.com/users/vvcephei/orgs","repos_url":"https://api.github.com/users/vvcephei/repos","events_url":"https://api.github.com/users/vvcephei/events{/privacy}","received_events_url":"https://api.github.com/users/vvcephei/received_events","type":"User","site_admin":false},"body":"This is Part 2 of suppression. \r\nPart 1 was https://github.com/apache/kafka/pull/5567\r\n\r\nIn an effort to control the scope of the review, I'm sending this PR with just the unit tests for buffered suppression.\r\n\r\n### Committer Checklist (excluded from commit message)\r\n- [ ] Verify design and implementation \r\n- [ ] Verify test coverage and CI build status\r\n- [ ] Verify documentation (including upgrade notes)\r\n","created_at":"2018-09-24T20:53:39Z","updated_at":"2018-09-24T21:14:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f1dbf317b19cc274c6f1dafaaff3def3cbab180","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/5687/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/5687/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/5687/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/70d74df94f29e1689459726039a2d313addc7fd2","head":{"label":"vvcephei:KAFKA-7223-in-mem-suppress-unit-tests","ref":"KAFKA-7223-in-mem-suppress-unit-tests","sha":"70d74df94f29e1689459726039a2d313addc7fd2","user":{"login":"vvcephei","id":832787,"node_id":"MDQ6VXNlcjgzMjc4Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/832787?v=4","gravatar_id":"","url":"https://api.github.com/users/vvcephei","html_url":"https://github.com/vvcephei","followers_url":"https://api.github.com/users/vvcephei/followers","following_url":"https://api.github.com/users/vvcephei/following{/other_user}","gists_url":"https://api.github.com/users/vvcephei/gists{/gist_id}","starred_url":"https://api.github.com/users/vvcephei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvcephei/subscriptions","organizations_url":"https://api.github.com/users/vvcephei/orgs","repos_url":"https://api.github.com/users/vvcephei/repos","events_url":"https://api.github.com/users/vvcephei/events{/privacy}","received_events_url":"https://api.github.com/users/vvcephei/received_events","type":"User","site_admin":false},"repo":{"id":124139257,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQxMzkyNTc=","name":"kafka","full_name":"vvcephei/kafka","private":false,"owner":{"login":"vvcephei","id":832787,"node_id":"MDQ6VXNlcjgzMjc4Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/832787?v=4","gravatar_id":"","url":"https://api.github.com/users/vvcephei","html_url":"https://github.com/vvcephei","followers_url":"https://api.github.com/users/vvcephei/followers","following_url":"https://api.github.com/users/vvcephei/following{/other_user}","gists_url":"https://api.github.com/users/vvcephei/gists{/gist_id}","starred_url":"https://api.github.com/users/vvcephei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvcephei/subscriptions","organizations_url":"https://api.github.com/users/vvcephei/orgs","repos_url":"https://api.github.com/users/vvcephei/repos","events_url":"https://api.github.com/users/vvcephei/events{/privacy}","received_events_url":"https://api.github.com/users/vvcephei/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vvcephei/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/vvcephei/kafka","forks_url":"https://api.github.com/repos/vvcephei/kafka/forks","keys_url":"https://api.github.com/repos/vvcephei/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vvcephei/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vvcephei/kafka/teams","hooks_url":"https://api.github.com/repos/vvcephei/kafka/hooks","issue_events_url":"https://api.github.com/repos/vvcephei/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/vvcephei/kafka/events","assignees_url":"https://api.github.com/repos/vvcephei/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/vvcephei/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/vvcephei/kafka/tags","blobs_url":"https://api.github.com/repos/vvcephei/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vvcephei/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vvcephei/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/vvcephei/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vvcephei/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/vvcephei/kafka/languages","stargazers_url":"https://api.github.com/repos/vvcephei/kafka/stargazers","contributors_url":"https://api.github.com/repos/vvcephei/kafka/contributors","subscribers_url":"https://api.github.com/repos/vvcephei/kafka/subscribers","subscription_url":"https://api.github.com/repos/vvcephei/kafka/subscription","commits_url":"https://api.github.com/repos/vvcephei/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/vvcephei/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/vvcephei/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/vvcephei/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/vvcephei/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/vvcephei/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vvcephei/kafka/merges","archive_url":"https://api.github.com/repos/vvcephei/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vvcephei/kafka/downloads","issues_url":"https://api.github.com/repos/vvcephei/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/vvcephei/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/vvcephei/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/vvcephei/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vvcephei/kafka/labels{/name}","releases_url":"https://api.github.com/repos/vvcephei/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/vvcephei/kafka/deployments","created_at":"2018-03-06T21:12:33Z","updated_at":"2018-04-05T14:43:40Z","pushed_at":"2018-09-24T21:01:49Z","git_url":"git://github.com/vvcephei/kafka.git","ssh_url":"git@github.com:vvcephei/kafka.git","clone_url":"https://github.com/vvcephei/kafka.git","svn_url":"https://github.com/vvcephei/kafka","homepage":null,"size":73777,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"057c5307e0f055b37794453d16f6f43b8c56528c","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"node_id":"MDEwOlJlcG9zaXRvcnkyMjExMjQz","name":"kafka","full_name":"apache/kafka","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2018-09-24T20:29:17Z","pushed_at":"2018-09-24T21:01:52Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":73687,"stargazers_count":9687,"watchers_count":9687,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5458,"mirror_url":null,"archived":false,"open_issues_count":504,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5458,"open_issues":504,"watchers":9687,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/5687"},"html":{"href":"https://github.com/apache/kafka/pull/5687"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/5687"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/5687/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/5687/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/5687/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/70d74df94f29e1689459726039a2d313addc7fd2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vvcephei"}}