{"action":"created","comment":{"url":"https://api.github.com/repos/rchain/rchain/pulls/comments/187453136","pull_request_review_id":119238814,"id":187453136,"diff_hunk":"@@ -146,8 +162,13 @@ object ProtoUtil {\n   def hashString(b: BlockMessage): String = Base16.encode(b.blockHash.toByteArray)\n \n   def basicDeploy(id: Int): Deploy = {\n+    val term = InterpreterUtil.mkTerm(s\"@${id}!($id)\").right.get","path":"casper/src/main/scala/coop/rchain/casper/util/ProtoUtil.scala","position":43,"original_position":43,"commit_id":"afd11373d84a700ba0dc4d1860fd7232d8b78d1a","original_commit_id":"afd11373d84a700ba0dc4d1860fd7232d8b78d1a","user":{"login":"birchmd","id":13788876,"avatar_url":"https://avatars1.githubusercontent.com/u/13788876?v=4","gravatar_id":"","url":"https://api.github.com/users/birchmd","html_url":"https://github.com/birchmd","followers_url":"https://api.github.com/users/birchmd/followers","following_url":"https://api.github.com/users/birchmd/following{/other_user}","gists_url":"https://api.github.com/users/birchmd/gists{/gist_id}","starred_url":"https://api.github.com/users/birchmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birchmd/subscriptions","organizations_url":"https://api.github.com/users/birchmd/orgs","repos_url":"https://api.github.com/users/birchmd/repos","events_url":"https://api.github.com/users/birchmd/events{/privacy}","received_events_url":"https://api.github.com/users/birchmd/received_events","type":"User","site_admin":false},"body":"Yeah, just a dummy. This is only used in the deploy demo and in tests as an easy way of generating Rholang terms. Real deployments are covered in #722 ","created_at":"2018-05-10T20:39:33Z","updated_at":"2018-05-10T20:39:34Z","html_url":"https://github.com/rchain/rchain/pull/718#discussion_r187453136","pull_request_url":"https://api.github.com/repos/rchain/rchain/pulls/718","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rchain/rchain/pulls/comments/187453136"},"html":{"href":"https://github.com/rchain/rchain/pull/718#discussion_r187453136"},"pull_request":{"href":"https://api.github.com/repos/rchain/rchain/pulls/718"}},"in_reply_to_id":187448830},"pull_request":{"url":"https://api.github.com/repos/rchain/rchain/pulls/718","id":187039811,"html_url":"https://github.com/rchain/rchain/pull/718","diff_url":"https://github.com/rchain/rchain/pull/718.diff","patch_url":"https://github.com/rchain/rchain/pull/718.patch","issue_url":"https://api.github.com/repos/rchain/rchain/issues/718","number":718,"state":"open","locked":false,"title":" Casper using Rholang Runtime to add deployed terms to state","user":{"login":"birchmd","id":13788876,"avatar_url":"https://avatars1.githubusercontent.com/u/13788876?v=4","gravatar_id":"","url":"https://api.github.com/users/birchmd","html_url":"https://github.com/birchmd","followers_url":"https://api.github.com/users/birchmd/followers","following_url":"https://api.github.com/users/birchmd/following{/other_user}","gists_url":"https://api.github.com/users/birchmd/gists{/gist_id}","starred_url":"https://api.github.com/users/birchmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birchmd/subscriptions","organizations_url":"https://api.github.com/users/birchmd/orgs","repos_url":"https://api.github.com/users/birchmd/repos","events_url":"https://api.github.com/users/birchmd/events{/privacy}","received_events_url":"https://api.github.com/users/birchmd/received_events","type":"User","site_admin":false},"body":"## Overview\r\nCasper using Rholang Runtime to add deployed terms to state and reduce to quiescence. Blocks contain hash of final result and what terms were deployed. This completes the move to using Rholang terms in Casper blocks instead of the simulated terms.\r\n\r\n### Does this PR relate to an RChain JIRA issue? \r\nhttps://rchain.atlassian.net/browse/RHOL-271\r\n\r\n### Complete this checklist before you submit the PR\r\n- [x] This PR contains no more than 200 lines of code, excluding test code.\r\n- [x] This PR meets [RChain development coding standards](https://rchain.atlassian.net/wiki/spaces/DOC/pages/28082177/Coding+Standards).\r\n- [x] You have someone in mind to assign for review. Make this assignment after submitting the PR.\r\n\r\n### Notes\r\nOptional. Add any notes on caveats, approaches you tried that didn't work, or anything else.\r\n","created_at":"2018-05-09T21:04:01Z","updated_at":"2018-05-10T20:39:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e77c50ffa217e78cfb079b23a452b428a3de3456","assignee":null,"assignees":[],"requested_reviewers":[{"login":"goral09","id":5120801,"avatar_url":"https://avatars2.githubusercontent.com/u/5120801?v=4","gravatar_id":"","url":"https://api.github.com/users/goral09","html_url":"https://github.com/goral09","followers_url":"https://api.github.com/users/goral09/followers","following_url":"https://api.github.com/users/goral09/following{/other_user}","gists_url":"https://api.github.com/users/goral09/gists{/gist_id}","starred_url":"https://api.github.com/users/goral09/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goral09/subscriptions","organizations_url":"https://api.github.com/users/goral09/orgs","repos_url":"https://api.github.com/users/goral09/repos","events_url":"https://api.github.com/users/goral09/events{/privacy}","received_events_url":"https://api.github.com/users/goral09/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rchain/rchain/pulls/718/commits","review_comments_url":"https://api.github.com/repos/rchain/rchain/pulls/718/comments","review_comment_url":"https://api.github.com/repos/rchain/rchain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rchain/rchain/issues/718/comments","statuses_url":"https://api.github.com/repos/rchain/rchain/statuses/afd11373d84a700ba0dc4d1860fd7232d8b78d1a","head":{"label":"birchmd:dev-birch-rhol-271","ref":"dev-birch-rhol-271","sha":"afd11373d84a700ba0dc4d1860fd7232d8b78d1a","user":{"login":"birchmd","id":13788876,"avatar_url":"https://avatars1.githubusercontent.com/u/13788876?v=4","gravatar_id":"","url":"https://api.github.com/users/birchmd","html_url":"https://github.com/birchmd","followers_url":"https://api.github.com/users/birchmd/followers","following_url":"https://api.github.com/users/birchmd/following{/other_user}","gists_url":"https://api.github.com/users/birchmd/gists{/gist_id}","starred_url":"https://api.github.com/users/birchmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birchmd/subscriptions","organizations_url":"https://api.github.com/users/birchmd/orgs","repos_url":"https://api.github.com/users/birchmd/repos","events_url":"https://api.github.com/users/birchmd/events{/privacy}","received_events_url":"https://api.github.com/users/birchmd/received_events","type":"User","site_admin":false},"repo":{"id":122343689,"name":"rchain","full_name":"birchmd/rchain","owner":{"login":"birchmd","id":13788876,"avatar_url":"https://avatars1.githubusercontent.com/u/13788876?v=4","gravatar_id":"","url":"https://api.github.com/users/birchmd","html_url":"https://github.com/birchmd","followers_url":"https://api.github.com/users/birchmd/followers","following_url":"https://api.github.com/users/birchmd/following{/other_user}","gists_url":"https://api.github.com/users/birchmd/gists{/gist_id}","starred_url":"https://api.github.com/users/birchmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birchmd/subscriptions","organizations_url":"https://api.github.com/users/birchmd/orgs","repos_url":"https://api.github.com/users/birchmd/repos","events_url":"https://api.github.com/users/birchmd/events{/privacy}","received_events_url":"https://api.github.com/users/birchmd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/birchmd/rchain","description":null,"fork":true,"url":"https://api.github.com/repos/birchmd/rchain","forks_url":"https://api.github.com/repos/birchmd/rchain/forks","keys_url":"https://api.github.com/repos/birchmd/rchain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/birchmd/rchain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/birchmd/rchain/teams","hooks_url":"https://api.github.com/repos/birchmd/rchain/hooks","issue_events_url":"https://api.github.com/repos/birchmd/rchain/issues/events{/number}","events_url":"https://api.github.com/repos/birchmd/rchain/events","assignees_url":"https://api.github.com/repos/birchmd/rchain/assignees{/user}","branches_url":"https://api.github.com/repos/birchmd/rchain/branches{/branch}","tags_url":"https://api.github.com/repos/birchmd/rchain/tags","blobs_url":"https://api.github.com/repos/birchmd/rchain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/birchmd/rchain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/birchmd/rchain/git/refs{/sha}","trees_url":"https://api.github.com/repos/birchmd/rchain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/birchmd/rchain/statuses/{sha}","languages_url":"https://api.github.com/repos/birchmd/rchain/languages","stargazers_url":"https://api.github.com/repos/birchmd/rchain/stargazers","contributors_url":"https://api.github.com/repos/birchmd/rchain/contributors","subscribers_url":"https://api.github.com/repos/birchmd/rchain/subscribers","subscription_url":"https://api.github.com/repos/birchmd/rchain/subscription","commits_url":"https://api.github.com/repos/birchmd/rchain/commits{/sha}","git_commits_url":"https://api.github.com/repos/birchmd/rchain/git/commits{/sha}","comments_url":"https://api.github.com/repos/birchmd/rchain/comments{/number}","issue_comment_url":"https://api.github.com/repos/birchmd/rchain/issues/comments{/number}","contents_url":"https://api.github.com/repos/birchmd/rchain/contents/{+path}","compare_url":"https://api.github.com/repos/birchmd/rchain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/birchmd/rchain/merges","archive_url":"https://api.github.com/repos/birchmd/rchain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/birchmd/rchain/downloads","issues_url":"https://api.github.com/repos/birchmd/rchain/issues{/number}","pulls_url":"https://api.github.com/repos/birchmd/rchain/pulls{/number}","milestones_url":"https://api.github.com/repos/birchmd/rchain/milestones{/number}","notifications_url":"https://api.github.com/repos/birchmd/rchain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/birchmd/rchain/labels{/name}","releases_url":"https://api.github.com/repos/birchmd/rchain/releases{/id}","deployments_url":"https://api.github.com/repos/birchmd/rchain/deployments","created_at":"2018-02-21T14:01:24Z","updated_at":"2018-03-15T09:23:44Z","pushed_at":"2018-05-10T18:19:20Z","git_url":"git://github.com/birchmd/rchain.git","ssh_url":"git@github.com:birchmd/rchain.git","clone_url":"https://github.com/birchmd/rchain.git","svn_url":"https://github.com/birchmd/rchain","homepage":null,"size":9342,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rchain:dev","ref":"dev","sha":"269b425fc6f03a92e3a4e372b75175752b0d241f","user":{"login":"rchain","id":20671765,"avatar_url":"https://avatars0.githubusercontent.com/u/20671765?v=4","gravatar_id":"","url":"https://api.github.com/users/rchain","html_url":"https://github.com/rchain","followers_url":"https://api.github.com/users/rchain/followers","following_url":"https://api.github.com/users/rchain/following{/other_user}","gists_url":"https://api.github.com/users/rchain/gists{/gist_id}","starred_url":"https://api.github.com/users/rchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchain/subscriptions","organizations_url":"https://api.github.com/users/rchain/orgs","repos_url":"https://api.github.com/users/rchain/repos","events_url":"https://api.github.com/users/rchain/events{/privacy}","received_events_url":"https://api.github.com/users/rchain/received_events","type":"Organization","site_admin":false},"repo":{"id":84493691,"name":"rchain","full_name":"rchain/rchain","owner":{"login":"rchain","id":20671765,"avatar_url":"https://avatars0.githubusercontent.com/u/20671765?v=4","gravatar_id":"","url":"https://api.github.com/users/rchain","html_url":"https://github.com/rchain","followers_url":"https://api.github.com/users/rchain/followers","following_url":"https://api.github.com/users/rchain/following{/other_user}","gists_url":"https://api.github.com/users/rchain/gists{/gist_id}","starred_url":"https://api.github.com/users/rchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchain/subscriptions","organizations_url":"https://api.github.com/users/rchain/orgs","repos_url":"https://api.github.com/users/rchain/repos","events_url":"https://api.github.com/users/rchain/events{/privacy}","received_events_url":"https://api.github.com/users/rchain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rchain/rchain","description":null,"fork":false,"url":"https://api.github.com/repos/rchain/rchain","forks_url":"https://api.github.com/repos/rchain/rchain/forks","keys_url":"https://api.github.com/repos/rchain/rchain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rchain/rchain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rchain/rchain/teams","hooks_url":"https://api.github.com/repos/rchain/rchain/hooks","issue_events_url":"https://api.github.com/repos/rchain/rchain/issues/events{/number}","events_url":"https://api.github.com/repos/rchain/rchain/events","assignees_url":"https://api.github.com/repos/rchain/rchain/assignees{/user}","branches_url":"https://api.github.com/repos/rchain/rchain/branches{/branch}","tags_url":"https://api.github.com/repos/rchain/rchain/tags","blobs_url":"https://api.github.com/repos/rchain/rchain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rchain/rchain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rchain/rchain/git/refs{/sha}","trees_url":"https://api.github.com/repos/rchain/rchain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rchain/rchain/statuses/{sha}","languages_url":"https://api.github.com/repos/rchain/rchain/languages","stargazers_url":"https://api.github.com/repos/rchain/rchain/stargazers","contributors_url":"https://api.github.com/repos/rchain/rchain/contributors","subscribers_url":"https://api.github.com/repos/rchain/rchain/subscribers","subscription_url":"https://api.github.com/repos/rchain/rchain/subscription","commits_url":"https://api.github.com/repos/rchain/rchain/commits{/sha}","git_commits_url":"https://api.github.com/repos/rchain/rchain/git/commits{/sha}","comments_url":"https://api.github.com/repos/rchain/rchain/comments{/number}","issue_comment_url":"https://api.github.com/repos/rchain/rchain/issues/comments{/number}","contents_url":"https://api.github.com/repos/rchain/rchain/contents/{+path}","compare_url":"https://api.github.com/repos/rchain/rchain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rchain/rchain/merges","archive_url":"https://api.github.com/repos/rchain/rchain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rchain/rchain/downloads","issues_url":"https://api.github.com/repos/rchain/rchain/issues{/number}","pulls_url":"https://api.github.com/repos/rchain/rchain/pulls{/number}","milestones_url":"https://api.github.com/repos/rchain/rchain/milestones{/number}","notifications_url":"https://api.github.com/repos/rchain/rchain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rchain/rchain/labels{/name}","releases_url":"https://api.github.com/repos/rchain/rchain/releases{/id}","deployments_url":"https://api.github.com/repos/rchain/rchain/deployments","created_at":"2017-03-09T22:15:35Z","updated_at":"2018-05-10T15:48:11Z","pushed_at":"2018-05-10T20:12:45Z","git_url":"git://github.com/rchain/rchain.git","ssh_url":"git@github.com:rchain/rchain.git","clone_url":"https://github.com/rchain/rchain.git","svn_url":"https://github.com/rchain/rchain","homepage":null,"size":9307,"stargazers_count":298,"watchers_count":298,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":80,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":80,"open_issues":9,"watchers":298,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rchain/rchain/pulls/718"},"html":{"href":"https://github.com/rchain/rchain/pull/718"},"issue":{"href":"https://api.github.com/repos/rchain/rchain/issues/718"},"comments":{"href":"https://api.github.com/repos/rchain/rchain/issues/718/comments"},"review_comments":{"href":"https://api.github.com/repos/rchain/rchain/pulls/718/comments"},"review_comment":{"href":"https://api.github.com/repos/rchain/rchain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rchain/rchain/pulls/718/commits"},"statuses":{"href":"https://api.github.com/repos/rchain/rchain/statuses/afd11373d84a700ba0dc4d1860fd7232d8b78d1a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"birchmd"}}