{"action":"created","comment":{"url":"https://api.github.com/repos/nteract/nteract/pulls/comments/173583481","pull_request_review_id":102799120,"id":173583481,"diff_hunk":"@@ -310,13 +350,27 @@ export function dispatchNewNotebook(\n   event: Event,\n   kernelSpec: Object\n ) {\n+  const state = store.getState();\n   const kernelRef = stateModule.createKernelRef();\n+  const contentRef = selectors.currentContentRef(state);\n \n   store.dispatch(\n+    // for desktop, we _can_ assume this has no path except for living in `cwd`\n+    // which I suppose _could_ be called `${cwd}/UntitledN.ipynb`\n+    // for jupyter extension, we _would_ call this `${cwd}/UntitledN.ipynb`\n+\n+    // TODO: the reducers will choose this as the current content ref\n+    //       and set up the initial model for this content even though set notebook\n+    //       will totally overwrite this afterward\n     actions.newNotebook({\n+      // last saved is never\n+      // you really do know that this content is a notebook and that it is\n+      // the newly selected content\n+      // You even should be able to create the notebook without SET_NOTEBOOK here","path":"applications/desktop/src/notebook/menu.js","position":243,"original_position":243,"commit_id":"548e5f0e583fc98e40f0d477adf6fbc65834b8dd","original_commit_id":"548e5f0e583fc98e40f0d477adf6fbc65834b8dd","user":{"login":"theengineear","id":6611546,"avatar_url":"https://avatars3.githubusercontent.com/u/6611546?v=4","gravatar_id":"","url":"https://api.github.com/users/theengineear","html_url":"https://github.com/theengineear","followers_url":"https://api.github.com/users/theengineear/followers","following_url":"https://api.github.com/users/theengineear/following{/other_user}","gists_url":"https://api.github.com/users/theengineear/gists{/gist_id}","starred_url":"https://api.github.com/users/theengineear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theengineear/subscriptions","organizations_url":"https://api.github.com/users/theengineear/orgs","repos_url":"https://api.github.com/users/theengineear/repos","events_url":"https://api.github.com/users/theengineear/events{/privacy}","received_events_url":"https://api.github.com/users/theengineear/received_events","type":"User","site_admin":false},"body":"we also have `created`, which i'm not sure if that would be first save? or this moment?","created_at":"2018-03-09T22:20:49Z","updated_at":"2018-03-09T22:33:47Z","html_url":"https://github.com/nteract/nteract/pull/2657#discussion_r173583481","pull_request_url":"https://api.github.com/repos/nteract/nteract/pulls/2657","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nteract/nteract/pulls/comments/173583481"},"html":{"href":"https://github.com/nteract/nteract/pull/2657#discussion_r173583481"},"pull_request":{"href":"https://api.github.com/repos/nteract/nteract/pulls/2657"}}},"pull_request":{"url":"https://api.github.com/repos/nteract/nteract/pulls/2657","id":173857394,"html_url":"https://github.com/nteract/nteract/pull/2657","diff_url":"https://github.com/nteract/nteract/pull/2657.diff","patch_url":"https://github.com/nteract/nteract/pull/2657.patch","issue_url":"https://api.github.com/repos/nteract/nteract/issues/2657","number":2657,"state":"open","locked":false,"title":"[WIP] Switch to content refs in desktop","user":{"login":"rgbkrk","id":836375,"avatar_url":"https://avatars0.githubusercontent.com/u/836375?v=4","gravatar_id":"","url":"https://api.github.com/users/rgbkrk","html_url":"https://github.com/rgbkrk","followers_url":"https://api.github.com/users/rgbkrk/followers","following_url":"https://api.github.com/users/rgbkrk/following{/other_user}","gists_url":"https://api.github.com/users/rgbkrk/gists{/gist_id}","starred_url":"https://api.github.com/users/rgbkrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgbkrk/subscriptions","organizations_url":"https://api.github.com/users/rgbkrk/orgs","repos_url":"https://api.github.com/users/rgbkrk/repos","events_url":"https://api.github.com/users/rgbkrk/events{/privacy}","received_events_url":"https://api.github.com/users/rgbkrk/received_events","type":"User","site_admin":false},"body":"Switch desktop over to using `contentRef`s and make them required in actions.","created_at":"2018-03-08T21:36:36Z","updated_at":"2018-03-09T22:33:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42743bf561cbd96faddbf8ddf7e26ce71fea5d1c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nteract/nteract/pulls/2657/commits","review_comments_url":"https://api.github.com/repos/nteract/nteract/pulls/2657/comments","review_comment_url":"https://api.github.com/repos/nteract/nteract/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nteract/nteract/issues/2657/comments","statuses_url":"https://api.github.com/repos/nteract/nteract/statuses/548e5f0e583fc98e40f0d477adf6fbc65834b8dd","head":{"label":"rgbkrk:content-refs-for-desktop","ref":"content-refs-for-desktop","sha":"548e5f0e583fc98e40f0d477adf6fbc65834b8dd","user":{"login":"rgbkrk","id":836375,"avatar_url":"https://avatars0.githubusercontent.com/u/836375?v=4","gravatar_id":"","url":"https://api.github.com/users/rgbkrk","html_url":"https://github.com/rgbkrk","followers_url":"https://api.github.com/users/rgbkrk/followers","following_url":"https://api.github.com/users/rgbkrk/following{/other_user}","gists_url":"https://api.github.com/users/rgbkrk/gists{/gist_id}","starred_url":"https://api.github.com/users/rgbkrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgbkrk/subscriptions","organizations_url":"https://api.github.com/users/rgbkrk/orgs","repos_url":"https://api.github.com/users/rgbkrk/repos","events_url":"https://api.github.com/users/rgbkrk/events{/privacy}","received_events_url":"https://api.github.com/users/rgbkrk/received_events","type":"User","site_admin":false},"repo":{"id":48899794,"name":"nteract","full_name":"rgbkrk/nteract","owner":{"login":"rgbkrk","id":836375,"avatar_url":"https://avatars0.githubusercontent.com/u/836375?v=4","gravatar_id":"","url":"https://api.github.com/users/rgbkrk","html_url":"https://github.com/rgbkrk","followers_url":"https://api.github.com/users/rgbkrk/followers","following_url":"https://api.github.com/users/rgbkrk/following{/other_user}","gists_url":"https://api.github.com/users/rgbkrk/gists{/gist_id}","starred_url":"https://api.github.com/users/rgbkrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgbkrk/subscriptions","organizations_url":"https://api.github.com/users/rgbkrk/orgs","repos_url":"https://api.github.com/users/rgbkrk/repos","events_url":"https://api.github.com/users/rgbkrk/events{/privacy}","received_events_url":"https://api.github.com/users/rgbkrk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rgbkrk/nteract","description":":notebook: Electron app of the Jupyter Notebook","fork":true,"url":"https://api.github.com/repos/rgbkrk/nteract","forks_url":"https://api.github.com/repos/rgbkrk/nteract/forks","keys_url":"https://api.github.com/repos/rgbkrk/nteract/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rgbkrk/nteract/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rgbkrk/nteract/teams","hooks_url":"https://api.github.com/repos/rgbkrk/nteract/hooks","issue_events_url":"https://api.github.com/repos/rgbkrk/nteract/issues/events{/number}","events_url":"https://api.github.com/repos/rgbkrk/nteract/events","assignees_url":"https://api.github.com/repos/rgbkrk/nteract/assignees{/user}","branches_url":"https://api.github.com/repos/rgbkrk/nteract/branches{/branch}","tags_url":"https://api.github.com/repos/rgbkrk/nteract/tags","blobs_url":"https://api.github.com/repos/rgbkrk/nteract/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rgbkrk/nteract/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rgbkrk/nteract/git/refs{/sha}","trees_url":"https://api.github.com/repos/rgbkrk/nteract/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rgbkrk/nteract/statuses/{sha}","languages_url":"https://api.github.com/repos/rgbkrk/nteract/languages","stargazers_url":"https://api.github.com/repos/rgbkrk/nteract/stargazers","contributors_url":"https://api.github.com/repos/rgbkrk/nteract/contributors","subscribers_url":"https://api.github.com/repos/rgbkrk/nteract/subscribers","subscription_url":"https://api.github.com/repos/rgbkrk/nteract/subscription","commits_url":"https://api.github.com/repos/rgbkrk/nteract/commits{/sha}","git_commits_url":"https://api.github.com/repos/rgbkrk/nteract/git/commits{/sha}","comments_url":"https://api.github.com/repos/rgbkrk/nteract/comments{/number}","issue_comment_url":"https://api.github.com/repos/rgbkrk/nteract/issues/comments{/number}","contents_url":"https://api.github.com/repos/rgbkrk/nteract/contents/{+path}","compare_url":"https://api.github.com/repos/rgbkrk/nteract/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rgbkrk/nteract/merges","archive_url":"https://api.github.com/repos/rgbkrk/nteract/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rgbkrk/nteract/downloads","issues_url":"https://api.github.com/repos/rgbkrk/nteract/issues{/number}","pulls_url":"https://api.github.com/repos/rgbkrk/nteract/pulls{/number}","milestones_url":"https://api.github.com/repos/rgbkrk/nteract/milestones{/number}","notifications_url":"https://api.github.com/repos/rgbkrk/nteract/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rgbkrk/nteract/labels{/name}","releases_url":"https://api.github.com/repos/rgbkrk/nteract/releases{/id}","deployments_url":"https://api.github.com/repos/rgbkrk/nteract/deployments","created_at":"2016-01-02T05:29:56Z","updated_at":"2018-02-01T19:13:20Z","pushed_at":"2018-03-09T21:08:30Z","git_url":"git://github.com/rgbkrk/nteract.git","ssh_url":"git@github.com:rgbkrk/nteract.git","clone_url":"https://github.com/rgbkrk/nteract.git","svn_url":"https://github.com/rgbkrk/nteract","homepage":null,"size":13310,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":1,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"nteract:master","ref":"master","sha":"c7e0ff6e2f234130a67419adfc661a78ebdff9ab","user":{"login":"nteract","id":12401040,"avatar_url":"https://avatars0.githubusercontent.com/u/12401040?v=4","gravatar_id":"","url":"https://api.github.com/users/nteract","html_url":"https://github.com/nteract","followers_url":"https://api.github.com/users/nteract/followers","following_url":"https://api.github.com/users/nteract/following{/other_user}","gists_url":"https://api.github.com/users/nteract/gists{/gist_id}","starred_url":"https://api.github.com/users/nteract/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nteract/subscriptions","organizations_url":"https://api.github.com/users/nteract/orgs","repos_url":"https://api.github.com/users/nteract/repos","events_url":"https://api.github.com/users/nteract/events{/privacy}","received_events_url":"https://api.github.com/users/nteract/received_events","type":"Organization","site_admin":false},"repo":{"id":37496521,"name":"nteract","full_name":"nteract/nteract","owner":{"login":"nteract","id":12401040,"avatar_url":"https://avatars0.githubusercontent.com/u/12401040?v=4","gravatar_id":"","url":"https://api.github.com/users/nteract","html_url":"https://github.com/nteract","followers_url":"https://api.github.com/users/nteract/followers","following_url":"https://api.github.com/users/nteract/following{/other_user}","gists_url":"https://api.github.com/users/nteract/gists{/gist_id}","starred_url":"https://api.github.com/users/nteract/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nteract/subscriptions","organizations_url":"https://api.github.com/users/nteract/orgs","repos_url":"https://api.github.com/users/nteract/repos","events_url":"https://api.github.com/users/nteract/events{/privacy}","received_events_url":"https://api.github.com/users/nteract/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nteract/nteract","description":"📘 Desktop notebook app + packages","fork":false,"url":"https://api.github.com/repos/nteract/nteract","forks_url":"https://api.github.com/repos/nteract/nteract/forks","keys_url":"https://api.github.com/repos/nteract/nteract/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nteract/nteract/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nteract/nteract/teams","hooks_url":"https://api.github.com/repos/nteract/nteract/hooks","issue_events_url":"https://api.github.com/repos/nteract/nteract/issues/events{/number}","events_url":"https://api.github.com/repos/nteract/nteract/events","assignees_url":"https://api.github.com/repos/nteract/nteract/assignees{/user}","branches_url":"https://api.github.com/repos/nteract/nteract/branches{/branch}","tags_url":"https://api.github.com/repos/nteract/nteract/tags","blobs_url":"https://api.github.com/repos/nteract/nteract/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nteract/nteract/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nteract/nteract/git/refs{/sha}","trees_url":"https://api.github.com/repos/nteract/nteract/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nteract/nteract/statuses/{sha}","languages_url":"https://api.github.com/repos/nteract/nteract/languages","stargazers_url":"https://api.github.com/repos/nteract/nteract/stargazers","contributors_url":"https://api.github.com/repos/nteract/nteract/contributors","subscribers_url":"https://api.github.com/repos/nteract/nteract/subscribers","subscription_url":"https://api.github.com/repos/nteract/nteract/subscription","commits_url":"https://api.github.com/repos/nteract/nteract/commits{/sha}","git_commits_url":"https://api.github.com/repos/nteract/nteract/git/commits{/sha}","comments_url":"https://api.github.com/repos/nteract/nteract/comments{/number}","issue_comment_url":"https://api.github.com/repos/nteract/nteract/issues/comments{/number}","contents_url":"https://api.github.com/repos/nteract/nteract/contents/{+path}","compare_url":"https://api.github.com/repos/nteract/nteract/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nteract/nteract/merges","archive_url":"https://api.github.com/repos/nteract/nteract/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nteract/nteract/downloads","issues_url":"https://api.github.com/repos/nteract/nteract/issues{/number}","pulls_url":"https://api.github.com/repos/nteract/nteract/pulls{/number}","milestones_url":"https://api.github.com/repos/nteract/nteract/milestones{/number}","notifications_url":"https://api.github.com/repos/nteract/nteract/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nteract/nteract/labels{/name}","releases_url":"https://api.github.com/repos/nteract/nteract/releases{/id}","deployments_url":"https://api.github.com/repos/nteract/nteract/deployments","created_at":"2015-06-15T23:21:49Z","updated_at":"2018-03-09T10:00:48Z","pushed_at":"2018-03-09T21:08:31Z","git_url":"git://github.com/nteract/nteract.git","ssh_url":"git@github.com:nteract/nteract.git","clone_url":"https://github.com/nteract/nteract.git","svn_url":"https://github.com/nteract/nteract","homepage":"https://nteract.io","size":13517,"stargazers_count":2347,"watchers_count":2347,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":245,"mirror_url":null,"archived":false,"open_issues_count":265,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":245,"open_issues":265,"watchers":2347,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nteract/nteract/pulls/2657"},"html":{"href":"https://github.com/nteract/nteract/pull/2657"},"issue":{"href":"https://api.github.com/repos/nteract/nteract/issues/2657"},"comments":{"href":"https://api.github.com/repos/nteract/nteract/issues/2657/comments"},"review_comments":{"href":"https://api.github.com/repos/nteract/nteract/pulls/2657/comments"},"review_comment":{"href":"https://api.github.com/repos/nteract/nteract/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nteract/nteract/pulls/2657/commits"},"statuses":{"href":"https://api.github.com/repos/nteract/nteract/statuses/548e5f0e583fc98e40f0d477adf6fbc65834b8dd"}},"author_association":"OWNER"}}
{"actor":{"display_login":"theengineear"}}