{"action":"opened","number":49,"pull_request":{"url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/pulls/49","id":229874025,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5ODc0MDI1","html_url":"https://github.com/wso2-extensions/identity-event-handler-account-lock/pull/49","diff_url":"https://github.com/wso2-extensions/identity-event-handler-account-lock/pull/49.diff","patch_url":"https://github.com/wso2-extensions/identity-event-handler-account-lock/pull/49.patch","issue_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/issues/49","number":49,"state":"open","locked":false,"title":"Improve handlePostAuthentication method","user":{"login":"AnuradhaSK","id":25483865,"node_id":"MDQ6VXNlcjI1NDgzODY1","avatar_url":"https://avatars2.githubusercontent.com/u/25483865?v=4","gravatar_id":"","url":"https://api.github.com/users/AnuradhaSK","html_url":"https://github.com/AnuradhaSK","followers_url":"https://api.github.com/users/AnuradhaSK/followers","following_url":"https://api.github.com/users/AnuradhaSK/following{/other_user}","gists_url":"https://api.github.com/users/AnuradhaSK/gists{/gist_id}","starred_url":"https://api.github.com/users/AnuradhaSK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnuradhaSK/subscriptions","organizations_url":"https://api.github.com/users/AnuradhaSK/orgs","repos_url":"https://api.github.com/users/AnuradhaSK/repos","events_url":"https://api.github.com/users/AnuradhaSK/events{/privacy}","received_events_url":"https://api.github.com/users/AnuradhaSK/received_events","type":"User","site_admin":false},"body":"### Proposed changes in this pull request\r\n\r\n- step 02 to resolve https://github.com/wso2/product-is/issues/3951\r\n- Improve handlePostAuthentication with a new claim\r\n\r\n\r\n### When should this PR be merged\r\n\r\n- Depends on https://github.com/wso2/carbon-identity-framework/pull/1975\r\n\r\n\r\n\r\n### Checklist (for reviewing)\r\n\r\n#### General\r\n\r\n- [ ] **Is this PR explained thoroughly?** All code changes must be accounted for in the PR description.\r\n- [ ] **Is the PR labeled correctly?**\r\n\r\n#### Functionality\r\n\r\n- [ ] **Are all requirements met?** Compare implemented functionality with the requirements specification.\r\n- [ ] **Does the UI work as expected?** There should be no Javascript errors in the console; all resources should load. There should be no unexpected errors. Deliberately try to break the feature to find out if there are corner cases that are not handled.\r\n\r\n#### Code\r\n\r\n- [ ] **Do you fully understand the introduced changes to the code?** If not ask for clarification, it might uncover ways to solve a problem in a more elegant and efficient way.\r\n- [ ] **Does the PR introduce any inefficient database requests?** Use the debug server to check for duplicate requests.\r\n- [ ] **Are all necessary strings marked for translation?** All strings that are exposed to users via the UI must be [marked for translation](https://docs.djangoproject.com/en/1.10/topics/i18n/translation/).\r\n\r\n#### Tests\r\n\r\n- [ ] **Are there sufficient test cases?** Ensure that all components are tested individually; models, forms, and serializers should be tested in isolation even if a test for a view covers these components.\r\n- [ ] **If this is a bug fix, are tests for the issue in place?**  There must be a test case for the bug to ensure the issue won’t regress. Make sure that the tests break without the new code to fix the issue.\r\n- [ ] **If this is a new feature or a significant change to an existing feature?** has the manual testing spreadsheet been updated with instructions for manual testing?\r\n\r\n#### Security\r\n\r\n- [ ] **Confirm this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.**\r\n- [ ] **Are all UI and API inputs run through forms or serializers?**\r\n- [ ] **Are all external inputs validated and sanitized appropriately?**\r\n- [ ] **Does all branching logic have a default case?**\r\n- [ ] **Does this solution handle outliers and edge cases gracefully?**\r\n- [ ] **Are all external communications secured and restricted to SSL?**\r\n\r\n#### Documentation\r\n\r\n- [ ] **Are changes to the UI documented in the platform docs?** If this PR introduces new platform site functionality or changes existing ones, the changes should be documented.\r\n- [ ] **Are changes to the API documented in the API docs?** If this PR introduces new API functionality or changes existing ones, the changes must be documented.\r\n- [ ] **Are reusable components documented?** If this PR introduces components that are relevant to other developers (for instance a mixin for a view or a generic form) they should be documented in the Wiki.\r\n","created_at":"2018-11-10T06:36:31Z","updated_at":"2018-11-10T06:36:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/pulls/49/commits","review_comments_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/pulls/49/comments","review_comment_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/issues/49/comments","statuses_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/statuses/e0824d7dc182463cb6172dc1ae6743cb25fbec22","head":{"label":"AnuradhaSK:failed-login-attempts-before-success-claim","ref":"failed-login-attempts-before-success-claim","sha":"e0824d7dc182463cb6172dc1ae6743cb25fbec22","user":{"login":"AnuradhaSK","id":25483865,"node_id":"MDQ6VXNlcjI1NDgzODY1","avatar_url":"https://avatars2.githubusercontent.com/u/25483865?v=4","gravatar_id":"","url":"https://api.github.com/users/AnuradhaSK","html_url":"https://github.com/AnuradhaSK","followers_url":"https://api.github.com/users/AnuradhaSK/followers","following_url":"https://api.github.com/users/AnuradhaSK/following{/other_user}","gists_url":"https://api.github.com/users/AnuradhaSK/gists{/gist_id}","starred_url":"https://api.github.com/users/AnuradhaSK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnuradhaSK/subscriptions","organizations_url":"https://api.github.com/users/AnuradhaSK/orgs","repos_url":"https://api.github.com/users/AnuradhaSK/repos","events_url":"https://api.github.com/users/AnuradhaSK/events{/privacy}","received_events_url":"https://api.github.com/users/AnuradhaSK/received_events","type":"User","site_admin":false},"repo":{"id":156657113,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY2NTcxMTM=","name":"identity-event-handler-account-lock","full_name":"AnuradhaSK/identity-event-handler-account-lock","private":false,"owner":{"login":"AnuradhaSK","id":25483865,"node_id":"MDQ6VXNlcjI1NDgzODY1","avatar_url":"https://avatars2.githubusercontent.com/u/25483865?v=4","gravatar_id":"","url":"https://api.github.com/users/AnuradhaSK","html_url":"https://github.com/AnuradhaSK","followers_url":"https://api.github.com/users/AnuradhaSK/followers","following_url":"https://api.github.com/users/AnuradhaSK/following{/other_user}","gists_url":"https://api.github.com/users/AnuradhaSK/gists{/gist_id}","starred_url":"https://api.github.com/users/AnuradhaSK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnuradhaSK/subscriptions","organizations_url":"https://api.github.com/users/AnuradhaSK/orgs","repos_url":"https://api.github.com/users/AnuradhaSK/repos","events_url":"https://api.github.com/users/AnuradhaSK/events{/privacy}","received_events_url":"https://api.github.com/users/AnuradhaSK/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AnuradhaSK/identity-event-handler-account-lock","description":null,"fork":true,"url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock","forks_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/forks","keys_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/teams","hooks_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/hooks","issue_events_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/issues/events{/number}","events_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/events","assignees_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/assignees{/user}","branches_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/branches{/branch}","tags_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/tags","blobs_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/statuses/{sha}","languages_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/languages","stargazers_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/stargazers","contributors_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/contributors","subscribers_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/subscribers","subscription_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/subscription","commits_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/contents/{+path}","compare_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/merges","archive_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/downloads","issues_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/issues{/number}","pulls_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/pulls{/number}","milestones_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/milestones{/number}","notifications_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/labels{/name}","releases_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/releases{/id}","deployments_url":"https://api.github.com/repos/AnuradhaSK/identity-event-handler-account-lock/deployments","created_at":"2018-11-08T05:55:21Z","updated_at":"2018-11-08T05:55:23Z","pushed_at":"2018-11-09T08:54:38Z","git_url":"git://github.com/AnuradhaSK/identity-event-handler-account-lock.git","ssh_url":"git@github.com:AnuradhaSK/identity-event-handler-account-lock.git","clone_url":"https://github.com/AnuradhaSK/identity-event-handler-account-lock.git","svn_url":"https://github.com/AnuradhaSK/identity-event-handler-account-lock","homepage":null,"size":215,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2-extensions:master","ref":"master","sha":"7dadc8c547908fddcebea2845a4a02aca3b50e9c","user":{"login":"wso2-extensions","id":17171218,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTcxMjE4","avatar_url":"https://avatars0.githubusercontent.com/u/17171218?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2-extensions","html_url":"https://github.com/wso2-extensions","followers_url":"https://api.github.com/users/wso2-extensions/followers","following_url":"https://api.github.com/users/wso2-extensions/following{/other_user}","gists_url":"https://api.github.com/users/wso2-extensions/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2-extensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2-extensions/subscriptions","organizations_url":"https://api.github.com/users/wso2-extensions/orgs","repos_url":"https://api.github.com/users/wso2-extensions/repos","events_url":"https://api.github.com/users/wso2-extensions/events{/privacy}","received_events_url":"https://api.github.com/users/wso2-extensions/received_events","type":"Organization","site_admin":false},"repo":{"id":58141332,"node_id":"MDEwOlJlcG9zaXRvcnk1ODE0MTMzMg==","name":"identity-event-handler-account-lock","full_name":"wso2-extensions/identity-event-handler-account-lock","private":false,"owner":{"login":"wso2-extensions","id":17171218,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTcxMjE4","avatar_url":"https://avatars0.githubusercontent.com/u/17171218?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2-extensions","html_url":"https://github.com/wso2-extensions","followers_url":"https://api.github.com/users/wso2-extensions/followers","following_url":"https://api.github.com/users/wso2-extensions/following{/other_user}","gists_url":"https://api.github.com/users/wso2-extensions/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2-extensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2-extensions/subscriptions","organizations_url":"https://api.github.com/users/wso2-extensions/orgs","repos_url":"https://api.github.com/users/wso2-extensions/repos","events_url":"https://api.github.com/users/wso2-extensions/events{/privacy}","received_events_url":"https://api.github.com/users/wso2-extensions/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wso2-extensions/identity-event-handler-account-lock","description":null,"fork":false,"url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock","forks_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/forks","keys_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/teams","hooks_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/hooks","issue_events_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/issues/events{/number}","events_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/events","assignees_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/assignees{/user}","branches_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/branches{/branch}","tags_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/tags","blobs_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/languages","stargazers_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/stargazers","contributors_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/contributors","subscribers_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/subscribers","subscription_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/subscription","commits_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/contents/{+path}","compare_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/merges","archive_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/downloads","issues_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/issues{/number}","pulls_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/labels{/name}","releases_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/releases{/id}","deployments_url":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/deployments","created_at":"2016-05-05T15:31:23Z","updated_at":"2018-09-25T04:45:44Z","pushed_at":"2018-09-25T04:45:50Z","git_url":"git://github.com/wso2-extensions/identity-event-handler-account-lock.git","ssh_url":"git@github.com:wso2-extensions/identity-event-handler-account-lock.git","clone_url":"https://github.com/wso2-extensions/identity-event-handler-account-lock.git","svn_url":"https://github.com/wso2-extensions/identity-event-handler-account-lock","homepage":null,"size":214,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":26,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/pulls/49"},"html":{"href":"https://github.com/wso2-extensions/identity-event-handler-account-lock/pull/49"},"issue":{"href":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/issues/49"},"comments":{"href":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/wso2-extensions/identity-event-handler-account-lock/statuses/e0824d7dc182463cb6172dc1ae6743cb25fbec22"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":30,"deletions":20,"changed_files":2}}
{"actor":{"display_login":"AnuradhaSK"}}