{"action":"created","comment":{"url":"https://api.github.com/repos/canalplus/rx-player/pulls/comments/216668300","pull_request_review_id":154201566,"id":216668300,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjY2ODMwMA==","diff_hunk":"@@ -100,15 +96,20 @@ export default function getMediaKeysInfos(\n           const { serverCertificate } = options;\n           return (\n             serverCertificate != null ?\n-            setServerCertificate(mediaKeys, serverCertificate, errorStream) :\n-            observableOf(null)\n-          ).pipe(mapTo({\n-            mediaKeySystemAccess,\n-            keySystemOptions: options,\n-            mediaKeys,\n-            sessionsStore,\n-            sessionStorage: createSessionStorage(options),\n-          }));\n+              setServerCertificate(mediaKeys, serverCertificate) :\n+              observableOf(null)\n+          ).pipe(\n+            map((error) => {\n+                return {\n+                  mediaKeySystemAccess,\n+                  keySystemOptions: options,\n+                  mediaKeys,\n+                  sessionsStore,\n+                  sessionStorage: createSessionStorage(options),\n+                  serverCertificateWarning: error,","path":"src/core/eme/get_media_keys.ts","position":51,"original_position":51,"commit_id":"96d242a638c4ea5f848771b456d4387f0bc32ca0","original_commit_id":"96d242a638c4ea5f848771b456d4387f0bc32ca0","user":{"login":"peaBerberian","id":8694124,"node_id":"MDQ6VXNlcjg2OTQxMjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/8694124?v=4","gravatar_id":"","url":"https://api.github.com/users/peaBerberian","html_url":"https://github.com/peaBerberian","followers_url":"https://api.github.com/users/peaBerberian/followers","following_url":"https://api.github.com/users/peaBerberian/following{/other_user}","gists_url":"https://api.github.com/users/peaBerberian/gists{/gist_id}","starred_url":"https://api.github.com/users/peaBerberian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peaBerberian/subscriptions","organizations_url":"https://api.github.com/users/peaBerberian/orgs","repos_url":"https://api.github.com/users/peaBerberian/repos","events_url":"https://api.github.com/users/peaBerberian/events{/privacy}","received_events_url":"https://api.github.com/users/peaBerberian/received_events","type":"User","site_admin":false},"body":"This is ugly. No way for a better solution?","created_at":"2018-09-11T13:28:46Z","updated_at":"2018-09-11T13:31:56Z","html_url":"https://github.com/canalplus/rx-player/pull/305#discussion_r216668300","pull_request_url":"https://api.github.com/repos/canalplus/rx-player/pulls/305","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/canalplus/rx-player/pulls/comments/216668300"},"html":{"href":"https://github.com/canalplus/rx-player/pull/305#discussion_r216668300"},"pull_request":{"href":"https://api.github.com/repos/canalplus/rx-player/pulls/305"}}},"pull_request":{"url":"https://api.github.com/repos/canalplus/rx-player/pulls/305","id":213316858,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMzE2ODU4","html_url":"https://github.com/canalplus/rx-player/pull/305","diff_url":"https://github.com/canalplus/rx-player/pull/305.diff","patch_url":"https://github.com/canalplus/rx-player/pull/305.patch","issue_url":"https://api.github.com/repos/canalplus/rx-player/issues/305","number":305,"state":"open","locked":false,"title":"Expired status different handling","user":{"login":"grenault73","id":12694091,"node_id":"MDQ6VXNlcjEyNjk0MDkx","avatar_url":"https://avatars0.githubusercontent.com/u/12694091?v=4","gravatar_id":"","url":"https://api.github.com/users/grenault73","html_url":"https://github.com/grenault73","followers_url":"https://api.github.com/users/grenault73/followers","following_url":"https://api.github.com/users/grenault73/following{/other_user}","gists_url":"https://api.github.com/users/grenault73/gists{/gist_id}","starred_url":"https://api.github.com/users/grenault73/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grenault73/subscriptions","organizations_url":"https://api.github.com/users/grenault73/orgs","repos_url":"https://api.github.com/users/grenault73/repos","events_url":"https://api.github.com/users/grenault73/events{/privacy}","received_events_url":"https://api.github.com/users/grenault73/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-05T14:33:17Z","updated_at":"2018-09-11T13:31:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aded213303c364283a170c52a972d682c3fc0212","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":708611609,"node_id":"MDU6TGFiZWw3MDg2MTE2MDk=","url":"https://api.github.com/repos/canalplus/rx-player/labels/API","name":"API","color":"000000","default":false},{"id":708610591,"node_id":"MDU6TGFiZWw3MDg2MTA1OTE=","url":"https://api.github.com/repos/canalplus/rx-player/labels/EME","name":"EME","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/canalplus/rx-player/pulls/305/commits","review_comments_url":"https://api.github.com/repos/canalplus/rx-player/pulls/305/comments","review_comment_url":"https://api.github.com/repos/canalplus/rx-player/pulls/comments{/number}","comments_url":"https://api.github.com/repos/canalplus/rx-player/issues/305/comments","statuses_url":"https://api.github.com/repos/canalplus/rx-player/statuses/96d242a638c4ea5f848771b456d4387f0bc32ca0","head":{"label":"canalplus:misc/expiredStatus","ref":"misc/expiredStatus","sha":"96d242a638c4ea5f848771b456d4387f0bc32ca0","user":{"login":"canalplus","id":2371279,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNzEyNzk=","avatar_url":"https://avatars2.githubusercontent.com/u/2371279?v=4","gravatar_id":"","url":"https://api.github.com/users/canalplus","html_url":"https://github.com/canalplus","followers_url":"https://api.github.com/users/canalplus/followers","following_url":"https://api.github.com/users/canalplus/following{/other_user}","gists_url":"https://api.github.com/users/canalplus/gists{/gist_id}","starred_url":"https://api.github.com/users/canalplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canalplus/subscriptions","organizations_url":"https://api.github.com/users/canalplus/orgs","repos_url":"https://api.github.com/users/canalplus/repos","events_url":"https://api.github.com/users/canalplus/events{/privacy}","received_events_url":"https://api.github.com/users/canalplus/received_events","type":"Organization","site_admin":false},"repo":{"id":37657658,"node_id":"MDEwOlJlcG9zaXRvcnkzNzY1NzY1OA==","name":"rx-player","full_name":"canalplus/rx-player","owner":{"login":"canalplus","id":2371279,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNzEyNzk=","avatar_url":"https://avatars2.githubusercontent.com/u/2371279?v=4","gravatar_id":"","url":"https://api.github.com/users/canalplus","html_url":"https://github.com/canalplus","followers_url":"https://api.github.com/users/canalplus/followers","following_url":"https://api.github.com/users/canalplus/following{/other_user}","gists_url":"https://api.github.com/users/canalplus/gists{/gist_id}","starred_url":"https://api.github.com/users/canalplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canalplus/subscriptions","organizations_url":"https://api.github.com/users/canalplus/orgs","repos_url":"https://api.github.com/users/canalplus/repos","events_url":"https://api.github.com/users/canalplus/events{/privacy}","received_events_url":"https://api.github.com/users/canalplus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/canalplus/rx-player","description":"Smooth/DASH HTML5 Video Player","fork":false,"url":"https://api.github.com/repos/canalplus/rx-player","forks_url":"https://api.github.com/repos/canalplus/rx-player/forks","keys_url":"https://api.github.com/repos/canalplus/rx-player/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canalplus/rx-player/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canalplus/rx-player/teams","hooks_url":"https://api.github.com/repos/canalplus/rx-player/hooks","issue_events_url":"https://api.github.com/repos/canalplus/rx-player/issues/events{/number}","events_url":"https://api.github.com/repos/canalplus/rx-player/events","assignees_url":"https://api.github.com/repos/canalplus/rx-player/assignees{/user}","branches_url":"https://api.github.com/repos/canalplus/rx-player/branches{/branch}","tags_url":"https://api.github.com/repos/canalplus/rx-player/tags","blobs_url":"https://api.github.com/repos/canalplus/rx-player/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canalplus/rx-player/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canalplus/rx-player/git/refs{/sha}","trees_url":"https://api.github.com/repos/canalplus/rx-player/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canalplus/rx-player/statuses/{sha}","languages_url":"https://api.github.com/repos/canalplus/rx-player/languages","stargazers_url":"https://api.github.com/repos/canalplus/rx-player/stargazers","contributors_url":"https://api.github.com/repos/canalplus/rx-player/contributors","subscribers_url":"https://api.github.com/repos/canalplus/rx-player/subscribers","subscription_url":"https://api.github.com/repos/canalplus/rx-player/subscription","commits_url":"https://api.github.com/repos/canalplus/rx-player/commits{/sha}","git_commits_url":"https://api.github.com/repos/canalplus/rx-player/git/commits{/sha}","comments_url":"https://api.github.com/repos/canalplus/rx-player/comments{/number}","issue_comment_url":"https://api.github.com/repos/canalplus/rx-player/issues/comments{/number}","contents_url":"https://api.github.com/repos/canalplus/rx-player/contents/{+path}","compare_url":"https://api.github.com/repos/canalplus/rx-player/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canalplus/rx-player/merges","archive_url":"https://api.github.com/repos/canalplus/rx-player/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canalplus/rx-player/downloads","issues_url":"https://api.github.com/repos/canalplus/rx-player/issues{/number}","pulls_url":"https://api.github.com/repos/canalplus/rx-player/pulls{/number}","milestones_url":"https://api.github.com/repos/canalplus/rx-player/milestones{/number}","notifications_url":"https://api.github.com/repos/canalplus/rx-player/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canalplus/rx-player/labels{/name}","releases_url":"https://api.github.com/repos/canalplus/rx-player/releases{/id}","deployments_url":"https://api.github.com/repos/canalplus/rx-player/deployments","created_at":"2015-06-18T12:16:05Z","updated_at":"2018-09-11T13:07:14Z","pushed_at":"2018-09-11T13:23:43Z","git_url":"git://github.com/canalplus/rx-player.git","ssh_url":"git@github.com:canalplus/rx-player.git","clone_url":"https://github.com/canalplus/rx-player.git","svn_url":"https://github.com/canalplus/rx-player","homepage":"","size":37103,"stargazers_count":327,"watchers_count":327,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":49,"open_issues":17,"watchers":327,"default_branch":"master"}},"base":{"label":"canalplus:release/v3.7.0","ref":"release/v3.7.0","sha":"ba51fe49f7e6b3ca340c6f6313832265125688ef","user":{"login":"canalplus","id":2371279,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNzEyNzk=","avatar_url":"https://avatars2.githubusercontent.com/u/2371279?v=4","gravatar_id":"","url":"https://api.github.com/users/canalplus","html_url":"https://github.com/canalplus","followers_url":"https://api.github.com/users/canalplus/followers","following_url":"https://api.github.com/users/canalplus/following{/other_user}","gists_url":"https://api.github.com/users/canalplus/gists{/gist_id}","starred_url":"https://api.github.com/users/canalplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canalplus/subscriptions","organizations_url":"https://api.github.com/users/canalplus/orgs","repos_url":"https://api.github.com/users/canalplus/repos","events_url":"https://api.github.com/users/canalplus/events{/privacy}","received_events_url":"https://api.github.com/users/canalplus/received_events","type":"Organization","site_admin":false},"repo":{"id":37657658,"node_id":"MDEwOlJlcG9zaXRvcnkzNzY1NzY1OA==","name":"rx-player","full_name":"canalplus/rx-player","owner":{"login":"canalplus","id":2371279,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNzEyNzk=","avatar_url":"https://avatars2.githubusercontent.com/u/2371279?v=4","gravatar_id":"","url":"https://api.github.com/users/canalplus","html_url":"https://github.com/canalplus","followers_url":"https://api.github.com/users/canalplus/followers","following_url":"https://api.github.com/users/canalplus/following{/other_user}","gists_url":"https://api.github.com/users/canalplus/gists{/gist_id}","starred_url":"https://api.github.com/users/canalplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canalplus/subscriptions","organizations_url":"https://api.github.com/users/canalplus/orgs","repos_url":"https://api.github.com/users/canalplus/repos","events_url":"https://api.github.com/users/canalplus/events{/privacy}","received_events_url":"https://api.github.com/users/canalplus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/canalplus/rx-player","description":"Smooth/DASH HTML5 Video Player","fork":false,"url":"https://api.github.com/repos/canalplus/rx-player","forks_url":"https://api.github.com/repos/canalplus/rx-player/forks","keys_url":"https://api.github.com/repos/canalplus/rx-player/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canalplus/rx-player/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canalplus/rx-player/teams","hooks_url":"https://api.github.com/repos/canalplus/rx-player/hooks","issue_events_url":"https://api.github.com/repos/canalplus/rx-player/issues/events{/number}","events_url":"https://api.github.com/repos/canalplus/rx-player/events","assignees_url":"https://api.github.com/repos/canalplus/rx-player/assignees{/user}","branches_url":"https://api.github.com/repos/canalplus/rx-player/branches{/branch}","tags_url":"https://api.github.com/repos/canalplus/rx-player/tags","blobs_url":"https://api.github.com/repos/canalplus/rx-player/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canalplus/rx-player/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canalplus/rx-player/git/refs{/sha}","trees_url":"https://api.github.com/repos/canalplus/rx-player/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canalplus/rx-player/statuses/{sha}","languages_url":"https://api.github.com/repos/canalplus/rx-player/languages","stargazers_url":"https://api.github.com/repos/canalplus/rx-player/stargazers","contributors_url":"https://api.github.com/repos/canalplus/rx-player/contributors","subscribers_url":"https://api.github.com/repos/canalplus/rx-player/subscribers","subscription_url":"https://api.github.com/repos/canalplus/rx-player/subscription","commits_url":"https://api.github.com/repos/canalplus/rx-player/commits{/sha}","git_commits_url":"https://api.github.com/repos/canalplus/rx-player/git/commits{/sha}","comments_url":"https://api.github.com/repos/canalplus/rx-player/comments{/number}","issue_comment_url":"https://api.github.com/repos/canalplus/rx-player/issues/comments{/number}","contents_url":"https://api.github.com/repos/canalplus/rx-player/contents/{+path}","compare_url":"https://api.github.com/repos/canalplus/rx-player/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canalplus/rx-player/merges","archive_url":"https://api.github.com/repos/canalplus/rx-player/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canalplus/rx-player/downloads","issues_url":"https://api.github.com/repos/canalplus/rx-player/issues{/number}","pulls_url":"https://api.github.com/repos/canalplus/rx-player/pulls{/number}","milestones_url":"https://api.github.com/repos/canalplus/rx-player/milestones{/number}","notifications_url":"https://api.github.com/repos/canalplus/rx-player/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canalplus/rx-player/labels{/name}","releases_url":"https://api.github.com/repos/canalplus/rx-player/releases{/id}","deployments_url":"https://api.github.com/repos/canalplus/rx-player/deployments","created_at":"2015-06-18T12:16:05Z","updated_at":"2018-09-11T13:07:14Z","pushed_at":"2018-09-11T13:23:43Z","git_url":"git://github.com/canalplus/rx-player.git","ssh_url":"git@github.com:canalplus/rx-player.git","clone_url":"https://github.com/canalplus/rx-player.git","svn_url":"https://github.com/canalplus/rx-player","homepage":"","size":37103,"stargazers_count":327,"watchers_count":327,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":49,"open_issues":17,"watchers":327,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/canalplus/rx-player/pulls/305"},"html":{"href":"https://github.com/canalplus/rx-player/pull/305"},"issue":{"href":"https://api.github.com/repos/canalplus/rx-player/issues/305"},"comments":{"href":"https://api.github.com/repos/canalplus/rx-player/issues/305/comments"},"review_comments":{"href":"https://api.github.com/repos/canalplus/rx-player/pulls/305/comments"},"review_comment":{"href":"https://api.github.com/repos/canalplus/rx-player/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/canalplus/rx-player/pulls/305/commits"},"statuses":{"href":"https://api.github.com/repos/canalplus/rx-player/statuses/96d242a638c4ea5f848771b456d4387f0bc32ca0"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"peaBerberian"}}