{"action":"created","comment":{"url":"https://api.github.com/repos/uber/pyro/pulls/comments/168555558","pull_request_review_id":96943729,"id":168555558,"diff_hunk":"@@ -0,0 +1,105 @@\n+from __future__ import absolute_import, division, print_function\n+\n+import torch\n+from torch.autograd import Variable\n+from torch.distributions import constraints, transform_to\n+from torch.nn import Parameter\n+\n+import pyro\n+import pyro.distributions as dist\n+from pyro.distributions.util import matrix_triangular_solve_compat\n+\n+from .vgp import VariationalGP\n+\n+\n+class SparseVariationalGP(VariationalGP):","path":"pyro/contrib/gp/models/svgp.py","position":15,"original_position":15,"commit_id":"8358ee93a5c08bf183082f27a24f2cb44fd76d12","original_commit_id":"8358ee93a5c08bf183082f27a24f2cb44fd76d12","user":{"login":"martinjankowiak","id":22105218,"avatar_url":"https://avatars1.githubusercontent.com/u/22105218?v=4","gravatar_id":"","url":"https://api.github.com/users/martinjankowiak","html_url":"https://github.com/martinjankowiak","followers_url":"https://api.github.com/users/martinjankowiak/followers","following_url":"https://api.github.com/users/martinjankowiak/following{/other_user}","gists_url":"https://api.github.com/users/martinjankowiak/gists{/gist_id}","starred_url":"https://api.github.com/users/martinjankowiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinjankowiak/subscriptions","organizations_url":"https://api.github.com/users/martinjankowiak/orgs","repos_url":"https://api.github.com/users/martinjankowiak/repos","events_url":"https://api.github.com/users/martinjankowiak/events{/privacy}","received_events_url":"https://api.github.com/users/martinjankowiak/received_events","type":"User","site_admin":false},"body":"isn't your class hierarchy backwards here? ","created_at":"2018-02-15T17:50:37Z","updated_at":"2018-02-15T17:56:06Z","html_url":"https://github.com/uber/pyro/pull/747#discussion_r168555558","pull_request_url":"https://api.github.com/repos/uber/pyro/pulls/747","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/uber/pyro/pulls/comments/168555558"},"html":{"href":"https://github.com/uber/pyro/pull/747#discussion_r168555558"},"pull_request":{"href":"https://api.github.com/repos/uber/pyro/pulls/747"}}},"pull_request":{"url":"https://api.github.com/repos/uber/pyro/pulls/747","id":167748859,"html_url":"https://github.com/uber/pyro/pull/747","diff_url":"https://github.com/uber/pyro/pull/747.diff","patch_url":"https://github.com/uber/pyro/pull/747.patch","issue_url":"https://api.github.com/repos/uber/pyro/issues/747","number":747,"state":"open","locked":false,"title":"[Done] Implement sparse variational GP","user":{"login":"fehiepsi","id":4736342,"avatar_url":"https://avatars1.githubusercontent.com/u/4736342?v=4","gravatar_id":"","url":"https://api.github.com/users/fehiepsi","html_url":"https://github.com/fehiepsi","followers_url":"https://api.github.com/users/fehiepsi/followers","following_url":"https://api.github.com/users/fehiepsi/following{/other_user}","gists_url":"https://api.github.com/users/fehiepsi/gists{/gist_id}","starred_url":"https://api.github.com/users/fehiepsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fehiepsi/subscriptions","organizations_url":"https://api.github.com/users/fehiepsi/orgs","repos_url":"https://api.github.com/users/fehiepsi/repos","events_url":"https://api.github.com/users/fehiepsi/events{/privacy}","received_events_url":"https://api.github.com/users/fehiepsi/received_events","type":"User","site_admin":false},"body":"I am trying to implement the variational versions of GP models in this pull request. I will try to keep the same interface with GPR and SGPR models.\r\n\r\n- [x] Implement sparse variational GP\r\n- [x] Implement variational GP\r\n- [x] Add Likelihood module\r\n- [x] Add some tests / examples\r\n\r\nTo reviewers: During implementing GP models using Pyro, I understand more about both GP and Pyro. After finishing this pull request, I think it is a good moment to refactor/remove redundant codes. Below are something I will change (at least). So please ignore those points while reviewing, they will be addressed in the next pull request. \r\n- Remove `kernel_prior`, `Xu_prior` arguments in models. Instead, it is better to use a method `set_prior(param_name, param_distribution)`.\r\n- Remove MAP guide in model, move MAP guide to `Kernel` module (if that param has prior).\r\n- Remove InducingPoints module. I created this module to be able to set prior to the parameter `Xu`. With the `set_prior` method, we can remove it.","created_at":"2018-02-07T16:52:29Z","updated_at":"2018-02-15T17:56:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65cd5edab2c746e48ce68efbe90b936f5f9575d6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":704871691,"url":"https://api.github.com/repos/uber/pyro/labels/awaiting%20review","name":"awaiting review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/uber/pyro/pulls/747/commits","review_comments_url":"https://api.github.com/repos/uber/pyro/pulls/747/comments","review_comment_url":"https://api.github.com/repos/uber/pyro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/pyro/issues/747/comments","statuses_url":"https://api.github.com/repos/uber/pyro/statuses/8358ee93a5c08bf183082f27a24f2cb44fd76d12","head":{"label":"fehiepsi:svgp","ref":"svgp","sha":"8358ee93a5c08bf183082f27a24f2cb44fd76d12","user":{"login":"fehiepsi","id":4736342,"avatar_url":"https://avatars1.githubusercontent.com/u/4736342?v=4","gravatar_id":"","url":"https://api.github.com/users/fehiepsi","html_url":"https://github.com/fehiepsi","followers_url":"https://api.github.com/users/fehiepsi/followers","following_url":"https://api.github.com/users/fehiepsi/following{/other_user}","gists_url":"https://api.github.com/users/fehiepsi/gists{/gist_id}","starred_url":"https://api.github.com/users/fehiepsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fehiepsi/subscriptions","organizations_url":"https://api.github.com/users/fehiepsi/orgs","repos_url":"https://api.github.com/users/fehiepsi/repos","events_url":"https://api.github.com/users/fehiepsi/events{/privacy}","received_events_url":"https://api.github.com/users/fehiepsi/received_events","type":"User","site_admin":false},"repo":{"id":111098185,"name":"pyro","full_name":"fehiepsi/pyro","owner":{"login":"fehiepsi","id":4736342,"avatar_url":"https://avatars1.githubusercontent.com/u/4736342?v=4","gravatar_id":"","url":"https://api.github.com/users/fehiepsi","html_url":"https://github.com/fehiepsi","followers_url":"https://api.github.com/users/fehiepsi/followers","following_url":"https://api.github.com/users/fehiepsi/following{/other_user}","gists_url":"https://api.github.com/users/fehiepsi/gists{/gist_id}","starred_url":"https://api.github.com/users/fehiepsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fehiepsi/subscriptions","organizations_url":"https://api.github.com/users/fehiepsi/orgs","repos_url":"https://api.github.com/users/fehiepsi/repos","events_url":"https://api.github.com/users/fehiepsi/events{/privacy}","received_events_url":"https://api.github.com/users/fehiepsi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fehiepsi/pyro","description":"Deep universal probabilistic programming with Python and PyTorch","fork":true,"url":"https://api.github.com/repos/fehiepsi/pyro","forks_url":"https://api.github.com/repos/fehiepsi/pyro/forks","keys_url":"https://api.github.com/repos/fehiepsi/pyro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fehiepsi/pyro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fehiepsi/pyro/teams","hooks_url":"https://api.github.com/repos/fehiepsi/pyro/hooks","issue_events_url":"https://api.github.com/repos/fehiepsi/pyro/issues/events{/number}","events_url":"https://api.github.com/repos/fehiepsi/pyro/events","assignees_url":"https://api.github.com/repos/fehiepsi/pyro/assignees{/user}","branches_url":"https://api.github.com/repos/fehiepsi/pyro/branches{/branch}","tags_url":"https://api.github.com/repos/fehiepsi/pyro/tags","blobs_url":"https://api.github.com/repos/fehiepsi/pyro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fehiepsi/pyro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fehiepsi/pyro/git/refs{/sha}","trees_url":"https://api.github.com/repos/fehiepsi/pyro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fehiepsi/pyro/statuses/{sha}","languages_url":"https://api.github.com/repos/fehiepsi/pyro/languages","stargazers_url":"https://api.github.com/repos/fehiepsi/pyro/stargazers","contributors_url":"https://api.github.com/repos/fehiepsi/pyro/contributors","subscribers_url":"https://api.github.com/repos/fehiepsi/pyro/subscribers","subscription_url":"https://api.github.com/repos/fehiepsi/pyro/subscription","commits_url":"https://api.github.com/repos/fehiepsi/pyro/commits{/sha}","git_commits_url":"https://api.github.com/repos/fehiepsi/pyro/git/commits{/sha}","comments_url":"https://api.github.com/repos/fehiepsi/pyro/comments{/number}","issue_comment_url":"https://api.github.com/repos/fehiepsi/pyro/issues/comments{/number}","contents_url":"https://api.github.com/repos/fehiepsi/pyro/contents/{+path}","compare_url":"https://api.github.com/repos/fehiepsi/pyro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fehiepsi/pyro/merges","archive_url":"https://api.github.com/repos/fehiepsi/pyro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fehiepsi/pyro/downloads","issues_url":"https://api.github.com/repos/fehiepsi/pyro/issues{/number}","pulls_url":"https://api.github.com/repos/fehiepsi/pyro/pulls{/number}","milestones_url":"https://api.github.com/repos/fehiepsi/pyro/milestones{/number}","notifications_url":"https://api.github.com/repos/fehiepsi/pyro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fehiepsi/pyro/labels{/name}","releases_url":"https://api.github.com/repos/fehiepsi/pyro/releases{/id}","deployments_url":"https://api.github.com/repos/fehiepsi/pyro/deployments","created_at":"2017-11-17T11:55:02Z","updated_at":"2017-11-17T11:55:04Z","pushed_at":"2018-02-15T03:46:04Z","git_url":"git://github.com/fehiepsi/pyro.git","ssh_url":"git@github.com:fehiepsi/pyro.git","clone_url":"https://github.com/fehiepsi/pyro.git","svn_url":"https://github.com/fehiepsi/pyro","homepage":"http://pyro.ai","size":29446,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":1,"watchers":0,"default_branch":"dev"}},"base":{"label":"uber:dev","ref":"dev","sha":"6422ee88a9a3bdfd93ec98d2def1e9f2b02eacab","user":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":94506832,"name":"pyro","full_name":"uber/pyro","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/pyro","description":"Deep universal probabilistic programming with Python and PyTorch","fork":false,"url":"https://api.github.com/repos/uber/pyro","forks_url":"https://api.github.com/repos/uber/pyro/forks","keys_url":"https://api.github.com/repos/uber/pyro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/pyro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/pyro/teams","hooks_url":"https://api.github.com/repos/uber/pyro/hooks","issue_events_url":"https://api.github.com/repos/uber/pyro/issues/events{/number}","events_url":"https://api.github.com/repos/uber/pyro/events","assignees_url":"https://api.github.com/repos/uber/pyro/assignees{/user}","branches_url":"https://api.github.com/repos/uber/pyro/branches{/branch}","tags_url":"https://api.github.com/repos/uber/pyro/tags","blobs_url":"https://api.github.com/repos/uber/pyro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/pyro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/pyro/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/pyro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/pyro/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/pyro/languages","stargazers_url":"https://api.github.com/repos/uber/pyro/stargazers","contributors_url":"https://api.github.com/repos/uber/pyro/contributors","subscribers_url":"https://api.github.com/repos/uber/pyro/subscribers","subscription_url":"https://api.github.com/repos/uber/pyro/subscription","commits_url":"https://api.github.com/repos/uber/pyro/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/pyro/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/pyro/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/pyro/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/pyro/contents/{+path}","compare_url":"https://api.github.com/repos/uber/pyro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/pyro/merges","archive_url":"https://api.github.com/repos/uber/pyro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/pyro/downloads","issues_url":"https://api.github.com/repos/uber/pyro/issues{/number}","pulls_url":"https://api.github.com/repos/uber/pyro/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/pyro/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/pyro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/pyro/labels{/name}","releases_url":"https://api.github.com/repos/uber/pyro/releases{/id}","deployments_url":"https://api.github.com/repos/uber/pyro/deployments","created_at":"2017-06-16T05:03:47Z","updated_at":"2018-02-15T17:29:35Z","pushed_at":"2018-02-15T17:55:11Z","git_url":"git://github.com/uber/pyro.git","ssh_url":"git@github.com:uber/pyro.git","clone_url":"https://github.com/uber/pyro.git","svn_url":"https://github.com/uber/pyro","homepage":"http://pyro.ai","size":49497,"stargazers_count":2834,"watchers_count":2834,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":276,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":276,"open_issues":64,"watchers":2834,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/pyro/pulls/747"},"html":{"href":"https://github.com/uber/pyro/pull/747"},"issue":{"href":"https://api.github.com/repos/uber/pyro/issues/747"},"comments":{"href":"https://api.github.com/repos/uber/pyro/issues/747/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/pyro/pulls/747/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/pyro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/pyro/pulls/747/commits"},"statuses":{"href":"https://api.github.com/repos/uber/pyro/statuses/8358ee93a5c08bf183082f27a24f2cb44fd76d12"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"martinjankowiak"}}