{"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/208314660","pull_request_review_id":144098975,"id":208314660,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODMxNDY2MA==","diff_hunk":"@@ -537,6 +563,56 @@ fileExplainForeignScan(ForeignScanState *node, ExplainState *es)\n \t}\n }\n \n+typedef struct FileCallbackExtra {\n+\tchar *filename;\n+\tFILE *file;\n+\tbool opened;\n+\tbool eof;","path":"contrib/file_fdw/file_fdw.c","position":55,"original_position":55,"commit_id":"e28088fd41e4c8efbe4f7c01d5142ffbd510d6e1","original_commit_id":"e28088fd41e4c8efbe4f7c01d5142ffbd510d6e1","user":{"login":"asimrp","id":4307811,"node_id":"MDQ6VXNlcjQzMDc4MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/4307811?v=4","gravatar_id":"","url":"https://api.github.com/users/asimrp","html_url":"https://github.com/asimrp","followers_url":"https://api.github.com/users/asimrp/followers","following_url":"https://api.github.com/users/asimrp/following{/other_user}","gists_url":"https://api.github.com/users/asimrp/gists{/gist_id}","starred_url":"https://api.github.com/users/asimrp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asimrp/subscriptions","organizations_url":"https://api.github.com/users/asimrp/orgs","repos_url":"https://api.github.com/users/asimrp/repos","events_url":"https://api.github.com/users/asimrp/events{/privacy}","received_events_url":"https://api.github.com/users/asimrp/received_events","type":"User","site_admin":false},"body":"This field seems redundant to me because `feof(file)` can always be checked as long as the file is opened.","created_at":"2018-08-07T17:18:53Z","updated_at":"2018-08-07T17:25:12Z","html_url":"https://github.com/greenplum-db/gpdb/pull/5413#discussion_r208314660","pull_request_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/5413","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/208314660"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/5413#discussion_r208314660"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/5413"}}},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/5413","id":206604673,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NjA0Njcz","html_url":"https://github.com/greenplum-db/gpdb/pull/5413","diff_url":"https://github.com/greenplum-db/gpdb/pull/5413.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/5413.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/5413","number":5413,"state":"open","locked":false,"title":" Add support for executing foreign tables on master, any or all segments (options way)","user":{"login":"adam8157","id":153160,"node_id":"MDQ6VXNlcjE1MzE2MA==","avatar_url":"https://avatars0.githubusercontent.com/u/153160?v=4","gravatar_id":"","url":"https://api.github.com/users/adam8157","html_url":"https://github.com/adam8157","followers_url":"https://api.github.com/users/adam8157/followers","following_url":"https://api.github.com/users/adam8157/following{/other_user}","gists_url":"https://api.github.com/users/adam8157/gists{/gist_id}","starred_url":"https://api.github.com/users/adam8157/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam8157/subscriptions","organizations_url":"https://api.github.com/users/adam8157/orgs","repos_url":"https://api.github.com/users/adam8157/repos","events_url":"https://api.github.com/users/adam8157/events{/privacy}","received_events_url":"https://api.github.com/users/adam8157/received_events","type":"User","site_admin":false},"body":"Specify mpp_execute in options, but store into catalog and separate out it when creating foreign tables, to have the compatibility and the ability to know mpp_execute at the same time.","created_at":"2018-08-07T07:30:28Z","updated_at":"2018-08-07T17:25:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"550f2db5e1e1a1fca5a63160809f646667e6a648","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hlinnaka","id":191602,"node_id":"MDQ6VXNlcjE5MTYwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/191602?v=4","gravatar_id":"","url":"https://api.github.com/users/hlinnaka","html_url":"https://github.com/hlinnaka","followers_url":"https://api.github.com/users/hlinnaka/followers","following_url":"https://api.github.com/users/hlinnaka/following{/other_user}","gists_url":"https://api.github.com/users/hlinnaka/gists{/gist_id}","starred_url":"https://api.github.com/users/hlinnaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlinnaka/subscriptions","organizations_url":"https://api.github.com/users/hlinnaka/orgs","repos_url":"https://api.github.com/users/hlinnaka/repos","events_url":"https://api.github.com/users/hlinnaka/events{/privacy}","received_events_url":"https://api.github.com/users/hlinnaka/received_events","type":"User","site_admin":false},{"login":"danielgustafsson","id":321790,"node_id":"MDQ6VXNlcjMyMTc5MA==","avatar_url":"https://avatars2.githubusercontent.com/u/321790?v=4","gravatar_id":"","url":"https://api.github.com/users/danielgustafsson","html_url":"https://github.com/danielgustafsson","followers_url":"https://api.github.com/users/danielgustafsson/followers","following_url":"https://api.github.com/users/danielgustafsson/following{/other_user}","gists_url":"https://api.github.com/users/danielgustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgustafsson/subscriptions","organizations_url":"https://api.github.com/users/danielgustafsson/orgs","repos_url":"https://api.github.com/users/danielgustafsson/repos","events_url":"https://api.github.com/users/danielgustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/danielgustafsson/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/5413/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/5413/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/5413/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/e28088fd41e4c8efbe4f7c01d5142ffbd510d6e1","head":{"label":"adam8157:mpp_fdw_option","ref":"mpp_fdw_option","sha":"e28088fd41e4c8efbe4f7c01d5142ffbd510d6e1","user":{"login":"adam8157","id":153160,"node_id":"MDQ6VXNlcjE1MzE2MA==","avatar_url":"https://avatars0.githubusercontent.com/u/153160?v=4","gravatar_id":"","url":"https://api.github.com/users/adam8157","html_url":"https://github.com/adam8157","followers_url":"https://api.github.com/users/adam8157/followers","following_url":"https://api.github.com/users/adam8157/following{/other_user}","gists_url":"https://api.github.com/users/adam8157/gists{/gist_id}","starred_url":"https://api.github.com/users/adam8157/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam8157/subscriptions","organizations_url":"https://api.github.com/users/adam8157/orgs","repos_url":"https://api.github.com/users/adam8157/repos","events_url":"https://api.github.com/users/adam8157/events{/privacy}","received_events_url":"https://api.github.com/users/adam8157/received_events","type":"User","site_admin":false},"repo":{"id":52776218,"node_id":"MDEwOlJlcG9zaXRvcnk1Mjc3NjIxOA==","name":"gpdb","full_name":"adam8157/gpdb","owner":{"login":"adam8157","id":153160,"node_id":"MDQ6VXNlcjE1MzE2MA==","avatar_url":"https://avatars0.githubusercontent.com/u/153160?v=4","gravatar_id":"","url":"https://api.github.com/users/adam8157","html_url":"https://github.com/adam8157","followers_url":"https://api.github.com/users/adam8157/followers","following_url":"https://api.github.com/users/adam8157/following{/other_user}","gists_url":"https://api.github.com/users/adam8157/gists{/gist_id}","starred_url":"https://api.github.com/users/adam8157/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam8157/subscriptions","organizations_url":"https://api.github.com/users/adam8157/orgs","repos_url":"https://api.github.com/users/adam8157/repos","events_url":"https://api.github.com/users/adam8157/events{/privacy}","received_events_url":"https://api.github.com/users/adam8157/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adam8157/gpdb","description":"Greenplum Database","fork":true,"url":"https://api.github.com/repos/adam8157/gpdb","forks_url":"https://api.github.com/repos/adam8157/gpdb/forks","keys_url":"https://api.github.com/repos/adam8157/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adam8157/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adam8157/gpdb/teams","hooks_url":"https://api.github.com/repos/adam8157/gpdb/hooks","issue_events_url":"https://api.github.com/repos/adam8157/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/adam8157/gpdb/events","assignees_url":"https://api.github.com/repos/adam8157/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/adam8157/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/adam8157/gpdb/tags","blobs_url":"https://api.github.com/repos/adam8157/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adam8157/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adam8157/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/adam8157/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adam8157/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/adam8157/gpdb/languages","stargazers_url":"https://api.github.com/repos/adam8157/gpdb/stargazers","contributors_url":"https://api.github.com/repos/adam8157/gpdb/contributors","subscribers_url":"https://api.github.com/repos/adam8157/gpdb/subscribers","subscription_url":"https://api.github.com/repos/adam8157/gpdb/subscription","commits_url":"https://api.github.com/repos/adam8157/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/adam8157/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/adam8157/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/adam8157/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/adam8157/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/adam8157/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adam8157/gpdb/merges","archive_url":"https://api.github.com/repos/adam8157/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adam8157/gpdb/downloads","issues_url":"https://api.github.com/repos/adam8157/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/adam8157/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/adam8157/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/adam8157/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adam8157/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/adam8157/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/adam8157/gpdb/deployments","created_at":"2016-02-29T08:35:15Z","updated_at":"2018-08-07T02:40:32Z","pushed_at":"2018-08-07T09:04:29Z","git_url":"git://github.com/adam8157/gpdb.git","ssh_url":"git@github.com:adam8157/gpdb.git","clone_url":"https://github.com/adam8157/gpdb.git","svn_url":"https://github.com/adam8157/gpdb","homepage":"http://greenplum.org","size":285887,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"01a39f36c6efbaf25d7c2566ba398727b0453b6f","user":{"login":"greenplum-db","id":14097842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDk3ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":44781140,"node_id":"MDEwOlJlcG9zaXRvcnk0NDc4MTE0MA==","name":"gpdb","full_name":"greenplum-db/gpdb","owner":{"login":"greenplum-db","id":14097842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDk3ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gpdb","description":"Greenplum Database","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb","forks_url":"https://api.github.com/repos/greenplum-db/gpdb/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb/deployments","created_at":"2015-10-23T00:25:17Z","updated_at":"2018-08-07T14:52:13Z","pushed_at":"2018-08-07T17:14:14Z","git_url":"git://github.com/greenplum-db/gpdb.git","ssh_url":"git@github.com:greenplum-db/gpdb.git","clone_url":"https://github.com/greenplum-db/gpdb.git","svn_url":"https://github.com/greenplum-db/gpdb","homepage":"http://greenplum.org","size":293162,"stargazers_count":2606,"watchers_count":2606,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":807,"mirror_url":null,"archived":false,"open_issues_count":221,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":807,"open_issues":221,"watchers":2606,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/5413"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/5413"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/5413"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/5413/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/5413/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/5413/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb/statuses/e28088fd41e4c8efbe4f7c01d5142ffbd510d6e1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"asimrp"}}