{"action":"created","issue":{"url":"https://api.github.com/repos/MikeInnes/MacroTools.jl/issues/100","repository_url":"https://api.github.com/repos/MikeInnes/MacroTools.jl","labels_url":"https://api.github.com/repos/MikeInnes/MacroTools.jl/issues/100/labels{/name}","comments_url":"https://api.github.com/repos/MikeInnes/MacroTools.jl/issues/100/comments","events_url":"https://api.github.com/repos/MikeInnes/MacroTools.jl/issues/100/events","html_url":"https://github.com/MikeInnes/MacroTools.jl/pull/100","id":362904666,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NDg3MjYw","number":100,"title":"more faithfully reconstruct original function in combinedef","user":{"login":"marius311","id":1510968,"node_id":"MDQ6VXNlcjE1MTA5Njg=","avatar_url":"https://avatars3.githubusercontent.com/u/1510968?v=4","gravatar_id":"","url":"https://api.github.com/users/marius311","html_url":"https://github.com/marius311","followers_url":"https://api.github.com/users/marius311/followers","following_url":"https://api.github.com/users/marius311/following{/other_user}","gists_url":"https://api.github.com/users/marius311/gists{/gist_id}","starred_url":"https://api.github.com/users/marius311/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marius311/subscriptions","organizations_url":"https://api.github.com/users/marius311/orgs","repos_url":"https://api.github.com/users/marius311/repos","events_url":"https://api.github.com/users/marius311/events{/privacy}","received_events_url":"https://api.github.com/users/marius311/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-23T01:30:24Z","updated_at":"2018-09-23T12:06:37Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/MikeInnes/MacroTools.jl/pulls/100","html_url":"https://github.com/MikeInnes/MacroTools.jl/pull/100","diff_url":"https://github.com/MikeInnes/MacroTools.jl/pull/100.diff","patch_url":"https://github.com/MikeInnes/MacroTools.jl/pull/100.patch"},"body":"Previously `combinedef` would put an `::Any` return type annotation on any function it reconstructed that didn't have one originally, and also wrap the function body in one extra `begin` block. These both seem completely superfluous except amazingly when combined they trigger the bug I reported here: https://github.com/JuliaLang/julia/issues/29326. \r\n\r\nThis PR gets rid of those things and more faithfully reconstructs the original function. \r\n\r\nI also switched to returning the expression via `@q` which would allow whatever macro is calling `combinedef` to insert the desired line numbers in there. "},"comment":{"url":"https://api.github.com/repos/MikeInnes/MacroTools.jl/issues/comments/423811697","html_url":"https://github.com/MikeInnes/MacroTools.jl/pull/100#issuecomment-423811697","issue_url":"https://api.github.com/repos/MikeInnes/MacroTools.jl/issues/100","id":423811697,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzgxMTY5Nw==","user":{"login":"marius311","id":1510968,"node_id":"MDQ6VXNlcjE1MTA5Njg=","avatar_url":"https://avatars3.githubusercontent.com/u/1510968?v=4","gravatar_id":"","url":"https://api.github.com/users/marius311","html_url":"https://github.com/marius311","followers_url":"https://api.github.com/users/marius311/followers","following_url":"https://api.github.com/users/marius311/following{/other_user}","gists_url":"https://api.github.com/users/marius311/gists{/gist_id}","starred_url":"https://api.github.com/users/marius311/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marius311/subscriptions","organizations_url":"https://api.github.com/users/marius311/orgs","repos_url":"https://api.github.com/users/marius311/repos","events_url":"https://api.github.com/users/marius311/events{/privacy}","received_events_url":"https://api.github.com/users/marius311/received_events","type":"User","site_admin":false},"created_at":"2018-09-23T12:06:37Z","updated_at":"2018-09-23T12:06:37Z","author_association":"NONE","body":"Played around with it some more following your comment @cstjean, I'm fairly convinced now that the right way to interpolate the body is always via `$(body.args...)`, otherwise you gain a begin/end block every time you do it, since `@capture` seems to in all cases give the body as a begin/end block. I've changed everything to work that way. E.g.\r\n\r\n![image](https://user-images.githubusercontent.com/1510968/45927814-757d7f00-bf39-11e8-9702-64a0eb204355.png)\r\n"}}
{"actor":{"display_login":"marius311"}}