{"action":"created","issue":{"url":"https://api.github.com/repos/codice/ddf/issues/3655","repository_url":"https://api.github.com/repos/codice/ddf","labels_url":"https://api.github.com/repos/codice/ddf/issues/3655/labels{/name}","comments_url":"https://api.github.com/repos/codice/ddf/issues/3655/comments","events_url":"https://api.github.com/repos/codice/ddf/issues/3655/events","html_url":"https://github.com/codice/ddf/pull/3655","id":353848993,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNzg4NzE3","number":3655,"title":"DDF-4034 Restructuring Sharing to Support Access Control","user":{"login":"Schachte","id":7055226,"node_id":"MDQ6VXNlcjcwNTUyMjY=","avatar_url":"https://avatars1.githubusercontent.com/u/7055226?v=4","gravatar_id":"","url":"https://api.github.com/users/Schachte","html_url":"https://github.com/Schachte","followers_url":"https://api.github.com/users/Schachte/followers","following_url":"https://api.github.com/users/Schachte/following{/other_user}","gists_url":"https://api.github.com/users/Schachte/gists{/gist_id}","starred_url":"https://api.github.com/users/Schachte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Schachte/subscriptions","organizations_url":"https://api.github.com/users/Schachte/orgs","repos_url":"https://api.github.com/users/Schachte/repos","events_url":"https://api.github.com/users/Schachte/events{/privacy}","received_events_url":"https://api.github.com/users/Schachte/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"pklinef","id":700518,"node_id":"MDQ6VXNlcjcwMDUxOA==","avatar_url":"https://avatars1.githubusercontent.com/u/700518?v=4","gravatar_id":"","url":"https://api.github.com/users/pklinef","html_url":"https://github.com/pklinef","followers_url":"https://api.github.com/users/pklinef/followers","following_url":"https://api.github.com/users/pklinef/following{/other_user}","gists_url":"https://api.github.com/users/pklinef/gists{/gist_id}","starred_url":"https://api.github.com/users/pklinef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pklinef/subscriptions","organizations_url":"https://api.github.com/users/pklinef/orgs","repos_url":"https://api.github.com/users/pklinef/repos","events_url":"https://api.github.com/users/pklinef/events{/privacy}","received_events_url":"https://api.github.com/users/pklinef/received_events","type":"User","site_admin":false},"assignees":[{"login":"pklinef","id":700518,"node_id":"MDQ6VXNlcjcwMDUxOA==","avatar_url":"https://avatars1.githubusercontent.com/u/700518?v=4","gravatar_id":"","url":"https://api.github.com/users/pklinef","html_url":"https://github.com/pklinef","followers_url":"https://api.github.com/users/pklinef/followers","following_url":"https://api.github.com/users/pklinef/following{/other_user}","gists_url":"https://api.github.com/users/pklinef/gists{/gist_id}","starred_url":"https://api.github.com/users/pklinef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pklinef/subscriptions","organizations_url":"https://api.github.com/users/pklinef/orgs","repos_url":"https://api.github.com/users/pklinef/repos","events_url":"https://api.github.com/users/pklinef/events{/privacy}","received_events_url":"https://api.github.com/users/pklinef/received_events","type":"User","site_admin":false},{"login":"djblue","id":1986211,"node_id":"MDQ6VXNlcjE5ODYyMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1986211?v=4","gravatar_id":"","url":"https://api.github.com/users/djblue","html_url":"https://github.com/djblue","followers_url":"https://api.github.com/users/djblue/followers","following_url":"https://api.github.com/users/djblue/following{/other_user}","gists_url":"https://api.github.com/users/djblue/gists{/gist_id}","starred_url":"https://api.github.com/users/djblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djblue/subscriptions","organizations_url":"https://api.github.com/users/djblue/orgs","repos_url":"https://api.github.com/users/djblue/repos","events_url":"https://api.github.com/users/djblue/events{/privacy}","received_events_url":"https://api.github.com/users/djblue/received_events","type":"User","site_admin":false},{"login":"stustison","id":4391679,"node_id":"MDQ6VXNlcjQzOTE2Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/4391679?v=4","gravatar_id":"","url":"https://api.github.com/users/stustison","html_url":"https://github.com/stustison","followers_url":"https://api.github.com/users/stustison/followers","following_url":"https://api.github.com/users/stustison/following{/other_user}","gists_url":"https://api.github.com/users/stustison/gists{/gist_id}","starred_url":"https://api.github.com/users/stustison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stustison/subscriptions","organizations_url":"https://api.github.com/users/stustison/orgs","repos_url":"https://api.github.com/users/stustison/repos","events_url":"https://api.github.com/users/stustison/events{/privacy}","received_events_url":"https://api.github.com/users/stustison/received_events","type":"User","site_admin":false},{"login":"bdeining","id":6551038,"node_id":"MDQ6VXNlcjY1NTEwMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/6551038?v=4","gravatar_id":"","url":"https://api.github.com/users/bdeining","html_url":"https://github.com/bdeining","followers_url":"https://api.github.com/users/bdeining/followers","following_url":"https://api.github.com/users/bdeining/following{/other_user}","gists_url":"https://api.github.com/users/bdeining/gists{/gist_id}","starred_url":"https://api.github.com/users/bdeining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdeining/subscriptions","organizations_url":"https://api.github.com/users/bdeining/orgs","repos_url":"https://api.github.com/users/bdeining/repos","events_url":"https://api.github.com/users/bdeining/events{/privacy}","received_events_url":"https://api.github.com/users/bdeining/received_events","type":"User","site_admin":false}],"milestone":null,"comments":27,"created_at":"2018-08-24T16:26:38Z","updated_at":"2018-09-05T22:08:06Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/3655","html_url":"https://github.com/codice/ddf/pull/3655","diff_url":"https://github.com/codice/ddf/pull/3655.diff","patch_url":"https://github.com/codice/ddf/pull/3655.patch"},"body":"#### What does this PR do?\r\nIncorporates idea of access control into metacards and removes any \"shareability\".  \r\n\r\n#### Who is reviewing it? \r\n@bdeining \r\n@djblue \r\n@pklinef \r\n@Lambeaux \r\n@troymohl \r\n@middlets719 \r\n@stustison \r\n\r\n#### How should this be tested?\r\nShare workspaces and search forms and ensure it still works. \r\n\r\n#### Any background context you want to provide?\r\nInitially, we incorporated the idea of sharing. Sharing was a requirement for only workspaces. This idea has now expanded for multiple metacard types and has become hard to manage as types grows. We tightly coupled sharing to tag types as well as the implementation types. This PR seeks to abstract \"sharing\" to only utilize security attributes and add more of an _access control_ feel to the process by introducing `security.access-administrators`. \r\n\r\n#### What are the relevant tickets?\r\n[DDF-4034](https://codice.atlassian.net/browse/DDF-4034)\r\n#### Screenshots\r\nSimple Decision Tree Overview\r\n<img width=\"1077\" alt=\"screen shot 2018-08-24 at 12 35 35 pm\" src=\"https://user-images.githubusercontent.com/7055226/44596458-3a512a00-a79a-11e8-88a4-f78cc035d346.png\">\r\n\r\n<!--(if appropriate)-->\r\n#### Checklist:\r\n- [ x ] Documentation Updated\r\n- [ x ] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n"},"comment":{"url":"https://api.github.com/repos/codice/ddf/issues/comments/418897490","html_url":"https://github.com/codice/ddf/pull/3655#issuecomment-418897490","issue_url":"https://api.github.com/repos/codice/ddf/issues/3655","id":418897490,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODg5NzQ5MA==","user":{"login":"Schachte","id":7055226,"node_id":"MDQ6VXNlcjcwNTUyMjY=","avatar_url":"https://avatars1.githubusercontent.com/u/7055226?v=4","gravatar_id":"","url":"https://api.github.com/users/Schachte","html_url":"https://github.com/Schachte","followers_url":"https://api.github.com/users/Schachte/followers","following_url":"https://api.github.com/users/Schachte/following{/other_user}","gists_url":"https://api.github.com/users/Schachte/gists{/gist_id}","starred_url":"https://api.github.com/users/Schachte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Schachte/subscriptions","organizations_url":"https://api.github.com/users/Schachte/orgs","repos_url":"https://api.github.com/users/Schachte/repos","events_url":"https://api.github.com/users/Schachte/events{/privacy}","received_events_url":"https://api.github.com/users/Schachte/received_events","type":"User","site_admin":false},"created_at":"2018-09-05T22:08:06Z","updated_at":"2018-09-05T22:08:06Z","author_association":"CONTRIBUTOR","body":"build now"}}
{"actor":{"display_login":"Schachte"}}