{"action":"created","issue":{"url":"https://api.github.com/repos/keyboardio/Kaleidoscope-LEDControl/issues/25","repository_url":"https://api.github.com/repos/keyboardio/Kaleidoscope-LEDControl","labels_url":"https://api.github.com/repos/keyboardio/Kaleidoscope-LEDControl/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/keyboardio/Kaleidoscope-LEDControl/issues/25/comments","events_url":"https://api.github.com/repos/keyboardio/Kaleidoscope-LEDControl/issues/25/events","html_url":"https://github.com/keyboardio/Kaleidoscope-LEDControl/pull/25","id":333058870,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1Mzc1MjQ3","number":25,"title":"add hue names header for convenience","user":{"login":"jamadagni","id":948170,"node_id":"MDQ6VXNlcjk0ODE3MA==","avatar_url":"https://avatars0.githubusercontent.com/u/948170?v=4","gravatar_id":"","url":"https://api.github.com/users/jamadagni","html_url":"https://github.com/jamadagni","followers_url":"https://api.github.com/users/jamadagni/followers","following_url":"https://api.github.com/users/jamadagni/following{/other_user}","gists_url":"https://api.github.com/users/jamadagni/gists{/gist_id}","starred_url":"https://api.github.com/users/jamadagni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamadagni/subscriptions","organizations_url":"https://api.github.com/users/jamadagni/orgs","repos_url":"https://api.github.com/users/jamadagni/repos","events_url":"https://api.github.com/users/jamadagni/events{/privacy}","received_events_url":"https://api.github.com/users/jamadagni/received_events","type":"User","site_admin":false},"labels":[{"id":526945843,"node_id":"MDU6TGFiZWw1MjY5NDU4NDM=","url":"https://api.github.com/repos/keyboardio/Kaleidoscope-LEDControl/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"algernon","id":17243,"node_id":"MDQ6VXNlcjE3MjQz","avatar_url":"https://avatars3.githubusercontent.com/u/17243?v=4","gravatar_id":"","url":"https://api.github.com/users/algernon","html_url":"https://github.com/algernon","followers_url":"https://api.github.com/users/algernon/followers","following_url":"https://api.github.com/users/algernon/following{/other_user}","gists_url":"https://api.github.com/users/algernon/gists{/gist_id}","starred_url":"https://api.github.com/users/algernon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algernon/subscriptions","organizations_url":"https://api.github.com/users/algernon/orgs","repos_url":"https://api.github.com/users/algernon/repos","events_url":"https://api.github.com/users/algernon/events{/privacy}","received_events_url":"https://api.github.com/users/algernon/received_events","type":"User","site_admin":false},"assignees":[{"login":"algernon","id":17243,"node_id":"MDQ6VXNlcjE3MjQz","avatar_url":"https://avatars3.githubusercontent.com/u/17243?v=4","gravatar_id":"","url":"https://api.github.com/users/algernon","html_url":"https://github.com/algernon","followers_url":"https://api.github.com/users/algernon/followers","following_url":"https://api.github.com/users/algernon/following{/other_user}","gists_url":"https://api.github.com/users/algernon/gists{/gist_id}","starred_url":"https://api.github.com/users/algernon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algernon/subscriptions","organizations_url":"https://api.github.com/users/algernon/orgs","repos_url":"https://api.github.com/users/algernon/repos","events_url":"https://api.github.com/users/algernon/events{/privacy}","received_events_url":"https://api.github.com/users/algernon/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-06-17T12:24:32Z","updated_at":"2018-08-11T11:32:03Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/keyboardio/Kaleidoscope-LEDControl/pulls/25","html_url":"https://github.com/keyboardio/Kaleidoscope-LEDControl/pull/25","diff_url":"https://github.com/keyboardio/Kaleidoscope-LEDControl/pull/25.diff","patch_url":"https://github.com/keyboardio/Kaleidoscope-LEDControl/pull/25.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/keyboardio/Kaleidoscope-LEDControl/issues/comments/412269408","html_url":"https://github.com/keyboardio/Kaleidoscope-LEDControl/pull/25#issuecomment-412269408","issue_url":"https://api.github.com/repos/keyboardio/Kaleidoscope-LEDControl/issues/25","id":412269408,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjI2OTQwOA==","user":{"login":"jamadagni","id":948170,"node_id":"MDQ6VXNlcjk0ODE3MA==","avatar_url":"https://avatars0.githubusercontent.com/u/948170?v=4","gravatar_id":"","url":"https://api.github.com/users/jamadagni","html_url":"https://github.com/jamadagni","followers_url":"https://api.github.com/users/jamadagni/followers","following_url":"https://api.github.com/users/jamadagni/following{/other_user}","gists_url":"https://api.github.com/users/jamadagni/gists{/gist_id}","starred_url":"https://api.github.com/users/jamadagni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamadagni/subscriptions","organizations_url":"https://api.github.com/users/jamadagni/orgs","repos_url":"https://api.github.com/users/jamadagni/repos","events_url":"https://api.github.com/users/jamadagni/events{/privacy}","received_events_url":"https://api.github.com/users/jamadagni/received_events","type":"User","site_admin":false},"created_at":"2018-08-11T11:32:03Z","updated_at":"2018-08-11T11:32:03Z","author_association":"NONE","body":"Hello. I agree to the part about ORANGE (obvlously I was being a little unimaginative there) and I have no problem with using other better _names_.\r\n\r\nBut there may a problem with using the hue *values* which you have copy-pasted, because they refer to the **rainbow** HSV colour model provided by FastLED which adjusts for a visually-expected broader yellow band.\r\n\r\nFurther down on that page are the named values for the pure mathematical **spectrum** model and they correspond to the values I have given (simply because they divide 0–256 into 12 parts). [Well it seems I instead divided _255_ into 12 parts so a couple of the values are off by 1 due to rounding but I'll fix that presently.]\r\n\r\nThe current LEDControl implementation doesn't use the FastLED code for HSV-to-RGB conversion, but instead code from some other webpage (which doesn't seem to be available now BTW) which follows the pure mathematical **spectrum** model as does most simple code on the web. (To use the **rainbow** model might be desirable, but that's for another day.)\r\n\r\nSee also what [the FastLED source](https://github.com/FastLED/FastLED/blob/master/hsv2rgb.cpp#L21) says about the differences between the two models. Certainly currently the HSV code doesn't attempt to maintain a uniform brightness and you can observe that the basic Rainbow effect becomes brighter whenever it goes through the CMY colours compared to the plain RGB where only one LED component will be working.\r\n\r\nThus I am OK with adding some more readable aliases for the intervening hues but would like to retain the prosaic names as well since they highlight the fact that they bisect the two major hues, and also am not sure these intervening hues all have other more readable names. (FastLED specifies HTML-style names for individual RGB colours but not for other hues AFAICS.)"}}
{"actor":{"display_login":"jamadagni"}}