{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/rocksdb/issues/3816","repository_url":"https://api.github.com/repos/facebook/rocksdb","labels_url":"https://api.github.com/repos/facebook/rocksdb/issues/3816/labels{/name}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/3816/comments","events_url":"https://api.github.com/repos/facebook/rocksdb/issues/3816/events","html_url":"https://github.com/facebook/rocksdb/issues/3816","id":320676008,"number":3816,"title":"Cmake release should not compile *_test.cc files","user":{"login":"xkszltl","id":5203025,"avatar_url":"https://avatars0.githubusercontent.com/u/5203025?v=4","gravatar_id":"","url":"https://api.github.com/users/xkszltl","html_url":"https://github.com/xkszltl","followers_url":"https://api.github.com/users/xkszltl/followers","following_url":"https://api.github.com/users/xkszltl/following{/other_user}","gists_url":"https://api.github.com/users/xkszltl/gists{/gist_id}","starred_url":"https://api.github.com/users/xkszltl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xkszltl/subscriptions","organizations_url":"https://api.github.com/users/xkszltl/orgs","repos_url":"https://api.github.com/users/xkszltl/repos","events_url":"https://api.github.com/users/xkszltl/events{/privacy}","received_events_url":"https://api.github.com/users/xkszltl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"gfosco","id":406732,"avatar_url":"https://avatars2.githubusercontent.com/u/406732?v=4","gravatar_id":"","url":"https://api.github.com/users/gfosco","html_url":"https://github.com/gfosco","followers_url":"https://api.github.com/users/gfosco/followers","following_url":"https://api.github.com/users/gfosco/following{/other_user}","gists_url":"https://api.github.com/users/gfosco/gists{/gist_id}","starred_url":"https://api.github.com/users/gfosco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfosco/subscriptions","organizations_url":"https://api.github.com/users/gfosco/orgs","repos_url":"https://api.github.com/users/gfosco/repos","events_url":"https://api.github.com/users/gfosco/events{/privacy}","received_events_url":"https://api.github.com/users/gfosco/received_events","type":"User","site_admin":false},"assignees":[{"login":"gfosco","id":406732,"avatar_url":"https://avatars2.githubusercontent.com/u/406732?v=4","gravatar_id":"","url":"https://api.github.com/users/gfosco","html_url":"https://github.com/gfosco","followers_url":"https://api.github.com/users/gfosco/followers","following_url":"https://api.github.com/users/gfosco/following{/other_user}","gists_url":"https://api.github.com/users/gfosco/gists{/gist_id}","starred_url":"https://api.github.com/users/gfosco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfosco/subscriptions","organizations_url":"https://api.github.com/users/gfosco/orgs","repos_url":"https://api.github.com/users/gfosco/repos","events_url":"https://api.github.com/users/gfosco/events{/privacy}","received_events_url":"https://api.github.com/users/gfosco/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-05-07T05:14:59Z","updated_at":"2018-05-07T23:27:50Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"### Expected behavior\r\n\r\nNo compile error in cmake Release build.\r\n\r\n### Actual behavior\r\n\r\nIn Release build (i.e. with `NDEBUG`):\r\nrocksdb::SyncPoint is not defined due to `#ifdef NDEBUG`\r\n\r\nhttps://github.com/facebook/rocksdb/blob/72942ad7a40d23ef9b6edf6cf1f53628e37c56b4/util/sync_point.h#L44-L48\r\n\r\nBut still referenced by files:\r\n\r\nhttps://github.com/facebook/rocksdb/blob/72942ad7a40d23ef9b6edf6cf1f53628e37c56b4/util/auto_roll_logger_test.cc#L294\r\n\r\n### Steps to reproduce the behavior\r\n\r\n```\r\nmkdir -p build\r\ncd $_\r\ncmake -DCMAKE_BUILD_TYPE=Release <other arguments> ..\r\n```"},"comment":{"url":"https://api.github.com/repos/facebook/rocksdb/issues/comments/387237204","html_url":"https://github.com/facebook/rocksdb/issues/3816#issuecomment-387237204","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/3816","id":387237204,"user":{"login":"xkszltl","id":5203025,"avatar_url":"https://avatars0.githubusercontent.com/u/5203025?v=4","gravatar_id":"","url":"https://api.github.com/users/xkszltl","html_url":"https://github.com/xkszltl","followers_url":"https://api.github.com/users/xkszltl/followers","following_url":"https://api.github.com/users/xkszltl/following{/other_user}","gists_url":"https://api.github.com/users/xkszltl/gists{/gist_id}","starred_url":"https://api.github.com/users/xkszltl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xkszltl/subscriptions","organizations_url":"https://api.github.com/users/xkszltl/orgs","repos_url":"https://api.github.com/users/xkszltl/repos","events_url":"https://api.github.com/users/xkszltl/events{/privacy}","received_events_url":"https://api.github.com/users/xkszltl/received_events","type":"User","site_admin":false},"created_at":"2018-05-07T23:27:49Z","updated_at":"2018-05-07T23:27:49Z","author_association":"CONTRIBUTOR","body":"Ah....I've got a nice experience with rocksdb+cmake on Win so just wanna try it on Linux\r\nBut seems it's still far from ready...\r\n\r\nWould you mind telling me why not?\r\nWhy are we relying on build type rather than a BUILD_TEST switch?\r\nThe reason I'm asking is, that doesn't make sense to build twice in our build system if we need a release build with quick test to proof it's not gonna crash\r\n"}}
{"actor":{"display_login":"xkszltl"}}