{"action":"created","comment":{"url":"https://api.github.com/repos/databricks/mlflow/pulls/comments/200437855","pull_request_review_id":134755882,"id":200437855,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDQzNzg1NQ==","diff_hunk":"@@ -49,8 +49,9 @@ def run_local(model_path, run_id, port, container):\n @click.option(\"--build/--no-build\", default=True, help=\"Build the container if set.\")\n @click.option(\"--push/--no-push\", default=True, help=\"Push the container to amazon ecr if set.\")\n @click.option(\"--container\", \"-c\", default=IMAGE, help=\"image name\")\n+@click.option(\"--version\", \"-v\", default=\"latest\", help=\"version to tag the image with\")","path":"mlflow/sagemaker/cli.py","position":4,"original_position":4,"commit_id":"84f5724ceeb9c5ff38449bfa5fbaae9280a82771","original_commit_id":"84f5724ceeb9c5ff38449bfa5fbaae9280a82771","user":{"login":"tomasatdatabricks","id":33237569,"node_id":"MDQ6VXNlcjMzMjM3NTY5","avatar_url":"https://avatars3.githubusercontent.com/u/33237569?v=4","gravatar_id":"","url":"https://api.github.com/users/tomasatdatabricks","html_url":"https://github.com/tomasatdatabricks","followers_url":"https://api.github.com/users/tomasatdatabricks/followers","following_url":"https://api.github.com/users/tomasatdatabricks/following{/other_user}","gists_url":"https://api.github.com/users/tomasatdatabricks/gists{/gist_id}","starred_url":"https://api.github.com/users/tomasatdatabricks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomasatdatabricks/subscriptions","organizations_url":"https://api.github.com/users/tomasatdatabricks/orgs","repos_url":"https://api.github.com/users/tomasatdatabricks/repos","events_url":"https://api.github.com/users/tomasatdatabricks/events{/privacy}","received_events_url":"https://api.github.com/users/tomasatdatabricks/received_events","type":"User","site_admin":false},"body":"What is the motivation for having version as a parameter? Shouldn't it always point to the same version of MLflow?","created_at":"2018-07-05T17:55:08Z","updated_at":"2018-07-05T18:00:50Z","html_url":"https://github.com/databricks/mlflow/pull/124#discussion_r200437855","pull_request_url":"https://api.github.com/repos/databricks/mlflow/pulls/124","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/databricks/mlflow/pulls/comments/200437855"},"html":{"href":"https://github.com/databricks/mlflow/pull/124#discussion_r200437855"},"pull_request":{"href":"https://api.github.com/repos/databricks/mlflow/pulls/124"}}},"pull_request":{"url":"https://api.github.com/repos/databricks/mlflow/pulls/124","id":199115848,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MTE1ODQ4","html_url":"https://github.com/databricks/mlflow/pull/124","diff_url":"https://github.com/databricks/mlflow/pull/124.diff","patch_url":"https://github.com/databricks/mlflow/pull/124.patch","issue_url":"https://api.github.com/repos/databricks/mlflow/issues/124","number":124,"state":"open","locked":false,"title":"Add custom versioning option for SageMaker docker image upload","user":{"login":"sueann","id":4411489,"node_id":"MDQ6VXNlcjQ0MTE0ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/4411489?v=4","gravatar_id":"","url":"https://api.github.com/users/sueann","html_url":"https://github.com/sueann","followers_url":"https://api.github.com/users/sueann/followers","following_url":"https://api.github.com/users/sueann/following{/other_user}","gists_url":"https://api.github.com/users/sueann/gists{/gist_id}","starred_url":"https://api.github.com/users/sueann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sueann/subscriptions","organizations_url":"https://api.github.com/users/sueann/orgs","repos_url":"https://api.github.com/users/sueann/repos","events_url":"https://api.github.com/users/sueann/events{/privacy}","received_events_url":"https://api.github.com/users/sueann/received_events","type":"User","site_admin":false},"body":"Sometimes tagging the SageMaker deployment docker image with a version is useful, e.g. for tagging with the version of mlflow used so we can track the correct image to use in `deploy()`. Added an option in `build_and_push_container` to take in the version (by default set to \"latest\" as before). \r\n\r\nTo test:\r\n1. Run `mlflow sagemaker build-and-push-container -c mlflow-pyfunc -v 0.2.2`\r\n2. Check image was uploaded, tagged with the correct version, by running `aws ecr describe-images --repository-name mlflow-pyfunc` and examining the field `\"imageTags\"` (should be \"0.2.2\" given the command in 1).","created_at":"2018-07-04T00:58:53Z","updated_at":"2018-07-05T18:00:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c633a054dc3063de17956f6e037b0ed372d29ca","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/databricks/mlflow/pulls/124/commits","review_comments_url":"https://api.github.com/repos/databricks/mlflow/pulls/124/comments","review_comment_url":"https://api.github.com/repos/databricks/mlflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/databricks/mlflow/issues/124/comments","statuses_url":"https://api.github.com/repos/databricks/mlflow/statuses/84f5724ceeb9c5ff38449bfa5fbaae9280a82771","head":{"label":"sueann:image_version","ref":"image_version","sha":"84f5724ceeb9c5ff38449bfa5fbaae9280a82771","user":{"login":"sueann","id":4411489,"node_id":"MDQ6VXNlcjQ0MTE0ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/4411489?v=4","gravatar_id":"","url":"https://api.github.com/users/sueann","html_url":"https://github.com/sueann","followers_url":"https://api.github.com/users/sueann/followers","following_url":"https://api.github.com/users/sueann/following{/other_user}","gists_url":"https://api.github.com/users/sueann/gists{/gist_id}","starred_url":"https://api.github.com/users/sueann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sueann/subscriptions","organizations_url":"https://api.github.com/users/sueann/orgs","repos_url":"https://api.github.com/users/sueann/repos","events_url":"https://api.github.com/users/sueann/events{/privacy}","received_events_url":"https://api.github.com/users/sueann/received_events","type":"User","site_admin":false},"repo":{"id":139075718,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkwNzU3MTg=","name":"mlflow","full_name":"sueann/mlflow","owner":{"login":"sueann","id":4411489,"node_id":"MDQ6VXNlcjQ0MTE0ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/4411489?v=4","gravatar_id":"","url":"https://api.github.com/users/sueann","html_url":"https://github.com/sueann","followers_url":"https://api.github.com/users/sueann/followers","following_url":"https://api.github.com/users/sueann/following{/other_user}","gists_url":"https://api.github.com/users/sueann/gists{/gist_id}","starred_url":"https://api.github.com/users/sueann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sueann/subscriptions","organizations_url":"https://api.github.com/users/sueann/orgs","repos_url":"https://api.github.com/users/sueann/repos","events_url":"https://api.github.com/users/sueann/events{/privacy}","received_events_url":"https://api.github.com/users/sueann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sueann/mlflow","description":"Open source platform for the complete machine learning lifecycle","fork":true,"url":"https://api.github.com/repos/sueann/mlflow","forks_url":"https://api.github.com/repos/sueann/mlflow/forks","keys_url":"https://api.github.com/repos/sueann/mlflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sueann/mlflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sueann/mlflow/teams","hooks_url":"https://api.github.com/repos/sueann/mlflow/hooks","issue_events_url":"https://api.github.com/repos/sueann/mlflow/issues/events{/number}","events_url":"https://api.github.com/repos/sueann/mlflow/events","assignees_url":"https://api.github.com/repos/sueann/mlflow/assignees{/user}","branches_url":"https://api.github.com/repos/sueann/mlflow/branches{/branch}","tags_url":"https://api.github.com/repos/sueann/mlflow/tags","blobs_url":"https://api.github.com/repos/sueann/mlflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sueann/mlflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sueann/mlflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/sueann/mlflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sueann/mlflow/statuses/{sha}","languages_url":"https://api.github.com/repos/sueann/mlflow/languages","stargazers_url":"https://api.github.com/repos/sueann/mlflow/stargazers","contributors_url":"https://api.github.com/repos/sueann/mlflow/contributors","subscribers_url":"https://api.github.com/repos/sueann/mlflow/subscribers","subscription_url":"https://api.github.com/repos/sueann/mlflow/subscription","commits_url":"https://api.github.com/repos/sueann/mlflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/sueann/mlflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/sueann/mlflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/sueann/mlflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/sueann/mlflow/contents/{+path}","compare_url":"https://api.github.com/repos/sueann/mlflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sueann/mlflow/merges","archive_url":"https://api.github.com/repos/sueann/mlflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sueann/mlflow/downloads","issues_url":"https://api.github.com/repos/sueann/mlflow/issues{/number}","pulls_url":"https://api.github.com/repos/sueann/mlflow/pulls{/number}","milestones_url":"https://api.github.com/repos/sueann/mlflow/milestones{/number}","notifications_url":"https://api.github.com/repos/sueann/mlflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sueann/mlflow/labels{/name}","releases_url":"https://api.github.com/repos/sueann/mlflow/releases{/id}","deployments_url":"https://api.github.com/repos/sueann/mlflow/deployments","created_at":"2018-06-28T22:52:40Z","updated_at":"2018-06-28T22:52:43Z","pushed_at":"2018-07-04T02:25:17Z","git_url":"git://github.com/sueann/mlflow.git","ssh_url":"git@github.com:sueann/mlflow.git","clone_url":"https://github.com/sueann/mlflow.git","svn_url":"https://github.com/sueann/mlflow","homepage":"https://mlflow.org","size":3105,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"databricks:master","ref":"master","sha":"ac14aa1f36e3dc34b8897719e6fa7ea0ea723bcf","user":{"login":"databricks","id":4998052,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTgwNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/4998052?v=4","gravatar_id":"","url":"https://api.github.com/users/databricks","html_url":"https://github.com/databricks","followers_url":"https://api.github.com/users/databricks/followers","following_url":"https://api.github.com/users/databricks/following{/other_user}","gists_url":"https://api.github.com/users/databricks/gists{/gist_id}","starred_url":"https://api.github.com/users/databricks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/databricks/subscriptions","organizations_url":"https://api.github.com/users/databricks/orgs","repos_url":"https://api.github.com/users/databricks/repos","events_url":"https://api.github.com/users/databricks/events{/privacy}","received_events_url":"https://api.github.com/users/databricks/received_events","type":"Organization","site_admin":false},"repo":{"id":136202695,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYyMDI2OTU=","name":"mlflow","full_name":"databricks/mlflow","owner":{"login":"databricks","id":4998052,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTgwNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/4998052?v=4","gravatar_id":"","url":"https://api.github.com/users/databricks","html_url":"https://github.com/databricks","followers_url":"https://api.github.com/users/databricks/followers","following_url":"https://api.github.com/users/databricks/following{/other_user}","gists_url":"https://api.github.com/users/databricks/gists{/gist_id}","starred_url":"https://api.github.com/users/databricks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/databricks/subscriptions","organizations_url":"https://api.github.com/users/databricks/orgs","repos_url":"https://api.github.com/users/databricks/repos","events_url":"https://api.github.com/users/databricks/events{/privacy}","received_events_url":"https://api.github.com/users/databricks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/databricks/mlflow","description":"Open source platform for the complete machine learning lifecycle","fork":false,"url":"https://api.github.com/repos/databricks/mlflow","forks_url":"https://api.github.com/repos/databricks/mlflow/forks","keys_url":"https://api.github.com/repos/databricks/mlflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/databricks/mlflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/databricks/mlflow/teams","hooks_url":"https://api.github.com/repos/databricks/mlflow/hooks","issue_events_url":"https://api.github.com/repos/databricks/mlflow/issues/events{/number}","events_url":"https://api.github.com/repos/databricks/mlflow/events","assignees_url":"https://api.github.com/repos/databricks/mlflow/assignees{/user}","branches_url":"https://api.github.com/repos/databricks/mlflow/branches{/branch}","tags_url":"https://api.github.com/repos/databricks/mlflow/tags","blobs_url":"https://api.github.com/repos/databricks/mlflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/databricks/mlflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/databricks/mlflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/databricks/mlflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/databricks/mlflow/statuses/{sha}","languages_url":"https://api.github.com/repos/databricks/mlflow/languages","stargazers_url":"https://api.github.com/repos/databricks/mlflow/stargazers","contributors_url":"https://api.github.com/repos/databricks/mlflow/contributors","subscribers_url":"https://api.github.com/repos/databricks/mlflow/subscribers","subscription_url":"https://api.github.com/repos/databricks/mlflow/subscription","commits_url":"https://api.github.com/repos/databricks/mlflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/databricks/mlflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/databricks/mlflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/databricks/mlflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/databricks/mlflow/contents/{+path}","compare_url":"https://api.github.com/repos/databricks/mlflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/databricks/mlflow/merges","archive_url":"https://api.github.com/repos/databricks/mlflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/databricks/mlflow/downloads","issues_url":"https://api.github.com/repos/databricks/mlflow/issues{/number}","pulls_url":"https://api.github.com/repos/databricks/mlflow/pulls{/number}","milestones_url":"https://api.github.com/repos/databricks/mlflow/milestones{/number}","notifications_url":"https://api.github.com/repos/databricks/mlflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/databricks/mlflow/labels{/name}","releases_url":"https://api.github.com/repos/databricks/mlflow/releases{/id}","deployments_url":"https://api.github.com/repos/databricks/mlflow/deployments","created_at":"2018-06-05T16:05:58Z","updated_at":"2018-07-05T17:17:01Z","pushed_at":"2018-07-05T17:56:27Z","git_url":"git://github.com/databricks/mlflow.git","ssh_url":"git@github.com:databricks/mlflow.git","clone_url":"https://github.com/databricks/mlflow.git","svn_url":"https://github.com/databricks/mlflow","homepage":"https://mlflow.org","size":3102,"stargazers_count":1546,"watchers_count":1546,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":203,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":203,"open_issues":35,"watchers":1546,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/databricks/mlflow/pulls/124"},"html":{"href":"https://github.com/databricks/mlflow/pull/124"},"issue":{"href":"https://api.github.com/repos/databricks/mlflow/issues/124"},"comments":{"href":"https://api.github.com/repos/databricks/mlflow/issues/124/comments"},"review_comments":{"href":"https://api.github.com/repos/databricks/mlflow/pulls/124/comments"},"review_comment":{"href":"https://api.github.com/repos/databricks/mlflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/databricks/mlflow/pulls/124/commits"},"statuses":{"href":"https://api.github.com/repos/databricks/mlflow/statuses/84f5724ceeb9c5ff38449bfa5fbaae9280a82771"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tomasatdatabricks"}}