{"action":"created","issue":{"url":"https://api.github.com/repos/missionpinball/mpf/issues/1107","repository_url":"https://api.github.com/repos/missionpinball/mpf","labels_url":"https://api.github.com/repos/missionpinball/mpf/issues/1107/labels{/name}","comments_url":"https://api.github.com/repos/missionpinball/mpf/issues/1107/comments","events_url":"https://api.github.com/repos/missionpinball/mpf/issues/1107/events","html_url":"https://github.com/missionpinball/mpf/pull/1107","id":300744390,"number":1107,"title":"Common method for expecting config/show version tag","user":{"login":"avanwinkle","id":5777240,"avatar_url":"https://avatars3.githubusercontent.com/u/5777240?v=4","gravatar_id":"","url":"https://api.github.com/users/avanwinkle","html_url":"https://github.com/avanwinkle","followers_url":"https://api.github.com/users/avanwinkle/followers","following_url":"https://api.github.com/users/avanwinkle/following{/other_user}","gists_url":"https://api.github.com/users/avanwinkle/gists{/gist_id}","starred_url":"https://api.github.com/users/avanwinkle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avanwinkle/subscriptions","organizations_url":"https://api.github.com/users/avanwinkle/orgs","repos_url":"https://api.github.com/users/avanwinkle/repos","events_url":"https://api.github.com/users/avanwinkle/events{/privacy}","received_events_url":"https://api.github.com/users/avanwinkle/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-27T18:34:18Z","updated_at":"2018-02-27T20:26:43Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/missionpinball/mpf/pulls/1107","html_url":"https://github.com/missionpinball/mpf/pull/1107","diff_url":"https://github.com/missionpinball/mpf/pull/1107.diff","patch_url":"https://github.com/missionpinball/mpf/pull/1107.patch"},"body":"Recent updates to config loading/processing (mainly related to caching and consistent version number tagging) changed how config files were parsed.\r\n\r\nThese changes were implemented in **config_processor.py** in the `_load_config_file_and_return_loaded_files()` method but not in the `load_config_files()` method. The latter is a public method that can be used by other scripts to interpret MPF config files, so consistent behavior with MPF's internal processing is optimal.\r\n\r\nThis PR extracts the config/show version tag parser into a new method `get_expected_version()` and calls that method from both places where version tags are expected."},"comment":{"url":"https://api.github.com/repos/missionpinball/mpf/issues/comments/369014793","html_url":"https://github.com/missionpinball/mpf/pull/1107#issuecomment-369014793","issue_url":"https://api.github.com/repos/missionpinball/mpf/issues/1107","id":369014793,"user":{"login":"avanwinkle","id":5777240,"avatar_url":"https://avatars3.githubusercontent.com/u/5777240?v=4","gravatar_id":"","url":"https://api.github.com/users/avanwinkle","html_url":"https://github.com/avanwinkle","followers_url":"https://api.github.com/users/avanwinkle/followers","following_url":"https://api.github.com/users/avanwinkle/following{/other_user}","gists_url":"https://api.github.com/users/avanwinkle/gists{/gist_id}","starred_url":"https://api.github.com/users/avanwinkle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avanwinkle/subscriptions","organizations_url":"https://api.github.com/users/avanwinkle/orgs","repos_url":"https://api.github.com/users/avanwinkle/repos","events_url":"https://api.github.com/users/avanwinkle/events{/privacy}","received_events_url":"https://api.github.com/users/avanwinkle/received_events","type":"User","site_admin":false},"created_at":"2018-02-27T20:26:43Z","updated_at":"2018-02-27T20:26:43Z","author_association":"COLLABORATOR","body":"Oh those pesky linter errors. I need to fix my local linter so it matches and I can stop checking in goofs! Fixed now :)\r\n\r\nYes to your question, I wrote a python script to traverse and maintain my audio files, copying them in from my source folder to the appropriate mode folder when added to a config file and moving/deleting audio files that are no longer in those modes. I'm constantly shuffling sounds around my configs :)\r\n"}}
{"actor":{"display_login":"avanwinkle"}}