{"action":"created","comment":{"url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/comments/174992350","pull_request_review_id":104448874,"id":174992350,"diff_hunk":"@@ -3,25 +3,73 @@ module Pod\n   # of the single Pods. The client targets will then depend on this one.\n   #\n   class AggregateTarget < Target\n+    # Product types where the product's frameworks must be embedded in a host target\n+    #\n+    EMBED_FRAMEWORKS_IN_HOST_TARGET_TYPES = [:app_extension, :framework, :static_library, :messages_extension, :watch_extension, :xpc_service].freeze\n+\n     # @return [TargetDefinition] the target definition of the Podfile that\n     #         generated this target.\n+    #\n     attr_reader :target_definition\n \n-    # Product types where the product's frameworks must be embedded in a host target\n+    # @return [Pathname] the folder where the client is stored used for\n+    #         computing the relative paths. If integrating it should be the\n+    #         folder where the user project is stored, otherwise it should\n+    #         be the installation root.\n     #\n-    EMBED_FRAMEWORKS_IN_HOST_TARGET_TYPES = [:app_extension, :framework, :static_library, :messages_extension, :watch_extension, :xpc_service].freeze\n+    attr_reader :client_root\n \n-    # Initialize a new instance\n+    # @return [Xcodeproj::Project] the user project that this target will\n+    #         integrate as identified by the analyzer.\n+    #\n+    attr_reader :user_project\n+\n+    # @return [Array<String>] the list of the UUIDs of the user targets that\n+    #         will be integrated by this target as identified by the analyzer.\n+    #\n+    # @note   The target instances are not stored to prevent editing different\n+    #         instances.\n+    #\n+    attr_reader :user_target_uuids\n+\n+    # @return [Hash<String, Xcodeproj::Config>] Map from configuration name to\n+    #         configuration file for the target\n+    #\n+    # @note   The configurations are generated by the {TargetInstaller} and\n+    #         used by {UserProjectIntegrator} to check for any overridden\n+    #         values.\n+    #\n+    attr_reader :xcconfigs\n+\n+    # @return [Array<PodTarget>] The dependencies for this target.\n+    #\n+    attr_accessor :pod_targets\n+\n+    # @return [Array<AggregateTarget>] The aggregate targets whose pods this\n+    #         target must be able to import, but will not directly link against.\n     #\n-    # @param [TargetDefinition] target_definition @see target_definition\n-    # @param [Sandbox] sandbox @see sandbox\n+    attr_reader :search_paths_aggregate_targets\n+\n+    # Initialize a new instance\n     #\n-    def initialize(target_definition, sandbox)\n+    # @param [Sandbox] sandbox @see Target#sandbox\n+    # @param [Boolean] host_requires_frameworks @see Target#host_requires_frameworks\n+    # @param [Hash{String=>Symbol}] user_build_configurations @see Target#user_build_configurations\n+    # @param [Array<String>] archs @see Target#archs\n+    # @param [TargetDefinition] target_definition @see #target_definition\n+    # @param [Pathname] client_root @see #client_root\n+    # @param [Xcodeproj::Project] user_project @see #user_project\n+    # @param [Array<String>] user_target_uuids @see #user_target_uuids\n+    # @param [Array<PodTarget>] pod_targets @see #pod_targets\n+    #\n+    def initialize(sandbox, host_requires_frameworks, user_build_configurations, archs, target_definition, client_root, user_project, user_target_uuids, pod_targets)\n+      super(sandbox, host_requires_frameworks, user_build_configurations, archs)\n       raise \"Can't initialize an AggregateTarget with an abstract TargetDefinition\" if target_definition.abstract?\n-      super()\n       @target_definition = target_definition\n-      @sandbox = sandbox","path":"lib/cocoapods/target/aggregate_target.rb","position":74,"original_position":74,"commit_id":"214aba000a7421e0d49d510238d31fe9359adb6b","original_commit_id":"214aba000a7421e0d49d510238d31fe9359adb6b","user":{"login":"dnkoutso","id":310370,"avatar_url":"https://avatars2.githubusercontent.com/u/310370?v=4","gravatar_id":"","url":"https://api.github.com/users/dnkoutso","html_url":"https://github.com/dnkoutso","followers_url":"https://api.github.com/users/dnkoutso/followers","following_url":"https://api.github.com/users/dnkoutso/following{/other_user}","gists_url":"https://api.github.com/users/dnkoutso/gists{/gist_id}","starred_url":"https://api.github.com/users/dnkoutso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnkoutso/subscriptions","organizations_url":"https://api.github.com/users/dnkoutso/orgs","repos_url":"https://api.github.com/users/dnkoutso/repos","events_url":"https://api.github.com/users/dnkoutso/events{/privacy}","received_events_url":"https://api.github.com/users/dnkoutso/received_events","type":"User","site_admin":false},"body":"this is set in super class was not needed","created_at":"2018-03-16T03:53:00Z","updated_at":"2018-03-16T03:53:00Z","html_url":"https://github.com/CocoaPods/CocoaPods/pull/7505#discussion_r174992350","pull_request_url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/7505","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/comments/174992350"},"html":{"href":"https://github.com/CocoaPods/CocoaPods/pull/7505#discussion_r174992350"},"pull_request":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/7505"}}},"pull_request":{"url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/7505","id":174839556,"html_url":"https://github.com/CocoaPods/CocoaPods/pull/7505","diff_url":"https://github.com/CocoaPods/CocoaPods/pull/7505.diff","patch_url":"https://github.com/CocoaPods/CocoaPods/pull/7505.patch","issue_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/7505","number":7505,"state":"open","locked":false,"title":"More immutability across several classes","user":{"login":"dnkoutso","id":310370,"avatar_url":"https://avatars2.githubusercontent.com/u/310370?v=4","gravatar_id":"","url":"https://api.github.com/users/dnkoutso","html_url":"https://github.com/dnkoutso","followers_url":"https://api.github.com/users/dnkoutso/followers","following_url":"https://api.github.com/users/dnkoutso/following{/other_user}","gists_url":"https://api.github.com/users/dnkoutso/gists{/gist_id}","starred_url":"https://api.github.com/users/dnkoutso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnkoutso/subscriptions","organizations_url":"https://api.github.com/users/dnkoutso/orgs","repos_url":"https://api.github.com/users/dnkoutso/repos","events_url":"https://api.github.com/users/dnkoutso/events{/privacy}","received_events_url":"https://api.github.com/users/dnkoutso/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-14T02:34:19Z","updated_at":"2018-03-16T03:53:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cba033cad3a426b2097f7384bbc630b47761d16f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/CocoaPods/CocoaPods/milestones/34","html_url":"https://github.com/CocoaPods/CocoaPods/milestone/34","labels_url":"https://api.github.com/repos/CocoaPods/CocoaPods/milestones/34/labels","id":2960166,"number":34,"title":"1.6.0","description":"","creator":{"login":"justinseanmartin","id":5855270,"avatar_url":"https://avatars3.githubusercontent.com/u/5855270?v=4","gravatar_id":"","url":"https://api.github.com/users/justinseanmartin","html_url":"https://github.com/justinseanmartin","followers_url":"https://api.github.com/users/justinseanmartin/followers","following_url":"https://api.github.com/users/justinseanmartin/following{/other_user}","gists_url":"https://api.github.com/users/justinseanmartin/gists{/gist_id}","starred_url":"https://api.github.com/users/justinseanmartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinseanmartin/subscriptions","organizations_url":"https://api.github.com/users/justinseanmartin/orgs","repos_url":"https://api.github.com/users/justinseanmartin/repos","events_url":"https://api.github.com/users/justinseanmartin/events{/privacy}","received_events_url":"https://api.github.com/users/justinseanmartin/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":0,"state":"open","created_at":"2017-12-05T18:27:15Z","updated_at":"2018-03-14T20:57:56Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/7505/commits","review_comments_url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/7505/comments","review_comment_url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/7505/comments","statuses_url":"https://api.github.com/repos/CocoaPods/CocoaPods/statuses/214aba000a7421e0d49d510238d31fe9359adb6b","head":{"label":"dnkoutso:immutability_wins_3","ref":"immutability_wins_3","sha":"214aba000a7421e0d49d510238d31fe9359adb6b","user":{"login":"dnkoutso","id":310370,"avatar_url":"https://avatars2.githubusercontent.com/u/310370?v=4","gravatar_id":"","url":"https://api.github.com/users/dnkoutso","html_url":"https://github.com/dnkoutso","followers_url":"https://api.github.com/users/dnkoutso/followers","following_url":"https://api.github.com/users/dnkoutso/following{/other_user}","gists_url":"https://api.github.com/users/dnkoutso/gists{/gist_id}","starred_url":"https://api.github.com/users/dnkoutso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnkoutso/subscriptions","organizations_url":"https://api.github.com/users/dnkoutso/orgs","repos_url":"https://api.github.com/users/dnkoutso/repos","events_url":"https://api.github.com/users/dnkoutso/events{/privacy}","received_events_url":"https://api.github.com/users/dnkoutso/received_events","type":"User","site_admin":false},"repo":{"id":39788662,"name":"CocoaPods","full_name":"dnkoutso/CocoaPods","owner":{"login":"dnkoutso","id":310370,"avatar_url":"https://avatars2.githubusercontent.com/u/310370?v=4","gravatar_id":"","url":"https://api.github.com/users/dnkoutso","html_url":"https://github.com/dnkoutso","followers_url":"https://api.github.com/users/dnkoutso/followers","following_url":"https://api.github.com/users/dnkoutso/following{/other_user}","gists_url":"https://api.github.com/users/dnkoutso/gists{/gist_id}","starred_url":"https://api.github.com/users/dnkoutso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnkoutso/subscriptions","organizations_url":"https://api.github.com/users/dnkoutso/orgs","repos_url":"https://api.github.com/users/dnkoutso/repos","events_url":"https://api.github.com/users/dnkoutso/events{/privacy}","received_events_url":"https://api.github.com/users/dnkoutso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dnkoutso/CocoaPods","description":"The Cocoa Dependency Manager.","fork":true,"url":"https://api.github.com/repos/dnkoutso/CocoaPods","forks_url":"https://api.github.com/repos/dnkoutso/CocoaPods/forks","keys_url":"https://api.github.com/repos/dnkoutso/CocoaPods/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dnkoutso/CocoaPods/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dnkoutso/CocoaPods/teams","hooks_url":"https://api.github.com/repos/dnkoutso/CocoaPods/hooks","issue_events_url":"https://api.github.com/repos/dnkoutso/CocoaPods/issues/events{/number}","events_url":"https://api.github.com/repos/dnkoutso/CocoaPods/events","assignees_url":"https://api.github.com/repos/dnkoutso/CocoaPods/assignees{/user}","branches_url":"https://api.github.com/repos/dnkoutso/CocoaPods/branches{/branch}","tags_url":"https://api.github.com/repos/dnkoutso/CocoaPods/tags","blobs_url":"https://api.github.com/repos/dnkoutso/CocoaPods/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dnkoutso/CocoaPods/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dnkoutso/CocoaPods/git/refs{/sha}","trees_url":"https://api.github.com/repos/dnkoutso/CocoaPods/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dnkoutso/CocoaPods/statuses/{sha}","languages_url":"https://api.github.com/repos/dnkoutso/CocoaPods/languages","stargazers_url":"https://api.github.com/repos/dnkoutso/CocoaPods/stargazers","contributors_url":"https://api.github.com/repos/dnkoutso/CocoaPods/contributors","subscribers_url":"https://api.github.com/repos/dnkoutso/CocoaPods/subscribers","subscription_url":"https://api.github.com/repos/dnkoutso/CocoaPods/subscription","commits_url":"https://api.github.com/repos/dnkoutso/CocoaPods/commits{/sha}","git_commits_url":"https://api.github.com/repos/dnkoutso/CocoaPods/git/commits{/sha}","comments_url":"https://api.github.com/repos/dnkoutso/CocoaPods/comments{/number}","issue_comment_url":"https://api.github.com/repos/dnkoutso/CocoaPods/issues/comments{/number}","contents_url":"https://api.github.com/repos/dnkoutso/CocoaPods/contents/{+path}","compare_url":"https://api.github.com/repos/dnkoutso/CocoaPods/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dnkoutso/CocoaPods/merges","archive_url":"https://api.github.com/repos/dnkoutso/CocoaPods/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dnkoutso/CocoaPods/downloads","issues_url":"https://api.github.com/repos/dnkoutso/CocoaPods/issues{/number}","pulls_url":"https://api.github.com/repos/dnkoutso/CocoaPods/pulls{/number}","milestones_url":"https://api.github.com/repos/dnkoutso/CocoaPods/milestones{/number}","notifications_url":"https://api.github.com/repos/dnkoutso/CocoaPods/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dnkoutso/CocoaPods/labels{/name}","releases_url":"https://api.github.com/repos/dnkoutso/CocoaPods/releases{/id}","deployments_url":"https://api.github.com/repos/dnkoutso/CocoaPods/deployments","created_at":"2015-07-27T17:39:59Z","updated_at":"2018-03-15T22:19:39Z","pushed_at":"2018-03-16T01:48:17Z","git_url":"git://github.com/dnkoutso/CocoaPods.git","ssh_url":"git@github.com:dnkoutso/CocoaPods.git","clone_url":"https://github.com/dnkoutso/CocoaPods.git","svn_url":"https://github.com/dnkoutso/CocoaPods","homepage":"cocoapods.org","size":55738,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CocoaPods:master","ref":"master","sha":"4739ff19d90aa2b8d6c3aa9d895320273b84750e","user":{"login":"CocoaPods","id":1189714,"avatar_url":"https://avatars1.githubusercontent.com/u/1189714?v=4","gravatar_id":"","url":"https://api.github.com/users/CocoaPods","html_url":"https://github.com/CocoaPods","followers_url":"https://api.github.com/users/CocoaPods/followers","following_url":"https://api.github.com/users/CocoaPods/following{/other_user}","gists_url":"https://api.github.com/users/CocoaPods/gists{/gist_id}","starred_url":"https://api.github.com/users/CocoaPods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CocoaPods/subscriptions","organizations_url":"https://api.github.com/users/CocoaPods/orgs","repos_url":"https://api.github.com/users/CocoaPods/repos","events_url":"https://api.github.com/users/CocoaPods/events{/privacy}","received_events_url":"https://api.github.com/users/CocoaPods/received_events","type":"Organization","site_admin":false},"repo":{"id":2203645,"name":"CocoaPods","full_name":"CocoaPods/CocoaPods","owner":{"login":"CocoaPods","id":1189714,"avatar_url":"https://avatars1.githubusercontent.com/u/1189714?v=4","gravatar_id":"","url":"https://api.github.com/users/CocoaPods","html_url":"https://github.com/CocoaPods","followers_url":"https://api.github.com/users/CocoaPods/followers","following_url":"https://api.github.com/users/CocoaPods/following{/other_user}","gists_url":"https://api.github.com/users/CocoaPods/gists{/gist_id}","starred_url":"https://api.github.com/users/CocoaPods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CocoaPods/subscriptions","organizations_url":"https://api.github.com/users/CocoaPods/orgs","repos_url":"https://api.github.com/users/CocoaPods/repos","events_url":"https://api.github.com/users/CocoaPods/events{/privacy}","received_events_url":"https://api.github.com/users/CocoaPods/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CocoaPods/CocoaPods","description":"The Cocoa Dependency Manager.","fork":false,"url":"https://api.github.com/repos/CocoaPods/CocoaPods","forks_url":"https://api.github.com/repos/CocoaPods/CocoaPods/forks","keys_url":"https://api.github.com/repos/CocoaPods/CocoaPods/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CocoaPods/CocoaPods/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CocoaPods/CocoaPods/teams","hooks_url":"https://api.github.com/repos/CocoaPods/CocoaPods/hooks","issue_events_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/events{/number}","events_url":"https://api.github.com/repos/CocoaPods/CocoaPods/events","assignees_url":"https://api.github.com/repos/CocoaPods/CocoaPods/assignees{/user}","branches_url":"https://api.github.com/repos/CocoaPods/CocoaPods/branches{/branch}","tags_url":"https://api.github.com/repos/CocoaPods/CocoaPods/tags","blobs_url":"https://api.github.com/repos/CocoaPods/CocoaPods/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CocoaPods/CocoaPods/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CocoaPods/CocoaPods/git/refs{/sha}","trees_url":"https://api.github.com/repos/CocoaPods/CocoaPods/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CocoaPods/CocoaPods/statuses/{sha}","languages_url":"https://api.github.com/repos/CocoaPods/CocoaPods/languages","stargazers_url":"https://api.github.com/repos/CocoaPods/CocoaPods/stargazers","contributors_url":"https://api.github.com/repos/CocoaPods/CocoaPods/contributors","subscribers_url":"https://api.github.com/repos/CocoaPods/CocoaPods/subscribers","subscription_url":"https://api.github.com/repos/CocoaPods/CocoaPods/subscription","commits_url":"https://api.github.com/repos/CocoaPods/CocoaPods/commits{/sha}","git_commits_url":"https://api.github.com/repos/CocoaPods/CocoaPods/git/commits{/sha}","comments_url":"https://api.github.com/repos/CocoaPods/CocoaPods/comments{/number}","issue_comment_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/comments{/number}","contents_url":"https://api.github.com/repos/CocoaPods/CocoaPods/contents/{+path}","compare_url":"https://api.github.com/repos/CocoaPods/CocoaPods/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CocoaPods/CocoaPods/merges","archive_url":"https://api.github.com/repos/CocoaPods/CocoaPods/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CocoaPods/CocoaPods/downloads","issues_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues{/number}","pulls_url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls{/number}","milestones_url":"https://api.github.com/repos/CocoaPods/CocoaPods/milestones{/number}","notifications_url":"https://api.github.com/repos/CocoaPods/CocoaPods/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CocoaPods/CocoaPods/labels{/name}","releases_url":"https://api.github.com/repos/CocoaPods/CocoaPods/releases{/id}","deployments_url":"https://api.github.com/repos/CocoaPods/CocoaPods/deployments","created_at":"2011-08-14T00:10:53Z","updated_at":"2018-03-15T22:58:53Z","pushed_at":"2018-03-16T02:17:21Z","git_url":"git://github.com/CocoaPods/CocoaPods.git","ssh_url":"git@github.com:CocoaPods/CocoaPods.git","clone_url":"https://github.com/CocoaPods/CocoaPods.git","svn_url":"https://github.com/CocoaPods/CocoaPods","homepage":"https://cocoapods.org/","size":55572,"stargazers_count":10297,"watchers_count":10297,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1885,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1885,"open_issues":112,"watchers":10297,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/7505"},"html":{"href":"https://github.com/CocoaPods/CocoaPods/pull/7505"},"issue":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/7505"},"comments":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/7505/comments"},"review_comments":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/7505/comments"},"review_comment":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/7505/commits"},"statuses":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/statuses/214aba000a7421e0d49d510238d31fe9359adb6b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dnkoutso"}}