{"action":"created","comment":{"url":"https://api.github.com/repos/basbeu/theSofties/pulls/comments/224984436","pull_request_review_id":164489729,"id":224984436,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDk4NDQzNg==","diff_hunk":"@@ -0,0 +1,46 @@\n+package ch.epfl.sweng.favors.database;\n+\n+import android.databinding.ObservableField;\n+import android.util.Log;\n+\n+import javax.annotation.Nonnull;\n+\n+/**\n+ * This class should be used when accessing user sexField\n+ */\n+public enum UserGender {","path":"app/src/main/java/ch/epfl/sweng/favors/database/UserGender.java","position":11,"original_position":11,"commit_id":"3c725ef8e64552a03f889c24ecd385df4ebdbd8b","original_commit_id":"6efaff41d5a4d0da6db067cf311c02f197a57eac","user":{"login":"basbeu","id":26392804,"node_id":"MDQ6VXNlcjI2MzkyODA0","avatar_url":"https://avatars2.githubusercontent.com/u/26392804?v=4","gravatar_id":"","url":"https://api.github.com/users/basbeu","html_url":"https://github.com/basbeu","followers_url":"https://api.github.com/users/basbeu/followers","following_url":"https://api.github.com/users/basbeu/following{/other_user}","gists_url":"https://api.github.com/users/basbeu/gists{/gist_id}","starred_url":"https://api.github.com/users/basbeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basbeu/subscriptions","organizations_url":"https://api.github.com/users/basbeu/orgs","repos_url":"https://api.github.com/users/basbeu/repos","events_url":"https://api.github.com/users/basbeu/events{/privacy}","received_events_url":"https://api.github.com/users/basbeu/received_events","type":"User","site_admin":false},"body":"Do not really understand why you do not encapsulate the sex or gender in the User object. Because sex or gender is a field of User ","created_at":"2018-10-14T08:32:34Z","updated_at":"2018-10-14T08:32:40Z","html_url":"https://github.com/basbeu/theSofties/pull/150#discussion_r224984436","pull_request_url":"https://api.github.com/repos/basbeu/theSofties/pulls/150","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/basbeu/theSofties/pulls/comments/224984436"},"html":{"href":"https://github.com/basbeu/theSofties/pull/150#discussion_r224984436"},"pull_request":{"href":"https://api.github.com/repos/basbeu/theSofties/pulls/150"}},"in_reply_to_id":224975192},"pull_request":{"url":"https://api.github.com/repos/basbeu/theSofties/pulls/150","id":222683954,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNjgzOTU0","html_url":"https://github.com/basbeu/theSofties/pull/150","diff_url":"https://github.com/basbeu/theSofties/pull/150.diff","patch_url":"https://github.com/basbeu/theSofties/pull/150.patch","issue_url":"https://api.github.com/repos/basbeu/theSofties/issues/150","number":150,"state":"open","locked":false,"title":"Fb profile edit sex binary","user":{"login":"Jmion","id":15061803,"node_id":"MDQ6VXNlcjE1MDYxODAz","avatar_url":"https://avatars2.githubusercontent.com/u/15061803?v=4","gravatar_id":"","url":"https://api.github.com/users/Jmion","html_url":"https://github.com/Jmion","followers_url":"https://api.github.com/users/Jmion/followers","following_url":"https://api.github.com/users/Jmion/following{/other_user}","gists_url":"https://api.github.com/users/Jmion/gists{/gist_id}","starred_url":"https://api.github.com/users/Jmion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jmion/subscriptions","organizations_url":"https://api.github.com/users/Jmion/orgs","repos_url":"https://api.github.com/users/Jmion/repos","events_url":"https://api.github.com/users/Jmion/events{/privacy}","received_events_url":"https://api.github.com/users/Jmion/received_events","type":"User","site_admin":false},"body":"# Summary of modifications made\r\nThis pull request resolves part of the issue #128 that reqested that we have binary sex in the edit profile.  The issue #149 was open to resolve similar issue in the user creation process. \r\n## UserGender\r\nThis enum was created to create and abstration between the database representation and it's representation in the app. Creating such an abstraction allows for more flexibility in the backend. The user of the gender does not need to know that in the backend it is a String.","created_at":"2018-10-14T00:04:55Z","updated_at":"2018-10-14T08:32:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"418a7c81f89c6eaeedba106f96a2323346d2880b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"alexander-san","id":23143285,"node_id":"MDQ6VXNlcjIzMTQzMjg1","avatar_url":"https://avatars3.githubusercontent.com/u/23143285?v=4","gravatar_id":"","url":"https://api.github.com/users/alexander-san","html_url":"https://github.com/alexander-san","followers_url":"https://api.github.com/users/alexander-san/followers","following_url":"https://api.github.com/users/alexander-san/following{/other_user}","gists_url":"https://api.github.com/users/alexander-san/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-san/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-san/subscriptions","organizations_url":"https://api.github.com/users/alexander-san/orgs","repos_url":"https://api.github.com/users/alexander-san/repos","events_url":"https://api.github.com/users/alexander-san/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-san/received_events","type":"User","site_admin":false},{"login":"nicolasp9-dev","id":25265664,"node_id":"MDQ6VXNlcjI1MjY1NjY0","avatar_url":"https://avatars1.githubusercontent.com/u/25265664?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolasp9-dev","html_url":"https://github.com/nicolasp9-dev","followers_url":"https://api.github.com/users/nicolasp9-dev/followers","following_url":"https://api.github.com/users/nicolasp9-dev/following{/other_user}","gists_url":"https://api.github.com/users/nicolasp9-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasp9-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasp9-dev/subscriptions","organizations_url":"https://api.github.com/users/nicolasp9-dev/orgs","repos_url":"https://api.github.com/users/nicolasp9-dev/repos","events_url":"https://api.github.com/users/nicolasp9-dev/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasp9-dev/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/basbeu/theSofties/pulls/150/commits","review_comments_url":"https://api.github.com/repos/basbeu/theSofties/pulls/150/comments","review_comment_url":"https://api.github.com/repos/basbeu/theSofties/pulls/comments{/number}","comments_url":"https://api.github.com/repos/basbeu/theSofties/issues/150/comments","statuses_url":"https://api.github.com/repos/basbeu/theSofties/statuses/3c725ef8e64552a03f889c24ecd385df4ebdbd8b","head":{"label":"basbeu:fb_profileEditSexBinary","ref":"fb_profileEditSexBinary","sha":"3c725ef8e64552a03f889c24ecd385df4ebdbd8b","user":{"login":"basbeu","id":26392804,"node_id":"MDQ6VXNlcjI2MzkyODA0","avatar_url":"https://avatars2.githubusercontent.com/u/26392804?v=4","gravatar_id":"","url":"https://api.github.com/users/basbeu","html_url":"https://github.com/basbeu","followers_url":"https://api.github.com/users/basbeu/followers","following_url":"https://api.github.com/users/basbeu/following{/other_user}","gists_url":"https://api.github.com/users/basbeu/gists{/gist_id}","starred_url":"https://api.github.com/users/basbeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basbeu/subscriptions","organizations_url":"https://api.github.com/users/basbeu/orgs","repos_url":"https://api.github.com/users/basbeu/repos","events_url":"https://api.github.com/users/basbeu/events{/privacy}","received_events_url":"https://api.github.com/users/basbeu/received_events","type":"User","site_admin":false},"repo":{"id":150413575,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA0MTM1NzU=","name":"theSofties","full_name":"basbeu/theSofties","private":false,"owner":{"login":"basbeu","id":26392804,"node_id":"MDQ6VXNlcjI2MzkyODA0","avatar_url":"https://avatars2.githubusercontent.com/u/26392804?v=4","gravatar_id":"","url":"https://api.github.com/users/basbeu","html_url":"https://github.com/basbeu","followers_url":"https://api.github.com/users/basbeu/followers","following_url":"https://api.github.com/users/basbeu/following{/other_user}","gists_url":"https://api.github.com/users/basbeu/gists{/gist_id}","starred_url":"https://api.github.com/users/basbeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basbeu/subscriptions","organizations_url":"https://api.github.com/users/basbeu/orgs","repos_url":"https://api.github.com/users/basbeu/repos","events_url":"https://api.github.com/users/basbeu/events{/privacy}","received_events_url":"https://api.github.com/users/basbeu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/basbeu/theSofties","description":null,"fork":false,"url":"https://api.github.com/repos/basbeu/theSofties","forks_url":"https://api.github.com/repos/basbeu/theSofties/forks","keys_url":"https://api.github.com/repos/basbeu/theSofties/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basbeu/theSofties/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basbeu/theSofties/teams","hooks_url":"https://api.github.com/repos/basbeu/theSofties/hooks","issue_events_url":"https://api.github.com/repos/basbeu/theSofties/issues/events{/number}","events_url":"https://api.github.com/repos/basbeu/theSofties/events","assignees_url":"https://api.github.com/repos/basbeu/theSofties/assignees{/user}","branches_url":"https://api.github.com/repos/basbeu/theSofties/branches{/branch}","tags_url":"https://api.github.com/repos/basbeu/theSofties/tags","blobs_url":"https://api.github.com/repos/basbeu/theSofties/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basbeu/theSofties/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basbeu/theSofties/git/refs{/sha}","trees_url":"https://api.github.com/repos/basbeu/theSofties/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basbeu/theSofties/statuses/{sha}","languages_url":"https://api.github.com/repos/basbeu/theSofties/languages","stargazers_url":"https://api.github.com/repos/basbeu/theSofties/stargazers","contributors_url":"https://api.github.com/repos/basbeu/theSofties/contributors","subscribers_url":"https://api.github.com/repos/basbeu/theSofties/subscribers","subscription_url":"https://api.github.com/repos/basbeu/theSofties/subscription","commits_url":"https://api.github.com/repos/basbeu/theSofties/commits{/sha}","git_commits_url":"https://api.github.com/repos/basbeu/theSofties/git/commits{/sha}","comments_url":"https://api.github.com/repos/basbeu/theSofties/comments{/number}","issue_comment_url":"https://api.github.com/repos/basbeu/theSofties/issues/comments{/number}","contents_url":"https://api.github.com/repos/basbeu/theSofties/contents/{+path}","compare_url":"https://api.github.com/repos/basbeu/theSofties/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basbeu/theSofties/merges","archive_url":"https://api.github.com/repos/basbeu/theSofties/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basbeu/theSofties/downloads","issues_url":"https://api.github.com/repos/basbeu/theSofties/issues{/number}","pulls_url":"https://api.github.com/repos/basbeu/theSofties/pulls{/number}","milestones_url":"https://api.github.com/repos/basbeu/theSofties/milestones{/number}","notifications_url":"https://api.github.com/repos/basbeu/theSofties/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basbeu/theSofties/labels{/name}","releases_url":"https://api.github.com/repos/basbeu/theSofties/releases{/id}","deployments_url":"https://api.github.com/repos/basbeu/theSofties/deployments","created_at":"2018-09-26T11:07:43Z","updated_at":"2018-10-13T10:29:19Z","pushed_at":"2018-10-14T07:40:46Z","git_url":"git://github.com/basbeu/theSofties.git","ssh_url":"git@github.com:basbeu/theSofties.git","clone_url":"https://github.com/basbeu/theSofties.git","svn_url":"https://github.com/basbeu/theSofties","homepage":null,"size":67537,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":61,"license":null,"forks":0,"open_issues":61,"watchers":0,"default_branch":"master"}},"base":{"label":"basbeu:develop","ref":"develop","sha":"3cc9b9580ac247434ae5f057d3272d833607bf72","user":{"login":"basbeu","id":26392804,"node_id":"MDQ6VXNlcjI2MzkyODA0","avatar_url":"https://avatars2.githubusercontent.com/u/26392804?v=4","gravatar_id":"","url":"https://api.github.com/users/basbeu","html_url":"https://github.com/basbeu","followers_url":"https://api.github.com/users/basbeu/followers","following_url":"https://api.github.com/users/basbeu/following{/other_user}","gists_url":"https://api.github.com/users/basbeu/gists{/gist_id}","starred_url":"https://api.github.com/users/basbeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basbeu/subscriptions","organizations_url":"https://api.github.com/users/basbeu/orgs","repos_url":"https://api.github.com/users/basbeu/repos","events_url":"https://api.github.com/users/basbeu/events{/privacy}","received_events_url":"https://api.github.com/users/basbeu/received_events","type":"User","site_admin":false},"repo":{"id":150413575,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA0MTM1NzU=","name":"theSofties","full_name":"basbeu/theSofties","private":false,"owner":{"login":"basbeu","id":26392804,"node_id":"MDQ6VXNlcjI2MzkyODA0","avatar_url":"https://avatars2.githubusercontent.com/u/26392804?v=4","gravatar_id":"","url":"https://api.github.com/users/basbeu","html_url":"https://github.com/basbeu","followers_url":"https://api.github.com/users/basbeu/followers","following_url":"https://api.github.com/users/basbeu/following{/other_user}","gists_url":"https://api.github.com/users/basbeu/gists{/gist_id}","starred_url":"https://api.github.com/users/basbeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basbeu/subscriptions","organizations_url":"https://api.github.com/users/basbeu/orgs","repos_url":"https://api.github.com/users/basbeu/repos","events_url":"https://api.github.com/users/basbeu/events{/privacy}","received_events_url":"https://api.github.com/users/basbeu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/basbeu/theSofties","description":null,"fork":false,"url":"https://api.github.com/repos/basbeu/theSofties","forks_url":"https://api.github.com/repos/basbeu/theSofties/forks","keys_url":"https://api.github.com/repos/basbeu/theSofties/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basbeu/theSofties/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basbeu/theSofties/teams","hooks_url":"https://api.github.com/repos/basbeu/theSofties/hooks","issue_events_url":"https://api.github.com/repos/basbeu/theSofties/issues/events{/number}","events_url":"https://api.github.com/repos/basbeu/theSofties/events","assignees_url":"https://api.github.com/repos/basbeu/theSofties/assignees{/user}","branches_url":"https://api.github.com/repos/basbeu/theSofties/branches{/branch}","tags_url":"https://api.github.com/repos/basbeu/theSofties/tags","blobs_url":"https://api.github.com/repos/basbeu/theSofties/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basbeu/theSofties/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basbeu/theSofties/git/refs{/sha}","trees_url":"https://api.github.com/repos/basbeu/theSofties/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basbeu/theSofties/statuses/{sha}","languages_url":"https://api.github.com/repos/basbeu/theSofties/languages","stargazers_url":"https://api.github.com/repos/basbeu/theSofties/stargazers","contributors_url":"https://api.github.com/repos/basbeu/theSofties/contributors","subscribers_url":"https://api.github.com/repos/basbeu/theSofties/subscribers","subscription_url":"https://api.github.com/repos/basbeu/theSofties/subscription","commits_url":"https://api.github.com/repos/basbeu/theSofties/commits{/sha}","git_commits_url":"https://api.github.com/repos/basbeu/theSofties/git/commits{/sha}","comments_url":"https://api.github.com/repos/basbeu/theSofties/comments{/number}","issue_comment_url":"https://api.github.com/repos/basbeu/theSofties/issues/comments{/number}","contents_url":"https://api.github.com/repos/basbeu/theSofties/contents/{+path}","compare_url":"https://api.github.com/repos/basbeu/theSofties/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basbeu/theSofties/merges","archive_url":"https://api.github.com/repos/basbeu/theSofties/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basbeu/theSofties/downloads","issues_url":"https://api.github.com/repos/basbeu/theSofties/issues{/number}","pulls_url":"https://api.github.com/repos/basbeu/theSofties/pulls{/number}","milestones_url":"https://api.github.com/repos/basbeu/theSofties/milestones{/number}","notifications_url":"https://api.github.com/repos/basbeu/theSofties/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basbeu/theSofties/labels{/name}","releases_url":"https://api.github.com/repos/basbeu/theSofties/releases{/id}","deployments_url":"https://api.github.com/repos/basbeu/theSofties/deployments","created_at":"2018-09-26T11:07:43Z","updated_at":"2018-10-13T10:29:19Z","pushed_at":"2018-10-14T07:40:46Z","git_url":"git://github.com/basbeu/theSofties.git","ssh_url":"git@github.com:basbeu/theSofties.git","clone_url":"https://github.com/basbeu/theSofties.git","svn_url":"https://github.com/basbeu/theSofties","homepage":null,"size":67537,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":61,"license":null,"forks":0,"open_issues":61,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/basbeu/theSofties/pulls/150"},"html":{"href":"https://github.com/basbeu/theSofties/pull/150"},"issue":{"href":"https://api.github.com/repos/basbeu/theSofties/issues/150"},"comments":{"href":"https://api.github.com/repos/basbeu/theSofties/issues/150/comments"},"review_comments":{"href":"https://api.github.com/repos/basbeu/theSofties/pulls/150/comments"},"review_comment":{"href":"https://api.github.com/repos/basbeu/theSofties/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/basbeu/theSofties/pulls/150/commits"},"statuses":{"href":"https://api.github.com/repos/basbeu/theSofties/statuses/3c725ef8e64552a03f889c24ecd385df4ebdbd8b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"basbeu"}}