{"action":"opened","number":11519,"pull_request":{"url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/11519","id":202836193,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyODM2MTkz","html_url":"https://github.com/RocketChat/Rocket.Chat/pull/11519","diff_url":"https://github.com/RocketChat/Rocket.Chat/pull/11519.diff","patch_url":"https://github.com/RocketChat/Rocket.Chat/pull/11519.patch","issue_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/11519","number":11519,"state":"open","locked":false,"title":"WIP: [FIX] Allow spaces in channel creation ui","user":{"login":"shahar3012","id":7993291,"node_id":"MDQ6VXNlcjc5OTMyOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/7993291?v=4","gravatar_id":"","url":"https://api.github.com/users/shahar3012","html_url":"https://github.com/shahar3012","followers_url":"https://api.github.com/users/shahar3012/followers","following_url":"https://api.github.com/users/shahar3012/following{/other_user}","gists_url":"https://api.github.com/users/shahar3012/gists{/gist_id}","starred_url":"https://api.github.com/users/shahar3012/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shahar3012/subscriptions","organizations_url":"https://api.github.com/users/shahar3012/orgs","repos_url":"https://api.github.com/users/shahar3012/repos","events_url":"https://api.github.com/users/shahar3012/events{/privacy}","received_events_url":"https://api.github.com/users/shahar3012/received_events","type":"User","site_admin":false},"body":"This PR allows spaces in channel creation in the client side.\r\nIt removes the code that used to be replacing spaces with empty string.\r\n\r\nThe `UI_Allow_room_names_with_special_chars` setting doesn't do any validation at the client side.\r\nHowever at the sever it caused error when trying to use non-latin languages like Hebrew, because it enables the slugify function of `underscore.string` (which is not so logical because there is another `UTF8_Names_Slugify` setting that is used only at `getUsernameSuggestion.js` and `sync.js` files in `server/methods` and `rocketchat-ldap` package respectively).\r\n\r\nThis PR fixes this issue and allow using spaces in channel names while configuring the `UTF8_Names_Validation` to include spaces.\r\n\r\nFurther work needs to be done in order to merge it with Official Rocket.Chat repo:\r\nThis fix is depends on the `UTF8_Names_Validation` setting, but it allows also users to have spaces in the username.\r\n\r\nIn order to fix it, I suggest to separate this setting into new 2 settings:\r\n* `UTF8_Channel_Names_Validation`\r\n* `UTF8_User_Names_Validation`\r\n\r\nThat way we can achieve granular-level settings.\r\n\r\nAlso, I suggest we should remove the `UI_Allow_room_names_with_special_chars` setting, because it's no longer needed when we have a granular-level settings - we can set the RegExp to be exactly how we intend.\r\n\r\n","created_at":"2018-07-20T12:33:48Z","updated_at":"2018-07-20T12:33:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/11519/commits","review_comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/11519/comments","review_comment_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/11519/comments","statuses_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/statuses/d958ab4c7d34053adeba67a3c611f8f695cc8e99","head":{"label":"shahar3012:fix-allow-spaces-in-channel-creation-ui","ref":"fix-allow-spaces-in-channel-creation-ui","sha":"d958ab4c7d34053adeba67a3c611f8f695cc8e99","user":{"login":"shahar3012","id":7993291,"node_id":"MDQ6VXNlcjc5OTMyOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/7993291?v=4","gravatar_id":"","url":"https://api.github.com/users/shahar3012","html_url":"https://github.com/shahar3012","followers_url":"https://api.github.com/users/shahar3012/followers","following_url":"https://api.github.com/users/shahar3012/following{/other_user}","gists_url":"https://api.github.com/users/shahar3012/gists{/gist_id}","starred_url":"https://api.github.com/users/shahar3012/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shahar3012/subscriptions","organizations_url":"https://api.github.com/users/shahar3012/orgs","repos_url":"https://api.github.com/users/shahar3012/repos","events_url":"https://api.github.com/users/shahar3012/events{/privacy}","received_events_url":"https://api.github.com/users/shahar3012/received_events","type":"User","site_admin":false},"repo":{"id":141475481,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE0NzU0ODE=","name":"Rocket.Chat","full_name":"shahar3012/Rocket.Chat","owner":{"login":"shahar3012","id":7993291,"node_id":"MDQ6VXNlcjc5OTMyOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/7993291?v=4","gravatar_id":"","url":"https://api.github.com/users/shahar3012","html_url":"https://github.com/shahar3012","followers_url":"https://api.github.com/users/shahar3012/followers","following_url":"https://api.github.com/users/shahar3012/following{/other_user}","gists_url":"https://api.github.com/users/shahar3012/gists{/gist_id}","starred_url":"https://api.github.com/users/shahar3012/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shahar3012/subscriptions","organizations_url":"https://api.github.com/users/shahar3012/orgs","repos_url":"https://api.github.com/users/shahar3012/repos","events_url":"https://api.github.com/users/shahar3012/events{/privacy}","received_events_url":"https://api.github.com/users/shahar3012/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shahar3012/Rocket.Chat","description":"Have your own Slack like online chat, built with Meteor.","fork":true,"url":"https://api.github.com/repos/shahar3012/Rocket.Chat","forks_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/forks","keys_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/teams","hooks_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/hooks","issue_events_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/issues/events{/number}","events_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/events","assignees_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/assignees{/user}","branches_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/branches{/branch}","tags_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/tags","blobs_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/git/refs{/sha}","trees_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/statuses/{sha}","languages_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/languages","stargazers_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/stargazers","contributors_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/contributors","subscribers_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/subscribers","subscription_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/subscription","commits_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/commits{/sha}","git_commits_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/git/commits{/sha}","comments_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/comments{/number}","issue_comment_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/issues/comments{/number}","contents_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/contents/{+path}","compare_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/merges","archive_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/downloads","issues_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/issues{/number}","pulls_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/pulls{/number}","milestones_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/milestones{/number}","notifications_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/labels{/name}","releases_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/releases{/id}","deployments_url":"https://api.github.com/repos/shahar3012/Rocket.Chat/deployments","created_at":"2018-07-18T18:37:36Z","updated_at":"2018-07-20T09:09:09Z","pushed_at":"2018-07-20T12:00:12Z","git_url":"git://github.com/shahar3012/Rocket.Chat.git","ssh_url":"git@github.com:shahar3012/Rocket.Chat.git","clone_url":"https://github.com/shahar3012/Rocket.Chat.git","svn_url":"https://github.com/shahar3012/Rocket.Chat","homepage":"https://rocket.chat/","size":74697,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"RocketChat:develop","ref":"develop","sha":"829c5d1bfb41331d4c990d2d1caf8ac13e3eca73","user":{"login":"RocketChat","id":12508788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA4Nzg4","avatar_url":"https://avatars1.githubusercontent.com/u/12508788?v=4","gravatar_id":"","url":"https://api.github.com/users/RocketChat","html_url":"https://github.com/RocketChat","followers_url":"https://api.github.com/users/RocketChat/followers","following_url":"https://api.github.com/users/RocketChat/following{/other_user}","gists_url":"https://api.github.com/users/RocketChat/gists{/gist_id}","starred_url":"https://api.github.com/users/RocketChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RocketChat/subscriptions","organizations_url":"https://api.github.com/users/RocketChat/orgs","repos_url":"https://api.github.com/users/RocketChat/repos","events_url":"https://api.github.com/users/RocketChat/events{/privacy}","received_events_url":"https://api.github.com/users/RocketChat/received_events","type":"Organization","site_admin":false},"repo":{"id":35866694,"node_id":"MDEwOlJlcG9zaXRvcnkzNTg2NjY5NA==","name":"Rocket.Chat","full_name":"RocketChat/Rocket.Chat","owner":{"login":"RocketChat","id":12508788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA4Nzg4","avatar_url":"https://avatars1.githubusercontent.com/u/12508788?v=4","gravatar_id":"","url":"https://api.github.com/users/RocketChat","html_url":"https://github.com/RocketChat","followers_url":"https://api.github.com/users/RocketChat/followers","following_url":"https://api.github.com/users/RocketChat/following{/other_user}","gists_url":"https://api.github.com/users/RocketChat/gists{/gist_id}","starred_url":"https://api.github.com/users/RocketChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RocketChat/subscriptions","organizations_url":"https://api.github.com/users/RocketChat/orgs","repos_url":"https://api.github.com/users/RocketChat/repos","events_url":"https://api.github.com/users/RocketChat/events{/privacy}","received_events_url":"https://api.github.com/users/RocketChat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RocketChat/Rocket.Chat","description":"Have your own Slack like online chat, built with Meteor.","fork":false,"url":"https://api.github.com/repos/RocketChat/Rocket.Chat","forks_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/forks","keys_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/teams","hooks_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/hooks","issue_events_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/events{/number}","events_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/events","assignees_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/assignees{/user}","branches_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/branches{/branch}","tags_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/tags","blobs_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/refs{/sha}","trees_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/statuses/{sha}","languages_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/languages","stargazers_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/stargazers","contributors_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/contributors","subscribers_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/subscribers","subscription_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/subscription","commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/commits{/sha}","git_commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/git/commits{/sha}","comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/comments{/number}","issue_comment_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/comments{/number}","contents_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/contents/{+path}","compare_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/merges","archive_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/downloads","issues_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues{/number}","pulls_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls{/number}","milestones_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/milestones{/number}","notifications_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/labels{/name}","releases_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/releases{/id}","deployments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat/deployments","created_at":"2015-05-19T07:36:09Z","updated_at":"2018-07-20T10:28:56Z","pushed_at":"2018-07-20T06:17:40Z","git_url":"git://github.com/RocketChat/Rocket.Chat.git","ssh_url":"git@github.com:RocketChat/Rocket.Chat.git","clone_url":"https://github.com/RocketChat/Rocket.Chat.git","svn_url":"https://github.com/RocketChat/Rocket.Chat","homepage":"https://rocket.chat/","size":74751,"stargazers_count":18960,"watchers_count":18960,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4050,"mirror_url":null,"archived":false,"open_issues_count":2006,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4050,"open_issues":2006,"watchers":18960,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/11519"},"html":{"href":"https://github.com/RocketChat/Rocket.Chat/pull/11519"},"issue":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/11519"},"comments":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/issues/11519/comments"},"review_comments":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/11519/comments"},"review_comment":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/pulls/11519/commits"},"statuses":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat/statuses/d958ab4c7d34053adeba67a3c611f8f695cc8e99"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"shahar3012"}}