{"action":"created","comment":{"url":"https://api.github.com/repos/xbulat/rack-example/pulls/comments/243160710","pull_request_review_id":186854476,"id":243160710,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzE2MDcxMA==","diff_hunk":"@@ -5,26 +5,29 @@ class TimeStamp\n               'hour' => '%H',\n               'second' => '%S' }.freeze\n \n-  def initialize(query)\n-    @query = query\n-    @format = []\n-    @unknown = []\n-    parse!\n+  def initialize(params)\n+    @params = params.split(',')\n   end\n \n-  def bad_request?\n-    @unknown.any?\n+  def has_invalid?","path":"timestamp.rb","position":12,"original_position":15,"commit_id":"5eded735097828c77f6e651fcf2751f52c4257f0","original_commit_id":"5eded735097828c77f6e651fcf2751f52c4257f0","user":{"login":"iBublik","id":11278497,"node_id":"MDQ6VXNlcjExMjc4NDk3","avatar_url":"https://avatars1.githubusercontent.com/u/11278497?v=4","gravatar_id":"","url":"https://api.github.com/users/iBublik","html_url":"https://github.com/iBublik","followers_url":"https://api.github.com/users/iBublik/followers","following_url":"https://api.github.com/users/iBublik/following{/other_user}","gists_url":"https://api.github.com/users/iBublik/gists{/gist_id}","starred_url":"https://api.github.com/users/iBublik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iBublik/subscriptions","organizations_url":"https://api.github.com/users/iBublik/orgs","repos_url":"https://api.github.com/users/iBublik/repos","events_url":"https://api.github.com/users/iBublik/events{/privacy}","received_events_url":"https://api.github.com/users/iBublik/received_events","type":"User","site_admin":false},"body":"В Ruby не принято создавать методы с префиксами has/is, ведь есть `?` в конце","created_at":"2018-12-20T05:39:54Z","updated_at":"2018-12-20T05:40:34Z","html_url":"https://github.com/xbulat/rack-example/pull/1#discussion_r243160710","pull_request_url":"https://api.github.com/repos/xbulat/rack-example/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/xbulat/rack-example/pulls/comments/243160710"},"html":{"href":"https://github.com/xbulat/rack-example/pull/1#discussion_r243160710"},"pull_request":{"href":"https://api.github.com/repos/xbulat/rack-example/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/xbulat/rack-example/pulls/1","id":238931716,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4OTMxNzE2","html_url":"https://github.com/xbulat/rack-example/pull/1","diff_url":"https://github.com/xbulat/rack-example/pull/1.diff","patch_url":"https://github.com/xbulat/rack-example/pull/1.patch","issue_url":"https://api.github.com/repos/xbulat/rack-example/issues/1","number":1,"state":"open","locked":false,"title":"rack app","user":{"login":"xbulat","id":9419816,"node_id":"MDQ6VXNlcjk0MTk4MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/9419816?v=4","gravatar_id":"","url":"https://api.github.com/users/xbulat","html_url":"https://github.com/xbulat","followers_url":"https://api.github.com/users/xbulat/followers","following_url":"https://api.github.com/users/xbulat/following{/other_user}","gists_url":"https://api.github.com/users/xbulat/gists{/gist_id}","starred_url":"https://api.github.com/users/xbulat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbulat/subscriptions","organizations_url":"https://api.github.com/users/xbulat/orgs","repos_url":"https://api.github.com/users/xbulat/repos","events_url":"https://api.github.com/users/xbulat/events{/privacy}","received_events_url":"https://api.github.com/users/xbulat/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-15T20:52:16Z","updated_at":"2018-12-20T05:40:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc029b323dfbd37130c9d0f645e23859954e6e4a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xbulat/rack-example/pulls/1/commits","review_comments_url":"https://api.github.com/repos/xbulat/rack-example/pulls/1/comments","review_comment_url":"https://api.github.com/repos/xbulat/rack-example/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbulat/rack-example/issues/1/comments","statuses_url":"https://api.github.com/repos/xbulat/rack-example/statuses/5eded735097828c77f6e651fcf2751f52c4257f0","head":{"label":"xbulat:rack/timestamp","ref":"rack/timestamp","sha":"5eded735097828c77f6e651fcf2751f52c4257f0","user":{"login":"xbulat","id":9419816,"node_id":"MDQ6VXNlcjk0MTk4MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/9419816?v=4","gravatar_id":"","url":"https://api.github.com/users/xbulat","html_url":"https://github.com/xbulat","followers_url":"https://api.github.com/users/xbulat/followers","following_url":"https://api.github.com/users/xbulat/following{/other_user}","gists_url":"https://api.github.com/users/xbulat/gists{/gist_id}","starred_url":"https://api.github.com/users/xbulat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbulat/subscriptions","organizations_url":"https://api.github.com/users/xbulat/orgs","repos_url":"https://api.github.com/users/xbulat/repos","events_url":"https://api.github.com/users/xbulat/events{/privacy}","received_events_url":"https://api.github.com/users/xbulat/received_events","type":"User","site_admin":false},"repo":{"id":161942555,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE5NDI1NTU=","name":"rack-example","full_name":"xbulat/rack-example","private":false,"owner":{"login":"xbulat","id":9419816,"node_id":"MDQ6VXNlcjk0MTk4MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/9419816?v=4","gravatar_id":"","url":"https://api.github.com/users/xbulat","html_url":"https://github.com/xbulat","followers_url":"https://api.github.com/users/xbulat/followers","following_url":"https://api.github.com/users/xbulat/following{/other_user}","gists_url":"https://api.github.com/users/xbulat/gists{/gist_id}","starred_url":"https://api.github.com/users/xbulat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbulat/subscriptions","organizations_url":"https://api.github.com/users/xbulat/orgs","repos_url":"https://api.github.com/users/xbulat/repos","events_url":"https://api.github.com/users/xbulat/events{/privacy}","received_events_url":"https://api.github.com/users/xbulat/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xbulat/rack-example","description":null,"fork":false,"url":"https://api.github.com/repos/xbulat/rack-example","forks_url":"https://api.github.com/repos/xbulat/rack-example/forks","keys_url":"https://api.github.com/repos/xbulat/rack-example/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbulat/rack-example/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbulat/rack-example/teams","hooks_url":"https://api.github.com/repos/xbulat/rack-example/hooks","issue_events_url":"https://api.github.com/repos/xbulat/rack-example/issues/events{/number}","events_url":"https://api.github.com/repos/xbulat/rack-example/events","assignees_url":"https://api.github.com/repos/xbulat/rack-example/assignees{/user}","branches_url":"https://api.github.com/repos/xbulat/rack-example/branches{/branch}","tags_url":"https://api.github.com/repos/xbulat/rack-example/tags","blobs_url":"https://api.github.com/repos/xbulat/rack-example/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbulat/rack-example/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbulat/rack-example/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbulat/rack-example/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbulat/rack-example/statuses/{sha}","languages_url":"https://api.github.com/repos/xbulat/rack-example/languages","stargazers_url":"https://api.github.com/repos/xbulat/rack-example/stargazers","contributors_url":"https://api.github.com/repos/xbulat/rack-example/contributors","subscribers_url":"https://api.github.com/repos/xbulat/rack-example/subscribers","subscription_url":"https://api.github.com/repos/xbulat/rack-example/subscription","commits_url":"https://api.github.com/repos/xbulat/rack-example/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbulat/rack-example/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbulat/rack-example/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbulat/rack-example/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbulat/rack-example/contents/{+path}","compare_url":"https://api.github.com/repos/xbulat/rack-example/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbulat/rack-example/merges","archive_url":"https://api.github.com/repos/xbulat/rack-example/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbulat/rack-example/downloads","issues_url":"https://api.github.com/repos/xbulat/rack-example/issues{/number}","pulls_url":"https://api.github.com/repos/xbulat/rack-example/pulls{/number}","milestones_url":"https://api.github.com/repos/xbulat/rack-example/milestones{/number}","notifications_url":"https://api.github.com/repos/xbulat/rack-example/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbulat/rack-example/labels{/name}","releases_url":"https://api.github.com/repos/xbulat/rack-example/releases{/id}","deployments_url":"https://api.github.com/repos/xbulat/rack-example/deployments","created_at":"2018-12-15T20:48:03Z","updated_at":"2018-12-15T20:50:51Z","pushed_at":"2018-12-19T17:51:21Z","git_url":"git://github.com/xbulat/rack-example.git","ssh_url":"git@github.com:xbulat/rack-example.git","clone_url":"https://github.com/xbulat/rack-example.git","svn_url":"https://github.com/xbulat/rack-example","homepage":null,"size":3,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"xbulat:master","ref":"master","sha":"a2acc3376f1c3ff87fc1ef456078c00bdc890493","user":{"login":"xbulat","id":9419816,"node_id":"MDQ6VXNlcjk0MTk4MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/9419816?v=4","gravatar_id":"","url":"https://api.github.com/users/xbulat","html_url":"https://github.com/xbulat","followers_url":"https://api.github.com/users/xbulat/followers","following_url":"https://api.github.com/users/xbulat/following{/other_user}","gists_url":"https://api.github.com/users/xbulat/gists{/gist_id}","starred_url":"https://api.github.com/users/xbulat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbulat/subscriptions","organizations_url":"https://api.github.com/users/xbulat/orgs","repos_url":"https://api.github.com/users/xbulat/repos","events_url":"https://api.github.com/users/xbulat/events{/privacy}","received_events_url":"https://api.github.com/users/xbulat/received_events","type":"User","site_admin":false},"repo":{"id":161942555,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE5NDI1NTU=","name":"rack-example","full_name":"xbulat/rack-example","private":false,"owner":{"login":"xbulat","id":9419816,"node_id":"MDQ6VXNlcjk0MTk4MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/9419816?v=4","gravatar_id":"","url":"https://api.github.com/users/xbulat","html_url":"https://github.com/xbulat","followers_url":"https://api.github.com/users/xbulat/followers","following_url":"https://api.github.com/users/xbulat/following{/other_user}","gists_url":"https://api.github.com/users/xbulat/gists{/gist_id}","starred_url":"https://api.github.com/users/xbulat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbulat/subscriptions","organizations_url":"https://api.github.com/users/xbulat/orgs","repos_url":"https://api.github.com/users/xbulat/repos","events_url":"https://api.github.com/users/xbulat/events{/privacy}","received_events_url":"https://api.github.com/users/xbulat/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xbulat/rack-example","description":null,"fork":false,"url":"https://api.github.com/repos/xbulat/rack-example","forks_url":"https://api.github.com/repos/xbulat/rack-example/forks","keys_url":"https://api.github.com/repos/xbulat/rack-example/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbulat/rack-example/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbulat/rack-example/teams","hooks_url":"https://api.github.com/repos/xbulat/rack-example/hooks","issue_events_url":"https://api.github.com/repos/xbulat/rack-example/issues/events{/number}","events_url":"https://api.github.com/repos/xbulat/rack-example/events","assignees_url":"https://api.github.com/repos/xbulat/rack-example/assignees{/user}","branches_url":"https://api.github.com/repos/xbulat/rack-example/branches{/branch}","tags_url":"https://api.github.com/repos/xbulat/rack-example/tags","blobs_url":"https://api.github.com/repos/xbulat/rack-example/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbulat/rack-example/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbulat/rack-example/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbulat/rack-example/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbulat/rack-example/statuses/{sha}","languages_url":"https://api.github.com/repos/xbulat/rack-example/languages","stargazers_url":"https://api.github.com/repos/xbulat/rack-example/stargazers","contributors_url":"https://api.github.com/repos/xbulat/rack-example/contributors","subscribers_url":"https://api.github.com/repos/xbulat/rack-example/subscribers","subscription_url":"https://api.github.com/repos/xbulat/rack-example/subscription","commits_url":"https://api.github.com/repos/xbulat/rack-example/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbulat/rack-example/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbulat/rack-example/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbulat/rack-example/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbulat/rack-example/contents/{+path}","compare_url":"https://api.github.com/repos/xbulat/rack-example/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbulat/rack-example/merges","archive_url":"https://api.github.com/repos/xbulat/rack-example/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbulat/rack-example/downloads","issues_url":"https://api.github.com/repos/xbulat/rack-example/issues{/number}","pulls_url":"https://api.github.com/repos/xbulat/rack-example/pulls{/number}","milestones_url":"https://api.github.com/repos/xbulat/rack-example/milestones{/number}","notifications_url":"https://api.github.com/repos/xbulat/rack-example/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbulat/rack-example/labels{/name}","releases_url":"https://api.github.com/repos/xbulat/rack-example/releases{/id}","deployments_url":"https://api.github.com/repos/xbulat/rack-example/deployments","created_at":"2018-12-15T20:48:03Z","updated_at":"2018-12-15T20:50:51Z","pushed_at":"2018-12-19T17:51:21Z","git_url":"git://github.com/xbulat/rack-example.git","ssh_url":"git@github.com:xbulat/rack-example.git","clone_url":"https://github.com/xbulat/rack-example.git","svn_url":"https://github.com/xbulat/rack-example","homepage":null,"size":3,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbulat/rack-example/pulls/1"},"html":{"href":"https://github.com/xbulat/rack-example/pull/1"},"issue":{"href":"https://api.github.com/repos/xbulat/rack-example/issues/1"},"comments":{"href":"https://api.github.com/repos/xbulat/rack-example/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/xbulat/rack-example/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/xbulat/rack-example/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbulat/rack-example/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/xbulat/rack-example/statuses/5eded735097828c77f6e651fcf2751f52c4257f0"}},"author_association":"OWNER"}}
{"actor":{"display_login":"iBublik"}}