{"action":"opened","number":747,"pull_request":{"url":"https://api.github.com/repos/MaslowCNC/GroundControl/pulls/747","id":204895383,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0ODk1Mzgz","html_url":"https://github.com/MaslowCNC/GroundControl/pull/747","diff_url":"https://github.com/MaslowCNC/GroundControl/pull/747.diff","patch_url":"https://github.com/MaslowCNC/GroundControl/pull/747.patch","issue_url":"https://api.github.com/repos/MaslowCNC/GroundControl/issues/747","number":747,"state":"open","locked":false,"title":"Add PID settings for the z axis (take two)","user":{"login":"BarbourSmith","id":9359447,"node_id":"MDQ6VXNlcjkzNTk0NDc=","avatar_url":"https://avatars0.githubusercontent.com/u/9359447?v=4","gravatar_id":"","url":"https://api.github.com/users/BarbourSmith","html_url":"https://github.com/BarbourSmith","followers_url":"https://api.github.com/users/BarbourSmith/followers","following_url":"https://api.github.com/users/BarbourSmith/following{/other_user}","gists_url":"https://api.github.com/users/BarbourSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/BarbourSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BarbourSmith/subscriptions","organizations_url":"https://api.github.com/users/BarbourSmith/orgs","repos_url":"https://api.github.com/users/BarbourSmith/repos","events_url":"https://api.github.com/users/BarbourSmith/events{/privacy}","received_events_url":"https://api.github.com/users/BarbourSmith/received_events","type":"User","site_admin":false},"body":"This pull request adds advanced settings options for independently setting the PID values for the z-axis. As near as I can tell it is working with the exception that settings are only pushed to the machine when the switch from using the default values to using custom values is switched, however this is the case for all the custom PID value settings not just the z-axis ones and was the case before this pull request so it seems like a separate issue.\r\n\r\nThe issue is caused by line **191** in `main.py`\r\n\r\n`elif key == 'enablePosPIDValues':`\r\n\r\nWhich only computes the new values when the switch changes position.","created_at":"2018-07-30T18:46:35Z","updated_at":"2018-07-30T18:46:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MaslowCNC/GroundControl/pulls/747/commits","review_comments_url":"https://api.github.com/repos/MaslowCNC/GroundControl/pulls/747/comments","review_comment_url":"https://api.github.com/repos/MaslowCNC/GroundControl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MaslowCNC/GroundControl/issues/747/comments","statuses_url":"https://api.github.com/repos/MaslowCNC/GroundControl/statuses/a7e2620fcfa5e8fa8c67b95db9d65ed5d7ef85aa","head":{"label":"MaslowCNC:add-PID-settings-for-the-Z-axis","ref":"add-PID-settings-for-the-Z-axis","sha":"a7e2620fcfa5e8fa8c67b95db9d65ed5d7ef85aa","user":{"login":"MaslowCNC","id":9359461,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzNTk0NjE=","avatar_url":"https://avatars3.githubusercontent.com/u/9359461?v=4","gravatar_id":"","url":"https://api.github.com/users/MaslowCNC","html_url":"https://github.com/MaslowCNC","followers_url":"https://api.github.com/users/MaslowCNC/followers","following_url":"https://api.github.com/users/MaslowCNC/following{/other_user}","gists_url":"https://api.github.com/users/MaslowCNC/gists{/gist_id}","starred_url":"https://api.github.com/users/MaslowCNC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaslowCNC/subscriptions","organizations_url":"https://api.github.com/users/MaslowCNC/orgs","repos_url":"https://api.github.com/users/MaslowCNC/repos","events_url":"https://api.github.com/users/MaslowCNC/events{/privacy}","received_events_url":"https://api.github.com/users/MaslowCNC/received_events","type":"Organization","site_admin":false},"repo":{"id":25612324,"node_id":"MDEwOlJlcG9zaXRvcnkyNTYxMjMyNA==","name":"GroundControl","full_name":"MaslowCNC/GroundControl","owner":{"login":"MaslowCNC","id":9359461,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzNTk0NjE=","avatar_url":"https://avatars3.githubusercontent.com/u/9359461?v=4","gravatar_id":"","url":"https://api.github.com/users/MaslowCNC","html_url":"https://github.com/MaslowCNC","followers_url":"https://api.github.com/users/MaslowCNC/followers","following_url":"https://api.github.com/users/MaslowCNC/following{/other_user}","gists_url":"https://api.github.com/users/MaslowCNC/gists{/gist_id}","starred_url":"https://api.github.com/users/MaslowCNC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaslowCNC/subscriptions","organizations_url":"https://api.github.com/users/MaslowCNC/orgs","repos_url":"https://api.github.com/users/MaslowCNC/repos","events_url":"https://api.github.com/users/MaslowCNC/events{/privacy}","received_events_url":"https://api.github.com/users/MaslowCNC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MaslowCNC/GroundControl","description":"This is the Ground Control software used to control the Maslow CNC Machine","fork":false,"url":"https://api.github.com/repos/MaslowCNC/GroundControl","forks_url":"https://api.github.com/repos/MaslowCNC/GroundControl/forks","keys_url":"https://api.github.com/repos/MaslowCNC/GroundControl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaslowCNC/GroundControl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaslowCNC/GroundControl/teams","hooks_url":"https://api.github.com/repos/MaslowCNC/GroundControl/hooks","issue_events_url":"https://api.github.com/repos/MaslowCNC/GroundControl/issues/events{/number}","events_url":"https://api.github.com/repos/MaslowCNC/GroundControl/events","assignees_url":"https://api.github.com/repos/MaslowCNC/GroundControl/assignees{/user}","branches_url":"https://api.github.com/repos/MaslowCNC/GroundControl/branches{/branch}","tags_url":"https://api.github.com/repos/MaslowCNC/GroundControl/tags","blobs_url":"https://api.github.com/repos/MaslowCNC/GroundControl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaslowCNC/GroundControl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaslowCNC/GroundControl/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaslowCNC/GroundControl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaslowCNC/GroundControl/statuses/{sha}","languages_url":"https://api.github.com/repos/MaslowCNC/GroundControl/languages","stargazers_url":"https://api.github.com/repos/MaslowCNC/GroundControl/stargazers","contributors_url":"https://api.github.com/repos/MaslowCNC/GroundControl/contributors","subscribers_url":"https://api.github.com/repos/MaslowCNC/GroundControl/subscribers","subscription_url":"https://api.github.com/repos/MaslowCNC/GroundControl/subscription","commits_url":"https://api.github.com/repos/MaslowCNC/GroundControl/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaslowCNC/GroundControl/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaslowCNC/GroundControl/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaslowCNC/GroundControl/issues/comments{/number}","contents_url":"https://api.github.com/repos/MaslowCNC/GroundControl/contents/{+path}","compare_url":"https://api.github.com/repos/MaslowCNC/GroundControl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaslowCNC/GroundControl/merges","archive_url":"https://api.github.com/repos/MaslowCNC/GroundControl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaslowCNC/GroundControl/downloads","issues_url":"https://api.github.com/repos/MaslowCNC/GroundControl/issues{/number}","pulls_url":"https://api.github.com/repos/MaslowCNC/GroundControl/pulls{/number}","milestones_url":"https://api.github.com/repos/MaslowCNC/GroundControl/milestones{/number}","notifications_url":"https://api.github.com/repos/MaslowCNC/GroundControl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaslowCNC/GroundControl/labels{/name}","releases_url":"https://api.github.com/repos/MaslowCNC/GroundControl/releases{/id}","deployments_url":"https://api.github.com/repos/MaslowCNC/GroundControl/deployments","created_at":"2014-10-23T01:06:29Z","updated_at":"2018-07-28T22:05:21Z","pushed_at":"2018-07-28T22:05:19Z","git_url":"git://github.com/MaslowCNC/GroundControl.git","ssh_url":"git@github.com:MaslowCNC/GroundControl.git","clone_url":"https://github.com/MaslowCNC/GroundControl.git","svn_url":"https://github.com/MaslowCNC/GroundControl","homepage":"https://www.MaslowCNC.com","size":123880,"stargazers_count":141,"watchers_count":141,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":69,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":65,"open_issues":69,"watchers":141,"default_branch":"master"}},"base":{"label":"MaslowCNC:master","ref":"master","sha":"8fc4118b7fd5d92bc7da223555702c64e33e6510","user":{"login":"MaslowCNC","id":9359461,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzNTk0NjE=","avatar_url":"https://avatars3.githubusercontent.com/u/9359461?v=4","gravatar_id":"","url":"https://api.github.com/users/MaslowCNC","html_url":"https://github.com/MaslowCNC","followers_url":"https://api.github.com/users/MaslowCNC/followers","following_url":"https://api.github.com/users/MaslowCNC/following{/other_user}","gists_url":"https://api.github.com/users/MaslowCNC/gists{/gist_id}","starred_url":"https://api.github.com/users/MaslowCNC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaslowCNC/subscriptions","organizations_url":"https://api.github.com/users/MaslowCNC/orgs","repos_url":"https://api.github.com/users/MaslowCNC/repos","events_url":"https://api.github.com/users/MaslowCNC/events{/privacy}","received_events_url":"https://api.github.com/users/MaslowCNC/received_events","type":"Organization","site_admin":false},"repo":{"id":25612324,"node_id":"MDEwOlJlcG9zaXRvcnkyNTYxMjMyNA==","name":"GroundControl","full_name":"MaslowCNC/GroundControl","owner":{"login":"MaslowCNC","id":9359461,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzNTk0NjE=","avatar_url":"https://avatars3.githubusercontent.com/u/9359461?v=4","gravatar_id":"","url":"https://api.github.com/users/MaslowCNC","html_url":"https://github.com/MaslowCNC","followers_url":"https://api.github.com/users/MaslowCNC/followers","following_url":"https://api.github.com/users/MaslowCNC/following{/other_user}","gists_url":"https://api.github.com/users/MaslowCNC/gists{/gist_id}","starred_url":"https://api.github.com/users/MaslowCNC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaslowCNC/subscriptions","organizations_url":"https://api.github.com/users/MaslowCNC/orgs","repos_url":"https://api.github.com/users/MaslowCNC/repos","events_url":"https://api.github.com/users/MaslowCNC/events{/privacy}","received_events_url":"https://api.github.com/users/MaslowCNC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MaslowCNC/GroundControl","description":"This is the Ground Control software used to control the Maslow CNC Machine","fork":false,"url":"https://api.github.com/repos/MaslowCNC/GroundControl","forks_url":"https://api.github.com/repos/MaslowCNC/GroundControl/forks","keys_url":"https://api.github.com/repos/MaslowCNC/GroundControl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaslowCNC/GroundControl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaslowCNC/GroundControl/teams","hooks_url":"https://api.github.com/repos/MaslowCNC/GroundControl/hooks","issue_events_url":"https://api.github.com/repos/MaslowCNC/GroundControl/issues/events{/number}","events_url":"https://api.github.com/repos/MaslowCNC/GroundControl/events","assignees_url":"https://api.github.com/repos/MaslowCNC/GroundControl/assignees{/user}","branches_url":"https://api.github.com/repos/MaslowCNC/GroundControl/branches{/branch}","tags_url":"https://api.github.com/repos/MaslowCNC/GroundControl/tags","blobs_url":"https://api.github.com/repos/MaslowCNC/GroundControl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaslowCNC/GroundControl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaslowCNC/GroundControl/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaslowCNC/GroundControl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaslowCNC/GroundControl/statuses/{sha}","languages_url":"https://api.github.com/repos/MaslowCNC/GroundControl/languages","stargazers_url":"https://api.github.com/repos/MaslowCNC/GroundControl/stargazers","contributors_url":"https://api.github.com/repos/MaslowCNC/GroundControl/contributors","subscribers_url":"https://api.github.com/repos/MaslowCNC/GroundControl/subscribers","subscription_url":"https://api.github.com/repos/MaslowCNC/GroundControl/subscription","commits_url":"https://api.github.com/repos/MaslowCNC/GroundControl/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaslowCNC/GroundControl/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaslowCNC/GroundControl/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaslowCNC/GroundControl/issues/comments{/number}","contents_url":"https://api.github.com/repos/MaslowCNC/GroundControl/contents/{+path}","compare_url":"https://api.github.com/repos/MaslowCNC/GroundControl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaslowCNC/GroundControl/merges","archive_url":"https://api.github.com/repos/MaslowCNC/GroundControl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaslowCNC/GroundControl/downloads","issues_url":"https://api.github.com/repos/MaslowCNC/GroundControl/issues{/number}","pulls_url":"https://api.github.com/repos/MaslowCNC/GroundControl/pulls{/number}","milestones_url":"https://api.github.com/repos/MaslowCNC/GroundControl/milestones{/number}","notifications_url":"https://api.github.com/repos/MaslowCNC/GroundControl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaslowCNC/GroundControl/labels{/name}","releases_url":"https://api.github.com/repos/MaslowCNC/GroundControl/releases{/id}","deployments_url":"https://api.github.com/repos/MaslowCNC/GroundControl/deployments","created_at":"2014-10-23T01:06:29Z","updated_at":"2018-07-28T22:05:21Z","pushed_at":"2018-07-28T22:05:19Z","git_url":"git://github.com/MaslowCNC/GroundControl.git","ssh_url":"git@github.com:MaslowCNC/GroundControl.git","clone_url":"https://github.com/MaslowCNC/GroundControl.git","svn_url":"https://github.com/MaslowCNC/GroundControl","homepage":"https://www.MaslowCNC.com","size":123880,"stargazers_count":141,"watchers_count":141,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":69,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":65,"open_issues":69,"watchers":141,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MaslowCNC/GroundControl/pulls/747"},"html":{"href":"https://github.com/MaslowCNC/GroundControl/pull/747"},"issue":{"href":"https://api.github.com/repos/MaslowCNC/GroundControl/issues/747"},"comments":{"href":"https://api.github.com/repos/MaslowCNC/GroundControl/issues/747/comments"},"review_comments":{"href":"https://api.github.com/repos/MaslowCNC/GroundControl/pulls/747/comments"},"review_comment":{"href":"https://api.github.com/repos/MaslowCNC/GroundControl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MaslowCNC/GroundControl/pulls/747/commits"},"statuses":{"href":"https://api.github.com/repos/MaslowCNC/GroundControl/statuses/a7e2620fcfa5e8fa8c67b95db9d65ed5d7ef85aa"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":56,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"BarbourSmith"}}