{"action":"created","issue":{"url":"https://api.github.com/repos/BretFisher/node-docker-good-defaults/issues/40","repository_url":"https://api.github.com/repos/BretFisher/node-docker-good-defaults","labels_url":"https://api.github.com/repos/BretFisher/node-docker-good-defaults/issues/40/labels{/name}","comments_url":"https://api.github.com/repos/BretFisher/node-docker-good-defaults/issues/40/comments","events_url":"https://api.github.com/repos/BretFisher/node-docker-good-defaults/issues/40/events","html_url":"https://github.com/BretFisher/node-docker-good-defaults/pull/40","id":379490617,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5OTMxNjU0","number":40,"title":"add docker secrets","user":{"login":"aidengaripoli","id":7554713,"node_id":"MDQ6VXNlcjc1NTQ3MTM=","avatar_url":"https://avatars2.githubusercontent.com/u/7554713?v=4","gravatar_id":"","url":"https://api.github.com/users/aidengaripoli","html_url":"https://github.com/aidengaripoli","followers_url":"https://api.github.com/users/aidengaripoli/followers","following_url":"https://api.github.com/users/aidengaripoli/following{/other_user}","gists_url":"https://api.github.com/users/aidengaripoli/gists{/gist_id}","starred_url":"https://api.github.com/users/aidengaripoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidengaripoli/subscriptions","organizations_url":"https://api.github.com/users/aidengaripoli/orgs","repos_url":"https://api.github.com/users/aidengaripoli/repos","events_url":"https://api.github.com/users/aidengaripoli/events{/privacy}","received_events_url":"https://api.github.com/users/aidengaripoli/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-11T05:04:36Z","updated_at":"2018-11-12T21:03:12Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/BretFisher/node-docker-good-defaults/pulls/40","html_url":"https://github.com/BretFisher/node-docker-good-defaults/pull/40","diff_url":"https://github.com/BretFisher/node-docker-good-defaults/pull/40.diff","patch_url":"https://github.com/BretFisher/node-docker-good-defaults/pull/40.patch"},"body":"resolves #32 by adding docker secrets for mongodb root username and password"},"comment":{"url":"https://api.github.com/repos/BretFisher/node-docker-good-defaults/issues/comments/438027691","html_url":"https://github.com/BretFisher/node-docker-good-defaults/pull/40#issuecomment-438027691","issue_url":"https://api.github.com/repos/BretFisher/node-docker-good-defaults/issues/40","id":438027691,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODAyNzY5MQ==","user":{"login":"BretFisher","id":792287,"node_id":"MDQ6VXNlcjc5MjI4Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/792287?v=4","gravatar_id":"","url":"https://api.github.com/users/BretFisher","html_url":"https://github.com/BretFisher","followers_url":"https://api.github.com/users/BretFisher/followers","following_url":"https://api.github.com/users/BretFisher/following{/other_user}","gists_url":"https://api.github.com/users/BretFisher/gists{/gist_id}","starred_url":"https://api.github.com/users/BretFisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BretFisher/subscriptions","organizations_url":"https://api.github.com/users/BretFisher/orgs","repos_url":"https://api.github.com/users/BretFisher/repos","events_url":"https://api.github.com/users/BretFisher/events{/privacy}","received_events_url":"https://api.github.com/users/BretFisher/received_events","type":"User","site_admin":false},"created_at":"2018-11-12T21:03:12Z","updated_at":"2018-11-12T21:03:12Z","author_association":"OWNER","body":"Thanks, this looks mostly good. Please add back the hostname, we don't want a hard-coded hostname of \"mongo\" in the code. For full flexibility, apps should be designed so that user, password, db, and host can all be set dynamically.\r\n\r\nFor local dev you don't want containers crashing/restarting because their dependencies aren't available. That's ideal for production, but for cleaner local dev it's nicer if things just wait. Now that we have the v2 compose feature to have depends_on using healthchecks, we can have this \"best of both worlds\" approach."}}
{"actor":{"display_login":"BretFisher"}}