{"action":"created","comment":{"url":"https://api.github.com/repos/usds/us-forms-system/pulls/comments/202452072","pull_request_review_id":137163789,"id":202452072,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjQ1MjA3Mg==","diff_hunk":"@@ -21,6 +24,16 @@ export function getActivePages(pages, data) {\n   return pages.filter(page => isActivePage(page, data));\n }\n \n+export function getActiveProperties(activePages) {\n+  let allProperties = [];","path":"src/js/helpers.js","position":15,"original_position":15,"commit_id":"2b5f1a9f9f8aab5b7c37e49d4f47767048c2f724","original_commit_id":"2c004fd40cfd8fc19f17828332de2e5e0263dae5","user":{"login":"annekainicUSDS","id":25183456,"node_id":"MDQ6VXNlcjI1MTgzNDU2","avatar_url":"https://avatars0.githubusercontent.com/u/25183456?v=4","gravatar_id":"","url":"https://api.github.com/users/annekainicUSDS","html_url":"https://github.com/annekainicUSDS","followers_url":"https://api.github.com/users/annekainicUSDS/followers","following_url":"https://api.github.com/users/annekainicUSDS/following{/other_user}","gists_url":"https://api.github.com/users/annekainicUSDS/gists{/gist_id}","starred_url":"https://api.github.com/users/annekainicUSDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annekainicUSDS/subscriptions","organizations_url":"https://api.github.com/users/annekainicUSDS/orgs","repos_url":"https://api.github.com/users/annekainicUSDS/repos","events_url":"https://api.github.com/users/annekainicUSDS/events{/privacy}","received_events_url":"https://api.github.com/users/annekainicUSDS/received_events","type":"User","site_admin":false},"body":"I like the idea of checking once up front for the presence of `schema`. Where do you think that check should happen? I might create a separate ticket for that.","created_at":"2018-07-13T19:34:08Z","updated_at":"2018-07-13T19:34:08Z","html_url":"https://github.com/usds/us-forms-system/pull/155#discussion_r202452072","pull_request_url":"https://api.github.com/repos/usds/us-forms-system/pulls/155","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/usds/us-forms-system/pulls/comments/202452072"},"html":{"href":"https://github.com/usds/us-forms-system/pull/155#discussion_r202452072"},"pull_request":{"href":"https://api.github.com/repos/usds/us-forms-system/pulls/155"}},"in_reply_to_id":202023299},"pull_request":{"url":"https://api.github.com/repos/usds/us-forms-system/pulls/155","id":200888119,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwODg4MTE5","html_url":"https://github.com/usds/us-forms-system/pull/155","diff_url":"https://github.com/usds/us-forms-system/pull/155.diff","patch_url":"https://github.com/usds/us-forms-system/pull/155.patch","issue_url":"https://api.github.com/repos/usds/us-forms-system/issues/155","number":155,"state":"open","locked":false,"title":"Do not filter out properties on inactive pages that also appear on active pages","user":{"login":"annekainicUSDS","id":25183456,"node_id":"MDQ6VXNlcjI1MTgzNDU2","avatar_url":"https://avatars0.githubusercontent.com/u/25183456?v=4","gravatar_id":"","url":"https://api.github.com/users/annekainicUSDS","html_url":"https://github.com/annekainicUSDS","followers_url":"https://api.github.com/users/annekainicUSDS/followers","following_url":"https://api.github.com/users/annekainicUSDS/following{/other_user}","gists_url":"https://api.github.com/users/annekainicUSDS/gists{/gist_id}","starred_url":"https://api.github.com/users/annekainicUSDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annekainicUSDS/subscriptions","organizations_url":"https://api.github.com/users/annekainicUSDS/orgs","repos_url":"https://api.github.com/users/annekainicUSDS/repos","events_url":"https://api.github.com/users/annekainicUSDS/events{/privacy}","received_events_url":"https://api.github.com/users/annekainicUSDS/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nResolves this ticket https://github.com/usds/us-forms-system/issues/140.\r\n\r\nThere are functions that transform the form data before it can be submitted. This is done to remove `view:` fields and inactive fields. Inactive fields were considered to be any field on a page that was inactive. This resulted in a problem where fields that appeared on both inactive and active pages were being removed from the form submission data entirely.\r\n\r\nThis PR adds logic to check if a property on an inactive page is also on an active page before determining whether it should be removed from the submission data.\r\n\r\nI tested this against vets-website to confirm the fix works. I'm also going to be adding unit tests.\r\n","created_at":"2018-07-12T04:58:14Z","updated_at":"2018-07-13T19:34:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6715dcb1f2dec4811c109da9dcad8e37febccdf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/usds/us-forms-system/pulls/155/commits","review_comments_url":"https://api.github.com/repos/usds/us-forms-system/pulls/155/comments","review_comment_url":"https://api.github.com/repos/usds/us-forms-system/pulls/comments{/number}","comments_url":"https://api.github.com/repos/usds/us-forms-system/issues/155/comments","statuses_url":"https://api.github.com/repos/usds/us-forms-system/statuses/2b5f1a9f9f8aab5b7c37e49d4f47767048c2f724","head":{"label":"usds:do-not-filter-properties-from-active-pages","ref":"do-not-filter-properties-from-active-pages","sha":"2b5f1a9f9f8aab5b7c37e49d4f47767048c2f724","user":{"login":"usds","id":8751968,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3NTE5Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/8751968?v=4","gravatar_id":"","url":"https://api.github.com/users/usds","html_url":"https://github.com/usds","followers_url":"https://api.github.com/users/usds/followers","following_url":"https://api.github.com/users/usds/following{/other_user}","gists_url":"https://api.github.com/users/usds/gists{/gist_id}","starred_url":"https://api.github.com/users/usds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usds/subscriptions","organizations_url":"https://api.github.com/users/usds/orgs","repos_url":"https://api.github.com/users/usds/repos","events_url":"https://api.github.com/users/usds/events{/privacy}","received_events_url":"https://api.github.com/users/usds/received_events","type":"Organization","site_admin":false},"repo":{"id":129421356,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk0MjEzNTY=","name":"us-forms-system","full_name":"usds/us-forms-system","owner":{"login":"usds","id":8751968,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3NTE5Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/8751968?v=4","gravatar_id":"","url":"https://api.github.com/users/usds","html_url":"https://github.com/usds","followers_url":"https://api.github.com/users/usds/followers","following_url":"https://api.github.com/users/usds/following{/other_user}","gists_url":"https://api.github.com/users/usds/gists{/gist_id}","starred_url":"https://api.github.com/users/usds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usds/subscriptions","organizations_url":"https://api.github.com/users/usds/orgs","repos_url":"https://api.github.com/users/usds/repos","events_url":"https://api.github.com/users/usds/events{/privacy}","received_events_url":"https://api.github.com/users/usds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/usds/us-forms-system","description":"Build React forms with JSON Schema and the U.S. Web Design System","fork":false,"url":"https://api.github.com/repos/usds/us-forms-system","forks_url":"https://api.github.com/repos/usds/us-forms-system/forks","keys_url":"https://api.github.com/repos/usds/us-forms-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/usds/us-forms-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/usds/us-forms-system/teams","hooks_url":"https://api.github.com/repos/usds/us-forms-system/hooks","issue_events_url":"https://api.github.com/repos/usds/us-forms-system/issues/events{/number}","events_url":"https://api.github.com/repos/usds/us-forms-system/events","assignees_url":"https://api.github.com/repos/usds/us-forms-system/assignees{/user}","branches_url":"https://api.github.com/repos/usds/us-forms-system/branches{/branch}","tags_url":"https://api.github.com/repos/usds/us-forms-system/tags","blobs_url":"https://api.github.com/repos/usds/us-forms-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/usds/us-forms-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/usds/us-forms-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/usds/us-forms-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/usds/us-forms-system/statuses/{sha}","languages_url":"https://api.github.com/repos/usds/us-forms-system/languages","stargazers_url":"https://api.github.com/repos/usds/us-forms-system/stargazers","contributors_url":"https://api.github.com/repos/usds/us-forms-system/contributors","subscribers_url":"https://api.github.com/repos/usds/us-forms-system/subscribers","subscription_url":"https://api.github.com/repos/usds/us-forms-system/subscription","commits_url":"https://api.github.com/repos/usds/us-forms-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/usds/us-forms-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/usds/us-forms-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/usds/us-forms-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/usds/us-forms-system/contents/{+path}","compare_url":"https://api.github.com/repos/usds/us-forms-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/usds/us-forms-system/merges","archive_url":"https://api.github.com/repos/usds/us-forms-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/usds/us-forms-system/downloads","issues_url":"https://api.github.com/repos/usds/us-forms-system/issues{/number}","pulls_url":"https://api.github.com/repos/usds/us-forms-system/pulls{/number}","milestones_url":"https://api.github.com/repos/usds/us-forms-system/milestones{/number}","notifications_url":"https://api.github.com/repos/usds/us-forms-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/usds/us-forms-system/labels{/name}","releases_url":"https://api.github.com/repos/usds/us-forms-system/releases{/id}","deployments_url":"https://api.github.com/repos/usds/us-forms-system/deployments","created_at":"2018-04-13T15:32:02Z","updated_at":"2018-07-13T15:24:10Z","pushed_at":"2018-07-13T19:20:05Z","git_url":"git://github.com/usds/us-forms-system.git","ssh_url":"git@github.com:usds/us-forms-system.git","clone_url":"https://github.com/usds/us-forms-system.git","svn_url":"https://github.com/usds/us-forms-system","homepage":null,"size":2918,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":51,"watchers":19,"default_branch":"master"}},"base":{"label":"usds:master","ref":"master","sha":"cced5198714b0eb57dbdc1caf0d38dd4d20108c7","user":{"login":"usds","id":8751968,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3NTE5Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/8751968?v=4","gravatar_id":"","url":"https://api.github.com/users/usds","html_url":"https://github.com/usds","followers_url":"https://api.github.com/users/usds/followers","following_url":"https://api.github.com/users/usds/following{/other_user}","gists_url":"https://api.github.com/users/usds/gists{/gist_id}","starred_url":"https://api.github.com/users/usds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usds/subscriptions","organizations_url":"https://api.github.com/users/usds/orgs","repos_url":"https://api.github.com/users/usds/repos","events_url":"https://api.github.com/users/usds/events{/privacy}","received_events_url":"https://api.github.com/users/usds/received_events","type":"Organization","site_admin":false},"repo":{"id":129421356,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk0MjEzNTY=","name":"us-forms-system","full_name":"usds/us-forms-system","owner":{"login":"usds","id":8751968,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3NTE5Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/8751968?v=4","gravatar_id":"","url":"https://api.github.com/users/usds","html_url":"https://github.com/usds","followers_url":"https://api.github.com/users/usds/followers","following_url":"https://api.github.com/users/usds/following{/other_user}","gists_url":"https://api.github.com/users/usds/gists{/gist_id}","starred_url":"https://api.github.com/users/usds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usds/subscriptions","organizations_url":"https://api.github.com/users/usds/orgs","repos_url":"https://api.github.com/users/usds/repos","events_url":"https://api.github.com/users/usds/events{/privacy}","received_events_url":"https://api.github.com/users/usds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/usds/us-forms-system","description":"Build React forms with JSON Schema and the U.S. Web Design System","fork":false,"url":"https://api.github.com/repos/usds/us-forms-system","forks_url":"https://api.github.com/repos/usds/us-forms-system/forks","keys_url":"https://api.github.com/repos/usds/us-forms-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/usds/us-forms-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/usds/us-forms-system/teams","hooks_url":"https://api.github.com/repos/usds/us-forms-system/hooks","issue_events_url":"https://api.github.com/repos/usds/us-forms-system/issues/events{/number}","events_url":"https://api.github.com/repos/usds/us-forms-system/events","assignees_url":"https://api.github.com/repos/usds/us-forms-system/assignees{/user}","branches_url":"https://api.github.com/repos/usds/us-forms-system/branches{/branch}","tags_url":"https://api.github.com/repos/usds/us-forms-system/tags","blobs_url":"https://api.github.com/repos/usds/us-forms-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/usds/us-forms-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/usds/us-forms-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/usds/us-forms-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/usds/us-forms-system/statuses/{sha}","languages_url":"https://api.github.com/repos/usds/us-forms-system/languages","stargazers_url":"https://api.github.com/repos/usds/us-forms-system/stargazers","contributors_url":"https://api.github.com/repos/usds/us-forms-system/contributors","subscribers_url":"https://api.github.com/repos/usds/us-forms-system/subscribers","subscription_url":"https://api.github.com/repos/usds/us-forms-system/subscription","commits_url":"https://api.github.com/repos/usds/us-forms-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/usds/us-forms-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/usds/us-forms-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/usds/us-forms-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/usds/us-forms-system/contents/{+path}","compare_url":"https://api.github.com/repos/usds/us-forms-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/usds/us-forms-system/merges","archive_url":"https://api.github.com/repos/usds/us-forms-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/usds/us-forms-system/downloads","issues_url":"https://api.github.com/repos/usds/us-forms-system/issues{/number}","pulls_url":"https://api.github.com/repos/usds/us-forms-system/pulls{/number}","milestones_url":"https://api.github.com/repos/usds/us-forms-system/milestones{/number}","notifications_url":"https://api.github.com/repos/usds/us-forms-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/usds/us-forms-system/labels{/name}","releases_url":"https://api.github.com/repos/usds/us-forms-system/releases{/id}","deployments_url":"https://api.github.com/repos/usds/us-forms-system/deployments","created_at":"2018-04-13T15:32:02Z","updated_at":"2018-07-13T15:24:10Z","pushed_at":"2018-07-13T19:20:05Z","git_url":"git://github.com/usds/us-forms-system.git","ssh_url":"git@github.com:usds/us-forms-system.git","clone_url":"https://github.com/usds/us-forms-system.git","svn_url":"https://github.com/usds/us-forms-system","homepage":null,"size":2918,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":51,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/usds/us-forms-system/pulls/155"},"html":{"href":"https://github.com/usds/us-forms-system/pull/155"},"issue":{"href":"https://api.github.com/repos/usds/us-forms-system/issues/155"},"comments":{"href":"https://api.github.com/repos/usds/us-forms-system/issues/155/comments"},"review_comments":{"href":"https://api.github.com/repos/usds/us-forms-system/pulls/155/comments"},"review_comment":{"href":"https://api.github.com/repos/usds/us-forms-system/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/usds/us-forms-system/pulls/155/commits"},"statuses":{"href":"https://api.github.com/repos/usds/us-forms-system/statuses/2b5f1a9f9f8aab5b7c37e49d4f47767048c2f724"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"annekainicUSDS"}}