{"action":"closed","number":201,"pull_request":{"url":"https://api.github.com/repos/guardicore/monkey/pulls/201","id":228365884,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MzY1ODg0","html_url":"https://github.com/guardicore/monkey/pull/201","diff_url":"https://github.com/guardicore/monkey/pull/201.diff","patch_url":"https://github.com/guardicore/monkey/pull/201.patch","issue_url":"https://api.github.com/repos/guardicore/monkey/issues/201","number":201,"state":"closed","locked":false,"title":"Fix/bugfix for 1.6","user":{"login":"MaorCore","id":39161867,"node_id":"MDQ6VXNlcjM5MTYxODY3","avatar_url":"https://avatars1.githubusercontent.com/u/39161867?v=4","gravatar_id":"","url":"https://api.github.com/users/MaorCore","html_url":"https://github.com/MaorCore","followers_url":"https://api.github.com/users/MaorCore/followers","following_url":"https://api.github.com/users/MaorCore/following{/other_user}","gists_url":"https://api.github.com/users/MaorCore/gists{/gist_id}","starred_url":"https://api.github.com/users/MaorCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaorCore/subscriptions","organizations_url":"https://api.github.com/users/MaorCore/orgs","repos_url":"https://api.github.com/users/MaorCore/repos","events_url":"https://api.github.com/users/MaorCore/events{/privacy}","received_events_url":"https://api.github.com/users/MaorCore/received_events","type":"User","site_admin":false},"body":"# Fixes\r\n\r\nWhile testing the develop code for version 1.6, two bugs came up:\r\n* Log file wasn't being written on disc\r\n* When trying to submit an outdated configuration file in the monkey island the server would return error 500 and the page would crash.\r\n\r\n##  Changes\r\n  - Updated the path to the logging json configuration file to be generic relative using os.path\r\n  - Added a small and specific error handling for the specific configuration submission endpoint for now.\r\n","created_at":"2018-11-05T14:13:57Z","updated_at":"2018-11-06T09:37:38Z","closed_at":"2018-11-06T09:37:38Z","merged_at":"2018-11-06T09:37:38Z","merge_commit_sha":"15f56dce97eb488543ac77a16f2ee862564afd5d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"danielguardicore","id":15857396,"node_id":"MDQ6VXNlcjE1ODU3Mzk2","avatar_url":"https://avatars2.githubusercontent.com/u/15857396?v=4","gravatar_id":"","url":"https://api.github.com/users/danielguardicore","html_url":"https://github.com/danielguardicore","followers_url":"https://api.github.com/users/danielguardicore/followers","following_url":"https://api.github.com/users/danielguardicore/following{/other_user}","gists_url":"https://api.github.com/users/danielguardicore/gists{/gist_id}","starred_url":"https://api.github.com/users/danielguardicore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielguardicore/subscriptions","organizations_url":"https://api.github.com/users/danielguardicore/orgs","repos_url":"https://api.github.com/users/danielguardicore/repos","events_url":"https://api.github.com/users/danielguardicore/events{/privacy}","received_events_url":"https://api.github.com/users/danielguardicore/received_events","type":"User","site_admin":false},{"login":"itaymmguardicore","id":30774653,"node_id":"MDQ6VXNlcjMwNzc0NjUz","avatar_url":"https://avatars3.githubusercontent.com/u/30774653?v=4","gravatar_id":"","url":"https://api.github.com/users/itaymmguardicore","html_url":"https://github.com/itaymmguardicore","followers_url":"https://api.github.com/users/itaymmguardicore/followers","following_url":"https://api.github.com/users/itaymmguardicore/following{/other_user}","gists_url":"https://api.github.com/users/itaymmguardicore/gists{/gist_id}","starred_url":"https://api.github.com/users/itaymmguardicore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itaymmguardicore/subscriptions","organizations_url":"https://api.github.com/users/itaymmguardicore/orgs","repos_url":"https://api.github.com/users/itaymmguardicore/repos","events_url":"https://api.github.com/users/itaymmguardicore/events{/privacy}","received_events_url":"https://api.github.com/users/itaymmguardicore/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/guardicore/monkey/pulls/201/commits","review_comments_url":"https://api.github.com/repos/guardicore/monkey/pulls/201/comments","review_comment_url":"https://api.github.com/repos/guardicore/monkey/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardicore/monkey/issues/201/comments","statuses_url":"https://api.github.com/repos/guardicore/monkey/statuses/53ed6004b56263dec6583ee942cb29095cbbe3e9","head":{"label":"guardicore:fix/bugfix_for_1.6","ref":"fix/bugfix_for_1.6","sha":"53ed6004b56263dec6583ee942cb29095cbbe3e9","user":{"login":"guardicore","id":5675395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NzUzOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/5675395?v=4","gravatar_id":"","url":"https://api.github.com/users/guardicore","html_url":"https://github.com/guardicore","followers_url":"https://api.github.com/users/guardicore/followers","following_url":"https://api.github.com/users/guardicore/following{/other_user}","gists_url":"https://api.github.com/users/guardicore/gists{/gist_id}","starred_url":"https://api.github.com/users/guardicore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardicore/subscriptions","organizations_url":"https://api.github.com/users/guardicore/orgs","repos_url":"https://api.github.com/users/guardicore/repos","events_url":"https://api.github.com/users/guardicore/events{/privacy}","received_events_url":"https://api.github.com/users/guardicore/received_events","type":"Organization","site_admin":false},"repo":{"id":41620215,"node_id":"MDEwOlJlcG9zaXRvcnk0MTYyMDIxNQ==","name":"monkey","full_name":"guardicore/monkey","private":false,"owner":{"login":"guardicore","id":5675395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NzUzOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/5675395?v=4","gravatar_id":"","url":"https://api.github.com/users/guardicore","html_url":"https://github.com/guardicore","followers_url":"https://api.github.com/users/guardicore/followers","following_url":"https://api.github.com/users/guardicore/following{/other_user}","gists_url":"https://api.github.com/users/guardicore/gists{/gist_id}","starred_url":"https://api.github.com/users/guardicore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardicore/subscriptions","organizations_url":"https://api.github.com/users/guardicore/orgs","repos_url":"https://api.github.com/users/guardicore/repos","events_url":"https://api.github.com/users/guardicore/events{/privacy}","received_events_url":"https://api.github.com/users/guardicore/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/guardicore/monkey","description":"Infection Monkey - An automated pentest tool","fork":false,"url":"https://api.github.com/repos/guardicore/monkey","forks_url":"https://api.github.com/repos/guardicore/monkey/forks","keys_url":"https://api.github.com/repos/guardicore/monkey/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardicore/monkey/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardicore/monkey/teams","hooks_url":"https://api.github.com/repos/guardicore/monkey/hooks","issue_events_url":"https://api.github.com/repos/guardicore/monkey/issues/events{/number}","events_url":"https://api.github.com/repos/guardicore/monkey/events","assignees_url":"https://api.github.com/repos/guardicore/monkey/assignees{/user}","branches_url":"https://api.github.com/repos/guardicore/monkey/branches{/branch}","tags_url":"https://api.github.com/repos/guardicore/monkey/tags","blobs_url":"https://api.github.com/repos/guardicore/monkey/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardicore/monkey/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardicore/monkey/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardicore/monkey/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardicore/monkey/statuses/{sha}","languages_url":"https://api.github.com/repos/guardicore/monkey/languages","stargazers_url":"https://api.github.com/repos/guardicore/monkey/stargazers","contributors_url":"https://api.github.com/repos/guardicore/monkey/contributors","subscribers_url":"https://api.github.com/repos/guardicore/monkey/subscribers","subscription_url":"https://api.github.com/repos/guardicore/monkey/subscription","commits_url":"https://api.github.com/repos/guardicore/monkey/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardicore/monkey/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardicore/monkey/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardicore/monkey/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardicore/monkey/contents/{+path}","compare_url":"https://api.github.com/repos/guardicore/monkey/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardicore/monkey/merges","archive_url":"https://api.github.com/repos/guardicore/monkey/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardicore/monkey/downloads","issues_url":"https://api.github.com/repos/guardicore/monkey/issues{/number}","pulls_url":"https://api.github.com/repos/guardicore/monkey/pulls{/number}","milestones_url":"https://api.github.com/repos/guardicore/monkey/milestones{/number}","notifications_url":"https://api.github.com/repos/guardicore/monkey/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardicore/monkey/labels{/name}","releases_url":"https://api.github.com/repos/guardicore/monkey/releases{/id}","deployments_url":"https://api.github.com/repos/guardicore/monkey/deployments","created_at":"2015-08-30T07:22:51Z","updated_at":"2018-11-06T07:20:10Z","pushed_at":"2018-11-06T09:37:38Z","git_url":"git://github.com/guardicore/monkey.git","ssh_url":"git@github.com:guardicore/monkey.git","clone_url":"https://github.com/guardicore/monkey.git","svn_url":"https://github.com/guardicore/monkey","homepage":"https://www.guardicore.com/infectionmonkey/","size":4730,"stargazers_count":2441,"watchers_count":2441,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":250,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":250,"open_issues":13,"watchers":2441,"default_branch":"develop"}},"base":{"label":"guardicore:develop","ref":"develop","sha":"84c2a5fa51601a16f714236e48df9e2878a009cd","user":{"login":"guardicore","id":5675395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NzUzOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/5675395?v=4","gravatar_id":"","url":"https://api.github.com/users/guardicore","html_url":"https://github.com/guardicore","followers_url":"https://api.github.com/users/guardicore/followers","following_url":"https://api.github.com/users/guardicore/following{/other_user}","gists_url":"https://api.github.com/users/guardicore/gists{/gist_id}","starred_url":"https://api.github.com/users/guardicore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardicore/subscriptions","organizations_url":"https://api.github.com/users/guardicore/orgs","repos_url":"https://api.github.com/users/guardicore/repos","events_url":"https://api.github.com/users/guardicore/events{/privacy}","received_events_url":"https://api.github.com/users/guardicore/received_events","type":"Organization","site_admin":false},"repo":{"id":41620215,"node_id":"MDEwOlJlcG9zaXRvcnk0MTYyMDIxNQ==","name":"monkey","full_name":"guardicore/monkey","private":false,"owner":{"login":"guardicore","id":5675395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NzUzOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/5675395?v=4","gravatar_id":"","url":"https://api.github.com/users/guardicore","html_url":"https://github.com/guardicore","followers_url":"https://api.github.com/users/guardicore/followers","following_url":"https://api.github.com/users/guardicore/following{/other_user}","gists_url":"https://api.github.com/users/guardicore/gists{/gist_id}","starred_url":"https://api.github.com/users/guardicore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardicore/subscriptions","organizations_url":"https://api.github.com/users/guardicore/orgs","repos_url":"https://api.github.com/users/guardicore/repos","events_url":"https://api.github.com/users/guardicore/events{/privacy}","received_events_url":"https://api.github.com/users/guardicore/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/guardicore/monkey","description":"Infection Monkey - An automated pentest tool","fork":false,"url":"https://api.github.com/repos/guardicore/monkey","forks_url":"https://api.github.com/repos/guardicore/monkey/forks","keys_url":"https://api.github.com/repos/guardicore/monkey/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardicore/monkey/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardicore/monkey/teams","hooks_url":"https://api.github.com/repos/guardicore/monkey/hooks","issue_events_url":"https://api.github.com/repos/guardicore/monkey/issues/events{/number}","events_url":"https://api.github.com/repos/guardicore/monkey/events","assignees_url":"https://api.github.com/repos/guardicore/monkey/assignees{/user}","branches_url":"https://api.github.com/repos/guardicore/monkey/branches{/branch}","tags_url":"https://api.github.com/repos/guardicore/monkey/tags","blobs_url":"https://api.github.com/repos/guardicore/monkey/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardicore/monkey/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardicore/monkey/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardicore/monkey/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardicore/monkey/statuses/{sha}","languages_url":"https://api.github.com/repos/guardicore/monkey/languages","stargazers_url":"https://api.github.com/repos/guardicore/monkey/stargazers","contributors_url":"https://api.github.com/repos/guardicore/monkey/contributors","subscribers_url":"https://api.github.com/repos/guardicore/monkey/subscribers","subscription_url":"https://api.github.com/repos/guardicore/monkey/subscription","commits_url":"https://api.github.com/repos/guardicore/monkey/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardicore/monkey/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardicore/monkey/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardicore/monkey/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardicore/monkey/contents/{+path}","compare_url":"https://api.github.com/repos/guardicore/monkey/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardicore/monkey/merges","archive_url":"https://api.github.com/repos/guardicore/monkey/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardicore/monkey/downloads","issues_url":"https://api.github.com/repos/guardicore/monkey/issues{/number}","pulls_url":"https://api.github.com/repos/guardicore/monkey/pulls{/number}","milestones_url":"https://api.github.com/repos/guardicore/monkey/milestones{/number}","notifications_url":"https://api.github.com/repos/guardicore/monkey/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardicore/monkey/labels{/name}","releases_url":"https://api.github.com/repos/guardicore/monkey/releases{/id}","deployments_url":"https://api.github.com/repos/guardicore/monkey/deployments","created_at":"2015-08-30T07:22:51Z","updated_at":"2018-11-06T07:20:10Z","pushed_at":"2018-11-06T09:37:38Z","git_url":"git://github.com/guardicore/monkey.git","ssh_url":"git@github.com:guardicore/monkey.git","clone_url":"https://github.com/guardicore/monkey.git","svn_url":"https://github.com/guardicore/monkey","homepage":"https://www.guardicore.com/infectionmonkey/","size":4730,"stargazers_count":2441,"watchers_count":2441,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":250,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":250,"open_issues":13,"watchers":2441,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/guardicore/monkey/pulls/201"},"html":{"href":"https://github.com/guardicore/monkey/pull/201"},"issue":{"href":"https://api.github.com/repos/guardicore/monkey/issues/201"},"comments":{"href":"https://api.github.com/repos/guardicore/monkey/issues/201/comments"},"review_comments":{"href":"https://api.github.com/repos/guardicore/monkey/pulls/201/comments"},"review_comment":{"href":"https://api.github.com/repos/guardicore/monkey/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardicore/monkey/pulls/201/commits"},"statuses":{"href":"https://api.github.com/repos/guardicore/monkey/statuses/53ed6004b56263dec6583ee942cb29095cbbe3e9"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"danielguardicore","id":15857396,"node_id":"MDQ6VXNlcjE1ODU3Mzk2","avatar_url":"https://avatars2.githubusercontent.com/u/15857396?v=4","gravatar_id":"","url":"https://api.github.com/users/danielguardicore","html_url":"https://github.com/danielguardicore","followers_url":"https://api.github.com/users/danielguardicore/followers","following_url":"https://api.github.com/users/danielguardicore/following{/other_user}","gists_url":"https://api.github.com/users/danielguardicore/gists{/gist_id}","starred_url":"https://api.github.com/users/danielguardicore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielguardicore/subscriptions","organizations_url":"https://api.github.com/users/danielguardicore/orgs","repos_url":"https://api.github.com/users/danielguardicore/repos","events_url":"https://api.github.com/users/danielguardicore/events{/privacy}","received_events_url":"https://api.github.com/users/danielguardicore/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":28,"deletions":4,"changed_files":4}}
{"actor":{"display_login":"danielguardicore"}}