{"action":"closed","number":5827,"pull_request":{"url":"https://api.github.com/repos/cilium/cilium/pulls/5827","id":221144706,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMTQ0NzA2","html_url":"https://github.com/cilium/cilium/pull/5827","diff_url":"https://github.com/cilium/cilium/pull/5827.diff","patch_url":"https://github.com/cilium/cilium/pull/5827.patch","issue_url":"https://api.github.com/repos/cilium/cilium/issues/5827","number":5827,"state":"closed","locked":false,"title":"protect bpf.PerfEvent.Read from infinite loop","user":{"login":"nebril","id":1417888,"node_id":"MDQ6VXNlcjE0MTc4ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/1417888?v=4","gravatar_id":"","url":"https://api.github.com/users/nebril","html_url":"https://github.com/nebril","followers_url":"https://api.github.com/users/nebril/followers","following_url":"https://api.github.com/users/nebril/following{/other_user}","gists_url":"https://api.github.com/users/nebril/gists{/gist_id}","starred_url":"https://api.github.com/users/nebril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nebril/subscriptions","organizations_url":"https://api.github.com/users/nebril/orgs","repos_url":"https://api.github.com/users/nebril/repos","events_url":"https://api.github.com/users/nebril/events{/privacy}","received_events_url":"https://api.github.com/users/nebril/received_events","type":"User","site_admin":false},"body":"Infinite loop in `Read` can be caused by `state->begin` pointer in\r\nperf_event_read getting ahead of `state->end` pointer.\r\n\r\nCondition is changed to make sure that this situation is handled not by\r\nreading further data from perf buffer.\r\n\r\nFixes: #5826\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cilium/cilium/5827)\r\n<!-- Reviewable:end -->\r\n","created_at":"2018-10-08T14:47:47Z","updated_at":"2018-10-10T21:17:44Z","closed_at":"2018-10-10T21:17:44Z","merged_at":null,"merge_commit_sha":"3dc643e82caca570bf02eaa82b490115bb5dcad3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"monitor","id":2519793,"node_id":"MDQ6VGVhbTI1MTk3OTM=","slug":"monitor","description":"Monitoring layer","privacy":"closed","url":"https://api.github.com/teams/2519793","members_url":"https://api.github.com/teams/2519793/members{/member}","repositories_url":"https://api.github.com/teams/2519793/repos","permission":"pull"}],"labels":[{"id":300384439,"node_id":"MDU6TGFiZWwzMDAzODQ0Mzk=","url":"https://api.github.com/repos/cilium/cilium/labels/kind/bug","name":"kind/bug","color":"fc2929","default":false},{"id":930690043,"node_id":"MDU6TGFiZWw5MzA2OTAwNDM=","url":"https://api.github.com/repos/cilium/cilium/labels/needs-backport/1.0","name":"needs-backport/1.0","color":"59f7df","default":false},{"id":893193455,"node_id":"MDU6TGFiZWw4OTMxOTM0NTU=","url":"https://api.github.com/repos/cilium/cilium/labels/needs-backport/1.1","name":"needs-backport/1.1","color":"5319e7","default":false},{"id":1007718548,"node_id":"MDU6TGFiZWwxMDA3NzE4NTQ4","url":"https://api.github.com/repos/cilium/cilium/labels/needs-backport/1.2","name":"needs-backport/1.2","color":"4f3daa","default":false},{"id":403149902,"node_id":"MDU6TGFiZWw0MDMxNDk5MDI=","url":"https://api.github.com/repos/cilium/cilium/labels/pending-review","name":"pending-review","color":"fbca04","default":false},{"id":562648678,"node_id":"MDU6TGFiZWw1NjI2NDg2Nzg=","url":"https://api.github.com/repos/cilium/cilium/labels/priority/release-blocker","name":"priority/release-blocker","color":"b60205","default":false},{"id":732924468,"node_id":"MDU6TGFiZWw3MzI5MjQ0Njg=","url":"https://api.github.com/repos/cilium/cilium/labels/release-note/bug","name":"release-note/bug","color":"c2e0c6","default":false}],"milestone":{"url":"https://api.github.com/repos/cilium/cilium/milestones/18","html_url":"https://github.com/cilium/cilium/milestone/18","labels_url":"https://api.github.com/repos/cilium/cilium/milestones/18/labels","id":3568158,"node_id":"MDk6TWlsZXN0b25lMzU2ODE1OA==","number":18,"title":"1.3-bugfix-exception","description":"","creator":{"login":"tgraf","id":1417913,"node_id":"MDQ6VXNlcjE0MTc5MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1417913?v=4","gravatar_id":"","url":"https://api.github.com/users/tgraf","html_url":"https://github.com/tgraf","followers_url":"https://api.github.com/users/tgraf/followers","following_url":"https://api.github.com/users/tgraf/following{/other_user}","gists_url":"https://api.github.com/users/tgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/tgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgraf/subscriptions","organizations_url":"https://api.github.com/users/tgraf/orgs","repos_url":"https://api.github.com/users/tgraf/repos","events_url":"https://api.github.com/users/tgraf/events{/privacy}","received_events_url":"https://api.github.com/users/tgraf/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":74,"state":"open","created_at":"2018-08-14T09:53:10Z","updated_at":"2018-10-10T21:17:44Z","due_on":"2018-10-09T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cilium/cilium/pulls/5827/commits","review_comments_url":"https://api.github.com/repos/cilium/cilium/pulls/5827/comments","review_comment_url":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/5827/comments","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/f3d37cbb6cb8b93e8ae4c08854ed3d404e1703c2","head":{"label":"nebril:monitor-infinite-loop-fix","ref":"monitor-infinite-loop-fix","sha":"f3d37cbb6cb8b93e8ae4c08854ed3d404e1703c2","user":{"login":"nebril","id":1417888,"node_id":"MDQ6VXNlcjE0MTc4ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/1417888?v=4","gravatar_id":"","url":"https://api.github.com/users/nebril","html_url":"https://github.com/nebril","followers_url":"https://api.github.com/users/nebril/followers","following_url":"https://api.github.com/users/nebril/following{/other_user}","gists_url":"https://api.github.com/users/nebril/gists{/gist_id}","starred_url":"https://api.github.com/users/nebril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nebril/subscriptions","organizations_url":"https://api.github.com/users/nebril/orgs","repos_url":"https://api.github.com/users/nebril/repos","events_url":"https://api.github.com/users/nebril/events{/privacy}","received_events_url":"https://api.github.com/users/nebril/received_events","type":"User","site_admin":false},"repo":{"id":103055444,"node_id":"MDEwOlJlcG9zaXRvcnkxMDMwNTU0NDQ=","name":"cilium","full_name":"nebril/cilium","private":false,"owner":{"login":"nebril","id":1417888,"node_id":"MDQ6VXNlcjE0MTc4ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/1417888?v=4","gravatar_id":"","url":"https://api.github.com/users/nebril","html_url":"https://github.com/nebril","followers_url":"https://api.github.com/users/nebril/followers","following_url":"https://api.github.com/users/nebril/following{/other_user}","gists_url":"https://api.github.com/users/nebril/gists{/gist_id}","starred_url":"https://api.github.com/users/nebril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nebril/subscriptions","organizations_url":"https://api.github.com/users/nebril/orgs","repos_url":"https://api.github.com/users/nebril/repos","events_url":"https://api.github.com/users/nebril/events{/privacy}","received_events_url":"https://api.github.com/users/nebril/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nebril/cilium","description":"Linux Native, HTTP Aware Networking and Security for Containers","fork":true,"url":"https://api.github.com/repos/nebril/cilium","forks_url":"https://api.github.com/repos/nebril/cilium/forks","keys_url":"https://api.github.com/repos/nebril/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nebril/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nebril/cilium/teams","hooks_url":"https://api.github.com/repos/nebril/cilium/hooks","issue_events_url":"https://api.github.com/repos/nebril/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/nebril/cilium/events","assignees_url":"https://api.github.com/repos/nebril/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/nebril/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/nebril/cilium/tags","blobs_url":"https://api.github.com/repos/nebril/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nebril/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nebril/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/nebril/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nebril/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/nebril/cilium/languages","stargazers_url":"https://api.github.com/repos/nebril/cilium/stargazers","contributors_url":"https://api.github.com/repos/nebril/cilium/contributors","subscribers_url":"https://api.github.com/repos/nebril/cilium/subscribers","subscription_url":"https://api.github.com/repos/nebril/cilium/subscription","commits_url":"https://api.github.com/repos/nebril/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/nebril/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/nebril/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/nebril/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/nebril/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/nebril/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nebril/cilium/merges","archive_url":"https://api.github.com/repos/nebril/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nebril/cilium/downloads","issues_url":"https://api.github.com/repos/nebril/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/nebril/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/nebril/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/nebril/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nebril/cilium/labels{/name}","releases_url":"https://api.github.com/repos/nebril/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/nebril/cilium/deployments","created_at":"2017-09-10T19:21:23Z","updated_at":"2017-09-10T19:21:26Z","pushed_at":"2018-10-10T17:00:12Z","git_url":"git://github.com/nebril/cilium.git","ssh_url":"git@github.com:nebril/cilium.git","clone_url":"https://github.com/nebril/cilium.git","svn_url":"https://github.com/nebril/cilium","homepage":"","size":59639,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cilium:master","ref":"master","sha":"cac7d0b4618b7b5ef80c76f17a1bbc44d25b7f71","user":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"node_id":"MDEwOlJlcG9zaXRvcnk0ODEwOTIzOQ==","name":"cilium","full_name":"cilium/cilium","private":false,"owner":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cilium/cilium","description":"HTTP, gRPC, and Kafka Aware Security and Networking for Containers with BPF and XDP","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2018-10-10T19:51:58Z","pushed_at":"2018-10-10T21:15:49Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":64805,"stargazers_count":2896,"watchers_count":2896,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":259,"mirror_url":null,"archived":false,"open_issues_count":512,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":259,"open_issues":512,"watchers":2896,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/5827"},"html":{"href":"https://github.com/cilium/cilium/pull/5827"},"issue":{"href":"https://api.github.com/repos/cilium/cilium/issues/5827"},"comments":{"href":"https://api.github.com/repos/cilium/cilium/issues/5827/comments"},"review_comments":{"href":"https://api.github.com/repos/cilium/cilium/pulls/5827/comments"},"review_comment":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cilium/cilium/pulls/5827/commits"},"statuses":{"href":"https://api.github.com/repos/cilium/cilium/statuses/f3d37cbb6cb8b93e8ae4c08854ed3d404e1703c2"}},"author_association":"MEMBER","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":10,"review_comments":14,"maintainer_can_modify":false,"commits":1,"additions":108,"deletions":5,"changed_files":4}}
{"actor":{"display_login":"tgraf"}}