{"action":"created","comment":{"url":"https://api.github.com/repos/apache/beam/pulls/comments/232049983","pull_request_review_id":173158112,"id":232049983,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjA0OTk4Mw==","diff_hunk":"@@ -1141,12 +1141,10 @@ artifactId=${project.name}\n \n         include \"**/*IT.class\"\n \n-        def pipelineOptionString = configuration.integrationTestPipelineOptions\n-        if(configuration.runner?.equalsIgnoreCase('dataflow')) {\n+        def pipelineOptionsString = configuration.integrationTestPipelineOptions\n+        if(pipelineOptionsString && configuration.runner?.equalsIgnoreCase('dataflow')) {","path":"buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy","position":15,"original_position":7,"commit_id":"303a8f3ca0cfc90b68910e2ca4cfaa925ea787b9","original_commit_id":"303a8f3ca0cfc90b68910e2ca4cfaa925ea787b9","user":{"login":"HuangLED","id":25540563,"node_id":"MDQ6VXNlcjI1NTQwNTYz","avatar_url":"https://avatars3.githubusercontent.com/u/25540563?v=4","gravatar_id":"","url":"https://api.github.com/users/HuangLED","html_url":"https://github.com/HuangLED","followers_url":"https://api.github.com/users/HuangLED/followers","following_url":"https://api.github.com/users/HuangLED/following{/other_user}","gists_url":"https://api.github.com/users/HuangLED/gists{/gist_id}","starred_url":"https://api.github.com/users/HuangLED/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuangLED/subscriptions","organizations_url":"https://api.github.com/users/HuangLED/orgs","repos_url":"https://api.github.com/users/HuangLED/repos","events_url":"https://api.github.com/users/HuangLED/events{/privacy}","received_events_url":"https://api.github.com/users/HuangLED/received_events","type":"User","site_admin":false},"body":"I see. Good question and fair concern.    \r\n\r\nLet me think about it and try to run a few other tasks.  IMHO, what we should do depends on if it ONLY happens for 'clean' task.","created_at":"2018-11-08T20:29:46Z","updated_at":"2018-11-08T20:29:46Z","html_url":"https://github.com/apache/beam/pull/6966#discussion_r232049983","pull_request_url":"https://api.github.com/repos/apache/beam/pulls/6966","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/comments/232049983"},"html":{"href":"https://github.com/apache/beam/pull/6966#discussion_r232049983"},"pull_request":{"href":"https://api.github.com/repos/apache/beam/pulls/6966"}},"in_reply_to_id":231709315},"pull_request":{"url":"https://api.github.com/repos/apache/beam/pulls/6966","id":228821938,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4ODIxOTM4","html_url":"https://github.com/apache/beam/pull/6966","diff_url":"https://github.com/apache/beam/pull/6966.diff","patch_url":"https://github.com/apache/beam/pull/6966.patch","issue_url":"https://api.github.com/repos/apache/beam/issues/6966","number":6966,"state":"closed","locked":false,"title":"[BEAM-5931] Add worker jar to integrationTest targets.","user":{"login":"HuangLED","id":25540563,"node_id":"MDQ6VXNlcjI1NTQwNTYz","avatar_url":"https://avatars3.githubusercontent.com/u/25540563?v=4","gravatar_id":"","url":"https://api.github.com/users/HuangLED","html_url":"https://github.com/HuangLED","followers_url":"https://api.github.com/users/HuangLED/followers","following_url":"https://api.github.com/users/HuangLED/following{/other_user}","gists_url":"https://api.github.com/users/HuangLED/gists{/gist_id}","starred_url":"https://api.github.com/users/HuangLED/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuangLED/subscriptions","organizations_url":"https://api.github.com/users/HuangLED/orgs","repos_url":"https://api.github.com/users/HuangLED/repos","events_url":"https://api.github.com/users/HuangLED/events{/privacy}","received_events_url":"https://api.github.com/users/HuangLED/received_events","type":"User","site_admin":false},"body":"This PR fixes PerformanceTest_TextIO. \r\n\r\n------------------------\r\n\r\nFollow this checklist to help us incorporate your contribution quickly and easily:\r\n\r\n - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.\r\n - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).\r\n\r\nIt will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it.\r\n\r\nPost-Commit Tests Status (on master branch)\r\n------------------------------------------------------------------------------------------------\r\n\r\nLang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark\r\n--- | --- | --- | --- | --- | --- | --- | ---\r\nGo | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | ---\r\nJava | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)\r\nPython | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | --- | ---\r\n\r\n\r\n\r\n\r\n","created_at":"2018-11-06T20:18:22Z","updated_at":"2018-11-08T20:29:46Z","closed_at":"2018-11-08T20:17:57Z","merged_at":"2018-11-08T20:17:57Z","merge_commit_sha":"851fb06041f3012de6d6899f35ef567f4de80cfa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/beam/pulls/6966/commits","review_comments_url":"https://api.github.com/repos/apache/beam/pulls/6966/comments","review_comment_url":"https://api.github.com/repos/apache/beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/beam/issues/6966/comments","statuses_url":"https://api.github.com/repos/apache/beam/statuses/303a8f3ca0cfc90b68910e2ca4cfaa925ea787b9","head":{"label":"HuangLED:perfTest","ref":"perfTest","sha":"303a8f3ca0cfc90b68910e2ca4cfaa925ea787b9","user":{"login":"HuangLED","id":25540563,"node_id":"MDQ6VXNlcjI1NTQwNTYz","avatar_url":"https://avatars3.githubusercontent.com/u/25540563?v=4","gravatar_id":"","url":"https://api.github.com/users/HuangLED","html_url":"https://github.com/HuangLED","followers_url":"https://api.github.com/users/HuangLED/followers","following_url":"https://api.github.com/users/HuangLED/following{/other_user}","gists_url":"https://api.github.com/users/HuangLED/gists{/gist_id}","starred_url":"https://api.github.com/users/HuangLED/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuangLED/subscriptions","organizations_url":"https://api.github.com/users/HuangLED/orgs","repos_url":"https://api.github.com/users/HuangLED/repos","events_url":"https://api.github.com/users/HuangLED/events{/privacy}","received_events_url":"https://api.github.com/users/HuangLED/received_events","type":"User","site_admin":false},"repo":{"id":149369216,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkzNjkyMTY=","name":"beam","full_name":"HuangLED/beam","private":false,"owner":{"login":"HuangLED","id":25540563,"node_id":"MDQ6VXNlcjI1NTQwNTYz","avatar_url":"https://avatars3.githubusercontent.com/u/25540563?v=4","gravatar_id":"","url":"https://api.github.com/users/HuangLED","html_url":"https://github.com/HuangLED","followers_url":"https://api.github.com/users/HuangLED/followers","following_url":"https://api.github.com/users/HuangLED/following{/other_user}","gists_url":"https://api.github.com/users/HuangLED/gists{/gist_id}","starred_url":"https://api.github.com/users/HuangLED/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuangLED/subscriptions","organizations_url":"https://api.github.com/users/HuangLED/orgs","repos_url":"https://api.github.com/users/HuangLED/repos","events_url":"https://api.github.com/users/HuangLED/events{/privacy}","received_events_url":"https://api.github.com/users/HuangLED/received_events","type":"User","site_admin":false},"html_url":"https://github.com/HuangLED/beam","description":"Apache Beam","fork":true,"url":"https://api.github.com/repos/HuangLED/beam","forks_url":"https://api.github.com/repos/HuangLED/beam/forks","keys_url":"https://api.github.com/repos/HuangLED/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HuangLED/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HuangLED/beam/teams","hooks_url":"https://api.github.com/repos/HuangLED/beam/hooks","issue_events_url":"https://api.github.com/repos/HuangLED/beam/issues/events{/number}","events_url":"https://api.github.com/repos/HuangLED/beam/events","assignees_url":"https://api.github.com/repos/HuangLED/beam/assignees{/user}","branches_url":"https://api.github.com/repos/HuangLED/beam/branches{/branch}","tags_url":"https://api.github.com/repos/HuangLED/beam/tags","blobs_url":"https://api.github.com/repos/HuangLED/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HuangLED/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HuangLED/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/HuangLED/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HuangLED/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/HuangLED/beam/languages","stargazers_url":"https://api.github.com/repos/HuangLED/beam/stargazers","contributors_url":"https://api.github.com/repos/HuangLED/beam/contributors","subscribers_url":"https://api.github.com/repos/HuangLED/beam/subscribers","subscription_url":"https://api.github.com/repos/HuangLED/beam/subscription","commits_url":"https://api.github.com/repos/HuangLED/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/HuangLED/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/HuangLED/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/HuangLED/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/HuangLED/beam/contents/{+path}","compare_url":"https://api.github.com/repos/HuangLED/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HuangLED/beam/merges","archive_url":"https://api.github.com/repos/HuangLED/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HuangLED/beam/downloads","issues_url":"https://api.github.com/repos/HuangLED/beam/issues{/number}","pulls_url":"https://api.github.com/repos/HuangLED/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/HuangLED/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/HuangLED/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HuangLED/beam/labels{/name}","releases_url":"https://api.github.com/repos/HuangLED/beam/releases{/id}","deployments_url":"https://api.github.com/repos/HuangLED/beam/deployments","created_at":"2018-09-19T00:35:07Z","updated_at":"2018-10-25T18:28:16Z","pushed_at":"2018-11-07T18:44:20Z","git_url":"git://github.com/HuangLED/beam.git","ssh_url":"git@github.com:HuangLED/beam.git","clone_url":"https://github.com/HuangLED/beam.git","svn_url":"https://github.com/HuangLED/beam","homepage":"https://beam.apache.org","size":110095,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"df432d34444c8ef109767ea26ca255f1473fcfd1","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"node_id":"MDEwOlJlcG9zaXRvcnk1MDkwNDI0NQ==","name":"beam","full_name":"apache/beam","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/beam","description":"Apache Beam","fork":false,"url":"https://api.github.com/repos/apache/beam","forks_url":"https://api.github.com/repos/apache/beam/forks","keys_url":"https://api.github.com/repos/apache/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/beam/teams","hooks_url":"https://api.github.com/repos/apache/beam/hooks","issue_events_url":"https://api.github.com/repos/apache/beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/beam/events","assignees_url":"https://api.github.com/repos/apache/beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/beam/tags","blobs_url":"https://api.github.com/repos/apache/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/beam/languages","stargazers_url":"https://api.github.com/repos/apache/beam/stargazers","contributors_url":"https://api.github.com/repos/apache/beam/contributors","subscribers_url":"https://api.github.com/repos/apache/beam/subscribers","subscription_url":"https://api.github.com/repos/apache/beam/subscription","commits_url":"https://api.github.com/repos/apache/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/beam/merges","archive_url":"https://api.github.com/repos/apache/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/beam/downloads","issues_url":"https://api.github.com/repos/apache/beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2018-11-08T20:28:14Z","pushed_at":"2018-11-08T20:27:58Z","git_url":"git://github.com/apache/beam.git","ssh_url":"git@github.com:apache/beam.git","clone_url":"https://github.com/apache/beam.git","svn_url":"https://github.com/apache/beam","homepage":"https://beam.apache.org","size":111403,"stargazers_count":2302,"watchers_count":2302,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1435,"mirror_url":null,"archived":false,"open_issues_count":86,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1435,"open_issues":86,"watchers":2302,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/6966"},"html":{"href":"https://github.com/apache/beam/pull/6966"},"issue":{"href":"https://api.github.com/repos/apache/beam/issues/6966"},"comments":{"href":"https://api.github.com/repos/apache/beam/issues/6966/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/beam/pulls/6966/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/beam/pulls/6966/commits"},"statuses":{"href":"https://api.github.com/repos/apache/beam/statuses/303a8f3ca0cfc90b68910e2ca4cfaa925ea787b9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"HuangLED"}}