{"action":"created","comment":{"url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/comments/234684854","pull_request_review_id":176379224,"id":234684854,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDY4NDg1NA==","diff_hunk":"@@ -61,6 +63,9 @@ func (s *GuestSecurityGroupsAdapter) Adapt(cfg Config) error {\n \ts.IngressSecurityGroupName = key.SecurityGroupName(cfg.CustomObject, key.KindIngress)\n \ts.IngressSecurityGroupRules = s.getIngressRules(cfg.CustomObject)\n \n+\ts.EtcdELBSecurityGroupName = key.SecurityGroupName(cfg.CustomObject, key.KindEtcdELB)","path":"service/controller/v19/adapter/guest_security_groups.go","position":13,"original_position":13,"commit_id":"eb85546f39c690242e3cf972bd4d6b464085bf22","original_commit_id":"eb85546f39c690242e3cf972bd4d6b464085bf22","user":{"login":"teemow","id":32488,"node_id":"MDQ6VXNlcjMyNDg4","avatar_url":"https://avatars1.githubusercontent.com/u/32488?v=4","gravatar_id":"","url":"https://api.github.com/users/teemow","html_url":"https://github.com/teemow","followers_url":"https://api.github.com/users/teemow/followers","following_url":"https://api.github.com/users/teemow/following{/other_user}","gists_url":"https://api.github.com/users/teemow/gists{/gist_id}","starred_url":"https://api.github.com/users/teemow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teemow/subscriptions","organizations_url":"https://api.github.com/users/teemow/orgs","repos_url":"https://api.github.com/users/teemow/repos","events_url":"https://api.github.com/users/teemow/events{/privacy}","received_events_url":"https://api.github.com/users/teemow/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n\ts.EtcdELBSecurityGroupName = key.SecurityGroupName(cfg.CustomObject, key.KindEtcd)\r\n```","created_at":"2018-11-19T16:20:35Z","updated_at":"2018-11-19T16:20:36Z","html_url":"https://github.com/giantswarm/aws-operator/pull/1284#discussion_r234684854","pull_request_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/1284","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/comments/234684854"},"html":{"href":"https://github.com/giantswarm/aws-operator/pull/1284#discussion_r234684854"},"pull_request":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/1284"}}},"pull_request":{"url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/1284","id":231268106,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMjY4MTA2","html_url":"https://github.com/giantswarm/aws-operator/pull/1284","diff_url":"https://github.com/giantswarm/aws-operator/pull/1284.diff","patch_url":"https://github.com/giantswarm/aws-operator/pull/1284.patch","issue_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/1284","number":1284,"state":"open","locked":false,"title":"change etcd dns to loadbalancer again","user":{"login":"teemow","id":32488,"node_id":"MDQ6VXNlcjMyNDg4","avatar_url":"https://avatars1.githubusercontent.com/u/32488?v=4","gravatar_id":"","url":"https://api.github.com/users/teemow","html_url":"https://github.com/teemow","followers_url":"https://api.github.com/users/teemow/followers","following_url":"https://api.github.com/users/teemow/following{/other_user}","gists_url":"https://api.github.com/users/teemow/gists{/gist_id}","starred_url":"https://api.github.com/users/teemow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teemow/subscriptions","organizations_url":"https://api.github.com/users/teemow/orgs","repos_url":"https://api.github.com/users/teemow/repos","events_url":"https://api.github.com/users/teemow/events{/privacy}","received_events_url":"https://api.github.com/users/teemow/received_events","type":"User","site_admin":false},"body":"* add etcd port to api loadbalancer\n* change the etcd dns record to the api loadbalancer","created_at":"2018-11-15T17:02:48Z","updated_at":"2018-11-19T16:20:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f69cd40d5acb0af403fea81556d59480d502d8bd","assignee":{"login":"teemow","id":32488,"node_id":"MDQ6VXNlcjMyNDg4","avatar_url":"https://avatars1.githubusercontent.com/u/32488?v=4","gravatar_id":"","url":"https://api.github.com/users/teemow","html_url":"https://github.com/teemow","followers_url":"https://api.github.com/users/teemow/followers","following_url":"https://api.github.com/users/teemow/following{/other_user}","gists_url":"https://api.github.com/users/teemow/gists{/gist_id}","starred_url":"https://api.github.com/users/teemow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teemow/subscriptions","organizations_url":"https://api.github.com/users/teemow/orgs","repos_url":"https://api.github.com/users/teemow/repos","events_url":"https://api.github.com/users/teemow/events{/privacy}","received_events_url":"https://api.github.com/users/teemow/received_events","type":"User","site_admin":false},"assignees":[{"login":"teemow","id":32488,"node_id":"MDQ6VXNlcjMyNDg4","avatar_url":"https://avatars1.githubusercontent.com/u/32488?v=4","gravatar_id":"","url":"https://api.github.com/users/teemow","html_url":"https://github.com/teemow","followers_url":"https://api.github.com/users/teemow/followers","following_url":"https://api.github.com/users/teemow/following{/other_user}","gists_url":"https://api.github.com/users/teemow/gists{/gist_id}","starred_url":"https://api.github.com/users/teemow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teemow/subscriptions","organizations_url":"https://api.github.com/users/teemow/orgs","repos_url":"https://api.github.com/users/teemow/repos","events_url":"https://api.github.com/users/teemow/events{/privacy}","received_events_url":"https://api.github.com/users/teemow/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[{"name":"team-spirit","id":2690120,"node_id":"MDQ6VGVhbTI2OTAxMjA=","slug":"team-spirit","description":"","privacy":"closed","url":"https://api.github.com/teams/2690120","members_url":"https://api.github.com/teams/2690120/members{/member}","repositories_url":"https://api.github.com/teams/2690120/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/1284/commits","review_comments_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/1284/comments","review_comment_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/1284/comments","statuses_url":"https://api.github.com/repos/giantswarm/aws-operator/statuses/eb85546f39c690242e3cf972bd4d6b464085bf22","head":{"label":"giantswarm:teemow-switch-etcd-back-to-elb","ref":"teemow-switch-etcd-back-to-elb","sha":"eb85546f39c690242e3cf972bd4d6b464085bf22","user":{"login":"giantswarm","id":7556340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTYzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":80619275,"node_id":"MDEwOlJlcG9zaXRvcnk4MDYxOTI3NQ==","name":"aws-operator","full_name":"giantswarm/aws-operator","private":false,"owner":{"login":"giantswarm","id":7556340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTYzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/giantswarm/aws-operator","description":"The aws-operator manages Kubernetes clusters running on AWS","fork":false,"url":"https://api.github.com/repos/giantswarm/aws-operator","forks_url":"https://api.github.com/repos/giantswarm/aws-operator/forks","keys_url":"https://api.github.com/repos/giantswarm/aws-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/aws-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/aws-operator/teams","hooks_url":"https://api.github.com/repos/giantswarm/aws-operator/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/aws-operator/events","assignees_url":"https://api.github.com/repos/giantswarm/aws-operator/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/aws-operator/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/aws-operator/tags","blobs_url":"https://api.github.com/repos/giantswarm/aws-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/aws-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/aws-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/aws-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/aws-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/aws-operator/languages","stargazers_url":"https://api.github.com/repos/giantswarm/aws-operator/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/aws-operator/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/aws-operator/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/aws-operator/subscription","commits_url":"https://api.github.com/repos/giantswarm/aws-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/aws-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/aws-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/aws-operator/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/aws-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/aws-operator/merges","archive_url":"https://api.github.com/repos/giantswarm/aws-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/aws-operator/downloads","issues_url":"https://api.github.com/repos/giantswarm/aws-operator/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/aws-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/aws-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/aws-operator/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/aws-operator/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/aws-operator/deployments","created_at":"2017-02-01T12:47:41Z","updated_at":"2018-11-19T14:50:50Z","pushed_at":"2018-11-19T16:16:12Z","git_url":"git://github.com/giantswarm/aws-operator.git","ssh_url":"git@github.com:giantswarm/aws-operator.git","clone_url":"https://github.com/giantswarm/aws-operator.git","svn_url":"https://github.com/giantswarm/aws-operator","homepage":"https://giantswarm.io/","size":84700,"stargazers_count":59,"watchers_count":59,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14,"open_issues":14,"watchers":59,"default_branch":"master"}},"base":{"label":"giantswarm:master","ref":"master","sha":"09a89684e4c3c8e7265453f7065ecf09953a99a4","user":{"login":"giantswarm","id":7556340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTYzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":80619275,"node_id":"MDEwOlJlcG9zaXRvcnk4MDYxOTI3NQ==","name":"aws-operator","full_name":"giantswarm/aws-operator","private":false,"owner":{"login":"giantswarm","id":7556340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTYzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/giantswarm/aws-operator","description":"The aws-operator manages Kubernetes clusters running on AWS","fork":false,"url":"https://api.github.com/repos/giantswarm/aws-operator","forks_url":"https://api.github.com/repos/giantswarm/aws-operator/forks","keys_url":"https://api.github.com/repos/giantswarm/aws-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/aws-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/aws-operator/teams","hooks_url":"https://api.github.com/repos/giantswarm/aws-operator/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/aws-operator/events","assignees_url":"https://api.github.com/repos/giantswarm/aws-operator/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/aws-operator/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/aws-operator/tags","blobs_url":"https://api.github.com/repos/giantswarm/aws-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/aws-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/aws-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/aws-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/aws-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/aws-operator/languages","stargazers_url":"https://api.github.com/repos/giantswarm/aws-operator/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/aws-operator/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/aws-operator/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/aws-operator/subscription","commits_url":"https://api.github.com/repos/giantswarm/aws-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/aws-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/aws-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/aws-operator/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/aws-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/aws-operator/merges","archive_url":"https://api.github.com/repos/giantswarm/aws-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/aws-operator/downloads","issues_url":"https://api.github.com/repos/giantswarm/aws-operator/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/aws-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/aws-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/aws-operator/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/aws-operator/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/aws-operator/deployments","created_at":"2017-02-01T12:47:41Z","updated_at":"2018-11-19T14:50:50Z","pushed_at":"2018-11-19T16:16:12Z","git_url":"git://github.com/giantswarm/aws-operator.git","ssh_url":"git@github.com:giantswarm/aws-operator.git","clone_url":"https://github.com/giantswarm/aws-operator.git","svn_url":"https://github.com/giantswarm/aws-operator","homepage":"https://giantswarm.io/","size":84700,"stargazers_count":59,"watchers_count":59,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14,"open_issues":14,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/1284"},"html":{"href":"https://github.com/giantswarm/aws-operator/pull/1284"},"issue":{"href":"https://api.github.com/repos/giantswarm/aws-operator/issues/1284"},"comments":{"href":"https://api.github.com/repos/giantswarm/aws-operator/issues/1284/comments"},"review_comments":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/1284/comments"},"review_comment":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/1284/commits"},"statuses":{"href":"https://api.github.com/repos/giantswarm/aws-operator/statuses/eb85546f39c690242e3cf972bd4d6b464085bf22"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"teemow"}}