{"action":"created","comment":{"url":"https://api.github.com/repos/spyder-ide/spyder/pulls/comments/206188901","pull_request_review_id":141580612,"id":206188901,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjE4ODkwMQ==","diff_hunk":"@@ -152,6 +161,7 @@ def python_executable_changed(self, pyexec):\n                       \"make sure to select a valid one.\"), QMessageBox.Ok)\r\n             self.pyexec_edit.setText(def_pyexec)\r\n             return\r\n+        return True\r","path":"spyder/plugins/maininterpreter.py","position":59,"original_position":59,"commit_id":"211e641117cb1a5a1436a273e40c33fa38d8cf17","original_commit_id":"211e641117cb1a5a1436a273e40c33fa38d8cf17","user":{"login":"ccordoba12","id":365293,"node_id":"MDQ6VXNlcjM2NTI5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/365293?v=4","gravatar_id":"","url":"https://api.github.com/users/ccordoba12","html_url":"https://github.com/ccordoba12","followers_url":"https://api.github.com/users/ccordoba12/followers","following_url":"https://api.github.com/users/ccordoba12/following{/other_user}","gists_url":"https://api.github.com/users/ccordoba12/gists{/gist_id}","starred_url":"https://api.github.com/users/ccordoba12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccordoba12/subscriptions","organizations_url":"https://api.github.com/users/ccordoba12/orgs","repos_url":"https://api.github.com/users/ccordoba12/repos","events_url":"https://api.github.com/users/ccordoba12/events{/privacy}","received_events_url":"https://api.github.com/users/ccordoba12/received_events","type":"User","site_admin":false},"body":"If you make this method to `return True` at the end, then you need to change the behavior of the previous `return`'s to be `return False`, and not simply `return` (as it right now). That's to be consistent.","created_at":"2018-07-30T15:14:22Z","updated_at":"2018-07-30T15:14:22Z","html_url":"https://github.com/spyder-ide/spyder/pull/7566#discussion_r206188901","pull_request_url":"https://api.github.com/repos/spyder-ide/spyder/pulls/7566","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/spyder-ide/spyder/pulls/comments/206188901"},"html":{"href":"https://github.com/spyder-ide/spyder/pull/7566#discussion_r206188901"},"pull_request":{"href":"https://api.github.com/repos/spyder-ide/spyder/pulls/7566"}}},"pull_request":{"url":"https://api.github.com/repos/spyder-ide/spyder/pulls/7566","id":204339006,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MzM5MDA2","html_url":"https://github.com/spyder-ide/spyder/pull/7566","diff_url":"https://github.com/spyder-ide/spyder/pull/7566.diff","patch_url":"https://github.com/spyder-ide/spyder/pull/7566.patch","issue_url":"https://api.github.com/repos/spyder-ide/spyder/issues/7566","number":7566,"state":"open","locked":false,"title":"PR: Improve selection of custom interpreter.","user":{"login":"dalthviz","id":16781833,"node_id":"MDQ6VXNlcjE2NzgxODMz","avatar_url":"https://avatars2.githubusercontent.com/u/16781833?v=4","gravatar_id":"","url":"https://api.github.com/users/dalthviz","html_url":"https://github.com/dalthviz","followers_url":"https://api.github.com/users/dalthviz/followers","following_url":"https://api.github.com/users/dalthviz/following{/other_user}","gists_url":"https://api.github.com/users/dalthviz/gists{/gist_id}","starred_url":"https://api.github.com/users/dalthviz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalthviz/subscriptions","organizations_url":"https://api.github.com/users/dalthviz/orgs","repos_url":"https://api.github.com/users/dalthviz/repos","events_url":"https://api.github.com/users/dalthviz/events{/privacy}","received_events_url":"https://api.github.com/users/dalthviz/received_events","type":"User","site_admin":false},"body":"<!--- Before submitting your pull request --->\r\n<!--- please complete as much as possible of the following checklist: --->\r\n\r\n### Pull Request Checklist\r\n\r\n* [x] Read and followed this repo's [Contributing Guidelines](https://github.com/spyder-ide/spyder/blob/master/CONTRIBUTING.md)\r\n* [x] Based your PR on the latest version of the correct branch (master or 3.x)\r\n* [x] Followed [PEP8](https://www.python.org/dev/peps/pep-0008/) for code style\r\n* [x] Ensured your pull request hasn't eliminated unrelated blank lines/spaces,\r\n      modified the ``spyder/defaults`` directory, or added new icons/assets\r\n* [x] Wrote at least one-line docstrings for any new functions\r\n* [ ] Added at least one unit test covering the changes, if at all possible\r\n* [x] Described your changes and the motivation for them below\r\n* [x] Noted what issue(s) this pull request resolves, creating one if needed\r\n* [x] Included a screenshot, if this PR makes any visible changes to the UI\r\n\r\n\r\n## Description of Changes\r\n\r\n<!--- Describe what you've changed and why. --->\r\n\r\nImprove custom interpreter selection.\r\n\r\n![imagen](https://user-images.githubusercontent.com/16781833/43304642-84df8c40-913a-11e8-8b88-97fb9fc6dcb6.png)\r\n\r\n\r\n### Issue(s) Resolved\r\n\r\n<!--- Pull requests should typically resolve one, preferably only one --->\r\n<!--- outstanding issue; create a new one if no relevant issue exists. --->\r\n<!--- List the issue(s) below, in the form \"Fixes #1234\" . One per line.--->\r\n\r\nFixes #7529 \r\n\r\n\r\n<!--- Thanks for your help making Spyder better for everyone! --->\r\n","created_at":"2018-07-27T06:16:56Z","updated_at":"2018-07-30T15:14:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a70a1bf05e973cddcfb2fd2dcf120ab91fe9cbf","assignee":{"login":"dalthviz","id":16781833,"node_id":"MDQ6VXNlcjE2NzgxODMz","avatar_url":"https://avatars2.githubusercontent.com/u/16781833?v=4","gravatar_id":"","url":"https://api.github.com/users/dalthviz","html_url":"https://github.com/dalthviz","followers_url":"https://api.github.com/users/dalthviz/followers","following_url":"https://api.github.com/users/dalthviz/following{/other_user}","gists_url":"https://api.github.com/users/dalthviz/gists{/gist_id}","starred_url":"https://api.github.com/users/dalthviz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalthviz/subscriptions","organizations_url":"https://api.github.com/users/dalthviz/orgs","repos_url":"https://api.github.com/users/dalthviz/repos","events_url":"https://api.github.com/users/dalthviz/events{/privacy}","received_events_url":"https://api.github.com/users/dalthviz/received_events","type":"User","site_admin":false},"assignees":[{"login":"dalthviz","id":16781833,"node_id":"MDQ6VXNlcjE2NzgxODMz","avatar_url":"https://avatars2.githubusercontent.com/u/16781833?v=4","gravatar_id":"","url":"https://api.github.com/users/dalthviz","html_url":"https://github.com/dalthviz","followers_url":"https://api.github.com/users/dalthviz/followers","following_url":"https://api.github.com/users/dalthviz/following{/other_user}","gists_url":"https://api.github.com/users/dalthviz/gists{/gist_id}","starred_url":"https://api.github.com/users/dalthviz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalthviz/subscriptions","organizations_url":"https://api.github.com/users/dalthviz/orgs","repos_url":"https://api.github.com/users/dalthviz/repos","events_url":"https://api.github.com/users/dalthviz/events{/privacy}","received_events_url":"https://api.github.com/users/dalthviz/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":177791403,"node_id":"MDU6TGFiZWwxNzc3OTE0MDM=","url":"https://api.github.com/repos/spyder-ide/spyder/labels/component:Preferences","name":"component:Preferences","color":"d4c5f9","default":false},{"id":177778991,"node_id":"MDU6TGFiZWwxNzc3Nzg5OTE=","url":"https://api.github.com/repos/spyder-ide/spyder/labels/type:Enhancement","name":"type:Enhancement","color":"e99695","default":false}],"milestone":{"url":"https://api.github.com/repos/spyder-ide/spyder/milestones/58","html_url":"https://github.com/spyder-ide/spyder/milestone/58","labels_url":"https://api.github.com/repos/spyder-ide/spyder/milestones/58/labels","id":3358889,"node_id":"MDk6TWlsZXN0b25lMzM1ODg4OQ==","number":58,"title":"v3.3.1","description":null,"creator":{"login":"ccordoba12","id":365293,"node_id":"MDQ6VXNlcjM2NTI5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/365293?v=4","gravatar_id":"","url":"https://api.github.com/users/ccordoba12","html_url":"https://github.com/ccordoba12","followers_url":"https://api.github.com/users/ccordoba12/followers","following_url":"https://api.github.com/users/ccordoba12/following{/other_user}","gists_url":"https://api.github.com/users/ccordoba12/gists{/gist_id}","starred_url":"https://api.github.com/users/ccordoba12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccordoba12/subscriptions","organizations_url":"https://api.github.com/users/ccordoba12/orgs","repos_url":"https://api.github.com/users/ccordoba12/repos","events_url":"https://api.github.com/users/ccordoba12/events{/privacy}","received_events_url":"https://api.github.com/users/ccordoba12/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":32,"state":"open","created_at":"2018-05-19T18:43:39Z","updated_at":"2018-07-30T07:27:08Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/spyder-ide/spyder/pulls/7566/commits","review_comments_url":"https://api.github.com/repos/spyder-ide/spyder/pulls/7566/comments","review_comment_url":"https://api.github.com/repos/spyder-ide/spyder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spyder-ide/spyder/issues/7566/comments","statuses_url":"https://api.github.com/repos/spyder-ide/spyder/statuses/211e641117cb1a5a1436a273e40c33fa38d8cf17","head":{"label":"dalthviz:fixes_issue_7529","ref":"fixes_issue_7529","sha":"211e641117cb1a5a1436a273e40c33fa38d8cf17","user":{"login":"dalthviz","id":16781833,"node_id":"MDQ6VXNlcjE2NzgxODMz","avatar_url":"https://avatars2.githubusercontent.com/u/16781833?v=4","gravatar_id":"","url":"https://api.github.com/users/dalthviz","html_url":"https://github.com/dalthviz","followers_url":"https://api.github.com/users/dalthviz/followers","following_url":"https://api.github.com/users/dalthviz/following{/other_user}","gists_url":"https://api.github.com/users/dalthviz/gists{/gist_id}","starred_url":"https://api.github.com/users/dalthviz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalthviz/subscriptions","organizations_url":"https://api.github.com/users/dalthviz/orgs","repos_url":"https://api.github.com/users/dalthviz/repos","events_url":"https://api.github.com/users/dalthviz/events{/privacy}","received_events_url":"https://api.github.com/users/dalthviz/received_events","type":"User","site_admin":false},"repo":{"id":71612781,"node_id":"MDEwOlJlcG9zaXRvcnk3MTYxMjc4MQ==","name":"spyder","full_name":"dalthviz/spyder","owner":{"login":"dalthviz","id":16781833,"node_id":"MDQ6VXNlcjE2NzgxODMz","avatar_url":"https://avatars2.githubusercontent.com/u/16781833?v=4","gravatar_id":"","url":"https://api.github.com/users/dalthviz","html_url":"https://github.com/dalthviz","followers_url":"https://api.github.com/users/dalthviz/followers","following_url":"https://api.github.com/users/dalthviz/following{/other_user}","gists_url":"https://api.github.com/users/dalthviz/gists{/gist_id}","starred_url":"https://api.github.com/users/dalthviz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalthviz/subscriptions","organizations_url":"https://api.github.com/users/dalthviz/orgs","repos_url":"https://api.github.com/users/dalthviz/repos","events_url":"https://api.github.com/users/dalthviz/events{/privacy}","received_events_url":"https://api.github.com/users/dalthviz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dalthviz/spyder","description":"Official repository for Spyder - The Scientific PYthon Development EnviRonment","fork":true,"url":"https://api.github.com/repos/dalthviz/spyder","forks_url":"https://api.github.com/repos/dalthviz/spyder/forks","keys_url":"https://api.github.com/repos/dalthviz/spyder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dalthviz/spyder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dalthviz/spyder/teams","hooks_url":"https://api.github.com/repos/dalthviz/spyder/hooks","issue_events_url":"https://api.github.com/repos/dalthviz/spyder/issues/events{/number}","events_url":"https://api.github.com/repos/dalthviz/spyder/events","assignees_url":"https://api.github.com/repos/dalthviz/spyder/assignees{/user}","branches_url":"https://api.github.com/repos/dalthviz/spyder/branches{/branch}","tags_url":"https://api.github.com/repos/dalthviz/spyder/tags","blobs_url":"https://api.github.com/repos/dalthviz/spyder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dalthviz/spyder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dalthviz/spyder/git/refs{/sha}","trees_url":"https://api.github.com/repos/dalthviz/spyder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dalthviz/spyder/statuses/{sha}","languages_url":"https://api.github.com/repos/dalthviz/spyder/languages","stargazers_url":"https://api.github.com/repos/dalthviz/spyder/stargazers","contributors_url":"https://api.github.com/repos/dalthviz/spyder/contributors","subscribers_url":"https://api.github.com/repos/dalthviz/spyder/subscribers","subscription_url":"https://api.github.com/repos/dalthviz/spyder/subscription","commits_url":"https://api.github.com/repos/dalthviz/spyder/commits{/sha}","git_commits_url":"https://api.github.com/repos/dalthviz/spyder/git/commits{/sha}","comments_url":"https://api.github.com/repos/dalthviz/spyder/comments{/number}","issue_comment_url":"https://api.github.com/repos/dalthviz/spyder/issues/comments{/number}","contents_url":"https://api.github.com/repos/dalthviz/spyder/contents/{+path}","compare_url":"https://api.github.com/repos/dalthviz/spyder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dalthviz/spyder/merges","archive_url":"https://api.github.com/repos/dalthviz/spyder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dalthviz/spyder/downloads","issues_url":"https://api.github.com/repos/dalthviz/spyder/issues{/number}","pulls_url":"https://api.github.com/repos/dalthviz/spyder/pulls{/number}","milestones_url":"https://api.github.com/repos/dalthviz/spyder/milestones{/number}","notifications_url":"https://api.github.com/repos/dalthviz/spyder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dalthviz/spyder/labels{/name}","releases_url":"https://api.github.com/repos/dalthviz/spyder/releases{/id}","deployments_url":"https://api.github.com/repos/dalthviz/spyder/deployments","created_at":"2016-10-22T02:53:14Z","updated_at":"2018-07-19T18:00:13Z","pushed_at":"2018-07-28T22:18:15Z","git_url":"git://github.com/dalthviz/spyder.git","ssh_url":"git@github.com:dalthviz/spyder.git","clone_url":"https://github.com/dalthviz/spyder.git","svn_url":"https://github.com/dalthviz/spyder","homepage":"","size":42599,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spyder-ide:3.x","ref":"3.x","sha":"aed5a5a190e92e8e653d92218582715039aa6f23","user":{"login":"spyder-ide","id":1284937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODQ5Mzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1284937?v=4","gravatar_id":"","url":"https://api.github.com/users/spyder-ide","html_url":"https://github.com/spyder-ide","followers_url":"https://api.github.com/users/spyder-ide/followers","following_url":"https://api.github.com/users/spyder-ide/following{/other_user}","gists_url":"https://api.github.com/users/spyder-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/spyder-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spyder-ide/subscriptions","organizations_url":"https://api.github.com/users/spyder-ide/orgs","repos_url":"https://api.github.com/users/spyder-ide/repos","events_url":"https://api.github.com/users/spyder-ide/events{/privacy}","received_events_url":"https://api.github.com/users/spyder-ide/received_events","type":"Organization","site_admin":false},"repo":{"id":30892477,"node_id":"MDEwOlJlcG9zaXRvcnkzMDg5MjQ3Nw==","name":"spyder","full_name":"spyder-ide/spyder","owner":{"login":"spyder-ide","id":1284937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODQ5Mzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1284937?v=4","gravatar_id":"","url":"https://api.github.com/users/spyder-ide","html_url":"https://github.com/spyder-ide","followers_url":"https://api.github.com/users/spyder-ide/followers","following_url":"https://api.github.com/users/spyder-ide/following{/other_user}","gists_url":"https://api.github.com/users/spyder-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/spyder-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spyder-ide/subscriptions","organizations_url":"https://api.github.com/users/spyder-ide/orgs","repos_url":"https://api.github.com/users/spyder-ide/repos","events_url":"https://api.github.com/users/spyder-ide/events{/privacy}","received_events_url":"https://api.github.com/users/spyder-ide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spyder-ide/spyder","description":"Official repository for Spyder - The Scientific Python Development Environment","fork":false,"url":"https://api.github.com/repos/spyder-ide/spyder","forks_url":"https://api.github.com/repos/spyder-ide/spyder/forks","keys_url":"https://api.github.com/repos/spyder-ide/spyder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spyder-ide/spyder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spyder-ide/spyder/teams","hooks_url":"https://api.github.com/repos/spyder-ide/spyder/hooks","issue_events_url":"https://api.github.com/repos/spyder-ide/spyder/issues/events{/number}","events_url":"https://api.github.com/repos/spyder-ide/spyder/events","assignees_url":"https://api.github.com/repos/spyder-ide/spyder/assignees{/user}","branches_url":"https://api.github.com/repos/spyder-ide/spyder/branches{/branch}","tags_url":"https://api.github.com/repos/spyder-ide/spyder/tags","blobs_url":"https://api.github.com/repos/spyder-ide/spyder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spyder-ide/spyder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spyder-ide/spyder/git/refs{/sha}","trees_url":"https://api.github.com/repos/spyder-ide/spyder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spyder-ide/spyder/statuses/{sha}","languages_url":"https://api.github.com/repos/spyder-ide/spyder/languages","stargazers_url":"https://api.github.com/repos/spyder-ide/spyder/stargazers","contributors_url":"https://api.github.com/repos/spyder-ide/spyder/contributors","subscribers_url":"https://api.github.com/repos/spyder-ide/spyder/subscribers","subscription_url":"https://api.github.com/repos/spyder-ide/spyder/subscription","commits_url":"https://api.github.com/repos/spyder-ide/spyder/commits{/sha}","git_commits_url":"https://api.github.com/repos/spyder-ide/spyder/git/commits{/sha}","comments_url":"https://api.github.com/repos/spyder-ide/spyder/comments{/number}","issue_comment_url":"https://api.github.com/repos/spyder-ide/spyder/issues/comments{/number}","contents_url":"https://api.github.com/repos/spyder-ide/spyder/contents/{+path}","compare_url":"https://api.github.com/repos/spyder-ide/spyder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spyder-ide/spyder/merges","archive_url":"https://api.github.com/repos/spyder-ide/spyder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spyder-ide/spyder/downloads","issues_url":"https://api.github.com/repos/spyder-ide/spyder/issues{/number}","pulls_url":"https://api.github.com/repos/spyder-ide/spyder/pulls{/number}","milestones_url":"https://api.github.com/repos/spyder-ide/spyder/milestones{/number}","notifications_url":"https://api.github.com/repos/spyder-ide/spyder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spyder-ide/spyder/labels{/name}","releases_url":"https://api.github.com/repos/spyder-ide/spyder/releases{/id}","deployments_url":"https://api.github.com/repos/spyder-ide/spyder/deployments","created_at":"2015-02-16T22:49:48Z","updated_at":"2018-07-30T14:41:59Z","pushed_at":"2018-07-30T07:37:32Z","git_url":"git://github.com/spyder-ide/spyder.git","ssh_url":"git@github.com:spyder-ide/spyder.git","clone_url":"https://github.com/spyder-ide/spyder.git","svn_url":"https://github.com/spyder-ide/spyder","homepage":"https://www.spyder-ide.org/","size":43565,"stargazers_count":3336,"watchers_count":3336,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":708,"mirror_url":null,"archived":false,"open_issues_count":689,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":708,"open_issues":689,"watchers":3336,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spyder-ide/spyder/pulls/7566"},"html":{"href":"https://github.com/spyder-ide/spyder/pull/7566"},"issue":{"href":"https://api.github.com/repos/spyder-ide/spyder/issues/7566"},"comments":{"href":"https://api.github.com/repos/spyder-ide/spyder/issues/7566/comments"},"review_comments":{"href":"https://api.github.com/repos/spyder-ide/spyder/pulls/7566/comments"},"review_comment":{"href":"https://api.github.com/repos/spyder-ide/spyder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spyder-ide/spyder/pulls/7566/commits"},"statuses":{"href":"https://api.github.com/repos/spyder-ide/spyder/statuses/211e641117cb1a5a1436a273e40c33fa38d8cf17"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ccordoba12"}}