{"action":"created","comment":{"url":"https://api.github.com/repos/S2E/libs2eplugins/pulls/comments/194586628","pull_request_review_id":127787042,"id":194586628,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDU4NjYyOA==","diff_hunk":"@@ -21,23 +22,148 @@ namespace s2e {\n namespace plugins {\n namespace testcases {\n \n+///\n+/// \\brief Stores information about file chunks encoded in symbolic variable names\n+///\n struct TestCaseFile {\n-    /* Maps a chunk id to the size */\n+    // Maps a chunk id to the size\n     std::map<unsigned, unsigned> chunks;\n-    /* Maps a chunk id to the data */\n+\n+    // Maps a chunk id to the data\n     std::map<unsigned, const uint8_t *> chunksData;\n+\n     unsigned totalParts;\n };\n \n-typedef std::map<std::string, TestCaseFile> TestCaseFiles;\n+///\n+/// \\brief Maps a test case file name to a test case file descriptor\n+///\n+typedef std::unordered_map<std::string, TestCaseFile> TestCaseFiles;\n \n+///\n+/// \\brief Represents any byte-sized data\n+///\n typedef std::vector<uint8_t> Data;\n+\n+///\n+/// \\brief Maps a test case file name to its concrete data\n+///\n typedef std::unordered_map<std::string, Data> TestCaseData;\n \n-enum TestCaseType : unsigned { TC_NONE = 0, TC_LOG = 1, TC_TRACE = 2, TC_FILE = 4 };\n+///\n+/// \\brief Specifies the type of the test case to generate\n+///\n+enum TestCaseType : unsigned {\n+    TC_NONE = 0,\n \n-/** Handler required for KLEE interpreter */\n-class TestCaseGenerator : public Plugin {\n+    // The test case will be written to the S2E's debug log\n+    TC_LOG = 1,\n+\n+    // The test case is to be written to the execution trace file\n+    TC_TRACE = 2,\n+\n+    // The test case is a concrete file written to to the output\n+    // folder on the host. Symbolic variable names must have a proper\n+    // encoding for such test cases to be generated.\n+    TC_FILE = 4\n+};\n+\n+///\n+/// \\brief Maps a sanitized file name to concrete data.\n+///\n+/// This map will be stored in each execution state and copied\n+/// on state fork, because each state may have different sets\n+/// of concrete input files.\n+///\n+/// We use an immutable map in order to avoid needless duplication,\n+/// as in general every state will have the exact same copy of the\n+/// concrete data.\n+///\n+typedef klee::ImmutableMap<std::string, Data> ConcreteFileTemplates;","path":"src/s2e/Plugins/ExecutionTracers/TestCaseGenerator.h","position":83,"original_position":83,"commit_id":"9d340eb7c384ad4884ec61a1046e40c9faba57b7","original_commit_id":"9d340eb7c384ad4884ec61a1046e40c9faba57b7","user":{"login":"adrianherrera","id":8626578,"node_id":"MDQ6VXNlcjg2MjY1Nzg=","avatar_url":"https://avatars2.githubusercontent.com/u/8626578?v=4","gravatar_id":"","url":"https://api.github.com/users/adrianherrera","html_url":"https://github.com/adrianherrera","followers_url":"https://api.github.com/users/adrianherrera/followers","following_url":"https://api.github.com/users/adrianherrera/following{/other_user}","gists_url":"https://api.github.com/users/adrianherrera/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianherrera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianherrera/subscriptions","organizations_url":"https://api.github.com/users/adrianherrera/orgs","repos_url":"https://api.github.com/users/adrianherrera/repos","events_url":"https://api.github.com/users/adrianherrera/events{/privacy}","received_events_url":"https://api.github.com/users/adrianherrera/received_events","type":"User","site_admin":false},"body":"Ah wait, I guess it still successfully compiles because you include the Klee header before this one. Let’s change it anyway :)","created_at":"2018-06-12T00:34:28Z","updated_at":"2018-06-12T00:34:28Z","html_url":"https://github.com/S2E/libs2eplugins/pull/38#discussion_r194586628","pull_request_url":"https://api.github.com/repos/S2E/libs2eplugins/pulls/38","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/S2E/libs2eplugins/pulls/comments/194586628"},"html":{"href":"https://github.com/S2E/libs2eplugins/pull/38#discussion_r194586628"},"pull_request":{"href":"https://api.github.com/repos/S2E/libs2eplugins/pulls/38"}},"in_reply_to_id":194585806},"pull_request":{"url":"https://api.github.com/repos/S2E/libs2eplugins/pulls/38","id":193824909,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzODI0OTA5","html_url":"https://github.com/S2E/libs2eplugins/pull/38","diff_url":"https://github.com/S2E/libs2eplugins/pull/38.diff","patch_url":"https://github.com/S2E/libs2eplugins/pull/38.patch","issue_url":"https://api.github.com/repos/S2E/libs2eplugins/issues/38","number":38,"state":"open","locked":false,"title":"TestCaseGenerator: support marking part of files symbolic","user":{"login":"vitalych","id":2332715,"node_id":"MDQ6VXNlcjIzMzI3MTU=","avatar_url":"https://avatars2.githubusercontent.com/u/2332715?v=4","gravatar_id":"","url":"https://api.github.com/users/vitalych","html_url":"https://github.com/vitalych","followers_url":"https://api.github.com/users/vitalych/followers","following_url":"https://api.github.com/users/vitalych/following{/other_user}","gists_url":"https://api.github.com/users/vitalych/gists{/gist_id}","starred_url":"https://api.github.com/users/vitalych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitalych/subscriptions","organizations_url":"https://api.github.com/users/vitalych/orgs","repos_url":"https://api.github.com/users/vitalych/repos","events_url":"https://api.github.com/users/vitalych/events{/privacy}","received_events_url":"https://api.github.com/users/vitalych/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Vitaly Chipounov <vitaly@cyberhaven.io>","created_at":"2018-06-10T12:56:37Z","updated_at":"2018-06-12T00:34:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15373006b02c37f820a18e0ba98f8f94a2833540","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/S2E/libs2eplugins/pulls/38/commits","review_comments_url":"https://api.github.com/repos/S2E/libs2eplugins/pulls/38/comments","review_comment_url":"https://api.github.com/repos/S2E/libs2eplugins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/S2E/libs2eplugins/issues/38/comments","statuses_url":"https://api.github.com/repos/S2E/libs2eplugins/statuses/9d340eb7c384ad4884ec61a1046e40c9faba57b7","head":{"label":"S2E:issue/129-selsymb","ref":"issue/129-selsymb","sha":"9d340eb7c384ad4884ec61a1046e40c9faba57b7","user":{"login":"S2E","id":7384376,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczODQzNzY=","avatar_url":"https://avatars0.githubusercontent.com/u/7384376?v=4","gravatar_id":"","url":"https://api.github.com/users/S2E","html_url":"https://github.com/S2E","followers_url":"https://api.github.com/users/S2E/followers","following_url":"https://api.github.com/users/S2E/following{/other_user}","gists_url":"https://api.github.com/users/S2E/gists{/gist_id}","starred_url":"https://api.github.com/users/S2E/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/S2E/subscriptions","organizations_url":"https://api.github.com/users/S2E/orgs","repos_url":"https://api.github.com/users/S2E/repos","events_url":"https://api.github.com/users/S2E/events{/privacy}","received_events_url":"https://api.github.com/users/S2E/received_events","type":"Organization","site_admin":false},"repo":{"id":87454183,"node_id":"MDEwOlJlcG9zaXRvcnk4NzQ1NDE4Mw==","name":"libs2eplugins","full_name":"S2E/libs2eplugins","owner":{"login":"S2E","id":7384376,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczODQzNzY=","avatar_url":"https://avatars0.githubusercontent.com/u/7384376?v=4","gravatar_id":"","url":"https://api.github.com/users/S2E","html_url":"https://github.com/S2E","followers_url":"https://api.github.com/users/S2E/followers","following_url":"https://api.github.com/users/S2E/following{/other_user}","gists_url":"https://api.github.com/users/S2E/gists{/gist_id}","starred_url":"https://api.github.com/users/S2E/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/S2E/subscriptions","organizations_url":"https://api.github.com/users/S2E/orgs","repos_url":"https://api.github.com/users/S2E/repos","events_url":"https://api.github.com/users/S2E/events{/privacy}","received_events_url":"https://api.github.com/users/S2E/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/S2E/libs2eplugins","description":"S2E plugins library","fork":false,"url":"https://api.github.com/repos/S2E/libs2eplugins","forks_url":"https://api.github.com/repos/S2E/libs2eplugins/forks","keys_url":"https://api.github.com/repos/S2E/libs2eplugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/S2E/libs2eplugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/S2E/libs2eplugins/teams","hooks_url":"https://api.github.com/repos/S2E/libs2eplugins/hooks","issue_events_url":"https://api.github.com/repos/S2E/libs2eplugins/issues/events{/number}","events_url":"https://api.github.com/repos/S2E/libs2eplugins/events","assignees_url":"https://api.github.com/repos/S2E/libs2eplugins/assignees{/user}","branches_url":"https://api.github.com/repos/S2E/libs2eplugins/branches{/branch}","tags_url":"https://api.github.com/repos/S2E/libs2eplugins/tags","blobs_url":"https://api.github.com/repos/S2E/libs2eplugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/S2E/libs2eplugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/S2E/libs2eplugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/S2E/libs2eplugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/S2E/libs2eplugins/statuses/{sha}","languages_url":"https://api.github.com/repos/S2E/libs2eplugins/languages","stargazers_url":"https://api.github.com/repos/S2E/libs2eplugins/stargazers","contributors_url":"https://api.github.com/repos/S2E/libs2eplugins/contributors","subscribers_url":"https://api.github.com/repos/S2E/libs2eplugins/subscribers","subscription_url":"https://api.github.com/repos/S2E/libs2eplugins/subscription","commits_url":"https://api.github.com/repos/S2E/libs2eplugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/S2E/libs2eplugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/S2E/libs2eplugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/S2E/libs2eplugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/S2E/libs2eplugins/contents/{+path}","compare_url":"https://api.github.com/repos/S2E/libs2eplugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/S2E/libs2eplugins/merges","archive_url":"https://api.github.com/repos/S2E/libs2eplugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/S2E/libs2eplugins/downloads","issues_url":"https://api.github.com/repos/S2E/libs2eplugins/issues{/number}","pulls_url":"https://api.github.com/repos/S2E/libs2eplugins/pulls{/number}","milestones_url":"https://api.github.com/repos/S2E/libs2eplugins/milestones{/number}","notifications_url":"https://api.github.com/repos/S2E/libs2eplugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/S2E/libs2eplugins/labels{/name}","releases_url":"https://api.github.com/repos/S2E/libs2eplugins/releases{/id}","deployments_url":"https://api.github.com/repos/S2E/libs2eplugins/deployments","created_at":"2017-04-06T17:00:57Z","updated_at":"2018-05-31T20:33:30Z","pushed_at":"2018-06-10T12:56:38Z","git_url":"git://github.com/S2E/libs2eplugins.git","ssh_url":"git@github.com:S2E/libs2eplugins.git","clone_url":"https://github.com/S2E/libs2eplugins.git","svn_url":"https://github.com/S2E/libs2eplugins","homepage":null,"size":576,"stargazers_count":12,"watchers_count":12,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":2,"watchers":12,"default_branch":"master"}},"base":{"label":"S2E:master","ref":"master","sha":"c72d54d39f9515f4f933a67f764f723f08b82bc5","user":{"login":"S2E","id":7384376,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczODQzNzY=","avatar_url":"https://avatars0.githubusercontent.com/u/7384376?v=4","gravatar_id":"","url":"https://api.github.com/users/S2E","html_url":"https://github.com/S2E","followers_url":"https://api.github.com/users/S2E/followers","following_url":"https://api.github.com/users/S2E/following{/other_user}","gists_url":"https://api.github.com/users/S2E/gists{/gist_id}","starred_url":"https://api.github.com/users/S2E/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/S2E/subscriptions","organizations_url":"https://api.github.com/users/S2E/orgs","repos_url":"https://api.github.com/users/S2E/repos","events_url":"https://api.github.com/users/S2E/events{/privacy}","received_events_url":"https://api.github.com/users/S2E/received_events","type":"Organization","site_admin":false},"repo":{"id":87454183,"node_id":"MDEwOlJlcG9zaXRvcnk4NzQ1NDE4Mw==","name":"libs2eplugins","full_name":"S2E/libs2eplugins","owner":{"login":"S2E","id":7384376,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczODQzNzY=","avatar_url":"https://avatars0.githubusercontent.com/u/7384376?v=4","gravatar_id":"","url":"https://api.github.com/users/S2E","html_url":"https://github.com/S2E","followers_url":"https://api.github.com/users/S2E/followers","following_url":"https://api.github.com/users/S2E/following{/other_user}","gists_url":"https://api.github.com/users/S2E/gists{/gist_id}","starred_url":"https://api.github.com/users/S2E/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/S2E/subscriptions","organizations_url":"https://api.github.com/users/S2E/orgs","repos_url":"https://api.github.com/users/S2E/repos","events_url":"https://api.github.com/users/S2E/events{/privacy}","received_events_url":"https://api.github.com/users/S2E/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/S2E/libs2eplugins","description":"S2E plugins library","fork":false,"url":"https://api.github.com/repos/S2E/libs2eplugins","forks_url":"https://api.github.com/repos/S2E/libs2eplugins/forks","keys_url":"https://api.github.com/repos/S2E/libs2eplugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/S2E/libs2eplugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/S2E/libs2eplugins/teams","hooks_url":"https://api.github.com/repos/S2E/libs2eplugins/hooks","issue_events_url":"https://api.github.com/repos/S2E/libs2eplugins/issues/events{/number}","events_url":"https://api.github.com/repos/S2E/libs2eplugins/events","assignees_url":"https://api.github.com/repos/S2E/libs2eplugins/assignees{/user}","branches_url":"https://api.github.com/repos/S2E/libs2eplugins/branches{/branch}","tags_url":"https://api.github.com/repos/S2E/libs2eplugins/tags","blobs_url":"https://api.github.com/repos/S2E/libs2eplugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/S2E/libs2eplugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/S2E/libs2eplugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/S2E/libs2eplugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/S2E/libs2eplugins/statuses/{sha}","languages_url":"https://api.github.com/repos/S2E/libs2eplugins/languages","stargazers_url":"https://api.github.com/repos/S2E/libs2eplugins/stargazers","contributors_url":"https://api.github.com/repos/S2E/libs2eplugins/contributors","subscribers_url":"https://api.github.com/repos/S2E/libs2eplugins/subscribers","subscription_url":"https://api.github.com/repos/S2E/libs2eplugins/subscription","commits_url":"https://api.github.com/repos/S2E/libs2eplugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/S2E/libs2eplugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/S2E/libs2eplugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/S2E/libs2eplugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/S2E/libs2eplugins/contents/{+path}","compare_url":"https://api.github.com/repos/S2E/libs2eplugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/S2E/libs2eplugins/merges","archive_url":"https://api.github.com/repos/S2E/libs2eplugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/S2E/libs2eplugins/downloads","issues_url":"https://api.github.com/repos/S2E/libs2eplugins/issues{/number}","pulls_url":"https://api.github.com/repos/S2E/libs2eplugins/pulls{/number}","milestones_url":"https://api.github.com/repos/S2E/libs2eplugins/milestones{/number}","notifications_url":"https://api.github.com/repos/S2E/libs2eplugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/S2E/libs2eplugins/labels{/name}","releases_url":"https://api.github.com/repos/S2E/libs2eplugins/releases{/id}","deployments_url":"https://api.github.com/repos/S2E/libs2eplugins/deployments","created_at":"2017-04-06T17:00:57Z","updated_at":"2018-05-31T20:33:30Z","pushed_at":"2018-06-10T12:56:38Z","git_url":"git://github.com/S2E/libs2eplugins.git","ssh_url":"git@github.com:S2E/libs2eplugins.git","clone_url":"https://github.com/S2E/libs2eplugins.git","svn_url":"https://github.com/S2E/libs2eplugins","homepage":null,"size":576,"stargazers_count":12,"watchers_count":12,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":2,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/S2E/libs2eplugins/pulls/38"},"html":{"href":"https://github.com/S2E/libs2eplugins/pull/38"},"issue":{"href":"https://api.github.com/repos/S2E/libs2eplugins/issues/38"},"comments":{"href":"https://api.github.com/repos/S2E/libs2eplugins/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/S2E/libs2eplugins/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/S2E/libs2eplugins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/S2E/libs2eplugins/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/S2E/libs2eplugins/statuses/9d340eb7c384ad4884ec61a1046e40c9faba57b7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"adrianherrera"}}