{"action":"created","comment":{"url":"https://api.github.com/repos/artsy/exchange/pulls/comments/202187135","pull_request_review_id":136838944,"id":202187135,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjE4NzEzNQ==","diff_hunk":"@@ -1,11 +1,11 @@\n class AddShippingAddressToOrders < ActiveRecord::Migration[5.2]\n   def change\n     change_table :orders, bulk: true do |t|\n-      t.column :shipping_address, :string\n+      t.column :shipping_street, :string","path":"db/migrate/20180709195222_add_shipping_address_to_orders.rb","position":null,"original_position":5,"commit_id":"9100ff5e46f2f17d0b9738d79a703c83360b1755","original_commit_id":"9100ff5e46f2f17d0b9738d79a703c83360b1755","user":{"login":"williardx","id":4432348,"node_id":"MDQ6VXNlcjQ0MzIzNDg=","avatar_url":"https://avatars1.githubusercontent.com/u/4432348?v=4","gravatar_id":"","url":"https://api.github.com/users/williardx","html_url":"https://github.com/williardx","followers_url":"https://api.github.com/users/williardx/followers","following_url":"https://api.github.com/users/williardx/following{/other_user}","gists_url":"https://api.github.com/users/williardx/gists{/gist_id}","starred_url":"https://api.github.com/users/williardx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williardx/subscriptions","organizations_url":"https://api.github.com/users/williardx/orgs","repos_url":"https://api.github.com/users/williardx/repos","events_url":"https://api.github.com/users/williardx/events{/privacy}","received_events_url":"https://api.github.com/users/williardx/received_events","type":"User","site_admin":false},"body":"What is `shipping_street` exactly? Is that the address number + street? What if someone needs two lines for their street address?","created_at":"2018-07-12T21:36:54Z","updated_at":"2018-07-12T21:36:55Z","html_url":"https://github.com/artsy/exchange/pull/58#discussion_r202187135","pull_request_url":"https://api.github.com/repos/artsy/exchange/pulls/58","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/artsy/exchange/pulls/comments/202187135"},"html":{"href":"https://github.com/artsy/exchange/pull/58#discussion_r202187135"},"pull_request":{"href":"https://api.github.com/repos/artsy/exchange/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/artsy/exchange/pulls/58","id":200814832,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwODE0ODMy","html_url":"https://github.com/artsy/exchange/pull/58","diff_url":"https://github.com/artsy/exchange/pull/58.diff","patch_url":"https://github.com/artsy/exchange/pull/58.patch","issue_url":"https://api.github.com/repos/artsy/exchange/issues/58","number":58,"state":"open","locked":false,"title":"Shipping & Payment Mutations","user":{"login":"ashkan18","id":1230819,"node_id":"MDQ6VXNlcjEyMzA4MTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1230819?v=4","gravatar_id":"","url":"https://api.github.com/users/ashkan18","html_url":"https://github.com/ashkan18","followers_url":"https://api.github.com/users/ashkan18/followers","following_url":"https://api.github.com/users/ashkan18/following{/other_user}","gists_url":"https://api.github.com/users/ashkan18/gists{/gist_id}","starred_url":"https://api.github.com/users/ashkan18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashkan18/subscriptions","organizations_url":"https://api.github.com/users/ashkan18/orgs","repos_url":"https://api.github.com/users/ashkan18/repos","events_url":"https://api.github.com/users/ashkan18/events{/privacy}","received_events_url":"https://api.github.com/users/ashkan18/received_events","type":"User","site_admin":false},"body":"# Changes\r\nWe have had [some discussions](https://github.com/artsy/exchange/issues/54) about having separate mutations for setting shipping and payment info. Here we do the following:\r\n- Added new `setShipping` mutation that gets newly added shipping related fields:\r\n  - Added `ship_type` to `Order` which currently can be `SHIP` or `PICKUP`.\r\n- Added new `setPayment` mutation.\r\n- Renamed `credit_card_id` to `payment_source`. This way Exchange can create charges for both stored credit card ids or with tokenized credit card. \r\n- Updated `submitOrder` to only get order `id` and check if order is setup for submission (has shipping and payment info)\r\n","created_at":"2018-07-11T20:20:33Z","updated_at":"2018-07-12T21:36:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4d42a9c22f06efdb04b7238bc21bc34c1dcc8f4","assignee":{"login":"joeyAghion","id":28120,"node_id":"MDQ6VXNlcjI4MTIw","avatar_url":"https://avatars2.githubusercontent.com/u/28120?v=4","gravatar_id":"","url":"https://api.github.com/users/joeyAghion","html_url":"https://github.com/joeyAghion","followers_url":"https://api.github.com/users/joeyAghion/followers","following_url":"https://api.github.com/users/joeyAghion/following{/other_user}","gists_url":"https://api.github.com/users/joeyAghion/gists{/gist_id}","starred_url":"https://api.github.com/users/joeyAghion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeyAghion/subscriptions","organizations_url":"https://api.github.com/users/joeyAghion/orgs","repos_url":"https://api.github.com/users/joeyAghion/repos","events_url":"https://api.github.com/users/joeyAghion/events{/privacy}","received_events_url":"https://api.github.com/users/joeyAghion/received_events","type":"User","site_admin":false},"assignees":[{"login":"joeyAghion","id":28120,"node_id":"MDQ6VXNlcjI4MTIw","avatar_url":"https://avatars2.githubusercontent.com/u/28120?v=4","gravatar_id":"","url":"https://api.github.com/users/joeyAghion","html_url":"https://github.com/joeyAghion","followers_url":"https://api.github.com/users/joeyAghion/followers","following_url":"https://api.github.com/users/joeyAghion/following{/other_user}","gists_url":"https://api.github.com/users/joeyAghion/gists{/gist_id}","starred_url":"https://api.github.com/users/joeyAghion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeyAghion/subscriptions","organizations_url":"https://api.github.com/users/joeyAghion/orgs","repos_url":"https://api.github.com/users/joeyAghion/repos","events_url":"https://api.github.com/users/joeyAghion/events{/privacy}","received_events_url":"https://api.github.com/users/joeyAghion/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"sweir27","id":2081340,"node_id":"MDQ6VXNlcjIwODEzNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/2081340?v=4","gravatar_id":"","url":"https://api.github.com/users/sweir27","html_url":"https://github.com/sweir27","followers_url":"https://api.github.com/users/sweir27/followers","following_url":"https://api.github.com/users/sweir27/following{/other_user}","gists_url":"https://api.github.com/users/sweir27/gists{/gist_id}","starred_url":"https://api.github.com/users/sweir27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sweir27/subscriptions","organizations_url":"https://api.github.com/users/sweir27/orgs","repos_url":"https://api.github.com/users/sweir27/repos","events_url":"https://api.github.com/users/sweir27/events{/privacy}","received_events_url":"https://api.github.com/users/sweir27/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/artsy/exchange/pulls/58/commits","review_comments_url":"https://api.github.com/repos/artsy/exchange/pulls/58/comments","review_comment_url":"https://api.github.com/repos/artsy/exchange/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artsy/exchange/issues/58/comments","statuses_url":"https://api.github.com/repos/artsy/exchange/statuses/9100ff5e46f2f17d0b9738d79a703c83360b1755","head":{"label":"ashkan18:shipping-payment-mutations","ref":"shipping-payment-mutations","sha":"9100ff5e46f2f17d0b9738d79a703c83360b1755","user":{"login":"ashkan18","id":1230819,"node_id":"MDQ6VXNlcjEyMzA4MTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1230819?v=4","gravatar_id":"","url":"https://api.github.com/users/ashkan18","html_url":"https://github.com/ashkan18","followers_url":"https://api.github.com/users/ashkan18/followers","following_url":"https://api.github.com/users/ashkan18/following{/other_user}","gists_url":"https://api.github.com/users/ashkan18/gists{/gist_id}","starred_url":"https://api.github.com/users/ashkan18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashkan18/subscriptions","organizations_url":"https://api.github.com/users/ashkan18/orgs","repos_url":"https://api.github.com/users/ashkan18/repos","events_url":"https://api.github.com/users/ashkan18/events{/privacy}","received_events_url":"https://api.github.com/users/ashkan18/received_events","type":"User","site_admin":false},"repo":{"id":138088009,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgwODgwMDk=","name":"exchange","full_name":"ashkan18/exchange","owner":{"login":"ashkan18","id":1230819,"node_id":"MDQ6VXNlcjEyMzA4MTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1230819?v=4","gravatar_id":"","url":"https://api.github.com/users/ashkan18","html_url":"https://github.com/ashkan18","followers_url":"https://api.github.com/users/ashkan18/followers","following_url":"https://api.github.com/users/ashkan18/following{/other_user}","gists_url":"https://api.github.com/users/ashkan18/gists{/gist_id}","starred_url":"https://api.github.com/users/ashkan18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashkan18/subscriptions","organizations_url":"https://api.github.com/users/ashkan18/orgs","repos_url":"https://api.github.com/users/ashkan18/repos","events_url":"https://api.github.com/users/ashkan18/events{/privacy}","received_events_url":"https://api.github.com/users/ashkan18/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ashkan18/exchange","description":"Artsy Order Management","fork":true,"url":"https://api.github.com/repos/ashkan18/exchange","forks_url":"https://api.github.com/repos/ashkan18/exchange/forks","keys_url":"https://api.github.com/repos/ashkan18/exchange/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashkan18/exchange/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashkan18/exchange/teams","hooks_url":"https://api.github.com/repos/ashkan18/exchange/hooks","issue_events_url":"https://api.github.com/repos/ashkan18/exchange/issues/events{/number}","events_url":"https://api.github.com/repos/ashkan18/exchange/events","assignees_url":"https://api.github.com/repos/ashkan18/exchange/assignees{/user}","branches_url":"https://api.github.com/repos/ashkan18/exchange/branches{/branch}","tags_url":"https://api.github.com/repos/ashkan18/exchange/tags","blobs_url":"https://api.github.com/repos/ashkan18/exchange/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashkan18/exchange/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashkan18/exchange/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashkan18/exchange/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashkan18/exchange/statuses/{sha}","languages_url":"https://api.github.com/repos/ashkan18/exchange/languages","stargazers_url":"https://api.github.com/repos/ashkan18/exchange/stargazers","contributors_url":"https://api.github.com/repos/ashkan18/exchange/contributors","subscribers_url":"https://api.github.com/repos/ashkan18/exchange/subscribers","subscription_url":"https://api.github.com/repos/ashkan18/exchange/subscription","commits_url":"https://api.github.com/repos/ashkan18/exchange/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashkan18/exchange/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashkan18/exchange/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashkan18/exchange/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashkan18/exchange/contents/{+path}","compare_url":"https://api.github.com/repos/ashkan18/exchange/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashkan18/exchange/merges","archive_url":"https://api.github.com/repos/ashkan18/exchange/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashkan18/exchange/downloads","issues_url":"https://api.github.com/repos/ashkan18/exchange/issues{/number}","pulls_url":"https://api.github.com/repos/ashkan18/exchange/pulls{/number}","milestones_url":"https://api.github.com/repos/ashkan18/exchange/milestones{/number}","notifications_url":"https://api.github.com/repos/ashkan18/exchange/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashkan18/exchange/labels{/name}","releases_url":"https://api.github.com/repos/ashkan18/exchange/releases{/id}","deployments_url":"https://api.github.com/repos/ashkan18/exchange/deployments","created_at":"2018-06-20T21:32:30Z","updated_at":"2018-06-20T21:32:32Z","pushed_at":"2018-07-12T20:44:20Z","git_url":"git://github.com/ashkan18/exchange.git","ssh_url":"git@github.com:ashkan18/exchange.git","clone_url":"https://github.com/ashkan18/exchange.git","svn_url":"https://github.com/ashkan18/exchange","homepage":"","size":180,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"artsy:master","ref":"master","sha":"5b895bab33e074a4404d0058a37d2be14a5ed8b9","user":{"login":"artsy","id":546231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NjIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":136387707,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYzODc3MDc=","name":"exchange","full_name":"artsy/exchange","owner":{"login":"artsy","id":546231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NjIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/exchange","description":"Artsy Order Management","fork":false,"url":"https://api.github.com/repos/artsy/exchange","forks_url":"https://api.github.com/repos/artsy/exchange/forks","keys_url":"https://api.github.com/repos/artsy/exchange/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/exchange/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/exchange/teams","hooks_url":"https://api.github.com/repos/artsy/exchange/hooks","issue_events_url":"https://api.github.com/repos/artsy/exchange/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/exchange/events","assignees_url":"https://api.github.com/repos/artsy/exchange/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/exchange/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/exchange/tags","blobs_url":"https://api.github.com/repos/artsy/exchange/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/exchange/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/exchange/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/exchange/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/exchange/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/exchange/languages","stargazers_url":"https://api.github.com/repos/artsy/exchange/stargazers","contributors_url":"https://api.github.com/repos/artsy/exchange/contributors","subscribers_url":"https://api.github.com/repos/artsy/exchange/subscribers","subscription_url":"https://api.github.com/repos/artsy/exchange/subscription","commits_url":"https://api.github.com/repos/artsy/exchange/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/exchange/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/exchange/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/exchange/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/exchange/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/exchange/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/exchange/merges","archive_url":"https://api.github.com/repos/artsy/exchange/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/exchange/downloads","issues_url":"https://api.github.com/repos/artsy/exchange/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/exchange/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/exchange/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/exchange/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/exchange/labels{/name}","releases_url":"https://api.github.com/repos/artsy/exchange/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/exchange/deployments","created_at":"2018-06-06T21:24:37Z","updated_at":"2018-07-11T14:54:54Z","pushed_at":"2018-07-12T21:14:10Z","git_url":"git://github.com/artsy/exchange.git","ssh_url":"git@github.com:artsy/exchange.git","clone_url":"https://github.com/artsy/exchange.git","svn_url":"https://github.com/artsy/exchange","homepage":"","size":177,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":10,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artsy/exchange/pulls/58"},"html":{"href":"https://github.com/artsy/exchange/pull/58"},"issue":{"href":"https://api.github.com/repos/artsy/exchange/issues/58"},"comments":{"href":"https://api.github.com/repos/artsy/exchange/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/artsy/exchange/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/artsy/exchange/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artsy/exchange/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/artsy/exchange/statuses/9100ff5e46f2f17d0b9738d79a703c83360b1755"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"williardx"}}