{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/7758","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/7758/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/7758/comments","events_url":"https://api.github.com/repos/istio/istio/issues/7758/events","html_url":"https://github.com/istio/istio/pull/7758","id":348931089,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MTY3OTU4","number":7758,"title":"Render the sidecar injector configmap always","user":{"login":"mt-inside","id":1371795,"node_id":"MDQ6VXNlcjEzNzE3OTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1371795?v=4","gravatar_id":"","url":"https://api.github.com/users/mt-inside","html_url":"https://github.com/mt-inside","followers_url":"https://api.github.com/users/mt-inside/followers","following_url":"https://api.github.com/users/mt-inside/following{/other_user}","gists_url":"https://api.github.com/users/mt-inside/gists{/gist_id}","starred_url":"https://api.github.com/users/mt-inside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mt-inside/subscriptions","organizations_url":"https://api.github.com/users/mt-inside/orgs","repos_url":"https://api.github.com/users/mt-inside/repos","events_url":"https://api.github.com/users/mt-inside/events{/privacy}","received_events_url":"https://api.github.com/users/mt-inside/received_events","type":"User","site_admin":false},"labels":[{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-08-08T23:50:57Z","updated_at":"2018-08-09T00:44:58Z","closed_at":"2018-08-09T00:44:58Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/7758","html_url":"https://github.com/istio/istio/pull/7758","diff_url":"https://github.com/istio/istio/pull/7758.diff","patch_url":"https://github.com/istio/istio/pull/7758.patch"},"body":"Commit eeb9d77ff8 changed a bunch of stuff, and doesn't mention this change in the commit message, so it may even have been accidental?\r\n\r\nEither way, with the sidecar injector webhook turned off, manual injection using `istioctl kube-inject` still needs this configmap, and it isn't present any more. This PR re-enables it.\r\nEven when the sidecar injector is disabled, as `istioctl kube-inject`\r\nneeds it.\r\n\r\nI checked the istio-remote chart but this change wasn't made to it."},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/411600494","html_url":"https://github.com/istio/istio/pull/7758#issuecomment-411600494","issue_url":"https://api.github.com/repos/istio/istio/issues/7758","id":411600494,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTYwMDQ5NA==","user":{"login":"ayj","id":116378,"node_id":"MDQ6VXNlcjExNjM3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/116378?v=4","gravatar_id":"","url":"https://api.github.com/users/ayj","html_url":"https://github.com/ayj","followers_url":"https://api.github.com/users/ayj/followers","following_url":"https://api.github.com/users/ayj/following{/other_user}","gists_url":"https://api.github.com/users/ayj/gists{/gist_id}","starred_url":"https://api.github.com/users/ayj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayj/subscriptions","organizations_url":"https://api.github.com/users/ayj/orgs","repos_url":"https://api.github.com/users/ayj/repos","events_url":"https://api.github.com/users/ayj/events{/privacy}","received_events_url":"https://api.github.com/users/ayj/received_events","type":"User","site_admin":false},"created_at":"2018-08-09T00:44:58Z","updated_at":"2018-08-09T00:44:58Z","author_association":"CONTRIBUTOR","body":"sort-of-dup of https://github.com/istio/istio/pull/7565. We also need to handle the case where helm generates a standalone gateway configuration in a user namespace (i.e. not istio-system). Removing the added conditional as done in this PR will result in the injector configmap also being created in the user namespace."}}
{"actor":{"display_login":"ayj"}}