{"action":"created","comment":{"url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/pulls/comments/199957909","pull_request_review_id":134178728,"id":199957909,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTk1NzkwOQ==","diff_hunk":"@@ -79,6 +79,11 @@ public sealed class ContentManager : DisposableBase\n \n             IniDataContext.LoadIniFiles(@\"Data\\INI\\Default\\Object.ini\");\n             IniDataContext.LoadIniFiles(@\"Data\\INI\\Object\");\n+            IniDataContext.LoadIniFiles(@\"Data\\INI\\multiplayer.ini\");\n+\n+            //german2 has an Maps folder - english has an maps folder\n+            //so we need to deal with different spells in different versions\n+            IniDataContext.LoadIniFile(@\"Maps\\MapCache.ini\", @\"maps\\MapCache.ini\");","path":"src/OpenSage.Game/Content/ContentManager.cs","position":8,"original_position":8,"commit_id":"68c6c07c66bc8e2cfc5f5aa365d1ceaabe888818","original_commit_id":"68c6c07c66bc8e2cfc5f5aa365d1ceaabe888818","user":{"login":"feliwir","id":2104576,"node_id":"MDQ6VXNlcjIxMDQ1NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/2104576?v=4","gravatar_id":"","url":"https://api.github.com/users/feliwir","html_url":"https://github.com/feliwir","followers_url":"https://api.github.com/users/feliwir/followers","following_url":"https://api.github.com/users/feliwir/following{/other_user}","gists_url":"https://api.github.com/users/feliwir/gists{/gist_id}","starred_url":"https://api.github.com/users/feliwir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feliwir/subscriptions","organizations_url":"https://api.github.com/users/feliwir/orgs","repos_url":"https://api.github.com/users/feliwir/repos","events_url":"https://api.github.com/users/feliwir/events{/privacy}","received_events_url":"https://api.github.com/users/feliwir/received_events","type":"User","site_admin":false},"body":"I don't think is the right approach here. The entire filesystem should probably be case insensitive, because windows doesn't care about that anyways. So maybe the GetFile method in FileSystem.cs should take care of that. Need opinions of @tgjones and @paavohuhtala here.","created_at":"2018-07-03T21:39:40Z","updated_at":"2018-07-03T21:39:41Z","html_url":"https://github.com/OpenSAGE/OpenSAGE/pull/131#discussion_r199957909","pull_request_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/pulls/131","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/OpenSAGE/OpenSAGE/pulls/comments/199957909"},"html":{"href":"https://github.com/OpenSAGE/OpenSAGE/pull/131#discussion_r199957909"},"pull_request":{"href":"https://api.github.com/repos/OpenSAGE/OpenSAGE/pulls/131"}}},"pull_request":{"url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/pulls/131","id":199063367,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MDYzMzY3","html_url":"https://github.com/OpenSAGE/OpenSAGE/pull/131","diff_url":"https://github.com/OpenSAGE/OpenSAGE/pull/131.diff","patch_url":"https://github.com/OpenSAGE/OpenSAGE/pull/131.patch","issue_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/issues/131","number":131,"state":"open","locked":false,"title":"Update SkirmishGameOptionsMenu","user":{"login":"MarkusHiller","id":12080228,"node_id":"MDQ6VXNlcjEyMDgwMjI4","avatar_url":"https://avatars1.githubusercontent.com/u/12080228?v=4","gravatar_id":"","url":"https://api.github.com/users/MarkusHiller","html_url":"https://github.com/MarkusHiller","followers_url":"https://api.github.com/users/MarkusHiller/followers","following_url":"https://api.github.com/users/MarkusHiller/following{/other_user}","gists_url":"https://api.github.com/users/MarkusHiller/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkusHiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkusHiller/subscriptions","organizations_url":"https://api.github.com/users/MarkusHiller/orgs","repos_url":"https://api.github.com/users/MarkusHiller/repos","events_url":"https://api.github.com/users/MarkusHiller/events{/privacy}","received_events_url":"https://api.github.com/users/MarkusHiller/received_events","type":"User","site_admin":false},"body":"*fill SkirmishGameOptionsMenu with data\r\n*update ComboBox handling","created_at":"2018-07-03T19:33:54Z","updated_at":"2018-07-03T21:39:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b64a12f533c5886714e120321ebea18a1a3e0410","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/pulls/131/commits","review_comments_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/pulls/131/comments","review_comment_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/issues/131/comments","statuses_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/statuses/68c6c07c66bc8e2cfc5f5aa365d1ceaabe888818","head":{"label":"MarkusHiller:feature/SkirimishGameOptions","ref":"feature/SkirimishGameOptions","sha":"68c6c07c66bc8e2cfc5f5aa365d1ceaabe888818","user":{"login":"MarkusHiller","id":12080228,"node_id":"MDQ6VXNlcjEyMDgwMjI4","avatar_url":"https://avatars1.githubusercontent.com/u/12080228?v=4","gravatar_id":"","url":"https://api.github.com/users/MarkusHiller","html_url":"https://github.com/MarkusHiller","followers_url":"https://api.github.com/users/MarkusHiller/followers","following_url":"https://api.github.com/users/MarkusHiller/following{/other_user}","gists_url":"https://api.github.com/users/MarkusHiller/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkusHiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkusHiller/subscriptions","organizations_url":"https://api.github.com/users/MarkusHiller/orgs","repos_url":"https://api.github.com/users/MarkusHiller/repos","events_url":"https://api.github.com/users/MarkusHiller/events{/privacy}","received_events_url":"https://api.github.com/users/MarkusHiller/received_events","type":"User","site_admin":false},"repo":{"id":138781043,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg3ODEwNDM=","name":"OpenSAGE","full_name":"MarkusHiller/OpenSAGE","owner":{"login":"MarkusHiller","id":12080228,"node_id":"MDQ6VXNlcjEyMDgwMjI4","avatar_url":"https://avatars1.githubusercontent.com/u/12080228?v=4","gravatar_id":"","url":"https://api.github.com/users/MarkusHiller","html_url":"https://github.com/MarkusHiller","followers_url":"https://api.github.com/users/MarkusHiller/followers","following_url":"https://api.github.com/users/MarkusHiller/following{/other_user}","gists_url":"https://api.github.com/users/MarkusHiller/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkusHiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkusHiller/subscriptions","organizations_url":"https://api.github.com/users/MarkusHiller/orgs","repos_url":"https://api.github.com/users/MarkusHiller/repos","events_url":"https://api.github.com/users/MarkusHiller/events{/privacy}","received_events_url":"https://api.github.com/users/MarkusHiller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MarkusHiller/OpenSAGE","description":"OpenSAGE is a free, open source re-implementation of SAGE, the 3D real time strategy (RTS) engine used in Command & Conquer: Generals and other RTS titles from EA Pacific. Written in C#. Not affiliated with EA.","fork":true,"url":"https://api.github.com/repos/MarkusHiller/OpenSAGE","forks_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/forks","keys_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/teams","hooks_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/hooks","issue_events_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/issues/events{/number}","events_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/events","assignees_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/assignees{/user}","branches_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/branches{/branch}","tags_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/tags","blobs_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/statuses/{sha}","languages_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/languages","stargazers_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/stargazers","contributors_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/contributors","subscribers_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/subscribers","subscription_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/subscription","commits_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/contents/{+path}","compare_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/merges","archive_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/downloads","issues_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/issues{/number}","pulls_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/pulls{/number}","milestones_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/milestones{/number}","notifications_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/labels{/name}","releases_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/releases{/id}","deployments_url":"https://api.github.com/repos/MarkusHiller/OpenSAGE/deployments","created_at":"2018-06-26T19:02:01Z","updated_at":"2018-06-30T20:12:25Z","pushed_at":"2018-07-03T19:34:47Z","git_url":"git://github.com/MarkusHiller/OpenSAGE.git","ssh_url":"git@github.com:MarkusHiller/OpenSAGE.git","clone_url":"https://github.com/MarkusHiller/OpenSAGE.git","svn_url":"https://github.com/MarkusHiller/OpenSAGE","homepage":"http://timjones.io/blog/tags/opensage/","size":18532,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenSAGE:master","ref":"master","sha":"c4a09265bbe2b998bddd0eea9a7de1f332e5fcf3","user":{"login":"OpenSAGE","id":10568284,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTY4Mjg0","avatar_url":"https://avatars0.githubusercontent.com/u/10568284?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenSAGE","html_url":"https://github.com/OpenSAGE","followers_url":"https://api.github.com/users/OpenSAGE/followers","following_url":"https://api.github.com/users/OpenSAGE/following{/other_user}","gists_url":"https://api.github.com/users/OpenSAGE/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSAGE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSAGE/subscriptions","organizations_url":"https://api.github.com/users/OpenSAGE/orgs","repos_url":"https://api.github.com/users/OpenSAGE/repos","events_url":"https://api.github.com/users/OpenSAGE/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSAGE/received_events","type":"Organization","site_admin":false},"repo":{"id":94316145,"node_id":"MDEwOlJlcG9zaXRvcnk5NDMxNjE0NQ==","name":"OpenSAGE","full_name":"OpenSAGE/OpenSAGE","owner":{"login":"OpenSAGE","id":10568284,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTY4Mjg0","avatar_url":"https://avatars0.githubusercontent.com/u/10568284?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenSAGE","html_url":"https://github.com/OpenSAGE","followers_url":"https://api.github.com/users/OpenSAGE/followers","following_url":"https://api.github.com/users/OpenSAGE/following{/other_user}","gists_url":"https://api.github.com/users/OpenSAGE/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSAGE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSAGE/subscriptions","organizations_url":"https://api.github.com/users/OpenSAGE/orgs","repos_url":"https://api.github.com/users/OpenSAGE/repos","events_url":"https://api.github.com/users/OpenSAGE/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSAGE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenSAGE/OpenSAGE","description":"OpenSAGE is a free, open source re-implementation of SAGE, the 3D real time strategy (RTS) engine used in Command & Conquer: Generals and other RTS titles from EA Pacific. Written in C#. Not affiliated with EA.","fork":false,"url":"https://api.github.com/repos/OpenSAGE/OpenSAGE","forks_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/forks","keys_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/teams","hooks_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/hooks","issue_events_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/issues/events{/number}","events_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/events","assignees_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/assignees{/user}","branches_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/branches{/branch}","tags_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/tags","blobs_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/languages","stargazers_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/stargazers","contributors_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/contributors","subscribers_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/subscribers","subscription_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/subscription","commits_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/contents/{+path}","compare_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/merges","archive_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/downloads","issues_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/issues{/number}","pulls_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/labels{/name}","releases_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/releases{/id}","deployments_url":"https://api.github.com/repos/OpenSAGE/OpenSAGE/deployments","created_at":"2017-06-14T09:53:41Z","updated_at":"2018-07-03T02:30:40Z","pushed_at":"2018-07-03T19:33:54Z","git_url":"git://github.com/OpenSAGE/OpenSAGE.git","ssh_url":"git@github.com:OpenSAGE/OpenSAGE.git","clone_url":"https://github.com/OpenSAGE/OpenSAGE.git","svn_url":"https://github.com/OpenSAGE/OpenSAGE","homepage":"http://timjones.io/blog/tags/opensage/","size":18509,"stargazers_count":161,"watchers_count":161,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":18,"open_issues":20,"watchers":161,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenSAGE/OpenSAGE/pulls/131"},"html":{"href":"https://github.com/OpenSAGE/OpenSAGE/pull/131"},"issue":{"href":"https://api.github.com/repos/OpenSAGE/OpenSAGE/issues/131"},"comments":{"href":"https://api.github.com/repos/OpenSAGE/OpenSAGE/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenSAGE/OpenSAGE/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenSAGE/OpenSAGE/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenSAGE/OpenSAGE/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/OpenSAGE/OpenSAGE/statuses/68c6c07c66bc8e2cfc5f5aa365d1ceaabe888818"}},"author_association":"NONE"}}
{"actor":{"display_login":"feliwir"}}