{"action":"created","comment":{"url":"https://api.github.com/repos/way-cooler/way-cooler/pulls/comments/191624039","pull_request_review_id":124226831,"id":191624039,"diff_hunk":"@@ -26,6 +29,49 @@ impl Seat {\n                meta: false,\n                ..Seat::default() }\n     }\n+\n+    pub fn clear_focus(&mut self) {\n+        if let Some(focused_view) = self.focused.take() {\n+            focused_view.activate(false);\n+        }\n+        with_handles!([(seat: {&mut self.seat})] => {\n+            seat.keyboard_clear_focus();\n+        }).unwrap();\n+    }\n+\n+    pub fn focus_view(&mut self, view: Rc<View>, views: &mut Vec<Rc<View>>) {\n+        if let Some(ref focused) = self.focused {\n+            if focused == &view {","path":"src/compositor/seat.rs","position":33,"original_position":33,"commit_id":"da439944e87c12299e72d6b8e4d3f6df8e3ccd09","original_commit_id":"da439944e87c12299e72d6b8e4d3f6df8e3ccd09","user":{"login":"Timidger","id":3515754,"avatar_url":"https://avatars0.githubusercontent.com/u/3515754?v=4","gravatar_id":"","url":"https://api.github.com/users/Timidger","html_url":"https://github.com/Timidger","followers_url":"https://api.github.com/users/Timidger/followers","following_url":"https://api.github.com/users/Timidger/following{/other_user}","gists_url":"https://api.github.com/users/Timidger/gists{/gist_id}","starred_url":"https://api.github.com/users/Timidger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Timidger/subscriptions","organizations_url":"https://api.github.com/users/Timidger/orgs","repos_url":"https://api.github.com/users/Timidger/repos","events_url":"https://api.github.com/users/Timidger/events{/privacy}","received_events_url":"https://api.github.com/users/Timidger/received_events","type":"User","site_admin":false},"body":"(I don't believe this will trigger a move. If it does then don't do this).\r\n\r\n`*focused == view` would be clearer","created_at":"2018-05-30T02:01:14Z","updated_at":"2018-05-30T02:09:43Z","html_url":"https://github.com/way-cooler/way-cooler/pull/546#discussion_r191624039","pull_request_url":"https://api.github.com/repos/way-cooler/way-cooler/pulls/546","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/way-cooler/way-cooler/pulls/comments/191624039"},"html":{"href":"https://github.com/way-cooler/way-cooler/pull/546#discussion_r191624039"},"pull_request":{"href":"https://api.github.com/repos/way-cooler/way-cooler/pulls/546"}}},"pull_request":{"url":"https://api.github.com/repos/way-cooler/way-cooler/pulls/546","id":190801572,"html_url":"https://github.com/way-cooler/way-cooler/pull/546","diff_url":"https://github.com/way-cooler/way-cooler/pull/546.diff","patch_url":"https://github.com/way-cooler/way-cooler/pull/546.patch","issue_url":"https://api.github.com/repos/way-cooler/way-cooler/issues/546","number":546,"state":"open","locked":false,"title":"render and input fixes","user":{"login":"acrisci","id":3258764,"avatar_url":"https://avatars2.githubusercontent.com/u/3258764?v=4","gravatar_id":"","url":"https://api.github.com/users/acrisci","html_url":"https://github.com/acrisci","followers_url":"https://api.github.com/users/acrisci/followers","following_url":"https://api.github.com/users/acrisci/following{/other_user}","gists_url":"https://api.github.com/users/acrisci/gists{/gist_id}","starred_url":"https://api.github.com/users/acrisci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acrisci/subscriptions","organizations_url":"https://api.github.com/users/acrisci/orgs","repos_url":"https://api.github.com/users/acrisci/repos","events_url":"https://api.github.com/users/acrisci/events{/privacy}","received_events_url":"https://api.github.com/users/acrisci/received_events","type":"User","site_admin":false},"body":"Trying to get mostly usable shell surfaces.\r\n\r\n* [x] Render focused view on top of the other views\r\n* [x] Revert the focus to the next one in the list when a focused shell surface closes\r\n* [x] Set the focus to a newly created shell surface\r\n* [x] General keyboard fixes\r\n* [x] Add view on map, not create\r\n* [x] reference count the views\r\n* [x] make nicer view abstractions\r\n* [ ] Update to latest wlroots-rs","created_at":"2018-05-27T18:50:39Z","updated_at":"2018-05-30T02:09:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee566a3c795428a2df18be74e5e63945f4c68dae","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/way-cooler/way-cooler/pulls/546/commits","review_comments_url":"https://api.github.com/repos/way-cooler/way-cooler/pulls/546/comments","review_comment_url":"https://api.github.com/repos/way-cooler/way-cooler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/way-cooler/way-cooler/issues/546/comments","statuses_url":"https://api.github.com/repos/way-cooler/way-cooler/statuses/da439944e87c12299e72d6b8e4d3f6df8e3ccd09","head":{"label":"acrisci:render-input-fixes","ref":"render-input-fixes","sha":"da439944e87c12299e72d6b8e4d3f6df8e3ccd09","user":{"login":"acrisci","id":3258764,"avatar_url":"https://avatars2.githubusercontent.com/u/3258764?v=4","gravatar_id":"","url":"https://api.github.com/users/acrisci","html_url":"https://github.com/acrisci","followers_url":"https://api.github.com/users/acrisci/followers","following_url":"https://api.github.com/users/acrisci/following{/other_user}","gists_url":"https://api.github.com/users/acrisci/gists{/gist_id}","starred_url":"https://api.github.com/users/acrisci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acrisci/subscriptions","organizations_url":"https://api.github.com/users/acrisci/orgs","repos_url":"https://api.github.com/users/acrisci/repos","events_url":"https://api.github.com/users/acrisci/events{/privacy}","received_events_url":"https://api.github.com/users/acrisci/received_events","type":"User","site_admin":false},"repo":{"id":133191830,"name":"way-cooler","full_name":"acrisci/way-cooler","owner":{"login":"acrisci","id":3258764,"avatar_url":"https://avatars2.githubusercontent.com/u/3258764?v=4","gravatar_id":"","url":"https://api.github.com/users/acrisci","html_url":"https://github.com/acrisci","followers_url":"https://api.github.com/users/acrisci/followers","following_url":"https://api.github.com/users/acrisci/following{/other_user}","gists_url":"https://api.github.com/users/acrisci/gists{/gist_id}","starred_url":"https://api.github.com/users/acrisci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acrisci/subscriptions","organizations_url":"https://api.github.com/users/acrisci/orgs","repos_url":"https://api.github.com/users/acrisci/repos","events_url":"https://api.github.com/users/acrisci/events{/privacy}","received_events_url":"https://api.github.com/users/acrisci/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/acrisci/way-cooler","description":"Customizable Wayland compositor (window manager)","fork":true,"url":"https://api.github.com/repos/acrisci/way-cooler","forks_url":"https://api.github.com/repos/acrisci/way-cooler/forks","keys_url":"https://api.github.com/repos/acrisci/way-cooler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acrisci/way-cooler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acrisci/way-cooler/teams","hooks_url":"https://api.github.com/repos/acrisci/way-cooler/hooks","issue_events_url":"https://api.github.com/repos/acrisci/way-cooler/issues/events{/number}","events_url":"https://api.github.com/repos/acrisci/way-cooler/events","assignees_url":"https://api.github.com/repos/acrisci/way-cooler/assignees{/user}","branches_url":"https://api.github.com/repos/acrisci/way-cooler/branches{/branch}","tags_url":"https://api.github.com/repos/acrisci/way-cooler/tags","blobs_url":"https://api.github.com/repos/acrisci/way-cooler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acrisci/way-cooler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acrisci/way-cooler/git/refs{/sha}","trees_url":"https://api.github.com/repos/acrisci/way-cooler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acrisci/way-cooler/statuses/{sha}","languages_url":"https://api.github.com/repos/acrisci/way-cooler/languages","stargazers_url":"https://api.github.com/repos/acrisci/way-cooler/stargazers","contributors_url":"https://api.github.com/repos/acrisci/way-cooler/contributors","subscribers_url":"https://api.github.com/repos/acrisci/way-cooler/subscribers","subscription_url":"https://api.github.com/repos/acrisci/way-cooler/subscription","commits_url":"https://api.github.com/repos/acrisci/way-cooler/commits{/sha}","git_commits_url":"https://api.github.com/repos/acrisci/way-cooler/git/commits{/sha}","comments_url":"https://api.github.com/repos/acrisci/way-cooler/comments{/number}","issue_comment_url":"https://api.github.com/repos/acrisci/way-cooler/issues/comments{/number}","contents_url":"https://api.github.com/repos/acrisci/way-cooler/contents/{+path}","compare_url":"https://api.github.com/repos/acrisci/way-cooler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acrisci/way-cooler/merges","archive_url":"https://api.github.com/repos/acrisci/way-cooler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acrisci/way-cooler/downloads","issues_url":"https://api.github.com/repos/acrisci/way-cooler/issues{/number}","pulls_url":"https://api.github.com/repos/acrisci/way-cooler/pulls{/number}","milestones_url":"https://api.github.com/repos/acrisci/way-cooler/milestones{/number}","notifications_url":"https://api.github.com/repos/acrisci/way-cooler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acrisci/way-cooler/labels{/name}","releases_url":"https://api.github.com/repos/acrisci/way-cooler/releases{/id}","deployments_url":"https://api.github.com/repos/acrisci/way-cooler/deployments","created_at":"2018-05-12T23:53:16Z","updated_at":"2018-05-12T23:53:18Z","pushed_at":"2018-05-29T23:11:44Z","git_url":"git://github.com/acrisci/way-cooler.git","ssh_url":"git@github.com:acrisci/way-cooler.git","clone_url":"https://github.com/acrisci/way-cooler.git","svn_url":"https://github.com/acrisci/way-cooler","homepage":"http://way-cooler.org","size":2872,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"way-cooler:master","ref":"master","sha":"ccf86d7d59c577950dcb049768dded610128db08","user":{"login":"way-cooler","id":10932466,"avatar_url":"https://avatars3.githubusercontent.com/u/10932466?v=4","gravatar_id":"","url":"https://api.github.com/users/way-cooler","html_url":"https://github.com/way-cooler","followers_url":"https://api.github.com/users/way-cooler/followers","following_url":"https://api.github.com/users/way-cooler/following{/other_user}","gists_url":"https://api.github.com/users/way-cooler/gists{/gist_id}","starred_url":"https://api.github.com/users/way-cooler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/way-cooler/subscriptions","organizations_url":"https://api.github.com/users/way-cooler/orgs","repos_url":"https://api.github.com/users/way-cooler/repos","events_url":"https://api.github.com/users/way-cooler/events{/privacy}","received_events_url":"https://api.github.com/users/way-cooler/received_events","type":"Organization","site_admin":false},"repo":{"id":49312071,"name":"way-cooler","full_name":"way-cooler/way-cooler","owner":{"login":"way-cooler","id":10932466,"avatar_url":"https://avatars3.githubusercontent.com/u/10932466?v=4","gravatar_id":"","url":"https://api.github.com/users/way-cooler","html_url":"https://github.com/way-cooler","followers_url":"https://api.github.com/users/way-cooler/followers","following_url":"https://api.github.com/users/way-cooler/following{/other_user}","gists_url":"https://api.github.com/users/way-cooler/gists{/gist_id}","starred_url":"https://api.github.com/users/way-cooler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/way-cooler/subscriptions","organizations_url":"https://api.github.com/users/way-cooler/orgs","repos_url":"https://api.github.com/users/way-cooler/repos","events_url":"https://api.github.com/users/way-cooler/events{/privacy}","received_events_url":"https://api.github.com/users/way-cooler/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/way-cooler/way-cooler","description":"Customizable Wayland compositor (window manager)","fork":false,"url":"https://api.github.com/repos/way-cooler/way-cooler","forks_url":"https://api.github.com/repos/way-cooler/way-cooler/forks","keys_url":"https://api.github.com/repos/way-cooler/way-cooler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/way-cooler/way-cooler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/way-cooler/way-cooler/teams","hooks_url":"https://api.github.com/repos/way-cooler/way-cooler/hooks","issue_events_url":"https://api.github.com/repos/way-cooler/way-cooler/issues/events{/number}","events_url":"https://api.github.com/repos/way-cooler/way-cooler/events","assignees_url":"https://api.github.com/repos/way-cooler/way-cooler/assignees{/user}","branches_url":"https://api.github.com/repos/way-cooler/way-cooler/branches{/branch}","tags_url":"https://api.github.com/repos/way-cooler/way-cooler/tags","blobs_url":"https://api.github.com/repos/way-cooler/way-cooler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/way-cooler/way-cooler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/way-cooler/way-cooler/git/refs{/sha}","trees_url":"https://api.github.com/repos/way-cooler/way-cooler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/way-cooler/way-cooler/statuses/{sha}","languages_url":"https://api.github.com/repos/way-cooler/way-cooler/languages","stargazers_url":"https://api.github.com/repos/way-cooler/way-cooler/stargazers","contributors_url":"https://api.github.com/repos/way-cooler/way-cooler/contributors","subscribers_url":"https://api.github.com/repos/way-cooler/way-cooler/subscribers","subscription_url":"https://api.github.com/repos/way-cooler/way-cooler/subscription","commits_url":"https://api.github.com/repos/way-cooler/way-cooler/commits{/sha}","git_commits_url":"https://api.github.com/repos/way-cooler/way-cooler/git/commits{/sha}","comments_url":"https://api.github.com/repos/way-cooler/way-cooler/comments{/number}","issue_comment_url":"https://api.github.com/repos/way-cooler/way-cooler/issues/comments{/number}","contents_url":"https://api.github.com/repos/way-cooler/way-cooler/contents/{+path}","compare_url":"https://api.github.com/repos/way-cooler/way-cooler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/way-cooler/way-cooler/merges","archive_url":"https://api.github.com/repos/way-cooler/way-cooler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/way-cooler/way-cooler/downloads","issues_url":"https://api.github.com/repos/way-cooler/way-cooler/issues{/number}","pulls_url":"https://api.github.com/repos/way-cooler/way-cooler/pulls{/number}","milestones_url":"https://api.github.com/repos/way-cooler/way-cooler/milestones{/number}","notifications_url":"https://api.github.com/repos/way-cooler/way-cooler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/way-cooler/way-cooler/labels{/name}","releases_url":"https://api.github.com/repos/way-cooler/way-cooler/releases{/id}","deployments_url":"https://api.github.com/repos/way-cooler/way-cooler/deployments","created_at":"2016-01-09T05:24:44Z","updated_at":"2018-05-30T01:42:23Z","pushed_at":"2018-05-30T01:42:22Z","git_url":"git://github.com/way-cooler/way-cooler.git","ssh_url":"git@github.com:way-cooler/way-cooler.git","clone_url":"https://github.com/way-cooler/way-cooler.git","svn_url":"https://github.com/way-cooler/way-cooler","homepage":"http://way-cooler.org","size":2807,"stargazers_count":1579,"watchers_count":1579,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":62,"open_issues":26,"watchers":1579,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/way-cooler/way-cooler/pulls/546"},"html":{"href":"https://github.com/way-cooler/way-cooler/pull/546"},"issue":{"href":"https://api.github.com/repos/way-cooler/way-cooler/issues/546"},"comments":{"href":"https://api.github.com/repos/way-cooler/way-cooler/issues/546/comments"},"review_comments":{"href":"https://api.github.com/repos/way-cooler/way-cooler/pulls/546/comments"},"review_comment":{"href":"https://api.github.com/repos/way-cooler/way-cooler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/way-cooler/way-cooler/pulls/546/commits"},"statuses":{"href":"https://api.github.com/repos/way-cooler/way-cooler/statuses/da439944e87c12299e72d6b8e4d3f6df8e3ccd09"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Timidger"}}