{"action":"created","issue":{"url":"https://api.github.com/repos/google/closure-compiler/issues/3066","repository_url":"https://api.github.com/repos/google/closure-compiler","labels_url":"https://api.github.com/repos/google/closure-compiler/issues/3066/labels{/name}","comments_url":"https://api.github.com/repos/google/closure-compiler/issues/3066/comments","events_url":"https://api.github.com/repos/google/closure-compiler/issues/3066/events","html_url":"https://github.com/google/closure-compiler/pull/3066","id":356764872,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyOTQxMzc4","number":3066,"title":"Check iterator immediately before access.","user":{"login":"salsolatragus","id":154050,"node_id":"MDQ6VXNlcjE1NDA1MA==","avatar_url":"https://avatars3.githubusercontent.com/u/154050?v=4","gravatar_id":"","url":"https://api.github.com/users/salsolatragus","html_url":"https://github.com/salsolatragus","followers_url":"https://api.github.com/users/salsolatragus/followers","following_url":"https://api.github.com/users/salsolatragus/following{/other_user}","gists_url":"https://api.github.com/users/salsolatragus/gists{/gist_id}","starred_url":"https://api.github.com/users/salsolatragus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salsolatragus/subscriptions","organizations_url":"https://api.github.com/users/salsolatragus/orgs","repos_url":"https://api.github.com/users/salsolatragus/repos","events_url":"https://api.github.com/users/salsolatragus/events{/privacy}","received_events_url":"https://api.github.com/users/salsolatragus/received_events","type":"User","site_admin":false},"labels":[{"id":147878228,"node_id":"MDU6TGFiZWwxNDc4NzgyMjg=","url":"https://api.github.com/repos/google/closure-compiler/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-04T11:20:29Z","updated_at":"2018-09-18T07:12:07Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/google/closure-compiler/pulls/3066","html_url":"https://github.com/google/closure-compiler/pull/3066","diff_url":"https://github.com/google/closure-compiler/pull/3066.diff","patch_url":"https://github.com/google/closure-compiler/pull/3066.patch"},"body":"It is not immediately obvious that the Iterator queried in `constructAddOrStringNode()` always has a next element to fetch, since the `hasNext()` check occurs outside the querying method. The refactoring pulls this check closer to the query, in order to clarify that the access is always safe.\r\n\r\nThis problem was identified by our automated detector [MUDetect](https://github.com/stg-tud/MUDetect/). We would very much appreciate your feedback on our patch. Thank you very much!"},"comment":{"url":"https://api.github.com/repos/google/closure-compiler/issues/comments/422280845","html_url":"https://github.com/google/closure-compiler/pull/3066#issuecomment-422280845","issue_url":"https://api.github.com/repos/google/closure-compiler/issues/3066","id":422280845,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjI4MDg0NQ==","user":{"login":"salsolatragus","id":154050,"node_id":"MDQ6VXNlcjE1NDA1MA==","avatar_url":"https://avatars3.githubusercontent.com/u/154050?v=4","gravatar_id":"","url":"https://api.github.com/users/salsolatragus","html_url":"https://github.com/salsolatragus","followers_url":"https://api.github.com/users/salsolatragus/followers","following_url":"https://api.github.com/users/salsolatragus/following{/other_user}","gists_url":"https://api.github.com/users/salsolatragus/gists{/gist_id}","starred_url":"https://api.github.com/users/salsolatragus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salsolatragus/subscriptions","organizations_url":"https://api.github.com/users/salsolatragus/orgs","repos_url":"https://api.github.com/users/salsolatragus/repos","events_url":"https://api.github.com/users/salsolatragus/events{/privacy}","received_events_url":"https://api.github.com/users/salsolatragus/received_events","type":"User","site_admin":false},"created_at":"2018-09-18T07:12:07Z","updated_at":"2018-09-18T07:12:07Z","author_association":"CONTRIBUTOR","body":"> Can you squash your pull request into a single commit to make it easier for our import tools to merge? Thanks.\r\n\r\nSure! Done."}}
{"actor":{"display_login":"salsolatragus"}}