{"action":"created","issue":{"url":"https://api.github.com/repos/guardian/frontend/issues/20283","repository_url":"https://api.github.com/repos/guardian/frontend","labels_url":"https://api.github.com/repos/guardian/frontend/issues/20283/labels{/name}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/20283/comments","events_url":"https://api.github.com/repos/guardian/frontend/issues/20283/events","html_url":"https://github.com/guardian/frontend/pull/20283","id":357184529,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMjU5MDg4","number":20283,"title":"Empty fronts when ad-free is on","user":{"login":"lmath","id":3072877,"node_id":"MDQ6VXNlcjMwNzI4Nzc=","avatar_url":"https://avatars1.githubusercontent.com/u/3072877?v=4","gravatar_id":"","url":"https://api.github.com/users/lmath","html_url":"https://github.com/lmath","followers_url":"https://api.github.com/users/lmath/followers","following_url":"https://api.github.com/users/lmath/following{/other_user}","gists_url":"https://api.github.com/users/lmath/gists{/gist_id}","starred_url":"https://api.github.com/users/lmath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmath/subscriptions","organizations_url":"https://api.github.com/users/lmath/orgs","repos_url":"https://api.github.com/users/lmath/repos","events_url":"https://api.github.com/users/lmath/events{/privacy}","received_events_url":"https://api.github.com/users/lmath/received_events","type":"User","site_admin":false},"labels":[{"id":512259700,"node_id":"MDU6TGFiZWw1MTIyNTk3MDA=","url":"https://api.github.com/repos/guardian/frontend/labels/Seen-on-PROD","name":"Seen-on-PROD","color":"bfe5bf","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-05T11:26:08Z","updated_at":"2018-09-05T11:55:52Z","closed_at":"2018-09-05T11:37:02Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/20283","html_url":"https://github.com/guardian/frontend/pull/20283","diff_url":"https://github.com/guardian/frontend/pull/20283.diff","patch_url":"https://github.com/guardian/frontend/pull/20283.patch"},"body":"## What does this change?\r\nWe are developing an ad-free feature that will eventually be offered to digital pack subscribers. \r\n\r\nAt the moment, when ad-free mode is on, a front that contains only commercial content will show up empty. Though we will tend to avoid driving traffic to those pages (e.g. https://github.com/guardian/frontend/pull/20240), a user may land there by other means and they probably actually want to see the content. \r\n![image](https://user-images.githubusercontent.com/3072877/45088570-4b3a5d80-b101-11e8-8d2d-ce6934a4fd19.png)\r\n\r\nWe probably do not ever want to show an empty front, so if request an ad-free front that is empty, we will try getting the non-ad-free version and show that instead. \r\n\r\n## Screenshots\r\n\r\nOn a front with only commercial content, e.g. gu.com/discover-hong-kong-like-a-local\r\nCurrent state with ad-free on:\r\n![image](https://user-images.githubusercontent.com/3072877/45088712-c13ec480-b101-11e8-8701-94d44ce3c3da.png)\r\n\r\nThis change causes the page to look like this with ad-free on\r\n![image](https://user-images.githubusercontent.com/3072877/45088737-d3b8fe00-b101-11e8-867b-d59d1ecda5d3.png)\r\n\r\nPage with ad-free off:\r\n![image](https://user-images.githubusercontent.com/3072877/45088883-49bd6500-b102-11e8-8b7b-2477f61e10a2.png)\r\n\r\n## What is the value of this and can you measure success?\r\nEven if a user has ad-free on, it is a bad experience to show them an empty page when likely they ended up there to see that paid content \r\n\r\n## Checklist\r\n\r\n### Does this affect other platforms?\r\n\r\n- [ ] AMP <!-- AMP question? https://git.io/v9zIE -->\r\n- [ ] Apps\r\n- [ ] Other (please specify)\r\n- [x] No\r\n\r\n### Does this affect GLabs Paid Content Pages? Should it have support for Paid Content?\r\n\r\n<!-- if there are versions of this content with the paid styling (teal and grey) then they will need to be checked -->\r\n<!-- content can be found here: https://www.theguardian.com/tone/advertisement-features -->\r\n\r\n- [ ] No\r\n- [x] Yes (please give details)\r\n\r\nCurrently, paid content is filtered when ad-free mode is on, but we will show it when it is the only thing on a front. \r\n\r\n### Accessibility test checklist\r\n\r\n<!-- for changes that affect how a page appears in the browser -->\r\n\r\n- [ ] [Tested with screen reader](https://accessibility.gutools.co.uk/testing/web/screen-readers/)\r\n- [ ] [Navigable with keyboard](https://accessibility.gutools.co.uk/testing/web/keyboard-navigation/)\r\n- [ ] [Colour contrast passed](https://accessibility.gutools.co.uk/testing/web/colour-contrast/)\r\nThe code just determines if containers with paid content appear at all.\r\n\r\n### Tested\r\n\r\n- [x] Locally\r\n- [ ] On CODE (optional) \r\n\r\n<!-- AB test? https://git.io/v1V0x -->\r\n<!-- Does this PR meet the contributing guidelines? https://git.io/v1VEJ -->\r\n\r\ncc @JustinPinner @guardian/commercial-dev "},"comment":{"url":"https://api.github.com/repos/guardian/frontend/issues/comments/418703610","html_url":"https://github.com/guardian/frontend/pull/20283#issuecomment-418703610","issue_url":"https://api.github.com/repos/guardian/frontend/issues/20283","id":418703610,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODcwMzYxMA==","user":{"login":"prout-bot","id":8896019,"node_id":"MDQ6VXNlcjg4OTYwMTk=","avatar_url":"https://avatars2.githubusercontent.com/u/8896019?v=4","gravatar_id":"","url":"https://api.github.com/users/prout-bot","html_url":"https://github.com/prout-bot","followers_url":"https://api.github.com/users/prout-bot/followers","following_url":"https://api.github.com/users/prout-bot/following{/other_user}","gists_url":"https://api.github.com/users/prout-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/prout-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prout-bot/subscriptions","organizations_url":"https://api.github.com/users/prout-bot/orgs","repos_url":"https://api.github.com/users/prout-bot/repos","events_url":"https://api.github.com/users/prout-bot/events{/privacy}","received_events_url":"https://api.github.com/users/prout-bot/received_events","type":"User","site_admin":false},"created_at":"2018-09-05T11:55:52Z","updated_at":"2018-09-05T11:55:52Z","author_association":"COLLABORATOR","body":"Seen on [PROD](https://frontend.gutools.co.uk/deploys?stage=PROD&pageSize=50) (merged by @lmath 18 minutes and 50 seconds ago) \n- Check your changes on [www.theguardian.com](https://www.theguardian.com) ✔️\n- Keep an eye on the [deploy dashboard](https://logs.gutools.co.uk/app/kibana#/dashboard/8730df10-49fd-11e7-b778-ebbe55169b8f?_g=(refreshInterval:(display:Off,pause:!f,value:0),time:(from:now-15m,mode:quick,to:now))&_a=(description:'',filters:!(),fullScreenMode:!f,options:(darkTheme:!f,useMargins:!f),panels:!((gridData:(h:4,i:'4',w:6,x:6,y:0),id:'735f9ce0-4a04-11e7-9f15-395e2d1c9b1f',panelIndex:'4',type:visualization,version:'6.2.4'),(gridData:(h:4,i:'5',w:6,x:0,y:0),id:b9249830-4a03-11e7-91e8-2fbfd59c38bb,panelIndex:'5',type:visualization,version:'6.2.4'),(gridData:(h:4,i:'7',w:6,x:0,y:4),id:ac507b90-4a0f-11e7-9f15-395e2d1c9b1f,panelIndex:'7',type:visualization,version:'6.2.4'),(gridData:(h:4,i:'9',w:6,x:6,y:4),id:a5f78860-4ad2-11e7-9930-73b4968e85d8,panelIndex:'9',type:visualization,version:'6.2.4')),query:(language:lucene,query:(query_string:(analyze_wildcard:!t,query:'stage:PROD%20NOT%20app:preview'))),timeRestore:!f,title:'Frontend%20PROD%20Deploy',viewMode:view)) 📉\n"}}
{"actor":{"display_login":"prout-bot"}}