{"action":"created","issue":{"url":"https://api.github.com/repos/ymcatwincities/openy/issues/1060","repository_url":"https://api.github.com/repos/ymcatwincities/openy","labels_url":"https://api.github.com/repos/ymcatwincities/openy/issues/1060/labels{/name}","comments_url":"https://api.github.com/repos/ymcatwincities/openy/issues/1060/comments","events_url":"https://api.github.com/repos/ymcatwincities/openy/issues/1060/events","html_url":"https://github.com/ymcatwincities/openy/pull/1060","id":326102469,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwMjc0NjIz","number":1060,"title":"[OPENY-30] Basic block - component decoupling","user":{"login":"AndreyMaximov","id":5453109,"node_id":"MDQ6VXNlcjU0NTMxMDk=","avatar_url":"https://avatars2.githubusercontent.com/u/5453109?v=4","gravatar_id":"","url":"https://api.github.com/users/AndreyMaximov","html_url":"https://github.com/AndreyMaximov","followers_url":"https://api.github.com/users/AndreyMaximov/followers","following_url":"https://api.github.com/users/AndreyMaximov/following{/other_user}","gists_url":"https://api.github.com/users/AndreyMaximov/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreyMaximov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreyMaximov/subscriptions","organizations_url":"https://api.github.com/users/AndreyMaximov/orgs","repos_url":"https://api.github.com/users/AndreyMaximov/repos","events_url":"https://api.github.com/users/AndreyMaximov/events{/privacy}","received_events_url":"https://api.github.com/users/AndreyMaximov/received_events","type":"User","site_admin":false},"labels":[{"id":516730856,"node_id":"MDU6TGFiZWw1MTY3MzA4NTY=","url":"https://api.github.com/repos/ymcatwincities/openy/labels/PR:%20DO%20NOT%20MERGE","name":"PR: DO NOT MERGE","color":"d93f0b","default":false},{"id":596919156,"node_id":"MDU6TGFiZWw1OTY5MTkxNTY=","url":"https://api.github.com/repos/ymcatwincities/openy/labels/PR:%20Needs%20Review","name":"PR: Needs Review","color":"583A7B","default":false},{"id":621420269,"node_id":"MDU6TGFiZWw2MjE0MjAyNjk=","url":"https://api.github.com/repos/ymcatwincities/openy/labels/PR:%20Needs%20testing","name":"PR: Needs testing","color":"006b75","default":false}],"state":"open","locked":false,"assignee":{"login":"AndreyMaximov","id":5453109,"node_id":"MDQ6VXNlcjU0NTMxMDk=","avatar_url":"https://avatars2.githubusercontent.com/u/5453109?v=4","gravatar_id":"","url":"https://api.github.com/users/AndreyMaximov","html_url":"https://github.com/AndreyMaximov","followers_url":"https://api.github.com/users/AndreyMaximov/followers","following_url":"https://api.github.com/users/AndreyMaximov/following{/other_user}","gists_url":"https://api.github.com/users/AndreyMaximov/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreyMaximov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreyMaximov/subscriptions","organizations_url":"https://api.github.com/users/AndreyMaximov/orgs","repos_url":"https://api.github.com/users/AndreyMaximov/repos","events_url":"https://api.github.com/users/AndreyMaximov/events{/privacy}","received_events_url":"https://api.github.com/users/AndreyMaximov/received_events","type":"User","site_admin":false},"assignees":[{"login":"AndreyMaximov","id":5453109,"node_id":"MDQ6VXNlcjU0NTMxMDk=","avatar_url":"https://avatars2.githubusercontent.com/u/5453109?v=4","gravatar_id":"","url":"https://api.github.com/users/AndreyMaximov","html_url":"https://github.com/AndreyMaximov","followers_url":"https://api.github.com/users/AndreyMaximov/followers","following_url":"https://api.github.com/users/AndreyMaximov/following{/other_user}","gists_url":"https://api.github.com/users/AndreyMaximov/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreyMaximov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreyMaximov/subscriptions","organizations_url":"https://api.github.com/users/AndreyMaximov/orgs","repos_url":"https://api.github.com/users/AndreyMaximov/repos","events_url":"https://api.github.com/users/AndreyMaximov/events{/privacy}","received_events_url":"https://api.github.com/users/AndreyMaximov/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ymcatwincities/openy/milestones/15","html_url":"https://github.com/ymcatwincities/openy/milestone/15","labels_url":"https://api.github.com/repos/ymcatwincities/openy/milestones/15/labels","id":3335694,"node_id":"MDk6TWlsZXN0b25lMzMzNTY5NA==","number":15,"title":"OpenY 2.0","description":null,"creator":{"login":"ddrozdik","id":6285570,"node_id":"MDQ6VXNlcjYyODU1NzA=","avatar_url":"https://avatars2.githubusercontent.com/u/6285570?v=4","gravatar_id":"","url":"https://api.github.com/users/ddrozdik","html_url":"https://github.com/ddrozdik","followers_url":"https://api.github.com/users/ddrozdik/followers","following_url":"https://api.github.com/users/ddrozdik/following{/other_user}","gists_url":"https://api.github.com/users/ddrozdik/gists{/gist_id}","starred_url":"https://api.github.com/users/ddrozdik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddrozdik/subscriptions","organizations_url":"https://api.github.com/users/ddrozdik/orgs","repos_url":"https://api.github.com/users/ddrozdik/repos","events_url":"https://api.github.com/users/ddrozdik/events{/privacy}","received_events_url":"https://api.github.com/users/ddrozdik/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":12,"state":"open","created_at":"2018-05-10T09:54:11Z","updated_at":"2018-05-30T10:54:02Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-05-24T12:38:30Z","updated_at":"2018-06-01T15:28:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ymcatwincities/openy/pulls/1060","html_url":"https://github.com/ymcatwincities/openy/pull/1060","diff_url":"https://github.com/ymcatwincities/openy/pull/1060.diff","patch_url":"https://github.com/ymcatwincities/openy/pull/1060.patch"},"body":"Make sure these boxes are checked before asking for review of your pull request - thank you!\r\n\r\n## General checks\r\n- [ ] All coding styles are fulfilled and there are no any issues reported by CodeSniffer CI. <br/><img src=\"https://raw.githubusercontent.com/ymcatwincities/openy/8.x-1.x/.github/assets/ci-errors.png\" width=\"200\" alt=\"CI code sniffer errors\">\r\n- [ ] All tests are running and there are no failed tests reported by CI. <br/><img src=\"https://raw.githubusercontent.com/ymcatwincities/openy/8.x-1.x/.github/assets/behat.png\" width=\"200\" alt=\"Behat test results\">\r\n- [ ] [Documentation](https://github.com/ymcatwincities/openy/tree/8.x-1.x/docs) has been updated according to PR changes.\r\n- [ ] [Steps for review](https://github.com/ymcatwincities/openy/pull/94#issue-204580200) have been provided according to PR changes. <br/><img src=\"https://raw.githubusercontent.com/ymcatwincities/openy/8.x-1.x/.github/assets/steps-for-review.png\" width=\"200\" alt=\"Steps for review\"/>\r\n- [ ] Make sure you've provided all necessary hook\\_update\\_N to [support upgrade path](https://github.com/ymcatwincities/openy/blob/8.x-1.x/docs/Development/Upgrade%20path.md).\r\n- [ ] Make sure your git email is associated with account on drupal.org, otherwise you won't get commits there. <br/><img src=\"https://raw.githubusercontent.com/ymcatwincities/openy/8.x-1.x/.github/assets/drupalorg-email.png\" width=\"200\" alt=\"drupal.org email\"/>\r\n- [ ] If you would like to get credits on drupal.org, [check documentation](https://github.com/ymcatwincities/openy/blob/8.x-1.x/docs/Development/Contributing.md#drupalorg-credits).\r\n\r\nThank you for your contribution!\r\n\r\n## Steps for review\r\n\r\n- [ ] login as admin\r\n- [ ] In order to verify decoupling uninstall demo modules, that depend on openy_block_basic:\r\n   - OpenY Demo Block Footer\r\n   - OpenY Demo Block Simple\r\n- [ ] verify OpenY Block Basic now can be uninstalled\r\n- [ ] go to any of the entity reference fields, that used to be dependent on the module:\r\n    - e.g, `/admin/structure/paragraphs_type/secondary_description_sidebar/fields/paragraph.secondary_description_sidebar.field_prgf_left_column_block` \r\n    - find 'Reference method' is changed to 'Default (OpenY)'\r\n    - find the list of bundles (checkboxes)\r\n    - verify the list is unchanged (basic, code, date, simple blocks are checked) \r\n- [ ] uninstall the module\r\n- [ ] go to any of the entity reference fields, that used to be dependent on the module:\r\n    - e.g, `/admin/structure/paragraphs_type/secondary_description_sidebar/fields/paragraph.secondary_description_sidebar.field_prgf_left_column_block`\r\n    - find the field still contains the bundle limitation, but 'Basic Block' is not listed there anymore\r\n- [ ] verify secondary description sidebar paragraph works on the pages\r\n- [ ] verify secondary description sidebar paragraph edit form contains proper list of referenceable bundles (without Basic Block since it's uninstalled)\r\n\r\n\r\nThis PR contains the same issue as the one explained in https://github.com/ymcatwincities/openy/pull/1040 (shared field storage problem), thus as soon as the solution is found, the latest commit of the PR must be rewritten accordingly to the solution. I'm marking it DO NOT MERGE"},"comment":{"url":"https://api.github.com/repos/ymcatwincities/openy/issues/comments/393916299","html_url":"https://github.com/ymcatwincities/openy/pull/1060#issuecomment-393916299","issue_url":"https://api.github.com/repos/ymcatwincities/openy/issues/1060","id":393916299,"node_id":"MDEyOklzc3VlQ29tbWVudDM5MzkxNjI5OQ==","user":{"login":"gundevel","id":8766638,"node_id":"MDQ6VXNlcjg3NjY2Mzg=","avatar_url":"https://avatars3.githubusercontent.com/u/8766638?v=4","gravatar_id":"","url":"https://api.github.com/users/gundevel","html_url":"https://github.com/gundevel","followers_url":"https://api.github.com/users/gundevel/followers","following_url":"https://api.github.com/users/gundevel/following{/other_user}","gists_url":"https://api.github.com/users/gundevel/gists{/gist_id}","starred_url":"https://api.github.com/users/gundevel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gundevel/subscriptions","organizations_url":"https://api.github.com/users/gundevel/orgs","repos_url":"https://api.github.com/users/gundevel/repos","events_url":"https://api.github.com/users/gundevel/events{/privacy}","received_events_url":"https://api.github.com/users/gundevel/received_events","type":"User","site_admin":false},"created_at":"2018-06-01T15:28:29Z","updated_at":"2018-06-01T15:28:29Z","author_association":"COLLABORATOR","body":"Build comment file: \n--------------\n\n \n| Environment | Link |\n| ------------- | ------------- |\n| Fresh OpenY installation - Rose theme | http://openy.cibox.tools/build449 |\n| Fresh OpenY installation - Lily theme | http://lily.openy.cibox.tools/build449 |\n| Upgraded(upgrade path) installation | http://upgrade.openy.cibox.tools/build449 |\n| Installation process | http://install.openy.cibox.tools/build449/install.php |\n\n--------------\nTest PASSed.\nRefer to this link for build results (access rights to CI server needed): \nhttp://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/449/"}}
{"actor":{"display_login":"gundevel"}}