{"action":"opened","issue":{"url":"https://api.github.com/repos/plotly/dash/issues/399","repository_url":"https://api.github.com/repos/plotly/dash","labels_url":"https://api.github.com/repos/plotly/dash/issues/399/labels{/name}","comments_url":"https://api.github.com/repos/plotly/dash/issues/399/comments","events_url":"https://api.github.com/repos/plotly/dash/issues/399/events","html_url":"https://github.com/plotly/dash/issues/399","id":362751931,"node_id":"MDU6SXNzdWUzNjI3NTE5MzE=","number":399,"title":"Changing the name parameter to required.","user":{"login":"T4rk1n","id":9417722,"node_id":"MDQ6VXNlcjk0MTc3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/9417722?v=4","gravatar_id":"","url":"https://api.github.com/users/T4rk1n","html_url":"https://github.com/T4rk1n","followers_url":"https://api.github.com/users/T4rk1n/followers","following_url":"https://api.github.com/users/T4rk1n/following{/other_user}","gists_url":"https://api.github.com/users/T4rk1n/gists{/gist_id}","starred_url":"https://api.github.com/users/T4rk1n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/T4rk1n/subscriptions","organizations_url":"https://api.github.com/users/T4rk1n/orgs","repos_url":"https://api.github.com/users/T4rk1n/repos","events_url":"https://api.github.com/users/T4rk1n/events{/privacy}","received_events_url":"https://api.github.com/users/T4rk1n/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-21T19:48:49Z","updated_at":"2018-09-21T19:48:49Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"@ned2 and I had a thread on the `assets_folder` parameter being absolute if you provide it. We thought it would be better if it would conform to how flask handles the static folder relative to the module.\r\n\r\nTurns out the blueprint static folder is activated by `__name__` but I put `assets` as the parameter so it cannot find the root folder unless a module is named assets then it will take that path. This make the assets folder be absolute instead of relative to the module directory.\r\n\r\nWhen I tested to make it relative, it broke if you didn't explicitly put the `__name__` in the dash constructor because of our default of `__main__`. If we replace the default by an empty string it works (it will fallback to os.cwd) but it might be too brittle and dependent on the os.\r\n\r\nI think requiring the import_name like flask does would solve that issue and we would always be sure to have the right folder relative to the running project.\r\n\r\nThis would be a breaking change and would go in Dash 2.0"}}
{"actor":{"display_login":"T4rk1n"}}